From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 00:22:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Mar 2023 22:22:44 +0000 Subject: [Koha-bugs] [Bug 33285] It should be possible to specify the separator used in runreport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 00:22:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Mar 2023 22:22:46 +0000 Subject: [Koha-bugs] [Bug 33285] It should be possible to specify the separator used in runreport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148775|0 |1 is obsolete| | --- Comment #8 from Fridolin Somers --- Created attachment 149058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149058&action=edit Bug 33285: Allow specifying the delimeter for runreport.pl To test: 1 - Write a report in koha 2 - perl misc/cronjobs/runreport.pl --format csv 1 (or correct report number) 3 - Note you get commas 4 - Apply patch 5 - Repeat #2 - no change 6 - perl misc/cronjobs/runreport.pl --format csv --separator "|" 1 7 - Now it is pipe delimited 8 - perl misc/cronjobs/runreport.pl --format tsv --separator "|" 1 9 - Error is reported, you cannot set separator unless csv 10 - Try other separators Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 00:22:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Mar 2023 22:22:49 +0000 Subject: [Koha-bugs] [Bug 33285] It should be possible to specify the separator used in runreport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285 --- Comment #9 from Fridolin Somers --- Created attachment 149059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149059&action=edit Bug 33285: (QA follow-up) add POD and fix some code style Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 00:24:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Mar 2023 22:24:37 +0000 Subject: [Koha-bugs] [Bug 33285] It should be possible to specify the separator used in runreport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin Somers --- Strange we can not use "\t" : perl misc/cronjobs/runreport.pl --format csv --separator "\t" 1 Generates with "\" as separator. We have format tsv for that so no issue. Great option ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 01:15:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 Mar 2023 23:15:20 +0000 Subject: [Koha-bugs] [Bug 23567] Printable QR links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23567 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Christopher Brannon --- Yes, I know. I was the one that suggested it. For some reason it was created via another ticket afterward instead of this one. I will close this ticket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 10:32:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 08:32:41 +0000 Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 10:46:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 08:46:21 +0000 Subject: [Koha-bugs] [Bug 33168] Timeline on "About Koha" is not working for package installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #44 from Mason James --- (In reply to David Nind from comment #43) > Note: I also noticed that for lines 43 and 44 that spaces are used after the > first tab - do these need to be fixed as well? hi David thanks for the sign-off lines 43 and 44 are OK :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 12:35:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 10:35:17 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 --- Comment #29 from Katrin Fischer --- Really happy to see this one fixed :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 12:47:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 10:47:57 +0000 Subject: [Koha-bugs] [Bug 16700] Quick spine label creator: Add a hint that IntranetUserCSS can be used for styling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16700 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 12:58:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 10:58:45 +0000 Subject: [Koha-bugs] [Bug 21329] Add additional fields to purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Purchase Suggestions Add |Add additional fields to |Custom Fields |purchase suggestions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 13:01:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 11:01:37 +0000 Subject: [Koha-bugs] [Bug 21548] Make ILL patron category in koha-conf.xml match with ILL patron category in sample data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILLLIBS patron category / |Make ILL patron category in |partner_code seems |koha-conf.xml match with |extraneous |ILL patron category in | |sample data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 13:06:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 11:06:24 +0000 Subject: [Koha-bugs] [Bug 24968] Add system preference controls for cronjobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Syspref controls for |Add system preference |cronjobs |controls for cronjobs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 13:33:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 11:33:39 +0000 Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 13:33:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 11:33:41 +0000 Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371 --- Comment #1 from Mason James --- Created attachment 149060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149060&action=edit Bug 33371: Add 'koha-common.service' systemd service to test - install current package - note following $message on install 'Failed to enable unit: Unit /run/systemd/generator.late/koha-common.service is transient or generated.' - apply patch, build package, install new package - note $message is gone! :) - test koha-common.service # systemctl start koha-common # systemctl status koha-common | grep running Active: active (running) since Sun 2023-04-02 00:27:31 NZDT <<< # systemctl stop koha-common # systemctl status koha-common | grep dead Active: inactive (dead) since Sun 2023-04-02 00:25:34 NZDT <<< -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 14:10:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 12:10:08 +0000 Subject: [Koha-bugs] [Bug 33298] Add a internal/non-public note field to serial issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33298 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23616 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 14:10:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 12:10:08 +0000 Subject: [Koha-bugs] [Bug 23616] Private repeatable note field needed in Serials Subscription Record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23616 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33298 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 16:15:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 14:15:19 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 16:15:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 14:15:22 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149022|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim --- Created attachment 149061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149061&action=edit Bug 33381: Correct styling in the ERM menu If you are on /erm/agreements you will notice that the "Agreements" tab on the menu is correctly highlighted. However if you are on /erm/agreements/add it won't. Test plan: Go to /cgi-bin/koha/erm/agreements/add and confirm that the "Agreements" tab in styled the same as when you are on /erm/agreements Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 16:48:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 14:48:14 +0000 Subject: [Koha-bugs] [Bug 33391] New: Prevent applying hover style on navmenulist items that are active Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 Bug ID: 33391 Summary: Prevent applying hover style on navmenulist items that are active Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, jonathan.druart+koha at gmail.com, martin.renvoize at ptfs-europe.com, oleonard at myacpl.org Depends on: 30952 If you go to system preferences with "Accounting" menu item active: /cgi-bin/koha/admin/preferences.pl?tab=accounting Hover on it, you'll see no difference (that's the intended behaviour) Now go to cataloging tools - inventory with "Inventory" menu item active: /cgi-bin/koha/tools/inventory.pl Hover on it, you'll see the :hover is style is overriding the .current style, resulting in jumpy behaviour with bold->normal font-size. This is happening in other places (ERM side menu, others). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 16:48:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 14:48:14 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33391 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 [Bug 33391] Prevent applying hover style on navmenulist items that are active -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 16:49:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 14:49:19 +0000 Subject: [Koha-bugs] [Bug 33391] Prevent applying hover style on navmenulist currently active item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Prevent applying hover |Prevent applying hover |style on navmenulist items |style on navmenulist |that are active |currently active item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 16:50:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 14:50:31 +0000 Subject: [Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Prevent applying hover |Currently active menu item |style on navmenulist |on navmenulist should not |currently active item |change style on hover -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 16:51:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 14:51:37 +0000 Subject: [Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 16:51:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 14:51:39 +0000 Subject: [Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 --- Comment #1 from Pedro Amorim --- Created attachment 149062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149062&action=edit Bug 33391: Prevent applying hover style on navmenulist currently active item * Apply patch * Run yarn css:build * Do the 2nd example above again and verify -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 17:00:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 15:00:20 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #3 from Pedro Amorim --- Hmm... Giving this a second look, I don't think we should be adding niche ERM styling cases onto staff-global.scss. @Joubu this patch also "fixed" (unintentionally, I believe) the jumpy behavior I mentioned to you on hackfest, I opened bug 33391 for that. As for this specific bug, I think the selector in your patch is wrong, it should be not(.disabled) instead of not(:disabled) because we're applying the "disabled" class, instead of using the "disabled" attribute. I think we should either: 1) Fix this through styling but keep it in ERM files 2) Fix it through code (make sure .current class is added to the left menu item when in either FormAdd or Show views for that content type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 17:28:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 15:28:01 +0000 Subject: [Koha-bugs] [Bug 33370] Agreements_spec.ts is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33370 --- Comment #9 from Pedro Amorim --- This seems like a decent solution to the problem. (In reply to Jonathan Druart from comment #8) > Maybe we could overload cy.visit to not have to add the wait statement all > over the tests (?) What do you mean by overload cy.visit? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 17:41:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 15:41:55 +0000 Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 --- Comment #14 from Pedro Amorim --- (In reply to Hans PĂ„lsson from comment #13) > it would be > more logical to say what backends should be visible, since all are addons to > Koha (mainly plugins). Hi Hans! The workflow I'm proposing is: as soon as you install a backend, it's enabled and showing by default for both Staff and OPAC, as I believe this is likely the intent (and expectation) of most ILL backend installations (I may be wrong here, of course!). This change in the sys pref would provide the option of hiding in the OPAC any one, or more - or all - installed backends, an improvement over the current functionality that does not allow for hiding all the backends in the OPAC. Apologies if not clear enough! Any input or alternative suggestion is welcome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 19:39:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 17:39:00 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149061|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim --- Created attachment 149063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149063&action=edit Bug 33381: Change router link active class match rule This makes it so that the route erm/agreements/1 will also match the router-link /erm/agreements instead of the previous exact match rule, thus adding the 'current' class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 20:12:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 18:12:23 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147157|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim --- Created attachment 149064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149064&action=edit Bug 32548: Make illrequestattributes available in ILL emails Without this ILL module only provides very limited data to be included in the notices sent about the request itself. We have the columns illrequests, but not the illrequestattributes, that often will contain the more useful information needed. This patch enables to use values of the illrequestattributs using [% illrequestattributes. %] in the notices. To test: * Apply patch * First you'll need to activate the ILL module and install a backend to use it with. FreeForm was used for this test plan, BLDSS is usually also good for testing. See: https://wiki.koha-community.org/wiki/ILL_backends * Also set up an SMTP server to use for notices and make sure the email address is set in KohaAdminEmailAddress and the user you are using for testing this with. * Make sure your user has an email address and will receive ILL notices by seleting them in the messaging preferences. * Create an ILL request with the FreeForm backend for your user. * On the ILL request detail page: "Display supplier metadata" Pick some attributes you want to use in the notice * Go to Tools > Notices and slips and edit ILL_REQUEST_UNAVAIL * Add some of the attributes you picked. Example: [% illrequestattributes.type %] [% illrequestattributes.title %] * Back to the ILL request detail page: Send notice to patron > ILL request unavailable * Go to your patron's account and check the notices tab * The generated notice shoudl show and include the information from the illrequestattributes you picked. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 20:12:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 18:12:25 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149034|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim --- Created attachment 149065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149065&action=edit Bug 32548: Add tests Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 20:12:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 18:12:28 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149035|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim --- Created attachment 149066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149066&action=edit Bug 32548: Replace while with map Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 20:12:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 18:12:42 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 20:13:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 18:13:34 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 --- Comment #8 from Pedro Amorim --- I think this needs to be properly documented, or included in the fields list somehow, or maybe a note mentioning this in the UI? I have no idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 22:26:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 20:26:05 +0000 Subject: [Koha-bugs] [Bug 33342] Fix framework handling in manage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33342 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind --- If you could add a test plan, I would be more than happy to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 22:50:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 20:50:13 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 22:50:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 20:50:15 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148917|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 149067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149067&action=edit Bug 33356: Highlight mana-kb from reports when not configured This patch adds a 'Knowledgebase' info block under 'Useful resources' on teh report creation pages. This highlights to reports users that mana has not be configured as yet, hopefully encouraging them to turn it on. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 22:53:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 20:53:04 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. To see the highlight in the left sidebar, select any of the report creation links from the reports page (such as create guided report, create from SQL, and use saved). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 23:00:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 21:00:34 +0000 Subject: [Koha-bugs] [Bug 27513] Add description to reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 1 23:00:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Apr 2023 21:00:36 +0000 Subject: [Koha-bugs] [Bug 27513] Add description to reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149012|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 149068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149068&action=edit Bug 27513: Add notes to variables for report parameters template This patch adds the TT variable 'notes' to the variables that guided_reports.pl passes to the template guided_reports_start.tt during SQL parameters entry in the phase 'Run this report'. To test: 1. apply the patch 2. navigate to Reports -> Guided Reports -> Create from SQL 3. create an SQL report that includes at least one parameter, e.g.: SELECT barcode FROM items WHERE homebranch=<> the actual SQL and name of the report doesn't matter much, just make sure that you also put a note e.g. "Test text for display" in the field "Notes:" before you save the report. 4. run the report 5. the note you entered should now be displayed below the heading "Enter parameters for report..." Signed-off-by: David Nind Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 01:10:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Apr 2023 23:10:27 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #69 from AgustĂ­n Moyano --- Signed-off from me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 02:03:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 00:03:06 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148954|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 149150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149150&action=edit Bug 33368: Extends borrowers.flags to bigint it's a int(11) which means its limit is 2^31 We have currently 29 permissions, there is only one remaining, at 31 permissions the permission system won't support a case where a patron has all permissions. Test plan: Don't apply this patch Add another permission INSERT INTO userflags (bit, flag, flagdesc, defaulton) VALUES (30, 'new permission 1', '', 0) ; Go to the interface, tick all the boxes select flags from borrowers where borrowernumber=5; => 2113928830 Remember: 2^31 2147483648 2^32 4294967296 Add another one INSERT INTO userflags (bit, flag, flagdesc, defaulton) VALUES (31, 'new permission 2', '', 0) ; Repeat the step before => boom CGI::Compile::ROOT::kohadevbox_koha_members_member_2dflags_2epl::member_2dflags_2epl(): DBI Exception: DBD::mysql::st execute failed: Out of range value for column 'flags' at row 1 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 Apply the patch, try again QA note: That's ofc not the best solution, but the easiest for now Signed-off-by: Nick Clemens Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 02:03:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 00:03:08 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148955|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 149151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149151&action=edit Bug 33368: DBIC Signed-off-by: Nick Clemens Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 02:13:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 00:13:01 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- It works! However I don't get why because bigint(11) still has 11 for the number of digits. But it works up to at least 40 bits/flags. And MariaDB's doc doesn't have anything suspicious like the number for bigint being there for compatibility/historical reasons and not being used. https://mariadb.com/kb/en/bigint/ Anyway, second signoff added so it can still be used as a signoff and Nick can pass QA if they know the answer to the above and don't want to wait. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 03:17:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 01:17:13 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 --- Comment #8 from TomĂĄs Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #7) > It works! However I don't get why because bigint(11) still has 11 for the > number of digits. But it works up to at least 40 bits/flags. And MariaDB's > doc doesn't have anything suspicious like the number for bigint being there > for compatibility/historical reasons and not being used. > https://mariadb.com/kb/en/bigint/ > > Anyway, second signoff added so it can still be used as a signoff and Nick > can pass QA if they know the answer to the above and don't want to wait. (11) i.e. the 'display width' is not relevant to the storage size, which is the problem here. Any INT data type will have the same known limit. It is only relevant if you define things like zero padding, and then you know it will fill with zeroes up to 11 digits. For reference: https://dev.mysql.com/doc/refman/5.7/en/numeric-type-syntax.html#:~:text=The%20maximum%20display%20width%20is,digits%20that%20can%20be%20stored. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 03:43:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 01:43:24 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from A3950 in encodings other than UTF-8 are corrupted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Eric Phetteplace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace at cca.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 03:59:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 01:59:35 +0000 Subject: [Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145170|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 03:59:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 01:59:43 +0000 Subject: [Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145249|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 04:00:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 02:00:02 +0000 Subject: [Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602 --- Comment #7 from Alex Buckley --- Created attachment 149152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149152&action=edit Bug 32602: SIP server doesn't respect IssuingInProcess system preference The system preference 'IssuingInProcess' when set to "Don't prevent" means patrons will still be allowed to issue items if their rental charge took the patron over the noissuescharge system preference. However, SIP returns that a patron is fine blocked (even if 'IssuingInProcess' equals "Don't prevent") when they try to issue items that take them over the noissuecharge amount. Test plan: 1. Configure the BK item type to have a rental charge of $2 2. Configure system preferences: - noissuescharge = $5 - IssuingInProcess = Don't prevent 3. From a SIP2 device issue 3 BK items to a borrower and notice after the 2nd item you cannot issue the third item 4. Apply patches 5. Restart your SIP2 server 6. From a SIP2 device issue 3 BK items to a different patron and notice you can issue all three items Sponsored-by: Horowhenua District Council, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 04:00:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 02:00:17 +0000 Subject: [Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602 --- Comment #8 from Alex Buckley --- Created attachment 149153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149153&action=edit Bug 32602: Unit tests Test plan: 1. sudo koha-shell 2. prove -v t/db_dependent/SIP/Transaction.t 3. Confirm all tests pass Sponsored-by: Horowhenua District Council, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 04:55:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 02:55:06 +0000 Subject: [Koha-bugs] [Bug 33414] New: Dates displayed in ISO format in orders by fund Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 Bug ID: 33414 Summary: Dates displayed in ISO format in orders by fund Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Since Bug 30718, dates are displayed in ISO format in orders by fund -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 04:55:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 02:55:14 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 04:55:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 02:55:19 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30717 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 04:55:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 02:55:19 +0000 Subject: [Koha-bugs] [Bug 30717] Dates displayed in ISO format when editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30717 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33414 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 04:55:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 02:55:29 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30718 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 [Bug 30718] Use flatpickr's altInput option everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 04:55:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 02:55:29 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33414 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 [Bug 33414] Dates displayed in ISO format in orders by fund -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 05:01:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 03:01:08 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 05:01:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 03:01:10 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 --- Comment #1 from Fridolin Somers --- Created attachment 149154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149154&action=edit Bug 33414: Fix dates display in orders by fund Since Bug 30718, dates are displayed in ISO format in orders by fund. It removed dates formating in perl, this must be added in template. Test plan : 1) Create some fresh orders on a fund F1 2) Go to Acquisitions > Orders by fund 3) Select fund F1 and 'To screen into the browser' 4) Submit 5) Check you see a formatted date in 'Entry date' column 6) Recieve some order from fund F1 Repeat 2 to 4 7) Check you see formatted date in 'Date received' column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 07:25:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 05:25:48 +0000 Subject: [Koha-bugs] [Bug 33415] New: fix failing tests, force Crypt::CBC and Auth::GoogleAuth pkgs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33415 Bug ID: 33415 Summary: fix failing tests, force Crypt::CBC and Auth::GoogleAuth pkgs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com more info to come... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 07:25:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 05:25:58 +0000 Subject: [Koha-bugs] [Bug 33415] fix failing tests, force Crypt::CBC and Auth::GoogleAuth pkgs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33415 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 07:53:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 05:53:53 +0000 Subject: [Koha-bugs] [Bug 33370] Cypress tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33370 --- Comment #16 from Jonathan Druart --- Wondering if this actually needed if we have bug 33408, and specifically this change in Main.vue: -
+
-- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 08:07:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 06:07:48 +0000 Subject: [Koha-bugs] [Bug 33415] fix failing tests, force Crypt::CBC and Auth::GoogleAuth pkgs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33415 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 08:07:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 06:07:51 +0000 Subject: [Koha-bugs] [Bug 33415] fix failing tests, force Crypt::CBC and Auth::GoogleAuth pkgs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33415 --- Comment #1 from Mason James --- Created attachment 149155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149155&action=edit Bug 33415: fix failing tests, force Crypt::CBC and Auth::GoogleAuth pkgs to test... - run tests in KTD, observe failure 00:12:29.330 koha_1 | Base class package "Crypt::CBC" is empty. 00:08:46.991 koha_1 | Base class package "Auth::GoogleAuth" is empty. - apply patches, build/install new package - install new package in KTD, observe success -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 08:11:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 06:11:56 +0000 Subject: [Koha-bugs] [Bug 30594] Package Crypt::CBC 2.35 or higher to increase security In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30594 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Mason James --- (In reply to Martin Renvoize from comment #0) > Currently, Debian mostly comes with Crypt::CBC 2.33 pre-packaged. If we > package 2.35 or above we can benefit from a performance boost as well as > having the ability to update our derivation function to using the > recommended pbkdf2 algorithm instead of the backwards compatible default of > opensslv1. > > If we choose to package this, we should also update Koha::Encryption to > reflect the change and use pbkdf2. hiya, we now have libcrypt-cbc-perl (3.04-3) added to koha-staging/dev repo so we can proceed with an upgrade to pbkdf2 https://packages.debian.org/bookworm/libcrypt-cbc-perl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:03:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:03:27 +0000 Subject: [Koha-bugs] [Bug 33415] fix failing tests, force Crypt::CBC and Auth::GoogleAuth pkgs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33415 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID --- Comment #2 from Mason James --- oops, invalid bug is now fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:12:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:12:03 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:12:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:12:05 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149154|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 149156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149156&action=edit Bug 33414: Fix dates display in orders by fund Since Bug 30718, dates are displayed in ISO format in orders by fund. It removed dates formating in perl, this must be added in template. Test plan : 1) Create some fresh orders on a fund F1 2) Go to Acquisitions > Orders by fund 3) Select fund F1 and 'To screen into the browser' 4) Submit 5) Check you see a formatted date in 'Entry date' column 6) Recieve some order from fund F1 Repeat 2 to 4 7) Check you see formatted date in 'Date received' column Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:12:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:12:08 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 --- Comment #3 from Jonathan Druart --- Created attachment 149157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149157&action=edit Bug 33414: Add the data-order class Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:21:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:21:17 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #70 from Jonathan Druart --- Added your signed-off-by lines to the remote branch, thanks a lot! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:21:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:21:47 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #71 from Jonathan Druart --- Created attachment 149158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149158&action=edit Bug 33066: Introduce a KohaTable Vue component The way we deal with DataTables in Vue component is not nice, especially when we need to add buttons/link in the cell and interact with the rest of the Vue app from there. When I started to work on Vue last year there was no good solution from DataTables, now there is a Vue component. It is not perfect, you still cannot add Vue component in the DT component, but it brings something to follow. Agustin implemented something on theke/import_source_vue, but he went too far, and it will need to rewrite the whole ERM module. Additionally he didn't provide a solution that has the same features as what we have now. The goal of this patch is to not duplicate the code in datatables.js, we don't want to maintain two version of this code (one is enough already!) We split the huge function in datatables.js in small ones to make them reusable from the Vue component. This is quite ugly, and it needs to lot more addition, but it's a first start! Help, ideas, and feedback welcome (and needed!) Bug 33066: Fix agreement name in delete confirmation dialog Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:21:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:21:51 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #72 from Jonathan Druart --- Created attachment 149159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149159&action=edit Bug 33066: Fix dt - no need to reselect Bug 33066: (follow-up) Fix dt - no need to reselect Patron search result table was not displayed correctly Uncaught TypeError: this.on is not a function Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:21:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:21:54 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #73 from Jonathan Druart --- Created attachment 149160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149160&action=edit Bug 33066: Add colvis Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:21:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:21:58 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #74 from Jonathan Druart --- Created attachment 149161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149161&action=edit Bug 33066: Fix "Loading..." Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:01 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #75 from Jonathan Druart --- Created attachment 149162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149162&action=edit Bug 33066: Reintroduce column filters Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:05 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #76 from Jonathan Druart --- Created attachment 149163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149163&action=edit Bug 33066: Fix name display Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:08 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #77 from Jonathan Druart --- Created attachment 149164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149164&action=edit Bug 33066: Remove build_datatable Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:11 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #78 from Jonathan Druart --- Created attachment 149165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149165&action=edit Bug 33066: Embed vendor and retrieve vendor name from the request Bug 33066: (follow-up) Embed vendor and retrieve vendor name from the request It needs "Bug 32923: Allow to embed user_roles for agreements" Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:14 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #79 from Jonathan Druart --- Created attachment 149166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149166&action=edit Bug 33066: Remove duplicate 'Actions' column Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:18 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #80 from Jonathan Druart --- Created attachment 149167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149167&action=edit Bug 33066: Fix default_search Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:21 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #81 from Jonathan Druart --- Created attachment 149168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149168&action=edit Bug 33066: Fix default_filters Will need to be tested when EHoldingsEBSCOTitlesList.vue will be adjusted Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:24 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #82 from Jonathan Druart --- Created attachment 149169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149169&action=edit Bug 33066: Fix ColVis The filter (header) was not removed alongwith the column Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:28 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #83 from Jonathan Druart --- Created attachment 149170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149170&action=edit Bug 33066: Fix width after ColVis change This fixes the width to 100%, otherwise it is not recalculated correctly Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:31 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #84 from Jonathan Druart --- Created attachment 149171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149171&action=edit Bug 33066: Use KohaTable for LicensesList Bug 33066: (follow-up) Use KohaTable for LicensesList There was a mismatch, we can embed the whole vendor object info. Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:34 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #85 from Jonathan Druart --- Created attachment 149172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149172&action=edit Bug 33066: Restore HTML escaping And we add a render function that will escape by default Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:37 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #86 from Jonathan Druart --- Created attachment 149173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149173&action=edit Bug 33066: Restore filter by mine Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:41 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #87 from Jonathan Druart --- Created attachment 149174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149174&action=edit Bug 33066: Use KohaTable for EHoldingsLocalPackagesList Bug 33066: (follow-up) Use KohaTable for EHoldingsLocalTitlePackagesList Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:44 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #88 from Jonathan Druart --- Created attachment 149175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149175&action=edit Bug 33066: Use KohaTable for EHoldingsLocalPackageTitlesList Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:48 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #89 from Jonathan Druart --- Created attachment 149176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149176&action=edit Bug 33066: Use KohaTable for EHoldingsLocalTitlesList Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:51 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #90 from Jonathan Druart --- Created attachment 149177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149177&action=edit Bug 33066: Use KohaTable for EHoldingsEBSCOPackagesList Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:54 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #91 from Jonathan Druart --- Created attachment 149178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149178&action=edit Bug 33066: Restore '(#id)' to lists Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:22:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:22:57 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #92 from Jonathan Druart --- Created attachment 149179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149179&action=edit Bug 33066: Use KohaTable for EHoldingsEBSCOPackageTitlesList Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:23:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:23:01 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #93 from Jonathan Druart --- Created attachment 149180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149180&action=edit Bug 33066: Use KohaTable for EHoldingsEBSCOTitlesList Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:23:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:23:04 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #94 from Jonathan Druart --- Created attachment 149181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149181&action=edit Bug 33066: Remove useless use of useDataTable Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:23:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:23:08 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #95 from Jonathan Druart --- Created attachment 149182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149182&action=edit Bug 33066: Fix cypress tests Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:23:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:23:11 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #96 from Jonathan Druart --- Created attachment 149183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149183&action=edit Bug 33066: Fix table style Move table rendering outside
    to prevent unintended style in _forms.scss from being applied and causing table to not be full width Remove unecessary table styling JD: following commit has been squashed. Patch from Pedro is fixing the FIXME """ Bug 33066: Fix style - FIXME This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1 The table is not taking width: 100% I fixed it previously with the display: table in the style block, but here it's not applied. There is also the "green tick" (fa-check-square-o) that is not on the same line https://snipboard.io/jma923.jpg """ Signed-off-by: Pedro Amorim Signed-off-by: AgustĂ­n Moyano -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:38:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:38:42 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149133|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 149184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149184&action=edit Bug 33408: Fetch sysprefs from svc/config/systempreferences It will be easier to mock/set them from cypress tests. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:38:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:38:44 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149134|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 149185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149185&action=edit Bug 33408: Mock ERM sysprefs from cypress tests Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:44:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:44:57 +0000 Subject: [Koha-bugs] [Bug 33370] Cypress tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33370 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #17 from Jonathan Druart --- (In reply to Jonathan Druart from comment #16) > Wondering if this actually needed if we have bug 33408, and specifically > this change in Main.vue: > > -
    > +
    Giving this one a try and closing this one for now. *** This bug has been marked as a duplicate of bug 33408 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:44:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:44:57 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #7 from Jonathan Druart --- *** Bug 33370 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 09:44:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 07:44:57 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Bug 33402 depends on bug 33370, which changed state. Bug 33370 Summary: Cypress tests are failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33370 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:04:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 08:04:14 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #8 from Jonathan Druart --- Created attachment 149186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149186&action=edit Bug 33408: Extend defaultCommandTimeout for cypress Sometimes the initial page load takes more than 4 seconds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:29:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 08:29:30 +0000 Subject: [Koha-bugs] [Bug 33416] New: Agreements.ts is failing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Bug ID: 33416 Summary: Agreements.ts is failing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33408 --- Comment #1 from Jonathan Druart --- Not sure where it's coming from, but on top of bug 33408 it is failing consistently. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 [Bug 33408] Fetch sysprefs from svc/config/systempreferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:30:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 08:30:02 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 [Bug 33416] Agreements.ts is failing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:30:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 08:30:34 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:30:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 08:30:37 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 --- Comment #2 from Jonathan Druart --- Created attachment 149187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149187&action=edit Bug 33416: Fix Agreements.ts References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149063|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim --- Created attachment 149188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149188&action=edit Bug 33381: Fix sidemenu active and hover styling Change router link active class match rule. This makes it so that the route erm/agreements/1 will also match the router-link /erm/agreements instead of the previous exact match rule, thus adding the 'current' class Update styling router-links to not apply 'current' styling when .disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:38:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 08:38:09 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 10:39:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 08:39:10 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:07:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 09:07:16 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149188|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim --- Created attachment 149189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149189&action=edit Bug 33381: Fix sidemenu active and hover styling Change router link active class match rule. This makes it so that the route erm/agreements/1 will also match the router-link /erm/agreements instead of the previous exact match rule, thus adding the 'current' class Update styling router-links to not apply 'current' styling when .disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:10:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 09:10:56 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149189|0 |1 is obsolete| | --- Comment #8 from Pedro Amorim --- Created attachment 149190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149190&action=edit Bug 33381: Fix sidemenu active and hover styling Change router link active class match rule. This makes it so that the route erm/agreements/1 will also match the router-link /erm/agreements instead of the previous exact match rule, thus adding the 'current' class Update styling router-links to not apply 'current' styling when .disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:20:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 09:20:52 +0000 Subject: [Koha-bugs] [Bug 33125] 2nd sorting level of titles in results lists should be configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33125 Claes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claes.eriksson at vti.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 11:51:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 09:51:27 +0000 Subject: [Koha-bugs] [Bug 33400] Titles_spec.ts is failing because alert is not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33400 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m --- Comment #5 from Pedro Amorim --- Without applying patch yarn cypress run: * 1st run: no issues * 2nd run: Package CRUD operations Add package: AssertionError: Timed out retrying after 4000ms: Expected to find content: 'New package' but never did. at Context.eval (http://localhost:8081/__cypress/tests?p=t/cypress/integration/Packages_spec.ts:194:12) I don't think this is the same error, it's failing to find the "New package" on package CRUD, instead of failing to find the dialog in titles. * 3rd run: no issues * 4th run: no issues * 5th run: no issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:07:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 10:07:33 +0000 Subject: [Koha-bugs] [Bug 33400] Titles_spec.ts is failing because alert is not visible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33400 --- Comment #6 from Jonathan Druart --- (In reply to Pedro Amorim from comment #5) > * 2nd run: > Package CRUD operations > Add package: > AssertionError: Timed out retrying after 4000ms: Expected to find > content: 'New package' but never did. > at Context.eval > (http://localhost:8081/__cypress/tests?p=t/cypress/integration/Packages_spec. > ts:194:12) > > I don't think this is the same error, it's failing to find the "New package" > on package CRUD, instead of failing to find the dialog in titles. Yes, that's different. I think this one will be fixed by bug 33408. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:12:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 10:12:16 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #26 from Matt Blenkinsop --- Hi Nick - I'm getting an alert asking me to select a pickup location when placing a hold on next available item, even when a location is selected. Could you check again at your end and see if you're seeing the same? Looks like the alert is being thrown by the else block in lines 1570 - 1575 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:19:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 10:19:36 +0000 Subject: [Koha-bugs] [Bug 33410] Use template wrapper for breadcrumbs: Patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:19:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 10:19:38 +0000 Subject: [Koha-bugs] [Bug 33410] Use template wrapper for breadcrumbs: Patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149138|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop --- Created attachment 149191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149191&action=edit Bug 33410: Use template wrapper for breadcrumbs: Patron card creator This patch updates several patron card creator templates so that they use the new WRAPPER for displaying breadcrumbs. Unrelated minor change: I added around a few other strings in edit-profile.tt and edit-template.tt in order to improve translatability. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Patron card creator - New -> - Card batch - Image - Layout - Card template - Printer profile - Manage -> - Card batches - Images - Layouts - Card templates - Printer profiles Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:50:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 10:50:19 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 12:50:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 10:50:22 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149125|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim --- Created attachment 149192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149192&action=edit Bug 33402: Move ERM Cypress tests to their own directory We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts ) to their own subdirectory, eg t/cypress/integration/ERM Test plan: Confirm that the cypress tests are still passing after this change: perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 13:03:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 11:03:13 +0000 Subject: [Koha-bugs] [Bug 29607] addorderiso2709: The stored discount when importing an order from a file is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.03 |22.11.00, 22.05.03, released in| |21.11.19 CC| |arthur.suzuki at biblibre.com --- Comment #11 from Arthur Suzuki --- applied to 21.11 for 21.11.19 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 13:55:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 11:55:14 +0000 Subject: [Koha-bugs] [Bug 33417] New: Create one standard Toolbar component Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Bug ID: 33417 Summary: Create one standard Toolbar component Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: matt.blenkinsop at ptfs-europe.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com We currently have multiple Toolbar components with duplicate code - this could be standardised into one reusable component -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:06:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:06:55 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32932 Assignee|jonathan.druart+koha at gmail. |matt.blenkinsop at ptfs-europe |com |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 [Bug 32932] Re-structure Vue router-links to use "name" instead of urls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:06:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:06:55 +0000 Subject: [Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 [Bug 33417] Create one standard Toolbar component -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:12:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:12:15 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 --- Comment #1 from Matt Blenkinsop --- Created attachment 149193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149193&action=edit Bug 33417: Create standard toolbar component This commit introduces a standard Toolbar component that can be used throughout ERM Test plan: 1) Apply patch 2) Navigate to Agreements and click the "Add agreement" button - this should work as normal 3) Navigate to Licenses and repeat 4) Navigate to Local packages and repeat 5) Navigate to local titles - there should be two buttons, one to add and one to import. These should work as normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:12:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:12:17 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 --- Comment #2 from Matt Blenkinsop --- Created attachment 149194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149194&action=edit Bug 33417: Add toolbar imports and options This commit amends the required files to import the toolbar and add the correct options Test plan as above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:12:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:12:19 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 --- Comment #3 from Matt Blenkinsop --- Created attachment 149195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149195&action=edit Bug 33417: Remove old components This commit deletes the old toolbar components as they are no longer necessary Test plan as above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:13:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:13:05 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 --- Comment #4 from Matt Blenkinsop --- Not ready for signoff yet as 32932 needs a rebase and some fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:13:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:13:09 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #9 from Pedro Amorim --- Created attachment 149196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149196&action=edit Bug 33408: Remove obsolete template sys pref code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:13:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:13:11 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #10 from Pedro Amorim --- Created attachment 149197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149197&action=edit Bug 33408: Prevent access to erm module by URL if sys pref is disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:14:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:14:52 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149196|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim --- Created attachment 149198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149198&action=edit Bug 33408: Remove obsolete tests and template sys pref code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:19:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:19:21 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:19:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:19:23 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149187|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim --- Created attachment 149199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149199&action=edit Bug 33416: Fix Agreements.ts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:27:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:27:26 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #12 from Jonathan Druart --- Created attachment 149200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149200&action=edit Bug 33408: We need only one this.loaded call -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:27:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:27:55 +0000 Subject: [Koha-bugs] [Bug 33412] Problem importing records (bug 15869 follow-up) wrong use of assignment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15869 Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 [Bug 15869] Change framework on overlay -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:27:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:27:55 +0000 Subject: [Koha-bugs] [Bug 15869] Change framework on overlay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33412 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 [Bug 33412] Problem importing records (bug 15869 follow-up) wrong use of assignment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:27:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:27:58 +0000 Subject: [Koha-bugs] [Bug 33412] Problem importing records (bug 15869 follow-up) wrong use of assignment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 --- Comment #1 from Nick Clemens --- Created attachment 149201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149201&action=edit Bug 33412: Fix comparison -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:31:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:31:27 +0000 Subject: [Koha-bugs] [Bug 28609] Popularity sort is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28609 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Marcel de Rooy --- See bug 13976. I also had a struggle to get it working. You need a preference or the cron job to get the sum of issues into the biblioitems.totalissues column first. Closing this report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:31:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:31:48 +0000 Subject: [Koha-bugs] [Bug 28609] Popularity sort is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28609 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13976 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:31:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:31:48 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28609 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:34:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:34:18 +0000 Subject: [Koha-bugs] [Bug 33412] Problem importing records (bug 15869 follow-up) wrong use of assignment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:35:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:35:05 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 --- Comment #5 from Jonathan Druart --- + {{ $__(`${option.button_title}`) }} References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 --- Comment #6 from Jonathan Druart --- For a Vue module I am writing I need to show/hide button from the toolbar depending on other states. Wondering how easy/hard it will be with this new implementation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:49:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:49:50 +0000 Subject: [Koha-bugs] [Bug 33418] New: Allow setting overlay_framework for connexion imports Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33418 Bug ID: 33418 Summary: Allow setting overlay_framework for connexion imports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 15869 added the ability to specify frameworks when overlaying while importing, we should extend this to allow updating the framework for records imported from OCLC connexion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:54:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:54:16 +0000 Subject: [Koha-bugs] [Bug 33398] Show primary_contact_method when holds are triggered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33398 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149136|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 149202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149202&action=edit Bug 33398: Add primary_contact_method to display when triggering a waiting hold To test: 1. Apply patch, yarn build 2. Trigger a waiting hold for a patron that has a value for primary_contact_method 3. Notice the modal now includes a line indicating the primary_contact_method. 4. Trigger a hold for a patron without a primary_contact_method. Nothing should display. Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:54:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:54:33 +0000 Subject: [Koha-bugs] [Bug 33398] Show primary_contact_method when holds are triggered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33398 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 14:54:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 12:54:39 +0000 Subject: [Koha-bugs] [Bug 33418] Allow setting overlay_framework for connexion imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33418 --- Comment #1 from Nick Clemens --- Created attachment 149203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149203&action=edit Bug 33419: POC untested This will require testing, and better instructions on how to match etc. To test: 1 - Supply a value for 'framework' and 'overlay_framework' in the connxion.conf file 2 - Setup connexion, there is some help here on testing values: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15720 3 - Test importing bibs that match, and that don't match 4 - Confirm the framework value is used for new records 5 - Confirm if framework is blank the default framework is used for new records 6 - Confirm if framework is not supplied the default framework is used for new records 7 - Confirm a matching record that overlays obeys the overlay_framework param 8 - Confirm overlayed record uses default framework if the param is blank 9 - Confirm the original records framework is retained if the param is not passed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:04:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:04:10 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:04:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:04:13 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149184|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim --- Created attachment 149204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149204&action=edit Bug 33408: Fetch sysprefs from svc/config/systempreferences It will be easier to mock/set them from cypress tests. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:04:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:04:16 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149185|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim --- Created attachment 149205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149205&action=edit Bug 33408: Mock ERM sysprefs from cypress tests Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:04:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:04:18 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149186|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim --- Created attachment 149206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149206&action=edit Bug 33408: Extend defaultCommandTimeout for cypress Sometimes the initial page load takes more than 4 seconds. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:04:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:04:21 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149197|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim --- Created attachment 149207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149207&action=edit Bug 33408: Prevent access to erm module by URL if sys pref is disabled Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:04:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:04:24 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149198|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim --- Created attachment 149208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149208&action=edit Bug 33408: Remove obsolete tests and template sys pref code Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:04:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:04:27 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149200|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim --- Created attachment 149209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149209&action=edit Bug 33408: We need only one this.loaded call Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:04:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:04:27 +0000 Subject: [Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:04:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:04:32 +0000 Subject: [Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #32 from Agustín Moyano --- Created attachment 149210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149210&action=edit Bug 32932: (follow-up) Fix copy/paste bug in local titles form add and fix bad link definition in Main.vue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:06:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:06:22 +0000 Subject: [Koha-bugs] [Bug 33418] Allow setting overlay_framework for connexion imports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33418 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:10:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:10:36 +0000 Subject: [Koha-bugs] [Bug 29449] Show userid on "your personal details" tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #11 from Marcel de Rooy --- Interesting! I have a question: What would be the recommended way to use this in relation to the various borrower mandatory/unwanted settings? I applied this change on 21.11 and still did not see userid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:15:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:15:41 +0000 Subject: [Koha-bugs] [Bug 32256] self-checkout batch mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:23:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:23:03 +0000 Subject: [Koha-bugs] [Bug 33419] New: Make home branch mandatory by default Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Bug ID: 33419 Summary: Make home branch mandatory by default Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Items without a home branch can cause errors in Koha. On the bib page, items appear without the "edit" drop-down or the selection check box. On a bulk delete page, items without a home branch create a red error that says "Cannot delete". Making the home branch value mandatory can help avoid these issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:23:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:23:18 +0000 Subject: [Koha-bugs] [Bug 33419] Make home branch mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25449 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:23:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:23:18 +0000 Subject: [Koha-bugs] [Bug 25449] Make itemtype mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25449 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33419 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:26:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:26:47 +0000 Subject: [Koha-bugs] [Bug 33420] New: Allow deletion of ILL notices ILL_PICKUP_READY and ILL_REQUEST_UNAVAIL Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33420 Bug ID: 33420 Summary: Allow deletion of ILL notices ILL_PICKUP_READY and ILL_REQUEST_UNAVAIL Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org The notices ILL_PICKUP_READY and ILL_REQUEST_UNAVAIL cannot be deleted by users. Libraries that do not use the ILL module should be able to delete these notices. All the other ILL notices are able to be deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:41:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:41:23 +0000 Subject: [Koha-bugs] [Bug 33419] Make home branch mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #1 from Laura Escamilla --- Created attachment 149211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149211&action=edit Bug 33419: Set home library mandatory by default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:41:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:41:52 +0000 Subject: [Koha-bugs] [Bug 33419] Make home branch mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |Laura.escamilla at bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 15:44:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 13:44:31 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 --- Comment #7 from Matt Blenkinsop --- (In reply to Jonathan Druart from comment #6) > For a Vue module I am writing I need to show/hide button from the toolbar > depending on other states. Wondering how easy/hard it will be with this new > implementation. My first thoughts would be that filtering the toolbar_options array would show/hide buttons, perhaps a toolbar_options and a filtered_toolbar_options would be necessary -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:03:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:03:59 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 --- Comment #8 from Matt Blenkinsop --- Created attachment 149212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149212&action=edit Bug 33417: Fix translation in toolbar This commit allows the string to be translated using String.prototype.format() Test plan as above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:07:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:07:08 +0000 Subject: [Koha-bugs] [Bug 33421] New: Filtering purchase suggestions by status does not work if All Libraries is selected Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33421 Bug ID: 33421 Summary: Filtering purchase suggestions by status does not work if All Libraries is selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org To reproduce: 1. In suggestion.pl in the staff client, select "Viewing suggestions for library: Any" 2. Using the "Suggestion information" filters on the left of the page, select a particular status to filter by and click "Go" Result: When the page reloads, suggestions of all statuses are shown, regardless of the selected filter. In 22.5.09, the drop-down to filter by Status also resets to "All" (although the URL parameter appears correct). In 22.11 and master, the drop-down to filter by Status retains the selected value but the results are not filtered. If you set the drop-down for "Viewing suggestions for library" to a particular library and try again to filter by status, it filters correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:10:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:10:17 +0000 Subject: [Koha-bugs] [Bug 33419] Make home branch mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:11:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:11:44 +0000 Subject: [Koha-bugs] [Bug 33419] Make home branch mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149211|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:13:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:13:24 +0000 Subject: [Koha-bugs] [Bug 33422] New: ERM - Search header should change to match the section you are in Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 Bug ID: 33422 Summary: ERM - Search header should change to match the section you are in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: pedro.amorim at ptfs-europe.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 32728 Originally fixed in bug 32728 but it's not working again, we need to fix it, and provide tests for it to make sure this doesn't happen again. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 [Bug 32728] ERM - Search header should change to match the section you are in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:13:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:13:24 +0000 Subject: [Koha-bugs] [Bug 32728] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32728 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33422 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 [Bug 33422] ERM - Search header should change to match the section you are in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:16:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:16:04 +0000 Subject: [Koha-bugs] [Bug 33419] Make home branch mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #2 from Laura Escamilla --- Created attachment 149213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149213&action=edit Bug 33419: Set home library mandatory by default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:17:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:17:34 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 --- Comment #9 from Jonathan Druart --- (In reply to Matt Blenkinsop from comment #8) > Created attachment 149212 [details] [review] > Bug 33417: Fix translation in toolbar > > This commit allows the string to be translated using > String.prototype.format() > > Test plan as above Have you tried it? I haven't :) But I don't think it will work. Try that: Replace "New agreement" with something that is NOT in the PO already, then run the translate script => Make sure it's in the PO I am pretty sure it does not work and that you need to explicitly have $__("New agreement") in the code base. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:17:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:17:36 +0000 Subject: [Koha-bugs] [Bug 33423] New: Cypress - Using UI to login is against best practice Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33423 Bug ID: 33423 Summary: Cypress - Using UI to login is against best practice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 32030 https://docs.cypress.io/guides/references/best-practices#Organizing-Tests-Logging-In-Controlling-State We should update the way we login in for our cypress tests using the logging in recipes in the above link (if possible?), and not login through UI, as we are at the moment. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:17:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:17:36 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33423 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33423 [Bug 33423] Cypress - Using UI to login is against best practice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:18:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:18:03 +0000 Subject: [Koha-bugs] [Bug 33423] Cypress - Using UI to login is against best practice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33423 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:20:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:20:30 +0000 Subject: [Koha-bugs] [Bug 33419] Make home branch mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149211|Bug 33419: Set home library |Bug 33419: Set home library description|mandatory by default |mandatory by default | |(UNIMARC) Attachment #149211|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:32:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:32:00 +0000 Subject: [Koha-bugs] [Bug 33363] More specific permissions for purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:36:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:36:13 +0000 Subject: [Koha-bugs] [Bug 32565] Holds placed when all libraries are closed do not get added to holds queue if HoldsQueueSkipClosed and RealTimeHoldsQueue are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32565 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:45:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:45:43 +0000 Subject: [Koha-bugs] [Bug 33424] New: tags incompatibility across koha versions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33424 Bug ID: 33424 Summary: tags incompatibility across koha versions Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: PC OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Bugzilla Assignee: jonathan.druart+koha at gmail.com Reporter: kohasupport at nlj.gov.jm We store a backup of koha on version 21.05 and use a live version on 21.11. The database on the backup displays data in fields, whereas those same fields show up empty in the live version. For example 040$c shows data in version 21.05, but the same version of the database does not show data in version 21.11. Thank you for your assistance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:48:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:48:00 +0000 Subject: [Koha-bugs] [Bug 33419] Make home branch mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #3 from Laura Escamilla --- Created attachment 149214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149214&action=edit Bug 33419: Update basic_workflow.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:54:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:54:10 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149212|0 |1 is obsolete| | --- Comment #10 from Matt Blenkinsop --- Created attachment 149215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149215&action=edit Bug 33417: Fix translation in toolbar This commit allows the string to be translated - tested using fr-FR and a dummy string in the .po file (see image attached) Test plan as above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:54:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:54:19 +0000 Subject: [Koha-bugs] [Bug 33409] Use template wrapper for breadcrumbs: Patrons lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33409 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149137|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 149216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149216&action=edit Bug 33409: Use template wrapper for breadcrumbs: Patrons lists This patch updates several patron lists templates so that they use the new WRAPPER for displaying breadcrumbs. Unrelated minor change: I added around a few other strings in add-modify.tt in order to improve translatability. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Patron lists - Main page - Patron list contents view - Add patron list - Edit patron list Signed-off-by: Andrew Auld -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:54:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:54:42 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 --- Comment #11 from Matt Blenkinsop --- Created attachment 149217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149217&action=edit Translation example -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 16:54:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 14:54:55 +0000 Subject: [Koha-bugs] [Bug 33409] Use template wrapper for breadcrumbs: Patrons lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33409 Andrew Auld changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrew.auld at ptfs-europe.com --- Comment #4 from Andrew Auld --- All works and looks as it should. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:06:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 15:06:32 +0000 Subject: [Koha-bugs] [Bug 33419] Make home branch mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149214|0 |1 is obsolete| | --- Comment #4 from Laura Escamilla --- Created attachment 149218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149218&action=edit Bug 33419: Update basic_workflow.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:15:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 15:15:46 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149143|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 149219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149219&action=edit Bug 32412: Empty coce container before appending image To test: 1. Apply patch and clear browser cache 2. Turn on Coce for the OPAC. 3. OPACShelfBrowser must be on 4. Find a record that returns a cover image and open it's detail page. 5. Use the next/previous navigation links in the OPACShelfBrowser 6. Notice that no extra image is being added to the biblio-cover-slider. 7. Make sure that Coce images still load correctly in on the OPAC detail page, OPAC results page, and in the shelf browser. Signed-off-by: Andrew Auld -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:16:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 15:16:10 +0000 Subject: [Koha-bugs] [Bug 32412] OPACShelfBrowser controls add extra Coce images to biblio-cover-slider In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32412 Andrew Auld changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld at ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Auld --- Works perfectly. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:20:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 15:20:49 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Severity|normal |major --- Comment #3 from Katrin Fischer --- This got worse with the rewrites/changes in the newer versions. The string "Not for loan" is no longer in its own HTML element, so it's not longer a simple search and replace by jQuery as a workaround. It's now much more difficult as it has the library name in the same element. Bibliothek X: Not for loan (1). The problem is here: https://git.koha-community.org/Koha-community/Koha/src/branch/master/C4/XSLT.pm#L339 Can please someone help to fix this? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:24:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 15:24:13 +0000 Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:26:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 15:26:34 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |matt.blenkinsop at ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:34:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 15:34:35 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 --- Comment #1 from Matt Blenkinsop --- Created attachment 149220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149220&action=edit Bug 33422: ERM search header should change This patch removes reference to a non-existent id ("ui-id-X") and replaces it with new ids specific to agreements, titles and packages. Test plan: 1) Apply patch 2) Navigate between Agreements, Packages, Titles using the sidebar. The search bar should change each time to match the section 3) Add some agreemens, packages, titles 4) Perform a search using the different search bar options. Each time it should take you to the correct page with the search activated in the KohaTable. The navbar should also be highlighted to match the correct section and the top search bar should also show the correct section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:34:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 15:34:58 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:36:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 15:36:09 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 17:43:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 15:43:57 +0000 Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in cash_register_stats.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |Laura.escamilla at bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 18:05:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 16:05:17 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 18:40:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 16:40:53 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 18:49:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 16:49:41 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 18:49:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 16:49:44 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149220|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 149221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149221&action=edit Bug 33422: ERM search header should change This patch removes reference to a non-existent id ("ui-id-X") and replaces it with new ids specific to agreements, titles and packages. Test plan: 1) Apply patch 2) Navigate between Agreements, Packages, Titles using the sidebar. The search bar should change each time to match the section 3) Add some agreemens, packages, titles 4) Perform a search using the different search bar options. Each time it should take you to the correct page with the search activated in the KohaTable. The navbar should also be highlighted to match the correct section and the top search bar should also show the correct section Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 18:50:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 16:50:57 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. After applying the patch (step 1), run: yarn build -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 20:17:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 18:17:26 +0000 Subject: [Koha-bugs] [Bug 22018] Add an option to 'AllowEarlyRenewal' to enable users to renew before the autorenew date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22018 Kristi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger at cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 20:28:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 18:28:08 +0000 Subject: [Koha-bugs] [Bug 33425] New: No notification when items don't import due to matching existing barcodes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33425 Bug ID: 33425 Summary: No notification when items don't import due to matching existing barcodes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If a library imports a file with items whose barcodes are duplicates of barcodes that already exist in the system (on different bibs/items - this is *not* for overlay/matching), the file will show as Imported but the items will not actually import, but there is no indication of that in 'Staged MARC record management'. The only way a library can know is to individually view each bib to see that the items did not come in. It would be helpful if there were an error message or note of some sort during the 'Staged' phase in 'Staged MARC record management' to indicate that items won't actually import, or at the 'Imported' phase to show that they didn't. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 20:43:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 18:43:21 +0000 Subject: [Koha-bugs] [Bug 33425] No notification when items don't import due to matching existing barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33425 Christofer Zorn changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christofer.zorn at ajaxlibrary | |.ca --- Comment #1 from Christofer Zorn --- Thanks Sara ... we experienced this issue and while the duplication of the barcodes was a vendor issue, there was no indication from Koha that there was an issue with the overlay. I would have hoped that the system would have complained about the file not being correct, or errors prevented this from being imported correctly. Thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 20:46:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 18:46:17 +0000 Subject: [Koha-bugs] [Bug 28688] Auto Renew Patron Membership if Patron has Been Active In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 21:50:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 19:50:02 +0000 Subject: [Koha-bugs] [Bug 33426] New: Add client storage of user-selected DataTables configuration to suggestion.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Bug ID: 33426 Summary: Add client storage of user-selected DataTables configuration to suggestion.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: emily.lamancusa at montgomerycountymd.gov Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org Depends on: 22276 Bug 22276 added a method to columns_settings.inc to support the use of the DataTables "saveState" option. Making use of that function in suggestion.tt would enable the suggestion table to remember individual users' local changes to the table configuration. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 [Bug 22276] Add client storage of user-selected DataTables configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 21:50:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 19:50:02 +0000 Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected DataTables configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33426 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 21:56:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 19:56:12 +0000 Subject: [Koha-bugs] [Bug 33424] tags incompatibility across koha versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33424 --- Comment #1 from Katrin Fischer --- This is more likely a support issue and would be better suited for the mailing list or IRC chat. If you don't have a support provider you can contact, you can find the community support channels here: https://koha-community.org/support/community-support/ You didn't include where the fields don't show. Make sure you add more information on how the problem manifests and what steps you already tried. Did you make sure the field is set to visible in your frameworks? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 21:56:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 19:56:43 +0000 Subject: [Koha-bugs] [Bug 33424] tags incompatibility across koha versions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33424 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |m.de.rooy at rijksmuseum.nl QA Contact| |testopia at bugs.koha-communit | |y.org Product|Project Infrastructure |Koha Assignee|jonathan.druart+koha at gmail. |koha-bugs at lists.koha-commun |com |ity.org Component|Bugzilla |Cataloging -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 21:57:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 19:57:14 +0000 Subject: [Koha-bugs] [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 --- Comment #1 from Katrin Fischer --- I'd love to see that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:00:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 20:00:09 +0000 Subject: [Koha-bugs] [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 --- Comment #2 from Emily Lamancusa --- Created attachment 149222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149222&action=edit Bug 33426: Add DataTables saveState to suggestion.tt To test: 1. In the staff client, go to Purchase Suggestion management page and add a suggestion if needed to make the table display. 2. Make some changes to the table settings (hide/show columns, change sort column, and/or change number of rows to display) 3. Navigate to a different page. 4. Navigate back to Purchase Suggestions page. Note that the table settings have been reset. 5. Apply patch and restart_all 6. Repeat steps 1-4. Note that this time the changes to the table settings were preserved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:00:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 20:00:21 +0000 Subject: [Koha-bugs] [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:10:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 20:10:55 +0000 Subject: [Koha-bugs] [Bug 33420] Allow deletion of ILL notices ILL_PICKUP_READY and ILL_REQUEST_UNAVAIL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33420 --- Comment #1 from Katrin Fischer --- I think we'll need sure that it creates no issues when using the ILL module when the letter is missing. Maybe they were set to 'non deletable' because they are part of the patron messaging preferences? It's similar HOLD. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:11:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 20:11:06 +0000 Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #4 from David Nind --- The patch no longer applies (was trying to test bug 32735): git bz apply 31796 Bug 31796 - REST API: PUT endpoint for Authorities 144752 - Bug 31796: Add REST endpoint to modify an authority Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31796: Add REST endpoint to modify an authority error: sha1 information is lacking or useless (Koha/REST/V1/Authorities.pm). error: could not build fake ancestor Patch failed at 0001 Bug 31796: Add REST endpoint to modify an authority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:11:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 20:11:11 +0000 Subject: [Koha-bugs] [Bug 32399] Database update for bug 30483 is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32399 --- Comment #22 from Lucas Gass --- (In reply to Marcel de Rooy from comment #21) > Why wasn't this pushed to 22.05 yet ? I'm confused about this patch. It won't apply to 22.05 because the update is directly in installer/data/mysql/atomicupdate/db_revs. Should it not be in 'installer/data/mysql/atomicupdate/atomicupdate' and the Rmaints move it to db_revs? Sorry for the confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:11:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 20:11:19 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:38:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 20:38:30 +0000 Subject: [Koha-bugs] [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 --- Comment #3 from Emily Lamancusa --- (In reply to Katrin Fischer from comment #1) > I'd love to see that :) Granted :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:44:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 20:44:23 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #166 from David Nind --- Patch no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17499: Add Koha-objects for messaging preferences Applying: Bug 17499: Define koha_object(s)_class where needed Applying: Bug 17499: Replace test subroutines with build_object Applying: Bug 17499: (QA follow-up) Fix Licence Statements Applying: Bug 17499: (QA follow-up) Fix POD errors Applying: Bug 17499: (follow-up) More explicit exceptions Applying: Bug 17499: (follow-up) Fix warning Applying: Bug 17499: (follow-up) Validate phone and itiva transport types Applying: Bug 17499: (follow-up) Contact information vs. mtt validation Applying: Bug 17499: (follow-up) Rename to Koha::Patron::MessagePreference Applying: Bug 17499: (follow-up) Add $patron->messaging_preferences accessor error: sha1 information is lacking or useless (Koha/Patron.pm). error: could not build fake ancestor Patch failed at 0001 Bug 17499: (follow-up) Add $patron->messaging_preferences accessor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:55:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 20:55:06 +0000 Subject: [Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:55:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 20:55:09 +0000 Subject: [Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146475|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 149223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149223&action=edit Bug 32357: Set borrower_message_preferences.days_in_advance default to NULL To test: 1. prove t/db_dependent/cronjobs/advance_notices_digest.t 2. prove t/db_dependent/Letters/TemplateToolkit.t 3. prove t/db_dependent/Koha/CurbsidePickups.t 4. prove t/db_dependent/Koha/Patrons.t 5. prove t/db_dependent/Patron/Messaging.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 22:57:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 20:57:16 +0000 Subject: [Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 --- Comment #10 from David Nind --- Testing notes (using KTD): 1. Access the database: koha-mysql kohadev 2. Show the current database configuration - the default before the patch is applied for days_in_advance is 0. SQL query: show columns from borrower_message_preferences; 3. Apply the patch. 4. Update the database (updatedatabase). 5. Repeat steps 1-2 - the default for days_in_advance should now be NULL. 6. Tests should pass: . prove t/db_dependent/cronjobs/advance_notices_digest.t . prove t/db_dependent/Letters/TemplateToolkit.t . prove t/db_dependent/Koha/CurbsidePickups.t . prove t/db_dependent/Koha/Patrons.t . prove t/db_dependent/Patron/Messaging.t Note: the database update now updates the existing installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 23:00:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 21:00:17 +0000 Subject: [Koha-bugs] [Bug 33427] New: Managing individual users with access to subscriptions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33427 Bug ID: 33427 Summary: Managing individual users with access to subscriptions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: Koha.Bugz at treasury.govt.nz CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Suggested enhancement: For the new ERM module ... The ability to allocate individual patrons as having access to subscriptions which are logged in the ERM module with the ability to add and remove as those patrons needs change or they no longer require access. So functionality to not only manage the subscription/resource itself (licence/renewal) but who has access from within the participating organisation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 23:34:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 21:34:55 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ztajoli at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 5 23:45:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Apr 2023 21:45:12 +0000 Subject: [Koha-bugs] [Bug 30981] Add option to configure preferred pronouns as a pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30981 --- Comment #3 from Katrin Fischer --- (In reply to Lucas Gass from comment #2) > (In reply to Katrin Fischer from comment #0) > > This could work just like bsort1 and bsort2 for the statistic fields. We add > > a AV category that is emtpy, but once it is filled in, the pronouns field > > will show up as a pull down. While it's empty, it's a free text field. > > I just filed this Bug 33397, the way we add custom values can result in data > loss. True, and it would have been much easier to resolve if this had been fixed before the last release. But I still think having this optionally turned into an AV would be great. We could add a warning to the release notes or fix it 'right' from the beginning by adding a pull down value for a non-existing AV entry. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 05:47:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 03:47:26 +0000 Subject: [Koha-bugs] [Bug 33419] Make home branch mandatory by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 05:49:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 03:49:14 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 06:36:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 04:36:31 +0000 Subject: [Koha-bugs] [Bug 33378] OPAC advanced search limits and OPAC facets no longer correspond In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33378 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from David Cook --- (In reply to Katrin Fischer from comment #1) > Hi David, what do you mean by "facet won't be selected"? > > I don't remember the search requests having any effects on the facet > selections. After looking back on a few versions, it looks like you're right. To me, it would make sense that the limits from the advanced search would cause facets to be selected/checked/applied on the search results page but doesn't look like we've done that. It would be easy enough to do though... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 06:37:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 04:37:49 +0000 Subject: [Koha-bugs] [Bug 33376] Adding the option to modify/edit searches on the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33376 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from David Cook --- (In reply to Katrin Fischer from comment #2) > I was going to suggest the "Return to advanced search" for this feature. Is > there some functional difference to your local feature? The key difference is that "Edit search" applies for both basic searches and advanced searches. But you could argue that's unnecessary for a basic search since you can see everything you could when you made your basic search anyway. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 07:41:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 05:41:52 +0000 Subject: [Koha-bugs] [Bug 32399] Database update for bug 30483 is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32399 --- Comment #23 from Marcel de Rooy --- (In reply to Lucas Gass from comment #22) > (In reply to Marcel de Rooy from comment #21) > > Why wasn't this pushed to 22.05 yet ? > > I'm confused about this patch. It won't apply to 22.05 because the update is > directly in installer/data/mysql/atomicupdate/db_revs. > > Should it not be in 'installer/data/mysql/atomicupdate/atomicupdate' and the > Rmaints move it to db_revs? > > > Sorry for the confusion. Sure. Good plan! Dont wait any longer. This is a fix for something that was pushed to 22.05.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 07:43:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 05:43:26 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Marcel de Rooy --- Will have a look here soon. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 07:43:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 05:43:31 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:49:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 06:49:42 +0000 Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected DataTables configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 --- Comment #16 from Jonathan Druart --- Why do we have this in branches.tt only? We don't want to have one follow-up bug per table, we need to apply it from datatabase.js (or .inc or wherever, but in a single place). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:52:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 06:52:07 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32683 --- Comment #4 from Jonathan Druart --- Bug 32683 certainly caused this regression. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683 [Bug 32683] Convert header search tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:52:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 06:52:07 +0000 Subject: [Koha-bugs] [Bug 32683] Convert header search tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33422 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 [Bug 33422] ERM - Search header should change to match the section you are in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:54:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 06:54:54 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:54:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 06:54:56 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149221|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 149224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149224&action=edit Bug 33422: (bug 32728 follow-up) ERM - Update search header depending on navigation This patch removes reference to a non-existent id ("ui-id-X") and replaces it with new ids specific to agreements, titles and packages. Test plan: 1) Apply patch 2) Navigate between Agreements, Packages, Titles using the sidebar. The search bar should change each time to match the section 3) Add some agreemens, packages, titles 4) Perform a search using the different search bar options. Each time it should take you to the correct page with the search activated in the KohaTable. The navbar should also be highlighted to match the correct section and the top search bar should also show the correct section Signed-off-by: David Nind JD Amended commit message: link with 32728 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 08:55:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 06:55:23 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 --- Comment #6 from Jonathan Druart --- Not blocker - we should add tests for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:02:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:02:52 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Jonathan Druart --- Tested, and it does not work. % git --no-pager diff **/*.vue diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue index 5fee4862f17..a2bca463341 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue +++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue @@ -88,10 +88,12 @@ export default { toolbar_options: [ { to: "AgreementsFormAdd", - button_title: "New agreement", + button_title: "Here is a test string", }, ], + another_string: this.$__("Here is ANOTHER string"), } }, beforeRouteEnter(to, from, next) { next(vm => { % cd misc/translator % perl translate update fr-FR % git grep 'Here is .* string' misc/translator/po/fr-FR-* misc/translator/po/fr-FR-messages-js.po:msgid "Here is ANOTHER string" Matt, you are not supposed to add the string in the po file manually. What I meant previously is that the 'update' part of the translate process is picking the strings from the source code (tt, inc, js and vue files). To make it aware of the strings (and so new strings) you MUST use explicitly the __() function ($__() in vue files) If you didn't add the string manually in the po file then tell me which black magic you used ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:10:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:10:47 +0000 Subject: [Koha-bugs] [Bug 33428] New: Should only search in searchable patron attributes if searching in standard fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Bug ID: 33428 Summary: Should only search in searchable patron attributes if searching in standard fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Before patrons search using REST API, the search on patron attributes was only in standard fields. See Bug 18094 : Only search in searchable patron attributes if searching in standard fields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:11:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:11:51 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m --- Comment #1 from Fridolin Somers --- This creates strange behaviors for example when using search field surname and searching starts with one letter. Some results are matches on patron attributes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:12:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:12:02 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 [Bug 18094] Patron search filters are broken by searchable attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:12:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:12:02 +0000 Subject: [Koha-bugs] [Bug 18094] Patron search filters are broken by searchable attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 [Bug 33428] Should only search in searchable patron attributes if searching in standard fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:12:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:12:42 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3186 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:12:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:12:42 +0000 Subject: [Koha-bugs] [Bug 3186] invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3186 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33428 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:12:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:12:48 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3186 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:12:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:12:48 +0000 Subject: [Koha-bugs] [Bug 3186] invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3186 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33428 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:12:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:12:55 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31868 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:12:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:12:55 +0000 Subject: [Koha-bugs] [Bug 31868] Add search options for searchable patron attributes to pull down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31868 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33428 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:13:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:13:01 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31867 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:13:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:13:01 +0000 Subject: [Koha-bugs] [Bug 31867] Add note to DefaultPatronSearchFields that searchable patron attributes are always included In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31867 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33428 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:13:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:13:10 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32749 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:13:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:13:10 +0000 Subject: [Koha-bugs] [Bug 32749] Additional fields: Make searchable and display in result list separate attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32749 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33428 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:21:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:21:54 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:21:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:21:57 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149190|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 149225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149225&action=edit Bug 33381: Fix sidemenu active and hover styling Change router link active class match rule. This makes it so that the route erm/agreements/1 will also match the router-link /erm/agreements instead of the previous exact match rule, thus adding the 'current' class Update styling router-links to not apply 'current' styling when .disabled Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:22:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:22:36 +0000 Subject: [Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:22:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:22:38 +0000 Subject: [Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149097|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 149226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149226&action=edit Bug 33391: Prevent applying hover style on navmenulist currently active item * Apply patch * Run yarn css:build * Do the 2nd example above again and verify Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:22:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:22:46 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |pedro.amorim at ptfs-europe.co |com |m Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 09:30:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 07:30:45 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 --- Comment #2 from Fridolin Somers --- Ich How can we tell the searching is standard fields ? https://git.koha-community.org/Koha-community/Koha/src/commit/f74a353097710cf33b3b75b9912b2b00d2aa1a30/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc#L307 Using search_fields == 'firstname,middle_name,surname,othernames,cardnumber,userid' ? Looks not very strong to me :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 10:18:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 08:18:42 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 --- Comment #13 from Matt Blenkinsop --- Sorry, translations are new to me! I'll try again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 10:32:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 08:32:00 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 --- Comment #7 from Matt Blenkinsop --- I need to get used to Cypress so I can have a look at writing some tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 10:33:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 08:33:53 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #5 from Katrin Fischer --- Thanks Marcel, I tried, but I have run out of ideas and the code is a little complex. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 11:38:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 09:38:39 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 --- Comment #8 from Matt Blenkinsop --- Created attachment 149227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149227&action=edit Bug 33422: Add cypress test This patch adds a cypress test to check whether the "active" class is correctly updating when navigating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 12:40:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 10:40:24 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33429 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 [Bug 33429] Use template wrapper for breadcrumbs: Plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 12:40:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 10:40:24 +0000 Subject: [Koha-bugs] [Bug 33429] New: Use template wrapper for breadcrumbs: Plugins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 Bug ID: 33429 Summary: Use template wrapper for breadcrumbs: Plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update plugins templates so that they use the new template wrapper for breadcrumbs. - plugins-disabled.tt - plugins-home.tt - plugins-upload.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 12:56:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 10:56:49 +0000 Subject: [Koha-bugs] [Bug 33198] request.pl is calculating pickup locations that are not used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33198 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #5 from Laura Escamilla --- Can this be considered for backport? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 13:14:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 11:14:23 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141403|0 |1 is obsolete| | --- Comment #5 from Kevin Carnes --- Created attachment 149228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149228&action=edit Bug 31695: Type standard number is missing field ci_raw in field_config.yaml In Elasticsearch fields config field_config.yaml, default type as a field 'ci_raw'. This is used for exact search. This field is missing for type standard number 'stdno'. Test plan : 1) Use Elasticsearch search engine 2) For authorities, configure a search field with type 'standard number' 3) Go to authorities search 4) Perform a search on an existing value, with 'contains' => Result is found with or without patch 5) Perform a search on an existing value, with 'is exactly' => Result is found only with patch Signed-off-by: Kevin Carnes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 13:14:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 11:14:54 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149215|0 |1 is obsolete| | --- Comment #14 from Matt Blenkinsop --- Created attachment 149229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149229&action=edit Bug 33417: Fix translation in toolbar This commit allows the string to be translated - tested using fr-FR and a dummy string in the .po file Test plan as above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 13:15:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 11:15:10 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin.carnes at ub.lu.se Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 13:15:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 11:15:21 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 13:15:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 11:15:27 +0000 Subject: [Koha-bugs] [Bug 33429] Use template wrapper for breadcrumbs: Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 13:15:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 11:15:28 +0000 Subject: [Koha-bugs] [Bug 33429] Use template wrapper for breadcrumbs: Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 --- Comment #1 from Owen Leonard --- Created attachment 149230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149230&action=edit Bug 33429: Use template wrapper for breadcrumbs: Plugins This patch updates plugin management templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - In koha-conf.xml, look for "enable_plugins" - If this is set to 0, plugins are disabled: 0 - Navigate directly to /cgi-bin/koha/plugins/plugins-home.pl, which should say "Plugins disabled." Check the breadcrumbs on this page. - Enable plugins by changing the settimg in koha-conf.xml to 1 (a restart of services is required): 1 - Go to Administration -> Manage plugins - Test this page and the "Upload plugin" page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 13:15:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 11:15:55 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 13:19:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 11:19:20 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149228|0 |1 is obsolete| | --- Comment #6 from Kevin Carnes --- Created attachment 149231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149231&action=edit Bug 31695: Type standard number is missing field ci_raw in field_config.yaml In Elasticsearch fields config field_config.yaml, default type as a field 'ci_raw'. This is used for exact search. This field is missing for type standard number 'stdno'. Test plan : 1) Use Elasticsearch search engine 2) For authorities, configure a search field with type 'standard number' 3) Go to authorities search 4) Perform a search on an existing value, with 'contains' => Result is found with or without patch 5) Perform a search on an existing value, with 'is exactly' => Result is found only with patch Signed-off-by: Kevin Carnes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 13:30:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 11:30:24 +0000 Subject: [Koha-bugs] [Bug 33430] New: Suggestions.pl with several hundred items causes a slow loading screen Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Bug ID: 33430 Summary: Suggestions.pl with several hundred items causes a slow loading screen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The purchase suggestion management page take anywhere between 15-45 seconds to load if there are several hundred items in the suggestions table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 13:30:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 11:30:43 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 --- Comment #9 from Pedro Amorim --- These look good, some points for discussion: 1) Should we make this bug depend on bug 33408 and have these tests be written in that fashion? i.e. mock ERMModule sys pref. 2) Should we move Dialog_spec.ts and this new Searchbar_spec.ts into a single ERM/Common_spec.ts just for organization sake. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:01:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:01:38 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 --- Comment #10 from Jonathan Druart --- (In reply to Pedro Amorim from comment #9) > These look good, some points for discussion: > 1) Should we make this bug depend on bug 33408 and have these tests be > written in that fashion? i.e. mock ERMModule sys pref. > 2) Should we move Dialog_spec.ts and this new Searchbar_spec.ts into a > single ERM/Common_spec.ts just for organization sake. This (33422) should go first, as it's a bugfix. We will need to adjust the other bug on top of it. I would suggest ERM/Regressions_spec.ts, we have one "regressions" for selenium and it's good to group those small tests together IMO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:18:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:18:39 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119016|0 |1 is obsolete| | --- Comment #105 from Julian Maurice --- Created attachment 149232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149232&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The Koha::Patron::notice_email_address subroutine has been renamed to Koha::Patron::notice_email_addresses (plural). It only gets the patron emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1. Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2. Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3. Verify the email is correctly sent to the message_queue. 4. Fill the pref with email and emailpro (for instance) 5. Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6. You can also verify that only 1 notice is generated if the emailpro is empty. Important note for testers: Pending messages must be removed each time you change the value of AutoEmailPrimaryAddress. When there are already existing pending messages for a borrower, Koha tries to update them rather than enqueuing new ones, but it will not update the recipient's email address, nor add/remove messages depending on the new value of AutoEmailPrimaryAddress; not sure if this is a bug or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:18 +0000 Subject: [Koha-bugs] [Bug 31640] Fuzzy translations of preferences can cause missing sections and inaccurate translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:20 +0000 Subject: [Koha-bugs] [Bug 31640] Fuzzy translations of preferences can cause missing sections and inaccurate translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 --- Comment #15 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:22 +0000 Subject: [Koha-bugs] [Bug 32263] Capitalization: ...and on the Libraries page in the OPAC. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32263 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:25 +0000 Subject: [Koha-bugs] [Bug 32263] Capitalization: ...and on the Libraries page in the OPAC. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32263 --- Comment #4 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:27 +0000 Subject: [Koha-bugs] [Bug 33148] Use template wrapper for breadcrumbs: Cataloging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33148 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:29 +0000 Subject: [Koha-bugs] [Bug 33148] Use template wrapper for breadcrumbs: Cataloging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33148 --- Comment #6 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:31 +0000 Subject: [Koha-bugs] [Bug 33149] Use template wrapper for breadcrumbs: Circulation part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:32 +0000 Subject: [Koha-bugs] [Bug 33149] Use template wrapper for breadcrumbs: Circulation part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 --- Comment #5 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:34 +0000 Subject: [Koha-bugs] [Bug 33272] Color of the "(remove)" link when an item is in the cart (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:36 +0000 Subject: [Koha-bugs] [Bug 33272] Color of the "(remove)" link when an item is in the cart (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 --- Comment #5 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:38 +0000 Subject: [Koha-bugs] [Bug 33285] It should be possible to specify the separator used in runreport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:39 +0000 Subject: [Koha-bugs] [Bug 33285] It should be possible to specify the separator used in runreport.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285 --- Comment #11 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:41 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:43 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 --- Comment #10 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:45 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:30:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:30:47 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 --- Comment #11 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:13 +0000 Subject: [Koha-bugs] [Bug 27513] Add description to reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:16 +0000 Subject: [Koha-bugs] [Bug 27513] Add description to reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 --- Comment #8 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:17 +0000 Subject: [Koha-bugs] [Bug 31057] Add clarifying text to 'To date' in the calendar tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:19 +0000 Subject: [Koha-bugs] [Bug 31057] Add clarifying text to 'To date' in the calendar tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 --- Comment #8 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:21 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:23 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 --- Comment #18 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:25 +0000 Subject: [Koha-bugs] [Bug 32164] Add link to MARC modification templates from batch record modification page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32164 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:27 +0000 Subject: [Koha-bugs] [Bug 32164] Add link to MARC modification templates from batch record modification page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32164 --- Comment #5 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:29 +0000 Subject: [Koha-bugs] [Bug 33040] Add "Date published (text)" to serials tab on record view (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33040 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:31 +0000 Subject: [Koha-bugs] [Bug 33040] Add "Date published (text)" to serials tab on record view (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33040 --- Comment #5 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:33 +0000 Subject: [Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:34 +0000 Subject: [Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #15 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:36 +0000 Subject: [Koha-bugs] [Bug 33299] Item type column is empty when placing item level holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33299 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:38 +0000 Subject: [Koha-bugs] [Bug 33299] Item type column is empty when placing item level holds in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33299 --- Comment #5 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:40 +0000 Subject: [Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:52:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:52:42 +0000 Subject: [Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 --- Comment #5 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 14:58:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 12:58:26 +0000 Subject: [Koha-bugs] [Bug 32402] "Modification date" missing from OPAC Lists table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32402 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com --- Comment #5 from Tomås Cohen Arazi --- Please rebase ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:00:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:00:02 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Patch doesn't apply --- Comment #12 from Tomås Cohen Arazi --- Please rebase ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:03:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:03:49 +0000 Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:03:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:03:51 +0000 Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 --- Comment #18 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:03:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:03:54 +0000 Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:03:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:03:56 +0000 Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 --- Comment #12 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:03:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:03:58 +0000 Subject: [Koha-bugs] [Bug 30930] Ability to change authority type while editing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30930 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:03:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:03:59 +0000 Subject: [Koha-bugs] [Bug 30930] Ability to change authority type while editing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30930 --- Comment #7 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:04:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:04:01 +0000 Subject: [Koha-bugs] [Bug 31994] Clicking the next button of a DataTable loading its data from the HTML does nothing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31994 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:04:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:04:04 +0000 Subject: [Koha-bugs] [Bug 31994] Clicking the next button of a DataTable loading its data from the HTML does nothing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31994 --- Comment #12 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:04:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:04:06 +0000 Subject: [Koha-bugs] [Bug 32686] Specify action of action_logs entries to purge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32686 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:04:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:04:08 +0000 Subject: [Koha-bugs] [Bug 32686] Specify action of action_logs entries to purge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32686 --- Comment #10 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:19:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:19:25 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 --- Comment #13 from Matt Blenkinsop --- Looks like a conflict with bug 33309 which is avoiding a race condition - this would still call the indexer on each call to AddRenewal rather than skipping the individual indexing jobs and running one indexing job on the collected biblio ids. I don't think I can rebase in a way that doesn't involve deleting the intent of bug 33309 - looks like Nick wrote that bug and should be on the thread for this as he signed it off. Nick - Does this patch cover what you were trying to achieve with 33309 or do we need to combine them in some way? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:21:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:21:13 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:32:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:32:32 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Marius changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:32:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:32:37 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Marius changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131094|0 |1 is obsolete| | --- Comment #96 from Marius --- Created attachment 149233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149233&action=edit Bug 12532: Send email to guarantee and guarantor; This patch allows guarantors to receive emails sended to their guarentees. This patch is a rebase of the previous patches. NOTE: Attachment "Rebase and correction of the patch by adding the possibility of sending emails to several guarantors" generate an sha1 error. I had to took its content and put it in another commit. TO TEST: Before applying: 1) Search, or create, a patron with guarantor. 2) Enable checkout emails for both guarantors and guarantees. 3) Checkout an item. An email should be sent only to the guarantee. 4) Apply the patch. 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' 7) Run misc/cronjobs/process_message_queue.pl 8) Notice that the email should be sended to both the guarantee AND the guarantor. Everything works fine. Signed-off-by: Marius Mandrescu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:40:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:40:17 +0000 Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:40:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:40:19 +0000 Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 --- Comment #16 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:40:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:40:21 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:40:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:40:23 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 --- Comment #33 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:40:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:40:25 +0000 Subject: [Koha-bugs] [Bug 31615] Allow checkin of items bundles without verifying their contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:40:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:40:27 +0000 Subject: [Koha-bugs] [Bug 31615] Allow checkin of items bundles without verifying their contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 --- Comment #5 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:40:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:40:30 +0000 Subject: [Koha-bugs] [Bug 32510] "New list" option is not available when too many patron's lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32510 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:40:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:40:32 +0000 Subject: [Koha-bugs] [Bug 32510] "New list" option is not available when too many patron's lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32510 --- Comment #5 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:41:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:41:47 +0000 Subject: [Koha-bugs] [Bug 33431] New: Make code use C4::Context->yaml_preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Bug ID: 33431 Summary: Make code use C4::Context->yaml_preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:42:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:42:14 +0000 Subject: [Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30403, 23580 Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |ASSIGNED CC| |tomascohen at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23580 [Bug 23580] Add C4::Context->yaml_preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 [Bug 30403] Update notforloan status also on check out -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:42:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:42:14 +0000 Subject: [Koha-bugs] [Bug 23580] Add C4::Context->yaml_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23580 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33431 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 [Bug 33431] Make code use C4::Context->yaml_preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:42:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:42:14 +0000 Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33431 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 [Bug 33431] Make code use C4::Context->yaml_preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 15:50:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 13:50:21 +0000 Subject: [Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 --- Comment #7 from Katrin Fischer --- Please backport, this was originally spotted in 22.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 16:02:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 14:02:13 +0000 Subject: [Koha-bugs] [Bug 16544] Changes to circ rules should be logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16544 Juliet Heltibridle changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle at rcplib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 16:29:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 14:29:12 +0000 Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 --- Comment #17 from Tomås Cohen Arazi --- Created attachment 149234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149234&action=edit Bug 30403: (QA follow-up) Add new YAML syspref to about.pl Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 16:35:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 14:35:09 +0000 Subject: [Koha-bugs] [Bug 32399] Database update for bug 30483 is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32399 --- Comment #24 from Lucas Gass --- Created attachment 149235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149235&action=edit Bug 32399: [22.05.x] Remove FK constraints while changing columns -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 16:36:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 14:36:06 +0000 Subject: [Koha-bugs] [Bug 32399] Database update for bug 30483 is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32399 --- Comment #25 from Lucas Gass --- Marcel, Please have a look at the patch I added for 22.05.x and conform it is correct. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 16:45:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 14:45:11 +0000 Subject: [Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 16:45:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 14:45:13 +0000 Subject: [Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 --- Comment #1 from Tomås Cohen Arazi --- Created attachment 149236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149236&action=edit Bug 33431: Make C4::Circulation use C4::Context->yaml_preference This patch removes manual YAML handling for sysprefs in C4::Circulation. It also makes C4::Context->yaml_preference not warn when undef is retrieved from the sysprefs. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Circulation* => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 16:45:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 14:45:16 +0000 Subject: [Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 --- Comment #2 from Tomås Cohen Arazi --- Created attachment 149237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149237&action=edit Bug 33431: Make C4::Record use C4::Context->yaml_preference This patch makes what the title says. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Rec* => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 16:45:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 14:45:19 +0000 Subject: [Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 --- Comment #3 from Tomås Cohen Arazi --- Created attachment 149238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149238&action=edit Bug 33431: Fix remaining cases This patch tweaks three remaining cases, that are not covered by tests. To test: 1. Apply this patch 2. Make use of those places => SUCCESS: No behavior change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:01:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:01:01 +0000 Subject: [Koha-bugs] [Bug 33425] No notification when items don't import due to matching existing barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33425 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org --- Comment #2 from Andrew Fuerste-Henry --- +1 for accurate reporting of errors and complications! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:01:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:01:30 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #56 from Tomås Cohen Arazi --- Lari, are you still willing to work on this? Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:04:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:04:09 +0000 Subject: [Koha-bugs] [Bug 33432] New: Move a list of items from a record to an other Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33432 Bug ID: 33432 Summary: Move a list of items from a record to an other Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl It would be nice if a librarian could move a list of items (not only 1 item) from a record to an other. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:05:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:05:47 +0000 Subject: [Koha-bugs] [Bug 33397] Adding custom authorized values for bsort1/bsort2 can result in data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33397 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org --- Comment #1 from Andrew Fuerste-Henry --- The same is somewhat true of the ASORT values for acquisitions, though with the added wrinkle that those authorised values aren't automatically linked to a field like the BSORT ones. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:14:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:14:02 +0000 Subject: [Koha-bugs] [Bug 33429] Use template wrapper for breadcrumbs: Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 Andrew Auld changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld at ptfs-europe.com --- Comment #2 from Andrew Auld --- I notice that on the plugins-home page (page title Plugins > Tools > Koha), the breadcrumb is: home > Tools > Plugins But on the plugins-upload page (page title Upload plugin > Plugins > Tools > Koha), the breadcrumb is: home > Plugins > Upload plugins Is this what you intended? I wasn't able to test the 'plugins-disabled' page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:21:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:21:39 +0000 Subject: [Koha-bugs] [Bug 33433] New: Items with hourly loan periods fail to auto checkin Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33433 Bug ID: 33433 Summary: Items with hourly loan periods fail to auto checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Item types that have an hourly loan period (e.g. 22 hours) fail to be auto checked-in by their cron job. Once switched to a daily loan period, the auto check-ins resume as normal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:26:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:26:37 +0000 Subject: [Koha-bugs] [Bug 22018] Add an option to 'AllowEarlyRenewal' to enable users to renew before the autorenew date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22018 Daniel B. changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dbarden at cuyahogalibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:33:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:33:43 +0000 Subject: [Koha-bugs] [Bug 33158] Use template wrapper for authorized values and item types administration tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Andrew Auld changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:39:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:39:54 +0000 Subject: [Koha-bugs] [Bug 33395] Patron search results shows only overdues if patron has overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org --- Comment #1 from Andrew Fuerste-Henry --- I'm fairly certain this used to display both the checkout count and the overdue count when a patron had overdue items, but I don't have access to an older version on which to confirm this. It looks like bug 30063 (22.05) changed how patron search works, so maybe this behavior changed then? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:42:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:42:24 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:42:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:42:26 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149150|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:42:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:42:28 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149151|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:42:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:42:34 +0000 Subject: [Koha-bugs] [Bug 33395] Patron search results shows only overdues if patron has overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 --- Comment #2 from Andrew Fuerste-Henry --- Confirmed, this is a regression. The manual for 21.11 contains a screenshot of this screen: https://koha-community.org/manual/21.11/en/html/_images/patronsearchresults.png And here's the same from the latest manual: https://koha-community.org/manual/latest/en/html/_images/patronsearchresults.png -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:42:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:42:47 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 --- Comment #9 from Tomås Cohen Arazi --- Created attachment 149239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149239&action=edit Bug 33368: Extends borrowers.flags to bigint it's a int(11) which means its limit is 2^31 We have currently 29 permissions, there is only one remaining, at 31 permissions the permission system won't support a case where a patron has all permissions. Test plan: Don't apply this patch Add another permission INSERT INTO userflags (bit, flag, flagdesc, defaulton) VALUES (30, 'new permission 1', '', 0) ; Go to the interface, tick all the boxes select flags from borrowers where borrowernumber=5; => 2113928830 Remember: 2^31 2147483648 2^32 4294967296 Add another one INSERT INTO userflags (bit, flag, flagdesc, defaulton) VALUES (31, 'new permission 2', '', 0) ; Repeat the step before => boom CGI::Compile::ROOT::kohadevbox_koha_members_member_2dflags_2epl::member_2dflags_2epl(): DBI Exception: DBD::mysql::st execute failed: Out of range value for column 'flags' at row 1 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 Apply the patch, try again QA note: That's ofc not the best solution, but the easiest for now Signed-off-by: Nick Clemens Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:42:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:42:50 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 --- Comment #10 from Tomås Cohen Arazi --- Created attachment 149240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149240&action=edit Bug 33368: DBIC Signed-off-by: Nick Clemens Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:43:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:43:07 +0000 Subject: [Koha-bugs] [Bug 33395] Patron search results shows only overdues if patron has overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:43:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:43:29 +0000 Subject: [Koha-bugs] [Bug 33430] Suggestions.pl with several hundred items causes a slow loading screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:53:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:53:13 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 17:53:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 15:53:15 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 --- Comment #11 from Tomås Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 18:03:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 16:03:10 +0000 Subject: [Koha-bugs] [Bug 33434] New: Use template wrapper for breadcrumbs: Point of sale Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33434 Bug ID: 33434 Summary: Use template wrapper for breadcrumbs: Point of sale Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update point of sale templates so that they use the new template wrapper for breadcrumbs. - pos/pay.tt - pos/register.tt - pos/registers.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 18:03:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 16:03:10 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33434 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33434 [Bug 33434] Use template wrapper for breadcrumbs: Point of sale -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 18:05:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 16:05:22 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146922|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 149241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149241&action=edit Bug 33005: Use template wrapper for breadcrumbs: Acquisitions part 3 This patch updates several acquisitions-related templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Acquisitions -> -> All available funds table -> Ordered -> Spent -> Vendor -> Vendor details -> Uncertain prices -> Receive shipments (must have at least one open basket) -> If necessary, receive a new shipment. Or click an invoice number to reach the "receive orders" page. -> Click "Receive" in the table listing baskets. -> Basket -> Add to basket -> From a suggestion -> From an external source Signed-off-by: Andrew Auld -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 18:05:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 16:05:24 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147323|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 149242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149242&action=edit Bug 33005: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with Signed-off-by: Andrew Auld -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 18:06:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 16:06:06 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 Andrew Auld changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld at ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #5 from Andrew Auld --- All pages and links checked. Lovely! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 18:07:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 16:07:43 +0000 Subject: [Koha-bugs] [Bug 33395] Patron search results shows only overdues if patron has overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33395 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression --- Comment #3 from Caroline Cyr La Rose --- Thanks Andrew! I was pretty sure both were displayed before, but I didn't go the extra step... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 18:44:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 16:44:46 +0000 Subject: [Koha-bugs] [Bug 33435] New: We're missing sample dev data for ERM Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 Bug ID: 33435 Summary: We're missing sample dev data for ERM Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart+koha at gmail.com Depends on: 32030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 18:44:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 16:44:46 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 [Bug 33435] We're missing sample dev data for ERM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 18:45:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 16:45:32 +0000 Subject: [Koha-bugs] [Bug 33435] We're missing sample dev data for ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 18:45:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 16:45:35 +0000 Subject: [Koha-bugs] [Bug 33435] We're missing sample dev data for ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 --- Comment #1 from Pedro Amorim --- Created attachment 149243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149243&action=edit Bug 33435: Add sample ERM data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 18:48:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 16:48:45 +0000 Subject: [Koha-bugs] [Bug 33435] We're missing sample dev data for ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149243|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim --- Created attachment 149244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149244&action=edit Bug 33435: Add sample ERM data Apply patch run reset_all Check ERM module and verify it has data in it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 18:49:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 16:49:42 +0000 Subject: [Koha-bugs] [Bug 33435] We're missing sample dev data for ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 --- Comment #3 from Pedro Amorim --- Was not able to set erm_user_roles because by the time sample_erm_data.yml is imported, no patrons exist in the database yet. Any quick way around this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 18:50:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 16:50:25 +0000 Subject: [Koha-bugs] [Bug 33435] We're missing sample dev data for ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io, | |martin.renvoize at ptfs-europe | |.com, | |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 19:52:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 17:52:07 +0000 Subject: [Koha-bugs] [Bug 32627] Reprinting holds slips should not reset the expiration date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149148|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 149245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149245&action=edit Bug 32627: Calculate expirationdate relative to waitingdate Hold::set_waiting should calculate the MaxPickupDelay expiration date based on waitingdate rather than the current date, to avoid resetting the expirationdate on a hold that was already waiting. To test: 1. Place a hold and check in the item so the hold will be set to Waiting 2. Confirm that the expiration date is correct based on the ReservesMaxPickupDelay setting 3. Adjust your system clock to one day later 4. Check in the item again and confirm the hold 5. Note that the expiration date has changed 7. Apply patch and restart_all 8. Repeat steps 1-4. Confirm that the expiration date is calculated correctly, and does not change when the item is checked in again 9. Reset your system clock to the current date 10. Set ExcludeHolidaysFromMaxPickupDelay to Use the Calendar 11. Add an upcoming holiday to the calendar 12. Repeat steps 1-4. Confirm the expiration date correctly accounts for the holiday, and does not change when the item is checked in again Signed-off-by: Lucas Gass Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:28:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 18:28:28 +0000 Subject: [Koha-bugs] [Bug 33429] Use template wrapper for breadcrumbs: Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 --- Comment #3 from Owen Leonard --- There are some existing inconsistencies in the plugins breadcrumbs which stem from the conflict between Koha's division of "tool plugin" from "other plugin." My patch doesn't attempt to resolve this, it just replaces the markup around what is there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:36:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 18:36:35 +0000 Subject: [Koha-bugs] [Bug 33434] Use template wrapper for breadcrumbs: Point of sale In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33434 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:36:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 18:36:37 +0000 Subject: [Koha-bugs] [Bug 33434] Use template wrapper for breadcrumbs: Point of sale In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33434 --- Comment #1 from Owen Leonard --- Created attachment 149246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149246&action=edit Bug 33434: Use template wrapper for breadcrumbs: Point of sale This patch updates point of sale templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - If necessary, enable the EnablePointOfSale and UseCashRegisters system preferences. - If none are configured, define at least one register and at least one debit type by going to Administration -> Cash registers and Administration -> Debit types. - From the staff interface's user menu in the upper right of the header, choose "Set library and cash register." - Select a cash register. - Go to the Point of Sale page, and check the breadcrumbs on that page. - Check the "Transaction history for [register name]" and "Cash summary for [library] pages linked in the left-hand sidebar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:40:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 18:40:38 +0000 Subject: [Koha-bugs] [Bug 33436] New: Use template wrapper for breadcrumbs: Reports part 1 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 Bug ID: 33436 Summary: Use template wrapper for breadcrumbs: Reports part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several reports templates so that they use the new template wrapper for breadcrumbs. - reports/acquisitions_stats.tt - reports/bor_issues_top.tt - reports/borrowers_out.tt - reports/borrowers_stats.tt - reports/cash_register_stats.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:40:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 18:40:38 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 [Bug 33436] Use template wrapper for breadcrumbs: Reports part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:42:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 18:42:00 +0000 Subject: [Koha-bugs] [Bug 33430] Suggestions.pl with several hundred items causes a slow loading screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass --- For testing purposes in koha-testing-docker I wrote this. Definitely DO NOT add this to a production server: $('body').append(''); $('#makeSuggestions').click( function() { for (let i = 0; i < 100; i++) { let branches = ["CPL", "FFL","FPL","FRL","IPT","LPL","MPL","PVL","RPL","SPL","TPL","UPL"]; let random_branch = Math.floor(Math.random() * branches.length); let statuses = ["ASKED", "ACCEPTED", "REJECTED"]; let random_status = Math.floor(Math.random() * statuses.length); let random_title = (Math.random() + 1).toString(36).substring(2); $.ajax({ url: '/api/v1/suggestions', method: 'POST', data: JSON.stringify({ "title": random_title, "item_type": "BK", "suggested_by": Math.floor(Math.random() * 51), "suggestion_date": "2023-04-06", "timestamp": "2023-04-06T17:59:26+00:00", "managed_by": 51, "library_id": branches[random_branch], "status": statuses[random_status], }), contentType: 'application/json', success: function(result) { console.log('suggestion added'); }, }); } }); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:44:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 18:44:08 +0000 Subject: [Koha-bugs] [Bug 33437] New: Use template wrapper for breadcrumbs: Reports part 2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Bug ID: 33437 Summary: Use template wrapper for breadcrumbs: Reports part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more reports templates so that they use the new template wrapper for breadcrumbs. - reports/cat_issues_top.tt - reports/catalogue_out.tt - reports/catalogue_stats.tt - reports/dictionary.tt - reports/guided_reports_start.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:44:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 18:44:08 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33437 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:47:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 18:47:10 +0000 Subject: [Koha-bugs] [Bug 33438] New: Use template wrapper for breadcrumbs: Reports part 3 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 Bug ID: 33438 Summary: Use template wrapper for breadcrumbs: Reports part 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more reports templates so that they use the new template wrapper for breadcrumbs. - reports/issues_avg_stats.tt - reports/issues_stats.tt - reports/itemslost.tt - reports/itemtypes.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:47:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 18:47:10 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33438 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:47:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 18:47:53 +0000 Subject: [Koha-bugs] [Bug 33432] Move a list of items from a record to an other In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33432 --- Comment #1 from Katrin Fischer --- Hi Mathieu, can you describe the use case a little more? Do you want to have a barcode input field like we have for batch item edits or should the list be created otherwise? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:49:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 18:49:54 +0000 Subject: [Koha-bugs] [Bug 33439] New: Use template wrapper for breadcrumbs: Reports part 4 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 Bug ID: 33439 Summary: Use template wrapper for breadcrumbs: Reports part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more reports templates so that they use the new template wrapper for breadcrumbs. - reports/orders_by_budget.tt - reports/reports-home.tt - reports/reserves_stats.tt - reports/serials_stats.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 20:49:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 18:49:54 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 21:12:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 19:12:23 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #97 from David Nind --- I have tested (using koha-testing-docker), so that there is a sign-off from someone other than InLibro staff. It works, but I've failed QA because of the things under 'Notes from testing' - hopefully, once these are fixed the QA process should be easier! Test plan notes: 1. Add a guarantor to a patron (I added Mary Burton (23529000651225) as a guarantor to Lisa Charles (23529000197047)). 2. For each of the patrons: - Add an email address (I used two different email addresses) - Update the 'Patron messaging preferences' section so that an email is sent for item checkouts 3. To check the notices sent: [patron account] > Notices (can also check the database: koha-mysql kohadev the select * from message_queue;) 4. To run tests: prove t/db_dependent/Members.t and prove t/db_dependent/Letters.t 5. To test sending emails using a Google account, edit the /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where = your Google email address; = your APP password, not your Google account password - see Google Help on how to set up an app password): smtp.gmail.com 587 5 STARTTLS GOOGLEACCOUNTUSER GOOGLEAPPPASSWORD 1 Notes from testing: 1. There are whitespace errors when applying the patches. [1] 2. Formatting patch titles - these should be in the format Bug XXXX: The title for the patch AND Bug XXXX: (follow-up) The title for the follow-up (see https://wiki.koha-community.org/wiki/Commit_messages#Subject_line). 3. Patches with the same name - this can be confusing, but I'm not sure of the best way to do this for this bug. Also, as this bug has been around for a while, and has a bit of history, maybe the patches should be consolidated. I would ask on IRC to get expert advice on the best approach to take for this bug (maybe have the main patch, a patch for the database update, and a patch for test changes). 4. Running updatedatabase produced no output on the command line for me - normally it does. The way to do database updates changed a while ago, but I don't know enough about how this works to comment. Maybe ask on IRC or see https://wiki.koha-community.org/wiki/Database_updates However, the new system preference RedirectGuaranteeEmail appears for me. 5. Running the tests fail for: prove t/db_dependent/Members.t and prove t/db_dependent/Letters.t [2] 6. Comment #70 - not sure whether any of the issues raised have been addressed, or whether these should be addressed in a separate bug. [1] Applying the patch - whitespace error: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12532 - Send emails to guarantee and guarantor .git/rebase-apply/patch:35: trailing whitespace. unless ($to_address) { warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Letters.pm M Koha/Patron.pm M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref M t/db_dependent/Members.t .git/rebase-apply/patch:35: trailing whitespace. unless ($to_address) { warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Members.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging Koha/Patron.pm Auto-merging C4/Letters.pm Applying: Bug 12532 - (follow-up) clean up Applying: Bug 12532 - Correction of tests involving guarantorid Applying: Bug 12532: Send email to guarantee and guarantor; [2] Test output: prove t/db_dependent/Members.t t/db_dependent/Members.t .. 53/53 # Looks like you planned 53 tests but ran 57. t/db_dependent/Members.t .. Dubious, test returned 255 (wstat 65280, 0xff00) All 53 subtests passed Test Summary Report ------------------- t/db_dependent/Members.t (Wstat: 65280 Tests: 57 Failed: 4) Failed tests: 54-57 Non-zero exit status: 255 Parse errors: Bad plan. You planned 53 tests but ran 57. Files=1, Tests=57, 2 wallclock secs ( 0.02 usr 0.01 sys + 1.77 cusr 0.42 csys = 2.22 CPU) Result: FAIL prove t/db_dependent/Letters.t t/db_dependent/Letters.t .. 48/87 # Failed test 'SendAlerts is using the mocked send_or_die routine (claimissues)' # at t/db_dependent/Letters.t line 854. # didn't find a warning # expected to find warning: (?^u:Fake send_or_die) # Looks like you planned 14 tests but ran 2. # Looks like you failed 1 test of 2 run. # Failed test 'Test SMS handling in SendQueuedMessages' # at t/db_dependent/Letters.t line 923. Can't call method "letter_id" on an undefined value at t/db_dependent/Letters.t line 862. # Looks like your test exited with 11 just after 83. t/db_dependent/Letters.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 5/87 subtests Test Summary Report ------------------- t/db_dependent/Letters.t (Wstat: 2816 Tests: 83 Failed: 1) Failed test: 83 Non-zero exit status: 11 Parse errors: Bad plan. You planned 87 tests but ran 83. Files=1, Tests=83, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.74 cusr 0.34 csys = 2.10 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 21:17:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 19:17:47 +0000 Subject: [Koha-bugs] [Bug 33440] New: A public list can be transferred to a staff member without list permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33440 Bug ID: 33440 Summary: A public list can be transferred to a staff member without list permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl With the introduction of this bug, https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498, public lists can now be transferred to other staff. When testing this new feature, I was able to transfer a list a staff member without any list permissions. Once this transfer was successful, this staff member could edit the list, add and remove titles from this public list. The one thing this staff member (who had no permissions for lists) could not do was transfer the list to another person. I believe that this transfer option should only be allowed to staff with list permissions. Test Plan 1. Staff member A creates a public list. 2. Staff member A transfers this public list to another staff member (staff member b) without list permissions. 3. Staff Member B now has the ability to edit this public list and add/remove items from this list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 21:18:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 19:18:09 +0000 Subject: [Koha-bugs] [Bug 33440] A public list can be transferred to a staff member without list permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33440 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kelly at bywatersolutions.com |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 21:30:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 19:30:41 +0000 Subject: [Koha-bugs] [Bug 33441] New: SMTP server errors should have better logs in staff client Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33441 Bug ID: 33441 Summary: SMTP server errors should have better logs in staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: evelyn at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When using SMTP servers to send notices in Koha, if the sending fails there is an error message shown "Unhandled email failure, check the logs for further details". If the Koha is not hosted by the library, checking the server logs may not be possible. It would be beneficial to have at least the actual error code displayed to assist library staff with troubleshooting. This could be shown in the notices tab, centralized to the action logs, or a third option I haven't thought of yet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 6 22:07:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 20:07:57 +0000 Subject: [Koha-bugs] [Bug 33396] Link showing all courses in a particular department In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33396 --- Comment #2 from Tony Zbaraschuk --- (In reply to Katrin Fischer from comment #1) > Do you mean in the OPAC or in the staff interface? In the OPAC by preference, so that we can have links to "all courses in this department". We often get students taking multiple courses in the same department and this would be helpful for them. Having the same thing in staff mode would be nice, but not as important. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 00:14:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 22:14:36 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Authorities imported from |Authorities imported from |A3950 in encodings other |Z39.50 in encodings other |than UTF-8 are corrupted |than UTF-8 are corrupted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 01:36:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 23:36:41 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 --- Comment #17 from Hammat wele --- > What I wonder, is: will there always be enough time to locally complete the > downloading of the image before you remove the spinner? > Now you add the spinner by adding the class. And directly you check if there > is one visible image and you remove the spinner. (You could btw remove the > class again instead of the css change.) Hi Marcel, For the images with a src attribut already set in the html code ( images like localcover, CmazonCoverImages ...), they will have time to locally complete the downloading because of the `$(window).load` it will wait for all images to be load. But for the others they may not have enough time. I think it's better to just remove spinner by removing the "background-image", the class 'cover-slides' is used in opac.css file .cover-slides a.nav-active:visited {color: #85CA11;}, ( specially when we have severals images for the same notice). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 01:37:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 23:37:04 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 01:39:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 23:39:31 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 --- Comment #18 from Hammat wele --- Created attachment 149247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149247&action=edit Bug 32642: Loading spinner always visible when cover image is short (OPAC) We noticed that if the cover image is somewhat short (i.e. the height is under 80-90 px), the loading spinner indicating that the image is currently loading still appears after the image is loaded. this patch remove the spinner when the image is loaded,. To test: 1. Make sure the OPACLocalCoverImages system preference is enabled 1.1. Go to Administration > Global system preferences 1.2. Search for Coverimages 1.3. Set OPACLocalCoverImages to 'Show' 1.4. Click 'Save all Enhanced content preferences' 2. Add a short local cover image to a record (I added one which is just a grey rectangle with the size printed on it, to facilitate the test) 2.1. Download the attached image 2.2. Find a record without an image 2.3. Click the 'Images' tab 2.4. Click 'Upload' 2.5. Click 'Drop files here or click to select a file' and choose the downloaded image 2.6. Click 'Process images' 3. View the record in the OPAC 3.1. From the image upload page, click on the title of the record in the page heading to access the detailed record in the staff interface 3.2. Click on 'OPAC view: Open in new window.' --> Note that the image is displayed normally, but the spinner is also displayed 4. Apply the patch 5. View the record in the OPAC --> Note that the spinner is no more displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 01:42:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 23:42:28 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 --- Comment #19 from Hammat wele --- I've added a load event to check if images are completed and then the spinner is removed. this way the spinner is always removed once the image is complete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 01:42:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Apr 2023 23:42:42 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 03:36:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 01:36:40 +0000 Subject: [Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602 --- Comment #9 from David Nind --- Just checking whether the status for this bug should still be assigned or changed to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 03:45:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 01:45:52 +0000 Subject: [Koha-bugs] [Bug 33435] We're missing sample dev data for ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 03:45:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 01:45:55 +0000 Subject: [Koha-bugs] [Bug 33435] We're missing sample dev data for ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149244|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 149248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149248&action=edit Bug 33435: Add sample ERM data Apply patch run reset_all Check ERM module and verify it has data in it Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 03:51:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 01:51:51 +0000 Subject: [Koha-bugs] [Bug 33435] We're missing sample dev data for ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- (In reply to Pedro Amorim from comment #3) > Was not able to set erm_user_roles because by the time sample_erm_data.yml > is imported, no patrons exist in the database yet. Any quick way around this? For other bugs I have tested, if specific permissions are required then the test plan will normally say to set the specific permissions. Also, for most testing I use the koha user, and it has the super librarian permissions. Also, a great idea to add some sample ERM data! I was thinking the other day that having some sample data would make it much easier to test any ERM bugs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 04:10:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 02:10:16 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 04:10:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 02:10:19 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149247|0 |1 is obsolete| | --- Comment #20 from David Nind --- Created attachment 149249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149249&action=edit Bug 32642: Loading spinner always visible when cover image is short (OPAC) We noticed that if the cover image is somewhat short (i.e. the height is under 80-90 px), the loading spinner indicating that the image is currently loading still appears after the image is loaded. this patch remove the spinner when the image is loaded,. To test: 1. Make sure the OPACLocalCoverImages system preference is enabled 1.1. Go to Administration > Global system preferences 1.2. Search for Coverimages 1.3. Set OPACLocalCoverImages to 'Show' 1.4. Click 'Save all Enhanced content preferences' 2. Add a short local cover image to a record (I added one which is just a grey rectangle with the size printed on it, to facilitate the test) 2.1. Download the attached image 2.2. Find a record without an image 2.3. Click the 'Images' tab 2.4. Click 'Upload' 2.5. Click 'Drop files here or click to select a file' and choose the downloaded image 2.6. Click 'Process images' 3. View the record in the OPAC 3.1. From the image upload page, click on the title of the record in the page heading to access the detailed record in the staff interface 3.2. Click on 'OPAC view: Open in new window.' --> Note that the image is displayed normally, but the spinner is also displayed 4. Apply the patch 5. View the record in the OPAC --> Note that the spinner is no more displayed Signed-off-by: David Nind https://bugs.koha-community.org/show_bug.cgi?id=32624 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 04:12:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 02:12:14 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149249|0 |1 is obsolete| | --- Comment #21 from David Nind --- Created attachment 149250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149250&action=edit Bug 32642: Loading spinner always visible when cover image is short (OPAC) We noticed that if the cover image is somewhat short (i.e. the height is under 80-90 px), the loading spinner indicating that the image is currently loading still appears after the image is loaded. this patch remove the spinner when the image is loaded,. To test: 1. Make sure the OPACLocalCoverImages system preference is enabled 1.1. Go to Administration > Global system preferences 1.2. Search for Coverimages 1.3. Set OPACLocalCoverImages to 'Show' 1.4. Click 'Save all Enhanced content preferences' 2. Add a short local cover image to a record (I added one which is just a grey rectangle with the size printed on it, to facilitate the test) 2.1. Download the attached image 2.2. Find a record without an image 2.3. Click the 'Images' tab 2.4. Click 'Upload' 2.5. Click 'Drop files here or click to select a file' and choose the downloaded image 2.6. Click 'Process images' 3. View the record in the OPAC 3.1. From the image upload page, click on the title of the record in the page heading to access the detailed record in the staff interface 3.2. Click on 'OPAC view: Open in new window.' --> Note that the image is displayed normally, but the spinner is also displayed 4. Apply the patch 5. View the record in the OPAC --> Note that the spinner is no more displayed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 04:13:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 02:13:35 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149250|0 |1 is obsolete| | --- Comment #22 from David Nind --- Created attachment 149251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149251&action=edit Bug 32642: Loading spinner always visible when cover image is short (OPAC) We noticed that if the cover image is somewhat short (i.e. the height is under 80-90 px), the loading spinner indicating that the image is currently loading still appears after the image is loaded. this patch remove the spinner when the image is loaded,. To test: 1. Make sure the OPACLocalCoverImages system preference is enabled 1.1. Go to Administration > Global system preferences 1.2. Search for Coverimages 1.3. Set OPACLocalCoverImages to 'Show' 1.4. Click 'Save all Enhanced content preferences' 2. Add a short local cover image to a record (I added one which is just a grey rectangle with the size printed on it, to facilitate the test) 2.1. Download the attached image 2.2. Find a record without an image 2.3. Click the 'Images' tab 2.4. Click 'Upload' 2.5. Click 'Drop files here or click to select a file' and choose the downloaded image 2.6. Click 'Process images' 3. View the record in the OPAC 3.1. From the image upload page, click on the title of the record in the page heading to access the detailed record in the staff interface 3.2. Click on 'OPAC view: Open in new window.' --> Note that the image is displayed normally, but the spinner is also displayed 4. Apply the patch 5. View the record in the OPAC --> Note that the spinner is no more displayed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 04:16:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 02:16:47 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #23 from David Nind --- Apologies for the noise! I initially signed this bug off using the wrong bug number, and it added a link to Bugzilla at the end of the patch with the incorrect bug number. Ended up amending the commit message to remove that line, then reattached to the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 04:31:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 02:31:53 +0000 Subject: [Koha-bugs] [Bug 33304] Report schedule form time input element attribute type changed to improve valid time value entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 04:31:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 02:31:55 +0000 Subject: [Koha-bugs] [Bug 33304] Report schedule form time input element attribute type changed to improve valid time value entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148519|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 149252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149252&action=edit Bug 33304: Report schedule form time input element attribute type changed to improves valid time value entry I offer an enhancement for the task scheduler form: /cgi-bin/koha/tools/scheduler.pl via scheduler.tt The time input element currently has an 'text' value for type attribute. This requires a user to enter a valid time string for any scheduled report manually which is no fun. I have created patch in scheduler.tt that changes the type attribute value from 'text' to 'time' which makes the input of valid time easy. This change leveraged standard web form principles of html5 and would be compatible with any modern browser such as chrome, firefox and safari. To test: 1) login to koha instance 2) navigate to report module from home page 3) create test report with basic action and save. (no actual run of report is requires, simply need to save with valid syntax) ... SELECT id FROM biblio_metadata LIMIT 1 ... 4) Press 'Schedule' icon from nav options 5) Enter relevant time value for schedule in 'time' input element which now has type 'time' attribute 3.00 pm, added easily. 6) Enter valid future date 7) Enter valid email address and press 'Save' 8) SIGN OFF Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 04:32:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 02:32:33 +0000 Subject: [Koha-bugs] [Bug 33304] Report schedule form time input element attribute type changed to improve valid time value entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- This is a great idea! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:16:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 06:16:16 +0000 Subject: [Koha-bugs] [Bug 32399] Database update for bug 30483 is failing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32399 --- Comment #26 from Marcel de Rooy --- (In reply to Lucas Gass from comment #25) > Marcel, > > Please have a look at the patch I added for 22.05.x and conform it is > correct. > > Thanks! Looks fine to me. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:36:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 06:36:25 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:36:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 06:36:27 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 --- Comment #3 from David Nind --- Created attachment 149253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149253&action=edit Bug 33335: Fix JavaScript error on the MARC overlay rules page The "MARC overlay rules" page doesn't display or work correctly if a patron category code contains a "-". This happens because of the JavaScript function in "marc-overlay-rules.tt" line 469. This causes an error "Uncaught SyntaxError: missing : after property id". Test plan: 1. Go to Administration > Patron categories. 2. Make sure you don't have a patron category code that contains a "-". 3. Go to Administration > Record overlay rules. 4. The table should display correctly, and you can add, edit and delete rules. 5. Return to Patron categories. 6. Add a new patron category with a "-" in the patron category code. 7. Return to Record overlay rules page: => The page doesn't display and load correctly (see the attached image) - the normal DataTables header and footer aren't displayed, and you can't add, edit or delete overlay rules. => If you turn on web developer tools, an error is displayed in the console: "Uncaught SyntaxError: missing : after property id". 8. Apply the patch. 9. Repeat the step 7, the Record overlay rules page should now display correctly and you should be able to add, edit and delete rules. 10. Sign off. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:41:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 06:41:48 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Attachment #148841|0 |1 is obsolete| | --- Comment #4 from David Nind --- Comment on attachment 148841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148841 Bug 33335: fix marc overlay rules accept '-' I have edited the commit message to include the test plan - feel free to update if I haven't covered it correctly. Normally, the commit message should include the test plan - see https://wiki.koha-community.org/wiki/Commit_messages Also, I'm not sure what I did when I signed off, for some reason the original patch wasn't obsoleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 08:43:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 06:43:01 +0000 Subject: [Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33335 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |marius.mandrescu at inlibro.co |ity.org |m --- Comment #5 from David Nind --- I have changed the assignee to Marius. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 09:02:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 07:02:34 +0000 Subject: [Koha-bugs] [Bug 33431] Make code use C4::Context->yaml_preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33431 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- The tests for the first two patches pass, both before and after the patches are applied. I'm not sure for the third patch what features/things to test to make sure they work as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 09:08:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 07:08:51 +0000 Subject: [Koha-bugs] [Bug 33442] New: Messages: OPAC user cannot remove it ? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33442 Bug ID: 33442 Summary: Messages: OPAC user cannot remove it ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org If I read the message, I would like to remove it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 09:27:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 07:27:07 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 09:28:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 07:28:12 +0000 Subject: [Koha-bugs] [Bug 33442] Messages: OPAC user cannot remove it ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33442 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Marcel de Rooy --- *** This bug has been marked as a duplicate of bug 12029 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 09:28:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 07:28:12 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #74 from Marcel de Rooy --- *** Bug 33442 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 09:28:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 07:28:52 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #75 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #74) > *** Bug 33442 has been marked as a duplicate of this bug. *** Nice to see this one :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 10:33:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 08:33:25 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 10:43:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 08:43:17 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #19 from Jonathan Druart --- Created attachment 149254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149254&action=edit Bug 33408: Store sysprefs in a new ERM store We need the sysprefs' values to be shared between the components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 10:45:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 08:45:12 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #20 from Jonathan Druart --- There were 2 components using the erm_providers js variable from the .tt We need to store the values to make them reusable from other components. I am not 100% happy with this patch, there is certainly something to improve, for instance we should not need two variables here: + this.ERMStore.providers = providers.value.split(",") + this.providers = this.ERMStore.providers But here is a quick fix to restore the feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 10:48:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 08:48:38 +0000 Subject: [Koha-bugs] [Bug 33443] New: The "X titles/packages found locally" only displayed when we click the submit button Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 Bug ID: 33443 Summary: The "X titles/packages found locally" only displayed when we click the submit button Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com When you are in the EBSCO package or title list view, and you start a new search, there is a link to the local data: "X titles found locally" or "X packages found locally". However if you are landing into this package with some filters in the URL, the link to local eholdings is not displayed. /cgi-bin/koha/erm/eholdings/ebsco/titles?publication_title=art for instance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 10:52:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 08:52:17 +0000 Subject: [Koha-bugs] [Bug 33443] The "X titles/packages found locally" only displayed when we click the submit button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33408 --- Comment #1 from Jonathan Druart --- This is not caused by bug 33408 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 10:52:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 08:52:17 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33443 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 10:52:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 08:52:33 +0000 Subject: [Koha-bugs] [Bug 33443] The "X titles/packages found locally" only displayed when we click the submit button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33066 --- Comment #2 from Jonathan Druart --- We should build this fix on top of bug 33066. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 [Bug 33066] We need a KohaTable Vue component -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 10:52:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 08:52:33 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33443 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 [Bug 33443] The "X titles/packages found locally" only displayed when we click the submit button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 10:58:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 08:58:50 +0000 Subject: [Koha-bugs] [Bug 33443] The "X titles/packages found locally" only displayed when we click the submit button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 --- Comment #3 from Jonathan Druart --- I am... actually seeing it now (?) Race condition? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:02:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:02:07 +0000 Subject: [Koha-bugs] [Bug 33443] The "X titles found locally" not displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33408 | Depends on|33066 |32939 Status|NEW |ASSIGNED Summary|The "X titles/packages |The "X titles found |found locally" only |locally" not displayed |displayed when we click the | |submit button | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 [Bug 32939] Have generic fetch functions in vue modules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 [Bug 33066] We need a KohaTable Vue component -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:02:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:02:07 +0000 Subject: [Koha-bugs] [Bug 32939] Have generic fetch functions in vue modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33443 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 [Bug 33443] The "X titles found locally" not displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:02:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:02:07 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33443 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 [Bug 33443] The "X titles found locally" not displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:02:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:02:07 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33443 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:03:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:03:50 +0000 Subject: [Koha-bugs] [Bug 33443] The "X titles found locally" not displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:03:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:03:52 +0000 Subject: [Koha-bugs] [Bug 33443] The "X titles found locally" not displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 --- Comment #4 from Jonathan Druart --- Created attachment 149255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149255&action=edit Bug 33443: Restore "X titles found locally" link from EBSCO title list The link is missing, and there was a JS error in the console Uncaught (in promise) ReferenceError: filters is not defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:06:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:06:04 +0000 Subject: [Koha-bugs] [Bug 33443] The "X titles found locally" not displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 --- Comment #5 from Jonathan Druart --- and... I think this is fixed by bug 33066. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:33:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:33:07 +0000 Subject: [Koha-bugs] [Bug 33360] process_message_queue: Should limit parameter look at recipient domain? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:33:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:33:09 +0000 Subject: [Koha-bugs] [Bug 33360] process_message_queue: Should limit parameter look at recipient domain? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #1 from Marcel de Rooy --- Created attachment 149256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149256&action=edit Bug 33360: Add Koha::Notice::Util for mail domain limits Includes unit test. Test plan: Run t/db_dependent/Koha/Notice_Util.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:33:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:33:12 +0000 Subject: [Koha-bugs] [Bug 33360] process_message_queue: Should limit parameter look at recipient domain? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #2 from Marcel de Rooy --- Created attachment 149257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149257&action=edit Bug 33360: Extend Koha::Notice::Util with domain groups -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:33:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:33:14 +0000 Subject: [Koha-bugs] [Bug 33360] process_message_queue: Should limit parameter look at recipient domain? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #3 from Marcel de Rooy --- Created attachment 149258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149258&action=edit Bug 33360: Incorporate Koha::Notice::Util in Letters:SendQueuedMessages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:33:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:33:45 +0000 Subject: [Koha-bugs] [Bug 33360] process_message_queue: Should limit parameter look at recipient domain? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:34:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:34:35 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|process_message_queue: |SendQueuedMessages: Improve |Should limit parameter look |limit behavior and add |at recipient domain? |domain limits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:36:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:36:24 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #4 from Marcel de Rooy --- This is still work in progess. I stumbled over the where parameter now while converting stuff to a Koha object search. Not sure if we resolved such a thing somewhere else already. Could we automatically convert an old school SQL WHERE condition to correct Koha object/DBIx conditions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:41:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:41:33 +0000 Subject: [Koha-bugs] [Bug 31453] Add ability to filter messages to process using process_message_queue.pl via a command line parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31453 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #8 from Marcel de Rooy --- I am stumbling over this while doing changes in SendQueuedMessages on bug 33360. I would need to convert the SQL condition into DBIx constructs since I am switching to a Koha object search instead of calling get_unsent_messages. Any clues how to resolve that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:41:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:41:53 +0000 Subject: [Koha-bugs] [Bug 31453] Add ability to filter messages to process using process_message_queue.pl via a command line parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31453 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33360 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:41:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:41:53 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31453 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:46:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:46:24 +0000 Subject: [Koha-bugs] [Bug 31453] Add ability to filter messages to process using process_message_queue.pl via a command line parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31453 --- Comment #9 from Marcel de Rooy --- marcelr: 33360 - see misc/cronjobs/membership_expiry.pl:199 $upcoming_mem_expires = $upcoming_mem_expires->search( \$where_literal ) if @where; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 11:46:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 09:46:40 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #5 from Marcel de Rooy --- marcelr: 33360 - see misc/cronjobs/membership_expiry.pl:199 $upcoming_mem_expires = $upcoming_mem_expires->search( \$where_literal ) if @where; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:02:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 10:02:00 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #6 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #5) > marcelr: 33360 - see misc/cronjobs/membership_expiry.pl:199 > $upcoming_mem_expires = $upcoming_mem_expires->search( \$where_literal ) if > @where; Yes, that would be enough! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 12:02:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 10:02:41 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #7 from Marcel de Rooy --- Still patches forthcoming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:48:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 11:48:55 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:48:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 11:48:58 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148338|0 |1 is obsolete| | Attachment #148339|0 |1 is obsolete| | Attachment #148340|0 |1 is obsolete| | Attachment #148341|0 |1 is obsolete| | Attachment #148342|0 |1 is obsolete| | Attachment #148343|0 |1 is obsolete| | Attachment #148344|0 |1 is obsolete| | Attachment #148345|0 |1 is obsolete| | Attachment #148346|0 |1 is obsolete| | Attachment #148347|0 |1 is obsolete| | Attachment #148348|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart --- Created attachment 149259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149259&action=edit Bug 32334: Exceptions - Add parameter to WrongParameter Test plan: Run t/Koha/Exceptions.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:49:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 11:49:01 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 --- Comment #44 from Jonathan Druart --- Created attachment 149260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149260&action=edit Bug 32334: Add general exception FileNotFound No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:49:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 11:49:04 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 --- Comment #45 from Jonathan Druart --- Created attachment 149261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149261&action=edit Bug 32334: Introduce Koha::Database::Commenter Test plan: [1] Make a backup of your database. Just for precaution. [2] Run t/db_dependent/Koha/Database/Commenter.t. * Note: This test script adds and removes a test table. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:49:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 11:49:08 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 --- Comment #46 from Jonathan Druart --- Created attachment 149262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149262&action=edit Bug 32334: Add sync_db_comments script Test plan: [1] Backup your database, if not done already. [2] Check output of dry_run when clearing a table: misc/maintenance/sync_db_comments.pl -clear -table items -dry [3] Save output of misc/devel/update_dbix_class_files before changing comments in order to compare later. (Commit your changes.) You may not have changes after running (at least on a fresh database). That's fine. [4] Clear all comments: misc/maintenance/sync_db_comments.pl -clear [5] Renumber all comments: misc/maintenance/sync_db_comments.pl -renum [6] Reset all comments to schema. Make sure that script finds your structure in installer/data/mysql folder. misc/maintenance/sync_db_comments.pl -reset [7] Run update_dbix_class_files again and inspect changes as compared to previous run. Can you explain them? You should only see changes related to column comments. If you did not have changes in step 3, you should not have them here too. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:49:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 11:49:10 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 --- Comment #47 from Jonathan Druart --- Created attachment 149263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149263&action=edit Bug 32334: (QA follow-up) Force mutual exclusiveness of cmdline flags Test plan: Run sync_db_comments.pl --clear --renumber Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:49:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 11:49:13 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 --- Comment #48 from Jonathan Druart --- Created attachment 149264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149264&action=edit Bug 32334: (QA follow-up) Invert dry run mode to commit parameter Note: This is only done (and 'needed') for the command line, not for the module subroutines. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:49:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 11:49:16 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 --- Comment #49 from Jonathan Druart --- Created attachment 149265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149265&action=edit Bug 32334: (QA follow-up) Remove unused modules Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:49:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 11:49:19 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 --- Comment #50 from Jonathan Druart --- Created attachment 149266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149266&action=edit Bug 32334: (QA follow-up) Remove fh and verbose parameter in favor of messages The module returns messages. The script can print them in verbose mode. Test script adjusted accordingly. Test plan: Run t/db_dependent/Koha/Database/Commenter.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:49:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 11:49:22 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 --- Comment #51 from Jonathan Druart --- Created attachment 149267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149267&action=edit Bug 32334: (QA follow-up) Improve finding schema file Adds a schema parameter to the cmdline script now too. Test plan: Run sync_db_comments.pl with -schema file where file does not exist. (On dev install) rename kohastructure.sql, try with[out] referring to it using -schema. You could also use the standard path intranet/cgi-bin/installer/data/mysql. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:49:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 11:49:26 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 --- Comment #52 from Jonathan Druart --- Created attachment 149268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149268&action=edit Bug 32334: (follow-up) Fix for bug 31028, introducing IF NOT EXISTS We need to expect CREATE TABLE IF NOT EXISTS now in kohastructure. Test plan: Run misc/maintenance/sync_db_comments.pl -reset Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:49:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 11:49:29 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 --- Comment #53 from Jonathan Druart --- Created attachment 149269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149269&action=edit Bug 32334: (follow-up) Improvement for schema parameter Essentially only adds a warn, some cosmetic changes too. Test plan: Copy your kohastructure to xx.sql. Run sync_db_comments.pl -schema xx.sql. You will see usage. Run sync_db_comments.pl -schema xyz.sql. You will see a warn and the usage statement. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 13:49:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 11:49:31 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 --- Comment #54 from Jonathan Druart --- Created attachment 149270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149270&action=edit Bug 32334: Fix spelling Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:07:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 12:07:32 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #27 from Nick Clemens --- Created attachment 149271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149271&action=edit Bug 30579: (follow-up) Update form checker for each form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:15:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 12:15:20 +0000 Subject: [Koha-bugs] [Bug 26573] Limit patron attribute types to more than one patron category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26573 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #18 from Laura Escamilla --- Marking as "Patch doesn't apply" per Benjamin's comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:23:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 12:23:13 +0000 Subject: [Koha-bugs] [Bug 33396] Link showing all courses in a particular department In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33396 --- Comment #3 from Katrin Fischer --- Hi Tony, thx for clarifying, it's always good to get some insight into use cases and such. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:36:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 12:36:33 +0000 Subject: [Koha-bugs] [Bug 33436] Use template wrapper for breadcrumbs: Reports part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:36:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 12:36:36 +0000 Subject: [Koha-bugs] [Bug 33436] Use template wrapper for breadcrumbs: Reports part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 --- Comment #1 from Owen Leonard --- Created attachment 149272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149272&action=edit Bug 33436: Use template wrapper for breadcrumbs: Reports part 1 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Acquisitions statistics - Results - Patrons with the most checkouts - Results - Patrons who haven't checked out - Results - Patron statistics wizard - Results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:39:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 12:39:44 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #21 from Laura Escamilla --- After applying the patch I was unable to create a new patron. I received the message, "The following fields are wrong. Please fix them." even though all the required fields were completed and no fields were being marked as incorrect. Even after filling in all the optional fields the patron could still not be created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 14:49:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 12:49:27 +0000 Subject: [Koha-bugs] [Bug 29566] Convert bundle contents modal to a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |Laura.escamilla at bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:04:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:04:35 +0000 Subject: [Koha-bugs] [Bug 28658] With SearchMyLibraryFirst if library isn't set for the opac, try to guess it by checking branchip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #5 from Laura Escamilla --- Hi Michael, The dependency bug, Bug 28657, still does not apply cleanly to master. Auto-merging C4/Auth.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 28657: expand branches.branchip to allow for multiple ip ranges. [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-28657-expand-branchesbranchip-to-allow-for-mul-gxoeH0.patch Cannot apply cleanly patches from bug 28657. Everything will be left dirty. I'm going to mark this bug as blocked again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:09:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:09:14 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:09:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:09:16 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148780|0 |1 is obsolete| | Attachment #148781|0 |1 is obsolete| | --- Comment #22 from Nick Clemens --- Created attachment 149273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149273&action=edit Bug 23486: Set lastseen to default to current timestamp Generally, a patron is not registered without some action from the patron Defaulting the lastseen upon creation seems a reasonable way to set the initial value. This patch also makes the column NOT NULL to avoid any future data issues. To handle any currently NULL, we either set them to dateenrolled, or updated_on - the latter is already NOT NULL so is the bast fallback we have (assuming patron was also seen when they were updated) TO test: Apply patches Update database Create a patron Check their lastseen date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:09:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:09:19 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #23 from Nick Clemens --- Created attachment 149274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149274&action=edit Bug 23486: DO NOT PUSH - Schema updates Note that the fields must be manually updated after generation as generated syntax us invalid: default_value: 'current_timestamp()' First occurence: default_value: 'current_timestamp' Second occurence: default_value => \"current_timestamp", -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:11:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:11:27 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:11:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:11:29 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149126|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 149275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149275&action=edit Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 This patch updates several patron templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Patrons -> - Patron details - Notices - Accounting - Edit patron - Add patron - Patrons requesting modification (submit patron update via the OPAC) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:33:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:33:01 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Tomås Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:40:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:40:59 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:41:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:41:01 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145186|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 149276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149276&action=edit Bug 32013: Autorenewal batch indexing The automatic_renewals.pl cron script currently loops through items for automatic renewal and calls the indexer for each one individually. skip_record_index has now been added as a parameter to the AddRenewal function to skip the indexing process. The item numbers are now added to an array and then the indexer is called once from within automatic_renewals.pl and passed the array to queue one indexing job instead of multiple jobs. Test plan: 1) AddRenewal uses Koha::Items->store() to trigger the indexing process. Run prove -vv t/db_dependent/Koha/SearchEngine/Indexer.t and check tests 5,6,29,30. These tests prove whether passing skip_record_index to store() triggers or skips the indexing process. All four tests should pass to show that skip_index_records can prevent the indexing being triggered. 2) Add multiple renewals that are able to be autorenewed and run the automatic_renewals.pl script. There should be multiple items queued in zebraqueue. 3) Apply patch and try again 4) There should now only be one job queued in zebraqueue Mentored-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:41:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:41:03 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145187|0 |1 is obsolete| | --- Comment #15 from Nick Clemens --- Created attachment 149277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149277&action=edit Bug 32013: (follow-up) Add unit test A unit test has been added to show the pass-through of skip_record_index from AddRenewal() to the Item->store() method. Test plan: 1) In the shell run prove -vv t/db_dependent/Koha/SearchEngine/Indexer.t 2) Observe Subtest 3: Test AddRenewal indexer call 3) All four tests should pass Mentored-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:41:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:41:05 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145188|0 |1 is obsolete| | --- Comment #16 from Nick Clemens --- Created attachment 149278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149278&action=edit Bug 32013: (QA follow-up) Move mock to avoid warns from sample data creation Mentored-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:41:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:41:07 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 --- Comment #17 from Nick Clemens --- Created attachment 149279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149279&action=edit Bug 32013: Adjust unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:42:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:42:01 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 --- Comment #18 from Nick Clemens --- (In reply to Matt Blenkinsop from comment #13) > Nick - Does this patch cover what you were trying to achieve with 33309 or > do we need to combine them in some way? I think leaving the check I added, and moving your check down to the new section afterward seems to work - can you and Martin give my updates a once over? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 15:43:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 13:43:24 +0000 Subject: [Koha-bugs] [Bug 33444] New: AddRenewal should take a hash of parameters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33444 Bug ID: 33444 Summary: AddRenewal should take a hash of parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The routine (after bug 32013) now takes 9 parameters - this is unsustainable as a list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 16:25:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 14:25:59 +0000 Subject: [Koha-bugs] [Bug 33158] Use template wrapper for authorized values and item types administration tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 17:00:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 15:00:28 +0000 Subject: [Koha-bugs] [Bug 33444] AddRenewal should take a hash of parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33444 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 17:00:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 15:00:30 +0000 Subject: [Koha-bugs] [Bug 33444] AddRenewal should take a hash of parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33444 --- Comment #1 from Nick Clemens --- Created attachment 149280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149280&action=edit Bug 33444: Update AddRenewal to take a hashref of params -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 17:01:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 15:01:09 +0000 Subject: [Koha-bugs] [Bug 33444] AddRenewal should take a hash of parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33444 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Depends on| |32013 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 17:01:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 15:01:09 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33444 [Bug 33444] AddRenewal should take a hash of parameters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 17:31:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 15:31:34 +0000 Subject: [Koha-bugs] [Bug 33445] New: Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Bug ID: 33445 Summary: Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P3 Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: phil at chetcolibrary.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl, martin.renvoize at ptfs-europe.com, thibaud.guillot at biblibre.com Depends on: 29173 There are two steps to cataloguing/z3950_auth_search.pl - load it without op=do_search and it inserts the value from any params that match a form field name into the form and displays the form, or load it with op=do_search, and it searches for the values from params that match form field names and displays the results. Bug 29173 implemented prefilling the form for the case where you are coming from an authority detail view rather than an authority editor by looking up the existing authority record, and inserting values from it into the variables holding the input params. It does that in both the first step (overwriting changes you've made in the editor) and also in the do_search step, overwriting what you put in the search form with the data from the existing stored authority record. Steps to reproduce: 1. Find and edit any existing corporate name, personal name, subject or uniform title authority which will have results from the Z39.50 server you're going to search. For a usable ktd data and Library of Congress Names server example, use Smith, Bessie, 1894-1937. 2. In the editor, note what's in the main entry field's subfield a (Smith, Bessie) 3. Replace subfield a's contents with something different, like your own name 4. Click "Replace record via Z39.50/SRU search" 5. Note that rather than what you put in, the form field is filled with what the record originally had 6. Replace it with your name again, this time in the search form, select the server to search, and click Search 7. Note that the results are for what was originally in the record, not what you put in the form There are two cases where that makes replace via Z39.50 unusable: when you need something different than the original, like after a change in heading or when your existing record passed through an encoding error and you need to turn Gùomez, Hùector Carlos into Gómez, Héctor Carlos, and cases where just the subfield a is not enough to distinguish, like searching for Smith, John when you want Smith, John, Jr., -1853 who appears on page 39 of the results. Oh, and any name for UNIMARC, since subfield a is only the surname. A very good start to fixing this would be to revert bug 29173 from 22.11, 22.05, and 21.11, since this feature is now broken back to oldoldstable. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 17:31:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 15:31:34 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 18:15:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 16:15:29 +0000 Subject: [Koha-bugs] [Bug 30013] Limit/throttle/retry SMTP connections In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #4 from Liz Rea --- This also happens when using google as a provider of smtp. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 18:33:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 16:33:14 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #10 from Lucas Gass --- Created attachment 149281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149281&action=edit Bug 16122: Add localuse column to items and deleteditems -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 18:51:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 16:51:35 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #11 from Lucas Gass --- Created attachment 149282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149282&action=edit Bug 16122: API and Schema updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 18:58:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 16:58:09 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #12 from Lucas Gass --- Created attachment 149283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149283&action=edit Bug 16122: Increment items.localuse in AddReturn -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 19:06:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 17:06:24 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #13 from Lucas Gass --- Created attachment 149284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149284&action=edit Bug 16122: Add display to holdings/otherholdings and Table settings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 19:06:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 17:06:46 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |lucas at bywatersolutions.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 19:06:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 17:06:53 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 19:14:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 17:14:45 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #14 from Lucas Gass --- I've added some patches that will add an items.localuse column to the items table and also display this in the holdings/other holdings table. Leaving as assigned as this will still need adjusted/updated tests. Not sure how to deal with the information that is already available via statistics. I really think we should leave the statistics table as is. However we may need a script or DB update that will make the new items.localuse column congruent with what can be derived from statistics. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:09:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:09:08 +0000 Subject: [Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:09:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:09:10 +0000 Subject: [Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148662|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 149285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149285&action=edit Bug 33332: Fix formatting of TT comments to improve translations This patch reformats some Template::Toolkit multi-line comments in html_helpers.inc so that each line is commented separately. This seems to prevent the translation tool from putting the comments into the po file. To test, apply the patch and confirm that pages which use the breadcrumbs and tabs WRAPPER directives still work correctly: - Breadcrumbs: staff client home page, about page, error page. - Tabs: Administration -> Library transfer limits or circulation alerts. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that there is no instance of something like "[%%# BOOTSTRAP BREADCRUMBS WRAPPER USAGE" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:09:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:09:39 +0000 Subject: [Koha-bugs] [Bug 33367] tmp/modified_authorities/README.txt seems useless In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9988 CC| |phil at chetcolibrary.org --- Comment #2 from Phil Ringnalda --- It's been 6 years, probably nobody doing a git checkout of 23.05 on top of a 16.11 will expect their pending dontmerge file to survive anyway :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 [Bug 9988] Leave larger authority merges to merge_authorities cronjob (pref AuthorityMergeLimit) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:09:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:09:39 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob (pref AuthorityMergeLimit) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33367 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 [Bug 33367] tmp/modified_authorities/README.txt seems useless -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:10:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:10:00 +0000 Subject: [Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I think I tested this correctly, but it may need another sign off from someone more familiar with the translation process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:10:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:10:00 +0000 Subject: [Koha-bugs] [Bug 33367] tmp/modified_authorities/README.txt seems useless In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:10:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:10:03 +0000 Subject: [Koha-bugs] [Bug 33367] tmp/modified_authorities/README.txt seems useless In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148945|0 |1 is obsolete| | --- Comment #3 from Phil Ringnalda --- Created attachment 149286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149286&action=edit Bug 33367: Remove tmp/modified_authorities/README.txt This does not seem to be useful anymore. Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:29:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:29:37 +0000 Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:29:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:29:40 +0000 Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148656|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 149287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149287&action=edit Bug 33323: Select button in patron search modal is not translatable This patch modifies the JS which generates some markup during some kinds of patron searches so that the strings labeling submit buttons can be translated. To test, apply the patch and go to Administration -> Funds. - Add a fund or edit an existing one. - Test the "Select owner" link - A popup should appear, and after performing a patron search which returns results you should see a "Select" column in the last column of the patron search results table. - Test the "Add users" link - Perform the same test as above. The button in the last column should be "Add" - The template accommodates two other cases, "Edit" and "Check out" but I was unable to find a place where they were used. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that the correct strings are there: "Select", "Add", "Edit, and "Check out" should each have entries for line 234, e.g. koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:234 c-format msgid "Select" msgstr "Sélectionner" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:30:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:30:08 +0000 Subject: [Koha-bugs] [Bug 33407] With ES and QueryAutoTruncate on, a search containing ISBD punctuation returns no results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33407 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:30:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:30:34 +0000 Subject: [Koha-bugs] [Bug 33406] Searching for authority with hyphen surrounded by spaces causes error 500 (with ES) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33406 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:32:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:32:07 +0000 Subject: [Koha-bugs] [Bug 33404] Authorities imported from Z39.50 in encodings other than UTF-8 are corrupted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33404 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:48:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:48:37 +0000 Subject: [Koha-bugs] [Bug 33429] Use template wrapper for breadcrumbs: Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:48:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:48:39 +0000 Subject: [Koha-bugs] [Bug 33429] Use template wrapper for breadcrumbs: Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149230|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 149288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149288&action=edit Bug 33429: Use template wrapper for breadcrumbs: Plugins This patch updates plugin management templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - In koha-conf.xml, look for "enable_plugins" - If this is set to 0, plugins are disabled: 0 - Navigate directly to /cgi-bin/koha/plugins/plugins-home.pl, which should say "Plugins disabled." Check the breadcrumbs on this page. - Enable plugins by changing the settimg in koha-conf.xml to 1 (a restart of services is required): 1 - Go to Administration -> Manage plugins - Test this page and the "Upload plugin" page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:55:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:55:32 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #15 from Christopher Brannon --- (In reply to Lucas Gass from comment #14) > I've added some patches that will add an items.localuse column to the items > table and also display this in the holdings/other holdings table. > > Leaving as assigned as this will still need adjusted/updated tests. > > Not sure how to deal with the information that is already available via > statistics. I really think we should leave the statistics table as is. > However we may need a script or DB update that will make the new > items.localuse column congruent with what can be derived from statistics. In my opinion, it would be good to have an option to convert those stats over to the new counters. It would also be good to have the option to clear out those stats from the statistics table once converted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:57:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:57:29 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:57:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:57:31 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 --- Comment #1 from Nick Clemens --- Created attachment 149289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149289&action=edit Bug 33411: Unit test update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:57:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:57:33 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 --- Comment #2 from Nick Clemens --- Created attachment 149290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149290&action=edit Bug 33411: Don't count related guarantees fees against NoIssuesChargeGuarantees To test: 1 - Find an adult patron in Koha 2 - Add two guarantees 3 - Add $1 fine to parent, $5 fine to each guarantee 4 - Set no issues charge guarantees to 10 5 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron BARCODE 6 - Note the 64 message starts with Y's that mean patron is blocked 7 - Repeat with each child barcode 8 - They are blocked? 9 - Apply patch, restart all 10 - Try again 11 - Parent blocked, children should not be -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:57:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:57:55 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Depends on| |29755 Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:57:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:57:55 +0000 Subject: [Koha-bugs] [Bug 29755] SIP2 code does not correctly handle NoIssuesChargeGuarantees or NoIssuesChargeGuarantorsWithGuarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29755 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33411 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 20:59:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 18:59:04 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #16 from Christopher Brannon --- (In reply to Katrin Fischer from comment #8) > I get a feeling that opinions on the stats tables vary wildly. As I said, I > would not prune them, but only anonymize them if necessary. Having an idea > about when something happened seems important to me. Having jobs with > different options make sense. > > BTW: as far as I know it won't free space with MySQL if you delete lines. So > that should not be a reason? Hmmmm...this is news to me. I've always known data to take up space. Not sure how you can remove lines of data and not free up space. That is a huge problem if that is the case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 21:00:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 19:00:26 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #17 from Christopher Brannon --- (In reply to Lucas Gass from comment #14) > I've added some patches that will add an items.localuse column to the items > table and also display this in the holdings/other holdings table. > > Leaving as assigned as this will still need adjusted/updated tests. > > Not sure how to deal with the information that is already available via > statistics. I really think we should leave the statistics table as is. > However we may need a script or DB update that will make the new > items.localuse column congruent with what can be derived from statistics. I should clarify, it would be good to at least capture the existing stats and convert them to the counters before those stats are eliminated through table clean up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 21:59:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 19:59:37 +0000 Subject: [Koha-bugs] [Bug 33434] Use template wrapper for breadcrumbs: Point of sale In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33434 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 21:59:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 19:59:41 +0000 Subject: [Koha-bugs] [Bug 33434] Use template wrapper for breadcrumbs: Point of sale In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33434 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149246|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 149291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149291&action=edit Bug 33434: Use template wrapper for breadcrumbs: Point of sale This patch updates point of sale templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - If necessary, enable the EnablePointOfSale and UseCashRegisters system preferences. - If none are configured, define at least one register and at least one debit type by going to Administration -> Cash registers and Administration -> Debit types. - From the staff interface's user menu in the upper right of the header, choose "Set library and cash register." - Select a cash register. - Go to the Point of Sale page, and check the breadcrumbs on that page. - Check the "Transaction history for [register name]" and "Cash summary for [library] pages linked in the left-hand sidebar. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 22:02:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 20:02:17 +0000 Subject: [Koha-bugs] [Bug 33446] New: Revert transit status should have the option to cancel the item transfer as well Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33446 Bug ID: 33446 Summary: Revert transit status should have the option to cancel the item transfer as well Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently, when a hold's transit status is reverted, the item remains in-transit until the transfer is completed by a check-in. This makes sense if the item actually is still in-transit, but there are other situations in which this transit status is incorrect and may not be easy to remove. For example, in our system, we have HoldsAutoFill enabled. Occasionally there are exceptions where we don't want a book to be put in transit for a hold, but instead to remain available at its home branch. If the staff member reverts the transit status on the hold, the item still shows as In Transit. But they can't check in the item to complete the transfer without causing the hold to trap again. In this situation, the book shouldn't be showing as In Transit, but there's no simple way to remove that status. It's several extra steps at best to manually cancel the transfer (and most of our staff don't know how to do this, as manual transfers are not a normal part of our workflow, so many items retain an incorrect "In transit" status indefinitely). When a hold's transit status is reverted by the sending librarian because they're not planning on sending the book for whatever reason, it would be great if they could revert the hold transit status and cancel the item transfer all in one step. This could be something as simple as a checkbox option or a drop-down, so that the user can choose between "Revert transit status" versus "Revert transit status and cancel item transfer". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 22:42:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 20:42:09 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 22:42:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 20:42:11 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149289|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 149292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149292&action=edit Bug 33411: Unit test update Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 22:42:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 20:42:14 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149290|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 149293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149293&action=edit Bug 33411: Don't count related guarantees fees against NoIssuesChargeGuarantees To test: 1 - Find an adult patron in Koha 2 - Add two guarantees 3 - Add $1 fine to parent, $5 fine to each guarantee 4 - Set no issues charge guarantees to 10 5 - perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron BARCODE 6 - Note the 64 message starts with Y's that mean patron is blocked 7 - Repeat with each child barcode 8 - They are blocked? 9 - Apply patch, restart all 10 - Try again 11 - Parent blocked, children should not be Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 22:45:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 20:45:01 +0000 Subject: [Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- Testing notes using KTD: 1. I used Ruben Harper (23529000686353) as the guarantor and Joyce Gaines (23529000224510) and Bobbie Middleton (23529000080862) as the guarantees. 2. I wasn't sure how to restart the SIP emulator after applying the patch, so ending up shutting down and starting up KTD (otherwise there was no change in the responses received). 3. Tests passed after applying the patches: t/db_dependent/SIP/Patron.t Results before patch applied ============================ kohadev-koha at kohadevbox:koha(master)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron 23529000686353 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'patron_information' SEND: 6300120230407 201515 AOCPL|AA23529000686353|ACterm1| READ: 64YYYY 00120230407 201515000000000000000100000000AOCPL|AA23529000686353|AERuben Harper|BLY|BV1|CC5|BD6963 Library Rd. Springfield, MA 44224|BF(212) 555-1212|PB19170924|PCS|PIY|AFGreetings from Koha. -- Patron blocked by fines (11) on guaranteed accounts -- Patron owes 1.00| kohadev-koha at kohadevbox:koha(master)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron 23529000224510 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'patron_information' SEND: 6300120230407 201635 AOCPL|AA23529000224510|ACterm1| READ: 64 00120230407 201635000000000000000100000000AOCPL|AA23529000224510|AEJoyce Gaines|BLY|BV5|CC5|BD6012 Library Rd. Springfield, MA 44224|BF(212) 555-1212|PB20080407|PCYA|PIY|AFGreetings from Koha. -- Patron owes 5.00| kohadev-koha at kohadevbox:koha(master)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron 23529000080862 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'patron_information' SEND: 6300120230407 201658 AOCPL|AA23529000080862|ACterm1| READ: 64 00120230407 201658000000000000000100000000AOCPL|AA23529000080862|AEBobbie Middleton|BLY|BV5|CC5|BD4619 Library Rd. Springfield, MA 44224|BF(212) 555-1212|PB20080407|PCJ|PIY|AFGreetings from Koha. -- Patron owes 5.00| Results after patch applied ============================ kohadev-koha at kohadevbox:koha(bz33411)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron 23529000686353 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'patron_information' SEND: 6300120230407 202802 AOCPL|AA23529000686353|ACterm1| READ: 64 00120230407 202802000000000000000000000000AOCPL|AA23529000686353|AERuben Harper|BLY|BV0|CC5|BD6963 Library Rd. Springfield, MA 44224|BF(212) 555-1212|PB19170924|PCS|PIY|AFGreetings from Koha. | kohadev-koha at kohadevbox:koha(bz33411)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron 23529000224510 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'patron_information' SEND: 6300120230407 203519 AOCPL|AA23529000224510|ACterm1| READ: 64 00120230407 203519000000000000000000000000AOCPL|AA23529000224510|AEJoyce Gaines|BLY|BV0|CC5|BD6012 Library Rd. Springfield, MA 44224|BF(212) 555-1212|PB20080407|PCYA|PIY|AFGreetings from Koha. | kohadev-koha at kohadevbox:koha(bz33411)$ perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron 23529000080862 Attempting socket connection to localhost:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 123. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'patron_information' SEND: 6300120230407 203605 AOCPL|AA23529000080862|ACterm1| READ: 64 00120230407 203605000000000000000000000000AOCPL|AA23529000080862|AEBobbie Middleton|BLY|BV0|CC5|BD4619 Library Rd. Springfield, MA 44224|BF(212) 555-1212|PB20080407|PCJ|PIY|AFGreetings from Koha. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 22:45:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 20:45:52 +0000 Subject: [Koha-bugs] [Bug 16700] Quick spine label creator: Add a hint that IntranetUserCSS can be used for styling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16700 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/654 Keywords|Manual | --- Comment #9 from Caroline Cyr La Rose --- I added a note in the manual, will be in the manual for 23.05 https://gitlab.com/koha-community/koha-manual/-/merge_requests/654/diffs?commit_id=48b89a1baeec72e91bdf4f9ad2eb90e5565c1471 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:00:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 21:00:24 +0000 Subject: [Koha-bugs] [Bug 33436] Use template wrapper for breadcrumbs: Reports part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:00:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 21:00:27 +0000 Subject: [Koha-bugs] [Bug 33436] Use template wrapper for breadcrumbs: Reports part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149272|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 149294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149294&action=edit Bug 33436: Use template wrapper for breadcrumbs: Reports part 1 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Acquisitions statistics - Results - Patrons with the most checkouts - Results - Patrons who haven't checked out - Results - Patron statistics wizard - Results Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:06:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 21:06:10 +0000 Subject: [Koha-bugs] [Bug 33436] Use template wrapper for breadcrumbs: Reports part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. I disabled SQL strict mode[1] to run these reports: - Patrons with the most checkouts - Patrons who haven't checked out [1] To disable SQL struct mode: 1. Edit /etc/koha/sites/kohadev/koha-conf.xml 2. Change 0 from 1 to 0 3. Restart everything: restart_all -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:08:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 21:08:19 +0000 Subject: [Koha-bugs] [Bug 33447] New: Add caching to Biblio->pickup_locations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Bug ID: 33447 Summary: Add caching to Biblio->pickup_locations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Biblio->pickup_locations iterates over each item and calls Item->pickup_locations for each The routine uses a maximum of 5 data points: homebranch, holdingbranch, itype (specifically, not effective_itemtype), ccode (if using branch transfer limits by ccode), and patron branchcode We can add L1 caching on this call to reduce simple repeated calls -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:47:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 21:47:34 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:47:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 21:47:36 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #1 from Nick Clemens --- Created attachment 149295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149295&action=edit Bug 33447: Add Cache to Biblio->pickup_locations This is going to have the most effect on records with large numbers of items held by the same library, serial records and the like To test: 1 - Add 500 items to a biblio by select myltiple copies on the add item page 2 - Place a hold via the API and note response time, I found ~3-5 seconds 3 - Apply patch 4 - Restart all 5 - Place hold using api again 6 - Note improved response time, less than 1/2 a second in my tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:47:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 21:47:38 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #2 from Nick Clemens --- Created attachment 149296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149296&action=edit Bug 33447: Adjust tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 7 23:48:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 21:48:11 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 01:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Apr 2023 23:43:12 +0000 Subject: [Koha-bugs] [Bug 33448] New: staffaccess permission needs to have 'permissions' removed from description Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33448 Bug ID: 33448 Summary: staffaccess permission needs to have 'permissions' removed from description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com staffaccess no longer controls whether a staff member can modify user permissions. That is now controlled by the permissions permission. The staffaccess description needs to be updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 03:36:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 01:36:34 +0000 Subject: [Koha-bugs] [Bug 33304] Report schedule form time input element attribute type changed to improve valid time value entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 --- Comment #4 from Adam Styles --- Hi David, Thanks for the sign off! I know I would use this in my daily drive Koha once implemented. 8-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 05:00:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 03:00:20 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 --- Comment #12 from Victor Grousset/tuxayo --- (In reply to Tomås Cohen Arazi from comment #8) > (11) i.e. the 'display width' ok!!! Now I really get this part from MariaDB's doc: «If a column has been set to ZEROFILL, all values will be prepended by zeros so that the BIGINT value contains a number of M digits.» > is not relevant to the storage size, I though it was to have some business domain rules enforced in the DB so it was on top of storage constraints. > For reference: > https://dev.mysql.com/doc/refman/5.7/en/numeric-type-syntax.html#:~: > text=The%20maximum%20display%20width%20is,digits%20that%20can%20be%20stored. thanks, it's clearer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 11:01:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 09:01:51 +0000 Subject: [Koha-bugs] [Bug 33449] New: Marc Overlay rules screen is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33449 Bug ID: 33449 Summary: Marc Overlay rules screen is broken Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs at lists.koha-community.org Reporter: ruchi.agarwal at avidreaders.in QA Contact: testopia at bugs.koha-community.org Created attachment 149297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149297&action=edit Screenshot of Record Overlay rules screen Have a look at the attachment please. 1. Filter column has no dropdown. Even if I change the selection for module, no activity in shown in filter. 2. Present dropdown has no effect on the other four columns 3. "Add rule" button doesn't do anything. Overall, I am not able to define overlay rules for my Marc imports. Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 17:02:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 15:02:20 +0000 Subject: [Koha-bugs] [Bug 33449] Marc Overlay rules screen is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33449 --- Comment #1 from Katrin Fischer --- Can you check if there is an error in JavaScript on that page please? What exact version of Koha are you using? 22.11.??? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 17:16:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 15:16:05 +0000 Subject: [Koha-bugs] [Bug 32402] "Modification date" missing from OPAC lists table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Modification date" missing |"Modification date" missing |from OPAC Lists table |from OPAC lists table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 17:21:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 15:21:12 +0000 Subject: [Koha-bugs] [Bug 3186] Invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|invalid or uninstalled |Invalid or uninstalled |SMSSendDriver (or bad |SMSSendDriver (or bad |number format) causes |number format) causes |process_message_queue to |process_message_queue to |fail |fail -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 17:31:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 15:31:18 +0000 Subject: [Koha-bugs] [Bug 29678] Can't use external URL for XSLT stylesheet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29678 --- Comment #19 from Katrin Fischer --- > It would be helpful to know which logs to look in. Can you point me to the > right one? Also, I updated the paths Fred mentioned, but no luck. Is there > more than one path in each file to update? You need to check all the References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 --- Comment #17 from Katrin Fischer --- (In reply to Jonathan Druart from comment #16) > Why do we have this in branches.tt only? We don't want to have one follow-up > bug per table, we need to apply it from datatabase.js (or .inc or wherever, > but in a single place). If this is possible, I think we should do it. It would be so nice to have this globally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 17:40:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 15:40:30 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #18 from Katrin Fischer --- (In reply to Christopher Brannon from comment #17) > (In reply to Lucas Gass from comment #14) > > I've added some patches that will add an items.localuse column to the items > > table and also display this in the holdings/other holdings table. > > > > Leaving as assigned as this will still need adjusted/updated tests. > > > > Not sure how to deal with the information that is already available via > > statistics. I really think we should leave the statistics table as is. > > However we may need a script or DB update that will make the new > > items.localuse column congruent with what can be derived from statistics. > > I should clarify, it would be good to at least capture the existing stats > and convert them to the counters before those stats are eliminated through > table clean up. https://stackoverflow.com/questions/1270944/mysql-innodb-not-releasing-disk-space-after-deleting-data-rows-from-table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 17:46:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 15:46:09 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #19 from Christopher Brannon --- (In reply to Katrin Fischer from comment #18) > (In reply to Christopher Brannon from comment #17) > > (In reply to Lucas Gass from comment #14) > > > I've added some patches that will add an items.localuse column to the items > > > table and also display this in the holdings/other holdings table. > > > > > > Leaving as assigned as this will still need adjusted/updated tests. > > > > > > Not sure how to deal with the information that is already available via > > > statistics. I really think we should leave the statistics table as is. > > > However we may need a script or DB update that will make the new > > > items.localuse column congruent with what can be derived from statistics. > > > > I should clarify, it would be good to at least capture the existing stats > > and convert them to the counters before those stats are eliminated through > > table clean up. > > https://stackoverflow.com/questions/1270944/mysql-innodb-not-releasing-disk- > space-after-deleting-data-rows-from-table Well, that is just insane. REGARDLESS, I know for a fact that table queries on smaller tables run faster. Tables must be pruned on a regular basis to maintain optimal performance. This bug will ensure needed data is maintained over time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 17:59:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 15:59:29 +0000 Subject: [Koha-bugs] [Bug 33449] Marc Overlay rules screen is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33449 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal --- Comment #2 from Katrin Fischer --- Works for me on master and in 22.11.03 - I believe that there could be a local issue like broken JS maybe. Downgrading severity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 18:06:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 16:06:18 +0000 Subject: [Koha-bugs] [Bug 33448] staffaccess permission needs to have 'permissions' removed from description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33448 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- The description is not really false. When you don't have staffaccess, you can't change other staff member's permissions. I just verified this by giving myself all permissions but superlibrarian and staffaccess. I am not able to change permissions, but get prompted for authentication when I try. We could probably do a little better and display a nicer error with an explanation, like we do on the password reset page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 19:43:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 17:43:13 +0000 Subject: [Koha-bugs] [Bug 33304] Report schedule form time input element attribute type changed to improve valid time value entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 --- Comment #5 from David Nind --- (In reply to Adam Styles from comment #4) > Hi David, > > Thanks for the sign off! > > I know I would use this in my daily drive Koha once implemented. > > 8-) No problem Adam! Good luck with the QA process - there is a long list of items waiting for QA, so it may take some time 8-( (see the dashboard under 'Bug statuses' https://dashboard.koha-community.org/ ). David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 20:14:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 18:14:44 +0000 Subject: [Koha-bugs] [Bug 33450] New: Need option for placement of OPAC News Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33450 Bug ID: 33450 Summary: Need option for placement of OPAC News Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org For us, OPAC News is better suited in the side navigation panel rather than at the top of the screen. When it is at the top, it pushes everything down off the screen. It would helpful if there were a preference to indicate if OPAC News should be displayed at the top of the screen or on the side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 20:41:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 18:41:43 +0000 Subject: [Koha-bugs] [Bug 33451] New: Password reset menu location Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33451 Bug ID: 33451 Summary: Password reset menu location Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com For some reason we keep "Send password reset" under the more button. It seems more appropriate to replace the "Change password button" with a "Reset password", which also could include a dropdown option for the Change password action. Since staff should not typically enter a know or enter a patron password, resetting seems a more appropriate default action. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 21:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 19:03:38 +0000 Subject: [Koha-bugs] [Bug 33345] On-site checkout checkbox does not work since issue date using flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 21:03:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 19:03:40 +0000 Subject: [Koha-bugs] [Bug 33345] On-site checkout checkbox does not work since issue date using flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148787|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 149298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149298&action=edit Bug 33345: On-site checkout checkbox does not work since issue date using flatpickr Since Bug 30718, date due uses flatpickr. The JavaScript code setting due date via on-site checkout checkbox needs to be adapted. Sort of like Bug 30717. This patch renames the variable sent to template 'today_due_date_and_time' to avoid confusion with variable 'todaysdate' used in other templates. Test plan : 1) Enable system preference 'OnSiteCheckouts' 2) Go to a patron circulation page /cgi-bin/koha/circ/circulation.pl 3) Click on settings icon inside barcode input => Check due date input is empty 4) Click on 'On-site checkout' => Check due date input is filled with today date at 23:59 5) Fill barcode input and do check-out 6) Check due date is correct Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 21:10:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 19:10:08 +0000 Subject: [Koha-bugs] [Bug 33345] On-site checkout checkbox does not work since issue date using flatpickr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- Testing notes (using KTD): 1. If I understand this correctly, if OnSiteCheckouts is enabled: 1.1 Go to check out an item for a patron 1.2 Click on the settings icon in the barcode input field 1.3 Click the tick box next to 'On-site checkouts' 1.4 It should automatically fill in the 'Specify due date' field with today's date and 23:59 as the time 1.5 Before the patch is applied, it doesn't (when it should) 1.6 After the patch is applied, it does (which is what is expected) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 21:13:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 19:13:57 +0000 Subject: [Koha-bugs] [Bug 21309] Enforce password change on login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21309 --- Comment #11 from Christopher Brannon --- Noting that Koha now has the capability to send a reset notice. However, this is limiting to patrons that have email. Even if the notice were to send via text, this still limits capability to certain patrons. It would be preferable if the reset tied into the same mechanism that password expiration uses. Right now, they work independently from one another and the reset is exclusive to patrons that receive email. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 21:40:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 19:40:08 +0000 Subject: [Koha-bugs] [Bug 33435] We're missing sample dev data for ERM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 21:40:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 19:40:31 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 21:40:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 19:40:47 +0000 Subject: [Koha-bugs] [Bug 32716] update NGINX config examples to increase proxy_buffer_size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |gmc at esilibrary.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 21:41:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 19:41:03 +0000 Subject: [Koha-bugs] [Bug 33009] bump Standards-Version to 4.6.2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 21:50:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 19:50:31 +0000 Subject: [Koha-bugs] [Bug 33452] New: Patron statistics results is missing page-section Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Bug ID: 33452 Summary: Patron statistics results is missing page-section Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The patron statistics report is missing the page section on the results table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 21:50:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 19:50:53 +0000 Subject: [Koha-bugs] [Bug 33436] Use template wrapper for breadcrumbs: Reports part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 21:50:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 19:50:56 +0000 Subject: [Koha-bugs] [Bug 33436] Use template wrapper for breadcrumbs: Reports part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149294|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 149299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149299&action=edit Bug 33436: Use template wrapper for breadcrumbs: Reports part 1 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Acquisitions statistics - Results - Patrons with the most checkouts - Results - Patrons who haven't checked out - Results - Patron statistics wizard - Results Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 21:58:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 19:58:42 +0000 Subject: [Koha-bugs] [Bug 33452] Patron statistics results is missing page-section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:01:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:01:16 +0000 Subject: [Koha-bugs] [Bug 33453] New: Confirmation button for 'Record cashup' should be yellow Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Bug ID: 33453 Summary: Confirmation button for 'Record cashup' should be yellow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When recording a cashup the confirmation button in the modal should be 'yellow' for the primary action. * Enable cash registers and create a cash register * Go to Tools > Transaction history for ... * Click on 'Record cashup' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:01:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:01:41 +0000 Subject: [Koha-bugs] [Bug 33453] Confirmation button for 'Record cashup' should be yellow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33453 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:02:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:02:29 +0000 Subject: [Koha-bugs] [Bug 33434] Use template wrapper for breadcrumbs: Point of sale In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33434 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:02:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:02:31 +0000 Subject: [Koha-bugs] [Bug 33434] Use template wrapper for breadcrumbs: Point of sale In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33434 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149291|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149300&action=edit Bug 33434: Use template wrapper for breadcrumbs: Point of sale This patch updates point of sale templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - If necessary, enable the EnablePointOfSale and UseCashRegisters system preferences. - If none are configured, define at least one register and at least one debit type by going to Administration -> Cash registers and Administration -> Debit types. - From the staff interface's user menu in the upper right of the header, choose "Set library and cash register." - Select a cash register. - Go to the Point of Sale page, and check the breadcrumbs on that page. - Check the "Transaction history for [register name]" and "Cash summary for [library] pages linked in the left-hand sidebar. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:15:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:15:47 +0000 Subject: [Koha-bugs] [Bug 33429] Use template wrapper for breadcrumbs: Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:15:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:15:50 +0000 Subject: [Koha-bugs] [Bug 33429] Use template wrapper for breadcrumbs: Plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149288|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 149301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149301&action=edit Bug 33429: Use template wrapper for breadcrumbs: Plugins This patch updates plugin management templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - In koha-conf.xml, look for "enable_plugins" - If this is set to 0, plugins are disabled: 0 - Navigate directly to /cgi-bin/koha/plugins/plugins-home.pl, which should say "Plugins disabled." Check the breadcrumbs on this page. - Enable plugins by changing the settimg in koha-conf.xml to 1 (a restart of services is required): 1 - Go to Administration -> Manage plugins - Test this page and the "Upload plugin" page. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:18:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:18:02 +0000 Subject: [Koha-bugs] [Bug 33410] Use template wrapper for breadcrumbs: Patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:20:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:20:17 +0000 Subject: [Koha-bugs] [Bug 33410] Use template wrapper for breadcrumbs: Patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:20:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:20:19 +0000 Subject: [Koha-bugs] [Bug 33410] Use template wrapper for breadcrumbs: Patron card creator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149191|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149302&action=edit Bug 33410: Use template wrapper for breadcrumbs: Patron card creator This patch updates several patron card creator templates so that they use the new WRAPPER for displaying breadcrumbs. Unrelated minor change: I added around a few other strings in edit-profile.tt and edit-template.tt in order to improve translatability. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Patron card creator - New -> - Card batch - Image - Layout - Card template - Printer profile - Manage -> - Card batches - Images - Layouts - Card templates - Printer profiles Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:20:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:20:55 +0000 Subject: [Koha-bugs] [Bug 33409] Use template wrapper for breadcrumbs: Patrons lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33409 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:28:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:28:38 +0000 Subject: [Koha-bugs] [Bug 33454] New: Improve breadcrumbs for patron lists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 Bug ID: 33454 Summary: Improve breadcrumbs for patron lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 33409 When looking at a patron list, the breadcrumbs look like this: Tools > Patron lists > Test > Add patrons When you click on "Test", the name of the list, you get to the same page as "Add patrons". As that are not different pages, I think we should combine the crumbs: Tools > Patron lists > Add patrons to Test Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33409 [Bug 33409] Use template wrapper for breadcrumbs: Patrons lists -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:28:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:28:38 +0000 Subject: [Koha-bugs] [Bug 33409] Use template wrapper for breadcrumbs: Patrons lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33409 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33454 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33454 [Bug 33454] Improve breadcrumbs for patron lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:29:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:29:23 +0000 Subject: [Koha-bugs] [Bug 33409] Use template wrapper for breadcrumbs: Patrons lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33409 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:29:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:29:25 +0000 Subject: [Koha-bugs] [Bug 33409] Use template wrapper for breadcrumbs: Patrons lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33409 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149216|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 149303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149303&action=edit Bug 33409: Use template wrapper for breadcrumbs: Patrons lists This patch updates several patron lists templates so that they use the new WRAPPER for displaying breadcrumbs. Unrelated minor change: I added around a few other strings in add-modify.tt in order to improve translatability. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Patron lists - Main page - Patron list contents view - Add patron list - Edit patron list Signed-off-by: Andrew Auld Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:32:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:32:02 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from David Nind --- The patch no longer applies 8-(.. git bz apply 32735 Bug 32735 - REST API: Add a list endpoint for Authorities 147493 - Bug 32735: Add endpoint to list authorities Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32735: Add endpoint to list authorities error: sha1 information is lacking or useless (Koha/REST/V1/Authorities.pm). error: could not build fake ancestor Patch failed at 0001 Bug 32735: Add endpoint to list authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:32:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:32:32 +0000 Subject: [Koha-bugs] [Bug 33389] Use template wrapper for breadcrumbs: Patrons part 5 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:32:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:32:34 +0000 Subject: [Koha-bugs] [Bug 33389] Use template wrapper for breadcrumbs: Patrons part 5 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149147|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149304&action=edit Bug 33389: Use template wrapper for breadcrumbs: Patrons part 5 This patch updates several patron templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Patrons -> - Patron details -> (Patron with charges) -> - Accounting -> - Pay - Circulation history - Routing lists - Statistics - Purchase suggestions - More -> Manage two-factor authentication (must have TwoFactorAuthentication enabled) Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:32:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:32:43 +0000 Subject: [Koha-bugs] [Bug 33389] Use template wrapper for breadcrumbs: Patrons part 5 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:36:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:36:20 +0000 Subject: [Koha-bugs] [Bug 33455] New: Heading on 'update password' page it too big Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33455 Bug ID: 33455 Summary: Heading on 'update password' page it too big Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The h1 heading on the change password page is too big and should be outside of the legend. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:37:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:37:14 +0000 Subject: [Koha-bugs] [Bug 33387] Use template wrapper for breadcrumbs: Patrons part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:37:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:37:36 +0000 Subject: [Koha-bugs] [Bug 33387] Use template wrapper for breadcrumbs: Patrons part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:37:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:37:39 +0000 Subject: [Koha-bugs] [Bug 33387] Use template wrapper for breadcrumbs: Patrons part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149146|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149305&action=edit Bug 33387: Use template wrapper for breadcrumbs: Patrons part 3 This patch updates several patron templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Patrons home page - Patron detail page -> - Change password - Set permissions - Accounting -> - Create manual invoice - Create manual credit Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:39:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:39:26 +0000 Subject: [Koha-bugs] [Bug 33386] Use template wrapper for breadcrumbs: Patrons part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33386 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:46:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:46:05 +0000 Subject: [Koha-bugs] [Bug 33456] New: Standardize breadcrumbs in patron account in staff interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33456 Bug ID: 33456 Summary: Standardize breadcrumbs in patron account in staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Most of the pages in the patron account use a pattern like this in the breadcrumbs: Home > Patrons > koha (42) > Page name But some are missing the 'koha (42)' part. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:46:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:46:56 +0000 Subject: [Koha-bugs] [Bug 33386] Use template wrapper for breadcrumbs: Patrons part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33386 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:46:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:46:59 +0000 Subject: [Koha-bugs] [Bug 33386] Use template wrapper for breadcrumbs: Patrons part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33386 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149057|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 149306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149306&action=edit Bug 33386: Use template wrapper for breadcrumbs: Patrons part 2 This patch updates several patron templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Patron details -> - Files (EnableBorrowerFiles must be enabled) - Holds history - Housebound (HouseboundModule must be enabled) - Ill requests history (ILLModule must be enabled) - Staff interface home page -> Discharge requests pending - Must have useDischarge preference enabled - Must log into the OPAC and request a discharge using a patron account which has no checkouts. Signed-off-by: Andrew Auld Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:47:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:47:34 +0000 Subject: [Koha-bugs] [Bug 33385] Use template wrapper for breadcrumbs: Patrons part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33385 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:50:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:50:28 +0000 Subject: [Koha-bugs] [Bug 33385] Use template wrapper for breadcrumbs: Patrons part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33385 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:50:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:50:30 +0000 Subject: [Koha-bugs] [Bug 33385] Use template wrapper for breadcrumbs: Patrons part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33385 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149050|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 149307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149307&action=edit Bug 33385: Use template wrapper for breadcrumbs: Patrons part 1 This patch updates several patron templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Patron details -> - Accounting -> Transactions - Transaction details - Check the details of a debit and a credit - More -> - Manage API keys (must have RESTOAuth2ClientCredentials preference enabled) - Delete (with a patron who has checkouts) - Discharge Signed-off-by: Andrew Auld Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:56:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:56:12 +0000 Subject: [Koha-bugs] [Bug 33384] Use template wrapper for breadcrumbs: Labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33384 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:56:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:56:15 +0000 Subject: [Koha-bugs] [Bug 33384] Use template wrapper for breadcrumbs: Labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33384 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149051|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 149308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149308&action=edit Bug 33384: Use template wrapper for breadcrumbs: Labels This patch updates label creator templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Cataloging -> - Barcode image generator - Quick spine label creator - Label creator -> - Label creator home - New -> - Label batch - Layout - Label template - Printer profile - Barcode range - Manage -> - Label batches - Edit batch - Layouts - Edit layout - Label templates - Edit template - Printer profiles Signed-off-by: Andrew Auld Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:56:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:56:39 +0000 Subject: [Koha-bugs] [Bug 33383] Use template wrapper for breadcrumbs: Course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:58:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:58:23 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:58:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:58:25 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148399|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 149309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149309&action=edit Bug 27775: Add hint about drag and drop feature on framework subfield edit Bug 8976 introduced a way to sort subfields on a MARC/Auth framework using drag and drop. But there's no visible hint alerting the user the feature exists. Test plan : 1) Go to Admistration > MARC bibliographic framework 2) Choose a framework and click on Actions > MARC structure 3) Choose a field and click on Actions > Edit subfields 4) Check you see the hint 5) Go to Admistration > Authority types 6) Choose a type and click on Actions > MARC structure 7) Choose a field and click on Actions > Subfields 8) Click on Edit subfields 9) Check you see the hint Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:58:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:58:35 +0000 Subject: [Koha-bugs] [Bug 33383] Use template wrapper for breadcrumbs: Course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 22:58:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 20:58:38 +0000 Subject: [Koha-bugs] [Bug 33383] Use template wrapper for breadcrumbs: Course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149045|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149310&action=edit Bug 33383: Use template wrapper for breadcrumbs: Course reserves This patch updates several course reserves templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Course reserves - New course - Edit course - Batch remove reserves - Course details - Add reserves (step one and two) - Batch add reserves Signed-off-by: Andrew Auld Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:00:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:00:43 +0000 Subject: [Koha-bugs] [Bug 33382] Use template wrapper for breadcrumbs: Patron clubs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33382 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:00:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:00:46 +0000 Subject: [Koha-bugs] [Bug 33382] Use template wrapper for breadcrumbs: Patron clubs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33382 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149043|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149311&action=edit Bug 33382: Use template wrapper for breadcrumbs: Patron clubs This patch updates patron club templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Patron clubs - New club template - Edit club template - New club - Edit club - Club enrollments (from the "Actions" menu in the list of clubs) Signed-off-by: Andrew Auld Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:01:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:01:09 +0000 Subject: [Koha-bugs] [Bug 33382] Use template wrapper for breadcrumbs: Patron clubs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33382 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:03:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:03:58 +0000 Subject: [Koha-bugs] [Bug 33373] Use template wrapper for breadcrumbs: Circulation part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:04:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:04:00 +0000 Subject: [Koha-bugs] [Bug 33373] Use template wrapper for breadcrumbs: Circulation part 3 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149098|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 149312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149312&action=edit Bug 33373: Use template wrapper for breadcrumbs: Circulation part 3 This patch updates several circulation templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Circulation -> - Article requests -> Article request detail - Check in - Hold ratios - Transfers to send - Transfers to receive - Holds queue - Holds awaiting pickup - Set library Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:04:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:04:36 +0000 Subject: [Koha-bugs] [Bug 33456] Standardize breadcrumbs in patron account in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33456 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:04:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:04:47 +0000 Subject: [Koha-bugs] [Bug 33456] Standardize breadcrumbs in patron account in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33456 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:09:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:09:21 +0000 Subject: [Koha-bugs] [Bug 33372] Use template wrapper for breadcrumbs: Circulation part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33372 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:09:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:09:23 +0000 Subject: [Koha-bugs] [Bug 33372] Use template wrapper for breadcrumbs: Circulation part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33372 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149040|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149313&action=edit Bug 33372: Use template wrapper for breadcrumbs: Circulation part 2 This patch updates several circulation templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Circulation - Check out - Check out to patron - Curbside pickups - Built-in offline circulation - Pending on-site checkouts - Overdues - Holds to pull - Renew Signed-off-by: Philip Orr Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:09:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:09:36 +0000 Subject: [Koha-bugs] [Bug 33333] Use template wrapper for tabs: SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:13:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:13:18 +0000 Subject: [Koha-bugs] [Bug 33333] Use template wrapper for tabs: SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:13:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:13:20 +0000 Subject: [Koha-bugs] [Bug 33333] Use template wrapper for tabs: SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33333 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148756|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149314&action=edit Bug 33333: Use template wrapper for tabs: SQL reports This patch updates the saved SQL reports template so that it uses the new WRAPPER directive to build tab markup. To test, apply the patch and go to Reports -> Use saved. In order to properly test the patch you should have multiple reports defined with multiple categories ("Accounts", "Acquisitions", "Catalog", etc.). Clicking each tab should filter the table of reports correctly. After navigating away from the page and back to it, your selected tab should be remembered. Signed-off-by: Alexandra Speer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:14:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:14:03 +0000 Subject: [Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:17:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:17:05 +0000 Subject: [Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:17:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:17:07 +0000 Subject: [Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149285|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 149315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149315&action=edit Bug 33332: Fix formatting of TT comments to improve translations This patch reformats some Template::Toolkit multi-line comments in html_helpers.inc so that each line is commented separately. This seems to prevent the translation tool from putting the comments into the po file. To test, apply the patch and confirm that pages which use the breadcrumbs and tabs WRAPPER directives still work correctly: - Breadcrumbs: staff client home page, about page, error page. - Tabs: Administration -> Library transfer limits or circulation alerts. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that there is no instance of something like "[%%# BOOTSTRAP BREADCRUMBS WRAPPER USAGE" Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:17:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:17:46 +0000 Subject: [Koha-bugs] [Bug 33324] Use template wrapper for tabs: Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:21:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:21:33 +0000 Subject: [Koha-bugs] [Bug 33324] Use template wrapper for tabs: Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:21:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:21:36 +0000 Subject: [Koha-bugs] [Bug 33324] Use template wrapper for tabs: Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148875|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149316&action=edit Bug 33324: Use template wrapper for tabs: Tools This patch updates templates in the tools directory so that they use the new WRAPPER directive to build tabbed navigation. To test, apply the patch and test each page to confirm that tabs still work as before: - Cataloging -> Export - This page by default will have two tabs, "Export bibliographic records" and "Export authority records." You can edit koha-conf.xml to enable two additional options: backup_db_via_tools and backup_conf_via_tools - Tools -> Batch patron modification - "By card number" and "By borrowernumber," and "By patron list" if you have any patron lists defined. - Tools -> Overdue notice/status triggers Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:27:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:27:40 +0000 Subject: [Koha-bugs] [Bug 33457] New: Improve display of fund users when the patron has no surname Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33457 Bug ID: 33457 Summary: Improve display of fund users when the patron has no surname Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When a patron is added to a fund as user and they have no surname, null is displayed instead: * Go to administration > funds * Edit fund * Click 'Add users' * Select a user, only staff users will be searchable * In the sample database, choose cardnumber 42 * After adding the user, the name displays as: null koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:28:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:28:42 +0000 Subject: [Koha-bugs] [Bug 33457] Improve display of fund users when the patron has no firstname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33457 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve display of fund |Improve display of fund |users when the patron has |users when the patron has |no surname |no firstname --- Comment #1 from Katrin Fischer --- The same display problems appears for the owner of a fund when the firstname is missing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:29:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:29:37 +0000 Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:29:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:29:40 +0000 Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149287|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 149317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149317&action=edit Bug 33323: Select button in patron search modal is not translatable This patch modifies the JS which generates some markup during some kinds of patron searches so that the strings labeling submit buttons can be translated. To test, apply the patch and go to Administration -> Funds. - Add a fund or edit an existing one. - Test the "Select owner" link - A popup should appear, and after performing a patron search which returns results you should see a "Select" column in the last column of the patron search results table. - Test the "Add users" link - Perform the same test as above. The button in the last column should be "Add" - The template accommodates two other cases, "Edit" and "Check out" but I was unable to find a place where they were used. - To test translatability, run the translation tool for any language, e.g. perl misc/translator/translate update fr-FR Search the regenerated po file (in this example misc/translator/po/fr-FR-staff-prog.po) to confirm that the correct strings are there: "Select", "Add", "Edit, and "Check out" should each have entries for line 234, e.g. koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:234 c-format msgid "Select" msgstr "Sélectionner" Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:29:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:29:48 +0000 Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:30:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:30:18 +0000 Subject: [Koha-bugs] [Bug 33310] Use template wrapper for tabs: Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:31:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:31:43 +0000 Subject: [Koha-bugs] [Bug 33310] Use template wrapper for tabs: Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #3 from Katrin Fischer --- Patch doesn't apply, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33310: Use template wrapper for tabs: Suggestions Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 33310: Use template wrapper for tabs: Suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:35:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:35:31 +0000 Subject: [Koha-bugs] [Bug 33307] Use template wrapper for tabs: Lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33307 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:35:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:35:33 +0000 Subject: [Koha-bugs] [Bug 33307] Use template wrapper for tabs: Lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33307 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148594|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 149318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149318&action=edit 5# Attachment to Bug 33307 - Use template wrapper for tabs: Lists Bug 33307: Use template wrapper for tabs: Lists This patch updates the lists template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and go to the lists page in the staff interface. - Confirm that the two tabs, "Your lists" and "Public lists" look correct and work correctly. - Test that the correct tab is selected when you add the "public" or "private" parameter to the url: /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=1 /cgi-bin/koha/virtualshelves/shelves.pl?op=list&public=0 Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:39:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:39:17 +0000 Subject: [Koha-bugs] [Bug 33294] Use template wrapper for tabs: Checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:39:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:39:20 +0000 Subject: [Koha-bugs] [Bug 33294] Use template wrapper for tabs: Checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148754|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149319&action=edit Bug 33294: Use template wrapper for tabs: Checkout history This patch updates the checkout history template so that it uses the new WRAPPER directive to build tabbed navigation. In order to make the template logic a little easier to parse I moved the table of checkouts into its own BLOCK to be used when on-site checkouts are enabled or disabled. To test, apply the patch and locate a patron who has a checkout history. - If you have on-site checkouts enabled you will see three tabs: All, Checkouts, and On-site checkouts. - Each tab should work correctly: The checkouts tab showing only regular checkouts, the on-site checkouts tab showing only on-site checkouts. - If you have on-site checkouts disabled there should be no tabs, the table of checkouts should be displayed inside a "page-section" div instead. Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:39:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:39:37 +0000 Subject: [Koha-bugs] [Bug 33294] Use template wrapper for tabs: Checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:39:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:39:40 +0000 Subject: [Koha-bugs] [Bug 33458] New: Patron categories for specific libraries should be retained by other libraries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33458 Bug ID: 33458 Summary: Patron categories for specific libraries should be retained by other libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently you can set specific patron categories for specific libraries, or all. If we set them for specific libraries, that works well. What doesn't work is if the patron is edited by another library that doesn't have access to that particular category. If you edit a patron account that has a category that is not used by your library, the category will be changed to the top most category without warning. It would be preferred that if a patron is assigned a patron category that is not normally used by your library, that when editing, it would retain that category unless you change it. In other words, library limitations should only affect choosing those items (patron categories, shelving locations, or anything else that uses limitations). It shouldn't change it if you are updating a record. You should be allowed to change from it. But once you have changed from it, it shouldn't show, and you shouldn't be able to change back. This should probably be set for other library limitations too, but I specifically want to address patron categories in this bug. I think the simplest way to put this is, library limited items should show when in use and active on the record in question, but should not show when they aren't. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:42:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:42:03 +0000 Subject: [Koha-bugs] [Bug 33293] Use template wrapper for tabs: Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:42:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:42:05 +0000 Subject: [Koha-bugs] [Bug 33293] Use template wrapper for tabs: Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148753|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149320&action=edit Bug 33293: Use template wrapper for tabs: Holds This patch updates the holds template so that it uses the new WRAPPER directive to build tabbed navigation. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and locate a bibliographic record which can be placed on hold. - Start the process of placing a hold. - If you have any patron clubs defined, there should be two tabs: Patrons and Clubs. Both should look correct and work correctly. - If you have no patron clubs you should see only the Patrons tab. Works as advertised. Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:44:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:44:14 +0000 Subject: [Koha-bugs] [Bug 33458] Patron categories for specific libraries should be retained by other libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33458 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- This has been fixed by bug 31422 *** This bug has been marked as a duplicate of bug 31422 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:44:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:44:14 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss when editing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #20 from Katrin Fischer --- *** Bug 33458 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:46:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:46:21 +0000 Subject: [Koha-bugs] [Bug 21255] memberetnry.pl is missing categories in the Category pull-down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21255 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Katrin Fischer --- I believe this is fixed by bug 31422. *** This bug has been marked as a duplicate of bug 31422 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:46:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:46:21 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss when editing patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u --- Comment #21 from Katrin Fischer --- *** Bug 21255 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:51:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:51:51 +0000 Subject: [Koha-bugs] [Bug 33186] Use template wrapper for tabs on search history and advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:51:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:51:57 +0000 Subject: [Koha-bugs] [Bug 33187] Use template wrapper for tabs article requests and holds awaiting pickup pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:52:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:52:00 +0000 Subject: [Koha-bugs] [Bug 33187] Use template wrapper for tabs article requests and holds awaiting pickup pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148125|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149321&action=edit Bug 33187: Use template wrapper for tabs article requests and holds awaiting pickup pages This patch updates the article requests management and holds awaiting pickup templates in the staff interface so that they use the new WRAPPER directive for building tabs. To test, apply the patch and make sure the ArticleRequests system preference is enabled. - Go to Circulation -> Article requests - You should see three tabs, "New," "Pending," and "Processing." - The tabs should look correct and work correctly. - Go to Circulation -> Holds awaiting pickup - You should see three tabs, "Holds waiting", "Holds waiting over X days," and "Holds with cancellation requests." ("X" is the value in the ReservesMaxPickUpDelay system preference) Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:55:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:55:36 +0000 Subject: [Koha-bugs] [Bug 33186] Use template wrapper for tabs on search history and advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:55:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:55:39 +0000 Subject: [Koha-bugs] [Bug 33186] Use template wrapper for tabs on search history and advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148127|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149322&action=edit Bug 33186: Use template wrapper for tabs on search history and advanced search This patch updates the search history and advanced search templates in the staff interface so that they use the new WRAPPER directive for building tabs. The patch also makes a minor change to CSS in order to accommodate the different markup. To test, apply the patch and rebuild the staff interface CSS. - Go to the catalog's advanced search page. You should see tabs for each of the selections defined in the AdvancedSearchTypes system preference. - The tabs should look correct and work correctly. - If necessary, enable the EnableSearchHistory system preference. - Click the logged-in user name in the header menu and choose "Search history." - On this page you should see two tabs, catalog and authority. Both tabs should look correct and work correctly. Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:57:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:57:39 +0000 Subject: [Koha-bugs] [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:58:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:58:05 +0000 Subject: [Koha-bugs] [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 8 23:58:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 21:58:07 +0000 Subject: [Koha-bugs] [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148128|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149323&action=edit Bug 33185: Use template wrapper for tabs on authority and biblio MARC details This patch updates the MARC detail views of bibliographic and authority records so that they use the new WRAPPER directives to build tabs. To test, apply the patch and locate a bibliographic record in the catalog. - Click the "MARC" menu item in the left-hand sidebar. - Confirm that all tabs work correctly. Perform the same test by going to Authorities and doing a search for authorities. Clicking one of the results should take you to a tabbed MARC view. Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:00:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:00:06 +0000 Subject: [Koha-bugs] [Bug 33181] Use template wrapper for tabs on record merge pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:00:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:00:35 +0000 Subject: [Koha-bugs] [Bug 33181] Use template wrapper for tabs on record merge pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:00:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:00:37 +0000 Subject: [Koha-bugs] [Bug 33181] Use template wrapper for tabs on record merge pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148912|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 149324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149324&action=edit Bug 33181: Use template wrapper for tabs on record merge pages This patch updates the include file which is used by both the bibliographic and authority recrd merge pages. The markup is updated to use the new tab WRAPPER directives. To test, apply the patch and perform a catalog search which will return more than one record. - Select two or more records and choose "Merge records" from the edit menu at the top of the search results. - On the following page you should see one tab for each record you selected from the search results. - Clicking each tab should show you the correct bibliographic details. Perform the same tests from the authority search results page. Signed-off-by: Andrew Auld Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:00:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:00:42 +0000 Subject: [Koha-bugs] [Bug 33180] Use template wrapper for tabs: Budgets and Search engine configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:03:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:03:23 +0000 Subject: [Koha-bugs] [Bug 33180] Use template wrapper for tabs: Budgets and Search engine configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:03:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:03:26 +0000 Subject: [Koha-bugs] [Bug 33180] Use template wrapper for tabs: Budgets and Search engine configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148879|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 149325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149325&action=edit Bug 33180: Use template wrapper for tabs: Budgets and Search engine configuration This patch updates two administration templates so that they use the new WRAPPER directive to build tabbed navigation: Budgets and Search engine configuration. Note: this patch includes indentation changes, so check the diff accordingly. To test, apply the patch and check the updated pages: - Administration -> Budgets - Administration -> Search engine configuration On both pages tabs should look correct and work correctly. Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:03:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:03:50 +0000 Subject: [Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:07:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:07:26 +0000 Subject: [Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:07:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:07:28 +0000 Subject: [Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148695|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149326&action=edit Bug 33154: Tab WRAPPER follow-up: label text must be translatable This patch updates templates which have already been updated to use the new tab WRAPPER system for generating tab markup. Templates are changed so that tab label strings are wrapped in to make them translatable. The html_helpers include file is also updated so that the example code in comments shows the right pattern (the breadcrumb example is similarly corrected). To test apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files for some of the lines modified in the patch: - koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:31 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:69 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt:330 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:141 - koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt:118 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:259 - koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:455 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:98 Signed-off-by: Caroline Cyr La Rose Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:07:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:07:48 +0000 Subject: [Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 --- Comment #4 from Katrin Fischer --- QA tools show this warning, but I think it's irrelevant here: * Commit title does not contain 'follow-up' correctly spelt - b9bdec4b71 This might conflict with bug 33332. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:08:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:08:19 +0000 Subject: [Koha-bugs] [Bug 33187] Use template wrapper for tabs article requests and holds awaiting pickup pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:10:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:10:01 +0000 Subject: [Koha-bugs] [Bug 33147] Use template wrapper for breadcrumbs: Catalog part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33147 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:11:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:11:10 +0000 Subject: [Koha-bugs] [Bug 33147] Use template wrapper for breadcrumbs: Catalog part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33147 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:11:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:11:12 +0000 Subject: [Koha-bugs] [Bug 33147] Use template wrapper for breadcrumbs: Catalog part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33147 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148900|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149327&action=edit Bug 33147: Use template wrapper for breadcrumbs: Catalog part 2 This patch updates several catalog templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Catalog search results - Search history (from the user menu in the header) - Bibliographic detail page -> Rota (must have StockRotation enabled). Signed-off-by: Andrew Auld Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:15:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:15:06 +0000 Subject: [Koha-bugs] [Bug 33459] New: Patrons need messaging preferences for other notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33459 Bug ID: 33459 Summary: Patrons need messaging preferences for other notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Patrons should be able to set how they want all other notices that are not currently included in their messaging preferences. There is no reason they or staff should not be able to set how they get their password resets, welcome message, expirations, suggestions, etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:17:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:17:26 +0000 Subject: [Koha-bugs] [Bug 33460] New: Standardize breadcrumb for labeled MARC view Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33460 Bug ID: 33460 Summary: Standardize breadcrumb for labeled MARC view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 33131 The breadcrumbs for the labeled MARC view doesn't match the breadcrumbs for the other record views. Currently the breadcrumb reads: Home > Catalog > MARC details for Programming the Perl DBI / It should read: Home > Catalog > Programming the Perl DBI / > Labeled MARC details To see the labeled MARC view the viewLabeledMARC system preference needs to be activated. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33131 [Bug 33131] Use template wrapper for breadcrumbs: Catalog part 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:17:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:17:26 +0000 Subject: [Koha-bugs] [Bug 33131] Use template wrapper for breadcrumbs: Catalog part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33131 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33460 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33460 [Bug 33460] Standardize breadcrumb for labeled MARC view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:19:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:19:21 +0000 Subject: [Koha-bugs] [Bug 33131] Use template wrapper for breadcrumbs: Catalog part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33131 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:19:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:19:24 +0000 Subject: [Koha-bugs] [Bug 33131] Use template wrapper for breadcrumbs: Catalog part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33131 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148893|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149328&action=edit Bug 33131: Use template wrapper for breadcrumbs: Catalog part 1 This patch updates several catalog templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Advanced search - Bibliographic detail page - Labeled MARC detail page - MARC detail page - ISBD detail page - Item detail page - Image detail view (with LocalCoverImages enabled and a custom cover added) - Checkout history - Item search Signed-off-by: Andrew Auld Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:19:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:19:34 +0000 Subject: [Koha-bugs] [Bug 33130] Use template wrapper for breadcrumbs: Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33130 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:23:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:23:27 +0000 Subject: [Koha-bugs] [Bug 33130] Use template wrapper for breadcrumbs: Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33130 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:23:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:23:29 +0000 Subject: [Koha-bugs] [Bug 33130] Use template wrapper for breadcrumbs: Authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33130 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147816|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149329&action=edit Bug 33130: Use template wrapper for breadcrumbs: Authorities This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Authorities home page - Authority search results - Authority detail - Authority add/edit - Authority merge Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:23:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:23:45 +0000 Subject: [Koha-bugs] [Bug 33129] Use template wrapper for breadcrumbs: Administration part 6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:28:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:28:04 +0000 Subject: [Koha-bugs] [Bug 33129] Use template wrapper for breadcrumbs: Administration part 6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:28:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:28:06 +0000 Subject: [Koha-bugs] [Bug 33129] Use template wrapper for breadcrumbs: Administration part 6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148920|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 149330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149330&action=edit Bug 33129: Use template wrapper for breadcrumbs: Administration part 6 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> - Search engine configuration (Elasticsearch) - Share content with Mana KB - Circulation and fine rules - SMS cellular providers (SMSSendDriver preference must be set) - System preferences -> Local use (list, add, edit, confirm delete) - Library transfer limits (Advanced editor) - Transport cost matrix - Usage statistics - Z39.50/SRU servers administration (list, add, edit, both Z39.50 and SRU servers) Signed-off-by: Andrew Auld Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:28:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:28:59 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:29:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:29:06 +0000 Subject: [Koha-bugs] [Bug 33461] New: Password reset should act like patron expiration when there are no notices available Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33461 Bug ID: 33461 Summary: Password reset should act like patron expiration when there are no notices available Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com A password reset sends an email to a patron when executed. The following should be considered: 1) We should allow other delivery methods 2) If a patron doesn't have a delivery method, we should be able to use a method like password expiration, but Koha should generate a code that is put in place of the password. The patron has to put in the code in order to change the password. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:32:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:32:42 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:32:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:32:44 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148837|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 149331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149331&action=edit Bug 33127: Use template wrapper for breadcrumbs: Administration part 5 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> - Record overlay rules - Search filters (must have SavedSearchFilters enabled) - System preferences -> OverDriveAuthName -> OverDrive library authnames table - MARC bibliographic framework -> MARC structure (list, new, edit, delete confirm). - Record matching rules (list, new, edit, delete confirm) - OAI sets configuration (list, new, edit) -> Define mappings - Patron attribute types (list, new, edit, delete confirm) - Patron restrictions (list, new, edit, delete confirm) Signed-off-by: Andrew Auld Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:33:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:33:40 +0000 Subject: [Koha-bugs] [Bug 33111] Use template wrapper for breadcrumbs: Administration part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33111 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:36:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:36:18 +0000 Subject: [Koha-bugs] [Bug 33461] Password reset should act like patron expiration when there are no notices available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33461 --- Comment #1 from Katrin Fischer --- The email verification acts as a "second factor". By proving they have access to the email account, the user is verified. Same could be used for SMS/text messages when they need to have access to the phone. I am not sure where a code would come in and how would it be communicated to the user? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:49:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:49:40 +0000 Subject: [Koha-bugs] [Bug 33111] Use template wrapper for breadcrumbs: Administration part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33111 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:49:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:49:43 +0000 Subject: [Koha-bugs] [Bug 33111] Use template wrapper for breadcrumbs: Administration part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33111 --- Comment #3 from Katrin Fischer --- Created attachment 149332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149332&action=edit Bug 33111: (QA follow-up) Add more context to breadcrumb parts for easier translation With the new wrappers we will translate every part of the breadcrumb as a separate string and only once. So single words like 'new' can be problematic in translation. This changes: * New > New identity provider * Edit > Edit identity provider * (Item search fields) > Edit Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:50:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:50:23 +0000 Subject: [Koha-bugs] [Bug 33077] Improve ease of translating template title tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:58:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:58:19 +0000 Subject: [Koha-bugs] [Bug 33077] Improve ease of translating template title tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:58:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:58:22 +0000 Subject: [Koha-bugs] [Bug 33077] Improve ease of translating template title tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147794|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 149333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149333&action=edit Bug 33077: Improve ease of translating template title tags This patch uses the cities administration page as a proof-of-concept for using the [% t() %] construction to wrap translatable string in template tags. This should result in a significant improvement in translatability. To test, apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files: - In fr-FR-staff-prog.po you should no longer see a reference to cities.tt line 6, "#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt:6" - In fr-FR-messages.po you should see several strings which have been pulled individually from the <title> tag: - cities.tt:9, msgid "Modify city" - cities.tt:11, msgid "New city" - cities.tt:15, msgid "Confirm deletion of city" - cities.tt:19, msgid "Administration", msgid "Cities", msgid "Koha", and msgid "Administration" Translate the strings in fr-FR-messages.po and install the updated translation: perl misc/translator/translate install fr-FR Swith to the update language in the staff interface and confirm that the Cities page title is translated correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 00:58:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 22:58:49 +0000 Subject: [Koha-bugs] [Bug 33007] Use template wrapper for breadcrumbs: Administration part 2 In-Reply-To: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33007-70-OXrD0G5gS4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33007 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 01:07:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 23:07:20 +0000 Subject: [Koha-bugs] [Bug 33007] Use template wrapper for breadcrumbs: Administration part 2 In-Reply-To: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33007-70-Jkd03ewQLE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33007 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 01:07:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 23:07:22 +0000 Subject: [Koha-bugs] [Bug 33007] Use template wrapper for breadcrumbs: Administration part 2 In-Reply-To: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33007-70-Xuv4O8qbk9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33007 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148908|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149334&action=edit Bug 33007: Use template wrapper for breadcrumbs: Administration part 2 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. Note: The patch includes indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> - Authorized values - New category - View category - Add authorized value - Edit authorized value - Authority types - New authority type - Edit authority type - Confirm deletion of authority type - Manage jobs - Details of job - MARC bibliographic framework - New framework - Edit framework - Confirm deletion of framework - Library transfer limits - Libraries - New library - Edit library - Confirm deletion of library - Cash registers - New cash register - Edit cash register - Patron categories - New category - Edit category - Confirm deletion of category - MARC bibliographic framework test - Classification configuration - Modify classification source - Add classification source - Modify filing rule - Add filing rule - Modify splitting rule - Add splitting rule Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 01:26:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 23:26:02 +0000 Subject: [Koha-bugs] [Bug 33462] New: Force password change for new patrons Message-ID: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 Bug ID: 33462 Summary: Force password change for new patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Patrons that register via OPAC create whatever password they want. But when staff create a patron account, patrons are given a password. It would be preferred if patrons were forced to change their password after first logging in when a staff member creates the account. Unfortunately, the password expiration field is not available when creating the account. It is only editable after. It would be ideal if the password field were shown, even when adding a new patron, and the patron category setup page had an option next to expiration settings to force patron to change password at login when entered by staff. Then, when a staff member is adding the new patron, the date could be defaulted to today. The OPAC self registration would not need to do this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 01:26:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 23:26:25 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33462-70-1jqk36fnoo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Force password change for |Force password change for |new patrons |new patrons entered by | |staff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 01:38:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 23:38:19 +0000 Subject: [Koha-bugs] [Bug 31422] Library limitations might cause data loss when editing patrons In-Reply-To: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31422-70-H4BOoHSjhA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31422 --- Comment #22 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Lucas Gass from comment #17) > This, and Bug 32119, contain too many merge conflicts for 22.05.x. So no > backport. Oh no! We could really use this. That is too bad! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 01:41:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 23:41:23 +0000 Subject: [Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt In-Reply-To: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33088-70-rWzX9bcHa4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 01:41:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 23:41:25 +0000 Subject: [Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt In-Reply-To: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33088-70-8NIbF43X8A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148398|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 149335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149335&action=edit Bug 33088: Remove background-job-progressbar.js in batch_record_modification.tt It must be removed, we don't need it since bug 22417 Test plan : Play with batch record modification and check there is no JS error Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 01:43:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 23:43:26 +0000 Subject: [Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt In-Reply-To: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33088-70-bsMm6M1GzA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- Testing notes: 1. Ran some batch record modification jobs (used tempplate to add some text to 521$a): no JavaScript errors, everything worked as expected. 2. Hope this is sufficient. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 01:45:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Apr 2023 23:45:43 +0000 Subject: [Koha-bugs] [Bug 33461] Password reset should act like patron expiration when there are no notices available In-Reply-To: <bug-33461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33461-70-95MKEcMfI6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33461 --- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Katrin Fischer from comment #1) > I am not sure where a code would come in and how would it be communicated to > the user? If staff set the reset for a patron, we are usually confirming the patron through other means (via photo id or questions via phone). If the system sees that there is no email or text, it could generate the code and put it in place of the password, and the staff can tell the patron what that code is. This guarantees that only the person they verified with can reset the password, not just someone that might have access to the link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 06:47:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 04:47:29 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-7uUJMdUyN8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149192|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Created attachment 149336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149336&action=edit Bug 33402: Move ERM Cypress tests to their own directory We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts ) to their own subdirectory, eg t/cypress/integration/ERM Test plan: Confirm that the cypress tests are still passing after this change: perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 06:47:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 04:47:45 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-44AAB26uaR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Works[1], makes sense, QA script happy, code looks good, passing QA :) [1] with and without the patch, I got the same consistent failures of Licenses_spec.ts and random failures in other files. btw, is the CI running them? I couldn't find cypress output in the last builds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 12:07:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 10:07:09 +0000 Subject: [Koha-bugs] [Bug 28806] Labels exported as PDF create zero sized PDF files. In-Reply-To: <bug-28806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28806-70-so3oJuVfxj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28806 --- Comment #30 from Manos PETRIDIS <egpetridis at yahoo.com> --- Created attachment 149337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149337&action=edit Apache log Apache log, after a restart and an attempt to create pdf labels. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:18:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:18:06 +0000 Subject: [Koha-bugs] [Bug 33006] Use template wrapper for breadcrumbs: Administration part 1 In-Reply-To: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33006-70-YG6DdfZzMF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33006 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:18:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:18:10 +0000 Subject: [Koha-bugs] [Bug 33006] Use template wrapper for breadcrumbs: Administration part 1 In-Reply-To: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33006-70-OTUNOmtRfv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33006 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147092|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149338&action=edit Bug 33006: Use template wrapper for breadcrumbs: Administration part 1 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. Note: The patch includes indentation changes, so ignore whitespace when viewing the diff. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> Administration home page - Under "Additional parameters" -> Additional fields -> View, create, edit -> Advanced editor shortcuts -> Audio alerts - Under "Acquisition parameters" -> Budgets -> Add fund -> Close fund -> Budget details -> Planning -> Create, edit, duplicate - Under "Catalog" -> Authority types -> MARC structure -> New, edit, delete -> "Actions" -> Subfields -> Edit, delete Acquisitions -> Vendor -> Contracts - View, edit, delete Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:18:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:18:13 +0000 Subject: [Koha-bugs] [Bug 33006] Use template wrapper for breadcrumbs: Administration part 1 In-Reply-To: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33006-70-4NeqHY3hdc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33006 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149053|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149339&action=edit Bug 33006: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> This patch also modifies some of the templates to simplify the logic controlling how different elements of the breadcrumbs are shown or not. This patch also modifies another problematic set of strings in auth_tag_structure.tt outside the breadcrumbs. Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:18:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:18:39 +0000 Subject: [Koha-bugs] [Bug 33006] Use template wrapper for breadcrumbs: Administration part 1 In-Reply-To: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33006-70-PijsvmWFH3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33006 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:18:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:18:47 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-Gs3XtWPDKq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:19:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:19:19 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-HMZqjcVtbC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:19:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:19:21 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-llgDBPqvR5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149242|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149340&action=edit Bug 33005: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:19:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:19:24 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-mVzGBdvQIN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149341&action=edit Bug 33005: (QA follow-up) Update breadcrumb when editing a vendor When editing a vendor the last part of the breadcrumbs read: Update: <vendor> This is very unusual, so updated to the standard wording: Modify <vendor> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:19:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:19:58 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-tmo30JEhRD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149241|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149342&action=edit Bug 33005: Use template wrapper for breadcrumbs: Acquisitions part 3 This patch updates several acquisitions-related templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Acquisitions -> -> All available funds table -> Ordered -> Spent -> Vendor -> Vendor details -> Uncertain prices -> Receive shipments (must have at least one open basket) -> If necessary, receive a new shipment. Or click an invoice number to reach the "receive orders" page. -> Click "Receive" in the table listing baskets. -> Basket -> Add to basket -> From a suggestion -> From an external source Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:20:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:20:01 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-rG5tLF4Szz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149340|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149343&action=edit Bug 33005: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:20:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:20:04 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-9RUeFpgqup@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149341|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149344&action=edit Bug 33005: (QA follow-up) Update breadcrumb when editing a vendor When editing a vendor the last part of the breadcrumbs read: Update: <vendor> This is very unusual, so updated to the standard wording: Modify <vendor> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:20:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:20:46 +0000 Subject: [Koha-bugs] [Bug 33001] Use template wrapper for breadcrumbs: Acquisitions part 2 In-Reply-To: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33001-70-XuzbOtKtmD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33001 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:21:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:21:20 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-2cIgTuhHG1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149345&action=edit Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2 This patch updates several acquisitions-related templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Acquisitions -> - Late orders, - moddeliverydate.tt - modordernotes.tt -- These two templates aren't linked to from anywhere, but you can navigate directly to: http://127.0.0.1:8081/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=X and http://127.0.0.1:8081/cgi-bin/koha/acqui/moddeliverydate.pl?ordernumber=1 - Order search, order search results - Invoice search, - Invoice details, - Invoice files - Vendor -> Basket -> Add to basket -> - From a new (empty) record - From existing orders (copy) - From a subscription Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:21:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:21:22 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-mrgpQKZftL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149346&action=edit Bug 33001: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:22:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:22:55 +0000 Subject: [Koha-bugs] [Bug 33001] Use template wrapper for breadcrumbs: Acquisitions part 2 In-Reply-To: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33001-70-MOJA3WKtdn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33001 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:22:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:22:58 +0000 Subject: [Koha-bugs] [Bug 33001] Use template wrapper for breadcrumbs: Acquisitions part 2 In-Reply-To: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33001-70-KfmdPOY7RR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33001 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149140|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149347&action=edit Bug 33001: Use template wrapper for breadcrumbs: Acquisitions part 2 This patch updates several acquisitions-related templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Acquisitions -> - Late orders, - moddeliverydate.tt - modordernotes.tt -- These two templates aren't linked to from anywhere, but you can navigate directly to: http://127.0.0.1:8081/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=X and http://127.0.0.1:8081/cgi-bin/koha/acqui/moddeliverydate.pl?ordernumber=1 - Order search, order search results - Invoice search, - Invoice details, - Invoice files - Vendor -> Basket -> Add to basket -> - From a new (empty) record - From existing orders (copy) - From a subscription Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> https://bugs.koha-community.org/show_bug.cgi?id=33005 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:23:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:23:01 +0000 Subject: [Koha-bugs] [Bug 33001] Use template wrapper for breadcrumbs: Acquisitions part 2 In-Reply-To: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33001-70-MxDzTSe3om@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33001 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149141|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149348&action=edit Bug 33001: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> https://bugs.koha-community.org/show_bug.cgi?id=33005 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:23:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:23:47 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-GrKhB9DEEt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:23:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:23:48 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-NtrkOCIEIM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149345|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:23:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:23:50 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-xKeaiMhIvw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149346|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:24:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:24:35 +0000 Subject: [Koha-bugs] [Bug 32998] Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib In-Reply-To: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32998-70-q49AxmTs6X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32998 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:24:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:24:46 +0000 Subject: [Koha-bugs] [Bug 32998] Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib In-Reply-To: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32998-70-Z7grgEPvPI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32998 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:24:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:24:51 +0000 Subject: [Koha-bugs] [Bug 32998] Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib In-Reply-To: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32998-70-F28A2RRH0b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32998 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148902|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149349&action=edit Bug 32998: Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib This patch moves OPAC third-party assets from opac-tmpl/bootstrap/lib to opac-tmpl/lib, eliminating some redundancy and making it simpler to understand where such assets should be found. To test, apply the patch and confirm that there is no longer a lib directory under opac-tmpl/bootstrap. Test various parts of the OPAC to confirm that assets are still loading correctly. Everything should look right and work correctly. The browser's developer console should be free of errors. Signed-off-by: Philip Orr <philip.orr at lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:25:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:25:17 +0000 Subject: [Koha-bugs] [Bug 32956] Use template wrapper for HTML customizations tabs In-Reply-To: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32956-70-LVlZ3dbRTe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32956 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:25:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:25:51 +0000 Subject: [Koha-bugs] [Bug 32956] Use template wrapper for HTML customizations tabs In-Reply-To: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32956-70-PcxSf6ESNS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32956 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:25:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:25:53 +0000 Subject: [Koha-bugs] [Bug 32956] Use template wrapper for HTML customizations tabs In-Reply-To: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32956-70-wxtKv5NHug@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32956 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148795|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149350&action=edit Bug 32956: Use template wrapper for HTML customizations tabs This patch updates the HTML customizations template to replace tab markup with the use of WRAPPERs. - Apply the patch and go to Tools -> HTML customizations. - Create or edit an entry. - You should see tabs for each available language, for example Default, English, French. - Test adding content to each language to confirm that the correct information is saved under the correct tab. Signed-off-by: Philip Orr <philip.orr at lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:26:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:26:26 +0000 Subject: [Koha-bugs] [Bug 32955] Standardize structure around action fieldsets in various templates In-Reply-To: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32955-70-ziiMM394Wb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32955 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:26:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:26:57 +0000 Subject: [Koha-bugs] [Bug 32955] Standardize structure around action fieldsets in various templates In-Reply-To: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32955-70-WxyV7s0sC0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32955 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:27:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:27:00 +0000 Subject: [Koha-bugs] [Bug 32955] Standardize structure around action fieldsets in various templates In-Reply-To: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32955-70-h6CAnv5DZZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32955 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148915|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149351&action=edit Bug 32955: Standardize structure around action fieldsets in various templates This patch updates various templates so that fieldsets with the "action" class are placed outside the form's main fieldset. To test, apply the patch and check the following pages to confirm that changes to form structure look correct: - Cataloging -> Quick spine label creator - Patrons -> Patron details -> Files - Patrons -> Patron details -> Housebound - Circulation -> Upload offline circulation file - Tools -> Patron card creator -> Manage -> Images - Point of sale -> Transaction history -> "Older transactions" form Signed-off-by: Philip Orr <philip.orr at lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:28:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:28:01 +0000 Subject: [Koha-bugs] [Bug 32634] Add 'page-section' to various pages In-Reply-To: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32634-70-enZnE0Aa97@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:28:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:28:04 +0000 Subject: [Koha-bugs] [Bug 32634] Add 'page-section' to various pages In-Reply-To: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32634-70-DrX4BAlAD5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148904|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149352&action=edit Bug 32634: Add 'page-section' to various pages This patch adds a "page-section" container div around the main section of various pages which lack it. This patch contains indentation changes, so please ignore whitespace when looking at the diff. Apply the patch and view the following pages to confirm that the main content is contained in a white box: - Locate a patron who has one or more account transactions. - Go to the Accounting tab -> Transactions. Click "Details" on one of the lines. - The "Details of debit" and "History" sections should be wrapped in .page-section. - Go to Tools -> Patron card creator -> Manage -> Batches - If there is not a list of batches you will need to create at least one to see the page-section container. - Go to Reports -> View dictionary. - If necessary, add a definition. - The "Current terms" table should be wrapped in .page-section. - Go to Lists and view the contents of a list with one or more titles on it. The table of titles should be wrapped in .page-section. - Go to Circulation -> Upload offline circulation file (.koc) - Upload a .koc file and click the "Add to offline circulation queue." - On the confirmation page the "Your file was uploaded" message should be wrapped in .page-section. - Click "View pending offline circulation actions" - The list of pending actions should be wrapped in .page-section Signed-off-by: Magnus Enger <magnus at libriotech.no> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:28:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:28:07 +0000 Subject: [Koha-bugs] [Bug 32634] Add 'page-section' to various pages In-Reply-To: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32634-70-FNvEdUTMaU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148905|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149353&action=edit Bug 32634: (follow-up) Restructure page headings An error in template logic is preventing the page's h1 from displaying. Rather than fixing this I have changed the h1 to display a generic "Transaction details" h1. The h2 shows the transaction type (credit or debit). The h2 is now inside the .page-section. Signed-off-by: Magnus Enger <magnus at libriotech.no> Checked all the places mentioned in the commit message, and they all have .page-section now. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:28:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:28:18 +0000 Subject: [Koha-bugs] [Bug 32634] Add 'page-section' to various pages In-Reply-To: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32634-70-sqrB8G8p98@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:31:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:31:09 +0000 Subject: [Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off In-Reply-To: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31722-70-zbkWS1TSy1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:31:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:31:52 +0000 Subject: [Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off In-Reply-To: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31722-70-sfw2qPfgZl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:31:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:31:54 +0000 Subject: [Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off In-Reply-To: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31722-70-WUhLHkuEcB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148976|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149354&action=edit Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on This patch makes a small change to the display of the note "No EDIFACT configuration for..." on the basket group page to only display if the system preference EDIFACT is set to "Enable". To Test: 1. apply patch 2. navigate to a vendor over Acquisitions -> Vendor e.g. My Vendor 3. create a basket group (doesn't have to have any baskets, an empty one will do) 4. close the basket group 5. set system preference "EDIFACT" to "Enable" 6. navigate to Administration -> EDI Accounts and make sure the vendor doesn't have an EDI account configured 7. navigate to your vendor's closed basket groups over Acquisitions -> Vendor -> Basket groups (left panel) -> Tab "Closed" 8. you should see a message "No EDIFACT configuration for (name of vendor)" in the Action column 9. set system preference "EDIFACT" to "Disable" 10. go back to your vendor's closed basket groups 11. you shouldn't see the message "No EDIFACT configuration for (name of vendor)" Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:36:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:36:05 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-rhvIp8RQyo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am not so happy about the placement. Alternative suggestion: could we place it on the reports start page below the "Other" section? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:45:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:45:49 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-V6wRjRlO86@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149355&action=edit Bug 33356: [Alternate) Add mana-kb hint to reports start page An alternate placement of the Mana KB hint on the reports start page. To test: * Go to Reports module * Verify the hint shows when you haven't decided on Mana KB * Once you set yes or no, it will no longer show -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:46:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:46:29 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-53pSjoB1a9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org Status|Signed Off |Needs Signoff --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:50:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:50:03 +0000 Subject: [Koha-bugs] [Bug 33261] Dates for issues on subscription detail page display unformatted In-Reply-To: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33261-70-2IDjzp5NSV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33261 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:50:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:50:11 +0000 Subject: [Koha-bugs] [Bug 33261] Dates for issues on subscription detail page display unformatted In-Reply-To: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33261-70-u0D8T1iW5M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33261 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:50:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:50:13 +0000 Subject: [Koha-bugs] [Bug 33261] Dates for issues on subscription detail page display unformatted In-Reply-To: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33261-70-fefkoOFfEC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33261 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149108|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149356&action=edit Bug 33261: Format dates in subscription_issues table To test: * Add a subscription * Receive some issues * Go to the subscription detail page, issues tab * Verify the dates there display as YYYY-MM-DD * Change DateFormat system preference setting, nothing changes. * Apply patch * Date should now be formatted in the way specified in the DateFormat system preference Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:56:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:56:13 +0000 Subject: [Koha-bugs] [Bug 33265] Additional unformatted navigation items when on serial receive page In-Reply-To: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33265-70-kcQPt3Fb4K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33265 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:56:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:56:15 +0000 Subject: [Koha-bugs] [Bug 33265] Additional unformatted navigation items when on serial receive page In-Reply-To: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33265-70-z4dbFlcteJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33265 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149128|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149357&action=edit Bug 33265: Clean up serial links on serial edit page To test: 1. Reviece a serial 2. Notice the unstyled links: * Serial collection #1 * Subscription #1 * Show biblio 3. Apply pacth 4. The links should now be styled. Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 13:57:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 11:57:14 +0000 Subject: [Koha-bugs] [Bug 33265] Additional unformatted navigation items when on serial receive page In-Reply-To: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33265-70-36VY7CgljO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33265 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- There is a little more margin at the top of these elements to the other navigation items, but I think that works here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:05:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:05:13 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27775-70-ArxjB9O1iN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:05:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:05:16 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27775-70-Uz1p9UUX3C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149309|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149358&action=edit Bug 27775: Add hint about drag and drop feature on framework subfield edit Bug 8976 introduced a way to sort subfields on a MARC/Auth framework using drag and drop. But there's no visible hint alerting the user the feature exists. Test plan : 1) Go to Admistration > MARC bibliographic framework 2) Choose a framework and click on Actions > MARC structure 3) Choose a field and click on Actions > Edit subfields 4) Check you see the hint 5) Go to Admistration > Authority types 6) Choose a type and click on Actions > MARC structure 7) Choose a field and click on Actions > Subfields 8) Click on Edit subfields 9) Check you see the hint Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:05:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:05:18 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27775-70-1aTvWz62mB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149359&action=edit Bug 27775: (QA follow-up) Slightly change of wording Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:05:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:05:28 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27775-70-ceCKrHN7Nf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:08:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:08:31 +0000 Subject: [Koha-bugs] [Bug 33463] New: 'Actions' column on plugins table should not be sortable Message-ID: <bug-33463-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33463 Bug ID: 33463 Summary: 'Actions' column on plugins table should not be sortable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The last column in the plugins table is 'Actions' and should not be sortable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:10:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:10:29 +0000 Subject: [Koha-bugs] [Bug 33336] Use a dedicated column for plugin status in plugins table In-Reply-To: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33336-70-NFTg3uBroV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:10:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:10:31 +0000 Subject: [Koha-bugs] [Bug 33336] Use a dedicated column for plugin status in plugins table In-Reply-To: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33336-70-ww8RNxkCNs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148765|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149360&action=edit Bug 33336: Use a dedicated column for plugin status in plugins table In plugins table plugins/plugins-home.pl the status enable/disable is with the name, styled as a label. With new interface ENABLED is yellow, this looks weird. Also I bet this is bad for accessibility. I propose to move this info to a dedicated column. I use bootstrap classes bg-success and bg-warning like in about.pl Test plan: 1) Install some plugins 2) Go to Administration > Manage plugins 3) Check you see table with column status 4) Disable a plugin 5) Check you see 'Disabled' in status Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:14:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:14:03 +0000 Subject: [Koha-bugs] [Bug 33464] New: Report "Orders by fund" is missing page section on results Message-ID: <bug-33464-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33464 Bug ID: 33464 Summary: Report "Orders by fund" is missing page section on results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The Orders by fund report is missing the page section on its results table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:14:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:14:14 +0000 Subject: [Koha-bugs] [Bug 33464] Report "Orders by fund" is missing page-section class on results In-Reply-To: <bug-33464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33464-70-lW5UMxJwRo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33464 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Report "Orders by fund" is |Report "Orders by fund" is |missing page section on |missing page-section class |results |on results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:14:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:14:57 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33414-70-cgq9R4bJsF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:14:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:14:59 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33414-70-P7bIn0D3CT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149156|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149361&action=edit Bug 33414: Fix dates display in orders by fund Since Bug 30718, dates are displayed in ISO format in orders by fund. It removed dates formating in perl, this must be added in template. Test plan : 1) Create some fresh orders on a fund F1 2) Go to Acquisitions > Orders by fund 3) Select fund F1 and 'To screen into the browser' 4) Submit 5) Check you see a formatted date in 'Entry date' column 6) Recieve some order from fund F1 Repeat 2 to 4 7) Check you see formatted date in 'Date received' column Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:15:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:15:02 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33414-70-9I0d9R2SCs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149157|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149362&action=edit Bug 33414: Add the data-order class Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:15:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:15:08 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33414-70-3Fg8SenDs0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:19:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:19:18 +0000 Subject: [Koha-bugs] [Bug 33345] On-site checkout checkbox does not work since issue date using flatpickr In-Reply-To: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33345-70-I8J96sa9WT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Verified that this restores the previous behavior (tested in 20.11). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:19:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:19:23 +0000 Subject: [Koha-bugs] [Bug 33345] On-site checkout checkbox does not work since issue date using flatpickr In-Reply-To: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33345-70-v4kKfkpkat@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:19:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:19:44 +0000 Subject: [Koha-bugs] [Bug 33345] On-site checkout checkbox does not work since issue date using flatpickr In-Reply-To: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33345-70-N4mrOIuV67@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:19:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:19:46 +0000 Subject: [Koha-bugs] [Bug 33345] On-site checkout checkbox does not work since issue date using flatpickr In-Reply-To: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33345-70-KOgGaDrHwn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149298|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149363&action=edit Bug 33345: On-site checkout checkbox does not work since issue date using flatpickr Since Bug 30718, date due uses flatpickr. The JavaScript code setting due date via on-site checkout checkbox needs to be adapted. Sort of like Bug 30717. This patch renames the variable sent to template 'today_due_date_and_time' to avoid confusion with variable 'todaysdate' used in other templates. Test plan : 1) Enable system preference 'OnSiteCheckouts' 2) Go to a patron circulation page /cgi-bin/koha/circ/circulation.pl 3) Click on settings icon inside barcode input => Check due date input is empty 4) Click on 'On-site checkout' => Check due date input is filled with today date at 23:59 5) Fill barcode input and do check-out 6) Check due date is correct Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:24:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:24:25 +0000 Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in templates In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32127-70-AAxfh3kzWA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:24:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:24:27 +0000 Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in templates In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32127-70-jUd7GL00kd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149099|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149364&action=edit Bug 32127: Sort by description in Koha::Template::Plugin::Categories Like in Koha::Template::Plugin::Branches, methods in Koha::Template::Plugin::Categories must return categories sorted by description. Test plan : 1) Create a new patron category with code ZZZ and description AAAAAA 2) Go to patron search /cgi-bin/koha/members/members-home.pl 3) Look at filter by category : => Without patch the value AAAAAA is last => With patch the value AAAAAA is first 4) Click on 'New patron' => Without patch the value AAAAAA is last => With patch the value AAAAAA is first Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:24:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:24:30 +0000 Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in templates In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32127-70-lfC5stwkZo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149100|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149365&action=edit Bug 32127: Add unit test Run prove t/db_dependent/Template/Plugin/Categories.t Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 14:31:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 12:31:22 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31695-70-VcSGQUlGhN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Frido or Kevin, can you please update/detail the test plan a little? What I tried without the patch: * Add 035$a to an authority record with 12345678 * Search for it in staff: entire record, contains = it's found * Search for it in staff: entire record, is exactly = it's found There is no standard number option in the index pull down for authorities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:17:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:17:38 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21330-70-bGi4tumzGA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:17:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:17:42 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21330-70-56wh4N8Loi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148969|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149366&action=edit Bug 21330: Allow XSLT for authority detail view in OPAC This patch adds a syspref that allow to customize the authority detail view in OPAC with XSLT. Test plan: 1. Make sure to have at least one or more authorities 2. OPAC: Home > Authority search(Submit) > Authority search results 3. Click details on a result and notice the view 4. Apply patch 5. INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacDetailsDisplay" 6. Write the path where your file is. You can try with the XSLT for biblio for instance: .../koha/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl 7. Save changes 8. Repeat 2-3 and notice the display Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Thibault <thibault.keromnes at univ-paris8.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:17:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:17:45 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21330-70-qLAaTDjLNM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148970|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149367&action=edit Bug 21330: (follow-up) Update system preference description Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Thibault <thibault.keromnes at univ-paris8.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:17:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:17:49 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21330-70-beb0XolUD4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148971|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149368&action=edit Bug 21330: (follow-up) Fix new preference text and place Atomic updated fixed : intranet => OPAC Changed to be more like the one adding AuthorityXSLTOpacResultsDisplay New preference moved to opac.pref Signed-off-by: Thibault <thibault.keromnes at univ-paris8.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:17:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:17:53 +0000 Subject: [Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC In-Reply-To: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21330-70-o8uhdqMk6o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330 --- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149369&action=edit Bug 21330: (QA follow-up) Add 'empty' option to system preference description This adds another list item to match the preference description for the results page: * Empty. No XSLT will be applied (default) Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:19:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:19:50 +0000 Subject: [Koha-bugs] [Bug 33367] tmp/modified_authorities/README.txt seems useless In-Reply-To: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33367-70-nPvC4ZRbPv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:21:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:21:01 +0000 Subject: [Koha-bugs] [Bug 33367] tmp/modified_authorities/README.txt seems useless In-Reply-To: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33367-70-HyRiTIFO1O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:21:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:21:04 +0000 Subject: [Koha-bugs] [Bug 33367] tmp/modified_authorities/README.txt seems useless In-Reply-To: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33367-70-5w3jbV688A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149286|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149370&action=edit Bug 33367: Remove tmp/modified_authorities/README.txt This does not seem to be useful anymore. Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:30:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:30:06 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-ohQVklDGBh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Do we have instructions on how to run the Cypress tests somewhere? ... or in other words, can you please add a test plan? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:31:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:31:49 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-63MbpXkzpy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Sorry, the test plan is not detailed enough for me - can you please add some more info? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:41:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:41:14 +0000 Subject: [Koha-bugs] [Bug 33465] New: Make it clear if there are linked licenses when viewing the vendor record Message-ID: <bug-33465-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33465 Bug ID: 33465 Summary: Make it clear if there are linked licenses when viewing the vendor record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: katrin.fischer at bsz-bw.de CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 33106 Bug 33106 added a new tab to the vendors detail page that will take you to the licenses page in the ERM module and show any linked licenses for the vendor. At the moment you cannot tell without clicking the tab, if there are any linked licenses. There are 2 options that could improve things here: * Only show the tab if there are linked licenses * Show the number of linked licenses in the tab description I am leaning a little to the second and it would match what we do in the catalog detail page for holds and other things. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33106 [Bug 33106] Add vendor link to ERM Licences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:41:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:41:14 +0000 Subject: [Koha-bugs] [Bug 33106] Add vendor link to ERM Licences In-Reply-To: <bug-33106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33106-70-98ADthAP1l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33106 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33465 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33465 [Bug 33465] Make it clear if there are linked licenses when viewing the vendor record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:48:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:48:51 +0000 Subject: [Koha-bugs] [Bug 33106] Add vendor link to ERM Licences In-Reply-To: <bug-33106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33106-70-HKLOuZ9X8N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33106 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #11) > (In reply to Jonathan Field from comment #9) > > That works now, thanks for fixing that! I still think it would be good to > > not display the link if there is no attached record but I think we can deal > > with that in a separate bugzilla entry, this works as planned. > > I am not sure about that. The other tabs are there even if there is nothing > on the view (for baskets). If we add another tab later (for issues for > instance), it will be placed differently depending on the existence of > license linked to the vendor, that does not seem correct to me. > > We could add the number of licenses in parenthesis but again, it is > inconsistent with the other tabs. > > So basically, yes, we should discuss that on a separate bug :) I agree about the separate bug, so I filed it: Bug 33465 - Make it clear if there are linked licenses when viewing the vendor record I also agree that we should make it visible somehow if there are even licenses linked. Either by not displaying the tab or by showing the number of licenses link in the tab label. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:48:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:48:56 +0000 Subject: [Koha-bugs] [Bug 33106] Add vendor link to ERM Licences In-Reply-To: <bug-33106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33106-70-VJu8aR48wC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33106 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:50:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:50:00 +0000 Subject: [Koha-bugs] [Bug 33106] Add vendor link to ERM Licences In-Reply-To: <bug-33106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33106-70-4Fc6ZlKe2P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33106 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:50:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:50:03 +0000 Subject: [Koha-bugs] [Bug 33106] Add vendor link to ERM Licences In-Reply-To: <bug-33106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33106-70-nb8SPk5ET6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33106 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148946|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149371&action=edit Bug 33106: Add vendor link to ERM licenses This patch adds a "Licenses" link in the acquisition module to link to the licenses defined in the ERM module. Test plan: - Create a vendor - Create some licenses in the ERM module, add some to the vendor previously created - Go to the detail page of the vendor in the acquisition module => Notice the new "Licenses" tab on the side bar => Notice that this tab does not appear if you do not have the permission to see licenses - Click on the new tab => Notice that you are redirected to the license list view, in the ERM module, with an automatic filter on the vendor Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:51:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:51:14 +0000 Subject: [Koha-bugs] [Bug 33466] New: Link vendor name in list of licenses Message-ID: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 Bug ID: 33466 Summary: Link vendor name in list of licenses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: katrin.fischer at bsz-bw.de CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Bug 33106 adds a link from the vendor to the licenses. It would make sense to also have it the other way around. The easiest would be to link the vendor name in the table of licenses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 15:59:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 13:59:57 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-e3E7AQPpoz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact| |katrin.fischer at bsz-bw.de --- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Pedro, can you please clean these up? OK api/v1/swagger/paths/erm_agreements.yaml OK api/v1/swagger/paths/erm_documents.yaml OK api/v1/swagger/paths/erm_eholdings_packages.yaml OK api/v1/swagger/paths/erm_eholdings_packages_resources.yaml OK api/v1/swagger/paths/erm_eholdings_resources.yaml OK api/v1/swagger/paths/erm_eholdings_titles.yaml OK api/v1/swagger/paths/erm_eholdings_titles_resources.yaml OK api/v1/swagger/paths/erm_licenses.yaml OK api/v1/swagger/paths/erm_users.yaml OK erm/erm.pl FAIL installer/data/mysql/atomicupdate/bug_32968.pl FAIL file permissions File must have the exec flag OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc FAIL koha-tmpl/intranet-tmpl/prog/en/modules/erm/erm.tt FAIL filters missing_filter at line 49 ( write: [% CAN_user_erm_erm_licensing || CAN_user_erm_erm_admin ? 1 : 0 %],) missing_filter at line 50 ( read: [% CAN_user_erm_erm_licensing || CAN_user_erm_erm_admin || CAN_user_erm_erm_show || CAN_user_erm_erm_agreement ? 1 : 0 %],) missing_filter at line 53 ( write: [% CAN_user_erm_erm_agreement || CAN_user_erm_erm_admin ? 1 : 0 %],) missing_filter at line 54 ( read: [% CAN_user_erm_erm_agreement || CAN_user_erm_erm_admin || CAN_user_erm_erm_show || CAN_user_erm_erm_eholdings ? 1 : 0 %],) missing_filter at line 57 ( write: [% CAN_user_erm_erm_eholdings || CAN_user_erm_erm_admin ? 1 : 0 %],) missing_filter at line 58 ( read: [% CAN_user_erm_erm_eholdings || CAN_user_erm_erm_admin || CAN_user_erm_erm_show || CAN_user_erm_erm_agreement ? 1 : 0 %],) OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue FAIL koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue FAIL Tidiness File is not tidy, please run `yarn run prettier --trailing-comma es5 --semi false --arrow-parens avoid --write /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue` OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsToolbar.vue OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue FAIL koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue FAIL Tidiness File is not tidy, please run `yarn run prettier --trailing-comma es5 --semi false --arrow-parens avoid --write /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue` OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesToolbar.vue OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue FAIL koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue FAIL Tidiness File is not tidy, please run `yarn run prettier --trailing-comma es5 --semi false --arrow-parens avoid --write /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesShow.vue` OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesToolbar.vue OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue FAIL koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue FAIL Tidiness File is not tidy, please run `yarn run prettier --trailing-comma es5 --semi false --arrow-parens avoid --write /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesShow.vue` OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesToolbar.vue OK koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue OK koha-tmpl/intranet-tmpl/prog/js/vue/routes/erm.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 16:01:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 14:01:16 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-08PPFBea8M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Summary|Add vendor Interfaces |Add vendor interfaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 16:01:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 14:01:46 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-wHvS2mLeRW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 16:17:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 14:17:24 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-S3g8T3A3mO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 16:37:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 14:37:18 +0000 Subject: [Koha-bugs] [Bug 33467] New: Hacked by lord badut Message-ID: <bug-33467-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33467 Bug ID: 33467 Summary: Hacked by lord badut Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: samuelnasib006 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Created attachment 149372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149372&action=edit Hacked By LORD BADUT Hacked by LORD BADUT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 16:39:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 14:39:23 +0000 Subject: [Koha-bugs] [Bug 33468] New: Hacked by lord badut Message-ID: <bug-33468-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33468 Bug ID: 33468 Summary: Hacked by lord badut Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: samuelnasib006 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 149373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149373&action=edit Hacked By LORD BADUT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 16:41:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 14:41:04 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-PDIGb3Tmpr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- 1) Please check: OK Koha/Acquisition/Bookseller.pm FAIL Koha/Acquisition/Bookseller/Alias.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/Acquisition/Bookseller/Aliases.pm OK Koha/Schema/Result/Aqbookseller.pm FAIL Koha/Schema/Result/AqbooksellerAlias.pm FAIL pod coverage POD is missing for koha_object_class POD is missing for koha_objects_class 2) Vendor detail page * We should add some space between the the alias name and the trash * More important: it needs at least a tool tip, right now it's a big accessibility issue. I believe with aria-hidden=true it will actually be invisible to screen readers? * Same goes for the Plus icon to add another field: space and accessibility. * When you click 'enter' in the field, the form submits 'save' and you are back on the detail page, but the alias was not saved. 3) Other features * Search and display in the aquisition module work nicely 4) ERM module I am not persuaded by the display tbh, I believe it will get messy very soon as often those aliases will be quite long and we might even want to record a slight name change. Could it be an option to show the aliases in the list as "second level" entries, kind of a hiearchical display, like we have it for funds? I know that CORAL uses the aliases also for matching in some form (I believe when importing data), so it will be really nice to have this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 16:46:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 14:46:43 +0000 Subject: [Koha-bugs] [Bug 33467] Hacked by lord badut In-Reply-To: <bug-33467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33467-70-pFGarhn3Ks@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33467 Hacked by LORD BADUT <samuelnasib006 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samuelnasib006 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 16:48:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 14:48:38 +0000 Subject: [Koha-bugs] [Bug 33469] New: Hacked by lord badut Message-ID: <bug-33469-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33469 Bug ID: 33469 Summary: Hacked by lord badut Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.druart+koha at gmail.com Reporter: samuelnasib006 at gmail.com Created attachment 149374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149374&action=edit Retas web anda -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 16:55:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 14:55:35 +0000 Subject: [Koha-bugs] [Bug 33467] SPAM In-Reply-To: <bug-33467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33467-70-pIJJDv50oK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33467 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hacked by lord badut |SPAM Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 16:58:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 14:58:14 +0000 Subject: [Koha-bugs] [Bug 33469] SPAM In-Reply-To: <bug-33469-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33469-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33469-70-XsSshiuJAL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33469 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Hacked by lord badut |SPAM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:29:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 15:29:36 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-n888MvXP8l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- 1) I18N ol.append(`<li><button class="btn btn-default" onclick="remove_interface(${i});"><i class="fa fa-trash"></i> Delete interface</li>`); 2) Vendor search * I am seeing a strange effect there: the "My Vendor" vendor with booksellerid=1 is showing up twice after applying the patch. Switching back to master makes the doubled up vendor go away. 3) Vendor edit form * Adding the email validation to the email field would be good. * If you add multiple interfaces, the type pull down empties/resets to "" for all interfaces when clicking on "Add another interface". This also happens to the already saved interfaces. 4) Vendor details page * The new information is not displaying correctly (see screenshot). I did a yarn build and reset_all, nothing would fix. Background is wrong and also the line height doesn't match with the other sections on the page. 5) Database update and sample data * This appears complete and correct :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:31:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 15:31:07 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-jCjBBUrtSv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149375&action=edit Screenshot of vendor detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:35:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 15:35:35 +0000 Subject: [Koha-bugs] [Bug 33446] Revert transit status should have the option to cancel the item transfer as well In-Reply-To: <bug-33446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33446-70-czJpjYSwBx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33446 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:40:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 15:40:37 +0000 Subject: [Koha-bugs] [Bug 26967] Patron autocomplete does not correctly format addresses In-Reply-To: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26967-70-YXG4zxwbg9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26967 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:40:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 15:40:39 +0000 Subject: [Koha-bugs] [Bug 26967] Patron autocomplete does not correctly format addresses In-Reply-To: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26967-70-czQOy2XR1M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26967 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148498|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149376&action=edit Bug 26967: Correctly format patron address in autocomplete We should use the JS function to format patron's address in the autocomplete result Test plan: Search for patron using the autocomplete feature, using the different values of addressformat. The address should be formatted correctly, like other places in Koha. You should also notice that the street number is now displayed. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:44:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 15:44:51 +0000 Subject: [Koha-bugs] [Bug 32782] Add UNIMARC support to the ERM module In-Reply-To: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32782-70-HKkKFMd12r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|UNIMARC support |Add UNIMARC support to the | |ERM module Version|unspecified |master CC| |fridolin.somers at biblibre.co | |m, victor at tuxayo.net --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- We are a little short on UNIMARC users in the current QA team. Frido or Victor, could you take this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:51:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 15:51:43 +0000 Subject: [Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt In-Reply-To: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33088-70-EniV6mcS8l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:56:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 15:56:25 +0000 Subject: [Koha-bugs] [Bug 30860] Add option for CanBookBeReserved to return all item values In-Reply-To: <bug-30860-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30860-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30860-70-3doaZaqZ7E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30860 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:56:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 15:56:28 +0000 Subject: [Koha-bugs] [Bug 30860] Add option for CanBookBeReserved to return all item values In-Reply-To: <bug-30860-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30860-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30860-70-saBEbrNEdR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30860 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149124|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149377&action=edit Bug 30860: Cache CanItemBeReserved return value This patch caches the return value of CanItemBeReserved that could be then returned *on demand* We don't want to introduce side-effects hard to catch from this simple change, so let's return the cache value only from the 2 scripts we are dealing with. This patch requests all item values from CanBookBeReserved on request.pl Before this we either: - Looped every item to find out that book could not be reserved - Looped until we found an item that could be reserved, then looped all items to get statuses In the worst case we avoid double processing a single item, in the best case we avoid double processing all items (if only last on record is holdable) To test: 1 - Find a record in staff client with several items 2 - Set AllowHoldsOnDamagedItems to 'Dont allow' 3 - Add a damaged item to record 4 - Set a hold rule to only allow holds form homebranch and ensure record has items from other branches 5 - Setup things to prevent more items from being held 6 - Attempt hold for patron 7 - Note item statuses 8 - Apply patch 9 - Confirm statuses are as they were before Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:57:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 15:57:44 +0000 Subject: [Koha-bugs] [Bug 30860] Add option for CanBookBeReserved to return all item values In-Reply-To: <bug-30860-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30860-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30860-70-HV6gfbSyob@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30860 --- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Also ran prove t/db_dependent/Holds.t t/db_dependent/Circulation.t Circulation.t gave me some trouble in an unrelated test, but results between master and patched branch match. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 17:58:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 15:58:50 +0000 Subject: [Koha-bugs] [Bug 33284] checkout_renewals table retains checkout history in violation of patron privacy In-Reply-To: <bug-33284-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33284-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33284-70-qBq2ajE0Nm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 20:24:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 18:24:54 +0000 Subject: [Koha-bugs] [Bug 33470] New: Don't calculate overridden values when placing a hold via the REST api Message-ID: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 Bug ID: 33470 Summary: Don't calculate overridden values when placing a hold via the REST api Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com CC: tomascohen at gmail.com When placing a hold via the REST api, we can pass an override to force the hold even if pickup locations are not valid, or hold is not allowed. When this is passed, the calculations that determine if the hold would be allowed are moot, and should not be performed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 20:34:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 18:34:16 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST api In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-mkvmQkUjc4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 20:34:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 18:34:19 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST api In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-IVexgBSb0P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149378&action=edit Bug 33470: Don't calculate overridden hold limits This patch can largely be checked in the code to ensure it makes sense, it moves a conditional up one level for the two different checks that could prevent holds To test: 1 - Attempt to place a hold via the REST API with an invalid pickup location Set pickup location as no in branches to make this easy 2 - Confirm you get an error 3 - Attempt again with header (bug 27760): x-koha-override: any 4 - Hold is placed 5 - Repeat 1-4 above but with an item that cannot be held 6 - Apply patch 7 - Repeat 1-4 above 8 - Results should be the same -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 20:35:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 18:35:06 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST api In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-XQWEtsEyLG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 22:05:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 20:05:54 +0000 Subject: [Koha-bugs] [Bug 33471] New: Improve performance of hold pickup location verification for next available holds Message-ID: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471 Bug ID: 33471 Summary: Improve performance of hold pickup location verification for next available holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When placing a new hold, or updating the location of an existing hold, we verify that the pickup location is valid. To do so we call 'pickup_locations' on the bib, or the item. The item case is trivial, however, for bibs we call Item->pickup_locations for every item on the bib. If we are simply validating a single location this can be quite expensive and unnecessary. I propose adding a new function to specifically validate pickup location for a biblio -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 22:09:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 20:09:36 +0000 Subject: [Koha-bugs] [Bug 33471] Improve performance of hold pickup location verification for next available holds In-Reply-To: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33471-70-wWvMi8elTp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 22:09:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 20:09:38 +0000 Subject: [Koha-bugs] [Bug 33471] Improve performance of hold pickup location verification for next available holds In-Reply-To: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33471-70-jYlJNZRqhA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149379&action=edit Bug 33471: Add validate_pickup_location routine to Koha::Biblio This patch adds a new routine, similar to pickup_locations except that it short circuits once a location has been found as acceptable. To test: 1 - Attempt placing a hold for an acceptable pickup location via the API 2 - Attempt to change pickup location to an invalid location, you are blocked 3 - Attempt to place a another hold via API for an invalid locatoin, you are blocked 4 - Apply patch 5 - Repeat 6 - Results should be the same -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 22:10:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 20:10:46 +0000 Subject: [Koha-bugs] [Bug 33471] Improve performance of hold pickup location verification for next available holds In-Reply-To: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33471-70-6ZFez26tR8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Depends on| |33447, 33470 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 [Bug 33447] Add caching to Biblio->pickup_locations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 [Bug 33470] Don't calculate overridden values when placing a hold via the REST api -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 22:10:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 20:10:46 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-pOLJ6ahaIF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33471 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471 [Bug 33471] Improve performance of hold pickup location verification for next available holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 22:10:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 20:10:46 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST api In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-WXIzCKSxyA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33471 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471 [Bug 33471] Improve performance of hold pickup location verification for next available holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 9 23:04:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Apr 2023 21:04:01 +0000 Subject: [Koha-bugs] [Bug 33472] New: Error 500 when many items attached to bib record Message-ID: <bug-33472-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33472 Bug ID: 33472 Summary: Error 500 when many items attached to bib record Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We have a customer that has bibliographic records with several hundred items attached to each. When searching for these records, an error 500 is displayed instead. Lowering OpacMaxItemsToDisplay from 750 to 75 enables the records to display, although now when you click on the link to view all physical records an error 500 is still generated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 12:38:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 10:38:19 +0000 Subject: [Koha-bugs] [Bug 32634] Add 'page-section' to various pages In-Reply-To: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32634-70-ChYYukGlNp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 Tomås Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 12:38:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 10:38:21 +0000 Subject: [Koha-bugs] [Bug 32634] Add 'page-section' to various pages In-Reply-To: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32634-70-w8WXMQFeIP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 --- Comment #17 from Tomås Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 12:38:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 10:38:24 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-8Hvr4ut6x3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Tomås Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 12:38:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 10:38:26 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-OzhuDf2p3n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #97 from Tomås Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 13:10:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 11:10:53 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-cY1Swv9NmR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #98 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It looks like this broke Jenkins. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 13:21:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 11:21:55 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-cTp68onzPD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #99 from Tomås Cohen Arazi <tomascohen at gmail.com> --- (In reply to Katrin Fischer from comment #98) > It looks like this broke Jenkins. Hey, we need the images rebuilt with the new deps. thanks for reporting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 13:31:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 11:31:37 +0000 Subject: [Koha-bugs] [Bug 32878] Make it impossible to renew the item if it has active item level hold In-Reply-To: <bug-32878-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32878-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32878-70-OshlpGnGmZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32878 --- Comment #19 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Just following up to see if this can be backported to 22.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 13:36:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 11:36:37 +0000 Subject: [Koha-bugs] [Bug 33284] checkout_renewals table retains checkout history in violation of patron privacy In-Reply-To: <bug-33284-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33284-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33284-70-BJDj2wiEyN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Please remember to add the test plan to the commit messages. I am going to use Andrew's from comment 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:28:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 12:28:43 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-KlVtPjOqhh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 Tomås Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:28:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 12:28:45 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-uJL5MRSU8z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 Tomås Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144749|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:28:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 12:28:46 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-JpmFns00ri@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 Tomås Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144750|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 14:29:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 12:29:11 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-5JnMKkVjhK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 --- Comment #10 from Tomås Cohen Arazi <tomascohen at gmail.com> --- Created attachment 149380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149380&action=edit Bug 31795: Add REST endpoint to add an authority To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Make a POST request to /api/v1/authorities with one of the following content type header - application/json - application/marcxml+xml - application/marc-in-json - application/marc 4. If content type is other than application/json, then add the following header to the request: "x-authority-type: <auth type code>" 5. Check that the authority is created 6. Sign off Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 16:25:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 14:25:49 +0000 Subject: [Koha-bugs] [Bug 33284] checkout_renewals table retains checkout history in violation of patron privacy In-Reply-To: <bug-33284-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33284-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33284-70-lDksqOX88s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think that the option to immediately "delete circulation history" from the patron account in the OPAC doesn't work correctly yet. I have no more issues, but there is still a renewal entry that has the renewer_id of my user. The immediately deletion should always work, independent of the privacy setting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 16:27:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 14:27:26 +0000 Subject: [Koha-bugs] [Bug 33284] checkout_renewals table retains checkout history in violation of patron privacy In-Reply-To: <bug-33284-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33284-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33284-70-UYuUgkyvfu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 16:28:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 14:28:14 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-UrNk37zXb2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 16:34:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 14:34:13 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-Zd1wKZJMqi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- I've had many libraries complain about the small size/blurriness of cover images on the results page. We should make Syndetics cover images honor the 'SyndeticsCoverImageSize' in any place where they are displayed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 16:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 14:43:12 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-x4OewQa4kx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 16:43:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 14:43:15 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-HW37Lwzeph@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148139|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149381&action=edit Bug 33192: Update AutoEmailPrimaryAddress to EmailFieldPrimary This patch updates the database to reflect the new name for the AutoEmailPrimaryAddress system preferences Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 16:43:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 14:43:18 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-IpnsOfowk3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148140|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149382&action=edit Bug 33192: Update all occurrences of AutoEmailPrimaryAddress This patch updates all references to AutoEmailPrimaryAddress to refer to EmailFieldPrimary instead. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 16:43:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 14:43:21 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-RD9w9FEWrk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149383&action=edit Bug 33192: Fix it-IT sample data and unit tests To test: * prove t/db_dependent/Message.t * Run the it-IT web installer and make sure 'email' is set. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 16:44:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 14:44:03 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-Gu9FCLgC8J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149383|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149384&action=edit Bug 33192: (QA follow-up) Fix it-IT sample data and unit tests To test: * prove t/db_dependent/Message.t * Run the it-IT web installer and make sure 'email' is set. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 16:44:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 14:44:26 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-A4BoQ5tbHT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:01:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:01:25 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-7CjljnSaBt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Overall this looks good, but we got one blocker: 1) Unit tests are missing. 2) I wonder if we could simplify the system preference description a little: Use the following patron email fields in order of highest precedence first [email|emailpro|B_email] when selecting which email address to use to send patron notices. 2 things: * I think we should list the valid options in the system preference so that when one was deleted, it can be restored more easily. * I have no idea how to translate highest precedence... but what it means is that the first field with an email address will be used, right? Maybe we could phrase it along the lines of: When EmailFieldPrimary is set to 'first valid', check the patron email address fields in the following order and use the first valid email address found: * Not blocker: For languages we can sort the entries with drag&drop. Could this be a possible option here? Or maybe I could file as a separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:02:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:02:39 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-dwjbZ6nk6o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148145|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149385&action=edit Bug 29046: Add 'EmailFieldPrecedence' preference This patch adds a new EmailFieldPrecidence systempreference to allow users to set the precicence in which patron email fields should be used for communications. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:02:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:02:42 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-lTdzNpWNTc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148146|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149386&action=edit Bug 29046: Use EmailFieldPrecedence in first_valid_email_address This patch update the Koha::Patron->first_valid_email_address method to use the newly defined EmailFieldPrecedence preference. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:02:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:02:45 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-qk2IsQJTaq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148155|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149387&action=edit Bug 29046: Change link in EmailFieldPrecedence and add link in EmailFieldPrimary This patch modifies the link in EmailFieldPrecedence to reflect the new name of EmailFieldPrimary. It also adds a note in the latter to set the 'first valid' order in the former. To test: 1. Go to Administration > Global system preferences 2. Search for EmailFieldPrecedence 3. Click on the link in the description --> It should lead to EmailFieldPrimary 4. Read the note in EmailFieldPrimary, make sure the grammar and spelling are correct. 5. Click the link to EmailFieldPrecedence --> It should lead to EmailFieldPrecedence Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:18:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:18:11 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-AuFptOQNAH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:18:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:18:13 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-CvYoPwcHKi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149388&action=edit Bug 32041: Enforce SyndeticsCoverImageSize everywhere This patch add the SyndeticsCoverImageSize to the folling pages: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt To test: 1. Turn on SyndeticsCoverImages and SyndeticsEnabled. 2. Check the staff results page and make sure you can change the image size via SyndeticsCoverImageSize. 3. Check the OPAC results page. 4. Turn on 'OPACShelfBrowser' and make sure you change the image sizes within the shelf browser. 5. Test the OPAC checkout history page. ( opac-readingrecord.tt ) 6. Have a checkout and an overdue to test the 2 tables on the OPAC summary pahe. ( opac-user.tt ) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:18:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:18:25 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-HyFtU1crEC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:31:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:31:14 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-b4k7HHeANa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149295|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- Created attachment 149389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149389&action=edit Bug 33447: Add Cache to Biblio->pickup_locations This is going to have the most effect on records with large numbers of items held by the same library, serial records and the like To test: 1 - Add 500 items to a biblio by select myltiple copies on the add item page 2 - Place a hold via the API and note response time, I found ~3-5 seconds 3 - Apply patch 4 - Restart all 5 - Place hold using api again 6 - Note improved response time, less than 1/2 a second in my tests Signed-off-by: emlam <emily.lamancusa at montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:31:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:31:16 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-4OjACiGde6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149296|0 |1 is obsolete| | --- Comment #4 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- Created attachment 149390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149390&action=edit Bug 33447: Adjust tests Signed-off-by: emlam <emily.lamancusa at montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:32:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:32:11 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-4AQRMlctjC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:41:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:41:17 +0000 Subject: [Koha-bugs] [Bug 33473] New: Allow to send email receipts for payments/writeoff manually instead of automatically Message-ID: <bug-33473-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33473 Bug ID: 33473 Summary: Allow to send email receipts for payments/writeoff manually instead of automatically Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 31448 With bug 31448 it's possible to re-send a failed or lost email receipt. It would be nice if you could turn off the automatic sending of receipts by email and send them just manually whenever requested. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:41:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:41:17 +0000 Subject: [Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled In-Reply-To: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31448-70-k2KXWOozuc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33473 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33473 [Bug 33473] Allow to send email receipts for payments/writeoff manually instead of automatically -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:45:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:45:50 +0000 Subject: [Koha-bugs] [Bug 33474] New: Don't create a notice for patrons without email when UseEmailReceipts is used Message-ID: <bug-33474-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33474 Bug ID: 33474 Summary: Don't create a notice for patrons without email when UseEmailReceipts is used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org With UseEmailReceipts set to "Send" it will always create an entry in the message_queue, even if the user has no email address. We should not create the notice, when the patron has no email. I am not sure about falling back to print since the those would probably just be handed out and not mailed to the patron. There is also already a print option in Accounting to create a printed receipt. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:45:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:45:50 +0000 Subject: [Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled In-Reply-To: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31448-70-60Yk15CPvP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33474 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 17:47:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 15:47:27 +0000 Subject: [Koha-bugs] [Bug 33475] New: Remove Syndetics template variables from Auth.pm Message-ID: <bug-33475-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33475 Bug ID: 33475 Summary: Remove Syndetics template variables from Auth.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org 593 SyndeticsClientCode => C4::Context->preference("SyndeticsClientCode"), 594 SyndeticsEnabled => C4::Context->preference("SyndeticsEnabled"), 595 SyndeticsCoverImages => C4::Context->preference("SyndeticsCoverImages"), 596 SyndeticsTOC => C4::Context->preference("SyndeticsTOC"), 597 SyndeticsSummary => C4::Context->preference("SyndeticsSummary"), 598 SyndeticsEditions => C4::Context->preference("SyndeticsEditions"), 599 SyndeticsExcerpt => C4::Context->preference("SyndeticsExcerpt"), 600 SyndeticsReviews => C4::Context->preference("SyndeticsReviews"), 601 SyndeticsAuthorNotes => C4::Context->preference("SyndeticsAuthorNotes"), 602 SyndeticsAwards => C4::Context->preference("SyndeticsAwards"), 603 SyndeticsSeries => C4::Context->preference("SyndeticsSeries"), 604 SyndeticsCoverImageSize => C4::Context->preference("SyndeticsCoverImageSize"), I don't think these need to be in Auth.pm anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:04:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:04:33 +0000 Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs In-Reply-To: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29311-70-RJ5yReEPMq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It looks like this breaks a selenium test: t/db_dependent/selenium/regressions.t .. 7/8 STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} /usr/share/perl5/Selenium/Remote/Driver.pm:361 in Try::Tiny::try (eval 549):1 in Selenium::Remote::Driver::__ANON__ (eval 551):2 in Selenium::Remote::Driver::__ANON__ /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in (eval) t/db_dependent/selenium/regressions.t:358 in Selenium::Remote::Driver::find_element /usr/share/perl/5.32/Test/Builder.pm:334 in main::__ANON__ /usr/share/perl/5.32/Test/Builder.pm:334 in (eval) /usr/share/perl/5.32/Test/More.pm:809 in Test::Builder::subtest t/db_dependent/selenium/regressions.t:372 in Test::More::subtest # No tests run! t/db_dependent/selenium/regressions.t .. 8/8 # Failed test 'No tests run for subtest "OPAC - Suggest for purchase"' # at t/db_dependent/selenium/regressions.t line 372. Error while executing command: no such element: Unable to locate element: //input[@id="title"] at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. at /usr/share/perl5/Selenium/Remote/Driver.pm line 356. # Looks like your test exited with 11 just after 8. The test looks for an input field, but with this patch applied, there is no longer any input, just this: <label>Title:</label> <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=1">E Street shuffle :</a> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:14:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:14:31 +0000 Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs In-Reply-To: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29311-70-DiAjZQL2ga@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149391&action=edit Bug 29311: (follow-up) Add id to span elements The input fields in the form have ids, these are useful for styling, but also for the Selenium tests. This patch adds the ids from the former inputs to the now spans. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:14:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:14:34 +0000 Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs In-Reply-To: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29311-70-ozroqDrz3s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149392&action=edit Bug 29311: (follow-up) Fix t/db_dependent/selenium/regressions.t The test was checking for the value of an input field. But with this patch set, there is no longer an input, but a link element with the title. This adjusts the patch to look for the correct element. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:15:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:15:53 +0000 Subject: [Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled In-Reply-To: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31448-70-wBRNofRYGS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:15:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:15:56 +0000 Subject: [Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled In-Reply-To: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31448-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31448-70-es1ZS7I75t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147488|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149393&action=edit Bug 31448: Replace 'Print' with 'Receipt' dropdown This patch replaces the 'Print' button with a 'Receipt' menu dropdown exposing 'Print' and 'Email' options when `UseEmailReceipts` is enabled Test plan 1. Enable `UseEmailReceipts` 2. Navigate to a patron with paid charges 3. Note the new dropdown 'Receipt' menu 4. Confirm 'Print' works as expected 5. Confirm 'Email' works as expected Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:17:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:17:27 +0000 Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30392-70-4rZiyq2V3S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #25 from Christopher Brannon <cbrannon at cdalibrary.org> --- This is a good step for https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:18:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:18:01 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20271-70-DIxqbBWU99@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30392 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:18:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:18:01 +0000 Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30392-70-b6abnnqGm0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20271 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:19:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:19:19 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-q8Qzv0HW1t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Please make sure commit message has a descriptive subject and includes test plan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:21:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:21:05 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-8fZqogrocY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148576|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149394&action=edit Bug 33316: Improve display of ES indexer jobs We don't do a lot of processing to the data, but we can still make the display a bit nicer, to show how many records were done, and show the record ids. To test: 1 - Do some batch modifications on a system running ES 2 - Check background jobs to see ES jobs 3 - Note display 4 - Apply patch 5 - Confirm display is improved Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:26:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:26:25 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-Yy43POElpv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I've fixed the test, but I have a problem with the indexing job - it doesn't get done, so I can't verify the display. I remain stuck with: 3 New null/1 Update Elasticsearch index 04/10/2023 16:25 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:40:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:40:32 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-cYg3mUo5PF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:40:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:40:34 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-tH4buhTwqw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149394|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149395&action=edit Bug 33316: Improve display of ES indexer jobs We don't do a lot of processing to the data, but we can still make the display a bit nicer, to show how many records were done, and show the record ids. To test: 1 - Do some batch modifications on a system running ES 2 - Check background jobs to see ES jobs 3 - Note display 4 - Apply patch 5 - Confirm display is improved Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:40:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:40:37 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-3ASq6OKM7s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149396&action=edit Bug 33316: (QA follow-up) Add link to record, fix typo and heading * h2 h2 directly following each other make no sense. Changed to h2 h3 * ids changed to IDs * Linked the record ID to the catalog entry Note: We also have this link in the batch record mod job details Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:41:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:41:30 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-VjBoGZGHEi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #8) > I've fixed the test, but I have a problem with the indexing job - it doesn't > get done, so I can't verify the display. I remain stuck with: > > 3 New null/1 Update Elasticsearch index 04/10/2023 16:25 Turns out, things work better when Elastisearch is actually running... (In reply to Jonathan Druart from comment #5) > This should depend on the decision of keeping or removing > Koha::BackgroundJob::UpdateElasticIndex->process (see bug 32594 comment 41 & > 43). I am not sure about this one. Bug 32594 is now pushed to master, the job is still there. I think this won't hurt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:42:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:42:21 +0000 Subject: [Koha-bugs] [Bug 32970] Allow export of batch item modification results in background jobs In-Reply-To: <bug-32970-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32970-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32970-70-PgBGiwdnrY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32970 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:44:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:44:06 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-omYTiNI4l5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149396|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149397&action=edit Bug 33316: (QA follow-up) Add link to record, fix typo and heading * h2 h2 directly following each other make no sense. Changed to h2 h3 * ids changed to IDs * Linked the record ID to the catalog entry Note: We also have this link in the batch record mod job details Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:49:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:49:33 +0000 Subject: [Koha-bugs] [Bug 32970] Allow export of batch item modification results in background jobs In-Reply-To: <bug-32970-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32970-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32970-70-DfLjcWwnlz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32970 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:49:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:49:36 +0000 Subject: [Koha-bugs] [Bug 32970] Allow export of batch item modification results in background jobs In-Reply-To: <bug-32970-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32970-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32970-70-hEJ1vOc1AD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32970 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148950|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149398&action=edit Bug 32970: Use KohaTable for display of batch item modification results This patch updates the code to use KohaTables to provide export of the batch modification results. Additionally, searching is added, and the first two columns are made searchable To test: 1 - Perform a match item modification on several items 2 - View the results of the background job 3 - Apply patch 4 - Reload page 5 - Note you now have additional controls including 'search' and 'export' 6 - Test searching and exporting 7 - Confirm all work as expected Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 18:49:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 16:49:38 +0000 Subject: [Koha-bugs] [Bug 32970] Allow export of batch item modification results in background jobs In-Reply-To: <bug-32970-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32970-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32970-70-pYK9VMQvgG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32970 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148951|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149399&action=edit Bug 32970: (follow-up) Move include to specific job file Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:08:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:08:00 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18829-70-GurOn90e84@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:08:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:08:04 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18829-70-3civeJuZxy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148757|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149400&action=edit Bug 18829: Elasticsearch - Put a better display for the view of ES indexed record To test: - apply the patch - go to global sysPref - make sure that SearchEngine have "ElasticSearch" as value - Search whatever you want in Search the catalog and select a record - Search the link (Ctrl f) : "Elasticsearch Record :" , click on the link - make sure that the pop-up open and you should see the elasticsearch result in JSON (the pop-up look the same as MARC preview) - note fields are alphabetized - from the command line delete the es record: curl -XDELETE es:9200/koha_kohadev_biblios/data/5 - click the preview link, it syas record not found - check the logs - you see the error on missing record Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:08:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:08:07 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18829-70-a5tncN77zi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148758|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149401&action=edit Bug 18829: (QA follow-up) Fix punctuation, capitalization and page title Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:08:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:08:11 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18829-70-wjNK4BKlzS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148759|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149402&action=edit Bug 18829: (follow-up) Return 404 when record cannot be loaded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:08:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:08:15 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18829-70-gF85EP8uNj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148760|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149403&action=edit Bug 18829: (follow-up) Don't messup record encoding Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:08:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:08:18 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18829-70-GTlWzsrhfj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149404&action=edit Bug 18829: (QA follow-up) I18N, test character and breadcrumbs * Removes a 'heart' character from the file, probably added for testing * Corrects breadbrumbs to make QA test tool happy * Makes JS message translatable (test by manipulating the link to an invalid record number in DOM) Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:12:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:12:31 +0000 Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32301-70-QtYUdiMvKP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:14:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:14:45 +0000 Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32301-70-CL9o9gOsYY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:14:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:14:48 +0000 Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32301-70-7RV0quGpwj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148973|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149405&action=edit Bug 32301: [alternate] Fix default search sorting in advanced search when not editing a search Bug 22605 changed the sorting to expect the passed parameter from the previous search, this broke default when the search page was loaded fresh. We should simply fallback from the edited search to the default if it is not set To test: 1) Go to staff client 2) Go to Advanced Search 3) Notice the default Sort By value is "Relevance" 4) Go to system preferences 5) Go to "defaultSortField" 6) Change the value of the system preference 7) Go back to Advanced Search and refresh the page 8) Notice that there are no changes, the default Sort By is still "Relevance" 9) Apply patch 10) Notice that changing the system preference now changes the default Sort By in Advanced Search 11) Perform a search, change the sorting, then edit the search 12) Confirm the correct sorting from the search is preserved Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:15:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:15:27 +0000 Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32301-70-bsRWsHYXhG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx Nick, this now also works with the "Edit search" as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:18:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:18:19 +0000 Subject: [Koha-bugs] [Bug 33281] Improve authority links and add them to MARC preview In-Reply-To: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33281-70-Ojc194bPAk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:19:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:19:27 +0000 Subject: [Koha-bugs] [Bug 33281] Improve authority links and add them to MARC preview In-Reply-To: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33281-70-pGy9BWtZ0X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:19:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:19:29 +0000 Subject: [Koha-bugs] [Bug 33281] Improve authority links and add them to MARC preview In-Reply-To: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33281-70-Ofzdsz73xs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148974|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149406&action=edit Bug 33281: Improve detail auth links and add to marc preview This patch adds atuh links tot he marc preview, and makes detial auth links open in a new tab/window and consolidates some code To test: 1 - View a record linked to authorities in staff client 2 - Note links have no hover text, and open in same window 3 - Apply patch 4 - Restart and reload 5 - Note links now have a hint 6 - Note they open in new window 7 - View marc preview and note there are similar links Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:19:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:19:42 +0000 Subject: [Koha-bugs] [Bug 33281] Improve authority links and add them to MARC preview In-Reply-To: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33281-70-5rXyrHnMck@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Nice clean-up and improvement! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:20:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:20:35 +0000 Subject: [Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace In-Reply-To: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33236-70-3CtRQfD9W2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:31:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:31:13 +0000 Subject: [Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace In-Reply-To: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33236-70-bnrdI6g0vL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Nick, this looks quite good, but I think we need some more clean-up: 1) Serials C4/Serials.pm: if ( C4::Context->preference("RenewSerialAddsSuggestion") ) { require C4::Suggestions; C4::Suggestions::NewSuggestion( { 'suggestedby' => $user, 'title' => $subscription->{bibliotitle}, 'author' => $biblio->{author}, 'publishercode' => $biblio->{publishercode}, 'note' => $note, 'biblionumber' => $subscription->{biblionumber}, 'branchcode' => $branchcode, } ); } 2) Export list C4/Suggestions.pm: NewSuggestion Method is still in the list of exports. I would have fixed 2) but I think it would be better if you check on 1). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:34:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:34:59 +0000 Subject: [Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records In-Reply-To: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32800-70-WkNagjigiC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:36:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:36:17 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-l3evi6rb9K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 --- Comment #11 from Tomås Cohen Arazi <tomascohen at gmail.com> --- Created attachment 149407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149407&action=edit Bug 31795: (QA follow-up) Use x-koha-override header Despite its title, this patch does a couple more things. 1. The tests are rewritten to cover more things, and also to avoid deleting all authorities inside the transaction. It is really not required. 2. It makes the endpoint rely on the already generically implemented x-koha-override header, which is intended for the same use case as x-confirm-not-duplicate is for. 3. It changes the return codes to match the coding guidelines [1] 4. Only checks for duplicates if no override passed. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/authorities.t => SUCCESS: Tests pass! 2. Apply this follow-up 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D [1] https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER3.2.1_POST Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:50:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:50:37 +0000 Subject: [Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records In-Reply-To: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32800-70-zbLYSpfYdm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:50:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:50:40 +0000 Subject: [Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records In-Reply-To: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32800-70-k1ZVe7V3tb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148914|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149408&action=edit Bug 32800: Don't embed items for deleted records To test: 1 - Delete a biblio 2 - perl /kohadevbox/koha/misc/migration_tools/build_oai_sets.pl -v -i -r 3 - Error: Can't call method "items" on an undefined value at /kohadevbox/koha/Koha/Biblio/Metadata.pm line 163. 4 - Apply patch 5 - Repeat 6 - Success! Signed-off-by: Magnus Enger <magnus at libriotech.no> Works as advertised. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:51:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:51:29 +0000 Subject: [Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records In-Reply-To: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32800-70-xeSCvLY9Fz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Also verified that the deleted records are added to the set now correctly and show as "Deleted". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 19:54:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 17:54:44 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-R48cfEBXbT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 --- Comment #12 from Tomås Cohen Arazi <tomascohen at gmail.com> --- Created attachment 149409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149409&action=edit Bug 31795: Fix required permissions Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 21:00:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 19:00:20 +0000 Subject: [Koha-bugs] [Bug 33476] New: Tracking notices other than patron notices Message-ID: <bug-33476-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33476 Bug ID: 33476 Summary: Tracking notices other than patron notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It is extremely easy to view all notices sent to patrons. But it is not as easy to see system generated emails to libraries. Would it be possible to create a notices tab for libraries, and then wherever we define where internal notices go to, we can select either a patron account (for staff) or a library account (as long as it has an email address defined)? We might still retain the ability to put in a manual address. This would be the exception where we wouldn't be able to track notices, but being able to point to a patron account or library account would allow for easier setup and tracking all around. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 21:04:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 19:04:55 +0000 Subject: [Koha-bugs] [Bug 33476] Tracking notices other than patron notices In-Reply-To: <bug-33476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33476-70-vu4ilkAj8Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33476 --- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> --- Perhaps there should be an Admin notices tab on the admin page so that we could track notices that go to a specified generic address can be tracked as well? That could be an option when setting up emails like KohaAdminEmailAddress rather than inputing a manual address. The email address could be defined on that tab? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 21:25:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 19:25:16 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-pa5nLmuCfH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 --- Comment #7 from David Nind <david at davidnind.com> --- (In reply to Katrin Fischer from comment #6) > What do you think? I like your alternative Katrin! I have tested both patches and they work. Once it is decided, I am happy to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 21:41:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 19:41:03 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-4TbOQGf7fU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from David Nind <david at davidnind.com> --- The tests don't pass after applying the patches: prove t/db_dependent/api/v1/authorities.t t/db_dependent/api/v1/authorities.t .. 1/3 # Failed test '409 Conflict' # at t/db_dependent/api/v1/authorities.t line 204. # got: '201' # expected: '409' # Failed test 'Location header is only set when the new resource is created' # at t/db_dependent/api/v1/authorities.t line 204. # Failed test 'similar match for JSON Pointer "/error"' # at t/db_dependent/api/v1/authorities.t line 204. # undef # doesn't match '(?^u:Duplicate record (\d*))' # Failed test 'exact match for JSON Pointer "/error_code"' # at t/db_dependent/api/v1/authorities.t line 204. # got: undef # expected: 'duplicate' # Looks like you failed 4 tests of 19. t/db_dependent/api/v1/authorities.t .. 3/3 # Failed test 'post() tests' # at t/db_dependent/api/v1/authorities.t line 227. # Looks like you failed 1 test of 3. t/db_dependent/api/v1/authorities.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/api/v1/authorities.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 3 Non-zero exit status: 1 Files=1, Tests=3, 4 wallclock secs ( 0.02 usr 0.00 sys + 3.67 cusr 0.14 csys = 3.83 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 21:49:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 19:49:10 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST api In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-oYRiAgLzGB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149378|0 |1 is obsolete| | --- Comment #2 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- Created attachment 149410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149410&action=edit Bug 33470: Don't calculate overridden hold limits This patch can largely be checked in the code to ensure it makes sense, it moves a conditional up one level for the two different checks that could prevent holds To test: 1 - Attempt to place a hold via the REST API with an invalid pickup location Set pickup location as no in branches to make this easy 2 - Confirm you get an error 3 - Attempt again with header (bug 27760): x-koha-override: any 4 - Hold is placed 5 - Repeat 1-4 above but with an item that cannot be held 6 - Apply patch 7 - Repeat 1-4 above 8 - Results should be the same Signed-off-by: Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 21:52:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 19:52:41 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST api In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-yW7DgD6cxQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 21:56:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 19:56:26 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST api In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-Bz9zJWhcCs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 --- Comment #3 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- Testing notes: Step 0 - Set AllowHoldPolicyOverride to "Allow" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 22:12:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 20:12:41 +0000 Subject: [Koha-bugs] [Bug 33477] New: POST /holds/ allows invalid item-level hold if biblio_id and item_id are both specified Message-ID: <bug-33477-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33477 Bug ID: 33477 Summary: POST /holds/ allows invalid item-level hold if biblio_id and item_id are both specified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: emily.lamancusa at montgomerycountymd.gov CC: tomascohen at gmail.com To reproduce: 1. Locate or create a bib with multiple items 2. Set one item to type "Reference" and the rest to type "Book" 3. Go to the Circulation and Fines Rules > "Default holds policy by item type" section, and add a line specifying No Holds Allowed for Reference item type 4. Attempt to place an item-level hold on the Reference-type item via the REST API, specifying only the parameters: patron_id, item_id, and pickup_library_id 5. Confirm expected error message: Hold cannot be placed. Reason: notReservable 6. Attempt to place an item-level hold on the Reference-type item via the REST API, specifying only the parameters: patron_id, item_id, biblio_id, and pickup_library_id 7. Observe that an item-level hold has been placed on the Reference-type item, even though it should not be holdable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 22:40:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 20:40:17 +0000 Subject: [Koha-bugs] [Bug 33471] Improve performance of hold pickup location verification for next available holds In-Reply-To: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33471-70-FtEdaBSORv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149379|0 |1 is obsolete| | --- Comment #2 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- Created attachment 149411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149411&action=edit Bug 33471: Add validate_pickup_location routine to Koha::Biblio This patch adds a new routine, similar to pickup_locations except that it short circuits once a location has been found as acceptable. To test: 1 - Attempt placing a hold for an acceptable pickup location via the API 2 - Attempt to change pickup location to an invalid location, you are blocked 3 - Attempt to place a another hold via API for an invalid locatoin, you are blocked 4 - Apply patch 5 - Repeat 6 - Results should be the same Signed-off-by: Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 22:40:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 20:40:33 +0000 Subject: [Koha-bugs] [Bug 33471] Improve performance of hold pickup location verification for next available holds In-Reply-To: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33471-70-SU9opkfIlV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:15:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 21:15:27 +0000 Subject: [Koha-bugs] [Bug 33208] When a recalled item is checked-in there is no indication of that the item is recalled and the recall status is not updated from requested In-Reply-To: <bug-33208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33208-70-aLaOWrToMr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33208 Eric Phetteplace <ephetteplace at cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace at cca.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:32:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 21:32:40 +0000 Subject: [Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons In-Reply-To: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32986-70-OJBusP5toT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Starting here: 1) QA test tools: Ohoh! FAIL Koha/Template/Plugin/Notices.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss FAIL koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc FAIL filters missing_filter at line 36 ( <li><a class="printslip" data-code="[% notice.code %]" href="#">Print [% notice.name %] slip</a></li>) missing_filter at line 36 ( <li><a class="printslip" data-code="[% notice.code %]" href="#">Print [% notice.name %] slip</a></li>) FAIL forbidden patterns forbidden pattern: tab char (line 35) forbidden pattern: tab char (line 37) OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt FAIL forbidden patterns forbidden pattern: tab char (line 236) OK koha-tmpl/intranet-tmpl/prog/js/members-menu.js FAIL members/printslip.pl FAIL forbidden patterns forbidden pattern: tab char (line 101) forbidden pattern: tab char (line 102) forbidden pattern: tab char (line 103) forbidden pattern: tab char (line 104) forbidden pattern: tab char (line 105) forbidden pattern: tab char (line 106) Not finished with testing yet, but follow-ups welcome :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:43:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 21:43:01 +0000 Subject: [Koha-bugs] [Bug 28657] Expand branches.branchip to allow for multiple space separated ip ranges In-Reply-To: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28657-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28657-70-4j3pnsec4r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657 Michael Hafen <michael.hafen at washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134173|0 |1 is obsolete| | --- Comment #7 from Michael Hafen <michael.hafen at washk12.org> --- Created attachment 149412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149412&action=edit ug 28657: expand branches.branchip to allow for multiple ip ranges. [rebased 2023-04-10] change branches.branchip to a mediumtext, and remove '*' from existing branchip settings. Change C4/Auth.pm from a regexp to using in_iprange() to check client address against branchip. (in_iprange() doesn't work with '*' in branchip.) Change in_iprange() to default to false (which is what the POD says it should do). Also, have it trim '*' in case someone adds some back later. Change note in admin/branches.tt under branchip field to reflect changes to branchip handling. Test plan: 1. Turn on AutoLocation system preference 2. Change a branches branchip to multiple ip ranges seperated by a space, making sure one of the ranges includes your computers address. 3. Log out and try logging in. The location check will fail. 4. Apply patch. Restart plack if necessary. 5. Try logging in again. The location check will succeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 10 23:44:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 21:44:19 +0000 Subject: [Koha-bugs] [Bug 28658] With SearchMyLibraryFirst if library isn't set for the opac, try to guess it by checking branchip In-Reply-To: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28658-70-jPArITODNw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Michael Hafen <michael.hafen at washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #6 from Michael Hafen <michael.hafen at washk12.org> --- Bug 28657 has been rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 01:18:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 23:18:19 +0000 Subject: [Koha-bugs] [Bug 33435] We're missing sample dev data for ERM In-Reply-To: <bug-33435-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33435-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33435-70-T52Rd2bLwp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #6 from David Cook <dcook at prosentient.com.au> --- Sounds like a great idea but perhaps it should go in the koha-misc4dev repo? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 01:53:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 23:53:18 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-EWDBSyNTBf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 01:53:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Apr 2023 23:53:21 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-58Hyl2XHJo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149009|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149413&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. Sponsored-by: Colorado Library Consortium -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 02:09:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 00:09:39 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-2fwpr1eJdf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement makes it release notes| |easy for the library to | |view sent notices and | |filter by various search | |parameters. | | | |You can also | |print sent notices, | |individually or in a batch. | | | |This enhancement uses a | |new system preference | |NoticesManagement and a new | |view_generated_notices user | |permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 02:25:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 00:25:01 +0000 Subject: [Koha-bugs] [Bug 33478] New: Customise the format of notices when they are printed Message-ID: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Bug ID: 33478 Summary: Customise the format of notices when they are printed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org A feature to customise the format of notices when they are printed would be great. Some things we'd like to be able to customise for example are: - font size - margins - letterheads -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 02:25:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 00:25:11 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-UDqymwqug1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 04:55:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 02:55:33 +0000 Subject: [Koha-bugs] [Bug 33479] New: Add an option to pick a type of library during onboarding Message-ID: <bug-33479-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33479 Bug ID: 33479 Summary: Add an option to pick a type of library during onboarding Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: chris at bigballofwax.co.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com One of the requests from ICAL 2023 was that if during installation a type of library (public, school, academic, special, all) could be chosen. This would then set a bunch of preferences. Initially it was expressed as a request to have cut down versions of Koha for libraries that don't need all the features. I explained this is not something we would do, but that would could perhaps disable/hide some. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 05:04:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 03:04:12 +0000 Subject: [Koha-bugs] [Bug 33479] Add an option to pick a type of library during onboarding In-Reply-To: <bug-33479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33479-70-B9RQP6W0yk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33479 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook <dcook at prosentient.com.au> --- I've actually been thinking it could be interesting to have a "profile" passed to koha-create which would reset/override certain settings. I was thinking more so for vendors to provide a certain "configuration" to all their instances at install time, but doing some profiles by library type could be interesting too. I suppose that would be before the onboarding tool though... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 05:52:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 03:52:17 +0000 Subject: [Koha-bugs] [Bug 33479] Add an option to pick a type of library during onboarding In-Reply-To: <bug-33479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33479-70-zhFP8W9cyY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33479 --- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> --- Both options would be good. One for IT, one for the librarians. Maybe file another big for that one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 07:39:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 05:39:36 +0000 Subject: [Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739 In-Reply-To: <bug-32762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32762-70-gqKDa7OJ37@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762 --- Comment #10 from quickfire28 at gmail.com --- Still looking for help in this error while upgrading from v20.05 to v22.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 08:15:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 06:15:08 +0000 Subject: [Koha-bugs] [Bug 23773] Send MEMBERSHIP_EXPIRY notice by SMS In-Reply-To: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23773-70-0lu4KG1v2x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23773 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook <dcook at prosentient.com.au> --- I've had a library ask for this and I thought it sounded familiar... I'll make a note to come back to this when I have more time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 08:19:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 06:19:00 +0000 Subject: [Koha-bugs] [Bug 33435] We're missing sample dev data for ERM In-Reply-To: <bug-33435-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33435-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33435-70-dZqmAwErOZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I agree, this is probably better placed in misc4dev. Perhaps Jonathan could guild you in migrating this patch to a merge-request for that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:15:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 07:15:51 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-6LePzRfWYO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Comment 5 still valid. Nick? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:22:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 07:22:13 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-tMIfkHOcnD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- In ktd root at kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only Or you can run only Agreements.ts with: kohadev-koha at kohadevbox:koha$ yarn cypress run --spec /kohadevbox/koha/t/cypress/integration/Agreements_spec.ts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:23:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 07:23:47 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-ssHqoAPews@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #4) > btw, is the CI running them They are run at the end if no other failure happened. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:37:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 07:37:24 +0000 Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs In-Reply-To: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29311-70-NyQaq5WkOg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |jonathan.druart+koha at gmail. | |com --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Last two patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:56:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 07:56:30 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-X7ffKPSGel@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #35 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #34) Thanks, Katrin! > 1) Please check: > FAIL Koha/Acquisition/Bookseller/Alias.pm > FAIL pod coverage > POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 False positive. > OK Koha/Acquisition/Bookseller/Aliases.pm > OK Koha/Schema/Result/Aqbookseller.pm > FAIL Koha/Schema/Result/AqbooksellerAlias.pm > FAIL pod coverage > POD is missing for koha_object_class > POD is missing for koha_objects_class POD is always missing for those methods. Nothing to worry here. > 2) Vendor detail page > > * We should add some space between the the alias name and the trash > * More important: it needs at least a tool tip, right now it's a big > accessibility issue. I believe with aria-hidden=true it will actually be > invisible to screen readers? > * Same goes for the Plus icon to add another field: space and accessibility. > * When you click 'enter' in the field, the form submits 'save' and you are > back on the detail page, but the alias was not saved. Fixed in "Fix accessibility issues" > 3) Other features > > * Search and display in the aquisition module work nicely > > 4) ERM module > > I am not persuaded by the display tbh, I believe it will get messy very soon > as often those aliases will be quite long and we might even want to record a > slight name change. > > Could it be an option to show the aliases in the list as "second level" > entries, kind of a hiearchical display, like we have it for funds? > > > I know that CORAL uses the aliases also for matching in some form (I believe > when importing data), so it will be really nice to have this feature. It was the easiest approach to make the filtering works in the ERM module. Could we move that to its own bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:56:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 07:56:43 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-B1nLnfg3WN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 --- Comment #36 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149414&action=edit Bug 33103: Fix accessibility issues * Add spaces * Add 'Add' and 'Remove' in addition of the icons * Do not submit the form when enter is hit * Fix translatability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:57:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 07:57:42 +0000 Subject: [Koha-bugs] [Bug 33480] New: Improve display of the vendor aliases in the ERM module Message-ID: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33480 Bug ID: 33480 Summary: Improve display of the vendor aliases in the ERM module Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 33103 Coming from bug 33103 comment 34 """ I am not persuaded by the display tbh, I believe it will get messy very soon as often those aliases will be quite long and we might even want to record a slight name change. Could it be an option to show the aliases in the list as "second level" entries, kind of a hiearchical display, like we have it for funds? """ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 [Bug 33103] Add vendor aliases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 09:57:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 07:57:42 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-N3jjUCpKq1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33480 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33480 [Bug 33480] Improve display of the vendor aliases in the ERM module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:36:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:36:21 +0000 Subject: [Koha-bugs] [Bug 29598] Add a preference for default borrower's notice language In-Reply-To: <bug-29598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29598-70-HrFYGtkums@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29598 Lari Strand <lmstrand at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmstrand at gmail.com --- Comment #1 from Lari Strand <lmstrand at gmail.com> --- It seems also that on 22.11 the new borrower's (being added via staff interface) language is set to "default" by default and does not follow the selected intranet language selection anymore. Maybe a syspref (TranslateNoticesDefaultValue or something) that allows you to choose a language from the installed languages for the "default" value would be useful (requires TranslateNotices to be set to "Allow" to apply). If the default language for the new notices language syspref was not set, then the value "default" would be used? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:46:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:46:10 +0000 Subject: [Koha-bugs] [Bug 33266] Patron name missing space before surname In-Reply-To: <bug-33266-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33266-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33266-70-Mbi1GWIVrz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33266 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Interesting.. I thought I'd already fixed this with `Bug 31028: (follow-up) Fix missing whitespace on patron-title`.. did I miss a bit? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:48:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:48:07 +0000 Subject: [Koha-bugs] [Bug 32830] Fix cataloguing/value_builder/unimarc_field_116.pl In-Reply-To: <bug-32830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32830-70-OWpz1ADfu6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32830 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:48:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:48:08 +0000 Subject: [Koha-bugs] [Bug 32830] Fix cataloguing/value_builder/unimarc_field_116.pl In-Reply-To: <bug-32830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32830-70-Pv1kqm7Kvb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32830 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:48:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:48:10 +0000 Subject: [Koha-bugs] [Bug 32831] Fix cataloguing/value_builder/unimarc_field_117.pl In-Reply-To: <bug-32831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32831-70-W7bTHgrbAr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32831 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:48:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:48:12 +0000 Subject: [Koha-bugs] [Bug 32831] Fix cataloguing/value_builder/unimarc_field_117.pl In-Reply-To: <bug-32831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32831-70-z8S6N2DFJV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32831 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:48:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:48:13 +0000 Subject: [Koha-bugs] [Bug 32832] Fix cataloguing/value_builder/unimarc_field_120.pl In-Reply-To: <bug-32832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32832-70-KB21l8tFSG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32832 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:48:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:48:15 +0000 Subject: [Koha-bugs] [Bug 32832] Fix cataloguing/value_builder/unimarc_field_120.pl In-Reply-To: <bug-32832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32832-70-luIiTOSuiQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32832 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:48:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:48:16 +0000 Subject: [Koha-bugs] [Bug 32833] Fix cataloguing/value_builder/unimarc_field_121a.pl In-Reply-To: <bug-32833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32833-70-zzyeBXR4Ad@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32833 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:48:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:48:17 +0000 Subject: [Koha-bugs] [Bug 32833] Fix cataloguing/value_builder/unimarc_field_121a.pl In-Reply-To: <bug-32833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32833-70-mY4K9Nt3RH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32833 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:48:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:48:19 +0000 Subject: [Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued In-Reply-To: <bug-33019-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33019-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33019-70-QmmzMV6rTU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:48:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:48:21 +0000 Subject: [Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued In-Reply-To: <bug-33019-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33019-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33019-70-mNZgISjDdg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:48:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:48:22 +0000 Subject: [Koha-bugs] [Bug 33290] Incorrect variable used in http-client.js In-Reply-To: <bug-33290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33290-70-KpO9J1hJh3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:48:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:48:24 +0000 Subject: [Koha-bugs] [Bug 33290] Incorrect variable used in http-client.js In-Reply-To: <bug-33290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33290-70-IyZwudxXKq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:54:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:54:32 +0000 Subject: [Koha-bugs] [Bug 30966] Record overlay rules - can't use Z39.50 filter In-Reply-To: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30966-70-ZN458LiCCp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:54:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:54:34 +0000 Subject: [Koha-bugs] [Bug 30966] Record overlay rules - can't use Z39.50 filter In-Reply-To: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30966-70-ohLK1XuwCO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:54:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:54:36 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: <bug-32883-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32883-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32883-70-yXVmBJ8wf7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:54:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:54:37 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: <bug-32883-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32883-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32883-70-oQEGn9vTol@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:54:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:54:39 +0000 Subject: [Koha-bugs] [Bug 33137] Make sure columns on transactions and 'pay fines' tab are matching up In-Reply-To: <bug-33137-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33137-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33137-70-P40meP1mco@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:54:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:54:40 +0000 Subject: [Koha-bugs] [Bug 33137] Make sure columns on transactions and 'pay fines' tab are matching up In-Reply-To: <bug-33137-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33137-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33137-70-M6OyjBHeNI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 --- Comment #18 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:54:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:54:42 +0000 Subject: [Koha-bugs] [Bug 33309] Race condition while checkout renewal with ES In-Reply-To: <bug-33309-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33309-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33309-70-EoiwGQkdp4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33309 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 10:54:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 08:54:43 +0000 Subject: [Koha-bugs] [Bug 33309] Race condition while checkout renewal with ES In-Reply-To: <bug-33309-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33309-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33309-70-jZCdCA1MFa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33309 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:01:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:01:20 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14251-70-AAdAvlxUVN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #38 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:01:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:01:42 +0000 Subject: [Koha-bugs] [Bug 32945] Capitalization: id (part 2) In-Reply-To: <bug-32945-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32945-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32945-70-yUfo7Vny8T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:01:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:01:44 +0000 Subject: [Koha-bugs] [Bug 32945] Capitalization: id (part 2) In-Reply-To: <bug-32945-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32945-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32945-70-W9geohYiFs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:01:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:01:45 +0000 Subject: [Koha-bugs] [Bug 32969] Remove references to jQueryUI assets and style in the OPAC In-Reply-To: <bug-32969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32969-70-b0xposucA4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:01:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:01:47 +0000 Subject: [Koha-bugs] [Bug 32969] Remove references to jQueryUI assets and style in the OPAC In-Reply-To: <bug-32969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32969-70-1RcJmqWjtW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:01:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:01:48 +0000 Subject: [Koha-bugs] [Bug 33198] request.pl is calculating pickup locations that are not used In-Reply-To: <bug-33198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33198-70-vFgQpbvkBU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33198 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:01:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:01:50 +0000 Subject: [Koha-bugs] [Bug 33198] request.pl is calculating pickup locations that are not used In-Reply-To: <bug-33198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33198-70-Cm3HVO1A9w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33198 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:01:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:01:52 +0000 Subject: [Koha-bugs] [Bug 33278] Correct JS for activating default tab on various pages In-Reply-To: <bug-33278-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33278-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33278-70-SDKBMoEzwu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:01:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:01:53 +0000 Subject: [Koha-bugs] [Bug 33278] Correct JS for activating default tab on various pages In-Reply-To: <bug-33278-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33278-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33278-70-BcrwdXodhK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:02:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:02:15 +0000 Subject: [Koha-bugs] [Bug 29598] Add a preference for default borrower's notice language In-Reply-To: <bug-29598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29598-70-rFMZQ3oWQZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29598 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Lari Strand from comment #1) > It seems also that on 22.11 the new borrower's (being added via staff > interface) language is set to "default" by default and does not follow the > selected intranet language selection anymore. > > Maybe a syspref (TranslateNoticesDefaultValue or something) that allows you > to choose a language from the installed languages for the "default" value > would be useful (requires TranslateNotices to be set to "Allow" to apply). > If the default language for the new notices language syspref was not set, > then the value "default" would be used? Hi Lari and Marcel, I believe 'default' for a user added from the staff interface is correct and it also used to work like that. We rely on the user to pick a language and if we want to pre-select, it would only make sense for the OPAC. The staff user's preference and the user's preference don't necessarily have to be a match.I can think of some cases where this would have led to wrong settings in our libraries. I remember we had some problems with langauge/lang variable clashes on the borrowers pages in staff, could this be related? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:02:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:02:47 +0000 Subject: [Koha-bugs] [Bug 29598] Add a preference for default borrower's notice language In-Reply-To: <bug-29598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29598-70-J6v80bVJoO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29598 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- In other words... I believe this is a bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:04:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:04:18 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3150-70-Pesx4j8uPe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #196 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:05:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:05:17 +0000 Subject: [Koha-bugs] [Bug 33290] Incorrect variable used in http-client.js In-Reply-To: <bug-33290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33290-70-pT9ZqwyMJR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Matt Blenkinsop from comment #5) > Nice work everyone! > > Pushed to stable for 22.11.x Hi Matt, should it be 22.11.05 in the "Version(s) released in"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:06:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:06:27 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-cdrvcjKQmd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 --- Comment #37 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #35) > (In reply to Katrin Fischer from comment #34) > It was the easiest approach to make the filtering works in the ERM module. > Could we move that to its own bug? Opened bug 33480. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:07:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:07:21 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-pcCS4C4jYN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 --- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #37) > (In reply to Jonathan Druart from comment #35) > > (In reply to Katrin Fischer from comment #34) > > It was the easiest approach to make the filtering works in the ERM module. > > Could we move that to its own bug? > > Opened bug 33480. Makes sense. I'll try to get back to this asap, but if someone wants to steal it, that's also ok! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:07:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:07:50 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33388-70-ZdyVwoe1eC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 Andrew Auld <andrew.auld at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrew.auld at ptfs-europe.com --- Comment #4 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Patron details link not working: /members/moremember.pl?borrowernumber=# -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:10:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:10:04 +0000 Subject: [Koha-bugs] [Bug 33480] Improve display of the vendor aliases in the ERM module In-Reply-To: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33480-70-AYvwfZPRrV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33480 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:10:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:10:07 +0000 Subject: [Koha-bugs] [Bug 33480] Improve display of the vendor aliases in the ERM module In-Reply-To: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33480-70-NTMbz1E2bg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33480 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149415&action=edit Bug 33480: Improve vendor aliases display in dropdown list On bug 33103 we are adding the ability to filter vendors by aliases. To make it possible in the ERM module we are adding the alias list in the dropdown list. However it's not nicely displayed, especially if there are several entries. This patch suggests to display the aliases in a different line, and not for the selected option. To acchieve that we create a new Vue component FormSelectVendors. Test plan: Create several vendors, and add some aliases to them (keep one vendor without alias) Go to the ERM module go to the following page, search for vendors by aliases, save the form, and confirm that everything is nice and works correctly: * Add/edit an agreement * Add/edit a license * Add/edit a local package * Add a new package to a title (edit a title) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:10:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:10:09 +0000 Subject: [Koha-bugs] [Bug 33480] Improve display of the vendor aliases in the ERM module In-Reply-To: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33480-70-SMLp75CBqe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33480 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149416&action=edit Bug 33480: Remove vendors when not needed Several components retrieve the vendor list from store but it's not needed in those components. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:18:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:18:57 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_23824=5D_Add_a_=E2=80=98Save_and_ru?= =?utf-8?q?n=E2=80=99_button_to_reports?= In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-qXBWdWT0xL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:20:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:20:19 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_23824=5D_Add_a_=E2=80=98Save_and_ru?= =?utf-8?q?n=E2=80=99_button_to_reports?= In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-2kgBerdI3D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149080|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:20:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:20:29 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_23824=5D_Add_a_=E2=80=98Save_and_ru?= =?utf-8?q?n=E2=80=99_button_to_reports?= In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-peGJ9uqkAo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:20:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:20:48 +0000 Subject: [Koha-bugs] [Bug 32830] Fix cataloguing/value_builder/unimarc_field_116.pl In-Reply-To: <bug-32830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32830-70-hJqMbPMjXI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32830 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:21:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:21:15 +0000 Subject: [Koha-bugs] [Bug 32831] Fix cataloguing/value_builder/unimarc_field_117.pl In-Reply-To: <bug-32831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32831-70-8WxXvg2x9Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32831 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | CC| |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:21:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:21:51 +0000 Subject: [Koha-bugs] [Bug 32832] Fix cataloguing/value_builder/unimarc_field_120.pl In-Reply-To: <bug-32832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32832-70-kfdXAszCXP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32832 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:22:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:22:05 +0000 Subject: [Koha-bugs] [Bug 32833] Fix cataloguing/value_builder/unimarc_field_121a.pl In-Reply-To: <bug-32833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32833-70-GMK0TL8jS4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32833 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | CC| |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:22:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:22:23 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_23824=5D_Add_a_=E2=80=98Save_and_ru?= =?utf-8?q?n=E2=80=99_button_to_reports?= In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-fAiYRHDuNO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #9 from Magnus Enger <magnus at libriotech.no> --- (In reply to Laura Escamilla from comment #8) > (In reply to Magnus Enger from comment #7) > > I have taken the liberty of making a patch more in line with Katrin's > > suggestions. > > Patch did not apply. > > CONFLICT (content): Merge conflict in reports/guided_reports.pl > Auto-merging > koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt > error: Failed to merge in the changes. > Patch failed at 0001 Bug 23824: Add a Save and Run button to exports > [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m Hm, it looks like there could be a problem because there were two patches. I have taken the liberty of obsoleting the first patch to test. Could you please try again now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:22:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:22:28 +0000 Subject: [Koha-bugs] [Bug 33290] Incorrect variable used in http-client.js In-Reply-To: <bug-33290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33290-70-1gdymhVES1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | CC| |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:22:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:22:45 +0000 Subject: [Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued In-Reply-To: <bug-33019-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33019-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33019-70-2nTsgj1Aja@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | CC| |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:23:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:23:03 +0000 Subject: [Koha-bugs] [Bug 33137] Make sure columns on transactions and 'pay fines' tab are matching up In-Reply-To: <bug-33137-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33137-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33137-70-TRTaoBxY7A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:23:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:23:25 +0000 Subject: [Koha-bugs] [Bug 33309] Race condition while checkout renewal with ES In-Reply-To: <bug-33309-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33309-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33309-70-YITygb1EFW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33309 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:23:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:23:39 +0000 Subject: [Koha-bugs] [Bug 30966] Record overlay rules - can't use Z39.50 filter In-Reply-To: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30966-70-I6o53o1V53@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | CC| |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:23:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:23:53 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: <bug-32883-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32883-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32883-70-XO2IwKx9jB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:24:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:24:23 +0000 Subject: [Koha-bugs] [Bug 33198] request.pl is calculating pickup locations that are not used In-Reply-To: <bug-33198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33198-70-iSEZHxR6bD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33198 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:24:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:24:49 +0000 Subject: [Koha-bugs] [Bug 33278] Correct JS for activating default tab on various pages In-Reply-To: <bug-33278-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33278-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33278-70-k7fqZYIOD4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:25:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:25:06 +0000 Subject: [Koha-bugs] [Bug 32969] Remove references to jQueryUI assets and style in the OPAC In-Reply-To: <bug-32969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32969-70-L0fG1wRJbP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | CC| |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:25:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:25:21 +0000 Subject: [Koha-bugs] [Bug 32945] Capitalization: id (part 2) In-Reply-To: <bug-32945-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32945-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32945-70-s3dBxLKf4f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32945 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.05 released in| | CC| |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:28:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:28:59 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-n6gFz080Z6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:29:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:29:01 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-HS0AX1TjzW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149417&action=edit Bug 33466: Link to the vendor from the ERM module There are 3 tables in the ERM module where we display the vendor name but without a link to the acquisition module. This patch adds the links. Test plan: Create an agreement, a license and a local package. Pick a vendor and notice that now there is a link on the list view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:36:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:36:46 +0000 Subject: [Koha-bugs] [Bug 33480] Improve display of the vendor aliases in the ERM module In-Reply-To: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33480-70-OlMLMVDvya@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33480 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149418&action=edit Bug 33480: Display aliases on different lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:37:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:37:24 +0000 Subject: [Koha-bugs] [Bug 33480] Improve display of the vendor aliases in the ERM module In-Reply-To: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33480-70-jWzgsqhNpG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33480 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This last patch is supposed to add an indentation for the aliases but it does not work... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 11:44:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 09:44:47 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-3Y57rD0bl8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 --- Comment #39 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149419&action=edit Bug 33103: Prevent vendors to be displayed several times in the search result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:09:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:09:48 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-gb4ewpXtA0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #30 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #28) > 1) I18N > > ol.append(`<li><button class="btn btn-default" > onclick="remove_interface(${i});"><i class="fa fa-trash"></i> Delete > interface</li>`); Fixed. > 2) Vendor search > > * I am seeing a strange effect there: the "My Vendor" vendor with > booksellerid=1 is showing up twice after applying the patch. > Switching back to master makes the doubled up vendor go away. Fixed on bug 33103. > 3) Vendor edit form > > * Adding the email validation to the email field would be good. Done in "Add email validation" > * If you add multiple interfaces, the type pull down empties/resets to "" > for all interfaces when clicking on "Add another interface". This also > happens to the already saved interfaces. Done in "Prevent 'Type' to be cleared > 4) Vendor details page > > * The new information is not displaying correctly (see screenshot). I did a > yarn build and reset_all, nothing would fix. Background is wrong and also > the line height doesn't match with the other sections on the page. What are you suggesting? I think this is nicer than the others :D https://snipboard.io/Iwetbx.jpg Contacts are missing padding, contracts are in a table (what we don't want here, it won't be easy to read). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:15:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:15:57 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-FTkV8ksAjq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #31 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149420&action=edit Bug 33104: Fix translatability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:16:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:16:00 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-lj2ahQDHyK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #32 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149421&action=edit Bug 33104: Add email validation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:16:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:16:02 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-KYmgNVVlG2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #33 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149422&action=edit Bug 33104: Prevent 'Type' to be cleared -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:18:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:18:51 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-8Ycicr6sWQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:18:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:18:55 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-fTtmP6mNFh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148959|0 |1 is obsolete| | --- Comment #37 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149423&action=edit Bug 32968: ERM granular permissions - Preparation Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:18:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:18:57 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-M0H4yU4o4E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148960|0 |1 is obsolete| | --- Comment #38 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149424&action=edit Bug 32968: ERM granular permissions - API specs Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:19:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:19:00 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-ew0pRZdkUZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148966|0 |1 is obsolete| | --- Comment #39 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149425&action=edit Bug 32968: ERM granular permissions - DB specific Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:19:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:19:03 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-jx3cmABLxX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148961|0 |1 is obsolete| | --- Comment #40 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149426&action=edit Bug 32968: ERM granular permissions - Licenses Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:19:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:19:06 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-eKTFZkssJI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148962|0 |1 is obsolete| | --- Comment #41 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149427&action=edit Bug 32968: ERM granular permissions - Agreements Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:19:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:19:09 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-7aG7QbuEre@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148963|0 |1 is obsolete| | --- Comment #42 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149428&action=edit Bug 32968: ERM granular permissions - EHoldings Packages Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:19:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:19:12 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-LFVyJpKf4m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148964|0 |1 is obsolete| | --- Comment #43 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149429&action=edit Bug 32968: ERM granular permissions - EHoldings Titles Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:19:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:19:15 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-R94U9hsvPd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148965|0 |1 is obsolete| | --- Comment #44 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149430&action=edit Bug 32968: ERM granular permissions - Navigation guards Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:20:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:20:17 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-j33rP2SrjZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #45 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Thank you Katrin. Rebased this as it no longer applied nicely. QA script seems happy now, please confirm. Test plan remains the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:24:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:24:13 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-x1J0CdbNHM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #34 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149431&action=edit Bug 33104: Remove fieldset For consistency with "Contacts" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:25:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:25:24 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-3qmjxpNzhe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #35 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #30) > What are you suggesting? I think this is nicer than the others :D > > https://snipboard.io/Iwetbx.jpg > > Contacts are missing padding, contracts are in a table (what we don't want > here, it won't be easy to read). See last patch. Better for consistency, but IMO it was nicer prior to this patch (except the background weirdness) https://snipboard.io/jv7yIe.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:25:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:25:46 +0000 Subject: [Koha-bugs] [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt In-Reply-To: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33426-70-bDgUdONt1a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Should we use this bug as is.. or attempt to generalise the pattern.. I feel like we could move the code into our KohaTable wrappers and make it work for all cases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:34:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:34:46 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-Wavo1fuqxU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #3) > Sorry, the test plan is not detailed enough for me - can you please add some > more info? You need to play with the code, or test a follow-up bug. The code I pasted in the commit message is enough to test the change. You can pick a place in a Vue component ('script' part), add the change, hit the page when the component is mounted, then confirm that the syspref value has been changed in DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:40:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:40:35 +0000 Subject: [Koha-bugs] [Bug 32426] Make userid generation pluggable In-Reply-To: <bug-32426-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32426-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32426-70-mpXWHScBup@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32426 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #46 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:47:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:47:12 +0000 Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has two h1 headings In-Reply-To: <bug-32003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32003-70-fcHo5wAoFn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:47:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:47:13 +0000 Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has two h1 headings In-Reply-To: <bug-32003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32003-70-Glqs4D7x02@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:47:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:47:15 +0000 Subject: [Koha-bugs] [Bug 32964] OPACResultsMaxItemsUnavailable description is misleading In-Reply-To: <bug-32964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32964-70-AvSYakPB3F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:47:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:47:17 +0000 Subject: [Koha-bugs] [Bug 32964] OPACResultsMaxItemsUnavailable description is misleading In-Reply-To: <bug-32964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32964-70-mGWjMTheZu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32964 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:49:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:49:40 +0000 Subject: [Koha-bugs] [Bug 28658] With SearchMyLibraryFirst if library isn't set for the opac, try to guess it by checking branchip In-Reply-To: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28658-70-eTd04Hyhp0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 --- Comment #7 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149432&action=edit Bug 28658 - With SearchMyLibraryFirst guess the opac clients library If the SearchMyLibraryFirst syspref is set, the OPAC uses the logged in users branchcode to limit searches to their library. If it's an anonymous session that doesn't happen. This tries to guess the client library by checking for the client ip address in each libraries branchip setting. Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:49:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:49:41 +0000 Subject: [Koha-bugs] [Bug 32121] Show an alert when adding a checked out item to an item bundle In-Reply-To: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32121-70-DBJbWmMPZv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #12 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:50:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:50:12 +0000 Subject: [Koha-bugs] [Bug 28658] With SearchMyLibraryFirst if library isn't set for the opac, try to guess it by checking branchip In-Reply-To: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28658-70-tfddxgVw7v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:50:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:50:37 +0000 Subject: [Koha-bugs] [Bug 33021] Show an alert when adding a reserved item to an item bundle In-Reply-To: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33021-70-BKvikprbqt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33021 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #11 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:55:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:55:07 +0000 Subject: [Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist In-Reply-To: <bug-32807-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32807-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32807-70-xYxTXKGCMI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:55:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:55:08 +0000 Subject: [Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist In-Reply-To: <bug-32807-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32807-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32807-70-bL8I8OP0zx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:55:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:55:10 +0000 Subject: [Koha-bugs] [Bug 33133] Fast cataloging should be visible in cataloging In-Reply-To: <bug-33133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33133-70-4uXj4XGUSu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:55:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:55:11 +0000 Subject: [Koha-bugs] [Bug 33133] Fast cataloging should be visible in cataloging In-Reply-To: <bug-33133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33133-70-Es0aro4k04@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:55:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:55:13 +0000 Subject: [Koha-bugs] [Bug 33341] Perl 5.36 doesn't consider some of our code cool In-Reply-To: <bug-33341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33341-70-HA3pt2HLcK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33341 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:55:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:55:14 +0000 Subject: [Koha-bugs] [Bug 33341] Perl 5.36 doesn't consider some of our code cool In-Reply-To: <bug-33341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33341-70-cNXUpV71Av@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33341 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:56:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:56:43 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_23824=5D_Add_a_=E2=80=98Save_and_ru?= =?utf-8?q?n=E2=80=99_button_to_reports?= In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-UywmHaQcGi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149080|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149433&action=edit Bug 23824: Add a "Save and run" button to reports [alternative] This will save one click every time you want to save and then run a report. To test: - Apply this patch - Create a new report - Click the new "Update and run SQL" button - Verify the report was saved and the results are displayed Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 12:57:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 10:57:13 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_23824=5D_Add_a_=E2=80=98Save_and_ru?= =?utf-8?q?n=E2=80=99_button_to_reports?= In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-vKnyFxPFNN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:11 +0000 Subject: [Koha-bugs] [Bug 32834] Fix cataloguing/value_builder/unimarc_field_121b.pl In-Reply-To: <bug-32834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32834-70-YIebaxrSwt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32834 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:12 +0000 Subject: [Koha-bugs] [Bug 32834] Fix cataloguing/value_builder/unimarc_field_121b.pl In-Reply-To: <bug-32834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32834-70-zpZHYB6tHO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32834 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:14 +0000 Subject: [Koha-bugs] [Bug 32836] Fix cataloguing/value_builder/unimarc_field_123a.pl In-Reply-To: <bug-32836-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32836-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32836-70-LhB4jVLdnk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32836 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:15 +0000 Subject: [Koha-bugs] [Bug 32836] Fix cataloguing/value_builder/unimarc_field_123a.pl In-Reply-To: <bug-32836-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32836-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32836-70-v4TxLM5G8A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32836 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:16 +0000 Subject: [Koha-bugs] [Bug 32837] Fix cataloguing/value_builder/unimarc_field_123d.pl In-Reply-To: <bug-32837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32837-70-dQsBUDdgUr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32837 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:18 +0000 Subject: [Koha-bugs] [Bug 32837] Fix cataloguing/value_builder/unimarc_field_123d.pl In-Reply-To: <bug-32837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32837-70-wbNYOhTSHF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32837 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:19 +0000 Subject: [Koha-bugs] [Bug 32838] Fix cataloguing/value_builder/unimarc_field_123e.pl In-Reply-To: <bug-32838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32838-70-lO8TKyRopb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32838 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:21 +0000 Subject: [Koha-bugs] [Bug 32838] Fix cataloguing/value_builder/unimarc_field_123e.pl In-Reply-To: <bug-32838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32838-70-JpLae7JD4P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32838 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:22 +0000 Subject: [Koha-bugs] [Bug 32839] Fix cataloguing/value_builder/unimarc_field_123f.pl In-Reply-To: <bug-32839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32839-70-i2o2Vxiigw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32839 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:24 +0000 Subject: [Koha-bugs] [Bug 32839] Fix cataloguing/value_builder/unimarc_field_123f.pl In-Reply-To: <bug-32839-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32839-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32839-70-bEcIGNlh5F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32839 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:26 +0000 Subject: [Koha-bugs] [Bug 32840] Fix cataloguing/value_builder/unimarc_field_123g.pl In-Reply-To: <bug-32840-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32840-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32840-70-02sQ4kNrZH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32840 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:27 +0000 Subject: [Koha-bugs] [Bug 32840] Fix cataloguing/value_builder/unimarc_field_123g.pl In-Reply-To: <bug-32840-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32840-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32840-70-f8heciRd46@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32840 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:29 +0000 Subject: [Koha-bugs] [Bug 32841] Fix cataloguing/value_builder/unimarc_field_123i.pl In-Reply-To: <bug-32841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32841-70-OnsVMxUncP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32841 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:30 +0000 Subject: [Koha-bugs] [Bug 32841] Fix cataloguing/value_builder/unimarc_field_123i.pl In-Reply-To: <bug-32841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32841-70-a9FhYNhQdY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32841 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:31 +0000 Subject: [Koha-bugs] [Bug 32842] Fix cataloguing/value_builder/unimarc_field_123j.pl In-Reply-To: <bug-32842-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32842-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32842-70-UQv881xxly@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32842 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:33 +0000 Subject: [Koha-bugs] [Bug 32842] Fix cataloguing/value_builder/unimarc_field_123j.pl In-Reply-To: <bug-32842-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32842-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32842-70-eNhqn0xXj6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32842 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:34 +0000 Subject: [Koha-bugs] [Bug 32843] Fix cataloguing/value_builder/unimarc_field_124a.pl In-Reply-To: <bug-32843-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32843-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32843-70-o2GRbN28Nc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32843 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:36 +0000 Subject: [Koha-bugs] [Bug 32843] Fix cataloguing/value_builder/unimarc_field_124a.pl In-Reply-To: <bug-32843-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32843-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32843-70-eBwgIGLfVI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32843 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:37 +0000 Subject: [Koha-bugs] [Bug 32844] Fix cataloguing/value_builder/unimarc_field_124b.pl In-Reply-To: <bug-32844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32844-70-M2nZvxeTwV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32844 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:39 +0000 Subject: [Koha-bugs] [Bug 32844] Fix cataloguing/value_builder/unimarc_field_124b.pl In-Reply-To: <bug-32844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32844-70-VAi1kcEnBb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32844 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:40 +0000 Subject: [Koha-bugs] [Bug 32845] Fix cataloguing/value_builder/unimarc_field_124c.pl In-Reply-To: <bug-32845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32845-70-qZApiWqB64@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32845 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:42 +0000 Subject: [Koha-bugs] [Bug 32845] Fix cataloguing/value_builder/unimarc_field_124c.pl In-Reply-To: <bug-32845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32845-70-oi15uoWU0x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32845 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:43 +0000 Subject: [Koha-bugs] [Bug 32846] Fix cataloguing/value_builder/unimarc_field_124d.pl In-Reply-To: <bug-32846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32846-70-KgVOKxQnpA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32846 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:45 +0000 Subject: [Koha-bugs] [Bug 32846] Fix cataloguing/value_builder/unimarc_field_124d.pl In-Reply-To: <bug-32846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32846-70-Z3RGPiSU4T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32846 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:46 +0000 Subject: [Koha-bugs] [Bug 32847] Fix cataloguing/value_builder/unimarc_field_124e.pl In-Reply-To: <bug-32847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32847-70-hGafmBupuy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32847 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:48 +0000 Subject: [Koha-bugs] [Bug 32847] Fix cataloguing/value_builder/unimarc_field_124e.pl In-Reply-To: <bug-32847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32847-70-M1u4In5aXX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32847 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:49 +0000 Subject: [Koha-bugs] [Bug 32848] Fix cataloguing/value_builder/unimarc_field_124f.pl In-Reply-To: <bug-32848-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32848-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32848-70-Hcoz4apGq6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32848 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:51 +0000 Subject: [Koha-bugs] [Bug 32848] Fix cataloguing/value_builder/unimarc_field_124f.pl In-Reply-To: <bug-32848-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32848-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32848-70-4QmEbEDX29@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32848 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:52 +0000 Subject: [Koha-bugs] [Bug 32849] Fix cataloguing/value_builder/unimarc_field_124g.pl In-Reply-To: <bug-32849-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32849-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32849-70-DbIPSqYN5y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32849 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:54 +0000 Subject: [Koha-bugs] [Bug 32849] Fix cataloguing/value_builder/unimarc_field_124g.pl In-Reply-To: <bug-32849-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32849-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32849-70-xHlOtr21Fa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32849 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:55 +0000 Subject: [Koha-bugs] [Bug 32851] Fix cataloguing/value_builder/unimarc_field_125a.pl In-Reply-To: <bug-32851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32851-70-1uITFKNZ6f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32851 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:57 +0000 Subject: [Koha-bugs] [Bug 32851] Fix cataloguing/value_builder/unimarc_field_125a.pl In-Reply-To: <bug-32851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32851-70-tD5TqeiDzH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32851 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:02:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:02:58 +0000 Subject: [Koha-bugs] [Bug 32852] Fix cataloguing/value_builder/unimarc_field_125b.pl In-Reply-To: <bug-32852-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32852-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32852-70-bA4HRjB8pc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32852 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:03:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:03:00 +0000 Subject: [Koha-bugs] [Bug 32852] Fix cataloguing/value_builder/unimarc_field_125b.pl In-Reply-To: <bug-32852-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32852-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32852-70-ifnCJkH5X7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32852 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:14 +0000 Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion In-Reply-To: <bug-30162-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30162-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30162-70-3QLGtRrSw7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:16 +0000 Subject: [Koha-bugs] [Bug 30162] XSLT has broken link for traced series because of OPAC/staff interface confusion In-Reply-To: <bug-30162-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30162-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30162-70-gAbAgpfxAM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30162 --- Comment #23 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:17 +0000 Subject: [Koha-bugs] [Bug 32217] Typo: Error authenticating in external provider In-Reply-To: <bug-32217-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32217-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32217-70-hk2IxJMwNv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32217 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:19 +0000 Subject: [Koha-bugs] [Bug 32217] Typo: Error authenticating in external provider In-Reply-To: <bug-32217-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32217-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32217-70-soMh7epsEg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32217 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:21 +0000 Subject: [Koha-bugs] [Bug 32854] Fix cataloguing/value_builder/unimarc_field_126a.pl In-Reply-To: <bug-32854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32854-70-uoVEUzIcW5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32854 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:22 +0000 Subject: [Koha-bugs] [Bug 32854] Fix cataloguing/value_builder/unimarc_field_126a.pl In-Reply-To: <bug-32854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32854-70-sryoxflMz6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32854 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:24 +0000 Subject: [Koha-bugs] [Bug 32855] Fix cataloguing/value_builder/unimarc_field_126b.pl In-Reply-To: <bug-32855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32855-70-EPDfN2iiw5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32855 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:25 +0000 Subject: [Koha-bugs] [Bug 32855] Fix cataloguing/value_builder/unimarc_field_126b.pl In-Reply-To: <bug-32855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32855-70-B03dEDRRMZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32855 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:27 +0000 Subject: [Koha-bugs] [Bug 32857] Fix cataloguing/value_builder/unimarc_field_127.pl In-Reply-To: <bug-32857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32857-70-84Ew9C1TrD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32857 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:28 +0000 Subject: [Koha-bugs] [Bug 32857] Fix cataloguing/value_builder/unimarc_field_127.pl In-Reply-To: <bug-32857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32857-70-rAlk6FHxu9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32857 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:30 +0000 Subject: [Koha-bugs] [Bug 32858] Fix cataloguing/value_builder/unimarc_field_128a.pl In-Reply-To: <bug-32858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32858-70-gCDFHBngnV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32858 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:32 +0000 Subject: [Koha-bugs] [Bug 32858] Fix cataloguing/value_builder/unimarc_field_128a.pl In-Reply-To: <bug-32858-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32858-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32858-70-orpGCiGd6o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32858 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:33 +0000 Subject: [Koha-bugs] [Bug 32859] Fix cataloguing/value_builder/unimarc_field_128b.pl In-Reply-To: <bug-32859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32859-70-pLNc9cqzjq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32859 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:35 +0000 Subject: [Koha-bugs] [Bug 32859] Fix cataloguing/value_builder/unimarc_field_128b.pl In-Reply-To: <bug-32859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32859-70-ThXcpPriSp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32859 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:36 +0000 Subject: [Koha-bugs] [Bug 32860] Fix cataloguing/value_builder/unimarc_field_128c.pl In-Reply-To: <bug-32860-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32860-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32860-70-Ghj04CmhQV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32860 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:38 +0000 Subject: [Koha-bugs] [Bug 32860] Fix cataloguing/value_builder/unimarc_field_128c.pl In-Reply-To: <bug-32860-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32860-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32860-70-MklXzqMI0L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32860 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:39 +0000 Subject: [Koha-bugs] [Bug 32861] Fix cataloguing/value_builder/unimarc_field_130.pl In-Reply-To: <bug-32861-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32861-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32861-70-LEd5QafqsP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32861 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:41 +0000 Subject: [Koha-bugs] [Bug 32861] Fix cataloguing/value_builder/unimarc_field_130.pl In-Reply-To: <bug-32861-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32861-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32861-70-ngiulqoCya@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32861 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:42 +0000 Subject: [Koha-bugs] [Bug 32862] Fix cataloguing/value_builder/unimarc_field_135a.pl In-Reply-To: <bug-32862-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32862-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32862-70-wnfIf8xyJQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32862 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:43 +0000 Subject: [Koha-bugs] [Bug 32862] Fix cataloguing/value_builder/unimarc_field_135a.pl In-Reply-To: <bug-32862-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32862-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32862-70-BFjv9vchwd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32862 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:45 +0000 Subject: [Koha-bugs] [Bug 32863] Fix cataloguing/value_builder/unimarc_field_140.pl In-Reply-To: <bug-32863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32863-70-VAEbFjwifo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32863 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:46 +0000 Subject: [Koha-bugs] [Bug 32863] Fix cataloguing/value_builder/unimarc_field_140.pl In-Reply-To: <bug-32863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32863-70-bjGzPJuRJ3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32863 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:48 +0000 Subject: [Koha-bugs] [Bug 32864] Fix cataloguing/value_builder/unimarc_field_141.pl In-Reply-To: <bug-32864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32864-70-OB5pSC0pY0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32864 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:12:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:12:49 +0000 Subject: [Koha-bugs] [Bug 32864] Fix cataloguing/value_builder/unimarc_field_141.pl In-Reply-To: <bug-32864-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32864-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32864-70-9efY0x18ak@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32864 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:19:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:19:55 +0000 Subject: [Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin In-Reply-To: <bug-29234-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29234-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29234-70-KNF4UUdfsS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:19:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:19:57 +0000 Subject: [Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin In-Reply-To: <bug-29234-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29234-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29234-70-95cBbSh0g0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:19:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:19:58 +0000 Subject: [Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC) In-Reply-To: <bug-32336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32336-70-9TWdOaTYmo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:20:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:20:00 +0000 Subject: [Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC) In-Reply-To: <bug-32336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32336-70-7fvTybduN5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:20:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:20:01 +0000 Subject: [Koha-bugs] [Bug 32710] UI/Form/Builder/Item.t is failing randomly In-Reply-To: <bug-32710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32710-70-gwWdb2GoOs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32710 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:20:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:20:03 +0000 Subject: [Koha-bugs] [Bug 32710] UI/Form/Builder/Item.t is failing randomly In-Reply-To: <bug-32710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32710-70-TDGlWYPEt8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32710 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:20:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:20:04 +0000 Subject: [Koha-bugs] [Bug 33136] Catalog search pop-up is missing page-section In-Reply-To: <bug-33136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33136-70-UUOKlyV9rT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33136 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:20:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:20:06 +0000 Subject: [Koha-bugs] [Bug 33136] Catalog search pop-up is missing page-section In-Reply-To: <bug-33136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33136-70-74mkafoYUK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33136 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:20:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:20:07 +0000 Subject: [Koha-bugs] [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX In-Reply-To: <bug-33159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33159-70-vS3KAktoTb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:20:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:20:09 +0000 Subject: [Koha-bugs] [Bug 33159] Thesaurus is not defined by second indicator for controlled fields outside of 6XX In-Reply-To: <bug-33159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33159-70-duxJmZH2n0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33159 --- Comment #38 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:24:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:24:04 +0000 Subject: [Koha-bugs] [Bug 29449] Show userid on "your personal details" tab In-Reply-To: <bug-29449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29449-70-OlFNRCkbzf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #12 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:24:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:24:59 +0000 Subject: [Koha-bugs] [Bug 26433] Control number search option missing from SRU mapping options In-Reply-To: <bug-26433-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26433-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26433-70-S3AvyFQ7At@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26433 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:25:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:25:01 +0000 Subject: [Koha-bugs] [Bug 26433] Control number search option missing from SRU mapping options In-Reply-To: <bug-26433-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26433-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26433-70-xddKwFZA5H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26433 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:25:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:25:02 +0000 Subject: [Koha-bugs] [Bug 32794] mailto links in 856 can be incorrectly formed by XSLT In-Reply-To: <bug-32794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32794-70-CJZiRpfjB7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32794 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:25:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:25:04 +0000 Subject: [Koha-bugs] [Bug 32794] mailto links in 856 can be incorrectly formed by XSLT In-Reply-To: <bug-32794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32794-70-NTVoLEjNM6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32794 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:25:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:25:05 +0000 Subject: [Koha-bugs] [Bug 33168] Timeline on "About Koha" is not working for package installs In-Reply-To: <bug-33168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33168-70-67VPGzNCHe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:25:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:25:07 +0000 Subject: [Koha-bugs] [Bug 33168] Timeline on "About Koha" is not working for package installs In-Reply-To: <bug-33168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33168-70-CE8i91poGq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 --- Comment #46 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:25:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:25:09 +0000 Subject: [Koha-bugs] [Bug 33346] Add Help link to Koha manual in ERM module In-Reply-To: <bug-33346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33346-70-L6D7fCNGxm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33346 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:25:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:25:11 +0000 Subject: [Koha-bugs] [Bug 33346] Add Help link to Koha manual in ERM module In-Reply-To: <bug-33346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33346-70-PMTguv9OCF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33346 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:26:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:26:36 +0000 Subject: [Koha-bugs] [Bug 21548] Make ILL patron category in koha-conf.xml match with ILL patron category in sample data In-Reply-To: <bug-21548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21548-70-lVVZnUa110@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #11 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:26:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:26:36 +0000 Subject: [Koha-bugs] [Bug 19822] Add system preferences for ILL Module In-Reply-To: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19822-70-Q43BqohHPP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822 Bug 19822 depends on bug 21548, which changed state. Bug 21548 Summary: Make ILL patron category in koha-conf.xml match with ILL patron category in sample data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:26:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:26:37 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-o82MJpRyf0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Bug 32911 depends on bug 21548, which changed state. Bug 21548 Summary: Make ILL patron category in koha-conf.xml match with ILL patron category in sample data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21548 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:27:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:27:30 +0000 Subject: [Koha-bugs] [Bug 33349] Patron attributes don't have identifying info in the staff interface In-Reply-To: <bug-33349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33349-70-AHxSNFeAl6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33349 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |RESOLVED --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:28:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:28:05 +0000 Subject: [Koha-bugs] [Bug 33146] Add a public fetch endpoint for items In-Reply-To: <bug-33146-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33146-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33146-70-ql7j4VOiSl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33146 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |RESOLVED --- Comment #21 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:28:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:28:05 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30979-70-NNwZhj7hiW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Bug 30979 depends on bug 33146, which changed state. Bug 33146 Summary: Add a public fetch endpoint for items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33146 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:28:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:28:06 +0000 Subject: [Koha-bugs] [Bug 31789] REST API: CRUD endpoint for Items In-Reply-To: <bug-31789-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31789-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31789-70-h5Zx6u6rrx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31789 Bug 31789 depends on bug 33146, which changed state. Bug 33146 Summary: Add a public fetch endpoint for items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33146 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:29:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:29:14 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-8DzS8j4lJn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Patch failed to apply: error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue). error: could not build fake ancestor Patch failed at 0001 Bug 33466: Link to the vendor from the ERM module hint: Use 'git am --show-current-patch=diff' to see the failed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:29:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:29:18 +0000 Subject: [Koha-bugs] [Bug 33443] The "X titles found locally" not displayed In-Reply-To: <bug-33443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33443-70-lZMrastF6B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33443 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Can't reproduce the problem before applying patch. Can't apply patch because already applied from bug 33066. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:33:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:33:12 +0000 Subject: [Koha-bugs] [Bug 32373] Show date of restriction on patron screen In-Reply-To: <bug-32373-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32373-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32373-70-IbFBZDnlHt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #31 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:33:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:33:31 +0000 Subject: [Koha-bugs] [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses In-Reply-To: <bug-28641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28641-70-0Ltxkom7F6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:33:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:33:33 +0000 Subject: [Koha-bugs] [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses In-Reply-To: <bug-28641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28641-70-4p6I4tLzZw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:33:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:33:34 +0000 Subject: [Koha-bugs] [Bug 31409] Set focus for cursor to Fund code when adding a new fund In-Reply-To: <bug-31409-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31409-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31409-70-fz3gTpGf8Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31409 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:33:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:33:36 +0000 Subject: [Koha-bugs] [Bug 31409] Set focus for cursor to Fund code when adding a new fund In-Reply-To: <bug-31409-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31409-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31409-70-7cNfngiSD9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31409 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:33:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:33:37 +0000 Subject: [Koha-bugs] [Bug 32771] Standardize structure around action fieldsets in serials In-Reply-To: <bug-32771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32771-70-a3kU7C0tKw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:33:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:33:39 +0000 Subject: [Koha-bugs] [Bug 32771] Standardize structure around action fieldsets in serials In-Reply-To: <bug-32771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32771-70-SYJSOop1qz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:36:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:36:53 +0000 Subject: [Koha-bugs] [Bug 33481] New: EBSCO ws return 415: Content type 'application/octet-stream' not supported Message-ID: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 Bug ID: 33481 Summary: EBSCO ws return 415: Content type 'application/octet-stream' not supported Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 32030 ERROR - EBSCO API /vendors/19/packages/3816 returned 415 - Content type 'application/octet-stream' not supported [ERROR] PATCH /api/v1/erm/eholdings/ebsco/packages/19-3816: unhandled exception (Mojo::Exception)<<ERROR requesting EBSCO API /vendors/19/packages/3816 code 415: Content type 'application/octet-stream' not supported>> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:36:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:36:53 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32030-70-uHy46vrtV1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33481 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:37:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:37:32 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-jwPjlFO6kx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149434&action=edit Bug 33481: Pass content-type when requesting EBSCO's webservice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:38:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:38:12 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-0TEnbm6xtl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #21 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Last patch doesn't apply after bug 33066 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:38:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:38:29 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-uRZRgs4cJU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:46:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:46:33 +0000 Subject: [Koha-bugs] [Bug 33482] New: Errors from EBSCO's ws are not reported to the UI Message-ID: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 Bug ID: 33482 Summary: Errors from EBSCO's ws are not reported to the UI Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:49:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:49:25 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-Z8T7sS5ej2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:49:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:49:28 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-3O8DTVrXuo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149435&action=edit Bug 33482: Propagate errors from EBSCO's ws to the UI When adding or removing eholdings from EBSCO, if an error happens it is lost and not propagated to the UI. We were missing a return in the logic, and always returning 200 Test plan: Do not apply (or revert) bug 33481 Configure EBSCO for ERM and add a package to your holdings With this patch applied you will get a 500 that is propagated to the UI Without this patch nothing happens and the user is not aware that something bad happened -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 13:54:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 11:54:48 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-5ikZwWIWr5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 Jan Kissig <bibliothek at th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek at th-wildau.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:07:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:07:43 +0000 Subject: [Koha-bugs] [Bug 32850] Fix cataloguing/value_builder/unimarc_field_124.pl In-Reply-To: <bug-32850-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32850-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32850-70-IjDxO6AxzP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32850 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is actually pushed to master along with all the others in this series.. updating status as such. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:07:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:07:48 +0000 Subject: [Koha-bugs] [Bug 32850] Fix cataloguing/value_builder/unimarc_field_124.pl In-Reply-To: <bug-32850-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32850-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32850-70-TfrGD0EOIc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32850 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:07:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:07:52 +0000 Subject: [Koha-bugs] [Bug 32850] Fix cataloguing/value_builder/unimarc_field_124.pl In-Reply-To: <bug-32850-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32850-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32850-70-CvpeiQYzTH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32850 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:08:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:08:01 +0000 Subject: [Koha-bugs] [Bug 32850] Fix cataloguing/value_builder/unimarc_field_124.pl In-Reply-To: <bug-32850-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32850-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32850-70-yVgxeOOCno@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32850 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:08:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:08:46 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-8YluYSGQ9V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:08:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:08:48 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-Oq9Ed3WuZ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149434|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149436&action=edit Bug 33481: Pass content-type when requesting EBSCO's webservice Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:13:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:13:20 +0000 Subject: [Koha-bugs] [Bug 33483] New: Cannot link EBSCO's package with local agreement Message-ID: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Bug ID: 33483 Summary: Cannot link EBSCO's package with local agreement Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 33066 The modal opens empty with "Loading..." Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 [Bug 33066] We need a KohaTable Vue component -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:13:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:13:20 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-1wxkNouequ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 [Bug 33483] Cannot link EBSCO's package with local agreement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:15:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:15:18 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-YYkU6yRUUH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:15:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:15:21 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-gOrqiWn56l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149437&action=edit Bug 33483: Fix link EBSCO package with local agreements Bug 33066 broke that, we need to set 'initialized'. Test plan: Turn on EBSCO provider, search for a package and click "Add new agreement". The modal must open with the list of agreements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:17:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:17:08 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-Rb3CxavxF4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 --- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- It appears that some update on EBSCO's end has started to cause this error (tighter validation?). It also appears we should be sending the request header in the first place anyway, and we weren't. https://developer.ebsco.com/knowledge-services/holdingsiq/code-samples The patch fixes the "add packages to holdings" button bug, sample link to reproduce: http://localhost:8081/cgi-bin/koha/erm/eholdings/ebsco/packages/186-3962361 However the same apparent issue is also happening on "add titles to holdings" but not sure yet if related to this or a different bug, logs and console are not showing anything at first glance: http://localhost:8081/cgi-bin/koha/erm/eholdings/ebsco/resources/19-2691705-28038201 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:20:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:20:40 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-gR1fPlcOw3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com Status|Needs Signoff |Failed QA --- Comment #8 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Hi! Overall the new syspref and notices management page is working as expected. However, there are a few things I noticed that seem to be a little broken. 1. In the Notices Management page if you search for a patron and their name populates then clicking on the populated name will appropriately take you to their notice history. However, if you use the "Browse by last name" option or if you just search for a letter such as "K", then the table that is supposed to show the patron names is not displayed properly. It is askew to the left and mixes into the filter options. 2. The print notices work, but there is a lot of whitespace within the messages. This might be a separate bug, but having the messages more condensed and still separated by the horizontal line would be ideal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:25:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:25:16 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-Fi7SZKxglj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149254|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149438&action=edit Bug 33408: Store sysprefs in a new ERM store We need the sysprefs' values to be shared between the components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:25:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:25:38 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-8k08n2zDwa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:25:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:25:47 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-I3uu1MTfBj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:29:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:29:26 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-NQB1YtfwVN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Laura Escamilla from comment #2) > Patch failed to apply: Can you pull the latest master and try again please? It looks ok for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:30:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:30:50 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-x5wkfPIVu2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Pedro Amorim from comment #3) > However the same apparent issue is also happening on "add titles to > holdings" but not sure yet if related to this or a different bug, logs and > console are not showing anything at first glance: > http://localhost:8081/cgi-bin/koha/erm/eholdings/ebsco/resources/19-2691705- > 28038201 It works for me on other resources, for instance /cgi-bin/koha/erm/eholdings/ebsco/resources/19-3754-560226 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:31:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:31:33 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-slexMLxIaH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:45:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:45:01 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32013-70-lVIqG43cWy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 --- Comment #19 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Seems logical to me and code looks fine - thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:47:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:47:02 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-p3z5ZuKILg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 --- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149439&action=edit Bug 33482: Add Unsupported Media Type exception -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:47:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:47:05 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-bs8gY2NUhT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 --- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149440&action=edit Bug 33482: Unsupported Media Type exception in packages patch method This adds the Unsupported Media Type exception error code and error message to the UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:49:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:49:38 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-WYseEc72sp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 --- Comment #4 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- The error code and message are now showing when reproducing the error for packages and titles, however you'll notice the patch only contains changes to erm_eholdings_packages.yaml, this is because "adding titles to holdings" is using the same endpoint. @Joubu just to confirm, is this intended? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:49:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:49:58 +0000 Subject: [Koha-bugs] [Bug 33484] New: Generalise table saveState for all tables Message-ID: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Bug ID: 33484 Summary: Generalise table saveState for all tables Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We should really make bug 22276 work globally rather than having a bug per table to add this feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:50:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:50:04 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-CkM6xfNGwI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:53:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:53:34 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-Nx73a8d6gm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #13) > Comment 5 still valid. Nick? I am happy either way - if you want to remove 'process', please file a bug :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:57:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:57:15 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-MnhzOuVozC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 [Bug 22276] Add client storage of user-selected DataTables configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:57:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:57:15 +0000 Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected DataTables configuration In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22276-70-1onaPUMA0S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 [Bug 33484] Generalise table saveState for all tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:58:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:58:03 +0000 Subject: [Koha-bugs] [Bug 32939] Have generic fetch functions in vue modules In-Reply-To: <bug-32939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32939-70-gyhpICIP8Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #81 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149441&action=edit Bug 32939: Fix title endpoint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:59:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:59:14 +0000 Subject: [Koha-bugs] [Bug 33485] New: Add/remove title from holdings is not using the correct endpoint Message-ID: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 Bug ID: 33485 Summary: Add/remove title from holdings is not using the correct endpoint Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 32939 Bad copy/paste from 32939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 [Bug 32939] Have generic fetch functions in vue modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:59:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:59:14 +0000 Subject: [Koha-bugs] [Bug 32939] Have generic fetch functions in vue modules In-Reply-To: <bug-32939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32939-70-GZKMNDH77H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33485 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 [Bug 33485] Add/remove title from holdings is not using the correct endpoint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:59:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:59:30 +0000 Subject: [Koha-bugs] [Bug 32939] Have generic fetch functions in vue modules In-Reply-To: <bug-32939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32939-70-LwVzCGqPeP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32939 --- Comment #82 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #81) > Created attachment 149441 [details] [review] > Bug 32939: Fix title endpoint Moved to bug 33485. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 14:59:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 12:59:39 +0000 Subject: [Koha-bugs] [Bug 33485] Add/remove title from holdings is not using the correct endpoint In-Reply-To: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33485-70-JThmm7A6Dg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:00:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:00:28 +0000 Subject: [Koha-bugs] [Bug 33485] Add/remove title from holdings is not using the correct endpoint In-Reply-To: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33485-70-EgEi67bYT1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:00:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:00:30 +0000 Subject: [Koha-bugs] [Bug 33485] Add/remove title from holdings is not using the correct endpoint In-Reply-To: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33485-70-deYGMaUE8J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149442&action=edit Bug 33485: (bug 32939 follow-up) Fix title endpoint The change is obvious, we shoulf call the title endpoint, not package. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:12:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:12:15 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing randomly In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-V7oyCcOyqs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Still failing Koha_Master_MDB_Latest/1286 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:14:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:14:15 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-KNBJjiCZoC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Sorry, I don't have time for this now. Back to PQA, but we should not push as it IMO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:28:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:28:13 +0000 Subject: [Koha-bugs] [Bug 24977] Enable translations for authorised values (POC) In-Reply-To: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24977-70-S7yFpU5rTk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20307 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Is this is a possible duplicate of bug 20307? Both appear a bit stuck :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:28:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:28:13 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20307-70-T31ryq5A8a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24977 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:40:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:40:50 +0000 Subject: [Koha-bugs] [Bug 33486] New: Remove Koha::BackgroundJob::UpdateElasticIndex->process routine Message-ID: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Bug ID: 33486 Summary: Remove Koha::BackgroundJob::UpdateElasticIndex->process routine Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com Bug 32594 introduced a dedicated worker for ES background jobs. It now handles all elastic indexing, and should be the only process that does so. To avoid confusion, we should remove the 'process' method from the background module as it is not expected to be called -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:41:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:41:21 +0000 Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disabled In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24806-70-KWBrU0HPaV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 --- Comment #15 from Hans PĂ„lsson <hans.palsson at hkr.se> --- Hi! The suggestion is ok. The important thing is the possibility to hide/disable OPAC integration without "hacking" CSS or similar, as we do today. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:44:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:44:12 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-sxXBxz3eJn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:44:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:44:14 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-2eklkmLwmk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149443&action=edit Bug 33486: Remove Koha::BackgroundJob::UpdateElasticIndex->process -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:44:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:44:34 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-oAGw6kqrf6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:44:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:44:34 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-4dip6JrGyp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 [Bug 33316] Improve display of ES indexer jobs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:45:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:45:02 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-EcMzT06j2m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 15:47:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 13:47:22 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-y0c4BA6a7p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #15) > Sorry, I don't have time for this now. > > Back to PQA, but we should not push as it IMO. This is only a display change - can you explain your worries? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:05:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:05:08 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-sPErnZfBcZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149444&action=edit Bug 33484: Make saveState column handling global This patch updates the handling for saveState added in bug 22276 to work globally for all KohaTables that pass a table_settings hash. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:05:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:05:10 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-qRKd2sw4Kg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149445&action=edit Bug 33484: Revert template change introduced in bug 22276 With the globalisation of the stateSave handling introduced by bug 22276 we can remove the localised changes to the template in branches.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:05:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:05:50 +0000 Subject: [Koha-bugs] [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt In-Reply-To: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33426-70-0GyAuN9EYv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Please see bug 33484 for a more global approach to this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:07:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:07:47 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-f7Hn2IYAKj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:10:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:10:30 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-izyjhm5SW4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- To Test. 1) Confirm the test plan for bug 22276 still passes. 2) Check other instances where KohaTable is used and table_settings (i.e. you can choose what columns to display) is passed.. all should now save and restore state upon navigating back to them I'm not 100% sure about the original patch.. I feel it does more than expected in so much as saveState also saves and restores pagination, search filters etc etc. Secondly.. whilst I do this for the KohaTable (found in column_settings.inc).. I haven't added it to the DT REST wrapper.. or Vue components.. we should really do all three... but I wanted to start getting feedback first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:10:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:10:46 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-bX2Dcuttbx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |lucas at bywatersolutions.com, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:11:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:11:05 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-RcIfXm1tZy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:12:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:12:11 +0000 Subject: [Koha-bugs] [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt In-Reply-To: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33426-70-lxzHbcEnzB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Awesome work btw Emily.. I didn't mean to rain on your parade here.. the code works perfectly here and I'll SO on it.. we can perhaps replace with bug 33484 once it's ready and keep your work here credited :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:13:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:13:31 +0000 Subject: [Koha-bugs] [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt In-Reply-To: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33426-70-2ofUpSLAUL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149222|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149446&action=edit Bug 33426: Add DataTables saveState to suggestion.tt To test: 1. In the staff client, go to Purchase Suggestion management page and add a suggestion if needed to make the table display. 2. Make some changes to the table settings (hide/show columns, change sort column, and/or change number of rows to display) 3. Navigate to a different page. 4. Navigate back to Purchase Suggestions page. Note that the table settings have been reset. 5. Apply patch and restart_all 6. Repeat steps 1-4. Note that this time the changes to the table settings were preserved. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:13:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:13:51 +0000 Subject: [Koha-bugs] [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt In-Reply-To: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33426-70-Mfb6UX7fV6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:14:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:14:32 +0000 Subject: [Koha-bugs] [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt In-Reply-To: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33426-70-aCN5smzmm8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Going straight for QA on this one.. it works perfectly as designed.. it's the design of the original bug I dissagree with ;P Making my bug depend on both so we can keep Emily's contribution recorded :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:14:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:14:50 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-l2zOA3ia19@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33426 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:14:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:14:50 +0000 Subject: [Koha-bugs] [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt In-Reply-To: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33426-70-kXGRqzP0PZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 [Bug 33484] Generalise table saveState for all tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:17:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:17:22 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-y250pUaCcz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149444|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149447&action=edit Bug 33484: Make saveState column handling global This patch updates the handling for saveState added in bug 22276 to work globally for all KohaTables that pass a table_settings hash. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:17:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:17:25 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-3eWEM2Ya0J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149445|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149448&action=edit Bug 33484: Revert template change introduced in bug 22276 With the globalisation of the stateSave handling introduced by bug 22276 we can remove the localised changes to the template in branches.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:17:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:17:27 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-Xw6nqxEQF3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149449&action=edit Bug 33484: Revert template change on suggestion.tt This reverts commit 2b0693dbfd6aa2dd2c7c91428b23aba717ccc0af as it's no longer required once we globalise the logic as we do in this patchset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:20:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:20:21 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-CPZc0sBcOx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:21:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:21:09 +0000 Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected DataTables configuration In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22276-70-bccvwWmxcL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Katrin Fischer from comment #17) > (In reply to Jonathan Druart from comment #16) > > Why do we have this in branches.tt only? We don't want to have one follow-up > > bug per table, we need to apply it from datatabase.js (or .inc or wherever, > > but in a single place). > > If this is possible, I think we should do it. It would be so nice to have > this globally. See bug 33484 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:21:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:21:11 +0000 Subject: [Koha-bugs] [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt In-Reply-To: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33426-70-Muzw1jbGal@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 --- Comment #9 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- Thanks Martin! :) I agree that generalizing it is a better approach - working on testing yours now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:42:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:42:29 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-mdTuZItfRb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #14 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- (In reply to David Nind from comment #13) > The tests don't pass after applying the patches: > > prove t/db_dependent/api/v1/authorities.t > t/db_dependent/api/v1/authorities.t .. 1/3 > # Failed test '409 Conflict' > # at t/db_dependent/api/v1/authorities.t line 204. > # got: '201' > # expected: '409' This is odd. It fails on Zebra, and passes on ES. It means the FindDuplicateAuthority method is not behaving the same on each. I'll mock the call to the method and file a new bug for the method specifically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 16:58:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 14:58:20 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-ZPNeuSCiDW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #7 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- This works on some pages, but not on others. I have a meeting in a few minutes and so can't test them all at the moment, but this is what I've found so far: Pages that work: pendingreserves.pl suggestions.pl Pages that don't retain the save state: branches.pl members-home.pl (table id: memberresults) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:14:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 15:14:56 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-jVA9PlbKf9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149439|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:15:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 15:15:00 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-h1roWvL0XJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149440|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:16:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 15:16:34 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-SgALgjjBiN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:16:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 15:16:38 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-Za1hWvJIZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149435|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149450&action=edit Bug 33482: Propagate errors from EBSCO's ws to the UI When adding or removing eholdings from EBSCO, if an error happens it is lost and not propagated to the UI. We were missing a return in the logic, and always returning 200 Test plan: Do not apply (or revert) bug 33481 Configure EBSCO for ERM and add a package to your holdings With this patch applied you will get a 500 that is propagated to the UI Without this patch nothing happens and the user is not aware that something bad happened Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:30:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 15:30:42 +0000 Subject: [Koha-bugs] [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level In-Reply-To: <bug-20463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20463-70-swTOlERPvX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:33:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 15:33:13 +0000 Subject: [Koha-bugs] [Bug 33487] New: Elasticsearch: Create an index for LDR, pos 19 - Multipart resource record level Message-ID: <bug-33487-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33487 Bug ID: 33487 Summary: Elasticsearch: Create an index for LDR, pos 19 - Multipart resource record level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de Depends on: 20463 Bug 20463 added a new index for LDR pos. 19. We should also add it to Elasticsearch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:33:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 15:33:13 +0000 Subject: [Koha-bugs] [Bug 20463] Create an index for LDR, pos 19 - Multipart resource record level In-Reply-To: <bug-20463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20463-70-ENhbQiiBGW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20463 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33487 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33487 [Bug 33487] Elasticsearch: Create an index for LDR, pos 19 - Multipart resource record level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:38:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 15:38:27 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-apuIC4JUhU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 --- Comment #15 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 149451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149451&action=edit Bug 31795: (follow-up) Mock call to FindDuplicateAuthority When running against Zebra, this tests fail because it requires the record to be indexed timely. In theory, a 5 seconds delay should be enough for the indexer to pick up. But that's not the point of the test, and we should better just mock the query in this case. To test: 1. Have ktd launch with zebra: $ ktd up -d 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/authorities.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Launch ktd with ES: $ ktd down $ ktd --es7 up -d 6. Repeat 2 => SUCCESS: Tests pass! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:38:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 15:38:54 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-Z1GWyRDEEz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 17:41:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 15:41:14 +0000 Subject: [Koha-bugs] [Bug 32321] 006 field not correctly prepopulated in Advanced cataloging editor In-Reply-To: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32321-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32321-70-WfjPYUcVRR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32321 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 18:00:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 16:00:30 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8367-70-aIaoMFGbsj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 18:00:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 16:00:56 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8367-70-0B1EbcoDSe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 18:08:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 16:08:00 +0000 Subject: [Koha-bugs] [Bug 33488] New: Branch transfer limits should have an index on fromBranch Message-ID: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 Bug ID: 33488 Summary: Branch transfer limits should have an index on fromBranch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In a consortium with many libraries, the branch transfer limits can become complex and have many rows - we have seen 750k+ At this size, searching on limits can take 1/2 a second or more - and when a record has many items this begins to add up fast Adding an index to the fromBranch column greatly reduces the cost of a lookup: CREATE INDEX fromBranch_index ON branch_transfer_limits (fromBranch); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 18:13:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 16:13:59 +0000 Subject: [Koha-bugs] [Bug 33489] New: The borrowers table should have indexes on default patron search fields Message-ID: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 Bug ID: 33489 Summary: The borrowers table should have indexes on default patron search fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org While a library can specify the default patron search fields in the similarly named preference, DefaultPatronSearchFields, Koha should ship with indices on the default fields: firstname,middle_name,surname,othernames,cardnumber,userid These exist for firstname, surname, and othernames We have seen the basic patron search take between 2-4 seconds without these indexes on a database of 700k patrons. When using only the indexed fields, the search takes 6 milliseconds In testing with 100k patrons I saw a reduction after adding the indices from half a second to ~1 centisecond -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 18:23:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 16:23:06 +0000 Subject: [Koha-bugs] [Bug 33172] Should not be possible to delete item with open transit In-Reply-To: <bug-33172-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33172-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33172-70-nBKhVUpvVf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33172 Rebecca Coert <rcoert at arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us --- Comment #1 from Rebecca Coert <rcoert at arlingtonva.us> --- +1 agreed - items in transit should not be able to be deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 18:31:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 16:31:55 +0000 Subject: [Koha-bugs] [Bug 33490] New: Agreements - Filter by expired results in error Message-ID: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Bug ID: 33490 Summary: Agreements - Filter by expired results in error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: pedro.amorim at ptfs-europe.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 32030 [ERROR] GET /api/v1/erm/agreements: unhandled exception (DBIx::Class::Exception)<<DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'agreement_id' in where clause is ambiguous at /kohadevbox/koha/Koha/Objects.pm line 394 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 18:31:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 16:31:55 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32030-70-Ide251kdvM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 [Bug 33490] Agreements - Filter by expired results in error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 18:34:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 16:34:02 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-ho3CXkhZfd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149452&action=edit Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 18:57:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 16:57:20 +0000 Subject: [Koha-bugs] [Bug 33491] New: EBSCO Packages - Add new agreement UI has some issues Message-ID: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Bug ID: 33491 Summary: EBSCO Packages - Add new agreement UI has some issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: pedro.amorim at ptfs-europe.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 33483 Created attachment 149453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149453&action=edit screenshot of UI Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 [Bug 33483] Cannot link EBSCO's package with local agreement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 18:57:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 16:57:20 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-FUPhJskCMK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33491 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 [Bug 33491] EBSCO Packages - Add new agreement UI has some issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 18:58:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 16:58:52 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-MjcN7rBKiQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- * There's a problem with the "filter by mine" filter at the top * There's a problem with the table not going full width, this is not as trivial as the fix I did for bug 33066 here https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33066&attachment=149183 Can't just move the table out of the <fieldset> since it's a nested component. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:04:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:04:28 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-ObEqhcM6Kf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 --- Comment #8 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Kyle, can we move this back to "Signed-off"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:09:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:09:27 +0000 Subject: [Koha-bugs] [Bug 32911] Remove ILL partner_code config from koha-conf.xml and turn it into a system preference In-Reply-To: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32911-70-Au3xJmd3C6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Yes 🙂 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:15:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:15:17 +0000 Subject: [Koha-bugs] [Bug 33485] Add/remove title from holdings is not using the correct endpoint In-Reply-To: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33485-70-XtuqQ3lyPi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:15:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:15:20 +0000 Subject: [Koha-bugs] [Bug 33485] Add/remove title from holdings is not using the correct endpoint In-Reply-To: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33485-70-mUvSKeCmsd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149442|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149454&action=edit Bug 33485: (bug 32939 follow-up) Fix title endpoint The change is obvious, we shoulf call the title endpoint, not package. Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:17:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:17:52 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-X51hfiCXxV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 --- Comment #5 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- It seems bug 33485 has fixed the EBSCO titles issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:20:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:20:09 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-dYtPpy6BhK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:20:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:20:12 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-NxBygfrXax@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149437|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149455&action=edit Bug 33483: Fix link EBSCO package with local agreements Bug 33066 broke that, we need to set 'initialized'. Test plan: Turn on EBSCO provider, search for a package and click "Add new agreement". The modal must open with the list of agreements. Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:20:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:20:14 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-Q2jhs1id4R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149452|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149456&action=edit Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:24:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:24:09 +0000 Subject: [Koha-bugs] [Bug 33492] New: We need EBSCO Cypress tests Message-ID: <bug-33492-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33492 Bug ID: 33492 Summary: We need EBSCO Cypress tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: pedro.amorim at ptfs-europe.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 32030 For discussion. Today we became aware of many new bugs in the EBSCO part of ERM that have apparently found their way over the last few weeks/months(?). We don't have cypress tests for this as it requires EBSCO credentials but is there a way around this? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:24:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:24:09 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32030-70-Rys2C084qR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33492 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33492 [Bug 33492] We need EBSCO Cypress tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:24:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:24:31 +0000 Subject: [Koha-bugs] [Bug 33492] ERM - We need EBSCO Cypress tests In-Reply-To: <bug-33492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33492-70-Mmyjj3c23s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33492 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|We need EBSCO Cypress tests |ERM - We need EBSCO Cypress | |tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:35:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:35:23 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-PFec7FigL0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:35:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:35:25 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-okdVWbf9Wk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149457&action=edit Bug 33489: Add indices to default patron search fields This patch adds indices to the borrowers table to match the default search fields for patrons. To test: 1 - Apply patch 2 - Update database 3 - Ensure patron searching works as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:36:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:36:06 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-QRyFWwcPR2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |jonathan.druart+koha at gmail. | |com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:48:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:48:16 +0000 Subject: [Koha-bugs] [Bug 33488] Branch transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-trKfvjy3Cb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:48:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:48:18 +0000 Subject: [Koha-bugs] [Bug 33488] Branch transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-4hfoYrQBVm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149458&action=edit Bug 33488: Add fromBranch index to branch_transfer_limits To test: 1 - Enable UseBranchTransferLimits by item type 2 - Set some limits for book 3 - Place a hold, verify that pikcup dropdown reflects the limits before and after patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:49:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:49:41 +0000 Subject: [Koha-bugs] [Bug 33488] Branch transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-q0teyFQeA5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33489 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 19:49:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 17:49:41 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-xqYTJh7219@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33488 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:11:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:11:34 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-xNVtoqXjAB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:11:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:11:37 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-EWR2hypF5j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149380|0 |1 is obsolete| | --- Comment #16 from David Nind <david at davidnind.com> --- Created attachment 149459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149459&action=edit Bug 31795: Add REST endpoint to add an authority To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Make a POST request to /api/v1/authorities with one of the following content type header - application/json - application/marcxml+xml - application/marc-in-json - application/marc 4. If content type is other than application/json, then add the following header to the request: "x-authority-type: <auth type code>" 5. Check that the authority is created 6. Sign off Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:11:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:11:40 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-T4Zpf63U2t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149407|0 |1 is obsolete| | --- Comment #17 from David Nind <david at davidnind.com> --- Created attachment 149460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149460&action=edit Bug 31795: (QA follow-up) Use x-koha-override header Despite its title, this patch does a couple more things. 1. The tests are rewritten to cover more things, and also to avoid deleting all authorities inside the transaction. It is really not required. 2. It makes the endpoint rely on the already generically implemented x-koha-override header, which is intended for the same use case as x-confirm-not-duplicate is for. 3. It changes the return codes to match the coding guidelines [1] 4. Only checks for duplicates if no override passed. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/authorities.t => SUCCESS: Tests pass! 2. Apply this follow-up 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D [1] https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER3.2.1_POST Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:11:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:11:43 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-YLROYGc664@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149409|0 |1 is obsolete| | --- Comment #18 from David Nind <david at davidnind.com> --- Created attachment 149461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149461&action=edit Bug 31795: Fix required permissions Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:11:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:11:46 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-n6QYsZgw6j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149451|0 |1 is obsolete| | --- Comment #19 from David Nind <david at davidnind.com> --- Created attachment 149462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149462&action=edit Bug 31795: (follow-up) Mock call to FindDuplicateAuthority When running against Zebra, this tests fail because it requires the record to be indexed timely. In theory, a 5 seconds delay should be enough for the indexer to pick up. But that's not the point of the test, and we should better just mock the query in this case. To test: 1. Have ktd launch with zebra: $ ktd up -d 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/authorities.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Launch ktd with ES: $ ktd down $ ktd --es7 up -d 6. Repeat 2 => SUCCESS: Tests pass! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:12:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:12:29 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: <bug-31672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31672-70-32X4h5Nm15@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #5 from Christopher Brannon <cbrannon at cdalibrary.org> --- Usually there is an explanation for the changes. Would you mind sharing what led to the need for this change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:21:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:21:17 +0000 Subject: [Koha-bugs] [Bug 33493] New: Add a filter relationship for branchtransfers Message-ID: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 Bug ID: 33493 Summary: Add a filter relationship for branchtransfers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Moved from bug 33167 Prefetching is useful, but we don't want to fetch all the inactive transfers for an item. This patch will a filtered relationship and update get_transfer/s to use this -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:26:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:26:05 +0000 Subject: [Koha-bugs] [Bug 13529] Easy analyticals and UseControl number should be able to coexist In-Reply-To: <bug-13529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13529-70-pPAh5xrmze@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13529 Lauren Denny <lauren_denny at sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:30:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:30:11 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-dH3FuRQAlR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:30:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:30:14 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-vVriP5fS1o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149457|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 149463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149463&action=edit Bug 33489: Add indices to default patron search fields This patch adds indices to the borrowers table to match the default search fields for patrons. To test: 1 - Apply patch 2 - Update database 3 - Ensure patron searching works as before Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:31:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:31:19 +0000 Subject: [Koha-bugs] [Bug 33494] New: Catalog concerns - Toggle 'Hide resolved' and 'Show all' Message-ID: <bug-33494-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33494 Bug ID: 33494 Summary: Catalog concerns - Toggle 'Hide resolved' and 'Show all' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When viewing the Catalog concerns report (Cataloging > Catalog concerns), there are two links/buttons at the top of the page: Hide resolved and Show all. If all is already shown, 'Show all' is useless. Same thing with if 'Hide resolved' is clicked, this option becomes obsolete. Elsewhere in Koha (for example in Administration > Debit types), we offer 'Filter ...' and when that is clicked, the link changes to 'Show all ...'. In the catalog concerns page, it should alternate between 'Filter resolved concerns' and 'Show all concerns'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:32:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:32:06 +0000 Subject: [Koha-bugs] [Bug 33495] New: Patron search results can be misleading Message-ID: <bug-33495-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33495 Bug ID: 33495 Summary: Patron search results can be misleading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If I search for a patron barcode, particularly one that has been deleted, there is a slight chance that this number could be part of another searchable field in the patron record, like a phone number. In that case, the Koha might just go straight into the record without skipping a beat, and staff make the assumption that they are in the correct record. It would be preferable that unless an exact match is made on search criteria, Koha only displays search results rather than going straight into the record, if it is only the closest match. There is still room for error, but this would help shave that rate down a bit. Close or partial matches should not go straight into a record. If you are typing a patron name or number and the suggestions show up, it is on the staff member for picking the right or wrong patron. But if the system is throwing us into a record based on loose information, that is a problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:32:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:32:20 +0000 Subject: [Koha-bugs] [Bug 33494] Catalog concerns - Toggle 'Hide resolved' and 'Show all' In-Reply-To: <bug-33494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33494-70-ut2Br7ucBg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33494 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31028 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:32:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:32:20 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-T2qA0hUz2v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33494 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33494 [Bug 33494] Catalog concerns - Toggle 'Hide resolved' and 'Show all' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:32:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:32:20 +0000 Subject: [Koha-bugs] [Bug 33327] Hide resolved catalog concerns by default In-Reply-To: <bug-33327-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33327-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33327-70-LbMxUuiCGw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33327 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33494 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:33:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:33:49 +0000 Subject: [Koha-bugs] [Bug 33494] Catalog concerns - Toggle 'Hide resolved' and 'Show all' In-Reply-To: <bug-33494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33494-70-pLwOHCzPnc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33494 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- The icon should also probably be changed to the funnel, to match other places where there are filter/show all links. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:34:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:34:04 +0000 Subject: [Koha-bugs] [Bug 27507] Search host record using control number identifier / organization code In-Reply-To: <bug-27507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27507-70-aIgTXz2VJY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27507 Lauren Denny <lauren_denny at sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:37:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:37:14 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-RJzSSU9Tur@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:37:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:37:16 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-kak87eIwHy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149464&action=edit Bug 33493: Add a filter relationship for branchtransfers Prefetching is useful, but we don't want to fetch all the inactive transfers for an item. This patch adds a filtered relationship and updates get_transfer(s) to use this To test: prove -v t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:39:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:39:08 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-6MnNNW13oS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:39:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:39:19 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-hrYBTadEe2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 [Bug 33167] Bibs with several hundred items causes a slow loading screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:39:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:39:19 +0000 Subject: [Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-jeuNvrLjBq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33493 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 [Bug 33493] Add a filter relationship for branchtransfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:40:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:40:05 +0000 Subject: [Koha-bugs] [Bug 33496] New: Add 'host_items' param to Koha::Biblio->items Message-ID: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 Bug ID: 33496 Summary: Add 'host_items' param to Koha::Biblio->items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This patch will add an option to the $biblio->items method to allow retrieving the items and analytic items for a record. This is intended to allow fetching a single Items object, and related object, rather than having to fetch the items, and the host items, and push them together -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:50:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:50:40 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-3aYA9BKicl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:50:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:50:42 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-K6ob66w9W4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149465&action=edit Bug 33496: Add 'host_items' param to Koha::Biblio->items This patch adds an option to the $biblio->items method to allow retrieving the items and analytic items for a record. This is intended to allow fetching a single Items object, and related object, rather than having to fetch the items, and the host items, and push them together This is step towards being able to fetch items using API/DataTables directly To test: 1 - prove -v t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:51:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:51:45 +0000 Subject: [Koha-bugs] [Bug 33497] New: Reduce DB calls on staff detail page Message-ID: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 Bug ID: 33497 Summary: Reduce DB calls on staff detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:52:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:52:29 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-gHJrFyNbGy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:52:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:52:32 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-iNhpJkd9fG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149417|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 149466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149466&action=edit Bug 33466: Link to the vendor from the ERM module There are 3 tables in the ERM module where we display the vendor name but without a link to the acquisition module. This patch adds the links. Test plan: Create an agreement, a license and a local package. Pick a vendor and notice that now there is a link on the list view. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:57:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:57:01 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-JFyDxTc2nf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:57:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:57:03 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-YnCp2MhzOp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149467&action=edit Bug 33497: Use 'host_items' param to fetch all items at once This patch adjusts the detail page to fetch items and host items together, and prefetches transfers and checkouts To test: 1 - Enable easy analytics 2 - Attach some items to a bib 3 - Checkout an item on the bib 4 - View the details page 5 - Apply patch 6 - View details page, confirm nothing has changed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:57:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:57:05 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-Fbx77L1lgS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149468&action=edit Bug 33497: Add a filter relationship for branchtransfers This uses the new relationship from bug 33493 to fetch the transfers for items To test: 1 - Transfer some items on a bib 2 - View the biblio details page in the staff interface 3 - Apply patch 4 - Confirm the view is the same -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:57:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:57:28 +0000 Subject: [Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-PdDnVsHcJb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148432|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:57:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:57:37 +0000 Subject: [Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-2dYoDByJZT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148433|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:57:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:57:52 +0000 Subject: [Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-uj9VWRuhmo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148434|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:58:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:58:51 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-rPTVqTentc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33167 | Depends on| |33167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 [Bug 33167] Bibs with several hundred items causes a slow loading screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:58:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:58:51 +0000 Subject: [Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-PLONtK1BF9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33493 Depends on|33493 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 [Bug 33493] Add a filter relationship for branchtransfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:59:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:59:09 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-Dpb5I55yAV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. Enable the ERM module (ERMModule system preference). 2. In the ERM module add an agreement, a licence, and a package - when creating this use 'My Vendor' for the vendor field for each of them. 3. Note that in the table listings for agreements, licences, and packages that 'My Vendor' in the vendor column is not linked to the vendor record. 4. Apply the patch. 5. Run: yarn build 6. Restart everything (restart_all). 7. Now note for step 3, that 'My Vendor' is now linked to the vendor record (and correctly goes to the vendor page). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:59:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:59:11 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-len2tsQYse@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33167, 33496, 33493 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 [Bug 33167] Bibs with several hundred items causes a slow loading screen https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 [Bug 33493] Add a filter relationship for branchtransfers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 [Bug 33496] Add 'host_items' param to Koha::Biblio->items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:59:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:59:11 +0000 Subject: [Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-KR7rqzx5qk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 [Bug 33497] Reduce DB calls on staff detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:59:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:59:11 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-BqTSo95UAX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 [Bug 33497] Reduce DB calls on staff detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 20:59:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 18:59:11 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-jQSp3CywDp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 [Bug 33497] Reduce DB calls on staff detail page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:09:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:09:28 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-iu5yF6KnO0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:09:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:09:30 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-eBqN3jVdnT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149464|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 149469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149469&action=edit Bug 33493: Add a filter relationship for branchtransfers Prefetching is useful, but we don't want to fetch all the inactive transfers for an item. This patch adds a filtered relationship and updates get_transfer(s) to use this To test: prove -v t/db_dependent/Koha/Item.t Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:11:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:11:14 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-dEd4nSzl3R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |david at davidnind.com --- Comment #2 from David Nind <david at davidnind.com> --- Added assignee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:12:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:12:36 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-q3mwmBcu3T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | --- Comment #3 from David Nind <david at davidnind.com> --- Added assignee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:16:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:16:03 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-qsHMkd8uv4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:16:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:16:06 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-KrarvMMDr1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149456|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149470&action=edit Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:16:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:16:09 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-wARf2Byyth@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149471&action=edit Bug 33483: Make KohaTable accept customizable actions button We have hardcoded some buttons: edit, delete But we could need specific buttons. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:16:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:16:12 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-x5eH4w4T5q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149472&action=edit Bug 33483: Restore 'select' We are not supposed to see edit and delete buttons, but select instead, to pick an agreement. Regression introduced by commit 809f90d394fdef8142fdf8f4a6e825dc14a132d4 Bug 33066: Remove build_datatable Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:20:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:20:03 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-ssI5DB6vaS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149473&action=edit Bug 33483: (follow-up) Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:22:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:22:44 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-k6NQ8LTIFn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I don't recreate this one, can you provide more details please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:22:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:22:50 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-5BNEH2jfA1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:39:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:39:20 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-3sB4PgVLXJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149474&action=edit Bug 33491: Fix UI issues in EHoldingsEBSCOPackageAgreements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:40:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:40:18 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-XpabDSkQ2O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This patch is not ideal but it's fixing the main problems. Pedro, do you think it's acceptable as it, at least for backport maybe then we see how we can improve this view later? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 21:42:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 19:42:39 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-ziGqsMa9Fj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- Update: The tables that aren't retaining the save state are generated with the REST API wrapper from datatables.js, not the KohaTable wrapper from column_settings.inc. All the tables I've tested that use the KohaTable wrapper do retain the save state as intended. I think I do need to set this in its current state to Failed QA for causing a regression on branches.tt, though. As for the fact that saveState saves pagination and filters, there are certainly times when that's less desirable, but there are times when it is desirable too. Part of what spurred me to create bug 33426 was that our selectors want that behavior on the purchase suggestion table. Also, to be fair, the same could be said for saving the column configuration - there are definitely times when staff hide certain columns to make a page print more nicely, but don't necessarily need that state to persist. That being said...there are definitely some tables where saving the search filters is almost never going to be desirable. For example, on holdings_table in detail.pl, because the search filter on one bib will carry over to a different bib where that search filter may not even make sense. Not sure what the right answer is here... Go back to adding saveState only to certain tables individually, where it's actually needed? Add it globally but make it configurable (which would add some scope creep)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:05:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:05:13 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-jR1R7SKO3y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Emily, thanks for your comments! I hope I won't get myself into trouble for this... but could it be a flag we set on the column configuration page? But that would bring us back to having a different behaviour for column controlled vs. column uncontrolled tables... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:26:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:26:58 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: <bug-31672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31672-70-ZnOR9mpJVc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think we had talked about this one on the IRC chat. IIRC: * It was a way to shorten the descriptions, especially for languages where the words are much longer anyway and My turns into more letters too. * For German it also removes the problem between formal and informal translation of you (different words). * We had agreed that it seemed uncommon given the rest of Koha's interface and comparing with other applications. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:27:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:27:15 +0000 Subject: [Koha-bugs] [Bug 33498] New: Catalog concerns - Lots of whitespace before the notice text Message-ID: <bug-33498-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33498 Bug ID: 33498 Summary: Catalog concerns - Lots of whitespace before the notice text Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org When viewing the catalog concerns notices in the patron's file, there is a big whitespace before the text. To reproduce: 1. Enable CatalogConcerns in system preferences 2. Enter an email address in CatalogerEmails 3. Add a concern on a bibliographic record from the staff interface 3.1. Search the catalog for a record 3.2. Click the title to access the details page 3.3. Click New > New catalog concern 3.4. Fill out the form 3.5. Click "Submit" 4. Add an update to the concern 4.1. Go to Cataloging > Catalog concerns 4.2. Click "Details" next to the concern 4.3. Enter some text in the "Update" field 4.4. Check "Notify" 4.5. Click "Comment" 5. Resolve the concern 5.1. Click "Details" again 5.2. Enter some text in the "Update" field 5.3. Check "Notify" 5.4. Click "Resolve" 6. View the notices in the reporter's account 6.1. At the top right, click your username and choose My account 6.2. Click "Notices" on the left 6.3. Click "Catalog concern acknowledgment" (TICKET_ACKNOWLEDGE) --> Long whitespace followed by the text 6.4. Close the preview 6.5. Click "Catalog concern updated" (TICKET_UPDATE) --> Long whitespace followed by the text 6.6. Close the preview 6.7. Click "Catalog concern resolved" (TICKET_RESOLVE) --> Long whitespace followed by the text 7. Check the notice in the CatalogerEmail inbox 7.1. Go to the inbox for the email address in CatalogerEmail and view the "Catalog concern reported" message (TICKET_NOTIFY) (note: in sandbox, check the "Koha mail log") --> Long whitespace followed by text -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:27:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:27:25 +0000 Subject: [Koha-bugs] [Bug 33498] Catalog concerns - Lots of whitespace before the notice text In-Reply-To: <bug-33498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33498-70-h6VE8VXbYl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33498 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31028 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:27:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:27:25 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-bUj7bL6PsT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33498 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33498 [Bug 33498] Catalog concerns - Lots of whitespace before the notice text -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:29:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:29:31 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-58xIp6gOXh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #4) > (In reply to Katrin Fischer from comment #3) > > Sorry, the test plan is not detailed enough for me - can you please add some > > more info? > > You need to play with the code, or test a follow-up bug. > > The code I pasted in the commit message is enough to test the change. You > can pick a place in a Vue component ('script' part), add the change, hit > the page when the component is mounted, then confirm that the syspref value > has been changed in DB. I only understood half of that, probably because I have not even basic knowledge of how Vue works. I'll leave this to someone more knowledgeable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:36:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:36:57 +0000 Subject: [Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button In-Reply-To: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33233-70-dlM4X5yVXb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:40:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:40:08 +0000 Subject: [Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups In-Reply-To: <bug-32105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32105-70-dkkKNiD5CV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Michael Hafen <michael.hafen at washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |michael.hafen at washk12.org |ity.org | --- Comment #3 from Michael Hafen <michael.hafen at washk12.org> --- Created attachment 149475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149475&action=edit Bug 32105 - Add Library and Individual sharing modes to Patron Lists Test Plan: 1. apply patch, restart Plack, etc. 2. create or select three users, two at the same library and one not. 3. create or select a patron list owned by one of the users at the same library. 4. edit list and change sharing mode to 'Library and individuals'. 5. login as the other user at the same library and navigate to patron lists. 6. observe that the list is shared. 7. login as the third user and navigate to patron lists. 8. observe that the list is not shared with this user. 9. login as the owner of the list. 10. edit the list and add the third user as an individual. 11. login as the third user and navigate to patron lists. 12. observe that the list is now shared with the third user. 13. login as the owner of the list. 14. edit the list to change the sharing mode to 'Individuals'. 15. login as the second and third users. 16. observe that the list is not shared with the second user, but still is with the third user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:40:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:40:22 +0000 Subject: [Koha-bugs] [Bug 32105] Patron lists needs to share to specific people or groups In-Reply-To: <bug-32105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32105-70-PqeSMh2d1V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 Michael Hafen <michael.hafen at washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32730 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 [Bug 32730] Add patron lists tab to patron details and circulation pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:40:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:40:22 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32730-70-9rZve8rs8k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen <michael.hafen at washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32105 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32105 [Bug 32105] Patron lists needs to share to specific people or groups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:44:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:44:34 +0000 Subject: [Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button In-Reply-To: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33233-70-2fS2IAg1WH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:44:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:44:36 +0000 Subject: [Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button In-Reply-To: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33233-70-jTMPMupMPf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149476&action=edit Bug 33233: Don't allow disabled attribute to remain when using browser's back button To test: 1. Go to OPAC advanced search and do a search using only one of the inputs. 2. Once the search is complete use the browser's back button to return to the advanced search. 3. Notice the unused inputs are disabled. 4. Apply patch and try again. Now the inputs should not be disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:45:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:45:25 +0000 Subject: [Koha-bugs] [Bug 32730] Add patron lists tab to patron details and circulation pages In-Reply-To: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32730-70-G4hdjr5FXz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32730 Michael Hafen <michael.hafen at washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146039|0 |1 is obsolete| | Attachment #147982|0 |1 is obsolete| | --- Comment #16 from Michael Hafen <michael.hafen at washk12.org> --- Created attachment 149477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149477&action=edit Bug 32730: Add Patron Lists tab to patron details and circulation pages [Rebased 2023-04-10] Test Plan: 1. Apply patch 2. create a patron list if there aren't any 3. search for a patron 4. observe the "Patron lists" tab showing the list that the patron is not in 5. try adding the patron to the list and removing them from the list to be sure the feature has full operation 6. click "Check Out" on the side bar menu to navigate to the circulation page for this patron 7. observe the "Patron lists" tab, and verify it operates as it did on the patron details page Bug 32730: (follow-up) Minor corrections by Owen Leonard This patch corrects an instance of an incorrect capital letter ("Patron Lists" -> "Patron lists") and makes minor tweaks to indentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:47:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:47:37 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-rQWJVmuvg1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #100 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- ERM is totally broken for me :( I have tried it all: git pull, ktd down, ktd pull, ktd up, etc. But I am still stuck with that and no table will display: Source map error: Error: unsupported protocol for sourcemap request webpack://koha/node_modules/vue-select/dist/vue-select.js.map Resource URL: webpack://koha/./node_modules/vue-select/dist/vue-select.js? Source Map URL: vue-select.js.map [Vue warn]: Unhandled error during execution of render function at <DataTable columns= Array(8) [ Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, {
} ] options= Object { language: {
}, dom: '<"dt-info"i><"top pager"<"table_entries"lp><"table_controls"fB>>tr<"bottom pager"ip>', buttons: Proxy, lengthMenu: (2) [
], pageLength: 20, fixedHeader: true, initComplete: initComplete(settings), deferRender: true, paging: true, serverSide: true, 
 } data= Array [] ... > at <KohaTable ref="table" columns= Array(7) [ {
}, {
}, {
}, {
}, {
}, {
}, {
} ] url="/api/v1/erm/licenses" ... > at <LicensesList onVnodeUnmounted=fn<onVnodeUnmounted> ref=Ref< Proxy { <target>: {
}, <handler>: {
} } > > at <RouterView> at <Main> runtime-core.esm-bundler.js:167:17 [Vue warn]: Unhandled error during execution of scheduler flush. This is likely a Vue internals bug. Please open an issue at https://new-issue.vuejs.org/?repo=vuejs/core at <DataTable columns= Array(8) [ Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, {
} ] options= Object { language: {
}, dom: '<"dt-info"i><"top pager"<"table_entries"lp><"table_controls"fB>>tr<"bottom pager"ip>', buttons: Proxy, lengthMenu: (2) [
], pageLength: 20, fixedHeader: true, initComplete: initComplete(settings), deferRender: true, paging: true, serverSide: true, 
 } data= Array [] ... > at <KohaTable ref="table" columns= Array(7) [ {
}, {
}, {
}, {
}, {
}, {
}, {
} ] url="/api/v1/erm/licenses" ... > at <LicensesList onVnodeUnmounted=fn<onVnodeUnmounted> ref=Ref< Proxy { <target>: {
}, <handler>: {
} } > > at <RouterView> at <Main> runtime-core.esm-bundler.js:167:17 Uncaught (in promise) TypeError: currentRenderingInstance is null renderSlot webpack://koha/../node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:3092 render VueJS renderComponentRoot webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:1028 componentUpdateFn webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5730 run webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225 update webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844 setupRenderEffect webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5858 mountComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5640 processComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5598 patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5200 componentUpdateFn webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5737 run webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225 update webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844 setupRenderEffect webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5858 mountComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5640 processComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5598 patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5200 mountChildren webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5384 mountElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5294 processElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5277 patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5197 mountChildren webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5384 mountElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5294 processElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5277 patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5197 componentUpdateFn webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5810 run webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225 update webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844 callWithErrorHandling webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:284 flushJobs webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:514 promise callback*queueFlush webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:406 queueJob webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:400 effect webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5842 triggerEffect webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:430 triggerEffects webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:420 trigger webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:392 set webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:559 set webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:3311 beforeRouteEnter webpack://koha/./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue?./node_modules/vue-loader/dist/index.js??ruleSet[1].rules[5].use[0]:68 promise callback*beforeRouteEnter/< webpack://koha/./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue?./node_modules/vue-loader/dist/index.js??ruleSet[1].rules[5].use[0]:68 setup webpack://koha/./node_modules/vue-router/dist/vue-router.cjs?:2385 setup webpack://koha/./node_modules/vue-router/dist/vue-router.cjs?:2385 callWithErrorHandling webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:284 callWithAsyncErrorHandling webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:293 job webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:1915 flushPostFlushCbs webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:467 flushJobs webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:521 erm_22.1200019.js line 3481 > eval:3092:9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:50:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:50:47 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-EQZYOks0If@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 --- Comment #101 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Fixed by a yarn install before yarn build. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:53:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:53:41 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-WkHRAXyshe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:53:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:53:44 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-8seq7GU3mC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149466|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149478&action=edit Bug 33466: Link to the vendor from the ERM module There are 3 tables in the ERM module where we display the vendor name but without a link to the acquisition module. This patch adds the links. Test plan: Create an agreement, a license and a local package. Pick a vendor and notice that now there is a link on the list view. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 22:57:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 20:57:15 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-03uFE7dhP8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/655 Documentation| |Caroline Cyr La Rose contact| | --- Comment #497 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I finished documenting this, but I see there are some patches that still need to be pushed. I hesitate to put it to "RESOLVED", but I don't have many choices after "Needs documenting" (RESOLVED or CLOSED). Can someone with more permissions maybe put it back to Passed QA or Signed off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:00:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:00:48 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-784Aa9mJuo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:00:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:00:52 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-9S0orm31ba@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148448|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149479&action=edit Bug 33103: DB changes Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:00:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:00:56 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-lMrWU9fuTE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148449|0 |1 is obsolete| | --- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149480&action=edit Bug 33103: DBIC changes Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:00:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:00:59 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-vXOlcfoxLs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148450|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149481&action=edit Bug 33103: DBIC specific Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:01:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:01:03 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-VsKWeEY36z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148451|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149482&action=edit Bug 33103: Koha classes Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:01:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:01:06 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-LDbQzu5CCR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148452|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149483&action=edit Bug 33103: Add tests for Aliases Koha classes Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:01:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:01:09 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-35fQp3d2uR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148453|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149484&action=edit Bug 33103: Add the ability to create vendor aliases This patchset is adding the ability to create aliases for vendors. It will then be easier to search for vendors. * new DB table aqbookseller_aliases(id, vendor_id, alias) * new pair of Koha classes Koha::Acquisition::Bookseller::Alias[es] * new method to retrieve the aliases from the vendor Koha::Acquisition::Bookseller->aliases * The api spec changes to allow aliases to be embeded on GET /acquisitions/vendors * Add/Delete alias when editing a vendor * Display the aliases on the vendor show view * Search vendors by aliases * Display the aliases in the dropdown list of the vendors in the ERM module Test plan: - Create a vendor, add it some aliases - Edit the vendor, remove some aliases => Behaviour must be consistent - Search the vendor in the acquisition module by its aliases => The vendor must be returned in the result - Go to the ERM module, add a new agreement or license => Notice that the dropdown list of the vendors is displaying the aliases, that make vendors searchable by their aliases Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:01:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:01:12 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-PMByHa9wLy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148454|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149485&action=edit Bug 33103: Make vendors searchable by aliases Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:01:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:01:16 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-Ykikc5S2nH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148455|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149486&action=edit Bug 33103: Embed aliases in GET /vendors Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:01:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:01:19 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-48CgQrbHUV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148456|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149487&action=edit Bug 33103: Add REST API tests Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:01:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:01:22 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-6eIrCXqxLA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148457|0 |1 is obsolete| | --- Comment #49 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149488&action=edit Bug 33103: Display the aliases in the dropdown list in ERM Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:01:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:01:25 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-Q6zDCQJerS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148458|0 |1 is obsolete| | --- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149489&action=edit Bug 33103: Deal with html tags HTML tags won't be interpreted. However <script> will still break the display, but it's by nature, JS will execute it even if it's in a string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:01:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:01:28 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-OXGXPycLr2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149414|0 |1 is obsolete| | --- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149490&action=edit Bug 33103: Fix accessibility issues * Add spaces * Add 'Add' and 'Remove' in addition of the icons * Do not submit the form when enter is hit * Fix translatability Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:01:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:01:31 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-ABFK3nJwKo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149419|0 |1 is obsolete| | --- Comment #52 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149491&action=edit Bug 33103: Prevent vendors to be displayed several times in the search result Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:02:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:02:57 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-2ctiKheLuq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #498 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #497) > I finished documenting this, but I see there are some patches that still > need to be pushed. I hesitate to put it to "RESOLVED", but I don't have many > choices after "Needs documenting" (RESOLVED or CLOSED). > > Can someone with more permissions maybe put it back to Passed QA or Signed > off? Hi Caroline, it's a workflow thing, not a permission thing. You can only jump to certain status from one status... so you might have to step through some in order to get to where you want to be. - Maybe we could improve this for Needs documenting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:02:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:02:58 +0000 Subject: [Koha-bugs] [Bug 32435] Add resolution types to catalog concerns In-Reply-To: <bug-32435-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32435-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32435-70-sXE1JnhcHP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 Bug 32435 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:02:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:02:58 +0000 Subject: [Koha-bugs] [Bug 32436] Add 'quick replies' to catalog concerns In-Reply-To: <bug-32436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32436-70-F1xtvej4Km@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32436 Bug 32436 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:02:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:02:58 +0000 Subject: [Koha-bugs] [Bug 33286] 'Catalog record' should be 'Bibliographic record' In-Reply-To: <bug-33286-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33286-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33286-70-wizioQ3nQM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286 Bug 33286 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:02:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:02:58 +0000 Subject: [Koha-bugs] [Bug 33288] Catalog concerns - Fallback email when CatalogerEmails is empty In-Reply-To: <bug-33288-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33288-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33288-70-HTto1TPR8K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33288 Bug 33288 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:02:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:02:59 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-S5zkasssUd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Bug 33313 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:02:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:02:59 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-2JX1WHANoR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 Bug 33314 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:02:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:02:59 +0000 Subject: [Koha-bugs] [Bug 33327] Hide resolved catalog concerns by default In-Reply-To: <bug-33327-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33327-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33327-70-2gRyci4c77@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33327 Bug 33327 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:02:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:02:59 +0000 Subject: [Koha-bugs] [Bug 33498] Catalog concerns - Lots of whitespace before the notice text In-Reply-To: <bug-33498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33498-70-5QMvTyYZy2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33498 Bug 33498 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:02:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:02:59 +0000 Subject: [Koha-bugs] [Bug 33494] Catalog concerns - Toggle 'Hide resolved' and 'Show all' In-Reply-To: <bug-33494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33494-70-PNT9m0CHbr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33494 Bug 33494 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:02:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:02:59 +0000 Subject: [Koha-bugs] [Bug 33266] Patron name missing space before surname In-Reply-To: <bug-33266-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33266-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33266-70-Yzz6KiJHZ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33266 Bug 33266 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:00 +0000 Subject: [Koha-bugs] [Bug 33315] Missing space in TICKET_NOTIFY In-Reply-To: <bug-33315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33315-70-rmQhCosSuh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33315 Bug 33315 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:09 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-RWHR8eVmxo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:10 +0000 Subject: [Koha-bugs] [Bug 32435] Add resolution types to catalog concerns In-Reply-To: <bug-32435-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32435-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32435-70-azx0zKv8ei@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32435 Bug 32435 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:10 +0000 Subject: [Koha-bugs] [Bug 32436] Add 'quick replies' to catalog concerns In-Reply-To: <bug-32436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32436-70-slWQl5DWfK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32436 Bug 32436 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:10 +0000 Subject: [Koha-bugs] [Bug 33286] 'Catalog record' should be 'Bibliographic record' In-Reply-To: <bug-33286-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33286-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33286-70-oBi23w5CFe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286 Bug 33286 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:10 +0000 Subject: [Koha-bugs] [Bug 33288] Catalog concerns - Fallback email when CatalogerEmails is empty In-Reply-To: <bug-33288-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33288-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33288-70-dwR7uDuOzR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33288 Bug 33288 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:11 +0000 Subject: [Koha-bugs] [Bug 33327] Hide resolved catalog concerns by default In-Reply-To: <bug-33327-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33327-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33327-70-Omzg2nLPSm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33327 Bug 33327 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:10 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-riG87Da8G0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Bug 33313 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:10 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-lkTY6fFCDu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 Bug 33314 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:11 +0000 Subject: [Koha-bugs] [Bug 33494] Catalog concerns - Toggle 'Hide resolved' and 'Show all' In-Reply-To: <bug-33494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33494-70-DyRD9ZPWUc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33494 Bug 33494 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:11 +0000 Subject: [Koha-bugs] [Bug 33498] Catalog concerns - Lots of whitespace before the notice text In-Reply-To: <bug-33498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33498-70-Eonl4rzrQN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33498 Bug 33498 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:11 +0000 Subject: [Koha-bugs] [Bug 33266] Patron name missing space before surname In-Reply-To: <bug-33266-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33266-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33266-70-qwAtCqDzWg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33266 Bug 33266 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:12 +0000 Subject: [Koha-bugs] [Bug 33315] Missing space in TICKET_NOTIFY In-Reply-To: <bug-33315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33315-70-tjm1pjvzRl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33315 Bug 33315 depends on bug 31028, which changed state. Bug 31028 Summary: Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:22 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-sqaRULsGhw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:30 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-II1SVDESCR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:03:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:03:39 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-K6EXmoW8H4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:10:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:10:23 +0000 Subject: [Koha-bugs] [Bug 33499] New: Improve styling of vendor detail page Message-ID: <bug-33499-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Bug ID: 33499 Summary: Improve styling of vendor detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There are some inconsistencies on this page we could/should fix. * The labels of the ordering information and subscriptions section are bold, but all other labels are not. * The sections with repeating information (contacts and interfaces) could be improved for better readability. * The information takes up a lot of space. I wonder if we could reorder/regroup the information in a better way maybe? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:10:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:10:29 +0000 Subject: [Koha-bugs] [Bug 33499] Improve styling of vendor detail page In-Reply-To: <bug-33499-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33499-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33499-70-qd7h33XXBz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33104 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 [Bug 33104] Add vendor interfaces -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:10:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:10:29 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-n8mHrZznKg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33499 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33499 [Bug 33499] Improve styling of vendor detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:11:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:11:07 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-0826vVZjN8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #35) > (In reply to Jonathan Druart from comment #30) > > What are you suggesting? I think this is nicer than the others :D > > > > https://snipboard.io/Iwetbx.jpg > > > > Contacts are missing padding, contracts are in a table (what we don't want > > here, it won't be easy to read). > > See last patch. Better for consistency, but IMO it was nicer prior to this > patch (except the background weirdness) > > https://snipboard.io/jv7yIe.jpg I've filed bug 33499 for improving the vendor detail page. Otherwise... PQA now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:13:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:13:16 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-Ts41AE0Gl2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:13:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:13:19 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-DVthrLhU3c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148473|0 |1 is obsolete| | --- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149492&action=edit Bug 33104: DB changes Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:13:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:13:22 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-jNyFRyHLbk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148474|0 |1 is obsolete| | --- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149493&action=edit Bug 33104: DBIC changes Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:13:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:13:24 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-18GDKjeLXl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148475|0 |1 is obsolete| | --- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149494&action=edit Bug 33104: Koha classes Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:13:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:13:27 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-RXDGQHRAdx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148476|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149495&action=edit Bug 33104: Add the ability to create vendor interfaces This patchset is adding the ability to create interfaces for vendors. An interface is a website, software, or portal that you use to manage orders or gather statistics from the vendor/organisation. It will help librarians to keep track of those different information within Koha. * new DB table aqbookseller_interfaces(id, vendor_id, type, name, uri, login, password, account_email, notes) * new AV category VENDOR_INTERFACE_TYPE with 3 example values ADMIN, ORDERS, REPORTS * new pair of Koha classes Koha::Acquisition::Bookseller::Interface[s] * new method to retrieve the interfaces from the vendor Koha::Acquisition::Bookseller->interfaces * Add/Delete interfaces when editing a vendor * Display the interfaces on the vendor show view Test plan: - Add a new vendor => Notice the new "Interfaces" block - Create some interfaces => They are display on the vendor show view => The password is hashed and can displayed on the demand QA Note: The "contacts" code is not very nice and I didn't want to replicate it, so I went another way and tried to make the code reusable, for further reutilisation. Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:13:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:13:30 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-0YGlLXiymP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148477|0 |1 is obsolete| | --- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149496&action=edit Bug 33104: Make the code reusable We could then reuse it for the contacts code in this same template, on another bug report. Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:13:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:13:33 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-7Q9vgYovBE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148478|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149497&action=edit Bug 33104: Encrypt password Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:13:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:13:38 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-sKS0J9XE4C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148479|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149498&action=edit Bug 33104: Display the VENDOR_INTERFACE_TYPE AVs in the dropdown list Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:13:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:13:42 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-U6DRiGJxw6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148480|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149499&action=edit Bug 33104: Add tests Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:13:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:13:46 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-HsQyobqvbQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149420|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149500&action=edit Bug 33104: Fix translatability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:13:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:13:50 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-ngJ1rsShpH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149421|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149501&action=edit Bug 33104: Add email validation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:13:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:13:53 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-ZmX7luQrMR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149422|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149502&action=edit Bug 33104: Prevent 'Type' to be cleared Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:13:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:13:56 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-qPODrL04e1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149431|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149503&action=edit Bug 33104: Remove fieldset For consistency with "Contacts" Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:16:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:16:57 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-I6DdMayKm5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This is temporarily BLOCKED by the dependent patch waiting for sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:18:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:18:12 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-lgRYL9ItlP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:18:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:18:14 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-5leIUUef9f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #1 from Phil Ringnalda <phil at chetcolibrary.org> --- Created attachment 149504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149504&action=edit Revert "Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail)" This reverts commit 26c26164ba78029cb99fa99662f9e0a8ce9557df. Test plan: 1. Without the patch, edit a personal name authority record, replacing the value in 100 subfield a (200 subfield a for UNIMARC) with your own name. 2. Click "Replace record via Z39.50/SRU search" and note that the prefilled search field contains the original value, not your name. 3. Replace the Author (personal) field with your name again, choose a search target, and click Search. 4. Note that the results of the search are for the original value, not for your name. 5. Apply patch, repeat, noting that the search form is prefilled with your change made in the editor, and any changes you make in the search form are reflected in what the search results return. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:21:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:21:23 +0000 Subject: [Koha-bugs] [Bug 29598] Add a preference for default borrower's notice language In-Reply-To: <bug-29598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29598-70-bDpTdygd1P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29598 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Marcel de Rooy from comment #0) > Notice language for a new borrower via staff interface defaults to language > of the staff interface user. > In the OPAC self registration does not list the field and the value will be > set to the database default called ... 'default'. > > Would be nice if we could make that more consistent. I can't reproduce this on master: * TranslateNotices off: Add a new patron. lang = default * TranslateNotices on: Add a new patron. lang = default * TranslateNotices on, staff user set to fr-FR. Add new patron. lang = default Which version did you test with? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:23:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:23:47 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-aVQL6UJ6sI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:26:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:26:44 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-JhOhOqtsex@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:26:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:26:47 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-pskcrMG4uR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149463|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149505&action=edit Bug 33489: Add indices to default patron search fields This patch adds indices to the borrowers table to match the default search fields for patrons. To test: 1 - Apply patch 2 - Update database 3 - Ensure patron searching works as before Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:29:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:29:21 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33493-70-MBPeoo0Cvf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This is temporarily BLOCKED by the dependent patch waiting for SO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:29:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:29:52 +0000 Subject: [Koha-bugs] [Bug 33470] Don't calculate overridden values when placing a hold via the REST API In-Reply-To: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33470-70-uptgdonvjL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33470 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't calculate overridden |Don't calculate overridden |values when placing a hold |values when placing a hold |via the REST api |via the REST API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:38:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:38:53 +0000 Subject: [Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons In-Reply-To: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32986-70-b6CE73Zogj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:38:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:38:56 +0000 Subject: [Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons In-Reply-To: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32986-70-k4Ai3XnxZ7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148376|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149506&action=edit Bug 32986: Add patron_slip module to letters and allow printing on members account This patch adds a new module to letters 'patron_slip' / Patrons toolbar (slip) This also combines some of the slip printing JS to make things more direct To test: 1 - Apply patch 2 - restart_all 3 - yarn build 4 - Confirm you can print slip, summary, quickslip, and checkin slip when viewing a patron's account 5 - Enable DisplayClearScreenButton syspref, and test that it works with both values 6 - Go to Tools->Notices and slips 7 - Define a new notice in the 'Patron toolbar (slip)' module 8 - Enter content like below in the 'Print' transport: Patron has [% borrower.holds.count %] holds List of holds: [% FOREACH hold IN borrower.holds %] =============================== Reserve id: [% hold.reserve_id %] Title [% hold.biblio.title %] [% END %] 9 - Go to patron scree 10 - Note new option under 'Print' 11 - Print the new slip and confirm it works (try with and without placing holds for patron Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:38:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:38:59 +0000 Subject: [Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons In-Reply-To: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32986-70-sSGhbqnoZb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149507&action=edit Bug 32986: (QA follow-up) Fix QA script complaints: tabs and TT filters * Perltidied the section with tabs in printslip.pl * Fixed indentation and tabs in letter.tt * Added missing TT filters to members-toolbar.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:39:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:39:35 +0000 Subject: [Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons In-Reply-To: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32986-70-dEWAicvblR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Still not finished here, but I have fixed the QA script complaints :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:47:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:47:12 +0000 Subject: [Koha-bugs] [Bug 33500] New: Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record Message-ID: <bug-33500-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Bug ID: 33500 Summary: Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: -Set the sys pref 'RecordLocalUseOnReturn' to 'record'. -prove -v /kohadevbox/koha/t/db_dependent/Circulation.t # Subtest: Tests for BlockReturnOfWithdrawnItems 1..1 not ok 1 - Item returned as withdrawn, no other messages # Failed test 'Item returned as withdrawn, no other messages' # at /kohadevbox/koha/t/db_dependent/Circulation.t line 5816. # Structures begin differing at: # $got->[1]{LocalUse} = '1' # $expected->[1]{LocalUse} = Does not exist # Looks like you failed 1 test of 1. not ok 65 - Tests for BlockReturnOfWithdrawnItems # Subtest: Tests for transfer not in transit # Failed test 'Tests for BlockReturnOfWithdrawnItems' # at /kohadevbox/koha/t/db_dependent/Circulation.t line 5819. 1..2 not ok 1 - Item is reported to have been transferred # Failed test 'Item is reported to have been transferred' # at /kohadevbox/koha/t/db_dependent/Circulation.t line 5837. # Structures begin differing at: # $got->[1]{LocalUse} = '1' # $expected->[1]{LocalUse} = Does not exist ok 2 - The datesent field is populated, i.e. transfer is initiated # Looks like you failed 1 test of 2. not ok 66 - Tests for transfer not in transit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:47:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:47:21 +0000 Subject: [Koha-bugs] [Bug 33500] Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record In-Reply-To: <bug-33500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33500-70-cdfTSt8TJP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:56:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:56:54 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-B1odZUgHW6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 AspenCat Team <aspencatteam at clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 11 23:57:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 21:57:41 +0000 Subject: [Koha-bugs] [Bug 31672] Remove 'Your' from tab descriptions in OPAC patron account In-Reply-To: <bug-31672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31672-70-xFbDuEanG1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31672 --- Comment #7 from Christopher Brannon <cbrannon at cdalibrary.org> --- Ah! Thank you for the clarification. Makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 01:06:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 23:06:45 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-h3jqIFWia9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 01:09:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 23:09:41 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-VZeKjzyKBQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 01:16:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Apr 2023 23:16:20 +0000 Subject: [Koha-bugs] [Bug 33501] New: Cashup amount should be configurable Message-ID: <bug-33501-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33501 Bug ID: 33501 Summary: Cashup amount should be configurable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It seems the Cashup summary only accounts for the cash payment type. We have a check payment type that should also be included. Am I missing a configuration somewhere, or do we need some way to define what should be included in the summary and intake balance? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 04:30:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 02:30:36 +0000 Subject: [Koha-bugs] [Bug 14287] Preserve valid ISBN-13 identifiers if they start with something else than 978 In-Reply-To: <bug-14287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14287-70-YlfnK3OhHm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14287 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #15 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Hi all, I think this is becoming a problem now - we have a library getting covers through Syndetics and records with ^979 ISBNs are not fetching covers successfully. Any progress on this work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 06:47:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 04:47:03 +0000 Subject: [Koha-bugs] [Bug 19814] Batch Check-in function In-Reply-To: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19814-70-EGvqGK67tN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 Mubassir Ahsan <mahsandu at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high CC| |mahsandu at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 06:53:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 04:53:13 +0000 Subject: [Koha-bugs] [Bug 19814] Batch Check-in function In-Reply-To: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19814-70-jOi6HsAdam@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 --- Comment #27 from Mubassir Ahsan <mahsandu at gmail.com> --- Hi, We are looking for this for localuse records. Everyday users left used books on the table, we like to add them to localuse check in. We are using blutooth handheld scanner to capture barcodes. but it is difficult to put all the barcode one by one. So batch check in is very much needed. Thanks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 08:23:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 06:23:55 +0000 Subject: [Koha-bugs] [Bug 33492] ERM - We need EBSCO Cypress tests In-Reply-To: <bug-33492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33492-70-v3TFRvxrMR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33492 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I wonder if we could optionally run tests if an environment variable, containing an API key, is set? That way ebsco partners with a valid test key could at least run tests. It's not perfect as it wouldn't be easy to run them consistently in the existing CI framework as I imagine sharing such a key with community would likely be against some terms and conditions somewhere. The only other thing I can think of is to attempt to kick the ebsco APIs, but that negates the integration test where aiming for in the first place. We want to easily detect breakages caused by us or changes at the ebsco end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 08:40:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 06:40:06 +0000 Subject: [Koha-bugs] [Bug 33492] ERM - We need EBSCO Cypress tests In-Reply-To: <bug-33492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33492-70-TLyENJ8mYO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33492 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook <dcook at prosentient.com.au> --- (In reply to Martin Renvoize from comment #1) > I wonder if we could optionally run tests if an environment variable, > containing an API key, is set? This would be the most realistic thorough option I think. > That way ebsco partners with a valid test key could at least run tests. > It's not perfect as it wouldn't be easy to run them consistently in the > existing CI framework as I imagine sharing such a key with community would > likely be against some terms and conditions somewhere. One could ask EBSCO for testing credentials but I think they tend to only do that for short-term scenarios. > The only other thing I can think of is to attempt to kick the ebsco APIs, > but that negates the integration test where aiming for in the first place. > We want to easily detect breakages caused by us or changes at the ebsco end. Another option could be mocking the API. It wouldn't help detect breakages on the EBSCO end, but it would cover breakages caused by us. I have a Ruby project where I provide a HTTP API which makes a lot of backend calls to a variety of other APIs from different vendors. In my unit tests, I override important Net::HTTP methods so that they return what I want. It looks like Cypress has some options for stubbing responses: https://docs.cypress.io/guides/guides/network-requests -- With my Ruby project, I mock the responses for my unit tests, and then when I want to run my integration tests, I use real credentials for real test systems, and run tests on those real test systems. Those test systems are all in a client's own ecosystem though, so it's very easy to organize. It's not like interacting with an external third-party system. I reckon robust integration tests for the EBSCO API aren't going to be doable. Someone with EBSCO API credentials could test but probably not doable from a generic community perspective... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 09:26:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 07:26:54 +0000 Subject: [Koha-bugs] [Bug 33116] Limit reports execution time with sql variables In-Reply-To: <bug-33116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33116-70-OkARxAHM53@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33116 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger <magnus at libriotech.no> --- Is this "work in progress" or should it be "Needs Signoff"? If it is meant for signoff, I think it also needs to update etc/koha-conf.xml, and include a test plan. But this sure sounds like something that will be a good thing to have! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 10:08:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 08:08:38 +0000 Subject: [Koha-bugs] [Bug 33161] Implement +strings for GET /items and /items/:item_id In-Reply-To: <bug-33161-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33161-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33161-70-MOHKqTM5A7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33161 --- Comment #33 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- + _strings: + type: + - object + - "null" description: A return claims object if one exists that's unresolved Missing description in the api spec file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 10:20:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 08:20:09 +0000 Subject: [Koha-bugs] [Bug 33502] New: Run reports against a replicated database Message-ID: <bug-33502-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33502 Bug ID: 33502 Summary: Run reports against a replicated database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org One potential problem when running Koha is that someone can create a report that makes the database really slow and/or crash. This will be mitigated to some extent by bug 33116, but for sites that have a setup where the database is replicated to a second database server, it could be interesting to be able to direct queries generated by reports to the replica, not to the main server. Then a heavy/slow/big report would only affect the replica, not the main database. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 10:20:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 08:20:22 +0000 Subject: [Koha-bugs] [Bug 33502] Run reports against a replicated database In-Reply-To: <bug-33502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33502-70-qaSB7Va81O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33502 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33116 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 10:20:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 08:20:22 +0000 Subject: [Koha-bugs] [Bug 33116] Limit reports execution time with sql variables In-Reply-To: <bug-33116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33116-70-Z4YyFnzX2R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33116 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33502 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 10:23:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 08:23:36 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-LqENuo3w3s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 --- Comment #6 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149508&action=edit Bug 33408: We need only one this.loaded call Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 10:41:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 08:41:05 +0000 Subject: [Koha-bugs] [Bug 28328] Editing a record can cause an ISE if data too long for column In-Reply-To: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28328-70-dnzvlSCiTr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28328 --- Comment #3 from Jan Kissig <bibliothek at th-wildau.de> --- The same problem for columns publishercode or place obtained from MARC 264$b and $a or 260$a and $b to reproduce 1 - edit or add new biblio 2 - in 264$a enter f.e. "1averylongtextaverylongtextaverylongtext42averylongtextaverylongtextaverylongtext84 | 2averylongtextaverylongtextaverylongtext42averylongtextaverylongtextaverylongtext84 | 3averylongtextaverylongtextaverylongtext42averylongtextaverylongtextaverylongtext847" 3 - fill in other mandatory fields 4 - save /var/log/koha/kohadev/plack-intranet-error.log says [2023/04/12 08:27:52] [WARN] DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'place' at row 1 at /kohadevbox/koha/Koha/Object.pm line 176 As 260/264 $a and $c are repeatable fields, which get joined, it is not uncommon that they exceed the maximal length of 256 in some of my records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:20:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:20:44 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-ntDUe7iOQE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:20:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:20:46 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-qvsnHAmRU8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149509&action=edit Bug 33105: DB changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:20:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:20:50 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-MkE3JJ2Lj2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149510&action=edit Bug 33105: DBIC schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:20:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:20:52 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-MLCetf0nPY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149511&action=edit Bug 33105: DBIC specific -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:20:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:20:55 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-GzP87FBAu6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149512&action=edit Bug 33105: Add Koha object classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:20:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:20:58 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-EUub4DyuGQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149513&action=edit Bug 33105: Add vendor issues This patch is the main patch of this patch set, it contains the controller acqui/vendor_issues.pl, its corresponding template, and some links to this script. It adds: * A new DB table aqbookseller_issues linked with the aqbooksellers table * A new subpermission acquisition.issue_manage * A new authorised value category VENDOR_ISSUE_TYPE and two examples MAINTENANCE and OUTAGE * A new controller couple acqui/vendor_issues.[pl,tt] Test plan: 0. Apply the patches, run updatedatabase and restart_all 1. Go to the acquisition module, create a new vendor or use an existing one 2. Create a couple of issues for this vendor 3. Edit/Delete and search for those issues This is the basics for tracking issues with vendors. Suggestions welcome, on follow-up bug reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:21:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:21:01 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-dMvCVIUroN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149514&action=edit Bug 33105: REST API specs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:21:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:21:03 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-VSk9SZ05IZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149515&action=edit Bug 33105: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:21:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:21:12 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-3z5hfrDeGF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33104 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 [Bug 33104] Add vendor interfaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:21:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:21:12 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-Y2pDoQvF7p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33105 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 [Bug 33105] Add vendor Issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:45:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:45:09 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-ZOlfCYbist@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149438|0 |1 is obsolete| | --- Comment #23 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149516&action=edit Bug 33408: Store sysprefs in a new ERM store We need the sysprefs' values to be shared between the components Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:45:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:45:11 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-oj3VgrIYfB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #24 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149517&action=edit Bug 33408: Add storeToRefs to ERMStore It makes it so that any changes to the local property is also reflected in the store and other components are made aware of the new value. No need to explicitly change both local property and store property values. Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:45:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:45:14 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-Lhj9R9hYJm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #25 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149518&action=edit Bug 33408: Move providers into syspref array ERMProviders is a sys pref, place it in sysprefs Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:45:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:45:32 +0000 Subject: [Koha-bugs] [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword In-Reply-To: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33375-70-Dgc3KOyOiA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23996 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 [Bug 23996] MySQL 8 support [Omnibus] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:45:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:45:32 +0000 Subject: [Koha-bugs] [Bug 23996] MySQL 8 support [Omnibus] In-Reply-To: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23996-70-uhLlOXEIxk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33375 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:48:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:48:57 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: <bug-30708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30708-70-UMFqElC7Th@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com Change sponsored?|Seeking sponsor |Sponsored --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Progress on this new feature can be found at https://tree.taiga.io/project/joubu-koha-preservation-module/kanban The current state of the code is at https://gitlab.com/joubu/Koha/-/commits/bug_30708 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:49:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:49:44 +0000 Subject: [Koha-bugs] [Bug 33435] We're missing sample dev data for ERM In-Reply-To: <bug-33435-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33435-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33435-70-dFimyeUgKu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Signed Off |RESOLVED --- Comment #8 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Thank you David and Martin. Understood. However, should we decide on a standard way/place where dev sample data should be? (if not already) At the moment it seems it's split between core and misc4dev, and honestly I wasn't sure where to place it to begin with! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 11:52:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 09:52:26 +0000 Subject: [Koha-bugs] [Bug 33503] New: Plugin OpenAPI2.0 specification schema fragments are not resolved. Merge full schema definitions. Message-ID: <bug-33503-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33503 Bug ID: 33503 Summary: Plugin OpenAPI2.0 specification schema fragments are not resolved. Merge full schema definitions. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at hypernova.fi QA Contact: testopia at bugs.koha-community.org Koha::REST::Plugin::PluginRoutes.pm simply injects a plugin's OpenAPI2.0 route definitions into the /paths -object. Possibly after Bug 30194, dereferencing OpenAPI2.0 schema fragments/components has started to fail. This plugin: https://github.com/Hypernova-Oy/koha-plugin-self-service/releases/tag/v1.0.11 used to get it's REST API paths injected and dereferenced/bundled correctly, for Koha versions 22.05 and before, but in the new Koha version the same schema definitions no longer work. This patch adds a new plugin hook, api_spec which injects a full OpenAPI2.0 compatible schema into the full Koha schema, avoiding to overwrite any existing definitions/parameters/info/paths/etc. This way we maintain backwards compatibility with existing plugins, which are not broken, and maintain updated plugins' ability to use complex schemas. We need to inject full schema definitions, because of the way how the new OpenAPI validator does dereferencing, by creating /parameters and /definitions -objects inside the plugin's OpenAPI schema object. The api_route()-plugin hook then proceeds to strip away only the paths/routes and loses the internal data structure references to the schema fragments/components. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:09:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:09:20 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-hzHPPsWTOl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #2 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149519&action=edit /cgi-bin/koha/erm/agreements?by_expired=true -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:09:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:09:37 +0000 Subject: [Koha-bugs] [Bug 33504] New: ILD-DI does not respect new renewals code Message-ID: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Bug ID: 33504 Summary: ILD-DI does not respect new renewals code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org With the introduction on new code around renewals, we updated the REST API and other renewal avenues, but neglected ILD-DI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:19:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:19:41 +0000 Subject: [Koha-bugs] [Bug 33504] ILD-DI does not respect new renewals code In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-C8zUA49QDE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Oh.. I'm wrong.. it's not that we don't handle it.... it's that we somehow don't have a userenv for ils-di sessions if I'm not mistaken? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:20:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:20:01 +0000 Subject: [Koha-bugs] [Bug 33503] Plugin OpenAPI2.0 specification schema fragments are not resolved. Merge full schema definitions. In-Reply-To: <bug-33503-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33503-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33503-70-ZkwWPRKKiu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33503 Olli-Antti Kivilahti <olli-antti.kivilahti at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |olli-antti.kivilahti at hypern | |ova.fi Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at hypern |ity.org |ova.fi --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at hypernova.fi> --- Created attachment 149520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149520&action=edit Bug 33503 - Plugin OpenAPI2.0 specification schema fragments are not resolved. Merge full schema definitions. Bug 33503 - Plugin OpenAPI2.0 specification schema fragments are not resolved. Merge full schema definitions. Koha::REST::Plugin::PluginRoutes.pm simply injects a plugin's OpenAPI2.0 route definitions into the /paths -object. Possibly after Bug 30194, dereferencing OpenAPI2.0 schema fragments/components has started to fail. This plugin: https://github.com/Hypernova-Oy/koha-plugin-self-service/releases/tag/v1.0.11 used to get it's REST API paths injected and dereferenced/bundled correctly, for Koha versions 22.05 and before, but in the new Koha version the same schema definitions no longer work. This patch adds a new plugin hook, api_spec which injects a full OpenAPI2.0 compatible schema into the full Koha schema, avoiding to overwrite any existing definitions/parameters/info/paths/etc. This way we maintain backwards compatibility with existing plugins, which are not broken, and maintain updated plugins' ability to use complex schemas. We need to inject full schema definitions, because of the way how the new OpenAPI validator does dereferencing, by creating /parameters and /definitions -objects inside the plugin's OpenAPI schema object. The api_route()-plugin hook then proceeds to strip away only the paths/routes and loses the internal data structure references to the schema fragments/components. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:24:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:24:15 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-4Kh9vXA138@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149521&action=edit Bug 33490: Prevent 400 because agreements?by_expired=true is missing date We need to update the filter THEN update the current route -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:30:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:30:08 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-wB2vwkNFym@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149521|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149522&action=edit Bug 33490: Prevent 400 on agreements?by_expired=true We need to update the filter THEN update the current route -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:30:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:30:17 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-RlN01tyQ4r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:32:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:32:00 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-zWvghBItoJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILD-DI does not respect new |ILS-DI does not record |renewals code |renewer_id for renewals -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:36:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:36:31 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-XukLaddAFc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:37:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:37:04 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-biAiT1ZVrr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- The symptom here is that the renewal history modal fails to load as the renewer_id isn't set for ils-di renewals. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:39:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:39:20 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-UIZzGEHtQQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:39:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:39:33 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-ph2dT8c07h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:39:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:39:34 +0000 Subject: [Koha-bugs] [Bug 33435] We're missing sample dev data for ERM In-Reply-To: <bug-33435-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33435-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33435-70-rYezvU7npD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33435 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- You are not wrong, traditionally we had sample libraries, sample users etc. that could be installed via the web installer. And I think they are really helpful if libraries just want to have a first look at Koha for initial testing. The lable examples are also very helpful if you are just starting out using the module. The ERM data is maybe a grey area? We haven't added new sample data (not configuration) to the installer in a while. The web installer makes it more generally available, the misc4dev only to devs. If we want to add to web installer, we should make some of the fields (the notes) translatable in the yaml file :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:39:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:39:36 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-t1mWMxi6K4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149522|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149523&action=edit Bug 33490: Prevent 400 on agreements?by_expired=true We need to update the filter THEN update the current route Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:39:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:39:43 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-xA9z3Wajrq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:41:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:41:27 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-74Yk73PdcN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #6 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Turns out the error I was experiencing was caused by an outdated schema on my end. However, in the process, Joubu discovered this error 400 and provided the fix. The problem can be reproduced by visiting: /cgi-bin/koha/erm/agreements?by_expired=true Apply the patch and visit the URL again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:51:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:51:55 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-h9ifhPE5Qf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149524&action=edit Bug 33504: Update patron_to_html to deal with null In the patron_to_html function we were dealing explicitly with the case where patron may be passed undefined, but forgetting that it may be returned as 'null' from the api too. Changing from `( patron === undefined )` to `( patron == null )` is the recommended approach for detecting 'undefined or null' in javascript. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:52:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:52:18 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-ZyuqIDLzDs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:53:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:53:16 +0000 Subject: [Koha-bugs] [Bug 33492] ERM - We need EBSCO Cypress tests In-Reply-To: <bug-33492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33492-70-PsrAnvabEW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33492 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #3 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Ignoring the credentials for a bit, I think mocking the API would at least be better than not having any tests. Some of the recent bugs we discovered were caused by changes in the way we render tables, or the way we handle loading in the UI. These would've been caught by tests even if they were simply mocking the API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:54:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:54:05 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-eONCfUZd0G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This fixes the symptom, not the cause. To test. 1) Use ILS-DI to renew an checkout 2) View the circulation history for the item 3) Click the 'View' button next to the count of renewals 4) Note that the modal just stalls at 'Retrieving renewals' 5) Apply the patch 6) Now the 'retrieving renewals' message should list the renewals instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:55:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:55:54 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-wZe5PH5IXW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 12:57:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 10:57:37 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-Li7S189dSI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:03:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:03:37 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-AFRmf8iBml@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 --- Comment #6 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149525&action=edit Bug 33289: DO NOT PUSH - test plan only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:06:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:06:22 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-Xs0yBCBhJd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m --- Comment #7 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- @Katrin: Before applying patches: * Verify that 'cardnumberlength' is empty in the system preferences Apply both patches: * Visit /cgi-bin/koha/erm/agreements (it will run the test code to change a syspref value from the api-client.js + http-client.js) * Go back to the system preferences and verify that 'cardnumberlength' now has a value of 42 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:12:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:12:34 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-rIgAqc69AJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:18:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:18:51 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-TlQeYn2wBE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148596|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149526&action=edit Bug 33289: Add API client class to interact with svc/config/systempreferences On bug 30708 we will need to modify sysprefs from the UI (Vue app), it could be useful for other developments as well and so it is moved on its own bug report. Test plan: It can be tested independently of bug 30708 using the following code: const client = APIClient.sysprefs client.sysprefs .update( "CardnumberLength", "42" ) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:19:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:19:40 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-7eqppYFkNv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Clear and simple code all working as expected. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:27:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:27:56 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-Kd6dsoReTI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Jonathan Field <jonathan.field at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #8 from Jonathan Field <jonathan.field at ptfs-europe.com> --- Deletion is currently failing due to a typo in vendor_issues.pl cgi-bin/koha/acqui/vendor_iddues.pl?op=delete_confirm&issue_id=1 iddues instead of issues. Looking good otherwise! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:28:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:28:31 +0000 Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service In-Reply-To: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33371-70-hULbfdNRGu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:29:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:29:16 +0000 Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service In-Reply-To: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33371-70-rXZAWb8Aiw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:41:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:41:20 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-hWtVVxAt9X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149471|0 |1 is obsolete| | Attachment #149472|0 |1 is obsolete| | Attachment #149473|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149527&action=edit Bug 33483: Make KohaTable accept customizable actions button We have hardcoded some buttons: edit, delete But we could need specific buttons. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:41:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:41:23 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-X3amTe3JGR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149528&action=edit Bug 33483: Restore 'select' We are not supposed to see edit and delete buttons, but select instead, to pick an agreement. Regression introduced by commit 809f90d394fdef8142fdf8f4a6e825dc14a132d4 Bug 33066: Remove build_datatable Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:41:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:41:26 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-mTxZeBacpG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149529&action=edit Bug 33483: (follow-up) Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:56:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:56:46 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-iber33tlib@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:56:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:56:48 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-a1S1vdNuno@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149513|0 |1 is obsolete| | Attachment #149514|0 |1 is obsolete| | Attachment #149515|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149530&action=edit Bug 33105: Add vendor issues This patch is the main patch of this patch set, it contains the controller acqui/vendor_issues.pl, its corresponding template, and some links to this script. It adds: * A new DB table aqbookseller_issues linked with the aqbooksellers table * A new subpermission acquisition.issue_manage * A new authorised value category VENDOR_ISSUE_TYPE and two examples MAINTENANCE and OUTAGE * A new controller couple acqui/vendor_issues.[pl,tt] Test plan: 0. Apply the patches, run updatedatabase and restart_all 1. Go to the acquisition module, create a new vendor or use an existing one 2. Create a couple of issues for this vendor 3. Edit/Delete and search for those issues This is the basics for tracking issues with vendors. Suggestions welcome, on follow-up bug reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:56:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:56:51 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-OiS0DhJZXR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149531&action=edit Bug 33105: REST API specs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:56:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:56:54 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-85WbGcewN7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149532&action=edit Bug 33105: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 13:58:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 11:58:30 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-LchM28vhmK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Field from comment #8) > Deletion is currently failing due to a typo in vendor_issues.pl oops, should be fixed now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:01:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:01:29 +0000 Subject: [Koha-bugs] [Bug 33503] Plugin OpenAPI2.0 specification schema fragments are not resolved. Merge full schema definitions. In-Reply-To: <bug-33503-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33503-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33503-70-c5BLk2aM6Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33503 Olli-Antti Kivilahti <olli-antti.kivilahti at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149520|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at hypernova.fi> --- Created attachment 149533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149533&action=edit Bug 33503 - Plugin OpenAPI2.0 specification schema fragments are not resolved. Merge full schema definitions. Koha::REST::Plugin::PluginRoutes.pm simply injects a plugin's OpenAPI2.0 route definitions into the /paths -object. Possibly after Bug 30194, dereferencing OpenAPI2.0 schema fragments/components has started to fail. This plugin: https://github.com/Hypernova-Oy/koha-plugin-self-service/releases/tag/v1.0.11 used to get it's REST API paths injected and dereferenced/bundled correctly, for Koha versions 22.05 and before, but in the new Koha version the same schema definitions no longer work. This patch adds a new plugin hook, api_spec which injects a full OpenAPI2.0 compatible schema into the full Koha schema, avoiding to overwrite any existing definitions/parameters/info/paths/etc. This way we maintain backwards compatibility with existing plugins, which are not broken, and maintain updated plugins' ability to use complex schemas. We need to inject full schema definitions, because of the way how the new OpenAPI validator does dereferencing, by creating /parameters and /definitions -objects inside the plugin's OpenAPI schema object. The api_route()-plugin hook then proceeds to strip away only the paths/routes and loses the internal data structure references to the schema fragments/components. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:30 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27775-70-YEftJgAxIz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:32 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27775-70-j9dVHh8Mhk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:34 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32013-70-lF2GKWwJB3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:36 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32013-70-G1WEzXo5Rb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 --- Comment #20 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:38 +0000 Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32301-70-ArQqJFxdGG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:40 +0000 Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32301-70-I6IoYae3Lj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #14 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:43 +0000 Subject: [Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records In-Reply-To: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32800-70-v3OkyK4Ep0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:44 +0000 Subject: [Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records In-Reply-To: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32800-70-9ifRnVjLIx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 --- Comment #7 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:46 +0000 Subject: [Koha-bugs] [Bug 33281] Improve authority links and add them to MARC preview In-Reply-To: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33281-70-L628avudfL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:48 +0000 Subject: [Koha-bugs] [Bug 33505] New: Doubled up id 'scan-index' on 'scan index' page Message-ID: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Bug ID: 33505 Summary: Doubled up id 'scan-index' on 'scan index' page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com An id should be unique, but we have scan-index appear twice on the scan index page. To test: * Go to advanced search * Select Author and add author name * Check checkbox for scan index * Search * Verify in the source code that the id is doubled up -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:48 +0000 Subject: [Koha-bugs] [Bug 33281] Improve authority links and add them to MARC preview In-Reply-To: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33281-70-jjB7Cg63R4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:50 +0000 Subject: [Koha-bugs] [Bug 33367] tmp/modified_authorities/README.txt seems useless In-Reply-To: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33367-70-e9lVRjG8RB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:52 +0000 Subject: [Koha-bugs] [Bug 33367] tmp/modified_authorities/README.txt seems useless In-Reply-To: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33367-70-n7D8IXVb6O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:54 +0000 Subject: [Koha-bugs] [Bug 33383] Use template wrapper for breadcrumbs: Course reserves In-Reply-To: <bug-33383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33383-70-uAEQfbHWOT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33383 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:56 +0000 Subject: [Koha-bugs] [Bug 33383] Use template wrapper for breadcrumbs: Course reserves In-Reply-To: <bug-33383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33383-70-oEmn8X3yaT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33383 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:27:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:27:58 +0000 Subject: [Koha-bugs] [Bug 33384] Use template wrapper for breadcrumbs: Labels In-Reply-To: <bug-33384-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33384-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33384-70-hz7pSYKXv7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33384 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:00 +0000 Subject: [Koha-bugs] [Bug 33384] Use template wrapper for breadcrumbs: Labels In-Reply-To: <bug-33384-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33384-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33384-70-anGmq0BrLN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33384 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:02 +0000 Subject: [Koha-bugs] [Bug 33385] Use template wrapper for breadcrumbs: Patrons part 1 In-Reply-To: <bug-33385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33385-70-BDd8QIFnSr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33385 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:04 +0000 Subject: [Koha-bugs] [Bug 33385] Use template wrapper for breadcrumbs: Patrons part 1 In-Reply-To: <bug-33385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33385-70-vjRWPAJplo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33385 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:06 +0000 Subject: [Koha-bugs] [Bug 33386] Use template wrapper for breadcrumbs: Patrons part 2 In-Reply-To: <bug-33386-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33386-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33386-70-OvOQkYaEyy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33386 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:08 +0000 Subject: [Koha-bugs] [Bug 33386] Use template wrapper for breadcrumbs: Patrons part 2 In-Reply-To: <bug-33386-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33386-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33386-70-Q2U4HktM3o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33386 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:10 +0000 Subject: [Koha-bugs] [Bug 33387] Use template wrapper for breadcrumbs: Patrons part 3 In-Reply-To: <bug-33387-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33387-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33387-70-qLreej7f2n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33387 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:12 +0000 Subject: [Koha-bugs] [Bug 33387] Use template wrapper for breadcrumbs: Patrons part 3 In-Reply-To: <bug-33387-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33387-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33387-70-IAl8VDPRIK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33387 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:14 +0000 Subject: [Koha-bugs] [Bug 33389] Use template wrapper for breadcrumbs: Patrons part 5 In-Reply-To: <bug-33389-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33389-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33389-70-vHvtahzBET@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33389 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:16 +0000 Subject: [Koha-bugs] [Bug 33389] Use template wrapper for breadcrumbs: Patrons part 5 In-Reply-To: <bug-33389-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33389-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33389-70-Ldzoz7znxw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33389 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:17 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-RxXU0HlOmh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:19 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-TKrkI8cYo1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:21 +0000 Subject: [Koha-bugs] [Bug 33409] Use template wrapper for breadcrumbs: Patrons lists In-Reply-To: <bug-33409-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33409-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33409-70-tbPJGBr5LM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33409 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:23 +0000 Subject: [Koha-bugs] [Bug 33409] Use template wrapper for breadcrumbs: Patrons lists In-Reply-To: <bug-33409-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33409-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33409-70-jPuU7ojmwJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33409 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:25 +0000 Subject: [Koha-bugs] [Bug 33410] Use template wrapper for breadcrumbs: Patron card creator In-Reply-To: <bug-33410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33410-70-m9QTfrpWWh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:27 +0000 Subject: [Koha-bugs] [Bug 33410] Use template wrapper for breadcrumbs: Patron card creator In-Reply-To: <bug-33410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33410-70-qDr5iMXyby@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:29 +0000 Subject: [Koha-bugs] [Bug 33429] Use template wrapper for breadcrumbs: Plugins In-Reply-To: <bug-33429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33429-70-7WfoAALTEu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:30 +0000 Subject: [Koha-bugs] [Bug 33429] Use template wrapper for breadcrumbs: Plugins In-Reply-To: <bug-33429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33429-70-gxAgJvGkRs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:32 +0000 Subject: [Koha-bugs] [Bug 33434] Use template wrapper for breadcrumbs: Point of sale In-Reply-To: <bug-33434-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33434-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33434-70-11nEAcNyUm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33434 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:34 +0000 Subject: [Koha-bugs] [Bug 33434] Use template wrapper for breadcrumbs: Point of sale In-Reply-To: <bug-33434-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33434-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33434-70-ufnl0u6B1g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33434 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:36 +0000 Subject: [Koha-bugs] [Bug 33436] Use template wrapper for breadcrumbs: Reports part 1 In-Reply-To: <bug-33436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33436-70-Xbkw99ry6r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:28:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:28:38 +0000 Subject: [Koha-bugs] [Bug 33436] Use template wrapper for breadcrumbs: Reports part 1 In-Reply-To: <bug-33436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33436-70-JMNuxDsYGf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:29:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:29:49 +0000 Subject: [Koha-bugs] [Bug 33506] New: Series has wrong index name on scan index page Message-ID: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Bug ID: 33506 Summary: Series has wrong index name on scan index page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org On the 'scan index' page in the staff interface, there is a typo in the template: <option value="su">Series</option> su is the index for subjects. This should be series-title or se. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:29:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:29:55 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-qq0k1evy9l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:35:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:35:22 +0000 Subject: [Koha-bugs] [Bug 33419] Make home branch mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-Ow31k6j4ZT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Test plan to be used with KTD (Koha Testing Docker): 1. Reset KTD so that the web installer is used to setup Koha 2. Setup the web installer -> When setting up the default settings, don't add any of the optional data. 3. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a is not mandatory. 4. Apply the patch. 5. Repeat steps 1-2. 6. Once setup and logged in, check the two frameworks (default and ACQ) and note that $952$a is now mandatory. How to setup the web installer ~~~~~~~~~~~~~~~~~~~~~~~ 1. Access the database server[1]: mysql -uroot -ppassword -hkoha_db_1 2. Drop the koha_kohadev database: drop database koha_kohadev; 3. Create the database: create database koha_kohadev; 4. Add privileges (for a real installation this would be limited): grant all on koha_kohadev.* to koha_kohadev; 5. Restart everything (may not be required, but just to be safe): flush_memcached + restart_all 6. Access the web installer: go to 127.0.0.1:8081 7. Use the database user name and password: get from /etc/koha/sites/kohadev/koha-conf.xml (default: koha_kohadev, password) 8. Continue through the installation process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:38:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:38:59 +0000 Subject: [Koha-bugs] [Bug 33432] Move a list of items from a record to an other In-Reply-To: <bug-33432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33432-70-zLSaqoqxkC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33432 --- Comment #2 from mathieu saby <mathsabypro at gmail.com> --- The use case is rare but for example in my library we have an "small object" record with hundreds of items (calculators, staplers...), and we have just decided to create a record by object type, and to move for ex. all the calculators on the "calculator" record. Other use case for serials : we inherited records from our previous ILS with some items linked to a wrong record, because the a new record has been created for the serial at some point, with a new ISSN (the title of the publication was changed for example). We have to move the items one by one I suppose we could have a page inspired by tools/batchMod.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:42:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:42:49 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-xu0yXWsTHt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149336|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149534&action=edit Bug 33402: Move ERM Cypress tests to their own directory We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts ) to their own subdirectory, eg t/cypress/integration/ERM Test plan: Confirm that the cypress tests are still passing after this change: perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:44:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:44:14 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-clz48fQobj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149204|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149535&action=edit Bug 33408: Fetch sysprefs from svc/config/systempreferences It will be easier to mock/set them from cypress tests. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:44:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:44:17 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-kr3Cpn8G8T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149205|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149536&action=edit Bug 33408: Mock ERM sysprefs from cypress tests Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:44:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:44:20 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-fOQPbDDk11@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149206|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149537&action=edit Bug 33408: Extend defaultCommandTimeout for cypress Sometimes the initial page load takes more than 4 seconds. Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:44:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:44:22 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-4lbbnkqFbP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149207|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149538&action=edit Bug 33408: Prevent access to erm module by URL if sys pref is disabled Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:44:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:44:25 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-eCqqWD6kYF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149208|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149539&action=edit Bug 33408: Remove obsolete tests and template sys pref code Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:44:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:44:28 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-Tp3R74B5Aq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149209|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149540&action=edit Bug 33408: We need only one this.loaded call Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:44:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:44:31 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-sCClGPMGP8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149516|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149541&action=edit Bug 33408: Store sysprefs in a new ERM store We need the sysprefs' values to be shared between the components Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:44:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:44:34 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-S4jLaeHdiz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149517|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149542&action=edit Bug 33408: Add storeToRefs to ERMStore It makes it so that any changes to the local property is also reflected in the store and other components are made aware of the new value. No need to explicitly change both local property and store property values. Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:44:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:44:36 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-Sx5etgyKqj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149518|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149543&action=edit Bug 33408: Move providers into syspref array ERMProviders is a sys pref, place it in sysprefs Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:45:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:45:00 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-gJaqMD7q5t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:45:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:45:54 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-qnOjiCidh1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is a nice clear improvement.. QA script squeeks about template literals in ktd, but I thought we'd decided those were OK now? Happy to PQA is someone is happy to verify that template literals are OK now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:50:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:50:33 +0000 Subject: [Koha-bugs] [Bug 25079] Show club enrollment question answers in staff client In-Reply-To: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25079-70-ao7fRdUqq0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 --- Comment #2 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 149544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149544&action=edit Bug 25079: Add a 'edit' functionality to the Clubs tool in the staff interface A club enrollment can be cancel but it can't be edited This patch add a 'edit' functionality to the Clubs tool in the staff interface Test plan 1. Create a club template 1.1. Go to Tools > Patron clubs 1.2. Click on 'New Club Template' 1.3. Fill the form 1.4. on the 'Club fields' section, Click on Add new field 1.5. Fill in the form 1.6. on the 'Enrollment fields' section, Click on Add new field 1.7. Fill in the form 1.8. Click on Save button 2. Creation of the club 2.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 2.2. Click on the 'New Club' button and select the club template create on step 1 2.3. Fill in the form 2.4. Click on Save button 3. Club enrollement On the intranet 3.1. Search for a pratron and open the patron folder 3.2. Click on the 'Clubs' tab 3.3. Find the name of the club and click on 'Enroll' 3.4. Fill the questionnaire 3.5. Confirm registration ---> Note that the enrollement can be canceled but it cannot be modified 4. Apply the patch 5. Click one more time on the 'Clubs' tab ---> Note that the enrollement can now be modified -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:50:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:50:37 +0000 Subject: [Koha-bugs] [Bug 25079] Show club enrollment question answers in staff client In-Reply-To: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25079-70-jtH5KcK3fs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 --- Comment #3 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 149545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149545&action=edit Bug 25079: Show club enrollment question answers in staff client When a patron is enrolled in a patron club, koha collects answers to library-defined enrollment questions. Those answers go into the database but are not viewable outside of reports. This patch make those answers viewable on club-enrollments.pl. Test plan 1. Apply the patch 2. Create a club template 2.1. Go to Tools > Patron clubs 2.2. Click on 'New Club Template' 2.3. Fill the form 2.4. on the 'Club fields' section, Click on Add new field 2.5. Fill in the form 2.6. on the 'Enrollment fields' section, Click on Add new field 2.7. Fill in the form 2.8. Click on Save button 3. Creation of the club 3.1. Go to Tools > Patron clubs > 'Clubs' section (bottom) 3.2. Click on the 'New Club' button and select the club template create on step 1 3.3. Fill in the form 3.4. Click on Save button 4. Club enrollement On the intranet (or the OPAC if permitted) 4.1. Search for a pratron and open the patron folder 4.2. Click on the 'Clubs' tab 4.3. Find the name of the club and click on 'Enroll' 4.4. Fill the questionnaire 4.5. Confirm registration 5. Check registrations on the intranet 5.1. Go to Tools > Patron clubs 5.2. In the bottom 'Clubs' section, find the name of the club 5.3. check the 'Enrolled patrons' column ---> should not be equal to zero. 5.4 Click on 'Action' and choose the option “Enrollments” ---> The Enrollment fields created on step 2.6. are viewable in the table with their values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:52:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:52:24 +0000 Subject: [Koha-bugs] [Bug 25079] Show club enrollment question answers in staff client In-Reply-To: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25079-70-sF8JFpF4Hj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com, | |hammat.wele at inlibro.com, | |philippe.blouin at inlibro.com Assignee|koha-bugs at lists.koha-commun |hammat.wele at inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:56:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:56:15 +0000 Subject: [Koha-bugs] [Bug 32554] Test prediction pattern does not consider subscription length (uses only subscription end date) In-Reply-To: <bug-32554-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32554-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32554-70-fVJzmB1lK9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32554 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:56:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:56:41 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-riWX2HU7R2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This works great.. but I think we need a cyrpess test to prevent a future regression here.. I'm going to look at using this one to learn how to write such a test :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:56:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:56:51 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-eaED0rjG1m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:58:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:58:12 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-dXC4f41TYL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Doh.. my bad.. I missed that Victor had already QA'd.. All good.. it's been pushed too now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 14:59:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 12:59:47 +0000 Subject: [Koha-bugs] [Bug 25079] Show club enrollment question answers in staff client In-Reply-To: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25079-70-sBvEwbrQcN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:17:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:17:32 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-93u0W75Ye3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:18:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:18:06 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-9K9b2fOVdo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:19:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:19:33 +0000 Subject: [Koha-bugs] [Bug 33480] Improve display of the vendor aliases in the ERM module In-Reply-To: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33480-70-VASDIkrImg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33480 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:23:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:23:16 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-l24C8i4488@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- It's missing a test file that has been created in the meanwhile. git mv t/cypress/integration/Searchbar_spec.ts t/cypress/integration/ERM/Searchbar_spec.ts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:41:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:41:10 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31699-70-Hpx2HRngv6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #51 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Could this be used to solve bug 33175? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:42:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:42:10 +0000 Subject: [Koha-bugs] [Bug 33175] When reporting a problem while not logged in, the problematic page is set to opac-reportproblem.pl In-Reply-To: <bug-33175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33175-70-joght08NPI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33175 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31699 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:42:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:42:10 +0000 Subject: [Koha-bugs] [Bug 31699] Add a generic way to redirect back to the page you were on at login for modal logins In-Reply-To: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31699-70-r29XhqaLl0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31699 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33175 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:44:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:44:58 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-piXjs2keFt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:45:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:45:00 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-84msUZoai1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149256|0 |1 is obsolete| | Attachment #149257|0 |1 is obsolete| | Attachment #149258|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149546&action=edit Bug 33360: Add Koha::Notice::Util for mail domain limits Ground work in new module. Includes unit test. Test plan: Run t/db_dependent/Koha/Notice_Util.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:45:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:45:02 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-K04tsXKlTR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149547&action=edit Bug 33360: Extend Koha::Notice::Util with domain groups The functionality is extended a bit here by: [1] Allowing to combine domains in a shared count. [2] Only counting sent messages for the specified domains when it is really needed. Test plan: Run t/db_dependent/Koha/Notice_Util.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:45:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:45:05 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-sSSIyEPCP1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149548&action=edit Bug 33360: Incorporate Koha::Notice::Util in Letters:SendQueuedMessages Minimal adjustment to get the feature working. Will still be improved in follow-up. Test plan: [1] Add a domain limit to your koha-conf: <message_domain_limits> <domain><name>gmail.com</name><limit>1</limit> <unit>1h</unit></domain> </message_domain_limits> Replace gmail.com by the domain you want to send to. Restart all. [2] Disable cron job for message queue. [3] Generate two pending notices in the queue. [4] Run process_message_queue.pl [5] Check that one is sent, one is still pending. [6] Run again. [7] Check: nothing is sent, last one still pending. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:45:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:45:07 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-k7ffjfx4wb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149549&action=edit Bug 33360: Improving limit behavior in SendQueuedMessages Includes: [1] Do no longer use the limit in the sql selection, but apply the limit as a maximum for the number of sent messages. This is more practical in terms of not flooding your mail server (and the receiving ones). [2] Replace call of _get_unsent_messages by Koha objects search. [3] Do no longer report the number of messages seen, but report the number actually 'sent'. [4] If we lookup the to_address but we need to delay a message, save the email address for the next run. Also optimizing patron lookup in _send_message_by_email. [5} Add support for $where parameter in SendQueuedMessages. Used by process_message_queue.pl. [6] Handle scalar/array for letter_code and type parameter too. Test plan: [1] Adjust your domain limit settings in koha-conf. Use notices to three domains. Group A and B. <message_domain_limits> <domain><name>A</name><limit>1</limit><unit>1h</unit></domain> <domain><name>B/name><belongs_to>A</belongs_to></domain> <domain><name>C</name><limit>1</limit><unit>1h</unit></domain> </message_domain_limits> Replace A, B and C with your choice. Do not forget the belongs_to. Restart all. [2] Disable cron job for message queue. [3] Generate two notices for each domain A, B and C (in that order). Make sure that borrowers involved have correct address. [4] Run process_message_queue.pl -limit 1 [5] Check that one is sent for A, 5 pending. [6] Run process_message_queue.pl -limit 2 [7] Check that one is sent for C, 4 pending. [8] Run process_message_queue.pl (without limit). [9] Check that nothing is sent, 4 pending. [10] Check that message_queue.to_address is filled for those 4. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:45:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:45:09 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-M2oDJmKlyf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149550&action=edit Bug 33360: Adjust Letters.t for limit parameter and domain limits Includes: [1] Add a counter in the send_or_die mock. [2] Correct from processed count to sent count. [3] More extensive testing for limit parameter and domain limits. Test plan: Run t/db_dependent/Letters.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:45:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:45:11 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-wYGqt8cgJA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149551&action=edit Bug 33360: Update koha-conf.xml Test plan: We already tested it. Just look at changes in this patch. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:45:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:45:13 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-gUeRz1x9t1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149552&action=edit Bug 33360: (follow-up) Adjust wording in verbose mode Koha reports 'sending mail' while we actually are still processing mail. It could still be delayed, fail, etc. Test plan: Run process_message_queue in verbose mode. If a message get processed, you should see: Processing email message to patron: 51 at /usr/share/koha/C4/Letters.pm line 1008. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:54:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:54:39 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-rVsdmHGEAD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 --- Comment #10 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 149553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149553&action=edit Bug 33402: (follow-up) Move Searchbar_spec.ts Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 15:56:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 13:56:38 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-ZUJvKSPw0M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Note for testers/QA: An adjusted version already runs in production on 21.11 for me. And was 'put to the test' with a large mailing already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:32 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32334-70-gg1RYcWPiL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:34 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32334-70-5Y6EjmKNc1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 --- Comment #55 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:35 +0000 Subject: [Koha-bugs] [Bug 33006] Use template wrapper for breadcrumbs: Administration part 1 In-Reply-To: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33006-70-ZrqjOgSGoP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33006 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:37 +0000 Subject: [Koha-bugs] [Bug 33006] Use template wrapper for breadcrumbs: Administration part 1 In-Reply-To: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33006-70-4Ft2LNLoFG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33006 --- Comment #9 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:39 +0000 Subject: [Koha-bugs] [Bug 33007] Use template wrapper for breadcrumbs: Administration part 2 In-Reply-To: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33007-70-DMrKSc2g8x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33007 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:41 +0000 Subject: [Koha-bugs] [Bug 33007] Use template wrapper for breadcrumbs: Administration part 2 In-Reply-To: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33007-70-4Fx9TUAhOZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33007 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:42 +0000 Subject: [Koha-bugs] [Bug 33130] Use template wrapper for breadcrumbs: Authorities In-Reply-To: <bug-33130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33130-70-Onij4CufAI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33130 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:44 +0000 Subject: [Koha-bugs] [Bug 33130] Use template wrapper for breadcrumbs: Authorities In-Reply-To: <bug-33130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33130-70-AxRNFUV2yq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33130 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:46 +0000 Subject: [Koha-bugs] [Bug 33131] Use template wrapper for breadcrumbs: Catalog part 1 In-Reply-To: <bug-33131-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33131-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33131-70-QO8QiVWGeJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33131 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:47 +0000 Subject: [Koha-bugs] [Bug 33131] Use template wrapper for breadcrumbs: Catalog part 1 In-Reply-To: <bug-33131-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33131-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33131-70-AzLoLnZtaQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33131 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:49 +0000 Subject: [Koha-bugs] [Bug 33147] Use template wrapper for breadcrumbs: Catalog part 2 In-Reply-To: <bug-33147-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33147-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33147-70-PFY5Ra0bTG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33147 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:51 +0000 Subject: [Koha-bugs] [Bug 33147] Use template wrapper for breadcrumbs: Catalog part 2 In-Reply-To: <bug-33147-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33147-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33147-70-wbwHuRpG14@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33147 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:53 +0000 Subject: [Koha-bugs] [Bug 33324] Use template wrapper for tabs: Tools In-Reply-To: <bug-33324-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33324-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33324-70-YEzNFm1S8w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:54 +0000 Subject: [Koha-bugs] [Bug 33324] Use template wrapper for tabs: Tools In-Reply-To: <bug-33324-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33324-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33324-70-trdJmmKUe7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:56 +0000 Subject: [Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations In-Reply-To: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33332-70-UXREudOWZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:22:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:22:58 +0000 Subject: [Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations In-Reply-To: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33332-70-Hf8BFkBJz4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:23:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:23:00 +0000 Subject: [Koha-bugs] [Bug 33333] Use template wrapper for tabs: SQL reports In-Reply-To: <bug-33333-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33333-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33333-70-dddlLv21ht@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33333 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:23:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:23:02 +0000 Subject: [Koha-bugs] [Bug 33333] Use template wrapper for tabs: SQL reports In-Reply-To: <bug-33333-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33333-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33333-70-bblWihCsMm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33333 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:25:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:25:08 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32334-70-g9QBjJfsq4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 --- Comment #56 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to TomĂĄs Cohen Arazi from comment #55) > Pushed to master for 23.05. > > Nice work everyone, thanks! Thanks Jonathan and Tomas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:27:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:27:58 +0000 Subject: [Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable In-Reply-To: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33154-70-GLdHPCXBBP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:29:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:29:44 +0000 Subject: [Koha-bugs] [Bug 33106] Add vendor link to ERM Licences In-Reply-To: <bug-33106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33106-70-pqOguiIEze@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33106 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:35:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:35:24 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-GnBZ0Eimlo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #36 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Comment on attachment 149535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149535 Bug 33408: Fetch sysprefs from svc/config/systempreferences Review of attachment 149535: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33408&attachment=149535) ----------------------------------------------------------------- Can you review this? Thanks ::: koha-tmpl/intranet-tmpl/prog/js/vue/fetch/system-preferences-api-client.js @@ +10,5 @@ > get sysprefs() { > return { > + get: (variable) => > + this.get({ > + endpoint: `/?pref=${variable}`, FAIL koha-tmpl/intranet-tmpl/prog/js/vue/fetch/system-preferences-api-client.js FAIL ES template literals ES template literals found ( endpoint: `/?pref=${variable}`,) - See bug 24725 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:35:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:35:36 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-qdCMdWmiOX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:43:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:43:41 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-InzpWERJPL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #12 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- I think there's a bug when adding more than one agreement to an EBSCO package (getting error 400 but need to double-check this), I also think we should only list agreements that are not already related to said package, i.e. when adding subsequent agreements to the same packages, the ones already related do not show up in the "to-relate" list. Working on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:07 +0000 Subject: [Koha-bugs] [Bug 33001] Use template wrapper for breadcrumbs: Acquisitions part 2 In-Reply-To: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33001-70-vuL09djTrO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33001 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:09 +0000 Subject: [Koha-bugs] [Bug 33001] Use template wrapper for breadcrumbs: Acquisitions part 2 In-Reply-To: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33001-70-7rJljbZDdB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33001 --- Comment #9 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:11 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-b2E8UNrJkM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:13 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-xinQnwa2f3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 --- Comment #13 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:14 +0000 Subject: [Koha-bugs] [Bug 33077] Improve ease of translating template title tags In-Reply-To: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33077-70-NnhVSYYvrn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:16 +0000 Subject: [Koha-bugs] [Bug 33077] Improve ease of translating template title tags In-Reply-To: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33077-70-LpDtvd5B5t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:18 +0000 Subject: [Koha-bugs] [Bug 33111] Use template wrapper for breadcrumbs: Administration part 4 In-Reply-To: <bug-33111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33111-70-ohmn9KZd6q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33111 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:20 +0000 Subject: [Koha-bugs] [Bug 33111] Use template wrapper for breadcrumbs: Administration part 4 In-Reply-To: <bug-33111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33111-70-uvTCdLKm40@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33111 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:22 +0000 Subject: [Koha-bugs] [Bug 33180] Use template wrapper for tabs: Budgets and Search engine configuration In-Reply-To: <bug-33180-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33180-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33180-70-27d9mrVEzK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33180 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:24 +0000 Subject: [Koha-bugs] [Bug 33180] Use template wrapper for tabs: Budgets and Search engine configuration In-Reply-To: <bug-33180-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33180-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33180-70-nPSGr1QGKV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33180 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:26 +0000 Subject: [Koha-bugs] [Bug 33261] Dates for issues on subscription detail page display unformatted In-Reply-To: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33261-70-ZtUJ7AVwmG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33261 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:27 +0000 Subject: [Koha-bugs] [Bug 33261] Dates for issues on subscription detail page display unformatted In-Reply-To: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33261-70-Jz1VRliVDG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33261 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:29 +0000 Subject: [Koha-bugs] [Bug 33265] Additional unformatted navigation items when on serial receive page In-Reply-To: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33265-70-uMIIhtArsd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33265 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:31 +0000 Subject: [Koha-bugs] [Bug 33265] Additional unformatted navigation items when on serial receive page In-Reply-To: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33265-70-fgPzJzJzTl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33265 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:33 +0000 Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable In-Reply-To: <bug-33323-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33323-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33323-70-uBqppVm3QH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:35 +0000 Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable In-Reply-To: <bug-33323-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33323-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33323-70-FOYNm1BNwD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:37 +0000 Subject: [Koha-bugs] [Bug 33372] Use template wrapper for breadcrumbs: Circulation part 2 In-Reply-To: <bug-33372-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33372-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33372-70-WEOgrxoqtm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33372 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:38 +0000 Subject: [Koha-bugs] [Bug 33372] Use template wrapper for breadcrumbs: Circulation part 2 In-Reply-To: <bug-33372-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33372-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33372-70-F4GChEFLfp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33372 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:40 +0000 Subject: [Koha-bugs] [Bug 33373] Use template wrapper for breadcrumbs: Circulation part 3 In-Reply-To: <bug-33373-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33373-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33373-70-10lwD4Okt9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:42 +0000 Subject: [Koha-bugs] [Bug 33373] Use template wrapper for breadcrumbs: Circulation part 3 In-Reply-To: <bug-33373-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33373-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33373-70-7M6EmB6FZo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 --- Comment #8 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:44 +0000 Subject: [Koha-bugs] [Bug 33382] Use template wrapper for breadcrumbs: Patron clubs In-Reply-To: <bug-33382-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33382-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33382-70-bsZkb1RWJx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33382 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:46 +0000 Subject: [Koha-bugs] [Bug 33382] Use template wrapper for breadcrumbs: Patron clubs In-Reply-To: <bug-33382-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33382-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33382-70-lE9ejkFiNL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33382 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:47 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33414-70-KUFuD3n5xi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:44:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:44:49 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33414-70-ssbV2IwbxC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:48:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:48:40 +0000 Subject: [Koha-bugs] [Bug 9762] Log circulation overrides In-Reply-To: <bug-9762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9762-70-3HibWVEtVR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #6 from solene.ngamga at inlibro.com --- Created attachment 149554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149554&action=edit Bug 9762: Log circulation overrides This patch allows you to save commands that have been overridden by someone. To test: --After each step, a message will be display on the actionlog-- Circulation -- Checking out - Check out an item that is age restricted (AgeRestrictionOverride syspref) - Check out an item that has a not for loan status (AllowNotForLoanOverride syspref) - Check out an item that has a lost status (IssueLostItem syspref) - Check out an item to a patron who has reached the checkout limit (AllowTooManyOverride syspref) - Check out an item to a patron who is not allowed to borrow this item type - Check out an item to a patron who has unpaid fines (AllFinesNeedOverride and/or AllowFineOverride + noissuescharge sysprefs) - Check out an item on hold for someone else - Check out an item on hold ready for pickup by someone else - Check out an item already checked out to someone else (AutoReturnCheckedOutItems syspref) - Check out to a patron who has restrictions Circulation -- Checking in - Ignore a hold upon check in - Ignore a hold & transfer upon check in Circulation -- Renewing - Renew an item on hold for someone else - Renew an item that has reached the maximum amount of renewals Holds - Place a hold for a patron who is not allowed to put this item type on hold - Place a hold for a patron who has reached the maximum amount of holds - Place an item-level hold when rules say this is not allowed Signed-off-by: Solene Ngamga <solene.ngamga at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 16:50:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 14:50:19 +0000 Subject: [Koha-bugs] [Bug 9762] Log circulation overrides In-Reply-To: <bug-9762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9762-70-adSZ035ekl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 solene.ngamga at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |solene.ngamga at inlibro.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:00:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:00:20 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-Zs5zI4w9UN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149555&action=edit Bug 33483: Prevent 400 when more than 1 agreement is linked We were passing package_agreements.agreement and the server returned Object { message: "Properties not allowed: agreement.", path: "/body/package_agreements/0" } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:12:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:12:02 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-f9Ws9EXuuG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149509|0 |1 is obsolete| | --- Comment #13 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 149556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149556&action=edit Bug 33105: DB changes Signed-off-by: Jonathan Field <jonathan.fieeld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:12:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:12:05 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-XulS5cPBxp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149510|0 |1 is obsolete| | --- Comment #14 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 149557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149557&action=edit Bug 33105: DBIC schema changes Signed-off-by: Jonathan Field <jonathan.fieeld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:12:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:12:07 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-OkW1oxI8ji@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149511|0 |1 is obsolete| | --- Comment #15 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 149558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149558&action=edit Bug 33105: DBIC specific Signed-off-by: Jonathan Field <jonathan.fieeld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:12:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:12:09 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-YI7cpjvlIW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149512|0 |1 is obsolete| | --- Comment #16 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 149559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149559&action=edit Bug 33105: Add Koha object classes Signed-off-by: Jonathan Field <jonathan.fieeld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:12:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:12:12 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-HrNejsCObk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149530|0 |1 is obsolete| | --- Comment #17 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 149560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149560&action=edit Bug 33105: Add vendor issues This patch is the main patch of this patch set, it contains the controller acqui/vendor_issues.pl, its corresponding template, and some links to this script. It adds: * A new DB table aqbookseller_issues linked with the aqbooksellers table * A new subpermission acquisition.issue_manage * A new authorised value category VENDOR_ISSUE_TYPE and two examples MAINTENANCE and OUTAGE * A new controller couple acqui/vendor_issues.[pl,tt] Test plan: 0. Apply the patches, run updatedatabase and restart_all 1. Go to the acquisition module, create a new vendor or use an existing one 2. Create a couple of issues for this vendor 3. Edit/Delete and search for those issues This is the basics for tracking issues with vendors. Suggestions welcome, on follow-up bug reports. Signed-off-by: Jonathan Field <jonathan.fieeld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:12:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:12:14 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-4jN3Eh4cn3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149531|0 |1 is obsolete| | --- Comment #18 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 149561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149561&action=edit Bug 33105: REST API specs Signed-off-by: Jonathan Field <jonathan.fieeld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:12:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:12:16 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-jWOtOmvSBV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149532|0 |1 is obsolete| | --- Comment #19 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 149562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149562&action=edit Bug 33105: Add tests Signed-off-by: Jonathan Field <jonathan.fieeld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:17:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:17:28 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor Issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-wgZZfijkgz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Jonathan Field <jonathan.field at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:21:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:21:41 +0000 Subject: [Koha-bugs] [Bug 33507] New: EBSCO packages - Dont list already related agreements when adding a new agreement Message-ID: <bug-33507-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33507 Bug ID: 33507 Summary: EBSCO packages - Dont list already related agreements when adding a new agreement Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: pedro.amorim at ptfs-europe.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com Depends on: 33483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 [Bug 33483] Cannot link EBSCO's package with local agreement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:21:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:21:41 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-8uixNGPoaB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33507 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33507 [Bug 33507] EBSCO packages - Dont list already related agreements when adding a new agreement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:23:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:23:19 +0000 Subject: [Koha-bugs] [Bug 33507] EBSCO packages - Dont list already related agreements when adding a new agreement In-Reply-To: <bug-33507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33507-70-bCjHKEs9Sj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33507 --- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149563&action=edit Bug 33507: WIP This is a work in progress, have not been able to get the 'not equals' query to work, its documented as a comment in the code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:27:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:27:33 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-CgbIzMswpT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:27:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:27:36 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-tUphoSQeFJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149455|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149564&action=edit Bug 33483: Fix link EBSCO package with local agreements Bug 33066 broke that, we need to set 'initialized'. Test plan: Turn on EBSCO provider, search for a package and click "Add new agreement". The modal must open with the list of agreements. Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:27:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:27:39 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-qsbJeHVQGu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149470|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149565&action=edit Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:27:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:27:42 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-5fa0dOnCSV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149527|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149566&action=edit Bug 33483: Make KohaTable accept customizable actions button We have hardcoded some buttons: edit, delete But we could need specific buttons. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:27:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:27:44 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-8AyjeoBthG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149528|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149567&action=edit Bug 33483: Restore 'select' We are not supposed to see edit and delete buttons, but select instead, to pick an agreement. Regression introduced by commit 809f90d394fdef8142fdf8f4a6e825dc14a132d4 Bug 33066: Remove build_datatable Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:27:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:27:47 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-NlkcvYMAsH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149529|0 |1 is obsolete| | --- Comment #18 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149568&action=edit Bug 33483: (follow-up) Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:27:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:27:50 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-gmOXI0UFjx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149555|0 |1 is obsolete| | --- Comment #19 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149569&action=edit Bug 33483: Prevent 400 when more than 1 agreement is linked We were passing package_agreements.agreement and the server returned Object { message: "Properties not allowed: agreement.", path: "/body/package_agreements/0" } Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:28:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:28:29 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-gcVECG8Fij@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #20 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Tested last patch, can confirm it fixes the 400 error when adding a 2nd agreement to an EBSCO package. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:32:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:32:48 +0000 Subject: [Koha-bugs] [Bug 9596] Allow longoverdue.pl to be configured by library In-Reply-To: <bug-9596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9596-70-qJM0F0xr0V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9596 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 17:42:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 15:42:45 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-NGMjK03phI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149525|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 18:03:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 16:03:17 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33462-70-Qz1KaeEq6v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 18:04:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 16:04:04 +0000 Subject: [Koha-bugs] [Bug 21309] Enforce password change on login In-Reply-To: <bug-21309-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21309-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21309-70-FGB8VPb2xa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21309 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 18:05:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 16:05:01 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33462-70-yOdH2GjlKB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 AspenCat Team <aspencatteam at clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 18:18:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 16:18:59 +0000 Subject: [Koha-bugs] [Bug 25689] Move 'Manage OPAC problem reports' permission into tools In-Reply-To: <bug-25689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25689-70-Y6QzwEx4cJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25689 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 18:22:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 16:22:45 +0000 Subject: [Koha-bugs] [Bug 32256] self-checkout batch mode In-Reply-To: <bug-32256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32256-70-B752uDs5oT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 18:32:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 16:32:36 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-kaZJMSsEo4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #37 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149570&action=edit Bug 33408: Fix template literal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 18:33:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 16:33:36 +0000 Subject: [Koha-bugs] [Bug 33508] New: Submitting patron update request from OPAC deletes any pending updates Message-ID: <bug-33508-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33508 Bug ID: 33508 Summary: Submitting patron update request from OPAC deletes any pending updates Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a patron submits a request for update of their personal information, if they submit another request before the first one is approved, the info is deleted. To demonstrate: 1. In OPAC, submit a update changing street address (or any field) 2. View in staff interface and see that the submission shows. Do not take any action on it. 3. Go back to OPAC and submit an update for something else, such as phone number 4. In staff interface, view the new update request and see that only the last one (phone number) shows, the address request has been removed. This is a problem because patrons have no indication that their previous request is being deleted, and staff have no idea that other updates have been requested. For instance, a patron goes into their account and updates address, then realizes they also need to change phone number, and there is no way for them to know they are deleting the previous request. We need to either block patrons from being able to overwrite the previous request, or find a way to retain both requests. I think the second option would be the most customer friendly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 18:34:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 16:34:57 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-GaPURBTlpv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #38 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- I think there's something wrong in this patch: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149535 With it applied, if you access http://localhost:8081/cgi-bin/koha/erm/agreements on a new window, it never gets past "Loading", but clicking on the different menu items and going back to agreements, all works fine. It's only with agreements too. This doesn't happen with licenses or any of the others. I'm looking into this but ask if someone else can confirm if they can also reproduce this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 18:42:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 16:42:20 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16122-70-jy0o7AMwra@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33500 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 [Bug 33500] Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 18:42:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 16:42:20 +0000 Subject: [Koha-bugs] [Bug 33500] Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record In-Reply-To: <bug-33500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33500-70-YmWI9sY9f9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16122 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 [Bug 16122] Item record needs to keep Local Use count -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 18:52:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 16:52:01 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-4Fsmmtt7ke@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #39 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- The behaviour I'm experiencing is fixed by bug 33483, more specifically this patch: https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33483&attachment=149564 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 18:59:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 16:59:27 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-a2VCifrpxS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #4 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- It doesn't fix the "show mine only" being punted to the left, this is because it's getting a float:left also from being a child of <fieldset> (which is also causing the table to not be full width). The problem is <EHoldingsPackageAgreements> sits inside a <fieldset> in EHoldingsEBSCOPackagesShow.vue. Then, in EHoldingsEBSCOPackageAgreements.vue we're opening the modal that has <AgreementsList> inside it, but that modal is already a child of the aforementioned <fieldset> so it's inheriting its style unintendendly. There is also another problem: the modal needs a overflow (and perhaps a max-height?). If we have many agreements created, the modal overflows the screen and doesn't let the user scroll vertically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 19:09:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 17:09:14 +0000 Subject: [Koha-bugs] [Bug 33032] Alternate holdings broken in staff interface search results In-Reply-To: <bug-33032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33032-70-ixllxxGE5p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- With this patch in 22.11.04 we now show "Other holdings" in the staff interface result list, when the alternate holdings field is not present in the record. Before this patch we showed "No items", which is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 19:10:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 17:10:44 +0000 Subject: [Koha-bugs] [Bug 33509] New: Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternat holdings Message-ID: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Bug ID: 33509 Summary: Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternat holdings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, michaela.sieber at kit.edu Depends on: 33032 With bug 33032 in 22.11.04 we now show "Other holdings" in the staff interface result list, when the alternate holdings field is not present in the record. Before this patch we showed "No items", which is correct in this case. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 [Bug 33032] Alternate holdings broken in staff interface search results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 19:10:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 17:10:44 +0000 Subject: [Koha-bugs] [Bug 33032] Alternate holdings broken in staff interface search results In-Reply-To: <bug-33032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33032-70-cBV1lYGSOh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternat holdings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 19:13:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 17:13:17 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-bDay4LDOyP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Staff search result list |Staff search result list |shows "other holdings" with |shows "other holdings" with |AlternateHoldingsField when |AlternateHoldingsField when |there are no alternat |there are no alternate |holdings |holdings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 19:13:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 17:13:36 +0000 Subject: [Koha-bugs] [Bug 33032] Alternate holdings broken in staff interface search results In-Reply-To: <bug-33032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33032-70-oBKUYfer3x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #10) > With this patch in 22.11.04 we now show "Other holdings" in the staff > interface result list, when the alternate holdings field is not present in > the record. > > Before this patch we showed "No items", which is correct. Filed as bug 33509 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 19:34:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 17:34:20 +0000 Subject: [Koha-bugs] [Bug 33271] Show charges_guarantors_guarantees on patron detials page In-Reply-To: <bug-33271-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33271-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33271-70-eb0mq2qPcf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33271 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 19:34:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 17:34:22 +0000 Subject: [Koha-bugs] [Bug 33271] Show charges_guarantors_guarantees on patron detials page In-Reply-To: <bug-33271-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33271-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33271-70-lvtX8hJibq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33271 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149571&action=edit Bug 33271: Add collective owing message to moremember page To test: 1. Turn on NoIssuesChargeGuarantorsWithGuarantees and set the amount to 5. 2. Create a guarantor/guarantee relationship. 3. Add a manual invoice to the guarantor that is larger than 5.00. 4. Notice the message on that circulation ( check out tab ) page. " Charges: Patron's guarantors and their other guarantees collectively owe X. Checkouts are BLOCKED because fine balance is OVER THE LIMIT. " 5. Look at the moremember ( details ) page. The same message does not appear. 6. Apply patch, restart_all 7. Try step 5 again, the message should now appear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 19:34:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 17:34:36 +0000 Subject: [Koha-bugs] [Bug 33271] Show charges_guarantors_guarantees on patron detials page In-Reply-To: <bug-33271-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33271-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33271-70-ckCC77hd6p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33271 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 19:36:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 17:36:11 +0000 Subject: [Koha-bugs] [Bug 33271] Show charges_guarantors_guarantees on patron details page In-Reply-To: <bug-33271-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33271-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33271-70-pRjwBHLFWp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33271 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show |Show |charges_guarantors_guarante |charges_guarantors_guarante |es on patron detials page |es on patron details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 19:43:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 17:43:51 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-IAcZcIzatW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 19:43:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 17:43:54 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-7XVTyRmecc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149465|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 149572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149572&action=edit Bug 33496: Add 'host_items' param to Koha::Biblio->items This patch adds an option to the $biblio->items method to allow retrieving the items and analytic items for a record. This is intended to allow fetching a single Items object, and related object, rather than having to fetch the items, and the host items, and push them together This is step towards being able to fetch items using API/DataTables directly To test: 1 - prove -v t/db_dependent/Koha/Biblio.t Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 20:00:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 18:00:56 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-z7KowyGMba@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 20:00:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 18:00:59 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-spcNj6clHB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149467|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 149573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149573&action=edit Bug 33497: Use 'host_items' param to fetch all items at once This patch adjusts the detail page to fetch items and host items together, and prefetches transfers and checkouts To test: 1 - Enable easy analytics 2 - Attach some items to a bib 3 - Checkout an item on the bib 4 - View the details page 5 - Apply patch 6 - View details page, confirm nothing has changed Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 20:01:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 18:01:01 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-nQw4aANR7q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149468|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 149574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149574&action=edit Bug 33497: Add a filter relationship for branchtransfers This uses the new relationship from bug 33493 to fetch the transfers for items To test: 1 - Transfer some items on a bib 2 - View the biblio details page in the staff interface 3 - Apply patch 4 - Confirm the view is the same Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 20:02:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 18:02:30 +0000 Subject: [Koha-bugs] [Bug 33510] New: Add context to "New" as a status Message-ID: <bug-33510-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33510 Bug ID: 33510 Summary: Add context to "New" as a status Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When trying to correct the translation for OPAC problem reports, I noticed that in some cases, the word "New" alone is used as "Add a new thing" (action/verb) and in other cases, it is used as "This thing is new" (status/adjective). Currently, the word "New" alone is used in these places As "Add a new thing" (action/verb) #: koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt:38 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt:110 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt:320 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt:146 #: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:1586 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt:383 #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt:988 As "This thing is new" (status/adjective) #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt:51 #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt:95 #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt:99 #: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt:158 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt:166 #: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt:896 #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt:318 #: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt:36 #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:381 #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:412 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/problem-reports.tt:108 #: koha-tmpl/intranet-tmpl/prog/en/includes/filter-orders.inc:57 #: koha-tmpl/intranet-tmpl/prog/en/includes/filter-orders.inc:59 #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt:954 Not sure? #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/problem-reports.tt:149 I wonder if the solution here is to add translation context, or to change the word to "Add" or "Add new" where it is used as "Add a new thing". In French, the gender of "New" as an adjective should also change depending on the gender of the thing that is new, so in the context, it should say what thing is new. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 20:06:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 18:06:03 +0000 Subject: [Koha-bugs] [Bug 33510] Add context to "New" as a status In-Reply-To: <bug-33510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33510-70-WNhOSgwcRW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33510 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- There is a lot of precedent where the word "Add" alone is used as "Add a new thing". #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt:418 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt:149 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/curbside_pickup.tt:154 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt:62 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt:45 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:120 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:141 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:186 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:189 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:279 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt:95 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt:125 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:863 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:947 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:1002 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:1061 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:1382 #: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt:279 #: koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt:230 #: koha-tmpl/intranet-tmpl/prog/en/modules/labels/result.tt:86 #: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt:305 #: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt:341 #: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt:556 #: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt:629 #: koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt:85 #: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:582 #: koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt:118 #: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:108 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt:431 #: koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc:48 #, c-format msgid "Add" msgstr "Ajouter" #: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt:63 #: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt:227 #, c-format msgid "Add " msgstr "Ajouter " #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt:77 #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt:256 #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt:283 #: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt:370 #: koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc:36 msgid "Add" msgstr "Ajouter" So maybe the word "New" alone should be reserved to status/adjective and "Add" should be used as action/verb? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 20:15:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 18:15:05 +0000 Subject: [Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-9Ck1D9wmSg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #13 from David Nind <david at davidnind.com> --- I'm not sure what is required to test this one - apply the patch, and repeat the tests for bug 33493 and 33497? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 20:43:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 18:43:50 +0000 Subject: [Koha-bugs] [Bug 33175] When reporting a problem while not logged in, the problematic page is set to opac-reportproblem.pl In-Reply-To: <bug-33175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33175-70-QIGzIfLDsd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33175 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #1 from David Nind <david at davidnind.com> --- For me, Koha is recording the OPAC home page (/) as the problematic page, irrespective of: - whether I'm logged in or not - irrespective of the page I'm on For example: 1. Log out of the OPAC 2. Go to a detail page for a record (for example http://127.0.0.1:8080/cgi-bin/koha/opac-detail.pl?biblionumber=262) or any other page (except the OPAC home page) 3. Click on report a problem in the footer 4. Prompted to log in 5. Log in 6. For the form, / is shown for "Problem found on page" 7. Enter some details and submit 8. In the staff interface, the problem page is reported as the OPAC home page Maybe this feature requires some other bugs to be applied, or that aren't in master yet? Or maybe I'm misunderstanding and getting confused with bug 31028 ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 21:56:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 19:56:06 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-rHTn5Trkin@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 22:01:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 20:01:50 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-OeLFAvP9eq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 22:01:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 20:01:53 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-3Zt551EtWZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149575&action=edit Bug 33509: Don't show Other holdings when there are no alternate holdings With bug 33509 alternate holdings defined in AlternateHoldingsField are shown in the staff interface result list. This works greatly when there are items or when there is are alternate holdings (the configured field/subfields exist in the record), but not when there are no items and no alternate holdings. To test: * Add 100a to AlternateHoldingsField * Make a search with some records without items Sample data: perl * Make sure the alternate holdings show when there are no items and 100a exists * Change to 100z * Verify the result list now shows "Other holdings:" with nothing below * Apply patch * Repeat * Alternate holdings should still show nicely * Without alternate holdings 'no items' is displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 22:08:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 20:08:02 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-chOvti3FAU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 | released in| | --- Comment #11 from Victor Grousset/tuxayo <victor at tuxayo.net> --- (In reply to Jonathan Druart from comment #5) > (In reply to Victor Grousset/tuxayo from comment #4) > > btw, is the CI running them > > They are run at the end if no other failure happened. ok! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 22:09:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 20:09:09 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-PDaXk3TYGI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think I might still be missing some step? yarn cypress run --spec /kohadevbox/koha/t/cypress/integration/Agreements_spec.ts yarn run v1.22.19 $ cypress run --spec /kohadevbox/koha/t/cypress/integration/Agreements_spec.ts [4571:0412/200617.573954:ERROR:sandbox_linux.cc(377)] InitializeSandbox() called with multiple threads in process gpu-process. [4571:0412/200617.575611:ERROR:gpu_memory_buffer_support_x11.cc(44)] dri3 extension not supported. Can't run because no spec files were found. We searched for specs matching this glob pattern: > /kohadevbox/koha/t/cypress/integration/Agreements_spec.ts error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 22:10:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 20:10:31 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-G0sNw1hDxo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make home branch mandatory |Make home library mandatory |by default |by default QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 22:14:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 20:14:52 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-q2nt4uQypb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Laura, I fully agree with this change. Some small things: 1) Please take a look at your dev environment configuration, you probably missed setting the variables in .env. The patches were written by: From: John Doe <you at example.com> 2) Should we not do the same for holding library? ... I can't finish here right now because I have some trouble with Selenium tonight. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 22:16:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 20:16:26 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-GAUIuYh1NI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 22:42:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 20:42:44 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-xtgglHF8jm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Series has wrong index name |Series has wrong index name |on scan index page |on scan index page and | |search option selection is | |not retained -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 22:46:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 20:46:00 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-HSEy9IzORX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 22:46:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 20:46:03 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-vSqg2318vO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149576&action=edit Bug 33506: Fix false index for series and keep selected index on scan index page The pull down with search options had the wrong index linked to the Series entry: su instead of se To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Verify search results link to authors using c * Switch to series * Verify search results use 'su' for subject * Verify that search option pull down always jumps back to first entry: Any word * Apply patch * Verify the search results for series now use correct index se * Verify that coming from advanced search, the correct search option is selected * Verify that changing the search option also keeps the selection after searching Note: with Elasticsearch and default configuration author, title and series will give you results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 22:47:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 20:47:22 +0000 Subject: [Koha-bugs] [Bug 33505] Doubled up id 'scan-index' on 'scan index' page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-WcxZXHM8BK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33506 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 22:47:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 20:47:22 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-R6j0JIoxRY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 [Bug 33505] Doubled up id 'scan-index' on 'scan index' page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 22:53:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 20:53:46 +0000 Subject: [Koha-bugs] [Bug 33505] Doubled up id 'scan-index' on 'scan index' page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-wKfUAiPdui@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 23:01:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 21:01:02 +0000 Subject: [Koha-bugs] [Bug 33511] New: Gather print notices can only send overdue notices to the patron's home library Message-ID: <bug-33511-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33511 Bug ID: 33511 Summary: Gather print notices can only send overdue notices to the patron's home library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The overdue notices generator can split overdues by home library, so if a patron is from library A and has overdues from libraries A, B and C, that person will receive 3 overdue notices ( one for each library's items ). The problem is, the gather print notices cronjob also has the option to separate notices by branch, but it only works by patron home library. So, with this option enabled, all three overdue notices would by sent to library A. What some libraries are expecting is that the notices for A's items goes to A, B's items goes to B, and so on. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 23:01:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 21:01:03 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-BLtlclarSe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149576|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149577&action=edit Bug 33506: Fix false index for series and keep selected index on scan index page The pull down with search options had the wrong index linked to the Series entry: su instead of se To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Verify search results link to authors using c * Switch to series * Verify search results use 'su' for subject * Verify that search option pull down always jumps back to first entry: Any word * Apply patch * Verify the search results for series now use correct index se * Verify that coming from advanced search, the correct search option is selected * Verify that changing the search option also keeps the selection after searching Note: with Elasticsearch and default configuration author, title and series will give you results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 23:01:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 21:01:17 +0000 Subject: [Koha-bugs] [Bug 33511] Gather print notices can only send overdue notices to the patron's home library In-Reply-To: <bug-33511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33511-70-TmN24Mu8W5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33511 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Notices |and plumbing | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 23:02:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 21:02:52 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-7FZP4JBLTJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Doubled up id 'scan-index' |Improve styling of scan |on 'scan index' page |index page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 23:09:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 21:09:00 +0000 Subject: [Koha-bugs] [Bug 27572] Move OpacLocationBranchToDisplay system preference into table settings In-Reply-To: <bug-27572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27572-70-zC58Wknmv7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27572 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- (In reply to Katrin Fischer from comment #1) > I think it is because the location shows below the library on a new line and > the pref decides if it shows below the home library or below the current > library - so the column settings don't work there. > You're thinking of OpacLocationOnDetail, which is a different one. :) Currently Administration > Table settings > OPAC > holdingst has the option to show/hide item_current_location (holding library) and item_home_location (home library), but if we try to show/hide on of the columns using table settings, it doesn't change anything. But if we hide both using table settings, it works. To test: 1. Set OpacLocationBranchToDisplay to both home and holding library 2. Go to a bibliographic record with an item in the OPAC --> Both columns should show 3. Go to Administration > Table settings > OPAC > holdingst and check "Is hidden by default" for item_home_location, save 4. Go to the OPAC and refresh the page --> Both columns are still visible 5. Go back to table settings and check also item_current_location (both current and home should now be checked), save 6. Go back to the OPAC and refresh the page --> No columns are visible -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 23:09:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 21:09:54 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-5TBSMXWcJk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 23:09:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 21:09:56 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-BUaemQ1TJT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149578&action=edit Bug 33505: Improve styling of scan index page This patch makes some changes to the 'scan index' page. * Updates second h1 heading "Scan index:" to h2 level heading "Scan index" * Removes table from the search form * Moves search index pull down and search term into one line * Reorders options with search index first and search term after, matching the advanced search form * Removes the catalog results toolbar from the top, card hold etc. are not needed here. * Fixes doubled up id attribute: scan-index by turning one into scan-index-term. To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Check display, especially search options, options at the top of the page etc. * Apply patch * Verify changes listed above * Regression test the normal search results, all should look the same with and without patch. * If you think the scan index page is nicer now - sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 23:12:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 21:12:50 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-SINyMzYaeN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149578|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149579&action=edit Bug 33505: Improve styling of scan index page This patch makes some changes to the 'scan index' page. * Updates second h1 heading "Scan index:" to h2 level heading "Scan index" * Removes table from the search form * Moves search index pull down and search term into one line * Reorders options with search index first and search term after, matching the advanced search form * Removes the catalog results toolbar from the top, card hold etc. are not needed here. * Fixes doubled up id attribute: scan-index by turning one into scan-index-term. To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Check display, especially search options, options at the top of the page etc. * Apply patch * Verify changes listed above * Regression test the normal search results, all should look the same with and without patch. * If you think the scan index page is nicer now - sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 12 23:13:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 21:13:14 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-QgfG5bigUp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 00:03:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 22:03:39 +0000 Subject: [Koha-bugs] [Bug 33512] New: Labels/buttons are confusing on serials-edit page Message-ID: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Bug ID: 33512 Summary: Labels/buttons are confusing on serials-edit page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org TO recreate: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. At this point you are actually editing an item, not adding an item. This is confusing and leads librarians to never edit these items because they assume they are adding an item, not editing the existing one. Also, the 'Click to add item' is small and grey. It should look more like a button. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 00:29:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 22:29:28 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-g31USyCyds@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 00:29:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 22:29:30 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-JwbkudbElB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149580&action=edit Bug 33512: Change text and add button classes on serial-edit page To test: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. 8. Apply patch. 9. Try 6 & 7 again. The existing items should now read 'Click to edit item' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 00:29:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 22:29:41 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-m7sS5Qo3vz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 00:53:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 22:53:45 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-6Q8G0xOTs9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #9 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Thank you for testing Laura! (In reply to Laura Escamilla from comment #8) > Hi! > > Overall the new syspref and notices management page is working as expected. > However, there are a few things I noticed that seem to be a little broken. > > 1. In the Notices Management page if you search for a patron and their name > populates then clicking on the populated name will appropriately take you to > their notice history. However, if you use the "Browse by last name" option > or if you just search for a letter such as "K", then the table that is > supposed to show the patron names is not displayed properly. It is askew to > the left and mixes into the filter options. > I'll work on fixing this. > 2. The print notices work, but there is a lot of whitespace within the > messages. This might be a separate bug, but having the messages more > condensed and still separated by the horizontal line would be ideal. This is just how the default HOLD print notice comes in Koha, it has heaps of line breaks in it. You can go to Notices & slips and delete the newlines from the template notice to remove that whitespace. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 01:11:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 23:11:50 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-1GN0wbVBk1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 01:11:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 23:11:53 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-3BjtCMcRbD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #10 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149581&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 01:31:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Apr 2023 23:31:13 +0000 Subject: [Koha-bugs] [Bug 33511] Gather print notices can only send overdue notices to the patron's home library In-Reply-To: <bug-33511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33511-70-vU2Dp2OPei@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33511 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 06:49:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 04:49:24 +0000 Subject: [Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF In-Reply-To: <bug-33393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33393-70-idlD8rfDd8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #7 from Alex Buckley <alexbuckley at catalyst.net.nz> --- (In reply to David Nind from comment #6) > Hi Alex. > > This works well. > > My only comment would be to add a hint or note to the 1PageOrderPDFText > system preference about the length of the text. > > I added multiple long paragraphs and the text was cut off where the order > table starts, and does not display the delivery comment. > > David Hi David, That is a great idea. Thanks for that. I will add a follow-up patch with that addition. Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 07:55:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 05:55:19 +0000 Subject: [Koha-bugs] [Bug 33513] New: batch update from report module - no patrons loaded into view Message-ID: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 Bug ID: 33513 Summary: batch update from report module - no patrons loaded into view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org #32368 add spaces in codes list and #27142 is back you can't batch update from reports. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 08:00:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 06:00:50 +0000 Subject: [Koha-bugs] [Bug 33273] There is no space between the words after ":" In-Reply-To: <bug-33273-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33273-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33273-70-EWhYAWGe3V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33273 --- Comment #4 from Igor A. Sychev <Igor.A.Sychev at mail.ru> --- There is no space after ":" RESSOURCES EN LIGNE :Cliquez ici pour consulter en ligne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 08:00:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 06:00:58 +0000 Subject: [Koha-bugs] [Bug 33513] batch update from report module - no patrons loaded into view In-Reply-To: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33513-70-F5jZadBffk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 Didier Gautheron <didier.gautheron at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32368 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32368 [Bug 32368] Add page-section to saved report results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 08:00:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 06:00:58 +0000 Subject: [Koha-bugs] [Bug 32368] Add page-section to saved report results In-Reply-To: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32368-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32368-70-U4cRxj3kL2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32368 Didier Gautheron <didier.gautheron at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33513 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 [Bug 33513] batch update from report module - no patrons loaded into view -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 08:03:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 06:03:06 +0000 Subject: [Koha-bugs] [Bug 33273] There is no space between the words after ":" In-Reply-To: <bug-33273-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33273-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33273-70-Jiet5iqSAo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33273 --- Comment #5 from Igor A. Sychev <Igor.A.Sychev at mail.ru> --- In English: ONLINE RESOURCES:Click here to access online -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 08:14:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 06:14:20 +0000 Subject: [Koha-bugs] [Bug 33513] batch update from report module - no patrons loaded into view In-Reply-To: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33513-70-e68s27Ybgp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 --- Comment #1 from Didier Gautheron <didier.gautheron at biblibre.com> --- Created attachment 149582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149582&action=edit Bug 33513: (follow-up) Remove whitespace in batch report lists Bug 32368 added whitespaces, remove them. To test: 1 - Create a report like: SELECT biblionumber FROM biblio 2 - Run it 3 - Try the various options from the 'Batch operations' button 4 - The operations don't find the biblios 5 - Create a report like: SELECT cardnumber FROM borrowers 6 - Run it 7 - Test the batch operations 8 - They fail 9 - Apply patch 10 - Run each report again and test batch operations 11 - They work! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 08:14:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 06:14:50 +0000 Subject: [Koha-bugs] [Bug 33513] batch update from report module - no patrons loaded into view In-Reply-To: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33513-70-I9nPttZSRz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 Didier Gautheron <didier.gautheron at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:07:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:07:23 +0000 Subject: [Koha-bugs] [Bug 33507] EBSCO packages - Dont list already related agreements when adding a new agreement In-Reply-To: <bug-33507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33507-70-VGBlVwG2yx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33507 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Try that: { "agreement_packages.package_id": [ {"!=": 1}, {"=": null } ] } You want to list those that are not linked with the current one but also those that are not linked with any packages (it's a left join). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:07:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:07:36 +0000 Subject: [Koha-bugs] [Bug 33507] EBSCO packages - Dont list already related agreements when adding a new agreement In-Reply-To: <bug-33507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33507-70-bj7l68gAFH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33507 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|jonathan.druart+koha at gmail. |pedro.amorim at ptfs-europe.co |com |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:11:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:11:46 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-yNo7Fiimdj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Yesterday the tests have been moved to t/cypress/integration/ERM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:17:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:17:19 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31695-70-IwiAZQk75c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Kevin Carnes <kevin.carnes at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149231|0 |1 is obsolete| | --- Comment #8 from Kevin Carnes <kevin.carnes at ub.lu.se> --- Created attachment 149583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149583&action=edit Bug 31695: Type standard number is missing field ci_raw in field_config.yaml In Elasticsearch fields config field_config.yaml, default type as a field 'ci_raw'. This is used for exact search. This field is missing for type standard number 'stdno'. Test plan : 1) In the staff interface, go to Administration, and search for SearchEngine 2) Make sure that the SearchEngine preference is set to Elasticsearch and save 3) Return to Administration and select "Search engine configuration" 4) Change the type of "Heading-Main" to "Std. Number" and save 5) Rebuild the index (e.g. "koha-elasticsearch --rebuild -d kohadev") 6) Go to the main staff page and select Authorities 7) Search for a heading (e.g. "A Dual-language book") => Result is found with or without patch 8) Click on the sliders and select "is exactly" for the operator and search => Result is found only with patch 9) Apply the patch 10) Rebuild the index (e.g. "koha-elasticsearch --rebuild -d kohadev") 11) Click on the sliders and select "is exactly" for the operator and search => Result is found only with patch Signed-off-by: Kevin Carnes <kevin.carnes at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:17:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:17:45 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-Sa8cZjACST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:17:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:17:47 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-2acGCWiaO9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149443|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149584&action=edit Bug 33486: Remove Koha::BackgroundJob::UpdateElasticIndex->process Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:18:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:18:21 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-Z2sASI4EvH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149395|0 |1 is obsolete| | Attachment #149397|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149585&action=edit Bug 33316: Improve display of ES indexer jobs We don't do a lot of processing to the data, but we can still make the display a bit nicer, to show how many records were done, and show the record ids. To test: 1 - Do some batch modifications on a system running ES 2 - Check background jobs to see ES jobs 3 - Note display 4 - Apply patch 5 - Confirm display is improved Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:18:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:18:24 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-DedQgJKD16@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149586&action=edit Bug 33316: (QA follow-up) Add link to record, fix typo and heading * h2 h2 directly following each other make no sense. Changed to h2 h3 * ids changed to IDs * Linked the record ID to the catalog entry Note: We also have this link in the batch record mod job details Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:18:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:18:58 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-dckBXNtEZk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #16) > (In reply to Jonathan Druart from comment #15) > > Sorry, I don't have time for this now. > > > > Back to PQA, but we should not push as it IMO. > > This is only a display change - can you explain your worries? Not better than on bug 32594 comment 41. This is all good now. Thanks, Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:19:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:19:04 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-QIN11VwIW1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:30:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:30:39 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-a5mt9pfdl3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23079 CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:30:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:30:39 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: <bug-23079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23079-70-ZotyN04Iyh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32232 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:36:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:36:11 +0000 Subject: [Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt In-Reply-To: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33088-70-47GrKjQrbt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:36:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:36:14 +0000 Subject: [Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt In-Reply-To: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33088-70-1AL440oObs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149335|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149587&action=edit Bug 33088: Remove background-job-progressbar.js in batch_record_modification.tt It must be removed, we don't need it since bug 22417 Test plan : Play with batch record modification and check there is no JS error Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:43:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:43:02 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-ek5PXeyjGi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #33 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- * We don't need to hide nodes in the template * The links we display in the template does not work (we do not send the biblio to the template as we exit early) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:57:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:57:11 +0000 Subject: [Koha-bugs] [Bug 33514] New: breaks ISBN search in item search Message-ID: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 Bug ID: 33514 Summary: breaks ISBN search in item search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 23919 Item search is SQL based, not search engine based. When bug 23919 added SearchWithISSNVariations to item search, it broke all searches, but for one use case (that was tested): single ISBN, no ISBD punctuation. We are exploding the search now with up to 4 forms of ISBN into something like: isbn like 'isbn1' or isbn like 'isbn2' ... But: We are not truncating. As soon as there is more than one ISBN (this is a repeatable field) or the library actually follows MARC21 standard adding ISBD punctuation, this fails. The data in biblioitems.isbn looks like this: isbn1 ; | isbn2 ; | isbn3. isbn1. This also seems to create quite a performance issue on big databases and it can't be turned off separately from the normal search. I am not sure what is best, we could do something like this, which will make the search work again, but I think we also should make it a separate switch: @@ -1047,7 +1047,12 @@ sub _SearchItems_build_where_fragment { if ( C4::Context->preference("SearchWithISBNVariations") and $query ) { my @isbns = C4::Koha::GetVariationsOfISBN( $query ); $query = []; + foreach my $isbn(@isbns) { + $isbn = "%" . $isbn . "%"; + } Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 [Bug 23919] Make ISSN searchable with and without hyphen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:57:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:57:11 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23919-70-SjIBHhX0Yd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33514 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 [Bug 33514] breaks ISBN search in item search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:57:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:57:18 +0000 Subject: [Koha-bugs] [Bug 33514] breaks ISBN search in item search In-Reply-To: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33514-70-bayJdrfXoM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:58:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:58:03 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23919-70-iIe8sBnRE2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 --- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am sad to say, but adding this to item search was not a great idea :( Item search is SQL based, not a search engine, which changes things quite a bit. We are exploding the search now with up to 4 forms of ISBN into something like: isbn like 'isbn1' or isbn like 'isbn2' ... But: We are not truncating. As soon as there is more than one ISBN or ISSN (these are repeatable fields) or the library actually follows MARC21 standard adding ISBD punctuation, this fails. We store in biblioitems.isbn like this: isbn1 ; | isbn2 ; | isbn3. isbn1. This also seems to create quite a performance issue on big databases and it can't be turned off separately from the normal search. I've filed bug 33514. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 09:58:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 07:58:54 +0000 Subject: [Koha-bugs] [Bug 33514] SearchWithISSNVariations breaks ISBN search in item search In-Reply-To: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33514-70-cYuSSshslD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|breaks ISBN search in item |SearchWithISSNVariations |search |breaks ISBN search in item | |search --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I should also mention that any truncation entered in the item search is lost when it's run through the ISBN conversion. So there is no workaround. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 10:00:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 08:00:25 +0000 Subject: [Koha-bugs] [Bug 33514] SearchWithIS[B|S]NVariations breaks ISBN search in item search In-Reply-To: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33514-70-zYODw00ox6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SearchWithISSNVariations |SearchWithIS[B|S]NVariation |breaks ISBN search in item |s breaks ISBN search in |search |item search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 10:38:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 08:38:05 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-lNqTU7NQFe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Expose MARC21 tag 765 - |Show MARC21 tag 765 - |Original Language Entry |Original Language Entry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 10:42:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 08:42:25 +0000 Subject: [Koha-bugs] [Bug 33515] New: XSLT: Use GetCnumSearchURL utility template in other places Message-ID: <bug-33515-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33515 Bug ID: 33515 Summary: XSLT: Use GetCnumSearchURL utility template in other places Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Bug 29185 adds this new template (XSLT function) to build a URL for a search on control number/organization code based on record control number subfields (often $w) like 765$w. We could use this logic in few more places in the OPAC/intranet XSLTs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 10:46:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 08:46:42 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-hysjaiHqkA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 10:46:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 08:46:44 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-6t2GTW3tGt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149588&action=edit Bug 29185: Facilitate searching for cnum Instead of typing the case sensitive Control-number each time. 4 strikes instead of 15 on your keyboard. Wow! Gain of 73%. Test plan: Copy ccl.properties to /etc/koha/zebradb, restart Zebra and search for cnum=SOME_ID in opac or intranet. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 10:46:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 08:46:46 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-mcKHAr0jRF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149589&action=edit Bug 29185: Groundwork: add template GetCnumSearchURL in Utils Note for QA: Opened bug 33515 to see if we can use this same function in a few other places too. Would probably reduce code and increase consistency. Test plan: See next patch. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 10:46:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 08:46:49 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-YEg5PEMeSR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149590&action=edit Bug 29185: Display MARC tag 765 in OPAC and intranet XSLT Test plan: ** For OPAC [1] Pick a biblio record A as original entry, fill $001/$003. [2] Pick another biblio record B as translation, add 765 with $t, $a and $d. Put (orgcode)cnum from A into $w. [3] Disable UseControlNumber. [4] Goto OPAC detail page of B. Check link; should be title based. [5] Enable UseControlNumber. [6] Goto OPAC detail page of B. Check link; should incl orgcode and cnum. [7] Edit B. Replace $w with cnum of A only. [8] Goto OPAC detail page of B. Check link; should incl cnum only. ** For staff client [9] Goto staff detail page of B. Check link again. [10] Edit B. Set 765 ind2 to 8, fill $i. [11] Goto staff detail page of B. You should see different label. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 10:48:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 08:48:37 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-OSdmb0eyvm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #46 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- 1. Should we restrict access to the whole ERM module is vendor_manage is not set? 2. I can list agreements even if I have only erm_eholdings. It's confusing as we don't have access to "Licenses". 3. EBSCO Add to/Remove from holdings buttons should be removed with only erm_show 4. Same for "Add new agreement" on EBSCO pkg show view 5. I don't get an error when I access /cgi-bin/koha/erm/licenses/edit/1 with only erm_show (same for agreement) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 10:49:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 08:49:01 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-c6Ni9APSuh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Katrin: Please take a look at the logic in the second patch building a URL for control-number and corresponding identifier. Depends on UseControlNumber pref too. Additionally, it looks at the orgcode if present and narrows the search down to that orgcode too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 10:49:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 08:49:13 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-lwin6GXtbC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33515 [Bug 33515] XSLT: Use GetCnumSearchURL utility template in other places -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 10:49:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 08:49:13 +0000 Subject: [Koha-bugs] [Bug 33515] XSLT: Use GetCnumSearchURL utility template in other places In-Reply-To: <bug-33515-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33515-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33515-70-NhJtub7xsM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33515 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29185 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 [Bug 29185] Show MARC21 tag 765 - Original Language Entry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 10:49:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 08:49:47 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-uXI0j9QEiH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #47 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Note that you should certain rebase on top of bug 33483, here is how I fixed the conflict: 130 actions: { 131 0: ["show"], 132 ...((permissions.agreement.write || this.embedded) && { 133 "-1": this.embedded 134 ? [ 135 { 136 select: { 137 text: this.$__("Select"), 138 icon: "fa fa-check", 139 }, 140 }, 141 ] 142 : ["edit", "delete"], 143 }), 144 }, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 10:51:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 08:51:53 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-QndT4nNCK1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #48 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #46) > 5. I don't get an error when I access /cgi-bin/koha/erm/licenses/edit/1 with > only erm_show (same for agreement) Not sure we should consider this blocker, does not seem trivial to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 11:09:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 09:09:11 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-iaD3WiFXxp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Should not we add the original name in the description, so that the search will return the new one when then old one is searched for? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 11:30:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 09:30:12 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-2LsXse9FJ3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 Paul Derscheid <paul.derscheid at lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 11:30:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 09:30:15 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-HNMl71peXY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 --- Comment #34 from Paul Derscheid <paul.derscheid at lmscloud.de> --- Created attachment 149591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149591&action=edit Bug 32418: (follow-up) Remove jQuery, Fix typos in url, add biblio as template param To test: 1. Go to any record 2. Hit the edit button on an item in the holdings table 3. Modify the URL so that the query param for the itemnumber is either 3.1 empty: /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber= 3.2 an itemnumber that doesn't exist: /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=9999999999 3.3 whatever else you come up with.. 4. Check the same thing for the dupe option (op=dupeitem) 5. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 12:04:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 10:04:47 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-Cjqs6tUBe4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #13) > Should not we add the original name in the description, so that the search > will return the new one when then old one is searched for? Formerly known as... ? :) I am not sure to be honest. I hesitate as that will mean that we will probably never get rid of it and we might end up with a lot of those entries over time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 12:08:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 10:08:22 +0000 Subject: [Koha-bugs] [Bug 33273] There is no space between the words after ":" In-Reply-To: <bug-33273-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33273-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33273-70-PhoqYzY2wS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33273 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Igor, this looks like a translation issue. Translators have ommitted the ending space in some (but not all) versions: https://translate.koha-community.org/fr/translate/#search=ONLINE%20RESOURCES%3A&sfields=source,target&soptions=exact&unit=436557&offset=0 It needs to be fixed on translate.koha-community.org. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 12:21:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 10:21:10 +0000 Subject: [Koha-bugs] [Bug 33516] New: Accessibility: WCAG 1.4.1 - Content reflow Message-ID: <bug-33516-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33516 Bug ID: 33516 Summary: Accessibility: WCAG 1.4.1 - Content reflow Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org 1.4.10 Reflow: Content can be presented without loss of information or functionality, and without requiring scrolling in two dimensions for: (Level AA) ‱ Vertical scrolling content at a width equivalent to 320 CSS pixels; ‱ Horizontal scrolling content at a height equivalent to 256 CSS pixels. Except for parts of the content which require two-dimensional layout for usage or meaning. These 2 requirements are to be met simultaneously and are not independent of each other. A user should be able to increase the size of text to 200% even when the information is displayed on a narrow mobile phone screen. Alternatively, a user should be able to magnify the screen to 400% and increase the text size a further 200% Users with visual impairments often enlarge web content to make it easier to see. When content is enlarged to 400% zoom or viewed on a screen with a width of 320 CSS pixels, content should be presented to a user with no loss of information or functionality, and without requiring scrolling in two dimensions. The value of 320 CSS pixels was chosen as a reasonable minimum size that authors could achieve and also replicates the smaller screen sizes of common mobile devices. The width of 320 CSS pixels exactly corresponds to a desktop browser window set to a width of 1280px and zoomed in to 400%. FAIL: When the browser window is set to a width of 320px on the homepage, the horizontal scroll bar is displayed. FAIL: When the browser window is set to a width of 320px on the ‘Details for: Biblio title’ page, the horizontal scroll bar is displayed. Other pages may also be failing on this criteria.. To reach AA standard, we are required to rework these pages and how they reflow for such zoom levels/screen sizes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 12:23:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 10:23:12 +0000 Subject: [Koha-bugs] [Bug 33516] Accessibility: WCAG 1.4.1 - Content reflow In-Reply-To: <bug-33516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33516-70-A11c7bOZ7h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33516 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 13:38:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 11:38:06 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-z2V9JTHVul@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I fixed a problem with the dependent bug and forgot to rebase this one on top. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 13:49:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 11:49:29 +0000 Subject: [Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable In-Reply-To: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33154-70-oFEt9j8aR2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 13:49:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 11:49:31 +0000 Subject: [Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable In-Reply-To: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33154-70-1aSfZ00HqE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149326|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149592&action=edit Bug 33154: Tab WRAPPER follow-up: label text must be translatable This patch updates templates which have already been updated to use the new tab WRAPPER system for generating tab markup. Templates are changed so that tab label strings are wrapped in <span> to make them translatable. The html_helpers include file is also updated so that the example code in comments shows the right pattern (the breadcrumb example is similarly corrected). To test apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files for some of the lines modified in the patch: - koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:31 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:69 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt:330 - koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt:141 - koha-tmpl/intranet-tmpl/prog/en/modules/admin/item_circulation_alerts.tt:118 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:259 - koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt:455 - koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt:98 Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:07:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:07:52 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31695-70-EKX6DbmAWG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Kevin Carnes <kevin.carnes at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:29:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:29:26 +0000 Subject: [Koha-bugs] [Bug 33514] SearchWithIS[B|S]NVariations breaks ISBN search in item search In-Reply-To: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33514-70-RI8tbBUqmv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:36:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:36:09 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-9V6jroMfKx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149581|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149593&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:37:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:37:15 +0000 Subject: [Koha-bugs] [Bug 33517] New: Add support for extended attributes mapping on IdP config Message-ID: <bug-33517-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33517 Bug ID: 33517 Summary: Add support for extended attributes mapping on IdP config Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:37:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:37:18 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-OYom9kEuIF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148437|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149594&action=edit Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:37:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:37:20 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-RHdP3lxYUo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148438|0 |1 is obsolete| | --- Comment #13 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149595&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:37:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:37:21 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-pgzHJthKbx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148439|0 |1 is obsolete| | --- Comment #14 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149596&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:37:23 +0000 Subject: [Koha-bugs] [Bug 33517] Add support for extended attributes mapping on IdP config In-Reply-To: <bug-33517-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33517-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33517-70-agLbcqkjUK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33517 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Depends on| |31378 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 [Bug 31378] Add a generic OAuth2/OIDC client implementation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:37:23 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-CDJ6XtuLmJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149413|0 |1 is obsolete| | --- Comment #15 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149597&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. Sponsored-by: Colorado Library Consortium Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:37:23 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31378-70-Ib6mdZKupV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33517 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33517 [Bug 33517] Add support for extended attributes mapping on IdP config -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:37:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:37:25 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-6yXEQjiDVZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149593|0 |1 is obsolete| | --- Comment #16 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149598&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:38:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:38:10 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-uGBDN9YbFh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Love the way the new setup looks for the notice management page! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:39:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:39:22 +0000 Subject: [Koha-bugs] [Bug 33518] New: Inconsistent breadcrumbs in IdP pages Message-ID: <bug-33518-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33518 Bug ID: 33518 Summary: Inconsistent breadcrumbs in IdP pages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org There's no mention to the particular IdP you are editing or you are adding domains to, so you need to start from scratch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:39:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:39:33 +0000 Subject: [Koha-bugs] [Bug 33518] Inconsistent breadcrumbs in IdP pages In-Reply-To: <bug-33518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33518-70-4NaQ6Gth3S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33518 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31378 CC| |tomascohen at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 [Bug 31378] Add a generic OAuth2/OIDC client implementation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:39:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:39:33 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31378-70-2L2GIxUDIS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33518 [Bug 33518] Inconsistent breadcrumbs in IdP pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:43:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:43:45 +0000 Subject: [Koha-bugs] [Bug 11585] pubdate index not working well in UNIMARC In-Reply-To: <bug-11585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11585-70-z0Zmogw0po@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11585 Anke Bruns <anke.bruns at gwdg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anke.bruns at gwdg.de --- Comment #1 from Anke Bruns <anke.bruns at gwdg.de> --- In 22.05, the pubdate index works well if searched for one year only (e.g. 1999). However, searching for a date range, as suggested in the pulldown menu, doesn't yield anything at all. Thus, "1999-2002" or "1999 - 2002" return 0 results, even though there are records with pubdates 1999, 2002 and the years in between, that can be retrieved by searching for one single year as mentioned above. How can this be fixed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:52:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:52:00 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-svgUnaIDsx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Laura Escamilla <Laura.escamilla at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #7 from Laura Escamilla <Laura.escamilla at bywatersolutions.com> --- Thank you for taking the time to look at this! You're right, I do need to make some changes to my Dev environment config. I'll work on that and rebase the patches. We should do the same for the holding library. Do you suggest that we include this in the same bug or open a new bug for this? (In reply to Katrin Fischer from comment #6) > Hi Laura, > > I fully agree with this change. Some small things: > > 1) Please take a look at your dev environment configuration, you probably > missed setting the variables in .env. The patches were written by: > From: John Doe <you at example.com> > > 2) Should we not do the same for holding library? > > ... I can't finish here right now because I have some trouble with Selenium > tonight. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 14:58:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 12:58:26 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-Pz3Ql9LwVC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think combining both here would make sense. We can also write up some nice release notes to highlight the change in one place then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:02:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:02:05 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33388-70-tEKYawKnJd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Andrew Auld from comment #4) > Patron details link not working: > /members/moremember.pl?borrowernumber=# This looks to me like it is working. Could you re-test? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:02:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:02:14 +0000 Subject: [Koha-bugs] [Bug 33519] New: Update description of ILS-DI:AuthorizedIPs Message-ID: <bug-33519-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33519 Bug ID: 33519 Summary: Update description of ILS-DI:AuthorizedIPs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com After bug 24537, "we can use addresses in a variety of formats [in ILS-DI:AuthorizedIPs]. This includes 127.0.0.1, 192.168.1.0/24, 10.0.0, and so on." It would be nice if this was reflected in the description of the syspref. This syspref used to take a plain list of IPs, so if you missed it in the release notes, there is no hint that the functionality has been changed/enhanced. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:04:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:04:19 +0000 Subject: [Koha-bugs] [Bug 33167] Bibs with several hundred items causes a slow loading screen In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-yG1kDcf3uw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to David Nind from comment #13) > I'm not sure what is required to test this one - apply the patch, and repeat > the tests for bug 33493 and 33497? This one shouldn't cause any visible changes to the detail page - best test plan would be to add items with varying statuses: lost damage withdrawn in transit checked out to a record, and confirm the page looks the same before and after -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:05:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:05:22 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-ESkafUjYvx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26802 Summary|Bibs with several hundred |Cleanup staff record |items causes a slow loading |details page |screen | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802 [Bug 26802] Improve speed with records with many items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:05:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:05:22 +0000 Subject: [Koha-bugs] [Bug 26802] Improve speed with records with many items In-Reply-To: <bug-26802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26802-70-bx05zcPFAp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 [Bug 33167] Cleanup staff record details page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:11:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:11:02 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-s6RZfMz770@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:18:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:18:37 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-laWDedjf6l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 --- Comment #15 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- AFAIK, there is no precedent for this... gist -> TaxRates, gist is not mentioned in the description NotesBlacklist -> NotesToHide, no mention RequestOnOpac -> OPACHoldRequests, no mention etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:19:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:19:27 +0000 Subject: [Koha-bugs] [Bug 32542] Coce images not appearing in staff client In-Reply-To: <bug-32542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32542-70-cYarr2FRzf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 pierre.genty at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:24:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:24:22 +0000 Subject: [Koha-bugs] [Bug 33520] New: Update Patron Details link alignment Message-ID: <bug-33520-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33520 Bug ID: 33520 Summary: Update Patron Details link alignment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.auld at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 149599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149599&action=edit Image showing alignment issue The link to the 'Patron Details' view in the 'Update Patron Records' page is out of alignment with the rest of the text on that row and the spacing is off. /members/members-update.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:25:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:25:04 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33388-70-Yts8agUeYb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149275|0 |1 is obsolete| | --- Comment #6 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 149600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149600&action=edit Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 This patch updates several patron templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Patrons -> - Patron details - Notices - Accounting - Edit patron - Add patron - Patrons requesting modification (submit patron update via the OPAC) Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:26:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:26:22 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33388-70-prhtg39Kg6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 Andrew Auld <andrew.auld at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Andrew Auld <andrew.auld at ptfs-europe.com> --- This is now signed off. However I did spot an alignment issue on the Update Patron Records page for which I have created a new bug number #33520. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:26:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:26:56 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33388-70-ISyaZ68OxA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 --- Comment #8 from Andrew Auld <andrew.auld at ptfs-europe.com> --- https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:34:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:34:40 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: <bug-31694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31694-70-Ixqo7XeCtZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #15 from Kevin Carnes <kevin.carnes at ub.lu.se> --- Created attachment 149601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149601&action=edit Bug 31694: (follow-up) Use values for operations to avoid translation issues To test: * Try adding a preset rule that has an operation with different translations for the column and the pull down (e.g. Outrepasser for fr-CA) * Without the patch it appears as Custom (e.g. PersonnalisĂ©) * With then patch it appears correctly (e.g. Outrepasser) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:37:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:37:27 +0000 Subject: [Koha-bugs] [Bug 31694] MARC overlay rules presets don't change anything if presets are translated In-Reply-To: <bug-31694-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31694-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31694-70-AQ01rvPNze@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Kevin Carnes <kevin.carnes at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149601|0 |1 is obsolete| | --- Comment #16 from Kevin Carnes <kevin.carnes at ub.lu.se> --- Created attachment 149602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149602&action=edit Bug 31694: (follow-up) Use values for operations to avoid translation issues To test: * Try adding a preset rule that has an operation with different translations for the column and the pull down (e.g. Outrepasser for fr-CA) * Without the patch it appears as Custom (e.g. PersonnalisĂ©) * With the patch it appears correctly (e.g. Outrepasser) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:40:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:40:26 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-ihI4xlUAYD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149603&action=edit Bug 33490: Unit tests This patch adds cypress tests for the filter by expired functionality in the ERM Agreements page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:40:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:40:29 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-2GYpMvNoWx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149523|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149604&action=edit Bug 33490: Prevent 400 on agreements?by_expired=true We need to update the filter THEN update the current route Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:40:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:40:34 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-ey50mETc5x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149580|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 149605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149605&action=edit Bug 33512: Change text and add button classes on serial-edit page To test: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. 8. Apply patch. 9. Try 6 & 7 again. The existing items should now read 'Click to edit item' Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:41:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:41:04 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-COYpjACrab@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Andrew Auld <andrew.auld at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld at ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Lovely...much less confusing now. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:47:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:47:58 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-YKB00bVO87@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- OK, that was a nice distraction for a few hours and I feel like I've wrapped my brain around Cypress testing much better now. I've added tests that I believe catch this particular issue, though I'd love a review if anyone fancies it. * I test for the existence of the filter options when there are any agreements in the system. * I then test for the default date of today being filled after filtering when the 'Filter by expired' checkbox is checked. * This tests: a) that the xhr includes the correct max_expiration_date b) that the window url is updated to reflect the filtering c) the input box value is set and displayed * We then reload the page using the url as defined in step b) above and test that the xhr and input box value get correctly filled again * We then add a user selected date in the input box and check a) that the xhr includes the new correct max_expiration_date b) the window url is updated to reflect the filtering (including the new date) c) the input box value is set and displaying the new date too * Finally, we reload the page again in b) above and confirm all the changes stuck. I added a note that we should also really be testing the other filter too.. but I felt that was out of scope for this particular patch (and I was running low on tuits) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:48:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:48:38 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-5u7qUF2iMf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- PS.. I'm happy to PQA on the bug as a whole if someone wants to just feedback/verify my cypress test addition here is sane. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:49:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:49:03 +0000 Subject: [Koha-bugs] [Bug 33521] New: Column item_priority in OPAC holdingst can never show Message-ID: <bug-33521-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33521 Bug ID: 33521 Summary: Column item_priority in OPAC holdingst can never show Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I was trying to document what all the columns in Administration > Table settings > OPAC > holdingst were exactly and I'm having trouble with item_priority. Katrin looked at the opac-details.tt template and said there was a logic error. To test: 1. Change OPACShowHoldQueueDetails to show holds and priority levels 2. Place an item-level hold on an item 3. In the OPAC, log in as the user with the hold 4. Go to the bibliographic record --> In the holdings table, there is an "Item holds" column with hold AND priority information but no Item hold priority column I wonder if the column is useful at all... I don't mind having both information in the same column. But I would only show the item holds column if there is an item-level hold. Right now it shows if there is any hold, even just a record-level hold, and I find it confusing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:49:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:49:39 +0000 Subject: [Koha-bugs] [Bug 33521] Column item_priority in OPAC holdingst can never show In-Reply-To: <bug-33521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33521-70-IYpF5EG9LT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33521 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Line https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt#L1208 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:56:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:56:39 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-YcEjClpVE2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Hmmm.. I'd love to see some tests around this whole area... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:57:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:57:31 +0000 Subject: [Koha-bugs] [Bug 33522] New: Optionally skip inactive patrons when sending membership expiry notices Message-ID: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 Bug ID: 33522 Summary: Optionally skip inactive patrons when sending membership expiry notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Could we use the patron->is_active method here? See bug 33245 (wip). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:57:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:57:49 +0000 Subject: [Koha-bugs] [Bug 33522] Optionally skip inactive patrons when sending membership expiry notices In-Reply-To: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33522-70-6k55qkiMqs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 [Bug 33245] Add $patron->is_active -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 15:57:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 13:57:49 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33245-70-QfxWaTfWaz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33522 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 [Bug 33522] Optionally skip inactive patrons when sending membership expiry notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:00:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:00:05 +0000 Subject: [Koha-bugs] [Bug 33245] Add $patron->is_active In-Reply-To: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33245-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33245-70-iheqO19gEh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Still have some code for this in the pipeline. Coming up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:10:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:10:16 +0000 Subject: [Koha-bugs] [Bug 27992] When recording local use with statistical patron items are not checked in In-Reply-To: <bug-27992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27992-70-eUTOmgvAsZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #18 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- It sounds like the plan to (1) respect BlockReturnOfLostItems, (2) ask for confirmation when recording local use on a lost item if it is not blocked, and (3) resolve any return claims on the item, addresses all the concerns that have been raised. For #2, I feel like it could also make sense to follow the setting for IssueLostItem instead of requiring confirmation no matter what, but I'm not sure I have strong reasons for insisting on it if there are objections/downsides. Anything else that needs to be resolved before we can move forward with this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:14:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:14:30 +0000 Subject: [Koha-bugs] [Bug 33523] New: Hold Queue targets items on record level holds that should not fill the hold Message-ID: <bug-33523-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33523 Bug ID: 33523 Summary: Hold Queue targets items on record level holds that should not fill the hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Holds queue doesn't check if a branch's item can fill the hold if at least one item is available on the record for a bib level hold To recreate: ‱ Have ReservesControlBranch set to "item's home library" ‱ Have at least 2 libraries. ‱ Set the circulation rules so that a patron type can place holds on an item type at library A ‱ Set the circulation rules so that the same patron type cannot place holds on or have any checkouts on the same item type at library B ‱ Make a record with at least 2 items, one at library A and one at library B. ‱ Place a bib level hold for a patron matching the patron type in the rules ‱ Run holds to pull for both branches ‱ The item should only show on Library A's list, but it also shows on library B. Library B doesn't allow checkout of those items for that patron type. The same thing also happens if there are separate item types on the same record, such as a public copy and a staff copy. The staff copy will try to fill the hold even though it can only be held and loaned by staff. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:17:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:17:51 +0000 Subject: [Koha-bugs] [Bug 33517] Add support for extended attributes mapping on IdP config In-Reply-To: <bug-33517-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33517-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33517-70-Pk8CfoPfid@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33517 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:18:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:18:43 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-u2OX66dpqs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Martin Renvoize from comment #21) > Hmmm.. I'd love to see some tests around this whole area... See bug 33492. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:30:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:30:22 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-7FBLj9G8NM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I've noticed when reading the tests that something is not totally correct. + cy.url().should('include', "/cgi-bin/koha/erm/agreements?by_expired=true"); // Browser url also updated It should contain max_expiration_date here. The problem is the following: Go to /cgi-bin/koha/erm/agreements Tick "Filter by expired" Click "Filter" New route is "/cgi-bin/koha/erm/agreements?by_expired=true" Input date is filled with today Click "Filter" again New route is "/cgi-bin/koha/erm/agreements?by_expired=true&max_expiration_date=2023-04-13" The date should be in the URL directly. Anybody who'd take a look at it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:18 +0000 Subject: [Koha-bugs] [Bug 32998] Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib In-Reply-To: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32998-70-he1UWoZLD7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32998 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:19 +0000 Subject: [Koha-bugs] [Bug 32998] Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib In-Reply-To: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32998-70-uUiyOwTG0H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32998 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:21 +0000 Subject: [Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable In-Reply-To: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33154-70-JDW9xQdzuY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:23 +0000 Subject: [Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable In-Reply-To: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33154-70-Zyimu1c8Zk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:25 +0000 Subject: [Koha-bugs] [Bug 29716] [DOCS] Automated screenshots using Cypress.io testing framework In-Reply-To: <bug-29716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29716-70-F7ffrAVTRP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29716 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:25 +0000 Subject: [Koha-bugs] [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details In-Reply-To: <bug-33185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33185-70-lJefbS6jQi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:27 +0000 Subject: [Koha-bugs] [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details In-Reply-To: <bug-33185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33185-70-IF056youYm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:29 +0000 Subject: [Koha-bugs] [Bug 33186] Use template wrapper for tabs on search history and advanced search In-Reply-To: <bug-33186-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33186-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33186-70-QXXhOyYjJ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:30 +0000 Subject: [Koha-bugs] [Bug 33186] Use template wrapper for tabs on search history and advanced search In-Reply-To: <bug-33186-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33186-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33186-70-kBc99tsdJj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:32 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-0hu3amXmDt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:34 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-SXsTFHJzxr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 --- Comment #10 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:36 +0000 Subject: [Koha-bugs] [Bug 33293] Use template wrapper for tabs: Holds In-Reply-To: <bug-33293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33293-70-7crTsQMBOU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:37 +0000 Subject: [Koha-bugs] [Bug 33293] Use template wrapper for tabs: Holds In-Reply-To: <bug-33293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33293-70-ZJWfHtlqQn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:39 +0000 Subject: [Koha-bugs] [Bug 33294] Use template wrapper for tabs: Checkout history In-Reply-To: <bug-33294-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33294-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33294-70-NFbYFUk5eW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33294 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:41 +0000 Subject: [Koha-bugs] [Bug 33294] Use template wrapper for tabs: Checkout history In-Reply-To: <bug-33294-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33294-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33294-70-FARlQw8UWj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33294 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:43 +0000 Subject: [Koha-bugs] [Bug 33307] Use template wrapper for tabs: Lists In-Reply-To: <bug-33307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33307-70-mPOJaVeFAi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33307 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:44 +0000 Subject: [Koha-bugs] [Bug 33307] Use template wrapper for tabs: Lists In-Reply-To: <bug-33307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33307-70-8vVZxmT0CA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33307 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:46 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-Ylxl77Bxpu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:48 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-8HuO9ocjm7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 --- Comment #20 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:50 +0000 Subject: [Koha-bugs] [Bug 33336] Use a dedicated column for plugin status in plugins table In-Reply-To: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33336-70-mnE0LM9Pdc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:52 +0000 Subject: [Koha-bugs] [Bug 33336] Use a dedicated column for plugin status in plugins table In-Reply-To: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33336-70-j7CEjvxF0Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:54 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-nqya40mOnr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:56 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-5gl7UzHlh3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 --- Comment #40 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:49:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:49:58 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-S4S0So5ZmR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:50:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:50:00 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-qVghvFrdST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 --- Comment #7 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:50:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:50:02 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-D7sh8VacrY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:50:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:50:04 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-UhoDmzafhG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 --- Comment #3 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:52:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:52:13 +0000 Subject: [Koha-bugs] [Bug 33524] New: Use template wrapper for tabs: Authority editor Message-ID: <bug-33524-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33524 Bug ID: 33524 Summary: Use template wrapper for tabs: Authority editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, I would like to update the authority editor in the staff client to use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:52:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:52:13 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32571-70-upyqHSe5W1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33524 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33524 [Bug 33524] Use template wrapper for tabs: Authority editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:52:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:52:55 +0000 Subject: [Koha-bugs] [Bug 33525] New: Use template wrapper for tabs: Basic MARC editor Message-ID: <bug-33525-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 Bug ID: 33525 Summary: Use template wrapper for tabs: Basic MARC editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, I would like to update the basic MARC (bibliographic record) editor in the staff client to use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:52:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:52:55 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32571-70-9hVpCj3gR9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33525 [Bug 33525] Use template wrapper for tabs: Basic MARC editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:54:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:54:07 +0000 Subject: [Koha-bugs] [Bug 33526] New: Use template wrapper for tabs: Bibliographic detail page Message-ID: <bug-33526-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 Bug ID: 33526 Summary: Use template wrapper for tabs: Bibliographic detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, I would like to update the bibliographic detail page in the staff client to use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:54:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:54:07 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32571-70-H5cGMcdA7F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 [Bug 33526] Use template wrapper for tabs: Bibliographic detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:55:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:55:55 +0000 Subject: [Koha-bugs] [Bug 33527] New: Use template wrapper for tabs: Checkout page Message-ID: <bug-33527-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33527 Bug ID: 33527 Summary: Use template wrapper for tabs: Checkout page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, I would like to update the checkout page in the staff client to use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:55:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:55:55 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32571-70-igNyXqNbCX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33527 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33527 [Bug 33527] Use template wrapper for tabs: Checkout page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:56:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:56:21 +0000 Subject: [Koha-bugs] [Bug 33528] New: Use template wrapper for tabs: Patron details page Message-ID: <bug-33528-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 Bug ID: 33528 Summary: Use template wrapper for tabs: Patron details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, I would like to update the patron details page in the staff client to use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 16:56:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 14:56:21 +0000 Subject: [Koha-bugs] [Bug 32571] Use template wrapper to build tabbed components In-Reply-To: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32571-70-INuxy0VdDM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33528 [Bug 33528] Use template wrapper for tabs: Patron details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 17:06:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 15:06:18 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-WkEM8y1IqU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149488|0 |1 is obsolete| | Attachment #149489|0 |1 is obsolete| | Attachment #149490|0 |1 is obsolete| | Attachment #149491|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149606&action=edit Bug 33103: Display the aliases in the dropdown list in ERM Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 17:06:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 15:06:21 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-VanNISKr6j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 --- Comment #54 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149607&action=edit Bug 33103: Deal with html tags HTML tags won't be interpreted. However <script> will still break the display, but it's by nature, JS will execute it even if it's in a string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 17:06:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 15:06:24 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-D0zx8UsUmL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 --- Comment #55 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149608&action=edit Bug 33103: Fix accessibility issues * Add spaces * Add 'Add' and 'Remove' in addition of the icons * Do not submit the form when enter is hit * Fix translatability Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 17:06:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 15:06:28 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-wyYIvw15Dn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 --- Comment #56 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149609&action=edit Bug 33103: Prevent vendors to be displayed several times in the search result Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 17:17:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 15:17:48 +0000 Subject: [Koha-bugs] [Bug 33523] Hold Queue & Holds to pull targets items on record level holds that should not fill the hold In-Reply-To: <bug-33523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33523-70-mXaNxqDvaF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33523 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hold Queue targets items on |Hold Queue & Holds to pull |record level holds that |targets items on record |should not fill the hold |level holds that should not | |fill the hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 17:42:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 15:42:32 +0000 Subject: [Koha-bugs] [Bug 33529] New: Increase flexibility of action buttons in tables Message-ID: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 Bug ID: 33529 Summary: Increase flexibility of action buttons in tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: matt.blenkinsop at ptfs-europe.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com In the usage statistics modules there is a need for some additional "action" buttons on top of the standard "edit" and "delete" (e.g. "Download" or "Run now"). This bug changes the way the action buttons are passed to the new KohaTable component so that extra customisation can be added where needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 17:42:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 15:42:46 +0000 Subject: [Koha-bugs] [Bug 33529] Increase flexibility of action buttons in tables In-Reply-To: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33529-70-E9OiUymwt1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33066 Assignee|jonathan.druart+koha at gmail. |matt.blenkinsop at ptfs-europe |com |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 [Bug 33066] We need a KohaTable Vue component -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 17:42:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 15:42:46 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-fIJZnaIsdN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 [Bug 33529] Increase flexibility of action buttons in tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 17:50:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 15:50:33 +0000 Subject: [Koha-bugs] [Bug 33529] Increase flexibility of action buttons in tables In-Reply-To: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33529-70-flEa6AS4eZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 17:50:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 15:50:35 +0000 Subject: [Koha-bugs] [Bug 33529] Increase flexibility of action buttons in tables In-Reply-To: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33529-70-avpUxoCcJJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149610&action=edit Bug 33529: Update KohaTable to accept customised buttons This patch updates the KohaTable component to accept action buttons as objects rather than as hard coded strings. This allows buttons to be customised for different use cases Test plan: 1) Apply patch 2) Run yarn build 3) Navigate to Agreements - add an agreement if the table is empty 4) Test the buttons for editing and deleting agreements in the "Actions" column 5) Repeat for licenses 6) Repeat for local packages 7) Repeat for local titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 17:50:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 15:50:37 +0000 Subject: [Koha-bugs] [Bug 33529] Increase flexibility of action buttons in tables In-Reply-To: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33529-70-sZgsoIvkwg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149611&action=edit Bug 33529: Update action buttons in list components This patch updates the inputs in the different list components Test plan as above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 17:59:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 15:59:59 +0000 Subject: [Koha-bugs] [Bug 33529] Increase flexibility of action buttons in Vue Kohatables In-Reply-To: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33529-70-PbFVuiFsUa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Increase flexibility of |Increase flexibility of |action buttons in tables |action buttons in Vue | |Kohatables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 18:00:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 16:00:47 +0000 Subject: [Koha-bugs] [Bug 33530] New: Add a 'filter' to public lists to aid retrieval of a list Message-ID: <bug-33530-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33530 Bug ID: 33530 Summary: Add a 'filter' to public lists to aid retrieval of a list Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: helm.consortium at nhs.net QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 18:02:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 16:02:58 +0000 Subject: [Koha-bugs] [Bug 33530] Add a 'filter' to public lists to aid retrieval of a list In-Reply-To: <bug-33530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33530-70-YqGUbTjCgP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33530 helm.consortium at nhs.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |helm.consortium at nhs.net --- Comment #1 from helm.consortium at nhs.net --- When there are numerous public lists on the OPAC, a way of filtering to the list you need would be very helpful for both staff and public users. Otherwise you are simply scrolling through page after page of lists trying to identify the one you need. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 18:06:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 16:06:59 +0000 Subject: [Koha-bugs] [Bug 33303] Performance issues/timeouts in item search In-Reply-To: <bug-33303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33303-70-pJgJDzuY6q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33303 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Performance issues/timeouts |Performance issues/timeouts |when using |in item search |more_subfields_xml in item | |search | --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It looks like there is a general issue with item search being very slow in some cases. One issue is left truncation of search terms. The example is an ISBN search. Multiple ISBN are stored in biblioitems.isbn | separated with additional ISBD punctuation. So you'll need to truncate left and right to make sure you get correct results. Left truncation creates an issue as we assume the index on the field cannot be used in this case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 18:16:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 16:16:51 +0000 Subject: [Koha-bugs] [Bug 20644] Per itemtype setting for CheckPrevCheckout In-Reply-To: <bug-20644-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20644-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20644-70-Wkl1r2Lfdu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Is this still valid after bug 16284? The need is specifically for serials, and that is covered in bug 16284. Would a library want to control CheckPrevCheckout per itemtype for other types of materials? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 18:30:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 16:30:29 +0000 Subject: [Koha-bugs] [Bug 33231] (Bug 30813 follow-up) No publication date nor edition statements in Z39.50 biblio search results In-Reply-To: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33231-70-Gu5mwu8KRQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 18:30:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 16:30:31 +0000 Subject: [Koha-bugs] [Bug 33231] (Bug 30813 follow-up) No publication date nor edition statements in Z39.50 biblio search results In-Reply-To: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33231-70-Q8yP5zwN1N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149612&action=edit Bug 33231: (Bug 30813 follow-up) No publication date nor edition statements in Z39.50 biblio search results After executing Z39.50 search, the result table is not populated with publication dates. This is the result of code refactoring made by Bug 30813. The removed function _add_rowdata treated in special way the publication date putting it in $row in under special, non MARC variant dependent key 'date'--since the z3950_search.tt looks under breeding_loo.date. Same effect (no data in the result table) with edition statement. Reason: editionstatement coming from TransformMarcToKoha vs edition expected by z3950_search.tt. Test plan: ========== 1. Have a Koha instance with some Z39.50 servers defined. 2. In Cataloging, perform a Z39.50 search for any term. 3. In the result table you would not get the publication dates nor edition statement (if present in the record). 4. Apply the patch. 5. Repeat the search. 6. You should see the publication dates (according to the current mapping, i.e. for MARC 21 coming from 260 $c or 264 $c subfield) and edition statements from the records found. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 18:30:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 16:30:33 +0000 Subject: [Koha-bugs] [Bug 33231] (Bug 30813 follow-up) No publication date nor edition statements in Z39.50 biblio search results In-Reply-To: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33231-70-0NdXR6v2Bh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149613&action=edit Bug 33231: (QA follow-up) Simplify conditional for date display This patch simply checks if we have a value for copyrighydate and displays publicationyear if not. Even if copyrightdate is requested (MARC21) but isn't populated, the publicatoinyear won't replace it because we haven't transformed that field. I think this read a bit easier, but RM can weigh in Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 18:57:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 16:57:33 +0000 Subject: [Koha-bugs] [Bug 33310] Use template wrapper for tabs: Suggestions In-Reply-To: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33310-70-K3uDsNW4RE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33310 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 18:57:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 16:57:35 +0000 Subject: [Koha-bugs] [Bug 33310] Use template wrapper for tabs: Suggestions In-Reply-To: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33310-70-FTuanCmRM1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33310 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148783|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149614&action=edit Bug 33310: Use template wrapper for tabs: Suggestions This patch updates the suggestions template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and go to the suggestions page in the staff interface. - By default you suggestions should be organized by status, with a separate tab for each status (pending, accepted, etc). - Use the "Organize by" form in the sidebar to change how suggestions are listed. In each case confirm that the tabs are redisplayed correctly. Works as advertised. 3/3 Signed-off-by: Paul Derscheid <paul.derscheid at lmscloud.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 19:13:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 17:13:47 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-OXZAl2jiLu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149615&action=edit Bug 33490: Make url consistent This ensures we populate the max_expiration_date param on the browser url for consistency with selected dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 19:14:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 17:14:53 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-SI8F1yIZBx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- That last patch does the trick, but I don't like it.. we're repeating code with it.. but for the life of me I couldn't work out where to move it to get it to work for both cases. Remaining Failed QA seeking more eyes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 19:22:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 17:22:05 +0000 Subject: [Koha-bugs] [Bug 33531] New: Item Search: Use modalselect or similar for user friendly selection of options Message-ID: <bug-33531-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33531 Bug ID: 33531 Summary: Item Search: Use modalselect or similar for user friendly selection of options Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org On itemsearch.pl it would be great if modalselect, or something similar, could be used like in the system preferences to allow easier selection of options, especially for multibranch systems and systems with lots of item types or collection codes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 19:26:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 17:26:50 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-AxeGHwc3ov@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 19:26:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 17:26:53 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-8QJnZ9ntyg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149575|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 149616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149616&action=edit Bug 33509: Don't show Other holdings when there are no alternate holdings With bug 33509 alternate holdings defined in AlternateHoldingsField are shown in the staff interface result list. This works greatly when there are items or when there is are alternate holdings (the configured field/subfields exist in the record), but not when there are no items and no alternate holdings. To test: * Add 100a to AlternateHoldingsField * Make a search with some records without items Sample data: perl * Make sure the alternate holdings show when there are no items and 100a exists * Change to 100z * Verify the result list now shows "Other holdings:" with nothing below * Apply patch * Repeat * Alternate holdings should still show nicely * Without alternate holdings 'no items' is displayed Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 19:34:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 17:34:12 +0000 Subject: [Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType In-Reply-To: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33176-70-Hj2ZL29n2J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 19:34:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 17:34:14 +0000 Subject: [Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType In-Reply-To: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33176-70-DkenGgjiNP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149617&action=edit Bug 33176: Handle RequirePaymentType Test plan: 1. Turn on RequirePaymentType 2. Create a manual invocie on a patron account 3. Go to pay it, 'Payment type:' is marked as required. 4. In the inscept the select input ( #payment_type ) with your browser's dev tools. Removed the required attribute. 5. You are able to make the payment without a payment type. 6. Apply patch and restart_all 7. Try 4-5 again. This time you should get a 500 error and the payment should not go through. 8. Turn RequirePaymentType off. Try a payment with a payment type, you shoud be successful. 9. Make sure tests will pass: prove -v t/db_dependent/Koha/Account.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 19:41:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 17:41:28 +0000 Subject: [Koha-bugs] [Bug 33310] Use template wrapper for tabs: Suggestions In-Reply-To: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33310-70-OfaPHnDFKS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33310 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149614|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149618&action=edit Bug 33310: Use template wrapper for tabs: Suggestions This patch updates the suggestions template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and go to the suggestions page in the staff interface. - By default you suggestions should be organized by status, with a separate tab for each status (pending, accepted, etc). - Use the "Organize by" form in the sidebar to change how suggestions are listed. In each case confirm that the tabs are redisplayed correctly. Works as advertised. 3/3 Signed-off-by: Paul Derscheid <paul.derscheid at lmscloud.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 19:53:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 17:53:28 +0000 Subject: [Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType In-Reply-To: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33176-70-QAOlxb6tSH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149619&action=edit Bug 33176: Enforce RequirePaymentType with API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 19:54:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 17:54:47 +0000 Subject: [Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType In-Reply-To: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33176-70-8HDZK03f0I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:18:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:18:03 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-VnG0t1x36n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:18:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:18:05 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-CyBdVYY8rQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149577|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 149620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149620&action=edit Bug 33506: Fix false index for series and keep selected index on scan index page The pull down with search options had the wrong index linked to the Series entry: su instead of se To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Verify search results link to authors using c * Switch to series * Verify search results use 'su' for subject * Verify that search option pull down always jumps back to first entry: Any word * Apply patch * Verify the search results for series now use correct index se * Verify that coming from advanced search, the correct search option is selected * Verify that changing the search option also keeps the selection after searching Note: with Elasticsearch and default configuration author, title and series will give you results. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:19:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:19:09 +0000 Subject: [Koha-bugs] [Bug 33529] Increase flexibility of action buttons in Vue Kohatables In-Reply-To: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33529-70-K4Rkawyg27@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I think this is done in https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149566 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:22:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:22:48 +0000 Subject: [Koha-bugs] [Bug 33532] New: Catalog concerns - Title of the page says Tools instead of Cataloging Message-ID: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 Bug ID: 33532 Summary: Catalog concerns - Title of the page says Tools instead of Cataloging Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Very minor, but the title of the page of the Catalog concerns management page, which appears in the browser tab, says Catalog concerns > **Tools** > Koha. But the page is under Cataloging, not Tools. To reproduce: 1. Enable the CatalogConcerns system preference 2. Go to Cataloging > Catalog concerns --> The title of the page in the browser tab says Tools -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:23:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:23:04 +0000 Subject: [Koha-bugs] [Bug 33532] Catalog concerns - Title of the page says Tools instead of Cataloging In-Reply-To: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33532-70-DhRKXxpFGh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31028 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:23:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:23:04 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-8NadRopx43@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 [Bug 33532] Catalog concerns - Title of the page says Tools instead of Cataloging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:23:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:23:53 +0000 Subject: [Koha-bugs] [Bug 33327] Catalog concerns - Hide resolved catalog concerns by default In-Reply-To: <bug-33327-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33327-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33327-70-Nl6b0QlkKe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33327 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hide resolved catalog |Catalog concerns - Hide |concerns by default |resolved catalog concerns | |by default -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:25:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:25:36 +0000 Subject: [Koha-bugs] [Bug 33158] Use template wrapper for authorized values and item types administration tabs In-Reply-To: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33158-70-SB1rRH5YK1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:25:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:25:38 +0000 Subject: [Koha-bugs] [Bug 33158] Use template wrapper for authorized values and item types administration tabs In-Reply-To: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33158-70-UPP6dMufcR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147854|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149621&action=edit Bug 33158: Use template wrapper for authorized values and item types administration tabs This patch updates the authorized values and item types administration templates so that they use the new WRAPPER directive to build tabbed navigation. Seeing that the markup in itemtypes.tt and authorised_values.tt is indential when it comes to icon selection, I have moved that section of the template into an include file and updated both templates to use it. The patch also makes minor SCSS changes, so to test you must rebuild the staff interface CSS. To test, apply the patch and go to Administration -> Item types. - Edit an item type. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that if you specify a remote image (e.g.https://via.placeholder.com/50/FF0000/FFFFFF.png) the tab is correctly shown after you save and re-edit. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit view. Perform the same tests in Administration -> Authorized values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:27:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:27:33 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-cagZnFzAYX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. One thing I noted (not related to this bug) is that: - when using Zebra, only 20 results are displayed - it looks to me like the pagination of search results is missing - when using Elasticsearch, there is pagination at the bottom (like the normal staff interface catalog search results) 2. Also not related to this bug, the results pages need the page section added (bug 31757). I'm happy to add the bugs for these if they don't exist already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:50:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:50:17 +0000 Subject: [Koha-bugs] [Bug 33533] New: Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt Message-ID: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Bug ID: 33533 Summary: Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr In memberentrygen.tt, there is a condition to show either "Patron identity" or "Organization identity" in the patron form. These three words, "Patron", "Organization", and "identity" were separated in different spans. However, in French at least, we have to invert the order of the words otherwise it doesn't make sense. So "Patron identity" becomes "IdentitĂ© de l'utilisateur" ("Identity of patron"). Right now, it is translated as "Utilisateur identitĂ©" which doesn't mean anything and looks like it was translated directly from English :) This whole condition should be kept together, with %s to separate the elements so that we can move them around. <legend id="identity_lgd">[% IF ( I ) %]<span>Organization</span> [% ELSE %]<span>Patron</span> [% END %]<span>identity</span></legend> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:57:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:57:00 +0000 Subject: [Koha-bugs] [Bug 33532] Catalog concerns - Title of the page says Tools instead of Cataloging In-Reply-To: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33532-70-HHadnBixjn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:57:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:57:02 +0000 Subject: [Koha-bugs] [Bug 33532] Catalog concerns - Title of the page says Tools instead of Cataloging In-Reply-To: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33532-70-QeW3v2IIRB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 --- Comment #1 from David Nind <david at davidnind.com> --- Created attachment 149622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149622&action=edit Bug 33532: Fix HTML page title for cataloging concerns page The HTML title of the Catalog concerns management page (which appears in the browser tab) says Catalog concerns > Tools > Koha. But the page is under Cataloging, not Tools. Test plan: 1. Enable the CatalogConcerns system preference. 2. Go to Cataloging > Catalog concerns: => The title of the page in the browser tab says Catalog concerns > Tools > Koha 3. Apply the patch. 4. Refresh the catalog concerns page. 5. The title of the page in the browser tab should now say Catalog concerns > Cataloging > Koha 6. Sign off 8-) Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 20:59:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 18:59:07 +0000 Subject: [Koha-bugs] [Bug 33532] Catalog concerns - Title of the page says Tools instead of Cataloging In-Reply-To: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33532-70-Uq0W6B8TFP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Text to go in the| |This fixes the HTML page release notes| |title for the cataloging | |concerns management page so | |that it says Catalog | |concerns > Cataloging > | |Koha (as it is under | |cataloging, not tools). CC| |david at davidnind.com Version|unspecified |master Assignee|koha-bugs at lists.koha-commun |david at davidnind.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 21:01:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 19:01:08 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-CGm8U9hflS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 21:01:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 19:01:10 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-wR7P5CSLE2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 149623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149623&action=edit Bug 33533: Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt This patch corrects the HTML markup in order to reunite "Patron identity" or "Organization identity" for translatability. To test: 1. Apply patch 2. Update translation files ./misc/translator/translate update xx-XX 3. Check the xx-XX-staff-prog.po file, the line for memberentrygen.tt:275 should look like \#: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:275 \#, c-format msgid "Organization %sPatron %sidentity" msgstr "IdentitĂ© de l'organisme %sIdentitĂ© de l'utilisateur %s" 4. Optionally, translate the string, install translation and check the page (Patrons > New patron), trying a institutional patron and a regular patron ./misc/translator/translate install xx-XX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 21:02:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 19:02:18 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-Cw0l3Kovd6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 21:42:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 19:42:17 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-Bzkdxyq3Wi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 21:42:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 19:42:19 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-mJruzpq7Lm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149504|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 149624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149624&action=edit Revert "Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail)" This reverts commit 26c26164ba78029cb99fa99662f9e0a8ce9557df. Test plan: 1. Without the patch, edit a personal name authority record, replacing the value in 100 subfield a (200 subfield a for UNIMARC) with your own name. 2. Click "Replace record via Z39.50/SRU search" and note that the prefilled search field contains the original value, not your name. 3. Replace the Author (personal) field with your name again, choose a search target, and click Search. 4. Note that the results of the search are for the original value, not for your name. 5. Apply patch, repeat, noting that the search form is prefilled with your change made in the editor, and any changes you make in the search form are reflected in what the search results return. https://bugs.koha-community.org/show_bug.cgi?id=33445 Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 21:45:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 19:45:45 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-95sPuPNtA0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. I have signed off based on what is in the test plan working. I'm not familiar enough with authorities, and how it should work, to comment on that. 2. I think the bug title/description needs fixing - see https://wiki.koha-community.org/wiki/Commit_messages#Subject_line -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 21:50:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 19:50:11 +0000 Subject: [Koha-bugs] [Bug 11585] pubdate index not working well in UNIMARC In-Reply-To: <bug-11585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11585-70-pAZWJMFkcd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11585 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Anke, this bug is about UNIMARC, you should file separately for MARC21. This is also about a single year not being searchable, not a date range. IMO the pull down should have the misleading text removed. It doesn't make sense to thave the same functionality twice on the page and we still have the date range search below. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 21:52:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 19:52:18 +0000 Subject: [Koha-bugs] [Bug 33531] Item Search: Use modalselect or similar for user friendly selection of options In-Reply-To: <bug-33531-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33531-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33531-70-7Z4oAJnpzs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33531 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I like the idea for improvement. I know some libraires really have a lot of locations. Maybe we could also use select2 searchable pull down with an option to make multiple selections? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 22:02:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 20:02:04 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-EWNSvRXkWr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #8) > Yesterday the tests have been moved to t/cypress/integration/ERM Sabotage... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 22:05:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 20:05:30 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-7E40Z8basE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- ... I tried again, but I think I can't reproduce the problem without the patch: Spec Tests Passing Failing Pending Skipped ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ ✔ ERM/Agreements_spec.ts 00:36 5 5 - - - │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ ✔ All specs passed! 00:36 5 5 - - - -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 22:12:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 20:12:30 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-TDEXEv8E3B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 22:12:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 20:12:33 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-6yF8lRZF6R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149579|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149625&action=edit Bug 33505: Improve styling of scan index page This patch makes some changes to the 'scan index' page. * Updates second h1 heading "Scan index:" to h2 level heading "Scan index" * Removes table from the search form * Moves search index pull down and search term into one line * Reorders options with search index first and search term after, matching the advanced search form * Removes the catalog results toolbar from the top, card hold etc. are not needed here. * Fixes doubled up id attribute: scan-index by turning one into scan-index-term. To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Check display, especially search options, options at the top of the page etc. * Apply patch * Verify changes listed above * Regression test the normal search results, all should look the same with and without patch. * If you think the scan index page is nicer now - sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 22:13:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 20:13:23 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-lwQ2jZtnWY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Rebased! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 22:16:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 20:16:23 +0000 Subject: [Koha-bugs] [Bug 33231] (Bug 30813 follow-up) No publication date nor edition statements in Z39.50 biblio search results In-Reply-To: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33231-70-UCBdBAKLZu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Fast moving patch, I like it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 23:05:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 21:05:55 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-Y9472Bf3zD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from David Nind <david at davidnind.com> --- I noticed these differences from my testing (see 'How I tested' at the end), and have changed the status to Failed QA: 1. Checked out items: - Before the patch, a checked out item shows in the status column as "Checked out to Mary Burton (23529000651225) : due 04/18/2023" - After the patch, the checked out item shows as "Checked out to A patron from library : due 04/19/2023" 2. For a record that is linked to a host item (the child item - in this case http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=262) there is this text after the DataTable (after the 'Showing 1 to 2 of 2 entries'): "Show all items (-1 hidden)". The text is an active link (in this case to http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=262&showallitems=1). Let me know if you would like me to add some screenshots. How I tested (using KTD): 1. Setup some analytics using easy analytics: - Enable Easy Analytics (EasyAnalyticalRecords system preference) - Attach some items to a host record - Checkout an item on the host record - View the record details page 2. For an existing record: - Duplicate items so that there are at least 6 items - Mark separate items as lost, damaged, and withdrawn - Check out an item - Place a hold on an item - Transfer an item to another library - View the details page for the record 3. Apply the patch. 4. Review the details pages for the records in another browser - they should look the same before and after. 5. The tests should pass: prove -v t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 23:10:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 21:10:06 +0000 Subject: [Koha-bugs] [Bug 11889] Option to keep public or shared lists when deleting patron In-Reply-To: <bug-11889-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11889-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11889-70-PlJDRgN12Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/658 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 23:10:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 21:10:16 +0000 Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30933-70-MlBXo4BLLM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/658 CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 23:27:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 21:27:49 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-ekoKs7nrEB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 23:27:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 21:27:52 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-3DT2LcgI2h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149092|0 |1 is obsolete| | --- Comment #35 from David Nind <david at davidnind.com> --- Created attachment 149626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149626&action=edit Bug 32418: Can't call method 'unblessed' on an undefined value at cataloguing/additem.pl Check whether the current op is edititem or dupeitem and if so check whether the itemnumber supplied as a query param actually exists. If it doesn't, redirect to the additem op and hide all UI elements except for a dialog that gives options to add a new item to the record or to view the records holdings. This behaviour was adapted from the addbiblio view, as suggested by Fridolin. To test: 1. Go to any record 2. Hit the edit button on an item in the holdings table 3. Modify the URL so that the query param for the itemnumber is either 3.1 empty: /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber= 3.2 an itemnumber that doesn't exist: /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=9999999999 3.3 whatever else you come up with.. 4. Check the same thing for the dupe option (op=dupeitem) 5. Sign off Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 13 23:27:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 21:27:55 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-SjbUdcHwOZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149591|0 |1 is obsolete| | --- Comment #36 from David Nind <david at davidnind.com> --- Created attachment 149627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149627&action=edit Bug 32418: (follow-up) Remove jQuery, Fix typos in url, add biblio as template param To test: 1. Go to any record 2. Hit the edit button on an item in the holdings table 3. Modify the URL so that the query param for the itemnumber is either 3.1 empty: /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber= 3.2 an itemnumber that doesn't exist: /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=9999999999 3.3 whatever else you come up with.. 4. Check the same thing for the dupe option (op=dupeitem) 5. Sign off Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 00:21:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 22:21:39 +0000 Subject: [Koha-bugs] [Bug 32921] SelfCheckTimeout doesn't logout if SelfCheckReceiptPrompt modal is open In-Reply-To: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32921-70-FGLSkWKRHP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Laura Escamilla from comment #2) > (In reply to Lucas Gass from comment #1) > > Created attachment 146414 [details] [review] [review] > > Bug 32921: Honor SelfCheckTimeout when modal is open > > > > To test: > > 1. Set the 'SelfCheckTimeout' system preference to something low for testing. > > 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. > > 3. Log in to SCO and press finish but leave the modal open. > > 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. > > 5. Apply patch and try again. You should be logged out when SelfCheckTimeout > > expires. > > Hi Lucas, > > I set my SelfCheckTimeout to 10 seconds, left the modal open and it did not > log out even after applying the patch. Hmmm, this does work for me in both Firefox and Chrome. Question, did you try clearing your cache after applying the patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 00:22:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 22:22:31 +0000 Subject: [Koha-bugs] [Bug 32921] SelfCheckTimeout doesn't logout if SelfCheckReceiptPrompt modal is open In-Reply-To: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32921-70-kBmsJL9436@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Since this is working for me I am going to set it back to NSO to see if I can get some more feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 01:30:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Apr 2023 23:30:28 +0000 Subject: [Koha-bugs] [Bug 33534] New: catalog New record An error has occurred! Error 500 Message-ID: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33534 Bug ID: 33534 Summary: catalog New record An error has occurred! Error 500 Change sponsored?: --- Product: Koha Version: 22.11 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: jenni.neenan at defence.gov.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl I had just logged in to Koha ready to begin work. While cataloguing a new item, I tried to search for an item using Z39.50 protocol and received the following: An error has occurred! Error 500. I then tried to open a "New record" to add the item manually and received the same message. When I search for an item I can locate resources already added to our catalogue, however when I try to open the record to edit it I received again: An error has occurred! Error 500" However, I can access the new item feature on another PC. I am also able to conduct a search using Z39.50. How can I gain access to the full cataloguing module again on our master PC. Can someone help me to determine what has gone wrong and suggest a solution? Your assistance in this issue is much appreciated. Thank-you. Jenni -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 02:33:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 00:33:06 +0000 Subject: [Koha-bugs] [Bug 33513] batch update from report module - no patrons loaded into view In-Reply-To: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33513-70-LwyVufnQc0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind <david at davidnind.com> --- For me (testing using koha-testing-docker): 1. For the first report (step 1), I had no issues before the patch was applied. I was able to successfully use the batch record modification, batch record deletion, and add to list options. Things worked the same after the patch was applied. 2. For the second report (step 5), I did have issues that the patch fixed. Before the patch was applied, there was a warning when the batch patron modification was used: "Warning, the following card numbers were not found:". The odd thing about this is that card number 1 was able to be modified, and was the only one there wasn't a warning about. After the patch was applied, all were able to be modified. On the basis that it does fix things, just not exactly as set out in the test plan, I will sign off. Maybe you could comment on why I got different results than the test plan, which may help the QA Team? Testing notes (using KTD): 1. To find the batch operations after running a report, look under 'Total number of results' - there should be buttons saying: 'Batch operations with 20 visible records', 'Rows per page: 20', and 'Hide data menus'. Clicking on the 'Batch operations...' gives you some options, and clicking on 'Rows per page: ...' lets you change the number of results displayed. (It took me a while to find this, even though it was staring me in the face! 8-)) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 02:33:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 00:33:55 +0000 Subject: [Koha-bugs] [Bug 33513] batch update from report module - no patrons loaded into view In-Reply-To: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33513-70-bN5E0v8DzC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 02:33:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 00:33:57 +0000 Subject: [Koha-bugs] [Bug 33513] batch update from report module - no patrons loaded into view In-Reply-To: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33513-70-vusW9eYOeB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149582|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 149628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149628&action=edit Bug 33513: (follow-up) Remove whitespace in batch report lists Bug 32368 added whitespaces, remove them. To test: 1 - Create a report like: SELECT biblionumber FROM biblio 2 - Run it 3 - Try the various options from the 'Batch operations' button 4 - The operations don't find the biblios 5 - Create a report like: SELECT cardnumber FROM borrowers 6 - Run it 7 - Test the batch operations 8 - They fail 9 - Apply patch 10 - Run each report again and test batch operations 11 - They work! Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 02:37:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 00:37:48 +0000 Subject: [Koha-bugs] [Bug 33534] catalog New record An error has occurred! Error 500 In-Reply-To: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33534-70-L589HHW6TB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33534 --- Comment #1 from Jen <jenni.neenan at defence.gov.au> --- Follow up from last report, now I am unable to access an item record for editing on the other library PC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 02:53:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 00:53:59 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-EZLnHBBLSJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 --- Comment #5 from David Nind <david at davidnind.com> --- (In reply to David Nind from comment #4) > Testing notes (using KTD): > > 1. One thing I noted (not related to this bug) is that: > - when using Zebra, only 20 results are displayed - it looks to me like > the pagination of search results is missing > - when using Elasticsearch, there is pagination at the bottom (like the > normal staff interface catalog search results) > > 2. Also not related to this bug, the results pages need the page section > added (bug 31757). > > I'm happy to add the bugs for these if they don't exist already. Please ignore this comment. I've added it to bug 33505. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 02:56:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 00:56:05 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-u7mHPla5Ng@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind <david at davidnind.com> --- This is an improvement, here are some additional things I noted: 1. Zebra and Elasticsearch result differences: - when using Zebra, only 20 results are displayed - it looks to me like the pagination of search results is missing, or maybe it is too difficult. - when using Elasticsearch, there is pagination at the bottom (like the normal staff interface catalog search results) 2. The results pages need the page section added (bug 31757). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 06:23:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 04:23:34 +0000 Subject: [Koha-bugs] [Bug 33479] Add an option to pick a type of library during onboarding In-Reply-To: <bug-33479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33479-70-mutsAPsIeB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33479 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz --- Comment #3 from Alex Buckley <alexbuckley at catalyst.net.nz> --- An enhancement to the onboarding tool that I think could be helpful is adding the ability to create a non-super librarian patron. Here's how I see it could work: 1. Onboarding tool prompts user to create a superlibrarian patron 2. Click 'Submit' 3. Onboarding tool prompts user to create patron and define which permissions to enable 4. Click 'Submit' and go through the rest of the onboarding steps 5. When it comes time to log into the staff client for the first time the user can choose to log in as a superlibrarian or as a patron with only the modules they actually need to use. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:06:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:06:33 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-lmmDPbhavx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 --- Comment #57 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149629&action=edit Bug 33103: Rename aqbookseller_aliases.id with alias_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:06:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:06:36 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-bqmvLe4wvq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149480|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149630&action=edit Bug 33103: DBIC changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:13:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:13:48 +0000 Subject: [Koha-bugs] [Bug 33009] bump Standards-Version to 4.6.2 In-Reply-To: <bug-33009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33009-70-Ah6wIchQDR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Magnus Enger from comment #4) > Not really tested this, but I trust Mason to do the right thing and fix if > it was wrong. Please reset to NSO if you disagree. :-) I understand. But a signoff or QA should be passed on something, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:15:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:15:21 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-zdWeScQR9I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #49 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149631&action=edit Bug 33104: Rename interfaces.id with interface_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:15:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:15:24 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-WSBCzvDw18@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149493|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149632&action=edit Bug 33104: DBIC changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:15:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:15:46 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-ep9WgbLCCQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 --- Comment #59 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Rename asked by Tomas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:15:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:15:55 +0000 Subject: [Koha-bugs] [Bug 33104] Add vendor interfaces In-Reply-To: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33104-70-02sABmqwYB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 --- Comment #51 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Rename asked by Tomas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:16:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:16:50 +0000 Subject: [Koha-bugs] [Bug 33009] bump Standards-Version to 4.6.2 In-Reply-To: <bug-33009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33009-70-wmFoyZ8r4r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I am reading: When updating existing packaging, the Standards-Version must not be updated except after reviewing the changes between the old and the new versions of the standards and updating your package if necessary (the Upgrading checklist can help with this task). Mason, how do/did we implement that review ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:20:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:20:42 +0000 Subject: [Koha-bugs] [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword In-Reply-To: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33375-70-6aX5bwd0CJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:20:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:20:44 +0000 Subject: [Koha-bugs] [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword In-Reply-To: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33375-70-brWLq6sIli@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149056|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149633&action=edit Bug 33375: Quote reserved keyword 'rank' in advanced editor This change quotes the 'rank' keyword in the advanced editor, so that it doesn't cause fatal crashes when using MySQL 8 Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Enable advanced editor http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=EnableAdvancedCatalogingEditor 2. Go to http://localhost:8081/cgi-bin/koha/cataloguing/editor.pl#new/ 3. Click on "Advanced" on the left nav 4. Note that "LIBRARY OF CONGRESS" is ordered before "NATIONAL LIBRARY OF FRANCE" 5. Rejoice! Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:20:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:20:53 +0000 Subject: [Koha-bugs] [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword In-Reply-To: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33375-70-q2ngqcKWb3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:22:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:22:29 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-tskKcIfxiC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:22:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:22:32 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-PCGOKL3MCm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149436|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149634&action=edit Bug 33481: Pass content-type when requesting EBSCO's webservice Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:23:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:23:42 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-8OUJnCNOey@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:24:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:24:29 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-uCuFOef6S3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:24:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:24:32 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-rPTZs6ZEzj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149626|0 |1 is obsolete| | Attachment #149627|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149635&action=edit Bug 32418: Can't call method 'unblessed' on an undefined value at cataloguing/additem.pl Check whether the current op is edititem or dupeitem and if so check whether the itemnumber supplied as a query param actually exists. If it doesn't, redirect to the additem op and hide all UI elements except for a dialog that gives options to add a new item to the record or to view the records holdings. This behaviour was adapted from the addbiblio view, as suggested by Fridolin. To test: 1. Go to any record 2. Hit the edit button on an item in the holdings table 3. Modify the URL so that the query param for the itemnumber is either 3.1 empty: /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber= 3.2 an itemnumber that doesn't exist: /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=9999999999 3.3 whatever else you come up with.. 4. Check the same thing for the dupe option (op=dupeitem) 5. Sign off Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:24:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:24:35 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-zAMwMWwKFR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 --- Comment #38 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149636&action=edit Bug 32418: (follow-up) Remove jQuery, Fix typos in url, add biblio as template param To test: 1. Go to any record 2. Hit the edit button on an item in the holdings table 3. Modify the URL so that the query param for the itemnumber is either 3.1 empty: /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber= 3.2 an itemnumber that doesn't exist: /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=9999999999 3.3 whatever else you come up with.. 4. Check the same thing for the dupe option (op=dupeitem) 5. Sign off Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:24:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:24:38 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-Tu4U1f4QmE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 --- Comment #39 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149637&action=edit Bug 32418: Remove useless statement Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:27:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:27:33 +0000 Subject: [Koha-bugs] [Bug 33485] Add/remove title from holdings is not using the correct endpoint In-Reply-To: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33485-70-WS3Olzc0r5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:27:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:27:35 +0000 Subject: [Koha-bugs] [Bug 33485] Add/remove title from holdings is not using the correct endpoint In-Reply-To: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33485-70-iQSxfJ2yvK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149454|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149638&action=edit Bug 33485: (bug 32939 follow-up) Fix title endpoint The change is obvious, we shoulf call the title endpoint, not package. Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:27:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:27:46 +0000 Subject: [Koha-bugs] [Bug 33485] Add/remove title from holdings is not using the correct endpoint In-Reply-To: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33485-70-AtojVO7qN5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:29:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:29:27 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-RhW7G6Cv0s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:29:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:29:29 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-9raNK5IUjn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149616|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149639&action=edit Bug 33509: Don't show Other holdings when there are no alternate holdings With bug 33509 alternate holdings defined in AlternateHoldingsField are shown in the staff interface result list. This works greatly when there are items or when there is are alternate holdings (the configured field/subfields exist in the record), but not when there are no items and no alternate holdings. To test: * Add 100a to AlternateHoldingsField * Make a search with some records without items Sample data: perl * Make sure the alternate holdings show when there are no items and 100a exists * Change to 100z * Verify the result list now shows "Other holdings:" with nothing below * Apply patch * Repeat * Alternate holdings should still show nicely * Without alternate holdings 'no items' is displayed Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:29:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:29:45 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-8GUR3KEgGN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:31:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:31:39 +0000 Subject: [Koha-bugs] [Bug 33191] AutoEmailPrimaryAddress options don't match labels in memberentry In-Reply-To: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33191-70-DAkfe3fvJE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:31:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:31:41 +0000 Subject: [Koha-bugs] [Bug 33191] AutoEmailPrimaryAddress options don't match labels in memberentry In-Reply-To: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33191-70-MbxkfGLreL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148156|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149640&action=edit Bug 33191: AutoEmailPrimaryAddress options don't match labels in memberentry This patch changes the wording for the EmailFieldPrimary system preference to make it clearer. To test: 1. Go to Administration > Global system preferences 2. Search for EmailFieldPrimary 3. Read the sentence and choices, make sure it makes sense, grammar and spelling are correct 4. Optionally, try the different options, they should work as before Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:31:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:31:57 +0000 Subject: [Koha-bugs] [Bug 33191] AutoEmailPrimaryAddress options don't match labels in memberentry In-Reply-To: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33191-70-9AMGzmHUbg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:37:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:37:03 +0000 Subject: [Koha-bugs] [Bug 32716] update NGINX config examples to increase proxy_buffer_size In-Reply-To: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32716-70-GS3NusIK3Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32716 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:37:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:37:05 +0000 Subject: [Koha-bugs] [Bug 32716] update NGINX config examples to increase proxy_buffer_size In-Reply-To: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32716-70-z2G8xhEcBm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32716 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148911|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149641&action=edit Bug 32716: larger proxy_buffer_size in NGINX example config This patch updates the example NGINX config to increase the proxy_buffer_size to 16k. The default value of 4k (on some platforms) has empirically been shown to be a bit too small for the Link headers emitted by the REST API when pagination is requested. To test ------- [1] Set up a Koha system with NGINX as a reverse proxy in front of it (either in front of Apache or in front of of Starman). [2] Perform a patron search that returns at least two pages of results and navigate to the second page. [3] Note that the navigation can fail with a 502 HTTP error and an "upstream sent too big header while reading response header from upstream" error in the NGINX log. The problem is most likely when the pagesize of the server running NGINX is 4096 bytes. [4] Update the NGINX configuration per this patch and restart NGINX. [5] This time, repeating step 2 should work. Signed-off-by: Galen Charlton <gmc at equinoxOLI.org> Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:37:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:37:24 +0000 Subject: [Koha-bugs] [Bug 32716] update NGINX config examples to increase proxy_buffer_size In-Reply-To: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32716-70-3bIaHlnv2j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32716 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:41:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:41:50 +0000 Subject: [Koha-bugs] [Bug 32306] Hold modifications don't log correctly In-Reply-To: <bug-32306-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32306-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32306-70-Kxs0jX9ktH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32306 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- + found => "W", + priority => 0, + itemnumber => undef, Waiting hold without an item number ?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:45:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:45:48 +0000 Subject: [Koha-bugs] [Bug 32306] Hold modifications don't log correctly In-Reply-To: <bug-32306-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32306-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32306-70-2eOkhXlBG1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32306 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Not clear if we finished discussing the questions raised here. => In Discussion Intuitively, this unit test feels too long (maintenance). Changing from BEFORE to AFTER for one specific case feels wrong too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:55:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:55:11 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31695-70-e7NFMzttX6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:55:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:55:13 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31695-70-u45DJNTaCS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149583|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149642&action=edit Bug 31695: Type standard number is missing field ci_raw in field_config.yaml In Elasticsearch fields config field_config.yaml, default type as a field 'ci_raw'. This is used for exact search. This field is missing for type standard number 'stdno'. Test plan : 1) In the staff interface, go to Administration, and search for SearchEngine 2) Make sure that the SearchEngine preference is set to Elasticsearch and save 3) Return to Administration and select "Search engine configuration" 4) Change the type of "Heading-Main" to "Std. Number" and save 5) Rebuild the index (e.g. "koha-elasticsearch --rebuild -d kohadev") 6) Go to the main staff page and select Authorities 7) Search for a heading (e.g. "A Dual-language book") => Result is found with or without patch 8) Click on the sliders and select "is exactly" for the operator and search => Result is found only with patch 9) Apply the patch 10) Rebuild the index (e.g. "koha-elasticsearch --rebuild -d kohadev") 11) Click on the sliders and select "is exactly" for the operator and search => Result is found only with patch Signed-off-by: Kevin Carnes <kevin.carnes at ub.lu.se> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 08:55:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 06:55:30 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31695-70-BGjRhnD5FT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:01:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:01:43 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-6CIZWKG6DH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- + [% SET item_locatoin = AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => item.location ) %] There is a typo here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:09:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:09:29 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-gJZeetSP25@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:18:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:18:17 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-XDSDCYY2rl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I think that it would be a very good thing to try caching here. What I am not sure about, is the theoretical possibility of getting wrong results if we would repeatedly ask for pickup_locations (while handling one request). The change in the test confirms this actually. You do not add a test for caching, but just add a flush. Removing that one makes the test fail. # Subtest: pickup_locations not ok 6 - ReservesControlBranch: PatronLibrary, biblio1, patron8 should return 3 but returns 1 not ok 7 - ReservesControlBranch: PatronLibrary, biblio2, patron1 should return 0 but returns 2 not ok 8 - ReservesControlBranch: PatronLibrary, biblio2, patron8 should return 3 but returns 0 # Looks like you failed 3 tests of 9. not ok 8 - pickup_locations I would recommend to add the flush in Biblio->pickup_locations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:20:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:20:44 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-OhD4QYH5kg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- FAIL Koha/Biblio.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling FAIL valid "my" variable $params masks earlier declaration in same scope "my" variable $params masks earlier declaration in same scope FAIL t/db_dependent/Koha/Biblio.t OK critic OK forbidden patterns OK git manipulation OK pod SKIP spelling FAIL valid "my" variable $params masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:21:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:21:58 +0000 Subject: [Koha-bugs] [Bug 32706] User search problem caused by branchcode errors In-Reply-To: <bug-32706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32706-70-iFNJAEzY9n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32706 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Yes, we should fix import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:23:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:23:39 +0000 Subject: [Koha-bugs] [Bug 32706] User search problem caused by branchcode errors In-Reply-To: <bug-32706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32706-70-nzsOLoKx5Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32706 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #8) > (In reply to Jonathan Druart from comment #7) > > Letting open to let others give their opinion. > > This is the same than bug 32517 for category codes. I argued similarly > there, but I think we should not push one and block the other. Understand the point. Increasing insight? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:25:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:25:37 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-4O5mihmvYK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149615|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149643&action=edit Bug 33490: Make url consistent This ensures we populate the max_expiration_date param on the browser url for consistency with selected dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:27:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:27:58 +0000 Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21699-70-CxySWYu6bG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED CC| |m.de.rooy at rijksmuseum.nl --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:28:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:28:50 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-MURqIRu98o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- OK.. I'm happy with that last patch now. However, it does mean that the old url of `/agreements?by_expired=true` leads to a datatables error as we no longer autofill table_url with a default max_expiration_date when it's not passed in the url. The url you'll see in the address bar will include max_expiration_date however, so as long as someone isn't manually typing their url and leaving out the date we're OK.. Does this seem reasonable to you Jonathan.. or should we have belt and braces and autofill for both cases as my last patch did? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:41:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:41:52 +0000 Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21699-70-3bW1iSgkp9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:41:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:41:55 +0000 Subject: [Koha-bugs] [Bug 21699] Allow circulation messages to be editable In-Reply-To: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21699-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21699-70-g39S3M3XCb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21699 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146316|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149644&action=edit Bug 21699: Allow circulation messages to be editable During a Webinar discussion regarding the new placement of the circulation messages appearing in the Patron Detail page. It was commented by a librarian that it would be nice to have the circulation messages editable. At times libraries need to keep a specific message on a patrons account with the details such as what branch it was written from and the staff member that wrote it, but it would be nice to be able to edit this message. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Browser to a patron record 4) Create a new patron message 5) Note the patron message now has an "edit" button 6) Edit the existing message using the edit button and form 7) Check the action logs for that message, note there is a modification logged to that message if BorrowersLog is enabled Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:46:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:46:11 +0000 Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered) In-Reply-To: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31631-70-bqeoTGbk1n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- # Looks like you failed 4 tests of 156. # Failed test 'total spent for budget1 is 160' # at t/db_dependent/Budgets.t line 436. # got: '0' # expected: '160' # Failed test 'total spent for budget11 is 100' # at t/db_dependent/Budgets.t line 437. # got: '0' # expected: '100' # Failed test 'total spent for budget111 is 20' # at t/db_dependent/Budgets.t line 438. # got: '0' # expected: '20' # Failed test 'total ordered price is 20' # at t/db_dependent/Budgets.t line 519. # got: '0' # expected: '20' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:46:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:46:36 +0000 Subject: [Koha-bugs] [Bug 31799] REST API: PUT endpoint for Items In-Reply-To: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31799-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31799-70-zfjKkv1AtT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31799 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:51:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:51:51 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-7synrPIYIV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:53:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:53:44 +0000 Subject: [Koha-bugs] [Bug 31798] REST API: POST endpoint for Items In-Reply-To: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31798-70-epPV7Pto5r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31798 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Applying: Bug 31798: (follow-up) Handle all values of autoBarcode error: sha1 information is lacking or useless (Koha/REST/V1/Biblios.pm). error: could not build fake ancestor Patch failed at 0001 Bug 31798: (follow-up) Handle all values of autoBarcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:54:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:54:17 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-borUKnQfFT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |m.de.rooy at rijksmuseum.nl CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:57:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:57:45 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-AysYxhi7vb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Please explain why you add the third occurrence to hidden=9 ? Close to 0 on the keyboard, haha? - hidden: -6 + hidden: 9 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:58:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:58:21 +0000 Subject: [Koha-bugs] [Bug 33529] Increase flexibility of action buttons in Vue Kohatables In-Reply-To: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33529-70-5xEDsKOus4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Ah yes, hadn't spotted that patch - I'll close this one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:59:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:59:12 +0000 Subject: [Koha-bugs] [Bug 33529] Increase flexibility of action buttons in Vue Kohatables In-Reply-To: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33529-70-L2W4Ar3aAI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33529 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 33483 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 09:59:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 07:59:12 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-cf2fsVfK5Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #23 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- *** Bug 33529 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 10:01:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 08:01:22 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-FEShoeOTNy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking here again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:01:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:01:48 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-3NobVvZMoS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30013 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:01:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:01:48 +0000 Subject: [Koha-bugs] [Bug 30013] Limit/throttle/retry SMTP connections In-Reply-To: <bug-30013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30013-70-TJLwiXQiQ7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33360 --- Comment #5 from Magnus Enger <magnus at libriotech.no> --- Not sure if this will be solved by 33360. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:05:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:05:48 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-LFW9nI1gwd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149546|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149645&action=edit Bug 33360: Add Koha::Notice::Util for mail domain limits Ground work in new module. Includes unit test. Test plan: Run t/db_dependent/Koha/Notice_Util.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:05:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:05:51 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-424VMmtnEv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149547|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149646&action=edit Bug 33360: Extend Koha::Notice::Util with domain groups The functionality is extended a bit here by: [1] Allowing to combine domains in a shared count. [2] Only counting sent messages for the specified domains when it is really needed. Test plan: Run t/db_dependent/Koha/Notice_Util.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:05:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:05:53 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-c9YLMcm51I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149548|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149647&action=edit Bug 33360: Incorporate Koha::Notice::Util in Letters:SendQueuedMessages Minimal adjustment to get the feature working. Will still be improved in follow-up. Test plan: [1] Add a domain limit to your koha-conf: <message_domain_limits> <domain><name>gmail.com</name><limit>1</limit> <unit>1h</unit></domain> </message_domain_limits> Replace gmail.com by the domain you want to send to. Restart all. [2] Disable cron job for message queue. [3] Generate two pending notices in the queue. [4] Run process_message_queue.pl [5] Check that one is sent, one is still pending. [6] Run again. [7] Check: nothing is sent, last one still pending. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:05:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:05:56 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-WoMSPgzWeZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149549|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149648&action=edit Bug 33360: Improving limit behavior in SendQueuedMessages Includes: [1] Do no longer use the limit in the sql selection, but apply the limit as a maximum for the number of sent messages. This is more practical in terms of not flooding your mail server (and the receiving ones). [2] Replace call of _get_unsent_messages by Koha objects search. [3] Do no longer report the number of messages seen, but report the number actually 'sent'. [4] If we lookup the to_address but we need to delay a message, save the email address for the next run. Also optimizing patron lookup in _send_message_by_email. [5} Add support for $where parameter in SendQueuedMessages. Used by process_message_queue.pl. [6] Handle scalar/array for letter_code and type parameter too. Test plan: [1] Adjust your domain limit settings in koha-conf. Use notices to three domains. Group A and B. <message_domain_limits> <domain><name>A</name><limit>1</limit><unit>1h</unit></domain> <domain><name>B/name><belongs_to>A</belongs_to></domain> <domain><name>C</name><limit>1</limit><unit>1h</unit></domain> </message_domain_limits> Replace A, B and C with your choice. Do not forget the belongs_to. Restart all. [2] Disable cron job for message queue. [3] Generate two notices for each domain A, B and C (in that order). Make sure that borrowers involved have correct address. [4] Run process_message_queue.pl -limit 1 [5] Check that one is sent for A, 5 pending. [6] Run process_message_queue.pl -limit 2 [7] Check that one is sent for C, 4 pending. [8] Run process_message_queue.pl (without limit). [9] Check that nothing is sent, 4 pending. [10] Check that message_queue.to_address is filled for those 4. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:05:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:05:58 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-FPnX28pMh4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149550|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149649&action=edit Bug 33360: Adjust Letters.t for limit parameter and domain limits Includes: [1] Add a counter in the send_or_die mock. [2] Correct from processed count to sent count. [3] More extensive testing for limit parameter and domain limits. Test plan: Run t/db_dependent/Letters.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:06:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:06:01 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-99mQENKyqQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149551|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149650&action=edit Bug 33360: Update koha-conf.xml Test plan: We already tested it. Just look at changes in this patch. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:06:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:06:03 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-un44FJjneU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149552|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149651&action=edit Bug 33360: (follow-up) Adjust wording in verbose mode Koha reports 'sending mail' while we actually are still processing mail. It could still be delayed, fail, etc. Test plan: Run process_message_queue in verbose mode. If a message get processed, you should see: Processing email message to patron: 51 at /usr/share/koha/C4/Letters.pm line 1008. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:10:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:10:08 +0000 Subject: [Koha-bugs] [Bug 30013] Limit/throttle/retry SMTP connections In-Reply-To: <bug-30013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30013-70-5i5GjyN37q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Liz Rea from comment #4) > This also happens when using google as a provider of smtp. Yes, I wrote 33360 with mail deferrals from google in mind. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:10:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:10:43 +0000 Subject: [Koha-bugs] [Bug 30013] Limit/throttle/retry SMTP connections In-Reply-To: <bug-30013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30013-70-0t8ulJ1Byv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Magnus Enger from comment #5) > Not sure if this will be solved by 33360. Yes. But the current -limit is already doing that partially. The domain limits will be additional. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:11:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:11:54 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-p2wNzHoe2C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Two things do not work with this last patch: 1. As said by Martin already /agreements?by_expired=true will explode (400) 2. The date is not filled in with today's date when you click "filter", empty the date, click "filter" again. New patch coming... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:14:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:14:17 +0000 Subject: [Koha-bugs] [Bug 30013] Limit/throttle/retry SMTP connections In-Reply-To: <bug-30013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30013-70-lYAlf1Cv8j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #3) > How do we know what the error is? Koha::Email uses Email::Stuffer as a base > with uses Email::Sender::Simple which throws an Email::Sender::Failure > exception. If we know what the code for that is, we add a new 'retry' > status, and a 'retry_after' timestamp such that process_message_queue.pl > will only attempt to send retries after that timestamp. In many cases Koha will just send to port 25. If the local mta receives it, Koha marks it as sent. But the mail is not yet outside. E.g. My local mta is now trying to send it to my mail container. Which also receives it and the problem comes up there. Bug 33360 tries to throttle a bit smarter than the current limit does by looking at recipient domains too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:14:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:14:35 +0000 Subject: [Koha-bugs] [Bug 30013] Limit/throttle/retry SMTP connections In-Reply-To: <bug-30013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30013-70-JCfgh9165M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30013 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- *** This bug has been marked as a duplicate of bug 33360 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:14:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:14:35 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-1OxMtwSUcD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- *** Bug 30013 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:16:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:16:37 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-Wg9No87Cu8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- You are right... typo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:19:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:19:21 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-Q9Ib7Ectc9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149652&action=edit Bug 33490: Improve max date handling It fixes: 1. /agreements?by_expired=true do no longer explode 2. Fill date with today's date when we setup the component and when we hit "filter" However there are a couple of things totally wrong: 1. We should not need is_fp_disabled, we could be able to use :disabled="!filters.by_expired" in the template, but it does not work 2. We should not need to deal with filters.max_expiration_date the "old JS way", but should use a Vue computed value instead. I've failed at that I think those 2 problems have the same root, the way we deal with filters in data() is wrong, and we may be loosing the ref at some point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:19:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:19:50 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-sZAFvNFAQI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- All working well in testing, not obvious code issues. Signing Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:21:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:21:47 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-y4SXm9fsmW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This last patch (and the current code and difficulty we have in fixing this) highlight a problem with the way we handle the filters object. I am really not sure how to deal with it properly, but I think we should spend time on it now, or we are going to carry that and it makes the code too complicated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:22:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:22:08 +0000 Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities In-Reply-To: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31796-70-XLmuoByAkW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 Jan Kissig <bibliothek at th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek at th-wildau.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:22:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:22:21 +0000 Subject: [Koha-bugs] [Bug 17387] Add an undelete feature for items/biblios In-Reply-To: <bug-17387-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17387-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17387-70-8PsCY0K4DC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 davewood at gmx.at changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |davewood at gmx.at --- Comment #3 from davewood at gmx.at --- I have written this code already and would like to add the feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:23:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:23:41 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-ZA2U3RDKwG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Note that this last patch adds an new behaviour, the input is disabled when the checkbox is not ticked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:44:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:44:59 +0000 Subject: [Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl In-Reply-To: <bug-30349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30349-70-bXPaksYt1m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349 davewood at gmx.at changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:52:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:52:23 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-dX2jMHsXi2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145189|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149653&action=edit Bug 32450: Update db to add noissuescharge flag and remove sysprefs This commit updates the database to add a new flag to show which debit_types are included in noissuescharge. It also deletes the current sysprefs that are hardcoded for this as these are now redundant. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Mentored-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:52:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:52:26 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-luzQZYIBa5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145190|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149654&action=edit Bug 32450: DBIC Schema Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:52:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:52:28 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-eAU1tIyFh4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145191|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149655&action=edit Bug 32450: Noissuescharge debit type exclusions Currently the debit types to be excluded from the noissuescharge syspref are hardcoded in non_issues_charges which gives no flexibility for selecting which debit types should be included. This patch amends the subroutine to use a database flag to identify which debit types should be included. It also adds a column to the table in the Debit Types area of System Preferences which shows which debit types are included. The ability to edit all debit types has been added rather than just the non-system ones and the flag to include/exclude the debit type from noissuescharge can be changed by clicking that edit button. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Mentored-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:52:31 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-gMtNYbYK1m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145194|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149656&action=edit Bug 32450: Unit tests updated Unit tests for the non_issues_charges function have been updated to remove the system preferences and test based on the new database flags Test plan: 1) Apply all patches 2) In the kshell, run prove -v t/db_dependent/Accounts.t 3) All tests should pass Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:52:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:52:33 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-27WMrEjSW3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145198|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149657&action=edit Bug 32450: Add boolean to DBIC schema Adding boolean flag to DBIC schema. Test plan as per previous commits Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:52:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:52:35 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-wYm47duh1D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147563|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149658&action=edit Bug 32450: (QA follow-up) Fix QA test errors Exec flag added to atomic update file, trailing whitespaces removed Unit tests patched to remove duplicate variable names Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:52:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:52:38 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-5ECEYVqpRN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149659&action=edit Bug 32450: (QA follow-up) Polishing atomic update Database comment. Variable names. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:52:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:52:40 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-z4ugdbWX0D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149660&action=edit Bug 32450: (QA follow-up) Update UsageStats for removed prefs Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:55:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:55:51 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-juN1RLSifs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- This looks quite good. But still needs some attention. I didnt finish up yet, but will post some findings already. Please give attention first to the failing tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:56:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:56:03 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-uJaLZG9ItM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- TODO Fix t/db_dependent/SIP/Patron.t # Subtest: NoIssuesChargeGuarantees tests 1..6 not ok 1 - Only patron's fines are reported in total # Failed test 'Only patron's fines are reported in total' # at t/db_dependent/SIP/Patron.t line 315. # got: '0' # expected: '11' not ok 2 - Guarantor blocked # Failed test 'Guarantor blocked' # at t/db_dependent/SIP/Patron.t line 316. not ok 3 - Screen message includes related fines total # Failed test 'Screen message includes related fines total' # at t/db_dependent/SIP/Patron.t line 317. # 'Greetings from Koha. yauSBUttb' # doesn't match '(?^u:Patron blocked by fines \(11\.11\) on guaranteed accounts)' ok 4 - Guarantee only fines correctly counted ok 5 - Guarantee not blocked by guarantor fines ok 6 - Screen message does not include blocked message # Looks like you failed 3 tests of 6. not ok 9 - NoIssuesChargeGuarantees tests # Failed test 'NoIssuesChargeGuarantees tests' # at t/db_dependent/SIP/Patron.t line 326. TODO t/db_dependent/SIP/Transaction.t # Looks like you failed 3 tests of 17. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:56:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:56:39 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-3rnvAjlyjq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Preliminary QA Comments Bit confusing as to naming. + my @renewals = ('RENT', 'RENT_DAILY', 'RENT_RENEW', 'RENT_DAILY_RENEW'); + if($_ eq 'RentalsInNoissuesCharge') { push @debit_types_to_update, @renewals}; Will fix in a follow-up. + if($_ eq 'ManInvInNoissuesCharge') { push @debit_types_to_update, @manual}; Perl allows you to do: statement if condition; for these kind of lines. When we are using { }, we normally add newlines etc. No blocker This is a theory thing. But if you run it multiple times, the field has been inserted already and the DEFAULT 1 has been applied. The sysprefs have been deleted, so saying 'default value has been applied' is not true anymore. They are not reset again or so. No blocker, just noting. Wording is a bit less intuitive. The column name is No issues charge (which is already obscure). And then we could have the value Not included. Twice, no and not, might not be very clear. No blocker, could be improved. Or even should be, I am breaking my head every time ;) Similar for sub non_issues_charges. Already existed. But non should better be no here, I guess. Leaving as-is. Remove prefs from C4/UsageStats.pm. See follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 11:57:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 09:57:39 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-z2clLrjGn1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 12:06:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 10:06:06 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-PFYmhQbpde@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- - tagfield: "246" tagsubfield: "n" liblibrarian: "Number of part/section of a work" libopac: "Number of part/section of a work" repeatable: 1 mandatory: 0 kohafield: "" tab: 2 authorised_value: "" authtypecode: "" value_builder: "" isurl: hidden: 9 frameworkcode: "" seealso: "" link: "" defaultvalue: - tagfield: "246" tagsubfield: "p" liblibrarian: "Name of part/section of a work" libopac: "Name of part/section of a work" repeatable: 1 mandatory: 0 kohafield: "" tab: 2 authorised_value: "" authtypecode: "" value_builder: "" isurl: hidden: -6 frameworkcode: "" seealso: "" link: "" I am seeing now that you change field 246. You are out of scope? Or change title and what about 246$p ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 12:07:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 10:07:28 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-GUhbSvDjkC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149661&action=edit Bug 33490: Use computed values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 12:09:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 10:09:18 +0000 Subject: [Koha-bugs] [Bug 33535] New: Date range search for Publication Year not working Message-ID: <bug-33535-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33535 Bug ID: 33535 Summary: Date range search for Publication Year not working Change sponsored?: --- Product: Koha Version: 22.05 Hardware: Other OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: anke.bruns at gwdg.de In 22.05, the pubdate index that searches pos. 7-10 in field 008 works well if searched for one year only (e.g. 1999). However, searching for a date range, as suggested in the pulldown menu where it says "Publication date (yyyy-yyyy), doesn't yield anything at all. Thus, "1999-2002" or "1999 - 2002" return 0 results, even though there are records with pubdates 1999, 2002 and the years in between, and they can be retrieved by searching for one single year as mentioned above. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 12:09:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 10:09:22 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-5Lz8rWk32a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I am almost there. I think the only problem is that the input is not filled in with today's date when we click "filter". The last patch gets rid of the unnecessary is_fp_disabled and updateMaxExpirationDate() I was referring to in my previous comment. I won't have more time for this today, please have a look! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 12:11:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 10:11:51 +0000 Subject: [Koha-bugs] [Bug 11585] pubdate index not working well in UNIMARC In-Reply-To: <bug-11585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11585-70-i0UQJPzkct@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11585 --- Comment #3 from Anke Bruns <anke.bruns at gwdg.de> --- Done. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33535 However, I don't know what is meant by having the same functionality twice on the page - I can see it only once in the search pulldown menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 12:12:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 10:12:16 +0000 Subject: [Koha-bugs] [Bug 33535] Date range search for Publication Year not working in MARC21 In-Reply-To: <bug-33535-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33535-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33535-70-6xFCc01Isp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33535 Anke Bruns <anke.bruns at gwdg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Date range search for |Date range search for |Publication Year not |Publication Year not |working |working in MARC21 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 12:42:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 10:42:31 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-H7bp9IKTLu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Sorry Jonathan, I can't get those patches to apply.. sha1 issues :(. That looks reasonable to me though. This can wait for Monday and fresher brains though, so no hurry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 12:59:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 10:59:48 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-UCcRzWu2q3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 12:59:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 10:59:50 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-MQu8DixfCl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149645|0 |1 is obsolete| | Attachment #149646|0 |1 is obsolete| | Attachment #149647|0 |1 is obsolete| | Attachment #149648|0 |1 is obsolete| | Attachment #149649|0 |1 is obsolete| | Attachment #149650|0 |1 is obsolete| | Attachment #149651|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 149662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149662&action=edit Bug 33360: Add Koha::Notice::Util for mail domain limits Ground work in new module. Includes unit test. Test plan: Run t/db_dependent/Koha/Notice_Util.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 12:59:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 10:59:57 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-6WFEuks8HS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 149663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149663&action=edit Bug 33360: Extend Koha::Notice::Util with domain groups The functionality is extended a bit here by: [1] Allowing to combine domains in a shared count. [2] Only counting sent messages for the specified domains when it is really needed. Test plan: Run t/db_dependent/Koha/Notice_Util.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 12:59:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 10:59:59 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-yDcuRqkywL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 149664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149664&action=edit Bug 33360: Incorporate Koha::Notice::Util in Letters:SendQueuedMessages Minimal adjustment to get the feature working. Will still be improved in follow-up. Test plan: [1] Add a domain limit to your koha-conf: <message_domain_limits> <domain><name>gmail.com</name><limit>1</limit> <unit>1h</unit></domain> </message_domain_limits> Replace gmail.com by the domain you want to send to. Restart all. [2] Disable cron job for message queue. [3] Generate two pending notices in the queue. [4] Run process_message_queue.pl [5] Check that one is sent, one is still pending. [6] Run again. [7] Check: nothing is sent, last one still pending. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 13:00:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 11:00:01 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-5snX6LglEB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 149665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149665&action=edit Bug 33360: Improving limit behavior in SendQueuedMessages Includes: [1] Do no longer use the limit in the sql selection, but apply the limit as a maximum for the number of sent messages. This is more practical in terms of not flooding your mail server (and the receiving ones). [2] Replace call of _get_unsent_messages by Koha objects search. [3] Do no longer report the number of messages seen, but report the number actually 'sent'. [4] If we lookup the to_address but we need to delay a message, save the email address for the next run. Also optimizing patron lookup in _send_message_by_email. [5} Add support for $where parameter in SendQueuedMessages. Used by process_message_queue.pl. [6] Handle scalar/array for letter_code and type parameter too. Test plan: [1] Adjust your domain limit settings in koha-conf. Use notices to three domains. Group A and B. <message_domain_limits> <domain><name>A</name><limit>1</limit><unit>1h</unit></domain> <domain><name>B/name><belongs_to>A</belongs_to></domain> <domain><name>C</name><limit>1</limit><unit>1h</unit></domain> </message_domain_limits> Replace A, B and C with your choice. Do not forget the belongs_to. Restart all. [2] Disable cron job for message queue. [3] Generate two notices for each domain A, B and C (in that order). Make sure that borrowers involved have correct address. [4] Run process_message_queue.pl -limit 1 [5] Check that one is sent for A, 5 pending. [6] Run process_message_queue.pl -limit 2 [7] Check that one is sent for C, 4 pending. [8] Run process_message_queue.pl (without limit). [9] Check that nothing is sent, 4 pending. [10] Check that message_queue.to_address is filled for those 4. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 13:00:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 11:00:04 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-rQ5idhM9ed@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 149666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149666&action=edit Bug 33360: Adjust Letters.t for limit parameter and domain limits Includes: [1] Add a counter in the send_or_die mock. [2] Correct from processed count to sent count. [3] More extensive testing for limit parameter and domain limits. Test plan: Run t/db_dependent/Letters.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 13:00:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 11:00:06 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-qSDD25kTU5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 149667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149667&action=edit Bug 33360: Update koha-conf.xml Test plan: We already tested it. Just look at changes in this patch. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 13:00:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 11:00:08 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-Ng2xXObnb8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 149668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149668&action=edit Bug 33360: (follow-up) Adjust wording in verbose mode Koha reports 'sending mail' while we actually are still processing mail. It could still be delayed, fail, etc. Test plan: Run process_message_queue in verbose mode. If a message get processed, you should see: Processing email message to patron: 51 at /usr/share/koha/C4/Letters.pm line 1008. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 13:04:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 11:04:07 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-5tn19WHw7I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> --- QA thoughts: Considering the SMTP configuration is web based, it would be nice if the controls for this were integrated into it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 13:26:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 11:26:48 +0000 Subject: [Koha-bugs] [Bug 33158] Use template wrapper for authorized values and item types administration tabs In-Reply-To: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33158-70-vXsaUmywu3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149621|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 149669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149669&action=edit Bug 33158: Use template wrapper for authorized values and item types administration tabs This patch updates the authorized values and item types administration templates so that they use the new WRAPPER directive to build tabbed navigation. Seeing that the markup in itemtypes.tt and authorised_values.tt is indential when it comes to icon selection, I have moved that section of the template into an include file and updated both templates to use it. The patch also makes minor SCSS changes, so to test you must rebuild the staff interface CSS. To test, apply the patch and go to Administration -> Item types. - Edit an item type. - On the edit page you should see tabs under "Choose an icon." - Confirm that the tabs look correct and work correctly. - If you did not previously have any icon selected, the "None" tab should be active. - If you had an icon selected, that icon set's tab should be active. - Confirm that if you specify a remote image (e.g.https://via.placeholder.com/50/FF0000/FFFFFF.png) the tab is correctly shown after you save and re-edit. - Confirm that changing icons works correctly and that the selected icon's tab is always active when you return to the edit view. Perform the same tests in Administration -> Authorized values. Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 13:27:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 11:27:16 +0000 Subject: [Koha-bugs] [Bug 33158] Use template wrapper for authorized values and item types administration tabs In-Reply-To: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33158-70-10CwIoct1Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Andrew Auld <andrew.auld at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Great! Works perfectly now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 13:32:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 11:32:21 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-NpaW0pH4tD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #33 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #32) > QA thoughts: Considering the SMTP configuration is web based, it would be > nice if the controls for this were integrated into it. Thanks Kyle for QA. Happy to put some further improvements on a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 13:34:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 11:34:36 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-gx0JjZsLKA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 13:34:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 11:34:38 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-PJUbo8sQWK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148814|0 |1 is obsolete| | Attachment #148815|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149670&action=edit Bug 32914: Use template wrapper for batch record deletion and modification templates This patch updates the batch record modification and batch record deletion templates to replace tab markup with the use of WRAPPERs. This patch adds a "clearfix" snippet of CSS to _mixins.scss copied from Bootstrap. Applied to the active tab pane, this helps in situations where Bootstrap tabs follow a floated element. The patch also wraps tab label strings in <span> to ensure they can be translated. Unrelated: The patch removes an extra </option> from the batch record modification template. To test you should have at least one list and at least one MARC modification template defined. - Apply the patch and go to Cataloging -> Batch record modification - You should see three tabs, "Upload a file," "Select a list of records," and "Enter a list of record numbers." - The tabs should look correct and work correctly. - Checking the "Authorities" radio button should hide the lists tab. - Test that submissions from each form work correctly. - Go to Cataloging -> Batch record deletion and perform the same tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 13:44:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 11:44:56 +0000 Subject: [Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema In-Reply-To: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33328-70-SIMYZDK5Df@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 13:44:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 11:44:58 +0000 Subject: [Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema In-Reply-To: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33328-70-tVUpQKcPzY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148626|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus at libriotech.no> --- Created attachment 149671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149671&action=edit Bug 33328: Rename x-marc-schema => x-record-schema This patch renames the header on the biblio API so it is not entirely tied to MARC, trying to follow the biblio_metadata table generic approach. To test: 1. Apply this patch 2. Run: $ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass 3. You agree with the change? 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Magnus Enger <magnus at libriotech.no> Change sounds reasonable. Tests pass before and after patch. "grep -r "x-marc-schema" *" confirms no occurrences after patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:00:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:00:55 +0000 Subject: [Koha-bugs] [Bug 31327] Add color scheme picker to the OPAC In-Reply-To: <bug-31327-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31327-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31327-70-f6fUCaHPa9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31327 Daniel Jones <daniel.jones at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.jones at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:01:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:01:11 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-YyFFekfIrm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- As I understood, the L1 and Memory Lite caches are flushed on each request: /etc/koha/sites/kohadev/plack.psgi: use CGI qw(-utf8 ); # we will loose -utf8 under plack, otherwise { no warnings 'redefine'; my $old_new = \&CGI::new; *CGI::new = sub { my $q = $old_new->( @_ ); $CGI::PARAM_UTF8 = 1; Koha::Caches->flush_L1_caches(); Koha::Cache::Memory::Lite->flush(); return $q; }; } Am I not understanding correctly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:32:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:32:33 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-HYmhpH6J6U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149603|0 |1 is obsolete| | Attachment #149604|0 |1 is obsolete| | Attachment #149643|0 |1 is obsolete| | Attachment #149652|0 |1 is obsolete| | Attachment #149661|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149672&action=edit Bug 33490: Unit tests This patch adds cypress tests for the filter by expired functionality in the ERM Agreements page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:32:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:32:36 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-IqYNErGCkN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #25 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149673&action=edit Bug 33490: Prevent 400 on agreements?by_expired=true We need to update the filter THEN update the current route Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:32:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:32:38 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-xS0NN3pX8A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #26 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149674&action=edit Bug 33490: Make url consistent This ensures we populate the max_expiration_date param on the browser url for consistency with selected dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:32:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:32:41 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-GnbBMfDI2G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #27 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149675&action=edit Bug 33490: Improve max date handling It fixes: 1. /agreements?by_expired=true do no longer explode 2. Fill date with today's date when we setup the component and when we hit "filter" However there are a couple of things totally wrong: 1. We should not need is_fp_disabled, we could be able to use :disabled="!filters.by_expired" in the template, but it does not work 2. We should not need to deal with filters.max_expiration_date the "old JS way", but should use a Vue computed value instead. I've failed at that I think those 2 problems have the same root, the way we deal with filters in data() is wrong, and we may be loosing the ref at some point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:32:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:32:44 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-RxFEpEcryd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #28 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149676&action=edit Bug 33490: Use computed values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:33:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:33:40 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-v8B6o2zQp4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:33:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:33:42 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-n0xZoJ3gzH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148431|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149677&action=edit Bug 33167: Cleanup staff detail page This patch begins reduing some of the extra things we are doing in detail.pl that could easily be handled in the templates - fetching authorised values and branches etc It also removes a loop to find items that should be hidden, and instead uses a searh parameter The template changes either use item object rather than passed variables, or utilize plugins to fetch authorised valued -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:34:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:34:32 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-zvohKILCMX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33483 Status|Signed Off |ASSIGNED --- Comment #29 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Rebased on top of bug 33483. But that's not enough IMO, there are some tiny bugs in the behaviours, see comment 22. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 [Bug 33483] Cannot link EBSCO's package with local agreement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:34:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:34:32 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-U30ch9wdtw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 [Bug 33490] Agreements - Filter by expired results in error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:34:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:34:41 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-3GchuenQmS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:44:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:44:24 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-04zzS9PCVg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Philip Orr <philip.orr at lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Philip Orr <philip.orr at lmscloud.de> --- in Batch Record Modification, all forms now look and perform correctly for Record type: Biblios. The tab "Select a list of records" also disappears when you select Record type: Authorities. However, if Record Type: Biblios is still selected and you first select your list from the drop down under "Select a list of records" and afterwards you then switch from Record type: Biblios to Record type: Authorities, your list actually stays selected and is still shown (and will indeed be modified if you proceed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:47:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:47:34 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-0rSKRkMfan@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:47:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:47:35 +0000 Subject: [Koha-bugs] [Bug 33496] Add 'host_items' param to Koha::Biblio->items In-Reply-To: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33496-70-XV9RG256iA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33496 --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149678&action=edit Bug 33496: (follow-up) Correct param names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 14:51:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 12:51:25 +0000 Subject: [Koha-bugs] [Bug 14891] Attempting to place hold with no item selected freezes the request screen In-Reply-To: <bug-14891-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14891-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14891-70-qTSD6wWSCE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14891 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- No longer valid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 15:12:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 13:12:48 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-ogmEOhJFS7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #5) > I think that it would be a very good thing to try caching here. What I am > not sure about, is the theoretical possibility of getting wrong results if > we would repeatedly ask for pickup_locations (while handling one request). (In reply to Nick Clemens from comment #6) > As I understood, the L1 and Memory Lite caches are flushed on each request: > > Am I not understanding correctly? Sure you do. But see above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 15:28:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 13:28:47 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-HHrsKKlJ8Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Nick, I have a plan to rewrite the items table on the staff detail page to make it use the REST API. I will base my patches on top of this bug, but keep it in mind in case you would like to provide more things. Maybe we are going to collide :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 15:44:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 13:44:59 +0000 Subject: [Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace In-Reply-To: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33236-70-JxL1FlCkRk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 15:45:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 13:45:01 +0000 Subject: [Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace In-Reply-To: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33236-70-RcFQysQRyi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149679&action=edit Bug 33236: (follow-up) Handle new suggestion in ReNewSubscription -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 15:45:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 13:45:03 +0000 Subject: [Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace In-Reply-To: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33236-70-4UmcrakGTK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149680&action=edit Bug 33236: (follow-up) Remove export of NewSuggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 15:48:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 13:48:39 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-RhqosXLzaJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6) > Nick, I have a plan to rewrite the items table on the staff detail page to > make it use the REST API. I will base my patches on top of this bug, but > keep it in mind in case you would like to provide more things. Maybe we are > going to collide :) Excellent! I had started trying to clean the page, then realized it would just be better to move to the API, so switched to setting the stage for that. Let me know if any of this set needs adjustment or how I can help. I won't file anymore touching this one for now :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 15:52:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 13:52:28 +0000 Subject: [Koha-bugs] [Bug 33532] Catalog concerns - Title of the page says Tools instead of Cataloging In-Reply-To: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33532-70-oj1bfK3GZb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 15:52:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 13:52:30 +0000 Subject: [Koha-bugs] [Bug 33532] Catalog concerns - Title of the page says Tools instead of Cataloging In-Reply-To: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33532-70-xlsvqQUx7i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149622|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 149681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149681&action=edit Bug 33532: Fix HTML page title for cataloging concerns page The HTML title of the Catalog concerns management page (which appears in the browser tab) says Catalog concerns > Tools > Koha. But the page is under Cataloging, not Tools. Test plan: 1. Enable the CatalogConcerns system preference. 2. Go to Cataloging > Catalog concerns: => The title of the page in the browser tab says Catalog concerns > Tools > Koha 3. Apply the patch. 4. Refresh the catalog concerns page. 5. The title of the page in the browser tab should now say Catalog concerns > Cataloging > Koha 6. Sign off 8-) Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 15:53:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 13:53:05 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-1VnBw7Hcix@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #5) > I think that it would be a very good thing to try caching here. What I am > not sure about, is the theoretical possibility of getting wrong results if > we would repeatedly ask for pickup_locations (while handling one request). > > The change in the test confirms this actually. You do not add a test for > caching, but just add a flush. Removing that one makes the test fail. > > # Subtest: pickup_locations > not ok 6 - ReservesControlBranch: PatronLibrary, biblio1, patron8 should > return 3 but returns 1 > not ok 7 - ReservesControlBranch: PatronLibrary, biblio2, patron1 should > return 0 but returns 2 > not ok 8 - ReservesControlBranch: PatronLibrary, biblio2, patron8 should > return 3 but returns 0 > # Looks like you failed 3 tests of 9. > not ok 8 - pickup_locations > > I would recommend to add the flush in Biblio->pickup_locations. Those tests fail because we have changed a syspref - we are essentially testing multiple requests there. It is not expected for a syspref to change during a request. I flush to indicate that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 15:59:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 13:59:15 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26346-70-NcuyxTW4Kw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/658 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:17:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:17:01 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-EtI4Jur63B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords| |release-notes-needed --- Comment #34 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- (In reply to Kyle M Hall from comment #32) > QA thoughts: Considering the SMTP configuration is web based, it would be > nice if the controls for this were integrated into it. Agreed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:19:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:19:40 +0000 Subject: [Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off In-Reply-To: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31722-70-Wk4vwUNYuf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:19:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:19:42 +0000 Subject: [Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off In-Reply-To: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31722-70-YegwckDtbg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:19:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:19:44 +0000 Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in templates In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32127-70-qSTYwPW9n0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:19:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:19:46 +0000 Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in templates In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32127-70-bp2B8ne0QP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 --- Comment #15 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:19:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:19:47 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-9Pd3IFCyL7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:19:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:19:50 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-3dCSL0hEJE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 --- Comment #40 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:19:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:19:51 +0000 Subject: [Koha-bugs] [Bug 32716] update NGINX config examples to increase proxy_buffer_size In-Reply-To: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32716-70-AvxOk0IVz7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32716 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:19:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:19:53 +0000 Subject: [Koha-bugs] [Bug 32716] update NGINX config examples to increase proxy_buffer_size In-Reply-To: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32716-70-mUWTYqPSC5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32716 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:19:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:19:58 +0000 Subject: [Koha-bugs] [Bug 32955] Standardize structure around action fieldsets in various templates In-Reply-To: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32955-70-WsYmaEBPep@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32955 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:00 +0000 Subject: [Koha-bugs] [Bug 32955] Standardize structure around action fieldsets in various templates In-Reply-To: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32955-70-dEvLAB4ek9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32955 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:01 +0000 Subject: [Koha-bugs] [Bug 32956] Use template wrapper for HTML customizations tabs In-Reply-To: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32956-70-8IEvaBv4MS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32956 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:03 +0000 Subject: [Koha-bugs] [Bug 32956] Use template wrapper for HTML customizations tabs In-Reply-To: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32956-70-AoJlSSaSrc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32956 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:05 +0000 Subject: [Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt In-Reply-To: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33088-70-AMzv788pfK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:07 +0000 Subject: [Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt In-Reply-To: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33088-70-9Gcof7R331@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:09 +0000 Subject: [Koha-bugs] [Bug 33345] On-site checkout checkbox does not work since issue date using flatpickr In-Reply-To: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33345-70-Aq3VqqVmWG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:11 +0000 Subject: [Koha-bugs] [Bug 33345] On-site checkout checkbox does not work since issue date using flatpickr In-Reply-To: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33345-70-s7vplT7vBM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 --- Comment #8 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:12 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-NA5wespSLh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:14 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-by98er9vTW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #35 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:16 +0000 Subject: [Koha-bugs] [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword In-Reply-To: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33375-70-ZeZnYgCjwN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:18 +0000 Subject: [Koha-bugs] [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword In-Reply-To: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33375-70-ZjXxXPg2LZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:20 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-BsHowwUDmZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:22 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-Evl7RW6Gt8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 --- Comment #7 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:24 +0000 Subject: [Koha-bugs] [Bug 33485] Add/remove title from holdings is not using the correct endpoint In-Reply-To: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33485-70-L4sZquIFhZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:20:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:20:29 +0000 Subject: [Koha-bugs] [Bug 33485] Add/remove title from holdings is not using the correct endpoint In-Reply-To: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33485-70-pCbmXtvxAi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:21:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:21:54 +0000 Subject: [Koha-bugs] [Bug 33231] (Bug 30813 follow-up) No publication date nor edition statements in Z39.50 biblio search results In-Reply-To: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33231-70-cDxCHsdJWt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Attachment #149142|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:23:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:23:46 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-QIY19eJ3sh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- It definitely looks better! There is a small typo around line 376: [% ELSE %]<option selected="selected" value="">Any word</option[% END %] should be: [% ELSE %]<option selected="selected" value="">Any word</option>[% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:29:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:29:38 +0000 Subject: [Koha-bugs] [Bug 33536] New: If staff member only has catalogue permission, search bar is hidden Message-ID: <bug-33536-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33536 Bug ID: 33536 Summary: If staff member only has catalogue permission, search bar is hidden Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If a staff member with only the catalogue permission (permission to access the staff interface), the search bar at the top of the page is hidden. You have to click "Search catalog" and then it appears. I guess they wouldn't know that it's not usually like this, but normally, the search bar is visible at the top of the page. To reproduce: 1. Create a staff patron and give them only the catalogue permission 2. Log into the staff interface with that account --> No search bar at the top of the page 3. Click "Search catalog" in the green bar at the top of the page --> Search bar appears Since it's their only option, I think the search bar should be displayed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:33:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:33:11 +0000 Subject: [Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes In-Reply-To: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21083-70-QZmfrJG98E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:36:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:36:06 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31695-70-d5Dqkontu2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:36:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:36:08 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31695-70-N8voYq2hW9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 --- Comment #10 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:36:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:36:10 +0000 Subject: [Koha-bugs] [Bug 33191] AutoEmailPrimaryAddress options don't match labels in memberentry In-Reply-To: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33191-70-FPzeD2Tdun@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:36:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:36:12 +0000 Subject: [Koha-bugs] [Bug 33191] AutoEmailPrimaryAddress options don't match labels in memberentry In-Reply-To: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33191-70-4DMtbGiko3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 --- Comment #12 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:36:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:36:14 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-dtbfBbjyPl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:36:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:36:16 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-sSX9djJT4r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 --- Comment #16 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:36:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:36:18 +0000 Subject: [Koha-bugs] [Bug 33231] (Bug 30813 follow-up) No publication date nor edition statements in Z39.50 biblio search results In-Reply-To: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33231-70-n2cLCZrbGs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:36:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:36:20 +0000 Subject: [Koha-bugs] [Bug 33231] (Bug 30813 follow-up) No publication date nor edition statements in Z39.50 biblio search results In-Reply-To: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33231-70-oCF26X4BZU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 --- Comment #8 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:36:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:36:22 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-2TOGYRdyoQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:36:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:36:24 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-eougyGHywq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:48:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:48:55 +0000 Subject: [Koha-bugs] [Bug 9762] Log circulation overrides In-Reply-To: <bug-9762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9762-70-ndyqZ23tbS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Solene, Most of this is working and this will be a great addition! A few things though: -Do these strings need to translatable? -This is going to need unit tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 16:50:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 14:50:25 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-O1gTlSG8K3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:06:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:06:51 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-NIDIsmzt73@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149081|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149682&action=edit Bug 11844: Use additional fields for order lines This patch allows to create additional fields for order lines. Once created, these fields can be filled during order line creation or modification. If additional field is linked to a MARC field, there are two possible scenario: - MARC field mode = get: The field cannot be modified and its value is retrieved from the bibliographic record (current behaviour) - MARC field mode = set: The field can be modified and its value is saved to the bibliographic record (new behaviour) If additional field is linked to an authorised value category, then authorised values are used. If not directly linked to an authorised value category, but linked to a MARC field, a search for an AV category is made on MARC default framework. This patch doesn't display additional fields value anywhere (except in order line creation/modification). Future patches will do that. Test plan: 1/ Go to Acquisitions home 2/ In the left menu, click on "Add order line fields" 3/ Click on "New field" button 4/ Give the field a name (unique), no AV category and no MARC field. 5/ Save. 6/ Create 5 other fields: a/ no AV category, a MARC field not linked to AV category, MARC field mode = get b/ no AV category, a MARC field not linked to AV category, MARC field mode = set c/ no AV category, a MARC field linked to AV category, MARC field mode = get d/ no AV category, a MARC field linked to AV category, MARC field mode = set e/ an AV category, no MARC field 7/ Create everything you need to be able to create order lines (supplier, basket, ...) 8/ Create an order line. At bottom of the page, you should see your additional fields, with authorised values dropdrown list for fields (c), (d) and (e). Fields (a) and (c) should be disabled. 9/ Fill these fields with some data and save order line 10/ check that data was correctly saved into biblio for fields (b) and (d), but not for (a) and (c) 11/ modify the same order line, check that values you've filled are correctly retrieved and that values for (a) and (c) were correctly retrieved from the bibliographic record 12/ modify all values, save, and check biblio once again Signed-off-by: Harold Dramer <harold.dramer at nyls.edu> Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:06:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:06:55 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-RnUNtFB3aL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149082|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149683&action=edit Bug 11844: Take into account itemtypes, branches, and cn_source MARC subfields can be linked to "authorised values" that are not real authorised values: itemtypes, branches, and cn_source. Those were not taken into account. This patch fixes that Test plan: 1. Create additional fields for order lines with a MARC subfield that is linked to one of those "fake" authorised values list 2. Follow the same steps as in the main test plan Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:06:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:06:59 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-Mlue4dOvtt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149083|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149684&action=edit Bug 11844: Fix QA issues (POD, TT filters, file exec flag) Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:07:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:07:03 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-iIEOONaSea@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149084|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149685&action=edit Bug 11844: [DO NOT PUSH] Schema changes Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:07:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:07:07 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-14lu0DoEvu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149085|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149686&action=edit Bug 11844: (follow-up) Fix terminology: biblio should be bibliographic record This is about the note displaying after an additional field that is linked to a MARC field. Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:07:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:07:11 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-uoDX7lbjFZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149086|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149687&action=edit Bug 11844: (follow-up) Add standard note to database update Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:07:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:07:15 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-Rv9hPMIIln@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149087|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149688&action=edit Bug 11844: (follow-up) Add new option to acq navigation The navigation on the left in the acq module has links to the additional fields for baskets and invoices. This also adds a link for the new order lines feature. Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:07:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:07:19 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-didG4CDkDH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149088|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149689&action=edit Bug 11844: (follow-up) Add format hint to the additional fields admin page The MARC field needs to be added with a $ between field and subfield for things to work right. So this adds a hint about the expected format. Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:07:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:07:23 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-PNXhoRT1ox@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149089|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149690&action=edit Bug 11844: Add tests for Koha::AdditionalField Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:07:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:07:27 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-No8R7FPUDr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149090|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149691&action=edit Bug 11844: Add tests for TransferOrder Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:07:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:07:31 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-ABXqYn8lmI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149091|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149692&action=edit Bug 11844: Add tests for marcfield_mode Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:08:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:08:51 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-pTRx8EFEg1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #94 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks for adding all the tests.. this works great and is now covered nicely. Passing QA RM note.. the QA tool threw two issues.. POD coverage which is a false positive here I believe and a permissions issue.. but the permissions all look correct to me.. not sure what's going on there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:09:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:09:06 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-sWQVU5btHx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:09:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:09:08 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-dZNfSMaZQC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149623|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149693&action=edit Bug 33533: Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt This patch corrects the HTML markup in order to reunite "Patron identity" or "Organization identity" for translatability. To test: 1. Apply patch 2. Update translation files ./misc/translator/translate update xx-XX 3. Check the xx-XX-staff-prog.po file, the line for memberentrygen.tt:275 should look like \#: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:275 \#, c-format msgid "Organization %sPatron %sidentity" msgstr "IdentitĂ© de l'organisme %sIdentitĂ© de l'utilisateur %s" 4. Optionally, translate the string, install translation and check the page (Patrons > New patron), trying a institutional patron and a regular patron ./misc/translator/translate install xx-XX Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:09:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:09:24 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-M5jt7oeZ4I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to TomĂĄs Cohen Arazi from comment #35) > Pushed to master for 23.05. > > Nice work everyone, thanks! Top ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:09:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:09:32 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-EZuPUfy98U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |In order to release notes| |control/throttle the volume | |of mail messages sent by | |Koha, this report makes the | |limit parameter of | |process_message_queue (and | |associated routine in | |Letters) look at the number | |of messages actually sent, | |not processed. It also adds | |the possibility of delaying | |messages to specified | |domains according to limits | |defined in koha-conf.xml | |(see example section added | |in this patch set). For | |instance, you may define | |that each minute only 30 | |messages are sent to | |outlook.com or 50 messages | |per hour to gmail.com, etc. | |This will help in reducing | |deferred or rejected mails | |due to exceeding limits of | |various email providers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:09:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:09:44 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-kbDkoQP3O2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:12:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:12:08 +0000 Subject: [Koha-bugs] [Bug 33537] New: Move domain limits from koha-conf to staff SMTP configuration Message-ID: <bug-33537-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Bug ID: 33537 Summary: Move domain limits from koha-conf to staff SMTP configuration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com See 33360 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:12:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:12:28 +0000 Subject: [Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration In-Reply-To: <bug-33537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33537-70-nhenT9ytm2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:12:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:12:43 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-IYlAftUWSd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33537 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:12:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:12:43 +0000 Subject: [Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration In-Reply-To: <bug-33537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33537-70-S1QTOzvIWF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33360 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:12:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:12:58 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-XlqXM28Ejm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 --- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to TomĂĄs Cohen Arazi from comment #34) > (In reply to Kyle M Hall from comment #32) > > QA thoughts: Considering the SMTP configuration is web based, it would be > > nice if the controls for this were integrated into it. > > Agreed! Bug 33537 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:14:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:14:16 +0000 Subject: [Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration In-Reply-To: <bug-33537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33537-70-bxXmb5qjnk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:18:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:18:54 +0000 Subject: [Koha-bugs] [Bug 33532] Catalog concerns - Title of the page says Tools instead of Cataloging In-Reply-To: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33532-70-2FKtYd1FyQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:18:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:18:56 +0000 Subject: [Koha-bugs] [Bug 33532] Catalog concerns - Title of the page says Tools instead of Cataloging In-Reply-To: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33532-70-L7YXHwOzjZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33532 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149681|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149694&action=edit Bug 33532: Fix HTML page title for cataloging concerns page The HTML title of the Catalog concerns management page (which appears in the browser tab) says Catalog concerns > Tools > Koha. But the page is under Cataloging, not Tools. Test plan: 1. Enable the CatalogConcerns system preference. 2. Go to Cataloging > Catalog concerns: => The title of the page in the browser tab says Catalog concerns > Tools > Koha 3. Apply the patch. 4. Refresh the catalog concerns page. 5. The title of the page in the browser tab should now say Catalog concerns > Cataloging > Koha 6. Sign off 8-) Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:23:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:23:54 +0000 Subject: [Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl In-Reply-To: <bug-30349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30349-70-OEPPjJ10iQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- A couple failures from the QA script: FAIL misc/migration_tools/bulkmarcimport.pl FAIL forbidden patterns forbidden pattern: tab char (line 579) Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - 23a34f0d0b * Commit title does not start with 'Bug XXXXX: ' - 6b73fdeb22 * Commit title does not start with 'Bug XXXXX: ' - 7d5ade6229 Can these be fixed please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:41:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:41:50 +0000 Subject: [Koha-bugs] [Bug 32740] Add a new option patron home library to OverdueNoticeFrom In-Reply-To: <bug-32740-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32740-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32740-70-EHRsU5dkA8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- This works as described, glad to see this patch as this is the behavior some libraries would like to see. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:42:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:42:34 +0000 Subject: [Koha-bugs] [Bug 32740] Add a new option patron home library to OverdueNoticeFrom In-Reply-To: <bug-32740-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32740-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32740-70-vceeVvufNa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:42:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:42:36 +0000 Subject: [Koha-bugs] [Bug 32740] Add a new option patron home library to OverdueNoticeFrom In-Reply-To: <bug-32740-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32740-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32740-70-4ake1LQJv6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145779|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149695&action=edit Bug 32740: Add a new option patron home library to OverdueNoticeFrom This patch add 'patron home library' option to the OverdueNoticeFrom preference. When it's selected notification messages for overdues will be bundled and sent from the borrowing user's home library To Test 1. Create 3 libraries B1, B2 and B3 1.1. Go to Koha administration, click on Libraries 1.2. Click New library 1.3. Fill the Library Code (ex. B1), Name(ex. B1) and email(ex. b1 at test.com) fields. 2. Create a user belonging to B1 2.1. Go to patron module, click on New patron and patron 2.2. Fill the Surname,Card number,Primary email,Card number field and select B1 as Library. 3. Create 2 notices : the first belongs to B2 and the second belong to B3 3.1. Go to Cataloging module and click on new 3.2. field the required field (000 subfield 0, 003 subfield 0, 005 subfield 0, 008 subfield 0, 040 subfield c,245 subfield a, and 942 subfield c ) 3.3. Click on save 3.4. In the item form, Select Home library = B2 and Current library = B2 and type a Barcode. 3.5. Repeat 3.1 3.2 3.3 3.4 to create a second notice belong to B3 4. Have (or create) a default notice for all branches in Notices and Slips Module 5. Make sure you connected to branch B2 or Switch to branch B2 6. checkout item I2 (belonging to B2) to the user created in step 2 (specifying as due date the day before (1 day overdue)) 7. switch to branch B3 8. checkout item I3 (belonging to B3) to the user created in step 2 (specifying as due date the day before (1 day overdue)) 9. make sure you have defined 'Overdue notice/status triggers' for that patron category, ie with Delay=1 so that 'Overdue Notice' is selected and 'Email' is checked. Note: we have a user belong to B1, two item: I2 belong to B2, I3 belong to B3 and the user has borrowed I2 from B2 and I3 from B3. 10. Test 10.1. Search for OverdueNoticeFrom in System preferences and select item home library 10.2. from cli run 'perl ./misc/cronjobs/overdue_notices.pl' => Two new entries will be generated in message_queue DB table, coming from different branches that have the SAME list of overdue items. => The sender address is the item home library address for each entry. 11. Apply the patch 12. Search for OverdueNoticeFrom in System preferences => There is now 'patron home library' in the options list 13. Select patron home library 14. from cli run 'perl ./misc/cronjobs/overdue_notices.pl' => You will see that only one message had been created. Its content shows both B2 and B3 overdue items => The sender address matches B1 address (the patron home library). 15. Search for OverdueNoticeFrom in System preferences and select cron 16. from cli run './misc/cronjobs/overdue_notices.pl --frombranch patron-homebranch' => you will get the same result at step 14 Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:42:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:42:56 +0000 Subject: [Koha-bugs] [Bug 32740] Add a new option patron home library to OverdueNoticeFrom In-Reply-To: <bug-32740-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32740-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32740-70-r7vSpIK5uk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 17:50:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 15:50:23 +0000 Subject: [Koha-bugs] [Bug 33038] Add classes to patroncategorycode in patronbriefinfo for easier customization In-Reply-To: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33038-70-hlqjklw20j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33038 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:23:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:23:23 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-ul5M4SkFQe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:23:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:23:25 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-OJc1FxeZNe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149696&action=edit Bug 33037: Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) Patch 32555 tries to resolve the issue caused by bug 31313. But the way it is fixed seems to be at least problematic. With patch 32555 we will never see the difference between `serial`.`serialseq` and `items`.`enumchron` which is still intended in opac-detail.tt (line ~ 1332) and [intranet] catalogue/detail.tt (line ~ 446). This is because ITEM_RESULT.serialitem (in opac-detail.tt) and item.itemserial.serial (in catalogue/detail.tt) refer to non-existing things. (and therefor the problem described in 32555 no longer emerge). The original problem is caused by mixing up serialitem with serial in [opac-]detail.pl and passing serialitem instead of serial to both templates. To test: 1. Create a serial subscription 1.1. Go to Serials 1.2. Click on New subscription 1.3. Fill out the first form - Vendor: leave empty - Record: enter a record number - Create an item record when receiving this serial - When there is an irregular issue: Keep issue number - Manual history: leave unchecked - Call number: leave empty - Library: Centerville - Public/nonpublic note: leave empty - Patron notification: None - Location: None - Collection: None - Item type: Continuing resources - Grace period: leave empty - Number of issues to display: leave both empty 1.4. Click Next (and confirm you are not using a vendor) 1.5. Fill out the second form - First issue publication date: 2023-01-01 - Frequency: 1/month - Subscription length: issues 12 - Subscription start date: 2023-01-01 - Subscription end date: 2024-01-01 - Numbering pattern: Number - Locale: leave empty - Begins with: 42 - Inner counter: leave empty 1.6. Click Test prediction pattern 1.7. Click Save subscription 2. Click OPAC view: Open in new window. 3. Back in the staff interface tab, receive an issue 3.1. Click Receive 3.2. In Status, choose Arrived for No. 42 3.3. IN ITEM DETAILS BELOW CHANGE h - Serial enumeration / chronology from No. 42 to some different string 3.3. Click Save 4. Check the items in OPAC and Intranet – you will see only the value from the item $h subfield (enumchron) instead of desired "enumchron -- serialseq" in case of a difference between `serial`.`serialseq` and `items`.`enumchron`. 5. Apply this patch 6. Repeat 4 7. Check the items in OPAC and Intranet – you should now see the desired "enumchron -- serialseq" string. 8. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:23:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:23:48 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-Y2oTxEGvO2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Attachment #147131|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:24:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:24:14 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-aqoL483IQn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149696|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149697&action=edit Bug 33037: Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) Patch 32555 tries to resolve the issue caused by bug 31313. But the way it is fixed seems to be at least problematic. With patch 32555 we will never see the difference between `serial`.`serialseq` and `items`.`enumchron` which is still intended in opac-detail.tt (line ~ 1332) and [intranet] catalogue/detail.tt (line ~ 446). This is because ITEM_RESULT.serialitem (in opac-detail.tt) and item.itemserial.serial (in catalogue/detail.tt) refer to non-existing things. (and therefor the problem described in 32555 no longer emerge). The original problem is caused by mixing up serialitem with serial in [opac-]detail.pl and passing serialitem instead of serial to both templates. To test: 1. Create a serial subscription 1.1. Go to Serials 1.2. Click on New subscription 1.3. Fill out the first form - Vendor: leave empty - Record: enter a record number - Create an item record when receiving this serial - When there is an irregular issue: Keep issue number - Manual history: leave unchecked - Call number: leave empty - Library: Centerville - Public/nonpublic note: leave empty - Patron notification: None - Location: None - Collection: None - Item type: Continuing resources - Grace period: leave empty - Number of issues to display: leave both empty 1.4. Click Next (and confirm you are not using a vendor) 1.5. Fill out the second form - First issue publication date: 2023-01-01 - Frequency: 1/month - Subscription length: issues 12 - Subscription start date: 2023-01-01 - Subscription end date: 2024-01-01 - Numbering pattern: Number - Locale: leave empty - Begins with: 42 - Inner counter: leave empty 1.6. Click Test prediction pattern 1.7. Click Save subscription 2. Click OPAC view: Open in new window. 3. Back in the staff interface tab, receive an issue 3.1. Click Receive 3.2. In Status, choose Arrived for No. 42 3.3. IN ITEM DETAILS BELOW CHANGE h - Serial enumeration / chronology from No. 42 to some different string 3.3. Click Save 4. Check the items in OPAC and Intranet – you will see only the value from the item $h subfield (enumchron) instead of desired "enumchron -- serialseq" in case of a difference between `serial`.`serialseq` and `items`.`enumchron`. 5. Apply this patch 6. Repeat 4 7. Check the items in OPAC and Intranet – you should now see the desired "enumchron -- serialseq" string. 8. Sign off Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:24:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:24:51 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-APxcAzFhzT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- This works as described so I am signing off. I did amend the commit message to please the QA scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:28:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:28:10 +0000 Subject: [Koha-bugs] [Bug 33031] Update OPAC lists page to use Bootstrap markup for tabs In-Reply-To: <bug-33031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33031-70-dtgdhiWVku@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:28:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:28:11 +0000 Subject: [Koha-bugs] [Bug 32969] Remove references to jQueryUI assets and style in the OPAC In-Reply-To: <bug-32969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32969-70-eYG1map2ok@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Bug 32969 depends on bug 33031, which changed state. Bug 33031 Summary: Update OPAC lists page to use Bootstrap markup for tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33031 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:30:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:30:27 +0000 Subject: [Koha-bugs] [Bug 33063] Duplicated reports should maintain subgroup of original In-Reply-To: <bug-33063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33063-70-VLqNW1M2Q0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33063 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:31:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:31:13 +0000 Subject: [Koha-bugs] [Bug 32746] Standardize structure around action fieldsets in acquisitions In-Reply-To: <bug-32746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32746-70-UjRFkPvxQc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:31:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:31:13 +0000 Subject: [Koha-bugs] [Bug 32744] [OMNIBUS] Standardize structure around action fieldsets In-Reply-To: <bug-32744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32744-70-t34ZYRTf6f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32744 Bug 32744 depends on bug 32746, which changed state. Bug 32746 Summary: Standardize structure around action fieldsets in acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:31:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:31:13 +0000 Subject: [Koha-bugs] [Bug 32771] Standardize structure around action fieldsets in serials In-Reply-To: <bug-32771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32771-70-74GvdHsc2F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Bug 32771 depends on bug 32746, which changed state. Bug 32746 Summary: Standardize structure around action fieldsets in acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:31:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:31:14 +0000 Subject: [Koha-bugs] [Bug 32952] Standardize action fieldsets in authorities, cataloging, and circulation In-Reply-To: <bug-32952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32952-70-awRzTFY3dB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32952 Bug 32952 depends on bug 32746, which changed state. Bug 32746 Summary: Standardize structure around action fieldsets in acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:31:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:31:14 +0000 Subject: [Koha-bugs] [Bug 32954] Standardize action fieldsets in rotating collections, suggestions, tools In-Reply-To: <bug-32954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32954-70-qrDHcDihqt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Bug 32954 depends on bug 32746, which changed state. Bug 32746 Summary: Standardize structure around action fieldsets in acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:31:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:31:14 +0000 Subject: [Koha-bugs] [Bug 32955] Standardize structure around action fieldsets in various templates In-Reply-To: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32955-70-Sjx9qxSYee@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32955 Bug 32955 depends on bug 32746, which changed state. Bug 32746 Summary: Standardize structure around action fieldsets in acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:33:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:33:01 +0000 Subject: [Koha-bugs] [Bug 32886] Set focus for cursor to Code when adding a new restriction In-Reply-To: <bug-32886-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32886-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32886-70-XXINUB35zs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32886 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply clean in 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:33:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:33:01 +0000 Subject: [Koha-bugs] [Bug 31411] [Omnibus] Set focus to first input field of an add/entry form In-Reply-To: <bug-31411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31411-70-cTwu5RHucf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411 Bug 31411 depends on bug 32886, which changed state. Bug 32886 Summary: Set focus for cursor to Code when adding a new restriction https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32886 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:33:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:33:27 +0000 Subject: [Koha-bugs] [Bug 32683] Convert header search tabs to Bootstrap In-Reply-To: <bug-32683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32683-70-cYB1rSFVzt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> --- Enhancement will not be backpoted to 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:33:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:33:28 +0000 Subject: [Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs In-Reply-To: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29226-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29226-70-KbsvImKrbM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Bug 29226 depends on bug 32683, which changed state. Bug 32683 Summary: Convert header search tabs to Bootstrap https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:33:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:33:28 +0000 Subject: [Koha-bugs] [Bug 33278] Correct JS for activating default tab on various pages In-Reply-To: <bug-33278-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33278-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33278-70-qR6LaMZQWc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Bug 33278 depends on bug 32683, which changed state. Bug 32683 Summary: Convert header search tabs to Bootstrap https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:33:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:33:28 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: <bug-33422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33422-70-XRScWRwpnW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 Bug 33422 depends on bug 32683, which changed state. Bug 32683 Summary: Convert header search tabs to Bootstrap https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:40:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:40:52 +0000 Subject: [Koha-bugs] [Bug 32952] Standardize action fieldsets in authorities, cataloging, and circulation In-Reply-To: <bug-32952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32952-70-XNIO5InVfM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32952 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:40:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:40:53 +0000 Subject: [Koha-bugs] [Bug 32744] [OMNIBUS] Standardize structure around action fieldsets In-Reply-To: <bug-32744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32744-70-laXjiL6FUt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32744 Bug 32744 depends on bug 32952, which changed state. Bug 32952 Summary: Standardize action fieldsets in authorities, cataloging, and circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:42:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:42:16 +0000 Subject: [Koha-bugs] [Bug 32519] In Elasticsearch mappings table use search field name In-Reply-To: <bug-32519-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32519-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32519-70-ErjP4nMPux@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32519 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.12 released in| | --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:51:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:51:10 +0000 Subject: [Koha-bugs] [Bug 33211] Fix failing test for basic_workflow.t when adding item In-Reply-To: <bug-33211-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33211-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33211-70-mdUj0Eh1mZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33211 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.12 released in| | CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:55:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:55:02 +0000 Subject: [Koha-bugs] [Bug 30920] Add caching to C4::Biblio::GetAuthorisedValueDesc In-Reply-To: <bug-30920-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30920-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30920-70-w49Y9NVffn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #43 from Lucas Gass <lucas at bywatersolutions.com> --- Merge conflicts with 22.05.x, no backport. If this is needed please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 18:55:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 16:55:03 +0000 Subject: [Koha-bugs] [Bug 33214] Make sure cache is cleared properly In-Reply-To: <bug-33214-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33214-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33214-70-s2WagyoXPL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33214 Bug 33214 depends on bug 30920, which changed state. Bug 30920 Summary: Add caching to C4::Biblio::GetAuthorisedValueDesc https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 19:22:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 17:22:11 +0000 Subject: [Koha-bugs] [Bug 33038] Add classes to patroncategorycode in patronbriefinfo for easier customization In-Reply-To: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33038-70-bt9A62aXrA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33038 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147163|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149698&action=edit Bug 33038: Add classes to patroncategorycode for easier customization To test: 1. Pull up a patron and look at the patroncategory inside the patronbriefinfo. Description and code are together in one HTML element, they are hard to seperate. 2. Apply patch. 3. Look again and notice the new classes. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 19:22:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 17:22:35 +0000 Subject: [Koha-bugs] [Bug 33038] Add classes to patroncategorycode in patronbriefinfo for easier customization In-Reply-To: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33038-70-FkrC0TA4qk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33038 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 19:30:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 17:30:54 +0000 Subject: [Koha-bugs] [Bug 33271] Show charges_guarantors_guarantees on patron details page In-Reply-To: <bug-33271-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33271-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33271-70-LxBn9NI7Yn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33271 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149571|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149699&action=edit Bug 33271: Add collective owing message to moremember page To test: 1. Turn on NoIssuesChargeGuarantorsWithGuarantees and set the amount to 5. 2. Create a guarantor/guarantee relationship. 3. Add a manual invoice to the guarantor that is larger than 5.00. 4. Notice the message on that circulation ( check out tab ) page. " Charges: Patron's guarantors and their other guarantees collectively owe X. Checkouts are BLOCKED because fine balance is OVER THE LIMIT. " 5. Look at the moremember ( details ) page. The same message does not appear. 6. Apply patch, restart_all 7. Try step 5 again, the message should now appear. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 19:31:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 17:31:45 +0000 Subject: [Koha-bugs] [Bug 33271] Show charges_guarantors_guarantees on patron details page In-Reply-To: <bug-33271-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33271-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33271-70-18T4VP6vaR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33271 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 19:34:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 17:34:25 +0000 Subject: [Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-0itGszIAGM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 19:34:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 17:34:27 +0000 Subject: [Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-HT3WCnCn1X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146615|0 |1 is obsolete| | --- Comment #2 from Phil Ringnalda <phil at chetcolibrary.org> --- Created attachment 149700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149700&action=edit Bug 32959: Don't store results of autobarcode in item editor templates Test Plan: 1) Enable autobarcode 2) Create a new item template, leave the barcode field blank 3) Apply that item template 4) Note the template prefills the barcode field 5) Delete that item template 6) Apply this patch 7) Restart all the things! 8) Repeat steps 2-4 9) Note the barcode field remains empty! Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 19:34:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 17:34:57 +0000 Subject: [Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-ayOwse8zUE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 19:38:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 17:38:58 +0000 Subject: [Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button In-Reply-To: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33233-70-eEW3cJyDeQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149476|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149701&action=edit Bug 33233: Don't allow disabled attribute to remain when using browser's back button To test: 1. Go to OPAC advanced search and do a search using only one of the inputs. 2. Once the search is complete use the browser's back button to return to the advanced search. 3. Notice the unused inputs are disabled. 4. Apply patch and try again. Now the inputs should not be disabled. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 19:39:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 17:39:37 +0000 Subject: [Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button In-Reply-To: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33233-70-bO3jpIq1IS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off --- Comment #5 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- This worked great - so glad to see this fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 19:57:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 17:57:00 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-QHoNLsjHvP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Failed QA --- Comment #4 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- Everything about the patch worked great except for step #4. Even though I had OPACShelfBrowser turned on I could never find any records in the OPAC that would display the shelf browser so I couldn't test that part. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 19:59:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 17:59:59 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23486-70-YuEDNQSOaZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:02:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:02:34 +0000 Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared list In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25498-70-W7IgmlYEMH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/658 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:05:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:05:21 +0000 Subject: [Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's In-Reply-To: <bug-30578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30578-70-zvU1wEJJuQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED --- Comment #35 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I'm unsure what needs to be documented here. Setting it to resolved, but feel free to reopen it with specifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:05:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:05:22 +0000 Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared list In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25498-70-93l3aWBcGR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Bug 25498 depends on bug 30578, which changed state. Bug 30578 Summary: We should drop circ/ysearch.pl in preference to using the REST API's https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:05:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:05:23 +0000 Subject: [Koha-bugs] [Bug 30980] Make patron selection more consistent In-Reply-To: <bug-30980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30980-70-JSJjUu84Q9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30980 Bug 30980 depends on bug 30578, which changed state. Bug 30578 Summary: We should drop circ/ysearch.pl in preference to using the REST API's https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:05:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:05:23 +0000 Subject: [Koha-bugs] [Bug 31782] Patron autocomplete broken when using js/autocomplete/patrons.js In-Reply-To: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31782-70-VwxaZEpAEP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782 Bug 31782 depends on bug 30578, which changed state. Bug 30578 Summary: We should drop circ/ysearch.pl in preference to using the REST API's https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:05:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:05:23 +0000 Subject: [Koha-bugs] [Bug 30965] Add patron autocomplete search to curbside pickups In-Reply-To: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30965-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30965-70-7sMf7Xbsqp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 Bug 30965 depends on bug 30578, which changed state. Bug 30578 Summary: We should drop circ/ysearch.pl in preference to using the REST API's https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:05:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:05:26 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-0owuhyoTV8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Barbara Johnson from comment #4) > Everything about the patch worked great except for step #4. Even though I > had OPACShelfBrowser turned on I could never find any records in the OPAC > that would display the shelf browser so I couldn't test that part. Did your items have an item.itemcallnumber? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:05:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:05:43 +0000 Subject: [Koha-bugs] [Bug 25498] Allow to change owner of public or shared list In-Reply-To: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25498-70-sCWFJgRqaU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #65 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Added to manual https://gitlab.com/koha-community/koha-manual/-/merge_requests/658 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:05:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:05:44 +0000 Subject: [Koha-bugs] [Bug 30933] Add a designated owner for shared and public lists at patron deletion In-Reply-To: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30933-70-eRRh6WyfOe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30933 Bug 30933 depends on bug 25498, which changed state. Bug 25498 Summary: Allow to change owner of public or shared list https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:08:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:08:15 +0000 Subject: [Koha-bugs] [Bug 32994] Remove compiled files from src (2) In-Reply-To: <bug-32994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32994-70-EiMLDwGRcJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #28 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:08:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:08:31 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-CJsxRJ0a8f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #6 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- They did not. Let me add that and try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:09:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:09:56 +0000 Subject: [Koha-bugs] [Bug 32991] Improve our Dialog component and remove routes for deletion In-Reply-To: <bug-32991-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32991-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32991-70-0nhqUUd1uN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #105 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:09:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:09:57 +0000 Subject: [Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist In-Reply-To: <bug-32807-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32807-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32807-70-xAuh8mb7iS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Bug 32807 depends on bug 32991, which changed state. Bug 32991 Summary: Improve our Dialog component and remove routes for deletion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:09:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:09:57 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-k4LOWl7YMA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Bug 33066 depends on bug 32991, which changed state. Bug 32991 Summary: Improve our Dialog component and remove routes for deletion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:09:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:09:57 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-fD4b3SLRn3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Bug 33169 depends on bug 32991, which changed state. Bug 32991 Summary: Improve our Dialog component and remove routes for deletion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32991 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:11:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:11:08 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33127-70-C2ntXYCnIp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:12:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:12:36 +0000 Subject: [Koha-bugs] [Bug 33144] Authority lookup in advanced editor overencodes HTML In-Reply-To: <bug-33144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33144-70-FhIe8YLCxF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33144 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.12 released in| | CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:13:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:13:56 +0000 Subject: [Koha-bugs] [Bug 32684] Implement SIP patron status field "too many items lost" In-Reply-To: <bug-32684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32684-70-tt4xjzOlQD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32684 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #21 from Lucas Gass <lucas at bywatersolutions.com> --- Enhancement will not be backported to 22.05.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:17:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:17:47 +0000 Subject: [Koha-bugs] [Bug 33150] Add specific message for renewal too_soon situation In-Reply-To: <bug-33150-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33150-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33150-70-UWx1I3NIgM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.12 released in| | --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:19:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:19:36 +0000 Subject: [Koha-bugs] [Bug 29354] Make overdue_notices.pl send HTML attachment as .html In-Reply-To: <bug-29354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29354-70-JpaXwmAJxO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29354 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> --- This patchset doesn't apply cleanly in 22.05, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:20:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:20:07 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-NtuyC6PIUE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #7 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- That worked. The images do appear in the correct sizes in the shelf browser. However, when scrolling back and forth through the titles in the shelf browser, once I go back to look at the original images they now display the ‘No cover image available’ graphic instead of the cover images. It doesn’t seem to be holding on to the images. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:20:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:20:55 +0000 Subject: [Koha-bugs] [Bug 31801] REST API: PUT endpoint for Biblios In-Reply-To: <bug-31801-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31801-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31801-70-xnRkmIoNNu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #16 from Lucas Gass <lucas at bywatersolutions.com> --- Enhancement will no be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:20:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:20:56 +0000 Subject: [Koha-bugs] [Bug 31788] REST API: CRUD endpoints for Biblios [omnibus] In-Reply-To: <bug-31788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31788-70-F040LoYjCT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31788 Bug 31788 depends on bug 31801, which changed state. Bug 31801 Summary: REST API: PUT endpoint for Biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:20:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:20:57 +0000 Subject: [Koha-bugs] [Bug 32734] REST API: Add a list endpoint for Biblios In-Reply-To: <bug-32734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32734-70-Ch6KaC2R1E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 Bug 32734 depends on bug 31801, which changed state. Bug 31801 Summary: REST API: PUT endpoint for Biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31801 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:21:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:21:30 +0000 Subject: [Koha-bugs] [Bug 32734] REST API: Add a list endpoint for Biblios In-Reply-To: <bug-32734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32734-70-Yl64vPpuLd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:21:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:21:31 +0000 Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25870-70-fMLJ4v4QJU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 Bug 25870 depends on bug 32734, which changed state. Bug 32734 Summary: REST API: Add a list endpoint for Biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:21:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:21:31 +0000 Subject: [Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search In-Reply-To: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27113-70-8N7eaEvtaY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Bug 27113 depends on bug 32734, which changed state. Bug 32734 Summary: REST API: Add a list endpoint for Biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:21:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:21:33 +0000 Subject: [Koha-bugs] [Bug 31788] REST API: CRUD endpoints for Biblios [omnibus] In-Reply-To: <bug-31788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31788-70-J8uPOTaAy4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31788 Bug 31788 depends on bug 32734, which changed state. Bug 32734 Summary: REST API: Add a list endpoint for Biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:21:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:21:33 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-JEp0mkSzM8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Bug 33329 depends on bug 32734, which changed state. Bug 32734 Summary: REST API: Add a list endpoint for Biblios https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:24:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:24:03 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-NY2lEUls8S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Barbara Johnson from comment #7) > That worked. The images do appear in the correct sizes in the shelf > browser. However, when scrolling back and forth through the titles in the > shelf browser, once I go back to look at the original images they now > display the ‘No cover image available’ graphic instead of the cover images. > It doesn’t seem to be holding on to the images. Is that behavior that you can recreate with or without this patch? If so, perhaps we should file a separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:28:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:28:33 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-nNUtIIGrXS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #9 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- I’m not sure. Is there a way to un-apply a patch on a sandbox? Or do I need to start from scratch with a new one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:28:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:28:39 +0000 Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities In-Reply-To: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31796-70-scWMkCKz45@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 AgustĂ­n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:28:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:28:42 +0000 Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities In-Reply-To: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31796-70-PzHeJLxn5e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 AgustĂ­n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144752|0 |1 is obsolete| | --- Comment #5 from AgustĂ­n Moyano <agustinmoyano at theke.io> --- Created attachment 149702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149702&action=edit Bug 31796: Add REST endpoint to modify an authority To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Pick an authority to modify, and modify it's marc record 4. Make a PUT request to /api/v1/authorities/:authid with one of the following content type header - application/json - application/marcxml+xml - application/marc-in-json - application/marc 5. If content type is other than 'application/json' place the following header in the request 'x-authority-type: <auth type>' 5. Check that the authority was modified 6. Sign off Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:33:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:33:03 +0000 Subject: [Koha-bugs] [Bug 33183] Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6 In-Reply-To: <bug-33183-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33183-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33183-70-jdZsnpbb8k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33183 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.12 released in| | CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:39:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:39:05 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18829-70-76uY1dRNP7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:39:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:39:08 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18829-70-PFQPgJLg1T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 --- Comment #27 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:39:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:39:10 +0000 Subject: [Koha-bugs] [Bug 33129] Use template wrapper for breadcrumbs: Administration part 6 In-Reply-To: <bug-33129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33129-70-vzewvnKTf6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:39:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:39:12 +0000 Subject: [Koha-bugs] [Bug 33129] Use template wrapper for breadcrumbs: Administration part 6 In-Reply-To: <bug-33129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33129-70-KcN1RaBln0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 --- Comment #7 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:39:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:39:14 +0000 Subject: [Koha-bugs] [Bug 33181] Use template wrapper for tabs on record merge pages In-Reply-To: <bug-33181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33181-70-6UeS2WJ6i5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:39:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:39:16 +0000 Subject: [Koha-bugs] [Bug 33181] Use template wrapper for tabs on record merge pages In-Reply-To: <bug-33181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33181-70-Um2qkWNSn4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:39:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:39:18 +0000 Subject: [Koha-bugs] [Bug 33187] Use template wrapper for tabs article requests and holds awaiting pickup pages In-Reply-To: <bug-33187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33187-70-FQBtTsdSAC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33187 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:39:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:39:20 +0000 Subject: [Koha-bugs] [Bug 33187] Use template wrapper for tabs article requests and holds awaiting pickup pages In-Reply-To: <bug-33187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33187-70-KgBbqf5mgM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33187 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:39:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:39:22 +0000 Subject: [Koha-bugs] [Bug 33229] Patron reading history should be cleared when privacy set to never In-Reply-To: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33229-70-Q2kEwJuNAI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33229 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:39:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:39:24 +0000 Subject: [Koha-bugs] [Bug 33229] Patron reading history should be cleared when privacy set to never In-Reply-To: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33229-70-bi0xqRFAgc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33229 --- Comment #9 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:39:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:39:48 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-gBbojf9UVZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 AgustĂ­n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:39:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:39:51 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-CV9X8jJMCF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 AgustĂ­n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147493|0 |1 is obsolete| | --- Comment #4 from AgustĂ­n Moyano <agustinmoyano at theke.io> --- Created attachment 149703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149703&action=edit Bug 32735: Add endpoint to list authorities This patch adds an endpoint to list authorities To test: 1. apply patch 2. enable basic auth 3. call to GET /api/v1/authorities with the following Accept headers: * application/json * application/marcxml+xml * application/marc-in-json * application/marc * text/plain 4. notice how data changes with each Accept header 5. prove t/db_dependent/api/v1/authorities.t 6. sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:49:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:49:02 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-uN4EdtRdUo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 20:49:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 18:49:05 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-8QSSbx3qrb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149677|0 |1 is obsolete| | --- Comment #18 from David Nind <david at davidnind.com> --- Created attachment 149704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149704&action=edit Bug 33167: Cleanup staff detail page This patch begins reduing some of the extra things we are doing in detail.pl that could easily be handled in the templates - fetching authorised values and branches etc It also removes a loop to find items that should be hidden, and instead uses a searh parameter The template changes either use item object rather than passed variables, or utilize plugins to fetch authorised valued Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 21:02:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 19:02:59 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-XEUFRql0rZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 21:03:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 19:03:02 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-xZSIAkXROJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149703|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 149705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149705&action=edit Bug 32735: Add endpoint to list authorities This patch adds an endpoint to list authorities To test: 1. apply patch 2. enable basic auth 3. call to GET /api/v1/authorities with the following Accept headers: * application/json * application/marcxml+xml * application/marc-in-json * application/marc * text/plain 4. notice how data changes with each Accept header 5. prove t/db_dependent/api/v1/authorities.t 6. sign off Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 21:04:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 19:04:20 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-Ni6deuaweq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 --- Comment #6 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. Used Postman to send requests. 2. 20 results are returned for each of the different Accept headers. 3. The tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 21:17:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 19:17:22 +0000 Subject: [Koha-bugs] [Bug 33538] New: Allow for independent shibboleth autocreate and sync mapping Message-ID: <bug-33538-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33538 Bug ID: 33538 Summary: Allow for independent shibboleth autocreate and sync mapping Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: pgsengstock at wisc.edu QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Shibboleth auth's autocreate and sync functions both rely on the same //shibboleth/mapping block in koha-conf.xml. Because autocreate requires mapping and/or defaults for branchcode and categorycode, this has the undesired affect of overwriting manual edits to borrowers on later syncs if the those fields are not delivered via shibboleth and explicitly mapped. Example: 1) Patron signs in for first time and borrower account is autocreated with a default branch and categorycode. 2) Staff update patron to set new branch and category codes as needed (e.g. from "SSOAUTH" to "MAINLIB"). 3) On next sign-in, patron's mapped data is synced, but branch and category codes are overwritten with the defaults. Suggested workaround is to differentiate //shibboleth/autocreatemapping vs //shibboleth/syncmapping. This allows greater control over which fields are mapped for autocreate vs sync. This schema change would not be backward compatible, though. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 21:21:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 19:21:23 +0000 Subject: [Koha-bugs] [Bug 33138] Don't copy tag 147 to MARC frameworks, since it should only be in a manually-created NAME_EVENT framework In-Reply-To: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33138-70-ojZPNbyD6A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33138 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 21:21:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 19:21:25 +0000 Subject: [Koha-bugs] [Bug 33138] Don't copy tag 147 to MARC frameworks, since it should only be in a manually-created NAME_EVENT framework In-Reply-To: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33138-70-Hmp637HVby@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33138 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147768|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 149706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149706&action=edit Bug 33138: Don't copy tag 147 to authority MARC frameworks We shouldn't be including tag 147 in every authority MARC framework we install, since like all 1xx authority tags there should only be one per record. It only belongs in a NAME_EVENT framework, which we don't install. Test plan: 1. Apply patch, kd && ku or however you like to restart 2. Administration - Authority types - Actions button for Default - MARC structure 3. In the search box below the text "Select an authority framework" enter 147 and click OK 4. Once you see that it exists in Default, switch the dropdown to each of the other frameworks and verify it doesn't appear in any. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 21:21:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 19:21:58 +0000 Subject: [Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls In-Reply-To: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32932-70-ITibv92gE9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 AgustĂ­n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149210|0 |1 is obsolete| | --- Comment #33 from AgustĂ­n Moyano <agustinmoyano at theke.io> --- Created attachment 149707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149707&action=edit Bug 32932: (follow-up) Fix copy/paste bug in local titles form add and fix bad link definition in Main.vue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 21:22:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 19:22:28 +0000 Subject: [Koha-bugs] [Bug 33138] Don't copy tag 147 to MARC frameworks, since it should only be in a manually-created NAME_EVENT framework In-Reply-To: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33138-70-tQpD08WSE8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33138 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. To reload the authority frameworks after apply the patch in KTD: reset_all -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 22:23:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 20:23:39 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-PErgUlV0Nx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|julian.maurice at biblibre.com |tomascohen at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 22:25:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 20:25:59 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-daqAJ7dmYv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 --- Comment #3 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 149708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149708&action=edit Bug 33329: Correctly handle UNIMARC encoding for biblios This patch introduces the same treatment we had for bug 32336, this time for Koha::Objects::Record::Collections. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail! Encoding is wrong for UNIMARC! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 22:31:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 20:31:56 +0000 Subject: [Koha-bugs] [Bug 32735] REST API: Add a list endpoint for Authorities In-Reply-To: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32735-70-PHiAkEbAsG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33329 --- Comment #7 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- We might need a follow-up for UNIMARC authorities as of bug 33329. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 [Bug 33329] GET /biblios encoding wrong when UNIMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 22:31:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 20:31:56 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-M6RMLcDek7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32735 [Bug 32735] REST API: Add a list endpoint for Authorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 22:34:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 20:34:59 +0000 Subject: [Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls In-Reply-To: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32932-70-zm4HWmYzGi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 AgustĂ­n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148558|0 |1 is obsolete| | Attachment #148559|0 |1 is obsolete| | Attachment #148560|0 |1 is obsolete| | Attachment #148561|0 |1 is obsolete| | Attachment #149707|0 |1 is obsolete| | --- Comment #34 from AgustĂ­n Moyano <agustinmoyano at theke.io> --- Created attachment 149709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149709&action=edit Bug 32932: Update router to use object references - agreements This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings Signed-off-by: Agustin Moyano <agustinmoyano at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 22:36:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 20:36:14 +0000 Subject: [Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls In-Reply-To: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32932-70-OU91ZLsG0u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #35 from AgustĂ­n Moyano <agustinmoyano at theke.io> --- squashed commits for rebase to apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 23:07:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 21:07:43 +0000 Subject: [Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen In-Reply-To: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23919-70-XF3A8OMr92@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/659 CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 14 23:07:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 21:07:48 +0000 Subject: [Koha-bugs] [Bug 28269] Order search should be possible with ISSN too In-Reply-To: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28269-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28269-70-rYjZJ5HqQB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/659 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 00:07:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 22:07:34 +0000 Subject: [Koha-bugs] [Bug 33513] Batch update from report module - no patrons loaded into view In-Reply-To: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33513-70-fHDX1DUoaD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|batch update from report |Batch update from report |module - no patrons loaded |module - no patrons loaded |into view |into view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 00:46:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 22:46:48 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-VZuDJs3afN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 AgustĂ­n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 00:46:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Apr 2023 22:46:52 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-UCvGS6kuMR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 AgustĂ­n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148097|0 |1 is obsolete| | --- Comment #8 from AgustĂ­n Moyano <agustinmoyano at theke.io> --- Created attachment 149710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149710&action=edit Bug 33169: Build breadcrumbs and left-hand side menu from routes definition -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 22:20:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 20:20:19 +0000 Subject: [Koha-bugs] [Bug 33539] New: Add capitalization checks for branchcodes and categorycodes to inconsistencies script Message-ID: <bug-33539-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33539 Bug ID: 33539 Summary: Add capitalization checks for branchcodes and categorycodes to inconsistencies script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Through import or migrations and maybe other unknown ways you can end up with data that doesn't match the configured codes for libraries and patron categories in terms of capitalization. It would be nice to have some inconsistency checks for this in our scripts. A good starting point would be: * Check holdingbranch/homebranch in items * Check branchcode and categorycode in borrowers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 22:21:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 20:21:21 +0000 Subject: [Koha-bugs] [Bug 32706] User search problem caused by branchcode errors In-Reply-To: <bug-32706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32706-70-P4ZhWw7AAO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32706 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thinking more about it, I think this type of fix is a bit dangerous as we cannot tell what other hidden side effects wrong branchcodes will have, I am pretty sure there will be problems in other areas. I've filed a bug to add a capitalization check to the inconsistencies script: Bug 33539 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 22:21:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 20:21:31 +0000 Subject: [Koha-bugs] [Bug 33539] Add capitalization checks for branchcodes and categorycodes to inconsistencies script In-Reply-To: <bug-33539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33539-70-3aU1lKnX3d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33539 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32706 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 22:21:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 20:21:31 +0000 Subject: [Koha-bugs] [Bug 32706] User search problem caused by branchcode errors In-Reply-To: <bug-32706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32706-70-FQghZVuwvF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32706 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33539 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 22:21:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 20:21:41 +0000 Subject: [Koha-bugs] [Bug 33539] Add capitalization checks for branchcodes and categorycodes to inconsistencies script In-Reply-To: <bug-33539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33539-70-gJVriCS6Z3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33539 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32517 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 22:21:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 20:21:41 +0000 Subject: [Koha-bugs] [Bug 32517] Patron search dies on case mismatch of patron category In-Reply-To: <bug-32517-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32517-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32517-70-fXNpO755eD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32517 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33539 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 22:33:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 20:33:08 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-4uzknTLcsV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Barbara Johnson from comment #9) > I’m not sure. Is there a way to un-apply a patch on a sandbox? Or do I > need to start from scratch with a new one? You can't remove the patch, but you can make another sandbox without entering a bug number to get an installation without any chances for comparison. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 22:40:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 20:40:22 +0000 Subject: [Koha-bugs] [Bug 11585] pubdate index not working well in UNIMARC In-Reply-To: <bug-11585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11585-70-JNv5bEYCh6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11585 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- > However, I don't know what is meant by having the same functionality twice > on the page - I can see it only once in the search pulldown menu. When you click on 'more options' there is a separate date range search on the lower part of the page in staff and the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 22:59:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 20:59:24 +0000 Subject: [Koha-bugs] [Bug 33038] Add classes to patroncategorycode in patronbriefinfo for easier customization In-Reply-To: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33038-70-0zoVI8jZQd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33038 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 22:59:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 20:59:27 +0000 Subject: [Koha-bugs] [Bug 33038] Add classes to patroncategorycode in patronbriefinfo for easier customization In-Reply-To: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33038-70-UdxD3TgNLZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33038 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149698|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149711&action=edit Bug 33038: Add classes to patroncategorycode for easier customization To test: 1. Pull up a patron and look at the patroncategory inside the patronbriefinfo. Description and code are together in one HTML element, they are hard to seperate. 2. Apply patch. 3. Look again and notice the new classes. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 23:01:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 21:01:13 +0000 Subject: [Koha-bugs] [Bug 33038] Add classes to category code and category type in patron brief information for easier customization In-Reply-To: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33038-70-UKIFyjOA2i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33038 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add classes to |Add classes to category |patroncategorycode in |code and category type in |patronbriefinfo for easier |patron brief information |customization |for easier customization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 23:02:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 21:02:22 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-ZCzvTi8Tj0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 23:03:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 21:03:47 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-fN7baEdXqN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx for the patch Caroline - this one has been annoying me forever! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 23:05:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 21:05:00 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-wRwZrPER45@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 23:05:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 21:05:03 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-Zn7lpi7kPf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149693|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149712&action=edit Bug 33533: Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt This patch corrects the HTML markup in order to reunite "Patron identity" or "Organization identity" for translatability. To test: 1. Apply patch 2. Update translation files ./misc/translator/translate update xx-XX 3. Check the xx-XX-staff-prog.po file, the line for memberentrygen.tt:275 should look like \#: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:275 \#, c-format msgid "Organization %sPatron %sidentity" msgstr "IdentitĂ© de l'organisme %sIdentitĂ© de l'utilisateur %s" 4. Optionally, translate the string, install translation and check the page (Patrons > New patron), trying a institutional patron and a regular patron ./misc/translator/translate install xx-XX Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 23:12:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 21:12:55 +0000 Subject: [Koha-bugs] [Bug 9762] Log circulation overrides In-Reply-To: <bug-9762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9762-70-sOVOGRbIvg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Lucas Gass from comment #7) > Solene, > > Most of this is working and this will be a great addition! A few things > though: > > -Do these strings need to translatable? > -This is going to need unit tests. The messages in action_logs are usually not translated, but they are also usually not sentences/text, but data changes in JSON and other machine friendly syntax. Could we use codes instead of plain text and then translate them on the action log viewer? This would make them translatable and we could also adjust the texts easier. I expected to find override in the descriptions or it being a new type of action. Maybe we could be a little bit clearer that these were all override actions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 23:33:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 21:33:41 +0000 Subject: [Koha-bugs] [Bug 33536] If staff member only has catalogue permission, search bar is hidden In-Reply-To: <bug-33536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33536-70-daZooxHYRV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33536 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I've tried and fail to come up with a nice solution here. It looks like we'd need to touch quite a lot of files to change the selected first tab when the permissions are different. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 23:41:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 21:41:13 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-gqZFxlsc8C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 23:41:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 21:41:16 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-I7ZQfwj28l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149625|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149713&action=edit Bug 33505: Improve styling of scan index page This patch makes some changes to the 'scan index' page. * Updates second h1 heading "Scan index:" to h2 level heading "Scan index" * Removes table from the search form * Moves search index pull down and search term into one line * Reorders options with search index first and search term after, matching the advanced search form * Removes the catalog results toolbar from the top, card hold etc. are not needed here. * Fixes doubled up id attribute: scan-index by turning one into scan-index-term. To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Check display, especially search options, options at the top of the page etc. * Apply patch * Verify changes listed above * Regression test the normal search results, all should look the same with and without patch. * If you think the scan index page is nicer now - sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 15 23:42:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 21:42:10 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-Xq9AyTa4s0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Lucas Gass from comment #7) > It definitely looks better! There is a small typo around line 376: > > > [% ELSE %]<option selected="selected" value="">Any word</option[% END %] > > > should be: > > > [% ELSE %]<option selected="selected" value="">Any word</option>[% END %] Hi Lucas, thx for noticing :) I have fixed that for the third (and hopefully last time) now. I hope this one for good (had some problems with the branches building on each other and rebases :( ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 00:21:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 22:21:51 +0000 Subject: [Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace In-Reply-To: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33236-70-MVpQEgHHf2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 00:21:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 22:21:54 +0000 Subject: [Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace In-Reply-To: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33236-70-ZdbL9NLkMV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149103|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149714&action=edit Bug 33236: Move NewSuggestion to Koha::Suggestion->store The NewSuggestion routine saved the suggestion to the DB and returned the id This patch moves the code to Koha::Suggestion->store and handles emailing upon creation, this adds that functionality to suggestions added via api To test: 1 - Apply patch 2 - Test adding a suggestion on the opac and staff client 3 - Confirm the suggestions are added correctly Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 00:21:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 22:21:57 +0000 Subject: [Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace In-Reply-To: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33236-70-zImndu3MK2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149679|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149715&action=edit Bug 33236: (follow-up) Handle new suggestion in ReNewSubscription Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 00:21:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 22:21:59 +0000 Subject: [Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace In-Reply-To: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33236-70-2pBkJqLc8z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149680|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149716&action=edit Bug 33236: (follow-up) Remove export of NewSuggestion Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 00:25:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 22:25:25 +0000 Subject: [Koha-bugs] [Bug 33535] Date range search for Publication Year not working in MARC21 In-Reply-To: <bug-33535-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33535-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33535-70-NJNZTlNcki@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33535 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 00:32:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 22:32:12 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-G1fqBOI9Mo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146918|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149717&action=edit Bug 31432: Make 245$n$p visible by default in frameworks $n (part_number) and $p (part_name) now have their own columns in the database, but we are still hiding them by default. It woudl ease testing and cataloguig if we changed them to be visible by default in new installations. To test: * Check that in your current frameworks when adding a new record, 245 n and p are hidden * Apply the patch and start over: drop your db and run the web installer * Verify that the fields are now visible Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 00:32:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 22:32:44 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-re8m1HuG3L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx Marcel, good catch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 00:40:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 22:40:54 +0000 Subject: [Koha-bugs] [Bug 32306] Hold modifications don't log correctly In-Reply-To: <bug-32306-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32306-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32306-70-AAibIxNxY7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32306 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- > And don't we already do this with some logs? Yep, MEMBERS MODIFY looks like > this: > > UPDATED FIELD(S): branchcode: A => B, dateexpiry: 2023-01-01 => 2024-01-01 I think changing to the way we log patron changes would be really nice and work well for holds changes. It logs before and after and is quite easy to read. But it looks a little differently for me? { "B_address" : { "after" : "", "before" : null }, "B_address2" : { "after" : "", "before" : null }, "B_city" : { "after" : "", "before" : null }, "B_country" : { "after" : "", "before" : null }, "B_email" : { "after" : "", "before" : null }, "B_phone" : { "after" : "", "before" : null }, "B_state" : { "after" : "", "before" : null }, "B_streetnumber" : { "after" : "", "before" : null }, ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 01:03:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 23:03:14 +0000 Subject: [Koha-bugs] [Bug 33513] Batch update from report module - no patrons loaded into view In-Reply-To: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33513-70-CXHMWTqUgd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 01:03:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 23:03:17 +0000 Subject: [Koha-bugs] [Bug 33513] Batch update from report module - no patrons loaded into view In-Reply-To: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33513-70-MSenYg0giO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33513 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149628|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149718&action=edit Bug 33513: (follow-up) Remove whitespace in batch report lists Bug 32368 added whitespaces, remove them. To test: 1 - Create a report like: SELECT biblionumber FROM biblio 2 - Run it 3 - Try the various options from the 'Batch operations' button 4 - The operations don't find the biblios 5 - Create a report like: SELECT cardnumber FROM borrowers 6 - Run it 7 - Test the batch operations 8 - They fail 9 - Apply patch 10 - Run each report again and test batch operations 11 - They work! Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 01:17:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 23:17:39 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-1RswFVM2RG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149605|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149719&action=edit Bug 33512: Change text and add button classes on serial-edit page To test: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. 8. Apply patch. 9. Try 6 & 7 again. The existing items should now read 'Click to edit item' Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 01:17:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 23:17:42 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-W4LvbSJjRt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149720&action=edit Bug 33512: (QA follow-up) Remove 'Click to' from buttons This is following recommendations from accessibility guidelines. It being a link or button already indicates that you need to click it. We don't need to spell it out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 01:18:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 23:18:49 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-7sl6UEioNN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Lucas, I just realized that we had the "Click to..." previous to your patches, but we should not do that. I've added a small follow-up to remove them. It being a link or button already indicates that you can click it, see also accessibility guidelines like: https://www.mtu.edu/accessibility/training/web/link-text/ Hope you agree :) But: The edit/add text change doesn't work perfectly yet: To test: * Add a new subscription creating items on receive * Receive a first issue and create the item * From serial collection check both issues and edit * The unreceived issue in status "arrived also has "Edit item", but there is no item to edit yet I really like this change, can you please have another look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 01:23:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 23:23:57 +0000 Subject: [Koha-bugs] [Bug 33534] catalog New record An error has occurred! Error 500 In-Reply-To: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33534-70-qOSVv1H0td@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33534 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Jen, Bugzilla is only for bugs and enhancement requests, but your problem sounds like a support issue and is therefore better suited for the mailing list or IRC chat. See: https://koha-community.org/support/community-support/ Please make sure you include your exact Koha version and as much information about the bug as you can. If you made any changes to the frameworks or other configuration settings? Did it work before or is this a new installation? The first thing you should do is check the logs on the server for more information if you can. The Plack error log is likely to tell you more about why the error is occurring. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 01:30:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 23:30:07 +0000 Subject: [Koha-bugs] [Bug 33501] Cashup amount should be configurable In-Reply-To: <bug-33501-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33501-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33501-70-XXuwr876hS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33501 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Component|Tools |Fines and fees --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It's not configurable now. I think the feature was written with cash registers in mind. When you do a cash-up, it tells you how much money you need to take out in order to keep a certain amount of change in the register. I am not sure if adding non-cash payment types would complicate this in some way. Adding Martin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 01:32:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 23:32:16 +0000 Subject: [Koha-bugs] [Bug 33472] Error 500 when many items attached to bib record In-Reply-To: <bug-33472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33472-70-p3YCOQ0bKf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33472 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 01:56:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 23:56:05 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32548-70-6g2Wc8FM5S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Pedro Amorim from comment #8) > I think this needs to be properly documented, or included in the fields list > somehow, or maybe a note mentioning this in the UI? I have no idea. I'll be happy to add it to the wiki where we keep hints on the TT notices right now. I just added some first notes on ILL notices: https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit (table at the bottom) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 01:59:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Apr 2023 23:59:24 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-7y1oV2kMeW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Can someone help to get this tested? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 02:02:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 00:02:34 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-egLmJBs0G8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 02:02:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 00:02:37 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-lyVPcwV1y4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148585|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149721&action=edit Bug 33300: (follow-up) DBRev for existing databases Test plan : 1.1) Start from a Koha 22.05 1.2) Upgrade to master => Check the upgrade says : Wrong system preference 'AutomaticWrongTransfer' renamed 'AutomaticConfirmTransfer' 2.1) Start from a Koha 22.05 2.2) Upgrade to 22.11 2.3) Via interface change system preference 'AutomaticConfirmTransfer' and save 2.4) Upgrade to master => Check the upgrade says : Wrong system preference 'AutomaticWrongTransfer' deleted Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 02:06:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 00:06:46 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-xU3sIcCgUj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 02:07:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 00:07:09 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-4fQp9oARxi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I wanted to have a look at this, but bug 31028 needs a rebase. Adding Martin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 02:09:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 00:09:56 +0000 Subject: [Koha-bugs] [Bug 33311] Add preference for voice notices In-Reply-To: <bug-33311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33311-70-U9ec2s0e3u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33311 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- If you enable the PhoneNotification system preference you will get a phone option in the messaging preferences table. There is also a new field "main contact method" that can be edited by the patron in the OPAC and be set to one of the phone options. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 02:11:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 00:11:16 +0000 Subject: [Koha-bugs] [Bug 33318] [21.11] Advanced editor doesn't load in 21.11.x In-Reply-To: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33318-70-j8YUn7aInm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Advanced editor doesn't |[21.11] Advanced editor |load in 21.11.x |doesn't load in 21.11.x Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 02:12:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 00:12:01 +0000 Subject: [Koha-bugs] [Bug 33318] [21.11] Advanced editor doesn't load in 21.11.x In-Reply-To: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33318-70-AQzepFUwVg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 02:26:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 00:26:16 +0000 Subject: [Koha-bugs] [Bug 20913] Allow multiple if/unless statements in MARC modification template actions by adding AND/OR qualifiers In-Reply-To: <bug-20913-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20913-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20913-70-vwAFCNTtTC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20913 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Component|Tools |Cataloging Summary|allow multiple if/unless |Allow multiple if/unless |statements in MARC |statements in MARC |modification template |modification template |actions by adding AND/OR |actions by adding AND/OR |qualifiers |qualifiers Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 02:28:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 00:28:22 +0000 Subject: [Koha-bugs] [Bug 21762] ES: Is it possible to differentiate between any and anywhere? In-Reply-To: <bug-21762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21762-70-atP24fvQiL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21762 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Marcel, can this be closed with Nick's reply? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:24:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:24:05 +0000 Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22375-70-MjOdAKYOqL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:24:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:24:08 +0000 Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22375-70-khB3EC6Ldp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85331|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149722&action=edit Bug 22375: Format due date consistantly Test plan: Make some daily an hourly checkouts and confirm the right display (hourly with hours and minutes, daily only date) of due date on these places: 1) catalogue -> checkout history 2) circulation -> overdues with fines 3) <already fixed> 4) circulation -> pending on site checkouts 5) patrons circulation history 6) opac -> account summary -> relatives checkouts Note: I suspect the moremember-receipt.tt template is not used anymore Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:24:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:24:10 +0000 Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22375-70-CkvAf26tR1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149723&action=edit Bug 22375: (follow-up) Format even more due dates consistently To test: Create some checkouts in future and past, make sure to include some with a time != 23:59.CirculateILL Verify that the due date is displayed correctly on: * Catalog detail page > Items tab > Checkout status * Circulation start page > Renew > Renew one of your checkouts > dialog message * ILL request page: requires ILL setup and CirculateILL system preference * Patron acccount in staff > Print > Print summary * Catalog detail page > Holds > search for patron > due date on checked out items * Recalls: * Activate UseRecalls system preference, set up circulation rules to allow recalls * Checkout an item to another user * In the OPAC, place a recall on that record with yor use * Check "Recall a specific item" * Verify due date in item list * Place recall on checked out item * Patron account in OPAC > Recalls history (due date might have been changed through recall) * OPAC patron account > Summary > Overdue tab * Self checkout: * Activate WebBasedSelfCheck * Go to <opacbaseurl>/cgi-bin/koha/sco/sco-main.pl * Log in > Tab checkouts Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:25:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:25:55 +0000 Subject: [Koha-bugs] [Bug 22375] Due dates should be formatted consistently In-Reply-To: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22375-70-0mARxm0MT0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22375 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Owen Leonard from comment #2) > (In reply to Josef Moravec from comment #1) > > Everything looks like it's working well except this page: > > > 3) batch checkouts > > I get an error on that page. This file is no longer included in the patch set (already fixed). > > Note: I suspect the moremember-receipt.tt template is not used anymore > > Yes, which is causing a conflict when apply this patch! This file has been deleted meanwhile and is also not included. I found some more and wrote up a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:31:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:31:25 +0000 Subject: [Koha-bugs] [Bug 23650] Multiple opac-restrictedpage.pl pages In-Reply-To: <bug-23650-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23650-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23650-70-Ic7n2SaQHi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23650 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Maybe instead of building this on top of the restrictedpage setting, the new Pages could be used here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:31:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:31:45 +0000 Subject: [Koha-bugs] [Bug 23650] Restrict access to pages by home library or patron category In-Reply-To: <bug-23650-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23650-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23650-70-pmEpL7kBqm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23650 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Multiple |Restrict access to pages by |opac-restrictedpage.pl |home library or patron |pages |category -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:33:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:33:26 +0000 Subject: [Koha-bugs] [Bug 23269] Long hold queues are slowing the service In-Reply-To: <bug-23269-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23269-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23269-70-XYlSaUUv7q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Maybe this would be another candidate to be moved to the REST API? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:40:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:40:19 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: <bug-23415-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23415-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23415-70-iRRs4800OY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle at bywatersolutions.com |testopia at bugs.koha-communit | |y.org Status|Signed Off |Patch doesn't apply --- Comment #55 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23415: Notify patron fines when renewing Applying: Bug 23415: Add missing filters Applying: Bug 23415: Use OPACFineNoRenewals instead of noissuecharge error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt). error: could not build fake ancestor Patch failed at 0001 Bug 23415: Use OPACFineNoRenewals instead of noissuecharge hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23415-Use-OPACFineNoRenewals-instead-of-noissu-dlItcl.patch Please also check the fine formatting as noted by Sally in comment#54. There is now also a way to format in JS afaik. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:45:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:45:36 +0000 Subject: [Koha-bugs] [Bug 23824] Add a 'Save and run' button to reports In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-p7mwVE73Lh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Summary|Add a ‘Save and run’ button |Add a 'Save and run' button |to reports |to reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:45:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:45:57 +0000 Subject: [Koha-bugs] [Bug 23824] Add a 'Save and run' button to reports In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-3RgtFjcr6Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|michalurban177 at gmail.com |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:46:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:46:15 +0000 Subject: [Koha-bugs] [Bug 23824] Add a 'Save and run' button to reports In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-Kf1isjfEuJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:46:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:46:18 +0000 Subject: [Koha-bugs] [Bug 23824] Add a 'Save and run' button to reports In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-ZnGQH70p8u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149724&action=edit Bug 23824: Add a "Save and run" button to reports This will save one click every time you want to save and then run a report. To test: - Apply this patch - Create a new report - Click the new "Update and run SQL" button - Verify the report was saved and the results are displayed Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:49:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:49:12 +0000 Subject: [Koha-bugs] [Bug 18348] SHOW_BCODE should be a column of the borrowers table In-Reply-To: <bug-18348-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18348-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18348-70-xdZ5SLiI5v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18348 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It would be really interesting to get feedback on this from libraries using it. I think it was introduced with the extended patron attributes, maybe as some kind of example? But I never quite understood the use case. Maybe we could even do without? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:50:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:50:12 +0000 Subject: [Koha-bugs] [Bug 18496] Membership renewal fee In-Reply-To: <bug-18496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18496-70-54uB9Nf59c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18496 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|amitddng135 at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:51:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:51:07 +0000 Subject: [Koha-bugs] [Bug 18618] Mana - Add reading suggestions (crontab and scripts for Koha) In-Reply-To: <bug-18618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18618-70-YO2HjPWipb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18618 --- Comment #40 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Any update on this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:52:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:52:21 +0000 Subject: [Koha-bugs] [Bug 12015] Google map of libraries and availability In-Reply-To: <bug-12015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12015-70-fEoVYvNyqk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12015 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|google map of branches and |Google map of libraries and |availability |availability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 03:53:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 01:53:37 +0000 Subject: [Koha-bugs] [Bug 11022] Reorganize or rename French unimarc frameworks In-Reply-To: <bug-11022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11022-70-VK2YLFBAUm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11022 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Reorganize or rename french |Reorganize or rename French |unimarc frameworks |unimarc frameworks --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to David Cook from comment #1) > Closing this one due to age I think it is also outdated with the installer files having moved to yaml. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 09:34:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 07:34:58 +0000 Subject: [Koha-bugs] [Bug 33540] New: Add death date for deceased patron Message-ID: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33540 Bug ID: 33540 Summary: Add death date for deceased patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: giuseppe.angilella at ct.infn.it QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a patron dies, one shouldn't simply remove the patron from the database, in order to keep track of the patron's past circulation history. However, setting the expiration date to the patron's death date doesn't prevent the system from increasing the patron's age (indefinitely, as time passes), which is then displayed in the patron's details. I would then suggest to introduce some "death_date" additional field to the patrons table, and modify moremember.pl to compute the final age using death_date rather than the current (today's) date, whenever death_date is nonempty. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 11:55:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 09:55:45 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18829-70-fACDZ52RCa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 --- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It looks like this broke one test on master: https://jenkins.koha-community.org/job/Koha_Master/2479/testReport/junit/(root)/t_00_testcritic_t/Test__Perl__Critic_for__catalogue_showelastic_pl___1972_/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 11:55:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 09:55:52 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18829-70-4iQe6DqC2p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 12:00:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 10:00:56 +0000 Subject: [Koha-bugs] [Bug 33229] Patron reading history should be cleared when privacy set to never In-Reply-To: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33229-70-hE7v6dPk1j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33229 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Nick, git bisect (not me!) blames you for the failing test on master: https://jenkins.koha-community.org/job/Koha_Master/2479/testReport/junit/(root)/t_db_dependent_Koha_Hold_t/fill___tests__1624_/ I had a look, but couldn't figure it out: # Failed test 'fill() tests' # at t/db_dependent/Koha/Hold.t line 307. Exception 'Koha::Exceptions::SysPref::NotSet' thrown 'Required syspref is not set' with syspref => AnonymousPatron # Looks like your test exited with 255 just after 2. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 10/11 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 12:09:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 10:09:51 +0000 Subject: [Koha-bugs] [Bug 33540] Add death date for deceased patron In-Reply-To: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33540-70-sgT1HVqW50@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33540 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement Version|unspecified |master --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I wonder about this in terms of data privacy and GDPR, I'd say we should delete this data once all outstanding checkouts/fines have been taken care of. And I am not sure if we should encourage libraries to keep this kind of data by adding a specified field. It sounds like you would like to freeze the age, so a patron attribute would not quite work for you. Would be interesting to get some more input here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 12:21:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 10:21:15 +0000 Subject: [Koha-bugs] [Bug 24806] Syspref ILLOpacbackends can not be disabled In-Reply-To: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24806-70-fMm8nAZm49@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24806 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Pedro Amorim from comment #14) > (In reply to Hans PĂ„lsson from comment #13) > > it would be > > more logical to say what backends should be visible, since all are addons to > > Koha (mainly plugins). > > Hi Hans! > The workflow I'm proposing is: as soon as you install a backend, it's > enabled and showing by default for both Staff and OPAC, as I believe this is > likely the intent (and expectation) of most ILL backend installations (I may > be wrong here, of course!). > > This change in the sys pref would provide the option of hiding in the OPAC > any one, or more - or all - installed backends, an improvement over the > current functionality that does not allow for hiding all the backends in the > OPAC. > > Apologies if not clear enough! Any input or alternative suggestion is > welcome. I believe it was done the currnet way for technical reasons. I am not sure if it's possible to detect all installed backends (probably that is possible), but it might be harder to trigger an update to pref at the time a backend is installed, without each backend implementing the update itself. I guess when this was added the intent was not to be disruptive/change current behaviour and not to enforce backend providers to change. Ideally we should display a list of installed backends in a list, so people just need to check/uncheck. Maybe an "all" or "always hide" option could work? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 12:29:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 10:29:15 +0000 Subject: [Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss In-Reply-To: <bug-32464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32464-70-SuCgg2iDtP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It looks like the mss option was added 4 years ago by Tomas and removed 2 years ago by Joubu: https://git.koha-community.org/Koha-community/Koha/blame/commit/b52c7d7b3664b81b41bade88cbb3491dcdb81693/Koha/Item.pm#L851 Nick, Tomas and Joubu - maybe you could resolve that between the three of you? It looks as Frido's patch is correct, because passing mss won't have any effect in the current codebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 12:29:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 10:29:41 +0000 Subject: [Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss In-Reply-To: <bug-32464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32464-70-lr3NCjqdQ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- If we decide to bring it back... can it get a nicer/more telling name? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 12:36:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 10:36:26 +0000 Subject: [Koha-bugs] [Bug 33247] Deleted authority still on results list In-Reply-To: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33247-70-iTHU5VviEi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33247 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I can confirm this behavior in current master. The index update usually happens almost immediately, but only almost and the page load/search appears to be a little faster. I am really not sure how this could be helped. Maybe we could show a "success" dialog page first to gain some time, but then we lose a bit of usability. Waiting for the index also seems like a bad idea as it could be stuck for a little when a lot of operations need to be done. Maybe someone else has a good idea? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 12:42:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 10:42:50 +0000 Subject: [Koha-bugs] [Bug 33253] 2FA - Form not excluded from autofill In-Reply-To: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33253-70-AjZHnDHlFj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33253 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Version|22.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 12:45:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 10:45:37 +0000 Subject: [Koha-bugs] [Bug 33253] 2FA - Form not excluded from autofill In-Reply-To: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33253-70-xP3BLOa33h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33253 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 12:49:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 10:49:25 +0000 Subject: [Koha-bugs] [Bug 33253] 2FA - Form not excluded from autofill In-Reply-To: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33253-70-dxxX6CzI2B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33253 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 12:49:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 10:49:27 +0000 Subject: [Koha-bugs] [Bug 33253] 2FA - Form not excluded from autofill In-Reply-To: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33253-70-ri0r2drAtL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33253 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149725&action=edit Bug 33253: Turn off autocompletion for 2FA authentication code The form for entering your authentication code shoudl not suggest previous codes. To test: * Activate TwoFactorAuthentication * Go to your patron account in staff * More > Manage 2-factor authentication * I used "Google authenticator" on my phone, so: * Open app on your phone, add new and scan the QR code * Enter activation code * Log out of staff interface * Log back in, you are now also asked for an authentication code as second step * Look up code in app, enter, get logged in * Log out, log back in - the form now suggests the previous code when you click on it * Apply patch * Reload things (restart_all on ktd) * Verify that you no longer get the suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 12:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 10:54:31 +0000 Subject: [Koha-bugs] [Bug 33253] 2FA - Form not excluded from autofill In-Reply-To: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33253-70-eazUGPc979@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33253 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx for filing Sam! Maybe you want to test? It should work on the sandboxes too: https://wiki.koha-community.org/wiki/Sandboxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 12:57:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 10:57:29 +0000 Subject: [Koha-bugs] [Bug 32327] When replacing bib record via z39.50, only 1 ISBN should be searched and it should be normalized In-Reply-To: <bug-32327-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32327-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32327-70-kFkOHuEjYR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32327 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Manos PETRIDIS from comment #2) > Or all ISBNs should be searched -each in normalised form- and the results be > aggregated before reaching the results window. This would be more close to > "search according to data already existing in the current entry". While this would be the ideal solution, I would require quite a bit more of work. The solution Andrew suggests would work well for an immediate fix to the bug and we could also easily backport to stable releases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:00:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:00:38 +0000 Subject: [Koha-bugs] [Bug 33228] All charges should be displayed on the patron checkout page In-Reply-To: <bug-33228-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33228-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33228-70-U9DEpddbRP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33228 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14803 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Trying to make sure we have all information needed here: * Is this about the patron account in staff interface, the patron account in OPAC or the self checkout display (web based/SIP2 based?) For rentals and staff there is also an old bug here: bug 14803 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:00:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:00:38 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: <bug-14803-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14803-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14803-70-9SldCyGjnk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33228 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:02:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:02:04 +0000 Subject: [Koha-bugs] [Bug 31298] Framework defaults don't work when adding records to basket from external source In-Reply-To: <bug-31298-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31298-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31298-70-ED448NrgoX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31298 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I believe this is resolved by 30250 now being pushed and available from 21.11.18. *** This bug has been marked as a duplicate of bug 30250 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:02:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:02:04 +0000 Subject: [Koha-bugs] [Bug 30250] Configure when to apply framework defaults when cataloguing In-Reply-To: <bug-30250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30250-70-DKLKnAsujr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30250 --- Comment #47 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 31298 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:03:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:03:14 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-lceDKiipLU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SIP fee paid messages |SIP fee paid messages |explode if payment |explode if payment |registers are enabled and |registers are enabled and |the sip account has no |the SIP account has no |register |register --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Kyle, should this be Needs Signoff? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:04:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:04:37 +0000 Subject: [Koha-bugs] [Bug 31231] Link authorities automatically does not always work In-Reply-To: <bug-31231-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31231-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31231-70-dojVxKG1ff@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31231 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Nick, can you maybe tell how this relates to your recent work on auth linking? Maybe one of the other bugs will resolve? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:10:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:10:57 +0000 Subject: [Koha-bugs] [Bug 33238] (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-kLGRL9IJu4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:11:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:11:00 +0000 Subject: [Koha-bugs] [Bug 33238] (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-K8BBDDEHDA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148245|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149726&action=edit Bug 33238 (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions. In errorlog you would find "DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous". Test plan: ========== 1. Have a Koha instance with IndependentBranches, some accepted suggestions, and a vendor defined. 2. Be a non superlibrarian librarian with permissions to manage acquisitions. 3. Create a new basket and try to add an item to the basket "From a suggestion". 4. Koha would generate error 500. 5. Apply the patch. 6. Try to add an item to the basket "From a suggestion". 7. You should succeed. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:11:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:11:30 +0000 Subject: [Koha-bugs] [Bug 33238] (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-i2hRXTrilu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Using QAM privilege to put this straight to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:33:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:33:13 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-7S262bo2wm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:33:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:33:15 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-C9cKWG9JCI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149727&action=edit Bug 32931: Fix translatability issues on 'new agreement' form This fixes the "Yes" and "No" options and "License info" placeholder. To get to the options: 1. Enable the ERMModule system preference 2. Go to E-resource management 3. Click "Agreements" 4. Click "New agreement" --> Field "Is perpetual", options are Yes and No --> At the bottom of the form "License info" with "License info" within the input field 5. Install (complete) language, verify those are not translated 6. Apply patch 7. Update po files 8. Verify strings exist for this file, translate if necessary 9. Re-install language 10. Verify strings are now translated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:34:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:34:29 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-unxGZ0Ex4m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I believe I found a fix for the form... but I couldn't see where the other Yes/No (from comment 1) might go wrong. Adding Jonathan and attaching my patch. Caroline, maybe you want to test if that fixes the form for you too? The form/label layout is also a bit broken, but I see the same on master without my change. You might need to do a yarn build after applying the patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:35:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:35:53 +0000 Subject: [Koha-bugs] [Bug 32464] Koha::Item->as_marc_field obsolete option mss In-Reply-To: <bug-32464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32464-70-XBZaZCiDKu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32464 --- Comment #11 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- I loved my first implementation performance. Don't remember why it was removed. I would have kept it, as it was an optional parameter, to be used where it makes sense. mss stands for 'marc subfield structure'. It is named like that everywhere as far as I can tell. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 13:56:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 11:56:56 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-Q0XHMF8Prv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Component|Searching |Searching - Zebra Version|21.11 |master QA Contact|testopia at bugs.koha-communit | |y.org | Summary|copyright symbol |Zebra: Ignore copyright | |symbol when searching --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- For searching you should catalog the normalized date in 008 7-10, this will be used for date range search and might improve things a bit. I will also attach patches that work for ignoring © with Zebra. I am not sure if a change is needed for Elasticsearch (cannot test it currently) and I would not know where to make the changes. If you are using Elastisearch and can confirm this is a problem there too, would you mind filing another bug for the "Searching - Elasticsearch" component? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:02:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:02:51 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-hsw6pUJY5D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:02:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:02:53 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-LViCk3DYa8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149728&action=edit Bug 32937: Make Zebra ignore the copyright symbol in searches It's common to catalog the year with the copyright symbol attached to it. This creates some issues with search that we can fix by adding the © to the list of characters Zebra ignores in search. To test: * Search for any existing publication year with ©, example: ©1951 * Verify your record is not found * Add the copyright symbol to a record, verify it's now found with ©, but not without * Apply patch * On ktd: * sudo cp -i /kohadevbox/koha/etc/zebradb/etc/word-phrase-utf.chr /etc/koha/zebradb/etc/word-phrase-utf.chr * sudo koha-zebra --restart kohadev * sudo koha-mysql kohadev * DELETE FROM biblio WHERE biblionumber = 369; * The reindex woudl fail for me with this broken record present. * sudo koha-rebuild-zebra -f kohadev * Repeat searches, the records should be found when searching with and without ©. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:03:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:03:15 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-ephjBwKfJu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:08:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:08:33 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-57U9Nn7ZDF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:25:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:25:22 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-UpedrYHjf3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:25:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:25:25 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-nYHtuBd2Nz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149729&action=edit Bug 32917: Fix sample notice for CHANGE_PASSWORD We've identified 3 issues: * Name of patron is not showing up in subject line * Name of patron is now showing in notice text * Notice is set to be HTML, but has no line breaks and uses no HTML tags In the database update, these issues don't occur: $dbh->do( q{ INSERT IGNORE INTO letter (module, code, name, title, content, message_transport_type) VALUES ('members', 'PASSWORD_CHANGE', 'Notification of password change', 'Library account password change notification', "Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nWe want to notify you that your password has been changed. If you did not change it yourself (or requested that change), please contact library staff.\r\n\r\nYour library.", 'email'); }); So this patch will make them match up: * Remove HTML flag * Update patron. to borrower. in message text * Remove patron name from subject (it won't work even with the correct variables) To test: * Add an email address to your favourite sample user * Make sure NotifyPasswordChange is set to "Notify" * Update the sample user's password using the "change password" feature * Verify a notice is shown in the notices tabs Note: you won't see the line break issue there because of bug 30287 * Apply patch * Recreate your database/run web installer so sample notices are loaded * Repeat the test, it should generate a nice lookig notice now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:29:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:29:51 +0000 Subject: [Koha-bugs] [Bug 30277] Make fetching ILL data from the API more efficient In-Reply-To: <bug-30277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30277-70-ui8ah6TrdZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30277 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Maybe this was fixed by some work from the hackfest? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:31:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:31:32 +0000 Subject: [Koha-bugs] [Bug 30265] Hide 'Log into your account' in OPAC authentication page In-Reply-To: <bug-30265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30265-70-L9xbRs25DC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30265 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Fridolin Somers from comment #11) > OK lets keep it. +1 Should we remove the non-functional JS then? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:34:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:34:43 +0000 Subject: [Koha-bugs] [Bug 27642] Add notes to receipts In-Reply-To: <bug-27642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27642-70-m0bSQGS9ld@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27642 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- > Maybe the series info could be on another bug. I'd move it. Maybe that could somehow be done on top of bug 32986. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:35:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:35:10 +0000 Subject: [Koha-bugs] [Bug 27642] Add notes to circulation receipts at time of printing In-Reply-To: <bug-27642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27642-70-s2aiLspB97@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27642 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add notes to receipts |Add notes to circulation | |receipts at time of | |printing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:35:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:35:51 +0000 Subject: [Koha-bugs] [Bug 27765] Set a custom order to library branches on opac-library.pl In-Reply-To: <bug-27765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27765-70-bV1Gr3oalN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27765 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It might also be interesting to use this in other places, like as a default sort option for items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:46:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:46:26 +0000 Subject: [Koha-bugs] [Bug 28029] Add ability to use OFFSET in SQL reports In-Reply-To: <bug-28029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28029-70-UPUuJs4Iv4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28029 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |trivial Version|20.05 |master --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It looks like the MariaDB version on ktd is too old to test this: 10.5.19-MariaDB-1:10.5.19+maria~ubu2004 The error I get indicates that the SQL statement was used as I entered it, but that the DBMS doesn't support it. So I think a change in Koha might not be needed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '10 Joe, can you verify you were testing with 10.6 or later? MariaDB: https://mariadb.com/kb/en/select-offset-fetch/ MySQL seems to have had it for a while: https://dev.mysql.com/doc/refman/8.0/en/select.html https://dev.mysql.com/doc/refman/5.7/en/select.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:47:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:47:40 +0000 Subject: [Koha-bugs] [Bug 28395] Allow patron enrollment period to be set in days for patron categories In-Reply-To: <bug-28395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28395-70-8AMja6eCYN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28395 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|allow patron enrollment |Allow patron enrollment |period to be set in days |period to be set in days |for patron categories |for patron categories Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:51:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:51:16 +0000 Subject: [Koha-bugs] [Bug 28691] Quick spine label should split the same way the label creator does / use splitting rules In-Reply-To: <bug-28691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28691-70-7lPGr3CsPX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28691 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Quick Spine Label should |Quick spine label should |split the same way the |split the same way the |Label Creator does |label creator does / use | |splitting rules Severity|normal |enhancement --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I believe the quick spine labels just break on spaces. You can add a lot of logic using JS and CSS, but that's quite painful. Using the splitting rules makes a lot of sense here, I'll mark bug 32021 as a duplicate of this, as the general problem is the splitting rules not being used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:51:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:51:39 +0000 Subject: [Koha-bugs] [Bug 23021] Quick Spine Label Creator doesn't use regex splitting rule In-Reply-To: <bug-23021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23021-70-OtfomB1FdH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23021 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 28691 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:51:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:51:39 +0000 Subject: [Koha-bugs] [Bug 28691] Quick spine label should split the same way the label creator does / use splitting rules In-Reply-To: <bug-28691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28691-70-IMZyF9H7Qy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28691 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 23021 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:54:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:54:39 +0000 Subject: [Koha-bugs] [Bug 27188] Show current class in plugins home In-Reply-To: <bug-27188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27188-70-smgFZIcddT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27188 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I believe the page/table have changed since, any chance to revive? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:55:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:55:42 +0000 Subject: [Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page In-Reply-To: <bug-13614-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13614-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13614-70-il84fqetxY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #13) > Did we forget to remove koha-tmpl/intranet-tmpl/prog/js/basketgroup.js? We did, but fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 14:57:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 12:57:47 +0000 Subject: [Koha-bugs] [Bug 23604] Multiple partners with the same email address causes all to be emailed In-Reply-To: <bug-23604-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23604-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23604-70-EAvc6FMrRl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23604 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 15:50:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 13:50:55 +0000 Subject: [Koha-bugs] [Bug 33326] When adding an item to a basket from a purchase suggestion SUGGEST_FORMAT is lost In-Reply-To: <bug-33326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33326-70-tX5XWgK0hx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33326 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Juliet Heltibridle from comment #1) > It seems strange to me that the options for patrons to choose from are a > separate authorized value instead of just using the item types in the > system. But if that's not possible, we do need a way to retain the > suggestion requested format through the ordering process, so there is no > confusion for staff on what the patron wanted. It used to be the item types... then libraries wanted to be able to change them. The issue is, I think, that not for all libraries item types reflect material types, and that makes a lot of sense. For academic libraries you'll be more likely to find things like 'overnight loan' 'reference' or 'normal loan'. That would not be helpful in the ordering process. But I fully agree that it only makes sense if we pull it through somehow. Would showing it on the list of suggestions where you pick them for ordering work? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 15:59:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 13:59:51 +0000 Subject: [Koha-bugs] [Bug 33541] New: Show 'Document type' in list of suggestions when creating an order from a suggestion Message-ID: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Bug ID: 33541 Summary: Show 'Document type' in list of suggestions when creating an order from a suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 16:00:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 14:00:29 +0000 Subject: [Koha-bugs] [Bug 33326] When adding an item to a basket from a purchase suggestion SUGGEST_FORMAT is lost In-Reply-To: <bug-33326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33326-70-gK1AgSdpPL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33326 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33541 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #2) > > Would showing it on the list of suggestions where you pick them for ordering > work? Bug 33541 - Show 'Document type' in list of suggestions when creating an order from a suggestion Ready for testing in a few minutes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 16:00:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 14:00:29 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-MKeRUvLxQ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33326 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 16:17:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 14:17:07 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-dZow8Z4ktI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 16:17:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 14:17:10 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-ZHZsPoJudH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149730&action=edit Bug 33541: Add document type to list of suggestions when ordering This adds the document type (suggestions.itemtype) to the list of accepted suggestions when creating an order from a suggestion. To test: * Add some suggestions and make sure to pick different document types. * Accept those suggestions in the staff interface. * Go to acquisitions * Create a basket * Add an 'order from a suggestion' * Verify that the list shows the 'document type' nicely and correctly * Order one, all good? sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 16:18:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 14:18:59 +0000 Subject: [Koha-bugs] [Bug 30277] Make fetching ILL data from the API more efficient In-Reply-To: <bug-30277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30277-70-4prWgsRz9W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30277 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- This is already being worked on bug 22440. With great results. The UI details are looked after by Pedro *** This bug has been marked as a duplicate of bug 22440 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 16:18:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 14:18:59 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-Bt5QI9AzGL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- *** Bug 30277 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 16:19:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 14:19:00 +0000 Subject: [Koha-bugs] [Bug 32626] [Omnibus] Improve REST API for ILL In-Reply-To: <bug-32626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32626-70-XiYJOWps1Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32626 Bug 32626 depends on bug 30277, which changed state. Bug 30277 Summary: Make fetching ILL data from the API more efficient https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30277 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 16:20:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 14:20:21 +0000 Subject: [Koha-bugs] [Bug 33540] Add death date for deceased patron In-Reply-To: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33540-70-nu6Y7UjL5d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33540 --- Comment #2 from giuseppe.angilella at ct.infn.it --- How about then computing the patron's age until the patron's expiration date, if nonempty? This wouldn't require adding any field (and associate it to any specific event, such as the patron's death), but would prevent the system showing ages in principle increasing indefinitely. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 16:21:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 14:21:05 +0000 Subject: [Koha-bugs] [Bug 18280] Prevent duplicate barcodes being created with autBarcode In-Reply-To: <bug-18280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18280-70-miItJcQNaF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18280 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to TomĂĄs Cohen Arazi from comment #1) > What if... Koha locked the barcode on cataloguing instead, and the barcode > got calculated on saving? I think this would work and avoid some of the known issues. We also do it for cardnumbers, so why not for barcodes :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 16:23:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 14:23:08 +0000 Subject: [Koha-bugs] [Bug 19249] Date picker broken in "Quick add new patron" form In-Reply-To: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19249-70-G1mF1OnvAE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19249 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Updating severity - this is a bad issue and we have kept it around for too long. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 16:48:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 14:48:37 +0000 Subject: [Koha-bugs] [Bug 33540] Add death date for deceased patron In-Reply-To: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33540-70-7mp9RZ9CNN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33540 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Let's take a step back: why is the computing of the age important? I don't think we should stop for expired accounts, it's still a good information in most use cases. And expiration and age are not really linked in any way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 17:11:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 15:11:42 +0000 Subject: [Koha-bugs] [Bug 33540] Add death date for deceased patron In-Reply-To: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33540-70-yzSYZtc78K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33540 --- Comment #4 from giuseppe.angilella at ct.infn.it --- I think that originally the reason why the age of a patron should be displayed was to help the librarian to identify the patron as an adult or otherwise, and therefore to conclude whether restrictions should be applied. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 17:48:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 15:48:24 +0000 Subject: [Koha-bugs] [Bug 33540] Add death date for deceased patron In-Reply-To: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33540-70-xjZbzjyqYM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33540 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I assume you wouldn't keep the data of deceased patrons very long. Also you wouldn't want to check out any new items, so circulation rules would be irrelevant. What I would probably do is to create a restriction of type "DECEASED" and set that. That would restrict the account and at the same time make it clear what happened. It would also be easily possible to use that in reports and the like. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 18:40:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 16:40:12 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-tvjWXjhRYi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149730|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149731&action=edit Bug 33541: Add document type to list of suggestions when ordering This adds the document type (suggestions.itemtype) to the list of accepted suggestions when creating an order from a suggestion. To test: * Add some suggestions and make sure to pick different document types. * Accept those suggestions in the staff interface. * Go to acquisitions * Create a basket * Add an 'order from a suggestion' * Verify that the list shows the 'document type' nicely and correctly * Order one, all good? sign off. Signed-off-by: Juliet <jheltibridle at rcplib.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 18:41:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 16:41:05 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-5jX16uphmL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- That was fast! Thank you, Juliet! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 18:44:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 16:44:10 +0000 Subject: [Koha-bugs] [Bug 33326] When adding an item to a basket from a purchase suggestion SUGGEST_FORMAT is lost In-Reply-To: <bug-33326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33326-70-LxD7pXSTpT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33326 --- Comment #4 from Juliet Heltibridle <jheltibridle at rcplib.org> --- The reasoning for making the values different makes sense, we don't want our patrons to have to pick between Book, New Book and Children's Book either. It would be nice to retain that information in some way on the page where you actually add the order, but having it in the suggestions table will help a lot. Looks good in the attached bug, signed off on that one. Thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:23:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:23:56 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13976-70-lO4s5SyhiP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:23:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:23:58 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13976-70-bjCNnul8At@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 --- Comment #30 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:00 +0000 Subject: [Koha-bugs] [Bug 25590] Street number is missing from alternate address in the OPAC In-Reply-To: <bug-25590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25590-70-jAZ0QmxZSI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:02 +0000 Subject: [Koha-bugs] [Bug 25590] Street number is missing from alternate address in the OPAC In-Reply-To: <bug-25590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25590-70-vywpIUm72L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25590 --- Comment #12 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:08 +0000 Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server In-Reply-To: <bug-31259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31259-70-7EcezfgMdK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:10 +0000 Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server In-Reply-To: <bug-31259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31259-70-DFCuy1xXwt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 --- Comment #20 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:11 +0000 Subject: [Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports of C4::AuthoritiesMarc In-Reply-To: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32279-70-RcAiSn2LUk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:13 +0000 Subject: [Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports of C4::AuthoritiesMarc In-Reply-To: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32279-70-ApwNA6e3wh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:15 +0000 Subject: [Koha-bugs] [Bug 32280] Export method ImportBreedingAuth from C4::Breeding In-Reply-To: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32280-70-5bp7TkezqG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:16 +0000 Subject: [Koha-bugs] [Bug 32280] Export method ImportBreedingAuth from C4::Breeding In-Reply-To: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32280-70-W9UoTBrZik@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:18 +0000 Subject: [Koha-bugs] [Bug 32437] When adding to a basket form a staged file and matching the imported records are ignored when set to overwrite In-Reply-To: <bug-32437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32437-70-hhLDJLUjZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:19 +0000 Subject: [Koha-bugs] [Bug 32437] When adding to a basket form a staged file and matching the imported records are ignored when set to overwrite In-Reply-To: <bug-32437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32437-70-t5yU5gLQdq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 --- Comment #40 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:21 +0000 Subject: [Koha-bugs] [Bug 32447] In items table barcode column can not be filtered In-Reply-To: <bug-32447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32447-70-a2tQtHBShl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32447 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:23 +0000 Subject: [Koha-bugs] [Bug 32447] In items table barcode column can not be filtered In-Reply-To: <bug-32447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32447-70-89SERIVmXX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32447 --- Comment #18 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:24 +0000 Subject: [Koha-bugs] [Bug 32850] Fix cataloguing/value_builder/unimarc_field_124.pl In-Reply-To: <bug-32850-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32850-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32850-70-GxB2Imh2PT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32850 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:26 +0000 Subject: [Koha-bugs] [Bug 32850] Fix cataloguing/value_builder/unimarc_field_124.pl In-Reply-To: <bug-32850-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32850-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32850-70-AuSAR4gsvZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32850 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:28 +0000 Subject: [Koha-bugs] [Bug 32976] Patron image Add/Edit button should not appear if permission is turned off In-Reply-To: <bug-32976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32976-70-alQfzh1FJu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:30 +0000 Subject: [Koha-bugs] [Bug 32976] Patron image Add/Edit button should not appear if permission is turned off In-Reply-To: <bug-32976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32976-70-fb58kTHe9j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32976 --- Comment #7 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:31 +0000 Subject: [Koha-bugs] [Bug 33148] Use template wrapper for breadcrumbs: Cataloging In-Reply-To: <bug-33148-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33148-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33148-70-9dy9gnpyEl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33148 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:33 +0000 Subject: [Koha-bugs] [Bug 33148] Use template wrapper for breadcrumbs: Cataloging In-Reply-To: <bug-33148-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33148-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33148-70-E2Oal9H5VH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33148 --- Comment #7 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:35 +0000 Subject: [Koha-bugs] [Bug 33149] Use template wrapper for breadcrumbs: Circulation part 1 In-Reply-To: <bug-33149-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33149-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33149-70-yr7zjZVTYL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:36 +0000 Subject: [Koha-bugs] [Bug 33149] Use template wrapper for breadcrumbs: Circulation part 1 In-Reply-To: <bug-33149-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33149-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33149-70-u5jUVZpgSU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:40 +0000 Subject: [Koha-bugs] [Bug 33285] It should be possible to specify the separator used in runreport.pl In-Reply-To: <bug-33285-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33285-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33285-70-OZmWC01qg7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:42 +0000 Subject: [Koha-bugs] [Bug 33285] It should be possible to specify the separator used in runreport.pl In-Reply-To: <bug-33285-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33285-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33285-70-t2GDzdkSF8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285 --- Comment #12 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:44 +0000 Subject: [Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page In-Reply-To: <bug-33322-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33322-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33322-70-7aTT886H9x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:46 +0000 Subject: [Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page In-Reply-To: <bug-33322-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33322-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33322-70-7BCjf7CQGn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 --- Comment #8 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:47 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: <bug-33381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33381-70-hQlEh3xYWa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:24:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:24:49 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: <bug-33381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33381-70-SyUK0VLz3H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 --- Comment #11 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:36:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:36:29 +0000 Subject: [Koha-bugs] [Bug 33272] Color of the "(remove)" link when an item is in the cart (OPAC) In-Reply-To: <bug-33272-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33272-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33272-70-TedkbuOfYS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jacob.omara at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:37:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:37:27 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: <bug-33422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33422-70-HkzYoiZaO9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jacob.omara at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:38:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:38:19 +0000 Subject: [Koha-bugs] [Bug 33299] Item type column is empty when placing item level holds in OPAC In-Reply-To: <bug-33299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33299-70-qdQcjTx7iQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33299 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor CC| |jacob.omara at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:39:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:39:51 +0000 Subject: [Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover In-Reply-To: <bug-33391-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33391-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33391-70-qvaBMsE19C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:40:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:40:59 +0000 Subject: [Koha-bugs] [Bug 27513] Add description to reports page In-Reply-To: <bug-27513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27513-70-b8r0aXlUKn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:43:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:43:45 +0000 Subject: [Koha-bugs] [Bug 33040] Add "Date published (text)" to serials tab on record view (detail.pl) In-Reply-To: <bug-33040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33040-70-eniHq6YDoD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33040 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:44:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:44:10 +0000 Subject: [Koha-bugs] [Bug 31057] Add clarifying text to 'To date' in the calendar tool In-Reply-To: <bug-31057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31057-70-MXzxD6bh0t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 19:49:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 17:49:47 +0000 Subject: [Koha-bugs] [Bug 32510] "New list" option is not available when too many patron's lists In-Reply-To: <bug-32510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32510-70-xFk7IKFYdd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32510 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jacob.omara at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 20:34:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 18:34:45 +0000 Subject: [Koha-bugs] [Bug 33318] [21.11] Advanced editor doesn't load in 21.11.x In-Reply-To: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33318-70-5i69zYgiwd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 20:34:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 18:34:47 +0000 Subject: [Koha-bugs] [Bug 33318] [21.11] Advanced editor doesn't load in 21.11.x In-Reply-To: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33318-70-12DNNcj6CF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148627|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 149732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149732&action=edit Bug 33318: Fix JS errors on advanced cataloguing editor This patch reverts bug 31818 Test plan: 1. Checkout 21.11.x 2. Set the EnableAdvancedCatalogingEditor syspref = 'Enable' 3. Go to Cataloguing > Advanced editor 4. Notice the advanced editor is stuck on 'Loading, please wait' 5. Right click > Inspect > Console 6. Notice there is a JS error: "Uncaught TypeError: $.fn.popover.Constructor.DEFAULTS.whiteList is undefined" 7. Apply patch 8. Restart services 9. Refresh the advanced editor 10. Notice it is not stuck on 'Loading, please wait' 11. Right click > Inspect > Console 12. Notice the JS error is no longer showing 13. Click on 'Keyboard shortcuts' and confirm it contains content - that is what bug 31818 was aiming to fix Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 20:39:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 18:39:05 +0000 Subject: [Koha-bugs] [Bug 33318] [21.11] Advanced editor doesn't load in 21.11.x In-Reply-To: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33318-70-KcipdGFsJP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. Edit .env and change KOHA_IMAGE=21.11 2. For your local git repository, checkout 21.11.x 3. To access the container,[1] ktd --root --shell [1] If I didn't do this, and accessed as normal (ktd --shell), I couldn't apply the patch: git bz apply 33318 Traceback (most recent call last): File "/usr/bin/git-bz", line 2716, in <module> applied = do_apply(bug_ref) File "/usr/bin/git-bz", line 1738, in do_apply attachmentdata=True) File "/usr/bin/git-bz", line 1473, in load bug._load(bug_reference.id, attachmentdata) File "/usr/bin/git-bz", line 1229, in _load response = self.server.send_request("GET", url) File "/usr/bin/git-bz", line 999, in send_request cookies = self.get_cookie_string() File "/usr/bin/git-bz", line 992, in get_cookie_string self.cookies = get_bugzilla_cookies(host) NameError: global name 'host' is not defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 21:57:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 19:57:27 +0000 Subject: [Koha-bugs] [Bug 33253] 2FA - Form not excluded from autofill In-Reply-To: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33253-70-tdV256k4rc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33253 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 21:57:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 19:57:29 +0000 Subject: [Koha-bugs] [Bug 33253] 2FA - Form not excluded from autofill In-Reply-To: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33253-70-cZYGYEv1r7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33253 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149725|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 149733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149733&action=edit Bug 33253: Turn off autocompletion for 2FA authentication code The form for entering your authentication code shoudl not suggest previous codes. To test: * Activate TwoFactorAuthentication * Go to your patron account in staff * More > Manage 2-factor authentication * I used "Google authenticator" on my phone, so: * Open app on your phone, add new and scan the QR code * Enter activation code * Log out of staff interface * Log back in, you are now also asked for an authentication code as second step * Look up code in app, enter, get logged in * Log out, log back in - the form now suggests the previous code when you click on it * Apply patch * Reload things (restart_all on ktd) * Verify that you no longer get the suggestion Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:07:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:07:54 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-dXlVYitdoG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind <david at davidnind.com> --- Hi Juliet. If you could edit status to change it to 'Signed off', that would be great! This will give you credit for the sign off in the dashboard - it will then show under Signoffs - April (https://dashboard.koha-community.org/). David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:13:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:13:25 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-PIWjqRTCzv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |agustinmoyano at theke.io |ity.org | CC| |david at davidnind.com --- Comment #9 from David Nind <david at davidnind.com> --- Changed assignee 8-). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:32:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:32:32 +0000 Subject: [Koha-bugs] [Bug 33001] Use template wrapper for breadcrumbs: Acquisitions part 2 In-Reply-To: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33001-70-XD4ofItCWz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33001 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:33:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:33:36 +0000 Subject: [Koha-bugs] [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details In-Reply-To: <bug-33185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33185-70-41r8MjX13d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:33:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:33:46 +0000 Subject: [Koha-bugs] [Bug 33186] Use template wrapper for tabs on search history and advanced search In-Reply-To: <bug-33186-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33186-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33186-70-lU8ZVF7eQj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:33:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:33:58 +0000 Subject: [Koha-bugs] [Bug 33293] Use template wrapper for tabs: Holds In-Reply-To: <bug-33293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33293-70-MiRSmu9bn8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:34:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:34:08 +0000 Subject: [Koha-bugs] [Bug 33294] Use template wrapper for tabs: Checkout history In-Reply-To: <bug-33294-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33294-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33294-70-Trj09pwiPS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33294 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jacob.omara at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:34:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:34:17 +0000 Subject: [Koha-bugs] [Bug 33307] Use template wrapper for tabs: Lists In-Reply-To: <bug-33307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33307-70-CQKxiqVben@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33307 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:36:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:36:53 +0000 Subject: [Koha-bugs] [Bug 27513] Add description to reports page In-Reply-To: <bug-27513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27513-70-uv1IY8Ovju@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:36:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:36:55 +0000 Subject: [Koha-bugs] [Bug 27513] Add description to reports page In-Reply-To: <bug-27513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27513-70-RcWCh6y6Cp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27513 --- Comment #9 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:36:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:36:57 +0000 Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs In-Reply-To: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29311-70-t6hYyNGGIX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:36:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:36:59 +0000 Subject: [Koha-bugs] [Bug 29311] Do not allow editing of bibliographic information when entering suggestion from existing bibs In-Reply-To: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29311-70-iUdHZ9ULcq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29311 --- Comment #17 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:01 +0000 Subject: [Koha-bugs] [Bug 31057] Add clarifying text to 'To date' in the calendar tool In-Reply-To: <bug-31057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31057-70-DloaJVMOHZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:02 +0000 Subject: [Koha-bugs] [Bug 31057] Add clarifying text to 'To date' in the calendar tool In-Reply-To: <bug-31057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31057-70-xuFEtJKDMH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 --- Comment #9 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:04 +0000 Subject: [Koha-bugs] [Bug 31640] Fuzzy translations of preferences can cause missing sections and inaccurate translations In-Reply-To: <bug-31640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31640-70-jpKb15DJC3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:06 +0000 Subject: [Koha-bugs] [Bug 31640] Fuzzy translations of preferences can cause missing sections and inaccurate translations In-Reply-To: <bug-31640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31640-70-FITXRpTSf8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31640 --- Comment #16 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:08 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query In-Reply-To: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31841-70-6gaX1KaOO9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:09 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query In-Reply-To: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31841-70-F0bKcZyWO9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 --- Comment #19 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:11 +0000 Subject: [Koha-bugs] [Bug 31994] Clicking the next button of a DataTable loading its data from the HTML does nothing In-Reply-To: <bug-31994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31994-70-NSOdBkiEpg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31994 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:13 +0000 Subject: [Koha-bugs] [Bug 31994] Clicking the next button of a DataTable loading its data from the HTML does nothing In-Reply-To: <bug-31994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31994-70-2Us7PY9ESf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31994 --- Comment #13 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:15 +0000 Subject: [Koha-bugs] [Bug 32263] Capitalization: ...and on the Libraries page in the OPAC. In-Reply-To: <bug-32263-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32263-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32263-70-SwZuE9Gsme@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32263 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:17 +0000 Subject: [Koha-bugs] [Bug 32263] Capitalization: ...and on the Libraries page in the OPAC. In-Reply-To: <bug-32263-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32263-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32263-70-2pXsnvIj6l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32263 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:18 +0000 Subject: [Koha-bugs] [Bug 32510] "New list" option is not available when too many patron's lists In-Reply-To: <bug-32510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32510-70-M4vbXXDmQg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32510 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:20 +0000 Subject: [Koha-bugs] [Bug 32510] "New list" option is not available when too many patron's lists In-Reply-To: <bug-32510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32510-70-wZTBp02GHJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32510 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:22 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing randomly In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-m7ZuPCLB9K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:24 +0000 Subject: [Koha-bugs] [Bug 32648] Search.t is failing randomly In-Reply-To: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32648-70-AxUTawpJWK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #7 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:25 +0000 Subject: [Koha-bugs] [Bug 33001] Use template wrapper for breadcrumbs: Acquisitions part 2 In-Reply-To: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33001-70-OarQ9a1GT6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33001 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:27 +0000 Subject: [Koha-bugs] [Bug 33001] Use template wrapper for breadcrumbs: Acquisitions part 2 In-Reply-To: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33001-70-G0GVj9eDwT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33001 --- Comment #10 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:28 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-fiI7d2qJND@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:30 +0000 Subject: [Koha-bugs] [Bug 33005] Use template wrapper for breadcrumbs: Acquisitions part 3 In-Reply-To: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33005-70-HKSREwgokK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33005 --- Comment #14 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:32 +0000 Subject: [Koha-bugs] [Bug 33040] Add "Date published (text)" to serials tab on record view (detail.pl) In-Reply-To: <bug-33040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33040-70-60ZlPBtOZz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33040 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:34 +0000 Subject: [Koha-bugs] [Bug 33040] Add "Date published (text)" to serials tab on record view (detail.pl) In-Reply-To: <bug-33040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33040-70-FgWyYp9q9U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33040 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:35 +0000 Subject: [Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w In-Reply-To: <bug-33160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33160-70-ejfSrMSgrJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:37 +0000 Subject: [Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w In-Reply-To: <bug-33160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33160-70-YBOm3YExRY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #16 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:39 +0000 Subject: [Koha-bugs] [Bug 33180] Use template wrapper for tabs: Budgets and Search engine configuration In-Reply-To: <bug-33180-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33180-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33180-70-E46HYY0qhl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33180 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:40 +0000 Subject: [Koha-bugs] [Bug 33180] Use template wrapper for tabs: Budgets and Search engine configuration In-Reply-To: <bug-33180-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33180-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33180-70-0HY5Jqj3WV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33180 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:42 +0000 Subject: [Koha-bugs] [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details In-Reply-To: <bug-33185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33185-70-LVS16NuO7l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:44 +0000 Subject: [Koha-bugs] [Bug 33185] Use template wrapper for tabs on authority and biblio MARC details In-Reply-To: <bug-33185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33185-70-DNurncx9hL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33185 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:45 +0000 Subject: [Koha-bugs] [Bug 33186] Use template wrapper for tabs on search history and advanced search In-Reply-To: <bug-33186-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33186-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33186-70-VTOu4BGCCb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:47 +0000 Subject: [Koha-bugs] [Bug 33186] Use template wrapper for tabs on search history and advanced search In-Reply-To: <bug-33186-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33186-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33186-70-8Ozd5EwdYH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33186 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:48 +0000 Subject: [Koha-bugs] [Bug 33272] Color of the "(remove)" link when an item is in the cart (OPAC) In-Reply-To: <bug-33272-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33272-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33272-70-5bVy8Usl5S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:50 +0000 Subject: [Koha-bugs] [Bug 33272] Color of the "(remove)" link when an item is in the cart (OPAC) In-Reply-To: <bug-33272-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33272-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33272-70-K3dKa4C7C2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33272 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:52 +0000 Subject: [Koha-bugs] [Bug 33293] Use template wrapper for tabs: Holds In-Reply-To: <bug-33293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33293-70-xnNq21k4qX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:53 +0000 Subject: [Koha-bugs] [Bug 33293] Use template wrapper for tabs: Holds In-Reply-To: <bug-33293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33293-70-QtaJ5ruQHL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33293 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:55 +0000 Subject: [Koha-bugs] [Bug 33294] Use template wrapper for tabs: Checkout history In-Reply-To: <bug-33294-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33294-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33294-70-sjSua1nWDJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33294 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:56 +0000 Subject: [Koha-bugs] [Bug 33294] Use template wrapper for tabs: Checkout history In-Reply-To: <bug-33294-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33294-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33294-70-ytNJg7Zntx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33294 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:37:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:37:58 +0000 Subject: [Koha-bugs] [Bug 33299] Item type column is empty when placing item level holds in OPAC In-Reply-To: <bug-33299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33299-70-kkH1PHb6b6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33299 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:00 +0000 Subject: [Koha-bugs] [Bug 33299] Item type column is empty when placing item level holds in OPAC In-Reply-To: <bug-33299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33299-70-N9DAwIJ5zx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33299 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:02 +0000 Subject: [Koha-bugs] [Bug 33307] Use template wrapper for tabs: Lists In-Reply-To: <bug-33307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33307-70-ZPX4Ys3flL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33307 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:03 +0000 Subject: [Koha-bugs] [Bug 33307] Use template wrapper for tabs: Lists In-Reply-To: <bug-33307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33307-70-YG0OyHqjro@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33307 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:05 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: <bug-33368-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33368-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33368-70-A2O3sQTbhS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:07 +0000 Subject: [Koha-bugs] [Bug 33368] borrowers.flags is about to reach the limit In-Reply-To: <bug-33368-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33368-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33368-70-gYI0M4ZABI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33368 --- Comment #13 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:09 +0000 Subject: [Koha-bugs] [Bug 33372] Use template wrapper for breadcrumbs: Circulation part 2 In-Reply-To: <bug-33372-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33372-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33372-70-SoxVwbzIMR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33372 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:10 +0000 Subject: [Koha-bugs] [Bug 33372] Use template wrapper for breadcrumbs: Circulation part 2 In-Reply-To: <bug-33372-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33372-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33372-70-SSTazTLRWn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33372 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:12 +0000 Subject: [Koha-bugs] [Bug 33373] Use template wrapper for breadcrumbs: Circulation part 3 In-Reply-To: <bug-33373-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33373-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33373-70-19acUTCA7e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:13 +0000 Subject: [Koha-bugs] [Bug 33373] Use template wrapper for breadcrumbs: Circulation part 3 In-Reply-To: <bug-33373-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33373-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33373-70-OTCwT7veJv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33373 --- Comment #9 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:15 +0000 Subject: [Koha-bugs] [Bug 33382] Use template wrapper for breadcrumbs: Patron clubs In-Reply-To: <bug-33382-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33382-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33382-70-yLE4CCsjkX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33382 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:17 +0000 Subject: [Koha-bugs] [Bug 33382] Use template wrapper for breadcrumbs: Patron clubs In-Reply-To: <bug-33382-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33382-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33382-70-BQlHIJATm4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33382 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:18 +0000 Subject: [Koha-bugs] [Bug 33383] Use template wrapper for breadcrumbs: Course reserves In-Reply-To: <bug-33383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33383-70-VH3KxxDgAk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33383 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:20 +0000 Subject: [Koha-bugs] [Bug 33383] Use template wrapper for breadcrumbs: Course reserves In-Reply-To: <bug-33383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33383-70-Gd2c2eOrnK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33383 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:22 +0000 Subject: [Koha-bugs] [Bug 33384] Use template wrapper for breadcrumbs: Labels In-Reply-To: <bug-33384-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33384-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33384-70-6SiOZCQEa7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33384 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:23 +0000 Subject: [Koha-bugs] [Bug 33384] Use template wrapper for breadcrumbs: Labels In-Reply-To: <bug-33384-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33384-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33384-70-etPX1DX5gC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33384 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:25 +0000 Subject: [Koha-bugs] [Bug 33385] Use template wrapper for breadcrumbs: Patrons part 1 In-Reply-To: <bug-33385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33385-70-sg4lxdBdEg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33385 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:26 +0000 Subject: [Koha-bugs] [Bug 33385] Use template wrapper for breadcrumbs: Patrons part 1 In-Reply-To: <bug-33385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33385-70-AYUTa8xqMd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33385 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:28 +0000 Subject: [Koha-bugs] [Bug 33386] Use template wrapper for breadcrumbs: Patrons part 2 In-Reply-To: <bug-33386-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33386-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33386-70-7c4blxyqMs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33386 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:30 +0000 Subject: [Koha-bugs] [Bug 33386] Use template wrapper for breadcrumbs: Patrons part 2 In-Reply-To: <bug-33386-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33386-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33386-70-SFfJlwTwG8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33386 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:31 +0000 Subject: [Koha-bugs] [Bug 33387] Use template wrapper for breadcrumbs: Patrons part 3 In-Reply-To: <bug-33387-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33387-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33387-70-G8iI50nrpK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33387 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:33 +0000 Subject: [Koha-bugs] [Bug 33387] Use template wrapper for breadcrumbs: Patrons part 3 In-Reply-To: <bug-33387-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33387-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33387-70-p9F9xQxjie@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33387 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:35 +0000 Subject: [Koha-bugs] [Bug 33389] Use template wrapper for breadcrumbs: Patrons part 5 In-Reply-To: <bug-33389-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33389-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33389-70-GXw74PydHy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33389 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:36 +0000 Subject: [Koha-bugs] [Bug 33389] Use template wrapper for breadcrumbs: Patrons part 5 In-Reply-To: <bug-33389-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33389-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33389-70-jn0RGmpj68@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33389 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:38 +0000 Subject: [Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover In-Reply-To: <bug-33391-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33391-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33391-70-iWrFThbsph@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:40 +0000 Subject: [Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover In-Reply-To: <bug-33391-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33391-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33391-70-S34qmbtDtp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:41 +0000 Subject: [Koha-bugs] [Bug 33409] Use template wrapper for breadcrumbs: Patrons lists In-Reply-To: <bug-33409-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33409-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33409-70-PhzgEXyzcz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33409 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:43 +0000 Subject: [Koha-bugs] [Bug 33409] Use template wrapper for breadcrumbs: Patrons lists In-Reply-To: <bug-33409-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33409-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33409-70-YOQyOR0T0Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33409 --- Comment #7 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:45 +0000 Subject: [Koha-bugs] [Bug 33410] Use template wrapper for breadcrumbs: Patron card creator In-Reply-To: <bug-33410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33410-70-3nKgriYyeX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:46 +0000 Subject: [Koha-bugs] [Bug 33410] Use template wrapper for breadcrumbs: Patron card creator In-Reply-To: <bug-33410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33410-70-gkWwCJ6CWA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:48 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: <bug-33422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33422-70-lxDByBnoQu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:49 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: <bug-33422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33422-70-P8nH09YSnw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 --- Comment #12 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:51 +0000 Subject: [Koha-bugs] [Bug 33429] Use template wrapper for breadcrumbs: Plugins In-Reply-To: <bug-33429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33429-70-AqfxQEYo5I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:53 +0000 Subject: [Koha-bugs] [Bug 33429] Use template wrapper for breadcrumbs: Plugins In-Reply-To: <bug-33429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33429-70-xpdBSGH5Zl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 --- Comment #7 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:54 +0000 Subject: [Koha-bugs] [Bug 33434] Use template wrapper for breadcrumbs: Point of sale In-Reply-To: <bug-33434-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33434-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33434-70-9SvCYSQrFX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33434 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:56 +0000 Subject: [Koha-bugs] [Bug 33434] Use template wrapper for breadcrumbs: Point of sale In-Reply-To: <bug-33434-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33434-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33434-70-SSYS2QCka3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33434 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:57 +0000 Subject: [Koha-bugs] [Bug 33436] Use template wrapper for breadcrumbs: Reports part 1 In-Reply-To: <bug-33436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33436-70-WmQWv624QY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:38:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:38:59 +0000 Subject: [Koha-bugs] [Bug 33436] Use template wrapper for breadcrumbs: Reports part 1 In-Reply-To: <bug-33436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33436-70-akW4vBzBt0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33436 --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:39:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:39:55 +0000 Subject: [Koha-bugs] [Bug 33333] Use template wrapper for tabs: SQL reports In-Reply-To: <bug-33333-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33333-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33333-70-uXJBqIbqWd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33333 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:40:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:40:04 +0000 Subject: [Koha-bugs] [Bug 33324] Use template wrapper for tabs: Tools In-Reply-To: <bug-33324-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33324-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33324-70-L5XZuIMnQj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:40:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:40:12 +0000 Subject: [Koha-bugs] [Bug 33147] Use template wrapper for breadcrumbs: Catalog part 2 In-Reply-To: <bug-33147-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33147-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33147-70-hFhCbfAJ9K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33147 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jacob.omara at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:40:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:40:21 +0000 Subject: [Koha-bugs] [Bug 33131] Use template wrapper for breadcrumbs: Catalog part 1 In-Reply-To: <bug-33131-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33131-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33131-70-1kffJYFV5Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33131 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jacob.omara at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:40:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:40:29 +0000 Subject: [Koha-bugs] [Bug 33130] Use template wrapper for breadcrumbs: Authorities In-Reply-To: <bug-33130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33130-70-uF5qUENtg2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33130 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:40:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:40:43 +0000 Subject: [Koha-bugs] [Bug 33006] Use template wrapper for breadcrumbs: Administration part 1 In-Reply-To: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33006-70-aI97Uf9BXl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33006 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:42:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:42:42 +0000 Subject: [Koha-bugs] [Bug 33007] Use template wrapper for breadcrumbs: Administration part 2 In-Reply-To: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33007-70-vIfg39Yb6l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33007 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:43:12 +0000 Subject: [Koha-bugs] [Bug 33111] Use template wrapper for breadcrumbs: Administration part 4 In-Reply-To: <bug-33111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33111-70-EL9xmB8qAR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33111 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:43:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:43:37 +0000 Subject: [Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w In-Reply-To: <bug-33160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33160-70-FK96jWjUwi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jacob O'Mara from comment #16) > Nice work, thanks everyone! > > Pushed to 22.11.x for the next release. Hi Jacob, the dependency is not in 22.11 - not sure if this can work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:45:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:45:54 +0000 Subject: [Koha-bugs] [Bug 33006] Use template wrapper for breadcrumbs: Administration part 1 In-Reply-To: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33006-70-ctq58vMden@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33006 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:45:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:45:56 +0000 Subject: [Koha-bugs] [Bug 33006] Use template wrapper for breadcrumbs: Administration part 1 In-Reply-To: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33006-70-aF2AbpqHui@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33006 --- Comment #10 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:45:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:45:57 +0000 Subject: [Koha-bugs] [Bug 33007] Use template wrapper for breadcrumbs: Administration part 2 In-Reply-To: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33007-70-Ax2SVcRGU2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33007 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:45:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:45:59 +0000 Subject: [Koha-bugs] [Bug 33007] Use template wrapper for breadcrumbs: Administration part 2 In-Reply-To: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33007-70-koPc7Tx456@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33007 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:46:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:46:01 +0000 Subject: [Koha-bugs] [Bug 33111] Use template wrapper for breadcrumbs: Administration part 4 In-Reply-To: <bug-33111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33111-70-WjrSom0oFa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33111 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:46:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:46:02 +0000 Subject: [Koha-bugs] [Bug 33111] Use template wrapper for breadcrumbs: Administration part 4 In-Reply-To: <bug-33111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33111-70-EctZnpxpUy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33111 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:46:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:46:04 +0000 Subject: [Koha-bugs] [Bug 33130] Use template wrapper for breadcrumbs: Authorities In-Reply-To: <bug-33130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33130-70-JxIc30lOF0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33130 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:46:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:46:06 +0000 Subject: [Koha-bugs] [Bug 33130] Use template wrapper for breadcrumbs: Authorities In-Reply-To: <bug-33130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33130-70-5dzendgIdw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33130 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:46:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:46:08 +0000 Subject: [Koha-bugs] [Bug 33131] Use template wrapper for breadcrumbs: Catalog part 1 In-Reply-To: <bug-33131-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33131-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33131-70-Fo6EnSO9gf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33131 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:46:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:46:09 +0000 Subject: [Koha-bugs] [Bug 33131] Use template wrapper for breadcrumbs: Catalog part 1 In-Reply-To: <bug-33131-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33131-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33131-70-xgaPZrPLCR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33131 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:46:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:46:11 +0000 Subject: [Koha-bugs] [Bug 33147] Use template wrapper for breadcrumbs: Catalog part 2 In-Reply-To: <bug-33147-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33147-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33147-70-nmmBKJlp41@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33147 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:46:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:46:12 +0000 Subject: [Koha-bugs] [Bug 33147] Use template wrapper for breadcrumbs: Catalog part 2 In-Reply-To: <bug-33147-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33147-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33147-70-HOc11wRtzE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33147 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:46:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:46:14 +0000 Subject: [Koha-bugs] [Bug 33324] Use template wrapper for tabs: Tools In-Reply-To: <bug-33324-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33324-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33324-70-YKDklgTIDa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:46:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:46:16 +0000 Subject: [Koha-bugs] [Bug 33324] Use template wrapper for tabs: Tools In-Reply-To: <bug-33324-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33324-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33324-70-gBtuohlrul@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:46:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:46:17 +0000 Subject: [Koha-bugs] [Bug 33333] Use template wrapper for tabs: SQL reports In-Reply-To: <bug-33333-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33333-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33333-70-DYiqv3Lq4H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33333 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 22:46:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 20:46:19 +0000 Subject: [Koha-bugs] [Bug 33333] Use template wrapper for tabs: SQL reports In-Reply-To: <bug-33333-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33333-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33333-70-DZMxuc0EAF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33333 --- Comment #5 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 23:40:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 21:40:14 +0000 Subject: [Koha-bugs] [Bug 33318] [21.11] Advanced editor doesn't load In-Reply-To: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33318-70-Og7vHrfsZR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[21.11] Advanced editor |[21.11] Advanced editor |doesn't load in 21.11.x |doesn't load -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 23:45:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 21:45:08 +0000 Subject: [Koha-bugs] [Bug 32426] Make userid generation pluggable In-Reply-To: <bug-32426-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32426-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32426-70-koLn3dMNI2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32426 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 23:45:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 21:45:39 +0000 Subject: [Koha-bugs] [Bug 32992] Move background worker script to misc/workers In-Reply-To: <bug-32992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32992-70-ZIc9RLDQvp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32992 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 23:50:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 21:50:07 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-kXeumyQjoz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |phil at chetcolibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 23:51:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 21:51:13 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-54CfPM1WTd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Phil, if you are working on a patch, please remember to make yourself Assignee of the bug. It helps to avoid doubled up work among other things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 16 23:52:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 21:52:39 +0000 Subject: [Koha-bugs] [Bug 32959] Item Templates will apply the same barcode each time template is applied if autobarcode is enabled In-Reply-To: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32959-70-ZZlDT1YwdE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32959 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 00:08:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 22:08:05 +0000 Subject: [Koha-bugs] [Bug 33534] catalog New record An error has occurred! Error 500 In-Reply-To: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33534-70-nLtXvGFJeV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33534 Jen <jenni.neenan at defence.gov.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|1 |0 Status|RESOLVED |UNCONFIRMED Resolution|INVALID |--- --- Comment #3 from Jen <jenni.neenan at defence.gov.au> --- Hi Katrin, Sorry but I don't understand where I am supposed to post the issue to receive support. Is there an email address I can use? I have located the community support page but am unsure how to use it. I am not an IT person, I am a librarian and manager of a small library so have limited IT support. Your help in this matter is greatly appreciated. Kind regards, Jenni -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 00:12:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 22:12:33 +0000 Subject: [Koha-bugs] [Bug 33534] catalog New record An error has occurred! Error 500 In-Reply-To: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33534-70-EnXFOihcbI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33534 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- If you sign up to the mailing list with the link below, you can send your questions to the wider community - many more people will read it and be able to help you: lists.katipo.co.nz/mailman/listinfo/koha There is also a chat where you can get in touch with devs and librarians working on Koha: https://koha-community.org/get-involved/irc/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 00:49:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 22:49:26 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-vjkYnBK43S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 00:49:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 22:49:28 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-Rfuw1M9KgB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148629|0 |1 is obsolete| | --- Comment #4 from David Nind <david at davidnind.com> --- Created attachment 149734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149734&action=edit Bug 33329: Regression tests This patch introduces tests for the bug highlighted on bug 32336, but in the context of lists of records. To reproduce: 1. Run: $ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => FAIL: Test fail, encoding is bad! Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 00:49:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 22:49:31 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-d0qZVEvX3s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149708|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 149735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149735&action=edit Bug 33329: Correctly handle UNIMARC encoding for biblios This patch introduces the same treatment we had for bug 32336, this time for Koha::Objects::Record::Collections. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail! Encoding is wrong for UNIMARC! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 01:07:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 23:07:37 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-QnvInLMlTB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 01:07:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 23:07:40 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-kjP5Zbidu9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149728|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 149736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149736&action=edit Bug 32937: Make Zebra ignore the copyright symbol in searches It's common to catalog the year with the copyright symbol attached to it. This creates some issues with search that we can fix by adding the © to the list of characters Zebra ignores in search. To test: * Search for any existing publication year with ©, example: ©1951 * Verify your record is not found * Add the copyright symbol to a record, verify it's now found with ©, but not without * Apply patch * On ktd: * sudo cp -i /kohadevbox/koha/etc/zebradb/etc/word-phrase-utf.chr /etc/koha/zebradb/etc/word-phrase-utf.chr * sudo koha-zebra --restart kohadev * sudo koha-mysql kohadev * DELETE FROM biblio WHERE biblionumber = 369; * The reindex woudl fail for me with this broken record present. * sudo koha-rebuild-zebra -f kohadev * Repeat searches, the records should be found when searching with and without ©. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 01:57:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Apr 2023 23:57:32 +0000 Subject: [Koha-bugs] [Bug 17387] Add an undelete feature for items/biblios In-Reply-To: <bug-17387-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17387-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17387-70-Vm7BruaVDu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17387 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- (In reply to davewood from comment #3) > I have written this code already and would like to add the feature. If you haven't already, take a look at the following: https://koha-community.org/get-involved/for-developers/ If you need help attaching patches, I'd suggest hopping on IRC or the Koha Developers List: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:00:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:00:58 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-hyt8iA7p39@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind <david at davidnind.com> --- (In reply to Katrin Fischer from comment #1) > I will also attach patches that work for ignoring © with Zebra. I am not > sure if a change is needed for Elasticsearch (cannot test it currently) and > I would not know where to make the changes. If you are using Elastisearch > and can confirm this is a problem there too, would you mind filing another > bug for the "Searching - Elasticsearch" component? I tested with KTD and Elasticsearch and OpenSearch (ktd --es7 up and ktd --os1 up). The record was found with and without the copyright symbol, so I don't think it affects Koha with Elasticsearch or OpenSearch. Note: I couldn't get KTD to start properly using --es6, --es8, and --os2. Testing notes: 1. Edited the BKS framework so that 264$c is visible in the editor. 2. Add a year to 264$c with and without the copyright symbol, as per the test plan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:20:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:20:20 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-NDCPwQdJfI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #2 from David Cook <dcook at prosentient.com.au> --- That's a tricky one. It looks like dt_from_string() silently will produce a floating timestamp where a valid local timestamp can't be produced. In this particular case, if $today were converted from local to floating, then the age in years should be able to be computed without error. After grepping around a bit, this looks like it could actually be an all right strategy. I was worried about it pushing the problem further down the line, but it looks like dateofbirth is mostly just used for display with this one exception... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:25:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:25:21 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-TugpqlSVdC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #32 from David Nind <david at davidnind.com> --- The patches no longer apply 8-(.. git bz apply 27634 Bug 27634 - Turn off patron self-registration if no default category is set 147531 - Bug 27634: Turn off patron self-registration if no default category is set 147532 - Bug 27634: Force include categorycode to PatronSelfRegistrationBorrowerUnwantedField 147533 - Bug 27634: Add the ability to exclude fields from "modal" sysprefs 147534 - Bug 27634: Force include of dateexpiry 147535 - Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set 147536 - Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value 147537 - Bug 27634: Hide "Register here" links Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27634: Turn off patron self-registration if no default category is set Applying: Bug 27634: Force include categorycode to PatronSelfRegistrationBorrowerUnwantedField Applying: Bug 27634: Add the ability to exclude fields from "modal" sysprefs Applying: Bug 27634: Force include of dateexpiry Applying: Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set Using index info to reconstruct a base tree... M about.pl M koha-tmpl/intranet-tmpl/prog/en/modules/about.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/about.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/about.tt Auto-merging about.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:28:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:28:26 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-lf5KejQXbf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #3 from David Cook <dcook at prosentient.com.au> --- (In reply to Caroline Cyr La Rose from comment #0) > To test: > 1. Create a patron, setting the date of birth to one of these three dates > - 1947-04-27 > - 1948-04-25 > - 1949-04-24 > 2. Save the patron > --> Error To reproduce, you'll likely need to update <timezone></timezone> to include Canada/Eastern in your koha-conf.xml and then restart Plack. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:33:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:33:55 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-CoC5FZZOL6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:36:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:36:37 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-iL06S4obwc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:36:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:36:40 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-omvhtyIarZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- Created attachment 149737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149737&action=edit Bug 32232: Ignore DST when calculating patron age This change calculates patron age using the floating timezone, so that datetimes missing midnight don't cause fatal errors in the comparison. Test plan: 0. Apply patch 1. Change <timezone></timezone> in koha-conf.xml to include Canada/Eastern 2. koha-plack --restart kohadev 3. Create a patron, setting the date of birth to one of these three dates - 1947-04-27 - 1948-04-25 - 1949-04-24 4. Save the patron 5. Patron detail page loads instead of producing fatal error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:39:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:39:31 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-PNiw2BbhzE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #5 from David Cook <dcook at prosentient.com.au> --- Actually, I'm going to amend that to use the same syntax that Jonathan used in bug 23079 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:41:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:41:02 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-jSPBJJaNti@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149737|0 |1 is obsolete| | --- Comment #6 from David Cook <dcook at prosentient.com.au> --- Created attachment 149738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149738&action=edit Bug 32232: Ignore DST when calculating patron age This change calculates patron age using the floating timezone, so that datetimes missing midnight don't cause fatal errors in the comparison. Test plan: 0. Apply patch 1. Change <timezone></timezone> in koha-conf.xml to include Canada/Eastern 2. koha-plack --restart kohadev 3. Create a patron, setting the date of birth to one of these three dates - 1947-04-27 - 1948-04-25 - 1949-04-24 4. Save the patron 5. Patron detail page loads instead of producing fatal error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:42:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:42:12 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-q73rz6VcVf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #7 from David Cook <dcook at prosentient.com.au> --- Btw, it looks like t/db_dependent/Koha/Patrons.t has a unit test that covers this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:50:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:50:43 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-Tx1TBnitN6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:50:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:50:45 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-HS4WKYiNof@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95621|0 |1 is obsolete| | --- Comment #9 from David Nind <david at davidnind.com> --- Created attachment 149739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149739&action=edit Bug 23924: Add --date-field to add_date_fields_to_marc_records.pl The date used in the script will use this parameter, instead of today. Test plan: Use the POD of the script to understand how this flag works. Then use the script to create fields with a date contained in a specific MARC field. Signed-off-by: Hugo Agud <hagud at orex.es> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:50:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:50:48 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-p2zcormuSE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98217|0 |1 is obsolete| | --- Comment #10 from David Nind <david at davidnind.com> --- Created attachment 149740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149740&action=edit Bug 23924: Reset the fields to add We do not want to copy fields from the previous records! Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:56:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:56:26 +0000 Subject: [Koha-bugs] [Bug 33534] catalog New record An error has occurred! Error 500 In-Reply-To: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33534-70-iNLkbZWv5u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33534 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook <dcook at prosentient.com.au> --- (In reply to Jen from comment #3) > Hi Katrin, > > Sorry but I don't understand where I am supposed to post the issue to > receive support. Is there an email address I can use? I have located the > community support page but am unsure how to use it. I am not an IT person, I > am a librarian and manager of a small library so have limited IT support. > Your help in this matter is greatly appreciated. > > Kind regards, > > Jenni Hi Jenni, As Katrin said, if you go to https://koha-community.org/support/koha-mailing-lists/ and click on "Join the mailing list", you can send out emails to the global Koha community. If you go to https://koha-community.org/get-involved/irc/ and click "connect directly to the Koha channel through your browser" you can also chat in real time. I'm in the same timezone as you, so I could give you some advice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 02:57:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 00:57:38 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-IpR4Qir0BB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #11 from David Nind <david at davidnind.com> --- How I tested (using KTD): 1. Made 905$a and 908$a and visible in editor for the BKS framework. 2. Select a record and added a date in 908$a using default format e.g. 02/02/2023 (for example record 1) 3. Select another record and added a date in 908$a using ISO format e.g. 2023-04-01 (for example record 262) 4. Applied the patch. 5. Ran these examples, including output from change: - perl misc/add_date_fields_to_marc_records.pl --field='905$a=0/%Y' --field='905$a=1/%Y/%b-%m' --field='905$a=2/%Y/%b-%m/%d' --unless-exists='905$a' --where "biblionumber=1" --date-field='908$a' --verbose --confirm 02/02/2023 at misc/add_date_fields_to_marc_records.pl line 82. The following MARC fields will be added to record 1: 905 _a0/2023 905 _a1/2023/Feb-02 905 _a2/2023/Feb-02/02 Bibliographic record 1 has been modified - perl misc/add_date_fields_to_marc_records.pl --field='905$a=0/%Y' --field='905$a=1/%Y/%b-%m' --field='905$a=2/%Y/%b-%m/%d' --unless-exists='905$a' --where "biblionumber=262" --date-field='908$a' --verbose --confirm 2023-04-01 at misc/add_date_fields_to_marc_records.pl line 82. The following MARC fields will be added to record 262: 905 _a0/2023 905 _a1/2023/Apr-04 905 _a2/2023/Apr-04/01 Bibliographic record 262 has been modified I hope that is sufficent to test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 03:07:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 01:07:44 +0000 Subject: [Koha-bugs] [Bug 33540] Add death date for deceased patron In-Reply-To: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33540-70-u5eHDNkgeX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33540 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #6 from David Cook <dcook at prosentient.com.au> --- Technically speaking, if the patron is deleted, they'd still be in the deletedborrowers table, so you could delete patrons who have died and just write SQL reports to show any relevant information. Giuseppe, is this a hypothetical issue or is this coming from an existing library? I didn't notice a Koha on the Internet for your organisation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 03:12:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 01:12:52 +0000 Subject: [Koha-bugs] [Bug 33540] Add death date for deceased patron In-Reply-To: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33540-70-tnT2nqY1YY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33540 --- Comment #7 from David Cook <dcook at prosentient.com.au> --- I was just looking at the function for getting age for unrelated reasons, so this is on my mind a bit. Looking at the patron details in the staff interface in English, it doesn't technically say the age of the patron. It just notes how many years ago they were born. It's not uncommon to celebrate the birthdays of famous people many years after their deaths, so I don't think there is an issue with the year displayed continuing to increment. For display purposes, if an attribute of DECEASED were added, you could also use Javascript to dynamically update the display accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 04:06:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 02:06:21 +0000 Subject: [Koha-bugs] [Bug 33364] Stop Holds to Pull report showing items that have been allocated to a recall In-Reply-To: <bug-33364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33364-70-MatLt2AFYR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33364 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 04:06:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 02:06:23 +0000 Subject: [Koha-bugs] [Bug 33364] Stop Holds to Pull report showing items that have been allocated to a recall In-Reply-To: <bug-33364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33364-70-qmhc9ySyjI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33364 --- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149741&action=edit Bug 33364: Prevent Holds to Pull from including items with pending recalls This patch changes the check for pending recalls to include items in transit, as well as items awaiting pickup, to fill a recall request. It then ensures the Holds to Pull report excludes items that have pending recalls. To test: 1. Enable UseRecalls and set the recalls-related circulation rules 2. Check out an item to Patron A 3. Place a hold on the item for Patron B 4. Log into the OPAC as Patron C and search for the item. Place a recall on the item. 5. Go back to the staff interface. Go to Circulation -> Holds to pull 6. Confirm the item shows in the Holds to pull table, with the hold for Patron B 7. Check in the item and confirm the recall as waiting 8. Go back to the Holds to pull page. You may need to manually regenerate the page by running the cronjob in the terminal misc/cronjobs/holds/build_holds_queue.pl 9. Notice that even though the item is allocated for a recall, the hold is showing. It should not be showing in this page. 10. Apply the patch and refresh the page 11. The item allocated to a recall should no longer be showing in the Holds to pull report 12. Go to the record detail page and go to the Recalls tab 13. Revert the recall from its waiting status 14. The record will now show on the Holds to pull page 15. Go to the Circulation -> Check in page 16. Go to the menu in the top-right of the page and click Set library 17. Change your library to a different one 18. Check in the item to confirm the recall as waiting and trigger a transfer 19. Go back to the Holds to pull page, regenerate if needed 20. The item should no longer show on the Holds to pull report 21. Confirm tests pass t/db_dependent/Koha/Item.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 04:07:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 02:07:17 +0000 Subject: [Koha-bugs] [Bug 33364] Stop Holds to Pull report showing items that have been allocated to a recall In-Reply-To: <bug-33364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33364-70-bfd3laDALq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33364 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wainuiwitikapark at catalyst.n |aleisha at catalyst.net.nz |et.nz | Text to go in the| |This patch changes the release notes| |check for pending recalls | |to include items in | |transit, as well as items | |awaiting pickup, to fill a | |recall request. | | | |It then | |ensures the Holds to Pull | |report excludes items that | |have pending recalls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 04:46:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 02:46:35 +0000 Subject: [Koha-bugs] [Bug 33364] Stop Holds to Pull report showing items that have been allocated to a recall In-Reply-To: <bug-33364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33364-70-tAwFcmvTwJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33364 --- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149742&action=edit Bug 33364: [22.05] Prevent Holds to Pull from including items with pending recalls This patch changes the check for pending recalls to include items in transit, as well as items awaiting pickup, to fill a recall request. It then ensures the Holds to Pull report excludes items that have pending recalls. To test: 1. Enable UseRecalls and set the recalls-related circulation rules 2. Check out an item to Patron A 3. Place a hold on the item for Patron B 4. Log into the OPAC as Patron C and search for the item. Place a recall on the item. 5. Go back to the staff interface. Go to Circulation -> Holds to pull 6. Confirm the item shows in the Holds to pull table, with the hold for Patron B 7. Check in the item and confirm the recall as waiting 8. Go back to the Holds to pull page. You may need to manually regenerate the page by running the cronjob in the terminal misc/cronjobs/holds/build_holds_queue.pl 9. Notice that even though the item is allocated for a recall, the hold is showing. It should not be showing in this page. 10. Apply the patch and refresh the page 11. The item allocated to a recall should no longer be showing in the Holds to pull report 12. Go to the record detail page and go to the Recalls tab 13. Revert the recall from its waiting status 14. The record will now show on the Holds to pull page 15. Go to the Circulation -> Check in page 16. Go to the menu in the top-right of the page and click Set library 17. Change your library to a different one 18. Check in the item to confirm the recall as waiting and trigger a transfer 19. Go back to the Holds to pull page, regenerate if needed 20. The item should no longer show on the Holds to pull report 21. Confirm tests pass t/db_dependent/Koha/Item.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 06:51:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 04:51:48 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-EMZib2XlpI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149743&action=edit Bug 33478: [WIP] Allow formatting of notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 08:23:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 06:23:43 +0000 Subject: [Koha-bugs] [Bug 12015] Google map of libraries and availability In-Reply-To: <bug-12015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12015-70-a8NE5YyVip@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12015 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 08:31:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 06:31:29 +0000 Subject: [Koha-bugs] [Bug 33542] New: ERM: Display of an agreement on the edit page Message-ID: <bug-33542-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33542 Bug ID: 33542 Summary: ERM: Display of an agreement on the edit page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: christian.stelzenmueller at bsz-bw.de CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com The display of an ERM agreement on the edit page is partially off. Between "Closure reason" and "Renewal priority", the display of "Yes", "No" and "Is perpetual:" is out of line in a way. Tested with Firefox 102.9.0esr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 08:31:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 06:31:58 +0000 Subject: [Koha-bugs] [Bug 33540] Add death date for deceased patron In-Reply-To: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33540-70-Nm0IDjKLo4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33540 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 08:55:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 06:55:57 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-zf3p6gati3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #25 from David Nind <david at davidnind.com> --- There are 8 UNIMARC cataloguing plugins/value builders that I haven't been able to figure out what they do, and how to set them up and use them: - unimarc_field_124.pl (bug 32850) - unimarc_field_125.pl (bug 32853) - unimarc_field_126.pl (bug 32856) - unimarc_field_210c_bis.pl (bug 32868) - unimarc_field_210c.pl (bug 32869) - unimarc_field_225a_bis.pl (bug 32870) - unimarc_field_225a.pl (bug 32871) - unimarc_field_686a.pl (bug 32873) I've posted a message to the main Koha mailing list: https://lists.katipo.co.nz/pipermail/koha/2023-April/059297.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 09:19:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 07:19:51 +0000 Subject: [Koha-bugs] [Bug 32164] Add link to MARC modification templates from batch record modification page In-Reply-To: <bug-32164-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32164-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32164-70-almYlbMWfK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32164 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |jacob.omara at ptfs-europe.com --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 09:20:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 07:20:09 +0000 Subject: [Koha-bugs] [Bug 32686] Specify action of action_logs entries to purge In-Reply-To: <bug-32686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32686-70-t9DCDDkEn6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32686 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |jacob.omara at ptfs-europe.com --- Comment #11 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 09:20:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 07:20:26 +0000 Subject: [Koha-bugs] [Bug 26598] Display guarantee's fines on guarantor's details page In-Reply-To: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26598-70-UH9JcTyPJu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26598 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Status|Pushed to master |Needs documenting --- Comment #19 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 09:20:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 07:20:48 +0000 Subject: [Koha-bugs] [Bug 30930] Ability to change authority type while editing record In-Reply-To: <bug-30930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30930-70-Ub28d6UIzW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30930 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Status|Pushed to master |Needs documenting --- Comment #8 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 09:21:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 07:21:19 +0000 Subject: [Koha-bugs] [Bug 31123] Add a simple way to add 'Harmful content warnings' to catalogue records In-Reply-To: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31123-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31123-70-lk2BeSmkkJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31123 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |jacob.omara at ptfs-europe.com --- Comment #34 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 09:22:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 07:22:08 +0000 Subject: [Koha-bugs] [Bug 31615] Allow checkin of items bundles without verifying their contents In-Reply-To: <bug-31615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31615-70-obTGwPJsaW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |jacob.omara at ptfs-europe.com --- Comment #6 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 09:22:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 07:22:28 +0000 Subject: [Koha-bugs] [Bug 30403] Update notforloan status also on check out In-Reply-To: <bug-30403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30403-70-PfkN9SPMQ6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |jacob.omara at ptfs-europe.com --- Comment #18 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 09:24:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 07:24:12 +0000 Subject: [Koha-bugs] [Bug 33066] We need a KohaTable Vue component In-Reply-To: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33066-70-PhGgc455e2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com Status|Pushed to master |Needs documenting --- Comment #102 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 09:26:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 07:26:28 +0000 Subject: [Koha-bugs] [Bug 32334] Sync comments in database with schema In-Reply-To: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32334-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32334-70-8aRMWMgYy8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32334 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |jacob.omara at ptfs-europe.com --- Comment #57 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 09:27:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 07:27:06 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-p2Ihq9XrJA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |jacob.omara at ptfs-europe.com --- Comment #41 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 09:28:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 07:28:46 +0000 Subject: [Koha-bugs] [Bug 32013] Autorenewals is effectively a bulk action and should be treated as such In-Reply-To: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32013-70-iuBiE2pPzK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32013 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |jacob.omara at ptfs-europe.com --- Comment #21 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 10:17:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 08:17:36 +0000 Subject: [Koha-bugs] [Bug 33542] ERM: Display of an agreement on the edit page In-Reply-To: <bug-33542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33542-70-rvkLbuKloy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33542 --- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- I believe this is fixed in bug 33355 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 10:56:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 08:56:53 +0000 Subject: [Koha-bugs] [Bug 33281] Improve authority links and add them to MARC preview In-Reply-To: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33281-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33281-70-guW3GlzoVs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33281 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 10:57:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 08:57:54 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27775-70-8yvTVBsAle@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:00:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:00:29 +0000 Subject: [Koha-bugs] [Bug 33542] ERM: Display of an agreement on the edit page In-Reply-To: <bug-33542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33542-70-sUfiCLV6to@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33542 --- Comment #2 from Christian StelzenmĂŒller <christian.stelzenmueller at bsz-bw.de> --- You are right, i just checked in a sandbox - thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:02:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:02:24 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-CsMDcX4XgT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #12 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Not backporting as additional_work_needed flag is active and this is dependent on 33408 which has not been backported Not changing status to RESOLVED FIXED - is the additional_work_needed flag still required now that Searchbar_spec.ts has been migrated? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:03:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:03:26 +0000 Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32301-70-DLpvEc6spe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:03:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:03:28 +0000 Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32301-70-Iu3kjAWmhn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:03:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:03:30 +0000 Subject: [Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records In-Reply-To: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32800-70-PVEuDw9fHp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:03:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:03:31 +0000 Subject: [Koha-bugs] [Bug 32800] build_oai_sets.pl fails on deleted records In-Reply-To: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32800-70-gwQNU5KaZ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:03:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:03:33 +0000 Subject: [Koha-bugs] [Bug 33367] tmp/modified_authorities/README.txt seems useless In-Reply-To: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33367-70-aes33oudi5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:03:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:03:35 +0000 Subject: [Koha-bugs] [Bug 33367] tmp/modified_authorities/README.txt seems useless In-Reply-To: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33367-70-jTYZRbI3C2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33367 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:05:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:05:26 +0000 Subject: [Koha-bugs] [Bug 33542] ERM: Display of an agreement on the edit page In-Reply-To: <bug-33542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33542-70-JnR7reOnKZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33542 Christian StelzenmĂŒller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Christian StelzenmĂŒller <christian.stelzenmueller at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 33355 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:05:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:05:26 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-mM2p6S6D79@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Christian StelzenmĂŒller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de --- Comment #12 from Christian StelzenmĂŒller <christian.stelzenmueller at bsz-bw.de> --- *** Bug 33542 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:11 +0000 Subject: [Koha-bugs] [Bug 33077] Improve ease of translating template title tags In-Reply-To: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33077-70-INuo1nmv7i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:13 +0000 Subject: [Koha-bugs] [Bug 33077] Improve ease of translating template title tags In-Reply-To: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33077-70-B1GnNkhWV3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:14 +0000 Subject: [Koha-bugs] [Bug 33261] Dates for issues on subscription detail page display unformatted In-Reply-To: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33261-70-oHjmICTBVh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33261 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:16 +0000 Subject: [Koha-bugs] [Bug 33261] Dates for issues on subscription detail page display unformatted In-Reply-To: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33261-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33261-70-6DrGfM9JAd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33261 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:17 +0000 Subject: [Koha-bugs] [Bug 33265] Additional unformatted navigation items when on serial receive page In-Reply-To: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33265-70-gZMeaf1Sxd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33265 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:19 +0000 Subject: [Koha-bugs] [Bug 33265] Additional unformatted navigation items when on serial receive page In-Reply-To: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33265-70-x2abUvwF33@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33265 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:20 +0000 Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable In-Reply-To: <bug-33323-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33323-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33323-70-SXzWIBJeW8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:22 +0000 Subject: [Koha-bugs] [Bug 33323] Select button in patron search modal is not translatable In-Reply-To: <bug-33323-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33323-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33323-70-v6QOv25G57@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33323 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:23 +0000 Subject: [Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations In-Reply-To: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33332-70-KxDhkK2ti1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:25 +0000 Subject: [Koha-bugs] [Bug 33332] Fix formatting of TT comments to improve translations In-Reply-To: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33332-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33332-70-es3UEEKDFd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33332 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:27 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33414-70-gFEBKguDbg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:28 +0000 Subject: [Koha-bugs] [Bug 33414] Dates displayed in ISO format in orders by fund In-Reply-To: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33414-70-GHEBmrzrlG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33414 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:30 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-iRvZsOVzhg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:11:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:11:31 +0000 Subject: [Koha-bugs] [Bug 33486] Remove Koha::BackgroundJob::UpdateElasticIndex->process routine In-Reply-To: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33486-70-NZVO0Hzq13@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33486 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:12:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:12:33 +0000 Subject: [Koha-bugs] [Bug 33316] Improve display of ES indexer jobs In-Reply-To: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33316-70-lnHqHJRDAb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33316 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #21 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:13:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:13:56 +0000 Subject: [Koha-bugs] [Bug 33466] Link vendor name in list of licenses In-Reply-To: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33466-70-HcUSZq5GLg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #8 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:15:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:15:35 +0000 Subject: [Koha-bugs] [Bug 32998] Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib In-Reply-To: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32998-70-kEf3QxE5KD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32998 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:16:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:16:07 +0000 Subject: [Koha-bugs] [Bug 33336] Use a dedicated column for plugin status in plugins table In-Reply-To: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33336-70-NJUCtu17f2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:16:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:16:25 +0000 Subject: [Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable In-Reply-To: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33154-70-mgkzg4PYib@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:16:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:16:27 +0000 Subject: [Koha-bugs] [Bug 33154] Tab WRAPPER follow-up: label text must be translatable In-Reply-To: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33154-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33154-70-jR2eXtAp14@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33154 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:16:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:16:28 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-h9kUpNtrnv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:16:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:16:30 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-dBtGZJOP9r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 --- Comment #11 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:22:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:22:49 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-Ai2xe6Uhqs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Jan Kissig <bibliothek at th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek at th-wildau.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:26:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:26:18 +0000 Subject: [Koha-bugs] [Bug 33543] New: Search within result list broken? Message-ID: <bug-33543-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33543 Bug ID: 33543 Summary: Search within result list broken? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 32026 The new'ish feature for searching within a result list doesn't work in my tests. I tested on 2 different 22.11 installations, one with Zebra and one with Elasticsearch. The Elasticsearch installation wouldn't give any results. To test: * In the staff interface * Search for: Quantenmechanik (or any other existing word in your catalog) * Search within search: a keyword that exists in the result list titles, I used: Entwicklung * The generated URL is: /cgi-bin/koha/catalogue/search.pl?idx=kw&q=quantenmechanik&&&limit=kw:Entwicklung * No rsults were found Not completely sure yet if the search engine is to blame or some other setting. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32026 [Bug 32026] 'Search within results' and its input field in staff search results page are misaligned -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:26:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:26:18 +0000 Subject: [Koha-bugs] [Bug 32026] 'Search within results' and its input field in staff search results page are misaligned In-Reply-To: <bug-32026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32026-70-XH1MYX54zE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32026 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33543 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33543 [Bug 33543] Search within result list broken? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:29:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:29:50 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30579-70-a19rBhscF2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 --- Comment #28 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Still getting an error, this time when placing a hold on next available item in an item group - I'm getting an alert saying "Please select an item group to place hold", even though an item group is selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:44:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:44:39 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-DiHXsRreM1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 11:44:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 09:44:42 +0000 Subject: [Koha-bugs] [Bug 33169] Improve vue breadcrumbs and left-hand menu In-Reply-To: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33169-70-BpNRgWdwOf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149710|0 |1 is obsolete| | --- Comment #10 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149744&action=edit Bug 33169: Build breadcrumbs and left-hand side menu from routes definition Signed-off-by: Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 12:17:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 10:17:00 +0000 Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display In-Reply-To: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8948-70-vfBfB4TSUM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 Jacek Ablewicz <ablewicz at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ablewicz at gmail.com --- Comment #49 from Jacek Ablewicz <ablewicz at gmail.com> --- In 21.11.x it has an unexpected side effect (commit 21ea11ff49a8564c09cb310fc77b471265722cfc), "OPAC view: " is displayed twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 13:26:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 11:26:39 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18829-70-LAEFxG8uKT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 --- Comment #29 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 149745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149745&action=edit Bug 18829: (QA follow-up) Replace forbidden indirect syntax This pattern is forbidden and was overlooked by QA. To test: 1. Run: $ ktd --shell k$ prove t/00-testcritic.t => FAIL: Tests fail with 'Subroutine "new" called using indirect syntax...' 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 13:29:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 11:29:23 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-9QPOiwPx2a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsShow.vue: <span v-if="agreement.is_perpetual">Yes</span> This one is missing as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 13:40:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 11:40:20 +0000 Subject: [Koha-bugs] [Bug 30002] Remove unused xt/perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-RhEcsZaTXz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #8 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- What is the status of this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 13:53:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 11:53:15 +0000 Subject: [Koha-bugs] [Bug 33543] Search within result list broken? In-Reply-To: <bug-33543-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33543-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33543-70-OtQw4hPuJ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33543 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- With Nick's help we've been able to limit the problem: * IntranetCatalogSearchPulldown needs to be active, it defaults to keyword * Keyword needs to be selected when searching within results The search then generates the limit as: ...limit=kw:term This doesn't work But this will: ...limit=term -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:03:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:03:18 +0000 Subject: [Koha-bugs] [Bug 30002] Remove unused xt/perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-LBG9mFIZ5n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> --- This need to be reviewed by QA team, so... Signed Off ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:04:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:04:06 +0000 Subject: [Koha-bugs] [Bug 30002] Remove unused xt/perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-p67KZfGl33@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:04:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:04:12 +0000 Subject: [Koha-bugs] [Bug 30002] Remove unused xt/perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-zyHuBXLTi1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:15:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:15:01 +0000 Subject: [Koha-bugs] [Bug 33543] Search within result list broken? In-Reply-To: <bug-33543-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33543-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33543-70-87rcEq8vT7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33543 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Keyword,phrase also doesn't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:15:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:15:28 +0000 Subject: [Koha-bugs] [Bug 30002] Remove unused xt/perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-1Tl9ApVvKR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- The current max line length is too short, and 178 is too much in my testing. For instance I'd like to see my $h = { one => 1, two => 3, }; always on 2 lines my $h = { one => 1, two => 3, }; Otherwise 178 leads to hard to read structure. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:21:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:21:48 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-6fhU75pYL9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:21:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:21:51 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-LVUML2IkXk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147535|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149746&action=edit Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:21:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:21:54 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-VJvbNshx0m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147536|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149747&action=edit Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:21:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:21:57 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-384kcNI7XU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147537|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149748&action=edit Bug 27634: Hide "Register here" links Make sure the pref is filled with a valid patron's category to display the "register" link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:25:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:25:44 +0000 Subject: [Koha-bugs] [Bug 30002] Remove unused xt/perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-hOKdL3qmQY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> --- Have you tried --break-at-old-comma-breakpoints ? With this flag it should keep the line breaks, no matter what the max line length is. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:27:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:27:46 +0000 Subject: [Koha-bugs] [Bug 30002] Remove unused xt/perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-UGeM1stADu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> --- --comma-arrow-breakpoints=0 appears to solve the issue as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:29:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:29:26 +0000 Subject: [Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes In-Reply-To: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21083-70-BqNJU99il4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:29:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:29:29 +0000 Subject: [Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes In-Reply-To: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21083-70-8qeEuzKwXG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105201|0 |1 is obsolete| | Attachment #133104|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149749&action=edit Bug 21083: Handle repeatable patron attributes in batch patron modification tool This patch adds the ability to set patron attributes marked as repeatable in the batch patron modification tool. Prior to this patch they were ignored. Test plan: You should try with several combinaisons and set patron attributes using the batch patron modification tool. Make sure there is no data lose and that the result is what you expect Please detail in a comment what you tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:29:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:29:31 +0000 Subject: [Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes In-Reply-To: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21083-70-F5WaMssXpO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149750&action=edit Bug 21083: Remove all attributes not only the first one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:31:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:31:31 +0000 Subject: [Koha-bugs] [Bug 33229] Patron reading history should be cleared when privacy set to never In-Reply-To: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33229-70-Poyx599KWI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33229 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #11 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- This broke tests. Please review the consequences of this new exception thrown, on the UI as well. kohadev-koha at kohadevbox:koha(master)$ prove t/db_dependent/Koha/Hold.t t/db_dependent/Koha/Hold.t .. 1/11 # Looks like you planned 5 tests but ran 2. # Failed test 'anonymization behavior tests' # at t/db_dependent/Koha/Hold.t line 265. # Looks like you planned 13 tests but ran 12. # Looks like you failed 1 test of 12 run. t/db_dependent/Koha/Hold.t .. 2/11 # Failed test 'fill() tests' # at t/db_dependent/Koha/Hold.t line 307. Exception 'Koha::Exceptions::SysPref::NotSet' thrown 'Required syspref is not set' with syspref => AnonymousPatron # Looks like your test exited with 255 just after 2. t/db_dependent/Koha/Hold.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 10/11 subtests Test Summary Report ------------------- t/db_dependent/Koha/Hold.t (Wstat: 65280 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 255 Parse errors: Bad plan. You planned 11 tests but ran 2. Files=1, Tests=2, 3 wallclock secs ( 0.02 usr 0.00 sys + 2.91 cusr 0.55 csys = 3.48 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:35:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:35:31 +0000 Subject: [Koha-bugs] [Bug 23824] Add a 'Save and run' button to reports In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-NCjPsaQFmO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149433|0 |1 is obsolete| | --- Comment #12 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Comment on attachment 149433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149433 Bug 23824: Add a "Save and run" button to reports [alternative] Please obsolete patches that are not needed. This is confusing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:38:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:38:36 +0000 Subject: [Koha-bugs] [Bug 33238] (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-9IIZmLH2AU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- QA script is not happy with this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:39:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:39:13 +0000 Subject: [Koha-bugs] [Bug 33238] (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-4PEd6zoA5U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:39:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:39:16 +0000 Subject: [Koha-bugs] [Bug 33238] (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-h3P7VC0DTx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149726|0 |1 is obsolete| | --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 149751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149751&action=edit Bug 33238: Fix bad suggestions query (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions. In errorlog you would find "DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous". Test plan: ========== 1. Have a Koha instance with IndependentBranches, some accepted suggestions, and a vendor defined. 2. Be a non superlibrarian librarian with permissions to manage acquisitions. 3. Create a new basket and try to add an item to the basket "From a suggestion". 4. Koha would generate error 500. 5. Apply the patch. 6. Try to add an item to the basket "From a suggestion". 7. You should succeed. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:42:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:42:10 +0000 Subject: [Koha-bugs] [Bug 23824] Add a 'Save and run' button to reports In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-J45tOv8OMB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It was my fault - I removed the [alternative] - git bz doesn't pick up on that automatically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:42:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:42:14 +0000 Subject: [Koha-bugs] [Bug 23824] Add a 'Save and run' button to reports In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-7njya3CL8R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:42:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:42:17 +0000 Subject: [Koha-bugs] [Bug 23824] Add a 'Save and run' button to reports In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-OHDKoLB1aL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 --- Comment #14 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:42:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:42:18 +0000 Subject: [Koha-bugs] [Bug 33038] Add classes to category code and category type in patron brief information for easier customization In-Reply-To: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33038-70-mWIWchjbZI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33038 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:42:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:42:20 +0000 Subject: [Koha-bugs] [Bug 33038] Add classes to category code and category type in patron brief information for easier customization In-Reply-To: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33038-70-GjcQ1WLYam@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33038 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:42:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:42:22 +0000 Subject: [Koha-bugs] [Bug 33238] (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-A4xYVTulTb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:42:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:42:24 +0000 Subject: [Koha-bugs] [Bug 33238] (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-CSoWM1YVpL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:43:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:43:02 +0000 Subject: [Koha-bugs] [Bug 33238] (Bug 29886 follow-up) With IndependentBranches Koha explodes with Error 500 when a non superlibrarian tries to add to basket from suggestions In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-uUZ8xuWhT9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- oh, what was it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:45:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:45:55 +0000 Subject: [Koha-bugs] [Bug 33238] Error adding suggestion to basket as non-superlibrarian (Bug 29886 follow-up) In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-K6D0tcWfvT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|(Bug 29886 follow-up) With |Error adding suggestion to |IndependentBranches Koha |basket as |explodes with Error 500 |non-superlibrarian (Bug |when a non superlibrarian |29886 follow-up) |tries to add to basket from | |suggestions | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:49:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:49:55 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-O1gW0qm4Nc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:49:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:49:57 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-Rni2SIwmFD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149717|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149752&action=edit Bug 31432: Make 245$n$p visible by default in frameworks $n (part_number) and $p (part_name) now have their own columns in the database, but we are still hiding them by default. It woudl ease testing and cataloguig if we changed them to be visible by default in new installations. To test: * Check that in your current frameworks when adding a new record, 245 n and p are hidden * Apply the patch and start over: drop your db and run the web installer * Verify that the fields are now visible Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:51:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:51:46 +0000 Subject: [Koha-bugs] [Bug 21762] ES: Is it possible to differentiate between any and anywhere? In-Reply-To: <bug-21762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21762-70-3pF6T672XY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21762 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #2) > Marcel, can this be closed with Nick's reply? Yes, it seems so. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:52:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:52:49 +0000 Subject: [Koha-bugs] [Bug 33229] Patron reading history should be cleared when privacy set to never In-Reply-To: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33229-70-RPH2WOUs4x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33229 --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149753&action=edit Bug 33229: (follow-up) Adjust tests to set anonymous patron before setting patron privacy to 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 14:59:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 12:59:08 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-eBxUCdFMLG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove unused xt/perltidyrc |Add project-level | |perltidyrc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:00:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:00:19 +0000 Subject: [Koha-bugs] [Bug 33229] Patron reading history should be cleared when privacy set to never In-Reply-To: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33229-70-xiFUbwZ3Hn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33229 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #13 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Follow-up pushed. Thanks Nick for the quick fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:02:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:02:17 +0000 Subject: [Koha-bugs] [Bug 25947] Improve locked account message In-Reply-To: <bug-25947-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25947-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25947-70-cKeUZJ9Ax0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25947 --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #6) > Reset login attempts as been asked by the library, this is a new feature. > I hope it makes sens, otherwise I may create a new bug report. As noted above, please remove that part here. It needs more attention too. See earlier comments. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:07:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:07:43 +0000 Subject: [Koha-bugs] [Bug 29598] Add a preference for default borrower's notice language In-Reply-To: <bug-29598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29598-70-x1bppBvC7w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29598 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #4) > (In reply to Marcel de Rooy from comment #0) > > Notice language for a new borrower via staff interface defaults to language > > of the staff interface user. > > In the OPAC self registration does not list the field and the value will be > > set to the database default called ... 'default'. > > > > Would be nice if we could make that more consistent. > > I can't reproduce this on master: > > * TranslateNotices off: Add a new patron. lang = default > * TranslateNotices on: Add a new patron. lang = default > * TranslateNotices on, staff user set to fr-FR. Add new patron. lang = > default > > Which version did you test with? My comment dates from 2021. So it must have been fixed in the meantime? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:14:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:14:03 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-ooLzJS1FXD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Nick Clemens from comment #8) > (In reply to Marcel de Rooy from comment #5) > > I think that it would be a very good thing to try caching here. What I am > > not sure about, is the theoretical possibility of getting wrong results if > > we would repeatedly ask for pickup_locations (while handling one request). > > > > The change in the test confirms this actually. You do not add a test for > > caching, but just add a flush. Removing that one makes the test fail. > > > > # Subtest: pickup_locations > > not ok 6 - ReservesControlBranch: PatronLibrary, biblio1, patron8 should > > return 3 but returns 1 > > not ok 7 - ReservesControlBranch: PatronLibrary, biblio2, patron1 should > > return 0 but returns 2 > > not ok 8 - ReservesControlBranch: PatronLibrary, biblio2, patron8 should > > return 3 but returns 0 > > # Looks like you failed 3 tests of 9. > > not ok 8 - pickup_locations > > > > I would recommend to add the flush in Biblio->pickup_locations. > > Those tests fail because we have changed a syspref - we are essentially > testing multiple requests there. It is not expected for a syspref to change > during a request. I flush to indicate that Thx for explaining. Would be good to add a short comment for such things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:15:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:15:41 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-fKMHsOwEZr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #5) > I think that it would be a very good thing to try caching here. What I am > not sure about, is the theoretical possibility of getting wrong results if > we would repeatedly ask for pickup_locations (while handling one request). > > I would recommend to add the flush in Biblio->pickup_locations. Apart from the syspref issue, this comment still got a bit out of sight. The theoretical(!) chance of calling it multiple times within one(!) request.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:33:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:33:17 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-CwG0krxF17@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149738|0 |1 is obsolete| | --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 149754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149754&action=edit Bug 32232: Ignore DST when calculating patron age This change calculates patron age using the floating timezone, so that datetimes missing midnight don't cause fatal errors in the comparison. Test plan: 0. Apply patch 1. Change <timezone></timezone> in koha-conf.xml to include Canada/Eastern 2. koha-plack --restart kohadev 3. Create a patron, setting the date of birth to one of these three dates - 1947-04-27 - 1948-04-25 - 1949-04-24 4. Save the patron 5. Patron detail page loads instead of producing fatal error Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:33:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:33:59 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-xx57LK6YO4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #10) > (In reply to Marcel de Rooy from comment #5) > > I think that it would be a very good thing to try caching here. What I am > > not sure about, is the theoretical possibility of getting wrong results if > > we would repeatedly ask for pickup_locations (while handling one request). > > > > I would recommend to add the flush in Biblio->pickup_locations. > > Apart from the syspref issue, this comment still got a bit out of sight. The > theoretical(!) chance of calling it multiple times within one(!) request.. Multiple times is fine, we don't expect sysprefs to change within a single request - even for different bibs the results are not different for the same type of item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:34:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:34:08 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-V9jGaBWJyq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:34:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:34:10 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-sPTAgViCuP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148157|0 |1 is obsolete| | Attachment #148161|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 149755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149755&action=edit Bug 33216: Catch and handle RegisterRequired exceptions for SIP fee paid messages If registers are being used in Koha, they are required. If a SIP account has no register and a fee paid message is sent, the SIP server crashes and the client never gets a response. It would be much better if Koha would response with 38 response where "payment accepted" is N, and an AF field stating that the SIP account needs to be associated with a register. Test Plan: 1) Enable UseCashRegisters, set RequireCashRegister to "always require a cash register". Do *not* set a cash register for the SIP account you will be testing with. 2) Using the SIP cli tester, send a fee paid message for a patron owing fees. 3) Note the lack of a SIP response 4) Apply this patch 5) Restart the SIP server 6) Repeat step 2, you should now get a SIP response with the error message in it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:34:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:34:39 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-JRAxSgoktK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7) > Hi Kyle, should this be Needs Signoff? Was missing a test plan. Fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:34:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:34:56 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33127-70-AkB3JuFtpt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:34:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:34:58 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33127-70-IUf0gcVsVd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149331|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149756&action=edit Bug 33127: Use template wrapper for breadcrumbs: Administration part 5 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> - Record overlay rules - Search filters (must have SavedSearchFilters enabled) - System preferences -> OverDriveAuthName -> OverDrive library authnames table - MARC bibliographic framework -> MARC structure (list, new, edit, delete confirm). - Record matching rules (list, new, edit, delete confirm) - OAI sets configuration (list, new, edit) -> Define mappings - Patron attribute types (list, new, edit, delete confirm) - Patron restrictions (list, new, edit, delete confirm) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:35:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:35:08 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-YlhlA4XXid@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Thanks so much David! I can't vouch for the coding part, but the patch does solve the problem of accessing the patron's file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:52:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:52:41 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-AJlDBREFA8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I can see why Julian didn't extend the line length.. I thought I'd have a go with the 178 suggestion and didn't like it at all. For me, I max out at around 120 for preference. Reasoning behind that for me is that I often read code on a widescreen monitor in portrait orientation. and at my comfortable font size 120 chars at (my term actually fits 128, but I don't mind the small right margin.. 120 happens to match what the mojolicious project uses). This also allows me to put two windows side by side on a wide screen and not have my lines get wrapped. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:58:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:58:39 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-wzHqaTIOrR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149755|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149757&action=edit Bug 33216: Catch and handle RegisterRequired exceptions for SIP fee paid messages If registers are being used in Koha, they are required. If a SIP account has no register and a fee paid message is sent, the SIP server crashes and the client never gets a response. It would be much better if Koha would response with 38 response where "payment accepted" is N, and an AF field stating that the SIP account needs to be associated with a register. Test Plan: 1) Enable UseCashRegisters, set RequireCashRegister to "always require a cash register". Do *not* set a cash register for the SIP account you will be testing with. 2) Using the SIP cli tester, send a fee paid message for a patron owing fees. 3) Note the lack of a SIP response 4) Apply this patch 5) Restart the SIP server 6) Repeat step 2, you should now get a SIP response with the error message in it! Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 15:58:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 13:58:52 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-kFOfDBL5FX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Working well, thanks Kyle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 16:12:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 14:12:38 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-zNheg0Z1h9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6) > Hi Lucas, > > I just realized that we had the "Click to..." previous to your patches, but > we should not do that. I've added a small follow-up to remove them. It being > a link or button already indicates that you can click it, see also > accessibility guidelines like: > https://www.mtu.edu/accessibility/training/web/link-text/ > Hope you agree :) > > But: The edit/add text change doesn't work perfectly yet: > > To test: > * Add a new subscription creating items on receive > * Receive a first issue and create the item > * From serial collection check both issues and edit > * The unreceived issue in status "arrived also has "Edit item", but there is > no item to edit yet > > I really like this change, can you please have another look? Good catch Katrin. I 100% agree with you. Should we set this back to NSO? Thanks for the follow-up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 16:12:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 14:12:48 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-n6Qh6pfJRM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I'm having a bit of unrelated trouble with the form. However, I'm wondering if a checkbox wouldn't be better in this case (rather that yes/no radio buttons). Similar to open baskets in acquisitions (when creating a new a basket, we can check a box is the orders are standing). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 16:37:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 14:37:26 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-Pg0lAGCZsk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I applied the patch and updated/installed translations. I see the line in fr-CA-messages-js.po #: koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue:108 #: koha-tmpl/intranet-tmpl/prog/js/holds.js:241 msgid "Yes" msgstr "Oui" But it's still showing up as Yes in the form. I wonder if my unrelated problem is not related after all. The options are displayed before the question https://snipboard.io/R8i9th.jpg Not sure why, but it's the same in the ByWater sandbox, so it's not something in my installation or something I'm doing/not doing... Also, do we really want it to say "Noes"? XD I thought I was not seeing this correctly, but it's in the diff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 16:42:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 14:42:28 +0000 Subject: [Koha-bugs] [Bug 27765] Set a custom order to library branches on opac-library.pl In-Reply-To: <bug-27765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27765-70-SRoLrOtdef@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27765 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com --- Comment #4 from Lisette Scheer <lisette.scheer at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #3) > It might also be interesting to use this in other places, like as a default > sort option for items. Yes, having the option to custom sort anywhere there are branches listed would be helpful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 16:49:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 14:49:37 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-GQxiwD8jpR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Marius <marius.mandrescu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 16:49:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 14:49:40 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-d0YJ0mb4hK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Marius <marius.mandrescu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149754|0 |1 is obsolete| | --- Comment #10 from Marius <marius.mandrescu at inlibro.com> --- Created attachment 149758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149758&action=edit Bug 32232: Ignore DST when calculating patron age This change calculates patron age using the floating timezone, so that datetimes missing midnight don't cause fatal errors in the comparison. Test plan: 0. Apply patch 1. Change <timezone></timezone> in koha-conf.xml to include Canada/Eastern 2. koha-plack --restart kohadev 3. Create a patron, setting the date of birth to one of these three dates - 1947-04-27 - 1948-04-25 - 1949-04-24 4. Save the patron 5. Patron detail page loads instead of producing fatal error Signed-off-by: Marius Mandrescu <marius.mandrescu at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 16:55:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 14:55:49 +0000 Subject: [Koha-bugs] [Bug 33544] New: Squash some ILL fields to alleviate request table overflow Message-ID: <bug-33544-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Bug ID: 33544 Summary: Squash some ILL fields to alleviate request table overflow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com The ILL requests' table listing all ILL requests is prone to overflowing it's container and requiring horizontal scrolling. This is against a number of accessibility guidelines, and just doesn't look very nice. I believe we could merge a number of the current columns to display the same data vertically in one column. I think the item details (author, title, article title, issue, volume, year, pages) could all be merged into a column that looks more like how we display search catalogue search results. That would save us a lot of horizontal space to start with. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 16:56:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 14:56:44 +0000 Subject: [Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow In-Reply-To: <bug-33544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33544-70-pDbsZIG7On@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 17:01:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 15:01:02 +0000 Subject: [Koha-bugs] [Bug 33545] New: Adding faceting to API result sets Message-ID: <bug-33545-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33545 Bug ID: 33545 Summary: Adding faceting to API result sets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com CC: tomascohen at gmail.com Sometimes it would be great to have some additional data about the overall results returned by an api resultset query. For example, if an API query returns a list of things that include a library they're attached to, it might be nice to be able to get a list of all libraries that appear in the resultset. (not just the current page). This way, we could display a select filter of just the libraries associated with the current api request to allow further filtering.. i.e. facetting. We floated the idea of x-koha-facets for requesting this, but we haven't yet come up with a good way to get this data or return it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 17:01:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 15:01:12 +0000 Subject: [Koha-bugs] [Bug 33545] Adding faceting to API result sets In-Reply-To: <bug-33545-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33545-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33545-70-di0SCLtOnW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33545 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 17:02:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 15:02:08 +0000 Subject: [Koha-bugs] [Bug 26788] Circulation rule note field too small In-Reply-To: <bug-26788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26788-70-5O4FJNJqUj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26788 --- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> --- Would still like this to hold more data. Tried saving a note today and was severely limited to what info I could put in the note. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 17:07:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 15:07:44 +0000 Subject: [Koha-bugs] [Bug 33546] New: Poll/Questionnaire tools needed Message-ID: <bug-33546-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33546 Bug ID: 33546 Summary: Poll/Questionnaire tools needed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It would be helpful to have some polling/questionnaire tools available in Koha. Maybe something that is available only to logged in patrons, and would have answers recorded anonymously? I'm picturing a table that would record answers linked to questions, and a separate table that keeps track of who has answered a set of questions or poll, but not link the two together in any way. Maybe options to either limit the questionnaire to once per account or email address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 17:09:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 15:09:33 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-Q0N0AYzmWm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- It would help to have a test plan to know what is supposed to be corrected. I came here because of the 'is perpetual' thing, but I'm not sure what the other commits do -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 17:11:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 15:11:40 +0000 Subject: [Koha-bugs] [Bug 33200] IndependentBranchesTransfers does not prevent holds from creating transfers In-Reply-To: <bug-33200-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33200-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33200-70-75PnG0B74G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33200 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- As I didn't receive an answer to my comment #4, I'm putting this back in Needs Signoff. Like I said, the two other points were addressed in the latest patches by Hammat. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 17:19:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 15:19:58 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-7lB2vvfaXT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Matt pointed me to bug 33355 for my form problems. This one doesn't apply on top of that. So I can't check if it solves my problem. I retested and Yes/No are still in english. (It's not even Yes/Noes, so I have no idea what I'm doing wrong) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 17:32:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 15:32:44 +0000 Subject: [Koha-bugs] [Bug 33546] Poll/Questionnaire tools needed In-Reply-To: <bug-33546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33546-70-puMNZB10Hh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33546 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Severity|enhancement |new feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 17:46:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 15:46:52 +0000 Subject: [Koha-bugs] [Bug 30077] Add option for library dropdown in search function for staff interface In-Reply-To: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30077-70-ewRkK7xfdV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30077 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/661 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 17:50:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 15:50:07 +0000 Subject: [Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems In-Reply-To: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30392-70-aMIt66Dly5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #26 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Not sure what needs to be documented here. It doesn't affect the user interface. I'm closing, but feel free to reopen with more details as to what needs to be added to the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 17:56:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 15:56:53 +0000 Subject: [Koha-bugs] [Bug 30327] Sort component parts In-Reply-To: <bug-30327-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30327-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30327-70-nWeMrdGieS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30327 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/661 CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 18:33:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 16:33:37 +0000 Subject: [Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds In-Reply-To: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14783-70-zAI3omjvKF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/661 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 18:33:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 16:33:38 +0000 Subject: [Koha-bugs] [Bug 32470] (Bug 14783 follow-up) Fix mysql error in db_rev for 22.06.000.064 In-Reply-To: <bug-32470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32470-70-2A4MpmXcDq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32470 Bug 32470 depends on bug 14783, which changed state. Bug 14783 Summary: Allow patrons to change pickup location for non-waiting holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 18:36:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 16:36:22 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-LxLYBmJ7sT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #11 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149759&action=edit Bug 33168: (follow-up) Swap spaces for tabs Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 18:42:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 16:42:13 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-W4hIvpaMeg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- I retested and can confirm that the images not being retained when scrolling through the shelf browser exists without this patch. It has already been filed as bug 29993. Everything else about this patch works great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 18:42:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 16:42:58 +0000 Subject: [Koha-bugs] [Bug 29993] Syndetics cover images do not display in browse shelf when scrolling from the first page In-Reply-To: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29993-70-CviOQYtML5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:00:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:00:03 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-aMihiIimRZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 --- Comment #14 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149760&action=edit Screenshot before patch 149117 and the problems it fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:00:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:00:32 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-jsZduft0Cb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 --- Comment #15 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149761&action=edit Screenshot before patch 149118 and the problems it fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:02:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:02:18 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-QfuVG4rmey@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 --- Comment #16 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- (In reply to Caroline Cyr La Rose from comment #13) > It would help to have a test plan to know what is supposed to be corrected. > I came here because of the 'is perpetual' thing, but I'm not sure what the > other commits do Hi Caroline, thank you so much for looking into this. Apologies for not being clear enough. Please take a look at the screenshots I attached, I hope those help in explaining the problems and respective fixes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:06:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:06:54 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-Ev8PG8Bzft@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:10:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:10:05 +0000 Subject: [Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved In-Reply-To: <bug-32702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32702-70-Qzjm0vomYE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:10:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:10:07 +0000 Subject: [Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved In-Reply-To: <bug-32702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32702-70-dvZxWaiC7B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145590|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149762&action=edit Bug 32702: Move item status checks to CanItemBeReserved This patch moves item status checks from IsAvailableForItemLevelRequest to CanItemBeReserved. Changes to existing calls highlighted below. Existing Calls for CanItemBeReserved/CanBookBeReserved: Call in Circulation.pm checkHighHolds - previously would have allowed damaged, notforloan, etc items to fill holds CanBookBeRenewed - Already a combination of CanItemBeReserved and IsAvailableForItemLevelRequest Call in ILSDI/Services.pm HoldItem - would have allowed placing holds on damaged/notforloan/etc items GetServices - Already a combination of CanItemBeReserved and IsAvailableForItemLevelRequest C4/Reserves: What is ItemsAnyAvailableAndNotRestricted used for C4/SIP/ILS/Transaction/Hold.pm: do_hold - would have allowed hold on lost/damaged/etc. Koha/Club/Hold/pm: add - would have allowed etc. Koha/REST/V1/Holds.pm: add - would have allowed ... opac/opac-reserve.pl: Was already combo of CanItemBeReserved and IsAvailableForItemLevelRequest reserve/placerequest: Items would have been filtered on reserve/request.pl by IsAvailableForItemLevelRequest In this case and opac, I believe before this a hold could have been forced with the right parameters Existing Calls for IsAvailableForItemLevelRequest C4/Circulation - see above Call in opac/opac-reserve.pl: Already a combination of CanItemBeReserved and IsAvailableForItemLevelRequest Call in reserve/request.pl: Already a combination of CanItemBeReserved and IsAvailableForItemLevelRequest To test: 1 - Setup a record with items to have: 1 available item 1 lost item 1 item with positive not for loan status 1 item with negative not for loan status 1 item withdrawn 1 item damaged 1 item not for loan by itemtype 2 - Attempt to place hold on staff and opac and note the statuses 3 - Apply patch 4 - Confirm the statuses have not changed 5 - Attempt to hold lost/damaged/withdrawn/notforloan items via API 6 - You should not be able to place the hold 7 - Attempt to place club holds on these items - it should not be possible 8 - Attempt to place holds via ILSDI - it should not be possible -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:10:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:10:09 +0000 Subject: [Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved In-Reply-To: <bug-32702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32702-70-ZMQXOE86xa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149763&action=edit Bug 32702: Unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:24:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:24:14 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-dsuTmjgQm8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:36:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:36:14 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-MN7RtGSX8X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:36:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:36:16 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-lLWKpSYhXi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149764&action=edit Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Most circulated items - Report results - Items with no checkouts - Report results - Catalog statistics wizard - Report results - View dictionary - New definition (steps 1-5) - Saved reports - View report - New report - Edit report - Guided reports - Build a report - Steps 1 through 6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:43:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:43:45 +0000 Subject: [Koha-bugs] [Bug 29993] Syndetics cover images do not display in browse shelf when scrolling from the first page In-Reply-To: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29993-70-KCpJveLj7P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:43:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:43:47 +0000 Subject: [Koha-bugs] [Bug 29993] Syndetics cover images do not display in browse shelf when scrolling from the first page In-Reply-To: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29993-70-l4oRL3qVlF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149765&action=edit Bug 29993: Show Syndetics covers when using shelfbrowser controls 1. Have items that include itemcallnumber. 2. Enable OPACShelfBrowser. 3. Enable SyndeticsCoverImages and SyndeticsEnabled. 4. Go the an OPAC detail page and open the shelf browser. 5. Use the Next/Previous buttons. 6. Notice that no Syndetics images populate after using Next/Previous buttons. 7. Apply patch and try again, cover images for Syndetics should be generating. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:44:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:44:14 +0000 Subject: [Koha-bugs] [Bug 29993] Syndetics cover images do not display in browse shelf when scrolling from the first page In-Reply-To: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29993-70-gqDbwjJxw3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com Version|20.11 |master Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:44:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:44:39 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-GEqA0rZQYm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Barbara Johnson from comment #12) > I retested and can confirm that the images not being retained when scrolling > through the shelf browser exists without this patch. It has already been > filed as bug 29993. Everything else about this patch works great. Thanks Barbara, I have also added a patch for Bug 29993. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:47:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:47:28 +0000 Subject: [Koha-bugs] [Bug 29993] Syndetics cover images do not display in browse shelf when scrolling from the first page In-Reply-To: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29993-70-moOGM0pB44@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149765|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149766&action=edit Bug 29993: Show Syndetics covers when using shelfbrowser controls 1. Have items that include itemcallnumber. 2. Enable OPACShelfBrowser. 3. Enable SyndeticsCoverImages and SyndeticsEnabled. 4. Go the an OPAC detail page and open the shelf browser. 5. Use the Next/Previous buttons. 6. Notice that no Syndetics images populate after using Next/Previous buttons. 7. Apply patch and try again, cover images for Syndetics should be generating. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:47:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:47:54 +0000 Subject: [Koha-bugs] [Bug 29993] Syndetics cover images do not display in browse shelf when scrolling from the first page In-Reply-To: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29993-70-n71BkmoYb9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29993 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #3 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- works like a charm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 19:57:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 17:57:50 +0000 Subject: [Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3 In-Reply-To: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33438-70-DjwqWsVX1p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 20:35:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 18:35:22 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-QFHHXc6JtM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 20:35:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 18:35:24 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-sFspt3FWfo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149697|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149767&action=edit Bug 33037: Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) Patch 32555 tries to resolve the issue caused by bug 31313. But the way it is fixed seems to be at least problematic. With patch 32555 we will never see the difference between `serial`.`serialseq` and `items`.`enumchron` which is still intended in opac-detail.tt (line ~ 1332) and [intranet] catalogue/detail.tt (line ~ 446). This is because ITEM_RESULT.serialitem (in opac-detail.tt) and item.itemserial.serial (in catalogue/detail.tt) refer to non-existing things. (and therefor the problem described in 32555 no longer emerge). The original problem is caused by mixing up serialitem with serial in [opac-]detail.pl and passing serialitem instead of serial to both templates. To test: 1. Create a serial subscription 1.1. Go to Serials 1.2. Click on New subscription 1.3. Fill out the first form - Vendor: leave empty - Record: enter a record number - Create an item record when receiving this serial - When there is an irregular issue: Keep issue number - Manual history: leave unchecked - Call number: leave empty - Library: Centerville - Public/nonpublic note: leave empty - Patron notification: None - Location: None - Collection: None - Item type: Continuing resources - Grace period: leave empty - Number of issues to display: leave both empty 1.4. Click Next (and confirm you are not using a vendor) 1.5. Fill out the second form - First issue publication date: 2023-01-01 - Frequency: 1/month - Subscription length: issues 12 - Subscription start date: 2023-01-01 - Subscription end date: 2024-01-01 - Numbering pattern: Number - Locale: leave empty - Begins with: 42 - Inner counter: leave empty 1.6. Click Test prediction pattern 1.7. Click Save subscription 2. Click OPAC view: Open in new window. 3. Back in the staff interface tab, receive an issue 3.1. Click Receive 3.2. In Status, choose Arrived for No. 42 3.3. IN ITEM DETAILS BELOW CHANGE h - Serial enumeration / chronology from No. 42 to some different string 3.3. Click Save 4. Check the items in OPAC and Intranet – you will see only the value from the item $h subfield (enumchron) instead of desired "enumchron -- serialseq" in case of a difference between `serial`.`serialseq` and `items`.`enumchron`. 5. Apply this patch 6. Repeat 4 7. Check the items in OPAC and Intranet – you should now see the desired "enumchron -- serialseq" string. 8. Sign off Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Nick <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 20:38:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 18:38:29 +0000 Subject: [Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3 In-Reply-To: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33438-70-EehQoPoHhm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 20:38:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 18:38:31 +0000 Subject: [Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3 In-Reply-To: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33438-70-3XDOUtE4xG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149768&action=edit Bug 33438: Use template wrapper for breadcrumbs: Reports part 3 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Average loan time - Results - Circulation statistics - Results - Lost items - Results - Catalog by item type - Results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 20:41:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 18:41:31 +0000 Subject: [Koha-bugs] [Bug 33210] (Bug 31963 follow-up) No hold fee message on OPAC should be displayed when there is no fee In-Reply-To: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33210-70-TupBeyBcEt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33210 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 20:41:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 18:41:33 +0000 Subject: [Koha-bugs] [Bug 33210] (Bug 31963 follow-up) No hold fee message on OPAC should be displayed when there is no fee In-Reply-To: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33210-70-ZMl3TE2gOp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33210 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149145|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149769&action=edit Bug 33210: Add unit test Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 20:41:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 18:41:35 +0000 Subject: [Koha-bugs] [Bug 33210] (Bug 31963 follow-up) No hold fee message on OPAC should be displayed when there is no fee In-Reply-To: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33210-70-hA8GhF4mdB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33210 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149144|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149770&action=edit Bug 33210: (Bug 31963 follow-up) No hold fee message on OPAC should be displayed when there is no fee After resolving Bug 31963 everything works as expected when there is hold fee defined (!= 0). But in case when the fee for given patron category is set to 0.00, the user will always see the message "You will be charged a hold fee of 0,00 ...", which is obviously not intended. This is because categories.reservefee is returned from database as '0.000000' and as such, without type casting, is interpreted as string in Perl. Prior to Bug 31963 the result was compared to 0 before sending anything to the template, so the casting was done, now it is not. To test: ======== 1. Go to Administration -> Patron categories 2. Edit your patron category and give a hold fee of 0. 3. HoldFeeMode does not matter - you can set it to any value. 4. In another tab, open the OPAC. 5. Search the OPAC for any record with an item. 6. Go to place a hold on this record. You will see "You will be charged a hold fee of 0,00" --> This is a bug. 7. Apply patch and restart services. 6. Repeat step 6. 8. You should NOT see the hold fee message. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 20:53:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 18:53:02 +0000 Subject: [Koha-bugs] [Bug 33547] New: Print slips from the preservation module Message-ID: <bug-33547-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33547 Bug ID: 33547 Summary: Print slips from the preservation module Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Notices Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 30708 Bug 30708 is going to add a new "preservation" module. We will need to print slip for items that will need to be processed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 [Bug 30708] Creation of a new 'Preservation' module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 20:53:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 18:53:02 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: <bug-30708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30708-70-eqeQHKvDqD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33547 [Bug 33547] Print slips from the preservation module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 20:53:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 18:53:48 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: <bug-30708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30708-70-aK90Q6ZcZi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amaury.gau at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 20:53:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 18:53:54 +0000 Subject: [Koha-bugs] [Bug 33547] Print slips from the preservation module In-Reply-To: <bug-33547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33547-70-ZOxKknIUei@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33547 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |amaury.gau at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:02:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:02:36 +0000 Subject: [Koha-bugs] [Bug 33543] Search within result list broken? In-Reply-To: <bug-33543-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33543-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33543-70-BstlNRzV0i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33543 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |nick at bywatersolutions.com Status|NEW |RESOLVED --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 33093 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:02:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:02:36 +0000 Subject: [Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' In-Reply-To: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33093-70-TJfI0T61vP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- *** Bug 33543 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:06:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:06:29 +0000 Subject: [Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' In-Reply-To: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33093-70-yf3BhBzft8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:06:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:06:31 +0000 Subject: [Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' In-Reply-To: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33093-70-moLhEvNEXO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093 --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149771&action=edit Bug 33093: (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' The feature of searching within search results in librarian interface has some problems with with elastic: 'Keyword' and 'Keyword as phrase' searches give no results. This is because elastic is unaware of the search field 'kw' and 'kw' is not transformed nor removed for limits. Test plan ========= 1. Have a Koha instance with reasonable number of biblio records 1. Set SearchEngine to Elasticsearch 3. In librarian interface, perform a search that would give you a list of results 4. With the new search box 'Search within results', having 'Keyword' and 'Keyword as phrase' active, try to perform a search within search results with a term that should give you some results 5. You should get no results 6. Apply the patch 7. Repeat steps 3 and 4 8. You should get expected results. Note the difference between 'Keyword' and 'Keyword as phrase' in results 9. Sign off Signed-off-by: Emmi Takkinen <emmi.takkinen at koha-suomi.fi> Signed-off-by: Nick <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:06:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:06:47 +0000 Subject: [Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' In-Reply-To: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33093-70-IeMTF6aNHL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149021|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:09:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:09:17 +0000 Subject: [Koha-bugs] [Bug 33548] New: Searching within results with IntranetCatalogPulldown quotes/searches as phrase all indexes except kw Message-ID: <bug-33548-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33548 Bug ID: 33548 Summary: Searching within results with IntranetCatalogPulldown quotes/searches as phrase all indexes except kw Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com kw handling was fixed in bug 33093 - we should investigate why the others are quoted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:09:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:09:27 +0000 Subject: [Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase' In-Reply-To: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33093-70-hJosQl07Wg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093 --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- This fixes the bug, it also improves handling of phrasing for keyword search - title and other limits are all quoted by default - which looks intentional, but this works as expected. I think we should open a follow-up to address limit phrasing at large and possible consolidate code - bug 33548 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:27:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:27:44 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-Py5oTyvi9W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:27:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:27:45 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-V3SqVEjWBv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149772&action=edit Bug 33206: Bad title__sort made of multifield 245 In MARC 21, having title search field defined in mappings.yaml as 245abp (more than one subfield), the Koha generated title__sort will have not only $a, but also other subfields cut by ind2 characters, i.e.: 245 04 $a Die Renaissance : $b Architektur, Plastik, Malerei, Illustrationen, Zeichnungen becomes as title__sort: Renaissance : itektur, Plastik, Malerei, Illustrationen, Zeichnungen instead of: Renaissance : Architektur, Plastik, Malerei, Illustrationen, Zeichnungen This is because copying an array of pointers in Perl causes you to point to the same (anonymous) element. Therefore, the intended modification only for subfield "a" (Koha/SearchEngine/Elasticsearch.pm, ~line 1157) causes in fact modification for all the subfields sharing the same mapping definition and introduction of the nonfiling_characters_indicator to all subfields 245 when processing 245abp. And this is obviously not what is intended and results (in some cases) with bad sort order when sorting by titles. Test plan ========= 1. Have a standard Koha ES installation. In mappings.yaml you should have 245abp for title search field. 2. Insert / download / modify a record with 245 $b or $p, an article at the beginning of the title, and correctly set 2nd indicator. For instance: 245 04 $a Die Renaissance : $b Architektur, Plastik, Malerei, Illustrationen, Zeichnungen 3. In ES, with Kibana or culr, control the content of title__sort field for the related document. It will be: Renaissance : itektur, Plastik, Malerei, Illustrationen, Zeichnungen 4. Apply the patch, full reindex ES (--rebuild -r -d -a -b) 5. In ES, with Kibana or culr, control the content of title__sort field for the related document. It should be now correct, i.e.: Renaissance : Architektur, Plastik, Malerei, Illustrationen, Zeichnungen Signed-off-by: Nick <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:28:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:28:17 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-PrtJNrIUrc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148103|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149773&action=edit Bug 33206: Unit test Signed-off-by: Nick <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:29:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:29:07 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-gtRR60rx9L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Added a unit test, correct commit title, make sure the format is: Bug ####: Description it had a dash not a colon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:30:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:30:58 +0000 Subject: [Koha-bugs] [Bug 33547] Print slips from the preservation module In-Reply-To: <bug-33547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33547-70-hdT4Vb3PPu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33547 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149774&action=edit Bug 33547: Add print slip Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:31:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:31:00 +0000 Subject: [Koha-bugs] [Bug 33547] Print slips from the preservation module In-Reply-To: <bug-33547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33547-70-zfEuII5Yui@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33547 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149775&action=edit Bug 33547: DBIC schema changes Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:42:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:42:15 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-7oVDEUwSkI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- The update works well, but installing fresh failed. It looks like a bad copy paste here: installer/data/mysql/mandatory/subtag_registry.sql All the lines like: INSERT INTO language_subtag_registry( subtag, type, description, added) Should be: INSERT INTO language_descriptions(subtag, type, lang, description) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:42:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:42:30 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-t31HmRK88t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- It's failing consistently for me on master right now and jenkins agrees with that, please try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:45:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:45:10 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-gkKs0NzHas@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- And this patch does not fix the failures... There are more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:51:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:51:20 +0000 Subject: [Koha-bugs] [Bug 33134] Add some missing languages In-Reply-To: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33134-70-FWrf4XPkQD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33134 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:51:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:51:22 +0000 Subject: [Koha-bugs] [Bug 33134] Add some missing languages In-Reply-To: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33134-70-3vp89pYk96@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33134 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147758|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149776&action=edit Bug 33134: Add some 76 missing languages When languages come into facets in ES, Koha should know the names for the codes used records. Otherwise the three-letters language code is being displayed in the facet instead of name. Koha now knows about 77 languages, many are still missing. The most missed 76 languages, in order of occurrences in my data sets, are (MARC 21 codes): grc, syr, chu, cop, arc, ang, epo, syc, gez, sla, san, csb, akk, gmh, egy, wen, gle, fro, rom, mac, mal, uga, mis, sem, sux, pli, bos, che, dum, kaz, tib, enm, frm, mlt, got, nds, ira, lin, uzb, ave, cho, jrb, bnt, pal, tut, goh, hsb, inc, mlg, roa, cel, sam, bem, fur, gem, hit, lad, nah, ota, peo, pro, tat, wel, yor, bra, den, hau, her, kas, mga, myn, nya, pra, que, tir, tuk. Here, I do not put language codes which are extremely rare in my data sets. Subtags and names for language_subtag_registry are taken from https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry, English names for language_descriptions.description - from https://www.loc.gov/marc/languages/language_code.html, and Polish names - from https://przepisy.bn.org.pl/aneksy#25-kody-jezykow---marc-21. Test plan: ========== 1. Hava a ES installation with reasonable number of records, with a variety of languages in 008/35-39 not present in Koha (you can modify your record with codes from the list above). Set FacetMaxCount to a high number (like 500 or so, dependiing on the size of your data set). 2. Do a search, like '*a*'. 3. Controll the content of the Language faset -- you should see some bare codes instead of language names. 4. Apply the patch -- update the database. 5. Perform the same search. 6. You should see the names in place of the codes. 7. Optionally, you can activate the Polish translation and you should be able to see Polish names for the added languages. Signed-off-by: Nick <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:55:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:55:57 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-l58yqTqKhD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:58:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:58:50 +0000 Subject: [Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results In-Reply-To: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28884-70-Q0kNtxOL0I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- This was "solved" with a hack on bug 31213 If I understand what this patch is doing, you are escaping the question mark so it no longer operates as a special character? This is not a bad idea, however, it needs to be documented with a comment in the code, as well as in the system preference. I think it would actually be better as its own system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:59:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:59:16 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-YyhBrJ7EFL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33483 Status|ASSIGNED |Signed Off --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Ok, bug 33483 is fixing most of the other failures. The remaining one (see comment 0) is fixed by this patch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 [Bug 33483] Cannot link EBSCO's package with local agreement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 21:59:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 19:59:16 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-jCG8We1tgi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 [Bug 33416] Agreements.ts is failing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:00:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:00:45 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-FBzwkYDLiZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #24 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Martin Renvoize from comment #21) > Hmmm.. I'd love to see some tests around this whole area... And also note that these patches are actually fixing several tests that are currently failing on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:01:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:01:08 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-1cR1D5NxA9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #25 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- We really need this ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:01:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:01:41 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-NeFeWdqrPN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:01:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:01:43 +0000 Subject: [Koha-bugs] [Bug 33549] New: Patron restriction types - Style missing for dialog messages Message-ID: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 Bug ID: 33549 Summary: Patron restriction types - Style missing for dialog messages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When adding or deleting patron restriction types, the dialog messages ("Type added", "Type deleted", etc.) have no styling. Normally, such messages are on a blue background. To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'New restriction' 4. Enter a code and label 5. Click 'Save' --> 'Type added' at the top of the page is not styled To see a regular dialog message: 1. Go to Administration > Debit types 2. Click 'New debit type' 3. Enter a code and description 4. Click 'Save' --> 'Debit type saved successfully' on blue background -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:01:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:01:56 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-ynpxPx07Cg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 [Bug 23681] Make patron restrictions user definable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:01:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:01:56 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-TDLzGosiGS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33549 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 [Bug 33549] Patron restriction types - Style missing for dialog messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:02:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:02:54 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-xrCJ8BMvyH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 AgustĂ­n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:02:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:02:58 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-AQxlgyF5zG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 AgustĂ­n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146412|0 |1 is obsolete| | --- Comment #5 from AgustĂ­n Moyano <agustinmoyano at theke.io> --- Created attachment 149777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149777&action=edit Bug 32607: Add CRUD for import sources This patch adds vue components to create, read, update and delete import sources To test: 1. apply patches 2. updatedatabase 3. yarn build_js 4. go to Administration -> Import sources 5. play around with the ui and create, update, remove and search import sources 6. Sign off ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:17:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:17:30 +0000 Subject: [Koha-bugs] [Bug 33550] New: Rename Patron restrictions administration page 'Patron restriction types' Message-ID: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Bug ID: 33550 Summary: Rename Patron restrictions administration page 'Patron restriction types' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This is a suggestion because I think it would make more sense (we have attribute types, credit types, debit types, etc.) but also to help with translations. Right now, the term for a restriction on a specific patron and the term for the restriction type administration are the same, but they don't mean the same thing. #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt:130 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt:38 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt:57 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/restrictions.tt:167 #: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:218 #: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:1411 #: koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc:58 #, c-format msgid "Patron restrictions" msgstr "Restrictions de l'utilisateur" In memberentrygen, it's to add a restriction to a specific patron In admin-home/menu and restrictions, it's to add restriction types Therefore, I think the administration page should be named 'Patron restriction types'. Opinions? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:22:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:22:07 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-9rxx32zTrc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 [Bug 23681] Make patron restrictions user definable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:22:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:22:07 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-eHI6qoJcg3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:24:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:24:47 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-dX6Zu706Z5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149474|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149778&action=edit Bug 33491: Fix UI issues in EHoldingsEBSCOPackageAgreements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:25:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:25:29 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-vA7QR4P59r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Pedro Amorim from comment #4) > It doesn't fix the "show mine only" being punted to the left, this is > because it's getting a float:left also from being a child of <fieldset> > (which is also causing the table to not be full width). > > The problem is <EHoldingsPackageAgreements> sits inside a <fieldset> in > EHoldingsEBSCOPackagesShow.vue. > > Then, in EHoldingsEBSCOPackageAgreements.vue we're opening the modal that > has <AgreementsList> inside it, but that modal is already a child of the > aforementioned <fieldset> so it's inheriting its style unintendendly. Fixed in the last version of the patch. > There is also another problem: the modal needs a overflow (and perhaps a > max-height?). If we have many agreements created, the modal overflows the > screen and doesn't let the user scroll vertically. I would suggest to deal with that on a separate bug. I think we need a separate component for modal, in which we will deal with this issue (we use .modal in a couple of places already) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:41:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:41:14 +0000 Subject: [Koha-bugs] [Bug 32921] SelfCheckTimeout doesn't logout if SelfCheckReceiptPrompt modal is open In-Reply-To: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32921-70-1o1f2igGxQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Marius <marius.mandrescu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:41:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:41:16 +0000 Subject: [Koha-bugs] [Bug 32921] SelfCheckTimeout doesn't logout if SelfCheckReceiptPrompt modal is open In-Reply-To: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32921-70-zCPsS5vYaP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32921 Marius <marius.mandrescu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146414|0 |1 is obsolete| | --- Comment #5 from Marius <marius.mandrescu at inlibro.com> --- Created attachment 149779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149779&action=edit Bug 32921: Honor SelfCheckTimeout when modal is open To test: 1. Set the 'SelfCheckTimeout' system preference to something low for testing. 2. Make sure 'SelfCheckReceiptPrompt' is set to 'Show'. 3. Log in to SCO and press finish but leave the modal open. 4. Wait until the 'SelfCheckTimeout' time has expired, nothing happens. 5. Apply patch and try again. You should be logged out when SelfCheckTimeout expires. Signed-off-by: Marius Mandrescu <marius.mandrescu at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:52:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:52:38 +0000 Subject: [Koha-bugs] [Bug 33551] New: Rogue span in Patron restriction types admin page Message-ID: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Bug ID: 33551 Summary: Rogue span in Patron restriction types admin page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:52:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:52:48 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-YYNSEhl1mN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 [Bug 23681] Make patron restrictions user definable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:52:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:52:48 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-XRjTzpEBrM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 [Bug 33551] Rogue span in Patron restriction types admin page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:53:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:53:40 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-qCFrs9yDHf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33077 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:53:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:53:40 +0000 Subject: [Koha-bugs] [Bug 33077] Improve ease of translating template title tags In-Reply-To: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33077-70-bFp7N3Fhr7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33077 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33551 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 22:54:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 20:54:33 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-tPB9A6ahkJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 --- Comment #4 from Janusz Kaczmarek <januszop at gmail.com> --- (In reply to Nick Clemens from comment #3) > The update works well, but installing fresh failed. > > > It looks like a bad copy paste here: > installer/data/mysql/mandatory/subtag_registry.sql > > All the lines like: > INSERT INTO language_subtag_registry( subtag, type, description, added) > > Should be: > INSERT INTO language_descriptions(subtag, type, lang, description) What a shame--indeed. Correction follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 23:00:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 21:00:03 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-6sLXxDlyiM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 23:00:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 21:00:05 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-eNnCioXhtS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 149780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149780&action=edit Bug 33550: Rename Patron restrictions administration page to Patron restriction types This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration. To test: 0. Apply patch 1. Enable PatronRestrictionTypes 2. Go to Administration 3. Check the name, spelling/grammar of the following elements * Section name * Section caption 4. Click 'Patron restriction types' 5. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Left hand side menu * 'New' button * Page heading 6. Click 'New restriction type' 7. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 8. Fill out the form and click 'Save' to create a new restriction type * Dialog message ('Restriction type added') 9. Click 'New restriction type' 10. Enter the same code as last time * Warning ('Restriction type code is already in use') 11. Click 'Cancel' 12. Click 'Edit' next to one of the types 13. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 14. Without changing anything, click 'Save' * Warning ('Restriction type label is already in use') 15. Change the label and click 'Save' * Dialog message ('Restriction type updated') 16. Click 'Delete' next to one of the types 17. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading * Delete button 18. Click 'Delete this restriction type' * Dialog message ('Restriction type deleted') -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 23:05:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 21:05:54 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-OGigkLQgLf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148101|0 |1 is obsolete| | --- Comment #5 from Janusz Kaczmarek <januszop at gmail.com> --- Created attachment 149781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149781&action=edit Bug 33128: Add Polish translations for language descriptions This adds the Polish translations for the different languages to subtag_registry.sql that is used by all languages during installation. Test plan: ========== * Apply patch * Run database update * Install pl-PL and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to Polish - verify the Polish translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated [Test plan courtesy of Bug 31715 for German] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 23:06:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 21:06:07 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-fKDJE4LyZe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 23:08:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 21:08:20 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-hJqES8Wibs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147150|0 |1 is obsolete| | --- Comment #9 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- Created attachment 149782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149782&action=edit Bug 32092: Improve circulation rules cache utilization To test: 1) Go to the page for placing a hold for a biblio with a large number of items 2) Depending on the number of items this page can be very slow to load 3) Ensure the following tests pass: t/db_dependent/Circulation.t t/db_dependent/Reserves.t t/db_dependent/Biblio.t t/db_dependent/Koha/Charges/Fees.t t/db_dependent/Koha/Charges/Fees.t t/db_dependent/Items.t t/db_dependent/Koha/Patron.t t/db_dependent/api/v1/checkouts.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Template/Plugin/CirculationRules.t t/db_dependent/Koha/CirculationRules.t 3) Apply the patch 4) The page loading time should now be significantly faster 5) Ensure all the tests in 3) still pass Sponsored-by: Gothenburg University Library Signed-off-by: Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 23:08:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 21:08:22 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-CRCTWGPzEM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147151|0 |1 is obsolete| | --- Comment #10 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- Created attachment 149783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149783&action=edit Bug 32092: Fix tests Signed-off-by: Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 23:14:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 21:14:31 +0000 Subject: [Koha-bugs] [Bug 30335] Add ability to hide/disable manual invoices and manual credits in patron accounts In-Reply-To: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30335-70-suKylFzlQP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30335 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/661 CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 23:17:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 21:17:09 +0000 Subject: [Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results In-Reply-To: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28884-70-fo36v2G6Sm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #8 from Janusz Kaczmarek <januszop at gmail.com> --- (In reply to Nick Clemens from comment #7) > This was "solved" with a hack on bug 31213 > > If I understand what this patch is doing, you are escaping the question mark > so it no longer operates as a special character? > > This is not a bad idea, however, it needs to be documented with a comment in > the code, as well as in the system preference. I think it would actually be > better as its own system preference. Nick, I'm aware of your 'hack'--now, I'm unable to verify if quickly, but as far as I remember it didn't solve this case. If it did, there would be no point for me to dig into this. If I remember well, the patch intends to treat the question mark, in the function _query_regex_escape_process, in exactly the same way as it is done with slash: instead of escaping/unescaping only '/': (?=/) it escapes also '?': (?=[/\?]). Maybe I could extend the existing comment, but I don't feel like this is a candidate for a new syspref...? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 23:17:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 21:17:59 +0000 Subject: [Koha-bugs] [Bug 33364] Stop Holds to Pull report showing items that have been allocated to a recall In-Reply-To: <bug-33364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33364-70-CEEp2F6Fwr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33364 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149742|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149784&action=edit Bug 33364: [22.05] Prevent Holds to Pull from including items with pending recalls This patch changes the check for pending recalls to include items in transit, as well as items awaiting pickup, to fill a recall request. It then ensures the Holds to Pull report excludes items that have pending recalls. To test: 1. Enable UseRecalls and set the recalls-related circulation rules 2. Check out an item to Patron A 3. Place a hold on the item for Patron B 4. Log into the OPAC as Patron C and search for the item. Place a recall on the item. 5. Go back to the staff interface. Go to Circulation -> Holds to pull 6. Confirm the item shows in the Holds to pull table, with the hold for Patron B 7. Check in the item and confirm the recall as waiting 8. Go back to the Holds to pull page. You may need to manually regenerate the page by running the cronjob in the terminal misc/cronjobs/holds/build_holds_queue.pl 9. Notice that even though the item is allocated for a recall, the hold is showing. It should not be showing in this page. 10. Apply the patch and refresh the page 11. The item allocated to a recall should no longer be showing in the Holds to pull report 12. Go to the record detail page and go to the Recalls tab 13. Revert the recall from its waiting status 14. The record will now show on the Holds to pull page 15. Go to the Circulation -> Check in page 16. Go to the menu in the top-right of the page and click Set library 17. Change your library to a different one 18. Check in the item to confirm the recall as waiting and trigger a transfer 19. Go back to the Holds to pull page, regenerate if needed 20. The item should no longer show on the Holds to pull report 21. Confirm tests pass t/db_dependent/Koha/Item.t Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 17 23:32:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 21:32:51 +0000 Subject: [Koha-bugs] [Bug 32092] Improve circulation rules cache utilization In-Reply-To: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32092-70-Q55OxW2DDV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32092 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov Status|Needs Signoff |Signed Off --- Comment #11 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- Notes for QA team: - Circulation.t failed on master before applying the patch, and produced identical output after applying the patch. - Perl gave the warning, "Use of uninitialized value in addition (+)" warning for Patron.pm line 1091 when running the tests. It looks like + 0 was added to the output of the function to force an empty result to store as 0 rather than "", yes? The tests still passed and as far as I know this doesn't need to block a signoff, but noting it out of thoroughness in case it matters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 00:17:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 22:17:37 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29002-70-W5EDDMyrrr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Kris <kbecker at jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker at jcls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 01:29:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 23:29:16 +0000 Subject: [Koha-bugs] [Bug 33546] Poll/Questionnaire tools needed In-Reply-To: <bug-33546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33546-70-P3DeUpKRP8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33546 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook <dcook at prosentient.com.au> --- \ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 01:30:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 23:30:49 +0000 Subject: [Koha-bugs] [Bug 33546] Poll/Questionnaire tools needed In-Reply-To: <bug-33546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33546-70-PUJgIGdmC2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33546 --- Comment #2 from David Cook <dcook at prosentient.com.au> --- Years ago, we locally provided surveys alongside Koha, but none of our (predominately special) libraries used them, and we eventually removed the customization. It could be interesting for public and maybe academic libraries though. That said, this one might be best off as a Koha plugin I think. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 01:31:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 23:31:59 +0000 Subject: [Koha-bugs] [Bug 33545] Adding faceting to API result sets In-Reply-To: <bug-33545-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33545-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33545-70-OWLdPsmYsw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33545 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 01:39:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Apr 2023 23:39:49 +0000 Subject: [Koha-bugs] [Bug 33546] Poll/Questionnaire tools needed In-Reply-To: <bug-33546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33546-70-oi5Tph6OkV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33546 --- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to David Cook from comment #2) > Years ago, we locally provided surveys alongside Koha, but none of our > (predominately special) libraries used them, and we eventually removed the > customization. > > It could be interesting for public and maybe academic libraries though. > > That said, this one might be best off as a Koha plugin I think. A plugin would be welcome. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 02:22:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 00:22:40 +0000 Subject: [Koha-bugs] [Bug 31427] Automatic renewal too_many error is confusing in notices In-Reply-To: <bug-31427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31427-70-vx0VZ9MdpF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook <dcook at prosentient.com.au> --- I'm starting to think that automatic renewal errors shouldn't be sent out at all. That only automatic successes should be sent out. Although in this case I actually have a local customization where I skip renewal handling if it's too soon to renew. The current precedence of errors in automatic renewals is completely illogical. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 02:26:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 00:26:11 +0000 Subject: [Koha-bugs] [Bug 33552] New: Automatic renewals should only send emails for successes Message-ID: <bug-33552-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 Bug ID: 33552 Summary: Automatic renewals should only send emails for successes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org I get frequent complaints from libraries about patrons getting emails saying their items can't auto renew. The typical error message is "too_many", and it's sent every single day. Most of the time, we probably only want to send email notices out when the item has successfully renewed. Then notices like advanced item due, item due, and overdues take over from there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 02:26:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 00:26:22 +0000 Subject: [Koha-bugs] [Bug 33552] Automatic renewals should only send emails for successes In-Reply-To: <bug-33552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33552-70-ocdsUKBgZ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31427 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 02:26:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 00:26:22 +0000 Subject: [Koha-bugs] [Bug 31427] Automatic renewal too_many error is confusing in notices In-Reply-To: <bug-31427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31427-70-BfqRiawoZp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33552 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 02:27:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 00:27:22 +0000 Subject: [Koha-bugs] [Bug 33552] Automatic renewals should only send emails for successes In-Reply-To: <bug-33552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33552-70-BUVQfA6gG3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 --- Comment #1 from David Cook <dcook at prosentient.com.au> --- (On a side note, the precedence of errors in automatic renewals makes no sense. In the most common scenarios, you'll probably never see an "overdue" because you'll get "too_many" first.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 02:32:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 00:32:14 +0000 Subject: [Koha-bugs] [Bug 33552] Automatic renewals should only send emails for successes In-Reply-To: <bug-33552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33552-70-dlqF8Q3qWY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33552 --- Comment #2 from David Cook <dcook at prosentient.com.au> --- Since people will disagree on this one, we would wrap it in a system preference anyway. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 04:21:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 02:21:15 +0000 Subject: [Koha-bugs] [Bug 33534] catalog New record An error has occurred! Error 500 In-Reply-To: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33534-70-Y14u1qGucE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33534 --- Comment #6 from Jen <jenni.neenan at defence.gov.au> --- Thanks, David. i have just access the IRC but am unsure how to create a chat. I'll watch a video and hopefully can add my issue soon. Jen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 04:32:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 02:32:10 +0000 Subject: [Koha-bugs] [Bug 33534] catalog New record An error has occurred! Error 500 In-Reply-To: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33534-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33534-70-T4OrlIBnm9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33534 --- Comment #7 from David Cook <dcook at prosentient.com.au> --- (In reply to Jen from comment #6) > Thanks, David. i have just access the IRC but am unsure how to create a > chat. I'll watch a video and hopefully can add my issue soon. > > Jen I take it that you're "Jennee" on IRC? I'm dcook. After you hit the "Connect" button and it says "Welcome to #koha this channel is for discussion of the Koha project and software", you can start chatting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 06:58:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 04:58:58 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-RFyaDHh6Xb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149785&action=edit Bug 33478: Add formatting columns to letter table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 06:59:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 04:59:01 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-kHrjnmNuk8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149786&action=edit Bug 33478: Schema updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 06:59:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 04:59:03 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-FHh5TMITmQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149743|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149787&action=edit Bug 33478: [WIP] Allow formatting of notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 08:56:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 06:56:18 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-Nl3Vi6i2ct@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149630|0 |1 is obsolete| | --- Comment #60 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149788&action=edit Bug 33103: DBIC schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 08:56:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 06:56:57 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-kEc9beUbmv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 --- Comment #61 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I've got a very weird git conflict with the previous patch, it was trying to modify Koha/Schema/Result/CurbsidePickupIssue.pm (??) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 09:02:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 07:02:32 +0000 Subject: [Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results In-Reply-To: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28884-70-wUFe7Ooety@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Janusz Kaczmarek from comment #8) > (In reply to Nick Clemens from comment #7) > > This was "solved" with a hack on bug 31213 > > > > If I understand what this patch is doing, you are escaping the question mark > > so it no longer operates as a special character? > > > > This is not a bad idea, however, it needs to be documented with a comment in > > the code, as well as in the system preference. I think it would actually be > > better as its own system preference. > > Nick, I'm aware of your 'hack'--now, I'm unable to verify if quickly, but as > far as I remember it didn't solve this case. If it did, there would be no > point for me to dig into this. > > If I remember well, the patch intends to treat the question mark, in the > function _query_regex_escape_process, in exactly the same way as it is done > with slash: instead of escaping/unescaping only '/': (?=/) it escapes also > '?': (?=[/\?]). Maybe I could extend the existing comment, but I don't feel > like this is a candidate for a new syspref...? I think it would be nice if we could keep the truncation feature without requiring to escape it. It's easy to explain to people to use ?, but much harder to explain \? - also quite a change in behavior at this point maybe? I was wondering, if ? replaces one or more characters... why does it not work as a wild card if there really is a question mark? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 09:25:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 07:25:57 +0000 Subject: [Koha-bugs] [Bug 12802] Send notices using several email addresses In-Reply-To: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12802-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12802-70-lfPlVYMhST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 09:26:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 07:26:12 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-gpPcrZtNQO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Quick code review: 1. There are several wrong indentations (2 vs 4 spaces) or mismatch indentation (Koha::REST::V1::ImportSources->get for instance). You should run perltidy on new perl files 2. DB tables should be plural, import_source*s* (like other tables) 3. (naming) It's not clear what is Koha::ImportSource->patron and import_source.patron_id, could we find something more meaningful? 4. Permission check in missing in admin-home.tt 5. Permission description is missing in includes/permissions.inc 6. import-sources.tt * + const RESTOAuth2ClientCredentials = [% IF Koha.Preference('RESTOAuth2ClientCredentials') %]true[% ELSE %]false[% END %]; not needed? * "erm" occurrences need to be adjusted 7. FormKit/Form => You are introducing a change that is not applied to other Vue files, and you are changing the UI, it's not consistent with other area of Koha. I don't think we are ready for that. 8. In ISEdit.vue, processSubmit. The way we are displaying the message is in then(). Same for the other AJAX requests in other components. 9. ISList.vue you should not display an empty table, to be consistent with other tables. 10. the routes: you are deciding to change the URL, admin/import-sources.pl/add We are not having the '.pl' for other vue pages (which require the apache's rewriterule, but I think we need to stay consistent) 11. import-sources.js You are using add/remove/update/getOne when we use create/delete/update/get in other fetch files. 12. In patron-api-client.js you are using "list" when we use "getAll" in ERM 13. About autocomplete, I would not use it. We already have a way to select patrons (in all the different Koha modules, and the same that we reuse in ERM). If we want an autocomplete feature I think we should then use select2 and implement bug 32474. I'd like to add that, as usual, I am not against new ways of doing things, but we need to apply them first to the existing code, and be consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 10:20:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 08:20:20 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-CJswbA4j0G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I've decided to just go straight for QA here.. lets pass it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 10:45:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 08:45:41 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-wafoBWgC3X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #40 from Frank Hansen <frank.hansen at ub.lu.se> --- (In reply to Katrin Fischer from comment #39) > Can someone help to get this tested? I have now tested the patch on my testing docker. I get different results depending on whether I choose the ES or the Zebra engine. I am following the test plan in comment #17 ES works flawlessly. All headings are linked after the patch is applied. But when doing the same using Zebra, without the patch installed only field 100 is linked. After applying the patch and restarted not all headings are linked. Only field 100, 655 (Literature English), 700 and 830 fields are linked after saving the record again. Have I missed something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 12:13:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 10:13:58 +0000 Subject: [Koha-bugs] [Bug 33503] Plugin OpenAPI2.0 specification schema fragments are not resolved. Merge full schema definitions. In-Reply-To: <bug-33503-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33503-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33503-70-rBrfJeJA2b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33503 --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at hypernova.fi> --- >From the plugin, one can implement this hook with this code fragment: sub api_spec { my ( $plugin, $args ) = @_; return JSON::Validator::Schema::OpenAPIv2->new; my $schema2 = JSON::Validator::Schema::OpenAPIv2->new; $schema2->resolve($plugin->mbf_dir() . "/openapi.yaml"); return $schema2->bundle->data; #Bundle merges the external/internal/local references in the plugin schema path. } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 12:22:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 10:22:48 +0000 Subject: [Koha-bugs] [Bug 32966] [DOCS] Build error on GitLab - sphinxcontrib.spelling extension error In-Reply-To: <bug-32966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32966-70-Ju9R3DPXt1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32966 --- Comment #5 from David Nind <david at davidnind.com> --- Have updated the build process for 22.11.x, so the 22.11 manual should now build. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 12:56:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 10:56:27 +0000 Subject: [Koha-bugs] [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4 In-Reply-To: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33439-70-iWAzQZQTtO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 12:56:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 10:56:30 +0000 Subject: [Koha-bugs] [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4 In-Reply-To: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33439-70-fNRpsZiWKd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149789&action=edit Bug 33439: Use template wrapper for breadcrumbs: Reports part 4 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Reports home - Orders by fund - Results - Holds statistics wizard - Results - Serials statistics wizard - Results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 12:59:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 10:59:22 +0000 Subject: [Koha-bugs] [Bug 33553] New: Unecessary GetCategories calls in template Message-ID: <bug-33553-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33553 Bug ID: 33553 Summary: Unecessary GetCategories calls in template Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs-add-modify.tt:[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %] koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-enroll.tt:[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %] koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt:[% SET AuthorisedValuesCategories = AuthorisedValues.GetCategories %] AuthorisedValuesCategories is not used later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:07:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:07:01 +0000 Subject: [Koha-bugs] [Bug 33554] New: searching borrowers is a lot slower if there's searchable extended attributes. Message-ID: <bug-33554-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 Bug ID: 33554 Summary: searching borrowers is a lot slower if there's searchable extended attributes. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 30055 Hi, Since BZ 30055 search is using the REST API. For a library with 80,000 borrowers and 800,000 borrower_attributes, (one searchable per borrower), searching a borrower is twice as slow and is noticeable in checkin/checkout. before 30055 the request was something like : SELECT borrowernumber FROM borrowers WHERE firstname` LIKE '%foo%' OR middle_name LIKE '%foo%' OR surname LIKE '%foo%' OR othernames LIKE '%foo%' OR cardnumber LIKE '%foo%' OR userid LIKE '%foo%' OR borrowernumber in ( select borrowernumber from borrower_attributes where attribute LIKE '%foo%' AND code = 'BAR' ) GROUP BY borrowernumber; runtime 0.069 sec in master SELECT borrowernumber FROM borrowers LEFT JOIN borrower_attributes USING(borrowernumber) WHERE firstname` LIKE '%foo%' OR middle_name LIKE '%foo%' OR surname LIKE '%foo%' OR othernames LIKE '%foo%' OR cardnumber LIKE '%foo%' OR userid LIKE '%foo%' OR (attribute LIKE '%foo%' AND code = 'BAR' ) GROUP BY borrowernumber; runtime 1.324 sec Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:07:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:07:01 +0000 Subject: [Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes In-Reply-To: <bug-30055-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30055-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30055-70-CbCBSpP06q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Didier Gautheron <didier.gautheron at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33554 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:21:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:21:00 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-AAtjlqR3NU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #41 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Frank Hansen from comment #40) > (In reply to Katrin Fischer from comment #39) > > Can someone help to get this tested? > > I have now tested the patch on my testing docker. I get different results > depending on whether I choose the ES or the Zebra engine. I am following the > test plan in comment #17 > > ES works flawlessly. All headings are linked after the patch is applied. > > But when doing the same using Zebra, without the patch installed only field > 100 is linked. After applying the patch and restarted not all headings are > linked. Only > field 100, 655 (Literature English), 700 and 830 fields are linked after > saving the record again. > > Have I missed something. The test plan is missing the steps for Zebra as the index files need to be copied and then a full reindex: sudo cp /kohadevbox/koha/etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl /etc/koha/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl restart_all sudo koha-rebuild-zebra -v -f kohadev -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:22:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:22:04 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-8Q05mmCKMG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Nick Clemens from comment #11) > (In reply to Marcel de Rooy from comment #10) > > (In reply to Marcel de Rooy from comment #5) > > > I think that it would be a very good thing to try caching here. What I am > > > not sure about, is the theoretical possibility of getting wrong results if > > > we would repeatedly ask for pickup_locations (while handling one request). > > > > > > I would recommend to add the flush in Biblio->pickup_locations. > > > > Apart from the syspref issue, this comment still got a bit out of sight. The > > theoretical(!) chance of calling it multiple times within one(!) request.. > > Multiple times is fine, we don't expect sysprefs to change within a single > request - even for different bibs the results are not different for the same > type of item I had in mind to be depending on some patron attribute too, but it looks good. In pickup_locations and related calls, we only seem to actually use branchcode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:24:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:24:17 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: <bug-33554-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33554-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33554-70-7T9zRZeeh8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33489 CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- An index on those tables might help - we saw similar issues on a site with many borrowers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:24:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:24:17 +0000 Subject: [Koha-bugs] [Bug 33489] The borrowers table should have indexes on default patron search fields In-Reply-To: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33489-70-s2zC1Rjra2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33489 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33554 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:30:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:30:08 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-3yuzf9QG8v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:30:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:30:12 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-JPZXBmMjuv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149389|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149790&action=edit Bug 33447: Add Cache to Biblio->pickup_locations This is going to have the most effect on records with large numbers of items held by the same library, serial records and the like To test: 1 - Add 500 items to a biblio by select myltiple copies on the add item page 2 - Place a hold via the API and note response time, I found ~3-5 seconds 3 - Apply patch 4 - Restart all 5 - Place hold using api again 6 - Note improved response time, less than 1/2 a second in my tests Signed-off-by: emlam <emily.lamancusa at montgomerycountymd.gov> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:30:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:30:14 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-6uwqi1Ky6v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149390|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149791&action=edit Bug 33447: Adjust tests Signed-off-by: emlam <emily.lamancusa at montgomerycountymd.gov> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:30:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:30:17 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-OC7LYyMdJE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149792&action=edit Bug 33447: (QA follow-up) Add comment for flushing cache Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:48:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:48:19 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-9pnXncLhI4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- What you actually need, is: UPDATE systempreferences SET variable='AutomaticConfirmTransfer' WHERE variable='AutomaticWrongTransfer' This works always. No need to count, delete, etc. You could even catch the number of updated recs. No blocker, just noting for next time :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:48:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:48:58 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-JIyEMlAalu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:49:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:49:00 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-cjoOSSarmU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148581|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149793&action=edit Bug 33300: Wrong system preference name AutomaticWrongTransfer Bug 29792 added a DBRev with new system preference 'AutomaticConfirmTransfer'. But name in installer/data/mysql/mandatory/sysprefs.sql is wrong 'AutomaticWrongTransfer' Test plan : Create a new database and check there is in table systempreferences an entry with variable='AutomaticConfirmTransfer' Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:49:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:49:03 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-iCgSRdIWkL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149721|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149794&action=edit Bug 33300: (follow-up) DBRev for existing databases Test plan : 1.1) Start from a Koha 22.05 1.2) Upgrade to master => Check the upgrade says : Wrong system preference 'AutomaticWrongTransfer' renamed 'AutomaticConfirmTransfer' 2.1) Start from a Koha 22.05 2.2) Upgrade to 22.11 2.3) Via interface change system preference 'AutomaticConfirmTransfer' and save 2.4) Upgrade to master => Check the upgrade says : Wrong system preference 'AutomaticWrongTransfer' deleted Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 13:57:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 11:57:18 +0000 Subject: [Koha-bugs] [Bug 30931] Handling of items.dateaccessioned in the item editor In-Reply-To: <bug-30931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30931-70-ZiEFI6fbO0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Alex Buckley from comment #0) > This bug report is for the community to decide which of the following is > desired for handling of the dateaccessioned field in the item editor: > > 1. A hint - To tell users if they leave the items.dateaccessioned field > (which is typically linked to the 952$d subfield) empty when adding a new > item in serials, cataloguing, or acquisitions then Koha will automatically > save the current date in that field. > > OR > > 2. Context-aware behaviour - Koha only pre-fills the item editor > dateaccessioned field with the current date when the item is added/new. > > Shifting this discussion away from bug 29963 so the community can proceed to > upstream the reversion of bug 29815 As I understand, the first patch is meant to revert 29815 but why doesnt it revert the plugin then? cataloguing/value_builder/dateaccessioned.pl Changing status. Please explain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:04:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:04:00 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-paDLvCT30i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149757|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 149795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149795&action=edit Bug 33216: Catch and handle RegisterRequired exceptions for SIP fee paid messages If registers are being used in Koha, they are required. If a SIP account has no register and a fee paid message is sent, the SIP server crashes and the client never gets a response. It would be much better if Koha would response with 38 response where "payment accepted" is N, and an AF field stating that the SIP account needs to be associated with a register. Test Plan: 1) Enable UseCashRegisters, set RequireCashRegister to "always require a cash register". Do *not* set a cash register for the SIP account you will be testing with. 2) Using the SIP cli tester, send a fee paid message for a patron owing fees. 3) Note the lack of a SIP response 4) Apply this patch 5) Restart the SIP server 6) Repeat step 2, you should now get a SIP response with the error message in it! Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:06:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:06:04 +0000 Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in templates In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32127-70-dK9WLz21Fq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:06:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:06:06 +0000 Subject: [Koha-bugs] [Bug 32127] Sort patron categories by description in templates In-Reply-To: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32127-70-gaBLXGHbaB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32127 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:06:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:06:07 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-61gIRQjvKl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:06:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:06:09 +0000 Subject: [Koha-bugs] [Bug 32418] CRASH: Can't call method "unblessed" on an undefined value at cataloguing/additem.pl In-Reply-To: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32418-70-KXQauPq2Dp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32418 --- Comment #41 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:06:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:06:11 +0000 Subject: [Koha-bugs] [Bug 32716] update NGINX config examples to increase proxy_buffer_size In-Reply-To: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32716-70-ylSQkf4ACZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32716 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:06:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:06:13 +0000 Subject: [Koha-bugs] [Bug 32716] update NGINX config examples to increase proxy_buffer_size In-Reply-To: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32716-70-al5uyNhC6U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32716 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:06:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:06:14 +0000 Subject: [Koha-bugs] [Bug 33345] On-site checkout checkbox does not work since issue date using flatpickr In-Reply-To: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33345-70-DrR4vUQrko@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:06:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:06:16 +0000 Subject: [Koha-bugs] [Bug 33345] On-site checkout checkbox does not work since issue date using flatpickr In-Reply-To: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33345-70-SsCilr91Qm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33345 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:06:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:06:17 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-scKS1csGt5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:06:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:06:19 +0000 Subject: [Koha-bugs] [Bug 33481] EBSCO ws return 415: Content type 'application/octet-stream' not supported In-Reply-To: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33481-70-yQr21ollzc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33481 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:06:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:06:21 +0000 Subject: [Koha-bugs] [Bug 33485] Add/remove title from holdings is not using the correct endpoint In-Reply-To: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33485-70-6NGeZAhhwG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:06:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:06:23 +0000 Subject: [Koha-bugs] [Bug 33485] Add/remove title from holdings is not using the correct endpoint In-Reply-To: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33485-70-ZLjTEeyevu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33485 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:10:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:10:28 +0000 Subject: [Koha-bugs] [Bug 33360] SendQueuedMessages: Improve limit behavior and add domain limits In-Reply-To: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33360-70-5PExLkdMEc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33360 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #38 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:11:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:11:46 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31695-70-TADZVVFFE5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:11:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:11:47 +0000 Subject: [Koha-bugs] [Bug 31695] Type standard number is missing field ci_raw in field_config.yaml In-Reply-To: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31695-70-cw0bEqDJG3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31695 --- Comment #11 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:11:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:11:49 +0000 Subject: [Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off In-Reply-To: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31722-70-LQOL5Cxx2D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:11:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:11:50 +0000 Subject: [Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off In-Reply-To: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31722-70-wxNupOkseC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:11:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:11:52 +0000 Subject: [Koha-bugs] [Bug 32955] Standardize structure around action fieldsets in various templates In-Reply-To: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32955-70-F6AFgMAi92@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32955 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:11:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:11:53 +0000 Subject: [Koha-bugs] [Bug 32955] Standardize structure around action fieldsets in various templates In-Reply-To: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32955-70-NpbFZWOGFA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32955 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:11:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:11:55 +0000 Subject: [Koha-bugs] [Bug 32956] Use template wrapper for HTML customizations tabs In-Reply-To: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32956-70-khHDw0ZzcS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32956 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:11:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:11:56 +0000 Subject: [Koha-bugs] [Bug 32956] Use template wrapper for HTML customizations tabs In-Reply-To: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32956-70-vXD589gzMX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32956 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:11:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:11:58 +0000 Subject: [Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt In-Reply-To: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33088-70-FJbWpOU8rG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:11:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:11:59 +0000 Subject: [Koha-bugs] [Bug 33088] background-job-progressbar.js no longer needed in batch_record_modification.tt In-Reply-To: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33088-70-AiIlHccqup@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33088 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:12:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:12:01 +0000 Subject: [Koha-bugs] [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword In-Reply-To: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33375-70-h3TjugZMl5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:12:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:12:03 +0000 Subject: [Koha-bugs] [Bug 33375] Advanced editor crashes when using MySQL 8 due to reserved rank keyword In-Reply-To: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33375-70-gkPMfuYOL6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33375 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:14:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:14:50 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-95SqdIsQoN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:15:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:15:25 +0000 Subject: [Koha-bugs] [Bug 33192] We should rename 'AutoEmailPrimaryAddress' to 'EmailFieldPrimary' for clarification In-Reply-To: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33192-70-DSfQ96689d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33192 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #17 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:17:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:17:42 +0000 Subject: [Koha-bugs] [Bug 33191] AutoEmailPrimaryAddress options don't match labels in memberentry In-Reply-To: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33191-70-BHKpka9kZp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #13 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Not backporting to 22.11.x as bug 33192 is an enhancement and has not been backported Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:19:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:19:47 +0000 Subject: [Koha-bugs] [Bug 33129] Use template wrapper for breadcrumbs: Administration part 6 In-Reply-To: <bug-33129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33129-70-aHTEW3et1o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:19:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:19:49 +0000 Subject: [Koha-bugs] [Bug 33129] Use template wrapper for breadcrumbs: Administration part 6 In-Reply-To: <bug-33129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33129-70-qxNFKSl2Pb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33129 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:19:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:19:50 +0000 Subject: [Koha-bugs] [Bug 33181] Use template wrapper for tabs on record merge pages In-Reply-To: <bug-33181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33181-70-aA78INxwBL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:19:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:19:52 +0000 Subject: [Koha-bugs] [Bug 33181] Use template wrapper for tabs on record merge pages In-Reply-To: <bug-33181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33181-70-89ZMK0EijV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:19:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:19:54 +0000 Subject: [Koha-bugs] [Bug 33187] Use template wrapper for tabs article requests and holds awaiting pickup pages In-Reply-To: <bug-33187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33187-70-1BSUpTiixs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33187 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:19:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:19:55 +0000 Subject: [Koha-bugs] [Bug 33187] Use template wrapper for tabs article requests and holds awaiting pickup pages In-Reply-To: <bug-33187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33187-70-lBICp6xPHW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33187 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:19:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:19:57 +0000 Subject: [Koha-bugs] [Bug 33231] (Bug 30813 follow-up) No publication date nor edition statements in Z39.50 biblio search results In-Reply-To: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33231-70-cqlFRodj29@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:19:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:19:59 +0000 Subject: [Koha-bugs] [Bug 33231] (Bug 30813 follow-up) No publication date nor edition statements in Z39.50 biblio search results In-Reply-To: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33231-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33231-70-nz1utHIQ47@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33231 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:20:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:20:01 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-gSxAHsKUHo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:20:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:20:02 +0000 Subject: [Koha-bugs] [Bug 33509] Staff search result list shows "other holdings" with AlternateHoldingsField when there are no alternate holdings In-Reply-To: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33509-70-Yd1GEOpRJe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33509 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:20:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:20:04 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-1mIOFFezIT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149795|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 149796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149796&action=edit Bug 33216: Catch and handle RegisterRequired exceptions for SIP fee paid messages If registers are being used in Koha, they are required. If a SIP account has no register and a fee paid message is sent, the SIP server crashes and the client never gets a response. It would be much better if Koha would response with 38 response where "payment accepted" is N, and an AF field stating that the SIP account needs to be associated with a register. Test Plan: 1) Enable UseCashRegisters, set RequireCashRegister to "always require a cash register". Do *not* set a cash register for the SIP account you will be testing with. 2) Using the SIP cli tester, send a fee paid message for a patron owing fees. 3) Note the lack of a SIP response 4) Apply this patch 5) Restart the SIP server 6) Repeat step 2, you should now get a SIP response with the error message in it! Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:21:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:21:10 +0000 Subject: [Koha-bugs] [Bug 18829] Elasticsearch - Add ability to view the ES indexed record In-Reply-To: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18829-70-A9FolaW69Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18829 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #30 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:22:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:22:35 +0000 Subject: [Koha-bugs] [Bug 33038] Add classes to category code and category type in patron brief information for easier customization In-Reply-To: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33038-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33038-70-8WKYp4VitF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33038 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #5 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:24:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:24:45 +0000 Subject: [Koha-bugs] [Bug 33555] New: Use template wrapper for breadcrumbs: Rotating collections Message-ID: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 Bug ID: 33555 Summary: Use template wrapper for breadcrumbs: Rotating collections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update rotating collections templates so that they use the new template wrapper for breadcrumbs. - rotating_collections/addItems.tt - rotating_collections/editCollections.tt - rotating_collections/rotatingCollections.tt - rotating_collections/transferCollection.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:24:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:24:45 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32507-70-Zv67NxRF1w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33555 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 [Bug 33555] Use template wrapper for breadcrumbs: Rotating collections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:24:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:24:48 +0000 Subject: [Koha-bugs] [Bug 23824] Add a 'Save and run' button to reports In-Reply-To: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23824-70-w7up5vx4rQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23824 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #15 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:25:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:25:16 +0000 Subject: [Koha-bugs] [Bug 33238] Error adding suggestion to basket as non-superlibrarian (Bug 29886 follow-up) In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-lHo6OSneIy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:25:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:25:17 +0000 Subject: [Koha-bugs] [Bug 33238] Error adding suggestion to basket as non-superlibrarian (Bug 29886 follow-up) In-Reply-To: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33238-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33238-70-xVHTIc1v6C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33238 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:28:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:28:57 +0000 Subject: [Koha-bugs] [Bug 33229] Patron reading history should be cleared when privacy set to never In-Reply-To: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33229-70-MFewXp2Lwt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33229 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:28:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:28:58 +0000 Subject: [Koha-bugs] [Bug 33229] Patron reading history should be cleared when privacy set to never In-Reply-To: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33229-70-jkf2P6IJty@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33229 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:32:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:32:15 +0000 Subject: [Koha-bugs] [Bug 33556] New: $c->validation->output should be avoided Message-ID: <bug-33556-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 Bug ID: 33556 Summary: $c->validation->output should be avoided Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com CC: tomascohen at gmail.com Talking to the OpenAPI plugin maintainer, he mentioned the use of $c->validation->output should be avoided as the plugin is not designed to have a stable behavior there, and he even thought of just removing the method. That method returns an internal data structure the plugin uses to validate things, and then updates the request itself. Take the following example: GET /patrons x-koha-embed: checkouts,library without the OpenAPI plugin, requesting the header like this: $c->req->headers->header('x-koha-embed') would return a scalar, the string 'checkouts,library'. When using the plugin, and with `x-koha-embed` being defined as collectionFormat: csv, that header is entirely replaced by an arrayref. That's how the plugin works and how it is expected to be used. So we need to replace the uses of $c->validation->format, with normal Mojo usage to avoid future headaches. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:33:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:33:23 +0000 Subject: [Koha-bugs] [Bug 32634] Add 'page-section' to various pages In-Reply-To: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32634-70-IkpmygDcaJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:33:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:33:24 +0000 Subject: [Koha-bugs] [Bug 32634] Add 'page-section' to various pages In-Reply-To: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32634-70-4h4Mm33liV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32634 --- Comment #18 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:33:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:33:26 +0000 Subject: [Koha-bugs] [Bug 32954] Standardize action fieldsets in rotating collections, suggestions, tools In-Reply-To: <bug-32954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32954-70-4yEWaqWUgi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:33:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:33:27 +0000 Subject: [Koha-bugs] [Bug 32954] Standardize action fieldsets in rotating collections, suggestions, tools In-Reply-To: <bug-32954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32954-70-Zgdx3xCYt6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:38:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:38:54 +0000 Subject: [Koha-bugs] [Bug 33555] Use template wrapper for breadcrumbs: Rotating collections In-Reply-To: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33555-70-gZkZQF6KgG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:38:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:38:56 +0000 Subject: [Koha-bugs] [Bug 33555] Use template wrapper for breadcrumbs: Rotating collections In-Reply-To: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33555-70-1amb40VPCm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149797&action=edit Bug 33555: Use template wrapper for breadcrumbs: Rotating collections This patch updates rotating collections templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Rotating collections - New rotating collection - Edit collection - Delete collection - Manage items - Transfer collection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:41:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:41:52 +0000 Subject: [Koha-bugs] [Bug 33557] New: Add a system preference to disable/enable thesaurus checking during authority linking Message-ID: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Bug ID: 33557 Summary: Add a system preference to disable/enable thesaurus checking during authority linking Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 30280 added support for multiple thesauri, however, this is a major change in behavior. Prior to this patch, heading from different sources would all link to the same authority, and auto generated authorities would link to any source. After this patch, however, a library will need to reindex their authorities after upgrade or face linking issues. For libraries who auto create authorities, there is the potential for generating a new set of authorities for any record from a differing source. In order to minimize disruption, we should provide a system preference, disabled by default, to allow libraries to opt in to thesaurus checking -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:45:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:45:54 +0000 Subject: [Koha-bugs] [Bug 33556] $c->validation->output should be avoided In-Reply-To: <bug-33556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33556-70-ptObDsnGqD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 14:46:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 12:46:03 +0000 Subject: [Koha-bugs] [Bug 33556] $c->validation->output should be avoided In-Reply-To: <bug-33556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33556-70-nyS0rjLTdt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:04:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:04:21 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-HmvNksxyYo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- This test ( $applydefaults =~ /changed/ && $changed_framework ) || wont work for default fw but currently we focus here on ACQ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:05:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:05:19 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-Go2lBo2ss8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:05:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:05:22 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-GpldMRMj0c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144706|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149798&action=edit Bug 32484: Enable plugins when UseACQFrameworkForBiblioRecords is set Test plan: 1. Do not apply the patch yet 2. Make sure you have an ACQ biblio framework with some framework plugins enabled. Create it if you don't. 3. Enable UseACQFrameworkForBiblioRecords system preference 4. Create a new acquisition basket. 5. On this new basket, click on "+ Add to basket", then "From a new (empty) record" 6. You should see a simplified MARC editor based on ACQ framework. Confirm that the plugins are not enabled (no visible buttons, nothing happening on focus/blur) 7. Apply patch 8. Repeat step 5 9. You should now see the plugins' buttons (only if you enabled plugins that use the 'click' event) 10. Confirm that the enabled plugins work correctly Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:05:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:05:24 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-MzwXzj54Ym@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147298|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149799&action=edit Bug 32484: Replace DateTime->now by Koha::DateUtils::dt_from_string Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:05:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:05:27 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-ZGPMs0NKai@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149800&action=edit Bug 32484: (QA follow-up) Fixes to POD Resolve: FAIL Koha/UI/Form/Builder/Biblio.pm FAIL pod coverage POD is missing for build_authorized_values_list POD is missing for create_key Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:05:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:05:29 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-Xw9q0qUbWY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149801&action=edit Bug 32484: (QA follow-up) Polishing unit test Test plan, removed done_testing. License. Since we are in t/db, good to add transaction, although we currently do not change anything here. But who knows? Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:05:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:05:31 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-ukX4oMj5GN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149802&action=edit Bug 32484: (QA follow-up) Few typos Test plan: Run git grep "specifique key" Run git grep "the fonction" Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:14:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:14:28 +0000 Subject: [Koha-bugs] [Bug 33558] New: Use template wrapper for breadcrumbs: Serials part 1 Message-ID: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 Bug ID: 33558 Summary: Use template wrapper for breadcrumbs: Serials part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several serials templates so that they use the new template wrapper for breadcrumbs. - serials/checkexpiration.tt - serials/claims.tt - serials/routing-preview.tt - serials/routing.tt - serials/serials-collection.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:14:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:14:28 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32507-70-Odj6tGmaxi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33558 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:16:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:16:06 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-gCevjlx4os@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> --- Thank you Marcel for the QA and the follow-ups :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:17:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:17:59 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-TWgALcUyY3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- item.object.itemnotes.replace('\n','<br />') Is this replace relevant? How do we test it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:18:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:18:26 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-NhaIOacJKc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149803&action=edit Bug 33064: Add a licenses option to the searchbar This patch adds a licenses option to the top searchbar Test plan: 1) Apply patch 2) run yarn build 3) Navigate to the ERM module 4) Observe that the top search bar should have an option for licenses 5) Click on licenses in the left hand menu, the search bar should update to show licenses as the active search option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:18:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:18:47 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-Lnwm3T8HFr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33277 Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 [Bug 33277] Correctly handle linking subfields with no defined thesaurus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:18:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:18:47 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-pZUUWEEI2z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33557 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:18:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:18:49 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-YvIXj9R83j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149804&action=edit Bug 33557: Add LinkerConsiderThesaurus system preference Bug 30280 added the ability to use multiple thesauri for authorities in Koha. This is a large change, and many libraries use authorities in a ess strict manner. This patch simply adds a preference, disabled by default, to enable this new feature To test: 1 - Find or create a record with a 650 heading, second indicator 0 (LOC) 2 - Ensure this links to an authority in your system 3 - Disable AutoCreateAuthorities, enable CatalogModuleRelink 4 - Edit the heading to second indicator 2 5 - Save, the heading does not link 6 - Apply patch, updatedatabase, restart all 7 - Edit and save record again 8 - Heading should now link to the LOC authority, despite different second indicator value for source -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:19:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:19:12 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-YyTuYOIMjJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:19:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:19:35 +0000 Subject: [Koha-bugs] [Bug 31925] AutoCreateAuthorities needs to preserve subject heading thesaurus to not create duplicate authority records In-Reply-To: <bug-31925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31925-70-NATkvvhguM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31925 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33557 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:19:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:19:35 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-ilcVRm62YM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31925 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:19:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:19:44 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-bsAhs9L9QR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149805&action=edit Bug 33064: Update cypress tests This patch amends Searchbar_spec.ts to account for the new licenses option Test plan: 1) Run yarn cypress open 2) Select the Searchbar_spec.ts test 3) The test should pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:19:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:19:57 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-uHtUVuu8JL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Status|NEW |Needs Signoff Assignee|jonathan.druart+koha at gmail. |matt.blenkinsop at ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:26:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:26:58 +0000 Subject: [Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3 In-Reply-To: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33438-70-xZ7OLoO4yn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149768|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 149806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149806&action=edit Bug 33438: Use template wrapper for breadcrumbs: Reports part 3 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Average loan time - Results - Circulation statistics - Results - Lost items - Results - Catalog by item type - Results Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:28:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:28:19 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31383-70-vLMpc2i0Qv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking here. Rebased conflict with new WRAPPER in koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:28:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:28:44 +0000 Subject: [Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3 In-Reply-To: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33438-70-4kACo0Ofu6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 Andrew Auld <andrew.auld at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld at ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Great job Owen, it all looks fine to me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:30:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:30:31 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31383-70-d4Xee0AJVw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- FAIL Koha/Schema/Result/AdditionalContentsLocalization.pm FAIL pod coverage POD is missing for koha_object_class POD is missing for koha_objects_class FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt FAIL valid_template DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.id' in 'field list' at /usr/share/koha/Koha/Objects.pm line 421 FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-page.tt FAIL valid_template DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.id' in 'field list' at /usr/share/koha/Koha/Objects.pm line 421 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:31:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:31:37 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-ZIoJTKwYC5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Marius <marius.mandrescu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:31:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:31:39 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-ZejIBCPKSe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Marius <marius.mandrescu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149780|0 |1 is obsolete| | --- Comment #2 from Marius <marius.mandrescu at inlibro.com> --- Created attachment 149807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149807&action=edit Bug 33550: Rename Patron restrictions administration page to Patron restriction types This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration. To test: 0. Apply patch 1. Enable PatronRestrictionTypes 2. Go to Administration 3. Check the name, spelling/grammar of the following elements * Section name * Section caption 4. Click 'Patron restriction types' 5. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Left hand side menu * 'New' button * Page heading 6. Click 'New restriction type' 7. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 8. Fill out the form and click 'Save' to create a new restriction type * Dialog message ('Restriction type added') 9. Click 'New restriction type' 10. Enter the same code as last time * Warning ('Restriction type code is already in use') 11. Click 'Cancel' 12. Click 'Edit' next to one of the types 13. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 14. Without changing anything, click 'Save' * Warning ('Restriction type label is already in use') 15. Change the label and click 'Save' * Dialog message ('Restriction type updated') 16. Click 'Delete' next to one of the types 17. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading * Delete button 18. Click 'Delete this restriction type' * Dialog message ('Restriction type deleted') Signed-off-by: Marius Mandrescu <marius.mandrescu at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:33:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:33:17 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-eoHQkPdYWC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 --- Comment #20 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #19) > item.object.itemnotes.replace('\n','<br />') > > Is this replace relevant? How do we test it? 1. Enter an itemnote note longer than 100 characters 2. Save the item 3. Edit the item, note field should now be a text area 4. Enter: a b c d 5. Save the item 6. View details page 7. Confirm line breaks are preserved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:34:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:34:15 +0000 Subject: [Koha-bugs] [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4 In-Reply-To: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33439-70-kvpjw8kUvq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149789|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 149808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149808&action=edit Bug 33439: Use template wrapper for breadcrumbs: Reports part 4 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Reports home - Orders by fund - Results - Holds statistics wizard - Results - Serials statistics wizard - Results Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:34:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:34:36 +0000 Subject: [Koha-bugs] [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4 In-Reply-To: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33439-70-IF3Vtr0n1V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 Andrew Auld <andrew.auld at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld at ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Nice one, looks great! All works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:37:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:37:21 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31383-70-NodIiOAIdu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- perl installer/data/mysql/updatedatabase.pl DEV atomic update /usr/share/koha/installer/data/mysql/atomicupdate/bug_31383.pl [13:36:56]: Bug 31383 - Split the additional_contents table Renamed additional_contents.idnew with 'id' Added new table 'additional_contents_localizations' Removed 'title', 'content', 'lang' columns from additional_contents ERROR - {UNKNOWN}: Not a HASH reference at /usr/share/koha/installer/data/mysql/atomicupdate/bug_31383.pl line 71. at /usr/share/koha/C4/Installer.pm line 743 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:37:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:37:47 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31383-70-mL399tyur5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:52:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:52:46 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-k94dn2Nblz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Andrew Auld <andrew.auld at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrew.auld at ptfs-europe.com --- Comment #2 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Hi Owen, I have found a couple of issues with this patch. Firstly, I can't test the 'Items with no checkouts' results page as I am getting an error on the sandbox when I hit 'Submit': CGI::Compile::ROOT::kohadevbox_koha_reports_catalogue_out_2epl::calculate(): DBI Exception: DBD::mysql::st execute failed: 'koha_bugs.items.barcode' isn't in GROUP BY at /kohadevbox/koha/reports/catalogue_out.pl line 51 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Secondly, under saved reports and in the guided reports wizard area, there are a number of pages where the breadcrumb doesn't show as it should I don't think. I have attached a number of screenshots to show what I mean. Steps 1 through 6 of the wizard are all fine. I think it is the 'edit report' screen, the 'run report' screen and the 'view report' screen that are not quite right. All other parts of the test plan work fine. I hope this is helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:55:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:55:15 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-zYx67DrXtO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #3 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Created attachment 149809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149809&action=edit Edit report breadcrumb error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:55:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:55:42 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-V6hH5j7Bs1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #4 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Created attachment 149810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149810&action=edit Run report breadcrumb error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:56:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:56:05 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-DFexwRJ1vR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #5 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Created attachment 149811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149811&action=edit View report breadcrumb error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 15:56:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 13:56:30 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-jjWGARxcQD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- +my $items = $biblio->items({ host_items => 1 })->search_ordered( $params, { prefetch => ['issue','branchtransfers'] } ); [...] +$dat->{'count'} = $biblio->items({ host_items => 1 })->count; +$dat->{'showncount'} = $items->count; Are not we going to always get count == showncount? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 16:12:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 14:12:57 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-XfaTYbW0RO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #42 from Frank Hansen <frank.hansen at ub.lu.se> --- (In reply to Nick Clemens from comment #41) > (In reply to Frank Hansen from comment #40) > > (In reply to Katrin Fischer from comment #39) > > > Can someone help to get this tested? > > > > I have now tested the patch on my testing docker. I get different results > > depending on whether I choose the ES or the Zebra engine. I am following the > > test plan in comment #17 > > > > ES works flawlessly. All headings are linked after the patch is applied. > > > > But when doing the same using Zebra, without the patch installed only field > > 100 is linked. After applying the patch and restarted not all headings are > > linked. Only > > field 100, 655 (Literature English), 700 and 830 fields are linked after > > saving the record again. > > > > Have I missed something. > > The test plan is missing the steps for Zebra as the index files need to be > copied and then a full reindex: > sudo cp > /kohadevbox/koha/etc/zebradb/marc_defs/marc21/authorities/authority-zebra- > indexdefs.xsl > /etc/koha/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl > restart_all > sudo koha-rebuild-zebra -v -f kohadev Yes! It works for me. I'm signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 16:26:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 14:26:01 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-qZRfJjdzqb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 16:31:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 14:31:13 +0000 Subject: [Koha-bugs] [Bug 29393] Ability to send emails from patron details page In-Reply-To: <bug-29393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29393-70-eycok9KjcC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 --- Comment #27 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 149812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149812&action=edit Bug 29393: Prevent SQL errors when SQL strict mode is set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 16:43:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 14:43:05 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31383-70-EhBJYeWk3V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 16:43:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 14:43:08 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31383-70-erriVenX8i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147891|0 |1 is obsolete| | Attachment #147892|0 |1 is obsolete| | Attachment #147893|0 |1 is obsolete| | Attachment #147894|0 |1 is obsolete| | Attachment #147895|0 |1 is obsolete| | Attachment #147896|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149813&action=edit Bug 31383: Create a parent-child DB relation for additional content In the design of additional contents the idea of a parent-child relation is implicitly present. You have a default page and translations. But we do this in one table coming from the old news items. Several reports show that we would be better off creating a parent table listing the main news items, CMS pages or HTML content. And a child table containing the title, content and lang. Note that this first step is a prelimenary step to clean this area and make it more robust and extensible. More enhancements to come. What is this patchset doing? * DB changes - Rename additional_contents.idnew with id - Create a new table additional_contents_localizations(id, additional_content_id, title, content, lang) that will contain the translated contents - Move the content to this new table - Remove title, content and lang columns from additional_contents - Replace the notice templates that are using ''<news>" (should only be ISSUESLIP) and remove support for this syntax. Also add a warning in case other occurrences of uses of the old syntax exist. * CRUD - We add a new Koha::AdditionalContentsLocalization[s] couple, and move some logic from Koha::AdditionalContent[s] to there. Note that, to prevent too much drastic changes in notice templates, and to make them easy to use, the different attributes of the content object is accessible from the translated content object (ie. Koha::AdditionalContentsLocatlization->library is available and return $self->additional_content->library). I think it's an elegant way to keep things simple. - No changes expected for "NewsLog" logging - Little behaviour changes for pages, see tools/page.pl changes. We are now passing the id of the content, and the desired language, instead of the mix of "page_id" or code and lang. Note that here we certainly need to rename "language" query param to not change the full interface language. Test plan: 0. Preparation steps, use master a. Create notice templates that are using "<< additional_contents.code >>". This won't be replaced, but we want the update process to alert us. b. Create several news, additional contents, pages. Some with translated contents, some without. c. Make sure ISSUESLIP has the "<news>" section. If you are using the sample data there is nothing to do here d. Turn on NewsLogs 1. Apply the patches, restart_all, updatedatabase => Confirm that the new table is created and filled with the contents you had prior to the update => Confirm that additional_contents_localizations.updated_on has been kept to the previous values => Confirm that ISSUESLIP has been replaced properly => Confirm that you get a warning about the additional_contents 2. Create, update, delete news, html customs, pages => Confirm that the additional_contents_localizations.updated_on is only adjusted when required => Confirm that the logs are correctly created when NewsLogs is on 3. Check some items out, generate a slip => Confirm that the news are displayed at the bottom of the slip, and that the publication date is correctly formatted 4. Have several HTML customizations (like OpacNav, opacheader), in translated in different languages => Confirm that the default values is displayed when you are using the interface in a language without translation => Confirm that the translated version is picked when it exists Notes for QA: * I am not sure we really need the alert during the update DB process about the additional_contents leftover. We should not have them outside of ISSUESLIP. Shouldn't it hurt? * There is something ugly in sample_news.yml, the id is hardcoded. But how do we prevent that and keep translatability? Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 16:43:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 14:43:11 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31383-70-4IqRC1Z19m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149814&action=edit Bug 31383: Adjust and add tests Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 16:43:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 14:43:14 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31383-70-RRWAdZo1eX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149815&action=edit Bug 31383: DB changes Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 16:43:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 14:43:17 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31383-70-krytLjAgkP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149816&action=edit Bug 31383: DBIC changes Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 16:43:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 14:43:20 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31383-70-2gSadje2OB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149817&action=edit Bug 31383: DBIC specific Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 16:43:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 14:43:23 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31383-70-B3gLa1uaIJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #21 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149818&action=edit Bug 31383: Restore updated_on for individual content Sponsored-by: Rijksmuseum, Netherlands -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 16:43:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 14:43:38 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31383-70-EUYp0lN5JV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #22 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Marcel de Rooy from comment #13) > Looking here. > > Rebased conflict with new WRAPPER in > koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt Done. (In reply to Marcel de Rooy from comment #14) > FAIL Koha/Schema/Result/AdditionalContentsLocalization.pm > FAIL pod coverage > POD is missing for koha_object_class > POD is missing for koha_objects_class We don't require POD for those subroutines. > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt > FAIL valid_template > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: > DBD::mysql::st execute failed: Unknown column 'me.id' in 'field list' at > /usr/share/koha/Koha/Objects.pm line 421 > > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-page.tt > FAIL valid_template > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: > DBD::mysql::st execute failed: Unknown column 'me.id' in 'field list' at > /usr/share/koha/Koha/Objects.pm line 421 Once you run the atomic update this will be fixed. (In reply to Marcel de Rooy from comment #15) > perl installer/data/mysql/updatedatabase.pl > DEV atomic update > /usr/share/koha/installer/data/mysql/atomicupdate/bug_31383.pl [13:36:56]: > Bug 31383 - Split the additional_contents table > Renamed additional_contents.idnew with 'id' > Added new table 'additional_contents_localizations' > Removed 'title', 'content', 'lang' columns from additional_contents > ERROR - {UNKNOWN}: Not a HASH reference at > /usr/share/koha/installer/data/mysql/atomicupdate/bug_31383.pl line 71. at > /usr/share/koha/C4/Installer.pm line 743 Fixed, sorry about that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 16:45:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 14:45:23 +0000 Subject: [Koha-bugs] [Bug 31383] Additional contents: We need a parent and child table In-Reply-To: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31383-70-60k5fIJ9q5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31383 --- Comment #23 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #22) > (In reply to Marcel de Rooy from comment #13) > > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt > > FAIL valid_template > > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: > > DBD::mysql::st execute failed: Unknown column 'me.id' in 'field list' at > > /usr/share/koha/Koha/Objects.pm line 421 > > > > FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-page.tt > > FAIL valid_template > > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: > > DBD::mysql::st execute failed: Unknown column 'me.id' in 'field list' at > > /usr/share/koha/Koha/Objects.pm line 421 > > Once you run the atomic update this will be fixed. Note that they are still failing with an other error: DBIx::Class::Schema::source(): Can't find source for AdditionalContentsLocalization at /kohadevbox/koha/Koha/Objects.pm line 524 I think it's a false positive, it happens occasionally with valid_template. t/db_dependent/TestBuilder.t is passing so I think we are safe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 17:04:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 15:04:42 +0000 Subject: [Koha-bugs] [Bug 33555] Use template wrapper for breadcrumbs: Rotating collections In-Reply-To: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33555-70-KG2sepDUqD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 17:04:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 15:04:44 +0000 Subject: [Koha-bugs] [Bug 33555] Use template wrapper for breadcrumbs: Rotating collections In-Reply-To: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33555-70-38O2KM5nyI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149797|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149819&action=edit Bug 33555: Use template wrapper for breadcrumbs: Rotating collections This patch updates rotating collections templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Rotating collections - New rotating collection - Edit collection - Delete collection - Manage items - Transfer collection Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 17:07:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 15:07:46 +0000 Subject: [Koha-bugs] [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1 In-Reply-To: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33558-70-cAlPoDyzkM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 17:07:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 15:07:48 +0000 Subject: [Koha-bugs] [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1 In-Reply-To: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33558-70-eVHd2uCzAP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149820&action=edit Bug 33558: Use template wrapper for breadcrumbs: Serials part 1 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Claims - Claims for a vendor - Check expiration - Subscription details -> - Serial collection - Create routing list - Edit routing list - Preview routing list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 17:20:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 15:20:23 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-7IPAk8K2pd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Nick answered me, itemlost is passed in $params -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 17:42:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 15:42:02 +0000 Subject: [Koha-bugs] [Bug 33559] New: Use template wrapper for breadcrumbs: Serials part 2 Message-ID: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Bug ID: 33559 Summary: Use template wrapper for breadcrumbs: Serials part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more serials templates so that they use the new template wrapper for breadcrumbs. - serials/serials-edit.tt - serials/serials-home.tt - serials/serials-search.tt - serials/subscription-add.tt - serials/subscription-batchedit.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 17:42:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 15:42:02 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32507-70-s61qdDhPzC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 18:15:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 16:15:18 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-ziLeEyGk3L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 18:15:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 16:15:21 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-aBOOpyaHS5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149803|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149821&action=edit Bug 33064: Add a licenses option to the searchbar This patch adds a licenses option to the top searchbar Test plan: 1) Apply patch 2) run yarn build 3) Navigate to the ERM module 4) Observe that the top search bar should have an option for licenses 5) Click on licenses in the left hand menu, the search bar should update to show licenses as the active search option Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 18:15:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 16:15:23 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-ZlUpeRTe0r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149805|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149822&action=edit Bug 33064: Update cypress tests This patch amends Searchbar_spec.ts to account for the new licenses option Test plan: 1) Run yarn cypress open 2) Select the Searchbar_spec.ts test 3) The test should pass Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 18:18:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 16:18:10 +0000 Subject: [Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved In-Reply-To: <bug-32702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32702-70-cc5Q6z4nHV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 18:31:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 16:31:26 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-Wfl9Sl9z9X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 18:31:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 16:31:29 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-iEr22594kG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149778|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149823&action=edit Bug 33491: Fix UI issues in EHoldingsEBSCOPackageAgreements Signed-off-by: Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 18:40:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 16:40:00 +0000 Subject: [Koha-bugs] [Bug 32745] Background jobs view breaks when there are jobs with context IS NULL In-Reply-To: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32745-70-yicWPCf5nT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 Cindy Murdock Ames <cmurdock at ccfls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock at ccfls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 18:50:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 16:50:29 +0000 Subject: [Koha-bugs] [Bug 33560] New: Batch edit link broken if subscriptions are selected using "select all" link Message-ID: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Bug ID: 33560 Summary: Batch edit link broken if subscriptions are selected using "select all" link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org When you use the mouse to check checkboxes on the serial search results page, it activates an "Edit selected serials" link which when clicked takes you to the batch edit page. If you use the "Select all" link to check the checkboxes the "Edit selected serials" link is activated but it doesn't work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 18:50:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 16:50:52 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-70arAzhWqz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 19:08:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 17:08:03 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-2GNxowNP7C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 19:08:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 17:08:06 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-2fVBTnWXoz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149824&action=edit Bug 33549: Fix dialog box in patron restrictions To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'New restriction' 4. Enter a code and label 5. Click 'Save' --> 'Type added' at the top of the page is not styled 6. Apply patch 7. Try again, dialog is styled correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 19:08:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 17:08:26 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-Q2YnovXmJh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 19:14:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 17:14:09 +0000 Subject: [Koha-bugs] [Bug 14210] Manage staged MARC records deletes replaced item when undoing import into catalog In-Reply-To: <bug-14210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14210-70-X67A1uOXp7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14210 CB <balestrieri at monterey.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |balestrieri at monterey.org --- Comment #8 from CB <balestrieri at monterey.org> --- I agree. It erases data. From an acquisitions standpoint, I need to add the item back on to the Bib record and input the item information again. It seems like the reversion should simply "undo" the process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 20:11:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 18:11:55 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-6J4dJBkBdV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32698 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698 [Bug 32698] Use template wrapper for serials pages tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 20:11:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 18:11:55 +0000 Subject: [Koha-bugs] [Bug 32698] Use template wrapper for serials pages tabs In-Reply-To: <bug-32698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32698-70-cKE8J2aYnU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32698 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 20:19:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 18:19:41 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-C0WFcpVaD8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 20:19:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 18:19:43 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-PlFH1WoFHF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149825&action=edit Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 20:20:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 18:20:03 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-LuDrATmyhv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Patch complexity|--- |Trivial patch Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 20:45:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 18:45:05 +0000 Subject: [Koha-bugs] [Bug 33098] Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled In-Reply-To: <bug-33098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33098-70-oWKuek3f0F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147526|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Created attachment 149826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149826&action=edit Bug 33098: Revert suggestion status when orders are cancelled This enhancement will revert the status of a suggestion from ORDERED to ACCEPTED when an order made from a suggestion is cancelled. To test: 1. Log into the OPAC and go to purchase suggestions 2. Add a new purchase suggestion 3. Log into the staff interface. The suggestion will show on the home page 4. Select the suggestion and mark it as Accepted 5. Go to Acquisitions. Find or create a basket 6. Add an order to the basket from a suggestion 7. You'll be redirected to the suggestions page. Click the order button next to your suggestion 8. Fill out the order details as normal and confirm the order. 9. In a new tab, go to the suggestions management page and confirm the suggestion now shows as ORDERED. 10. In the other tab with your basket, cancel the order you just made from the suggestion. 11. Refresh the suggestions management tab. Confirm the suggestion now shows as ACCEPTED. 12. Confirm tests pass t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Waikato Institute of Technology Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 20:51:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 18:51:19 +0000 Subject: [Koha-bugs] [Bug 33098] Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled In-Reply-To: <bug-33098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33098-70-b5iN1mJ8pi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor at tuxayo.net> --- @Laura hi, thanks for the signoff :) The "Signed-off-by" line needs to be added to the patch itself and the updated/signed patch needs to be attached to the ticket here. You likely have git bz installed in you test environment or maybe you are using the sandboxes. Here is some documentation about how add a signoff to a patch and how to attach it here. You might want to discuss that with a colleague to find what's the most efficient or simplest workflow for your case. https://wiki.koha-community.org/wiki/Sign_off_on_patches#Method_1:_Using_sandboxes https://wiki.koha-community.org/wiki/Sign_off_on_patches#Method_2%3A_Using_git_bz https://wiki.koha-community.org/wiki/Git_bz_configuration#Signing_off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 20:51:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 18:51:35 +0000 Subject: [Koha-bugs] [Bug 33098] Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled In-Reply-To: <bug-33098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33098-70-L61haPLe2e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 20:51:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 18:51:58 +0000 Subject: [Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results In-Reply-To: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28884-70-JHdK8PCxWu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #10 from Janusz Kaczmarek <januszop at gmail.com> --- (In reply to Katrin Fischer from comment #9) > (In reply to Janusz Kaczmarek from comment #8) > > (In reply to Nick Clemens from comment #7) > > > This was "solved" with a hack on bug 31213 > > > > > > If I understand what this patch is doing, you are escaping the question mark > > > so it no longer operates as a special character? > > > > > > This is not a bad idea, however, it needs to be documented with a comment in > > > the code, as well as in the system preference. I think it would actually be > > > better as its own system preference. > > > > Nick, I'm aware of your 'hack'--now, I'm unable to verify if quickly, but as > > far as I remember it didn't solve this case. If it did, there would be no > > point for me to dig into this. > > > > If I remember well, the patch intends to treat the question mark, in the > > function _query_regex_escape_process, in exactly the same way as it is done > > with slash: instead of escaping/unescaping only '/': (?=/) it escapes also > > '?': (?=[/\?]). Maybe I could extend the existing comment, but I don't feel > > like this is a candidate for a new syspref...? > > I think it would be nice if we could keep the truncation feature without > requiring to escape it. It's easy to explain to people to use ?, but much > harder to explain \? - also quite a change in behavior at this point maybe? > > I was wondering, if ? replaces one or more characters... why does it not > work as a wild card if there really is a question mark? Well, IMHO it will be not so easy to explain to an ordinary user (who usually will not read complicated introductory texts, and what we are discussing is a very special case) how '?' functions with ES. Moreover, I expect that an ordinary user will rather use '?' as a verbatim '?' (from copy-paste) than as a wildcard. So, I expect (and have already experienced) alarms from the users who are not able to find a book (with a title containing '?', copied from other data source) in the local catalog even if it is there. If I understand well, in query_string ES query, '?' stands for a single character. But, at the same time, after a normal text analysis of a string containing a question mark attached at the end of the word, the '?' character is removed from what is stored in the index. So, the query 'are?' will not find an original string 'are?' but it would find for instance 'ares', 'arer', 'area' etc. (Similarly, '/' has a special meaning in ES but at the same time can be put unconsciously by an ordinary user as a part of query string -- and hence, if I get it right, the option QueryRegexEscapeOptions of escaping it.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 21:01:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 19:01:35 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-C7AoevlxAJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thank you Frank. Note for QA: Please add sign-off lines! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 21:08:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 19:08:08 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-gh3z7sa0RR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Lucas Gass from comment #7) > (In reply to Katrin Fischer from comment #6) > > Hi Lucas, > > > > I just realized that we had the "Click to..." previous to your patches, but > > we should not do that. I've added a small follow-up to remove them. It being > > a link or button already indicates that you can click it, see also > > accessibility guidelines like: > > https://www.mtu.edu/accessibility/training/web/link-text/ > > Hope you agree :) > > > > But: The edit/add text change doesn't work perfectly yet: > > > > To test: > > * Add a new subscription creating items on receive > > * Receive a first issue and create the item > > * From serial collection check both issues and edit > > * The unreceived issue in status "arrived also has "Edit item", but there is > > no item to edit yet > > > > I really like this change, can you please have another look? > > Good catch Katrin. I 100% agree with you. Should we set this back to NSO? > Thanks for the follow-up! I couldn't fix the second issue - so we will still need a follow up or maybe change to "Add/edit item" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 21:45:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 19:45:37 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-SjTFoch9lx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 AgustĂ­n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146410|0 |1 is obsolete| | Attachment #146411|0 |1 is obsolete| | Attachment #149777|0 |1 is obsolete| | --- Comment #7 from AgustĂ­n Moyano <agustinmoyano at theke.io> --- Created attachment 149827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149827&action=edit Bug 32607: Add table and permissions Adds a new table called import_sources and a user permission called manage_import_sources -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 21:45:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 19:45:40 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-1IDjtDhL7V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #8 from AgustĂ­n Moyano <agustinmoyano at theke.io> --- Created attachment 149828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149828&action=edit Bug 32607: [DO NOT PUSH] Koha schemas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 21:45:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 19:45:44 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-zffEW8h432@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #9 from AgustĂ­n Moyano <agustinmoyano at theke.io> --- Created attachment 149829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149829&action=edit Bug 32607: Add CRUD for import sources This patch adds vue components to create, read, update and delete import sources To test: 1. apply patches 2. updatedatabase 3. yarn build_js 4. go to Administration -> Import sources 5. play around with the ui and create, update, remove and search import sources 6. Sign off ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 21:46:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 19:46:55 +0000 Subject: [Koha-bugs] [Bug 32702] Item statuses that block holds should be checked in CanItemBeReserved In-Reply-To: <bug-32702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32702-70-Zr94y2TfSo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32702 --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #3) > I haven't had time to look at the methods at a whole, but do we really want > to remove the checks from IsAvailableForItemLevelRequest? Holdability is determined by calling both routines, and we call 'CanItemBeReserved' first - moving these checks to the start of the routine saves time calculating values that will be ignored later -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 22:20:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 20:20:50 +0000 Subject: [Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results In-Reply-To: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28884-70-1hPW8Lq9Yd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- ? and * are quite common for truncation and databases and the like, people have been writing tutorials on Elasticsearch etc. like: https://drive.google.com/file/d/17-YVjG6IJKeDmDCKuF7ZYvcTfzDYyxwa/view That's also been promoted on the BywaterSolutions blog. So next question would be, why * and ? are handled differently... could the behaviour of Elasticsearch removing the ending ? be changed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 22:38:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 20:38:45 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-ilGRhOzxTq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #7) > Matt pointed me to bug 33355 for my form problems. This one doesn't apply on > top of that. So I can't check if it solves my problem. > > I retested and Yes/No are still in english. (It's not even Yes/Noes, so I > have no idea what I'm doing wrong) I guess it was a little too late again that day - I had changed it to noes to verify I was changing things in the right spot - forgot to change back or to commit the changed file... I won't be able to come back to this maybe for a while, if someone else wants to continue/fix this here please do. (I have no idea how to change to a checkbox either with vue) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 22:38:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 20:38:46 +0000 Subject: [Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results In-Reply-To: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28884-70-XFIF5Z4RCt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #12 from Janusz Kaczmarek <januszop at gmail.com> --- (In reply to Katrin Fischer from comment #11) > ? and * are quite common for truncation and databases and the like, people > have been writing tutorials on Elasticsearch etc. like: > https://drive.google.com/file/d/17-YVjG6IJKeDmDCKuF7ZYvcTfzDYyxwa/view > That's also been promoted on the BywaterSolutions blog. > > So next question would be, why * and ? are handled differently... could the > behaviour of Elasticsearch removing the ending ? be changed? The fundamental differences between ? and * are: 1. * very rarely would be present in ordinary users' copy-paste queries, 2. even if, * means '0 or more characters' (like /.*/ in Perl) -- so it would not create problems -- whereas ? means _exactly_ one character (like Perlish /./) -- and therefor is quite problematic in the context we are in. Still, I would not expect from the users of the catalogue the knowledge about quite advanced, wildcarded ES queries... s/he is usually is not interested in what is in the back-end. Hence, I would prefer to prepare Koha to first "understand" a normal user instead of advanced search engines operator. And still, the basic scenario is: the user does copy-paste search and does not get the result -- which for him/her (and therefor for me) is not acceptable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 22:39:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 20:39:14 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-NA8GwYlQDw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- You always need to build the vue files (yarn build) with every change I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 23:21:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 21:21:07 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-R8ASWqj4UR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 23:21:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 21:21:09 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-7xJBvHtkLJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149804|0 |1 is obsolete| | --- Comment #2 from Phil Ringnalda <phil at chetcolibrary.org> --- Created attachment 149830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149830&action=edit Bug 33557: Add LinkerConsiderThesaurus system preference Bug 30280 added the ability to use multiple thesauri for authorities in Koha. This is a large change, and many libraries use authorities in a ess strict manner. This patch simply adds a preference, disabled by default, to enable this new feature To test: 1 - Find or create a record with a 650 heading, second indicator 0 (LOC) 2 - Ensure this links to an authority in your system 3 - Disable AutoCreateAuthorities, enable CatalogModuleRelink 4 - Edit the heading to second indicator 2 5 - Save, the heading does not link 6 - Apply patch, updatedatabase, restart all 7 - Edit and save record again 8 - Heading should now link to the LOC authority, despite different second indicator value for source Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 23:21:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 21:21:30 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-xe1qE7HS04@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 18 23:32:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 21:32:43 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-jU8uIZcR56@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Juliet Heltibridle <jheltibridle at rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle at rcplib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 00:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 22:54:31 +0000 Subject: [Koha-bugs] [Bug 26477] Emaillibrarianwhenholdisplace may be change to specify email as per library choice In-Reply-To: <bug-26477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26477-70-U2FbLJ6TBK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26477 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com --- Comment #4 from Lisette Scheer <lisette.scheer at bywatersolutions.com> --- It would be great if like ILL staff email it could be set per branch, no matter if it's looking for the pickup branch or the patron's branch. Right now you'd have to change the branch address, but if they don't want to change their branch email for whatever reason it would be great to be able to specify. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 01:10:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 23:10:37 +0000 Subject: [Koha-bugs] [Bug 33561] New: Improve display of location column in search results Message-ID: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33561 Bug ID: 33561 Summary: Improve display of location column in search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I've been asked to customize the location column in staff search results. I am opening this bug to ideate. At the very least I would like to add more classes to make everything easier to customize. It would also be nice to have a way to only show items from the branch that you are logged in at. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 01:12:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 23:12:17 +0000 Subject: [Koha-bugs] [Bug 33561] Improve display of location column in search results In-Reply-To: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33561-70-YYKOnSkhLv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33561 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149831&action=edit Bug 33561: New dispay for location column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 01:14:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Apr 2023 23:14:24 +0000 Subject: [Koha-bugs] [Bug 33561] Improve display of location column in search results In-Reply-To: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33561-70-Gt5I0QlLcB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33561 --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149832&action=edit first iteration -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 02:42:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 00:42:07 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-xuaBl2f4DD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 02:42:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 00:42:09 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-2z21tYcGH5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149781|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149833&action=edit Bug 33128: Add Polish translations for language descriptions This adds the Polish translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install pl-PL and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to Polish - verify the Polish translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated Signed-off-by: Nick <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 02:50:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 00:50:03 +0000 Subject: [Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results In-Reply-To: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28884-70-6YlAhqXLjs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Janusz Kaczmarek from comment #8) > (In reply to Nick Clemens from comment #7) > > This was "solved" with a hack on bug 31213 > > Nick, I'm aware of your 'hack'--now, I'm unable to verify if quickly, but as > far as I remember it didn't solve this case. If it did, there would be no > point for me to dig into this. Ah, so it doesn't solve this issue because we don't index the a and b together by default. So when you search for: "Will libraries survive? the future of public libraries" The quoted version fails, because no single field contains that string. If you change or add a title index with 245(ab) then the "hack" does work. In fact, it's probably a good idea because any quoted 'full' title search including a subtitle will fail otherwise -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 03:01:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 01:01:23 +0000 Subject: [Koha-bugs] [Bug 25812] Fines can be displayed on SIP checkin/checkout In-Reply-To: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25812-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25812-70-w8vTBqn7Pj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |25815 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 [Bug 25815] SIP Checkout: add more information on why the patron is blocked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 03:01:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 01:01:23 +0000 Subject: [Koha-bugs] [Bug 25815] SIP Checkout: add more information on why the patron is blocked In-Reply-To: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25815-70-jKgl85I3Fx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25815 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812 [Bug 25812] Fines can be displayed on SIP checkin/checkout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 03:21:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 01:21:57 +0000 Subject: [Koha-bugs] [Bug 31118] Allow to send the TOTP token when enabling 2FA In-Reply-To: <bug-31118-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31118-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31118-70-q1rtn9Qrkx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31118 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook <dcook at prosentient.com.au> --- Yeah, I found it a bit weird that you need an Authenticator app to register but then can use email after that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 03:56:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 01:56:53 +0000 Subject: [Koha-bugs] [Bug 32762] Duplicate entry '10434' for key 'PRIMARY' at /usr/share/koha/lib/C4/Installer.pm line 739 In-Reply-To: <bug-32762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32762-70-ABio8kkpPc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32762 --- Comment #11 from quickfire28 at gmail.com --- (In reply to quickfire28 from comment #8) > Here is the table that has Duplicate entry > > error - {unknown}: dbi exception: dbd::mysql::db do failed: duplicate entry > '24690' for key 'import_biblios.primary' at > /usr/share/koha/lib/c4/installer.pm line 739 > > > and even the biblios in Reservoir detected as Duplicate entry. I already fixed this error by accessing the database using HeidiSQl then locate and clear the import_biblios table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 08:49:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 06:49:07 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-TXCBZrcPT8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 09:06:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 07:06:53 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-akw0mhtLuS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 09:06:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 07:06:56 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-TYTs71EwUe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149727|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149834&action=edit Bug 32931: Fix translatability issues on 'new agreement' form This fixes the "Yes" and "No" options and "License info" placeholder. To get to the options: 1. Enable the ERMModule system preference 2. Go to E-resource management 3. Click "Agreements" 4. Click "New agreement" --> Field "Is perpetual", options are Yes and No --> At the bottom of the form "License info" with "License info" within the input field 5. Install (complete) language, verify those are not translated 6. Apply patch 7. Update po files 8. Verify strings exist for this file, translate if necessary 9. Re-install language 10. Verify strings are now translated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 09:06:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 07:06:59 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-yi2CaB95Vl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149835&action=edit Bug 32931: Fix translatability issues on 'show agreement' view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 09:08:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 07:08:26 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-MDvj8zdFvX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I've fixed Katrin's patch. With this second patch it will work. Test plan: translate update LANG edit po/LANG-messages-js.po translate install LANG restart_all (JS strings are cached!!) Try now the UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 09:28:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 07:28:59 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-UnSH7zew04@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #12) > I've fixed Katrin's patch. > With this second patch it will work. > > Test plan: > translate update LANG > edit po/LANG-messages-js.po > translate install LANG > restart_all (JS strings are cached!!) > Try now the UI and ofc `yarn js:build` that is mandatory when you modify vue files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 10:09:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 08:09:44 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-lVEAD3KwlA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 10:09:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 08:09:46 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-BxTJ2mgOM3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149825|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149836&action=edit Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. Signed-off-by: Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 10:10:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 08:10:35 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-VwWDmNck87@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148527|0 |1 is obsolete| | --- Comment #44 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 149837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149837&action=edit Bug 33277: Do not search using thesaurus when linking non 6XX fields This patch sets thesaurus as undefined when linking any field except 6XX This fixes the case where authrotiy records don't have the thesaurus defined Consequently - this means that Koha does not support multiple thesaurus records for authorities outside of subjects i.e. Using the default linker, and having both an LCSH and Sears record for 'Shakespeare,William' A 100 entry will find two results and the heading won't be linked. Previously we always linked to the LCSH To test: 1 - Import the attached auths and biblio (from bug 33159 comment 24) 2 - Set system preferences: RequireChoosingExistingAuthority - don't require AutoCreateAuthorities - don't generate CatalogModuleRelink - Do LinkerKeepStale - Don't LinkerModule - default LinkerRelink - do 3 - Edit the imported bib 4 - Save it 5 - Headings are not linked except 600 6 - Apply patch 7 - Restart all 8 - Edit and save record 9 - Headings are successfully linked Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> Current status: Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 10:10:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 08:10:38 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-0SBZpgVldG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148528|0 |1 is obsolete| | --- Comment #45 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 149838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149838&action=edit Bug 33277: Support custom thesaurus authority with no 040 specified Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 10:10:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 08:10:41 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-C4u11d9Tmz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148529|0 |1 is obsolete| | --- Comment #46 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 149839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149839&action=edit Bug 33277: Add comments and missing thesauri Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 10:10:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 08:10:43 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-VgYFeIg2QW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 --- Comment #47 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 149840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149840&action=edit Bug 33277: Search thesaurus for 'notspecified' Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 10:10:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 08:10:46 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-pZ8jAHBoZS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148531|0 |1 is obsolete| | --- Comment #48 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 149841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149841&action=edit Bug 33277: (follow-up) Fix notdefined search for Zebra and ES Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 10:10:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 08:10:49 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-thXxRs51fV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148735|0 |1 is obsolete| | --- Comment #49 from Frank Hansen <frank.hansen at ub.lu.se> --- Created attachment 149842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149842&action=edit Bug 33277: Adjust source file for zebra mappings The previous patches adjusted the mappings directly - moving this change to the correct build file Not needed for sign off, but QA can test that nothing changes when rebuilding the files: xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml > etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 10:11:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 08:11:39 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-2LYaUXPukf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149836|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149843&action=edit Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 10:14:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 08:14:12 +0000 Subject: [Koha-bugs] [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1 In-Reply-To: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33558-70-NSPn0iz1JX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 10:14:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 08:14:14 +0000 Subject: [Koha-bugs] [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1 In-Reply-To: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33558-70-OkRR5PQfxj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149820|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149844&action=edit Bug 33558: Use template wrapper for breadcrumbs: Serials part 1 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Claims - Claims for a vendor - Check expiration - Subscription details -> - Serial collection - Create routing list - Edit routing list - Preview routing list Signed-off-by: Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:05:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:05:40 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-l4KmVE3WEq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149824|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149845&action=edit Bug 33549: Fix dialog box in patron restrictions To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'New restriction' 4. Enter a code and label 5. Click 'Save' --> 'Type added' at the top of the page is not styled 6. Apply patch 7. Try again, dialog is styled correctly Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:06:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:06:01 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-nmtbYAHDT8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- Works as described, thanks for the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:26:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:26:19 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33127-70-ds3MwyZDNT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149756|0 |1 is obsolete| | --- Comment #5 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 149846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149846&action=edit Bug 33127: Use template wrapper for breadcrumbs: Administration part 5 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> - Record overlay rules - Search filters (must have SavedSearchFilters enabled) - System preferences -> OverDriveAuthName -> OverDrive library authnames table - MARC bibliographic framework -> MARC structure (list, new, edit, delete confirm). - Record matching rules (list, new, edit, delete confirm) - OAI sets configuration (list, new, edit) -> Define mappings - Patron attribute types (list, new, edit, delete confirm) - Patron restrictions (list, new, edit, delete confirm) Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:30:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:30:51 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33127-70-DzBx8LYrRc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 Andrew Auld <andrew.auld at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Great. All looks good. I took a particularly deep dive around the Marc Structure and Marc overlay rules areas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:38:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:38:23 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-prLWkJDEsy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149564|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149847&action=edit Bug 33483: Fix link EBSCO package with local agreements Bug 33066 broke that, we need to set 'initialized'. Test plan: Turn on EBSCO provider, search for a package and click "Add new agreement". The modal must open with the list of agreements. Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:38:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:38:26 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-qEiOwzn71d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149565|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149848&action=edit Bug 33483: Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:38:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:38:28 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-GxtQiJlhUi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149566|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149849&action=edit Bug 33483: Make KohaTable accept customizable actions button We have hardcoded some buttons: edit, delete But we could need specific buttons. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:38:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:38:31 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-WQQ1Ony4Ab@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149567|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149850&action=edit Bug 33483: Restore 'select' We are not supposed to see edit and delete buttons, but select instead, to pick an agreement. Regression introduced by commit 809f90d394fdef8142fdf8f4a6e825dc14a132d4 Bug 33066: Remove build_datatable Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:38:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:38:34 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-wwVoAFLFZS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149568|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149851&action=edit Bug 33483: (follow-up) Update the way we distinguish if AgreementsList is called from EHoldingsEBSCOPackageAgreements or not Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:38:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:38:37 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-fWl06v6GuD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149569|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149852&action=edit Bug 33483: Prevent 400 when more than 1 agreement is linked We were passing package_agreements.agreement and the server returned Object { message: "Properties not allowed: agreement.", path: "/body/package_agreements/0" } Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:39:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:39:58 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-JSzUhDfMJz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- All working as expected and code reads reasonably. I think I would have liked to have seen the KohaTable flexibility improvements on their own bug as Matt had done, but I also don't want to block this one moving through, and we're early enough in the Vue/ERM side of things that I think we're OK this way. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:40:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:40:41 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-co5Lal9SyN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149823|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149853&action=edit Bug 33491: Fix UI issues in EHoldingsEBSCOPackageAgreements Signed-off-by: Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:41:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:41:08 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-SqiqUpGdIs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is certainly an improvement, Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:51:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:51:49 +0000 Subject: [Koha-bugs] [Bug 33354] Error 400 Bad Request when submitting form in ERM In-Reply-To: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33354-70-2jGXVsaSuv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149113|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149854&action=edit Bug 33354: Add 'required' UI elements Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:51:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:51:51 +0000 Subject: [Koha-bugs] [Bug 33354] Error 400 Bad Request when submitting form in ERM In-Reply-To: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33354-70-tmGYBNrHaH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149114|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149855&action=edit Bug 33354: Add error if related user open but user is missing Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:51:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:51:54 +0000 Subject: [Koha-bugs] [Bug 33354] Error 400 Bad Request when submitting form in ERM In-Reply-To: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33354-70-k55ISm221m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149115|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149856&action=edit Bug 33354: Show all form error messages in the warning dialog Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 11:53:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 09:53:23 +0000 Subject: [Koha-bugs] [Bug 33354] Error 400 Bad Request when submitting form in ERM In-Reply-To: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33354-70-fB4jt5FenY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Reasonable solution, Passing QA. I'd like to have seen a corresponding cyrpess test, but after a quick discussion with Pedro I understand there's a medium term plan to look at migrating this from new window to modal operation and then write the tests there.. writing new window tests is beyond scope here (and isn't trivial apparently) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 12:32:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 10:32:43 +0000 Subject: [Koha-bugs] [Bug 32563] Reservedate becomes expirationdate in some cases In-Reply-To: <bug-32563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32563-70-0alJprfEnc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32563 --- Comment #5 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> --- Created attachment 149857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149857&action=edit Bug 32563: Cloning $self->reservedate leads to error 500 If DefaultHoldExpirationdate is set and I trap a hold and revert the hold's waiting status and then try to cancel the hold, I get an error. To test: 1. Go to /cgi-bin/koha/admin/preferences.pl?op=search&searchfield=DefaultHoldExpirationdate 2. Setup default expiration date to be 1 year from reserve date for example. 3. Switch to catalog to any biblio with item for example /cgi-bin/koha/catalogue/detail.pl?biblionumber=1 and place a hold for any borrower. 4. Check in an item from the biblio you reserved and your hold gets trapped. 5. Go to the biblio and to it's holds page and revert the waiting status of your hold. 6. Notice that expiration date is empty. 7. Cancel the hold and get an error. 8. Apply this patch. 9. Repeat step above, but now no error should be raised. Also prove prove t/db_dependent/Hold.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 12:32:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 10:32:53 +0000 Subject: [Koha-bugs] [Bug 32563] Reservedate becomes expirationdate in some cases In-Reply-To: <bug-32563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32563-70-zmu5HyM1bc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32563 Emmi Takkinen <emmi.takkinen at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 12:34:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 10:34:01 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-igsLwQ80W8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #31 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149858&action=edit Bug 32450: (QA follow-up) Fix failing tests This patch fixes the failing tests in t/db_dependent/SIP/Patron.t Test plan: Run prove -v t/db_dependent/SIP/Patron.t and all tests should pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 12:34:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 10:34:04 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-jkcepI5amP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #32 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149859&action=edit Bug 32450: (QA follow-up) Change wording in debit types table This patch changes confusing wording in the debit types table. Column heading No issues charge has been changed to Blocks checkouts? and the column data is now simply Yes/No rather than Included/Not included Test plan: 1) Apply patch 2) Navigate to debit types in administration 3) The column in the table should exist as described above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 12:37:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 10:37:00 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-cKkr8YYQ37@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 12:45:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 10:45:59 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-kySgNJWjrC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146159|0 |1 is obsolete| | --- Comment #20 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149860&action=edit Bug 32721: Add branch specific userjs and usercss This patch allows for branch specific userJS and userCSS to be added through the libraries table. This works in conjunction with the global UserJS and UserCSS functionality and allows for multiple OPACs with different css and js options. Test plan: 1) Add to apache conf (/etc/apache2/sites-available/kohadev.conf) SetEnv OPAC_BRANCH_DEFAULT "FFL" RequestHeader add X-Koha-SetEnv "OPAC_BRANCH_DEFAULT FFL" 2) In the container, run restart_all 3) Navigate to the OPACUserJS and OPACUserCSS system preferences and add the following: OPACUserJS - console.log('Hello from global sysprefs');, OPACUserCSS - 'body { background-color: black; }' 4) Refresh the OPAC and the background should be black and the message should be logged to the console in developer tools 5) Navigate to Administration > Libraries 6) On the Fairfield branch (if this does not exist you will need to create a branch with a code matching the code that you added to the apache conf file), click edit 7) At the bottom there should be two fields to add userjs and usercss, complete with Codemirror syntax checking 8) In userjs add console.log('Hello from branch level'); and in usercss add 'body { background-color: blue; } then save 9) Return to the OPAC and refresh 10) If you are logged out of the OPAC it should now be logging both the message from global and from the branch level and the background should be blue (if not you will need to log out) 11) Log back into the OPAC using a user that DOES NOT have a default branch matching the branch you added to the Apache conf 12) The OPAC should now revert to only showing the global message in the console with a black background Sponsored-by: PTFS Europe Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 12:46:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 10:46:01 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-DCgBEUkE41@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146160|0 |1 is obsolete| | --- Comment #21 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149861&action=edit Bug 32721: Database update to add userjs and usercss to branches table This patch adds the columns for userjs and usercss to the branches table Test plan as per previous commit Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 12:46:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 10:46:04 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-iaesbJ8hsZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146161|0 |1 is obsolete| | --- Comment #22 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149862&action=edit Bug 32721: DBIC Schema This commit adds the DBIC Schema for the database change Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 12:46:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 10:46:07 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-fPiXCUR1ZA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146162|0 |1 is obsolete| | --- Comment #23 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149863&action=edit Bug 32721: Add unit tests Unit tests to test two new functions: GetBranchSpecificJS and GetBranchSpecificCSS Test plan: 1) In the shell run prove -t t/db_dependent/Template/Plugin/Branches.t Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 12:46:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 10:46:12 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-dyXw2ABO4b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146163|0 |1 is obsolete| | --- Comment #24 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149864&action=edit Bug 32721: Tidy up - duplicate fetching of userjs and css Currently UserJS and UserCSS is injected into the template as a parameter through Auth.pm but is then fetched using Koha.Preference() in the template. This patch tidies this up by removing the parameters from Auth.pm Test plan as per first commit Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 12:46:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 10:46:15 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-IDLJXYU99S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146164|0 |1 is obsolete| | --- Comment #25 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149865&action=edit Bug 32721: (QA follow up) - fix QA issues This patches addresses issues raised by the QA tests. It also adds a missed import of the Branches file in the document head Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 12:46:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 10:46:18 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-kcNuB6u3UM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147373|0 |1 is obsolete| | --- Comment #26 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149866&action=edit Bug 32721: (QA follow-up) Add missing imports Missing imports added in three template files Exec flag added to atomic update file Tinymce imports removed A new bug will be created to move codemirror into an inc file at latest version Test plan as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 12:47:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 10:47:18 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-yNjh7G2onK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #27 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Rebased - resetting to Signed off as previous status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 13:24:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 11:24:43 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-K5Tny8bBhE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 13:24:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 11:24:46 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-LmVF95LP9s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149764|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149867&action=edit Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Most circulated items - Report results - Items with no checkouts - Report results - Catalog statistics wizard - Report results - View dictionary - New definition (steps 1-5) - Saved reports - View report - New report - Edit report - Guided reports - Build a report - Steps 1 through 6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 13:24:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 11:24:58 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-JqcI4b0nTX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 --- Comment #29 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149868&action=edit Bug 32680: Add cover images plugin hook This patch adds a plugin hook to inject cover images into the templates Test plan: 1) Apply all patches 2) Go to https://github.com/PTFS-Europe/koha-plugin-addBDSCovers 3) In the releases section, download the .kpz file 4) Upload this in the plugins section and enable the plugin 5) In either the OPAC or staff client, search the catalog 6) The results should have cover art from BDS covers 7) Click on a result and the detail page should also have the cover art -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 13:25:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 11:25:01 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-F2WtizGVro@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 --- Comment #30 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149869&action=edit Bug 32680: Add classes to template files This patch adds the classes to the template files so that the plugin hook can identify that cover images are required and where to inject them Test plan as per first commit Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 13:25:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 11:25:20 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-Hc2PGnWLCL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 13:25:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 11:25:35 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-KJyQXcLSwJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 13:27:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 11:27:22 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-O9uOpYBR2r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 13:29:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 11:29:26 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-khWHG65kPx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 --- Comment #31 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- QA comments addressed: All changes removed from .pl files and plugins dealt with exclusively in the template files Unnecessary JS variables removed from template scripts Class names updated as suggested, plugin .kpz files also updated and re-released to reflect this Patch also rebased, hopefully everything should work as expected! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 13:40:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 11:40:35 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-OefT6MuNH9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #33 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Thanks Matt. Revisiting this one now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:05:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:05:06 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-aWGthDB0kz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:07:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:07:34 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-euxJy0QJiB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:07:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:07:53 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-5RGNiXf39p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149199|0 |1 is obsolete| | --- Comment #14 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 149870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149870&action=edit Bug 33416: Fix Agreements.ts <failure message="Timed out retrying after 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying a fter 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it. Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:20:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:20:34 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-wyX7i1IiUw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 --- Comment #15 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 149871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149871&action=edit Bug 33416: Fix Searchbar_spec.ts Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:00 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-O4wJ41nB6F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:02 +0000 Subject: [Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register In-Reply-To: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33216-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33216-70-2fXd1lxLN9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216 --- Comment #15 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:04 +0000 Subject: [Koha-bugs] [Bug 33354] Error 400 Bad Request when submitting form in ERM In-Reply-To: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33354-70-xJzosV661Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33354 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:06 +0000 Subject: [Koha-bugs] [Bug 33354] Error 400 Bad Request when submitting form in ERM In-Reply-To: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33354-70-FLR7pZMB7o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33354 --- Comment #11 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:08 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-tFLfamkWY2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:10 +0000 Subject: [Koha-bugs] [Bug 33416] Agreements.ts is failing In-Reply-To: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33416-70-k8zQE3PSRY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33416 --- Comment #16 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:12 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-lx3ixnLUQp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:14 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-ZjyuTMmzZU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #16 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:16 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-VUekRMpTpy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:18 +0000 Subject: [Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement In-Reply-To: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33483-70-YSHcij73OP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 --- Comment #33 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:20 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-Bip37WzAI1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:22 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-hjlAeRu77D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #10 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:24 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-RuPM0I6AnN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:22:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:22:26 +0000 Subject: [Koha-bugs] [Bug 33533] Translatability: Do not separate "Patron" or "Organization" and "identity" in memberentrygen.tt In-Reply-To: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33533-70-NS6sCpseg5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33533 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:26:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:26:48 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-r26b7dg2Fv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- $dat->{'count'} = $biblio->items->count + $hostitems->count; Should we apply the same count (ie. include host items) in other catalogue scripts as well? See catalog-strings.inc var count = [% count | html %]; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:35:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:35:10 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-vKklKKE6u1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- prove Circulation.t Circulation/NoIssuesChargeGuarantees.t Circulation/Returns.t Circulation/_CalculateAndUpdateFine.t Circulation/issue.t Koha/Account.t Koha/Account/Line.t Koha/Account/Lines.t Koha/Account/Offsets.t Koha/Cash/Register.t Koha/Cash/Register/Cashup.t Koha/Charges/Sales.t Koha/Checkouts.t Koha/Items.t Koha/Patron.t Koha/Plugins/Account_hooks.t Letters/TemplateToolkit.t Members.t Overdues.t Reserves.t SIP/Patron.t api/v1/patrons_accounts.t Circulation.t ........................... 62/66 Use of uninitialized value $rentalCharge in numeric gt (>) at /usr/share/koha/C4/Circulation.pm line 1120. Use of uninitialized value $rentalCharge in numeric gt (>) at /usr/share/koha/C4/Circulation.pm line 1120. Use of uninitialized value $rentalCharge in numeric gt (>) at /usr/share/koha/C4/Circulation.pm line 1120. Use of uninitialized value $rentalCharge in numeric gt (>) at /usr/share/koha/C4/Circulation.pm line 1120. Circulation.t ........................... ok Circulation/NoIssuesChargeGuarantees.t .. ok Circulation/Returns.t ................... ok Circulation/_CalculateAndUpdateFine.t ... ok Circulation/issue.t ..................... ok Koha/Account.t .......................... ok Koha/Account/Line.t ..................... ok Koha/Account/Lines.t .................... ok Koha/Account/Offsets.t .................. ok Koha/Cash/Register.t .................... ok Koha/Cash/Register/Cashup.t ............. ok Koha/Charges/Sales.t .................... ok Koha/Checkouts.t ........................ ok Koha/Items.t ............................ ok Koha/Patron.t ........................... ok Koha/Plugins/Account_hooks.t ............ ok Letters/TemplateToolkit.t ............... ok Members.t ............................... ok Overdues.t .............................. ok Reserves.t .............................. 8/77 No reserves HOLD_CANCELLATION letter transported by email at /usr/share/koha/C4/Letters.pm line 588. Reserves.t .............................. ok SIP/Patron.t ............................ ok api/v1/patrons_accounts.t ............... ok All tests successful. Files=22, Tests=422, 216 wallclock secs ( 0.85 usr 0.12 sys + 167.92 cusr 25.45 csys = 194.34 CPU) Result: PASS Looks promising :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:39:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:39:01 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-X3H24q9d93@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- git grep -l Accountline Accounts.t ILSDI_Services.t Koha/Cash/Register.t Koha/Patrons.t Patrons.t SIP/Patron.t SIP/Transaction.t api/v1/patrons_accounts.t They pass too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:41:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:41:09 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-HtgRWN6R0U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Matt Blenkinsop from comment #32) > Created attachment 149859 [details] [review] > Bug 32450: (QA follow-up) Change wording in debit types table > > This patch changes confusing wording in the debit types table. Column > heading No issues charge has been changed to Blocks checkouts? and the > column data is now simply Yes/No rather than Included/Not included Yes, I think that is clearer indeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:42:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:42:09 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-ZANtaWG8hR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:42:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:42:11 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-iMhgo3vWhp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149653|0 |1 is obsolete| | --- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149872&action=edit Bug 32450: Update db to add noissuescharge flag and remove sysprefs This commit updates the database to add a new flag to show which debit_types are included in noissuescharge. It also deletes the current sysprefs that are hardcoded for this as these are now redundant. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Mentored-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:42:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:42:14 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-SqQT4XT9CP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149654|0 |1 is obsolete| | --- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149873&action=edit Bug 32450: DBIC Schema Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:42:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:42:16 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-RGT84gWpdP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149655|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149874&action=edit Bug 32450: Noissuescharge debit type exclusions Currently the debit types to be excluded from the noissuescharge syspref are hardcoded in non_issues_charges which gives no flexibility for selecting which debit types should be included. This patch amends the subroutine to use a database flag to identify which debit types should be included. It also adds a column to the table in the Debit Types area of System Preferences which shows which debit types are included. The ability to edit all debit types has been added rather than just the non-system ones and the flag to include/exclude the debit type from noissuescharge can be changed by clicking that edit button. Test plan: 1) Choose a patron and add some fines to this patron that have different debit_types 2) Navigate to system preferences and observe that currently you can only amend the noissuescharge included debit types using three preferences: ManInvInNoissuesCharge, RentalsInNoissuesCharge, HoldsInNoissuesCharge 3) Apply both commits attached to this bug 4) Navigate as above and observe that these three system preferences are now gone 5) Navigate to Debit Types in System Preferences, the table should have a column called No issues charge that shows whether a debit_type is Included or Not included 6) Click the edit button and there should be a checkbox for Included in noissuescharge 7) Change some of the debit_types using this option and observe that the patron you added fines to will either be blocked from checkouts or able to checkout depending on which debit_types you include and the value of these fines. Mentored-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:42:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:42:19 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-mkwbVfI7gl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149656|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149875&action=edit Bug 32450: Unit tests updated Unit tests for the non_issues_charges function have been updated to remove the system preferences and test based on the new database flags Test plan: 1) Apply all patches 2) In the kshell, run prove -v t/db_dependent/Accounts.t 3) All tests should pass Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:42:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:42:21 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-zjsurx0Qfq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149657|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149876&action=edit Bug 32450: Add boolean to DBIC schema Adding boolean flag to DBIC schema. Test plan as per previous commits Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:42:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:42:24 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-1IdHdZwI5R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149658|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149877&action=edit Bug 32450: (QA follow-up) Fix QA test errors Exec flag added to atomic update file, trailing whitespaces removed Unit tests patched to remove duplicate variable names Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:42:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:42:27 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-BMFrn3Zyxp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149659|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149878&action=edit Bug 32450: (QA follow-up) Polishing atomic update Database comment. Variable names. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:42:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:42:29 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-WdVRxDiVEw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149660|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149879&action=edit Bug 32450: (QA follow-up) Update UsageStats for removed prefs Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:42:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:42:32 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-OJOr2o4IfN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149858|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149880&action=edit Bug 32450: (QA follow-up) Fix failing tests This patch fixes the failing tests in t/db_dependent/SIP/Patron.t Test plan: Run prove -v t/db_dependent/SIP/Patron.t and all tests should pass Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:42:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:42:34 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-YVavePwkbQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149859|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149881&action=edit Bug 32450: (QA follow-up) Change wording in debit types table This patch changes confusing wording in the debit types table. Column heading No issues charge has been changed to Blocks checkouts? and the column data is now simply Yes/No rather than Included/Not included Test plan: 1) Apply patch 2) Navigate to debit types in administration 3) The column in the table should exist as described above Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:42:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:42:37 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-lUTgqmYRvY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #47 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149882&action=edit Bug 32450: (QA follow-up) Fix SIP/Transaction.t You forgot this one, Matt. Comment29 :) Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:49:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:49:13 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-Fa1yzSG1AP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:51:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:51:56 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-IKxZ7n53vK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149116|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149883&action=edit Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:51:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:51:59 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-DrpIdljTiq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149117|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149884&action=edit Bug 33355: Update forms markup to be in line with interface patterns https://wiki.koha-community.org/wiki/Interface_patterns Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:52:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:52:02 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-OvT36t2dZp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149118|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149885&action=edit Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:52:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:52:50 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-grRaYqgRyJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Something in me doesn't really like the fieldset nesting this introduces.. but display wise it's working well. Code is all working after the changes, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 14:53:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 12:53:42 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-ZRNzctU4Pv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149869|0 |1 is obsolete| | --- Comment #32 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149886&action=edit Bug 32680: Add classes to template files This patch adds the classes to the template files so that the plugin hook can identify that cover images are required and where to inject them Test plan as per first commit Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:08:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:08:52 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-Z27a1Ct70z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:08:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:08:55 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-Oi3unUml8K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149868|0 |1 is obsolete| | Attachment #149886|0 |1 is obsolete| | --- Comment #33 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149887&action=edit Bug 32680: Add cover images plugin hook This patch adds a plugin hook to inject cover images into the templates Test plan: 1) Apply all patches 2) Go to https://github.com/PTFS-Europe/koha-plugin-addBDSCovers 3) In the releases section, download the .kpz file 4) Upload this in the plugins section and enable the plugin 5) In either the OPAC or staff client, search the catalog 6) The results should have cover art from BDS covers 7) Click on a result and the detail page should also have the cover art Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:08:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:08:57 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-uvTwMvr34Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 --- Comment #34 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149888&action=edit Bug 32680: Add classes to template files This patch adds the classes to the template files so that the plugin hook can identify that cover images are required and where to inject them Test plan as per first commit Sponsored-by: PTFS Europe Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:09:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:09:00 +0000 Subject: [Koha-bugs] [Bug 32680] Add hooks to allow cover images to be provided by plugins In-Reply-To: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32680-70-g4ZPqligUf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32680 --- Comment #35 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149889&action=edit Bug 32680: (QA follow-up) Fix opac call and remove second fetch Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:18:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:18:25 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-joJcBdonjV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147433|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149890&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:18:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:18:28 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-VPXZi4jTQB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147434|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149891&action=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all fields from the borrowers database table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:18:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:18:31 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-XhRzT0XteL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147435|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149892&action=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of moving from comma delimited to pipe delimitation for the preference contents -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:18:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:18:34 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-wehnWIcdYT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147436|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149893&action=edit Bug 29822: Database and Preference description updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:18:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:18:38 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-kBE0YqJvwW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147437|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149894&action=edit Bug 29822: Update unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:22:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:22:48 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-y8NULUOBII@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #37 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- We should be back on again now.. master is moving so fast at the moment :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:22:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:22:56 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29822-70-7bEiZ0nxSF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:29:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:29:55 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-KDoY7ie8vq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32607 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:29:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:29:55 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-nbkUfEvrYk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32474 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:35:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:35:35 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-gBPCGbjIA6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com --- Comment #10 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- I'm about to start working on 32474 again now that a lot of the ERM refactoring work is done - I'm aiming to pick that up towards the end of this week -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:45:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:45:38 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-KXTFKfHqqN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #11 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Agustin: we agreed on renaming this 'Record sources' as it will be reused with the overlay rules eventually, and we need to leave room for an API-driven cataloguing module, which is not, to be precise, an import source, and we will want to identify it as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:46:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:46:52 +0000 Subject: [Koha-bugs] [Bug 24609] Add routes for updating checkouts In-Reply-To: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24609-70-NFtjGRDvOX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 --- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- It's still on my list.. but I have other priorities at the moment.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 15:52:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 13:52:13 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-KHYXf4tvkY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Putting this back to Needs signoff since Marius works with me :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:17:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:17:32 +0000 Subject: [Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w In-Reply-To: <bug-33160-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33160-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33160-70-G0by2Ft7pr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Jacob O'Mara <jacob.omara at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara at ptfs-europe.com --- Comment #18 from Jacob O'Mara <jacob.omara at ptfs-europe.com> --- Hi Katrin, sorry this message slipped through my radar!!! I could be being really very stupid but was the dependency not pushed in 22.11.03? I'm probably missing something really obvious! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:26:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:26:06 +0000 Subject: [Koha-bugs] [Bug 31104] Pagination generates HTTP "Link:" header which is over 8192 bytes apache's limit In-Reply-To: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31104-70-rfqjH3fFOP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31104 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:26:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:26:53 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-7wE4wbXffS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Bumping here again on the lack of translated auth values .. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:28:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:28:06 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-4K5uzc9g4h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Marcel de Rooy from comment #7) > Bumping here again on the lack of translated auth values .. But this is not coming from an authorised value in that case... It's the fallback text for the itemtype level setting that's failing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:31:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:31:01 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20307-70-4rqyRRHZ69@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #107 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Ping people -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:31:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:31:20 +0000 Subject: [Koha-bugs] [Bug 24977] Enable translations for authorised values (POC) In-Reply-To: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24977-70-SjQnvnoiPi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Ping pong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:31:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:31:34 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-QeRfJ75V1Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Awesome guys, thanks for this.. great to see it worked through and the teamwork that happened here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:32:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:32:04 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-TT1HoI3aMZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #7 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Hi Owen, I have tested the guided reports screens and the breadcrumbs now look and behave as they should. Thank you. I still can't run the 'Items with no checkouts' report to get to the results page. This may well be user error rather than anything to do with your patch. But it does mean I haven't been able to test the Report results page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:33:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:33:49 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-gcFLuvjBRN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #8) > (In reply to Marcel de Rooy from comment #7) > > Bumping here again on the lack of translated auth values .. > > But this is not coming from an authorised value in that case... It's the > fallback text for the itemtype level setting that's failing. Sure. But it's the same code or direct context in the .xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:35:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:35:16 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-OBJUH7QiMC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Cleared up on IRC: the item type value will be translated, but the AV values will not. With this fix we can still have at least all translated one non-English language which often will help already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:40:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:40:04 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-cf52bigfWA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Some remarks from comment 6 are still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:40:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:40:45 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20307-70-J34nATSxG2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #108 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Give your opinion on the 2 implementations, that's the only way to make things move forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:55:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:55:33 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-h8okgRAb2j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Example display Availability: Items available for loan: Centerville (1)Call number: PERL A 1. Items available for reference: Centerville: NOT FOR LOAN (1)Call number: PERL A 4. Centerville: Staff collection (1)Call number: PERL A 5. Not available: Centerville: Damaged (1)Call number: PERL A 3. Centerville: Withdrawn (1)Call number: PERL A 2. # Toggling NFL statuses Availability: Items available for loan: Centerville (1)Call number: PERL A 1. Items available for reference: Centerville: NOT FOR LOAN (1)Call number: PERL A 4. Not available: Centerville: Damaged (1)Call number: PERL A 3. Centerville: Staff collection (1)Call number: PERL A 5. Centerville: Withdrawn (1)Call number: PERL A 2. # Toggling NFL statuses Availability: Items available for loan: Centerville (1)Call number: PERL A 1. Items available for reference: Centerville: Staff collection (1)Call number: PERL A 5. Not available: Centerville: Damaged (1)Call number: PERL A 3. Centerville: NOT FOR LOAN (1)Call number: PERL A 4. Centerville: Withdrawn (1)Call number: PERL A 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 16:56:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 14:56:11 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-sspBZHScrs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Clarification: uc NOT FOR LOAN is the translation :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 17:06:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 15:06:48 +0000 Subject: [Koha-bugs] [Bug 33520] Update Patron Details link alignment In-Reply-To: <bug-33520-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33520-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33520-70-tDEJpEpex4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33520 Andrew Auld <andrew.auld at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 17:22:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 15:22:47 +0000 Subject: [Koha-bugs] [Bug 33488] Branch transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-GGnqFea0pz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 AspenCat Team <aspencatteam at clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 17:24:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 15:24:20 +0000 Subject: [Koha-bugs] [Bug 33488] Branch transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-EXg6ASsmG4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 AspenCat Team <aspencatteam at clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #2 from AspenCat Team <aspencatteam at clicweb.org> --- Tested this on our test server and compared it to our production server, which has more resources and the test server worked far faster. This will be very helpful for our libraries - Bob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 17:49:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 15:49:59 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-R0C87kXWZA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Andrew Auld from comment #7) > I still can't run the 'Items with no checkouts' report to get to the results > page. Ah right, sorry I didn't comment on that issue. That seems to be a bug related to strict_sql_modes and can't be worked around unless you have access to koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 17:52:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 15:52:27 +0000 Subject: [Koha-bugs] [Bug 33562] New: Allow circulation and fine rules to select specific library hold groups Message-ID: <bug-33562-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33562 Bug ID: 33562 Summary: Allow circulation and fine rules to select specific library hold groups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com A library can belong to more than one local hold group. It would be nice if "Default checkout, hold and return policy" & "Holds policy by item type" by library could be set by either "local hold group" (which currently allows any branch in any local hold group it's in) OR to allow a specific hold group. Example of where having both would be useful: Library Group A: Library 1 Library 4 Library 5 Library 6 Library 7 No other branches (2, 3, 8) can place holds on any of those libraries items. Library Group B: Library 4 Library 5 Library 6 Group B wants a specific item type to be available to their patrons but not to library 1 or 7, even if they're picking up at library 4, 5, or 6 for some reason. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:10:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:10:13 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-tRWBs0aM0l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com --- Comment #10 from Lisette Scheer <lisette.scheer at bywatersolutions.com> --- Would it be possible to have it save as part of the saveState an option for keeping or clearing filters and have it clear filters by default, but someone could turn it on for a table if they wanted? Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:27:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:27:04 +0000 Subject: [Koha-bugs] [Bug 33563] New: Enable compatibility with Elasticsearch secure mode Message-ID: <bug-33563-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33563 Bug ID: 33563 Summary: Enable compatibility with Elasticsearch secure mode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org Hi friends, Koha should support authenticated access to Elasticsearch, at the very minimum https://www.elastic.co/guide/en/elasticsearch/reference/current/http-clients.html and https://www.elastic.co/guide/en/elasticsearch/reference/current/token-authentication-services.html We'd need a place to stash our ES configuration information much like we used to for Zebra. koha-conf.xml is probably fine? Obviously open to discussion from the way smarter people here - this is only to get the discussion started, as Elasticsearch will start creating egregious scary logs for every connection complaining about security, starting with version 7. Liz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:34:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:34:23 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-ROfDyoqAme@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:34:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:34:26 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-Pj2tTa09dD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149895&action=edit Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link This patch revises the process by which the serials search results page redirects to the batch edit page based on which checkboxes are checked. To test, apply the patch and go to serials. You should have some subscriptions which are open and some which are closed. - Perform a search which will return at least one result under each tab (Open and Closed). - Checking one or more checkboxes should activate the "Edit selected serials" link, which should work correctly to redirect you to the batch edit page. - Unchecking all the checkboxes should make the edit link disappear. - Check that the "Select all" and "Clear all" links work the same way manually checking checkboxes does. - Confirm that controls under each tab work correctly just for the results under that tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:39:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:39:59 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-KCy21ps8BR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:40:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:40:02 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-4mlOCuTxb8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147531|0 |1 is obsolete| | --- Comment #36 from David Nind <david at davidnind.com> --- Created attachment 149896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149896&action=edit Bug 27634: Turn off patron self-registration if no default category is set If there is no default category defined in PatronSelfRegistrationDefaultCategory the full feature must be displayed. We already hide the link from the OPAC main page, but the form is still accessible. Test plan (for the whole patch set): 1. Turn on PatronSelfRegistration 2. Don't set PatronSelfRegistrationDefaultCategory 3. Go to the OPAC main page and confirm that the "Register here" link is not displayed 4. Hit opac-memberentry.pl and confirm that you are redirected to the OPAC main page 5. Go to the about page and confirm that you see a warning in the "System information" tab 6. Set PatronSelfRegistrationDefaultCategory to an invalid patron's category 7. Repeat 3, 4, 5 8. Set PatronSelfRegistrationDefaultCategory to a valid patron's category 9. Self-register a patron and confirm it works as expected 10. Edit PatronSelfRegistrationBorrowerUnwantedField and confirm that you cannot remove dateexpiry and categorycode Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:40:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:40:05 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-rKctPoVWUi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147532|0 |1 is obsolete| | --- Comment #37 from David Nind <david at davidnind.com> --- Created attachment 149897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149897&action=edit Bug 27634: Force include categorycode to PatronSelfRegistrationBorrowerUnwantedField We should always use the category defined in PatronSelfRegistrationDefaultCategory. This could be discussed however. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:40:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:40:08 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-r8WUgcHlv1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147533|0 |1 is obsolete| | --- Comment #38 from David Nind <david at davidnind.com> --- Created attachment 149898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149898&action=edit Bug 27634: Add the ability to exclude fields from "modal" sysprefs Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:40:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:40:10 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-ZOopbRQGz7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147534|0 |1 is obsolete| | --- Comment #39 from David Nind <david at davidnind.com> --- Created attachment 149899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149899&action=edit Bug 27634: Force include of dateexpiry Otherwise we see a "Date expiry" entry in the form. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:40:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:40:13 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-UlszSDKsd7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149746|0 |1 is obsolete| | --- Comment #40 from David Nind <david at davidnind.com> --- Created attachment 149900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149900&action=edit Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:40:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:40:16 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-bgN8Kurxck@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149747|0 |1 is obsolete| | --- Comment #41 from David Nind <david at davidnind.com> --- Created attachment 149901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149901&action=edit Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:40:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:40:19 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-VgefHL8OvZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149748|0 |1 is obsolete| | --- Comment #42 from David Nind <david at davidnind.com> --- Created attachment 149902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149902&action=edit Bug 27634: Hide "Register here" links Make sure the pref is filled with a valid patron's category to display the "register" link Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:42:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:42:23 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-egDq3zvyml@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #43 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. For step 7, to set an invalid patron category: 1.1 koha-mysql kohadev 1.2 SQL query: update systempreferences set value = "INVALID" where variable = "PatronSelfRegistrationDefaultCategory"; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:54:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:54:54 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-szrAydkTS6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:54:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:54:54 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-VTux5pcVkQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:55:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:55:54 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-4vsU8Y4E0i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:55:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:55:56 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-Hs4xF6X2fs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128508|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149903&action=edit Bug 29691: Use template to display news on opac homepage This patch moves the fetching of news to the template and adds a p[lugin method to get news by id TO test: 1 - Define some general and library specific news items 2 - Define in various languages 3 - Define some 'Additional contents' as well 4 - Apply patch 5 - Confirm onlly 'all libraries' news show if not loigged in to opac 6 - Confirm correct library news show when logged in 7 - View specific news items: http://localhost:8080/cgi-bin/koha/opac-main.pl?news_id=12 8 - Confirm that non-existent ids show " This news item does not exist. " 9 - Confirm if you enter ID for additional contents you get 'does not exist' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 18:55:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 16:55:58 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-sc5rX9ZcMH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149904&action=edit Bug 29691: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 19:15:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 17:15:53 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-zZc3bPhj5Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #10) > $dat->{'count'} = $biblio->items->count + $hostitems->count; > > Should we apply the same count (ie. include host items) in other catalogue > scripts as well? See catalog-strings.inc > var count = [% count | html %]; moredetail needs it, the other areas using catalog-strings don't actually seemd to display count or items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 19:33:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 17:33:35 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-HRzh42p6CU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 19:33:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 17:33:37 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-PApW3deXoQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149905&action=edit Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Serials home page - New subscription - Serials search results - Subscription details -> Edit subscription - Subscription details -> Serial collection -> Edit serials - Select one or more seach results and click the "Edit selected serials" to test the batch edit page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 19:39:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 17:39:34 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-MLHOBN6p2F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 19:39:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 17:39:37 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-n5112Cp4hS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149588|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 149906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149906&action=edit Bug 29185: Facilitate searching for cnum Instead of typing the case sensitive Control-number each time. 4 strikes instead of 15 on your keyboard. Wow! Gain of 73%. Test plan: Copy ccl.properties to /etc/koha/zebradb, restart Zebra and search for cnum=SOME_ID in opac or intranet. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 19:39:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 17:39:39 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-0DZCWSWnwR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149589|0 |1 is obsolete| | --- Comment #6 from David Nind <david at davidnind.com> --- Created attachment 149907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149907&action=edit Bug 29185: Groundwork: add template GetCnumSearchURL in Utils Note for QA: Opened bug 33515 to see if we can use this same function in a few other places too. Would probably reduce code and increase consistency. Test plan: See next patch. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 19:39:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 17:39:41 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-ZnFlowP9rN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149590|0 |1 is obsolete| | --- Comment #7 from David Nind <david at davidnind.com> --- Created attachment 149908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149908&action=edit Bug 29185: Display MARC tag 765 in OPAC and intranet XSLT Test plan: ** For OPAC [1] Pick a biblio record A as original entry, fill $001/$003. [2] Pick another biblio record B as translation, add 765 with $t, $a and $d. Put (orgcode)cnum from A into $w. [3] Disable UseControlNumber. [4] Goto OPAC detail page of B. Check link; should be title based. [5] Enable UseControlNumber. [6] Goto OPAC detail page of B. Check link; should incl orgcode and cnum. [7] Edit B. Replace $w with cnum of A only. [8] Goto OPAC detail page of B. Check link; should incl cnum only. ** For staff client [9] Goto staff detail page of B. Check link again. [10] Edit B. Set 765 ind2 to 8, fill $i. [11] Goto staff detail page of B. You should see different label. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 19:43:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 17:43:22 +0000 Subject: [Koha-bugs] [Bug 33564] New: Use template wrapper for breadcrumbs: Serials part 3 Message-ID: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33564 Bug ID: 33564 Summary: Use template wrapper for breadcrumbs: Serials part 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more serials templates so that they use the new template wrapper for breadcrumbs. - serials/subscription-detail.tt - serials/subscription-frequencies.tt - serials/subscription-history.tt - serials/subscription-numberpatterns.tt - serials/viewalerts.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 19:43:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 17:43:22 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32507-70-Kf87hUIG1U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33564 [Bug 33564] Use template wrapper for breadcrumbs: Serials part 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 19:44:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 17:44:50 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-Pb2CmvfgIw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149905|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149909&action=edit Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Serials home page - New subscription - Serials search results - Subscription details -> Edit subscription - Subscription details -> Serial collection -> Edit serials - Select one or more seach results and click the "Edit selected serials" to test the batch edit page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 19:48:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 17:48:15 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-sPybjQPjPC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. Zebra changes - after applying the patches: 1.1 cp etc/zebradb/ccl.properties /etc/koha/zebradb/ 1.2 sudo koha-zebra --restart -v kohadev 2. Set up for testing - make these tags and subfields visible in the editor for the BKS MARC framework: 2.1 003 2.2 765$a, $d, $i, $t, and $w 3. Records used: - Record A: Programming Perl (biblionumber=262) - Record B: CGI programming with Perl (biblionumber=11) 4. cnum searching (OPAC and staff interface - should return Programming Perl): cnum=17259930 5. Step 2 of the test plan - 765$w: (OSt)17259930 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 19:55:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 17:55:53 +0000 Subject: [Koha-bugs] [Bug 2646] Add sort option for the series number In-Reply-To: <bug-2646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2646-70-9VyxgcxOXT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2646 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 20:21:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 18:21:33 +0000 Subject: [Koha-bugs] [Bug 27981] Add option to automatically set the 001 control number to the biblionumber In-Reply-To: <bug-27981-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27981-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27981-70-4HQlmOR4MM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 20:21:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 18:21:34 +0000 Subject: [Koha-bugs] [Bug 28685] Should AutoControlNumber also overwrite 003 field ? In-Reply-To: <bug-28685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28685-70-bSPN5rtG6x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28685 Bug 28685 depends on bug 27981, which changed state. Bug 27981 Summary: Add option to automatically set the 001 control number to the biblionumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27981 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 20:27:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 18:27:39 +0000 Subject: [Koha-bugs] [Bug 33564] Use template wrapper for breadcrumbs: Serials part 3 In-Reply-To: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33564-70-BPv1EsnGJm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33564 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 20:27:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 18:27:41 +0000 Subject: [Koha-bugs] [Bug 33564] Use template wrapper for breadcrumbs: Serials part 3 In-Reply-To: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33564-70-4AJJLLSEml@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33564 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149910&action=edit Bug 33564: Use template wrapper for breadcrumbs: Serials part 3 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Manage frequencies - New frequency - Edit frequency - Manage numbering patterns - New numbering pattern - Edit numbering pattern - Search subscriptions -> View subscription details - If necessary, edit the subscription to enable "Manual history" - Under the "Planning" tab of the detail page, click "Edit history" - If necessary, edit the subscription and select a notice under "Patron notification." - Under the "Information" tab of the subscription detail page, click "subscribers" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 20:44:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 18:44:51 +0000 Subject: [Koha-bugs] [Bug 33565] New: Use template wrapper for breadcrumbs: Tags Message-ID: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33565 Bug ID: 33565 Summary: Use template wrapper for breadcrumbs: Tags Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update tags templates so that they use the new template wrapper for breadcrumbs. - tags/list.tt - tags/review.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 20:44:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 18:44:51 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32507-70-Maung0T0ik@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33565 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33565 [Bug 33565] Use template wrapper for breadcrumbs: Tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 20:45:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 18:45:45 +0000 Subject: [Koha-bugs] [Bug 20058] Option to use shelving location instead of homebranch for sorting In-Reply-To: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20058-70-SONhleXwXC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20058 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 20:49:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 18:49:33 +0000 Subject: [Koha-bugs] [Bug 33565] Use template wrapper for breadcrumbs: Tags In-Reply-To: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33565-70-vKshKUOU1L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33565 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 20:49:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 18:49:35 +0000 Subject: [Koha-bugs] [Bug 33565] Use template wrapper for breadcrumbs: Tags In-Reply-To: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33565-70-kb7o3ZA7dN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33565 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149911&action=edit Bug 33565: Use template wrapper for breadcrumbs: Tags This patch updates two tags templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Tags - Click a tag to see titles with that tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 21:03:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 19:03:23 +0000 Subject: [Koha-bugs] [Bug 33566] New: Use template wrapper for breadcrumbs: Tools, part 1 Message-ID: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Bug ID: 33566 Summary: Use template wrapper for breadcrumbs: Tools, part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several tools templates so that they use the new template wrapper for breadcrumbs. - tools/access_files.tt - tools/additional-contents.tt - tools/automatic_item_modification_by_age.tt - tools/batch_delete_records.tt - tools/batch_extend_due_dates.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 21:03:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 19:03:23 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32507-70-oc6JP518JG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 21:07:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 19:07:49 +0000 Subject: [Koha-bugs] [Bug 33488] Branch transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-RIw2EtHyzR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149458|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149912&action=edit Bug 33488: Add fromBranch index to branch_transfer_limits To test: 1 - Enable UseBranchTransferLimits by item type 2 - Set some limits for book 3 - Place a hold, verify that pikcup dropdown reflects the limits before and after patch Signed-off-by: Bob Benhoff <bbenhoff at clicweb.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 21:18:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 19:18:30 +0000 Subject: [Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results In-Reply-To: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28884-70-zsPrYLsHt5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #14 from Janusz Kaczmarek <januszop at gmail.com> --- (In reply to Nick Clemens from comment #13) > If you change or add a title index with 245(ab) then the "hack" does work. > In fact, it's probably a good idea because any quoted 'full' title search > including a subtitle will fail otherwise Thank you for this comment. Yes, reformulating the search field definition in mappings would be of some help (but which search field? 'title' for sure - into 245(ahbnpc) at least - but will it solve all issues?). But it would not solve the problem universally. For instance, having the title in the record: "$a Will libraries survive? : $b the future of public libraries" and querying: "Will libraries survive? future of public libraries" (without 'the' in this case, but in general: missing any element from inside the recorded element) will still give the user no results. And this is not just for teasing--often the author taken from another data source would be transcribed differently in 245 $c (like omitting 'by' for instance). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 21:19:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 19:19:23 +0000 Subject: [Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response In-Reply-To: <bug-20517-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20517-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20517-70-Apwp6Zg8Hd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 21:26:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 19:26:38 +0000 Subject: [Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results In-Reply-To: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28884-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28884-70-4IZ9VBsaXn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- I am not against the concept of auto-escaping the question mark, however, I do think it needs to be controlled by a syspref. Possibly with different options for staff and opac. The code and the preference description also need to be clear about what they are doing - silently escaping '?' in the code that handles regex searching is confusing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 21:27:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 19:27:56 +0000 Subject: [Koha-bugs] [Bug 33488] Branch transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-3YDp8wqC7A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149912|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149913&action=edit Bug 33488: Add fromBranch index to branch_transfer_limits To test: 1 - Enable UseBranchTransferLimits by item type 2 - Set some limits for book 3 - Place a hold, verify that pikcup dropdown reflects the limits before and after patch Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 21:39:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 19:39:34 +0000 Subject: [Koha-bugs] [Bug 26247] Search terms retained in header search creates UX inconsistency In-Reply-To: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26247-70-Edii7ZRLFw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26247 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 22:22:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 20:22:56 +0000 Subject: [Koha-bugs] [Bug 24221] Convert OPACMySummaryNote system preference to news block In-Reply-To: <bug-24221-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24221-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24221-70-DojDo4oO5O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24221 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 22:23:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 20:23:08 +0000 Subject: [Koha-bugs] [Bug 24220] Convert OpacMoreSearches system preference to news block In-Reply-To: <bug-24220-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24220-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24220-70-mSOqej8hZN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24220 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 22:23:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 20:23:22 +0000 Subject: [Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language In-Reply-To: <bug-29144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29144-70-RqEh6JWfMj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 22:49:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 20:49:32 +0000 Subject: [Koha-bugs] [Bug 32423] Allow guarantor to renew guarantee's checkouts In-Reply-To: <bug-32423-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32423-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32423-70-XG52etXyMs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32423 Jason Robb <jrobb at sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 19 23:10:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 21:10:15 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15348-70-nlbha0Lx7I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 00:31:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Apr 2023 22:31:36 +0000 Subject: [Koha-bugs] [Bug 12141] On Display Module In-Reply-To: <bug-12141-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12141-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12141-70-n8uaLE7BjS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12141 Meg Flynn <meg at moablibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |meg at moablibrary.org --- Comment #21 from Meg Flynn <meg at moablibrary.org> --- Our library would LOVE this and would also use it daily! I agree with Rebecca, that the feature will be most helpful if there's the ability to auto-remove the "display" designation via check-out or check-in actions, so that the item is converted back to it's original shelving location upon check-out/in. There is currently no way for our Circ staff to know if an item was previously on display because they are using third party RFID software for check-ins. We've created a negative Not for Loan authorized value to indicate when items are on display because the status can be auto-updated (removed) at the time of check-in. But it's not a good work around (pretty problematic actually) to use a Not for Loan status for display workflows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 06:14:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 04:14:27 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-v3U93FQVj1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149785|0 |1 is obsolete| | Attachment #149786|0 |1 is obsolete| | Attachment #149787|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149914&action=edit Bug 33478: Add formatting columns to letter table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 06:14:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 04:14:30 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-Td1Ta2RWcj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149915&action=edit Bug 33478: Add format_notices user permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 06:14:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 04:14:32 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-yt8nmXrQ0b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #7 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149916&action=edit Bug 33478: Save notice format settings For an individual notice, or for all notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 06:14:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 04:14:35 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-lac2L2yxXm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #8 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149917&action=edit Bug 33478: [WIP] Apply formatting to printed notices Does not yet apply to all notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 06:14:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 04:14:37 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-SG8DeiHLED@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #9 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149918&action=edit Bug 33478: Schema updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 07:33:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 05:33:29 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-WnTIv1SNwd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to David Nind from comment #7) > Signed-off-by: David Nind <david at davidnind.com> Thx David. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 08:17:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 06:17:25 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-czPMG0E5sz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 08:17:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 06:17:28 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-8OqirUfNww@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149919&action=edit Bug 30352: Allow translation of Not for loan in OPAC XSLT results Note: Test plan below can be followed in English. If you would like to see the vernacular results, you need to update PO files and translate 'Not for loan', and update templates (xslt files) accordingly. The bootstrap PO does not yet include that string without %s suffix in the current codebase. Test plan: [1] Apply this patch and make the following change in MARC21slim2OPACResults.xsl, line 1207. Change: <status english="Not for loan">Not for loan</status> to: <status english="Not for loan">NOT for loan</status> Important: Change text inside, not the attribute! Restart all. [2] Pick a biblio, add some items with different statuses: Checked out, Damaged, Not for loan, Staff collection. [3] Make it appear in a OPAC results display (not detail). [4] You should see the different statuses, including NOT for loan. The uppercase NOT serves to prove that the string has been translated. Also verify that you see Staff collection as-is. [5] Bonus: Toggle with values in Reference_NFL_Statuses to move results from Reference section to Not available section v.v. [6] Revert the change from step 1. Sign off :) Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 08:17:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 06:17:30 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-0bs3nLDB0L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149920&action=edit Bug 30352: Add a comment to the substatus translation The tric of combining the XPath union operator (|) with the value-of instruction works as a sort of ternary operation. The value-of only picks the string value of the first node from the union in document order. So, if there is a translation, it will be the first node. If there is no translation, the original substatus will be used. Note that there will be no translation for authorised values like Staff collection, etc. Test plan: None. Just comments. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 08:44:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 06:44:56 +0000 Subject: [Koha-bugs] [Bug 33567] New: Remove fallback for Reference_NFL_statuses in C4/XSLT module Message-ID: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 Bug ID: 33567 Summary: Remove fallback for Reference_NFL_statuses in C4/XSLT module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org C4/XSLT contains this line: my $ref_status = C4::Context->preference('Reference_NFL_Statuses') || '1|2'; This is a kind of undocumented fallback (that I introduced myself). We should either add this to the pref text or just do what is kind of intuitively expected: if the pref is empty, move all items to Not available. Note that the installer creates the pref by default with 1|2. So this might be a quite theoretical change for most. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 08:45:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 06:45:06 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-xwVPrqkhAn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 08:46:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 06:46:18 +0000 Subject: [Koha-bugs] [Bug 33568] New: Use the REST API to display items on the biblio detail view Message-ID: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Bug ID: 33568 Summary: Use the REST API to display items on the biblio detail view Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It will fix performance issues to use our REST API route /biblios/XXX/items to display the items table on the bibliographic record detail view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 08:46:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 06:46:43 +0000 Subject: [Koha-bugs] [Bug 23024] Limit number of items displayed on detail pages in staff (MaxItemsToDisplay) In-Reply-To: <bug-23024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23024-70-RK6o81XqwD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23024 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |jonathan.druart+koha at gmail. | |com Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This will be fixed by bug 33568. *** This bug has been marked as a duplicate of bug 33568 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 08:46:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 06:46:43 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-2wFNdpNnjT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |b.pastern4k at gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- *** Bug 23024 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 08:58:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 06:58:19 +0000 Subject: [Koha-bugs] [Bug 33569] New: Order by relevance many not be visible Message-ID: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 Bug ID: 33569 Summary: Order by relevance many not be visible Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org When ordering catalog search by relevance from advanced search, this is not visible in sort order combobox in staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 08:58:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 06:58:26 +0000 Subject: [Koha-bugs] [Bug 33569] Order by relevance many not be visible In-Reply-To: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33569-70-8vEKTKEtRu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 09:00:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 07:00:01 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-nsHDeONlFP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30352 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 09:00:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 07:00:01 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-2sSfhc4IhH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33567 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 09:03:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 07:03:46 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-CFOPpYzZGt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 09:03:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 07:03:48 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-LQPhqMnSTS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149921&action=edit Bug 33567: Empty NFL_statuses pref in unit test This test should fail now, since it would trigger the hardcoded fallback in the XSLT module. Test plan: Run t/db_dependent/XSLT.t Should fail. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 09:03:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 07:03:50 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-bNZjiKSwz7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149922&action=edit Bug 33567: Remove hardcoded fallback in module Test plan: Run t/db_dependent/XSLT.t again Should pass now. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 09:03:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 07:03:52 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-JBWSZ5wD2K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149923&action=edit Bug 33567: Add a dbrev for installation with empty pref To keep current behavior, we can copy the removed fallback into the syspref value in case someone might have cleared the pref. Note: We are not restoring deleted prefs here; that is a data problem outside the scope of this report. A regular installation should always have this pref. Test plan: Run updatedatabase.pl Bonus: Clear the pref Reference_NFL_Statuses and run again, verify that the pref has changed. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 09:04:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 07:04:11 +0000 Subject: [Koha-bugs] [Bug 33567] Remove fallback for Reference_NFL_statuses in C4/XSLT module In-Reply-To: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33567-70-soLre6kAqE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33567 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Architectural/trivial: self SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 09:19:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 07:19:43 +0000 Subject: [Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments In-Reply-To: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29145-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29145-70-ST1Da3ghq0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 10:20:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 08:20:30 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at branch level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-380gGn6td8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 10:20:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 08:20:48 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-mVwjQ1Yy4W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I've got a patch for the AJAX datatables now, and I'm working through making it all configurable through the table settings page. I'll need a hand working through the Vue table component, but I don't imagine it'll be too honerous. I'll throw the patches up as soon as I've got the configuration patch working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 10:33:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 08:33:20 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-cjlbTdcOok@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |lucas at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |oleonard at myacpl.org, | |pedro.amorim at ptfs-europe.co | |m, tomascohen at gmail.com Depends on| |33037, 33497 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I've pushed a remote branch as WIP/POC, see https://gitlab.com/joubu/Koha/-/commits/bug_33568 This is really awesome, please have a look! I let the git history to show how I made the changes, step by step. But we could decide to squash later if needed. There is still a lot of work to be done, and I would like to make sure I won't be alone on this one before spending more time on it. I think we really to do this move, it will help people with lot of items attached to a single biblio. I am expecting support with: * early code review (now, it's ready for that) * answer the FIXMEs (in git log and code), can be done inline in gitlab? * help with the remaining work * testing session (it will need to be fully tested before we push it) * keeping in mind that this is on its way and we should not work/push big changes to this script/template (!) It's either a candidate for an early push to 23.11, and a couple of you are with me, or I drop it now (read that I am not going to rebase it if the conflicts are getting tricky). Let me know what you think about it and if you are willing (and how) to help me here. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 [Bug 33497] Reduce DB calls on staff detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 10:33:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 08:33:20 +0000 Subject: [Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) In-Reply-To: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33037-70-61HCmHAVwp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 10:33:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 08:33:20 +0000 Subject: [Koha-bugs] [Bug 33497] Reduce DB calls on staff detail page In-Reply-To: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33497-70-AYKji9S51B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 10:41:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 08:41:21 +0000 Subject: [Koha-bugs] [Bug 33063] Duplicated reports should maintain subgroup of original In-Reply-To: <bug-33063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33063-70-YTfxCsZafK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33063 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.04,22.05.12 |23.05.00,22.11.04,22.05.12, released in| |21.11.20 --- Comment #11 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 10:59:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 08:59:53 +0000 Subject: [Koha-bugs] [Bug 32519] In Elasticsearch mappings table use search field name In-Reply-To: <bug-32519-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32519-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32519-70-DSjR10Jm0C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32519 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.04,22.05.12 |23.05.00,22.11.04,22.05.12, released in| |21.11.20 --- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 11:12:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 09:12:12 +0000 Subject: [Koha-bugs] [Bug 33211] Fix failing test for basic_workflow.t when adding item In-Reply-To: <bug-33211-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33211-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33211-70-T9nDBRy3k2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33211 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.04,22.05.12 |23.05.00,22.11.04,22.05.12, released in| |21.11.20 --- Comment #6 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 11:16:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 09:16:13 +0000 Subject: [Koha-bugs] [Bug 33144] Authority lookup in advanced editor overencodes HTML In-Reply-To: <bug-33144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33144-70-PUCgXGLHf4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33144 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com Version(s)|23.05.00,22.11.04,22.05.12 |23.05.00,22.11.04,22.05.12, released in| |21.11.20 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 11:17:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 09:17:36 +0000 Subject: [Koha-bugs] [Bug 33150] Add specific message for renewal too_soon situation In-Reply-To: <bug-33150-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33150-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33150-70-M5Z64uKGfc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04,22.05.12 |23.05.00,22.11.04,22.05.12, released in| |21.11.20 CC| |arthur.suzuki at biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 11:18:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 09:18:38 +0000 Subject: [Koha-bugs] [Bug 33183] Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6 In-Reply-To: <bug-33183-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33183-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33183-70-v8nUP0JJyu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33183 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04,22.05.12 |23.05.00,22.11.04,22.05.12, released in| |21.11.20 CC| |arthur.suzuki at biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #9 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- applied to 21.11.x for 21.11.20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 11:25:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 09:25:40 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-QhgVRMoXwO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #11 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 149924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149924&action=edit comparison Top picture is the header in agreements list before the patch, bottom picture is after the patch. This CSS in this patch is being applied in agreements list unintentionally. .filters input[type="checkbox"] { margin-left: 0 !important; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:25:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:25:27 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-fuk09fJtOf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149447|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149925&action=edit Bug 33484: Make saveState column handling global This patch updates the handling for saveState added in bug 22276 to work globally for all KohaTables that pass a table_settings hash. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:25:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:25:30 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-NjbF2NTEZo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149448|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149926&action=edit Bug 33484: Revert template change introduced in bug 22276 With the globalisation of the stateSave handling introduced by bug 22276 we can remove the localised changes to the template in branches.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:25:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:25:33 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-vwXhLEXE5D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149449|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149927&action=edit Bug 33484: Revert template change on suggestion.tt This reverts commit 2b0693dbfd6aa2dd2c7c91428b23aba717ccc0af as it's no longer required once we globalise the logic as we do in this patchset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:25:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:25:36 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-05iuAe7rNt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149928&action=edit Bug 33484: Add support to kohaTable (AJAX Tables) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:25:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:25:39 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-OvwtSp8xWd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149929&action=edit Bug 33484: Add save state option to table settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:25:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:25:41 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-FVnxLf7sDI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149930&action=edit Bug 33484: Schema Update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:26:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:26:06 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-SFMDlaANAa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:31:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:31:19 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-GpkKCyZAVS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- OK.. we now have this applying to KohaTable and kohaTable components (<KohaTable isn't yet covered). We also have the requested switches so one can enable/disable the filter state saving from the admin table settings page. Feel free to test and give feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:31:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:31:53 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-PzrNVNpNJf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- PS, you'll need to run the DB update ;P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:37:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:37:43 +0000 Subject: [Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues In-Reply-To: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33491-70-1bZOcM9HMi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:40:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:40:42 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-nvr1o8m1zV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Just checking with Nick whether we need any index changes for ES to work with this too.. otherwise I'm happy to PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:47:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:47:42 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-6zholMpBP7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148673|0 |1 is obsolete| | --- Comment #499 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149931&action=edit Bug 31028: (follow-up) Unify table creation This patch updates kohastructure to use the same syntax we use everywhere else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:48:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:48:06 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-58MKS7hPMr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:48:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:48:51 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-LVM4KDFQN2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 --- Comment #500 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I think it's just the very last patch thats still outstanding on master.. it's just a tidy up so not 100% required, but a nice to have for consistency in our kohastructure file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 12:50:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 10:50:16 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-cIHcXQXgQQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Yes, sorry.. I've just not had a moment to breath yet.. This is certainly still near the top of my list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:03:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:03:59 +0000 Subject: [Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls In-Reply-To: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32932-70-buhNm9gwnV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:09:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:09:41 +0000 Subject: [Koha-bugs] [Bug 33501] Cashup amount should be configurable In-Reply-To: <bug-33501-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33501-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33501-70-3qmjLlkTRG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33501 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is where 'credit type' and 'payment/transaction type' differ... credit types are configurable, but transaction types aren't at this time.. most places you select the payment/transaction type at transaction time.. is there's somewhere missing this and could you not select 'Cheque' for 'Credit type' with 'Cash' as transaction type? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:10:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:10:58 +0000 Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit In-Reply-To: <bug-32556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32556-70-FFXc4BufzA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 --- Comment #9 from Hans PĂ„lsson <hans.palsson at hkr.se> --- We ran into this problem again recently on our test server (22.05). It seems it is not a problem for most libraries I guess, because then the issue would have been solved. But we use a cronjob to set message preferences for all users which probably leads to a large number of autoincrements that eventually fills the table. A possible solution for us would be to set the patron message preferences when creating patrons with the API. Is this possible with the API now? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:13:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:13:54 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-eEQksWlgGf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Katrin Fischer from comment #1) > I wanted to have a look at this, but bug 31028 needs a rebase. Adding Martin. It's because 31028 is pretty much all pushed.. you don't need to apply it.. it's in master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:26:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:26:21 +0000 Subject: [Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls In-Reply-To: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32932-70-RTj99H5lfU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #36 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Needs another rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:26:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:26:22 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-0K5l6Yx47s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149903|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149932&action=edit Bug 29691: Use template to display news on opac homepage This patch moves the fetching of news to the template and adds a p[lugin method to get news by id TO test: 1 - Define some general and library specific news items 2 - Define in various languages 3 - Define some 'Additional contents' as well 4 - Apply patch 5 - Confirm onlly 'all libraries' news show if not loigged in to opac 6 - Confirm correct library news show when logged in 7 - View specific news items: http://localhost:8080/cgi-bin/koha/opac-main.pl?news_id=12 8 - Confirm that non-existent ids show " This news item does not exist. " 9 - Confirm if you enter ID for additional contents you get 'does not exist' Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:26:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:26:24 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-Saw4un9G6O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149904|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149933&action=edit Bug 29691: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:26:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:26:44 +0000 Subject: [Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls In-Reply-To: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32932-70-qy7Hu2UIDd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149709|0 |1 is obsolete| | --- Comment #37 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149934&action=edit Bug 32932: Update router to use object references - agreements This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings Signed-off-by: Agustin Moyano <agustinmoyano at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:27:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:27:14 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display opac news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-o4ubmD1zir@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- All working as described, thanks Nick. Signing off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:27:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:27:17 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33568-70-gzFSBO0DzB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:30:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:30:22 +0000 Subject: [Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls In-Reply-To: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32932-70-tyZ2YoNPhL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149934|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149935&action=edit Bug 32932: Update router to use object references - agreements This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings Signed-off-by: Agustin Moyano <agustinmoyano at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:32:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:32:57 +0000 Subject: [Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls In-Reply-To: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32932-70-xaqDCJNl4u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Functionality all tests out good, QA scripts are happy :) Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:33:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:33:01 +0000 Subject: [Koha-bugs] [Bug 32932] Re-structure Vue router-links to use "name" instead of urls In-Reply-To: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32932-70-rusaJsmKGF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:51:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:51:25 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-vgEAP4rd5W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 13:53:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 11:53:21 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-cHixqEW82T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #2) > It seems we keep running into this kind of issue in some variations. This is why I add a test here, to prevent future breakage > Actually, I am also confused: > When do we want to update the permanent item location and when do we not? If it is visible in the form, but has no value then we want to preserve the original value and not set it to location > My impression was that whenever the location is updated and the value is not > CART or PROC, the we'd also like to make the permanent location match. It's > been moved to a new location, so if it was checked out/checked in, set to > CART, it should be able to go back to the new location. This was the case originally, however, it became possible to add both to the editors and set individual values. > But now it feels a bit like we might have different uses of the field > depending on configuration maybe? And if we do... should we do that? And if > so, is this documented somewhere? It may not be documented, but it has become a fairly common practice. I think we should document and support it. > Do we expect people to always set both manually if they are linked to MARC > fields? What if $k was set to hidden in the item form? If mapped and hidden, then it operates where a location update always updates both. If exposed in the form, i.e. we receive a value in the scripts, then we need to assess if the value is blank and preserve pre-edited value rather than matching to location -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:10:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:10:24 +0000 Subject: [Koha-bugs] [Bug 33570] New: Reprinting holds slip with updated expiration date - in patron account Message-ID: <bug-33570-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33570 Bug ID: 33570 Summary: Reprinting holds slip with updated expiration date - in patron account Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: sally.healey at cheshiresharedservices.gov.uk QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 29338 introduced the ability to reprint a hold slip from request.tt One of our workflows is: - Patron receives hold e-mail, which is sent from a back office e-mail address - They reply to e-mail to request a change to the collection date - The back office changes the date - The back office tells the library staff to update the slip in the book Bug 29338 helps because the slip can be reprinted. But it's only available on the item record - and there can be 200+ holds on a record. This makes it tricky for the staff to pick out which slip to reprint. It would be useful if the reprint hold button could also be included in the patron account - in the holds tab found on circulation.pl and moremember.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:10:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:10:35 +0000 Subject: [Koha-bugs] [Bug 33570] Reprinting holds slip with updated expiration date - in patron account In-Reply-To: <bug-33570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33570-70-Psw0yRUf4G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33570 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29338 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:10:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:10:35 +0000 Subject: [Koha-bugs] [Bug 29338] Reprinting holds slip with updated expiration date In-Reply-To: <bug-29338-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29338-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29338-70-yKlfFMmSx6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29338 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33570 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:15:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:15:23 +0000 Subject: [Koha-bugs] [Bug 25631] Adding ability to alter the expiration date of the hold from the patron's account in staff In-Reply-To: <bug-25631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25631-70-4UszcyJCjl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25631 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:19:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:19:18 +0000 Subject: [Koha-bugs] [Bug 25631] Adding ability to alter the expiration date of the hold from the patron's account in staff In-Reply-To: <bug-25631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25631-70-HhkKh0FG7M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25631 --- Comment #2 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- +1 This would be really useful. When Bug 8030 introduced changing pickup location from the patron record, it really sped things up for the staff. I think this would have a similar impact on front line staff. This development would also tie in nicely with Bug 33570 - the ability to then print the updated slip from the patron record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:19:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:19:26 +0000 Subject: [Koha-bugs] [Bug 25631] Adding ability to alter the expiration date of the hold from the patron's account in staff In-Reply-To: <bug-25631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25631-70-0yAxrEboND@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25631 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33570 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:19:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:19:26 +0000 Subject: [Koha-bugs] [Bug 33570] Reprinting holds slip with updated expiration date - in patron account In-Reply-To: <bug-33570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33570-70-t8XpkgMQfg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33570 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25631 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:28:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:28:08 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33417-70-9aRbnah7jn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149193|0 |1 is obsolete| | --- Comment #15 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149936&action=edit Bug 33417: Create standard toolbar component This commit introduces a standard Toolbar component that can be used throughout ERM Test plan: 1) Apply patch 2) Navigate to Agreements and click the "Add agreement" button - this should work as normal 3) Navigate to Licenses and repeat 4) Navigate to Local packages and repeat 5) Navigate to local titles - there should be two buttons, one to add and one to import. These should work as normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:28:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:28:11 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33417-70-nrQY2OZkx9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149194|0 |1 is obsolete| | --- Comment #16 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149937&action=edit Bug 33417: Add toolbar imports and options This commit amends the required files to import the toolbar and add the correct options Test plan as above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:28:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:28:13 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33417-70-9tsJcW9qCH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149195|0 |1 is obsolete| | --- Comment #17 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149938&action=edit Bug 33417: Remove old components This commit deletes the old toolbar components as they are no longer necessary Test plan as above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:28:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:28:15 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33417-70-iVE6g5a6ea@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149229|0 |1 is obsolete| | --- Comment #18 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 149939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149939&action=edit Bug 33417: Fix translation in toolbar This commit allows the string to be translated - tested using fr-FR and a dummy string in the .po file Test plan as above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:31:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:31:00 +0000 Subject: [Koha-bugs] [Bug 31981] Need to be able to more clearly distinguish between hold warning boxes In-Reply-To: <bug-31981-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31981-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31981-70-E4Y7Td20GX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31981 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:35:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:35:43 +0000 Subject: [Koha-bugs] [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 In-Reply-To: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33566-70-6HfQhogNwT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:35:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:35:45 +0000 Subject: [Koha-bugs] [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 In-Reply-To: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33566-70-wPLpcRlMbB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149940&action=edit Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Batch extend due dates - Access files (it is not necessary to have file access configured to test, there are no variations to the breadcrumbs) - News, HTML customizations, and Pages: For each category check each variation: - List of entries - New entry - Edit entry - Cataloging -> - Batch record deletion - Item modifications by age - Edit rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:44:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:44:14 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-KKeAnpNnsi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:44:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:44:18 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-97TN7VoKPA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132546|0 |1 is obsolete| | Attachment #132562|0 |1 is obsolete| | Attachment #132563|0 |1 is obsolete| | Attachment #132564|0 |1 is obsolete| | Attachment #132565|0 |1 is obsolete| | Attachment #132566|0 |1 is obsolete| | Attachment #132567|0 |1 is obsolete| | Attachment #132568|0 |1 is obsolete| | Attachment #132569|0 |1 is obsolete| | Attachment #132570|0 |1 is obsolete| | Attachment #132571|0 |1 is obsolete| | Attachment #132572|0 |1 is obsolete| | Attachment #132573|0 |1 is obsolete| | Attachment #132574|0 |1 is obsolete| | Attachment #132575|0 |1 is obsolete| | --- Comment #87 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149941&action=edit Bug 24975: Refactor database translations This is an attempt to make the process of translating database strings (like itemtype descriptions) easier for developers and translators. For developers by reducing the amount of code needed to enable translations for a new kind of object (authorised values, letters, news, ...). For translators by providing a single entry point for all translatable strings Table `localization` is replaced by two new tables `l10n_source` and `l10n_target`. `l10n_source` contains the original text while `l10n_target` contains the corresponding translations `l10n_source` is automatically updated whenever an itemtype is inserted, updated, or deleted, so it is always up to date (this is done in Koha::Schema::Result::ItemType). It means that if you delete an itemtype, translations get deleted too. It also means that if you change an itemtype's description, translations are lost (not sure if this should be fixed, since if description changes, translations should probably be changed too) It adds a new subroutine in Koha::I18N, `db_t`, which returns the translation for a given context and string, according to the current language. Translations are stored in memcached (if enabled). So instead of having to declare a new subroutine Koha::ItemType::translated_description, you can write db_t('itemtype', $itemtype->description) In templates you can write [% ItemTypes.t(itemtype.description) %] There's also a new page, accessible from the administration main page, "Localization". It displays all translatable strings and allow to translate them for all enabled languages. Test plan: 1. Before applying the patch, make sure you have translated some itemtypes. Translations should be kept by the updatedatabase script. Before applying the updatedatabase you may want to comment the 'DROP TABLE localization' statement if you want to keep this table 2. Apply patch, run updatedatabase.pl, run update_dbix_class_files.pl and reload starman 3. Go to Admin » Localization, verify that you have your itemtypes and their translations. 4. Verify that the filter is working (it filters on the source column only). 5. Translate some strings by clicking on one of the 'Translate' link, entering some text and clicking on the 'Save' button. You can remove a translation by emptying the text box. 6. Add a new item type. Verify that it appears in the Localization page 7. Change the description of this item type. Verify that the new description appears in Localization page and that the old description is gone 8. Delete this item type and verify that its description no longer appears in Localization page 9. Navigate through Koha (intranet and opac) in multiple languages and verify that item types are translated (if not, please verify in master too, not all occurrences were translated) Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:44:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:44:22 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-9h3adNKoH5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #88 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149942&action=edit Bug 24975: Keep the translations, prevent duplicates, and other fixes Translations are no longer lost when you change an itemtype's description, thanks to a new `l10n_source.key` column which must be unique within it's "text group" ('itemtype' is a text group) This also prevent duplicate entries in l10n_source Columns were renamed to better match their purpose: * context -> group * source -> text Use Koha::Cache::Memory::Lite if other caching systems are not available Prepend 'l10n:' to the cache key to avoid conflicts Test plan: 1. DROP TABLE IF EXISTS l10n_target, l10n_source 2. Follow the test plan from previous patch Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:44:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:44:26 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-uOono4nkjO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #89 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149943&action=edit Bug 24975: Fix l10n_source definition in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:44:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:44:29 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-05QlgC1PUI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #90 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149944&action=edit Bug 24975: Fix syntax issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:44:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:44:33 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-Kw3a7pnhaD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #91 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149945&action=edit Bug 24975: (follow-up) Rebase for bug 21946 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:44:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:44:37 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-MNjDkHLhyr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #92 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149946&action=edit Bug 24975: Use 'key' for translation lookup This patch switches from using the original text as a key for translations to using a dedicated 'key' field. We also add in a 'fuzzy' flag to denote when the source text has changed and as such the pre-existing translations may be incorrect. ToDo: 1/ Expose 'Fuzzy' on the 'Localization' admin page 2/ Add a 'translation_key' method to Koha::Itemtype to encourage the adoption of a standardly names accessor to get the 'translation_key' from a Koha::Object derived class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:44:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:44:40 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-OvDq2ziIXz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #93 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149947&action=edit Bug 24975: Re-introduce translated_description accessor method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:44:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:44:44 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-VaCX83GVzy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #94 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149948&action=edit Bug 24975: Add translation_key method example -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:44:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:44:47 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-d4RS8xmftb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #95 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149949&action=edit Bug 24975: Use translation_key in preference to description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:44:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:44:51 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-MK1hgHwSaj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #96 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149950&action=edit Bug 24975: Add to Koha::UI::Form::Builder::Item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:44:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:44:54 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-upfEdEO0dL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #97 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149951&action=edit Bug 24975: Fix bugs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:44:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:44:58 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-SnAbCO1g5b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #98 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149952&action=edit Bug 24975: DBIC Build -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:45:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:45:01 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-X2jnz3jsmd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #99 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149953&action=edit Bug 24975: Fix db_t The query here is difficult.. I wanted to return FULL LEFT JOIN, but filtering on the joined data (l10n_targets.language) means we drop the l10n_source rows where there are no corresponding l10n_targets with language code. I tried setting `l10n_targets.language => [ $language, undef ]` to include null values, but that doesn't work either. I then tried coming up with a correlate subquery instead of the join and couldn't get dbic to play nicely there either. As such, I've fallen back to multiple queries over the relationship.. I'm sure we can do better... but this works for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:45:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:45:05 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-6p8lZcJBxR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #100 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149954&action=edit Bug 24975: Some more fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:45:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:45:47 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-Nki9IWzHb4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|julian.maurice at biblibre.com |jonathan.druart+koha at gmail. | |com --- Comment #101 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Patches rebased, not without troubles... IMO there are inconsistencies in the way we deal with itemtypes, and we should correct that in this patch set. We should always either call db_t in the script and pass the translated version to the template, or pass the object and let the template deals with it. Ready for testing (spoiler: it is full of bugs). Remote branch pushed to https://gitlab.com/joubu/Koha/-/commits/bug_24975 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:46:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:46:29 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-DbSCqQzytz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #102 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- If this has not moved forward in 2 months I won't be back to it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:49:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:49:28 +0000 Subject: [Koha-bugs] [Bug 24977] Enable translations for authorised values (POC) In-Reply-To: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24977-70-YHneXySUXs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101798|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149955&action=edit Bug 24977: Enable translations for authorised values (POC) Only a proof of concept to illustrate what's needed to enable translation for a new kind of object. Only authorised values retrieved with Koha::AuthorisedValues->get_descriptions_by_koha_field and Koha::AuthorisedValues->get_description_by_koha_field are translated. This is used for instance for shelving locations in catalogue/itemsearch.pl Test plan: 1. Run updatedatabase && update_dbix_class_files && reload starman 2. Go to Admin » Localization 3. Find a LOC authorised value and translate it 4. Go to Item search form and verify that it is translated 4. Verify that it is translated in results too Requires bug 24975 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:50:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:50:03 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-4B3fpaEUYY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Should I still put the 'depends on' when it's pushed? I just wanted to alert the people who worked on 31028 of related bugs that I found while documenting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:54:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:54:39 +0000 Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21357-70-exWH10ND6B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop at gmail.com --- Comment #73 from Janusz Kaczmarek <januszop at gmail.com> --- It is a pity that after almost five years this issue is still not solved ;) I take the opportunity to add some initial elisions from an Italian/international catalogue -- because the problem is not really French-specific: dell' o' nell' dall' all' un' sull' sant' ch' --to list only the most common. BTW, the problem of apostrophe is not only the problem of the initial elisions--also the saxon genetive creates problems: looking for "Shakespeare's" with "Shakespeare" will give no results unless QueryAutoTruncate is on. So maybe in analyzer_standard, as a third filter the apostrophe filter should be used as well? (which probably would also have some drawbacks...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 14:59:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 12:59:25 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-YFTCGh5gAJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #103 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 149956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149956&action=edit Bug 24975: (follow-up) Fix dbrev -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:04:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:04:44 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-apVnUy8Uzh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #104 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- DataTables warning: table id=localization - Ajax error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:06:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:06:24 +0000 Subject: [Koha-bugs] [Bug 33571] New: Use template wrapper for breadcrumbs: Tools, part 2 Message-ID: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33571 Bug ID: 33571 Summary: Use template wrapper for breadcrumbs: Tools, part 2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more tools templates so that they use the new template wrapper for breadcrumbs. - tools/batch_record_modification.tt - tools/batchMod-del.tt - tools/batchMod-edit.tt - tools/batchMod.tt - tools/cleanborrowers.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:06:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:06:24 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32507-70-LeAErs6osH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33571 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33571 [Bug 33571] Use template wrapper for breadcrumbs: Tools, part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:08:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:08:03 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-yoGtYLtDNI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #105 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 149957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149957&action=edit Bug 24975: WIP remove db_t from controllers This is not done yet, for discussion. I don't think we should call db_t in controllers, or we do it better, but now it's confusing. This patch may impact performances, as we are not caching the itemtype object. Ideas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:09:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:09:13 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-Ih16hREY8N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #106 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- An error occurred : Inconsistent hierarchy during C3 merge of class 'Koha::I18N': current merge results [ Koha::I18N, ] merging failed on 'Exporter' at /app/qatools/koha-qa.pl line 112. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:17:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:17:40 +0000 Subject: [Koha-bugs] [Bug 30274] Non-reservable items should only fill item-level reserves In-Reply-To: <bug-30274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30274-70-KdwxyHftqQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Sharon Dugdale <sharon.dugdale at cumbria.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sharon.dugdale at cumbria.gov. | |uk --- Comment #1 from Sharon Dugdale <sharon.dugdale at cumbria.gov.uk> --- We have just noticed this is happening when a non-reservable item is checked in - KOHA is saying that it is available to satisfy a request. We have two library services (Public Libraries and Schools Library Service) using the same system and catalogue, though the stock is NOT inter-changeable and the school stock is shadowed on the OPAC. On occasion school stock is returned to a public library by mistake and when these items are checked in, if a request is pending, KOHA makes it available to satisfy it. The Schools Service does NOT use a request function on KOHA so it would be up to the Public Library staff to identify these errors and ensure these items are NOT trapped for holds. Within the Public Libraries, we also have unreservable and OPAC shadowed stock which may also be affected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:24:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:24:02 +0000 Subject: [Koha-bugs] [Bug 33571] Use template wrapper for breadcrumbs: Tools, part 2 In-Reply-To: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33571-70-RP4rLJpCHd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33571 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:24:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:24:04 +0000 Subject: [Koha-bugs] [Bug 33571] Use template wrapper for breadcrumbs: Tools, part 2 In-Reply-To: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33571-70-DFUfVpp0Py@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33571 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 149958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149958&action=edit Bug 33571: Use template wrapper for breadcrumbs: Tools, part 2 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Batch patron deletion and anonymization - Confirmation - Results - Cataloging -> - Batch item modification - Batch item deletion - Batch record modification - Results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:24:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:24:18 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-ow2zbO2rzB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149385|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149959&action=edit Bug 29046: Add 'EmailFieldPrecedence' preference This patch adds a new EmailFieldPrecidence systempreference to allow users to set the precicence in which patron email fields should be used for communications. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:24:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:24:21 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-FUjM3AfS3M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149386|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149960&action=edit Bug 29046: Use EmailFieldPrecedence in first_valid_email_address This patch update the Koha::Patron->first_valid_email_address method to use the newly defined EmailFieldPrecedence preference. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:24:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:24:24 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-9rZ4El26oa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149387|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149961&action=edit Bug 29046: Change link in EmailFieldPrecedence and add link in EmailFieldPrimary This patch modifies the link in EmailFieldPrecedence to reflect the new name of EmailFieldPrimary. It also adds a note in the latter to set the 'first valid' order in the former. To test: 1. Go to Administration > Global system preferences 2. Search for EmailFieldPrecedence 3. Click on the link in the description --> It should lead to EmailFieldPrimary 4. Read the note in EmailFieldPrimary, make sure the grammar and spelling are correct. 5. Click the link to EmailFieldPrecedence --> It should lead to EmailFieldPrecedence Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:24:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:24:26 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-F4gZjsaX2Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149962&action=edit Bug 29046: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:24:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:24:29 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-VeYVzuaEm9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149963&action=edit Bug 29046: Reword system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:24:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:24:58 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-tKTbuQ5pt6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:26:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:26:11 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-oCFa1zpCjQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Katrin Fischer from comment #11) > Overall this looks good, but we got one blocker: > > 1) Unit tests are missing. Done > 2) I wonder if we could simplify the system preference description a little: > > Use the following patron email fields in order of highest precedence first > [email|emailpro|B_email] when selecting which email address to use to send > patron notices. > > 2 things: > * I think we should list the valid options in the system preference so that > when one was deleted, it can be restored more easily. > > * I have no idea how to translate highest precedence... but what it means is > that the first field with an email address will be used, right? Maybe we > could phrase it along the lines of: > > When EmailFieldPrimary is set to 'first valid', check the patron email > address fields in the following order and use the first valid email address > found: Done > * Not blocker: For languages we can sort the entries with drag&drop. Could > this be a possible option here? Or maybe I could file as a separate bug? Please do this on another bug... this was meant as a starting point.. I don't have time to polish it any further I'm afraid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:26:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:26:47 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-lUp3ROmq5U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Katrins is fine.. go with it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:28:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:28:16 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-5Ftwmmeg9U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Depends on is good.. it's just that in this case the bug was a bit messy and ended up going backwards in bugzilla states.. as such git bz ignore it as is should. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:30:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:30:15 +0000 Subject: [Koha-bugs] [Bug 33572] New: Use template wrapper for breadcrumbs: Tools, part 3 Message-ID: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33572 Bug ID: 33572 Summary: Use template wrapper for breadcrumbs: Tools, part 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more tools templates so that they use the new template wrapper for breadcrumbs. - tools/csv-profiles.tt - tools/export.tt - tools/holidays.tt - tools/import_borrowers.tt - tools/inventory.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:30:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:30:15 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32507-70-c1YtimsNhG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33572 [Bug 33572] Use template wrapper for breadcrumbs: Tools, part 3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:31:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:31:06 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33417-70-H2XbVrrcPW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149936|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149964&action=edit Bug 33417: Create standard toolbar component This commit introduces a standard Toolbar component that can be used throughout ERM Test plan: 1) Apply patch 2) Navigate to Agreements and click the "Add agreement" button - this should work as normal 3) Navigate to Licenses and repeat 4) Navigate to Local packages and repeat 5) Navigate to local titles - there should be two buttons, one to add and one to import. These should work as normal Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:31:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:31:08 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33417-70-cneai9VD7h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149937|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149965&action=edit Bug 33417: Add toolbar imports and options This commit amends the required files to import the toolbar and add the correct options Test plan as above Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:31:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:31:11 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33417-70-vTr5T4Dx0u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149938|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149966&action=edit Bug 33417: Remove old components This commit deletes the old toolbar components as they are no longer necessary Test plan as above Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:31:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:31:14 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33417-70-m1ZI8ZKijz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149939|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149967&action=edit Bug 33417: Fix translation in toolbar This commit allows the string to be translated - tested using fr-FR and a dummy string in the .po file Test plan as above Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:31:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:31:44 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33417-70-kcyGQqHMhe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- All working as expected and the translations working nicely now.. well spotted Jonathan. I'm happy to signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:40:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:40:29 +0000 Subject: [Koha-bugs] [Bug 33570] Reprinting holds slip with updated expiration date - in patron account In-Reply-To: <bug-33570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33570-70-PbxNWlMozW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33570 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 15:53:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 13:53:59 +0000 Subject: [Koha-bugs] [Bug 23258] Batch holding In-Reply-To: <bug-23258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23258-70-j0KA1HeZy1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Katie Bliss <kebliss at dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 16:22:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 14:22:27 +0000 Subject: [Koha-bugs] [Bug 33573] New: Holds cancellation for waiting holds via the API don't generate a cancellation request Message-ID: <bug-33573-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33573 Bug ID: 33573 Summary: Holds cancellation for waiting holds via the API don't generate a cancellation request Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com DELETE request to /api/v1/holds/{holdkey} simply cancels a waiting hold if that is allowed. It should instead generate a cancellation request We should add a new endpoint: DELETE /api/v1/public/patrons/:patron_id/holds/:hold_id And it should return a 202 accepted response as the actual deletion doesn't happen until the library confirms -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 16:22:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 14:22:39 +0000 Subject: [Koha-bugs] [Bug 33573] Holds cancellation for waiting holds via the API don't generate a cancellation request In-Reply-To: <bug-33573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33573-70-MOpI3qrIZ1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33573 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 16:23:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 14:23:12 +0000 Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21357-70-gLGVZjcDG8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 --- Comment #74 from Janusz Kaczmarek <januszop at gmail.com> --- ... I mean the original apostrophe filter: https://www.elastic.co/guide/en/elasticsearch/reference/8.7/analysis-apostrophe-tokenfilter.html I.e. to have: analyzer_standard: tokenizer: icu_tokenizer filter: - icu_folding - elision - apostrophe So: GET koha_<instance>_biblios/_analyze { "analyzer": "analyzer_standard", "text": "Nell'aria voce di Sant'Antonio e Shakespeare's" } would give: aria voce di antonio e shakespeare which is quite nice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 16:28:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 14:28:54 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-uIIS2u4Pji@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #107 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Will post some more comments tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 17:05:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 15:05:05 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-9aEycQbEAN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Lisette Scheer <lisette.scheer at bywatersolutions.com> --- None of the koha tables show anymore and the console is showing these errors/warnings: caught SyntaxError: Unexpected token '<<' jquery-3.6.0.min_22.1200016.js:2 jQuery.Deferred exception: $(...).kohaTable is not a function TypeError: $(...).kohaTable is not a function at HTMLDocument.<anonymous> (https://staff-save2.sandbox.bywatersolutions.com/cgi-bin/koha/admin/branches.pl:1632:45) at e (https://staff-save2.sandbox.bywatersolutions.com/intranet-tmpl/lib/jquery/jquery-3.6.0.min_22.1200016.js:2:30038) at t (https://staff-save2.sandbox.bywatersolutions.com/intranet-tmpl/lib/jquery/jquery-3.6.0.min_22.1200016.js:2:30340) undefined S.Deferred.exceptionHook @ jquery-3.6.0.min_22.1200016.js:2 jquery-3.6.0.min_22.1200016.js:2 Uncaught TypeError: $(...).kohaTable is not a function at HTMLDocument.<anonymous> (branches.pl:1632:45) at e (jquery-3.6.0.min_22.1200016.js:2:30038) at t (jquery-3.6.0.min_22.1200016.js:2:30340) Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 17:21:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 15:21:46 +0000 Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25870-70-yvsAMA8xXv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 Paul Derscheid <paul.derscheid at lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.derscheid at lmscloud.de |hammat.wele at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 17:25:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 15:25:05 +0000 Subject: [Koha-bugs] [Bug 33574] New: Restriction type is not stored, all restrictions fall back to MANUAL Message-ID: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 Bug ID: 33574 Summary: Restriction type is not stored, all restrictions fall back to MANUAL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, martin.renvoize at ptfs-europe.com The new restriction types are not stored anymore and therefore right now, useless :( More so that creates quite an issue for libraries using it as they can no longer differentiate/report etc. properly. To test: * Activate PatronRestrictionTypes * Add a new restriction type from Administration * Open a patron account and add the new restriction by choosing it from the pull down * Save * Review the saved restriction: it says Manual instead of your restriction type. I the database it's also wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 17:26:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 15:26:12 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-0gmHTh6W29@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 [Bug 23681] Make patron restrictions user definable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 17:26:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 15:26:12 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-1CvthLUCQr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33574 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 17:43:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 15:43:40 +0000 Subject: [Koha-bugs] [Bug 30274] Non-reservable items should only fill item-level reserves In-Reply-To: <bug-30274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30274-70-RhcvGWRvcI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 17:45:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 15:45:32 +0000 Subject: [Koha-bugs] [Bug 33575] New: Add table settings to hold_table on /reserve/request.pl Message-ID: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 Bug ID: 33575 Summary: Add table settings to hold_table on /reserve/request.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Some libraries who have lots of holds on a single bib would like to be able to sort/search/filter that table. We should make it a dataTable with table settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 17:46:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 15:46:23 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-OHVDYV1wOY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149968&action=edit Bug 33447: (follow-up) Fix tests and make assumption explicit The patches made an assumption that patron would always be passed. It is within Koha, but not in the Biblios tests. There is no scenario where we can determine pickup locations that are not in reference to a patron (who is picking it up?) so we should always have this parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 17:55:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 15:55:47 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-3ajYPjQjX3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149969&action=edit Bug 32250: (follow-up) Commit background job to the DB We can't run a background job if it isn't in the database, however, this script runs with AutoCommit disabled. We need to enable it while generating the background job, then disable for the updates. I don't nkow if using a transaction would be preferable. I tried to solve this independently, but it requires consolidating the index requests to make this work easily -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 17:56:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 15:56:01 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-Pva9DWEEZm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 17:56:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 15:56:03 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-qZj3pHQKvH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149970&action=edit Bug 33575: Add dataTable to hold table on /reserve/request.tt To test: 1. Have a record with several holds on it. 2. Go to the holds page for that record ( /cgi-bin/koha/reserve/request.pl?biblionumber=144 ) 3. Cannot sort by columns 4. Apply patch, restart_all 5. Now the table should be a dataTable that will allow you sort. 6. Try hiding columns by clicking on the 'Columns' icon above the table, make sure columns are correctly being hidden. 7. Try to hide columns by going to Adminstration > Table settings ( Circulation > Holds > patron_holds_table ), make sure columns are correctly being hidden. 8. Now login with a user who has the 'place_holds' permission but does NOT have the 'modify_holds_priority' permssion. 9. The table will not have the change priority columns. Make sure all columns can still be hidden/shown correctly for that use. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 17:57:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 15:57:25 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-yir7Dn0bZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:00:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:00:07 +0000 Subject: [Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results In-Reply-To: <bug-20346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20346-70-efcJCXynpU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:02:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:02:03 +0000 Subject: [Koha-bugs] [Bug 33576] New: Records are not indexed when imported if using Elasticsearch Message-ID: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Bug ID: 33576 Summary: Records are not indexed when imported if using Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The importing is done in a transaction. We call the indexer form inside the transaction. This means that when rabbit sends the task, it may not be found in the DB yet. We need to ensure we index after the transaction completes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:05:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:05:13 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-W8XS7rGUwR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:05:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:05:15 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-yDvSEnWOIq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 149971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149971&action=edit Bug 33576: Index records after import transaction is committed This patch simply moves our indexing call after the transaction is committed so that the job will exist in the DB when called. To test: 1 - Have Koha using Elasticsearch 2 - Stage and import a file of records 3 - View the job in Admin->Manage jobs 4 - Note it is not finished 5 - Check log: /var/log/koha/kohadev/es-indexer-output.log 6 - Note: [WARN] No job found for id=### 7 - Apply patch 8 - Stage and import 9 - Note no error in log 10 - Note successful completion of indexing job -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:07:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:07:19 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-7VhmZ3XjPx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23681 |31095 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 [Bug 23681] Make patron restrictions user definable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:07:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:07:19 +0000 Subject: [Koha-bugs] [Bug 23681] Make patron restrictions user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-vmHFoQM1Ic@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33574 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:07:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:07:19 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31095-70-UE1ruD2BbF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33574 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:07:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:07:30 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-aULQs7cKz3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Caused by bug 31095 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:08:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:08:22 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-tk1mPTPqEK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:11:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:11:00 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-FMWnK6qkkJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149972&action=edit Bug 33574: Correct pointer for restrict_type.code Somehow this was missed during QA of bug 31095.. likely during a rebase. Test plan: 1) Check that manual restriction types are now saved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:11:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:11:09 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-KxVy2g1t6F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:11:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:11:18 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-vq6JqKPS8M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:11:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:11:21 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-N6HG0bFKrJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:15:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:15:36 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-5MVnV6hULP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I can't replicate that I'm afraid.. I just freshly applied the bug and it's all working for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:16:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:16:24 +0000 Subject: [Koha-bugs] [Bug 33426] Add client storage of user-selected DataTables configuration to suggestion.tt In-Reply-To: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33426-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33426-70-nsQXXVRAPB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33426 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149446|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149973&action=edit Bug 33426: Add DataTables saveState to suggestion.tt To test: 1. In the staff client, go to Purchase Suggestion management page and add a suggestion if needed to make the table display. 2. Make some changes to the table settings (hide/show columns, change sort column, and/or change number of rows to display) 3. Navigate to a different page. 4. Navigate back to Purchase Suggestions page. Note that the table settings have been reset. 5. Apply patch and restart_all 6. Repeat steps 1-4. Note that this time the changes to the table settings were preserved. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:16:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:16:49 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-CWGjSWCons@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149925|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149974&action=edit Bug 33484: Make saveState column handling global This patch updates the handling for saveState added in bug 22276 to work globally for all KohaTables that pass a table_settings hash. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:16:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:16:52 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-aPmsuw1tzS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149926|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149975&action=edit Bug 33484: Revert template change introduced in bug 22276 With the globalisation of the stateSave handling introduced by bug 22276 we can remove the localised changes to the template in branches.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:16:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:16:55 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-IChrIXnwEo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149927|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149976&action=edit Bug 33484: Revert template change on suggestion.tt This reverts commit 2b0693dbfd6aa2dd2c7c91428b23aba717ccc0af as it's no longer required once we globalise the logic as we do in this patchset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:16:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:16:58 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-otmPiv4Pn8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149928|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149977&action=edit Bug 33484: Add support to kohaTable (AJAX Tables) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:17:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:17:01 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-D8XRkAO61H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149929|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149978&action=edit Bug 33484: Add save state option to table settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:17:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:17:04 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-03td56e5A5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149930|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 149979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149979&action=edit Bug 33484: Schema Update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:17:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:17:59 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-Ub00O24GgU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Re-attached the patches, but nothings changed in them.. The message you report looks like a merge issue, but I can't see any such markers in the patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:33:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:33:00 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-7wuN6fNaPT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #29 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- I can't reproduce the error on KTD either. Lisette, can you give more information about how to reproduce it? I am noticing so far a few other unexpected behaviors so far, though: - Holds to Pull saves the client-side state regardless of the configuration on the admin table settings page - Holds Queue appears to be working correctly for the most part. If you disable state saving from the admin table settings page, the table will continue to save the client-side state for the rest of the session, but will respect the configuration if you start a new session. (I'm not sure if that's an error or if it's the expected behavior.) - memberresultst and branches.pl (both of which use the kohaTable API wrapper rather than the KohaTable wrapper) appear to be working correctly for the most part. However, if the admin table settings hide a column by default, that column stays hidden even when state saving is enabled. Other aspects of client-side state saving (hiding columns that are shown by default, entries per page) work, though. Also, this was the case for branches.pl in master, too, so it wasn't introduced by this patch. I really like where this is going - but I think it's going to need more thorough/systematic testing than what I've done so far to catch any anomalies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:39:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:39:54 +0000 Subject: [Koha-bugs] [Bug 33577] New: Buttons on reserve/request.pl are misaligned Message-ID: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 Bug ID: 33577 Summary: Buttons on reserve/request.pl are misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com While working on Bug 33575 I noticed the Update hold and Cancel hold buttons are not quite the same size. One needs the cancel_selected_holds button needs the Bootstrap 'btn' class. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:44:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:44:02 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-jiASgTzM9d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:44:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:44:04 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-m9Mk0fxvai@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 149980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149980&action=edit Bug 33577: Add btn class to cancel hold button on /reserve/request.pl To test: 1. Place a hold on a record and look at the /reserve/request.pl page. 2. Notice the two buttons 'Update hold(s)' and 'Cancel selected' buttons are not quite the same size. 3. Apply patch and look again, the buttons should line up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:44:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:44:15 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-87eSJWJUL3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:44:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:44:21 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-r18H27ybXx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 18:47:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 16:47:18 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-mpvoNQweF4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 19:03:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 17:03:48 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-poMR3hjwpc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #30 from Lisette Scheer <lisette.scheer at bywatersolutions.com> --- I'm no longer getting that error, but it's still not working. Likely a problem with my KTD. I'll try and sort that out before testing again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 19:30:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 17:30:18 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-xEjKX6gu9V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #13 from AgustĂ­n Moyano <agustinmoyano at theke.io> --- (In reply to Jonathan Druart from comment #6) > Quick code review: > 1. There are several wrong indentations (2 vs 4 spaces) or mismatch > indentation (Koha::REST::V1::ImportSources->get for instance). You should > run perltidy on new perl files Will check that out > 2. DB tables should be plural, import_source*s* (like other tables) Thanks, will rename things as "record source", and will take this into account > 3. (naming) It's not clear what is Koha::ImportSource->patron and > import_source.patron_id, could we find something more meaningful? It is the patron account that is allowed to create records with this source.. I'm not sure what could we call it.. Koha::RecordSource->allowed_patron and record_sources.allowed_patron_id? > 4. Permission check in missing in admin-home.tt > 5. Permission description is missing in includes/permissions.inc Ok, will check both of these things > 6. import-sources.tt > * + const RESTOAuth2ClientCredentials = [% IF > Koha.Preference('RESTOAuth2ClientCredentials') %]true[% ELSE %]false[% END > %]; > not needed? not anymore.. will delete that, thanks > * "erm" occurrences need to be adjusted copy/paste leftovers.. sorry > 7. FormKit/Form => You are introducing a change that is not applied to other > Vue files, and you are changing the UI, it's not consistent with other area > of Koha. I don't think we are ready for that. I believe Formkit or another form library it's a good idea, and we are in a good time, in that we are at the very beginning of using Vue. I believe it can help a lot with the maintainability of the components. For example, if we apply a library that creates forms from a yaml or json definition, theoretically we could be able to reduce ERM components to 4: a Main component, a List component, a Form component and a Show component, and what get's displayed and the actions could be just parameters that are passed or picked up by those components. If your concern is that it's not implemented in other vue files, we can make other bugs to implement them. But if it is about the UI, css classes can always be modified. > 8. In ISEdit.vue, processSubmit. The way we are displaying the message is in > then(). Same for the other AJAX requests in other components. It is implemented in the "then" part.. you see, in Javascript if you are in an async function doing client.agreements.update(agreement, agreement_id).then( success => { setMessage(this.$__("Agreement updated")) this.$router.push({ name: "AgreementsList" }) }, error => { setError(error) } ) Is exactly the same as doing try { const success = await client.agreements.update(agreement, agreement_id) setMessage(this.$__("Agreement updated")) this.$router.push({ name: "AgreementsList" }) } catch(error) { setError(error) } In ISEdit.vue the setMessage is after an "await" statement, so it is in the "then" part. Generally it is recomended to use async/await to improve readability > 9. ISList.vue you should not display an empty table, to be consistent with > other tables. Ok, I'll check that > 10. the routes: you are deciding to change the URL, > admin/import-sources.pl/add > We are not having the '.pl' for other vue pages (which require the apache's > rewriterule, but I think we need to stay consistent) I forgot about this part, and am not sure how to implement this, but definitely will take a look > 11. import-sources.js > You are using add/remove/update/getOne when we use create/delete/update/get > in other fetch files. I cannot use create/delete/update/get because http-client implement those same methods.. one way would be to add a new level like return { record_source: { get: () .... create: () ... update: () ... delete: () ... } } but it's kind of redundant since I don't have many things to fetch as in ERM.. and I would end up calling the actions like record_source.record_source.get() The other way would be to rename the methods in http-client to _create/_delete/_update/_get and there would be no collision in the names > 12. In patron-api-client.js you are using "list" when we use "getAll" in ERM Ups, I did not realize that... "list" seems to me as a more intuitive name for it, but have absolutely no problem in changing the name > 13. About autocomplete, I would not use it. We already have a way to select > patrons (in all the different Koha modules, and the same that we reuse in > ERM). If we want an autocomplete feature I think we should then use select2 > and implement bug 32474. I did not know about that way to select patrons, but it involves using a popup window. I would not recommend that, as it may get blocked by the browser. I will definitely check select2, but as we are using Vue, I would try to minimize as much as possible the use of jQuery and jQuery components. > > > I'd like to add that, as usual, I am not against new ways of doing things, > but we need to apply them first to the existing code, and be consistent. I have no problem implementing new features to the existing code, but I think it better to be done in another bug so things don't get messed up Thanks again for checking this out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 19:30:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 17:30:54 +0000 Subject: [Koha-bugs] [Bug 28658] With SearchMyLibraryFirst if library isn't set for the opac, try to guess it by checking branchip In-Reply-To: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28658-70-Tp7Hb30wTw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28658 koha-US bug tracker <bugzilla at koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 19:44:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 17:44:09 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-foLFEMvhwV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 19:49:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 17:49:11 +0000 Subject: [Koha-bugs] [Bug 30025] Split BiblioAddsAuthorities into 2 preferences In-Reply-To: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30025-70-o2KVRzDqJI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:08:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:08:22 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-7kbuyjyIBp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149968|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:08:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:08:40 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-zfIQECzti7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #18 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 149981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149981&action=edit Bug 33447: (follow-up) Fix tests and make assumption explicit The patches made an assumption that patron would always be passed. It is within Koha, but not in the Biblios tests. There is no scenario where we can determine pickup locations that are not in reference to a patron (who is picking it up?) so we should always have this parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:08:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:08:43 +0000 Subject: [Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations In-Reply-To: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33447-70-VaQq7K7Jw6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447 --- Comment #19 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 149982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149982&action=edit Bug 33447: Make *->pickup_locations methods throw an exception on missing parameter This patch fixes the FIXME for making the methods throw an exception. Tests are added, and POD is adapted as well. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/patrons* \ t/db_dependent/api/v1/holds.t \ t/db_dependent/Reserves* \ t/db_dependent/Hold* \ t/db_dependent/Koha/Hold* \ t/db_dependent/Items* => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:11:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:11:37 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-tzzvJhWlZn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:11:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:11:40 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-JiqySMiBt7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149972|0 |1 is obsolete| | --- Comment #3 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 149983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149983&action=edit Bug 33574: Correct pointer for restrict_type.code Somehow this was missed during QA of bug 31095.. likely during a rebase. Test plan: 1) Check that manual restriction types are now saved. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:12:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:12:04 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-b29fX5ddIt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:23:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:23:03 +0000 Subject: [Koha-bugs] [Bug 20644] Per itemtype setting for CheckPrevCheckout In-Reply-To: <bug-20644-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20644-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20644-70-8uS7gTMoi8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644 --- Comment #2 from hebah at bywatersolutions.com --- This granularity of CheckPrevCheckout by itemtype would still be useful functionality beyond serials - many libraries have unique things that they circulate that they would like to put a limitation on checkout within a timeframe in the interest of fairness of access - like laptops, hotspots, or local passes. Libraries may not want to turn on CheckPrevCheckout for a whole collection when they really only need it for certain subsets of items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:29:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:29:20 +0000 Subject: [Koha-bugs] [Bug 33569] Order by relevance many not be visible In-Reply-To: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33569-70-eY4EvOdTbk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:29:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:29:22 +0000 Subject: [Koha-bugs] [Bug 33569] Order by relevance many not be visible In-Reply-To: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33569-70-1RdKxcLIlZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 149984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149984&action=edit Bug 33569: Fix sort by relevance in catalog search When ordering catalog search by relevance from advanced search, this is not visible in sort order combobox in staff interface. This is because sort by relevance is a special case not using sort order. This patch add a new method C4::Context->default_catalog_sort_by to use in both staff interface and OPAC. Test plan : 1.0) On staff interface 1.1) Define system preferences defaultSortField = 'relevance' and defaultSortOrder = 'descending' 1.2) Perform a catalog search from main page on any term, ie 'perl' => You see in sort combobox 'relevance' selected (with a check icon) 1.3) Perform an advanced search on any term, ie 'perl', with sort by relevance => Without patch : you see in sort combobox 'relevance' not selected (no check icon) => With patch : you see in sort combobox 'relevance' selected (with a check icon) 2.0) On OPAC 2.1) Define system preferences OPACdefaultSortField = 'relevance' and OPACdefaultSortOrder = 'descending' 2.2) Perform a catalog search from main page on any term, ie 'perl' => You see in sort combobox 'relevance' selected 3.0) Run prove t/Context.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:45:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:45:31 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-znmsdB3BHS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:45:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:45:34 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-UGmUhHuvVR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 --- Comment #9 from David Nind <david at davidnind.com> --- Created attachment 149985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149985&action=edit Bug 33356: Add mana-kb hint to reports start page An alternate placement of the Mana KB hint on the reports start page. To test: * Go to Reports module * Verify the hint shows when you haven't decided on Mana KB * Once you set yes or no, it will no longer show Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:46:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:46:38 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-Ofx9AM5rkp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149067|0 |1 is obsolete| | --- Comment #10 from David Nind <david at davidnind.com> --- Comment on attachment 149067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149067 Bug 33356: Highlight mana-kb from reports when not configured Obsoleted, as Katrin's alternative patch signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:47:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:47:42 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-Q92LIjSaEf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149355|0 |1 is obsolete| | --- Comment #11 from David Nind <david at davidnind.com> --- Comment on attachment 149355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149355 Bug 33356: [Alternate) Add mana-kb hint to reports start page Obsoleted, amended commit message before sign off to remove [Alternative] from the commit message title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:47:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:47:43 +0000 Subject: [Koha-bugs] [Bug 23258] Batch holding In-Reply-To: <bug-23258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23258-70-7TcWlb3hsN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 --- Comment #23 from Jessie Zairo <jzairo at bywatersolutions.com> --- Batch modifying the pickup location would be another good option to include in this tool. Often a patron will call and ask that all 10 holds be send to another location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:48:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:48:14 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12029-70-biBtVflJzq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:48:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:48:16 +0000 Subject: [Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages In-Reply-To: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12029-70-IUUdndfUxy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #76 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:48:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:48:19 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-P5LWGKTn41@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:48:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:48:21 +0000 Subject: [Koha-bugs] [Bug 33103] Add vendor aliases In-Reply-To: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33103-70-ZdjZ5RLKAx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103 --- Comment #62 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:48:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:48:23 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-qLzUXgs7uz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:48:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:48:25 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-neM7VHhH5W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 20:48:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 18:48:51 +0000 Subject: [Koha-bugs] [Bug 29691] Use template plugins to display OPAC news on homepage In-Reply-To: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29691-70-1ubMM2qy04@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29691 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use template plugins to |Use template plugins to |display opac news on |display OPAC news on |homepage |homepage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:05:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:05:36 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-iEw0JrcV0r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I feel strongly that this has started as a 'hack', because it kinda worked... and now we are in trouble. I feel that making a behavior change dependent on a framework setting will always keep causing us trouble - it will always lead to bug reports about things being broken one way or the other for some, but others expecting it to work that way. And I see no easy way to fix this with comments or hints in framework/Koha-to-MARC mappings page Could we imagine making this more solid somehow if people really need it? What's the use case? Can you still use CART/PROC or is this exclusive? I think a system preference would work better and allow us to tie in with the other features using this database field in terms of documentation/linking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:09:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:09:54 +0000 Subject: [Koha-bugs] [Bug 32721] Allow UserCSS and UserJS at library level In-Reply-To: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32721-70-ut9T87z5HF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow UserCSS and UserJS at |Allow UserCSS and UserJS at |branch level |library level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:14:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:14:09 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-VXNA9o6f0l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #6 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- (In reply to Katrin Fischer from comment #5) > Could we imagine making this more solid somehow if people really need it? > What's the use case? Can you still use CART/PROC or is this exclusive? I'm not against moving this into a real feature rather than a possible modification. The use case here is a temporary shelving location to show that an item has been placed in a display. Items are pulled from the stacks and put in a display, the shelving location is set to DISPLAY so staff/patrons know the item is available but not at its usual spot. If those items are checked out, we don't want to try to get them back to the display on return -- that's too much staff hassle and likely the display will have been changed out before the item is returned anyway. This workaround makes it so that when the item is returned its shelving location automatically reverts to its regular value. This workflow does not impact the usability of CART or PROC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:18:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:18:44 +0000 Subject: [Koha-bugs] [Bug 33488] Library transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-Z11vxSgRcB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Branch transfer limits |Library transfer limits |should have an index on |should have an index on |fromBranch |fromBranch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:19:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:19:15 +0000 Subject: [Koha-bugs] [Bug 26368] Add support for OCLC Encoding level values In-Reply-To: <bug-26368-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26368-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26368-70-Uz96nkbE1l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26368 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:22:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:22:37 +0000 Subject: [Koha-bugs] [Bug 33561] Improve display of location column in search results In-Reply-To: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33561-70-SmZPhsK7f3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33561 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- > It would also be nice to have a way to only show items from the branch that > you are logged in at. Hm, aren't SeparateHoldings and SeparateHoldingsBranch doing this? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:23:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:23:09 +0000 Subject: [Koha-bugs] [Bug 33561] Improve display of location column in search results In-Reply-To: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33561-70-9rt0NcT2ao@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33561 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Lucas Gass from comment #0) > I've been asked to customize the location column in staff search results. I > am opening this bug to ideate. > > At the very least I would like to add more classes to make everything easier > to customize. > > It would also be nice to have a way to only show items from the branch that > you are logged in at. Oh, or more like a search filter that can be applied/removed anytime? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:25:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:25:47 +0000 Subject: [Koha-bugs] [Bug 33569] Order by relevance may not be visible In-Reply-To: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33569-70-shSH4eUYSu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Order by relevance many not |Order by relevance may not |be visible |be visible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:27:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:27:26 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-pqtXyYJbGg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Lol, I just got to that one! Would be great if it could still make it into 22.11.05 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:30:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:30:10 +0000 Subject: [Koha-bugs] [Bug 23258] Tool for batch processing holds - placing, cancelling, updating In-Reply-To: <bug-23258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23258-70-8rZCKRCLXS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch holding |Tool for batch processing | |holds - placing, | |cancelling, updating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:30:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:30:37 +0000 Subject: [Koha-bugs] [Bug 33561] Improve display of location column in search results In-Reply-To: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33561-70-rL3kZzJbR9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33561 --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #3) > > It would also be nice to have a way to only show items from the branch that > > you are logged in at. > > Hm, aren't SeparateHoldings and SeparateHoldingsBranch doing this? Maybe I am mistaken but don't these only apply when viewing for the detail page? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:31:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:31:20 +0000 Subject: [Koha-bugs] [Bug 23258] Batch tool for placing and cancelling holds In-Reply-To: <bug-23258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23258-70-97nYIt0icd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23258 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Tool for batch processing |Batch tool for placing and |holds - placing, |cancelling holds |cancelling, updating | --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- As holding can have a different meaning (stuff the library owns, items) I have updated the bug description a little bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:31:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:31:52 +0000 Subject: [Koha-bugs] [Bug 33561] Improve display of location column in search results In-Reply-To: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33561-70-LNorWpGHOv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33561 --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #4) > (In reply to Lucas Gass from comment #0) > > I've been asked to customize the location column in staff search results. I > > am opening this bug to ideate. > > > > At the very least I would like to add more classes to make everything easier > > to customize. > > > > It would also be nice to have a way to only show items from the branch that > > you are logged in at. > > Oh, or more like a search filter that can be applied/removed anytime? Yes, many consortia are using some type of jQuery to do this now. It would be nice if we had functionality like this in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:33:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:33:26 +0000 Subject: [Koha-bugs] [Bug 33561] Improve display of location column in search results In-Reply-To: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33561-70-853fq3CbBN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33561 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Lucas Gass from comment #6) > (In reply to Katrin Fischer from comment #4) > > (In reply to Lucas Gass from comment #0) > > > I've been asked to customize the location column in staff search results. I > > > am opening this bug to ideate. > > > > > > At the very least I would like to add more classes to make everything easier > > > to customize. > > > > > > It would also be nice to have a way to only show items from the branch that > > > you are logged in at. > > > > Oh, or more like a search filter that can be applied/removed anytime? > > Yes, many consortia are using some type of jQuery to do this now. It would > be nice if we had functionality like this in Koha. It does apply only to the detail page, but having a clickable filter on the full table without splitting into 2 tabs would still be nice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:34:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:34:24 +0000 Subject: [Koha-bugs] [Bug 33561] Improve display of location column in search results In-Reply-To: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33561-70-Xfcd5MP6jf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33561 --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7) > (In reply to Lucas Gass from comment #6) > > (In reply to Katrin Fischer from comment #4) > > > (In reply to Lucas Gass from comment #0) > > > > I've been asked to customize the location column in staff search results. I > > > > am opening this bug to ideate. > > > > > > > > At the very least I would like to add more classes to make everything easier > > > > to customize. > > > > > > > > It would also be nice to have a way to only show items from the branch that > > > > you are logged in at. > > > > > > Oh, or more like a search filter that can be applied/removed anytime? > > > > Yes, many consortia are using some type of jQuery to do this now. It would > > be nice if we had functionality like this in Koha. > > It does apply only to the detail page, but having a clickable filter on the > full table without splitting into 2 tabs would still be nice. Ah yes, a clickable filter would be helpful on both the results and details pages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:40:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:40:06 +0000 Subject: [Koha-bugs] [Bug 25426] Allow return policy to be selected via syspref and not just home library In-Reply-To: <bug-25426-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25426-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25426-70-uzf7np1jTA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25426 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/665 Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:45:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:45:36 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-xHcqPuNu8o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 solene.ngamga at inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146747|0 |1 is obsolete| | --- Comment #15 from solene.ngamga at inlibro.com --- Created attachment 149986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149986&action=edit Bug 32341: (follow-up) Add responsivity to Curbside pickups table and changing button style for finestables To activate Curbside pickups 1- Enable the CurbsidePickup system preference 1.1 Go to Administration > Global system preferences 1.2 Search for CurbsidePickup 1.3 Change the value for 'Enable' 1.4 Click on 'Save all circulation preferences' 2- Configure time slots for at least one library 2.1 Go to Administration > Curbside pickup 2.2 Fill out the form for Centerville (or another library) Enable: Check Pickup interval: 10 (or other) Maximum boss per interval: 3 (or other) Patron-scheduled pickup: Check Enable for waiting holds only: DO NOT check 2.3 Add a time slot In 'New slot', enter Monday From: 10:00 To: 12:00 Click on 'Add' 3- Make an appointment from the OPAC 3.1 Go to OPAC 3.2 Open mobile mode 3.3 Connect with a user 3.4 Click on 'Curbside pickups' 3.5 Choose the library in 'Pick a library' 3.6 Choose a date in 'Pickup date' 3.7 Choose a time range in 'Select a time' 3.8 Click on 'Schedule pickup' => Notice The table is not responsive 4- Apply the patch 5- Execute 'yarn build --view opac' 6- Clean your cache or open your navigator on private mode (to load updated css files) 7- Perform step 3.1, 3.2, 3.3, 3.4, 8- click on 'Your pickups' => Confirm that the CurbsidePickup table are now displayed correctly and is now responsive. 9- Click on 'Charges' => Confirm that the Charges table are now displayed correctly and is now responsive. I correct a little bug. The "suspend_hold" button did not work anymore. This change resets it to it's original state. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:48:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:48:58 +0000 Subject: [Koha-bugs] [Bug 28691] Quick spine label should split the same way the label creator does / use splitting rules In-Reply-To: <bug-28691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28691-70-ew3Fmfm41o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28691 Chris Nighswonger <cnighswonger at foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2500 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:48:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:48:58 +0000 Subject: [Koha-bugs] [Bug 2500] Standing enhancement request for adding/updating call number splitting algorithms in C4/Labels.pm In-Reply-To: <bug-2500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2500-70-t0bqj7kM82@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2500 Chris Nighswonger <cnighswonger at foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28691 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 21:51:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 19:51:30 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-u3G8GxfTwe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #5) > I feel strongly that this has started as a 'hack', because it kinda > worked... and now we are in trouble. This is how features develop :-) Covering it with tests and preventing breakages are a fair thing to do > I feel that making a behavior change dependent on a framework setting will > always keep causing us trouble - it will always lead to bug reports about > things being broken one way or the other for some, but others expecting it > to work that way. And I see no easy way to fix this with comments or hints > in framework/Koha-to-MARC mappings page We have plugins and mappings that are defined in the frameworks that alter behavior. I don't think this is unexpected. Editing the frameworks can have consequences and users should be aware, but we do expect Koha to work differently when the frameworks are altered. > Could we imagine making this more solid somehow if people really need it? > What's the use case? Can you still use CART/PROC or is this exclusive? I agree with Andrew - a fully fledged feature would be great here. But I don't think that is a blocker to this patch set > I think a system preference would work better and allow us to tie in with > the other features using this database field in terms of > documentation/linking. I am not against adding a syspref, but I am not sure what the switch would do here? I am strongly in favor of this moving forward, and a new feature/sypref being developed on a new bug report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:02:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:02:14 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-jKJYlymH5b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am ok to continue discussion elsewhere and it's not the ideal way for features to develop - but it happens, I just want to deal with it in a saner way to avoid having more bugs like this :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:27:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:27:27 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33127-70-Nx87H8sedn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:27:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:27:30 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33127-70-qC3qrxGiiX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149846|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149987&action=edit Bug 33127: Use template wrapper for breadcrumbs: Administration part 5 This patch updates several administration templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. Administration -> - Record overlay rules - Search filters (must have SavedSearchFilters enabled) - System preferences -> OverDriveAuthName -> OverDrive library authnames table - MARC bibliographic framework -> MARC structure (list, new, edit, delete confirm). - Record matching rules (list, new, edit, delete confirm) - OAI sets configuration (list, new, edit) -> Define mappings - Patron attribute types (list, new, edit, delete confirm) - Patron restrictions (list, new, edit, delete confirm) Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:30:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:30:48 +0000 Subject: [Koha-bugs] [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1 In-Reply-To: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33558-70-wbeJqrO7gq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:30:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:30:50 +0000 Subject: [Koha-bugs] [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1 In-Reply-To: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33558-70-4WK8eGawIC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149844|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149988&action=edit Bug 33558: Use template wrapper for breadcrumbs: Serials part 1 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Claims - Claims for a vendor - Check expiration - Subscription details -> - Serial collection - Create routing list - Edit routing list - Preview routing list Signed-off-by: Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:33:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:33:33 +0000 Subject: [Koha-bugs] [Bug 33555] Use template wrapper for breadcrumbs: Rotating collections In-Reply-To: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33555-70-tWySadxMRp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:33:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:33:36 +0000 Subject: [Koha-bugs] [Bug 33555] Use template wrapper for breadcrumbs: Rotating collections In-Reply-To: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33555-70-LcYiEGWwGT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149819|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149989&action=edit Bug 33555: Use template wrapper for breadcrumbs: Rotating collections This patch updates rotating collections templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Rotating collections - New rotating collection - Edit collection - Delete collection - Manage items - Transfer collection Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:35:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:35:00 +0000 Subject: [Koha-bugs] [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4 In-Reply-To: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33439-70-VqRJMClSMz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:36:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:36:38 +0000 Subject: [Koha-bugs] [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4 In-Reply-To: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33439-70-tzqgFvpAN3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:36:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:36:43 +0000 Subject: [Koha-bugs] [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4 In-Reply-To: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33439-70-ckqlpbD8Wf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149808|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149990&action=edit Bug 33439: Use template wrapper for breadcrumbs: Reports part 4 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Reports home - Orders by fund - Results - Holds statistics wizard - Results - Serials statistics wizard - Results Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:39:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:39:25 +0000 Subject: [Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3 In-Reply-To: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33438-70-fjS7donDUA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:39:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:39:27 +0000 Subject: [Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3 In-Reply-To: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33438-70-8IIdqGIMyj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149806|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149991&action=edit Bug 33438: Use template wrapper for breadcrumbs: Reports part 3 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Average loan time - Results - Circulation statistics - Results - Lost items - Results - Catalog by item type - Results Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:39:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:39:33 +0000 Subject: [Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3 In-Reply-To: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33438-70-xy4ZArkYrM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:43:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:43:33 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33388-70-hFsa2yWwpb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:43:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:43:56 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33388-70-o0ZiEngDl1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:43:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:43:59 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33388-70-yBY72oWXKD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149600|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149992&action=edit Bug 33388: Use template wrapper for breadcrumbs: Patrons part 4 This patch updates several patron templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Patrons -> - Patron details - Notices - Accounting - Edit patron - Add patron - Patrons requesting modification (submit patron update via the OPAC) Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:47:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:47:39 +0000 Subject: [Koha-bugs] [Bug 33310] Use template wrapper for tabs: Suggestions In-Reply-To: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33310-70-mKsdhq6ey2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33310 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:47:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:47:42 +0000 Subject: [Koha-bugs] [Bug 33310] Use template wrapper for tabs: Suggestions In-Reply-To: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33310-70-LWqhZIdDve@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33310 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149618|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149993&action=edit Bug 33310: Use template wrapper for tabs: Suggestions This patch updates the suggestions template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and go to the suggestions page in the staff interface. - By default you suggestions should be organized by status, with a separate tab for each status (pending, accepted, etc). - Use the "Organize by" form in the sidebar to change how suggestions are listed. In each case confirm that the tabs are redisplayed correctly. Works as advertised. 3/3 Signed-off-by: Paul Derscheid <paul.derscheid at lmscloud.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:48:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:48:15 +0000 Subject: [Koha-bugs] [Bug 33158] Use template wrapper for authorized values and item types administration tabs In-Reply-To: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33158-70-tbLNPq6XCy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:49:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:49:01 +0000 Subject: [Koha-bugs] [Bug 33158] Use template wrapper for authorized values and item types administration tabs In-Reply-To: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33158-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33158-70-UMX5MpRh5H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33158 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Can you please check on the QA test fail? FAIL koha-tmpl/intranet-tmpl/prog/en/includes/admin-icon-selection.inc FAIL valid_template tab_item: not found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:50:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:50:22 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-Ta391uSIGU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:53:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:53:28 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-ngLK34YXrw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32061 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:53:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:53:28 +0000 Subject: [Koha-bugs] [Bug 32061] <span> in the title of z39.50 servers page In-Reply-To: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32061-70-gLiHvmAKhy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32061 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33551 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:58:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:58:43 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-Zz9X97MaYf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149843|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149994&action=edit Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:58:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:58:46 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-TM5vgyTPUO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149995&action=edit Bug 33551: (follow-up) Remove spans by using TT filter This allows up to keep the restriction name in the title by removing the span tags with a TT filter. Copied from bug 32061. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 22:59:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 20:59:38 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-g5I1SXrzd4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The first patch removed not only the spans, but also the restriction type (Manual, etc.) from the title. My follow-up adds them back, but still removes the spans. Maybe we could get another sign-off/QA check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:04:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:04:48 +0000 Subject: [Koha-bugs] [Bug 33578] New: Cannot edit patron restriction types Message-ID: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 Bug ID: 33578 Summary: Cannot edit patron restriction types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, martin.renvoize at ptfs-europe.com When editing an existing patron restriction type you'll always get an error on saving: Label is already in use Of course the label is already in use... for the restriction type I am just editing. To test: * Activate use of patron restriction types * Edit any of the system types * Save --> Notice error :( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:05:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:05:24 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in Patron restriction types admin page In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-kO4e503ZXO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6) > The first patch removed not only the spans, but also the restriction type > (Manual, etc.) from the title. My follow-up adds them back, but still > removes the spans. Maybe we could get another sign-off/QA check? Probably a good idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:08:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:08:39 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-3VLPcZTLmu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:08:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:08:41 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-tSZ1r6g8bc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149845|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149996&action=edit Bug 33549: Fix dialog box in patron restrictions To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'New restriction' 4. Enter a code and label 5. Click 'Save' --> 'Type added' at the top of the page is not styled 6. Apply patch 7. Try again, dialog is styled correctly Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:08:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:08:44 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-PMENHgwAhD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 149997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149997&action=edit Bug 33549: Improve wording of dialog messages In terms of translations type can be a lot of things. Usually translations are easier with more context, so I've added restriction to the type :) Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:09:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:09:02 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-n3Bo1JX1Gu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:09:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:09:22 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-JnjA6w4Okw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rogue span in Patron |Rogue span in patron |restriction types admin |restriction types admin |page |page title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:24:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:24:30 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff interface In-Reply-To: <bug-22605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22605-70-HG7qJdLTzB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED --- Comment #56 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Already in the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:24:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:24:31 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17170-70-2oW5YEpWIF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Bug 17170 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:24:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:24:32 +0000 Subject: [Koha-bugs] [Bug 27546] Add option to search within results on the staff interface In-Reply-To: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27546-70-1odJ2UqPmH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 Bug 27546 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:24:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:24:32 +0000 Subject: [Koha-bugs] [Bug 30357] Better display of 'Edit this search' In-Reply-To: <bug-30357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30357-70-ZUlANnoOz1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30357 Bug 30357 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:24:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:24:33 +0000 Subject: [Koha-bugs] [Bug 31271] "Edit search" always resets search options to keyword In-Reply-To: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31271-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31271-70-ZSez7lFmae@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31271 Bug 31271 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:24:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:24:33 +0000 Subject: [Koha-bugs] [Bug 32100] "edit search" feature quote-wraps search terms if original search had no results In-Reply-To: <bug-32100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32100-70-IRP9o9UQDS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32100 Bug 32100 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:24:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:24:34 +0000 Subject: [Koha-bugs] [Bug 31076] Bug 22605 breaks date of publication range search In-Reply-To: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31076-70-9n83OoEVtE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31076 Bug 31076 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:24:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:24:33 +0000 Subject: [Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search In-Reply-To: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32301-70-fp0dI0PcMk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Bug 32301 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 20 23:42:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 21:42:57 +0000 Subject: [Koha-bugs] [Bug 30274] Non-reservable items should only fill item-level reserves In-Reply-To: <bug-30274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30274-70-pPJNKz6N2z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30274 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |--- Status|ASSIGNED |NEW Assignee|aleisha at catalyst.net.nz |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 01:36:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Apr 2023 23:36:39 +0000 Subject: [Koha-bugs] [Bug 7972] GUI for Crons In-Reply-To: <bug-7972-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7972-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7972-70-KEAL6aQ44K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972 Kris <kbecker at jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker at jcls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 03:13:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 01:13:09 +0000 Subject: [Koha-bugs] [Bug 33563] Enable compatibility with Elasticsearch secure mode In-Reply-To: <bug-33563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33563-70-ZYRchVMSxr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33563 Wes <wsmith at marshallcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wsmith at marshallcolibrary.or | |g -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 03:21:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 01:21:02 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-RRIjDxqbnD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149980|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 149998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149998&action=edit Bug 33577: Add btn class to cancel hold button on /reserve/request.pl To test: 1. Place a hold on a record and look at the /reserve/request.pl page. 2. Notice the two buttons 'Update hold(s)' and 'Cancel selected' buttons are not quite the same size. 3. Apply patch and look again, the buttons should line up. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 03:21:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 01:21:21 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-TxuuXr8eCG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:39:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:39:50 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-PgCwFOlXvQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:39:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:39:53 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-vPXnUct1Dv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149914|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 149999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149999&action=edit Bug 33478: Add formatting columns to letter table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:39:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:39:55 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-VXLjYwQvny@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149918|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150000&action=edit Bug 33478: Schema updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:39:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:39:58 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-EAwB1XiuYf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149915|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150001&action=edit Bug 33478: Add format_notices user permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:40:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:40:00 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-fiof2Sb2sA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149916|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150002&action=edit Bug 33478: Save notice format settings Save format settings for an individual notice, or for all notices To test: 1. Apply the patches, install database updates, update schema if needed, and restart services 2. Go to Tools -> Notices and slips 3. Edit any notice 4. Go to the Print tab 5. Confirm format settings now show underneath the notice content box 6. Change some settings and confirm they save correctly 7. Test that 'apply these settings to all notices' option works 8. Add a new notice and confirm format settings save successfully 9. Search for a patron, go to More -> Set permissions 10. Ensure they have all Tools permissions EXCEPT for new format_notices user permission 11. Log into the staff interface as this patron 12. Go to Tools -> Notices and slips 13. Edit a notice 14. Go to the Print tab 15. Confirm the format settings DO NOT show underneath the notice content box Sponsored-by: Colorado Library Consortium -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:40:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:40:03 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-RPXU3gnWVy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #14 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150003&action=edit Bug 33478: Apply formatting to HOLD_SLIP To test: 1. Place a hold on a record 2. Check in an item attached to the record 3. When the pop-up for the hold is triggered, confirm hold and print slip 4. Confirm your format settings for HOLD_SLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:40:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:40:05 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-VzvIQGY4Mf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #15 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150004&action=edit Bug 33478: Apply formatting to AR_SLIP To test: 1. Enable ArticleRequests system preference in Koha Administration -> Global system preferences 2. Log into the OPAC 3. Do a catalogue search 4. Click the 'Request article' button for a record 5. Fill in some information and submit 6. Go to the staff interface 7. Go to Circulation -> Article Requests 8. Click the Actions menu next to your article request and choose Print slip 9. Confirm your format settings for AR_SLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:40:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:40:08 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-qU8Wuse56l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #16 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150005&action=edit Bug 33478: Apply formatting to TRANSFERSLIP To test: 1. Search for an item that was last seen at a library different from your logged in library i.e the holding library is Fairview but your logged in library is Centerville 2. Use the barcode to check in the item 3. When the popup to 'please return this item to <home library>' is triggered, click the Print slip button 4. Confirm your format settings for TRANSFERSLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:40:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:40:10 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-gPMNkaEBiF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #17 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150006&action=edit Bug 33478: Apply formatting to OVERDUES_SLIP To test: 1. Check out an item to a user. Set the due date to a time in the past so it is overdue 2. Click Print in the members toolbar, then Print overdues 3. Confirm your format settings for OVERDUES_SLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:40:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:40:13 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-lKkN330ifx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #18 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150007&action=edit Bug 33478: Apply formatting to ACCOUNT_DEBIT To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. You'll be redirected to the Transactions tab 4. Click the Print button next to your invoice 5. Confirm your format settings for ACCOUNT_DEBIT are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:40:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:40:15 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-Cqwdy6gVGQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #19 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150008&action=edit Bug 33478: Apply formatting to ACCOUNT_DEBIT To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. You'll be redirected to the Transactions tab 4. Click the Pay button next to your invoice and confirm Payment 5. Click the Print button next to your Payment 6. Confirm your format settings for ACCOUNT_CREDIT are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:40:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:40:18 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-8muF2R4MgY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #20 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150009&action=edit Bug 33478: Apply formatting to ISSUESLIP, ISSUEQSLIP, CHECKINSLIP To test: 1. Check out an item to a patron 2. Click Print in the members toolbar, then Print quick slip 3. Confirm your format settings for ISSUEQSLIP are applied 4. Click Print in the members toolbar, then Print slip 5. Confirm your format settings for ISSUESLIP are applied 6. Return the item 7. When the item is checked in, click the 'Print checkin slip' button 8. Confirm your format settings for CHECKINSLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:40:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:40:20 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-zrMw5OgRFB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #21 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150010&action=edit Bug 33478: Apply formatting to RECEIPT To test: 1. Enable EnablePointOfSale and UseCashRegisters system preferences in Koha Administration -> Global system preferences 2. Go to Koha Administration -> Cash registers and add a new cash register 3. Go to Koha Administration -> Debit types and add a new debit type. Make sure you check the 'can be sold' option 4. Go to Point of sale 5. Select Add for your item under Items for purchase 6. Fill in Collect payment box and click Confirm 7. When payment is received, click Print receipt 8. Confirm your format settings for RECEIPT are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:40:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:40:23 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-TfyQfO1F2c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #22 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150011&action=edit Bug 33478: Apply formatting to ACCOUNTS_SUMMARY To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. Click the Print button in the patron toolbar 4. Click the 'Print account balance' button 5. Confirm your format settings for ACCOUNTS_SUMMARY are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:40:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:40:25 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-xLEpScF9LZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #23 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150012&action=edit Bug 33478: Apply formatting to RECALL_REQUESTER_DET To test: 1. Enable UseRecalls system preference and configure all relevant recalls circulation and fines rules 2. Search for a record with only one item 3. Check out this item to Patron A 4. Log into the OPAC as Patron B 5. Search for the item and place a recall 6. Go back to the staff interface 7. Check in the item 8. When the pop-up for the recall is triggered, confirm recall and print slip 9. Confirm your format settings for RECALL_REQUESTER_DET are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 05:42:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 03:42:54 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-6IaSIifDAX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149917|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 08:26:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 06:26:34 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32607-70-hmIcZrGSqW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to AgustĂ­n Moyano from comment #13) A global response would be (and sorry if I am rambling here) that we enforce consistency. We must not have 2 ways to do the same thing. If you want to add something new to the Vue code in Koha, it must be done globally. Otherwise we end up with divergences. We cannot allow a module that would do something differently. > > 3. (naming) It's not clear what is Koha::ImportSource->patron and > > import_source.patron_id, could we find something more meaningful? > > It is the patron account that is allowed to create records with this > source.. I'm not sure what could we call it.. > Koha::RecordSource->allowed_patron and record_sources.allowed_patron_id? I am bad at naming, keep patron_id for now. (Is this correct to have 1-N instead of N-N then?) > > 7. FormKit/Form => You are introducing a change that is not applied to other > > Vue files, and you are changing the UI, it's not consistent with other area > > of Koha. I don't think we are ready for that. > > I believe Formkit or another form library it's a good idea, and we are in a > good time, in that we are at the very beginning of using Vue. I believe it > can help a lot with the maintainability of the components. For example, if > we apply a library that creates forms from a yaml or json definition, > theoretically we could be able to reduce ERM components to 4: a Main > component, a List component, a Form component and a Show component, and what > get's displayed and the actions could be just parameters that are passed or > picked up by those components. > > If your concern is that it's not implemented in other vue files, we can make > other bugs to implement them. But if it is about the UI, css classes can > always be modified. Yes, of course it would be nice to have such mechanisms to ease writing of our form. But as said previously this new code should not introduce something new it would be the only one to use. First we adapt our code, then we use it in new module. In your position it would be easier to stick to the exist patterns. > > 8. In ISEdit.vue, processSubmit. The way we are displaying the message is in > > then(). Same for the other AJAX requests in other components. > > It is implemented in the "then" part.. you see, in Javascript if you are in > an async function doing Yes ofc, I know. But still the same answer, it's a different pattern... > > 10. the routes: you are deciding to change the URL, > > admin/import-sources.pl/add > > We are not having the '.pl' for other vue pages (which require the apache's > > rewriterule, but I think we need to stay consistent) > > I forgot about this part, and am not sure how to implement this, but > definitely will take a look See debian/templates/apache-shared-intranet.conf:RewriteRule ^/cgi-bin/koha/erm/.*$ /cgi-bin/koha/erm/erm.pl [PT] > > 11. import-sources.js > > You are using add/remove/update/getOne when we use create/delete/update/get > > in other fetch files. > > I cannot use create/delete/update/get because http-client implement those > same methods.. one way would be to add a new level like > > return { > record_source: { > get: () .... > create: () ... > update: () ... > delete: () ... > } > } > > but it's kind of redundant since I don't have many things to fetch as in > ERM.. and I would end up calling the actions like > > record_source.record_source.get() Yes, that's not a problem, we have it for patron as well, see components/ERM/UserRoles.vue const client = APIClient.patron // FIXME We are missing a "loading..." client.patrons.get(selected_patron_id).then(p => { We can imagine to have something related to patron but that is not "patrons" (like the attributes for instance). Stick to the existing patterns please ;) > The other way would be to rename the methods in http-client to > _create/_delete/_update/_get and there would be no collision in the names > > > 12. In patron-api-client.js you are using "list" when we use "getAll" in ERM > > Ups, I did not realize that... "list" seems to me as a more intuitive name > for it, but have absolutely no problem in changing the name Yes I agree, we could rethink the verbs. But that's for another bug. > > 13. About autocomplete, I would not use it. We already have a way to select > > patrons (in all the different Koha modules, and the same that we reuse in > > ERM). If we want an autocomplete feature I think we should then use select2 > > and implement bug 32474. > > I did not know about that way to select patrons, but it involves using a > popup window. I would not recommend that, as it may get blocked by the > browser. I will definitely check select2, but as we are using Vue, I would > try to minimize as much as possible the use of jQuery and jQuery components. Yes, we discussed that recently on #koha. We should have an autocomplete on select2 (with infinite scrolling) to search for patrons. And a "more options" link that would open the new window (that should be a modal). But that is for all the different patron searches in Koha, and so that's a big change, out of the scope here. You should stick to the existing patterns. > > I'd like to add that, as usual, I am not against new ways of doing things, > > but we need to apply them first to the existing code, and be consistent. > I have no problem implementing new features to the existing code, but I > think it better to be done in another bug so things don't get messed up Yes, that's all my point! :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 08:33:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 06:33:59 +0000 Subject: [Koha-bugs] [Bug 33579] New: Typo: record record Message-ID: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Bug ID: 33579 Summary: Typo: record record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org $ grep -rn "record record" * koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt:184: '_str': _("Batch bibliographic record record deletion") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 08:34:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 06:34:43 +0000 Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25870-70-9CIUkvfvuq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #35 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Hammat wele from comment #34) > I still need help with Koha::Biblios->search thing. how to use it to search > biblio hidden_in_opac. With the Koha::Biblios->search adding the pagination > would be more easier. How that? You need to rewrite ->hidden_in_opac, to build a parameter hashref from the syspref, then pass it to ->search I haven't had a deep look but I think it is possible and should work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 08:42:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 06:42:08 +0000 Subject: [Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge) In-Reply-To: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32450-70-Agkh3dNqQZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450 --- Comment #49 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Also very glad to see this has reached PQA, thanks to all involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 08:44:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 06:44:36 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-ZxYlKbVd24@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 08:44:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 06:44:38 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-DFCLK3e5k3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 --- Comment #1 from Magnus Enger <magnus at libriotech.no> --- Created attachment 150013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150013&action=edit Bug 33579: Typo: record record To reproduce: - Search for records - Select two or more records - Select "Edit" > "Batch delete records" - Click "Delete selcted records" - Click "View detail of the enqueued job" - Verify the page says "Type: Batch bibliographic record record deletion" To test: - Repeat the steps above - The page should now say "Type: Batch bibliographic record deletion" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 08:46:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 06:46:53 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-hHwlzt4KFS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 08:54:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 06:54:12 +0000 Subject: [Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit In-Reply-To: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27775-70-YHtNv5ejaG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775 --- Comment #8 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Katrin Fischer from comment #5) > Created attachment 149359 [details] [review] > Bug 27775: (QA follow-up) Slightly change of wording > > Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Thanks for that, I always write plurals wrong ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 08:56:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 06:56:03 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-FySFH1GwAS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #108 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Some findings in random order: I am missing an Add button on admin/localization. You can clear a record and remove it; but perhaps adding a Delete button would be nice too. Not sure why we are using DBIC here instead of Koha objects. No performance figures are given to justify. Koha::Object should be our standard. opac/opac-search.pl my $description = $itemtypes->{$itemtype}->{iscat} ? $itemtypes->{$itemtype}->{description} - : db_t('itemtype', Koha::ItemTypes->find($itemtype)->itemtype); + : Koha::ItemTypes->find($itemtype)->translated_description; $itemtypes->{$itemtype}->{description} = $description || $itemtypes->{$itemtype}->{description} || q{}; Weird code. package Koha::Template::Plugin::ItemTypes; sub GetDescription { return $parent ? $self->t($parent->description) . "->" . $self->t($itemtype->description) : $self->t($itemtype->description); Omission for switching to itemtype. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 08:56:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 06:56:16 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-v5feRL1qhb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #109 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- There is still something confusing in the table design: select * from l10n_source; +----------------+----------+-----+------------------------+ | l10n_source_id | group | key | text | +----------------+----------+-----+------------------------+ | 1 | itemtype | BK | Books | | 2 | itemtype | BKS | Books | | 3 | itemtype | CF | Computer Files | select * from l10n_target; +----------------+----------------+----------+-----------------+-------+ | l10n_target_id | l10n_source_id | language | translation | fuzzy | +----------------+----------------+----------+-----------------+-------+ | 2 | 1 | nl-NL | Boek | 0 | | 3 | 2 | en | BKS_EN | 0 | | 4 | 2 | nl-NL | Boek | 0 | The source seems to be the English text. But I can translate it into EN again via target. Easiest seems to be: prevent having EN in the target table. Shouldnt we check if we are calling db_t btw for an English translation? We should not be looking for the English translation of itemtype if we have the description already in our object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 08:58:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 06:58:12 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-DomOKrIRLn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #110 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- db_t could be made more flexible? Now we look for key and we removed description. But I think we should support both. Not sure how the concept of localization group will grow. But it might be too big soon for loading all its sources and finding corresponding translations. (The code needs a join here.) For instance, thinking about AV, I am probably only interested in a particular category and not in all entries under 'authorised_values' if that was the group. Other areas may have other needs again. This is a quite fundamental issue on the design of db_t. It feels not complete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 08:59:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 06:59:46 +0000 Subject: [Koha-bugs] [Bug 33336] Use a dedicated column for plugin status in plugins table In-Reply-To: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33336-70-tTnDMm5IYN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 --- Comment #7 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Matt Blenkinsop from comment #6) > Enhancement - not backporting to 22.11.x > > Nice work everyone! Hi, This is a really trivial patch, but the change is really useful for end users. Could you reconsider backporting ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 09:01:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 07:01:01 +0000 Subject: [Koha-bugs] [Bug 27188] Show current class in plugins home In-Reply-To: <bug-27188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27188-70-HjG8xJku1P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27188 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #5 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Owen Leonard from comment #2) > I don't like that this uses the button toolbar to switch views, based on my > conception of our conventions of views and actions: > > https://wiki.koha-community.org/wiki/Interface_patterns#Views_and_Actions > > I would prefer that the views be links in the sidebar or some kind of > DataTables filter. > > I think it's not ideal that one is offered choices to view classes of > plugins for which there are no results. This would be an advantage of making > the table a DataTable, including the class as a (hidden?) column, and > offering table filtering based on the available classes. This is the best solution so I close this one invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 09:02:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 07:02:20 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32642-70-DmYW88JVu5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Revisiting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 09:55:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 07:55:15 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-bzMTCreIoh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150013|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 150014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150014&action=edit Bug 33579: Typo: record record To reproduce: - Search for records - Select two or more records - Select "Edit" > "Batch delete records" - Click "Delete selcted records" - Click "View detail of the enqueued job" - Verify the page says "Type: Batch bibliographic record record deletion" To test: - Repeat the steps above - The page should now say "Type: Batch bibliographic record deletion" Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 09:55:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 07:55:47 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-7QCFYRrkOy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- Signed off, thanks for the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 10:23:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 08:23:47 +0000 Subject: [Koha-bugs] [Bug 33336] Use a dedicated column for plugin status in plugins table In-Reply-To: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33336-70-lKQVECx18H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Hi Fridolin, I'm happy to backport this but we are currently in string freeze as we head towards this months release. We'll backport this at the start of next month once this release is finished -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 10:29:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 08:29:42 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-Dz4bm9dnhF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Is this on a specific version, Katrin? I can't replicate it here -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 10:30:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 08:30:58 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32642-70-fq234go60j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 --- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- The more I look at this cover images code in javascript, the more I wonder about it ;) I think the whole code (not talking about this adjustment) needs more attention and has been scattered over various js files for specific cover image providers etc. We are starting wait_for_images in window.load. It all looks quite suboptimal. What this adjustment is doing now, is adding the spinner after everything has been loaded already. And it therefore immediately removes it again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 10:50:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 08:50:20 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-qoketnqe02@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 10:51:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 08:51:24 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-8JDwfQIsHa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #111 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- > Bug 24975: Add translation_key method example This breaks the whole logic. If there is no translation we are displaying the code instead of the non-translated description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 10:53:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 08:53:05 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-spvjj1zqli@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #2 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- This is a brilliant idea, Lucas - adding configuration to the request.pl table is super helpful, and I'd love to see this patch in Koha. It works well on testing: - The dataTable works as expected; I am able to hide columns using the controls on the page - The dataTable configuration works as expected; I am able to change settings (hidden by default, cannot be toggled) in the administration screen and they're correctly reflected on the dataTable - and these changes are remembered when the page reloads after submitting a change - Logging in as a staff member without the modify_holds_priority permission works as described The only issue is that there's a couple of columns which I think need to be set as default as visible / cannot be toggled, the same as the checkbox. They are: Priority and Pickup Library Priority When you hide Priority and submit any changes, the page redirects to: /cgi-bin/koha/reserve/request.pl / Place a hold on No title - instead of reloading the page you were on Pickup library When you hide Pickup library and submit any changes, Koha throws an error: [You must supply a pickup location when placing a hold] at /usr/share/perl5/Exception/Class/Base.pm line 88 If those two changes can be made, I can sign off. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 10:54:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 08:54:02 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-Fe7sfkhouU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #112 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #111) > > Bug 24975: Add translation_key method example > > This breaks the whole logic. If there is no translation we are displaying > the code instead of the non-translated description. Forget that, that's not correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 11:58:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 09:58:53 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-mb4n0F5H4b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I was testing on master yesterday - I'll repeat the test now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:00:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:00:57 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-rQrzTdzEDd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, I still have the issue, git pulled master, restart_all and in a new private window. Edit MANUAL Change nothing Try to save > Error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:04:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:04:11 +0000 Subject: [Koha-bugs] [Bug 33578] Cannot edit patron restriction types In-Reply-To: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33578-70-VXxPWqoKjl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33578 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Quick guess: Maybe the one you edit shouldn't be in the list of existing ones? <script> var MSG_DUPLICATE_CODE = _("Restriction code is already in use"); var MSG_DUPLICATE_DISPLAY_TEXT = _("Label is already in use"); var existing = { DISCHARGE: 'Discharge tkk', MANUAL: 'Manual', OVERDUES: 'Overdues', SUSPENSION: 'Suspension', }; </script> jQuery.validator.addMethod( "restrictionDisplayText", function(value){ var ex = Object.values(existing).map(function(el) { return el.toLowerCase(); }); return (value.length > 0 && ex.indexOf(value.toLowerCase()) > -1) ? false : true; }, MSG_DUPLICATE_DISPLAY_TEXT); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:16:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:16:18 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-WhtOFtSd0h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144719|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:16:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:16:38 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-1gSqyAPG1f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145154|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:18:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:18:50 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-HCXrzn5A3d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #113 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Marcel de Rooy from comment #108) > Some findings in random order: > > I am missing an Add button on admin/localization. You can clear a record and > remove it; but perhaps adding a Delete button would be nice too. What would you like to add? You are not supposed to need it, at least for now. > Not sure why we are using DBIC here instead of Koha objects. No performance > figures are given to justify. Koha::Object should be our standard. It avoids 2 new packages, Koha::I18N::L10nSource[s]? I would go without them to start with this approach, please keep things as simple as possible. > opac/opac-search.pl > my $description = $itemtypes->{$itemtype}->{iscat} > ? $itemtypes->{$itemtype}->{description} > - : db_t('itemtype', Koha::ItemTypes->find($itemtype)->itemtype); > + : Koha::ItemTypes->find($itemtype)->translated_description; > $itemtypes->{$itemtype}->{description} = $description || > $itemtypes->{$itemtype}->{description} || q{}; > Weird code. All this "itemtype category" code is ugly, but why is this part weird? (there is a comment above about non-translatability of item type categories) > package Koha::Template::Plugin::ItemTypes; > sub GetDescription { > return $parent ? $self->t($parent->description) . "->" . > $self->t($itemtype->description) : $self->t($itemtype->description); > Omission for switching to itemtype. Should be fixed now. (In reply to Marcel de Rooy from comment #109) > There is still something confusing in the table design: > select * from l10n_source; > +----------------+----------+-----+------------------------+ > | l10n_source_id | group | key | text | > +----------------+----------+-----+------------------------+ > | 1 | itemtype | BK | Books | > | 2 | itemtype | BKS | Books | > | 3 | itemtype | CF | Computer Files | > select * from l10n_target; > +----------------+----------------+----------+-----------------+-------+ > | l10n_target_id | l10n_source_id | language | translation | fuzzy | > +----------------+----------------+----------+-----------------+-------+ > | 2 | 1 | nl-NL | Boek | 0 | > | 3 | 2 | en | BKS_EN | 0 | > | 4 | 2 | nl-NL | Boek | 0 | > The source seems to be the English text. But I can translate it into EN > again via target. Easiest seems to be: prevent having EN in the target table. The source (l10n_source.text) also contain the default in case there is no translation. We should keep it. > Shouldnt we check if we are calling db_t btw for an English translation? We > should not be looking for the English translation of itemtype if we have the > description already in our object. If we are not doing worst with this patch than before, I would not recommend to add more to it. First step should be to have something pushed that is stable. Then we can iterate and improve. (In reply to Marcel de Rooy from comment #110) > db_t could be made more flexible? Now we look for key and we removed > description. But I think we should support both. No, that's the whole point of the discussion earlier. We should go with the key. At least not for now. > Not sure how the concept of localization group will grow. But it might be > too big soon for loading all its sources and finding corresponding > translations. (The code needs a join here.) For instance, thinking about AV, > I am probably only interested in a particular category and not in all > entries under 'authorised_values' if that was the group. Other areas may > have other needs again. > This is a quite fundamental issue on the design of db_t. It feels not > complete. Well, it's cached, I would not care much about performances here, that should not be a problem if we are doing things correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:22:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:22:10 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-hEKeiDPePH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:28:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:28:18 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-LiHI6Mkaqh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149954|0 |1 is obsolete| | Attachment #149956|0 |1 is obsolete| | Attachment #149957|0 |1 is obsolete| | --- Comment #114 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150015&action=edit Bug 24975: Simplify and uniform calls to get the translation This patch add a caching mecanism for ItemType objects. We are also caching the result of the image location and the translation key so that we can retrieve from the cache and pass them to the temmplate. We should avoid call to db_t in the controller scripts, and prefer to pass the itemtype object and let the template does what it needs (retrieve the translated description, display the image) Note that the new Koha::Template::Plugin::ItemTypes->GetSorted should certainly be used in other places, for instance in * catalogue/search.pl sub prepare_adv_search_types * opac/opac-search.pl but those 2 occurrences are tricky and we would like to prevent regressions (as much as possible...) A major change is the modification of the prototype of search_compat, I am not sure this patch is updating all the template when the result of the search is passed. Note that Koha::SearchEngine::Elasticsearch::Search could use Koha::ItemTypes->get_from_cache, and certainly other places as well(?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:28:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:28:39 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-Qr7PCTfWq1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147499|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150016&action=edit Bug 32894: Remove wrong caching from Koha:: methods - simple In some of our Koha:: objects we have methods that cache their result and return it in subsequent calls. However there is no invalidation of the cache if the object is modified. For instance, in Koha/ArticleRequest.pm sub biblio { my ($self) = @_; $self->{_biblio} ||= Koha::Biblios->find( $self->biblionumber() ); return $self->{_biblio}; } This pattern exists in several places. It can lead to confusion and incorrect results, such as: use Koha::ArticleRequests; my $ar = Koha::ArticleRequest->new({ borrowernumber => 42, biblionumber => 42, })->store; say $ar->biblio->biblionumber; # Display 42, correct $ar->set({ biblionumber => 24 })->store; say $ar->biblio->biblionumber; # Display 42, wrong $ar->discard_changes; say $ar->biblio->biblionumber; # Display 42, wrong $ar->delete; We should remove those caching and rely on DBIC/DBMS caching mechanism instead. This patch is adjusting the trivial occurrences Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:28:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:28:42 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-Kr6xe4pwT1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147500|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150017&action=edit Bug 32894: Koha::Item->last_returned_by Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:28:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:28:44 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-ZQeoDAqEv6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147502|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150018&action=edit Bug 32894: Koha::Biblio->biblioitem Can we do better here? Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:28:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:28:47 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-VsiQFQLrBs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147503|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150019&action=edit Bug 32894: Fix test Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:28:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:28:49 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-z8fA4cwdpV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150020&action=edit Bug 32894: Remove incorrect caching from bundle_items Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:28:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:28:52 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-dbjHCCgdD2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150021&action=edit Bug 32894: (QA follow-up) Fix typo Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:29:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:29:03 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-NAiBcQ6gjd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #115 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I haven't spent much time testing this patch, but attaching to get feedback if possible. TODO tests are missing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:29:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:29:04 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-vf53MaA4Ny@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:30:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:30:07 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-A6NhcyWUlA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Added a tiny typo fix and also a patch for item_bundles. I agree.. lets to Koha::Objects as it's own bug. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:35:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:35:17 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16223-70-dyWpWnx5uu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31095 |33574 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:35:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:35:17 +0000 Subject: [Koha-bugs] [Bug 31095] Remove Koha::Patron::Debarment::GetDebarments and use $patron->restrictions in preference In-Reply-To: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31095-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31095-70-e8C4N302po@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|16223 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 [Bug 16223] Automatically remove any borrower debarments after a payment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:35:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:35:17 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-mP0egcnZD6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 [Bug 16223] Automatically remove any borrower debarments after a payment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:35:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:35:46 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-v0DOth5EgG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:35:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:35:48 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-gGTGM7CZXV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:39:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:39:18 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32642-70-RZ2vOIQXma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:39:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:39:20 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32642-70-H0bx9NNGME@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149251|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150022&action=edit Bug 32642: Loading spinner always visible when cover image is short (OPAC) We noticed that if the cover image is somewhat short (i.e. the height is under 80-90 px), the loading spinner indicating that the image is currently loading still appears after the image is loaded. this patch remove the spinner when the image is loaded,. To test: 1. Make sure the OPACLocalCoverImages system preference is enabled 1.1. Go to Administration > Global system preferences 1.2. Search for Coverimages 1.3. Set OPACLocalCoverImages to 'Show' 1.4. Click 'Save all Enhanced content preferences' 2. Add a short local cover image to a record (I added one which is just a grey rectangle with the size printed on it, to facilitate the test) 2.1. Download the attached image 2.2. Find a record without an image 2.3. Click the 'Images' tab 2.4. Click 'Upload' 2.5. Click 'Drop files here or click to select a file' and choose the downloaded image 2.6. Click 'Process images' 3. View the record in the OPAC 3.1. From the image upload page, click on the title of the record in the page heading to access the detailed record in the staff interface 3.2. Click on 'OPAC view: Open in new window.' --> Note that the image is displayed normally, but the spinner is also displayed 4. Apply the patch 5. View the record in the OPAC --> Note that the spinner is no more displayed Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> This needs a follow-up; the code in this template activates the spinner actually when the job has been done already and did not remove it. And we did not see that but only with a short image like above. The construction with .one, .each is not needed given the execution context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:39:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:39:23 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32642-70-mxA14blXbu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 --- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150023&action=edit Bug 32642: (QA follow-up) Activate spinner early See comment on former patch too. We need to activate the spinner early and we can simplify the code to remove it. Note: unfortunately this is kind of a workaround, since using load would be nicer but currently hard to implement since the cover image code is scattered/widespread. This code still checks the complete attribute, we could argue that it should just remove the spinner. Note too that the spinner belongs to a div where multiple img may be part of. If we do not remove the spinner now, something went wrong at load time, but if you can actually see the spinner is another thing. Test plan: See former patch. Check few cover images on detail page, enable various providers. Bonus: I tested with a sleep statement in opac-image.pl. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:40:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:40:09 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16223-70-bTog02jAI3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148307|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150024&action=edit Bug 16223: Add new columns to table restriction_types This patch adds two new columns, lift_after_payment and fee_limit, to table restriction_types. These colums are used to control lifting patrons restrictions after paying their fees. To test: 1. Apply this patch. 2. Update your database via updatedatabase.pl. => Confirm your table restriction_types has two new columns. Sponsored-by: Koha-Suomi Oy Signed-off-by: Anneli Österman <anneli.osterman at koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:40:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:40:13 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16223-70-B4Rv9etbJ1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148308|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150025&action=edit Bug 16223: DO NOT PUSH! Schema changes Sponsored-by: Koha-Suomi Oy Signed-off-by: Anneli Österman <anneli.osterman at koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:40:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:40:16 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16223-70-Ey4qVBTm0F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148309|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150026&action=edit Bug 16223: Add ability to define liftable restrictions Some libraries debar Patrons at the end of the year for having unpaid fines, like in Bug 15157. Currently librarians have to manually remove this type of debarments after Patron has paid his/her fines. This patch adds ability to create restrictions which are lifted after patron pays ceratain amount of fines. To test: 1. Apply this patch. 2. Restart your services if needed. 3. Navigate to page restrictions.pl. => Note that table has two new colums in it, "Lift after payment?" and "Fee limit". 4. Add new restriction which has "Lift after payment?" set as Yes and fee limit as 5. 5. Create fees for a patron so they exceed fee limit e.g. 10 6. Add restriction made in step 2. for the patron 7. Pay patrons fees partially so that they go under fee limit => Note that patrons restriction should now be lifted. Also prove t/db_dependent/Patron/Borrower_Debarments.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: Anneli Österman <anneli.osterman at koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:40:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:40:20 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16223-70-rzQ7jPjZDe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148310|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150027&action=edit Bug 16223: (QA follow-up) Remove GetDebarments We remove the GetDebarments routine in 31095. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:40:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:40:24 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16223-70-6qM96E9f1S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148311|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150028&action=edit Bug 16223: (QA follow-up) Move trigger to apply This patch moves the del_restrictions_after_payment from before the actual credit application call inside Koha::Account::pay to after the application of credits to debits in Koha::Account::Line::apply. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:40:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:40:28 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16223-70-mHlwfxEoCB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148313|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150029&action=edit Bug 16223: Require fee limit only if "Lift after payment" is set as "Yes" Fee limit should only be required if restriction is meant to be lifted after payment. This patch makes "Fee limit" input field required based on value of "Lift after payment" select field. To test: 1. Create a new restriction. 2. "Lift after payment" should be set as "No". 3. Change value as "Yes". => "Fee limit" should now have "Required" text after input field. 4. Try to save restriction. => Text "This field is required" should be displayed after "Fee limit". 5. Change "Lift after payment" back to "No". => Both texts should now be lifted. Also test with existing restriction and make sure restrictions are still saved without problems. Sponsored-by: Koha-Suomi Oy Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:41:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:41:08 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16223-70-UiY9ZgiEZT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit |.com |y.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 12:50:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 10:50:27 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-iR77GmjJVj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 150030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150030&action=edit Data creation script Script for creating licenses to test patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 13:05:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 11:05:09 +0000 Subject: [Koha-bugs] [Bug 28314] Spinning icon is not always going away for local covers in staff In-Reply-To: <bug-28314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28314-70-asdpqQRbSO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28314 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- This code may get further attention. See change on 32642 for OPAC. The line $(coverSlide).addClass("cover-slides"); is actually hilarious, since we start showing the spinner after all images have been loaded. And then rightaway try to remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 13:09:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 11:09:19 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-NaxpIA7XcG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 150031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150031&action=edit Bug 32474: Infinite scroll v-selects This patch is an example ajax based v-select. The v-select will load the first 20 items and then continue to load paginated sections of 20 items as the user scrolls down. The v-select also offers ajax based searches (unpaginated) and will return to 20 item pagination if the search is cleared. Currently the pagination just works with an Intersection Observer based on scrolling - the main issue with this is that the size of the v-select window changes every time new data is added to the list and this causes the scrollbar to jump before resetting at the correct size. This can be a bit annoying, especially when scrolling quickly. The only way round this will either be to paginate using buttons i.e. (previous/next page) or to limit the data to 20 items at all times and re-paginate when scrolling back up - interested to hear thoughts/suggestions on this or whether anyone has a magic CSS fix that solves it ;) The new v-select is only in one location so far as a test - Agreement Licenses Test plan: 1) You will need to add multiple licenses in order to see the pagination, attached is a script that will create 100 dummy licenses at a time if you wish to use that 2) Once licenses are created, apply patch and run yarn build 3) Navigate to Agreements and click the New Agreement button 4) Scroll down to the Add new license option and click the button 5) The License select is the InfiniteScrollSelect and should display the licenses you have added 6) Open the dropdown and 20 items will be listed 7) Scroll down and as you scroll, more items will be loaded (this can be seen in the Network tab in developer tools) 8) Enter a search query and the results should reflect the search query 9) Delete the search query and the dropdown should return to the first 20 paginated items and pagination will work again when scrolling 10) Try submitting the form with paginate/searched options and the form should still work as intended -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 13:09:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 11:09:22 +0000 Subject: [Koha-bugs] [Bug 33580] New: Bring back ability to mark item as seen via SIP2 item information request Message-ID: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Bug ID: 33580 Summary: Bring back ability to mark item as seen via SIP2 item information request Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Prior to Koha 22.05, the SIP2 item information message had a side affect of updating the datelastseen field for items. This bug has been fixed, but was being utilized by inventory tools that used SIP2. We should bring back this affect and formalize it as an optional SIP2 config account setting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 13:09:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 11:09:36 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-QS7MBtWtd5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 13:10:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 11:10:16 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-gVyYOAH2Lu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 13:10:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 11:10:17 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-EJNSyRkDI1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150032&action=edit Bug 33580 - Bring back ability to mark item as seen via SIP2 item information request Prior to Koha 22.05, the SIP2 item information message had a side affect of updating the datelastseen field for items. This bug has been fixed, but was being utilized by inventory tools that used SIP2. We should bring back this affect and formalize it as an optional SIP2 config account setting. Test Plan: 1) Apply this patch set 2) prove t/db_dependent/SIP/Message.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 13:14:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 11:14:47 +0000 Subject: [Koha-bugs] [Bug 33574] Restriction type is not stored, all restrictions fall back to MANUAL In-Reply-To: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33574-70-m9trhZW77o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33574 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 13:22:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 11:22:04 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-tNsR3OFV9n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #116 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- TODO: * Add the entries into l10n_* tables when a new item type is created. * Remove them when the item type is deleted? * What to do when the description of an item type is modified? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 13:26:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 11:26:13 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-svGgD3Wdgn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #117 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150033&action=edit Bug 24975: to squash - fix search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 13:31:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 11:31:41 +0000 Subject: [Koha-bugs] [Bug 33472] Error 500 when many items attached to bib record In-Reply-To: <bug-33472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33472-70-MKKew5Xkaf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33472 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 13:33:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 11:33:00 +0000 Subject: [Koha-bugs] [Bug 33581] New: Error in Webinstaller concerning sample holidays Message-ID: <bug-33581-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Bug ID: 33581 Summary: Error in Webinstaller concerning sample holidays Change sponsored?: --- Product: Koha Version: 22.11 Hardware: Other OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Holidays Assignee: koha-bugs at lists.koha-community.org Reporter: anke.bruns at gwdg.de QA Contact: testopia at bugs.koha-community.org If sample holidays are chosen in the onboarding tool, there is an error message: sample_libraries_holidays.yml DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_pks`.`repeatable_holidays`, CONSTRAINT `repeatable_holidays_ibfk_1` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE) at /usr/share/koha/lib/C4/Installer.pm line 575. This is probably due to the fact that at that stage no branches have yet been created for the instance. It would probably with sample branches chosen but it should work also without the sample branches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 13:35:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 11:35:19 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-9AbRAKr4Nt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150033|0 |1 is obsolete| | --- Comment #118 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150034&action=edit Bug 24975: to squash - fix search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 13:45:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 11:45:34 +0000 Subject: [Koha-bugs] [Bug 2500] Standing enhancement request for adding/updating call number splitting algorithms in C4/Labels.pm In-Reply-To: <bug-2500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2500-70-XAskIqp7fx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2500 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:02:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:02:22 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-O0vUR5kbHy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #119 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #116) > TODO: > * Add the entries into l10n_* tables when a new item type is created. > * Remove them when the item type is deleted? > * What to do when the description of an item type is modified? There are stuffs in Koha/Schema/Result/Itemtype.pm to deal with that actually. I need to retest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:02:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:02:29 +0000 Subject: [Koha-bugs] [Bug 33572] Use template wrapper for breadcrumbs: Tools, part 3 In-Reply-To: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33572-70-f6kVjtuThZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33572 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:02:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:02:31 +0000 Subject: [Koha-bugs] [Bug 33572] Use template wrapper for breadcrumbs: Tools, part 3 In-Reply-To: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33572-70-dXtYf9e4Ai@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33572 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150035&action=edit Bug 33572: Use template wrapper for breadcrumbs: Tools, part 3 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - CSV profiles - New CSV profile - Edit CSV profile - Calendar - Import patrons - Results - Cataloging -> - Export catalog data - Inventory - Results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:10:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:10:12 +0000 Subject: [Koha-bugs] [Bug 33582] New: Use template wrapper for breadcrumbs: Tools, part 4 Message-ID: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 Bug ID: 33582 Summary: Use template wrapper for breadcrumbs: Tools, part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more tools templates so that they use the new template wrapper for breadcrumbs. - tools/letter.tt - tools/manage-marc-import.tt - tools/marc_modification_templates.tt - tools/modborrowers.tt - tools/overduerules.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:10:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:10:12 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32507-70-X76vYR2zMp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:13:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:13:24 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-zw2r5WeByV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27421 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:13:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:13:24 +0000 Subject: [Koha-bugs] [Bug 27421] Porting tools/stage-marc-import.pl to BackgroundJob In-Reply-To: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27421-70-n5Zfdeax9h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27421 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33576 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 [Bug 33576] Records are not indexed when imported if using Elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:21:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:21:33 +0000 Subject: [Koha-bugs] [Bug 32668] Automatic debian/control updates (oldoldstable) In-Reply-To: <bug-32668-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32668-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32668-70-KwZs0U8Y3X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32668 --- Comment #11 from Mason James <mtj at kohaaloha.com> --- (In reply to Mason James from comment #6) > (In reply to Katrin Fischer from comment #3) > > Does this need QA? In the past I think the packaging managers just went > > straight to PQA. > > hiya, i doesnt really need QA, as it is automated > > i'll modify the script to set to PQA hi Arthur, can we push this please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:25:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:25:07 +0000 Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25870-70-wmmdxWKwXi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #36 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- You really need to perform the search against the search engine, with any implicit filtering like OpacHiddenItems added to the CCL query. Otherwise you would kill the interesting bit of searching on the backend. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:38:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:38:33 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31479-70-NL3bzzg5XW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:38:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:38:36 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31479-70-Gx65Xx7CEH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139934|0 |1 is obsolete| | --- Comment #2 from Mason James <mtj at kohaaloha.com> --- Created attachment 150036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150036&action=edit Bug 31479: Option to skip t/00-check-atomic-updates.t when building custom packages This enhancement adds an option to skip the check for leftover atomic updates when building custom packages. This is particularly useful for Koha providers or anyone else building Koha packages manually. In practice, this could be run like: sudo CUSTOM_PACKAGE=1 ./debian/build-git-snapshot -r ~/debian -v 21.11.01git -d This test plan should all take place within the shell. 0. sudo koha-shell kohadev 1. Run prove t/00-check-atomic-updates.t and confirm the test passes 2. Add a fake atomic update to installer/data/mysql/atomicupdate/ . You can use the example from https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file 3. Run prove t/00-check-atomic-updates.t and notice the test fails 4. Set the CUSTOM_PACKAGE environment variable so we can test this. You can either set on the commandline (using export) or in /etc/environment (remember to run source /etc/environment so the changes are accessed) 5. Run prove t/00-check-atomic-updates.t and the test should now pass. Sponsored-by: Catalyst IT Signed-off-by: Mason James <mtj at kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:39:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:39:19 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31479-70-jcQksSgBXf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #3 from Mason James <mtj at kohaaloha.com> --- signing off, looks good to me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:41:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:41:49 +0000 Subject: [Koha-bugs] [Bug 33583] New: Put back the biblionumber coloumn in batch records import table Message-ID: <bug-33583-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33583 Bug ID: 33583 Summary: Put back the biblionumber coloumn in batch records import table Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: noemie.labine at collecto.ca QA Contact: testopia at bugs.koha-community.org Hi, In 21.05, the record column in the batch records import table displayed the biblionumber of the imported record. Now, this column displays 2 buttons : edit and view. It would be nice to keep those two buttons but also have the option to have the biblionumber displayed in that table. A couple of libraries would use this table to export a list of records to edit (add an image, edit the items, etc.) after the import. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:42:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:42:01 +0000 Subject: [Koha-bugs] [Bug 33583] Put back the biblionumber coloumn in batch records import table In-Reply-To: <bug-33583-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33583-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33583-70-FTi58lNQ55@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33583 NoĂ©mie Labine <noemie.labine at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca, | |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:42:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:42:15 +0000 Subject: [Koha-bugs] [Bug 33583] Put back the biblionumber column in batch records import table In-Reply-To: <bug-33583-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33583-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33583-70-ts2pOug7KO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33583 NoĂ©mie Labine <noemie.labine at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Put back the biblionumber |Put back the biblionumber |coloumn in batch records |column in batch records |import table |import table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:46:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:46:44 +0000 Subject: [Koha-bugs] [Bug 24977] Enable translations for authorised values (POC) In-Reply-To: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24977-70-ndGJvdtZjh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150037&action=edit Bug 24977: WIP Adjust and continue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:48:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:48:04 +0000 Subject: [Koha-bugs] [Bug 24977] Enable translations for authorised values (POC) In-Reply-To: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24977-70-7QB846TzSy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24977 --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- hum I feel like I am not going into the correct direction with AVs, I am concerned by perf impact here. See FIXMEs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:51:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:51:43 +0000 Subject: [Koha-bugs] [Bug 29942] Spurious commit in mysql session storage In-Reply-To: <bug-29942-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29942-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29942-70-U9Uqpda7RY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29942 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- (In reply to Marcel de Rooy from comment #2) > Koha::Session should not be that hard to write given the specs? Agreed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:56:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:56:06 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-ZgzlnMkcop@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #30 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150038&action=edit Bug 33490: Rollback computed Use a watch instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:56:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:56:09 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-axh9yHwOYx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #31 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150039&action=edit Bug 33490: Fix ambiguous query error Doing actual testing with some agreements with expired periods, this was returning a 500 error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 14:56:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 12:56:12 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-1VaejFsvj8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #32 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150040&action=edit Bug 33490: Add test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:03:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:03:37 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-6vtxEN7rZR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #33 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Getting 400 when hitting /erm/agreements?by_expired=true But I don't think it's blocker now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:10:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:10:54 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-QsVX3auGvN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #34 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Tests are using 'today_us' that was not used. That means that the tests will fail if dateformat is not the value from the sample data. Not ideal but better to have a test. + cy.url().should('include', "/cgi-bin/koha/erm/agreements?by_expired=true"); // Browser url also updated Should not we adjust this test? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:17:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:17:30 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-A9hZ4gLERi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:08 +0000 Subject: [Koha-bugs] [Bug 26967] Patron autocomplete does not correctly format addresses In-Reply-To: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26967-70-hkzuvFK36k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26967 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:10 +0000 Subject: [Koha-bugs] [Bug 26967] Patron autocomplete does not correctly format addresses In-Reply-To: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26967-70-Wd1KefpLWE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26967 --- Comment #9 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:12 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-e2DG5KUoVx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:14 +0000 Subject: [Koha-bugs] [Bug 31432] MARC21: Make 245 n and p subfields visible in frameworks by default In-Reply-To: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31432-70-BGTYdKwbKo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31432 --- Comment #9 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:15 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-sVsSO015TU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:17 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-HDbRwCWoM8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 --- Comment #17 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:19 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32642-70-jSfadt65Yz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:21 +0000 Subject: [Koha-bugs] [Bug 32642] Loading spinner always visible when cover image is short (OPAC) In-Reply-To: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32642-70-txBalPFCTS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32642 --- Comment #28 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:23 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33127-70-N8131yT3Ma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:25 +0000 Subject: [Koha-bugs] [Bug 33127] Use template wrapper for breadcrumbs: Administration part 5 In-Reply-To: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33127-70-FFeVvbrrb2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33127 --- Comment #8 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:27 +0000 Subject: [Koha-bugs] [Bug 33210] (Bug 31963 follow-up) No hold fee message on OPAC should be displayed when there is no fee In-Reply-To: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33210-70-tQUlEIbbAC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33210 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:29 +0000 Subject: [Koha-bugs] [Bug 33210] (Bug 31963 follow-up) No hold fee message on OPAC should be displayed when there is no fee In-Reply-To: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33210-70-qeBx4m2bga@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33210 --- Comment #10 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:31 +0000 Subject: [Koha-bugs] [Bug 33310] Use template wrapper for tabs: Suggestions In-Reply-To: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33310-70-XqIyZXXTA0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33310 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:33 +0000 Subject: [Koha-bugs] [Bug 33310] Use template wrapper for tabs: Suggestions In-Reply-To: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33310-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33310-70-B78k5cEHmc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33310 --- Comment #7 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:35 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33388-70-RkWLN7B0a2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:36 +0000 Subject: [Koha-bugs] [Bug 33388] Use template wrapper for breadcrumbs: Patrons part 4 In-Reply-To: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33388-70-OGAaVDaIlD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33388 --- Comment #10 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:38 +0000 Subject: [Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3 In-Reply-To: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33438-70-RlOGea5m95@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:40 +0000 Subject: [Koha-bugs] [Bug 33438] Use template wrapper for breadcrumbs: Reports part 3 In-Reply-To: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33438-70-1DblkMQJl4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33438 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:42 +0000 Subject: [Koha-bugs] [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4 In-Reply-To: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33439-70-GYWCt8m7O8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:44 +0000 Subject: [Koha-bugs] [Bug 33439] Use template wrapper for breadcrumbs: Reports part 4 In-Reply-To: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33439-70-uhJsVpgXke@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33439 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:46 +0000 Subject: [Koha-bugs] [Bug 33555] Use template wrapper for breadcrumbs: Rotating collections In-Reply-To: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33555-70-7dZMMUVNQc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:48 +0000 Subject: [Koha-bugs] [Bug 33555] Use template wrapper for breadcrumbs: Rotating collections In-Reply-To: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33555-70-Cu8aKkzp5C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33555 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:49 +0000 Subject: [Koha-bugs] [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1 In-Reply-To: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33558-70-48I2EfzVCz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:37:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:37:51 +0000 Subject: [Koha-bugs] [Bug 33558] Use template wrapper for breadcrumbs: Serials part 1 In-Reply-To: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33558-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33558-70-oEme69OahZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33558 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:39:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:39:17 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-QNGu8PtUwQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Raising severity as the linker currently doesn't successfully index for Elasticsearch due to a race condition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 15:53:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 13:53:04 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-sim0Vi8MOV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:04:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:04:52 +0000 Subject: [Koha-bugs] [Bug 31256] Circ rules batch modification In-Reply-To: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31256-70-znXcRkpSgO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Hi all, it's not an overall solution to batch edit rules (I honestly have no idea what that would look like or what it would entail), but a lot of schools might find this plugin useful to change hard due dates in batch https://inlibro.com/en/koha-plugins/#rule-hard-due-date . It's not perfect, as few plugins are imo, but a usable alternative to manually changing hard due dates until it's possible to batch edit rule in the koha interface. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:20:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:20:07 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-kJ4vqoqMac@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150041&action=edit Bug 33575: (follow-up) don't allow priority and pickup location to be hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:23:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:23:05 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-lCqqYtlamN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Sally, thanks for your testing! I have provided a follow-up so you cannot hide the priority or pickup location columns. I also added a hidden span to the set lowest priority <th> so that when you try to hide/show the columns using the button above the table you will see the name of the column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:23:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:23:12 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-DIhbAg7lh9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146589|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150042&action=edit Bug 31187: Preserve permanent_location if it is mapped to a field in the editor To test: 1 - Map permanent_location to a marc field 2 - Expose that field in the item editor 3 - Cataloging -> Batch item modification 4 - Enter the barcode for an item 5 - Change the location of the item and retain the permanent location on saving 6 - note that permanent location is set to locatoin 7 - Apply patch 8 - Repeat 9 - Note permanent location is retained -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:23:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:23:32 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-dZ0I8ADhf4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:23:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:23:35 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-igzrNOpFsI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149883|0 |1 is obsolete| | --- Comment #21 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150043&action=edit Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:23:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:23:38 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-eCdaESNeBg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149884|0 |1 is obsolete| | --- Comment #22 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150044&action=edit Bug 33355: Update forms markup to be in line with interface patterns https://wiki.koha-community.org/wiki/Interface_patterns Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:23:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:23:41 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-qpGW1TjRrx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149885|0 |1 is obsolete| | --- Comment #23 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150045&action=edit Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:33:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:33:45 +0000 Subject: [Koha-bugs] [Bug 32752] Add new serial issue status: "Out for binding", "Bound", and "Circulating" In-Reply-To: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32752-70-33x9BlLt6X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32752 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:34:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:34:17 +0000 Subject: [Koha-bugs] [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 In-Reply-To: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33566-70-h1RERGgMB5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Failed QA --- Comment #2 from Barbara Johnson <barbara.johnson at bedfordtx.gov> --- Everything works fine except I in the the News area. When I go to News > Edit Entry the end of the breadcrumb displays (1 News ) instead of just (News) Any entry you click on always says (1 News ) which I don't think is the intent. Also there is an extra space between News and the closing parenthesis. Home > Tools > News > Modify additional content (1 News ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:37:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:37:40 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-eIgKnrUIgz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:37:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:37:42 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-lCRGp7xL5Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150042|0 |1 is obsolete| | --- Comment #10 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Created attachment 150046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150046&action=edit Bug 31187: Preserve permanent_location if it is mapped to a field in the editor To test: 1 - Map permanent_location to a marc field 2 - Expose that field in the item editor 3 - Cataloging -> Batch item modification 4 - Enter the barcode for an item 5 - Change the location of the item and retain the permanent location on saving 6 - note that permanent location is set to locatoin 7 - Apply patch 8 - Repeat 9 - Note permanent location is retained Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:39:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:39:32 +0000 Subject: [Koha-bugs] [Bug 33571] Use template wrapper for breadcrumbs: Tools, part 2 In-Reply-To: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33571-70-P6AK7C0Nj2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33571 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149958|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 150047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150047&action=edit Bug 33571: Use template wrapper for breadcrumbs: Tools, part 2 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Batch patron deletion and anonymization - Confirmation - Results - Cataloging -> - Batch item modification - Batch item deletion - Batch record modification - Results Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:39:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:39:56 +0000 Subject: [Koha-bugs] [Bug 33571] Use template wrapper for breadcrumbs: Tools, part 2 In-Reply-To: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33571-70-okle16NmVU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33571 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:40:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:40:41 +0000 Subject: [Koha-bugs] [Bug 30910] Allow local definition of temporary shelving locations In-Reply-To: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30910-70-VrttTsaHsN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30910 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:47:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:47:16 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-5ZAr3Cw0yI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150040|0 |1 is obsolete| | --- Comment #35 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150048&action=edit Bug 33490: Add test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:47:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:47:36 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-23zPoJRJQw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #36 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- (In reply to Jonathan Druart from comment #34) > Tests are using 'today_us' that was not used. That means that the tests will > fail if dateformat is not the value from the sample data. > > Not ideal but better to have a test. > > > + cy.url().should('include', > "/cgi-bin/koha/erm/agreements?by_expired=true"); // Browser url also updated > > Should not we adjust this test? The flatpickr input in the UI is using today_us e.g. 04/20/2023 The flatpickr element attribute that stores the date is today_iso e.g. 2023-04-20 The URL dateformat is today_iso e.g. 2023-04-20 There was a slight difference in the selector ("+input") of my test. Adjusted now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:48:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:48:54 +0000 Subject: [Koha-bugs] [Bug 33572] Use template wrapper for breadcrumbs: Tools, part 3 In-Reply-To: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33572-70-K7wzlh0iAY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33572 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150035|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 150049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150049&action=edit Bug 33572: Use template wrapper for breadcrumbs: Tools, part 3 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - CSV profiles - New CSV profile - Edit CSV profile - Calendar - Import patrons - Results - Cataloging -> - Export catalog data - Inventory - Results Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:49:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:49:43 +0000 Subject: [Koha-bugs] [Bug 33572] Use template wrapper for breadcrumbs: Tools, part 3 In-Reply-To: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33572-70-ahJlBgTtIy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33572 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:50:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:50:06 +0000 Subject: [Koha-bugs] [Bug 31167] Only mark due dates in the past red on overdues report In-Reply-To: <bug-31167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31167-70-W45BQulszI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31167 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I confirm this is still valid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:55:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:55:38 +0000 Subject: [Koha-bugs] [Bug 33565] Use template wrapper for breadcrumbs: Tags In-Reply-To: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33565-70-80F6poeuXq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33565 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149911|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 150050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150050&action=edit Bug 33565: Use template wrapper for breadcrumbs: Tags This patch updates two tags templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Tags - Click a tag to see titles with that tag Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 16:59:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 14:59:38 +0000 Subject: [Koha-bugs] [Bug 32752] Add new serial issue status: "Out for binding", "Bound", and "Circulating" In-Reply-To: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32752-70-CvPFcUKkvh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32752 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #27 from Lucas Gass <lucas at bywatersolutions.com> --- Works as described. The template changes look good. Checked all the HTML and everything is valid. QA scripts are happy. Nice enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:00:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:00:56 +0000 Subject: [Koha-bugs] [Bug 32752] Add new serial issue status: "Out for binding", "Bound", and "Circulating" In-Reply-To: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32752-70-JqSuGnU0Yi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32752 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:00:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:00:58 +0000 Subject: [Koha-bugs] [Bug 32752] Add new serial issue status: "Out for binding", "Bound", and "Circulating" In-Reply-To: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32752-70-xmHxcIfuac@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32752 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148370|0 |1 is obsolete| | --- Comment #28 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150051&action=edit Bug 32752: Use an include for displaying the serial status in the OPAC This moves the existing status in the OPAC into an include. To test: * Add a subscription with issues in different status * View the OPAC detail page of the record * Verify that in the subscription tab the status display nicely * Veriy that More details > Full history displays the status nicely too Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:01:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:01:00 +0000 Subject: [Koha-bugs] [Bug 32752] Add new serial issue status: "Out for binding", "Bound", and "Circulating" In-Reply-To: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32752-70-2pFcaRFmqx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32752 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148371|0 |1 is obsolete| | --- Comment #29 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150052&action=edit Bug 32752: Use an include to display the serial status in the staff interface This moves the identical code used to display the serial status from the different templates into one common include. To test: * Add a subscription * Receive several issues, make sure 2 are late * Claim one of the late issues * Verify the status displays nicely on these pages: * Subscription detail page > issues tab * Catalog detail page > subscription tab * Serial claims page * Serial collection page of your subscription Note: there was some code for the subscription detail page that should have displayed the claim date, but didn't work. To keep things simpler and identical to before, I have left that bit out for now. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:01:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:01:03 +0000 Subject: [Koha-bugs] [Bug 32752] Add new serial issue status: "Out for binding", "Bound", and "Circulating" In-Reply-To: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32752-70-9S9stVdSCV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32752 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148372|0 |1 is obsolete| | --- Comment #30 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150053&action=edit Bug 32752: Add new status Circulating, Out for binding, and Bound to includes To test with the next patch that allows to set the new status. Sponsored-by: The Research University in the Helmholtz Association (KIT) Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:01:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:01:05 +0000 Subject: [Koha-bugs] [Bug 32752] Add new serial issue status: "Out for binding", "Bound", and "Circulating" In-Reply-To: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32752-70-PXifbd3LgF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32752 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148490|0 |1 is obsolete| | --- Comment #31 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150054&action=edit Bug 32752: Update serial edit form to allow for new status With this patch the new status Circulating, Out for binding and Bound can be set for any issue, if the current status is not "Expected". This is to keep the list a little shorter when the issue hasn't even arrived in the library yet. These new status will be especially helpful if the library has opted to not create items for all their subscriptions as a lot of libraries will only lend bound volumes, but not the singular issues. * Circulating: this will be useful if the library is using routing lists and the items are not available at the library for a longer time. * Out for binding: if you send out issues for binding this will help to track these. * Bound: this will help users to know that the issue is now available as a bound volume. To test: * If you haven't yet: * Create a subscription * From the serial collection page: * Receive or create several issues and set different status * Make sure you have at least 2 late and claim one of them * Make sure you have several Arrived issues * Edit Arrived serial issues and others * Verify that the status pull down no also shows the new status if the issue has a different status than "Expected" * Set the new status * Verify they save and show correctly * Edit again and verify the pull downs are pre-set correctly to the saved status * Verify they show everywhere else (see previous test plans :) ) Signed-off-by: Michaela Sieber <michaela.sieber at kit.edu> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:11:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:11:31 +0000 Subject: [Koha-bugs] [Bug 33025] Show an alert when adding a lost item to an item bundle In-Reply-To: <bug-33025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33025-70-GOyUa67sYg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33025 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:25:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:25:15 +0000 Subject: [Koha-bugs] [Bug 31349] Add option to not update items.permanent_location when editing items.location In-Reply-To: <bug-31349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31349-70-liwbueseUJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31349 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- Apparently I posited a different solution on 30910, one I like better. Good job, other me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:27:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:27:12 +0000 Subject: [Koha-bugs] [Bug 33025] Show an alert when adding a lost item to an item bundle In-Reply-To: <bug-33025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33025-70-EKkFCzFKsb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33025 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:27:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:27:18 +0000 Subject: [Koha-bugs] [Bug 33025] Show an alert when adding a lost item to an item bundle In-Reply-To: <bug-33025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33025-70-8WYIBoAHCL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33025 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle at bywatersolutions.com |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:27:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:27:39 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-y5LnMu8M6N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Marius <marius.mandrescu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marius.mandrescu at inlibro.co | |m Attachment #149233|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:28:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:28:37 +0000 Subject: [Koha-bugs] [Bug 33584] New: Fix failures for Database/Commenter.t Message-ID: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 Bug ID: 33584 Summary: Fix failures for Database/Commenter.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org # Subtest: ->new, dry_run 1..6 ok 1 - No dbh ok 2 - dbh no string ok 3 - Schema deleted not ok 4 - No comment for toc_request not ok 5 - Numbered comment for toc_request not ok 6 - Reset for one-columned article_requests not ok 1 - ->new, dry_run 22:24:01 koha_1 | # Failed test 'No comment for toc_request' 22:24:01 koha_1 | # at t/db_dependent/Koha/Database/Commenter.t line 34. 22:24:01 koha_1 | # got: '0' 22:24:01 koha_1 | # expected: '1' 22:24:01 koha_1 | Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. => [sub renumber] next if $params->{table} && $col->{table_name} ne $params->{table}; Looks like we are reading info from another database or so, here: SELECT table_name, column_name, column_comment FROM information_schema.columns WHERE table_schema=? AND table_name=? ORDER BY table_name, column_name|; Or perhaps no permissions ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:28:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:28:44 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-QTuo5XtcQM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:28:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:28:49 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-VBOKuf5H49@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:28:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:28:59 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-jWnkXGBphl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:29:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:29:34 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-Q5FQJrDWxR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Failures second subtest should be related to problem in first: # Subtest: ->clear, ->reset, ->renumber 1..6 not ok 1 - Found no comment for sometext not ok 2 - Found no comment for anotherint ok 3 - Found comment for sometext ok 4 - Found comment for anotherint not ok 5 - Found Column_1 not ok 6 - Found Column_5 not ok 2 - ->clear, ->reset, ->renumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:32:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:32:02 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-OZ7djsvFge@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:33:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:33:38 +0000 Subject: [Koha-bugs] [Bug 33565] Use template wrapper for breadcrumbs: Tags In-Reply-To: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33565-70-8bVaI9Qzhy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33565 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150050|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 150055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150055&action=edit Bug 33565: Use template wrapper for breadcrumbs: Tags This patch updates two tags templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Tags - Click a tag to see titles with that tag Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:34:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:34:32 +0000 Subject: [Koha-bugs] [Bug 33565] Use template wrapper for breadcrumbs: Tags In-Reply-To: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33565-70-VCRiEA0sGV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33565 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:40:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:40:59 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9525-70-OYFQEZeplO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:41:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:41:31 +0000 Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep In-Reply-To: <bug-33190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33190-70-pH97i0zdnm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:41:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:41:51 +0000 Subject: [Koha-bugs] [Bug 33585] New: Remove javascript code duplicate in shelf browser Message-ID: <bug-33585-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33585 Bug ID: 33585 Summary: Remove javascript code duplicate in shelf browser Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: virgil.dupras at collecto.ca QA Contact: testopia at bugs.koha-community.org Created attachment 150056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150056&action=edit Initial patch The handling of JS "previous" and "next" links in the shelf browser duplicate non-trivial code, which increases the chances for accidental bugs and makes the integration of other cover providers harder than it should (that is, duplication is propagated to each further provider). This patch removes that duplication by harmonizing the "itemnumber" data element attached to the buttons and by making the jquery selector apply to both buttons at once. Test Plan: 1) Apply patch. 2) Open the detail page of a document with enough adjacent documents to have a more-than-full shelf. 3) Open the shelf for the document. 4) Click previous and check that the handler still does its thing as expected. 5) Same thing for Next. I'm new to Koha (and perl) and its development workflow, I hope that this bug report doesn't break too many rules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:42:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:42:03 +0000 Subject: [Koha-bugs] [Bug 33585] Remove javascript code duplication in shelf browser In-Reply-To: <bug-33585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33585-70-4bZL8Pfgf9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33585 Virgil Dupras <virgil.dupras at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove javascript code |Remove javascript code |duplicate in shelf browser |duplication in shelf | |browser -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:43:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:43:31 +0000 Subject: [Koha-bugs] [Bug 33585] Remove javascript code duplication in shelf browser In-Reply-To: <bug-33585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33585-70-bAERl6buec@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33585 Virgil Dupras <virgil.dupras at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:56:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:56:04 +0000 Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep In-Reply-To: <bug-33190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33190-70-a6GhA7HNpZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:56:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:56:06 +0000 Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep In-Reply-To: <bug-33190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33190-70-RCPtm3y5e1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148153|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150057&action=edit Bug 33190: Add search history button to advance search form if EnableSearchHistory keep Add 'search history' button to advanced search button groups if 'EnableSearchHistory' sys pref is set to 'keep' via added code block to advsearch.tt To test: 1) Login to Koha dev box instance 2) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 'Search history' icon will not be visible in tools groups in form. 3) Select 'koha administration' module '/cgi-bin/koha/admin/admin-home.pl' 4) Enter 'EnableSearchHistory' string into top search field 5) Change ' EnableSearchHistory' value to 'keep' 6) Press 'Save all Searching preferences' to save pref changes 7) Navigate back to Koha landing home '/cgi-bin/koha/mainpage.pl' 8) Select 'Advanced search module' '/cgi-bin/koha/catalogue/search.pl' 9) 'Search history' icon will now be visible in tools groups in form 10) SIGN OFF Signed-off-by: Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:56:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:56:26 +0000 Subject: [Koha-bugs] [Bug 9474] Merge "Overdues" and "Overdues with fines" reports In-Reply-To: <bug-9474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9474-70-WoyUQ9c6Lg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9474 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- >From usage*, here's what I can tell are the differences/what we should add to Overdues so that we can remove Overdues with fines - Overdues with fines allows to filter on shelving location, add this filter to Overdues - Overdues with fines is limited to logged in library (not sure if this is useful? Maybe add a default library syspref or permission for the overdues report so that those people who use Overdues with fines can still only see their library and don't have to manually add the filter each time?) - Overdues with fines only shows overdues with fines (duh!), add a filter to only show overdues with fines in the Overdues report I can't read the code, so I don't know if there's anything else going on in the back -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:56:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:56:49 +0000 Subject: [Koha-bugs] [Bug 33190] Add search history button to advance search form if EnableSearchHistory keep In-Reply-To: <bug-33190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33190-70-irEOEt6UZe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33190 --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- After trying half a dozen different things, I've come to the conclusion that the link is sufficiently self-explanatory as-is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 17:58:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 15:58:53 +0000 Subject: [Koha-bugs] [Bug 9313] Show fine amount on 'Overdues with fines' report In-Reply-To: <bug-9313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9313-70-RpoJ0S6zdH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9313 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I agree that "Overdues with fines" is a bit useless without actually showing the fines. Like Katrin, I think a "Fines" column should be added to "Overdues" (in addition to Overdues with fines if we don't get rid of it in bug 9474). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:00:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:00:13 +0000 Subject: [Koha-bugs] [Bug 33565] Use template wrapper for breadcrumbs: Tags In-Reply-To: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33565-70-mzoVGIjNHT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33565 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:00:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:00:15 +0000 Subject: [Koha-bugs] [Bug 33565] Use template wrapper for breadcrumbs: Tags In-Reply-To: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33565-70-h0kEYNpR3T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33565 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150055|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150058&action=edit Bug 33565: Use template wrapper for breadcrumbs: Tags This patch updates two tags templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Tags - Click a tag to see titles with that tag Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:08:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:08:27 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-l30e5t6jlE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Assignee|oleonard at myacpl.org |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:09:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:09:01 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-RNmSUwaFy8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:11:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:11:04 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-DCB8kzsByg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:11:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:11:06 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-X75DuG6e6F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150014|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150059&action=edit Bug 33579: Typo: record record To reproduce: - Search for records - Select two or more records - Select "Edit" > "Batch delete records" - Click "Delete selcted records" - Click "View detail of the enqueued job" - Verify the page says "Type: Batch bibliographic record record deletion" To test: - Repeat the steps above - The page should now say "Type: Batch bibliographic record deletion" Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:45:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:45:53 +0000 Subject: [Koha-bugs] [Bug 33076] Add context to "Quotes" In-Reply-To: <bug-33076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33076-70-ohQ5rTDiad@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.12 released in| | --- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:46:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:46:55 +0000 Subject: [Koha-bugs] [Bug 32180] ERM - Mandatory fields don't have the 'required' class on the label In-Reply-To: <bug-32180-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32180-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32180-70-40zChcyXYa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32180 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:49:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:49:00 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-FbzbnBXFEQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #49 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- This wasn't applying. Rebased. It's even worse now. After bug 33408, the staff user also requires the permission parameters in order to be able to fetch the ERMModule syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:49:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:49:35 +0000 Subject: [Koha-bugs] [Bug 33263] selenium/patrons_search.t is failing randomly In-Reply-To: <bug-33263-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33263-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33263-70-tWydy7r1uL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33263 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply clean to 22.05.x, needs rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:50:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:50:06 +0000 Subject: [Koha-bugs] [Bug 33082] Add yellow buttons and page sections to 'copy order' pages In-Reply-To: <bug-33082-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33082-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33082-70-56kdpOEpBh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33082 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:50:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:50:06 +0000 Subject: [Koha-bugs] [Bug 30952] New design for staff interface In-Reply-To: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30952-70-v2OAeqYlEU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 Bug 30952 depends on bug 33082, which changed state. Bug 33082 Summary: Add yellow buttons and page sections to 'copy order' pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33082 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:50:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:50:54 +0000 Subject: [Koha-bugs] [Bug 32495] Required fields in API and UI form don't match In-Reply-To: <bug-32495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32495-70-EUAPz96srm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32495 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed in 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:50:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:50:55 +0000 Subject: [Koha-bugs] [Bug 33235] Cypress tests are failing In-Reply-To: <bug-33235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33235-70-YFmq82g00n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33235 Bug 33235 depends on bug 32495, which changed state. Bug 32495 Summary: Required fields in API and UI form don't match https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32495 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:51:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:51:32 +0000 Subject: [Koha-bugs] [Bug 33235] Cypress tests are failing In-Reply-To: <bug-33235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33235-70-7ByWtJoPTr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33235 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed in 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:54:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:54:55 +0000 Subject: [Koha-bugs] [Bug 33100] Authority linking doesn't work for bib headings ending in two or more punctuation characters In-Reply-To: <bug-33100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33100-70-YgUIBYXmYm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33100 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.12 released in| | --- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:57:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:57:07 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-oa6oCJuomD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149423|0 |1 is obsolete| | --- Comment #50 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150060&action=edit Bug 32968: ERM granular permissions - Preparation Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:57:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:57:10 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-WDtxfemnml@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149424|0 |1 is obsolete| | --- Comment #51 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150061&action=edit Bug 32968: ERM granular permissions - API specs Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:57:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:57:13 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-f8VxTqBvw2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149425|0 |1 is obsolete| | --- Comment #52 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150062&action=edit Bug 32968: ERM granular permissions - DB specific Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:57:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:57:16 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-zSEI90VL5E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149426|0 |1 is obsolete| | --- Comment #53 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150063&action=edit Bug 32968: ERM granular permissions - Licenses Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:57:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:57:19 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-HT1z3UKglm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149427|0 |1 is obsolete| | --- Comment #54 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150064&action=edit Bug 32968: ERM granular permissions - Agreements Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:57:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:57:22 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-RzlVrD3X8Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149428|0 |1 is obsolete| | --- Comment #55 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150065&action=edit Bug 32968: ERM granular permissions - EHoldings Packages Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:57:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:57:25 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-FBuIMuRc4Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149429|0 |1 is obsolete| | --- Comment #56 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150066&action=edit Bug 32968: ERM granular permissions - EHoldings Titles Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 18:57:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 16:57:28 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-Wp2ROobARP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149430|0 |1 is obsolete| | --- Comment #57 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150067&action=edit Bug 32968: ERM granular permissions - Navigation guards Signed-off-by: Jonathan Field <jonathan.field at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 19:04:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 17:04:14 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-3DY8Xto4hS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #58 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- (In reply to Jonathan Druart from comment #46) > 1. Should we restrict access to the whole ERM module is vendor_manage is not > set? I don't know :) Also, see comment #49 > 2. I can list agreements even if I have only erm_eholdings. It's confusing > as we don't have access to "Licenses". It's working as intented. I followed your suggestion on comment #3, to me it makes sense because eHoldings may be related to agreements, but not licenses. Either way, I'm open to suggestions about this, should eHoldings write permission give read-only permission to both agreements+licenses? > 3. EBSCO Add to/Remove from holdings buttons should be removed with only > erm_show > 4. Same for "Add new agreement" on EBSCO pkg show view Yes, thanks! I missed EBSCO permissions in these patches. Will provide patches for this when I find the time. > 5. I don't get an error when I access /cgi-bin/koha/erm/licenses/edit/1 with > only erm_show (same for agreement) You don't get an error, you are redirected to /cgi-bin/koha/erm/erm.pl. If this is what you are experiencing, do you think it would be preferable to show an error page instead? (I don't think this is important, this is just a permission double-check in case the user attempts to access content that he doesn't have permission to, directly through the URL). Error or not, user doesn't have access to the content he's not permitted to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 19:04:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 17:04:50 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-dN0DiZ6FZF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 19:11:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 17:11:36 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-z764rHsxO7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix failures for |Fix failures for |Database/Commenter.t |Database/Commenter.t on | |MySQL 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 19:15:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 17:15:32 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-5eKklDHHjY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 19:15:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 17:15:34 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-GjXMJlGNea@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150068&action=edit Bug 33584: Fix failures for Commenter.t on MySQL8 The column names from information_schema are uppercase now in MySQL8. In the arrayref with sliced hashes, we expected lowercase. See e.g. https://stackoverflow.com/questions/54538448/what-are-the-changes-in-mysql-8-result-rowset-case Test plan: Run t/db_dependent/Koha/Database/Commenter.t Do it again if possible with a MySQL 8 db server. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 19:16:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 17:16:12 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-49XEjkskAo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Tomas: Could you please try to run the test with Mysql 8 ? Or just push and see :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 19:17:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 17:17:10 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-LgodwwK9hf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #0) > Looks like we are reading info from another database or so, here: > > SELECT table_name, column_name, column_comment FROM > information_schema.columns > WHERE table_schema=? AND table_name=? > ORDER BY table_name, column_name|; > > Or perhaps no permissions ? It is always simpler: I got uppercase in my hash keys instead of lower case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 19:31:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 17:31:14 +0000 Subject: [Koha-bugs] [Bug 33586] New: library and category are mislabeled in memberresultst table settings Message-ID: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33586 Bug ID: 33586 Summary: library and category are mislabeled in memberresultst table settings Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: catrina at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com A partner reports the following issue: The category and library columns for the table settings for memberresultst are switched. When you check is hidden by default for library, it hides the patron category. When you check is hidden by default for category, it hides the library. I am able to replicate this behavior. This seems similar to Bug 32461 so I cleared my cache and the issue persists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 19:32:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 17:32:44 +0000 Subject: [Koha-bugs] [Bug 9313] Show fine amount on 'Overdues with fines' report In-Reply-To: <bug-9313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9313-70-CLoXUB0ZRL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9313 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- As for which calculation, to me it should be the total accrued for that checkout, not each offset. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 20:19:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 18:19:58 +0000 Subject: [Koha-bugs] [Bug 32752] Add new serial issue status: "Out for binding", "Bound", and "Circulating" In-Reply-To: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32752-70-XpOSZ3Hwjc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32752 --- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thanks a lot! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 20:24:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 18:24:48 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-4S5qeD5WZ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #120 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #116) > TODO: > * Add the entries into l10n_* tables when a new item type is created. Does this mean there have to be entries even if you don't translate? (sorry, I should maybe know from the rest of the patch/bug) > * Remove them when the item type is deleted? Removing translations when the itemtype is deleted makes sense to me. > * What to do when the description of an item type is modified? I think, when an itemtype description is modified, this should not change the translations or remove them. Libraries will take care of it and a typo fix or modification should not cause any changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 20:28:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 18:28:22 +0000 Subject: [Koha-bugs] [Bug 30949] Error 500 in z3950_search.pl In-Reply-To: <bug-30949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30949-70-Hmhh2EZs8u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30949 Esther Melander <estherm at sodaspringsid.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |estherm at sodaspringsid.com --- Comment #3 from Esther Melander <estherm at sodaspringsid.com> --- This problem recently appeared for for our library. To reproduce: 1. Set up Seattle Public Library as a search target Host: zserver.spl.org Port: 210 DN: horizon 2. Edit a bibliographic record in the advanced editor and then click on Advanced Search to search for a new record to overlay the original. Be sure to have Seattle Public Library selected as a search target as well as Library of Congress. 3. Perform the search using an ISBN search. Search results should be returned from Library of Congress. 4. Repeat the search but do a title search instead. No search results are returned and instead the Error 500 pops up. Repeat the above searches with the z3950 search in the basic editor. No Error 500 occurs with either an ISBN search or a title search. After some investigation it appears that Seattle has migrated to a new platform and their z3950 protocol no longer works. It seems that in the cases where there was no server error, the z3950 search ignored or skipped the lack of response from Seattle whereas the advanced search in the advanced editor created a stop when there was no response. We would not have known about the problem without the server error, so in that sense it was helpful in at least alerting us to a problem. It may be helpful to change the Error 500 response message to something that makes it clear there is no response from a search target. There should be consistent behavior across all z3950 searches in the system. It would also be nice to have a test tool in the z3950 setup to be able to test the targets periodically. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 20:39:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 18:39:54 +0000 Subject: [Koha-bugs] [Bug 33581] Error in Webinstaller concerning sample holidays In-Reply-To: <bug-33581-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33581-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33581-70-9THa8UX8qB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It cannot work without the sample branches as every holiday needs to be connected to a library. They cannot be added without a library present in the database. The sample data is loaded before the onboarding process starts. I think the best we could probably do is maybe to lock/grey out the checkbox when the sample libraries are not selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 20:40:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 18:40:08 +0000 Subject: [Koha-bugs] [Bug 33581] Error in Webinstaller concerning sample holidays In-Reply-To: <bug-33581-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33581-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33581-70-j2Zs0ObM2i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Component|Holidays |Installation and upgrade | |(web-based installer) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 20:57:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 18:57:31 +0000 Subject: [Koha-bugs] [Bug 33587] New: "Save" button in modifying "News" entry is not working in Russian localization Message-ID: <bug-33587-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33587 Bug ID: 33587 Summary: "Save" button in modifying "News" entry is not working in Russian localization Change sponsored?: --- Product: Koha Version: 22.11 Hardware: PC OS: Windows Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: shatuln at gmail.com QA Contact: testopia at bugs.koha-community.org Overview: "Save" button is not working when you click on it while modifying "News" entry when Koha is in Russian localization. Switching to English localization resolves the issue. Steps to reproduce: - Staff interface - Tools - News - Add new entry - Fill fields - Click on "Save"("ĐĄĐŸŃ…Ń€Đ°ĐœĐžŃ‚ŃŒ") button Actual result: Nothing happens, the entry is not saving. Expected result: The entry is saving and the user brings to "News" page. Additional info: The issue is not reproducing when you fill the quite same page for HTML customizations. On English localization all work as expected. In intranet-error.log there are some entries about "wide character", maybe it can affect on the issue. These entries also appears on other pages of Koha. Example: [Fri Apr 21 18:52:36.183764 2023] [cgi:error] [pid 2183] [client 109.92.248.138:51053] AH01215: Wide character (U+438) in substitution (s///) at /usr/lib/x86_64-linux-gnu/perl5/5.34/Template/Filters.pm line 62.: /usr/share/koha/intranet/cgi-bin/tools/additional-contents.pl, referer: http://45.12.236.250:8080/cgi-bin/koha/tools/additional-contents.pl?op=add_form&category=news&editmode=wysiwyg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 21:40:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 19:40:49 +0000 Subject: [Koha-bugs] [Bug 33587] "Save" button in modifying "News" entry is not working in Russian localization In-Reply-To: <bug-33587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33587-70-5dR72WfgIO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33587 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I have tried to reproduce the issue on the current development branch, but it works as expected there with ru-RU. News entries can be edited and changes are saved correctly. I think this could be a translation issue, but reviewing the translations for ru-RU nothing stood out. If this is a translation issue, it needs to be identified and fixed on translate.koha-community.org. Maybe you can see in your template something that should not have been translated? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 21:43:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 19:43:14 +0000 Subject: [Koha-bugs] [Bug 33586] library and category are mislabeled in memberresultst table settings In-Reply-To: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33586-70-V9r8ZZmSJA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33586 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master QA Contact|testopia at bugs.koha-communit | |y.org | Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 21:46:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 19:46:20 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-KFqgjKGKhn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Marius <marius.mandrescu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149233|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 21:48:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 19:48:52 +0000 Subject: [Koha-bugs] [Bug 33586] library and category are mislabeled in memberresultst table settings In-Reply-To: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33586-70-t4pnznGhxI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33586 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 21:48:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 19:48:54 +0000 Subject: [Koha-bugs] [Bug 33586] library and category are mislabeled in memberresultst table settings In-Reply-To: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33586-70-Fk04Kb8WgR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33586 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150069&action=edit Bug 33586: Fix sequence of fields for memberresultst in table configuration The sequence of options actually matters, not the name. Library and category were switched, this patch fixes it and now it should all hide/show as expected: * Go to administration > table configuration * Hide library in memberresultst * Go to patron search and search * Verify that category was hidden instead * Apply patch * Verify now label and columns for library and category match with configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 21:49:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 19:49:27 +0000 Subject: [Koha-bugs] [Bug 33586] Library and category are switched in table configuration for patron search results table settings In-Reply-To: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33586-70-ABpwFp9kRr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33586 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|library and category are |Library and category are |mislabeled in |switched in table |memberresultst table |configuration for patron |settings |search results table | |settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 22:00:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 20:00:23 +0000 Subject: [Koha-bugs] [Bug 33572] Use template wrapper for breadcrumbs: Tools, part 3 In-Reply-To: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33572-70-qHbFUgRIc9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33572 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 22:04:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 20:04:36 +0000 Subject: [Koha-bugs] [Bug 33588] New: Inventory item list is missing page-section class Message-ID: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33588 Bug ID: 33588 Summary: Inventory item list is missing page-section class Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The inventory tool's result list is missing a page-section class for white background. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 22:05:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 20:05:07 +0000 Subject: [Koha-bugs] [Bug 33572] Use template wrapper for breadcrumbs: Tools, part 3 In-Reply-To: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33572-70-wSxg6xPfXu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33572 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 22:05:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 20:05:09 +0000 Subject: [Koha-bugs] [Bug 33572] Use template wrapper for breadcrumbs: Tools, part 3 In-Reply-To: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33572-70-nlaSSCXnAa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33572 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150049|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150070&action=edit Bug 33572: Use template wrapper for breadcrumbs: Tools, part 3 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - CSV profiles - New CSV profile - Edit CSV profile - Calendar - Import patrons - Results - Cataloging -> - Export catalog data - Inventory - Results Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 22:05:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 20:05:51 +0000 Subject: [Koha-bugs] [Bug 33588] Inventory item list is missing page-section class In-Reply-To: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33588-70-gxZ8BRjc5s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33588 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 22:10:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 20:10:00 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-sjmOe0nGNe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Marius <marius.mandrescu at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149233|0 |1 is obsolete| | --- Comment #98 from Marius <marius.mandrescu at inlibro.com> --- Created attachment 150071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150071&action=edit Bug 12532: Send email to guarantee and guarantor; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 22:15:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 20:15:00 +0000 Subject: [Koha-bugs] [Bug 33588] Inventory item list is missing page-section class In-Reply-To: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33588-70-Rs73wSnf5a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33588 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 22:15:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 20:15:03 +0000 Subject: [Koha-bugs] [Bug 33588] Inventory item list is missing page-section class In-Reply-To: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33588-70-xoJcsGdzVx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33588 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150072&action=edit Bug 33588: Add page-section to inventory tool items list The table with items created by the inventory tool was missing the page-section class and therefore had no white background. To test: * Go to cataloguing > inventory * When you don't have a lot of data: just submit the form * Look at the result list, confirm missing white background * Apply patch * Confirm the background is now correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 22:43:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 20:43:52 +0000 Subject: [Koha-bugs] [Bug 31256] Circ rules batch modification In-Reply-To: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31256-70-jgWz1BZsKN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256 --- Comment #6 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Caroline Cyr La Rose from comment #5) > Hi all, it's not an overall solution to batch edit rules (I honestly have no > idea what that would look like or what it would entail), but a lot of > schools might find this plugin useful to change hard due dates in batch > https://inlibro.com/en/koha-plugins/#rule-hard-due-date . It's not perfect, > as few plugins are imo, but a usable alternative to manually changing hard > due dates until it's possible to batch edit rule in the koha interface. Unfortunately, this is not a practical solution. This would have us changing the due dates after the checkout, which means A) we would constantly have to check back and update checkouts, and B) change the due date from something other than what was given at time of checkout, and C) possibly have to notify patrons of the change. If we were going to do this, we might as well just manually change the due date at the time of checkout, and there are obvious reasons why we are not suggesting that. It is preferable to have this dealt with via the rules, before the items are checked out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 22:46:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 20:46:17 +0000 Subject: [Koha-bugs] [Bug 33501] Cashup amount should be configurable In-Reply-To: <bug-33501-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33501-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33501-70-SGnoRbCGlS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33501 --- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Katrin Fischer from comment #1) > It's not configurable now. > > I think the feature was written with cash registers in mind. When you do a > cash-up, it tells you how much money you need to take out in order to keep a > certain amount of change in the register. > I am not sure if adding non-cash payment types would complicate this in some > way. Adding Martin. Yes, and checks are typically taken out and tallied along with cash. They have to be accounted for, and not left in the register. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 22:47:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 20:47:44 +0000 Subject: [Koha-bugs] [Bug 31256] Circ rules batch modification In-Reply-To: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31256-70-wE0kwnqxZq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- (In reply to Christopher Brannon from comment #6) > (In reply to Caroline Cyr La Rose from comment #5) > > Hi all, it's not an overall solution to batch edit rules (I honestly have no > > idea what that would look like or what it would entail), but a lot of > > schools might find this plugin useful to change hard due dates in batch > > https://inlibro.com/en/koha-plugins/#rule-hard-due-date . It's not perfect, > > as few plugins are imo, but a usable alternative to manually changing hard > > due dates until it's possible to batch edit rule in the koha interface. > > Unfortunately, this is not a practical solution. This would have us > changing the due dates after the checkout, which means A) we would > constantly have to check back and update checkouts, and B) change the due > date from something other than what was given at time of checkout, and C) > possibly have to notify patrons of the change. > > If we were going to do this, we might as well just manually change the due > date at the time of checkout, and there are obvious reasons why we are not > suggesting that. > > It is preferable to have this dealt with via the rules, before the items are > checked out. I'm not sure what you mean. This plugin changes the rules not the actual checkouts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 23:07:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 21:07:26 +0000 Subject: [Koha-bugs] [Bug 33586] Library and category are switched in table configuration for patron search results table settings In-Reply-To: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33586-70-GnIQn1uWg7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33586 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150069|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 150073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150073&action=edit Bug 33586: Fix sequence of fields for memberresultst in table configuration The sequence of options actually matters, not the name. Library and category were switched, this patch fixes it and now it should all hide/show as expected: * Go to administration > table configuration * Hide library in memberresultst * Go to patron search and search * Verify that category was hidden instead * Apply patch * Verify now label and columns for library and category match with configuration. Signed-off-by: Lisette Scheer <lisette.scheer at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 23:07:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 21:07:50 +0000 Subject: [Koha-bugs] [Bug 33586] Library and category are switched in table configuration for patron search results table settings In-Reply-To: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33586-70-bwNAEan7yl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33586 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com Status|Needs Signoff |Signed Off --- Comment #3 from Lisette Scheer <lisette.scheer at bywatersolutions.com> --- Worked as expected. Thanks! Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 23:14:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 21:14:44 +0000 Subject: [Koha-bugs] [Bug 31256] Circ rules batch modification In-Reply-To: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31256-70-SB2laIbPu8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256 --- Comment #8 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Caroline Cyr La Rose from comment #7) > > I'm not sure what you mean. This plugin changes the rules not the actual > checkouts. Sorry! Please ignore. My mind was thinking of another due date plugin. This plugin DOES make more sense. Still, I am looking forward to the day that Koha just has some of this basic functionality built in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 23:19:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 21:19:39 +0000 Subject: [Koha-bugs] [Bug 33501] Cashup amount should be configurable In-Reply-To: <bug-33501-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33501-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33501-70-neaGpzuPU1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33501 --- Comment #4 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Martin Renvoize from comment #2) > This is where 'credit type' and 'payment/transaction type' differ... credit > types are configurable, but transaction types aren't at this time.. most > places you select the payment/transaction type at transaction time.. is > there's somewhere missing this and could you not select 'Cheque' for 'Credit > type' with 'Cash' as transaction type? I'm not sure I'm understanding you here. I am only aware of the PAYMENT_TYPE authorized value where we set types of Cash, Credit, or Check. That works just fine. It is in the cashup workflow where it shows the balance that we need to pull from the register where it does not reflect the check amounts. There is no place that I can see where we can define what payment types are included in the cashup balance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 23:23:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 21:23:45 +0000 Subject: [Koha-bugs] [Bug 31256] Circ rules batch modification In-Reply-To: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31256-70-AfYUPJmFx9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- (In reply to Christopher Brannon from comment #8) > (In reply to Caroline Cyr La Rose from comment #7) > > > > > I'm not sure what you mean. This plugin changes the rules not the actual > > checkouts. > > Sorry! Please ignore. My mind was thinking of another due date plugin. > This plugin DOES make more sense. Still, I am looking forward to the day > that Koha just has some of this basic functionality built in. No problem. I agree that it should be built in. But I thought this could be an alternative while the functionality is being developped (if/when it is taken up). Changing rules one by one is a pain. Depending on the type of library, you might not need to do it often, but schools that use hard due dates must do it every term or school year. If you only have a couple of rules, it's manageable, but as soon as you have more, it can get very tedious. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 21 23:41:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 21:41:05 +0000 Subject: [Koha-bugs] [Bug 12104] Add print label to serials receive In-Reply-To: <bug-12104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12104-70-tLrsoIWu9W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12104 Michaela Sieber <michaela.sieber at kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 00:52:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 22:52:09 +0000 Subject: [Koha-bugs] [Bug 31256] Circ rules batch modification In-Reply-To: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31256-70-ZEfGt0iTIB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256 --- Comment #10 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Caroline Cyr La Rose from comment #5) > Hi all, it's not an overall solution to batch edit rules (I honestly have no > idea what that would look like or what it would entail), but a lot of > schools might find this plugin useful to change hard due dates in batch > https://inlibro.com/en/koha-plugins/#rule-hard-due-date . It's not perfect, > as few plugins are imo, but a usable alternative to manually changing hard > due dates until it's possible to batch edit rule in the koha interface. I just looked at this plugin, and it looks like it will affect ALL branches. I am not seeing an option to only make changes to specific branches. Also, it affects items already in circulation. Again, I don't want to touch stuff that was already given a due date. So, it does not look like we can even use this as a work around. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 01:01:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Apr 2023 23:01:49 +0000 Subject: [Koha-bugs] [Bug 29653] Return claims on deleted items In-Reply-To: <bug-29653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29653-70-nOm680vbUP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29653 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 12:00:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 10:00:06 +0000 Subject: [Koha-bugs] [Bug 33571] Use template wrapper for breadcrumbs: Tools, part 2 In-Reply-To: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33571-70-Fk1t1hRs5J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33571 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 12:00:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 10:00:09 +0000 Subject: [Koha-bugs] [Bug 33571] Use template wrapper for breadcrumbs: Tools, part 2 In-Reply-To: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33571-70-YWLuceP35T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33571 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150047|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150074&action=edit Bug 33571: Use template wrapper for breadcrumbs: Tools, part 2 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Batch patron deletion and anonymization - Confirmation - Results - Cataloging -> - Batch item modification - Batch item deletion - Batch record modification - Results Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 12:00:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 10:00:14 +0000 Subject: [Koha-bugs] [Bug 33571] Use template wrapper for breadcrumbs: Tools, part 2 In-Reply-To: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33571-70-KIiCVz8OYJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33571 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 15:18:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 13:18:32 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-zlRFjMNUQZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 15:18:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 13:18:37 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-hQoNfLkomb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149704|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150075&action=edit Bug 33167: Cleanup staff detail page This patch begins reduing some of the extra things we are doing in detail.pl that could easily be handled in the templates - fetching authorised values and branches etc It also removes a loop to find items that should be hidden, and instead uses a searh parameter The template changes either use item object rather than passed variables, or utilize plugins to fetch authorised valued Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 15:18:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 13:18:40 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-1tQU76cXqO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150076&action=edit Bug 33167: Fix TT comment for better translatability We just figured out that multi-line TT comments show up weirdly in translations and fixed it on bug 33332. So this just follows the newly established pattern. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 15:18:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 13:18:56 +0000 Subject: [Koha-bugs] [Bug 33167] Cleanup staff record details page In-Reply-To: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33167-70-Fd5exbs5mS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am also stumbling on this change: [% IF ( itemdata_itemnotes ) %] <td><div class="itemnotes">[% item.object.itemnotes.replace('\n','<br />') | $raw %]</div></td> [% END %] [% IF itemdata_nonpublicnotes %] <td class="nonpublicnote">[% item.itemnotes_nonpublic | html %]</td> [% END %] Why do this for the one note and not the other? It was also not there before and we allow HTML in this field. It seems counterintiuitive to allow both <br> and manual line breaks maybe. But: Not a blocker for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 15:20:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 13:20:39 +0000 Subject: [Koha-bugs] [Bug 33488] Library transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-oAQOInzmri@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 15:21:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 13:21:28 +0000 Subject: [Koha-bugs] [Bug 33488] Library transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-eHsepfnchx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 15:21:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 13:21:31 +0000 Subject: [Koha-bugs] [Bug 33488] Library transfer limits should have an index on fromBranch In-Reply-To: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33488-70-5Y6vE0F8qh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33488 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149913|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150077&action=edit Bug 33488: Add fromBranch index to branch_transfer_limits To test: 1 - Enable UseBranchTransferLimits by item type 2 - Set some limits for book 3 - Place a hold, verify that pikcup dropdown reflects the limits before and after patch Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 15:30:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 13:30:42 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-ZZIh0iwbj8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 15:30:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 13:30:45 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-0Qs0V5jo4T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149998|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150078&action=edit Bug 33577: Add btn class to cancel hold button on /reserve/request.pl To test: 1. Place a hold on a record and look at the /reserve/request.pl page. 2. Notice the two buttons 'Update hold(s)' and 'Cancel selected' buttons are not quite the same size. 3. Apply patch and look again, the buttons should line up. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 15:46:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 13:46:30 +0000 Subject: [Koha-bugs] [Bug 33365] Add item type column to cn_browser results table In-Reply-To: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33365-70-nTBiBLSRVp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33365 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 15:46:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 13:46:33 +0000 Subject: [Koha-bugs] [Bug 33365] Add item type column to cn_browser results table In-Reply-To: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33365-70-NxB6UGSRsT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33365 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149139|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150079&action=edit Bug 33365: Add item type column to cn_browser results To test: 1. Go to MARC bibliographic framework, pick a framework and go to 952, subfield "o". Turn the cn_browser plugin on. 2. Pick or create an item in that framework, edit that item. 3. TO the right of the 952$o notice the "...". Click that start the call number browser. 4. Notice there is no column for item type. 5. Apply patch, restart_all 6. Notice there is now a column for item type. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 15:46:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 13:46:35 +0000 Subject: [Koha-bugs] [Bug 33365] Add item type column to cn_browser results table In-Reply-To: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33365-70-zMHDQo1Dgg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33365 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150080&action=edit Bug 33365: (QA follow-up) Add check on item-level_itypes With biblio level itemtypes you won't have any on the item type level, so I feel like it will make sense to hide the column here like we do in other spots. To test: * pref at specific item = itemtype column shows * pref at biblio level = no itemtype column Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 15:47:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 13:47:15 +0000 Subject: [Koha-bugs] [Bug 33365] Add item type column to cn_browser results table In-Reply-To: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33365-70-B0ApLS5q6q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33365 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Should we have some check on item-level_itypes here? Just in case... I added a follow-up :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 16:22:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 14:22:51 +0000 Subject: [Koha-bugs] [Bug 33304] Report schedule form time input element attribute type changed to improve valid time value entry In-Reply-To: <bug-33304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33304-70-MKgapnmTsj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This is a bit of an odd one for me. It looks like the form is not really up to 'Koha standard' to begin with. Meaning that time and date should not really be separate input fields. It should all be handled by he datepicker. Also: with the change, it doesn't work according to the TimeFormat preference still. In my case I see PM/AM times now, while TimeFormat is set to 24 hours. This makes me unsure of if it's better than before or not. Adam, would you be interested in having a look in how to use Flatpickr to achieve the same goal here? An example for date and time can be seen in circulation when specifying a due date for example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 16:23:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 14:23:06 +0000 Subject: [Koha-bugs] [Bug 33304] Report schedule form time input element attribute type changed to improve valid time value entry In-Reply-To: <bug-33304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33304-70-bb94yI1OdF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 16:31:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 14:31:58 +0000 Subject: [Koha-bugs] [Bug 33102] Cart in OPAC and staff interface does no longer display infos from biblioitems table In-Reply-To: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33102-70-QCXHAhEmG4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33102 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 16:33:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 14:33:33 +0000 Subject: [Koha-bugs] [Bug 33102] Cart in OPAC and staff interface does no longer display infos from biblioitems table In-Reply-To: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33102-70-N3V2to3IVf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33102 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- ISBN and ISSN are a little easier to test for MARC21 installations :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 16:35:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 14:35:36 +0000 Subject: [Koha-bugs] [Bug 33102] Cart in OPAC and staff interface does no longer display infos from biblioitems table In-Reply-To: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33102-70-T7LcN7RQrj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33102 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 16:35:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 14:35:38 +0000 Subject: [Koha-bugs] [Bug 33102] Cart in OPAC and staff interface does no longer display infos from biblioitems table In-Reply-To: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33102-70-vt1h0BOF0t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33102 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149023|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150081&action=edit dBug 33102: Display fields from biblioitems in OPAC/staff interface cart The OPAC/PRO cart only displays biblio fields coming from 'biblio' table. Fields from biblioitems table aren't displayed anymore. TO TEST: 1. Populate a cart in OPAC/staff interface and display it. 2. You can see that Year column is empty (if you don't have copyright field). And other fields. 3. Apply the patch. 4. You can see more fields in cart simple/detailed view. Signed-off-by: Magnus Enger <magnus at libriotech.no> Tested by having a record with: - biblio.copyrightdate = NULL - biblioitems.publicationyear = 2025 Without the patch, no year is shown in the cart. With the patch, 2025 is shown. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 16:36:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 14:36:48 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-GIOnxI2rlD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 16:54:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 14:54:43 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-eXazIElTJx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 16:54:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 14:54:46 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-2To9KgM8OO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149833|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150082&action=edit Bug 33128: Add Polish translations for language descriptions This adds the Polish translations for the different languages to subtag_registry.sql that is used by all languages during installation. * Apply patch * Run database update * Install pl-PL and activate it for the OPAC * Go to advanced search * Look at the language pull down - it shows the languages in their language and then translated to English * Switch to Polish - verify the Polish translations are used now There are 2-3 cases where the translation = name, so only name is shown. * Drop your database, create your database * Run the web installer * Everything should complete without error and the language pull down should look exactly the same and be translated Signed-off-by: Nick <nick at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 16:55:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 14:55:07 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-Curh3zNV8G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Ultimately, we should do better with the way we manage these, but for now, this is all good :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 16:56:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 14:56:23 +0000 Subject: [Koha-bugs] [Bug 33134] Add some missing languages In-Reply-To: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33134-70-HL8OKPMLwy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33134 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 19:44:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 17:44:46 +0000 Subject: [Koha-bugs] [Bug 33134] Add some missing languages In-Reply-To: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33134-70-4RLCRS0qQy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33134 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I don't want to be the mean person here, but we are missing the languages name in their own language for all of these new languages. This really makes a difference in the language pull downs in the advanced searches in staff and OPAC. I think we should try and add as many as possible of these as well. Another small thing: the .sql file used to be organized by languages, scripts and regions, but we kinda messed that up. Also there is no visual order to entries. (noting because I was trying to make sense of things) What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 20:36:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 18:36:14 +0000 Subject: [Koha-bugs] [Bug 33589] New: Turn "register here" into "register" or rephrase without using "here" Message-ID: <bug-33589-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33589 Bug ID: 33589 Summary: Turn "register here" into "register" or rephrase without using "here" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Accessibility guidelines tell you to avoid 'here' in links and I strongly agree. You should always describe clearly what's going to happen when you click on the link. I feel we should remove the 'here' from 'register here' when patron self registration is activated. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:12:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:12:45 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-wi0gP2mWdJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:12:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:12:49 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-VB2gBqxKQ1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149896|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150083&action=edit Bug 27634: Turn off patron self-registration if no default category is set If there is no default category defined in PatronSelfRegistrationDefaultCategory the full feature must be displayed. We already hide the link from the OPAC main page, but the form is still accessible. Test plan (for the whole patch set): 1. Turn on PatronSelfRegistration 2. Don't set PatronSelfRegistrationDefaultCategory 3. Go to the OPAC main page and confirm that the "Register here" link is not displayed 4. Hit opac-memberentry.pl and confirm that you are redirected to the OPAC main page 5. Go to the about page and confirm that you see a warning in the "System information" tab 6. Set PatronSelfRegistrationDefaultCategory to an invalid patron's category 7. Repeat 3, 4, 5 8. Set PatronSelfRegistrationDefaultCategory to a valid patron's category 9. Self-register a patron and confirm it works as expected 10. Edit PatronSelfRegistrationBorrowerUnwantedField and confirm that you cannot remove dateexpiry and categorycode Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:12:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:12:53 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-d0d3JNrRX6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149897|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150084&action=edit Bug 27634: Force include categorycode to PatronSelfRegistrationBorrowerUnwantedField We should always use the category defined in PatronSelfRegistrationDefaultCategory. This could be discussed however. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:12:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:12:57 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-IgD3nvkpOw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149898|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150085&action=edit Bug 27634: Add the ability to exclude fields from "modal" sysprefs Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:13:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:13:01 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-6CQQPT7YPA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149899|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150086&action=edit Bug 27634: Force include of dateexpiry Otherwise we see a "Date expiry" entry in the form. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:13:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:13:04 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-QzkmEkJ8Ns@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149900|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150087&action=edit Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:13:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:13:08 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-mQexxeYMI1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149901|0 |1 is obsolete| | --- Comment #49 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150088&action=edit Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:13:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:13:11 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-kA6eQxTs2g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149902|0 |1 is obsolete| | --- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150089&action=edit Bug 27634: Hide "Register here" links Make sure the pref is filled with a valid patron's category to display the "register" link Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:13:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:13:14 +0000 Subject: [Koha-bugs] [Bug 27634] Turn off patron self-registration if no default category is set In-Reply-To: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27634-70-Rb0a9Zb6JO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150090&action=edit Bug 27634: (QA follow-up) Add punctuation to message on About page This just adds some missing commas and turns a pref into preference in the messages displayed on the system information tab. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:21:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:21:12 +0000 Subject: [Koha-bugs] [Bug 24192] Show host record items in basket/shelves in staff In-Reply-To: <bug-24192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24192-70-b0cUfCyWMV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24192 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am not sure about limiting this to records with no items. I had a look at other places in the code where host_items is called and we don't seem to use that condition there. (moredetail.pl, opac-detail.pl, request.pl). I think it's quite possible that a record has real items and host items. That happens with bound-withs here quite often. Maybe I am missing something? EasyAnalytics is checked in host_items, so that is taken care of. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:22:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:22:01 +0000 Subject: [Koha-bugs] [Bug 24192] Show host record items in basket/shelves in staff In-Reply-To: <bug-24192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24192-70-1PhoV9wbVC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24192 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Also: what about the OPAC equivalents? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:49:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:49:19 +0000 Subject: [Koha-bugs] [Bug 33134] Add some missing languages In-Reply-To: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33134-70-iFuqQdortS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33134 --- Comment #5 from Janusz Kaczmarek <januszop at gmail.com> --- OK, I'm just speculating: Is somewhere a place where you could find the names of the ancient languages in the language itself? What would be the point for this? I think the serious major problem now, with ES and the language facet, is that in a humanistic library the user is presented with meaningless code entries in the facet instead of language names, at least in English. Do we really need the language name in the language itself? for what purpose? It is nice if it is present in the advanced search but if it is not--like classic Syriac for syc or classis Greek including koine for grc or other exotic languages we hold in our libraries--it is not a big problem. At least much less important than syc and grc etc. as elements of the language facet, IMVHO. Any idea how to solve this and move it forward so that this issue would not remain frozen for next months or years? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:52:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:52:29 +0000 Subject: [Koha-bugs] [Bug 32876] Fix cataloguing/value_builder/unimarc_leader.pl In-Reply-To: <bug-32876-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32876-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32876-70-3nFlMhXEky@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32876 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:52:31 +0000 Subject: [Koha-bugs] [Bug 32876] Fix cataloguing/value_builder/unimarc_leader.pl In-Reply-To: <bug-32876-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32876-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32876-70-No4khk98gF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32876 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149007|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150091&action=edit Bug 32876: Fix cataloguing/value_builder/unimarc_leader.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:53:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:53:01 +0000 Subject: [Koha-bugs] [Bug 32875] Fix cataloguing/value_builder/unimarc_leader_authorities.pl In-Reply-To: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32875-70-hMi0DrRGhO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32875 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 22:55:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 20:55:53 +0000 Subject: [Koha-bugs] [Bug 33134] Add some missing languages In-Reply-To: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33134-70-hCfnncPDon@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33134 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Janusz Kaczmarek from comment #5) > OK, I'm just speculating: Is somewhere a place where you could find the > names of the ancient languages in the language itself? What would be the > point for this? > > I think the serious major problem now, with ES and the language facet, is > that in a humanistic library the user is presented with meaningless code > entries in the facet instead of language names, at least in English. > > Do we really need the language name in the language itself? for what > purpose? It is nice if it is present in the advanced search but if it is > not--like classic Syriac for syc or classis Greek including koine for grc or > other exotic languages we hold in our libraries--it is not a big problem. > At least much less important than syc and grc etc. as elements of the > language facet, IMVHO. > > Any idea how to solve this and move it forward so that this issue would not > remain frozen for next months or years? That's why I wrote this: I think we should try and add _as many as possible_ of these as well. I am aware that for some it makes no sense. I believe we are also missing some more common ones. I'll think on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:02:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:02:24 +0000 Subject: [Koha-bugs] [Bug 32875] Fix cataloguing/value_builder/unimarc_leader_authorities.pl In-Reply-To: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32875-70-xIDGfHfkSj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32875 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:02:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:02:27 +0000 Subject: [Koha-bugs] [Bug 32875] Fix cataloguing/value_builder/unimarc_leader_authorities.pl In-Reply-To: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32875-70-TdphK2MyFr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32875 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149006|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150092&action=edit Bug 32875: Fix cataloguing/value_builder/unimarc_leader_authorities.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:05:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:05:50 +0000 Subject: [Koha-bugs] [Bug 32874] Fix cataloguing/value_builder/unimarc_field_700-4.pl In-Reply-To: <bug-32874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32874-70-LFfDTD4C4p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32874 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:05:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:05:53 +0000 Subject: [Koha-bugs] [Bug 32874] Fix cataloguing/value_builder/unimarc_field_700-4.pl In-Reply-To: <bug-32874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32874-70-TklAR5o7PU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32874 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149004|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150093&action=edit Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:06:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:06:51 +0000 Subject: [Koha-bugs] [Bug 33134] Add some missing languages In-Reply-To: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33134-70-oU6a1HALqG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33134 --- Comment #7 from Janusz Kaczmarek <januszop at gmail.com> --- So maybe we should add all these: https://www.loc.gov/marc/languages/language_code.html in English and as many in other languages as we could find. BTW we already have the file MARC21Languages.xsl both for opac and bootstrap and the translations in many languages. Shouldn't we just add them all to the database? This would be an easy brute force solution but it would not require changing of the program logic... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:12:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:12:57 +0000 Subject: [Koha-bugs] [Bug 32872] Fix cataloguing/value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32872-70-zU1sIrgdsp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32872 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:14:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:14:34 +0000 Subject: [Koha-bugs] [Bug 32872] Fix cataloguing/value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32872-70-Goaob4g6UU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32872 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:14:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:14:36 +0000 Subject: [Koha-bugs] [Bug 32872] Fix cataloguing/value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32872-70-Cs5sMGTcxS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32872 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149003|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150094&action=edit Bug 32872: Fix cataloguing/value_builder/unimarc_field_4XX.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:15:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:15:47 +0000 Subject: [Koha-bugs] [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl In-Reply-To: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32818-70-EVqbkbkXyC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30975 | QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Blocks| |30975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:15:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:15:47 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-UNhRLKj4Zz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32818 | Depends on| |32818 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:18:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:18:36 +0000 Subject: [Koha-bugs] [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl In-Reply-To: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32818-70-8DmeFzanWT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:18:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:18:40 +0000 Subject: [Koha-bugs] [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl In-Reply-To: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32818-70-rqiiiguhiz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148847|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150095&action=edit Bug 32818: Fix cataloguing/value_builder/marc21_field_005.pl Remove unnecessary return statement This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:21:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:21:11 +0000 Subject: [Koha-bugs] [Bug 32817] Clean up cataloguing/value_builder/dateaccessioned.pl In-Reply-To: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32817-70-QH8odGG7Wh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30975 Depends on|30975 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:21:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:21:11 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-3L7qJLUOZH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32817 | Depends on| |32817 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 [Bug 32817] Clean up cataloguing/value_builder/dateaccessioned.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:21:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:21:16 +0000 Subject: [Koha-bugs] [Bug 32817] Clean up cataloguing/value_builder/dateaccessioned.pl In-Reply-To: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32817-70-Y7bpwYPtW8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:23:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:23:07 +0000 Subject: [Koha-bugs] [Bug 32817] Clean up cataloguing/value_builder/dateaccessioned.pl In-Reply-To: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32817-70-QeIwvH8HKh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:23:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:23:10 +0000 Subject: [Koha-bugs] [Bug 32817] Clean up cataloguing/value_builder/dateaccessioned.pl In-Reply-To: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32817-70-jeRWRNbOAG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148846|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150096&action=edit Bug 32817: Fix cataloguing/value_builder/dateaccessioned.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:24:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:24:24 +0000 Subject: [Koha-bugs] [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl In-Reply-To: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32867-70-m2mf9A9xm6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30975 | Blocks| |30975 QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:24:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:24:24 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-3DO4Grg0g7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32867 | Depends on| |32867 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:26:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:26:25 +0000 Subject: [Koha-bugs] [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl In-Reply-To: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32867-70-lakZhBz196@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:26:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:26:28 +0000 Subject: [Koha-bugs] [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl In-Reply-To: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32867-70-w8sUm9opcw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148845|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150097&action=edit Bug 32867: Fix cataloguing/value_builder/unimarc_field_146i.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:27:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:27:44 +0000 Subject: [Koha-bugs] [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl In-Reply-To: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32866-70-8PtxY48k6i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30975 Depends on|30975 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:27:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:27:44 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-pdEXPcfg6l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32866 | Depends on| |32866 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:27:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:27:50 +0000 Subject: [Koha-bugs] [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl In-Reply-To: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32866-70-mzfgEH9wou@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:37:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:37:03 +0000 Subject: [Koha-bugs] [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl In-Reply-To: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32866-70-63hkzYCwd3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:37:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:37:06 +0000 Subject: [Koha-bugs] [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl In-Reply-To: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32866-70-bYVOldLZ2u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148844|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150098&action=edit Bug 32866: Fix cataloguing/value_builder/unimarc_field_146h.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:38:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:38:32 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-LvQAJK8aH6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:38:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:38:45 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-YXEgpLxL1L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:40:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:40:38 +0000 Subject: [Koha-bugs] [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl In-Reply-To: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32865-70-y0jm0r0W5r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|30975 | Blocks| |30975 QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:40:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:40:38 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-Iug0cYOEzM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|32865 | Depends on| |32865 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:42:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:42:09 +0000 Subject: [Koha-bugs] [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl In-Reply-To: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32865-70-Tyc6SDZJcN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:42:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:42:11 +0000 Subject: [Koha-bugs] [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl In-Reply-To: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32865-70-1vuuRdRVaH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148843|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150099&action=edit Bug 32865: Fix cataloguing/value_builder/unimarc_field_146a.pl Remove unnecessary call to event.preventDefault() This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:42:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:42:59 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-tL8CRY4qIr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32877 Blocks|32877 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32877 [Bug 32877] Clean up cataloguing/value_builder/upload.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:42:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:42:59 +0000 Subject: [Koha-bugs] [Bug 32877] Clean up cataloguing/value_builder/upload.pl In-Reply-To: <bug-32877-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32877-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32877-70-hkoHiU6AEv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32877 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30975 Depends on|30975 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 [Bug 30975] Framework plugins do not work on cloned fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:47:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:47:22 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-D4aUd7F3F1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:47:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:47:24 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-WqZObmqqeK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145305|0 |1 is obsolete| | --- Comment #9 from David Nind <david at davidnind.com> --- Created attachment 150100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150100&action=edit Bug 32250: Linking authorities does not change holdability If the only change is a linked heading, we don't need to rebuild the holds queue To test: 1 - Set preference RealTimeHoldsQueue to enable 2 - Run link_bibs_to_authorities 3 - Note holds queue jobs generated 4 - Apply patch 5 - repeat 6 - No holds queue updates Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:47:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:47:27 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-0VcmQv67Kg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145319|0 |1 is obsolete| | --- Comment #10 from David Nind <david at davidnind.com> --- Created attachment 150101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150101&action=edit Bug 32250: Only reindex records when commiting This patch adds an array to catch updated bibs, and defers indexing until a batch of changes is committed To test: 1 - Set LinkerModule system preference to either first or last match Alternate this between runs of the linker to ensure changes are made 2 - Set SearchEngine to Elasticsearch and reindex (to ensure index is built) 3 - perl misc/link_bibs_to_authorities.pl -v 4 - Check Admin->Jobs and see that many ES index jobs are queued 5 - Apply patch 6 - perl misc/link_bibs_to_authorities.pl -v 7 - Check Admin->Jobs and see that 1 index per commit from is enqueued Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:47:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:47:30 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-p9555tPA1R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149969|0 |1 is obsolete| | --- Comment #11 from David Nind <david at davidnind.com> --- Created attachment 150102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150102&action=edit Bug 32250: (follow-up) Commit background job to the DB We can't run a background job if it isn't in the database, however, this script runs with AutoCommit disabled. We need to enable it while generating the background job, then disable for the updates. I don't nkow if using a transaction would be preferable. I tried to solve this independently, but it requires consolidating the index requests to make this work easily Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:51:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:51:23 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-Y3atDP6J0J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #12 from David Nind <david at davidnind.com> --- How I tested (using KTD): 1. Start KTD with Elastic search (ktd --es7 up). 2. Update bibliographic record number 73 to remove one of the 010 LCCN numbers. Otherwise there is an error when running perl misc/link_bibs_to_authorities.pl -v: C4::Biblio::_koha_modify_biblioitem_nonmarc(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'lccn' at row 1 at /kohadevbox/koha/C4/Biblio.pm line 432 3. Set the RealTimeHoldsQueue system preference to Enable. 4. Run the authorities linker: perl misc/link_bibs_to_authorities.pl -v 5. Check the jobs list (Administration > Jobs > Manage jobs). Note that holds queue jobs were generated. 6. Set the LinkerModule system preference to either first or last match - alternate this between runs of the linker to ensure changes are made. 7. Rebuild search index (koha-elasticsearch --rebuild -d -b -a kohadev). 8. Run the authorities linker: perl misc/link_bibs_to_authorities.pl -v 9. Check the jobs list (Administration > Jobs > Manage jobs). Note that many Elasticsearch index jobs are queued. 10. Apply the patches, flush_memcached, restart_all. 11. Change the Set LinkerModule system preference. 12. Run the authorities linker: perl misc/link_bibs_to_authorities.pl -v 13. Check the jobs list (Administration > Jobs > Manage jobs). Note that: - There are no hold queue updates - That are a smaller number of Elastic search update (3 for me, instead of an update for each record) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 22 23:56:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 21:56:55 +0000 Subject: [Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl In-Reply-To: <bug-32853-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32853-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32853-70-WFKD8aDElS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This works, but doesn't really seem to make sense. It's not linked by default anywhere and it uses the template of UNIMARC 100. Looking at the definition of 125 doesn't clear things up either. (https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:00:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:00:40 +0000 Subject: [Koha-bugs] [Bug 32856] Fix cataloguing/value_builder/unimarc_field_126.pl In-Reply-To: <bug-32856-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32856-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32856-70-AnKfMWsB6e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32856 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, this, like bug 32853, uses the template for 100, but 125 doesn't look like that in the manual. Any hints? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:04:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:04:05 +0000 Subject: [Koha-bugs] [Bug 32868] Fix cataloguing/value_builder/unimarc_field_210c_bis.pl In-Reply-To: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32868-70-I5ZqnrlLxk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32868 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This is an auto-complete plugin for publisher names. You start typing and it will suggest existing entries that you can then choose from for your record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:04:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:04:43 +0000 Subject: [Koha-bugs] [Bug 32868] Fix cataloguing/value_builder/unimarc_field_210c_bis.pl In-Reply-To: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32868-70-1ybc6u6Geq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32868 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:04:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:04:46 +0000 Subject: [Koha-bugs] [Bug 32868] Fix cataloguing/value_builder/unimarc_field_210c_bis.pl In-Reply-To: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32868-70-vGD8AOPkbt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32868 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146801|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150103&action=edit Bug 32868: Fix cataloguing/value_builder/unimarc_field_210c_bis.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:05:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:05:17 +0000 Subject: [Koha-bugs] [Bug 32868] Fix cataloguing/value_builder/unimarc_field_210c_bis.pl In-Reply-To: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32868-70-K3Ts8JrLQ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32868 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Taking this one straight to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:16:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:16:25 +0000 Subject: [Koha-bugs] [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl In-Reply-To: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32869-70-hXzE4IWhPA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This is for when the publishers are managed with authority records: It expects an authority framework EDITORS with main heading 200 Easiest way to test is to change the existing NP authority framework to EDITORS with SQL. Then you can use the existing personal name authorities for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:17:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:17:02 +0000 Subject: [Koha-bugs] [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl In-Reply-To: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32869-70-OL0yUvmrH4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:17:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:17:06 +0000 Subject: [Koha-bugs] [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl In-Reply-To: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32869-70-jBX74pKzHq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146802|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150104&action=edit Bug 32869: Fix cataloguing/value_builder/unimarc_field_210c.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:17:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:17:30 +0000 Subject: [Koha-bugs] [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl In-Reply-To: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32869-70-Xw8e3vZBFz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:17:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:17:34 +0000 Subject: [Koha-bugs] [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl In-Reply-To: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32869-70-197sCfsRd6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150104|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150105&action=edit Bug 32869: Fix cataloguing/value_builder/unimarc_field_210c.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:17:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:17:51 +0000 Subject: [Koha-bugs] [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl In-Reply-To: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32869-70-HfGCw6clO1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Also putting this one straight to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:19:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:19:46 +0000 Subject: [Koha-bugs] [Bug 32870] Fix cataloguing/value_builder/unimarc_field_225a_bis.pl In-Reply-To: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32870-70-TzLPhCmpvj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32870 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This is an auto-complete search for existing series in the database. "Libre" will work for a test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:20:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:20:52 +0000 Subject: [Koha-bugs] [Bug 32870] Fix cataloguing/value_builder/unimarc_field_225a_bis.pl In-Reply-To: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32870-70-tuZC4uVCY7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32870 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:20:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:20:55 +0000 Subject: [Koha-bugs] [Bug 32870] Fix cataloguing/value_builder/unimarc_field_225a_bis.pl In-Reply-To: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32870-70-OVMyjMTDON@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32870 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146803|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150106&action=edit Bug 32870: Fix cataloguing/value_builder/unimarc_field_225a_bis.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:21:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:21:28 +0000 Subject: [Koha-bugs] [Bug 32870] Fix cataloguing/value_builder/unimarc_field_225a_bis.pl In-Reply-To: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32870-70-tNDnsT8Dbk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32870 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- 'coll' will work even better on the sample test data :) Straight through to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:39:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:39:37 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-KXvigL0elp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:39:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:39:40 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-IGQfPn6pnL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149919|0 |1 is obsolete| | --- Comment #15 from David Nind <david at davidnind.com> --- Created attachment 150107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150107&action=edit Bug 30352: Allow translation of Not for loan in OPAC XSLT results Note: Test plan below can be followed in English. If you would like to see the vernacular results, you need to update PO files and translate 'Not for loan', and update templates (xslt files) accordingly. The bootstrap PO does not yet include that string without %s suffix in the current codebase. Test plan: [1] Apply this patch and make the following change in MARC21slim2OPACResults.xsl, line 1207. Change: <status english="Not for loan">Not for loan</status> to: <status english="Not for loan">NOT for loan</status> Important: Change text inside, not the attribute! Restart all. [2] Pick a biblio, add some items with different statuses: Checked out, Damaged, Not for loan, Staff collection. [3] Make it appear in a OPAC results display (not detail). [4] You should see the different statuses, including NOT for loan. The uppercase NOT serves to prove that the string has been translated. Also verify that you see Staff collection as-is. [5] Bonus: Toggle with values in Reference_NFL_Statuses to move results from Reference section to Not available section v.v. [6] Revert the change from step 1. Sign off :) Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:39:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:39:43 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-buCSHoiWqd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149920|0 |1 is obsolete| | --- Comment #16 from David Nind <david at davidnind.com> --- Created attachment 150108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150108&action=edit Bug 30352: Add a comment to the substatus translation The tric of combining the XPath union operator (|) with the value-of instruction works as a sort of ternary operation. The value-of only picks the string value of the first node from the union in document order. So, if there is a translation, it will be the first node. If there is no translation, the original substatus will be used. Note that there will be no translation for authorised values like Staff collection, etc. Test plan: None. Just comments. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:42:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:42:59 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-FRsmM16tOX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #17 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. For step 1 of the test plan: . to edit file: vi koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl . line to edit for me was 1297 2. Second patch: I don't know enough to provide a useful comment, feel free to change the status back to needs signoff for someone else to comment if this is essential. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:56:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:56:55 +0000 Subject: [Koha-bugs] [Bug 32871] Fix cataloguing/value_builder/unimarc_field_225a.pl In-Reply-To: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32871-70-qupnGGmE0x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32871 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:56:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:56:57 +0000 Subject: [Koha-bugs] [Bug 32871] Fix cataloguing/value_builder/unimarc_field_225a.pl In-Reply-To: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32871-70-GUlDCH8SCz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32871 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146805|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150109&action=edit Bug 32871: Fix cataloguing/value_builder/unimarc_field_225a.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:57:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:57:40 +0000 Subject: [Koha-bugs] [Bug 32871] Fix cataloguing/value_builder/unimarc_field_225a.pl In-Reply-To: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32871-70-LFCHkzyFWN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32871 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This one is more complex: 23 This plugin is used to map isbn/editor with collection. 24 It need : 25 in thesaurus, a category named EDITORS 26 in this category, datas must be entered like following : 27 isbn separator editor separator collection. 28 for example : 29 2204 -- Cerf -- Cogitatio fidei 30 2204 -- Cerf -- Le Magistere de l'Eglise 31 2204 -- Cerf -- Lectio divina 32 2204 -- Cerf -- Lire la Bible 33 2204 -- Cerf -- Pour lire 34 2204 -- Cerf -- Sources chretiennes 35 36 when the user clic on ... on 225a line, the popup shows the list of collections from the selected editor 37 if the biblio has no isbn, then the search if done on editor only 38 If the biblio ha an isbn, the search is done on isbn and editor. It's faster. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 00:57:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 22:57:57 +0000 Subject: [Koha-bugs] [Bug 32871] Fix cataloguing/value_builder/unimarc_field_225a.pl In-Reply-To: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32871-70-UYvtybx4th@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32871 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- ... and through to Tomas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 01:02:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 23:02:30 +0000 Subject: [Koha-bugs] [Bug 32873] Fix cataloguing/value_builder/unimarc_field_686a.pl In-Reply-To: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32873-70-I9wQzZPOy0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32873 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 01:02:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 23:02:33 +0000 Subject: [Koha-bugs] [Bug 32873] Fix cataloguing/value_builder/unimarc_field_686a.pl In-Reply-To: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32873-70-llFBEgPq1f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32873 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146807|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150110&action=edit Bug 32873: Fix cataloguing/value_builder/unimarc_field_686a.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 01:03:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 23:03:05 +0000 Subject: [Koha-bugs] [Bug 32868] Fix cataloguing/value_builder/unimarc_field_210c_bis.pl In-Reply-To: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32868-70-neBotKkN1h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32868 --- Comment #7 from David Nind <david at davidnind.com> --- (In reply to Katrin Fischer from comment #4) > This is an auto-complete plugin for publisher names. You start typing and it > will suggest existing entries that you can then choose from for your record. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 01:03:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 23:03:43 +0000 Subject: [Koha-bugs] [Bug 32873] Fix cataloguing/value_builder/unimarc_field_686a.pl In-Reply-To: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32873-70-SWUBhlhSNR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32873 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 01:03:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 23:03:47 +0000 Subject: [Koha-bugs] [Bug 32873] Fix cataloguing/value_builder/unimarc_field_686a.pl In-Reply-To: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32873-70-sCDQTq9Z55@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32873 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 01:04:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 23:04:15 +0000 Subject: [Koha-bugs] [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl In-Reply-To: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32869-70-ORJsuGZJqO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 --- Comment #8 from David Nind <david at davidnind.com> --- (In reply to Katrin Fischer from comment #4) > This is for when the publishers are managed with authority records: > It expects an authority framework EDITORS with main heading 200 > Easiest way to test is to change the existing NP authority framework to > EDITORS with SQL. Then you can use the existing personal name authorities > for testing. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 01:04:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 23:04:59 +0000 Subject: [Koha-bugs] [Bug 32870] Fix cataloguing/value_builder/unimarc_field_225a_bis.pl In-Reply-To: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32870-70-8pIrlWqOob@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32870 --- Comment #7 from David Nind <david at davidnind.com> --- (In reply to Katrin Fischer from comment #4) > This is an auto-complete search for existing series in the database. "Libre" > will work for a test. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 01:06:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 23:06:25 +0000 Subject: [Koha-bugs] [Bug 33035] Add volume column in the item bundle table In-Reply-To: <bug-33035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33035-70-EA2ZrsXLyu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33035 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|victor at tuxayo.net |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Actions column is in the holdings = items table of the bibliographic record. But the feature needs to be activated first too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 01:42:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 23:42:28 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-G17ybq99yb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 01:42:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 23:42:31 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-fCV8Aqc5hO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149729|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 150111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150111&action=edit Bug 32917: Fix sample notice for CHANGE_PASSWORD We've identified 3 issues: * Name of patron is not showing up in subject line * Name of patron is now showing in notice text * Notice is set to be HTML, but has no line breaks and uses no HTML tags In the database update, these issues don't occur: $dbh->do( q{ INSERT IGNORE INTO letter (module, code, name, title, content, message_transport_type) VALUES ('members', 'PASSWORD_CHANGE', 'Notification of password change', 'Library account password change notification', "Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nWe want to notify you that your password has been changed. If you did not change it yourself (or requested that change), please contact library staff.\r\n\r\nYour library.", 'email'); }); So this patch will make them match up: * Remove HTML flag * Update patron. to borrower. in message text * Remove patron name from subject (it won't work even with the correct variables) To test: * Add an email address to your favourite sample user * Make sure NotifyPasswordChange is set to "Notify" * Update the sample user's password using the "change password" feature * Verify a notice is shown in the notices tabs Note: you won't see the line break issue there because of bug 30287 * Apply patch * Recreate your database/run web installer so sample notices are loaded * Repeat the test, it should generate a nice lookig notice now Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 01:46:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Apr 2023 23:46:35 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-6A21UZwFiK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. After applying the patch, a reset_all loads the updated notice: - remember to add email address again to patron used to test 2. I also tested by actually sending the email[1] - this showed that the formatting was fixed (line breaks now show where expected, so it is now nicely formatted). [1] To test sending emails using a Google account, edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where <user_name> = your Google email address; <password> = your APP password, not your Google account password): <smtp_server> <host>smtp.gmail.com</host> <port>587</port> <timeout>5</timeout> <ssl_mode>STARTTLS</ssl_mode> <user_name>GOOGLEACCOUNTUSER</user_name> <password>GOOGLEAPPPASSWORD</password> <debug>1</debug> </smtp_server> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 06:10:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 04:10:00 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-bzyWjTxkao@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind <david at davidnind.com> --- I'm successfully able to stage and import records and items (tried imports with and without items). I'm not seeing the warning in the log. However, I do have this error in /var/log/koha/kohadev/es-indexer-output.log - but this is there before doing any staging and importing: Cannot connect to the message broker, the jobs will be processed anyway (Failed to connect: Error connecting to localhost:61613: Cannot assign requested address at /usr/share/perl5/Net/Stomp.pm line 27.; giving up at /usr/share/perl5/Net/Stomp.pm line 27. ) at /kohadevbox/koha/misc/workers/es_indexer_daemon.pl line 84. I've logged this as an issue for KTD https://gitlab.com/koha-community/koha-testing-docker/-/issues/373 Maybe this is why I can't replicate the issue for this bug? Otherwise, is there anything else I need to be doing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 08:05:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 06:05:02 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-BXib8j1QOo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 08:05:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 06:05:05 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-zg0rY7v8uY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149895|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 150112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150112&action=edit Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link This patch revises the process by which the serials search results page redirects to the batch edit page based on which checkboxes are checked. To test, apply the patch and go to serials. You should have some subscriptions which are open and some which are closed. - Perform a search which will return at least one result under each tab (Open and Closed). - Checking one or more checkboxes should activate the "Edit selected serials" link, which should work correctly to redirect you to the batch edit page. - Unchecking all the checkboxes should make the edit link disappear. - Check that the "Select all" and "Clear all" links work the same way manually checking checkboxes does. - Confirm that controls under each tab work correctly just for the results under that tab. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 08:09:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 06:09:56 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-Q19JUbpWH0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 08:09:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 06:09:59 +0000 Subject: [Koha-bugs] [Bug 33580] Bring back ability to mark item as seen via SIP2 item information request In-Reply-To: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33580-70-rCb4vKwoRH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33580 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150032|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 150113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150113&action=edit Bug 33580 - Bring back ability to mark item as seen via SIP2 item information request Prior to Koha 22.05, the SIP2 item information message had a side affect of updating the datelastseen field for items. This bug has been fixed, but was being utilized by inventory tools that used SIP2. We should bring back this affect and formalize it as an optional SIP2 config account setting. Test Plan: 1) Apply this patch set 2) prove t/db_dependent/SIP/Message.t Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 08:36:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 06:36:05 +0000 Subject: [Koha-bugs] [Bug 33569] Order by relevance may not be visible In-Reply-To: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33569-70-xcIHMhmnXJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 08:36:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 06:36:08 +0000 Subject: [Koha-bugs] [Bug 33569] Order by relevance may not be visible In-Reply-To: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33569-70-OHXaSzDI9O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149984|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 150114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150114&action=edit Bug 33569: Fix sort by relevance in catalog search When ordering catalog search by relevance from advanced search, this is not visible in sort order combobox in staff interface. This is because sort by relevance is a special case not using sort order. This patch add a new method C4::Context->default_catalog_sort_by to use in both staff interface and OPAC. Test plan : 1.0) On staff interface 1.1) Define system preferences defaultSortField = 'relevance' and defaultSortOrder = 'descending' 1.2) Perform a catalog search from main page on any term, ie 'perl' => You see in sort combobox 'relevance' selected (with a check icon) 1.3) Perform an advanced search on any term, ie 'perl', with sort by relevance => Without patch : you see in sort combobox 'relevance' not selected (no check icon) => With patch : you see in sort combobox 'relevance' selected (with a check icon) 2.0) On OPAC 2.1) Define system preferences OPACdefaultSortField = 'relevance' and OPACdefaultSortOrder = 'descending' 2.2) Perform a catalog search from main page on any term, ie 'perl' => You see in sort combobox 'relevance' selected 3.0) Run prove t/Context.t Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 08:55:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 06:55:23 +0000 Subject: [Koha-bugs] [Bug 32745] Background jobs view breaks when there are jobs with context IS NULL In-Reply-To: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32745-70-oWExJWiq0G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 08:55:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 06:55:26 +0000 Subject: [Koha-bugs] [Bug 32745] Background jobs view breaks when there are jobs with context IS NULL In-Reply-To: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32745-70-I6JZk7nyJ3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148643|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 150115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150115&action=edit Bug 32745: Adjust context for invalid background jobs We had some problems recently and it's possible to have background_jobs.context=NULL But the REST API specs is expecting an object. We could either modify the specs, or adjust the incorrect entries in DB, which is IMO better. Test plan: 0. Don't apply the patch 1. Create some background jobs 2. Set context to NULL UPDATE background_jobs SET context=NULL; 3. List the jobs and note the datatable error, and the error in Koha log OpenAPI >>> GET api/v1/jobs [{"message":"Expected object - got null.","path":"\/body\/0\/context"},{"message":"Expected object - got null.","path":"\/body\/1\/context"}] 4. Apply the patch 5. Run `updatedatabase` 6. Confirm that the list and detail view are not working correctly Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 08:57:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 06:57:52 +0000 Subject: [Koha-bugs] [Bug 32745] Background jobs view breaks when there are jobs with context IS NULL In-Reply-To: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32745-70-U64LVAglOn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. To create some background jobs, I started KTD with --es7 then updated the titles for 3 records. 2. For step 6 of the test plan, I think that should say the list and detail views ARE working correctly 8-). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 11:31:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 09:31:11 +0000 Subject: [Koha-bugs] [Bug 33035] Add volume column in the item bundle table In-Reply-To: <bug-33035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33035-70-IvDH2pZ3b4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33035 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, showing volume is quite unsusual. I have to say that I thought this patch was about the enumchron value when I tested it. Volume is not mapped by default in MARC21 and I think not widely used at all. Could we at least make the visibility of the column dependent on there being any data for it? Or could it be a thought to add it to the title display instead of introducing a separate column? - That seems to be the more common way on how we handle title information here. Otherwise I think it might be confusing to most users expecting enumchron as we often display this with the items, but we never display volume from biblioitems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 11:32:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 09:32:07 +0000 Subject: [Koha-bugs] [Bug 33569] Order by relevance may not be visible In-Reply-To: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33569-70-TkKRUIlcFo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 11:40:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 09:40:12 +0000 Subject: [Koha-bugs] [Bug 33569] Order by relevance may not be visible In-Reply-To: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33569-70-CRKhJowNWM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 11:40:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 09:40:15 +0000 Subject: [Koha-bugs] [Bug 33569] Order by relevance may not be visible In-Reply-To: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33569-70-FjJCEv8oMa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33569 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150114|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150116&action=edit Bug 33569: Fix sort by relevance in catalog search When ordering catalog search by relevance from advanced search, this is not visible in sort order combobox in staff interface. This is because sort by relevance is a special case not using sort order. This patch add a new method C4::Context->default_catalog_sort_by to use in both staff interface and OPAC. Test plan : 1.0) On staff interface 1.1) Define system preferences defaultSortField = 'relevance' and defaultSortOrder = 'descending' 1.2) Perform a catalog search from main page on any term, ie 'perl' => You see in sort combobox 'relevance' selected (with a check icon) 1.3) Perform an advanced search on any term, ie 'perl', with sort by relevance => Without patch : you see in sort combobox 'relevance' not selected (no check icon) => With patch : you see in sort combobox 'relevance' selected (with a check icon) 2.0) On OPAC 2.1) Define system preferences OPACdefaultSortField = 'relevance' and OPACdefaultSortOrder = 'descending' 2.2) Perform a catalog search from main page on any term, ie 'perl' => You see in sort combobox 'relevance' selected 3.0) Run prove t/Context.t Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 11:42:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 09:42:22 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-SXS5TY5k5l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 11:47:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 09:47:33 +0000 Subject: [Koha-bugs] [Bug 33590] New: Select all/Clear all links on serial collection page are broken Message-ID: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Bug ID: 33590 Summary: Select all/Clear all links on serial collection page are broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: oleonard at myacpl.org The select all/clear all links to select items for editing or deleting on the serial collection page are broken and there is no reaction when clicking on them. To test: * Add a subscription * From the subscription detail page, click on serial collection link in left hand navigation * Create some additional issues * Clear all link for selecting issues to edit won't work, select all link neither -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 11:48:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 09:48:24 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-LAFneEdvqW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 11:48:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 09:48:27 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-ri1D6HitjU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150112|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150117&action=edit Bug 33560: Batch edit link broken if subscriptions are selected using "select all" link This patch revises the process by which the serials search results page redirects to the batch edit page based on which checkboxes are checked. To test, apply the patch and go to serials. You should have some subscriptions which are open and some which are closed. - Perform a search which will return at least one result under each tab (Open and Closed). - Checking one or more checkboxes should activate the "Edit selected serials" link, which should work correctly to redirect you to the batch edit page. - Unchecking all the checkboxes should make the edit link disappear. - Check that the "Select all" and "Clear all" links work the same way manually checking checkboxes does. - Confirm that controls under each tab work correctly just for the results under that tab. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 11:51:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 09:51:21 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-j6a8Mgzmja@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- How to move this forward the best? I think we need to decide on line length, does 120 sound like a reasonable compromise? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 11:52:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 09:52:25 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-k3u3FsDtnK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Lucas Gass from comment #7) > (In reply to Katrin Fischer from comment #6) > > The first patch removed not only the spans, but also the restriction type > > (Manual, etc.) from the title. My follow-up adds them back, but still > > removes the spans. Maybe we could get another sign-off/QA check? > > Probably a good idea. Lucas, do you want to test? We can sign off each others, if you agree to the change of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 11:52:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 09:52:59 +0000 Subject: [Koha-bugs] [Bug 32745] Background jobs view breaks when there are jobs with context IS NULL In-Reply-To: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32745-70-CYg0qmZhvv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:00:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:00:04 +0000 Subject: [Koha-bugs] [Bug 33591] New: Cannot merge bibliographic records Message-ID: <bug-33591-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Bug ID: 33591 Summary: Cannot merge bibliographic records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When trying to merge 2 bibliographic records in Koha, there is an error complaining about missing fields: Following required fields are missing: - 245 - 003 - 005 - 008 - 040 Of those fields only 003 is really missing. The other fields are all present in both records to be merged, but would only be needed in the 'winning' record to begin with. Also: I am merging with the framework Booklets and 003 is not a mandatory field for "Books, Booklets, Workbooks". When I edit the record in cataloguing, it saves without any missing fields error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:05:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:05:52 +0000 Subject: [Koha-bugs] [Bug 32745] Jobs view breaks when there are jobs with context IS NULL In-Reply-To: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32745-70-4Q8kf4VCnI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Background jobs view breaks |Jobs view breaks when there |when there are jobs with |are jobs with context IS |context IS NULL |NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:07:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:07:57 +0000 Subject: [Koha-bugs] [Bug 32745] Jobs view breaks when there are jobs with context IS NULL In-Reply-To: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32745-70-IHpBIxyCkR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:08:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:08:00 +0000 Subject: [Koha-bugs] [Bug 32745] Jobs view breaks when there are jobs with context IS NULL In-Reply-To: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32745-70-NMKnSMlJ7a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150115|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150118&action=edit Bug 32745: Adjust context for invalid background jobs We had some problems recently and it's possible to have background_jobs.context=NULL But the REST API specs is expecting an object. We could either modify the specs, or adjust the incorrect entries in DB, which is IMO better. Test plan: 0. Don't apply the patch 1. Create some background jobs 2. Set context to NULL UPDATE background_jobs SET context=NULL; 3. List the jobs and note the datatable error, and the error in Koha log OpenAPI >>> GET api/v1/jobs [{"message":"Expected object - got null.","path":"\/body\/0\/context"},{"message":"Expected object - got null.","path":"\/body\/1\/context"}] 4. Apply the patch 5. Run `updatedatabase` 6. Confirm that the list and detail view are not working correctly Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:08:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:08:28 +0000 Subject: [Koha-bugs] [Bug 32745] Jobs view breaks when there are jobs with context IS NULL In-Reply-To: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32745-70-4as7nYcQb5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32745 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Are we missing a 'success' message in the database update? (is the second output line manatory?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:09:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:09:28 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-R6hycqVAJx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:13:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:13:20 +0000 Subject: [Koha-bugs] [Bug 33501] Cashup amount should be configurable In-Reply-To: <bug-33501-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33501-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33501-70-Ya2zGO3szK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33501 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Christopher Brannon from comment #3) > (In reply to Katrin Fischer from comment #1) > > It's not configurable now. > > > > I think the feature was written with cash registers in mind. When you do a > > cash-up, it tells you how much money you need to take out in order to keep a > > certain amount of change in the register. > > I am not sure if adding non-cash payment types would complicate this in some > > way. Adding Martin. > > Yes, and checks are typically taken out and tallied along with cash. They > have to be accounted for, and not left in the register. I was wondering how it could affect the value of change that should always remain in the register. If your cash in the register is low and there is mostly checks, you'll get into a situation where you need to replace some checks with change money again. I wonder if there is a better way to handle this somehow. At least it would be necessary to be able to 'flag' which payment type are 'physical' ones ending in the register. But maybe there should also be some clever calculation that tell you: take out all cheques and please fill up change money by X. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:15:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:15:17 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23486-70-fM5uYbF6PZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:15:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:15:20 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23486-70-0U3InzH76v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149273|0 |1 is obsolete| | --- Comment #24 from David Nind <david at davidnind.com> --- Created attachment 150119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150119&action=edit Bug 23486: Set lastseen to default to current timestamp Generally, a patron is not registered without some action from the patron Defaulting the lastseen upon creation seems a reasonable way to set the initial value. This patch also makes the column NOT NULL to avoid any future data issues. To handle any currently NULL, we either set them to dateenrolled, or updated_on - the latter is already NOT NULL so is the bast fallback we have (assuming patron was also seen when they were updated) TO test: Apply patches Update database Create a patron Check their lastseen date Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:15:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:15:24 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23486-70-ny0uERvs9o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149274|0 |1 is obsolete| | --- Comment #25 from David Nind <david at davidnind.com> --- Created attachment 150120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150120&action=edit Bug 23486: DO NOT PUSH - Schema updates Note that the fields must be manually updated after generation as generated syntax us invalid: default_value: 'current_timestamp()' First occurence: default_value: 'current_timestamp' Second occurence: default_value => \"current_timestamp", Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:18:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:18:28 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23486-70-zjaVOc7Jdp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #26 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. To check the lastseen field in the database: - koha-mysql kohadev - SQL query (where XXX = borrower number for newly created patron): select * from borrowers where borrowernumber = XXX; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:26:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:26:32 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-Oc126m3Jyt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:26:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:26:35 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-3QytFzwxXU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150107|0 |1 is obsolete| | Attachment #150108|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150121&action=edit Bug 30352: Allow translation of Not for loan in OPAC XSLT results Note: Test plan below can be followed in English. If you would like to see the vernacular results, you need to update PO files and translate 'Not for loan', and update templates (xslt files) accordingly. The bootstrap PO does not yet include that string without %s suffix in the current codebase. Test plan: [1] Apply this patch and make the following change in MARC21slim2OPACResults.xsl, line 1207. Change: <status english="Not for loan">Not for loan</status> to: <status english="Not for loan">NOT for loan</status> Important: Change text inside, not the attribute! Restart all. [2] Pick a biblio, add some items with different statuses: Checked out, Damaged, Not for loan, Staff collection. [3] Make it appear in a OPAC results display (not detail). [4] You should see the different statuses, including NOT for loan. The uppercase NOT serves to prove that the string has been translated. Also verify that you see Staff collection as-is. [5] Bonus: Toggle with values in Reference_NFL_Statuses to move results from Reference section to Not available section v.v. [6] Revert the change from step 1. Sign off :) Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:26:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:26:39 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-rW7VxXUTZt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150122&action=edit Bug 30352: Add a comment to the substatus translation The tric of combining the XPath union operator (|) with the value-of instruction works as a sort of ternary operation. The value-of only picks the string value of the first node from the union in document order. So, if there is a translation, it will be the first node. If there is no translation, the original substatus will be used. Note that there will be no translation for authorised values like Staff collection, etc. Test plan: None. Just comments. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:27:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:27:51 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-0OL8RypNqj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thanks Marcel. I also verified that this is working by running the translation scripts and updating the po files. We now see a translated Not for loan according to selected language. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:36:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:36:35 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23486-70-V7rbutDyHx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- "Generally, a patron is not registered without some action from the patron Defaulting the lastseen upon creation seems a reasonable way to set the initial value" I believe this is a wrong assumption. It works for self registrations and manual registration, but not for patron imports. Often an institution will import all their users so they can log into the OPAC when they need to, but a lot of them never will. For this use case setting the date and assuming them as active won't be correct. This is also true when migrating data using the patron import tool, also common. I think we cannot handle that on database level for this reason, we need to handle the different types of registration somehow. Also, right now documentation would be wrong: last time a patron has been seen (connected at the OPAC or staff interface) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:42:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:42:45 +0000 Subject: [Koha-bugs] [Bug 33592] New: Use drag&drop or sorting options for AutoEmailPrimaryAddress Message-ID: <bug-33592-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33592 Bug ID: 33592 Summary: Use drag&drop or sorting options for AutoEmailPrimaryAddress Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 29046 With bug 29046 you can define the sequence the email fields are checked when searching for a valid email address. It would be nice if we could make the GUI a bit more inutitive by allowing to drag and drop for sorting like we can do it for the installed languages. It would also need the combination with checkbox to allow for not using some fields at all. We also have that for languages. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:42:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:42:45 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-MmWIcXg1G7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33592 [Bug 33592] Use drag&drop or sorting options for AutoEmailPrimaryAddress -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:47:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:47:47 +0000 Subject: [Koha-bugs] [Bug 33085] OPAC translation to Galician In-Reply-To: <bug-33085-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33085-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33085-70-aLKQuGUJa9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33085 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind <david at davidnind.com> --- Can this bug be closed now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:56:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:56:02 +0000 Subject: [Koha-bugs] [Bug 33588] Inventory item list is missing page-section class In-Reply-To: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33588-70-WMYzZ50yyY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33588 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 12:56:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 10:56:04 +0000 Subject: [Koha-bugs] [Bug 33588] Inventory item list is missing page-section class In-Reply-To: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33588-70-OW5x9ivp1O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33588 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150072|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 150123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150123&action=edit Bug 33588: Add page-section to inventory tool items list The table with items created by the inventory tool was missing the page-section class and therefore had no white background. To test: * Go to cataloguing > inventory * When you don't have a lot of data: just submit the form * Look at the result list, confirm missing white background * Apply patch * Confirm the background is now correct Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:20:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:20:01 +0000 Subject: [Koha-bugs] [Bug 33085] OPAC translation to Galician In-Reply-To: <bug-33085-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33085-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33085-70-GE52EjFySi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33085 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Needs Signoff |RESOLVED --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- We cannot resolve it here - please reach out on the koha-translate mailing list if you need any more help! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:22:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:22:57 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-ALelCEZ4Gk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- > > * Not blocker: For languages we can sort the entries with drag&drop. Could > > this be a possible option here? Or maybe I could file as a separate bug? > > Please do this on another bug... this was meant as a starting point.. I > don't have time to polish it any further I'm afraid. Specifically marked it as 'not blocker' just wanted to get your opinion. I am still not sure if you like the idea, but filed separately now: bug 33592 I have tests failing with this patch set applied that pass without it :( prove t/db_dependent/Koha/Patron.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patron.t ... 10/23 Use of uninitialized value in split at /kohadevbox/koha/Koha/Patron.pm line 1440. Use of uninitialized value in split at /kohadevbox/koha/Koha/Patron.pm line 1440. t/db_dependent/Koha/Patron.t ... 13/23 WARNING: The key derivation method "opensslv1" is deprecated. Using -pbkdf=>'pbkdf2' would be better. Pass -nodeprecate=>1 to inhibit this message. at /kohadevbox/koha/Koha/Patron.pm line 2423. t/db_dependent/Koha/Patron.t ... ok t/db_dependent/Koha/Patrons.t .. 31/43 Use of uninitialized value in split at /kohadevbox/koha/Koha/Patron.pm line 1440. t/db_dependent/Koha/Patrons.t .. 32/43 Use of uninitialized value in split at /kohadevbox/koha/Koha/Patron.pm line 1440. # Failed test 'One notice queued when NotifyPasswordChange enabled' # at t/db_dependent/Koha/Patrons.t line 1972. # got: '0' # expected: '1' # Looks like you planned 16 tests but ran 15. # Looks like you failed 1 test of 15 run. # Failed test '->set_password' # at t/db_dependent/Koha/Patrons.t line 1976. Can't call method "status" on an undefined value at t/db_dependent/Koha/Patrons.t line 1974. # Looks like your test exited with 11 just after 33. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 11/43 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 2816 Tests: 33 Failed: 1) Failed test: 33 Non-zero exit status: 11 Parse errors: Bad plan. You planned 43 tests but ran 33. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:24:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:24:23 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-RSDcGCTsU1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- My fault - it works now after running the database update :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:41:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:41:50 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-1Bamgk68hZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:41:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:41:53 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-Skp5vZY0GC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149959|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150124&action=edit Bug 29046: Add 'EmailFieldPrecedence' preference This patch adds a new EmailFieldPrecidence systempreference to allow users to set the precicence in which patron email fields should be used for communications. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:41:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:41:56 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-nX1qbIYydy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149960|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150125&action=edit Bug 29046: Use EmailFieldPrecedence in first_valid_email_address This patch update the Koha::Patron->first_valid_email_address method to use the newly defined EmailFieldPrecedence preference. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:42:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:42:00 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-sqkYLC3NEp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149961|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150126&action=edit Bug 29046: Change link in EmailFieldPrecedence and add link in EmailFieldPrimary This patch modifies the link in EmailFieldPrecedence to reflect the new name of EmailFieldPrimary. It also adds a note in the latter to set the 'first valid' order in the former. To test: 1. Go to Administration > Global system preferences 2. Search for EmailFieldPrecedence 3. Click on the link in the description --> It should lead to EmailFieldPrimary 4. Read the note in EmailFieldPrimary, make sure the grammar and spelling are correct. 5. Click the link to EmailFieldPrecedence --> It should lead to EmailFieldPrecedence Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:42:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:42:03 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-qWNIWK7OIq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149962|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150127&action=edit Bug 29046: Unit tests Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:42:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:42:07 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-GiwXGVd7nK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149963|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150128&action=edit Bug 29046: Reword system preference. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:42:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:42:10 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29046-70-HCqJPiCl4I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 --- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150129&action=edit Bug 29046: Fix and amend system preference description The first line would not show in the system preference editor due to missing quotes. Also added information on the option names, link to the schema and an example. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:42:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:42:58 +0000 Subject: [Koha-bugs] [Bug 31349] Add option to not update items.permanent_location when editing items.location In-Reply-To: <bug-31349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31349-70-oYNf0LBKu1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31349 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30910 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:42:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:42:58 +0000 Subject: [Koha-bugs] [Bug 30910] Allow local definition of temporary shelving locations In-Reply-To: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30910-70-fkemdqBrWK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30910 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31349 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:44:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:44:35 +0000 Subject: [Koha-bugs] [Bug 30910] Allow local definition of temporary shelving locations In-Reply-To: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30910-70-oJ0sN8yAZm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30910 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- +1 I quite like this idea, it would make it more flexible and move the config out of frameworks, which is a bit too 'magic' right now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:56:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:56:31 +0000 Subject: [Koha-bugs] [Bug 33593] New: CatalogConcernTemplate needs to be HTML Message-ID: <bug-33593-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33593 Bug ID: 33593 Summary: CatalogConcernTemplate needs to be HTML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: martin.renvoize at ptfs-europe.com Depends on: 31028 Currently the CatalogConcernTemplate is added to the HTML customizations as plain text. This results in all line breaks being lost and the text getting hard to read. I believe we need to switch this to HTML: - title: "Catalog concern template text" category: "html_customizations" location: "CatalogConcernTemplate" code: "CatalogConcernTemplate_1" content: - "**Describe the concern**" - "A clear and concise description of what the concern is." - "" - "**To Reproduce**" - "Steps to reproduce the behavior:" - "1. Go to '...'" - "2. Click on '....'" - "3. Scroll down to '....'" - "4. See error" - "" - "**Expected behavior**" - "A clear and concise description of what you expected to happen." lang: "default" published_on: "2007-10-29 05:25:58" expirationdate: "2099-01-10" number: 1 We should update the sample notices, but also the database update before 23.05 release. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 13:56:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 11:56:31 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-YPkW9tSZHu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33593 [Bug 33593] CatalogConcernTemplate needs to be HTML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:00:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:00:29 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-f3lvt79Lxz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:01:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:01:27 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-ND5PxWGwql@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:01:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:01:30 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-KlxOu8M4tw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150130&action=edit Bug 33313: Fix catalog links in TICKET_NOTIFY This fixes the system preference name from IntranetBaseURL to staffClientBaseURL. Also makes some small typo fixes. As this feature has just been pushed I chose to fix the database updates that will be run when installing 23.05. To test: * Verify the wrong link in TICKET_NOTIFY * Drop database, create database, run web installer * Verify the link is now correct in the notice Bonus: Test update from 22.11 to 23.05 and verify the notices are correct there as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:02:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:02:20 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-9M55kPOjBI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:15:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:15:34 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-0lPMtCXSGS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- What I did (and please provide test plans yourself...): 1) Updated dateformat to DD.MM.YYYY 2) Added 505$a 01.01.2024 to a record 3) Ran: ./misc/add_date_fields_to_marc_records.pl --field='505$g=0/%Y' --date-field='505$a' --verbose --confirm 505$g was created. In my tests it seems like --unless-exists='505$g' didn't have any effect, but that is out of scope here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:16:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:16:34 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-1GJxjt5dqZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:16:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:16:37 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-2RaX7oy00W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149739|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150131&action=edit Bug 23924: Add --date-field to add_date_fields_to_marc_records.pl The date used in the script will use this parameter, instead of today. Test plan: Use the POD of the script to understand how this flag works. Then use the script to create fields with a date contained in a specific MARC field. Signed-off-by: Hugo Agud <hagud at orex.es> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:16:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:16:41 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-Skhg9xgWHL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149740|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150132&action=edit Bug 23924: Reset the fields to add We do not want to copy fields from the previous records! Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:19:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:19:58 +0000 Subject: [Koha-bugs] [Bug 32651] Search borrowers by library doesn't work In-Reply-To: <bug-32651-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32651-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32651-70-PCPj2SFYdU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32651 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I believe this has been fixed on bug 33155. *** This bug has been marked as a duplicate of bug 33155 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:19:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:19:58 +0000 Subject: [Koha-bugs] [Bug 33155] Category and library filters from header patron search not taken into account In-Reply-To: <bug-33155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33155-70-WLLZEIdhYN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 32651 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:22:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:22:39 +0000 Subject: [Koha-bugs] [Bug 32577] Transactions table overflows window-size In-Reply-To: <bug-32577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32577-70-wAUugNln39@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32577 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think a horizontal scroll bar was also highlighted as an accessibility issue (bug 33516), so we should avoid it. How can we proceed here? Owen, do you have a patch with your idea for comparison? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:25:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:25:33 +0000 Subject: [Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface In-Reply-To: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32677-70-knjB1Ackvh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Victor, the remove didn't work. You need to make sure you add the instance name at the end of your commands: sudo koha-translate --remove es-ES instancename -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:27:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:27:08 +0000 Subject: [Koha-bugs] [Bug 24167] We should support installation on Debian 10 [OMNIBUS] In-Reply-To: <bug-24167-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24167-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24167-70-oMW2Hor52C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- All dependent bugs have been resolved and we are already listing Debian 10 and 11 on the requirements page: https://wiki.koha-community.org/wiki/System_requirements_and_recommendations Closing this one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:31:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:31:44 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-Rfqf2IzFme@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I managed to test and PQA on all but: > - unimarc_field_125.pl (bug 32853) > - unimarc_field_126.pl (bug 32856) These also work in theory, but don't appear to make sense. Some insight would be good. I am missing some plugins in the list - especially almos all marc21* ones. Do we have a way to check which plugins still need updating? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:35:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:35:36 +0000 Subject: [Koha-bugs] [Bug 29598] Add a preference for default borrower's notice language In-Reply-To: <bug-29598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29598-70-HdnZ31Sl8c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29598 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- > > Which version did you test with? > > My comment dates from 2021. So it must have been fixed in the meantime? Would be nice to know how and when... but I am closing this one for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:38:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:38:00 +0000 Subject: [Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow In-Reply-To: <bug-33544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33544-70-pEJRTeF3bV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I'd like to see a POC for this one and also think this might be what's best here to resolve the space issue. But we need to make sure that the information is still clearly distinguishable for librarians working with ILLs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:43:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:43:11 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-ghKHIysjku@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I just ran into this in training and glad to see there is already a fix underway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:57:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:57:31 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor issues In-Reply-To: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33105-70-I2aOJOI2gc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add vendor Issues |Add vendor issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:58:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:58:35 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-sLbh6kYEbL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Laura, I'd love to see this in 23.05 - please let me know if you need any help or won't have time to continue. We can figure something out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 14:59:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 12:59:03 +0000 Subject: [Koha-bugs] [Bug 33419] Make home library and holding library in items mandatory by default In-Reply-To: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33419-70-tqiUtORQEp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make home library mandatory |Make home library and |by default |holding library in items | |mandatory by default Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 15:01:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 13:01:43 +0000 Subject: [Koha-bugs] [Bug 33116] Limit reports execution time with SQL variables In-Reply-To: <bug-33116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33116-70-wClT0nVrMs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33116 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Limit reports execution |Limit reports execution |time with sql variables |time with SQL variables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 15:45:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 13:45:17 +0000 Subject: [Koha-bugs] [Bug 33120] Batch patron modification: add option to amend circulation/OPAC note instead of overwrite In-Reply-To: <bug-33120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33120-70-oPGMKKCpZL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33120 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Summary|Batch Patron Modification - |Batch patron modification: |Circulation Note Overwrites |add option to amend | |circulation/OPAC note | |instead of overwrite -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 17:39:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 15:39:59 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31405-70-PRFrQpSu7C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 17:40:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 15:40:01 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31405-70-tk1paxVuV6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150133&action=edit dBug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field * Save set * Edit set and verify the focus is in the search field at the top Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 17:40:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 15:40:51 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31405-70-qw5KDjIGtA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Lucas Gass from comment #3) > In other places we only set the focus when adding and but when editing? > Should we do that here to? > > See Bug 31410. I changed the patch to not set the focus on the description when an existing set is edited. This is to avoid accidental changes and matches behavior on other pages, as Lucas has pointed out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 17:45:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 15:45:26 +0000 Subject: [Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server In-Reply-To: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31410-70-RHfq8UVDLh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Other places we do this: * Bug 31410 - Set focus for cursor to Server name when adding a new Z39.50 or SRU server * Bug 27458 - Set focus for cursor to Credit type code field when creating new credit type * Bug 27192 - Set focus for cursor to item type input box when creating new item types - comment 8 has some notes about a prvious discussion on this too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 17:47:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 15:47:38 +0000 Subject: [Koha-bugs] [Bug 15187] Adding 880 Fields to index-list in order to Increase Search for ALL non-latin Scripts In-Reply-To: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15187-70-8pXelxzQcD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15187 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate --- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to David Cook from comment #37) > Looks like this wasn't reverted out of 22.05... Adding Rmaint and keyword. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 17:51:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 15:51:44 +0000 Subject: [Koha-bugs] [Bug 15347] itemcallnumber syspref does not work when adding items through acquisitions In-Reply-To: <bug-15347-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15347-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15347-70-VI67KFIqRh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15347 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Kate Fitz from comment #8) > We have recently experienced this issue when importing MARC records from an > outside vendor. After import, the Call Number is in the record, but does not > display on items on either the staff catalog or public catalog until the > record has been opened, saved, and closed. That's the correct behaviour. You imported with the callnumber in the record and it won't be added to the items automatically. Because you have set itemcallnumber system preference it will suggest the callnumber from the record when you edit an item with an empty callnumber field. Now when you save hte callnumber is actually added to the item. You might want to shift the callnumber into the items (952$o) before importing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 17:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 15:54:31 +0000 Subject: [Koha-bugs] [Bug 15347] itemcallnumber syspref does not work when adding items through acquisitions In-Reply-To: <bug-15347-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15347-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15347-70-xOf1UHChRS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15347 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #7) > I can confirm that the itemcallnumber system preference doesn't work for > adding items from acquisition. > > To test: > - Make sure itemcallnumber preference is set to field and subfield, that > exists > in the records you want to use for testing. > - Verify that preference works in general in your installation: > - Add new item for an existing record with the field. > - Verify that the callnumber is filled with the value from the > bibliographic record as a suggestion. > - Set AcqCreateItem to 'on order' > - Create a new basket > - Add a order line to it > - Verify that the callnumber remains empty unlike in cataloging. > Set AcqCreateItem to 'on receive' > - Create a new basket > - Add a order line to it > - Close basket > - Receive shipment > - Verify that callnumber remains empty unlike in cataloging. > > If I enter a callnumber to the item in one of those steps, it's stored > correctly and visible in the catalog immediately after saving. > > I think it doesn't matter if it's from Z39.50 or from an existing records - > it never works. Can confirm this is still an issue in current master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 17:55:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 15:55:28 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15348-70-DCsVQgpCuH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #135 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Should this be needs documenting? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 17:56:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 15:56:29 +0000 Subject: [Koha-bugs] [Bug 15399] MARCXML records larger than 1 MB (1048576 bytes) are not searchable. In-Reply-To: <bug-15399-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15399-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15399-70-SSI1i2ayU3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15399 --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to David Cook from comment #20) > (In reply to Katrin Fischer from comment #19) > > (In reply to David Cook from comment #18) > > > I was sure that I replied to this already... > > > > > > I changed zebra_max_record_size to 4096 in prod for one instance since there > > > were MARCXML records with large numbers of records, and it works fine. > > > > Could we add this to the wiki for Zebra troubleshooting? > > https://wiki.koha-community.org/wiki/ > Troubleshooting_Zebra#Records_with_lots_of_items_not_indexing Awesome, thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 17:58:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 15:58:38 +0000 Subject: [Koha-bugs] [Bug 32385] OPAC and staff (intranet) should not share the same session and cookie In-Reply-To: <bug-32385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32385-70-dU7Wf5z03R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32385 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15428 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think in a way this is a requirement for the older bug 15428. When we have different sessions, we can also implement different timeouts if I am not mistaken. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 [Bug 15428] Different timeout preference for opac and intranet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 17:58:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 15:58:38 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for opac and intranet In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-kV3nCnO3Jk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32385 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32385 [Bug 32385] OPAC and staff (intranet) should not share the same session and cookie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 17:59:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 15:59:37 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-DH2OMgP58o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32385 | Summary|Different timeout |Different timeout |preference for opac and |preference for OPAC and |intranet |staff interface --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Marked bug 32385 as a dependency for this one. I think in order to have different timeouts, we need different sessions first. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32385 [Bug 32385] OPAC and staff (intranet) should not share the same session and cookie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 17:59:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 15:59:37 +0000 Subject: [Koha-bugs] [Bug 32385] OPAC and staff (intranet) should not share the same session and cookie In-Reply-To: <bug-32385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32385-70-aUutXeNXvd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32385 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15428 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 [Bug 15428] Different timeout preference for OPAC and staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 18:03:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 16:03:20 +0000 Subject: [Koha-bugs] [Bug 15660] Prevent sharing budgets In-Reply-To: <bug-15660-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15660-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15660-70-CeNOBwEncZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15660 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Summary|prevent sharing budgets |Prevent sharing budgets Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this actually already works. You need to make sure the users don't have budget_manage_all and then limit the funds to library (and optionally to fund and user). That will also affect visibility on the start page. I have tested it a few times and it works. Nicole's original report was from 2016, I think it might not have worked back then. Wondering if another level of permissions would be needed here - permission control in acq is already very granular, it might makes things more complicated? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 18:07:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 16:07:23 +0000 Subject: [Koha-bugs] [Bug 32386] Record Matching rules not being created In-Reply-To: <bug-32386-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32386-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32386-70-Hua8Kjeak4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32386 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to David Cook from comment #2) > Not able to reproduce this in the master branch... I can't replicate the issue on master nor 22.11.03. I filled out all the required fields and it saves correctly. I am setting this WORKSFORME. If you need to reopen, please try to provide more information: * What is your exact Koha version? * What do you do to trigger the error? (which values have you entered into the form?) * Take a look at the server side logs, the 500 should be explained more there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 18:35:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 16:35:42 +0000 Subject: [Koha-bugs] [Bug 32498] Checking an in-transit item out at a library other than the tobranch should cancel the transfer rather than complete it In-Reply-To: <bug-32498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32498-70-TJKh5Sfgal@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32498 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Checking an in-transit item |Checking an in-transit item |out at a branch other than |out at a library other than |the tobranch should cancel |the tobranch should cancel |the transfer rather than |the transfer rather than |complete it |complete it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 18:39:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 16:39:17 +0000 Subject: [Koha-bugs] [Bug 32640] Add fields to branches table to improve ILL functionality. In-Reply-To: <bug-32640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32640-70-OYGQvoo0sk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32640 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Not that UK centries. We also have an identifier for each library participating in ILL. So another field for a library ID would make sense for Germany too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 18:39:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 16:39:38 +0000 Subject: [Koha-bugs] [Bug 32640] Add fields to branches table to improve ILL functionality. In-Reply-To: <bug-32640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32640-70-sD2JO46MfI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32640 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #1) > Not that UK centries. We also have an identifier for each library > participating in ILL. So another field for a library ID would make sense for > Germany too. Not that UK _centric_ ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 18:43:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 16:43:45 +0000 Subject: [Koha-bugs] [Bug 32723] chopPunctuation in XSLT issues In-Reply-To: <bug-32723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32723-70-iyVRTdapyt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32723 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|chopPunctuation in xslt |chopPunctuation in XSLT |issues |issues Version|21.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 19:50:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 17:50:41 +0000 Subject: [Koha-bugs] [Bug 33593] CatalogConcernTemplate needs to be HTML In-Reply-To: <bug-33593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33593-70-WuUCNtuInx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33593 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 20:22:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 18:22:38 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31405-70-eSmq6n1ZbT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 20:22:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 18:22:40 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31405-70-L9VKhiEorI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146267|0 |1 is obsolete| | --- Comment #6 from David Nind <david at davidnind.com> --- Created attachment 150134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150134&action=edit Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field * Save set * Edit set and verify the focus is in the search field at the top Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 20:24:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 18:24:37 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31405-70-2MUV6AmdLg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Attachment #150133|0 |1 is obsolete| | --- Comment #7 from David Nind <david at davidnind.com> --- Comment on attachment 150133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150133 dBug 31405: Set focus for cursor to setSpec input when adding a new OAI set Managed to double up the patches as I amended the patch title - from "dBug 31405: ..." to "Bug 31405: ...". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 21:32:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 19:32:14 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-9sb47vKlpC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind <david at davidnind.com> --- This fixes the link to the cataloging concerns management page, so happy to sign it off. In addition, should the link to the record title be fixed as well, or should I log that as a separate bug? For example: I used Programming Perl - the link for this in the email is to http://cgi-bin/koha/catalogue/detail.pl?biblionumber=262 (in the notice it is <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=262" class="title">), which is an invalid link without the domain name. Testing notes (using KTD): 1. After applying the patch, reset_all refreshes everything with the updated notice. (Need to set the required system preferences - enable CatalogConcerns, have a value for set CatalogerEmails, have a valid value for staffClientBaseURL, and have a valid email for the patron submitting the concern). 2. I'm not sure of the right steps using KTD to do the bonus test (test update from 22.11 to 23.05), so I haven't done that. 3. I set up email to test the actual emails received.[1] [1] To test sending emails using a Google account, edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where <user_name> = your Google email address; <password> = your APP password, not your Google account password): <smtp_server> <host>smtp.gmail.com</host> <port>587</port> <timeout>5</timeout> <ssl_mode>STARTTLS</ssl_mode> <user_name>GOOGLEACCOUNTUSER</user_name> <password>GOOGLEAPPPASSWORD</password> <debug>1</debug> </smtp_server> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 21:38:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 19:38:07 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-XBKYqWnQAB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #7 from David Nind <david at davidnind.com> --- (In reply to David Nind from comment #6) > In addition, should the link to the record title be fixed as well, or should > I log that as a separate bug? For example: I used Programming Perl - the > link for this in the email is to > http://cgi-bin/koha/catalogue/detail.pl?biblionumber=262 (in the notice it > is <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=262" > class="title">), which is an invalid link without the domain name. This is already logged as bug 33314. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 21:42:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 19:42:19 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-yzqjMGrZ0h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 21:42:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 19:42:22 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-0ktGWf4mRk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150130|0 |1 is obsolete| | --- Comment #8 from David Nind <david at davidnind.com> --- Created attachment 150135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150135&action=edit Bug 33313: Fix catalog links in TICKET_NOTIFY This fixes the system preference name from IntranetBaseURL to staffClientBaseURL. Also makes some small typo fixes. As this feature has just been pushed I chose to fix the database updates that will be run when installing 23.05. To test: * Verify the wrong link in TICKET_NOTIFY * Drop database, create database, run web installer * Verify the link is now correct in the notice Bonus: Test update from 22.11 to 23.05 and verify the notices are correct there as well. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 21:44:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 19:44:39 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-HcU8mjp5By@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #9 from David Nind <david at davidnind.com> --- Additional testing note (using KTD): 1. When applying the patch, DON'T follow 31028 (the main patch is pushed to master, some follow-up patches have not yet been pushed). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 22:35:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 20:35:41 +0000 Subject: [Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records In-Reply-To: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31028-70-3Q6aqRZEGa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33314 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 22:35:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 20:35:41 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-2uug3apls4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31028 |33313 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028 [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 22:35:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 20:35:41 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-bCbWCjsVQx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 22:37:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 20:37:19 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-4mnt9Dsu9l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I believe using the link here won't work as it is building a link for use inside of Koha - so missing the base URL part. It's not made for use in a notice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 22:42:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 20:42:31 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-mNZoBAuud9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 22:58:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 20:58:26 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-WBy7jiixZq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 22:58:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 20:58:28 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-D655LLVy2T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150136&action=edit Bug 33314: Fix link into staff catalog and link text Both fixes concern the TICKET_NOTIFY message. * biblio-title.inc builds a link with the intention of using it inside the Koha GUI. Therefore the baseURL part is missing. But we can use it for display and wrap it into a link. * Changes second link from reading 'page' to 'concern management page'. Accessiblity guidelines teach us that you should not link general terms, but always be specific. To test: 1. Make sure staffClientBaseURL is filled correctly 2. Enable CatalogConcerns 3. Enter an email address in CatalogerEmails 4. Go to a bibliographic record in the staff interface or in the OPAC 5. Click New > New catalog concern 6. Fill out the form and click Submit 7. Check the message_queue table for the message 8. Verify the first link is not working (incomplete) and the second is 'page' 9. Apply patch, drop db, create db and run web installer 10. Repeat setup and testing 11. Both links should now be updated and working -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 22:59:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 20:59:02 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-lDwwmcD9iy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to David Nind from comment #7) > (In reply to David Nind from comment #6) > > > In addition, should the link to the record title be fixed as well, or should > > I log that as a separate bug? For example: I used Programming Perl - the > > link for this in the email is to > > http://cgi-bin/koha/catalogue/detail.pl?biblionumber=262 (in the notice it > > is <a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=262" > > class="title">), which is an invalid link without the domain name. > > This is already logged as bug 33314. I was not aware of the other bug, I fixed the issue as a follow-up and made it dependent on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:17:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:17:01 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-somGXWZ0xC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:19:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:19:58 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-MzESFhEKSQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28488 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 [Bug 28488] Javascript error in self-checkout (__ is not defined) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:19:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:19:58 +0000 Subject: [Koha-bugs] [Bug 28488] Javascript error in self-checkout (__ is not defined) In-Reply-To: <bug-28488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28488-70-s3A32OJ1bf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32701 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 [Bug 32701] Self checkout help page lacks required I18N JavaScript -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:21:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:21:02 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-Y0OgAegSPB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:21:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:21:05 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-P59u5ddUZA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150137&action=edit Bug 32701: Fix I18N JavaScript libraries on self checkout help page The help page was missing the fixes from bug 28488. The missing libraries are causing a JavaScript error on the page and likely other issues. To test: * Make sure WebBasedSelfCheck is activated and configured Note: In ktd you don't need to configure anything, it's already set up. * In the OPAC, go to: /cgi-bin/koha/sco/sco-main.pl * Click on the link to the help in the top right corner * Verify you see the error in the console: jQuery.Deferred exception: __ is not defined * Apply patch * Restart things * Reload the page * Veriy the errors are gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:23:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:23:45 +0000 Subject: [Koha-bugs] [Bug 31582] With UseACQFrameworkForBiblioRecords 942$c doesn't display the itemtype pull-down In-Reply-To: <bug-31582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31582-70-JQdKeYTwD7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31582 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It's true, this is fixed in master now! *** This bug has been marked as a duplicate of bug 32484 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:23:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:23:45 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-UcJAcVsfqN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 31582 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:25:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:25:28 +0000 Subject: [Koha-bugs] [Bug 32484] Enable framework plugins when UseACQFrameworkForBiblioRecords is set In-Reply-To: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32484-70-xuGRjTtXH7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It appears that this fixed bug 31582. Any chance we could reasonably consider this for backporting maybe? This will also help immensely in not creating false record with missing LDR etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:28:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:28:55 +0000 Subject: [Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes In-Reply-To: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21083-70-VOioMeXTQ6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Did you see bug 33156? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:30:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:30:28 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-6lzJ1cBIiI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:40:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:40:03 +0000 Subject: [Koha-bugs] [Bug 33594] New: Sorting results by Title A-Z might use wrong title field Message-ID: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 Bug ID: 33594 Summary: Sorting results by Title A-Z might use wrong title field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de CC: januszop at gmail.com, nick at bywatersolutions.com Depends on: 33206 When sorting by title we expect the sorting to use 245, but this is not always the case. title in Elasticsearch is a broadly defined index, also containing other title fields. Example: * Search for 'e' with Elasticsearch in the sample data * Result will look something like this: 14. Agesilaos and the crisis of Sparta Paul Cartledge 15. Xenophƍntos Agēsilaos. Agesilaus of Xenophon / the text revised, with critical and explanatory notes, introduction, analyses and indices, by H. Hailstone. 16. Alcestis / Euripides ; edited with introduction and commentary by A.M. Dale. So what happened here? Look at the MARC of 15. - 240 was used: 240 1 0 _a Agesilaus. _l Greek. _f 1879 245 1 0 _a Xenophƍntos Agēsilaos. Agesilaus of Xenophon / _c the text revised, with critical and explanatory notes, introduction, analyses and indices, by H. Hailstone. Maybe we need a specific index definition for sorting? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 [Bug 33206] Bad title__sort made of multisubfield 245 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:40:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:40:03 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-GsH3pbZQq9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33594 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 [Bug 33594] Sorting results by Title A-Z might use wrong title field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:40:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:40:52 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-AI3aJk7yle@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:40:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:40:54 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-awXLygSWwM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149772|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150138&action=edit Bug 33206: Bad title__sort made of multifield 245 In MARC 21, having title search field defined in mappings.yaml as 245abp (more than one subfield), the Koha generated title__sort will have not only $a, but also other subfields cut by ind2 characters, i.e.: 245 04 $a Die Renaissance : $b Architektur, Plastik, Malerei, Illustrationen, Zeichnungen becomes as title__sort: Renaissance : itektur, Plastik, Malerei, Illustrationen, Zeichnungen instead of: Renaissance : Architektur, Plastik, Malerei, Illustrationen, Zeichnungen This is because copying an array of pointers in Perl causes you to point to the same (anonymous) element. Therefore, the intended modification only for subfield "a" (Koha/SearchEngine/Elasticsearch.pm, ~line 1157) causes in fact modification for all the subfields sharing the same mapping definition and introduction of the nonfiling_characters_indicator to all subfields 245 when processing 245abp. And this is obviously not what is intended and results (in some cases) with bad sort order when sorting by titles. Test plan ========= 1. Have a standard Koha ES installation. In mappings.yaml you should have 245abp for title search field. 2. Insert / download / modify a record with 245 $b or $p, an article at the beginning of the title, and correctly set 2nd indicator. For instance: 245 04 $a Die Renaissance : $b Architektur, Plastik, Malerei, Illustrationen, Zeichnungen 3. In ES, with Kibana or culr, control the content of title__sort field for the related document. It will be: Renaissance : itektur, Plastik, Malerei, Illustrationen, Zeichnungen 4. Apply the patch, full reindex ES (--rebuild -r -d -a -b) 5. In ES, with Kibana or culr, control the content of title__sort field for the related document. It should be now correct, i.e.: Renaissance : Architektur, Plastik, Malerei, Illustrationen, Zeichnungen Signed-off-by: Nick <nick at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:40:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:40:57 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-hZlMlsxF22@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149773|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150139&action=edit Bug 33206: Unit test Signed-off-by: Nick <nick at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:41:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:41:28 +0000 Subject: [Koha-bugs] [Bug 33206] Bad title__sort made of multisubfield 245 In-Reply-To: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33206-70-uxH4wZZau3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33206 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Signed-off-by: Nick <nick at bywatersolutions.com> ? Found some other 'oddness' with the title sorting, filed as bug 33594. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:47:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:47:04 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-W1ywC59ABf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:50:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:50:34 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-DAm6HTOeUN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Trusting Barbara and Lucas here for testing with Syndetics credentials. I have carefully reviewed the patch and compared it to how other syndetics file names were built previously and it all appears to match up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:50:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:50:38 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-cfKkezg2Vd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:52:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:52:12 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-9af9yzqi6j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:52:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:52:15 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-g91AsFBag7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149388|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150140&action=edit Bug 32041: Enforce SyndeticsCoverImageSize everywhere This patch add the SyndeticsCoverImageSize to the folling pages: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt To test: 1. Turn on SyndeticsCoverImages and SyndeticsEnabled. 2. Check the staff results page and make sure you can change the image size via SyndeticsCoverImageSize. 3. Check the OPAC results page. 4. Turn on 'OPACShelfBrowser' and make sure you change the image sizes within the shelf browser. 5. Test the OPAC checkout history page. ( opac-readingrecord.tt ) 6. Have a checkout and an overdue to test the 2 tables on the OPAC summary pahe. ( opac-user.tt ) Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:57:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:57:50 +0000 Subject: [Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button In-Reply-To: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33233-70-S00SAK2FQm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:57:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:57:53 +0000 Subject: [Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button In-Reply-To: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33233-70-4lO6kRosdp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149701|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 150141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150141&action=edit Bug 33233: Don't allow disabled attribute to remain when using browser's back button To test: 1. Go to OPAC advanced search and do a search using only one of the inputs. 2. Once the search is complete use the browser's back button to return to the advanced search. 3. Notice the unused inputs are disabled. 4. Apply patch and try again. Now the inputs should not be disabled. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:58:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:58:05 +0000 Subject: [Koha-bugs] [Bug 33233] OPAC advanced search inputs stay disabled when using browser's back button In-Reply-To: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33233-70-UtY4aVYRMv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 23 23:59:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 21:59:24 +0000 Subject: [Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences In-Reply-To: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33390-70-DahUIFWudi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 00:04:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 22:04:43 +0000 Subject: [Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences In-Reply-To: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33390-70-aJ2Pu2qLH8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Looking at this and as I won't finish right now, leaving a first note: ItemsDeniedRenewal: I feel the placement of the links right after the examples you can copy and paste is not ideal. Maybe we could put them into an explanatory sentence below? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 00:13:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 22:13:19 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-dzCuHCQA4w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 00:13:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 22:13:21 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-V1xxWICOv7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149834|0 |1 is obsolete| | --- Comment #14 from David Nind <david at davidnind.com> --- Created attachment 150142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150142&action=edit Bug 32931: Fix translatability issues on 'new agreement' form This fixes the "Yes" and "No" options and "License info" placeholder. To get to the options: 1. Enable the ERMModule system preference 2. Go to E-resource management 3. Click "Agreements" 4. Click "New agreement" --> Field "Is perpetual", options are Yes and No --> At the bottom of the form "License info" with "License info" within the input field 5. Install (complete) language, verify those are not translated 6. Apply patch 7. Update po files 8. Verify strings exist for this file, translate if necessary 9. Re-install language 10. Verify strings are now translated Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 00:13:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 22:13:24 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-p3TtNacUX9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149835|0 |1 is obsolete| | --- Comment #15 from David Nind <david at davidnind.com> --- Created attachment 150143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150143&action=edit Bug 32931: Fix translatability issues on 'show agreement' view Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 00:15:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 22:15:02 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-zR49hhqdN5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #12) > I've fixed Katrin's patch. > With this second patch it will work. Thank you - I was just doing it by trial and error mostly :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 00:50:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 22:50:03 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-A0YeGdnUU1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #17 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. Install a language: - cd misc/translator - ./translate install fr-CA 2. After applying the patch: - yarn js:build - flush_memcached and restart_all 3. Update the po files: - cd misc/translator - ./translate update fr-CA - vi po/fr-CA-messages-js.po - search for Yes, No and License info - should now be entries for ...AgreementsFormAdd.vue and ....AgreementsShow.vue files - reinstall the language: ./translate install fr-CA 4. When installing fr-CA (before and after the patch is applied) I get this message - does this need to be fixed? In file "admin.pref", "Options d'authentification" is a translation for sections "Google OpenID Connect", "Login options" at /kohadevbox/koha/misc/translator/LangInstaller.pm line 184. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 01:11:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 23:11:06 +0000 Subject: [Koha-bugs] [Bug 33304] Report schedule form time input element attribute type changed to improve valid time value entry In-Reply-To: <bug-33304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33304-70-xi2Gp1uiWp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304 --- Comment #7 from Adam Styles <adam.styles at esa.edu.au> --- Hi Katrin, Thanks for this feed back. I did not take into account any system preferences that might be applied to date/time format for this solution. I am happy to investigate how I can use Flatpickr to rebuild this. Thanks for the 'circulation' example. Stay tuned for a new patch soon. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 01:11:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 23:11:36 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-bbkJigsjth@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 01:13:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 23:13:36 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-KuHsnF8roP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 01:13:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 23:13:38 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-jpRYPYFGpm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150136|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 150144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150144&action=edit Bug 33314: Fix link into staff catalog and link text Both fixes concern the TICKET_NOTIFY message. * biblio-title.inc builds a link with the intention of using it inside the Koha GUI. Therefore the baseURL part is missing. But we can use it for display and wrap it into a link. * Changes second link from reading 'page' to 'concern management page'. Accessiblity guidelines teach us that you should not link general terms, but always be specific. To test: 1. Make sure staffClientBaseURL is filled correctly 2. Enable CatalogConcerns 3. Enter an email address in CatalogerEmails 4. Go to a bibliographic record in the staff interface or in the OPAC 5. Click New > New catalog concern 6. Fill out the form and click Submit 7. Check the message_queue table for the message 8. Verify the first link is not working (incomplete) and the second is 'page' 9. Apply patch, drop db, create db and run web installer 10. Repeat setup and testing 11. Both links should now be updated and working Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 01:16:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 23:16:39 +0000 Subject: [Koha-bugs] [Bug 33314] Link to bibliographic record incomplete in default TICKET_NOTIFY notice In-Reply-To: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33314-70-F0VM4ra9lH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33314 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. When applying the patch, DON'T follow 31028 (the main patch is pushed to master, some follow-up patches have not yet been pushed). 2. After applying the patch, reset_all refreshes everything with the updated notice (step 9). 3. I set up email to test the actual emails received.[1] [1] To test sending emails using a Google account, edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where <user_name> = your Google email address; <password> = your APP password, not your Google account password): <smtp_server> <host>smtp.gmail.com</host> <port>587</port> <timeout>5</timeout> <ssl_mode>STARTTLS</ssl_mode> <user_name>GOOGLEACCOUNTUSER</user_name> <password>GOOGLEAPPPASSWORD</password> <debug>1</debug> </smtp_server> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 01:18:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 23:18:37 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-L02MGMDq8g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 --- Comment #11 from David Nind <david at davidnind.com> --- (In reply to Katrin Fischer from comment #10) > > This is already logged as bug 33314. > > I was not aware of the other bug, I fixed the issue as a follow-up and made > it dependent on this one. Thanks for creating a patch for bug 33314! I've signed it off as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 01:27:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 23:27:57 +0000 Subject: [Koha-bugs] [Bug 32385] OPAC and staff (intranet) should not share the same session and cookie In-Reply-To: <bug-32385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32385-70-p4O4hHgmIL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32385 --- Comment #2 from David Cook <dcook at prosentient.com.au> --- Something else to keep in mind is cookie authentication for the REST API interface via the staff interface and OPAC. Maybe this is an opportunity to switch away from "CGISESSID" to more Koha-specific cookie names. There are over 200 references to CGISESSID in the code, although to lessen the work we could just change the cookie name for the OPAC. That would involve fewer script changes. Auth.pm would need an update at a minimum though. If someone is willing to do the work, I suppose there's no reason not to... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 01:30:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 23:30:44 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-HdjAxLzz37@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 01:30:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 23:30:46 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-nIN3lqLFdi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150137|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 150145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150145&action=edit Bug 32701: Fix I18N JavaScript libraries on self checkout help page The help page was missing the fixes from bug 28488. The missing libraries are causing a JavaScript error on the page and likely other issues. To test: * Make sure WebBasedSelfCheck is activated and configured Note: In ktd you don't need to configure anything, it's already set up. * In the OPAC, go to: /cgi-bin/koha/sco/sco-main.pl * Click on the link to the help in the top right corner * Verify you see the error in the console: jQuery.Deferred exception: __ is not defined * Apply patch * Restart things * Reload the page * Veriy the errors are gone Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 01:36:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 23:36:06 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-LDvlirVhEn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #8 from David Cook <dcook at prosentient.com.au> --- (In reply to Katrin Fischer from comment #7) > Marked bug 32385 as a dependency for this one. I think in order to have > different timeouts, we need different sessions first. I was thinking about alternatives but I think you might be right. In theory, an alternative would be to change how we handle timeouts. At the moment, the session is deleted if it's timed out, but we could remove those lines and leave the cleanup to the cleanup_database.pl cronjob. If someone was working in both the staff interface and OPAC, the OPAC could time out and prompt for login while they continued working in the staff interface. Then if they log into the OPAC, both interfaces will use the new session and new session cookie. However, I wonder if a browser might accidentally overwrite the new CGISESSID with the old CGISESSID if a staff interface action happens shortly after the new OPAC login... Maybe different sessions are the way to go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 01:54:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Apr 2023 23:54:30 +0000 Subject: [Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios In-Reply-To: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25870-70-xy44S2wTXU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870 --- Comment #37 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #35) > (In reply to Hammat wele from comment #34) > > I still need help with Koha::Biblios->search thing. how to use it to search > > biblio hidden_in_opac. With the Koha::Biblios->search adding the pagination > > would be more easier. > > How that? > You need to rewrite ->hidden_in_opac, to build a parameter hashref from the > syspref, then pass it to ->search > > I haven't had a deep look but I think it is possible and should work. I don't know if all item DB fields have matching index names/aliases, so that would be something that needs reviewing. (In reply to TomĂĄs Cohen Arazi from comment #36) > You really need to perform the search against the search engine, with any > implicit filtering like OpacHiddenItems added to the CCL query. Otherwise > you would kill the interesting bit of searching on the backend. Yeah, it'll need both OpacSuppression, OpacSuppressionByIPRange, and OpacHiddenItems checking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 02:01:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 00:01:30 +0000 Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit In-Reply-To: <bug-32556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32556-70-3HMf30LlsM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 --- Comment #10 from David Cook <dcook at prosentient.com.au> --- (In reply to Hans PĂ„lsson from comment #8) > If there is a solution i.e. use BIGINT instead of INT it is better to use it > in the schema instead of letting users run in to problems and having to find > this solution here. Good job everyone! Interestingly enough we ran into this same problem on a different system recently. The autonumber hit the ceiling on INT and we switched to BIGINT (using PostgreSQL rather than MySQL). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 02:06:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 00:06:27 +0000 Subject: [Koha-bugs] [Bug 32556] borrower_message_preference_id reaches limit In-Reply-To: <bug-32556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32556-70-Cmp4X6bCvD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32556 --- Comment #11 from David Cook <dcook at prosentient.com.au> --- (In reply to Magnus Enger from comment #7) > Next question then is: Should we change the schema and run Galen's solution > as part of an upgrade, or should we just document the quickfix for those > that run into the problem? And/or change how these message preferences are > handled? I think we need to change the schema as part of the upgrade. However, I think we could just use "FOREIGN_KEY_CHECKS" to disable the foreign key checks while changing from INT to BIGINT. That should make it a bit easier. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 02:13:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 00:13:59 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-HZmm2JUI2v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 --- Comment #27 from David Nind <david at davidnind.com> --- Just for information, here is a list of all the cataloging plugins/value builders in the folder and the related bug number: barcode_manual.pl - bug 32812 barcode.pl - bug 32813 callnumber-KU.pl - bug 32814 callnumber.pl - bug 32815 cn_browser.pl - bug 32816 dateaccessioned.pl - bug 32817 EXAMPLE.pl marc21_field_005.pl - bug 32818 marc21_field_006.pl marc21_field_007.pl marc21_field_008_authorities.pl marc21_field_008_classifications.pl marc21_field_008.pl marc21_field_245h.pl marc21_field_260b.pl marc21_leader_authorities.pl marc21_leader.pl marc21_linking_section.pl marc21_orgcode.pl stocknumberam123.pl - bug 32819 stocknumberAV.pl - bug 32820 stocknumber.pl - bug 32821 unimarc_field_009_ppn.pl unimarc_field_010.pl - bug 32822 unimarc_field_100_authorities.pl - bug 32823 unimarc_field_100.pl - bug 32824 unimarc_field_105.pl - bug 32825 unimarc_field_106.pl - bug 32826 unimarc_field_110.pl - bug 32827 unimarc_field_115a.pl - bug 32828 unimarc_field_115b.pl - bug 32829 unimarc_field_116.pl - bug 32830 unimarc_field_117.pl - bug 32831 unimarc_field_120.pl - bug 32832 unimarc_field_121a.pl - bug 32833 unimarc_field_121b.pl - bug 32834 unimarc_field_122.pl - bug 32835 unimarc_field_123a.pl - bug 32836 unimarc_field_123d.pl - bug 32837 unimarc_field_123e.pl - bug 32838 unimarc_field_123f.pl - bug 32839 unimarc_field_123g.pl - bug 32840 unimarc_field_123i.pl - bug 32841 unimarc_field_123j.pl - bug 32842 unimarc_field_124a.pl - bug 32843 unimarc_field_124b.pl - bug 32844 unimarc_field_124c.pl - bug 32845 unimarc_field_124d.pl - bug 32846 unimarc_field_124e.pl - bug 32847 unimarc_field_124f.pl - bug 32848 unimarc_field_124g.pl - bug 32849 unimarc_field_124.pl - bug 32850 unimarc_field_125a.pl - bug 32851 unimarc_field_125b.pl - bug 32852 unimarc_field_125.pl - bug 32853 unimarc_field_126a.pl - bug 32854 unimarc_field_126b.pl - bug 32855 unimarc_field_126.pl - bug 32856 unimarc_field_127.pl - bug 32857 unimarc_field_128a.pl - bug 32858 unimarc_field_128b.pl - bug 32859 unimarc_field_128c.pl - bug 32860 unimarc_field_130.pl - bug 32861 unimarc_field_135a.pl - bug 32862 unimarc_field_140.pl - bug 32863 unimarc_field_141.pl - bug 32864 unimarc_field_146a.pl - bug 32865 unimarc_field_146b.pl unimarc_field_146c.pl unimarc_field_146d.pl unimarc_field_146e.pl unimarc_field_146f.pl unimarc_field_146h.pl - bug 32866 unimarc_field_146i.pl - bug 32867 unimarc_field_181-2.pl unimarc_field_181a.pl unimarc_field_181b.pl unimarc_field_181c.pl unimarc_field_182-2.pl unimarc_field_182a.pl unimarc_field_182c.pl unimarc_field_183-2.pl unimarc_field_183a.pl unimarc_field_210c_bis.pl - bug 32868 unimarc_field_210c.pl - bug 32869 unimarc_field_225a_bis.pl - bug 32870 unimarc_field_225a.pl - bug 32871 unimarc_field_283-2.pl unimarc_field_283a.pl unimarc_field_325h.pl unimarc_field_325j.pl unimarc_field_4XX.pl - bug 32872 unimarc_field_686a.pl - bug 32873 unimarc_field_700-4.pl - bug 32874 unimarc_leader_authorities.pl - bug 32875 unimarc_leader.pl - bug 32876 upload.pl - bug 32877 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 02:20:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 00:20:24 +0000 Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered) In-Reply-To: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31631-70-6J7Fjam4tW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 --- Comment #28 from Alex Buckley <alexbuckley at catalyst.net.nz> --- Created attachment 150146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150146&action=edit Bug 31631: (follow-up) Fixes for failing unit test t/db_dependent/Budgets.t Test plan: 1. Set CalculateFundValuesIncludingTax = 'Include' 2. Run Budgets.t unit test sudo koha-shell kohadev prove t/db_dependent/Budgets.t 3. Set CalculateFundValuesIncludingTax = 'Exclude' 4. Run Budgets.t unit test sudo koha-shell kohadev prove t/db_dependent/Budgets.t Sponsored-By: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 02:21:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 00:21:25 +0000 Subject: [Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered) In-Reply-To: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31631-70-AxFmf7FOsi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #29 from Alex Buckley <alexbuckley at catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #27) > # Looks like you failed 4 tests of 156. > > # Failed test 'total spent for budget1 is 160' > # at t/db_dependent/Budgets.t line 436. > # got: '0' > # expected: '160' > > # Failed test 'total spent for budget11 is 100' > # at t/db_dependent/Budgets.t line 437. > # got: '0' > # expected: '100' > > # Failed test 'total spent for budget111 is 20' > # at t/db_dependent/Budgets.t line 438. > # got: '0' > # expected: '20' > > # Failed test 'total ordered price is 20' > # at t/db_dependent/Budgets.t line 519. > # got: '0' > # expected: '20' Thanks Marcel. I've attached a followup fixing the Budgets.t unit test when CalculateFundValuesIncludingTax is set to 'Include' or 'Exclude'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 03:44:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 01:44:36 +0000 Subject: [Koha-bugs] [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl In-Reply-To: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32865-70-bWb71WyBqt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Thanks Katrin, you beat me to it :) I confirm the that the plugin continues to work as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 04:18:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 02:18:06 +0000 Subject: [Koha-bugs] [Bug 26628] Clubs permissions should grant access to Tools page In-Reply-To: <bug-26628-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26628-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26628-70-idvqJtibog@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26628 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33595 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 08:44:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 06:44:24 +0000 Subject: [Koha-bugs] [Bug 33596] New: Merge result page is missing page-section Message-ID: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33596 Bug ID: 33596 Summary: Merge result page is missing page-section Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When merging 2 records in cataloguing the result shows a little table with the merged records in the last step. This page is missing page-sectioning. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 08:51:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 06:51:42 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-p7zQKUwlYk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #20) > Thanks Marcel. > > I also verified that this is working by running the translation scripts and > updating the po files. We now see a translated Not for loan according to > selected language. Great, thx. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 09:32:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 07:32:00 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-Pi0REmrvcq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 --- Comment #1 from Janusz Kaczmarek <januszop at gmail.com> --- I have encountered this some time ago. For me worked customizing the mappings.yaml as follows: - facet: '' marc_field: 240 marc_type: marc21 - sort: ~ + sort: '' suggestible: '' I.e. changing ~ into '' for all MARC fields except 245. For some to-me-mysterious reason, ~ (= undef) is explicitly interpreted as "yes, include it into the sort search field" by Koha/SearchEngine/Elasticsearch.pm: # Sort is a bit special as it can be true, false, undef. # We care about "true" or "undef", # "undef" means to do the default thing, which is make it sortable. So, since this is by design and mappings.yaml is configurable, I didn't treat it as a bug. Just use a customized copy of mappings. Please, check if changing ~ into '' works for you. Please, consider also if it is worth to be a bug. If so, the solution is there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 09:45:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 07:45:04 +0000 Subject: [Koha-bugs] [Bug 33581] Error in Webinstaller concerning sample holidays In-Reply-To: <bug-33581-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33581-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33581-70-g58jK0ojNJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33581 --- Comment #2 from Anke Bruns <anke.bruns at gwdg.de> --- Thanks for the explanation. The problem with sample branches is that there are quite a lot of them that are really cumbersome to remove later on. I would suggest either one of the following: - Reduce the number of sample branches to maybe one to three at most and explain in the web installer that they have to be checked for the sample holidays to function - change the order of the process so that people can add their own branch(es) before importing the sample holidays - just explain in the web installer that without the sample branches the sample holidays can't be imported, and give a hint how many sample branches there are so one knows what to expect. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 11:30:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 09:30:16 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-DmDJgXBZk5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 11:30:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 09:30:18 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-EGkHuji9zY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150147&action=edit Bug 33576: (QA follow-up) Polish comment, typo No test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 11:33:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 09:33:38 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-iNk8NwATwg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Feels like a race condition. So it depends who was faster: rabbitmq reading a new ticket or BatchCommitRecords doing the txn_commit. Agree with this patch. Happy to QA it. Do not have Elastic at hand for testing though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 11:34:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 09:34:05 +0000 Subject: [Koha-bugs] [Bug 33576] Records are not indexed when imported if using Elasticsearch In-Reply-To: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33576-70-TYlOCABpDH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33576 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:08:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:08:05 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23486-70-TBGOY9yPR5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I agree with Katrin here I'm afraid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:10:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:10:53 +0000 Subject: [Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow In-Reply-To: <bug-33544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33544-70-U98ACla8c3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] ILL API response objects inconsistent with other endpoints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:10:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:10:53 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-YbahRab5YF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 [Bug 33544] Squash some ILL fields to alleviate request table overflow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:11:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:11:10 +0000 Subject: [Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow In-Reply-To: <bug-33544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33544-70-ZsupgB74JG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- We'll knock something up once we have bug 22440 pushed :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:11:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:11:22 +0000 Subject: [Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow In-Reply-To: <bug-33544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33544-70-dEDz1B7mnh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:24:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:24:48 +0000 Subject: [Koha-bugs] [Bug 33597] New: Get rid of few SameSite warnings Message-ID: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Bug ID: 33597 Summary: Get rid of few SameSite warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:34:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:34:14 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-nmK3ZDQpo9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind <david at davidnind.com> --- I tested using KTD (changed database in .env file from DB_IMAGE=mariadb:10.5 to DB_IMAGE=mysql:8). I also tested using the default database (mariadb:10.5) - the tests pass before and after the patch is applied. Before patch applied (MySQL 8) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Before the patch was applied, I got these results: prove t/db_dependent/Koha/Database/Commenter.t t/db_dependent/Koha/Database/Commenter.t .. # Failed test 'No comment for toc_request' # at t/db_dependent/Koha/Database/Commenter.t line 34. # got: '0' # expected: '1' Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. # Failed test 'Numbered comment for toc_request' # at t/db_dependent/Koha/Database/Commenter.t line 39. # got: '0' # expected: '1' # Failed test 'Reset for one-columned article_requests' # at t/db_dependent/Koha/Database/Commenter.t line 49. # 'ALTER TABLE koha_kohadev.article_requests MODIFY COLUMN `toc_request` tinyint NOT NULL DEFAULT 0 COMMENT 'borrower requested table of contents';' # doesn't match '(?^um:ALTER.*toc_request.*DEFAULT 0;(.*\n)+ALTER.*toc_request.*COMMENT.*$)' # Looks like you failed 3 tests of 6. t/db_dependent/Koha/Database/Commenter.t .. 1/2 # Failed test '->new, dry_run' # at t/db_dependent/Koha/Database/Commenter.t line 52. # Failed test 'Found no comment for sometext' # at t/db_dependent/Koha/Database/Commenter.t line 61. # got: 'some nice quote's' # expected: '' # Failed test 'Found no comment for anotherint' # at t/db_dependent/Koha/Database/Commenter.t line 62. # got: 'my int' # expected: '' Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. Use of uninitialized value in string ne at /kohadevbox/koha/Koha/Database/Commenter.pm line 147. # Failed test 'Found Column_1' # at t/db_dependent/Koha/Database/Commenter.t line 73. # got: 'my int' # expected: 'Column_1' # Failed test 'Found Column_5' # at t/db_dependent/Koha/Database/Commenter.t line 74. # got: '' # expected: 'Column_5' # Looks like you failed 4 tests of 6. # Failed test '->clear, ->reset, ->renumber' # at t/db_dependent/Koha/Database/Commenter.t line 78. # Looks like you failed 2 tests of 2. t/db_dependent/Koha/Database/Commenter.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/2 subtests Test Summary Report ------------------- t/db_dependent/Koha/Database/Commenter.t (Wstat: 512 Tests: 2 Failed: 2) Failed tests: 1-2 Non-zero exit status: 2 Files=1, Tests=2, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.50 cusr 0.03 csys = 0.54 CPU) Result: FAIL After the patch was applied (MySQL 8) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ After the patch was applied, I got these results: prove t/db_dependent/Koha/Database/Commenter.t t/db_dependent/Koha/Database/Commenter.t .. 1/2 Failure for database_commenter_1:timestamp2 at /kohadevbox/koha/Koha/Database/Commenter.pm line 266. # Failed test 'Found Column_5' # at t/db_dependent/Koha/Database/Commenter.t line 80. # got: '' # expected: 'Column_5' # Looks like you failed 1 test of 6. # Failed test '->clear, ->reset, ->renumber' # at t/db_dependent/Koha/Database/Commenter.t line 84. # Looks like you failed 1 test of 2. t/db_dependent/Koha/Database/Commenter.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Test Summary Report ------------------- t/db_dependent/Koha/Database/Commenter.t (Wstat: 256 Tests: 2 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=2, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.50 cusr 0.06 csys = 0.58 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:41:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:41:37 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-gXwS3cufwV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:41:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:41:39 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-9i4RyZiAMe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150148&action=edit Bug 33597: Get rid of warning about intranet_bib_list Resolve: Cookie “intranet_bib_list” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. basket_22.1200022.js:67:65 Test plan: Do not apply this patch. Logout from staff. Check browser console warnings. Apply this patch. Login and logout again. Check warnings again. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:41:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:41:41 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-6qRyrH3bde@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150149&action=edit Bug 33597: Fix deleting cookie for holdfor(club) Resolve: Cookie “holdfor” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. Did not see warning for holdforclub. But since it is created with Lax, we should remove it with Lax. Test plan: Similar to previous patch. Check console on logout page. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:48:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:48:35 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-O2wJDHacpK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Trivial patches: self SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:48:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:48:42 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-5pOAq3IYD8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:52:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:52:17 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-CP8g8Uc3GZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150150&action=edit Bug 33597: (follow-up) Two other occurrences for holdfor Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 12:54:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 10:54:30 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-4FMJfElYDm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150150|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150151&action=edit Bug 33597: (follow-up) Two other occurrences for holdfor Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:00:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:00:09 +0000 Subject: [Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4 In-Reply-To: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33582-70-r1GQ9tguwj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:00:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:00:12 +0000 Subject: [Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4 In-Reply-To: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33582-70-JquOymeNlk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150152&action=edit Bug 33582: Use template wrapper for breadcrumbs: Tools, part 4 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Notices and slips - New notice - Edit notice - Confirm deletion - Batch patron modification - Overdue notice/status triggers - Cataloging -> - Manage staged records - Batch details - MARC modification templates - Edit actions for a template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:17:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:17:13 +0000 Subject: [Koha-bugs] [Bug 33598] New: Use template wrapper for breadcrumbs: Tools, part 5 Message-ID: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33598 Bug ID: 33598 Summary: Use template wrapper for breadcrumbs: Tools, part 5 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more tools templates so that they use the new template wrapper for breadcrumbs. - tools/page.tt - tools/picture-upload.tt - tools/problem-reports.tt - tools/quotes-upload.tt - tools/quotes.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:17:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:17:13 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32507-70-DqM9TeS8g8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33598 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33598 [Bug 33598] Use template wrapper for breadcrumbs: Tools, part 5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:27:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:27:25 +0000 Subject: [Koha-bugs] [Bug 33599] New: Use template wrapper for breadcrumbs: Tools, part 6 Message-ID: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Bug ID: 33599 Summary: Use template wrapper for breadcrumbs: Tools, part 6 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more tools templates so that they use the new template wrapper for breadcrumbs. - tools/page.tt - tools/picture-upload.tt - tools/problem-reports.tt - tools/quotes-upload.tt - tools/quotes.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:27:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:27:25 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32507-70-ToVeVTjQdX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33599 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 [Bug 33599] Use template wrapper for breadcrumbs: Tools, part 6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:29:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:29:01 +0000 Subject: [Koha-bugs] [Bug 33600] New: Use template wrapper for breadcrumbs: Tools, part 7 Message-ID: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33600 Bug ID: 33600 Summary: Use template wrapper for breadcrumbs: Tools, part 7 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more tools templates so that they use the new template wrapper for breadcrumbs. - tools/scheduler.tt - tools/showdiffmarc.tt - tools/stage-marc-import.tt - tools/stockrotation.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:29:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:29:01 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32507-70-6K2Yemh9Qz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33600 [Bug 33600] Use template wrapper for breadcrumbs: Tools, part 7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:29:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:29:52 +0000 Subject: [Koha-bugs] [Bug 33601] New: Use template wrapper for breadcrumbs: Tools, part 8 Message-ID: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 Bug ID: 33601 Summary: Use template wrapper for breadcrumbs: Tools, part 8 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update several more tools templates so that they use the new template wrapper for breadcrumbs. - tools/tools-home.tt - tools/upload-images.tt - tools/upload.tt - tools/viewlog.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:29:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:29:52 +0000 Subject: [Koha-bugs] [Bug 32507] Use template wrapper to build breadcrumb navigation In-Reply-To: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32507-70-fKmNOEpzKl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33601 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 [Bug 33601] Use template wrapper for breadcrumbs: Tools, part 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:39:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:39:42 +0000 Subject: [Koha-bugs] [Bug 33594] Sorting results by Title A-Z might use wrong title field In-Reply-To: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33594-70-sPqR1afEBB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33594 --- Comment #2 from Janusz Kaczmarek <januszop at gmail.com> --- (In reply to Janusz Kaczmarek from comment #1) > > I.e. changing ~ into '' for all MARC fields except 245. > I meant, for title search field, of course. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:52:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:52:29 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-AnwPlsPX7B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:54:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:54:13 +0000 Subject: [Koha-bugs] [Bug 33598] Use template wrapper for breadcrumbs: Tools, part 5 In-Reply-To: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33598-70-PgzksxxjbW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33598 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 13:54:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 11:54:16 +0000 Subject: [Koha-bugs] [Bug 33598] Use template wrapper for breadcrumbs: Tools, part 5 In-Reply-To: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33598-70-e39ZQcWwyH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33598 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150153&action=edit Bug 33598: Use template wrapper for breadcrumbs: Tools, part 5 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Pages -> - View a page in the staff interface - Upload patron images - Upload results - Quote editor - Quotes upload - OPAC problem reports (must have OPACReportProblem enabled) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 14:36:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 12:36:33 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-O9ZDCJ6nYI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 14:36:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 12:36:35 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-h7cu2u213G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150154&action=edit Bug 33584: (follow-up) Remove DEFAULT_GENERATED from column info MySQL 8 returns this additional information for a timestamp such as the timestamp2 in the Commenter test. Which results in the following alter: ALTER TABLE koha_myclone.database_commenter_1 MODIFY COLUMN `timestamp2` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP DEFAULT_GENERATED COMMENT 'Column_5' And that statement fails again on that keyword. For now, it seems sufficient to ignore this keyword when building the alter statement. Test plan: Run t/db_dependent/Koha/Database/Commenter.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Did test it now under MySQL 8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 14:38:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 12:38:35 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-nxmPPyVcb4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 14:40:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 12:40:21 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-hJ6H3TKbcK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #3) > Tomas: Could you please try to run the test with Mysql 8 ? Or just push and > see :) Tested it now with a Mysql 8 container myself :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 14:48:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 12:48:56 +0000 Subject: [Koha-bugs] [Bug 32748] Library limitations will cause data loss when editing items In-Reply-To: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32748-70-H97MVQinTa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 14:48:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 12:48:58 +0000 Subject: [Koha-bugs] [Bug 32748] Library limitations will cause data loss when editing items In-Reply-To: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32748-70-Kb7mLyfb8T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748 Thibaud Guillot <thibaud.guillot at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148491|0 |1 is obsolete| | --- Comment #10 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Created attachment 150155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150155&action=edit Bug 32748: Prevent data erasing when editing item When we set an authorised value linked to one library, users who do not belong to this library do not get the value and can therefore overwrite it. This patch add current value to the dropdown list even if it comes from an authorized value of another library. Test plan : 1) Edit an item with one of these fields has an authorized value from another library. 2) See that you don't get this value on 'edit' 3) Apply this patch 4) Refresh and do step 1 5) Now you have the value in dropdown list and a tooltip info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 14:53:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 12:53:15 +0000 Subject: [Koha-bugs] [Bug 32748] Library limitations will cause data loss when editing items In-Reply-To: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32748-70-Vfix774yL9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748 --- Comment #11 from Thibaud Guillot <thibaud.guillot at biblibre.com> --- Hello, I followed your advice to rework the patch to change the behavior of the GetAuthorisedValues function and then use the values obtained to target authorised values from other librairies. I have however the problem concerning the icon that I can't see :-/ (if anyone has an idea ?) I submit you this patch to know if I'm going in the right direction. Thanks for your future feedbacks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:10:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:10:36 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15348-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15348-70-sgurW7Y1AS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #136 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- (In reply to Katrin Fischer from comment #135) > Should this be needs documenting? I don,t think so. I already submitted something to the manual for this last week. I left it "Pushed to master" because to me, that means release maintainers haven't decided to backport it or not. If they have decided not to backport it, it can be set to resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:28:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:28:15 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-aVj6IxZcs0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- When I try deleting, I have extra quotes. Confirm deletion of restriction 'Manual''') > ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:42:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:42:29 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-FQMNZsY7Lx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #18 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- (In reply to David Nind from comment #17) > 4. When installing fr-CA (before and after the patch is applied) I get this > message - does this need to be fixed? > > In file "admin.pref", "Options d'authentification" is a translation for > sections "Google OpenID Connect", "Login options" at > /kohadevbox/koha/misc/translator/LangInstaller.pm line 184. It's already fixed in Pootle. However, I don't know how to make it so that the commited files are also corrected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:01 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-TSLTH2PYQo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:02 +0000 Subject: [Koha-bugs] [Bug 30352] "Not for loan" in result list doesn't translate in OPAC In-Reply-To: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30352-70-tn6O9Ay2VW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30352 --- Comment #22 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:04 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-L4eIvRlR2n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:06 +0000 Subject: [Koha-bugs] [Bug 32041] OPAC and staff client results page do not honor SyndeticsCoverImageSize In-Reply-To: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32041-70-77dLZi9fjd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32041 --- Comment #16 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:08 +0000 Subject: [Koha-bugs] [Bug 32817] Clean up cataloguing/value_builder/dateaccessioned.pl In-Reply-To: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32817-70-bf59NZlSPp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:10 +0000 Subject: [Koha-bugs] [Bug 32817] Clean up cataloguing/value_builder/dateaccessioned.pl In-Reply-To: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32817-70-ilaOKUNZ9d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32817 --- Comment #11 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:12 +0000 Subject: [Koha-bugs] [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl In-Reply-To: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32818-70-WWp8Jzeymp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:14 +0000 Subject: [Koha-bugs] [Bug 32818] Clean up cataloguing/value_builder/marc21_field_005.pl In-Reply-To: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32818-70-x53C0NkKcR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32818 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:15 +0000 Subject: [Koha-bugs] [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl In-Reply-To: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32865-70-9zNg5ylK7g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:17 +0000 Subject: [Koha-bugs] [Bug 32865] Clean up cataloguing/value_builder/unimarc_field_146a.pl In-Reply-To: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32865-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32865-70-0RQkjAFZI9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32865 --- Comment #9 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:19 +0000 Subject: [Koha-bugs] [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl In-Reply-To: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32866-70-QwOXYK83bq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:21 +0000 Subject: [Koha-bugs] [Bug 32866] Clean up cataloguing/value_builder/unimarc_field_146h.pl In-Reply-To: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32866-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32866-70-cJjZ1L3gIA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32866 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:23 +0000 Subject: [Koha-bugs] [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl In-Reply-To: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32867-70-oSWZcwbgPn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:25 +0000 Subject: [Koha-bugs] [Bug 32867] Clean up cataloguing/value_builder/unimarc_field_146i.pl In-Reply-To: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32867-70-Gfq6VqPVCl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32867 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:27 +0000 Subject: [Koha-bugs] [Bug 32868] Fix cataloguing/value_builder/unimarc_field_210c_bis.pl In-Reply-To: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32868-70-VZJt4S9bYm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32868 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:28 +0000 Subject: [Koha-bugs] [Bug 32868] Fix cataloguing/value_builder/unimarc_field_210c_bis.pl In-Reply-To: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32868-70-l9tDdHP2I8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32868 --- Comment #8 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:30 +0000 Subject: [Koha-bugs] [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl In-Reply-To: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32869-70-mqWS1TOSso@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:32 +0000 Subject: [Koha-bugs] [Bug 32869] Fix cataloguing/value_builder/unimarc_field_210c.pl In-Reply-To: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32869-70-RLOAlJyc9E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32869 --- Comment #9 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:34 +0000 Subject: [Koha-bugs] [Bug 32870] Fix cataloguing/value_builder/unimarc_field_225a_bis.pl In-Reply-To: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32870-70-fArFqZmc4c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32870 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:36 +0000 Subject: [Koha-bugs] [Bug 32870] Fix cataloguing/value_builder/unimarc_field_225a_bis.pl In-Reply-To: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32870-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32870-70-kYzBe5DdwX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32870 --- Comment #8 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:38 +0000 Subject: [Koha-bugs] [Bug 32871] Fix cataloguing/value_builder/unimarc_field_225a.pl In-Reply-To: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32871-70-zBDg2MdSBg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32871 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:39 +0000 Subject: [Koha-bugs] [Bug 32871] Fix cataloguing/value_builder/unimarc_field_225a.pl In-Reply-To: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32871-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32871-70-dDZWTH20IZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32871 --- Comment #7 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:41 +0000 Subject: [Koha-bugs] [Bug 32872] Fix cataloguing/value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32872-70-5TxqlDs1KH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32872 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:43 +0000 Subject: [Koha-bugs] [Bug 32872] Fix cataloguing/value_builder/unimarc_field_4XX.pl In-Reply-To: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32872-70-kEKc2cQONA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32872 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:45 +0000 Subject: [Koha-bugs] [Bug 32873] Fix cataloguing/value_builder/unimarc_field_686a.pl In-Reply-To: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32873-70-vJo5TZhnfZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32873 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:47 +0000 Subject: [Koha-bugs] [Bug 32873] Fix cataloguing/value_builder/unimarc_field_686a.pl In-Reply-To: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32873-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32873-70-eOEPxGHwvY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32873 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:48 +0000 Subject: [Koha-bugs] [Bug 32875] Fix cataloguing/value_builder/unimarc_leader_authorities.pl In-Reply-To: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32875-70-PVPWlbCy8w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32875 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:50 +0000 Subject: [Koha-bugs] [Bug 32875] Fix cataloguing/value_builder/unimarc_leader_authorities.pl In-Reply-To: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32875-70-tLT1IiysYY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32875 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:52 +0000 Subject: [Koha-bugs] [Bug 32876] Fix cataloguing/value_builder/unimarc_leader.pl In-Reply-To: <bug-32876-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32876-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32876-70-KtekyuoLzR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32876 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:54 +0000 Subject: [Koha-bugs] [Bug 32876] Fix cataloguing/value_builder/unimarc_leader.pl In-Reply-To: <bug-32876-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32876-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32876-70-W8FcCDWeeQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32876 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:56 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-H5TQbruCZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:49:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:49:58 +0000 Subject: [Koha-bugs] [Bug 33128] Add Polish translations for language descriptions In-Reply-To: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33128-70-r1mW9drEBf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33128 --- Comment #9 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:00 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-dw32jfRXPK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:02 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33300-70-JgO6kkpmML@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 --- Comment #16 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:04 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-hiqG0zUic4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:06 +0000 Subject: [Koha-bugs] [Bug 33549] Patron restriction types - Style missing for dialog messages In-Reply-To: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33549-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33549-70-7ucANH9npR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33549 --- Comment #6 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:08 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-Z4pEQDxS9p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:09 +0000 Subject: [Koha-bugs] [Bug 33560] Batch edit link broken if subscriptions are selected using "select all" link In-Reply-To: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33560-70-NVzV7VB6br@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33560 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:11 +0000 Subject: [Koha-bugs] [Bug 33565] Use template wrapper for breadcrumbs: Tags In-Reply-To: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33565-70-AlOpU72JEX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33565 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:13 +0000 Subject: [Koha-bugs] [Bug 33565] Use template wrapper for breadcrumbs: Tags In-Reply-To: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33565-70-CbK28IbLfZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33565 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:14 +0000 Subject: [Koha-bugs] [Bug 33571] Use template wrapper for breadcrumbs: Tools, part 2 In-Reply-To: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33571-70-wLUukwKOrR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33571 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:17 +0000 Subject: [Koha-bugs] [Bug 33571] Use template wrapper for breadcrumbs: Tools, part 2 In-Reply-To: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33571-70-qPjndiQfjm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33571 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:19 +0000 Subject: [Koha-bugs] [Bug 33572] Use template wrapper for breadcrumbs: Tools, part 3 In-Reply-To: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33572-70-Zrure64idY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33572 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:20 +0000 Subject: [Koha-bugs] [Bug 33572] Use template wrapper for breadcrumbs: Tools, part 3 In-Reply-To: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33572-70-tNV0HVuIq8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33572 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:22 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-ETpvKm6QRK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:24 +0000 Subject: [Koha-bugs] [Bug 33577] Buttons on reserve/request.pl are misaligned In-Reply-To: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33577-70-9rf2se6PBN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33577 --- Comment #4 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:26 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-6synxuWUms@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 15:50:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 13:50:28 +0000 Subject: [Koha-bugs] [Bug 33579] Typo: record record In-Reply-To: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33579-70-DgQ5rgTAMh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33579 --- Comment #5 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:09:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:09:14 +0000 Subject: [Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4 In-Reply-To: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33582-70-IcPMpfLpPL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150152|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 150156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150156&action=edit Bug 33582: Use template wrapper for breadcrumbs: Tools, part 4 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Notices and slips - New notice - Edit notice - Confirm deletion - Batch patron modification - Overdue notice/status triggers - Cataloging -> - Manage staged records - Batch details - MARC modification templates - Edit actions for a template Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:09:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:09:29 +0000 Subject: [Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4 In-Reply-To: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33582-70-4Lzb8I8T4K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:21:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:21:31 +0000 Subject: [Koha-bugs] [Bug 33598] Use template wrapper for breadcrumbs: Tools, part 5 In-Reply-To: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33598-70-9xYgtRUgpd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33598 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150153|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 150157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150157&action=edit Bug 33598: Use template wrapper for breadcrumbs: Tools, part 5 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Pages -> - View a page in the staff interface - Upload patron images - Upload results - Quote editor - Quotes upload - OPAC problem reports (must have OPACReportProblem enabled) Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:21:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:21:48 +0000 Subject: [Koha-bugs] [Bug 33598] Use template wrapper for breadcrumbs: Tools, part 5 In-Reply-To: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33598-70-fUBCBPpm14@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33598 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:29:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:29:36 +0000 Subject: [Koha-bugs] [Bug 33600] Use template wrapper for breadcrumbs: Tools, part 7 In-Reply-To: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33600-70-dB3kvKxlwG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33600 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:29:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:29:38 +0000 Subject: [Koha-bugs] [Bug 33600] Use template wrapper for breadcrumbs: Tools, part 7 In-Reply-To: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33600-70-QOIV4NPTdI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33600 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150158&action=edit Bug 33600: Use template wrapper for breadcrumbs: Tools, part 7 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Task scheduler - Cataloging -> - Stage MARC records for import (use a batch of MARC records which will match existing records) - View batch -> - View diff of records with a match - Stock rotation (must have StockRotation enabled) - New rota - Edit rota - Manage stages - Manage items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:41:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:41:47 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-9asb9GgkMC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:41:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:41:49 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-rCIKj8BLkG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150154|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:41:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:41:50 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-k9VHCpiTZI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150068|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:44:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:44:06 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-HQ8G8XKyuu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 --- Comment #8 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- I tested with: $ DB_IMAGE=mysql:8 ktd up -d $ ktd --shell $ prove t/db_dependent/Koha/Database/Commenter.t and $ ktd down $ DB_IMAGE=mariadb:10.5 ktd up -d $ ktd --shell $ prove t/db_dependent/Koha/Database/Commenter.t In both cases it run fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:44:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:44:38 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-397fAJePR3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:44:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:44:41 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-peqEfIolUX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 --- Comment #9 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 150159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150159&action=edit Bug 33584: Fix failures for Commenter.t on MySQL8 The column names from information_schema are uppercase now in MySQL8. In the arrayref with sliced hashes, we expected lowercase. See e.g. https://stackoverflow.com/questions/54538448/what-are-the-changes-in-mysql-8-result-rowset-case Test plan: Run t/db_dependent/Koha/Database/Commenter.t Do it again if possible with a MySQL 8 db server. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:44:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:44:44 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-mJfy9e88tN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 --- Comment #10 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 150160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150160&action=edit Bug 33584: (follow-up) Remove DEFAULT_GENERATED from column info MySQL 8 returns this additional information for a timestamp such as the timestamp2 in the Commenter test. Which results in the following alter: ALTER TABLE koha_myclone.database_commenter_1 MODIFY COLUMN `timestamp2` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP DEFAULT_GENERATED COMMENT 'Column_5' And that statement fails again on that keyword. For now, it seems sufficient to ignore this keyword when building the alter statement. Test plan: Run t/db_dependent/Koha/Database/Commenter.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Did test it now under MySQL 8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:45:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:45:53 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-GDRbVYhbJw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use template wrapper for |Use template wrapper for |breadcrumbs: Tools, part 6 |breadcrumbs: Various --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- To continue the process started by Bug 32507, this patch will update various templates so that they use the new template wrapper for breadcrumbs. - ill/ill-requests.tt - reserve/request.tt - reviews/reviewswaiting.tt - suggestion/suggestion.tt - virtualshelves/shelves.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:46:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:46:36 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-0uksdtyPmd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150159|0 |1 is obsolete| | --- Comment #11 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 150161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150161&action=edit Bug 33584: Fix failures for Commenter.t on MySQL8 The column names from information_schema are uppercase now in MySQL8. In the arrayref with sliced hashes, we expected lowercase. See e.g. https://stackoverflow.com/questions/54538448/what-are-the-changes-in-mysql-8-result-rowset-case Test plan: Run t/db_dependent/Koha/Database/Commenter.t Do it again if possible with a MySQL 8 db server. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 16:46:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 14:46:39 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-j7YS11Cv6j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150160|0 |1 is obsolete| | --- Comment #12 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Created attachment 150162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150162&action=edit Bug 33584: (follow-up) Remove DEFAULT_GENERATED from column info MySQL 8 returns this additional information for a timestamp such as the timestamp2 in the Commenter test. Which results in the following alter: ALTER TABLE koha_myclone.database_commenter_1 MODIFY COLUMN `timestamp2` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP DEFAULT_GENERATED COMMENT 'Column_5' And that statement fails again on that keyword. For now, it seems sufficient to ignore this keyword when building the alter statement. Test plan: Run t/db_dependent/Koha/Database/Commenter.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Did test it now under MySQL 8. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 17:04:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 15:04:40 +0000 Subject: [Koha-bugs] [Bug 31256] Circ rules batch modification In-Reply-To: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31256-70-F05ty1A2ZU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256 --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- (In reply to Christopher Brannon from comment #10) > (In reply to Caroline Cyr La Rose from comment #5) > > Hi all, it's not an overall solution to batch edit rules (I honestly have no > > idea what that would look like or what it would entail), but a lot of > > schools might find this plugin useful to change hard due dates in batch > > https://inlibro.com/en/koha-plugins/#rule-hard-due-date . It's not perfect, > > as few plugins are imo, but a usable alternative to manually changing hard > > due dates until it's possible to batch edit rule in the koha interface. > > I just looked at this plugin, and it looks like it will affect ALL branches. > I am not seeing an option to only make changes to specific branches. Also, > it affects items already in circulation. Again, I don't want to touch stuff > that was already given a due date. So, it does not look like we can even > use this as a work around. Is it possible we're not talking about the same plugin? I'm talking about the one called Rule Hard Due Date. (We have another one called Change Due Date that affects checkouts that we had created before the tool was added to Koha during the pandemic and that we still keep it around because the one in Koha is missing some functionality that we had.) I don't want to hijack this bug report to discuss the plugin, but I can confirm it can only affect specific branches if you specify the branch in the form (you can specify library, itemtype and/or patron category and it will only affect the rules that meet those criteria). And it does not affect current checkouts. Our school libraries have been using this for many years, and as far as I know it meets their need. Feel free to email me or the mailing list to further discuss the plugin or concerns about it. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 17:15:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 15:15:24 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-9A65KIPivC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150043|0 |1 is obsolete| | --- Comment #24 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150163&action=edit Bug 33355: Fix is_perpetual radio buttons in AgreementsFormAdd Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 17:15:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 15:15:27 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-S5HumT9u6A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150044|0 |1 is obsolete| | --- Comment #25 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150164&action=edit Bug 33355: Update forms markup to be in line with interface patterns https://wiki.koha-community.org/wiki/Interface_patterns Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 17:15:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 15:15:30 +0000 Subject: [Koha-bugs] [Bug 33355] ERM UI and markup has some issues In-Reply-To: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33355-70-f492isXY7Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33355 Pedro Amorim <pedro.amorim at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150045|0 |1 is obsolete| | --- Comment #26 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150165&action=edit Bug 33355: Add missing counter number to related users in agreements and licenses to be in line with other related content Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 17:27:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 15:27:50 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-kWLOk5lwYR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 17:34:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 15:34:50 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-O9O9atkzJc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 17:34:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 15:34:52 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-1BFGp3Dsj4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 --- Comment #13 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 17:54:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 15:54:04 +0000 Subject: [Koha-bugs] [Bug 32399] Database update for bug 30483 is failing In-Reply-To: <bug-32399-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32399-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32399-70-lI0igSCHuo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32399 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.01 |23.05.00,22.11.01,22.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #27 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 17:54:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 15:54:13 +0000 Subject: [Koha-bugs] [Bug 32399] Database update for bug 30483 is failing In-Reply-To: <bug-32399-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32399-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32399-70-dD9bluLA1B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32399 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:31:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:31:39 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: <bug-32804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32804-70-yzJxmvq013@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 --- Comment #27 from Lucas Gass <lucas at bywatersolutions.com> --- Merge conflicts with 22.05.x, no backport. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:33:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:33:50 +0000 Subject: [Koha-bugs] [Bug 33151] Improve translation of strings in cities and circulation desk administration pages In-Reply-To: <bug-33151-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33151-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33151-70-WD8n3XVaw8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33151 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.12 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:34:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:34:35 +0000 Subject: [Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv In-Reply-To: <bug-32923-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32923-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32923-70-dHzcb5zCsL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #42 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:34:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:34:35 +0000 Subject: [Koha-bugs] [Bug 32806] Some Vue files need to be moved for better reusability In-Reply-To: <bug-32806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32806-70-Rzum8tElHh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 Bug 32806 depends on bug 32923, which changed state. Bug 32923 Summary: x-koha-embed must a header of collectionFormat csv https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:40:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:40:39 +0000 Subject: [Koha-bugs] [Bug 32118] Clarify expansion/embed modifiers In-Reply-To: <bug-32118-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32118-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32118-70-VtsMlA3TNJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32118 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:41:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:41:35 +0000 Subject: [Koha-bugs] [Bug 32421] Add collection ( ccode ) column to holds to pull In-Reply-To: <bug-32421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32421-70-1Ea8JjLbJm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32421 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:45:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:45:06 +0000 Subject: [Koha-bugs] [Bug 32713] x-koha-embed appears to no longer properly validate In-Reply-To: <bug-32713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32713-70-80p0A1QWgC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32713 --- Comment #19 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply clean to 22.05.x, no backport. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:50:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:50:16 +0000 Subject: [Koha-bugs] [Bug 33227] OpenAPI validation is failing for paths/biblios.yaml In-Reply-To: <bug-33227-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33227-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33227-70-nNgUH4y9On@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33227 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply cleanly in 22.05.x, if needed please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:51:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:51:33 +0000 Subject: [Koha-bugs] [Bug 33060] Fix yes/no setting to 1/0 in system preference YAML files In-Reply-To: <bug-33060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33060-70-eKXZN8aX88@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33060 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:54:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:54:10 +0000 Subject: [Koha-bugs] [Bug 33282] Cypress tests are failing In-Reply-To: <bug-33282-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33282-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33282-70-lel2sOXpyl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33282 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:55:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:55:28 +0000 Subject: [Koha-bugs] [Bug 33290] Incorrect variable used in http-client.js In-Reply-To: <bug-33290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33290-70-6td7bodB4i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed in 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:55:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:55:28 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33289-70-nNb6jPOQ2A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 Bug 33289 depends on bug 33290, which changed state. Bug 33290 Summary: Incorrect variable used in http-client.js https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33290 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:56:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:56:16 +0000 Subject: [Koha-bugs] [Bug 33019] Records not indexed in Elasticsearch ES when first catalogued In-Reply-To: <bug-33019-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33019-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33019-70-UyjAk4THGp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33019 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #16 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:57:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:57:55 +0000 Subject: [Koha-bugs] [Bug 33137] Make sure columns on transactions and 'pay fines' tab are matching up In-Reply-To: <bug-33137-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33137-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33137-70-Az3h5uLFIM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33137 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #19 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 18:59:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 16:59:42 +0000 Subject: [Koha-bugs] [Bug 33309] Race condition while checkout renewal with ES In-Reply-To: <bug-33309-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33309-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33309-70-nk1HaGs2ig@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33309 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:01:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:01:23 +0000 Subject: [Koha-bugs] [Bug 30966] Record overlay rules - can't use Z39.50 filter In-Reply-To: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30966-70-ikPyxw9Q2b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | --- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:02:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:02:43 +0000 Subject: [Koha-bugs] [Bug 32883] Curbside pickups - Order "To be staged" by date and time of scheduled pickup In-Reply-To: <bug-32883-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32883-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32883-70-Ow8VO2dykj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32883 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:04:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:04:09 +0000 Subject: [Koha-bugs] [Bug 33198] request.pl is calculating pickup locations that are not used In-Reply-To: <bug-33198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33198-70-TcDO5oQklL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33198 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:04:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:04:45 +0000 Subject: [Koha-bugs] [Bug 33278] Correct JS for activating default tab on various pages In-Reply-To: <bug-33278-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33278-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33278-70-G4cF8td6tV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:04:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:04:46 +0000 Subject: [Koha-bugs] [Bug 33181] Use template wrapper for tabs on record merge pages In-Reply-To: <bug-33181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33181-70-tYzR4qjWec@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33181 Bug 33181 depends on bug 33278, which changed state. Bug 33278 Summary: Correct JS for activating default tab on various pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33278 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:05:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:05:13 +0000 Subject: [Koha-bugs] [Bug 29222] OMNIBUS: Replace the use of jQueryUI In-Reply-To: <bug-29222-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29222-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29222-70-uixookvhwt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29222 Bug 29222 depends on bug 32969, which changed state. Bug 32969 Summary: Remove references to jQueryUI assets and style in the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:05:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:05:13 +0000 Subject: [Koha-bugs] [Bug 32969] Remove references to jQueryUI assets and style in the OPAC In-Reply-To: <bug-32969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32969-70-yH0r16YMeg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:05:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:05:13 +0000 Subject: [Koha-bugs] [Bug 32998] Consolidate opac-tmpl/lib and opac-tmpl/bootstrap/lib In-Reply-To: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32998-70-F9fpOhAPUd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32998 Bug 32998 depends on bug 32969, which changed state. Bug 32969 Summary: Remove references to jQueryUI assets and style in the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32969 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:06:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:06:06 +0000 Subject: [Koha-bugs] [Bug 32003] Accessibility: Order search results has two h1 headings In-Reply-To: <bug-32003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32003-70-2DujQIioN5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:06:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:06:43 +0000 Subject: [Koha-bugs] [Bug 32807] No need to fetch all if we need to know if one exist In-Reply-To: <bug-32807-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32807-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32807-70-84EaNE63gi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32807 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:07:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:07:19 +0000 Subject: [Koha-bugs] [Bug 33133] Fast cataloging should be visible in cataloging In-Reply-To: <bug-33133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33133-70-V2jXcEefXe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33133 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:13:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:13:45 +0000 Subject: [Koha-bugs] [Bug 33600] Use template wrapper for breadcrumbs: Tools, part 7 In-Reply-To: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33600-70-2wHnrHlA4i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33600 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150158|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 150166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150166&action=edit Bug 33600: Use template wrapper for breadcrumbs: Tools, part 7 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Task scheduler - Cataloging -> - Stage MARC records for import (use a batch of MARC records which will match existing records) - View batch -> - View diff of records with a match - Stock rotation (must have StockRotation enabled) - New rota - Edit rota - Manage stages - Manage items Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:14:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:14:25 +0000 Subject: [Koha-bugs] [Bug 33600] Use template wrapper for breadcrumbs: Tools, part 7 In-Reply-To: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33600-70-pBjxPeauBM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33600 Andrew Auld <andrew.auld at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrew.auld at ptfs-europe.com --- Comment #3 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Works beautifully thanks Owen...and I learned how to export and then import marc records! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:17:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:17:11 +0000 Subject: [Koha-bugs] [Bug 33341] Perl 5.36 doesn't consider some of our code cool In-Reply-To: <bug-33341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33341-70-s5AoyrOYfX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33341 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:18:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:18:00 +0000 Subject: [Koha-bugs] [Bug 33136] Catalog search pop-up is missing page-section In-Reply-To: <bug-33136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33136-70-7XewpMzJSL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33136 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas at bywatersolutions.com Resolution|--- |FIXED --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:18:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:18:01 +0000 Subject: [Koha-bugs] [Bug 31757] [Omnibus] Add 'page-section' where it's missing In-Reply-To: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31757-70-4n9IqXrCUI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 Bug 31757 depends on bug 33136, which changed state. Bug 33136 Summary: Catalog search pop-up is missing page-section https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33136 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:19:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:19:54 +0000 Subject: [Koha-bugs] [Bug 29234] Transfers generated by stock rotation alert but do not initiate at checkin In-Reply-To: <bug-29234-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29234-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29234-70-cgbgq4Ll5w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29234 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:22:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:22:16 +0000 Subject: [Koha-bugs] [Bug 33346] Add Help link to Koha manual in ERM module In-Reply-To: <bug-33346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33346-70-I86sNZSK5D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33346 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> --- Not needed in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:23:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:23:09 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-XwP2UYhCQa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149909|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 150167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150167&action=edit Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Serials home page - New subscription - Serials search results - Subscription details -> Edit subscription - Subscription details -> Serial collection -> Edit serials - Select one or more seach results and click the "Edit selected serials" to test the batch edit page Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:23:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:23:46 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-oubddy8ehc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Andrew Auld <andrew.auld at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrew.auld at ptfs-europe.com --- Comment #4 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Lovely, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:24:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:24:41 +0000 Subject: [Koha-bugs] [Bug 33168] Timeline on "About Koha" is not working for package installs In-Reply-To: <bug-33168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33168-70-pVat62rT7U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33168 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | --- Comment #47 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:26:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:26:39 +0000 Subject: [Koha-bugs] [Bug 28641] ILLHiddenRequestStatuses does not consider custom statuses In-Reply-To: <bug-28641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28641-70-X2ONGxuLfG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28641 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | CC| |lucas at bywatersolutions.com --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:27:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:27:10 +0000 Subject: [Koha-bugs] [Bug 31409] Set focus for cursor to Fund code when adding a new fund In-Reply-To: <bug-31409-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31409-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31409-70-scGgwQv16z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31409 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:27:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:27:11 +0000 Subject: [Koha-bugs] [Bug 31411] [Omnibus] Set focus to first input field of an add/entry form In-Reply-To: <bug-31411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31411-70-TDMPFaqbsp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411 Bug 31411 depends on bug 31409, which changed state. Bug 31409 Summary: Set focus for cursor to Fund code when adding a new fund https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31409 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:27:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:27:39 +0000 Subject: [Koha-bugs] [Bug 32771] Standardize structure around action fieldsets in serials In-Reply-To: <bug-32771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32771-70-je9w2Sy0zN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:27:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:27:39 +0000 Subject: [Koha-bugs] [Bug 32744] [OMNIBUS] Standardize structure around action fieldsets In-Reply-To: <bug-32744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32744-70-q6SdfPiOlp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32744 Bug 32744 depends on bug 32771, which changed state. Bug 32771 Summary: Standardize structure around action fieldsets in serials https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32771 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:29:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:29:20 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13976-70-i0q8RJZxFS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #31 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:30:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:30:12 +0000 Subject: [Koha-bugs] [Bug 32437] When adding to a basket form a staged file and matching the imported records are ignored when set to overwrite In-Reply-To: <bug-32437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32437-70-sFNUWo9J6D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32437 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #41 from Lucas Gass <lucas at bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:31:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:31:44 +0000 Subject: [Koha-bugs] [Bug 31259] Downloading patron card PDF hangs the server In-Reply-To: <bug-31259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31259-70-YqUiCksjPS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31259 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | --- Comment #21 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:35:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:35:53 +0000 Subject: [Koha-bugs] [Bug 32280] Export method ImportBreedingAuth from C4::Breeding In-Reply-To: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32280-70-lShoQ3j7nd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:37:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:37:20 +0000 Subject: [Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page In-Reply-To: <bug-33322-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33322-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33322-70-8s20VhZz1d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:39:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:39:14 +0000 Subject: [Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports of C4::AuthoritiesMarc In-Reply-To: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32279-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32279-70-vkiqYZGQUK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:40:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:40:37 +0000 Subject: [Koha-bugs] [Bug 33601] Use template wrapper for breadcrumbs: Tools, part 8 In-Reply-To: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33601-70-lc2GfuS7hN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:40:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:40:39 +0000 Subject: [Koha-bugs] [Bug 33601] Use template wrapper for breadcrumbs: Tools, part 8 In-Reply-To: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33601-70-R46Bz217Lm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150168&action=edit Bug 33601: Use template wrapper for breadcrumbs: Tools, part 8 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Tools home page - Log viewer - Search result - Uploads - Upload results - Cataloging -> - Upload local cover image - Upload result - Test uploading an biblio-level image from the bibliographic detail page - Test uploading an item-level image from the bibliograhpic detail page's holdings table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:44:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:44:20 +0000 Subject: [Koha-bugs] [Bug 32447] In items table barcode column can not be filtered In-Reply-To: <bug-32447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32447-70-o3GbnWMTBk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32447 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com --- Comment #19 from Lucas Gass <lucas at bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, if needed please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:46:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:46:23 +0000 Subject: [Koha-bugs] [Bug 33381] Active link in the menu is not always correctly styled In-Reply-To: <bug-33381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33381-70-JIJRiQSvER@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:46:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:46:23 +0000 Subject: [Koha-bugs] [Bug 33391] Currently active menu item on navmenulist should not change style on hover In-Reply-To: <bug-33391-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33391-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33391-70-ajuIwyxGlM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33391 Bug 33391 depends on bug 33381, which changed state. Bug 33381 Summary: Active link in the menu is not always correctly styled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33381 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:48:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:48:21 +0000 Subject: [Koha-bugs] [Bug 33285] It should be possible to specify the separator used in runreport.pl In-Reply-To: <bug-33285-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33285-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33285-70-d0g7TO5BdF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33285 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.12 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:48:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:48:41 +0000 Subject: [Koha-bugs] [Bug 33148] Use template wrapper for breadcrumbs: Cataloging In-Reply-To: <bug-33148-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33148-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33148-70-Qfswk0Goa5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33148 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:48:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:48:59 +0000 Subject: [Koha-bugs] [Bug 33149] Use template wrapper for breadcrumbs: Circulation part 1 In-Reply-To: <bug-33149-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33149-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33149-70-lGC2YU0tgg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33149 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:50:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:50:16 +0000 Subject: [Koha-bugs] [Bug 33422] ERM - Search header should change to match the section you are in In-Reply-To: <bug-33422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33422-70-JKSHDLmcH7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33422 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:54:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:54:47 +0000 Subject: [Koha-bugs] [Bug 33564] Use template wrapper for breadcrumbs: Serials part 3 In-Reply-To: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33564-70-LFcZODTMjt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33564 Biblibre Sandboxes <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149910|0 |1 is obsolete| | --- Comment #2 from Biblibre Sandboxes <sandboxes at biblibre.com> --- Created attachment 150169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150169&action=edit Bug 33564: Use template wrapper for breadcrumbs: Serials part 3 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Manage frequencies - New frequency - Edit frequency - Manage numbering patterns - New numbering pattern - Edit numbering pattern - Search subscriptions -> View subscription details - If necessary, edit the subscription to enable "Manual history" - Under the "Planning" tab of the detail page, click "Edit history" - If necessary, edit the subscription and select a notice under "Patron notification." - Under the "Information" tab of the subscription detail page, click "subscribers" Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 19:55:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 17:55:06 +0000 Subject: [Koha-bugs] [Bug 33564] Use template wrapper for breadcrumbs: Serials part 3 In-Reply-To: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33564-70-0v5HC67SYo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33564 Andrew Auld <andrew.auld at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrew.auld at ptfs-europe.com --- Comment #3 from Andrew Auld <andrew.auld at ptfs-europe.com> --- Great! Thanks Owen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 20:13:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 18:13:44 +0000 Subject: [Koha-bugs] [Bug 31256] Circ rules batch modification In-Reply-To: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31256-70-UiKpONHHdd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256 --- Comment #12 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Caroline Cyr La Rose from comment #11) > > Is it possible we're not talking about the same plugin? I'm talking about > the one called Rule Hard Due Date. (We have another one called Change Due > Date that affects checkouts that we had created before the tool was added to > Koha during the pandemic and that we still keep it around because the one in > Koha is missing some functionality that we had.) I don't want to hijack this > bug report to discuss the plugin, but I can confirm it can only affect > specific branches if you specify the branch in the form (you can specify > library, itemtype and/or patron category and it will only affect the rules > that meet those criteria). And it does not affect current checkouts. > Our school libraries have been using this for many years, and as far as I > know it meets their need. Feel free to email me or the mailing list to > further discuss the plugin or concerns about it. :) This is the only one I see when I search in the plugin tools: koha-plugin-rolling-hard-due-dates Koha tool plugin to batch modify hard due date rules and hard due dates on existing checkouts This doesn't work for us. If there is another plugin, it is not available in the library. It may be that I have to find it in github or whatever and upload it manually? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 20:16:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 18:16:56 +0000 Subject: [Koha-bugs] [Bug 33514] SearchWithIS[B|S]NVariations breaks ISBN search in item search In-Reply-To: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33514-70-LIl1XK3Y1a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33514 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 20:29:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 18:29:37 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-F8JVAbv9aQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 20:29:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 18:29:39 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-Z3tFZC941b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150170&action=edit Bug 33599: Use template wrapper for breadcrumbs: Various This patch updates various templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - ILL requests - New ill request - Manage ill request - Bibliographic record -> - Place hold - Place multiple holds - Tools -> - Comments awaiting moderation - Approved comments - Suggestions - New suggestion - View suggestion - Edit suggestion - Lists - Public Lists - Private lists - New list - Edit list - Transfer list - View list contents -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 20:30:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 18:30:56 +0000 Subject: [Koha-bugs] [Bug 33418] Allow setting overlay_framework for connexion imports In-Reply-To: <bug-33418-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33418-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33418-70-TMG5UZMgBP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33418 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- TO DO: cronjobs/import_webservice_batch.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 20:36:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 18:36:58 +0000 Subject: [Koha-bugs] [Bug 30910] Allow local definition of temporary shelving locations In-Reply-To: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30910-70-3tYi5TjxKI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30910 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> --- Andrew, could you help me by providing a scenario for this. I'm trying to wrap my head around this one, and I'm just having a little trouble connecting the dots. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 20:46:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 18:46:36 +0000 Subject: [Koha-bugs] [Bug 30910] Allow local definition of temporary shelving locations In-Reply-To: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30910-70-QQcMrkGztA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30910 --- Comment #3 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- (In reply to Christopher Brannon from comment #2) > Andrew, could you help me by providing a scenario for this. I'm trying to > wrap my head around this one, and I'm just having a little trouble > connecting the dots. We have an item that normally lives in the shelving location GEN (for "General Stacks"). We put the item into a display. We want the shelving location in the catalog to reflect that the item isn't in its normal place, but we don't want to worry about getting that item back into the display if it gets checked out and we don't want to edit it again. If we set: items.location = DISPLAY items.permanent_location = GEN With UpdateItemLocationOnCheckin syspref containing _ALL_: _PERM_ Then the item will show DISPLAY in the catalog but return to GEN when it gets checked in. But right now it takes a fairly complicated setup to edit items.location without koha also edited items.permanent_location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 20:48:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 18:48:58 +0000 Subject: [Koha-bugs] [Bug 23422] CART location feature In-Reply-To: <bug-23422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23422-70-03sUiuh7Fb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23422 --- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> --- In thinking this over more, I think it would be great if the item record had one or two shelving statuses available, along with time stamps, and a preference that could manage them. For example, if we had at least one temp shelving field with associated timestamp, we could use this for the cart feature (which I think should at least be renamed bookcart), and we could tell how long it has been since it was triggered. Then we have a preference that allows us to look at this field and watch for certain values, and then decide how long that value sticks around, in either hours or days. So, maybe the entry looks like: bookcart|1d or bookcard|12h But this would only work with 1 value. Sometimes we might want to have more than one value. Maybe we want the item to be on a display too. If we had another field with timestamp, we could have it setup for a temp display for a period of time: display1|31d Maybe we don't need to touch cart at all, and just have the other for displays? It WOULD be helpful if whether it was a cart location or display location, that it would show next to the permanent location rather than replacing it, as the cart location currently does. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 20:59:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 18:59:08 +0000 Subject: [Koha-bugs] [Bug 23422] CART location feature In-Reply-To: <bug-23422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23422-70-3zjkzuJmIG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23422 --- Comment #4 from Christopher Brannon <cbrannon at cdalibrary.org> --- Also, maybe we don't want certain locations to be put back on display when returned, and others we do. Maybe if we don't want an item to go back on the display when checked out, instead of a time period, we put something else: display1||x If the item is checked back in and the timestamp is not older than the time period in the setting, or if the time period is x, the location and timestamp are cleared, and it acts as normal. But if it has a time period that hasn't lapsed, when the item is checked in, there is an alert or flag on the item to let the staff know it goes back to display. Then maybe a predefined term, like bookcart, doesn't need to remind or flag items on checkin. Or maybe we can use another indicator to not remind/flag on checkin. That way we have options on everything? bookcart|1d|n I'm just shooting out ideas here. If there would be a better way to implement this and still provide the same abilities, I'd be open to suggestions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 20:59:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 18:59:20 +0000 Subject: [Koha-bugs] [Bug 23422] CART location feature In-Reply-To: <bug-23422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23422-70-BqJa6o40W5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23422 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30910 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 20:59:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 18:59:20 +0000 Subject: [Koha-bugs] [Bug 30910] Allow local definition of temporary shelving locations In-Reply-To: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30910-70-Kr41QBoeT9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30910 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23422 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 20:59:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 18:59:58 +0000 Subject: [Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page In-Reply-To: <bug-33322-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33322-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33322-70-lIVdHRRUe9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 --- Comment #10 from Owen Leonard <oleonard at myacpl.org> --- The bug is a result of the new staff interface so 22.05.x shouldn't need it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 21:04:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 19:04:59 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-nhliXZ4EtU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 21:05:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 19:05:01 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-IiFmPrPgxj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149867|0 |1 is obsolete| | --- Comment #9 from David Nind <david at davidnind.com> --- Created attachment 150171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150171&action=edit Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Most circulated items - Report results - Items with no checkouts - Report results - Catalog statistics wizard - Report results - View dictionary - New definition (steps 1-5) - Saved reports - View report - New report - Edit report - Guided reports - Build a report - Steps 1 through 6 Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 21:07:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 19:07:32 +0000 Subject: [Koha-bugs] [Bug 33596] Merge result page is missing page-section In-Reply-To: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33596-70-RcjwAi3Mvc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33596 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 21:09:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 19:09:08 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-1Zcm54xB2c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #10 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. To turn off the strict database mode: - Edit /etc/koha/sites/kohadev/koha-conf.xml - Change strict_sql_modes from 1 to 0 (is right near the end of the file): <strict_sql_modes>0</strict_sql_modes> - flush_memcached and restart_all -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 21:18:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 19:18:56 +0000 Subject: [Koha-bugs] [Bug 33596] Merge result page is missing page-section In-Reply-To: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33596-70-xiNMUrT6xk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33596 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 21:18:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 19:18:58 +0000 Subject: [Koha-bugs] [Bug 33596] Merge result page is missing page-section In-Reply-To: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33596-70-RntgaKzuAk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33596 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150172&action=edit Bug 33596: Merge result page is missing page-section This patch adds a "page-section" container around the contents of the page seen when you complete the process of merging catalog records. The patch also adds the "merge was successful" message into the standard message dialog. Perform a catalog search which will return more than one record. - Select two records in your search results and click "Edit" -> "Merge records." - Complete the process of merging your selected records. - On the last page you should see a "merge was successful" message styled as the standard information box. - The "Report" section should be shown inside a "page-section" div. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 21:39:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 19:39:56 +0000 Subject: [Koha-bugs] [Bug 33601] Use template wrapper for breadcrumbs: Tools, part 8 In-Reply-To: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33601-70-VSndxK0KWs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 21:39:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 19:39:58 +0000 Subject: [Koha-bugs] [Bug 33601] Use template wrapper for breadcrumbs: Tools, part 8 In-Reply-To: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33601-70-VhYL02VWy8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150168|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 150173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150173&action=edit Bug 33601: Use template wrapper for breadcrumbs: Tools, part 8 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Tools home page - Log viewer - Search result - Uploads - Upload results - Cataloging -> - Upload local cover image - Upload result - Test uploading an biblio-level image from the bibliographic detail page - Test uploading an item-level image from the bibliograhpic detail page's holdings table Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 21:46:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 19:46:11 +0000 Subject: [Koha-bugs] [Bug 33601] Use template wrapper for breadcrumbs: Tools, part 8 In-Reply-To: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33601-70-ivCz4oP3q5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33601 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. To test uploading local cover images, enable the LocalCoverImages system preference. 2. For the Upload local cover image: after the first page (when you drag and drop the image), the menu item in the sidebar is not highlighted. It didn't before the patch was applied, so not sure whether it should now. 3. It's nice to have breadcrumbs back for Tools > Additional tools > Uploads! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 22:13:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 20:13:40 +0000 Subject: [Koha-bugs] [Bug 33322] "Please select at least one suggestion" when doing a catalog search from suggestions page In-Reply-To: <bug-33322-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33322-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33322-70-UJZJ2wn2MV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Owen Leonard from comment #10) > The bug is a result of the new staff interface so 22.05.x shouldn't need it Thanks Owen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 22:27:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 20:27:47 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17170-70-jjHaH1C5HA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/667 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #151 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I added some stuff to the manual. Hopefully I didn't get it completely wrong. I admit I didn't quite understand the use case for the URL thing, so I didn't add that in. But if someone has a specific example, feel free to add it in, or tell me and I'll add it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 22:27:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 20:27:48 +0000 Subject: [Koha-bugs] [Bug 33011] Capitalization: Show in Staff interface? In-Reply-To: <bug-33011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33011-70-p3kEiMPxLA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33011 Bug 33011 depends on bug 17170, which changed state. Bug 17170 Summary: Add the ability to create 'saved searches' for use as filters when searching the catalog https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 22:31:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 20:31:59 +0000 Subject: [Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login In-Reply-To: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30588-70-cDIYldnttW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/667 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 22:38:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 20:38:37 +0000 Subject: [Koha-bugs] [Bug 31577] Use patron category multi-select for OpacHiddenItemsExceptions system preference In-Reply-To: <bug-31577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31577-70-RzGFvPwgpn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31577 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/667 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 22:54:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 20:54:59 +0000 Subject: [Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found In-Reply-To: <bug-23012-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23012-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23012-70-9SLxYr4dhA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/667 Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 23:11:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 21:11:23 +0000 Subject: [Koha-bugs] [Bug 18686] TalkingTech_itiva_outbound.pl fails with Illegal mix of collations In-Reply-To: <bug-18686-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18686-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18686-70-cGdMZnCs9z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18686 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED CC| |wizzyrea at gmail.com --- Comment #3 from Liz Rea <wizzyrea at gmail.com> --- No longer seeing these messages, safe to close! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 24 23:41:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 21:41:10 +0000 Subject: [Koha-bugs] [Bug 33602] New: Add mark lost option to cancel transfer on transferstoreceive.pl Message-ID: <bug-33602-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33602 Bug ID: 33602 Summary: Add mark lost option to cancel transfer on transferstoreceive.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be handy if items could be marked as a lost status from the transfer page. Having a "cancel and mark lost" button/option would be helpful since that is one reason people might be cancelling a transfer. Similarly to the Holds Queue cancel button you could preset a particular lost value. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 00:40:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 22:40:52 +0000 Subject: [Koha-bugs] [Bug 33010] CheckinSlip doesn't return checkins if checkout branch and checkin branch differ In-Reply-To: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33010-70-rYuPBRYJ1J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 00:40:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 22:40:55 +0000 Subject: [Koha-bugs] [Bug 33010] CheckinSlip doesn't return checkins if checkout branch and checkin branch differ In-Reply-To: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33010-70-sy18t1UGFC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146943|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150174&action=edit Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl If one tries to print checkin slip for checkins that have been checked out from different branch, list of checkins is empty. One has to change their branch as checkout library to be able to print checkins. This happens because we filter (or rather search) patrons old checkouts with logged in patrons branch. This patch removes this search so that checkout are filtered using just filter_by_todays_checkins. To test: 1. Checkout items for patron from branch A. 2. Switch to branch B and checkin items. 3. Print checkin slip. => Checkins list is empty. 4. Switch back to branch A. 5. Print checkin slip again. => Checkins are printed. 6. Apply this patch, restart services if needed. 7. Switch back to branch B and print checkin slip. => Checkins should now print. Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 00:43:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 22:43:07 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-g7TM07SJhL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- I have Failed QA because of a change for suggestions: 1. After the patch is applied, when you view a suggestion the breadcrumb is Home > Acqusitions > Show suggestion #X. Before the patch was applied, it was Home > Acqusitions > Suggestions > Show suggestion #X. In addition, I noted these things - the patch reflects the behaviour before it was applied: 1. ILL requests: - For most of the options for a request the breadcrumb is Home > ILL request (Edit request, Confirm request, Place request with partner, Delete request, Edit item metadata) - Should this be Home > ILL requests > Request XXXX > Action? 2. Tools > Comments: - For the tab 'Comments awaiting moderation', the 'Comments' sidebar menu option is highlighted. - For the tab 'Approved comments' it isn't. 3. Suggestions: - Sidebar menu option 'Suggestions' not highlighted sometimes when you change between the suggestion status tabs (I think this is when you select a suggestion(s) and then mark select as and choose an option where there is not a tab). Testing notes (using KTD): 1. Setting up the ILL FreeForm backend: - mkdir Koha/Illbackends - change to Illbackends directory - git clone https://github.com/PTFS-Europe/koha-ill-freeform.git - rename directory: mv koha-ill-freeform to FreeForm - edit /etc/koha/sites/kohadev/koha-conf.xml - in the <interlibrary_loans> section change: . backend_directory to: <backend_directory>/kohadevbox/koha/Koha/Illbackends</backend_directory> . partner_code to: <partner_code>IL</partner_code> - flush_memcached and restart_all - enable ILLModule system preference - check that there are no ILL warnings under About > System information - check that you can create a request: ILL requests > New ILL request -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 00:47:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 22:47:37 +0000 Subject: [Koha-bugs] [Bug 33596] Merge result page is missing page-section In-Reply-To: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33596-70-92Bv7lt970@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33596 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 00:47:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 22:47:39 +0000 Subject: [Koha-bugs] [Bug 33596] Merge result page is missing page-section In-Reply-To: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33596-70-Ey0TzxSy6n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33596 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150172|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150175&action=edit Bug 33596: Merge result page is missing page-section This patch adds a "page-section" container around the contents of the page seen when you complete the process of merging catalog records. The patch also adds the "merge was successful" message into the standard message dialog. Perform a catalog search which will return more than one record. - Select two records in your search results and click "Edit" -> "Merge records." - Complete the process of merging your selected records. - On the last page you should see a "merge was successful" message styled as the standard information box. - The "Report" section should be shown inside a "page-section" div. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 00:53:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 22:53:00 +0000 Subject: [Koha-bugs] [Bug 33588] Inventory item list is missing page-section class In-Reply-To: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33588-70-HKLsGQeQVc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33588 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 00:53:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 22:53:02 +0000 Subject: [Koha-bugs] [Bug 33588] Inventory item list is missing page-section class In-Reply-To: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33588-70-PD9kPBMbPF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33588 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150123|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150176&action=edit Bug 33588: Add page-section to inventory tool items list The table with items created by the inventory tool was missing the page-section class and therefore had no white background. To test: * Go to cataloguing > inventory * When you don't have a lot of data: just submit the form * Look at the result list, confirm missing white background * Apply patch * Confirm the background is now correct Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 00:53:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 22:53:12 +0000 Subject: [Koha-bugs] [Bug 33596] Merge result page is missing page-section In-Reply-To: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33596-70-GojGXAAxnY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33596 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150175|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 150177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150177&action=edit Bug 33596: Merge result page is missing page-section This patch adds a "page-section" container around the contents of the page seen when you complete the process of merging catalog records. The patch also adds the "merge was successful" message into the standard message dialog. Perform a catalog search which will return more than one record. - Select two records in your search results and click "Edit" -> "Merge records." - Complete the process of merging your selected records. - On the last page you should see a "merge was successful" message styled as the standard information box. - The "Report" section should be shown inside a "page-section" div. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 01:01:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 23:01:25 +0000 Subject: [Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences In-Reply-To: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33390-70-XjIBgJCHhQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150178&action=edit Bug 33390: (follow-up) move ItemsDeniedRenewal links to less confusing place -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 01:02:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 23:02:01 +0000 Subject: [Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences In-Reply-To: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33390-70-7Sj5NRD7zK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390 --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6) > Looking at this and as I won't finish right now, leaving a first note: > > ItemsDeniedRenewal: I feel the placement of the links right after the > examples you can copy and paste is not ideal. Maybe we could put them into > an explanatory sentence below? I attached a follow-up to move those links. Let me know if you think that is better! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 01:54:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 23:54:46 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-l1GaYPLEff@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 01:54:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 23:54:48 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-3zmmG0eeEw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150179&action=edit Bug 33512: (follow-up) Check item count before adding add/edit button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 01:55:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Apr 2023 23:55:41 +0000 Subject: [Koha-bugs] [Bug 33512] Labels/buttons are confusing on serials-edit page In-Reply-To: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33512-70-N7U5ftoSSn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- > I couldn't fix the second issue - so we will still need a follow up or maybe > change to "Add/edit item" Katrin, let me know what you think of my follow-up for the 2nd issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 08:04:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 06:04:26 +0000 Subject: [Koha-bugs] [Bug 33603] New: misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field Message-ID: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 Bug ID: 33603 Summary: misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Since bug 29486, misc/maintenance/search_for_data_inconsistencies.pl search for biblio.biblionumber in MARC record with $record->subfield(). This fails when field is a control field (< 10). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 08:04:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 06:04:32 +0000 Subject: [Koha-bugs] [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field In-Reply-To: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33603-70-dbdWZotUEy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 08:04:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 06:04:32 +0000 Subject: [Koha-bugs] [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio In-Reply-To: <bug-29486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29486-70-B2UL5ae0E2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33603 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 08:04:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 06:04:44 +0000 Subject: [Koha-bugs] [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field In-Reply-To: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33603-70-aBdBdIfK6w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 08:10:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 06:10:57 +0000 Subject: [Koha-bugs] [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field In-Reply-To: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33603-70-BGukP4R866@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 Fridolin Somers <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 08:10:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 06:10:59 +0000 Subject: [Koha-bugs] [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field In-Reply-To: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33603-70-i4haIPSTpD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 --- Comment #1 from Fridolin Somers <fridolin.somers at biblibre.com> --- Created attachment 150180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150180&action=edit Bug 33603: Fix misc/maintenance/search_for_data_inconsistencies.pl when biblio.biblionumber on control field Since bug 29486, misc/maintenance/search_for_data_inconsistencies.pl search for biblio.biblionumber in MARC record with $record->subfield(). This fails when field is a control field (< 10). Idem for biblioitems.biblioitemnumber Test plan : 1.0) On a UNIMARC database (biblio.biblionumber is on 001) 1.1) Run misc/maintenance/search_for_data_inconsistencies.pl => Without patch you get error : Control fields (generally, just tags below 010) do not have subfields, use data() => With patch no error 2.0) On a MARC21 database (biblio.biblionumber is on 999c) 2.1) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you see no error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 09:10:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 07:10:37 +0000 Subject: [Koha-bugs] [Bug 33604] New: Show both article_title and title in ILL module and OPAC Message-ID: <bug-33604-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33604 Bug ID: 33604 Summary: Show both article_title and title in ILL module and OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de CC: pedro.amorim at ptfs-europe.com The ILL module will sometimes show the article title as title when one exists. This has led to quite some confusion. We should always show both, the article title and the title of the item the article is from (source). One place this is missing is the detail pages of ILL requests in OPAC and staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 09:10:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 07:10:38 +0000 Subject: [Koha-bugs] [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field In-Reply-To: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33603-70-6zaWkGIJHA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 09:10:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 07:10:40 +0000 Subject: [Koha-bugs] [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field In-Reply-To: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33603-70-m9ZCfLPbWq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150180|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 150181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150181&action=edit Bug 33603: Fix misc/maintenance/search_for_data_inconsistencies.pl when biblio.biblionumber on control field Since bug 29486, misc/maintenance/search_for_data_inconsistencies.pl search for biblio.biblionumber in MARC record with $record->subfield(). This fails when field is a control field (< 10). Idem for biblioitems.biblioitemnumber Test plan : 1.0) On a UNIMARC database (biblio.biblionumber is on 001) 1.1) Run misc/maintenance/search_for_data_inconsistencies.pl => Without patch you get error : Control fields (generally, just tags below 010) do not have subfields, use data() => With patch no error 2.0) On a MARC21 database (biblio.biblionumber is on 999c) 2.1) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you see no error Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 09:53:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 07:53:47 +0000 Subject: [Koha-bugs] [Bug 32995] Koha agent string not sent for OverDrive fulfillment requests In-Reply-To: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32995-70-ClWV3CxNQg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32995 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 09:53:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 07:53:50 +0000 Subject: [Koha-bugs] [Bug 32995] Koha agent string not sent for OverDrive fulfillment requests In-Reply-To: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32995-70-m0UJE311Qo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32995 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146841|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus at libriotech.no> --- Created attachment 150182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150182&action=edit Bug 32995: Pass user agent string for OverDrive fulfillment This patch simply adds the string Koha/VERSION to the fulfillment request TO test: 1 - Have OverDrive credentials for testing 2 - Enable all the overdrive options in system preferences 3 - Sign in to opac with an overdrive user and verify you can checkout and download titles 4 - Sign off Signed-off-by: Magnus Enger <magnus at libriotech.no> Not tested with OverDrive, but change looks harmless enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 10:45:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 08:45:27 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28130-70-sa9SwLkA7A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 10:56:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 08:56:07 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-yAVoUg2oe7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 12:15:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 10:15:26 +0000 Subject: [Koha-bugs] [Bug 28315] PopupMARCFieldDoc is defined twice in addbiblio.tt In-Reply-To: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28315-70-9Jfv3xGath@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28315 Philip Orr <philip.orr at lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr at lmscloud.de Assignee|koha-bugs at lists.koha-commun |philip.orr at lmscloud.de |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 12:48:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 10:48:19 +0000 Subject: [Koha-bugs] [Bug 28315] PopupMARCFieldDoc is defined twice in addbiblio.tt In-Reply-To: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28315-70-JQBkqkOmll@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28315 Philip Orr <philip.orr at lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 12:48:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 10:48:21 +0000 Subject: [Koha-bugs] [Bug 28315] PopupMARCFieldDoc is defined twice in addbiblio.tt In-Reply-To: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28315-70-xDMInFcasU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28315 --- Comment #1 from Philip Orr <philip.orr at lmscloud.de> --- Created attachment 150183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150183&action=edit Bug #28315: Remove duplicate function definition This patch removes the unnecessary second definition of the JS function PopupMARCFieldDoc from addbiblio.tt. To test: 1. Apply the patch 2. Check that addbiblio.tt contains only one function definition for PopupMARCFieldDoc 3. Navigate to "Cataloging" -> "Add MARC record" 4. Check that after clicking on the question mark symbol next to any MARC field, the loc description of that MARC field is opened in a new tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:00:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:00:57 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-cNhlUPurrr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:00:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:00:59 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-h7SQgNEVYp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149524|0 |1 is obsolete| | --- Comment #5 from Magnus Enger <magnus at libriotech.no> --- Created attachment 150184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150184&action=edit Bug 33504: Update patron_to_html to deal with null In the patron_to_html function we were dealing explicitly with the case where patron may be passed undefined, but forgetting that it may be returned as 'null' from the api too. Changing from `( patron === undefined )` to `( patron == null )` is the recommended approach for detecting 'undefined or null' in javascript. Signed-off-by: Magnus Enger <magnus at libriotech.no> Works as advertised. Martin's test plan from Bugzilla: To test. 1) Use ILS-DI to renew an checkout 2) View the circulation history for the item 3) Click the 'View' button next to the count of renewals 4) Note that the modal just stalls at 'Retrieving renewals' 5) Apply the patch 6) Now the 'retrieving renewals' message should list the renewals instead. Note that step 2 should be something like "Go to the "Circulation history" of the patron. https://bugs.koha-community.org/show_bug.cgi?id=22504 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:05:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:05:17 +0000 Subject: [Koha-bugs] [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 In-Reply-To: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33566-70-vsaMWk3vqc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:05:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:05:19 +0000 Subject: [Koha-bugs] [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 In-Reply-To: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33566-70-FXdRu7QHmf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149940|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150185&action=edit Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Batch extend due dates - Access files (it is not necessary to have file access configured to test, there are no variations to the breadcrumbs) - News, HTML customizations, and Pages: For each category check each variation: - List of entries - New entry - Edit entry - Cataloging -> - Batch record deletion - Item modifications by age - Edit rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:13:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:13:16 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-hS8EEzet1j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:13:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:13:18 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-3SsqUckrfN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150170|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150186&action=edit Bug 33599: Use template wrapper for breadcrumbs: Various This patch updates various templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - ILL requests - New ill request - Manage ill request - Bibliographic record -> - Place hold - Place multiple holds - Tools -> - Comments awaiting moderation - Approved comments - Suggestions - New suggestion - View suggestion - Edit suggestion - Lists - Public Lists - Private lists - New list - Edit list - Transfer list - View list contents -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:25:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:25:55 +0000 Subject: [Koha-bugs] [Bug 33412] Problem importing records (bug 15869 follow-up) wrong use of assignment In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-tysn0r5fMl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:27:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:27:29 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-RmB0pfcFkK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149970|0 |1 is obsolete| | --- Comment #5 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 150187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150187&action=edit Bug 33575: Add dataTable to hold table on /reserve/request.tt To test: 1. Have a record with several holds on it. 2. Go to the holds page for that record ( /cgi-bin/koha/reserve/request.pl?biblionumber=144 ) 3. Cannot sort by columns 4. Apply patch, restart_all 5. Now the table should be a dataTable that will allow you sort. 6. Try hiding columns by clicking on the 'Columns' icon above the table, make sure columns are correctly being hidden. 7. Try to hide columns by going to Adminstration > Table settings ( Circulation > Holds > patron_holds_table ), make sure columns are correctly being hidden. 8. Now login with a user who has the 'place_holds' permission but does NOT have the 'modify_holds_priority' permssion. 9. The table will not have the change priority columns. Make sure all columns can still be hidden/shown correctly for that use. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:27:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:27:31 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-TYoNOT7trj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150041|0 |1 is obsolete| | --- Comment #6 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 150188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150188&action=edit Bug 33575: (follow-up) don't allow priority and pickup location to be hidden Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:29:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:29:49 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl In-Reply-To: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33575-70-Df3wp2FATh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- Brilliant, Lucas - works perfectly! This is a really useful patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:55:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:55:06 +0000 Subject: [Koha-bugs] [Bug 33177] Use include file for subfield constraints in both authority and bibliographic frameworks In-Reply-To: <bug-33177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33177-70-NQJSv2z5kY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 150189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150189&action=edit Screenshots - before and after + issues I've had a go at testing this change - which I think is a great idea! Things work as expected, however I have noted some layout and consistency things - which is why I have Failed QA. The document attached includes screenshots for the potential issues identified. Subfield editor - alignment of tabs ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ If you are on subfield 0: - the rest of the subfield tags align on the second row under the second subfield tag - this works fine for the second row of subfield tags - however, the third row is aligned under the first tab If you are on another subfield tag, the second row of tabs is aligned after that one, and then the third row is aligned under the first tab. See screenshot document - section 3. Subfield editor - spacing and layout directly under the tabs ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Bibliographic subfield: no space - just white background (I'm not sure whether there should be a space after the subfield tabs). Authority subfield: from basic constraints downwards, everything is indented - that is, not aligned with the first subfield tab. See screenshot documents - sections 1 and 2 (after screenshots). Subfield editor - spacing and layout for the sections ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Bibliographic subfield: no spacing between sections (Basic constraints, Advanced constraints, Other options (Choose one)). Authority subfield: spacing between sections - that is, each section has its own white background. See screenshot documents - sections 1 and 2 (after screenshots). Link vs Koha link ~~~~~~~~~~~~~~~~~ I don't know enough about these fields and find it confusing: - Bibliographic subfield: . before patch, has Link field (An index name, e.g. title or LocalNumber) and a dropdown list Koha link with no selectable options . after patch, just has Link - Authorities: . before patch has Koha field and a populated dropdown list . after patch has Koha link and a populated dropdown list See screenshot documents - sections 1 and 2 (before and after screenshots). Other things noticed ~~~~~~~~~~~~~~~~~~~~ These may be out of scope for this bug, but addressing these would improve consistency. Constraint column when listing subfields ---------------------------------------- The table becomes very wide when there are a lot of constraints, for an example see 100$a for BKS bibliographic framework (note that this was the case before the patch was applied). See screenshot documents - section 4. Action menu for subfields ------------------------- Maybe these should be worded the same? - Bibliographic: . Edit tag . View subfields . Edit subfields . Delete - Authority: . Subfields . Edit . Delete See screenshot document - section 5. Label names when modifying a tag -------------------------------- Maybe these should be the same as used for the subfield editor (see screenshot document - section 1 and 2). Bibliographic: - Label for lib: should this be "Text for librarian"? - Label for opac: should this be "Text for OPAC"? - Authorized value: hint text is straight after the dropdown list, maybe it should be under the input field - like it is for authorities. Authority: - Text for librarians: should this be "Text for librarian"? - Text for opac: should this be "Text for OPAC"? See screenshot document - section 6. List of tags ------------ Table listing - tag column: - For authorities: tag is bold in each row - For bibliographic: tag is not bold in each row (No screenshot.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:55:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:55:27 +0000 Subject: [Koha-bugs] [Bug 33177] Use include file for subfield constraints in both authority and bibliographic frameworks In-Reply-To: <bug-33177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33177-70-jabPCSpBeQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33177 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:58:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:58:49 +0000 Subject: [Koha-bugs] [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field In-Reply-To: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33603-70-EXdfmeoNev@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 13:58:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 11:58:51 +0000 Subject: [Koha-bugs] [Bug 33603] misc/maintenance/search_for_data_inconsistencies.pl fails if biblio.biblionumber on control field In-Reply-To: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33603-70-pD7J1ZWqvb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33603 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150181|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150190&action=edit Bug 33603: Fix misc/maintenance/search_for_data_inconsistencies.pl when biblio.biblionumber on control field Since bug 29486, misc/maintenance/search_for_data_inconsistencies.pl search for biblio.biblionumber in MARC record with $record->subfield(). This fails when field is a control field (< 10). Idem for biblioitems.biblioitemnumber Test plan : 1.0) On a UNIMARC database (biblio.biblionumber is on 001) 1.1) Run misc/maintenance/search_for_data_inconsistencies.pl => Without patch you get error : Control fields (generally, just tags below 010) do not have subfields, use data() => With patch no error 2.0) On a MARC21 database (biblio.biblionumber is on 999c) 2.1) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you see no error Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:09:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:09:54 +0000 Subject: [Koha-bugs] [Bug 33412] Problem importing records (bug 15869 follow-up) wrong use of assignment In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-UZRIZ6g1I0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150191&action=edit Bug 33412: Fix comparison when checking for overlay framework TO test: 1 - Cataloging -> Export catalog data 2 - Export a record fom your catalog 3 - Cataloging -> Stage record for import 4 - Import the record, use Record matchign rule: KohaBiblio (999c) 5 - Stage, view batch 6 - Record should match the one that was exported 7 - When replacing record use this framework, choose a different value than current framework of record 8 - Import this batch 9 - View and edit record - note framework did not change 10 - Apply patch 11 - Restart all 12 - Repeat 4-8 13 - View and edit record, confirm framework has changed 14 - Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:10:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:10:07 +0000 Subject: [Koha-bugs] [Bug 33412] Problem importing records (bug 15869 follow-up) wrong use of assignment In-Reply-To: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33412-70-BWBPlY2GpA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33412 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149201|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:14:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:14:16 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-6YO6koUtuF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:14:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:14:19 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-Ye3EwEWeXl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150186|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 150192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150192&action=edit Bug 33599: Use template wrapper for breadcrumbs: Various This patch updates various templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - ILL requests - New ill request - Manage ill request - Bibliographic record -> - Place hold - Place multiple holds - Tools -> - Comments awaiting moderation - Approved comments - Suggestions - New suggestion - View suggestion - Edit suggestion - Lists - Public Lists - Private lists - New list - Edit list - Transfer list - View list contents Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:20:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:20:51 +0000 Subject: [Koha-bugs] [Bug 33605] New: Import framework and overlay framework are not stored for imports Message-ID: <bug-33605-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33605 Bug ID: 33605 Summary: Import framework and overlay framework are not stored for imports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When importing a staged file, one can set the framework for new records, and the framework for overlaying records. However, we don't store these, meaning we can't review what our settings were These options should be moved into the staging form (so they can take advantage of profiles) and be saved in the import batches table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:29:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:29:20 +0000 Subject: [Koha-bugs] [Bug 33156] Batch patron modification tool is missing search bar and other attributes In-Reply-To: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33156-70-3gbyvN6Hby@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:29:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:29:23 +0000 Subject: [Koha-bugs] [Bug 33156] Batch patron modification tool is missing search bar and other attributes In-Reply-To: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33156-70-8MGRYrPUho@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33156 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149074|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150193&action=edit Bug 33156: Fix JS error on batch patron modification The error currently breaks some of the functionality for updating patron attributes linked to AV values. With the bug, the input field will not change to the AV list when selected from the pull down of patron attributes. It was probably bug 29648 that changed the data structure without adapting for the additional data that is pushed to the object for the patron attribute columns. To test: * Create several extended patron attributes * Make sure at least one is linked to an AV * Repeatable and unique patron attributes can't be updated in batch patron modification, so you need some that can be modified. * Go to tools > batch patron modification * Enter one or more cardnumbers to update * Verify the table is missing columns, export and configure * Verify when selecting the AV tied patron attribute, the input remains a text one * Apply patch * Both should work now as expected Note: I believe there are some more errors on this page, but they should better be handled separately. So with this patch we push configuration again for each column to table columns, but the very last column keeps missing from the columns settings. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:37:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:37:30 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-IzFnMGLnZH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|julian.maurice at biblibre.com |jonathan.druart+koha at gmail. | |com Status|In Discussion |ASSIGNED --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I will be on it, I just need more time... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:38:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:38:52 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-7UXoWam3Fs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #121 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- See previous comment, that's not relevant. (In reply to Katrin Fischer from comment #120) > > * What to do when the description of an item type is modified? > > I think, when an itemtype description is modified, this should not change > the translations or remove them. Libraries will take care of it and a typo > fix or modification should not cause any changes. This will need to be confirmed however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:40:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:40:24 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-gGr3e6ldfp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #59 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Pedro Amorim from comment #49) > This wasn't applying. Rebased. It's even worse now. > After bug 33408, the staff user also requires the permission parameters in > order to be able to fetch the ERMModule syspref. Yes, we noticed that with Tomas last week. We need to fix that before anything else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:47:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:47:15 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-AFhwwTkZUB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:47:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:47:17 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-OJEVQThAr1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149672|0 |1 is obsolete| | Attachment #149673|0 |1 is obsolete| | Attachment #149674|0 |1 is obsolete| | Attachment #149675|0 |1 is obsolete| | Attachment #149676|0 |1 is obsolete| | Attachment #150038|0 |1 is obsolete| | Attachment #150039|0 |1 is obsolete| | Attachment #150048|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150194&action=edit Bug 33490: Unit tests This patch adds cypress tests for the filter by expired functionality in the ERM Agreements page. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:47:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:47:20 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-dh5QqFkhx6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #38 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150195&action=edit Bug 33490: Prevent 400 on agreements?by_expired=true We need to update the filter THEN update the current route Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:47:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:47:23 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-4L8yZZR7Ei@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #39 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150196&action=edit Bug 33490: Make url consistent This ensures we populate the max_expiration_date param on the browser url for consistency with selected dates. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:47:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:47:26 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-eTiMKVWrhL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #40 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150197&action=edit Bug 33490: Improve max date handling It fixes: 1. /agreements?by_expired=true do no longer explode 2. Fill date with today's date when we setup the component and when we hit "filter" However there are a couple of things totally wrong: 1. We should not need is_fp_disabled, we could be able to use :disabled="!filters.by_expired" in the template, but it does not work 2. We should not need to deal with filters.max_expiration_date the "old JS way", but should use a Vue computed value instead. I've failed at that I think those 2 problems have the same root, the way we deal with filters in data() is wrong, and we may be loosing the ref at some point. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:47:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:47:29 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-FYlFP3SLkg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #41 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150198&action=edit Bug 33490: Use computed values Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:47:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:47:32 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-oIOco5OriE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #42 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150199&action=edit Bug 33490: Rollback computed Use a watch instead Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:47:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:47:35 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-bSTdVUvRjf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #43 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150200&action=edit Bug 33490: Fix ambiguous query error Doing actual testing with some agreements with expired periods, this was returning a 500 error Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:47:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:47:38 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-vnsmrwDSg8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 --- Comment #44 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150201&action=edit Bug 33490: Add test Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:48:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:48:08 +0000 Subject: [Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error In-Reply-To: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33490-70-8mLEbp244p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #45 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This is good to go now! Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:49:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:49:41 +0000 Subject: [Koha-bugs] [Bug 33606] New: Access to ERM requires parameters => 'manage_sysprefs' Message-ID: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Bug ID: 33606 Summary: Access to ERM requires parameters => 'manage_sysprefs' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com Since bug 33408 we are fetching sysprefs from svc/config/systempreferences, but this script requires parameters => 'manage_sysprefs' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:49:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:49:47 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-M73WWjZBgf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 [Bug 33408] Fetch sysprefs from svc/config/systempreferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:49:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:49:47 +0000 Subject: [Koha-bugs] [Bug 33408] Fetch sysprefs from svc/config/systempreferences In-Reply-To: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33408-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33408-70-R5fnKzvYtc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33408 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33606 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:50:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:50:06 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-wTFamtknLm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 --- Comment #60 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #59) > (In reply to Pedro Amorim from comment #49) > > This wasn't applying. Rebased. It's even worse now. > > After bug 33408, the staff user also requires the permission parameters in > > order to be able to fetch the ERMModule syspref. > > Yes, we noticed that with Tomas last week. We need to fix that before > anything else. Reported on bug 33606. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:51:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:51:01 +0000 Subject: [Koha-bugs] [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 In-Reply-To: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33566-70-uEXJczSzQI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Biblibre Sandboxes <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150185|0 |1 is obsolete| | --- Comment #4 from Biblibre Sandboxes <sandboxes at biblibre.com> --- Created attachment 150202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150202&action=edit Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Batch extend due dates - Access files (it is not necessary to have file access configured to test, there are no variations to the breadcrumbs) - News, HTML customizations, and Pages: For each category check each variation: - List of entries - New entry - Edit entry - Cataloging -> - Batch record deletion - Item modifications by age - Edit rules Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 14:51:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 12:51:18 +0000 Subject: [Koha-bugs] [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 In-Reply-To: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33566-70-VnYlzm6Rkl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 15:14:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 13:14:41 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-aeGBJ6ziH3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|major |blocker Keywords| |rel_23_05_candidate --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This is blocker for 23.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 15:16:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 13:16:48 +0000 Subject: [Koha-bugs] [Bug 33605] Import framework and overlay framework are not stored for imports In-Reply-To: <bug-33605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33605-70-yDWzLhzdXF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33605 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150203&action=edit Bug 33605: WIP TO DO: - make profiles save the info - pass frameowrks to scripts - make import form fetch values from DB for new fields - handle changing values after staging (do along with redoing matching?) - tests? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 15:27:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 13:27:11 +0000 Subject: [Koha-bugs] [Bug 33607] New: Show framework on record details page Message-ID: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Bug ID: 33607 Summary: Show framework on record details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently you can only see the framework for a record by editing the record. It would be useful to make this visible when viewing a record in the staff client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 15:34:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 13:34:14 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-bYpAfo7ujl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33606 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 15:34:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 13:34:14 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-NwZrwE3BgD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32968 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 [Bug 32968] Create granular permissions for ERM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 15:34:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 13:34:34 +0000 Subject: [Koha-bugs] [Bug 32968] Create granular permissions for ERM In-Reply-To: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32968-70-dsbWjGySyw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33606 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 15:34:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 13:34:34 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-GuCM8qrxcp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32968 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968 [Bug 32968] Create granular permissions for ERM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 15:58:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 13:58:16 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-U1VlbbXOjg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 15:58:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 13:58:19 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-dR5ITnPhcu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150204&action=edit Bug 33606: Add a erm/config route to retrieve the ERM config needed for the Vue app This could be extended later in bug 32968 to pass the permission of the logged in user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 15:59:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 13:59:47 +0000 Subject: [Koha-bugs] [Bug 33606] Access to ERM requires parameters => 'manage_sysprefs' In-Reply-To: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33606-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33606-70-A6OyOpbkS8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33606 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:04:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:04:48 +0000 Subject: [Koha-bugs] [Bug 29173] Button "replace authority record via Z39/50/SRU" doesn't pre-fill In-Reply-To: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29173-70-q3AwVgp4Qe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #52 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Please have a look at bug 33445 that is suggesting to revert these patches! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:06:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:06:15 +0000 Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30687-70-OX8hg4Bhe3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #29 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to TomĂĄs Cohen Arazi from comment #26) > Aleisha: do you agree with what's been said and this last version of a > solution for the bug? Aleisha, ping? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:08:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:08:30 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-kMJfg1nfI5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha at gmail. | |com --- Comment #11 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- FAIL forbidden patterns: tab char -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:11:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:11:34 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-aKFKdE22y8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I think we should remove AutoCommit here, see bug 27245. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:13:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:13:25 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-q1ms9iZtPz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:13:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:13:28 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-CrvJ4JACXR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150142|0 |1 is obsolete| | Attachment #150143|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150205&action=edit Bug 32931: Fix translatability issues on 'new agreement' form This fixes the "Yes" and "No" options and "License info" placeholder. To get to the options: 1. Enable the ERMModule system preference 2. Go to E-resource management 3. Click "Agreements" 4. Click "New agreement" --> Field "Is perpetual", options are Yes and No --> At the bottom of the form "License info" with "License info" within the input field 5. Install (complete) language, verify those are not translated 6. Apply patch 7. Update po files 8. Verify strings exist for this file, translate if necessary 9. Re-install language 10. Verify strings are now translated Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:13:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:13:31 +0000 Subject: [Koha-bugs] [Bug 32931] ERM - (is perpetual) Yes / No options untranslatable In-Reply-To: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32931-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32931-70-234UpfAt6w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32931 --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150206&action=edit Bug 32931: Fix translatability issues on 'show agreement' view Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:15:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:15:18 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-8hSaNkAVY8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele at inlibro.com Attachment #131091|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:15:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:15:25 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-ANzyIlEb4C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131092|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:15:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:15:32 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-ezqMYozzXZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131093|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:15:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:15:38 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-Vd0NO4YEeH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150071|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:15:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:15:59 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-zX7HL2DiKY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Depends on| |25936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 [Bug 25936] Notify users if their password has changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:15:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:15:59 +0000 Subject: [Koha-bugs] [Bug 25936] Notify users if their password has changed In-Reply-To: <bug-25936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25936-70-dYoNo4IKCb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25936 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32917 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 [Bug 32917] Change patron.firstname and patron.surname in password change sample notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:16:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:16:34 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-QL4qVJ5mlA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:16:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:16:37 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-Edq3btt3md@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150111|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150207&action=edit Bug 32917: Fix sample notice for CHANGE_PASSWORD We've identified 3 issues: * Name of patron is not showing up in subject line * Name of patron is now showing in notice text * Notice is set to be HTML, but has no line breaks and uses no HTML tags In the database update, these issues don't occur: $dbh->do( q{ INSERT IGNORE INTO letter (module, code, name, title, content, message_transport_type) VALUES ('members', 'PASSWORD_CHANGE', 'Notification of password change', 'Library account password change notification', "Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nWe want to notify you that your password has been changed. If you did not change it yourself (or requested that change), please contact library staff.\r\n\r\nYour library.", 'email'); }); So this patch will make them match up: * Remove HTML flag * Update patron. to borrower. in message text * Remove patron name from subject (it won't work even with the correct variables) To test: * Add an email address to your favourite sample user * Make sure NotifyPasswordChange is set to "Notify" * Update the sample user's password using the "change password" feature * Verify a notice is shown in the notices tabs Note: you won't see the line break issue there because of bug 30287 * Apply patch * Recreate your database/run web installer so sample notices are loaded * Repeat the test, it should generate a nice lookig notice now Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:18:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:18:06 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-B9NUWlbP1P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #99 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 150208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150208&action=edit Bug 12532: Send email to guarantee and guarantor This patch allows guarantors to receive emails sended to their guarentees. This patch is a rebase of the previous patches. I took all the content of previous commit and put it in one commit. TO TEST: Before applying: 1) Search, or create, a patron with guarantor. 2) Enable checkout emails for both guarantors and guarantees. 3) Checkout an item. An email should be sent only to the guarantee. 4) Apply the patch. 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' 7) Run misc/cronjobs/process_message_queue.pl 8) Notice that the email should be sended to both the guarantee AND the guarantor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:18:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:18:38 +0000 Subject: [Koha-bugs] [Bug 33586] Library and category are switched in table configuration for patron search results table settings In-Reply-To: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33586-70-Lildk5ukjW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33586 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:18:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:18:40 +0000 Subject: [Koha-bugs] [Bug 33586] Library and category are switched in table configuration for patron search results table settings In-Reply-To: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33586-70-wVx4dafvdk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33586 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150073|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150209&action=edit Bug 33586: Fix sequence of fields for memberresultst in table configuration The sequence of options actually matters, not the name. Library and category were switched, this patch fixes it and now it should all hide/show as expected: * Go to administration > table configuration * Hide library in memberresultst * Go to patron search and search * Verify that category was hidden instead * Apply patch * Verify now label and columns for library and category match with configuration. Signed-off-by: Lisette Scheer <lisette.scheer at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:23:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:23:40 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-ElZQUyqmgv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:33:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:33:33 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-mL84g0X7mg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 --- Comment #14 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Philip Orr from comment #13) > then switch from Record type: Biblios to Record type: Authorities, your list > actually stays selected and is still shown (and will indeed be modified if > you proceed). In my testing this is a bug which exists in master and previous versions. I'm not sure if the bug should be resolved as part of this patch or not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:36:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:36:12 +0000 Subject: [Koha-bugs] [Bug 33253] 2FA - Form not excluded from autofill In-Reply-To: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33253-70-pbfynzZAbh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33253 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:36:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:36:14 +0000 Subject: [Koha-bugs] [Bug 33253] 2FA - Form not excluded from autofill In-Reply-To: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33253-70-ubfcqHdoyS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33253 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149733|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150210&action=edit Bug 33253: Turn off autocompletion for 2FA authentication code The form for entering your authentication code shoudl not suggest previous codes. To test: * Activate TwoFactorAuthentication * Go to your patron account in staff * More > Manage 2-factor authentication * I used "Google authenticator" on my phone, so: * Open app on your phone, add new and scan the QR code * Enter activation code * Log out of staff interface * Log back in, you are now also asked for an authentication code as second step * Look up code in app, enter, get logged in * Log out, log back in - the form now suggests the previous code when you click on it * Apply patch * Reload things (restart_all on ktd) * Verify that you no longer get the suggestion Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:37:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:37:11 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-0BE7pLJ3te@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #100 from Hammat wele <hammat.wele at inlibro.com> --- (In reply to David Nind from comment #97) > I have tested (using koha-testing-docker), so that there is a sign-off from > someone other than InLibro staff. > > Notes from testing: > > 1. There are whitespace errors when applying the patches. [1] > > 2. Formatting patch titles - these should be in the format Bug XXXX: The > title for the patch AND Bug XXXX: (follow-up) The title for the follow-up > (see https://wiki.koha-community.org/wiki/Commit_messages#Subject_line). > > 3. Patches with the same name - this can be confusing, but I'm not sure of > the best way to do this for this bug. Also, as this bug has been around for > a while, and has a bit of history, maybe the patches should be consolidated. > I would ask on IRC to get expert advice on the best approach to take for > this bug (maybe have the main patch, a patch for the database update, and a > patch for test changes). > > 4. Running updatedatabase produced no output on the command line for me - > normally it does. The way to do database updates changed a while ago, but I > don't know enough about how this works to comment. Maybe ask on IRC or see > https://wiki.koha-community.org/wiki/Database_updates However, the new > system preference RedirectGuaranteeEmail appears for me. > > 5. Running the tests fail for: prove t/db_dependent/Members.t and prove > t/db_dependent/Letters.t [2] > > 6. Comment #70 - not sure whether any of the issues raised have been > addressed, or whether these should be addressed in a separate bug. I've made some fixes to the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:40:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:40:52 +0000 Subject: [Koha-bugs] [Bug 33328] x-marc-schema should be renamed x-record-schema In-Reply-To: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33328-70-OYspT7AyNw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33328 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:42:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:42:32 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-fQ9Lk2D7TF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32672 CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:42:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:42:32 +0000 Subject: [Koha-bugs] [Bug 32672] Incorrect CSS path to jquery-ui In-Reply-To: <bug-32672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32672-70-gflfFVz9LD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32672 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32701 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:43:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:43:18 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-qYdZk4jMmh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:43:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:43:21 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-yIeUBHbm82@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150145|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150211&action=edit Bug 32701: Fix I18N JavaScript libraries on self checkout help page The help page was missing the fixes from bug 28488. The missing libraries are causing a JavaScript error on the page and likely other issues. To test: * Make sure WebBasedSelfCheck is activated and configured Note: In ktd you don't need to configure anything, it's already set up. * In the OPAC, go to: /cgi-bin/koha/sco/sco-main.pl * Click on the link to the help in the top right corner * Verify you see the error in the console: jQuery.Deferred exception: __ is not defined * Apply patch * Restart things * Reload the page * Veriy the errors are gone Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:43:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:43:36 +0000 Subject: [Koha-bugs] [Bug 32701] Self checkout help page lacks required I18N JavaScript In-Reply-To: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32701-70-dFaDdITq4W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- It does not make sense to have it here, but I am lazy to find a better solution (and it's already in sci-main). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:51:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:51:05 +0000 Subject: [Koha-bugs] [Bug 33608] New: Allow to get statistics about found books Message-ID: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Bug ID: 33608 Summary: Allow to get statistics about found books Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:54:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:54:29 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-tUOkjIWgE4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 16:54:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 14:54:35 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-CSVEeKP8tt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 17:21:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 15:21:28 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-uazsqqULVV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 17:21:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 15:21:30 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-m7usAW4rMY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150212&action=edit Bug 33607: Add framework display to staff details page This patch adds a Frameworks pluing to allow fetching the framework text and displays this on the intranet details page To test: 1 - Apply patch 2 - View a record details page in staff 3 - Confirm you see the framework name 4 - prove -v t/db_dependent/Template/Plugin/Frameworks.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 17:21:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 15:21:40 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-Y4obL8hNwT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 17:22:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 15:22:46 +0000 Subject: [Koha-bugs] [Bug 33277] Correctly handle linking subfields with no defined thesaurus In-Reply-To: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33277-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33277-70-K1McGeuS45@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33277 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 17:23:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 15:23:00 +0000 Subject: [Koha-bugs] [Bug 33557] Add a system preference to disable/enable thesaurus checking during authority linking In-Reply-To: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33557-70-4AQt7fb7xP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33557 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Severity|normal |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 17:30:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 15:30:08 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-BKJ7rCFmZv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 17:30:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 15:30:10 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-XrkLjm8i78@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150213&action=edit Bug 31187: (follow-up) Fix whitespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 17:33:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 15:33:57 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-n000mGzCA7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 17:34:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 15:34:00 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-1rlHpGceYm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 --- Comment #15 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 150214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150214&action=edit Bug 32914: (follow-up) Improve handling of list tab visibility This patch makes minor changes to the way this page handles switching between authority and bibliographic record batch operation in order to ensure that the list tab is correctly shown or hidden and that the list tab selection isn't transmitted when an authority batch is submitted. This patch also changes the labels on the "record type" fields to fix the incorrect use of the abbreviated "biblios" in favor of "Bibliographic." To test, apply the patch and go to Cataloging -> Batch record modification - With the "Bibliographic records" selected, click the "Select a list of records" tab." - Select the "Authority records" radio button. - The "Select a list of records" tab should disappear, and the "Upload a file" tab should now be selected." - Select the "Bibliographic records radio button. - The "Select a list of records" tab should reappear, and the "Upload a file" tab should be selected. - Test all combinations of form submissions to confirm that each works correctly: - Bibliographic records by upload, list, and biblionumber entry - Authory records by upload and authority record number entry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 17:34:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 15:34:58 +0000 Subject: [Koha-bugs] [Bug 33609] New: Script delete_records_via_leader.pl should work with authority records Message-ID: <bug-33609-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33609 Bug ID: 33609 Summary: Script delete_records_via_leader.pl should work with authority records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently this only works with biblios, we should provide the same service for authorities -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 17:35:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 15:35:00 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-u0Cnabs00M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 --- Comment #16 from Owen Leonard <oleonard at myacpl.org> --- > I'm not sure if the bug should be resolved as part of this patch or not I decided that since the patch includes changes affecting how tabs are shown and hidden it makes sense to roll this fix in at the same time. Hopefully my follow-up takes care of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 17:55:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 15:55:01 +0000 Subject: [Koha-bugs] [Bug 33363] More specific permissions for purchase suggestions In-Reply-To: <bug-33363-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33363-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33363-70-hXhh7q4v9g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 18:06:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 16:06:36 +0000 Subject: [Koha-bugs] [Bug 33610] New: Accelerated Reading Level Search not accurate Message-ID: <bug-33610-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33610 Bug ID: 33610 Summary: Accelerated Reading Level Search not accurate Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: dch at interleaf.ie QA Contact: testopia at bugs.koha-community.org If you search for Accelerated Reader level 6 the system shows all the books at that level, but it also picks up titles that are a reading level of .6 e.g. Angels and Demons by Dan Brown is 5.6 but it is listed when I search for AR level 6. We need a search that will only return books at level 6 (including all decimal points up to 7) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 18:20:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 16:20:15 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24151-70-IH9DGinwra@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Aude Charillon <aude.charillon at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/666 Status|Needs documenting |RESOLVED --- Comment #114 from Aude Charillon <aude.charillon at ptfs-europe.com> --- New system preferences and information about Bcrypt settings added to the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 18:20:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 16:20:16 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18081-70-RtxVohhLkF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Bug 18081 depends on bug 24151, which changed state. Bug 24151 Summary: Add a pseudonymization process for patrons and transactions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 18:20:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 16:20:17 +0000 Subject: [Koha-bugs] [Bug 28911] Bcrypt settings are required for pseudonymization but are not set on upgrade In-Reply-To: <bug-28911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28911-70-BufuHyQeKf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 Bug 28911 depends on bug 24151, which changed state. Bug 24151 Summary: Add a pseudonymization process for patrons and transactions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 18:20:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 16:20:18 +0000 Subject: [Koha-bugs] [Bug 32438] Pseudonymized_transactions should include payments and writeoffs In-Reply-To: <bug-32438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32438-70-SwnT7YChEO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32438 Bug 32438 depends on bug 24151, which changed state. Bug 24151 Summary: Add a pseudonymization process for patrons and transactions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 18:20:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 16:20:18 +0000 Subject: [Koha-bugs] [Bug 32440] Allow selective deletion of statistics entries based on type by cleanup_database In-Reply-To: <bug-32440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32440-70-hqtZvwOhz8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32440 Bug 32440 depends on bug 24151, which changed state. Bug 24151 Summary: Add a pseudonymization process for patrons and transactions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 18:20:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 16:20:18 +0000 Subject: [Koha-bugs] [Bug 32441] Localuse is recorded in statistics but not recreated in pseudonymized_transactions In-Reply-To: <bug-32441-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32441-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32441-70-iuBq4Iv3ng@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32441 Bug 32441 depends on bug 24151, which changed state. Bug 24151 Summary: Add a pseudonymization process for patrons and transactions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 18:20:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 16:20:19 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24152-70-QO2Q4tuXur@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Bug 24152 depends on bug 24151, which changed state. Bug 24151 Summary: Add a pseudonymization process for patrons and transactions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 18:20:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 16:20:19 +0000 Subject: [Koha-bugs] [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined In-Reply-To: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28912-70-cmNW6DRJ2H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 Bug 28912 depends on bug 24151, which changed state. Bug 24151 Summary: Add a pseudonymization process for patrons and transactions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 18:20:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 16:20:20 +0000 Subject: [Koha-bugs] [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC In-Reply-To: <bug-29341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29341-70-VHNZvB2egM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 Bug 29341 depends on bug 24151, which changed state. Bug 24151 Summary: Add a pseudonymization process for patrons and transactions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 18:20:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 16:20:20 +0000 Subject: [Koha-bugs] [Bug 32439] Allow selective deletion of statistics entries based on type by cleanup_database In-Reply-To: <bug-32439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32439-70-t1um5qI0IT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32439 Bug 32439 depends on bug 24151, which changed state. Bug 24151 Summary: Add a pseudonymization process for patrons and transactions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 18:45:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 16:45:45 +0000 Subject: [Koha-bugs] [Bug 20859] SMS and other notification preferences during self registration In-Reply-To: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20859-70-0NhzbJPWgG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- If SMSnumber is added it would be nice to also add sms_provider_id. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 18:59:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 16:59:08 +0000 Subject: [Koha-bugs] [Bug 27074] When a subscription is closed, it still shows as current in OPAC In-Reply-To: <bug-27074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27074-70-h9ksqMnnv0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27074 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 20:13:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 18:13:33 +0000 Subject: [Koha-bugs] [Bug 20859] SMS and other notification preferences during self registration In-Reply-To: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20859-70-xzIVRTTM3z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #5 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Lucas Gass from comment #4) > If SMSnumber is added it would be nice to also add sms_provider_id. Only if the particular type of SMS messaging requires it. We use Twilio, that doesn't require this info. Koha's built in SMS through email does. I'm not sure about the iTiva (Talking Tech) setup. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 20:15:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 18:15:05 +0000 Subject: [Koha-bugs] [Bug 20859] SMS and other notification preferences during self registration In-Reply-To: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20859-70-y0SjQ0qLp8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #6 from Christopher Brannon <cbrannon at cdalibrary.org> --- That is, if iTiva has an SMS solution. I think I am mixing that one up. I know they do voice. Anyway, not all SMS solutions require a vendor preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 20:45:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 18:45:01 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-gSRYTVANFc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #101 from David Nind <david at davidnind.com> --- (In reply to Hammat wele from comment #100) > I've made some fixes to the patch Thanks Hammat! Unfortunately, the patch no longer applies 8-(.. git bz apply 12532 Bug 12532 - Redirect guarantee email to guarantor 150208 - Bug 12532: Send email to guarantee and guarantor Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12532: Send email to guarantee and guarantor .git/rebase-apply/patch:37: trailing whitespace. unless ($to_address) { warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M C4/Letters.pm M Koha/Patron.pm M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref M t/db_dependent/Letters.t .git/rebase-apply/patch:37: trailing whitespace. unless ($to_address) { warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Letters.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging Koha/Patron.pm Auto-merging C4/Letters.pm CONFLICT (content): Merge conflict in C4/Letters.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 12532: Send email to guarantee and guarantor hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12532-Send-email-to-guarantee-and-guarantor-W5BJUI.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 20:48:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 18:48:41 +0000 Subject: [Koha-bugs] [Bug 33541] Show 'Document type' in list of suggestions when creating an order from a suggestion In-Reply-To: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33541-70-KcGgnewX2n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33541 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- This table can be configured, you need to update admin/columns_settings.yml Also you don't need the third parameter (opac=0), it's the default value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 20:52:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 18:52:46 +0000 Subject: [Koha-bugs] [Bug 33313] TICKET_NOTIFY looking for IntranetBaseURL rather than staffClientBaseURL in default notice In-Reply-To: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33313-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33313-70-fVefrquyFG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33313 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Status|Signed Off |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- There are 2 "Thankyou" left in installer/data/mysql/db_revs/221200010.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 20:54:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 18:54:53 +0000 Subject: [Koha-bugs] [Bug 33197] Terminology: rename GDPR_Policy system preference In-Reply-To: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33197-70-0Vk96gjjq9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33197 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- ping regarding the last 2 comments? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 21:18:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 19:18:48 +0000 Subject: [Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date In-Reply-To: <bug-32610-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32610-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32610-70-N3j5Nmn21X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Why are you adding data-date_to="to" in memberentrygen? Not blocker but it would have been more flexible (for future enhancements) to have a datatype='date' column instead of is_date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 21:20:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 19:20:34 +0000 Subject: [Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date In-Reply-To: <bug-32610-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32610-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32610-70-TyW15V4oct@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I guess you should adjust the comment here circ/overdue.pl:my @patron_attr_filter_loop; # array of [ domid cgivalue ismany isclone ordinal code description repeatable is_date authorised_value_category ] koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt: <!-- domid cgivalue ismany isclone ordinal code description repeatable authorised_value_category --> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 21:29:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 19:29:07 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-mRs9GGQrck@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Shouldn't we use html_linebreak as well? We do in moremember: [% patron.borrowernotes | $raw | html_line_break %] Also, why are we only dealing with the checkin page? There are other places where it's displayed escaped (`git grep 'borrowernotes | html'`) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 21:50:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 19:50:48 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-tTWDkCJMWa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Owen, excuse me for not knowing but are these ILL pages being handled in a separate bug? -Edit request -Confirm request -Place request with partner libraries -Edit item metadata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:09:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:09:08 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-Pv6VHnCbyO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:09:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:09:10 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-Lf7rTKpYXI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150215&action=edit Bug 33551: (follow-up) fix display when deleting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:10:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:10:07 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-c3m2fglCBo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #9) > When I try deleting, I have extra quotes. > > Confirm deletion of restriction 'Manual''') > ... Caroline, I fixed this with a follow-up. Maybe you can try and sign-off since Katrin and I both have patches on this now? I -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:18:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:18:22 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-fVm4pJ8cMd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- This is handy! I think the tests for Frameworks.t need to have permissions changed to -rwxrwxr-x . Also, is this something to be concerned about? FAIL Koha/Template/Plugin/Frameworks.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:18:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:18:36 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-8H8TGwVIJ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:19:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:19:23 +0000 Subject: [Koha-bugs] [Bug 33184] Warnings when running holds queue builder In-Reply-To: <bug-33184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33184-70-jqPjPW7zAi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33184 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28966 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:19:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:19:23 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28966-70-HooU5YMgOz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33184 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:22:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:22:26 +0000 Subject: [Koha-bugs] [Bug 28315] PopupMARCFieldDoc is defined twice in addbiblio.tt In-Reply-To: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28315-70-93SstNDPhK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28315 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:22:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:22:28 +0000 Subject: [Koha-bugs] [Bug 28315] PopupMARCFieldDoc is defined twice in addbiblio.tt In-Reply-To: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28315-70-9FzRuDJvo5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28315 --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150216&action=edit Bug 28315: Remove duplicate function definition This patch removes the unnecessary second definition of the JS function PopupMARCFieldDoc from addbiblio.tt. To test: 1. Apply the patch 2. Check that addbiblio.tt contains only one function definition for PopupMARCFieldDoc 3. Navigate to "Cataloging" -> "Add MARC record" 4. Check that after clicking on the question mark symbol next to any MARC field, the loc description of that MARC field is opened in a new tab Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:28:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:28:08 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-KAgUyM2uEK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:28:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:28:43 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-DHUlnHUaVX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Unfortunately this patch set no longer applies cleanly to current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:34:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:34:52 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-tKQUO1EH0P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150208|0 |1 is obsolete| | --- Comment #102 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 150217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150217&action=edit Bug 12532: Send email to guarantee and guarantor This patch allows guarantors to receive emails sended to their guarentees. This patch is a rebase of the previous patches. I took all the content of previous commit and put it in one commit. TO TEST: Before applying: 1) Search, or create, a patron with guarantor. 2) Enable checkout emails for both guarantors and guarantees. 3) Checkout an item. An email should be sent only to the guarantee. 4) Apply the patch. 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' 7) Run misc/cronjobs/process_message_queue.pl 8) Notice that the email should be sended to both the guarantee AND the guarantor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:35:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:35:02 +0000 Subject: [Koha-bugs] [Bug 30036] Add XSLT for authority results view in OPAC In-Reply-To: <bug-30036-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30036-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30036-70-7B5UwGPiSU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/669 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:40:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:40:29 +0000 Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30556-70-Ufvb7rIbWo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:40:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:40:32 +0000 Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30556-70-F03zsjoyNz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147378|0 |1 is obsolete| | --- Comment #39 from David Nind <david at davidnind.com> --- Created attachment 150218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150218&action=edit Bug 30556: Fix CanBookBeReserved to return early if no borrowernumber Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:40:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:40:35 +0000 Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30556-70-kgOhhIPoZD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147379|0 |1 is obsolete| | --- Comment #40 from David Nind <david at davidnind.com> --- Created attachment 150219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150219&action=edit Bug 30556: Fix IsAvailableForItemLevelRequest to return early Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:40:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:40:38 +0000 Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30556-70-7yw5y5gvoP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147380|0 |1 is obsolete| | --- Comment #41 from David Nind <david at davidnind.com> --- Created attachment 150220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150220&action=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds allowed is on "If all unavailable", the Place hold button is not shown. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. 8. Logout of the opac. 9. The button is here again since it should always show when not logged in. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:40:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:40:41 +0000 Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30556-70-ul0KH0KDGM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147381|0 |1 is obsolete| | --- Comment #42 from David Nind <david at davidnind.com> --- Created attachment 150221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150221&action=edit Bug 30556: (follow-up) Unit tests Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:40:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:40:44 +0000 Subject: [Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed In-Reply-To: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30556-70-uc1Cxe75U4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147382|0 |1 is obsolete| | --- Comment #43 from David Nind <david at davidnind.com> --- Created attachment 150222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150222&action=edit Bug 30556: Changing the logged-in user's branch by pick-up location Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:43:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:43:13 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-D8XzAxZVr7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #103 from Hammat wele <hammat.wele at inlibro.com> --- (In reply to David Nind from comment #101) > Unfortunately, the patch no longer applies 8-(.. I've rebased the patch, this one should apply now. Sorry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 22:57:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 20:57:53 +0000 Subject: [Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description In-Reply-To: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30407-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30407-70-eFHNUWQp9d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/669 Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:25:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:25:19 +0000 Subject: [Koha-bugs] [Bug 33611] New: Holds being placed in the future if DefaultHoldExpirationdate is set Message-ID: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Bug ID: 33611 Summary: Holds being placed in the future if DefaultHoldExpirationdate is set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 30718 altered C4::Reserves::AddReserve to use either the date passed in, or a dt_from_string object When storing the hold, we call Koha::Hold::_set_default_expirationdate This assumed reservedate was always a string, and used it to create a dt object, and add days for the expiration. Now that reservedate is already a dt object, this means we add the days to the object, so the reservedate is set into the future, as well as the expiration To recreate 1 - Set DefaultHoldExpiration to Set 2 - Set DefaultHoldExpirationPeriod to 365 3 - Set DefaultHoldExpirationunitOfTimeToDays 4 - Place a hold 5 - Note reserve date is 1 year in the future, same as expiration -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:25:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:25:53 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-ZH6r1FhSbv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150223&action=edit Bug 33611: WIP - needs tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:26:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:26:08 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-GgsjxmXomq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30718 CC| |jonathan.druart+koha at gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 [Bug 30718] Use flatpickr's altInput option everywhere -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:26:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:26:08 +0000 Subject: [Koha-bugs] [Bug 30718] Use flatpickr's altInput option everywhere In-Reply-To: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30718-70-XBUx3JAh3I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33611 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:27:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:27:30 +0000 Subject: [Koha-bugs] [Bug 33612] New: Staff with limited permissions don't always get an expanded catalog_search bar Message-ID: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Bug ID: 33612 Summary: Staff with limited permissions don't always get an expanded catalog_search bar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1. Setup a staff member with staff access permission but no circulate permissions. 2. Log in as that and on the intranet-home page notice that 'Search patron' bar across the top is not visible by default. 3. Click the 'Search patrons' link at the top, now you see the search bar. 4. This is also true on the item search page. It is because we are using the old home-search.inc when it should be the cat-search.inc If you git grep 'home-search.inc' you'll see it on these two pages. koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt: [% INCLUDE 'home-search.inc' %] koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt: [% INCLUDE 'home-search.inc' %] We can change that to cat-search.inc and remove the unused home-search.inc, I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:27:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:27:37 +0000 Subject: [Koha-bugs] [Bug 33612] Staff with limited permissions don't always get an expanded catalog_search bar In-Reply-To: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33612-70-6Tpz0H5eor@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:34:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:34:14 +0000 Subject: [Koha-bugs] [Bug 29792] Transfers created from 'wrong transfer' checkin are not sent if modal is dismissed In-Reply-To: <bug-29792-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29792-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29792-70-XD1m6xHz3g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29792 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/669 CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:37:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:37:46 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-OjweZvaEdv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 --- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150224&action=edit Bug 33612: Fix cat-search.inc and remove home-search.inc To test: 1. Setup a staff member with staff access permission but no circulate permissions. 2. Log in as that and on the intranet-home page notice that 'Search patron' bar across the top is not visible by default. 3. Click the 'Search patrons' link at the top, now you see the search bar. 4. This is also true on the item search page. 5. Apply patch 6. Try looking at the intranet home and item search pages again, the search bar should be expanded by default. 7. git grep 'home-search.inc' , this include should be gone along with all references to it. 8. Log in as a superlibrarian and make sure the top search bars still seem correct and default to the correct ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:38:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:38:04 +0000 Subject: [Koha-bugs] [Bug 33612] Staff with limited permissions don't always get an expanded catalog_search bar In-Reply-To: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33612-70-szz85JKMND@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:38:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:38:06 +0000 Subject: [Koha-bugs] [Bug 33612] Staff with limited permissions don't always get an expanded catalog_search bar In-Reply-To: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33612-70-nNzsMGesCP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150225&action=edit Bug 33612: Fix cat-search.inc and remove home-search.inc To test: 1. Setup a staff member with staff access permission but no circulate permissions. 2. Log in as that and on the intranet-home page notice that 'Search patron' bar across the top is not visible by default. 3. Click the 'Search patrons' link at the top, now you see the search bar. 4. This is also true on the item search page. 5. Apply patch 6. Try looking at the intranet home and item search pages again, the search bar should be expanded by default. 7. git grep 'home-search.inc' , this include should be gone along with all references to it. 8. Log in as a superlibrarian and make sure the top search bars still seem correct and default to the correct ones. https://bugs.koha-community.org/show_bug.cgi?id=33584 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:39:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:39:27 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-UjdMKaq23M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:39:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:39:29 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-tayvoOHi7V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149994|0 |1 is obsolete| | --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 150226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150226&action=edit Bug 33551: Fix HTML title on patron restrictions page To test: 1. Enable PatronRestrictionTypes 2. Go to Administration > Patron restrictions 3. Click 'Edit' next to MANUAL --> The title of the page (in the browser tab) contains <span> </span> 4. Apply patch 5. Look at the title of the page when viewing, editing, and deleteing restrictions to make sure they are correct. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:39:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:39:31 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-i2pnxe59GI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149995|0 |1 is obsolete| | --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 150227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150227&action=edit Bug 33551: (follow-up) Remove spans by using TT filter This allows up to keep the restriction name in the title by removing the span tags with a TT filter. Copied from bug 32061. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:39:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:39:34 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-fy9kgcVvq2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150215|0 |1 is obsolete| | --- Comment #14 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 150228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150228&action=edit Bug 33551: (follow-up) fix display when deleting Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:39:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:39:52 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-gzbOo9sPI2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 --- Comment #15 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Thank you both! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:47:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:47:37 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-ITSQi6lC9P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:47:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:47:39 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-YSYkQfBQ3Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149807|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 150229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150229&action=edit Bug 33550: Rename Patron restrictions administration page to Patron restriction types This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration. To test: 0. Apply patch 1. Enable PatronRestrictionTypes 2. Go to Administration 3. Check the name, spelling/grammar of the following elements * Section name * Section caption 4. Click 'Patron restriction types' 5. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Left hand side menu * 'New' button * Page heading 6. Click 'New restriction type' 7. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 8. Fill out the form and click 'Save' to create a new restriction type * Dialog message ('Restriction type added') 9. Click 'New restriction type' 10. Enter the same code as last time * Warning ('Restriction type code is already in use') 11. Click 'Cancel' 12. Click 'Edit' next to one of the types 13. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 14. Without changing anything, click 'Save' * Warning ('Restriction type label is already in use') 15. Change the label and click 'Save' * Dialog message ('Restriction type updated') 16. Click 'Delete' next to one of the types 17. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading * Delete button 18. Click 'Delete this restriction type' * Dialog message ('Restriction type deleted') Signed-off-by: Marius Mandrescu <marius.mandrescu at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:47:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:47:41 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-14ANNtHk5O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 150230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150230&action=edit Bug 33550: (follow-up) Rename Patron restrictions administration page to Patron restriction types) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 25 23:48:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 21:48:29 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-29beOh1QlI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I tried rebasing. Not sure what I'm doing so crossing my fingers it worked ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 00:20:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 22:20:24 +0000 Subject: [Koha-bugs] [Bug 33613] New: Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge Message-ID: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Bug ID: 33613 Summary: Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1. Have an item with a replacement cost checked out to a patron 2. Set the ClaimReturnedChargeFee sys pref to "Ask if a lost fee should be charged" 3. Make a claim and check the box for charging. 4. Claim happens but no charge occurs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 00:25:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 22:25:17 +0000 Subject: [Koha-bugs] [Bug 2646] Add sort option for the series number In-Reply-To: <bug-2646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2646-70-CkOLy14kbD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2646 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to slmontesdeoca from comment #1) > Being able to sort series by volume number would be extremely helpful. > However, doing so shouldn't be confined to the 440 $v, but also 8XX $v. What about the 490v? I, too, would like to see progress on this. Particularly when you click on a series link, that should default to a specific order. Would love to see more interest and movement on this. This bug is quite old. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 00:30:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 22:30:44 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16122-70-hacxz6QOsv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #20 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150231&action=edit Bug 16122: Increment localuse when checking out to stats patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 00:37:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 22:37:09 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16122-70-tOLJ9kz8vT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #21 from Lucas Gass <lucas at bywatersolutions.com> --- TEST PLAN: To test: 1. Apply patch, updatedatabase & schema, restart all Services 2. Go to Administration > Table setting. Find the holdings table ( Catalog > holdings_table ) and turn the local use column on. 3. Go to an item record and notice the column 'Local uses' 4. Turn the system preference RecordLocalUseOnReturn Off. 5. Check in an item that is not checkout out. No local use should be recorded for the item. 6. Turn RecordLocalUseOnReturn on and check in an item that is not checked out. Local use on that item should increment by 1. 7. Create a statistical patron and check an item out to them. Local use should increment by 1. 8. Go to /api/v1/items?external_id={barcode} and make sure the numbers for localuse look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 00:53:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 22:53:52 +0000 Subject: [Koha-bugs] [Bug 33602] Add mark lost option to cancel transfer on transferstoreceive.pl In-Reply-To: <bug-33602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33602-70-AoJUYFjW23@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33602 Avery Campbell (Butte County Library (CA)) <acampbell at buttecounty.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell at buttecounty.net --- Comment #1 from Avery Campbell (Butte County Library (CA)) <acampbell at buttecounty.net> --- We have items that have been in transit for several years. This would help remove these, as they are not likely to be found. And it they actually are on the shelf, we'll find them (or a patron will) which will automatically remove the lost status when checked in. The current 'Cancel Transfer' button just cancels the transfer (which can be helpful in some situations), but if we are canceling the transfer because the item is missing from the collection (or as I am seeing, in transit since 2019, 2020, or 2021), we currently have to open the record in a new tab to mark it missing (canceling the transfer removes it from the transferstoreceive.pl page, so good luck finding it again if you didn't write it down!). Having the option to take care of both together would simplify the process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 01:09:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 23:09:23 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-O92qTyReR4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- In modal-claims.inc: let fee = $('#claims-returned-charge-lost-fee').attr('checked') ? true : false; attr() won't always evaluate to true and I think prop() is a much better choice in this circumstance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 01:12:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 23:12:13 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16122-70-27V1QVzTlQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149281|0 |1 is obsolete| | --- Comment #22 from Biblibre Sandboxes <sandboxes at biblibre.com> --- Created attachment 150232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150232&action=edit Bug 16122: Add localuse column to items and deleteditems Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 01:12:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 23:12:15 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16122-70-7t1sPdsh3a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149282|0 |1 is obsolete| | --- Comment #23 from Biblibre Sandboxes <sandboxes at biblibre.com> --- Created attachment 150233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150233&action=edit Bug 16122: API and Schema updates Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 01:12:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 23:12:17 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16122-70-3u3n2m4PcA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149283|0 |1 is obsolete| | --- Comment #24 from Biblibre Sandboxes <sandboxes at biblibre.com> --- Created attachment 150234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150234&action=edit Bug 16122: Increment items.localuse in AddReturn Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 01:12:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 23:12:20 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16122-70-PO8UMEV8Dw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149284|0 |1 is obsolete| | --- Comment #25 from Biblibre Sandboxes <sandboxes at biblibre.com> --- Created attachment 150235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150235&action=edit Bug 16122: Add display to holdings/otherholdings and Table settings Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 01:12:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 23:12:22 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16122-70-ks33TU3cj2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150231|0 |1 is obsolete| | --- Comment #26 from Biblibre Sandboxes <sandboxes at biblibre.com> --- Created attachment 150236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150236&action=edit Bug 16122: Increment localuse when checking out to stats patron Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 01:12:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 23:12:24 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-6irqJH6CyC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 01:12:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 23:12:26 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-K3I0751P8b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150237&action=edit Bug 33613: Use prop() to evaluate checkbox To test: 1. Have an item with a replacement cost checked out to a patron 2. Set the ClaimReturnedChargeFee sys pref to "Ask if a lost fee should be charged" 3. Make a claim and check the box for charging. 4. Claim happens but no charge occurs. 5. Apply patch and try again. 6. A charge should now occur. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 01:12:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 23:12:41 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-ppLjbHPtxC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Severity|enhancement |normal Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 01:12:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 23:12:55 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16122-70-fMRuIJvU8g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off --- Comment #27 from Christopher Brannon <cbrannon at cdalibrary.org> --- Works like a charm! Cool beans! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 01:15:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 23:15:05 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-irtfBq3Xm6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 01:15:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 23:15:57 +0000 Subject: [Koha-bugs] [Bug 33612] Staff with limited permissions don't always get an expanded catalog_search bar In-Reply-To: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33612-70-kRSMtC58eG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 01:19:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Apr 2023 23:19:51 +0000 Subject: [Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice In-Reply-To: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32917-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32917-70-G77I0bAVFb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 02:13:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 00:13:32 +0000 Subject: [Koha-bugs] [Bug 33584] Fix failures for Database/Commenter.t on MySQL 8 In-Reply-To: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33584-70-EqK2Pbl9ae@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33584 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150224|0 |1 is obsolete| | --- Comment #15 from David Nind <david at davidnind.com> --- Comment on attachment 150224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150224 Bug 33612: Fix cat-search.inc and remove home-search.inc Obsoleting - patch attached to the wrong bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 02:47:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 00:47:52 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-pner7djozB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #104 from David Nind <david at davidnind.com> --- (In reply to Hammat wele from comment #103) > (In reply to David Nind from comment #101) > > Unfortunately, the patch no longer applies 8-(.. > > I've rebased the patch, this one should apply now. > Sorry No problem, and thanks! I can confirm that this all now works as per the test plan. However, the tests fail (even though that wasn't included in the test plan) - they passed before applying the patch. prove t/db_dependent/Members.t t/db_dependent/Members.t .. 1/57 # Failed test 'notice_email_address returns correct value when AutoEmailPrimaryAddress is emailpro' # at t/db_dependent/Members.t line 163. # got: 'Marie at email.com' # expected: 'Marie at work.com' t/db_dependent/Members.t .. 35/57 # Looks like you failed 1 test of 57. t/db_dependent/Members.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/57 subtests Test Summary Report ------------------- t/db_dependent/Members.t (Wstat: 256 Tests: 57 Failed: 1) Failed test: 11 Non-zero exit status: 1 Files=1, Tests=57, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.84 cusr 0.37 csys = 2.23 CPU) Result: FAIL prove t/db_dependent/Letters.t t/db_dependent/Letters.t .. 48/87 # Failed test 'SendQueuedMessages with limit 1' # at t/db_dependent/Letters.t line 1069. # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at /kohadevbox/koha/C4/Letters.pm line 1325. # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at /kohadevbox/koha/C4/Letters.pm line 1325. # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at /kohadevbox/koha/C4/Letters.pm line 1325. # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at /kohadevbox/koha/C4/Letters.pm line 1325. # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at /kohadevbox/koha/C4/Letters.pm line 1325. # expected to find warning: (?^u:Fake send_or_die) # Failed test 'Sent 1 message with limit of 1 and 5 unprocessed messages' # at t/db_dependent/Letters.t line 1071. # got: '0' # expected: '1' # Failed test 'SendQueuedMessages with limit 2' # at t/db_dependent/Letters.t line 1076. # didn't find a warning # expected to find warning: (?^u:Fake send_or_die) # expected to find warning: (?^u:Fake send_or_die) # Failed test 'Sent 2 messages with limit of 2 and 4 unprocessed messages' # at t/db_dependent/Letters.t line 1078. # got: '0' # expected: '2' # Failed test 'SendQueuedMessages with limit 3' # at t/db_dependent/Letters.t line 1083. # didn't find a warning # expected to find warning: (?^u:Fake send_or_die) # expected to find warning: (?^u:Fake send_or_die) # Failed test 'Sent 2 messages with limit of 3 and 2 unprocessed messages' # at t/db_dependent/Letters.t line 1085. # got: '0' # expected: '2' # Failed test '5 messages sent' # at t/db_dependent/Letters.t line 1088. # got: '0' # expected: '5' # Failed test 'SendQueuedMessages with limit 2 and domain limits' # at t/db_dependent/Letters.t line 1114. # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at /kohadevbox/koha/C4/Letters.pm line 1325. # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at /kohadevbox/koha/C4/Letters.pm line 1325. # found warning: Sending messages: domain fake1.domain reached limit of 1/1m at /kohadevbox/koha/Koha/Notice/Util.pm line 97. # found warning: Fake send_or_die at t/db_dependent/Letters.t line 43. # expected to find warning: (?^u:wrong.net reached limit) # expected to find warning: (?^u:Fake send_or_die) # expected to find warning: (?^u:fake1.domain reached limit) # expected to find warning: (?^u:Fake send_or_die) # Failed test 'Only expecting 2 sent messages' # at t/db_dependent/Letters.t line 1116. # got: '1' # expected: '2' # Failed test 'Still 4 pending' # at t/db_dependent/Letters.t line 1117. # got: '3' # expected: '4' # Failed test 'We saw 6 messages while checking domain limits: so we deferred 4' # at t/db_dependent/Letters.t line 1118. # got: '4' # expected: '6' # Looks like you planned 18 tests but ran 12. # Looks like you failed 11 tests of 12 run. # Failed test 'Test limit parameter for SendQueuedMessages' # at t/db_dependent/Letters.t line 1119. # Looks like you failed 1 test of 87. t/db_dependent/Letters.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/87 subtests Test Summary Report ------------------- t/db_dependent/Letters.t (Wstat: 256 Tests: 87 Failed: 1) Failed test: 86 Non-zero exit status: 1 Files=1, Tests=87, 2 wallclock secs ( 0.02 usr 0.01 sys + 1.87 cusr 0.31 csys = 2.21 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 03:13:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 01:13:05 +0000 Subject: [Koha-bugs] [Bug 17004] REST API: add route to authenticate patron (Single Sign On - SSO) In-Reply-To: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17004-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17004-70-92bY2aZCNz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004 --- Comment #40 from David Cook <dcook at prosentient.com.au> --- Now that bug 30962 has been pushed to 22.11.03+, I'll be using that in my Keycloak extension. -- Also I think that bug 30962 might actually meet quite a few of the original goals outlined in this bug report... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 03:17:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 01:17:00 +0000 Subject: [Koha-bugs] [Bug 25390] Login box is removed from opac-main.tt if Shibboleth or CAS is enabled In-Reply-To: <bug-25390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25390-70-7a32PyFw75@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook <dcook at prosentient.com.au> --- (In reply to Lucas Gass from comment #0) > 3. Maybe it would be simpler to keep the login box regardless of sign in > method and hide it via CSS for libraries that don't want it? This is my inclination. Some libraries want both local login and SSO, while others don't. CSS is the easiest way to control this on a per-instance basis. Bug 31064 was designed to make it easier to control the display of the local login. That said, it looks like there are quite a few lines like "<p>If you do not have a Google account, but do have a local account, you can still log in: </p>" which are missing selectors at the moment... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 03:21:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 01:21:01 +0000 Subject: [Koha-bugs] [Bug 33614] New: Templates contain problematic references to local login Message-ID: <bug-33614-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33614 Bug ID: 33614 Summary: Templates contain problematic references to local login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Bug 31064 wrapped the local login fields with a "local-login" class. However, if you hide the local login fields using this class, there are still references to local login in the SSO implementations where they say things like the following: -- Sorry, the CAS login also failed. If you have a local login you may use that below. If you have a local account, you may use that below. If you do not have a Shibboleth account, but you do have a local login, then you may login below. If you do not have a Google account, but do have a local account, you can still log in: -- These references should either include the "local-login" class so they can be hidden, or these references should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 03:21:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 01:21:26 +0000 Subject: [Koha-bugs] [Bug 33614] Templates contain problematic references to local login In-Reply-To: <bug-33614-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33614-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33614-70-cfonEOH0vX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33614 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25390, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31064 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 03:21:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 01:21:26 +0000 Subject: [Koha-bugs] [Bug 25390] Login box is removed from opac-main.tt if Shibboleth or CAS is enabled In-Reply-To: <bug-25390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25390-70-4rFRN9Nr3F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25390 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33614 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 03:21:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 01:21:26 +0000 Subject: [Koha-bugs] [Bug 31064] Local login is difficult to style using CSS In-Reply-To: <bug-31064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31064-70-hxjYWjVJkn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31064 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33614 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 03:22:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 01:22:20 +0000 Subject: [Koha-bugs] [Bug 28093] Additional configuration option(s) for Shibboleth-only mode In-Reply-To: <bug-28093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28093-70-9TUA4pBC7w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28093 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33614 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 03:22:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 01:22:20 +0000 Subject: [Koha-bugs] [Bug 33614] Templates contain problematic references to local login In-Reply-To: <bug-33614-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33614-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33614-70-II5VdqxQfP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33614 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28093 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 05:38:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 03:38:50 +0000 Subject: [Koha-bugs] [Bug 32782] Add UNIMARC support to the ERM module In-Reply-To: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32782-70-bopbvYJygK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 --- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> --- > Create a new local title and confirm that the Koha bibliographic record is created correctly. I filled all the fields in the local title and only one field ends up in the record (200$a (title)) But same happens without the patches on marc21 so I guess it's normal. Pointing out just in case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 05:39:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 03:39:13 +0000 Subject: [Koha-bugs] [Bug 33018] debian package tidy-up In-Reply-To: <bug-33018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33018-70-VyCBcgy5oS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #5 from David Cook <dcook at prosentient.com.au> --- (In reply to Magnus Enger from comment #2) > So the point is that we had to provide them in the Koha Debian repo, but now > we don't have to do that anymore, and we can remove them from "special > treatment"? I think this question should be answered before this issue is progressed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 06:27:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 04:27:55 +0000 Subject: [Koha-bugs] [Bug 33615] New: Date picker icon not visible Message-ID: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Bug ID: 33615 Summary: Date picker icon not visible Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: wainuiwitikapark at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Noticed on the Edit item screen and the Issues screen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 06:31:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 04:31:41 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-WisqPmA8Lh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #1 from wainuiwitikapark at catalyst.net.nz --- Aleisha did a git bisect to see what caused the issue 854c0fc1dea9435e35832a5190847aa7f922335e is the first bad commit commit 854c0fc1dea9435e35832a5190847aa7f922335e Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Date: Wed Jan 11 15:20:28 2023 +0100 Bug 32609: Remove CSS and JS compiled files Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> (cherry picked from commit dcf772cb7026b4ed21caf6b055f8260140dcefdb) Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> koha-tmpl/intranet-tmpl/prog/css/calendar.css | 9 --------- koha-tmpl/intranet-tmpl/prog/css/holds.css | 1 - koha-tmpl/intranet-tmpl/prog/css/installer.css | 9 --------- koha-tmpl/intranet-tmpl/prog/css/mainpage.css | 1 - koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 9 --------- koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/print-rtl.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/print.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/sco-rtl.css | 1 - koha-tmpl/opac-tmpl/bootstrap/css/sco.css | 1 - 11 files changed, 35 deletions(-) delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/calendar.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/holds.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/installer.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/mainpage.css delete mode 100644 koha-tmpl/intranet-tmpl/prog/css/staff-global.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/opac-rtl.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/opac.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/print-rtl.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/print.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/sco-rtl.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/sco.css -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 07:04:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 05:04:16 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-BllUc3iMQv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #65 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Hi all, This has caused some problems for our libraries upgrading to 22.11.04. For example, - the calendar icon that shows in the flatpickr text input fields does not show - making return claims on the checkouts page shows the 'loading' icon forever, have to refresh the page to show the claim Is there something we need to additionally do or install? Thanks Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 07:27:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 05:27:29 +0000 Subject: [Koha-bugs] [Bug 32748] Library limitations will cause data loss when editing items In-Reply-To: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32748-70-AqMd56qhNq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32748 --- Comment #12 from Michaela Sieber <michaela.sieber at kit.edu> --- (In reply to Thibaud Guillot from comment #11) > > I submit you this patch to know if I'm going in the right direction. > Thanks for your future feedbacks Hi Thibaud, I wanted to test the new patch, but the sandbox does not start and an error occurs: Template process failed: undef error - C4::Koha::GetAuthorisedValues(): DBI Exception: DBD::mysql::st execute failed: 'koha_b32748.av.category' isn't in GROUP BY at /kohadevbox/koha/Koha/Template/Plugin/AuthorisedValues.pm line 39 at /kohadevbox/koha/C4/Templates.pm line 127 for more information see: https://staff-b32748.sandboxes.biblibre.eu/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 07:31:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 05:31:05 +0000 Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30687-70-CAbBIAP4Bl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 --- Comment #30 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Yes alternate-alternate looks good thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 07:39:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 05:39:54 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-YAKOZXDr02@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #66 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #64) > Will know more soon! I'm working on a customized 22.11.03 and planning to > merge in 22.11.04 when it comes out. (In reply to Aleisha Amohia from comment #65) > This has caused some problems for our libraries upgrading to 22.11.04. (In reply to Aleisha Amohia from comment #65) > Is there something we need to additionally do or install? I recently decided to pin at 22.11.03 for the time being, so I'm not sure what the problem might be. I could probably look at this later this week if no one else does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 07:59:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 05:59:15 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-GZZdWTZwaH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.05 |22.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 09:34:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 07:34:36 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-lx61Ky6LGM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #67 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Martin Renvoize from comment #62) > Backported for release in 22.11.04 Did you ask Mason to adjust the pkg workflow to embed the css and js files? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 10:23:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 08:23:45 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-DLfKboEzB4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Philip Orr <philip.orr at lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Philip Orr <philip.orr at lmscloud.de> --- Thanks Owen for going above and beyond on this one :) Everything now works as expected and displays correctly. Although... I hope I'm not being too much of a nuisance, but I did find another bug. If you enter batch record modification, select Authority records, select a template and then hit continue without actually uploading a file or entering record numbers, the error message "No records were modified." will be displayed. All correct so far. If you then don't click on "New batch record modification" and instead use the back button in Firefox to go back one page, you will land in batch record modification with Authority records selected but with the tab "Select a list of records" now again displayed and usable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 11:08:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 09:08:54 +0000 Subject: [Koha-bugs] [Bug 27765] Set a custom order to library branches on opac-library.pl In-Reply-To: <bug-27765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27765-70-opXjtSTKjH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27765 kch-tr.lhl-consortium at nhs.net <kch-tr.lhl-consortium at nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kch-tr.lhl-consortium at nhs.n | |et --- Comment #5 from kch-tr.lhl-consortium at nhs.net <kch-tr.lhl-consortium at nhs.net> --- (In reply to Lisette Scheer from comment #1) > This would also be helpful for consortiums as we could group library groups > together. It might even be nice to give the option of using a library group > as part of the sort/and maybe as a heading for those branches. > > Lisette Agree with this, an option to allow the sorting by library branch on the OPAC would be really useful for large consortiums, and the ability to group libraries from the same organisation together on the list would be helpful during user inductions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 11:10:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 09:10:31 +0000 Subject: [Koha-bugs] [Bug 33197] Terminology: rename GDPR_Policy system preference In-Reply-To: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33197-70-G2Lubr989q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33197 --- Comment #9 from Aude Charillon <aude.charillon at ptfs-europe.com> --- I don't understand what's happening under the surface, so can only comment on what goes on above :-D I disagree with the idea that the sys pref not mentioning GDPR will hamper librarians. There are several other system preferences that are useful for data protection compliance, and they don't mention GDPR. I would expect librarians wanting to enhance their data protection practices to look for anything related to patrons, privacy and security; if they only look for GDPR surely they're already missing tons of things!? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 12:21:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 10:21:52 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-esLIdLLK51@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #68 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Jonathan Druart from comment #67) > (In reply to Martin Renvoize from comment #62) > > Backported for release in 22.11.04 > > Did you ask Mason to adjust the pkg workflow to embed the css and js files? Community packages are all working as expected here.. I presume your building your own Aliesha.. in which case the core thing is to ensure you run the build-resources.PL script as part of your package building process.. that will compile the CSS and JS resources for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 13:18:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 11:18:32 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-MkcEaHqjfh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 13:18:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 11:18:34 +0000 Subject: [Koha-bugs] [Bug 33607] Show framework on record details page In-Reply-To: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33607-70-sVgM0dDkIq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150212|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150238&action=edit Bug 33607: Add framework display to staff details page This patch adds a Frameworks pluing to allow fetching the framework text and displays this on the intranet details page To test: 1 - Apply patch 2 - View a record details page in staff 3 - Confirm you see the framework name 4 - prove -v t/db_dependent/Template/Plugin/Frameworks.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 14:29:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 12:29:22 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-tQQchUBUpr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- Hi Lucas. While this works, I'm getting this behavour: 1. When clicking on 'Claim returned' button, I get a spinning icon in place of the button and an error in the web developer console: Uncaught TypeError: value.match is not a function. 2. Even though the button is pressed just once, there are two entries in the Details section under the claims tab - in the Check out section claims tab it only appears once. This was tested using Firefox. David Testing notes (using KTD): 1. To set up claims to work: set system preference ClaimReturnedLostValue to 1 2. From a patron's checkout list, Check out > Checkouts tab - click on the Claim returned button in the return claims column: - Get spinning icon in place of the button - In the web developer tools console: Uncaught TypeError: value.match is not a function -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 14:51:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 12:51:04 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-5iWh2YfnT1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150239&action=edit Bug 32250: (follow-up) Remove use of AutoCommit=0 This patch moves to using txn_begin and txn_commit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 15:23:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 13:23:25 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16122-70-T1Vec1LEWx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #28 from Andrew Fuerste-Henry <andrewfh at dubcolib.org> --- FYI, I filed bug 32440 suggesting cleanup_database get enhanced to allow selective deletion from statistics based on type. Right now (per bug 19008) cleanup_database can delete all statistics entries older than a specified interval, but it makes sense to me to allow an additional constraint based on statistics.type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 16:00:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 14:00:26 +0000 Subject: [Koha-bugs] [Bug 16122] Item record needs to keep Local Use count In-Reply-To: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16122-70-pGEwEoWrx4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #29 from Lucas Gass <lucas at bywatersolutions.com> --- Christopher, Thanks for you sign-off! I do need to reset this one to ASSIGNED as it still needs some work. -Unit tests -Need to figure out what to do about the existing data in the stats table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 16:50:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 14:50:33 +0000 Subject: [Koha-bugs] [Bug 33590] Select all/Clear all links on serial collection page are broken In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-FR4vYn8TXb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Slava Shishkin <slavashishkin at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slavashishkin at gmail.com Assignee|koha-bugs at lists.koha-commun |slavashishkin at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 16:52:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 14:52:12 +0000 Subject: [Koha-bugs] [Bug 33590] Select all/Clear all links on many pages are broken In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-AY8kl2mjw1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Slava Shishkin <slavashishkin at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Select all/Clear all links |Select all/Clear all links |on serial collection page |on many pages are broken |are broken | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:01:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:01:44 +0000 Subject: [Koha-bugs] [Bug 33590] Select all/Clear all links on many pages are broken In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-l3L83gqp3N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #1 from Slava Shishkin <slavashishkin at gmail.com> --- I found the same issues on another page – /cgi-bin/koha/circ/article-requests.pl It is possible that problems occur on other pages where wrappers have been applied. I will check and prepare a correction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:03:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:03:29 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-zvtoUFTziH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:04:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:04:15 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-OZCcwjW0Xr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #105 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 150240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150240&action=edit Bug 12532: Send email to guarantee and guarantor This patch allows guarantors to receive emails sended to their guarentees. This patch is a rebase of the previous patches. I took all the content of previous commit and put it in one commit. TO TEST: Before applying: 1) Search, or create, a patron with guarantor. 2) For both guarantors and guarantees: - Add an email address - Update the 'Patron messaging preferences' section so that an email is sent for item checkouts 3) Checkout an item. An email should be sent only to the guarantee. 4) Apply the patch. 5) Run updatedatabase.pl 6) Run prove t/db_dependent/Members.t and prove t/db_dependent/Letters.t 7) Enable 'RedirectGuaranteeEmail' 8) Run misc/cronjobs/process_message_queue.pl 9) Notice that the email should be sended to both the guarantee AND the guarantor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:07:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:07:23 +0000 Subject: [Koha-bugs] [Bug 33616] New: JavaScript error in when using claims return button in checkout table Message-ID: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33616 Bug ID: 33616 Summary: JavaScript error in when using claims return button in checkout table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1. Set ClaimReturnedLostValue to a LOST value 2. Check out an item to a patron. 3. Click the Claim returned button within the checkout table. 4. Get spinning icon in place of the button 5. In the web developer tools console: Uncaught TypeError: value.match is not a function Looks like this is coming from includes/js-date-format.inc: 46 if ( ! value.match(/^\d{4}-\d{2}-\d{2}$/ ) ) { 47 m = m.tz(tz); 48 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:08:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:08:14 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-klAseV4v5I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- David, I see that too! It looks like it is happening with or without this patch. I filed a seperate bug for it: Bug 33616 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:08:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:08:25 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9525-70-OCejeQ6of0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:08:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:08:28 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9525-70-wFDQJADy0R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143740|0 |1 is obsolete| | Attachment #143741|0 |1 is obsolete| | Attachment #143742|0 |1 is obsolete| | Attachment #143743|0 |1 is obsolete| | --- Comment #64 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150241&action=edit Bug 9525: Add ft_local_float_group column This patch adds new ft_local_float_group column to library_groups table. To test: 1. Apply patch and update database 2. Confirm new column is added correctly to the library_groups table Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha at gmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:08:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:08:31 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9525-70-i4UktwL1H0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #65 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150242&action=edit Bug 9525: Add option to define float groups and rules for float Bug 22284 introduced ability to create hold groups. We should have ability to create float groups in same manner. This patch adds checkbox "Is local float group" to group creation feature and new return policy "Item floats by librarygroup". To test: 1. Add new float group and some libraries to it. 2. From circulation and fine rules, set default return policy as "Item floats by library group". 3. Check out an item for a patron. 4. Set library as one that belongs in the same float group. 5. Check in the item. => Observe that notice for transfer doesn't pop up. 6. Check out again. 7. This time set library as one that doen's belong in the same float group. 8. Check in. => Observe that notice for transfer pops up. Experiment this feature by changing return policy per library, item type etc. Also prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha at gmail.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:08:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:08:33 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9525-70-D9BzMs8Ccp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #66 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150243&action=edit Bug 9525: Fix tests To test prove t/db_dependent/Koha/Libraries.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:08:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:08:36 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9525-70-o5KyKaSnC2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #67 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150244&action=edit Bug 9525: DO NOT PUSH! Schema update Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:08:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:08:39 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9525-70-H6oNuG3GM9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #68 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150245&action=edit Bug 9525: (QA follow-up) Fix QA complaints Add boolean to schema Remove stray console.log Fix subroutine name in POD Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:08:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:08:42 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9525-70-hWr7GPBt3v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #69 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150246&action=edit Bug 9525: (QA follow-up) Clarify how float groups are selected in circulation rules Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:08:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:08:54 +0000 Subject: [Koha-bugs] [Bug 2646] Add sort option for the series number In-Reply-To: <bug-2646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2646-70-yRHOB0P9Yd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2646 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #3 from George Williams (NEKLS) <george at nekls.org> --- (In reply to Christopher Brannon from comment #2) > (In reply to slmontesdeoca from comment #1) > > Being able to sort series by volume number would be extremely helpful. > > However, doing so shouldn't be confined to the 440 $v, but also 8XX $v. > > What about the 490v? I, too, would like to see progress on this. > Particularly when you click on a series link, that should default to a > specific order. Would love to see more interest and movement on this. This > bug is quite old. At the time that nengard at gmail.com sent the e-mail this bug is based on, the 440 fields were still in use. The Marc standard change that moved the 440 data to 490 happened shortly after that e-mail was sent in September of 2008. Being able to sort by the 490$v would be an awesome addition to Koha. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:09:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:09:45 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9525-70-IMCnTLEv2f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #70 from Nick Clemens <nick at bywatersolutions.com> --- I had been testing this on a branch, minor rebase to make apply. All works well, added one patch to clarify how groups are searched, and addressed some simple QA complaints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:09:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:09:50 +0000 Subject: [Koha-bugs] [Bug 9525] Add option to define float groups and rules for float In-Reply-To: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9525-70-aUR9ltp7Fh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle at bywatersolutions.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:19:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:19:30 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-M3RFm1OzYO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #18 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Philip Orr from comment #17) > If you then don't click on "New batch record modification" and instead use > the back button in Firefox to go back one page, you will land in batch > record modification with Authority records selected but with the tab "Select > a list of records" now again displayed and usable. This is an existing bug not caused by my patch. I would ask that this one be covered in another bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:24:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:24:50 +0000 Subject: [Koha-bugs] [Bug 33616] JavaScript error in when using claims return button in checkout table In-Reply-To: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33616-70-qCGheJ2nBu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33616 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- match() matches a string against a regular expression. We need to make sure the value passed is a string. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:26:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:26:19 +0000 Subject: [Koha-bugs] [Bug 33363] More specific permissions for purchase suggestions In-Reply-To: <bug-33363-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33363-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33363-70-mG2qRWf9Ic@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150247&action=edit Bug 33363: Add separate permissions for creating and deleting suggestions There are a number of libraries that would like for their staff to be able to submit (and view existing) purchase suggestions from the borrower record, but not give the staff the ability to edit/manage/delete purchase suggestions. Test Plan: 1) Apply this patch 2) Run restart all the things! 3) Run updatedatabase 4) Verify anyone with the suggestions manage permissions now has the create and delete permissions as well 5) Verify anyone without the suggestions manage permission has not recieved the new permissions 6) Enable only the create permission for a librarian 7) Verify that librarian can only create new suggestions ( not manage or delete ) 8) Enable only the manage permission for a librarian 9) Verify that librarian can only manage existing suggestions ( not create or delete ) 10) Enable only the delete permission for a librarian 11) Verify that librarian can only delete suggestions ( not create or manage ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:29:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:29:43 +0000 Subject: [Koha-bugs] [Bug 33363] More specific permissions for purchase suggestions In-Reply-To: <bug-33363-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33363-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33363-70-Ku3YSjxppt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:30:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:30:33 +0000 Subject: [Koha-bugs] [Bug 33616] JavaScript error in when using claims return button in checkout table In-Reply-To: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33616-70-ht1ppF44MW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33616 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:30:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:30:35 +0000 Subject: [Koha-bugs] [Bug 33616] JavaScript error in when using claims return button in checkout table In-Reply-To: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33616-70-LI5OXYRIBE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33616 --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150248&action=edit Bug 33616: Make sure match() is evaluated against a string To Test: 1. Set ClaimReturnedLostValue to a LOST value 2. Check out an item to a patron. 3. Click the Claim returned button within the checkout table. 4. Get spinning icon in place of the button 5. In the web developer tools console: Uncaught TypeError: value.match is not a function 6. Apply patch 7. Try 2 - 3 again. This time the spinning icon should turn into a grey button with the correct date. 8. There should no longer be a console error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:30:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:30:51 +0000 Subject: [Koha-bugs] [Bug 33616] JavaScript error in when using claims return button in checkout table In-Reply-To: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33616-70-wGXCdKFN5z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33616 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:31:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:31:07 +0000 Subject: [Koha-bugs] [Bug 33617] New: Items in cart location still need to show permanent location on search.pl Message-ID: <bug-33617-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33617 Bug ID: 33617 Summary: Items in cart location still need to show permanent location on search.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org The search.pl page shows results for items, but only shows the cart location, if used, for the item location. Librarians want a quick way to locate items, and removing the permanent location forces librarians to click into records to see the permanent location. Cart locations should show next to the permanent location, either emphasized or in parenthesis. But wherever a shelf location is shown, permanent location should always show, and the cart location should be added to it in some discernable way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:32:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:32:42 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-19gMw2b6ps@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #106 from Hammat wele <hammat.wele at inlibro.com> --- (In reply to David Nind from comment #104) > However, the tests fail (even though that wasn't included in the test plan) > - they passed before applying the patch. I've added some fixes, the system preferences AutoEmailPrimaryAddress no more exist it was renamed to EmailFieldPrimary. Thanks for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:44:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:44:30 +0000 Subject: [Koha-bugs] [Bug 33599] Use template wrapper for breadcrumbs: Various In-Reply-To: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33599-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33599-70-Lugc04Lw5a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33599 --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Lucas Gass from comment #6) > -Edit request > -Confirm request > -Place request with partner libraries > -Edit item metadata These are all handled in the same template, but the existing breadcrumbs (in master) don't cover those cases. This could be addressed in another patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:46:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:46:53 +0000 Subject: [Koha-bugs] [Bug 33618] New: Borrowernumbers, Itemnumbers, and Biblionumbers should be readily available Message-ID: <bug-33618-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33618 Bug ID: 33618 Summary: Borrowernumbers, Itemnumbers, and Biblionumbers should be readily available Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It would be helpful, for those of us working with jQuery, if Borrowernumbers, Itemnumbers, or Biblionumbers were referenced in an attribute wherever these things appear in pages. For example, when doing a search, many bib records appear on search.pl, and with those bib records, many items appear off to the side. The bib records DO have the biblionumber in the url, but we have to work a little harder to get that number from the url. It would be easier if it were referenced in an attribute. However, none of the items referenced in the results have an itemnumber anywhere in the result. The link associated with the item is basically a call number search. It would be very helpful to have an attribute with the itemnumber there. It would be great if any time we were reference a patron, a bib record, or an item, if we could wrap them in a common wrapper, like a span or div, and have a consistent record identifier. This way, if we need to do an API call to grab more info, we have the one thing that would make that so much easier. Maybe something like: <div class="PatronElement" RecordID="BORROWERNUMBER HERE">PATRON STUFF</div> <div class="BiblioElement" RecordID="BIBLIONUMBER HERE">BIB RECORD STUFF</div> <div class="ItemElement" RecordID="ITEMNUMBER HERE">ITEM RECORD STUFF</div> This would be a nice, consistent normalized format that would make life so much easier, in my opinion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 17:58:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 15:58:34 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-Q1BcfhePY8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #24 from Nick Clemens <nick at bywatersolutions.com> --- I didn't do a full run through as I hit a few issues. Must fix: - A patron without permissions cannot save print notices. The current settings need to be included as hidden inputs - The permission doesn't prevent url/form manipulation without the permission. This must be checked in the code. - There is an empty value in the Units dropdown for 'AGATE' Should fix: - The DB fields should be enum if they only support a limited range of values - This reveals an consistency - ISSUESLIP is presented in print format, however, it uses the 'email' template. Possibly the settings can be their own section? Otherwise this needs to be addressed - 'Apply format settings to all notices' - I can see the utility here for initially settings things up - but this seems a bit too powerful. A warning at least would be nice - Even if you cannot edit the settings - it would be useful to view the print formatting so you know what you can see - The new form is added to all notices - but it really only applies to slips if I understand correctly? Does this work with bug 33260 for printing notices from the staff interface? It should be clarified if it does not work with gather_print_notices etc. Could fix: - I don't know that a permission is needed here, if you can edit slips I would assume you can edit this portion too, but I assume there is a motivation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 19:08:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 17:08:46 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-6Q8kp7lZbl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 --- Comment #5 from David Nind <david at davidnind.com> --- (In reply to Lucas Gass from comment #4) > David, > > I see that too! It looks like it is happening with or without this patch. I > filed a seperate bug for it: > > Bug 33616 Thanks Lucas, Sign off for this one coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 19:27:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 17:27:07 +0000 Subject: [Koha-bugs] [Bug 33616] JavaScript error in when using claims return button in checkout table In-Reply-To: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33616-70-JkmSJCBMy4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33616 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 19:27:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 17:27:09 +0000 Subject: [Koha-bugs] [Bug 33616] JavaScript error in when using claims return button in checkout table In-Reply-To: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33616-70-D6TdtIQq13@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33616 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150248|0 |1 is obsolete| | --- Comment #3 from David Nind <david at davidnind.com> --- Created attachment 150249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150249&action=edit Bug 33616: Make sure match() is evaluated against a string To Test: 1. Set ClaimReturnedLostValue to a LOST value 2. Check out an item to a patron. 3. Click the Claim returned button within the checkout table. 4. Get spinning icon in place of the button 5. In the web developer tools console: Uncaught TypeError: value.match is not a function 6. Apply patch 7. Try 2 - 3 again. This time the spinning icon should turn into a grey button with the correct date. 8. There should no longer be a console error. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 19:33:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 17:33:20 +0000 Subject: [Koha-bugs] [Bug 33430] Suggestions.pl with several hundred items causes a slow loading screen In-Reply-To: <bug-33430-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33430-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33430-70-Ln7zgwO3yp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Ultimately these tables probably need to be coming for the REST API? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 19:40:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 17:40:21 +0000 Subject: [Koha-bugs] [Bug 33590] Select all/Clear all links on many pages are broken In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-NpYMY8AqWe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #2 from Slava Shishkin <slavashishkin at gmail.com> --- Created attachment 150250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150250&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to article-requests.tt This commit fixed two cases: 1. Fixing "Select all" and "Clear all" links on the page. 2. Fixing the interaction with selected entries when switching between the "New" and "Pending" tabs. To test: (Create article requests if they don't exist) Case 1: 1. Go to /cgi-bin/koha/circ/article-requests.pl and don't switch between tabs. 2. Click on "Select all" and verify that it's not working -- the checkboxes are not selected. 3. Activate any checkbox and click "Clear all" -- the checkbox is not cleared. 4. Apply the patch. 5. Restart the page and, without switching between tabs, repeat steps 2 and 3. Verify that it works now. Case 2: 1. Go to /cgi-bin/koha/circ/article-requests.pl. 2. Switch between tabs and leave "New" active. 3. Select any entry and delete or move it to another tab. 4. Verify that the entry remains in the table until the page reloads. 5. Apply the patch. 6. Restart the page and repeat steps 2 and 3. Make sure that everything works now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 19:40:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 17:40:24 +0000 Subject: [Koha-bugs] [Bug 33590] Select all/Clear all links on many pages are broken In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-m3C81ppX7t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #3 from Slava Shishkin <slavashishkin at gmail.com> --- Created attachment 150251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150251&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to serials-collection.tt To test: * Add a subscription * From the subscription detail page, click on serial collection link in left hand navigation * Create some additional issues * "Clear all" link for selecting issues to edit won't work, "Select all" link neither * Apply the patch * * "Clear all" link for selecting issues to edit works now, "Select all" link works too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 19:42:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 17:42:43 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-mMiBl8TBJU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 19:42:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 17:42:46 +0000 Subject: [Koha-bugs] [Bug 33613] Claim return doesn't charge when "Ask if a lost fee should be charged" is selected and marked to charge In-Reply-To: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33613-70-9OjmeRgHbU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33613 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150237|0 |1 is obsolete| | --- Comment #6 from David Nind <david at davidnind.com> --- Created attachment 150252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150252&action=edit Bug 33613: Use prop() to evaluate checkbox To test: 1. Have an item with a replacement cost checked out to a patron 2. Set the ClaimReturnedChargeFee sys pref to "Ask if a lost fee should be charged" 3. Make a claim and check the box for charging. 4. Claim happens but no charge occurs. 5. Apply patch and try again. 6. A charge should now occur. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 19:49:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 17:49:54 +0000 Subject: [Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes In-Reply-To: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21083-70-eGdSCShjvg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 20:13:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 18:13:17 +0000 Subject: [Koha-bugs] [Bug 13015] AdvancedSearchLanguages doesn't support all language codes In-Reply-To: <bug-13015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13015-70-mJJAL5gnQa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13015 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |nick at bywatersolutions.com Status|NEW |RESOLVED --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 12250 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 20:13:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 18:13:17 +0000 Subject: [Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions In-Reply-To: <bug-12250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12250-70-NxgaJBESHJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- *** Bug 13015 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 20:14:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 18:14:39 +0000 Subject: [Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType In-Reply-To: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33176-70-Ns4DrOhtYx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david at davidnind.com --- Comment #5 from David Nind <david at davidnind.com> --- Hi Lucas. I get an error trace after applying the patch and repeating the steps. The payment is recorded. The start of the error trace: Exception 'Koha::Exceptions::Account::PaymentTypeRequired' thrown 'Account transaction requires a payment type' at /usr/share/perl5/Exception/Class/Base.pm line 88 in Exception::Class::Base::throw at /usr/share/perl5/Exception/Class/Base.pm line 88 85: 86: $proto->rethrow if ref $proto; 87: 88: die $proto->new(@_); 89: } 90: 91: sub rethrow { Show function arguments in Koha::Account::pay at /kohadevbox/koha/Koha/Account.pm line 105 .... David Testing notes (using KTD): 1. Editing the page HTML using Firefox: - Right click on the payment type label - Select 'Inspect' - In the web development tools window that opens, select <select name="payment_type" id="payment_type" class="required" required="required">, right click, and then select 'Edit HTML' - Remove: class="required" required="required" - Click on the Submit button in the page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 20:18:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 18:18:47 +0000 Subject: [Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType In-Reply-To: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33176-70-nnnblBfId8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to David Nind from comment #5) > Hi Lucas. > > I get an error trace after applying the patch and repeating the steps. The > payment is recorded. The start of the error trace: > > Exception 'Koha::Exceptions::Account::PaymentTypeRequired' thrown 'Account > transaction requires a payment type' > at /usr/share/perl5/Exception/Class/Base.pm line 88 > > in Exception::Class::Base::throw at > /usr/share/perl5/Exception/Class/Base.pm line 88 > > 85: > 86: $proto->rethrow if ref $proto; > 87: > 88: die $proto->new(@_); > 89: } > 90: > 91: sub rethrow { > > Show function arguments > in Koha::Account::pay at /kohadevbox/koha/Koha/Account.pm line 105 > .... > > David > > Testing notes (using KTD): > > 1. Editing the page HTML using Firefox: > - Right click on the payment type label > - Select 'Inspect' > - In the web development tools window that opens, select <select > name="payment_type" id="payment_type" class="required" required="required">, > right click, and then select 'Edit HTML' > - Remove: class="required" required="required" > - Click on the Submit button in the page David, if this is happening after you remove class="required" required="required" it is the desired behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 20:26:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 18:26:29 +0000 Subject: [Koha-bugs] [Bug 33612] Staff with limited permissions don't always get an expanded catalog_search bar In-Reply-To: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33612-70-BIesijVwGy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 20:26:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 18:26:31 +0000 Subject: [Koha-bugs] [Bug 33612] Staff with limited permissions don't always get an expanded catalog_search bar In-Reply-To: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33612-70-WI3Yg80D42@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150225|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 150253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150253&action=edit Bug 33612: Fix cat-search.inc and remove home-search.inc To test: 1. Setup a staff member with staff access permission but no circulate permissions. 2. Log in as that and on the intranet-home page notice that 'Search patron' bar across the top is not visible by default. 3. Click the 'Search patrons' link at the top, now you see the search bar. 4. This is also true on the item search page. 5. Apply patch 6. Try looking at the intranet home and item search pages again, the search bar should be expanded by default. 7. git grep 'home-search.inc' , this include should be gone along with all references to it. 8. Log in as a superlibrarian and make sure the top search bars still seem correct and default to the correct ones. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 20:27:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 18:27:29 +0000 Subject: [Koha-bugs] [Bug 33612] Staff with limited permissions don't always get an expanded catalog_search bar In-Reply-To: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33612-70-sISXAYi3zY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- I amended the commit message to remove the incorrect Bugzilla link at the bottom. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 20:34:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 18:34:21 +0000 Subject: [Koha-bugs] [Bug 2646] Add sort option for the series number In-Reply-To: <bug-2646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2646-70-yGDcsoIKB9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2646 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 21:01:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 19:01:44 +0000 Subject: [Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType In-Reply-To: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33176-70-msc7UY8E9i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 21:01:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 19:01:47 +0000 Subject: [Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType In-Reply-To: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33176-70-P2thNmOmAC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149617|0 |1 is obsolete| | --- Comment #7 from David Nind <david at davidnind.com> --- Created attachment 150254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150254&action=edit Bug 33176: Handle RequirePaymentType Test plan: 1. Turn on RequirePaymentType 2. Create a manual invocie on a patron account 3. Go to pay it, 'Payment type:' is marked as required. 4. In the inscept the select input ( #payment_type ) with your browser's dev tools. Removed the required attribute. 5. You are able to make the payment without a payment type. 6. Apply patch and restart_all 7. Try 4-5 again. This time you should get a 500 error and the payment should not go through. 8. Turn RequirePaymentType off. Try a payment with a payment type, you shoud be successful. 9. Make sure tests will pass: prove -v t/db_dependent/Koha/Account.t Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 21:01:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 19:01:49 +0000 Subject: [Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType In-Reply-To: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33176-70-0jeOn9RWST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149619|0 |1 is obsolete| | --- Comment #8 from David Nind <david at davidnind.com> --- Created attachment 150255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150255&action=edit Bug 33176: Enforce RequirePaymentType with API Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 21:18:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 19:18:35 +0000 Subject: [Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType In-Reply-To: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33176-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33176-70-zrD4BMOC0f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 --- Comment #9 from David Nind <david at davidnind.com> --- Updated testing notes (using KTD): 1. For step 4, editing the page HTML using Firefox: - Right click on the payment type label - Select 'Inspect' - In the web development tools window that opens, select <select name="payment_type" id="payment_type" class="required" required="required">, right click, and then select 'Edit HTML' - Remove: class="required" required="required" - Click on the Submit button in the page - Note: If you just remove 'required="required"', a standard form error message is displayed saying this is required 2. For step 7, when editing the HTML just remove: required="required" - If you remove 'class="required" required="required"', you will get an error trace and the payment will be recorded (as expected - see comment #6) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 21:25:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 19:25:40 +0000 Subject: [Koha-bugs] [Bug 33612] Staff with limited permissions don't always get an expanded catalog_search bar In-Reply-To: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33612-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33612-70-n8aIfva7hj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to David Nind from comment #3) > I amended the commit message to remove the incorrect Bugzilla link at the > bottom. Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 21:34:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 19:34:51 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-baLeSEJONh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 21:34:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 19:34:55 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-DLIkjroWaO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150240|0 |1 is obsolete| | --- Comment #107 from David Nind <david at davidnind.com> --- Created attachment 150256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150256&action=edit Bug 12532: Send email to guarantee and guarantor This patch allows guarantors to receive emails sended to their guarentees. This patch is a rebase of the previous patches. I took all the content of previous commit and put it in one commit. TO TEST: Before applying: 1) Search, or create, a patron with guarantor. 2) For both guarantors and guarantees: - Add an email address - Update the 'Patron messaging preferences' section so that an email is sent for item checkouts 3) Checkout an item. An email should be sent only to the guarantee. 4) Apply the patch. 5) Run updatedatabase.pl 6) Run prove t/db_dependent/Members.t and prove t/db_dependent/Letters.t 7) Enable 'RedirectGuaranteeEmail' 8) Run misc/cronjobs/process_message_queue.pl 9) Notice that the email should be sended to both the guarantee AND the guarantor. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 21:36:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 19:36:11 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-6YYp09wXwZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #108 from David Nind <david at davidnind.com> --- (In reply to Hammat wele from comment #106) > (In reply to David Nind from comment #104) > > However, the tests fail (even though that wasn't included in the test plan) > > - they passed before applying the patch. > > I've added some fixes, the system preferences AutoEmailPrimaryAddress no > more exist it was renamed to EmailFieldPrimary. > > Thanks for testing Thanks for fixing these - everything is now working. Good luck with the QA! You may also wish to update the assignee for the bug to yourself. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 21:44:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 19:44:06 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12532-70-aQIQjWKZPk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|charles.farmer at inlibro.com |hammat.wele at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 21:50:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 19:50:44 +0000 Subject: [Koha-bugs] [Bug 33619] New: the "update sql" window isn't showing obsolete fields and their new names. Message-ID: <bug-33619-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33619 Bug ID: 33619 Summary: the "update sql" window isn't showing obsolete fields and their new names. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: marie-luce.laflamme at inlibro.com QA Contact: testopia at bugs.koha-community.org The “update sql” button of an obsolete report has stopped describing fields that need to be fixed. If your report still contains a biblioitems.marcxml field, Koha will warn with a “This report seems obsolete” message. Then, you can click on the “update sql” button to fix the report, and Koha will open up a popup window. Unfortunately, this window is no longer showing obsolete fields and their new names. Instead, there is only a loading cursor on display without any explanations. At this point, you aren't sure if you can click on the "update" button within the window, thinking it may be broken. But if you try, Koha will update the report correctly. Is there a way to bring back the previous version behaviour in this window? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 21:54:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 19:54:51 +0000 Subject: [Koha-bugs] [Bug 33619] the "update sql" window isn't showing obsolete fields and their new names. In-Reply-To: <bug-33619-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33619-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33619-70-Mer6A7hyjS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33619 --- Comment #1 from Marie-Luce Laflamme <marie-luce.laflamme at inlibro.com> --- Test plan 1. Add a report that contains a biblioitems.marcxml field (e.g. ExtractValue(marcxml,'//datafield[@tag="245"]/@ind2') tinyurl.com/2ky73zhr ) 2. Go back to the saved reports page and find the new report /cgi-bin/koha/reports/guided_reports.pl?phase=Use saved 3. Click on "update sql" --> Koha will open up a popup window that shows an endless loading cursor without any information about what need to be fixed in the report. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 22:02:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 20:02:04 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-reYMkwqU6k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #8 from David Nind <david at davidnind.com> --- Hi Caroline. Your rebase worked, as I was able to successfully apply the patch! Some minor things I noted when testing: 1. Administration page: There is a full stop at the end of the description. No other administration menu options on the administration have this. 2. Page title when modifying and deleting a restriction type: in the page title that shows in the browser tab, the <span> tag is visible and has ' either side of it. For example: Modify restriction type '<span>Test patron restriction type</span>' > Patron restriction types > Administration > Koha. Note that this was the case before the patch was applied. 3. Breadcrumb when deleting a restriction type: I'm not sure I've have seen a question mark in breadcrumbs before, except for this one (although I haven't looked very hard). Maybe the breadcrumb should be "Confirm restriction type deletion", to match the page title. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 22:11:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 20:11:39 +0000 Subject: [Koha-bugs] [Bug 33619] the "update sql" window isn't showing obsolete fields and their new names. In-Reply-To: <bug-33619-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33619-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33619-70-INebtku6B5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33619 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 22:54:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 20:54:46 +0000 Subject: [Koha-bugs] [Bug 33620] New: Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowerRelationship is empty Message-ID: <bug-33620-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Bug ID: 33620 Summary: Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowerRelationship is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On the patron detail screen there are two list items: -Show checkouts to guarantor -Show charges to guarantor I end up hiding these with CSS often. It would be better if these simply did not show if borrowerRelationship is empty. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 22:58:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 20:58:40 +0000 Subject: [Koha-bugs] [Bug 33620] Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowerRelationship is empty In-Reply-To: <bug-33620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33620-70-ZR0RZhyp07@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 22:58:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 20:58:42 +0000 Subject: [Koha-bugs] [Bug 33620] Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowerRelationship is empty In-Reply-To: <bug-33620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33620-70-9IT9Jm0wqp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150257&action=edit Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty To test: 1. Apply patch 2. Have some values in borrowerRelationship. 3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:' 4. Now empty borrowerRelationship. 5. Visit the patron detail page again and you should no longer see either of those fields. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 22:58:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 20:58:54 +0000 Subject: [Koha-bugs] [Bug 33620] Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowerRelationship is empty In-Reply-To: <bug-33620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33620-70-5JqDF81RC8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 26 23:26:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 21:26:02 +0000 Subject: [Koha-bugs] [Bug 33484] Generalise table saveState for all tables In-Reply-To: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33484-70-HlCfPQDo57@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 --- Comment #31 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> --- I wrote up a test plan to keep myself organized while testing different tables and states...sharing in case someone else gets to it before me and would like to use it. (also open to feedback :) ) Considerations: - test a variety of tables - must include both tables that use KohaTable (column_settings.inc) and kohaTable (datatables.js) For reference: tables that use kohaTable (based on a git grep): - patron search (patrons_table) - acqui/parcel.tt (pending_orders) - admin/background_jobs.tt (table_jobs) - admin/branches.tt (libraries) - admin/cities.tt (table_cities) - admin/identity_provider_domains.tt (identity_provider_domains) - admin/identity_providers.tt (identity_providers) - admin/search_filters.tt (search_filters_table) - admin/smtp_servers.tt (smtp_servers) - catalogue/detail.tt (table_concerns) - catalogue/detail.tt (bundle_table) - cataloguing/concerns.tt (table_concerns) - pos/register.tt (table_cashups) - tools/quotes.tt (quotes) Test plan per table: 1. Edit the config to hide some columns and disable "save state" 2. Test that the "clean" page matches the config settings 3. Make some client-side changes a. Hide one or more showing columns b. Show one or more hidden columns c. Change number of results to display d. Add a search filter 4. Navigate away from that page and back 5. Confirm that the state was not saved and the page matches the config settings 6. Navigate away from that page 7. Edit the config to enable "save state" 8. Return to the page and confirm that it matches the config settings 9. Make some client-side changes a. Hide one or more showing columns b. Show one or more hidden columns c. Change number of results to display d. Add a search filter 10. Navigate away from the page and back 11. Confirm that all of the changes were retained -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 00:10:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 22:10:37 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-w72WKFCCpi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- > 2. Page title when modifying and deleting a restriction type: in the page > title that shows in the browser tab, the <span> tag is visible and has ' > either side of it. For example: Modify restriction type '<span>Test patron > restriction type</span>' > > Patron restriction types > Administration > Koha. Note that this was the > case before the patch was applied. I believe this problem is fixed in Bug 33551. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:02:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:02:39 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-hBmol6a8Qm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #69 from Aleisha Amohia <aleisha at catalyst.net.nz> --- (In reply to Martin Renvoize from comment #68) > (In reply to Jonathan Druart from comment #67) > > (In reply to Martin Renvoize from comment #62) > > > Backported for release in 22.11.04 > > > > Did you ask Mason to adjust the pkg workflow to embed the css and js files? > > Community packages are all working as expected here.. I presume your > building your own Aliesha.. in which case the core thing is to ensure you > run the build-resources.PL script as part of your package building process.. > that will compile the CSS and JS resources for you. Hey, nope, this problem is occurring for our libraries installing stock Koha from the community tag, so not building the packages ourselves $ apt-cache policy koha-common koha-common: Installed: 22.11.04-1 Candidate: 22.11.04-1 Version table: *** 22.11.04-1 500 500 http://debian.koha-community.org/koha 22.11/main amd64 Packages 100 /var/lib/dpkg/status How can I run the build-resources.PL script please? Couldn't see any documentation on the Community wiki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:03:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:03:42 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-MUXz6592Lt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #70 from David Cook <dcook at prosentient.com.au> --- (In reply to Martin Renvoize from comment #68) > Community packages are all working as expected here.. I presume your > building your own Aliesha.. in which case the core thing is to ensure you > run the build-resources.PL script as part of your package building process.. > that will compile the CSS and JS resources for you. The Makefile should be running build-resources.PL as per https://gitlab.com/joubu/Koha/-/commit/b64db106e0db41da06fbf72f1674b2ed43b3f76d If the overall process was failing, I think Aleisha would have different symptoms. The issue she's having might be unrelated to this change but won't know without more information (provided either by Aleisha or someone else investigating). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:05:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:05:03 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-hiYMA0Vk8W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #71 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #70) > If the overall process was failing, I think Aleisha would have different > symptoms. The issue she's having might be unrelated to this change but won't > know without more information (provided either by Aleisha or someone else > investigating). Actually, on that note, I think Aleisha should probably open a separate bug report for the issues she's facing and do a "See Also" to this one in case it's related. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:06:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:06:48 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-SjJhkEQGoQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #72 from Aleisha Amohia <aleisha at catalyst.net.nz> --- (In reply to David Cook from comment #71) > (In reply to David Cook from comment #70) > > If the overall process was failing, I think Aleisha would have different > > symptoms. The issue she's having might be unrelated to this change but won't > > know without more information (provided either by Aleisha or someone else > > investigating). > > Actually, on that note, I think Aleisha should probably open a separate bug > report for the issues she's facing and do a "See Also" to this one in case > it's related. Will do. I did a git bisect to narrow down the commit where we stopped seeing things we expected to see but there could be something else at play in the packaging process or other. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:08:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:08:37 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-GW3IxyvVK3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #73 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- As I posted on the koha-devel list: " Kyle and I have been working on this: https://gitlab.com/koha-community/koha-dpkg-docker#usage which is a simple way to build packages, and considers that required step. Hope it helps. " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:10:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:10:05 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-IYsqqCT8dV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33551 --- Comment #10 from David Nind <david at davidnind.com> --- (In reply to Lucas Gass from comment #9) > > 2. Page title when modifying and deleting a restriction type: in the page > > title that shows in the browser tab, the <span> tag is visible and has ' > > either side of it. For example: Modify restriction type '<span>Test patron > > restriction type</span>' > > > Patron restriction types > Administration > Koha. Note that this was the > > case before the patch was applied. > > I believe this problem is fixed in Bug 33551. Thanks Lucas for identifying that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:10:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:10:05 +0000 Subject: [Koha-bugs] [Bug 33551] Rogue span in patron restriction types admin page title In-Reply-To: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33551-70-SFafOgDCN5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33551 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33550 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:13:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:13:16 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-foERcfA5c5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #74 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Thank you TomĂĄs but as I said, we aren't building our own packages. It is community packages that we get this problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:13:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:13:59 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-N8yqUfpGra@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #75 from David Cook <dcook at prosentient.com.au> --- (In reply to TomĂĄs Cohen Arazi from comment #73) > As I posted on the koha-devel list: > > " > Kyle and I have been working on this: > > https://gitlab.com/koha-community/koha-dpkg-docker#usage > > which is a simple way to build packages, and considers that required step. > > Hope it helps. > " Could we get more details on why you did it that way? It should be unnecessary... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:15:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:15:00 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-z7fIdcE2xI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #76 from David Cook <dcook at prosentient.com.au> --- (In reply to Aleisha Amohia from comment #74) > Thank you TomĂĄs but as I said, we aren't building our own packages. It is > community packages that we get this problem It looks like there are some demo boxes on 22.11 so I'm happy to help Aleisha out with this one (on a separate bug report). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:22:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:22:13 +0000 Subject: [Koha-bugs] [Bug 33621] New: Some JS and CSS problems since 22.11.04 Message-ID: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Bug ID: 33621 Summary: Some JS and CSS problems since 22.11.04 Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We've noticed some interesting problems since upgrading to 22.11.04 that seem related to CSS and JS not compiling or being access correctly. Examples that have been reported: - the calendar icon that shows in the flatpickr text input fields does not show to reproduce: go to add or edit an item under a biblio. the date acquired field uses the flatpickr date picker, but the calendar icon that usually shows inside the input field on the left is invisible. - making return claims on the checkouts page shows the 'loading' icon forever, have to refresh the page to show the claim to reproduce: set the ClaimReturnedLostValue system preference. check out an item, then do a return claim. once the button is clicked, it looks like it keeps loading or processing until you refresh the page Any advice would be appreciated Thanks Aleisha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:22:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:22:30 +0000 Subject: [Koha-bugs] [Bug 33621] Some JS and CSS problems since 22.11.04 In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-8riugLW4jj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32609 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:22:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:22:30 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-5jVG7j3t5p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33621 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:22:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:22:45 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-C9tcQxArMl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #77 from Aleisha Amohia <aleisha at catalyst.net.nz> --- (In reply to David Cook from comment #76) > (In reply to Aleisha Amohia from comment #74) > > Thank you TomĂĄs but as I said, we aren't building our own packages. It is > > community packages that we get this problem > > It looks like there are some demo boxes on 22.11 so I'm happy to help > Aleisha out with this one (on a separate bug report). Thank you. I've reported Bug 33621 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:43:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:43:15 +0000 Subject: [Koha-bugs] [Bug 33621] Some JS and CSS problems since 22.11.04 In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-MyOhpHmwzp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook <dcook at prosentient.com.au> --- (In reply to Aleisha Amohia from comment #0) > - the calendar icon that shows in the flatpickr text input fields does not > show I decided to look at the calendar icon since it was the easiest thing to look at. It's a SVG which appears to be defined in ./koha-tmpl/opac-tmpl/bootstrap/css/src/_flatpickr.scss When I try to access the SVG in 22.11.04, I get an error page that says: "error on line 1 at column 70: AttValue: ' expected" Comparing between 22.11.03 and 22.11.04, there does seem to be an encoding difference. In 22.11.03: data:image/svg+xml;charset=utf-8,%3Csvg xmlns='http://www.w3.org/2000/svg' width='12' height='12' fill='%23369' class='bi bi-calendar3'%3E%3Cg stroke-width='1.333'%3E%3Cpath d='M10.5 0h-9A1.5 1.5 0 0 0 0 1.5v9A1.5 1.5 0 0 0 1.5 12h9a1.5 1.5 0 0 0 1.5-1.5v-9A1.5 1.5 0 0 0 10.5 0zM.75 2.893c0-.355.336-.643.75-.643h9c.414 0 .75.288.75.643v7.714c0 .355-.336.643-.75.643h-9c-.414 0-.75-.288-.75-.643z'/%3E%3Cpath d='M4.875 5.25a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5zm2.25 0a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5zm2.25 0a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5zM2.625 7.5a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5zm2.25 0a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5zm2.25 0a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5zm2.25 0a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5zm-6.75 2.25a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5zm2.25 0a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5zm2.25 0a.75.75 0 1 0 0-1.5.75.75 0 0 0 0 1.5z'/%3E%3C/g%3E%3C/svg%3E In 22.11.04: data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='12' height='12' fill='#369'%20class='bi%20bi-calendar3'%3E%3Cg%20stroke-width='1.333'%3E%3Cpath%20d='M10.5%200h-9A1.5%201.5%200%200%200%200%201.5v9A1.5%201.5%200%200%200%201.5%2012h9a1.5%201.5%200%200%200%201.5-1.5v-9A1.5%201.5%200%200%200%2010.5%200zM.75%202.893c0-.355.336-.643.75-.643h9c.414%200%20.75.288.75.643v7.714c0%20.355-.336.643-.75.643h-9c-.414%200-.75-.288-.75-.643z'/%3E%3Cpath%20d='M4.875%205.25a.75.75%200%201%200%200-1.5.75.75%200%200%200%200%201.5zm2.25%200a.75.75%200%201%200%200-1.5.75.75%200%200%200%200%201.5zm2.25%200a.75.75%200%201%200%200-1.5.75.75%200%200%200%200%201.5zM2.625%207.5a.75.75%200%201%200%200-1.5.75.75%200%200%200%200%201.5zm2.25%200a.75.75%200%201%200%200-1.5.75.75%200%200%200%200%201.5zm2.25%200a.75.75%200%201%200%200-1.5.75.75%200%200%200%200%201.5zm2.25%200a.75.75%200%201%200%200-1.5.75.75%200%200%200%200%201.5zm-6.75%202.25a.75.75%200%201%200%200-1.5.75.75%200%200%200%200%201.5zm2.25%200a.75.75%200%201%200%200-1.5.75.75%200%200%200%200%201.5zm2.25%200a.75.75%200%201%200%200-1.5.75.75%200%200%200%200%201.5z'/%3E%3C/g%3E%3C/svg%3E -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:48:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:48:13 +0000 Subject: [Koha-bugs] [Bug 33621] Some JS and CSS problems since 22.11.04 In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-sEHxGu2iAZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 --- Comment #2 from David Cook <dcook at prosentient.com.au> --- The problem in 22.11.04 is the hash (ie #) in the fill... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:56:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:56:13 +0000 Subject: [Koha-bugs] [Bug 33621] Some JS and CSS problems since 22.11.04 In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-LIqwGtaVjs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 --- Comment #3 from David Cook <dcook at prosentient.com.au> --- Bug 32978 changed from node-sass to dart-sass. My guess is that is what is encoding the SCSS files differently. I think the fix is probably to change fill='#369' to fill='%23369' in ./koha-tmpl/opac-tmpl/bootstrap/css/src/_flatpickr.scss -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:56:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:56:23 +0000 Subject: [Koha-bugs] [Bug 33621] Some JS and CSS problems since 22.11.04 In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-5p8261PYdL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32978 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32978 [Bug 32978] 'npm install' fails in ktd on aarch64, giving unsupported architecture error for node-sass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 01:56:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Apr 2023 23:56:23 +0000 Subject: [Koha-bugs] [Bug 32978] 'npm install' fails in ktd on aarch64, giving unsupported architecture error for node-sass In-Reply-To: <bug-32978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32978-70-oUVWvgQPi1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32978 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 [Bug 33621] Some JS and CSS problems since 22.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:03:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:03:03 +0000 Subject: [Koha-bugs] [Bug 33621] Some JS and CSS problems since 22.11.04 In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-CY6Yp9kJzh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- (In reply to Aleisha Amohia from comment #0) > to reproduce: set the ClaimReturnedLostValue system preference. check out an > item, then do a return claim. once the button is clicked, it looks like it > keeps loading or processing until you refresh the page There is a Javascript error that shows up in the console: circulation.pl:1365 Uncaught TypeError: value.match is not a function at window.$date (circulation.pl:1365:26) at window.$datetime (circulation.pl:1384:20) at Object.success (circulation.pl:1855:33) at c (jquery-3.6.0.min_22.1104000.js:2:28327) at Object.fireWith [as resolveWith] (jquery-3.6.0.min_22.1104000.js:2:29072) at l (jquery-3.6.0.min_22.1104000.js:2:79901) at XMLHttpRequest.<anonymous> (jquery-3.6.0.min_22.1104000.js:2:82355) It looks like it's just a bug in some Javascript in circulation.pl or with the API /api/v1/return_claims. As often happens in Koha, there isn't enough error checking/handling. I'll leave that one for you to investigate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:03:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:03:56 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-yh3M6NCC9f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 --- Comment #78 from David Cook <dcook at prosentient.com.au> --- (In reply to Aleisha Amohia from comment #77) > Thank you. I've reported Bug 33621 Thanks, Aleisha. It looks like one issue is probably due to bug 32978 and the other looks like a coding bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:14:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:14:53 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-FxzI5WCzb6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Some JS and CSS problems |Javascript error when |since 22.11.04 |claiming return via | |circulation.pl --- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Thanks David, I'll rename this bug report to be about the return claim bug as Bug 33615 was made about the flatpickr icon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:15:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:15:37 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-NcC2ev4Uo0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32609 CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:15:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:15:37 +0000 Subject: [Koha-bugs] [Bug 32609] Remove compiled files from src In-Reply-To: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32609-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32609-70-OynZS3ZPWp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32609 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33615 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:15:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:15:44 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-ogBLAyYv0L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32978 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:15:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:15:44 +0000 Subject: [Koha-bugs] [Bug 32978] 'npm install' fails in ktd on aarch64, giving unsupported architecture error for node-sass In-Reply-To: <bug-32978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32978-70-EBzc2jYOdO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32978 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33615 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:26:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:26:49 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-2j4jGBUsrc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|32978 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32978 [Bug 32978] 'npm install' fails in ktd on aarch64, giving unsupported architecture error for node-sass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:26:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:26:49 +0000 Subject: [Koha-bugs] [Bug 32978] 'npm install' fails in ktd on aarch64, giving unsupported architecture error for node-sass In-Reply-To: <bug-32978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32978-70-LbBZ8ZcR7O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32978 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33621 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 [Bug 33621] Javascript error when claiming return via circulation.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:27:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:27:37 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-0RT0owPRD8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32978 CC| |dcook at prosentient.com.au --- Comment #2 from David Cook <dcook at prosentient.com.au> --- I think bug 32978 might be the root cause of this one. As I noted on bug 33621 it looks like the problem is that a hash (ie #) isn't being encoded when it should be. I think the fix is probably to change fill='#369' to fill='%23369' in ./koha-tmpl/opac-tmpl/bootstrap/css/src/_flatpickr.scss Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32978 [Bug 32978] 'npm install' fails in ktd on aarch64, giving unsupported architecture error for node-sass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:27:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:27:37 +0000 Subject: [Koha-bugs] [Bug 32978] 'npm install' fails in ktd on aarch64, giving unsupported architecture error for node-sass In-Reply-To: <bug-32978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32978-70-xFkIKH3SAM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32978 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33615 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 [Bug 33615] Date picker icon not visible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:27:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:27:46 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-yMdGZr9gSk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:27:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:27:57 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-APgcsSi2FW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 --- Comment #6 from David Cook <dcook at prosentient.com.au> --- (In reply to Aleisha Amohia from comment #5) > Thanks David, I'll rename this bug report to be about the return claim bug > as Bug 33615 was made about the flatpickr icon. Sounds good -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:30:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:30:10 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33259-70-01v8jf6PD4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:30:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:30:13 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33259-70-xPm3n2QcRs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #9 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150259&action=edit Bug 33259: (follow-up) Use different speechmarks to prevent errors To test: Confirm the checkouts table for a patron loads successfully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:53:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:53:33 +0000 Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30687-70-cHd5VUMvyt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 02:53:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 00:53:37 +0000 Subject: [Koha-bugs] [Bug 30687] Unable to override hold policy if no pickup locations are available In-Reply-To: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30687-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30687-70-vpDT2cKJfw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30687 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140712|0 |1 is obsolete| | Attachment #140713|0 |1 is obsolete| | Attachment #144427|0 |1 is obsolete| | Attachment #148502|0 |1 is obsolete| | --- Comment #31 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150260&action=edit Bug 30687: Allow pickup location to be forced when override is allowed This is Julian's patch with some extra cleanup to reduce repeated code If AllowHoldPolicyOverride is enabled and only some pickup locations are available, you still have the possibility to force one of the others pickup locations. But when there are zero pickup locations available, that is not possible. This patch change that by always displaying the list of pickup locations when AllowHoldPolicyOverride is enabled. Test plan: 1. Apply patch 2. Disable AllowHoldPolicyOverride 3. Create a biblio B with an item I at library A. 4. Configure this library A to not be a pickup location 5. Add a "Default holds policy by item type" for item I type where "Hold pickup library match" is "item's home library" 6. Try to place a hold on biblio B You should not be able to place a hold because there is no valid pickup locations 7. Enable AllowHoldPolicyOverride 8. Try to place a hold on biblio B You should now see all valid pickup locations in a dropdown list (with an exclamation mark in front of each option) with none selected by default 9. Verify you can place a title-level hold and an item-level hold Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 03:06:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 01:06:47 +0000 Subject: [Koha-bugs] [Bug 33622] New: Notice content does not show on default tab if TranslateNotices enabled Message-ID: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Bug ID: 33622 Summary: Notice content does not show on default tab if TranslateNotices enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org This was first noticed in 22.11 but can confirm it happens in main too. To reproduce: 1. Restart services 2. Go to Koha Administration -> Global system preferences and enable the TranslateNotices system preference 3. Go to Tools -> Notices & slips 4. Go to edit any notice i.e. ACCOUNTS_SUMMARY 5. Expand the Email section of the Default tab. Confirm there is no content in the notice --> BUG 6. Click on the next language tab, then expand the Email section. It is probably empty if you've only just enabled TranslateNotices and have not set up specific notices for your installed languages so this is fine. 7. Go back to the Default tab and expand the Email section. Confirm the content now shows for the notice It should show upon first expand of Email section. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 03:15:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 01:15:58 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33259-70-hof8IrFtGd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 03:58:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 01:58:06 +0000 Subject: [Koha-bugs] [Bug 32641] Patron search is not working by firstname or surname after upgradation from 22.05 to 22.11 (due to 500 internal server error) In-Reply-To: <bug-32641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32641-70-I7LgkbKGPM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32641 quickfire28 at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |quickfire28 at gmail.com --- Comment #8 from quickfire28 at gmail.com --- i have the same error after upgrading koha to latest version. intranet-error.log [Thu Apr 27 09:30:07.295368 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.308694 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.322324 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.331470 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.343247 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.354523 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.395259 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.416168 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.424388 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.433685 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.459579 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.467768 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.478201 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.514425 2023] [cgi:error] [pid 8558] [client 172.16.35.152:56691] AH01215: [2023-04-27 09:30:07.51414] [8559] [warn] OpenAPI >>> GET api/v1/patrons [{"message":"Month out of range.","path":"\\/body\\/0\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/1\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/12\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/13\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/14\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/17\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/18\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/19\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/2\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/3\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/4\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/6\\/date_renewed"}]: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.950348 2023] [cgi:error] [pid 8560] [client 172.16.35.152:56711] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.965755 2023] [cgi:error] [pid 8560] [client 172.16.35.152:56711] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.975457 2023] [cgi:error] [pid 8560] [client 172.16.35.152:56711] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:07.983972 2023] [cgi:error] [pid 8560] [client 172.16.35.152:56711] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:08.008304 2023] [cgi:error] [pid 8560] [client 172.16.35.152:56711] AH01215: [2023-04-27 09:30:08.00812] [8561] [warn] OpenAPI >>> GET api/v1/patrons [{"message":"Month out of range.","path":"\\/body\\/0\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/2\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/3\\/date_renewed"}]: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=E [Thu Apr 27 09:30:58.802709 2023] [cgi:error] [pid 8621] [client 172.16.35.152:56745] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=M [Thu Apr 27 09:30:58.838325 2023] [cgi:error] [pid 8621] [client 172.16.35.152:56745] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=M [Thu Apr 27 09:30:58.874883 2023] [cgi:error] [pid 8621] [client 172.16.35.152:56745] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=M [Thu Apr 27 09:30:58.982971 2023] [cgi:error] [pid 8621] [client 172.16.35.152:56745] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=M [Thu Apr 27 09:30:59.076490 2023] [cgi:error] [pid 8621] [client 172.16.35.152:56745] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=M [Thu Apr 27 09:30:59.095116 2023] [cgi:error] [pid 8621] [client 172.16.35.152:56745] AH01215: Odd number of elements in anonymous hash at /usr/share/koha/lib/Koha/Object.pm line 430.: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=M [Thu Apr 27 09:30:59.162564 2023] [cgi:error] [pid 8621] [client 172.16.35.152:56745] AH01215: [2023-04-27 09:30:59.16167] [8622] [warn] OpenAPI >>> GET api/v1/patrons [{"message":"Month out of range.","path":"\\/body\\/10\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/11\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/12\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/15\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/17\\/date_renewed"},{"message":"Month out of range.","path":"\\/body\\/18\\/date_renewed"}]: /usr/share/koha/api/v1/app.pl, referer: http://172.16.35.114:15000/cgi-bin/koha/members/members-home.pl?firstletter=M -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 04:01:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 02:01:35 +0000 Subject: [Koha-bugs] [Bug 32641] Patron search is not working by firstname or surname after upgradation from 22.05 to 22.11 (due to 500 internal server error) In-Reply-To: <bug-32641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32641-70-gsB18kAUQn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32641 --- Comment #9 from David Cook <dcook at prosentient.com.au> --- I had the same thing happen recently and it was bad data. You probably have '0000-00-00' in some of your date_renewed columns in the borrowers database table. Change those to NULL and you should be fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 04:34:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 02:34:52 +0000 Subject: [Koha-bugs] [Bug 33353] Add compatibility with Elasticsearch 8 In-Reply-To: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33353-70-9gY3VW4EFb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353 --- Comment #11 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Wiki only I guess (which isn't up to date about ES 7 and OS 1 support ^^") https://wiki.koha-community.org/wiki/System_requirements_and_recommendations It's linked in every release notes so hopefully it's read on major releases. ES users are larger instances so hopefully they is more confidence it's read that and or have a test instance where they will quickly see the problem to run the wrong ES version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 04:40:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 02:40:34 +0000 Subject: [Koha-bugs] [Bug 33353] Add compatibility with Elasticsearch 8 In-Reply-To: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33353-70-AJWVJVhkYN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Victor Grousset/tuxayo <victor at tuxayo.net> --- By the way, thanks Philip for the test. It counts as a signoff and so I can QA! A second signoff is always useful. Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 04:57:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 02:57:21 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-e4AzNLlIZp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #3 from Mason James <mtj at kohaaloha.com> --- Created attachment 150261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150261&action=edit pic -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 04:58:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 02:58:14 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-ZHOxNyXYrC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #4 from Mason James <mtj at kohaaloha.com> --- (In reply to David Cook from comment #2) > I think bug 32978 might be the root cause of this one. > > As I noted on bug 33621 it looks like the problem is that a hash (ie #) > isn't being encoded when it should be. > > I think the fix is probably to change fill='#369' to fill='%23369' in > ./koha-tmpl/opac-tmpl/bootstrap/css/src/_flatpickr.scss this seems to have fixed the problem, tested in master (pic attached) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:07:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:07:40 +0000 Subject: [Koha-bugs] [Bug 32641] Patron search is not working by firstname or surname after upgradation from 22.05 to 22.11 (due to 500 internal server error) In-Reply-To: <bug-32641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32641-70-wNcDhOAjOw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32641 --- Comment #10 from quickfire28 at gmail.com --- (In reply to David Cook from comment #9) > I had the same thing happen recently and it was bad data. > > You probably have '0000-00-00' in some of your date_renewed columns in the > borrowers database table. Change those to NULL and you should be fine. We already check it and there is no 0000-00-00 and already set to null -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:15:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:15:38 +0000 Subject: [Koha-bugs] [Bug 32641] Patron search is not working by firstname or surname after upgradation from 22.05 to 22.11 (due to 500 internal server error) In-Reply-To: <bug-32641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32641-70-7c3VChAEwF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32641 --- Comment #11 from quickfire28 at gmail.com --- (In reply to quickfire28 from comment #10) > (In reply to David Cook from comment #9) > > I had the same thing happen recently and it was bad data. > > > > You probably have '0000-00-00' in some of your date_renewed columns in the > > borrowers database table. Change those to NULL and you should be fine. > > We already check it and there is no 0000-00-00 and already set to null there are some with date in it (like this 2019-10-10) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:18:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:18:24 +0000 Subject: [Koha-bugs] [Bug 33353] Add compatibility with Elasticsearch 8 In-Reply-To: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33353-70-kGoV9ATa63@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353 --- Comment #13 from Victor Grousset/tuxayo <victor at tuxayo.net> --- After having this in main/master there will be the question of backporting (now or later) to 22.11 which is the LTS. Because before the end of the LTS it's likely that ES 7 won't be supported anymore. Here https://www.elastic.co/support/eol#elasticsearch we can see that branch 7.x will be supported until 9.x comes out. There is no alpha version of 9.x for now, but when there will be, the stable release can be expected 6 months later. (learned this in ES forums) So people interested can keep an eye here: https://github.com/elastic/elasticsearch/tags for when the 1st 9.x alpha pops. Also, for OpenSearch, it's already planned that 1.x will reach end of life before the end of 22.11's support. https://opensearch.org/releases.html => "Maintenance Window End" => "December 31, 2023" So what's the best strategy? (because it implies dropping 6.x support) 1. backport now 2. backport when/a bit before OpenSearch 1.x support ends (December 31, 2023) 3. backport when/a bit before ElasticSearch 7.x support will have also ended. (we don't know yet, it could be sooner than OS 1 or later) 4. don't backport and require ES 7 or OS 1 Koha admins to keep an end of life search engine or upgrade from the LTS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:26:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:26:39 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-9kYFvFwx73@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:26:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:26:42 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-zzVkX81gVV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #5 from Mason James <mtj at kohaaloha.com> --- Created attachment 150262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150262&action=edit Bug 33615: Date picker icon not visible to test: - apply patch, build package - edit item, observe calendar icon is visible -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:50:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:50:25 +0000 Subject: [Koha-bugs] [Bug 31957] Translation: Ability to change the sentence structure on library administration page In-Reply-To: <bug-31957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31957-70-0HIRFDR1Mb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31957 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |wainuiwitikapark at catalyst.n | |et.nz Status|Pushed to oldoldstable |RESOLVED --- Comment #19 from wainuiwitikapark at catalyst.net.nz --- Not backporting to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:50:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:50:43 +0000 Subject: [Koha-bugs] [Bug 32641] Patron search is not working by firstname or surname after upgradation from 22.05 to 22.11 (due to 500 internal server error) In-Reply-To: <bug-32641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32641-70-CzSdL8OGNM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32641 --- Comment #12 from quickfire28 at gmail.com --- (In reply to quickfire28 from comment #11) > (In reply to quickfire28 from comment #10) > > (In reply to David Cook from comment #9) > > > I had the same thing happen recently and it was bad data. > > > > > > You probably have '0000-00-00' in some of your date_renewed columns in the > > > borrowers database table. Change those to NULL and you should be fine. > > Sorry my bad there are lots of 0000-00-00 on date_renewed columns. Thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:51:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:51:17 +0000 Subject: [Koha-bugs] [Bug 30993] Translation: Unbreak sentence in upload.tt In-Reply-To: <bug-30993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30993-70-NSpB15GtK7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30993 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #12 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:53:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:53:22 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-LP5NyXSPko@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:53:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:53:24 +0000 Subject: [Koha-bugs] [Bug 32909] Item type icons broken when placing an item-level hold In-Reply-To: <bug-32909-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32909-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32909-70-N4a1ZxOqhf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32909 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #13 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:54:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:54:07 +0000 Subject: [Koha-bugs] [Bug 22693] ILL "Price paid" column does not appear in column configuration In-Reply-To: <bug-22693-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22693-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22693-70-FCsVZHkX4z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22693 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #22 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:55:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:55:12 +0000 Subject: [Koha-bugs] [Bug 32813] Fix cataloguing/value_builder/barcode.pl In-Reply-To: <bug-32813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32813-70-wQt4YfbANW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #13 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:55:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:55:12 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-UN8vJqc2gU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Bug 30975 depends on bug 32813, which changed state. Bug 32813 Summary: Fix cataloguing/value_builder/barcode.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32813 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:55:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:55:49 +0000 Subject: [Koha-bugs] [Bug 32566] Don't show 'ILL request logs' button, when IllLog is turned off In-Reply-To: <bug-32566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32566-70-NhXiyNIg4Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32566 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED CC| |wainuiwitikapark at catalyst.n | |et.nz Resolution|--- |FIXED --- Comment #8 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:56:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:56:23 +0000 Subject: [Koha-bugs] [Bug 32979] Add Test::Exception to Logger.t In-Reply-To: <bug-32979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32979-70-ykp65GGMfz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32979 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #14 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 05:56:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 03:56:51 +0000 Subject: [Koha-bugs] [Bug 31209] Add a span with class around serial enumeration/chronology data in list of checkouts for better styling In-Reply-To: <bug-31209-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31209-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31209-70-lVK2kNeNM0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31209 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:00:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:00:19 +0000 Subject: [Koha-bugs] [Bug 32814] Fix cataloguing/value_builder/callnumber-KU.pl In-Reply-To: <bug-32814-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32814-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32814-70-MdxlU3atbJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32814 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #11 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:00:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:00:20 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-HHJz1xYhSO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Bug 30975 depends on bug 32814, which changed state. Bug 32814 Summary: Fix cataloguing/value_builder/callnumber-KU.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32814 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:25:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:25:39 +0000 Subject: [Koha-bugs] [Bug 32821] Fix cataloguing/value_builder/stocknumber.pl In-Reply-To: <bug-32821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32821-70-6m59GktC7b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32821 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:25:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:25:39 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-CQJce9a6A4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Bug 30975 depends on bug 32821, which changed state. Bug 32821 Summary: Fix cataloguing/value_builder/stocknumber.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32821 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:28:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:28:04 +0000 Subject: [Koha-bugs] [Bug 32816] Fix cataloguing/value_builder/cn_browser.pl In-Reply-To: <bug-32816-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32816-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32816-70-IxEkeZ8DZc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32816 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:28:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:28:04 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-i3YbDHzRQw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Bug 30975 depends on bug 32816, which changed state. Bug 32816 Summary: Fix cataloguing/value_builder/cn_browser.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32816 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:28:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:28:53 +0000 Subject: [Koha-bugs] [Bug 32999] Click handler to show QR code in OPAC lacks preventDefault In-Reply-To: <bug-32999-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32999-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32999-70-8nnbEZwJfC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32999 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #8 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:31:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:31:19 +0000 Subject: [Koha-bugs] [Bug 32307] Chocolat image viewer broken in the staff interface when Coce is enabled In-Reply-To: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32307-70-zC8DYiwn9H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #27 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:32:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:32:03 +0000 Subject: [Koha-bugs] [Bug 32933] Use val() instead of attr("value") when getting field values with jQuery In-Reply-To: <bug-32933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32933-70-eOzySvuTwI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32933 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #18 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:33:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:33:00 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-iPOXSX3Fjc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com Version|22.11 |unspecified Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:33:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:33:20 +0000 Subject: [Koha-bugs] [Bug 32375] 22.05.07 failing t/AuthoritiesMarc_MARC21.t In-Reply-To: <bug-32375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32375-70-EgmkmitvLH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32375 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #13 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:35:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:35:17 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-MQju1MbxNO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- The patch fixes the problem but I don't understand why the problem has been caused by bug 32609. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:40:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:40:34 +0000 Subject: [Koha-bugs] [Bug 32641] Patron search is not working by firstname or surname after upgradation from 22.05 to 22.11 (due to 500 internal server error) In-Reply-To: <bug-32641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32641-70-BalkePjAAP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32641 --- Comment #13 from quickfire28 at gmail.com --- Thanks! it is working fine now :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:41:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:41:51 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-Cw9bdmKeTo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to David Cook from comment #2) > I think bug 32978 might be the root cause of this one. I reverted e5b28d9c40cab651079eadc1b64d2479a34cbbeb && yarn install && yarn css:build => no icon -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:49:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:49:32 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-6piyINHEmA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 --- Comment #7 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150263&action=edit Bug 33621: Fix claim return -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:51:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:51:45 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-x9ncaqItZz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 --- Comment #8 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I guess this has been caused by bug 30310. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 06:52:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 04:52:56 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-gwB8hLX6Cn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 --- Comment #8 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #7) > (In reply to David Cook from comment #2) > > I think bug 32978 might be the root cause of this one. > > I reverted e5b28d9c40cab651079eadc1b64d2479a34cbbeb && yarn install && yarn > css:build => no icon I'm not familiar enough with the process but perhaps a person needs to remove all node_modules and all built files as well? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:02:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:02:21 +0000 Subject: [Koha-bugs] [Bug 33197] Terminology: rename GDPR_Policy system preference In-Reply-To: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33197-70-CwThDKnsqf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33197 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:02:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:02:24 +0000 Subject: [Koha-bugs] [Bug 33197] Terminology: rename GDPR_Policy system preference In-Reply-To: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33197-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33197-70-jF13TV9oUp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33197 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148499|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150264&action=edit Bug 33197: Rename GDPR_Policy system preference GDPR is a European Union (and, at time of writing, UK) law. The GDPR_Policy system preference is about a patron giving consent to their personal data being processed in line with the library's privacy policy. The name of the preference is vague: there could be many policies implemented by libraries to comply with GDPR. It also makes the preference look irrelevant for libraries outside the areas where GDPR applies, while it may be useful for libraries anywhere. This renames GDPR_Policy to PrivacyPolicyConsent and adjusts the system preference descriptions. To test: * Apply the patch * Run database update * Search for GDPR_Policy in the system preference - you should not find anything. * Search for DataPrivacyConsent in the system preferences - you should find it and be able to activate it * Verify the feature works as expected - If the preference is set to "enforced", you will be asked to give consent to the data privacy agreement in the OPAC when you log in * Verify the page is now phrased neutrally using 'privacy policy' Bonus: Consent date is now formatted according to DateFormat system preference. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:02:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:02:57 +0000 Subject: [Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes In-Reply-To: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21083-70-yl9xve6nEW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 --- Comment #10 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Katrin Fischer from comment #9) > Did you see bug 33156? Why are you asking? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:05:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:05:13 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-bLUtMhO35P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Hum, wondering if this is not safer to fix it in dt_from_string actually. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:10:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:10:41 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-0F01k0SIH3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:10:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:10:44 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-GPRPB7qRvt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149999|0 |1 is obsolete| | Attachment #150001|0 |1 is obsolete| | --- Comment #25 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150265&action=edit Bug 33478: Add formatting columns to letter table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:10:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:10:47 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-hriTOOQOHl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150000|0 |1 is obsolete| | --- Comment #26 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150266&action=edit Bug 33478: Schema updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:10:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:10:49 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-4pNGPyZAtm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150002|0 |1 is obsolete| | --- Comment #27 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150267&action=edit Bug 33478: Save notice format settings Save format settings for an individual notice, or for all notices To test: 1. Apply the patches, install database updates, update schema if needed, and restart services 2. Go to Tools -> Notices and slips 3. Edit any notice 4. Go to the Print tab 5. Confirm format settings now show underneath the notice content box 6. Change some settings and confirm they save correctly 7. Test that 'apply these settings to all notices' option works 8. Add a new notice and confirm format settings save successfully 9. Search for a patron, go to More -> Set permissions 10. Ensure they have all Tools permissions EXCEPT for new format_notices user permission 11. Log into the staff interface as this patron 12. Go to Tools -> Notices and slips 13. Edit a notice 14. Go to the Print tab 15. Confirm the format settings DO NOT show underneath the notice content box Sponsored-by: Colorado Library Consortium -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:10:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:10:52 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-pt1NHYFqUm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150003|0 |1 is obsolete| | --- Comment #28 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150268&action=edit Bug 33478: Apply formatting to HOLD_SLIP To test: 1. Place a hold on a record 2. Check in an item attached to the record 3. When the pop-up for the hold is triggered, confirm hold and print slip 4. Confirm your format settings for HOLD_SLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:10:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:10:55 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-RKpEPM7vY6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150004|0 |1 is obsolete| | --- Comment #29 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150269&action=edit Bug 33478: Apply formatting to AR_SLIP To test: 1. Enable ArticleRequests system preference in Koha Administration -> Global system preferences 2. Log into the OPAC 3. Do a catalogue search 4. Click the 'Request article' button for a record 5. Fill in some information and submit 6. Go to the staff interface 7. Go to Circulation -> Article Requests 8. Click the Actions menu next to your article request and choose Print slip 9. Confirm your format settings for AR_SLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:10:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:10:57 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-pFfolaHrmj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150005|0 |1 is obsolete| | --- Comment #30 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150270&action=edit Bug 33478: Apply formatting to TRANSFERSLIP To test: 1. Search for an item that was last seen at a library different from your logged in library i.e the holding library is Fairview but your logged in library is Centerville 2. Use the barcode to check in the item 3. When the popup to 'please return this item to <home library>' is triggered, click the Print slip button 4. Confirm your format settings for TRANSFERSLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:11:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:11:00 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-DxMbBZ6PCh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150006|0 |1 is obsolete| | --- Comment #31 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150271&action=edit Bug 33478: Apply formatting to OVERDUES_SLIP To test: 1. Check out an item to a user. Set the due date to a time in the past so it is overdue 2. Click Print in the members toolbar, then Print overdues 3. Confirm your format settings for OVERDUES_SLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:11:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:11:03 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-a1C9N11v4Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150007|0 |1 is obsolete| | Attachment #150008|0 |1 is obsolete| | --- Comment #32 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150272&action=edit Bug 33478: Apply formatting to ACCOUNT_DEBIT To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. You'll be redirected to the Transactions tab 4. Click the Print button next to your invoice 5. Confirm your format settings for ACCOUNT_DEBIT are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:11:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:11:05 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-dns31NjWgU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #33 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150273&action=edit Bug 33478: Apply formatting to ACCOUNT_DEBIT To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. You'll be redirected to the Transactions tab 4. Click the Pay button next to your invoice and confirm Payment 5. Click the Print button next to your Payment 6. Confirm your format settings for ACCOUNT_CREDIT are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:11:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:11:08 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-t74GIKOKT9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150009|0 |1 is obsolete| | --- Comment #34 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150274&action=edit Bug 33478: Apply formatting to ISSUESLIP, ISSUEQSLIP, CHECKINSLIP To test: 1. Check out an item to a patron 2. Click Print in the members toolbar, then Print quick slip 3. Confirm your format settings for ISSUEQSLIP are applied 4. Click Print in the members toolbar, then Print slip 5. Confirm your format settings for ISSUESLIP are applied 6. Return the item 7. When the item is checked in, click the 'Print checkin slip' button 8. Confirm your format settings for CHECKINSLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:11:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:11:11 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-fUIlWDqkPK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150010|0 |1 is obsolete| | --- Comment #35 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150275&action=edit Bug 33478: Apply formatting to RECEIPT To test: 1. Enable EnablePointOfSale and UseCashRegisters system preferences in Koha Administration -> Global system preferences 2. Go to Koha Administration -> Cash registers and add a new cash register 3. Go to Koha Administration -> Debit types and add a new debit type. Make sure you check the 'can be sold' option 4. Go to Point of sale 5. Select Add for your item under Items for purchase 6. Fill in Collect payment box and click Confirm 7. When payment is received, click Print receipt 8. Confirm your format settings for RECEIPT are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:11:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:11:13 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-yYH1ExeYeB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150011|0 |1 is obsolete| | --- Comment #36 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150276&action=edit Bug 33478: Apply formatting to ACCOUNTS_SUMMARY To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. Click the Print button in the patron toolbar 4. Click the 'Print account balance' button 5. Confirm your format settings for ACCOUNTS_SUMMARY are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:11:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:11:16 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-EIxpdPvKlq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150012|0 |1 is obsolete| | --- Comment #37 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150277&action=edit Bug 33478: Apply formatting to RECALL_REQUESTER_DET To test: 1. Enable UseRecalls system preference and configure all relevant recalls circulation and fines rules 2. Search for a record with only one item 3. Check out this item to Patron A 4. Log into the OPAC as Patron B 5. Search for the item and place a recall 6. Go back to the staff interface 7. Check in the item 8. When the pop-up for the recall is triggered, confirm recall and print slip 9. Confirm your format settings for RECALL_REQUESTER_DET are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:12:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:12:15 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-SwifAtPLaf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- What about this one? 88 $dbh->commit(); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:16:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:16:19 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-UmOyWz8L0z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #38 from Aleisha Amohia <aleisha at catalyst.net.nz> --- (In reply to Nick Clemens from comment #24) > I didn't do a full run through as I hit a few issues. Thank you for testing! Decided to remove the permission as I agree it's not really needed and think that addresses half of these issues. > > Must fix: > - A patron without permissions cannot save print notices. The current > settings need to be included as hidden inputs > - The permission doesn't prevent url/form manipulation without the > permission. This must be checked in the code. Removed permission > - There is an empty value in the Units dropdown for 'AGATE' Fixed in latest patchset > > Should fix: > - The DB fields should be enum if they only support a limited range of > values Fixed in latest patchset > - This reveals an consistency - ISSUESLIP is presented in print format, > however, it uses the 'email' template. Possibly the settings can be their > own section? Otherwise this needs to be addressed Moved to its own section out of the Print section) > - 'Apply format settings to all notices' - I can see the utility here for > initially settings things up - but this seems a bit too powerful. A warning > at least would be nice Added a confirmation box when hitting Save > - Even if you cannot edit the settings - it would be useful to view the > print formatting so you know what you can see I haven't addresses the print preview because you can see a print preview when you go to Print the notice - I know it's not ideal. I can come back to this if I have some time but I don't think it should be a blocker at this point. > - The new form is added to all notices - but it really only applies to > slips if I understand correctly? Does this work with bug 33260 for printing > notices from the staff interface? It should be clarified if it does not work > with gather_print_notices etc. I plan to rebase Bug 33260 on top of this. > > Could fix: > - I don't know that a permission is needed here, if you can edit slips I > would assume you can edit this portion too, but I assume there is a > motivation Removed permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:22:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:22:20 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-t55nFBIFSs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #13 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150278&action=edit Bug 31187: Make sure to not count twice There is another modified++ right after, we don't want to count it twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:26:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:26:28 +0000 Subject: [Koha-bugs] [Bug 32820] Fix cataloguing/value_builder/stocknumberAV.pl In-Reply-To: <bug-32820-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32820-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32820-70-nLi8qfP0J8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32820 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #12 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:26:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:26:28 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30975-70-49C4aEjyap@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 Bug 30975 depends on bug 32820, which changed state. Bug 32820 Summary: Fix cataloguing/value_builder/stocknumberAV.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32820 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:27:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:27:00 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-qYNXJmi7Ua@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #14 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Added a patch to add a next, it seems safe to have it (no idea if it's really needed). Also adjusting the 'reset' call to make it looks like other similar statements. I am not sure we are doing things correctly, the number of items modified displayed in the report of the batch tool won't be correct as we are considering each items of the batch is modified. Not enough brain power for now to go further with this one... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:27:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:27:47 +0000 Subject: [Koha-bugs] [Bug 32822] Fix cataloguing/value_builder/unimarc_field_010.pl In-Reply-To: <bug-32822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32822-70-TksBKapcy4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32822 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:28:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:28:02 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-2Vh8APkj2T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #14) > Also adjusting the 'reset' call to make it looks like other > similar statements. Well, forget that, that's not "all" other statements, but half of them... Can be dropped. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:28:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:28:13 +0000 Subject: [Koha-bugs] [Bug 32525] Standardize labels between ILL request list and detail page In-Reply-To: <bug-32525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32525-70-Vj7UzlrX2G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32525 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #8 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:28:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:28:40 +0000 Subject: [Koha-bugs] [Bug 32823] Fix cataloguing/value_builder/unimarc_field_100_authorities.pl In-Reply-To: <bug-32823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32823-70-AQJDxmCzi6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32823 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:29:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:29:47 +0000 Subject: [Koha-bugs] [Bug 32826] Fix cataloguing/value_builder/unimarc_field_106.pl In-Reply-To: <bug-32826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32826-70-jTdawltKJM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32826 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #11 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:30:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:30:09 +0000 Subject: [Koha-bugs] [Bug 32825] Fix cataloguing/value_builder/unimarc_field_105.pl In-Reply-To: <bug-32825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32825-70-Q9Lq2c3iLb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32825 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:31:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:31:14 +0000 Subject: [Koha-bugs] [Bug 32827] Fix cataloguing/value_builder/unimarc_field_110.pl In-Reply-To: <bug-32827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32827-70-psoDTTl6cc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32827 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:31:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:31:36 +0000 Subject: [Koha-bugs] [Bug 32828] Fix cataloguing/value_builder/unimarc_field_115a.pl In-Reply-To: <bug-32828-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32828-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32828-70-swHleWdUxZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32828 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:31:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:31:56 +0000 Subject: [Koha-bugs] [Bug 32829] Fix cataloguing/value_builder/unimarc_field_115b.pl In-Reply-To: <bug-32829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32829-70-EgO5l1yLYv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32829 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:32:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:32:25 +0000 Subject: [Koha-bugs] [Bug 32982] 'Add/Edit group' modals in library groups is missing it's primary button In-Reply-To: <bug-32982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32982-70-tlGd0uuNde@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32982 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:32:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:32:25 +0000 Subject: [Koha-bugs] [Bug 31947] [Omnibus] Add 'btn-primary' to the main action button where it's missing In-Reply-To: <bug-31947-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31947-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31947-70-6xRQTyKkk6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31947 Bug 31947 depends on bug 32982, which changed state. Bug 32982 Summary: 'Add/Edit group' modals in library groups is missing it's primary button https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32982 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:32:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:32:52 +0000 Subject: [Koha-bugs] [Bug 31413] Set focus for cursor to Selector when adding a new audio alert In-Reply-To: <bug-31413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31413-70-UbWaH14Bft@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31413 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED CC| |wainuiwitikapark at catalyst.n | |et.nz Resolution|--- |FIXED --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:32:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:32:53 +0000 Subject: [Koha-bugs] [Bug 31411] [Omnibus] Set focus to first input field of an add/entry form In-Reply-To: <bug-31411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31411-70-UiC6dgDJoX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31411 Bug 31411 depends on bug 31413, which changed state. Bug 31413 Summary: Set focus for cursor to Selector when adding a new audio alert https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31413 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:33:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:33:27 +0000 Subject: [Koha-bugs] [Bug 32926] Cannot expand or collapse some System preference sections after a search In-Reply-To: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32926-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32926-70-Q1NopUo1oP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #19 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:34:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:34:11 +0000 Subject: [Koha-bugs] [Bug 33032] Alternate holdings broken in staff interface search results In-Reply-To: <bug-33032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33032-70-Ol1LJRW0Nw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33032 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #12 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:34:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:34:40 +0000 Subject: [Koha-bugs] [Bug 33048] Empty email link on error page when opac login not allowed In-Reply-To: <bug-33048-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33048-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33048-70-EMGXStBix4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:35:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:35:07 +0000 Subject: [Koha-bugs] [Bug 32835] Fix cataloguing/value_builder/unimarc_field_122.pl In-Reply-To: <bug-32835-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32835-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32835-70-n9jgmII1JO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32835 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:35:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:35:35 +0000 Subject: [Koha-bugs] [Bug 32824] Fix cataloguing/value_builder/unimarc_field_100.pl In-Reply-To: <bug-32824-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32824-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32824-70-m2lYoYGJn0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32824 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:37:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:37:12 +0000 Subject: [Koha-bugs] [Bug 32205] Unnecessary sysprefs used in template params for masthead during failed OPAC auth In-Reply-To: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32205-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32205-70-cFX62nRJzZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32205 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #15 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:37:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:37:33 +0000 Subject: [Koha-bugs] [Bug 33055] SIP2 adding incorrect fines blocked message In-Reply-To: <bug-33055-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33055-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33055-70-CVFr2nzXtG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33055 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #12 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:37:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:37:54 +0000 Subject: [Koha-bugs] [Bug 32639] OpenSearch description format document generates search errors In-Reply-To: <bug-32639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32639-70-icdF75vl3t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32639 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:38:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:38:18 +0000 Subject: [Koha-bugs] [Bug 32663] Street number should not allow for entering more than 10 characters in OPAC In-Reply-To: <bug-32663-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32663-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32663-70-aPRrjBzarb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32663 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #13 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:38:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:38:47 +0000 Subject: [Koha-bugs] [Bug 33044] BackgroundJob enqueue does not return the job id if rabbit is unreachable In-Reply-To: <bug-33044-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33044-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33044-70-PZ4lDeYqM6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33044 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #14 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:39:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:39:22 +0000 Subject: [Koha-bugs] [Bug 31471] Duplicate check in cataloguing fails with Elasticsearch for records with multiple ISBN In-Reply-To: <bug-31471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31471-70-wQd8YKyjiU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31471 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #12 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:40:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:40:26 +0000 Subject: [Koha-bugs] [Bug 32811] Remove unused indexer.log In-Reply-To: <bug-32811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32811-70-VxgFJBe4nM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32811 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:42:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:42:32 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-bLZcq1Y0uh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I am not sure we actually need the modified++ you have added, do we? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:42:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:42:36 +0000 Subject: [Koha-bugs] [Bug 32678] Add new line in authorized values tests in search_for_data_inconsistencies.pl In-Reply-To: <bug-32678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32678-70-sWCBnbVXuM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32678 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:42:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:42:59 +0000 Subject: [Koha-bugs] [Bug 32815] Fix cataloguing/value_builder/callnumber.pl In-Reply-To: <bug-32815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32815-70-byTPjbXrJA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32815 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:43:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:43:22 +0000 Subject: [Koha-bugs] [Bug 32819] Fix cataloguing/value_builder/stocknumberam123.pl In-Reply-To: <bug-32819-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32819-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32819-70-t4pVwoxxVo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32819 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:48:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:48:38 +0000 Subject: [Koha-bugs] [Bug 24310] Use Text::Lorem instead of String::Random in Test::Builder In-Reply-To: <bug-24310-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24310-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24310-70-ektkQG24Ld@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24310 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96647|0 |1 is obsolete| | Attachment #96648|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150279&action=edit Bug 24310: Fix TestBuilder to generate consistent list content -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:48:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:48:40 +0000 Subject: [Koha-bugs] [Bug 24310] Use Text::Lorem instead of String::Random in Test::Builder In-Reply-To: <bug-24310-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24310-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24310-70-b4X9YeIroF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24310 --- Comment #6 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150280&action=edit Bug 24310: Use Text::Lorem instead of String::Random (new dependency) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:53:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:53:14 +0000 Subject: [Koha-bugs] [Bug 33155] Category and library filters from header patron search not taken into account In-Reply-To: <bug-33155-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33155-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33155-70-DnApJJ6bwa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33155 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #8 from wainuiwitikapark at catalyst.net.nz --- This is on 21.11 Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:53:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:53:38 +0000 Subject: [Koha-bugs] [Bug 32679] CSS class article-request-title is doubled up in article requests list in staff patron account In-Reply-To: <bug-32679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32679-70-NrqDIe5R1B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32679 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:54:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:54:11 +0000 Subject: [Koha-bugs] [Bug 32492] Improve mark-up of OPAC messaging table to ease customization In-Reply-To: <bug-32492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32492-70-NpUW3BPa3Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32492 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #21 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:54:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:54:33 +0000 Subject: [Koha-bugs] [Bug 33173] Save and continue button in standard cataloging module broken In-Reply-To: <bug-33173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33173-70-DqNC0GLLKm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33173 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #8 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:54:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:54:54 +0000 Subject: [Koha-bugs] [Bug 33189] Plugin upload should prompt for .kpz files In-Reply-To: <bug-33189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33189-70-3EcrFTsrGA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33189 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #8 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:55:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:55:19 +0000 Subject: [Koha-bugs] [Bug 29607] addorderiso2709: The stored discount when importing an order from a file is invalid In-Reply-To: <bug-29607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29607-70-AkyejfzFE9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29607 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #12 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:56:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:56:35 +0000 Subject: [Koha-bugs] [Bug 33063] Duplicated reports should maintain subgroup of original In-Reply-To: <bug-33063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33063-70-wRhegQI0lg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33063 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #12 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:57:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:57:47 +0000 Subject: [Koha-bugs] [Bug 32519] In Elasticsearch mappings table use search field name In-Reply-To: <bug-32519-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32519-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32519-70-x4WYnfr0Qq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32519 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:58:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:58:17 +0000 Subject: [Koha-bugs] [Bug 33211] Fix failing test for basic_workflow.t when adding item In-Reply-To: <bug-33211-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33211-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33211-70-40PVckwLHe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33211 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #7 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:58:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:58:55 +0000 Subject: [Koha-bugs] [Bug 33144] Authority lookup in advanced editor overencodes HTML In-Reply-To: <bug-33144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33144-70-ubswbIsMEa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33144 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:59:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:59:17 +0000 Subject: [Koha-bugs] [Bug 33150] Add specific message for renewal too_soon situation In-Reply-To: <bug-33150-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33150-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33150-70-8GCRCGNplW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33150 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #11 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 07:59:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 05:59:48 +0000 Subject: [Koha-bugs] [Bug 33183] Error inserting matchpoint_components when creating record matching rules with MariaDB 10.6 In-Reply-To: <bug-33183-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33183-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33183-70-YN05oCk86N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33183 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark at catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark at catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 08:41:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 06:41:33 +0000 Subject: [Koha-bugs] [Bug 33623] New: getAll not encoding URL params Message-ID: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 Bug ID: 33623 Summary: getAll not encoding URL params Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 08:49:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 06:49:32 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33623-70-UQKScStYt5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 08:49:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 06:49:35 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33623-70-WSgyt9zNE6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 --- Comment #1 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150281&action=edit Bug 33623: Encode URL params for getAll We must encode properly URL parameters when building the REST API routes Can be tested easily using const client = APIClient.erm client.licenses.getAll({ "me.name:%ff%" }) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 08:50:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 06:50:06 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33623-70-itzcjER0au@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 --- Comment #2 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Please make this patch part of master ASAP! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 08:50:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 06:50:51 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-6mwPR9jurk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33623 --- Comment #15 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Found some problems, this needs to depend on bug 33623, follow-ups coming. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 [Bug 33623] getAll not encoding URL params -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 08:50:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 06:50:51 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33623-70-Yk8mt66dVu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 [Bug 32474] Implement infinite scroll in vue-select -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 08:57:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 06:57:02 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33623-70-vdpKpUtwqZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 --- Comment #3 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Also contains some prettier changes: yarn run prettier --trailing-comma es5 --arrow-parens avoid --write koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js (yes, we are missing a QA test) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 09:00:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 07:00:01 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-okf0keqaJ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #16 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150282&action=edit Bug 32474: Do not fetch all the licenses Otherwise we are loosing all the point of the pagination! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 09:00:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 07:00:03 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-8XxJCRTL2r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #17 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150283&action=edit Bug 32474: Allow getAll to pass params We may want to extend that to other getAll functions as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 09:00:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 07:00:07 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-Jq5G36CsLw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150284&action=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 09:08:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 07:08:27 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-jLxj54vkZB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 --- Comment #19 from Philip Orr <philip.orr at lmscloud.de> --- will do! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 09:13:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 07:13:41 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-GMsRXv7tzv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Philip Orr <philip.orr at lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 09:13:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 07:13:43 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-soavhaSLsB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Philip Orr <philip.orr at lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149670|0 |1 is obsolete| | --- Comment #20 from Philip Orr <philip.orr at lmscloud.de> --- Created attachment 150285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150285&action=edit Bug 32914: Use template wrapper for batch record deletion and modification templates This patch updates the batch record modification and batch record deletion templates to replace tab markup with the use of WRAPPERs. This patch adds a "clearfix" snippet of CSS to _mixins.scss copied from Bootstrap. Applied to the active tab pane, this helps in situations where Bootstrap tabs follow a floated element. The patch also wraps tab label strings in <span> to ensure they can be translated. Unrelated: The patch removes an extra </option> from the batch record modification template. To test you should have at least one list and at least one MARC modification template defined. - Apply the patch and go to Cataloging -> Batch record modification - You should see three tabs, "Upload a file," "Select a list of records," and "Enter a list of record numbers." - The tabs should look correct and work correctly. - Checking the "Authorities" radio button should hide the lists tab. - Test that submissions from each form work correctly. - Go to Cataloging -> Batch record deletion and perform the same tests. Signed-off-by: Philip Orr <philip.orr at lmscloud.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 09:13:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 07:13:46 +0000 Subject: [Koha-bugs] [Bug 32914] Use template wrapper for batch record deletion and modification templates In-Reply-To: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32914-70-qbhiiDFQTV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32914 Philip Orr <philip.orr at lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150214|0 |1 is obsolete| | --- Comment #21 from Philip Orr <philip.orr at lmscloud.de> --- Created attachment 150286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150286&action=edit Bug 32914: (follow-up) Improve handling of list tab visibility This patch makes minor changes to the way this page handles switching between authority and bibliographic record batch operation in order to ensure that the list tab is correctly shown or hidden and that the list tab selection isn't transmitted when an authority batch is submitted. This patch also changes the labels on the "record type" fields to fix the incorrect use of the abbreviated "biblios" in favor of "Bibliographic." To test, apply the patch and go to Cataloging -> Batch record modification - With the "Bibliographic records" selected, click the "Select a list of records" tab." - Select the "Authority records" radio button. - The "Select a list of records" tab should disappear, and the "Upload a file" tab should now be selected." - Select the "Bibliographic records radio button. - The "Select a list of records" tab should reappear, and the "Upload a file" tab should be selected. - Test all combinations of form submissions to confirm that each works correctly: - Bibliographic records by upload, list, and biblionumber entry - Authory records by upload and authority record number entry Signed-off-by: Philip Orr <philip.orr at lmscloud.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 09:13:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 07:13:46 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-sGqdSgxSxw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #19 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Additional notes: * It would be interesting to have a delay between the requests * We are retrieving the 20 first license when clicking the "Add new license" button and when opening the dropdown list. Seems like there is an extra one, is it hiding something? * About the scrollbar hitting top when scrolling down, did you have a look at 'more'? https://select2.org/data-sources/ajax#pagination -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 09:37:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 07:37:35 +0000 Subject: [Koha-bugs] [Bug 33624] New: Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed Message-ID: <bug-33624-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33624 Bug ID: 33624 Summary: Using Browser "Back" button in Batch Record Modification causes biblio options to be displayed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: philip.orr at lmscloud.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl First seen in Bug #32914. If you enter Koha's Batch record modification tool, select Authority records, select a template and then hit continue without actually uploading a file or entering record numbers, the error message "No records were modified." will be displayed. All correct so far. If you then don't click on "New batch record modification" and instead use the back button in Firefox to go back one page, you will land in batch record modification with the option "Authority records" selected but with the tab "Select a list of records" (meant for lists of Biblios) now again displayed and usable. Since biblio records and authorities records could have similar biblionumbers, this could lead to a situation where you're accidentally modifying the wrong records. To recreate: - Make sure you have at least one template for MARC Modification - Also make sure you have at least one list of biblio records - navigate to Cataloging -> Batch record modification - Check the "Authorities" radio button - Select your template and continue - No records were modified -> use your browser's Back button to go back one page - The "Authorities" radio button should still be selected, but you should now see the tab "Select a list of records". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 09:54:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 07:54:28 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-06IcTsAw8W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150284|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Created attachment 150287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150287&action=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 09:59:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 07:59:17 +0000 Subject: [Koha-bugs] [Bug 30590] Add option for using AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module In-Reply-To: <bug-30590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30590-70-QSb53NhGAS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30590 Mirjam Vantieghem <mirjam.vantieghem at etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem at etf.edu --- Comment #7 from Mirjam Vantieghem <mirjam.vantieghem at etf.edu> --- This bug seems to have the same aim as #Bug 22322. Mark as duplicate? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 09:59:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 07:59:48 +0000 Subject: [Koha-bugs] [Bug 22322] Self-checkin module should provide for automatic logins (like self-checkout) In-Reply-To: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22322-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22322-70-HPTvuJcoTh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22322 Mirjam Vantieghem <mirjam.vantieghem at etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem at etf.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 10:08:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 08:08:29 +0000 Subject: [Koha-bugs] [Bug 21544] Self Check-in tool does not trigger holds In-Reply-To: <bug-21544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21544-70-BjqAHbyaHO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21544 Mirjam Vantieghem <mirjam.vantieghem at etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem at etf.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 11:11:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 09:11:54 +0000 Subject: [Koha-bugs] [Bug 33625] New: Enforce formatting on vue js files Message-ID: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Bug ID: 33625 Summary: Enforce formatting on vue js files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com We have a pre-commit git hook, a QA test and an unit test (in xt/vue_tidy.t) to make sure .vue files will always be correctly formatted, but we don't have anything for the .js and .ts files that were pretty at the beginning but are no longer. It should be: t/cypress/**/*.ts koha-tmpl/intranet-tmpl/prog/js/vue/*.js koha-tmpl/intranet-tmpl/prog/js/vue/**/*.js (maybe exclude dist?) With the following command: yarn run prettier --trailing-comma es5 --arrow-parens avoid --write FILES -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 11:12:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 09:12:24 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue js files In-Reply-To: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33625-70-KXsCkQ0f3k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32130, 32030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130 [Bug 32130] Vue files must be kept tidy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 11:12:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 09:12:24 +0000 Subject: [Koha-bugs] [Bug 32030] Electronic resource management (ERM) In-Reply-To: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32030-70-6KRMT9aFDJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 [Bug 33625] Enforce formatting on vue js files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 11:12:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 09:12:24 +0000 Subject: [Koha-bugs] [Bug 32130] Vue files must be kept tidy In-Reply-To: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32130-70-8rbgzGlbzK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32130 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 [Bug 33625] Enforce formatting on vue js files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 11:12:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 09:12:38 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33623-70-UllID5yBS4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 --- Comment #4 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Jonathan Druart from comment #3) > Also contains some prettier changes: > yarn run prettier --trailing-comma es5 --arrow-parens avoid --write > koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js > > (yes, we are missing a QA test) Opened bug 33625. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 11:15:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 09:15:38 +0000 Subject: [Koha-bugs] [Bug 33625] Enforce formatting on vue js files In-Reply-To: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33625-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33625-70-hB7oMYIdv5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33625 Jonathan Druart <jonathan.druart+koha at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 11:57:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 09:57:13 +0000 Subject: [Koha-bugs] [Bug 33018] debian package tidy-up In-Reply-To: <bug-33018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33018-70-0TUTfrN4Zg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #6 from Mason James <mtj at kohaaloha.com> --- Created attachment 150288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150288&action=edit Bug 33018: debian package tidy-up (2) remove unrequired module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 12:06:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 10:06:30 +0000 Subject: [Koha-bugs] [Bug 33018] debian package tidy-up In-Reply-To: <bug-33018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33018-70-nMDTwpLRdD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #7 from Mason James <mtj at kohaaloha.com> --- (In reply to Magnus Enger from comment #2) > It looks like these modules are still in use in Koha? > > $ grep -rn "LWP::Protocol" * > cpanfile:62:requires 'LWP::Protocol::https', '5.836'; > debian/list-deps:30: 'LWP::Protocol::https' => > 'liblwp-protocol-https-perl | libwww-perl (<<6.02), libio-socket-ssl-perl', this pkg is required, but no longer needs to be explicitly listed in deb/list-deps > > $ grep -rn "IO::Socket::IP" * > debian/list-deps:32: 'IO::Socket::IP' => 'perl-modules (>= 5.20.0) > | libio-socket-ip-perl', > misc/bin/connexion_import_daemon.pl:91:# use IO::Socket::IP; this pkg is not required, as its now provided by perl-modules-* pkg > > $ grep -rn "CPAN::Meta" * > cpanfile:15:requires 'CPAN::Meta', '2.150006'; > debian/list-deps:33: 'CPAN::Meta' => 'libcpan-meta-perl (>= > 2.150010) | perl-modules-5.28 | perl-modules-5.30 | perl-modules (>= > 5.20.2)', this pkg is not required, as its now provided by perl-modules-* pkg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 12:08:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 10:08:28 +0000 Subject: [Koha-bugs] [Bug 33353] Add compatibility with Elasticsearch 8 In-Reply-To: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33353-70-JVBNIGU6EG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353 David Liddle <david.liddle at wycliff.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.liddle at wycliff.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 13:07:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 11:07:46 +0000 Subject: [Koha-bugs] [Bug 33018] debian package tidy-up In-Reply-To: <bug-33018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33018-70-jj8B1PxAfW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33018 --- Comment #8 from Magnus Enger <magnus at libriotech.no> --- Thanks Mason, sounds good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 13:21:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 11:21:43 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33417-70-jI8v9FjIsi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 13:22:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 11:22:42 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33417-70-rnyOTus3ft@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- With Jonathan highlighting the translation points here I think we can call his comments a signoff.. my testing confirms all is working and I'm not seeing any regressions.. so I'm tempted to convert this to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 13:22:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 11:22:47 +0000 Subject: [Koha-bugs] [Bug 33626] New: compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 Message-ID: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33626 Bug ID: 33626 Summary: compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz [Param] ** Unknown param (scroll_in_qs) in (search) request. , called from sub Search::Elasticsearch::Client::7_0::Direct::scroll_helper at misc/maintenance/compare_es_to_db.pl line 55. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 13:27:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 11:27:14 +0000 Subject: [Koha-bugs] [Bug 33626] compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 In-Reply-To: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33626-70-EAfIZ0tXWR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33626 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 13:27:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 11:27:15 +0000 Subject: [Koha-bugs] [Bug 33626] compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 In-Reply-To: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33626-70-uz7jW8bbcx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33626 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150289&action=edit Bug 33626: Remove invalid params This patch reformats the params passed to scroll_helper as defined here: https://metacpan.org/pod/Search::Elasticsearch::Client::7_0::Scroll To test: 1 - perl misc/maintenance/compare_es_to_db.pl 2 - It dies: [Param] ** Unknown param (scroll_in_qs) in (search) request. , called from sub Search::Elasticsearch::Client::7_0::Direct::scroll_helper at misc/maintenance/compare_es_to_db.pl line 55. 3 - Apply patch 4 - Repeat 5 - It succeeds! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 13:27:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 11:27:23 +0000 Subject: [Koha-bugs] [Bug 33626] compare_es_to_db.pl does not work with Search::Elasticsearch 7.0 In-Reply-To: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33626-70-cVrcNHFqMU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33626 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 13:42:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 11:42:36 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-wjOMqkvpEn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149821|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150290&action=edit Bug 33064: Add a licenses option to the searchbar This patch adds a licenses option to the top searchbar Test plan: 1) Apply patch 2) run yarn build 3) Navigate to the ERM module 4) Observe that the top search bar should have an option for licenses 5) Click on licenses in the left hand menu, the search bar should update to show licenses as the active search option Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 13:42:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 11:42:39 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-N0SUkTzu7a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149822|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150291&action=edit Bug 33064: Update cypress tests This patch amends Searchbar_spec.ts to account for the new licenses option Test plan: 1) Run yarn cypress open 2) Select the Searchbar_spec.ts test 3) The test should pass Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 13:42:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 11:42:59 +0000 Subject: [Koha-bugs] [Bug 33064] Add a search option for licenses to top search bar In-Reply-To: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33064-70-asUuCTB2Xa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33064 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- All working as described, QA scripts happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:01:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:01:30 +0000 Subject: [Koha-bugs] [Bug 33627] New: OAI-PMH script build_oai_sets.pl is slow and memory angry Message-ID: <bug-33627-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33627 Bug ID: 33627 Summary: OAI-PMH script build_oai_sets.pl is slow and memory angry Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 15108 optimize set search but there's the same issue in: ./misc/migration_tools/build_oai_sets.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:03:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:03:10 +0000 Subject: [Koha-bugs] [Bug 33627] OAI-PMH script build_oai_sets.pl is slow and memory hungry In-Reply-To: <bug-33627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33627-70-chtzyu796f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33627 Didier Gautheron <didier.gautheron at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OAI-PMH script |OAI-PMH script |build_oai_sets.pl is slow |build_oai_sets.pl is slow |and memory angry |and memory hungry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:13:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:13:35 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-FbaPCH0ers@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149450|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150292&action=edit Bug 33482: Propagate errors from EBSCO's ws to the UI When adding or removing eholdings from EBSCO, if an error happens it is lost and not propagated to the UI. We were missing a return in the logic, and always returning 200 Test plan: Do not apply (or revert) bug 33481 Configure EBSCO for ERM and add a package to your holdings With this patch applied you will get a 500 that is propagated to the UI Without this patch nothing happens and the user is not aware that something bad happened Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:13:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:13:49 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-wXpxX12m36@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149508|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:13:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:13:59 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-5AstcjwI5k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #16) > I am not sure we actually need the modified++ you have added, do we? You are correct, I think. We are preserviing the old value, not modifying a field. You can remove, or I can provide a patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:14:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:14:10 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-WsdxB1DgAn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- All working as expected, no QA failures. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:14:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:14:15 +0000 Subject: [Koha-bugs] [Bug 33482] Errors from EBSCO's ws are not reported to the UI In-Reply-To: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33482-70-t4YoDtIYR6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33482 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:25:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:25:01 +0000 Subject: [Koha-bugs] [Bug 33402] ERM Cypress tests needs to be moved to their own directory In-Reply-To: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33402-70-kG5GAfmvJ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33402 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- The dependency is the other way around.. 33408 depends upon this. I think the additional_work_needed is a red herring too at this point.. I'm sure Tomas has pushed the follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:29:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:29:38 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-yXxg4Y7uDv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Slava Shishkin <slavashishkin at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Select all/Clear all links |WRAPPER tab_panel breaks JS |on many pages are broken |on some pages (Select | |all/Clear all, post-Ajax | |updates) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:39:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:39:23 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-S7dpHXxedm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:39:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:39:25 +0000 Subject: [Koha-bugs] [Bug 32250] link_bibs_to_authorities generates too many background jobs In-Reply-To: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32250-70-A4LFJNdzAC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32250 --- Comment #16 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150293&action=edit Bug 32250: (follow-up) Remove one more dbh commit and don't start a new transaction when done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:47:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:47:25 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-TXaOGN4ba5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 --- Comment #18 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- Please do, squash everything. I think we also need more tests... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:50:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:50:11 +0000 Subject: [Koha-bugs] [Bug 31740] Illrequests table has a foreign key constraint on status_alias In-Reply-To: <bug-31740-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31740-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31740-70-tnTNKAvmeI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31740 --- Comment #1 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- See also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20581#c156 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:50:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:50:48 +0000 Subject: [Koha-bugs] [Bug 33417] Create one standard Toolbar component In-Reply-To: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33417-70-nv5jy4RJPV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 --- Comment #25 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- I am not sure, see comment 6. I would like to give it a try, but I am lacking time at the moment... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 14:53:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 12:53:18 +0000 Subject: [Koha-bugs] [Bug 33353] Add compatibility with Elasticsearch 8 In-Reply-To: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33353-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33353-70-0twWBNG2o5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353 Lauren Denny <lauren_denny at sil.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 15:08:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 13:08:40 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-bk1y0wdkj7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 15:08:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 13:08:42 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-UDDDIEzRzm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150223|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150294&action=edit Bug 33611: Unit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 15:08:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 13:08:44 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-apmdnroYbB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150295&action=edit Bug 33611: Ensure dt_from_string always returns a new object This patch alters dt_from_string to pass a cloned object if called on an existing date time object This resolves an issue where a holds reserve date was being altered when the default expiration date was set To test: 1 - Set DefaultHoldExpiration to Set 2 - Set DefaultHoldExpirationPeriod to 365 3 - Set DefaultHoldExpirationunitOfTimeToDays 4 - Place a hold 5 - Note reserve date is 1 year in the future, same as expiration 6 - Apply patch 7 - Restart all 8 - Place another hold 9 - Note reserve date is set to today -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 15:08:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 13:08:51 +0000 Subject: [Koha-bugs] [Bug 33611] Holds being placed in the future if DefaultHoldExpirationdate is set In-Reply-To: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33611-70-OJkPagqDbh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33611 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 15:15:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 13:15:38 +0000 Subject: [Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields In-Reply-To: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31187-70-04igjFL6My@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150046|0 |1 is obsolete| | Attachment #150213|0 |1 is obsolete| | Attachment #150278|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150296&action=edit Bug 31187: Preserve permanent_location if it is mapped to a field in the editor To test: 1 - Map permanent_location to a marc field 2 - Expose that field in the item editor 3 - Cataloging -> Batch item modification 4 - Enter the barcode for an item 5 - Change the location of the item and retain the permanent location on saving 6 - note that permanent location is set to locatoin 7 - Apply patch 8 - Repeat 9 - Note permanent location is retained Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> Squashed and amended to fix modified count: Bug 31187: (follow-up) Fix whitespace Bug 31187: Make sure to not count twice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 15:21:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 13:21:18 +0000 Subject: [Koha-bugs] [Bug 33620] Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowerRelationship is empty In-Reply-To: <bug-33620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33620-70-LvF2fYeiBd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150257|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 150297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150297&action=edit Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty To test: 1. Apply patch 2. Have some values in borrowerRelationship. 3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:' 4. Now empty borrowerRelationship. 5. Visit the patron detail page again and you should no longer see either of those fields. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 15:21:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 13:21:43 +0000 Subject: [Koha-bugs] [Bug 33620] Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowerRelationship is empty In-Reply-To: <bug-33620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33620-70-HNXOAVH1zr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #3 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- Works as described, thanks for the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 15:24:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 13:24:12 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-B00Tz723xZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #4 from Slava Shishkin <slavashishkin at gmail.com> --- Created attachment 150298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150298&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to modborrowers.tt The submitted numbers were not processed by the search query. To test: 1. Go to /cgi-bin/koha/circ/modborrowers.pl 2. On the relevant tab, enter the card number or the borrower number in the text area, or upload a text file with a relevant list of numbers. 3. Click "Continue" and verify that a message appears stating "No patron card numbers or borrowernumbers given". 4. Apply the patch. 5. Restart the page and repeat steps 2 and 3. Make sure you receive the correct response -- a list of borrowers or a message indicating that the specified numbers were not found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 15:33:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 13:33:07 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-UPlJdtyD2w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 15:33:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 13:33:10 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-ZuknOdcsmu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149713|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150299&action=edit Bug 33505: Improve styling of scan index page This patch makes some changes to the 'scan index' page. * Updates second h1 heading "Scan index:" to h2 level heading "Scan index" * Removes table from the search form * Moves search index pull down and search term into one line * Reorders options with search index first and search term after, matching the advanced search form * Removes the catalog results toolbar from the top, card hold etc. are not needed here. * Fixes doubled up id attribute: scan-index by turning one into scan-index-term. To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Check display, especially search options, options at the top of the page etc. * Apply patch * Verify changes listed above * Regression test the normal search results, all should look the same with and without patch. * If you think the scan index page is nicer now - sign off. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 15:33:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 13:33:29 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-ATChDMHkia@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 15:33:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 13:33:32 +0000 Subject: [Koha-bugs] [Bug 33506] Series has wrong index name on scan index page and search option selection is not retained In-Reply-To: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33506-70-FZh7bYb2bw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33506 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149620|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150300&action=edit Bug 33506: Fix false index for series and keep selected index on scan index page The pull down with search options had the wrong index linked to the Series entry: su instead of se To test: * Go to advanced search in staff interface * Activate 'More options' * Check checkbox for scan indexes * Switch to author (especially when using Elasticsearch) * Search for C * Verify search results link to authors using c * Switch to series * Verify search results use 'su' for subject * Verify that search option pull down always jumps back to first entry: Any word * Apply patch * Verify the search results for series now use correct index se * Verify that coming from advanced search, the correct search option is selected * Verify that changing the search option also keeps the selection after searching Note: with Elasticsearch and default configuration author, title and series will give you results. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 15:48:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 13:48:50 +0000 Subject: [Koha-bugs] [Bug 33628] New: Show item info in self check-in module Message-ID: <bug-33628-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33628 Bug ID: 33628 Summary: Show item info in self check-in module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mirjam.vantieghem at etf.edu QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently (we are running on Koha 21.11) when returning items with the self check-in module, only the barcodes are displayed after initial input and after confirmation of the check-in. It would be more user-friendly if also the title/author and call number would be displayed, as is the case for the self check-out module. Anyone who knows what code is needed for this? Thank you! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:13:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:13:49 +0000 Subject: [Koha-bugs] [Bug 33629] New: allow pbuilder to use network via build-git-snapshot Message-ID: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 Bug ID: 33629 Summary: allow pbuilder to use network via build-git-snapshot Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com this bug tracks the progress of allowing pbuilder to use network via build-git-snapshot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:16:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:16:30 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-ppabe5sKPv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:16:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:16:32 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-Jkw9a7bdE2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 --- Comment #1 from Mason James <mtj at kohaaloha.com> --- Created attachment 150301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150301&action=edit Bug 33629: allow pbuilder to use network via build-git-snapshot to test... - build master packages, observe failure :( debian/build-git-snapshot -d -v 22.12.00-24~git1 -D dev -b base_22.12.00+deb10 --noautoversion "/usr/bin/perl" build-resources.PL yarn install v1.22.19 warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries. - apply patch - build master packages, observe success :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:18:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:18:23 +0000 Subject: [Koha-bugs] [Bug 32453] Object methods _result and _resultset methods not available in templates In-Reply-To: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32453-70-TffJSx7hIf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32453 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- If you really need to, you can add [% PERL %]$Template::Stash::PRIVATE = undef;[% END %] to the top of your notice to all access to those methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:20:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:20:32 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-5K7k4Lsx0m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to David Nind from comment #6) > This is an improvement, here are some additional things I noted: > > 1. Zebra and Elasticsearch result differences: > - when using Zebra, only 20 results are displayed - it looks to me like > the pagination of search results is missing, or maybe it is too difficult. > - when using Elasticsearch, there is pagination at the bottom (like the > normal staff interface catalog search results) This is because the Zebra scan only returns a single page of results, not a full count - I don't know why, it seems to be a variable we pass/set somewhere, but the scan size is always limited - much deeper bug than this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:23:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:23:28 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-9Au9ZZOUIV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:23:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:23:39 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-dba7zdERW0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:27:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:27:01 +0000 Subject: [Koha-bugs] [Bug 32453] Object methods _result and _resultset methods not available in templates In-Reply-To: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32453-70-GHLtlEm7vW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32453 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:32:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:32:31 +0000 Subject: [Koha-bugs] [Bug 32453] Object methods _result and _resultset methods not available in templates In-Reply-To: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32453-70-FHgUk5E9IH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32453 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:32:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:32:33 +0000 Subject: [Koha-bugs] [Bug 32453] Object methods _result and _resultset methods not available in templates In-Reply-To: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32453-70-2cldLAbJxA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32453 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150302&action=edit Bug 32453: Allow template access to _result/_resultset There are times where it would be really useful to be able to access the underying result or resultset within out templates. However, Template Toolkit itself disallows this, but you can disable this feature by setting the $Template::Stash::PRIVATE package variable to a false value. Test Plan: 1) Modify the CHECKOUT notice, add "*[% biblio._result %]*" to your notice 2) Generate a CHECKOUT notice, note you only get "**" 3) Apply this patch 4) Restart all the things! 5) Generate a CHECKOUT notice, note you know get something like "*Koha::Schema::Result::Biblio=HASH(0x564f907a3390*" in your notice! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:39:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:39:08 +0000 Subject: [Koha-bugs] [Bug 33630] New: Toolbar dropdown-menu doesn't always display well on patron pages Message-ID: <bug-33630-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33630 Bug ID: 33630 Summary: Toolbar dropdown-menu doesn't always display well on patron pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 150303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150303&action=edit 767px example Some of the dropdown-menu's in the toolbar of the patron pages are cut off when viewing a smaller screen sizes. To recreate: -Set viewport to 767px. From a patron page click the 'More' button and see that the dropdown is cut off on the left. ( example attached ) -Set viewport to 563px. From the patron page click the 'Print' button and see that the dropdown is cutoff to the right. ( example attached ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:39:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:39:32 +0000 Subject: [Koha-bugs] [Bug 33630] Toolbar dropdown-menu doesn't always display well on patron pages In-Reply-To: <bug-33630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33630-70-HNf3fg32KE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33630 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150304&action=edit 563px example -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:39:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:39:46 +0000 Subject: [Koha-bugs] [Bug 33630] Toolbar dropdown-menu doesn't always display well on patron pages In-Reply-To: <bug-33630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33630-70-Jeh9hHrWaq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33630 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:40:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:40:32 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-BocZGKQO0m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #21 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 150305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150305&action=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and improves functionality Test plan as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:42:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:42:28 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-ekMl6MaXTS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #22 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- (In reply to Jonathan Druart from comment #19) > Additional notes: > * It would be interesting to have a delay between the requests I've added a setTimeout for 2 seconds between the requests > * We are retrieving the 20 first license when clicking the "Add new license" > button and when opening the dropdown list. Seems like there is an extra one, > is it hiding something? This is now fixed, originally I need to pre-fill the data in the component to make the pagination work but I've solved that issue and it now loads the data only when its opened > * About the scrollbar hitting top when scrolling down, did you have a look > at 'more'? https://select2.org/data-sources/ajax#pagination There isn't a similar functionality for v-select, I'm trying a different method using v-autocomplete as a second option. I'll try and finish that before I go on holiday and see if it offers any improvement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 16:48:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 14:48:35 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-GZc7JcfhMl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 17:07:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 15:07:11 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-OA7PWbQogm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #23 from Jonathan Druart <jonathan.druart+koha at gmail.com> --- (In reply to Matt Blenkinsop from comment #22) > (In reply to Jonathan Druart from comment #19) > > Additional notes: > > * It would be interesting to have a delay between the requests > > I've added a setTimeout for 2 seconds between the requests IIRC we are using 250ms in other places. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 17:11:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 15:11:31 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-3nj2nVk1d2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 17:11:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 15:11:32 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-LjW0WcENRV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150301|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150306&action=edit Bug 33629: allow pbuilder to use network via build-git-snapshot to test... - build master packages, observe failure :( debian/build-git-snapshot -d -v 22.12.00-24~git1 -D dev -b base_22.12.00+deb10 --noautoversion "/usr/bin/perl" build-resources.PL yarn install v1.22.19 warning You don't appear to have an internet connection. Try the --offline flag to use the cache for registry queries. - apply patch - build master packages, observe success :) Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 17:12:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 15:12:02 +0000 Subject: [Koha-bugs] [Bug 26744] Log changes to extended patron attributes In-Reply-To: <bug-26744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26744-70-qypJDpl71S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 17:12:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 15:12:07 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-FQpbr0rwZu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Moving directly to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 17:15:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 15:15:54 +0000 Subject: [Koha-bugs] [Bug 33631] New: results_summary label and content are slightly misaligned in staff interface Message-ID: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Bug ID: 33631 Summary: results_summary label and content are slightly misaligned in staff interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: lucas at bywatersolutions.com Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If you look at the results_summary on either the results or detail pages you will notice that the label and content are slightly misaligned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 17:18:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 15:18:07 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-NDdOMk872R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 17:18:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 15:18:09 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-iPw0LJ5Bp3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150307&action=edit Bug 33631: Fix alignment issue in results_summary To test: 1 On staff results or detail page notice that slight misaligmnet between label and content. 2. Apply patch, yarn_build, clear browser cache 3. Look again, alignment should be fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 17:18:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 15:18:34 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-lTHNpY63i1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 17:22:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 15:22:13 +0000 Subject: [Koha-bugs] [Bug 26744] Log changes to extended patron attributes In-Reply-To: <bug-26744-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26744-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26744-70-lMYFGgUvMs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26744 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 17:39:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 15:39:59 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-z84ys7K9o5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150305|0 |1 is obsolete| | --- Comment #24 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 150308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150308&action=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 17:41:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 15:41:26 +0000 Subject: [Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select In-Reply-To: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32474-70-J4N6zvqENx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150308|0 |1 is obsolete| | --- Comment #25 from Matt Blenkinsop <matt.blenkinsop at ptfs-europe.com> --- Created attachment 150309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150309&action=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 18:45:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 16:45:10 +0000 Subject: [Koha-bugs] [Bug 33632] New: Editing a list with multiple pages always returns to first page Message-ID: <bug-33632-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33632 Bug ID: 33632 Summary: Editing a list with multiple pages always returns to first page Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: estherm at sodaspringsid.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When removing items from page 3 of a 10 page list, the user is always returned to page 1 of the list once the browser refreshes the page. The user than has to navigate back to the page of the list they were working on to continuing to work. This is time consuming when working on large lists. To reproduce: 1. Create a list with enough items to have multiple pages. 2. Navigate to page 3 of the list. 3. Select a few items and remove them from the list. The user is then returned to page 1 of the list. It would be nice if the user was returned to the page they were on, which would be page 3 of this example and not page 1. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 18:49:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 16:49:35 +0000 Subject: [Koha-bugs] [Bug 32453] Object methods _result and _resultset methods not available in templates In-Reply-To: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32453-70-xV55Ks8ngn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32453 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 18:49:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 16:49:37 +0000 Subject: [Koha-bugs] [Bug 32453] Object methods _result and _resultset methods not available in templates In-Reply-To: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32453-70-MVceLY7wIu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32453 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150302|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150310&action=edit Bug 32453: Allow template access to _result/_resultset There are times where it would be really useful to be able to access the underying result or resultset within out templates. However, Template Toolkit itself disallows this, but you can disable this feature by setting the $Template::Stash::PRIVATE package variable to a false value. Test Plan: 1) Modify the CHECKOUT notice, add "*[% biblio._result %]*" to your notice 2) Generate a CHECKOUT notice, note you only get "**" 3) Apply this patch 4) Restart all the things! 5) Generate a CHECKOUT notice, note you know get something like "*Koha::Schema::Result::Biblio=HASH(0x564f907a3390*" in your notice! Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 19:25:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 17:25:46 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-xF8Z141xZ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate, | |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 20:35:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 18:35:21 +0000 Subject: [Koha-bugs] [Bug 33196] Terminology: rephrase Pseudonymization system preference to be more general In-Reply-To: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33196-70-KJXYARHnpx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33196 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 20:35:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 18:35:24 +0000 Subject: [Koha-bugs] [Bug 33196] Terminology: rephrase Pseudonymization system preference to be more general In-Reply-To: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33196-70-GPKhezMqVH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33196 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148506|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150311&action=edit Bug 33196: Generalize pseudonymization system preference description The Pseudonymization system preference description in the staff interface is: "Disable/Enable pseudonymization to comply with GDPR for personal information. Patrons and transactions will be copied to a separate table for statistics purpose." GDPR is a European Union (and, at time of writing, UK) law; it makes the system preference look irrelevant for libraries outside this area. However, this is not correct: pseudonymization may be useful for libraries anywhere. This generalized the system preference description and only uses GDPR as an example instead of the only purpose. It also updates the fields listed to more closely reflect the labels on the patron form. To test: * Search for "Pseudonymization" in the systme preferences * Verify that the description of the system preference is very GDPR * Apply patch * Verify the system preference description is improved https://bugs.koha-community.org/show_bug.cgi?id=33196 Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 20:36:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 18:36:12 +0000 Subject: [Koha-bugs] [Bug 33196] Terminology: rephrase Pseudonymization system preference to be more general In-Reply-To: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33196-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33196-70-Oj91h5UONr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33196 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> --- The changes all make perfect sense, the QA script doesn't complain. An easy PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 20:45:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 18:45:50 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: <bug-33317-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33317-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33317-70-PGO3xmdGDz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> --- Hammat, This is missing a DB update. Have a look at Bug 30403 for an example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 20:51:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 18:51:13 +0000 Subject: [Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories In-Reply-To: <bug-24499-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24499-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24499-70-eYVY8kP59l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> --- Can the DB update be formatted a bit nicer please? Use installer/data/mysql/atomicupdate/skeleton.pl as an example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 21:20:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 19:20:15 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-VooeZmQsjQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 150312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150312&action=edit Bug 33550: Remove period in patron restriction type description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 21:20:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 19:20:17 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-a1VswJD7p0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 150313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150313&action=edit Bug 33550: Remove question mark in breadcrumb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 21:21:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 19:21:28 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-6b3Bt55gWD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 21:21:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 19:21:30 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-Am6A0kYUEt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150307|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 150314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150314&action=edit Bug 33631: Fix alignment issue in results_summary To test: 1 On staff results or detail page notice that slight misaligmnet between label and content. 2. Apply patch, yarn_build, clear browser cache 3. Look again, alignment should be fixed Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 21:22:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 19:22:42 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-kF3zrxmtnV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Hi David, Thanks for you input! I removed the period in the admin section description and changed the breadcrumb of the delete page to "Delete restriction type 'something'" to match the Modify page. Let me know if it worked! Caroline -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 21:24:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 19:24:12 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-aLpb8nrfAA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- Thanks Lucas for reporting and fixing this! I also noticed some ISBD view labels are slightly misaligned (see for example biblionumber=262 Programming Perl). I can log a separate bug for this if you like. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 21:31:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 19:31:12 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-QEjbhp9K7R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 21:31:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 19:31:15 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-YBoOffGhVF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150262|0 |1 is obsolete| | --- Comment #9 from David Nind <david at davidnind.com> --- Created attachment 150315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150315&action=edit Bug 33615: Date picker icon not visible to test: - apply patch, build package - edit item, observe calendar icon is visible Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 21:41:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 19:41:35 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-IINgdEcUqB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 Kristi <kkrueger at cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger at cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 22:22:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 20:22:36 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-DYtgg8wAps@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 22:22:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 20:22:39 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-gJVitykAr7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150229|0 |1 is obsolete| | --- Comment #14 from David Nind <david at davidnind.com> --- Created attachment 150316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150316&action=edit Bug 33550: Rename Patron restrictions administration page to Patron restriction types This patch renames 'Patron restriction' to 'Patron restriction type' in the context of custom restriction type administration. To test: 0. Apply patch 1. Enable PatronRestrictionTypes 2. Go to Administration 3. Check the name, spelling/grammar of the following elements * Section name * Section caption 4. Click 'Patron restriction types' 5. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Left hand side menu * 'New' button * Page heading 6. Click 'New restriction type' 7. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 8. Fill out the form and click 'Save' to create a new restriction type * Dialog message ('Restriction type added') 9. Click 'New restriction type' 10. Enter the same code as last time * Warning ('Restriction type code is already in use') 11. Click 'Cancel' 12. Click 'Edit' next to one of the types 13. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading 14. Without changing anything, click 'Save' * Warning ('Restriction type label is already in use') 15. Change the label and click 'Save' * Dialog message ('Restriction type updated') 16. Click 'Delete' next to one of the types 17. Check the name, spelling/grammar of the following elements * Title of the page (in the browser tab) * Breadcrumb * Page heading * Delete button 18. Click 'Delete this restriction type' * Dialog message ('Restriction type deleted') Signed-off-by: Marius Mandrescu <marius.mandrescu at inLibro.com> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 22:22:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 20:22:42 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-P0FP2L4EOV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150230|0 |1 is obsolete| | --- Comment #15 from David Nind <david at davidnind.com> --- Created attachment 150317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150317&action=edit Bug 33550: (follow-up) Rename Patron restrictions administration page to Patron restriction types) Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 22:22:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 20:22:44 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-l7hBeShslV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150312|0 |1 is obsolete| | --- Comment #16 from David Nind <david at davidnind.com> --- Created attachment 150318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150318&action=edit Bug 33550: Remove period in patron restriction type description Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 22:22:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 20:22:47 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-cIuNU2Fe0k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150313|0 |1 is obsolete| | --- Comment #17 from David Nind <david at davidnind.com> --- Created attachment 150319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150319&action=edit Bug 33550: Remove question mark in breadcrumb Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 22:24:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 20:24:26 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33550-70-s40zJBUgHh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 --- Comment #18 from David Nind <david at davidnind.com> --- (In reply to Caroline Cyr La Rose from comment #13) > Hi David, > > Thanks for you input! I removed the period in the admin section description > and changed the breadcrumb of the delete page to "Delete restriction type > 'something'" to match the Modify page. > > Let me know if it worked! > > Caroline Thanks Caroline! It worked 8-) David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 22:25:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 20:25:29 +0000 Subject: [Koha-bugs] [Bug 33505] Improve styling of scan index page In-Reply-To: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33505-70-gJ5lF1ZUMV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33505 --- Comment #12 from David Nind <david at davidnind.com> --- (In reply to Nick Clemens from comment #11) > (In reply to David Nind from comment #6) > > This is an improvement, here are some additional things I noted: > > > > 1. Zebra and Elasticsearch result differences: > > - when using Zebra, only 20 results are displayed - it looks to me like > > the pagination of search results is missing, or maybe it is too difficult. > > - when using Elasticsearch, there is pagination at the bottom (like the > > normal staff interface catalog search results) > > This is because the Zebra scan only returns a single page of results, not a > full count - I don't know why, it seems to be a variable we pass/set > somewhere, but the scan size is always limited - much deeper bug than this Thanks Nick for explaining. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 22:29:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 20:29:57 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-W9TUJxmkPJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #10 from David Nind <david at davidnind.com> --- Testing notes (using KTD): 1. In the staff interface, edit and item for a record. 2. Note that there is no calendar icon in the 'd - Date acquired' input field. 3. Apply the patch. 4. Rebuild: yarn build 5. Restart all the things: flush_memecached, restart_all 6. Repeat step 1 (refresh the page if required). 7. There is now a calendar icon in the date acquired field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 22:45:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 20:45:52 +0000 Subject: [Koha-bugs] [Bug 18317] Allow check out of already checked out items through SIP In-Reply-To: <bug-18317-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18317-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18317-70-uSz2Saz8sJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18317 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 22:57:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 20:57:53 +0000 Subject: [Koha-bugs] [Bug 31713] Allow easy printing of patron's fines In-Reply-To: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31713-70-r9mgBm7L5Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/669 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 23:07:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 21:07:58 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-nGqMwNGMOx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to David Nind from comment #3) > Thanks Lucas for reporting and fixing this! > > I also noticed some ISBD view labels are slightly misaligned (see for > example biblionumber=262 Programming Perl). I can log a separate bug for > this if you like. David, I am going to provide an alternative patch that will fix both. I think we can eliminate the vertical-align rule altogether. It will effect all label (element) and .label ( class ) in Koha so it will require a bit more thourough testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 23:09:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 21:09:47 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-JrYDFCn0RJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150320&action=edit Bug 33631: [alternate] Fix misaligned labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 23:10:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 21:10:34 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-1Jd5YuWqPR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Slava, is this ready for testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 23:44:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 21:44:20 +0000 Subject: [Koha-bugs] [Bug 24975] Refactor database translations In-Reply-To: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24975-70-imUb5VBRy0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 --- Comment #122 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #121) > See previous comment, that's not relevant. > > (In reply to Katrin Fischer from comment #120) > > > * What to do when the description of an item type is modified? > > > > I think, when an itemtype description is modified, this should not change > > the translations or remove them. Libraries will take care of it and a typo > > fix or modification should not cause any changes. > > This will need to be confirmed however. Confirmed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 27 23:55:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 21:55:24 +0000 Subject: [Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode In-Reply-To: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32341-70-gQlYf7HYNe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 --- Comment #16 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 150321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150321&action=edit Bug 32341: (follow-up) Making the label not showed twice when the tables are in responsive mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 00:20:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 22:20:57 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8367-70-cn5gGnGjat@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #234 from Aleisha Amohia <aleisha at catalyst.net.nz> --- There are lots of signoffs on these patches, can this be marked Passed QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 00:42:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 22:42:56 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-P1zXWgDNPJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 00:42:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 22:42:58 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-zlfqhQrPpU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150263|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150322&action=edit Bug 33621: Fix claim return To test: 1. Set the CaimReturnedLostValue system preference to one of your LOST authorised values 2. Check out an item 3. In the checkouts table, claim return 4. Notice the processing icon keeps spinning 5. Apply the patch 6. Check in the item and resolve the return claim to clear it 7. Check out an item 8. In the checkouts table, claim return 9. Confirm the checkouts table reloads and the return is claimed as expected Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 00:43:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 22:43:33 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-IFq929VcFs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master Change sponsored?|Sponsored |--- Assignee|aleisha at catalyst.net.nz |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 00:50:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 22:50:33 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-WvT2Z9ic7k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 --- Comment #10 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Please ensure this patch is backported to 22.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 00:52:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 22:52:56 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-xuui0XNkU3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 00:55:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 22:55:36 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-NMM5swvfzP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |aleisha at catalyst.net.nz |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:02:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:02:07 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-OE9NVimTk5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:02:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:02:10 +0000 Subject: [Koha-bugs] [Bug 33615] Date picker icon not visible In-Reply-To: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33615-70-2YwC0ipaLF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33615 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150315|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150323&action=edit Bug 33615: Date picker icon not visible to test: - apply patch, build package - edit item, observe calendar icon is visible Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:08:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:08:10 +0000 Subject: [Koha-bugs] [Bug 33622] Notice content does not show on default tab if TranslateNotices enabled In-Reply-To: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33622-70-sMsD7267Jo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33622 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:11:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:11:14 +0000 Subject: [Koha-bugs] [Bug 33633] New: Check if email exists Message-ID: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 Bug ID: 33633 Summary: Check if email exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Is there any kind of mechanism available for Koha to use to test the existence of an email address before actually trying to send an email? It seems like there should be some way to ask email servers if the address at least exists, if not asking the status of the account, so it can make an informed decision on sending notices. Right now, Koha just sends to the address without knowing anything. If it doesn't exist, or is full, or blocked, then it is up to staff to figure it out and pass that information along to the patron. If there is some way to figure this out before sending, then we would be able have Koha do something else, like send to a secondary email address, text, phone, restrict the account, etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:11:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:11:31 +0000 Subject: [Koha-bugs] [Bug 33634] New: Sidebar navigation links in system preferences not taking user to the clicked section Message-ID: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Bug ID: 33634 Summary: Sidebar navigation links in system preferences not taking user to the clicked section Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This is a bug that was reported in 22.11.04 but also exists in main. To reproduce: 1. Go to Koha Administration -> Global system preferences 2. Go to a tab with a few headings like Circulation 3. Click on a heading in the sidebar navigation under Circulation that takes you a bit down the page, like Recalls 4. Notice this anchor link does not work, you are not taken to the recalls preferences -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:11:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:11:38 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-WByNV0zFbX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:12:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:12:00 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-e89RJGNB7W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:12:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:12:09 +0000 Subject: [Koha-bugs] [Bug 33633] Check if email exists In-Reply-To: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33633-70-FgjcW7UzBD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 --- Comment #1 from Christopher Brannon <cbrannon at cdalibrary.org> --- And yes, I know that every server is different, but we could teach Koha the responses of different mail servers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:12:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:12:29 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-PSIxDy2s63@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:21:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:21:45 +0000 Subject: [Koha-bugs] [Bug 33629] allow pbuilder to use network via build-git-snapshot In-Reply-To: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33629-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33629-70-hSf7wT2BKb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33629 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:25:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:25:54 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-pC9GwZBsyK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150267|0 |1 is obsolete| | --- Comment #39 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150324&action=edit Bug 33478: Save notice format settings Save format settings for an individual notice, or for all notices To test: 1. Apply the patches, install database updates, update schema if needed, and restart services 2. Go to Tools -> Notices and slips 3. Edit any notice 4. Go to the Format tab 5. Confirm format settings are available to edit 6. Change some settings and confirm they save correctly 7. Test that 'apply these settings to all notices' option works. Test the confirmation box appears when this is checked. 8. Add a new notice and confirm format settings save successfully Sponsored-by: Colorado Library Consortium -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:25:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:25:57 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-rMAA7AxE2O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150268|0 |1 is obsolete| | --- Comment #40 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150325&action=edit Bug 33478: Apply formatting to HOLD_SLIP To test: 1. Place a hold on a record 2. Check in an item attached to the record 3. When the pop-up for the hold is triggered, confirm hold and print slip 4. Confirm your format settings for HOLD_SLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:26:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:26:00 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-OM3P8qhV1E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150269|0 |1 is obsolete| | --- Comment #41 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150326&action=edit Bug 33478: Apply formatting to AR_SLIP To test: 1. Enable ArticleRequests system preference in Koha Administration -> Global system preferences 2. Log into the OPAC 3. Do a catalogue search 4. Click the 'Request article' button for a record 5. Fill in some information and submit 6. Go to the staff interface 7. Go to Circulation -> Article Requests 8. Click the Actions menu next to your article request and choose Print slip 9. Confirm your format settings for AR_SLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:26:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:26:03 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-iL6ps7bNom@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150270|0 |1 is obsolete| | --- Comment #42 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150327&action=edit Bug 33478: Apply formatting to TRANSFERSLIP To test: 1. Search for an item that was last seen at a library different from your logged in library i.e the holding library is Fairview but your logged in library is Centerville 2. Use the barcode to check in the item 3. When the popup to 'please return this item to <home library>' is triggered, click the Print slip button 4. Confirm your format settings for TRANSFERSLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:26:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:26:05 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-Of3s4IRRdQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150271|0 |1 is obsolete| | --- Comment #43 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150328&action=edit Bug 33478: Apply formatting to OVERDUES_SLIP To test: 1. Check out an item to a user. Set the due date to a time in the past so it is overdue 2. Click Print in the members toolbar, then Print overdues 3. Confirm your format settings for OVERDUES_SLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:26:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:26:08 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-svYWRqKq9p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150272|0 |1 is obsolete| | Attachment #150273|0 |1 is obsolete| | --- Comment #44 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150329&action=edit Bug 33478: Apply formatting to ACCOUNT_DEBIT To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. You'll be redirected to the Transactions tab 4. Click the Print button next to your invoice 5. Confirm your format settings for ACCOUNT_DEBIT are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:26:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:26:11 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-4E4zTf93Yk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #45 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150330&action=edit Bug 33478: Apply formatting to ACCOUNT_DEBIT To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. You'll be redirected to the Transactions tab 4. Click the Pay button next to your invoice and confirm Payment 5. Click the Print button next to your Payment 6. Confirm your format settings for ACCOUNT_CREDIT are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:26:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:26:14 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-Cuje77aMwK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150274|0 |1 is obsolete| | --- Comment #46 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150331&action=edit Bug 33478: Apply formatting to ISSUESLIP, ISSUEQSLIP, CHECKINSLIP To test: 1. Check out an item to a patron 2. Click Print in the members toolbar, then Print quick slip 3. Confirm your format settings for ISSUEQSLIP are applied 4. Click Print in the members toolbar, then Print slip 5. Confirm your format settings for ISSUESLIP are applied 6. Return the item 7. When the item is checked in, click the 'Print checkin slip' button 8. Confirm your format settings for CHECKINSLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:26:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:26:17 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-fItGK6HamR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150275|0 |1 is obsolete| | --- Comment #47 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150332&action=edit Bug 33478: Apply formatting to RECEIPT To test: 1. Enable EnablePointOfSale and UseCashRegisters system preferences in Koha Administration -> Global system preferences 2. Go to Koha Administration -> Cash registers and add a new cash register 3. Go to Koha Administration -> Debit types and add a new debit type. Make sure you check the 'can be sold' option 4. Go to Point of sale 5. Select Add for your item under Items for purchase 6. Fill in Collect payment box and click Confirm 7. When payment is received, click Print receipt 8. Confirm your format settings for RECEIPT are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:26:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:26:20 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-XsRrXMmXER@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150276|0 |1 is obsolete| | --- Comment #48 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150333&action=edit Bug 33478: Apply formatting to ACCOUNTS_SUMMARY To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. Click the Print button in the patron toolbar 4. Click the 'Print account balance' button 5. Confirm your format settings for ACCOUNTS_SUMMARY are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:26:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:26:23 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-tXG2eFRJAP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150277|0 |1 is obsolete| | --- Comment #49 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150334&action=edit Bug 33478: Apply formatting to RECALL_REQUESTER_DET To test: 1. Enable UseRecalls system preference and configure all relevant recalls circulation and fines rules 2. Search for a record with only one item 3. Check out this item to Patron A 4. Log into the OPAC as Patron B 5. Search for the item and place a recall 6. Go back to the staff interface 7. Check in the item 8. When the pop-up for the recall is triggered, confirm recall and print slip 9. Confirm your format settings for RECALL_REQUESTER_DET are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:29:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:29:40 +0000 Subject: [Koha-bugs] [Bug 33633] Check if email exists In-Reply-To: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33633-70-6eYuHSC9gZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook <dcook at prosentient.com.au> --- There's no simple way to test the existence of an email address before actually trying to send an email. There are whole software systems that combine a number of different methods to try to guess if an email address is valid, but even then it's essentially an educated guess. So I don't think that aspect would be something included in Koha. -- However, perhaps there could be a better way of falling back to another method if one fails. Also, Koha could include an "email_verified" column. Many systems will ask you to verify your email. That could be a worthwhile addition to Koha for sure. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:40:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:40:07 +0000 Subject: [Koha-bugs] [Bug 33627] OAI-PMH script build_oai_sets.pl is slow and memory hungry In-Reply-To: <bug-33627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33627-70-a11jbvJMTJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33627 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:44:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:44:40 +0000 Subject: [Koha-bugs] [Bug 30590] Add option for using AutoSelfCheckID and AutoSelfCheckPass values to log into OPAC self check-in module In-Reply-To: <bug-30590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30590-70-CtgYcZEeYV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30590 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 01:49:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Apr 2023 23:49:25 +0000 Subject: [Koha-bugs] [Bug 33633] Check if email exists In-Reply-To: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33633-70-LLQXOQqwPS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 --- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to David Cook from comment #2) > There's no simple way to test the existence of an email address before > actually trying to send an email. There are sites that will test. Like https://email-checker.net/. It even seems to offer an API. Even if it isn't 100%, it could offer a way to say to staff, hey, something might be wrong here. Better verify. And then we can mark if it has been verified. > However, perhaps there could be a better way of falling back to another > method if one fails. > > Also, Koha could include an "email_verified" column. Many systems will ask > you to verify your email. That could be a worthwhile addition to Koha for > sure. Yes, I have actually filed another bug somewhere asking for that very thing. Maybe someday. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 02:10:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 00:10:46 +0000 Subject: [Koha-bugs] [Bug 33633] Check if email exists In-Reply-To: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33633-70-hEb97ds4RG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- (In reply to Christopher Brannon from comment #3) > (In reply to David Cook from comment #2) > > There's no simple way to test the existence of an email address before > > actually trying to send an email. > > There are sites that will test. Like https://email-checker.net/. It even > seems to offer an API. Even if it isn't 100%, it could offer a way to say > to staff, hey, something might be wrong here. Better verify. And then we > can mark if it has been verified. As I said before, there are entire software systems devoted to this, yes. If you look at the "How do we verify an email" section of https://email-checker.net/, you'll see that it's a multi-step process and not 100%. Koha already checks the email address format. Previously, we've talked a bit about checking the domain name and MX records, but it never went anywhere. As for simulating sending a message, that's more complex. Perhaps this is an area where a Koha plugin hook could be added. > > However, perhaps there could be a better way of falling back to another > > method if one fails. > > > > Also, Koha could include an "email_verified" column. Many systems will ask > > you to verify your email. That could be a worthwhile addition to Koha for > > sure. > > Yes, I have actually filed another bug somewhere asking for that very thing. > Maybe someday. :) If you sponsor the change, it'll be more likely to get done. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 02:11:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 00:11:01 +0000 Subject: [Koha-bugs] [Bug 31391] Staff-side recalls In-Reply-To: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31391-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31391-70-cvVPD76b6K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 02:29:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 00:29:00 +0000 Subject: [Koha-bugs] [Bug 29653] Return claims on deleted items In-Reply-To: <bug-29653-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29653-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29653-70-cx6sHD1khH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29653 Suzanne <smhodson123extra at yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 CC| |smhodson123extra at yahoo.com --- Comment #1 from Suzanne <smhodson123extra at yahoo.com> --- Yes, we would absolutely like to track claimed returns on items removed from the system. We usually remove them pretty quickly, but still want them to be counted on the patron's record, to prevent misuse. It could still be an option, as maybe some libraries would prefer not to count them once the item is removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 02:34:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 00:34:09 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-UqGr62BR4y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #9 from David Cook <dcook at prosentient.com.au> --- (In reply to Katrin Fischer from comment #7) > Marked bug 32385 as a dependency for this one. I think in order to have > different timeouts, we need different sessions first. Actually, thinking about this again, you would already have different sessions between the OPAC and staff interface, so long as your hostname is different, which should be 99% of Koha instances... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 03:19:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 01:19:27 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-cfXVoQI8F4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150324|0 |1 is obsolete| | --- Comment #50 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150335&action=edit Bug 33478: Save notice format settings Save format settings for an individual notice, or for all notices To test: 1. Apply the patches, install database updates, update schema if needed, and restart services 2. Go to Tools -> Notices and slips 3. Edit any notice 4. Go to the Format tab 5. Confirm format settings are available to edit 6. Change some settings and confirm they save correctly 7. Test that 'apply these settings to all notices' option works. Test the confirmation box appears when this is checked. 8. Add a new notice and confirm format settings save successfully Sponsored-by: Colorado Library Consortium -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 03:19:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 01:19:30 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-VHH4SVhkn4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150325|0 |1 is obsolete| | --- Comment #51 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150336&action=edit Bug 33478: Apply formatting to HOLD_SLIP To test: 1. Place a hold on a record 2. Check in an item attached to the record 3. When the pop-up for the hold is triggered, confirm hold and print slip 4. Confirm your format settings for HOLD_SLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 03:19:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 01:19:33 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-eYk69ZkqrZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150326|0 |1 is obsolete| | --- Comment #52 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150337&action=edit Bug 33478: Apply formatting to AR_SLIP To test: 1. Enable ArticleRequests system preference in Koha Administration -> Global system preferences 2. Log into the OPAC 3. Do a catalogue search 4. Click the 'Request article' button for a record 5. Fill in some information and submit 6. Go to the staff interface 7. Go to Circulation -> Article Requests 8. Click the Actions menu next to your article request and choose Print slip 9. Confirm your format settings for AR_SLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 03:19:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 01:19:36 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-Sv6kuIxkHJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150327|0 |1 is obsolete| | --- Comment #53 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150338&action=edit Bug 33478: Apply formatting to TRANSFERSLIP To test: 1. Search for an item that was last seen at a library different from your logged in library i.e the holding library is Fairview but your logged in library is Centerville 2. Use the barcode to check in the item 3. When the popup to 'please return this item to <home library>' is triggered, click the Print slip button 4. Confirm your format settings for TRANSFERSLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 03:19:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 01:19:39 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-JqwZHNMewz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150328|0 |1 is obsolete| | --- Comment #54 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150339&action=edit Bug 33478: Apply formatting to OVERDUES_SLIP To test: 1. Check out an item to a user. Set the due date to a time in the past so it is overdue 2. Click Print in the members toolbar, then Print overdues 3. Confirm your format settings for OVERDUES_SLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 03:19:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 01:19:42 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-LVhVxTTWFU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150329|0 |1 is obsolete| | Attachment #150330|0 |1 is obsolete| | --- Comment #55 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150340&action=edit Bug 33478: Apply formatting to ACCOUNT_DEBIT To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. You'll be redirected to the Transactions tab 4. Click the Print button next to your invoice 5. Confirm your format settings for ACCOUNT_DEBIT are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 03:19:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 01:19:46 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-0XtXUXZkwk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 --- Comment #56 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150341&action=edit Bug 33478: Apply formatting to ACCOUNT_CREDIT To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. You'll be redirected to the Transactions tab 4. Click the Pay button next to your invoice and confirm Payment 5. Click the Print button next to your Payment 6. Confirm your format settings for ACCOUNT_CREDIT are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 03:19:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 01:19:49 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-qR0yCmg5cV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150331|0 |1 is obsolete| | --- Comment #57 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150342&action=edit Bug 33478: Apply formatting to ISSUESLIP, ISSUEQSLIP, CHECKINSLIP To test: 1. Check out an item to a patron 2. Click Print in the members toolbar, then Print quick slip 3. Confirm your format settings for ISSUEQSLIP are applied 4. Click Print in the members toolbar, then Print slip 5. Confirm your format settings for ISSUESLIP are applied 6. Return the item 7. When the item is checked in, click the 'Print checkin slip' button 8. Confirm your format settings for CHECKINSLIP are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 03:19:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 01:19:52 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-fDJSA6dni5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150332|0 |1 is obsolete| | --- Comment #58 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150343&action=edit Bug 33478: Apply formatting to RECEIPT To test: 1. Enable EnablePointOfSale and UseCashRegisters system preferences in Koha Administration -> Global system preferences 2. Go to Koha Administration -> Cash registers and add a new cash register 3. Go to Koha Administration -> Debit types and add a new debit type. Make sure you check the 'can be sold' option 4. Go to Point of sale 5. Select Add for your item under Items for purchase 6. Fill in Collect payment box and click Confirm 7. When payment is received, click Print receipt 8. Confirm your format settings for RECEIPT are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 03:19:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 01:19:55 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-xUzs3Z9hY5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150333|0 |1 is obsolete| | --- Comment #59 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150344&action=edit Bug 33478: Apply formatting to ACCOUNTS_SUMMARY To test: 1. Go to a patron accounting page 2. Create a manual invoice and Save 3. Click the Print button in the patron toolbar 4. Click the 'Print account balance' button 5. Confirm your format settings for ACCOUNTS_SUMMARY are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 03:19:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 01:19:58 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-bEBjjQZAV7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150334|0 |1 is obsolete| | --- Comment #60 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150345&action=edit Bug 33478: Apply formatting to RECALL_REQUESTER_DET To test: 1. Enable UseRecalls system preference and configure all relevant recalls circulation and fines rules 2. Search for a record with only one item 3. Check out this item to Patron A 4. Log into the OPAC as Patron B 5. Search for the item and place a recall 6. Go back to the staff interface 7. Check in the item 8. When the pop-up for the recall is triggered, confirm recall and print slip 9. Confirm your format settings for RECALL_REQUESTER_DET are applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:21:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:21:28 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-GzViYgk2GS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 [Bug 33260] Show message queue on staff interface and make notices printable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:21:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:21:28 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-N8NnIH8D0y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff Depends on| |33478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 [Bug 33478] Customise the format of notices when they are printed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:21:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:21:32 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-zolYmJ6fLi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149597|0 |1 is obsolete| | --- Comment #18 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150346&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:21:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:21:35 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-UbySAyQyIa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149598|0 |1 is obsolete| | --- Comment #19 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150347&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:22:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:22:50 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33260-70-XyB18wBYeg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #20 from Aleisha Amohia <aleisha at catalyst.net.nz> --- I've rebased this to build on top of Bug 33478 and use the format settings. Only the patch "Bug 33260: Add Notice management tool" needs to be re-tested and a new sign-off line added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:29:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:29:51 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20844-70-jhKwxVUKbo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:29:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:29:55 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20844-70-3T57kOIqxL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140214|0 |1 is obsolete| | --- Comment #57 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150348&action=edit Bug 20844: Revert or cancel lost holds This patch introduces the RevertLostBibLevelHolds syspref. When an item is marked as lost, if there is a bib-level hold on it waiting, the hold is reverted. If there is an item-level hold on it waiting, there is an alert box asking if the library would like to revert the hold or cancel it. Test: 1) Update database and restart memcached/plack 2) Place a hold on Biblio A 3) Check in Item A from Biblio A and set the hold as waiting 4) Edit Item A and give it a lost status (952$1, you may need to edit your MARC frameworks to have this visible in the Editor) 5) Look at your hold. Notice it is still waiting. 6) Go to Administration -> System preferences. Find the RevertLostBibLevelHolds system preference and enable it. 7) Cancel your hold and remove Item A's lost status. Place another biblio-level hold on the same biblio 8) Check in Item A from Biblio A and set the hold as waiting 9) Go to the Items tab for Biblio A (catalogue/moredetail.pl) 10) Edit Item A and give it a lost status 11) Once the page reloads, go to view your hold. It should no longer be waiting and have no item allocated. 12) Cancel your hold and remove Item A's lost status. Place an item-level hold on Item A 13) Check in Item A and set the hold as waiting 14) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and click 'Edit' for Item A (end up on cataloguing/additem.pl) 15) Give Item A a lost status and save changes 16) Once the page reloads, confirm there is an alert box asking you to revert or cancel the hold. Click Revert 17) Confirm your hold is no longer waiting, but the item is still allocated 18) Remove Item A's lost status 19) Check in Item A and set the hold as waiting 20) Go to the catalogue detail page for Biblio A (catalogue/detail.pl) and click 'Edit' for Item A (end up on cataloguing/additem.pl) 21) Give Item A a lost status and save changes 22) Once the page reloads, confirm there is an alert box asking you to revert or cancel the hold. Click Cancel 23) Confirm the hold is now cancelled 24) Remove Item A's lost status 25) Place an item-level hold on Item A 26) Check in Item A and set the hold as waiting 27) Go to the Items tab for Biblio A (catalogue/moredetail.pl) 28) Give Item A a lost status and save changes 29) Once the page reloads, confirm there is an alert box asking you to revert or cancel the hold. Click Revert 30) Confirm your hold is no longer waiting, but the item is still allocated 31) Remove Item A's lost status 32) Check in Item A and set the hold as waiting 33) Go to the Items tab for Biblio A (catalogue/moredetail.pl) 34) Give Item A a lost status and save changes 35) Once the page reloads, confirm there is an alert box asking you to revert or cancel the hold. Click Cancel 36) Confirm the hold is now cancelled 37) Remove Item A's lost status 38) Place an item-level hold on Item A. Check in Item A and set the hold as waiting 39) Place an item-level hold on Item B (same biblio) for another borrower. Check in Item B and set the hold as waiting. 40) Give both Items A and B lost statuses. 41) Confirm that both Items are included in the alert box on page when editing items (cataloguing/additem.pl) 42) Confirm that both Items have individual alert boxes on the Items tab (catalogue/moredetail.pl) 43) Confirm tests pass t/db_dependent/Reserves.t Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:29:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:29:59 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20844-70-fxfFPbvanw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140215|0 |1 is obsolete| | --- Comment #58 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150349&action=edit Bug 20844: (follow-up) SendLostHoldNotices This patch adds a new syspref SendLostHoldNotices Test: 1) Update database and restart memcached 2) Enable the SendLostHoldNotices system preference 3) Place a hold on an item 4) Check in the item and set the hold to waiting 5) Go to edit the item and set an item lost status 6) Check the borrower's notices and confirm the notice has been enqueued 7) Confirm the notice is not sent twice when reverting or cancelling the hold 8) Confirm notice enqueues as expected for a bib-level hold Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:30:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:30:03 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20844-70-kq86ovl75s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140216|0 |1 is obsolete| | --- Comment #59 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150350&action=edit Bug 20844: (follow-up) Get working with transfers Test: 1) Change branch to Branch B 2) Place a biblio-level hold at Branch B 3) Change branch to Branch A 4) Check in item at Branch A and set waiting and trigger transfer 5) Go to edit item and set item as lost 6) Check borrower's notices tab and confirm the lost_waiting_hold notice was enqueued 7) Follow test plan again with item-level hold Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:52:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:52:38 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-tomOf1zjuw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |aleisha at catalyst.net.nz |y.org | CC| |aleisha at catalyst.net.nz Status|Signed Off |Failed QA --- Comment #17 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Please move schema update to a separate patch. Once fixed I'll be happy to pass QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:56:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:56:11 +0000 Subject: [Koha-bugs] [Bug 31498] Allow for custom primary contact method values In-Reply-To: <bug-31498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31498-70-pgIe4MvHk6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31498 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |aleisha at catalyst.net.nz |y.org | CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:56:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:56:32 +0000 Subject: [Koha-bugs] [Bug 31498] Allow for custom primary contact method values In-Reply-To: <bug-31498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31498-70-hJIOjgJeov@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31498 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:56:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:56:35 +0000 Subject: [Koha-bugs] [Bug 31498] Allow for custom primary contact method values In-Reply-To: <bug-31498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31498-70-FXivNTPAuD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31498 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147410|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150351&action=edit Bug 31498: Make primary_contact_method values configurable This patch makes the primary_contact_method field configurable by tying the values to the new CONTACT_METHODS authorized value. To test: 1. Apply patch, updatedatabase, and restart_all 2. Now to go edit or create a new patron and check the 'Main contact method' dropdown. The values should be the same as they were previuosly. ( Primary phone, Secondary phone, Other phone, Primary email, Secondary email, and Fax ) 3. Try editing some patrons and changing these values, making sure they save correctly. 4. Go to the patron detail tab and make sure the correct values are displaying under 'Main contact method'. 5. Go to the OPAC and trying saving and changing the values on both the self registratin form and the modification form. 6. Now go to Administration > Authorized values > CONTACT_METHODS. Add some new CONTACT_METHODS. 7. With some ew values added try going through steps 3, 4, and 5 again. Make sure everything is displaying and saving correctly. 8. Make sure you can still hide and make required the primary_contact_method via these system prefs: BorrowerUnwantedField, PatronSelfModificationBorrowerUnwantedField, PatronSelfRegistrationBorrowerUnwantedField BorrowerMandatoryField, PatronSelfRegistrationBorrowerMandatoryField Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:57:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:57:32 +0000 Subject: [Koha-bugs] [Bug 33203] Overdue notice/status triggers letter selection is ambiguous In-Reply-To: <bug-33203-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33203-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33203-70-f8F0EbR3tj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33203 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz QA Contact|testopia at bugs.koha-communit |aleisha at catalyst.net.nz |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:59:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:59:17 +0000 Subject: [Koha-bugs] [Bug 33203] Overdue notice/status triggers letter selection is ambiguous In-Reply-To: <bug-33203-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33203-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33203-70-KJgZlleS2K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33203 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 05:59:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 03:59:20 +0000 Subject: [Koha-bugs] [Bug 33203] Overdue notice/status triggers letter selection is ambiguous In-Reply-To: <bug-33203-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33203-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33203-70-QYpEXr7ygE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33203 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148154|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150352&action=edit Bug 33203: Add letter_code to the letter dropdown text To test: 1. Add a new notice in the Circulation module with a letter code of 'ABC'. Give the new notice a name of 'Overdue notice'. 2. Now to go Overdue notice/status triggers and look at the dropdown, notice 2 choices that both read 'Overdue notice'. 3. Apply patch and try again. 4. The new notice should now read "Overdue notice (ABC)" and should be easy to distinguish from the original. Signed-off-by: Sally <sally.healey at cheshiresharedservices.gov.uk> Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 06:02:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 04:02:38 +0000 Subject: [Koha-bugs] [Bug 33029] Add wrapper method for dt_from_string to KohaDates template toolkit plugin In-Reply-To: <bug-33029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33029-70-Ukqh4BlD9L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33029 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz QA Contact|testopia at bugs.koha-communit |aleisha at catalyst.net.nz |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 06:02:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 04:02:55 +0000 Subject: [Koha-bugs] [Bug 33029] Add wrapper method for dt_from_string to KohaDates template toolkit plugin In-Reply-To: <bug-33029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33029-70-kv67G9obuO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33029 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 06:02:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 04:02:58 +0000 Subject: [Koha-bugs] [Bug 33029] Add wrapper method for dt_from_string to KohaDates template toolkit plugin In-Reply-To: <bug-33029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33029-70-0fFUys1YLX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33029 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148263|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150353&action=edit Bug 33029: Add wrapper method for dt_from_string to KohaDates template toolkit plugin It would be very useful to have direct access to dt_from_string in our templates. This would allow for us to handle custom date and time formatting. It would, for example, allow us to output the month name for a given date via Template Toolkit easily. Test Plan: 1) Apply this patch 2) In a notice add '[% Use KohaDates %][% KohaDates.datetime_from_string().ymd %]' to the top of a notice 3) Generate that notice for a patron 4) Note today's date in iso format is rendered at the top of the notice Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 06:05:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 04:05:45 +0000 Subject: [Koha-bugs] [Bug 30621] Author should be its own column on opac-readingrecord.tt In-Reply-To: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30621-70-K0o8zTGFLt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30621 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |aleisha at catalyst.net.nz |y.org | CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 06:06:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 04:06:21 +0000 Subject: [Koha-bugs] [Bug 30621] Author should be its own column on opac-readingrecord.tt In-Reply-To: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30621-70-OMlZTdwZke@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30621 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 06:06:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 04:06:23 +0000 Subject: [Koha-bugs] [Bug 30621] Author should be its own column on opac-readingrecord.tt In-Reply-To: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30621-70-2NaFkj03eh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30621 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149049|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150354&action=edit Bug 30621: Add author column to opac-readingrecord.tt To test: 1. Have a patron with some checkout history. 2. Go to that patrons OPAC reading history page, notice author is listed in the same column as title. You cannot sort by author. 3. Apply patch and look again. 4. Now there should be an author column that allows patrons to sort by it. Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 06:08:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 04:08:56 +0000 Subject: [Koha-bugs] [Bug 33053] Tables item_groups and recalls have a biblio_id column with a default of 0 In-Reply-To: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33053-70-5VDCtHibQk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33053 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 06:08:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 04:08:59 +0000 Subject: [Koha-bugs] [Bug 33053] Tables item_groups and recalls have a biblio_id column with a default of 0 In-Reply-To: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33053-70-BGo07FeEOm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33053 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149075|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150355&action=edit Bug 33053: Remove default value for tables item_groups and recalls These default biblio_ids of 0 are harmless but incorrect. The default values should be removed. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Biblio.t 3) prove t/db_dependent/Koha/Recalls.t Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 06:09:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 04:09:02 +0000 Subject: [Koha-bugs] [Bug 33053] Tables item_groups and recalls have a biblio_id column with a default of 0 In-Reply-To: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33053-70-XwxQwa2lL5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33053 --- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150356&action=edit Bug 33053: (QA follow-up) fix syntax error Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 06:09:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 04:09:08 +0000 Subject: [Koha-bugs] [Bug 33053] Tables item_groups and recalls have a biblio_id column with a default of 0 In-Reply-To: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33053-70-nNzZFMcb9d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33053 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |aleisha at catalyst.net.nz |y.org | CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 08:05:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 06:05:53 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-nyBTR0kwsZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to David Cook from comment #9) > (In reply to Katrin Fischer from comment #7) > > Marked bug 32385 as a dependency for this one. I think in order to have > > different timeouts, we need different sessions first. > > Actually, thinking about this again, you would already have different > sessions between the OPAC and staff interface, so long as your hostname is > different, which should be 99% of Koha instances... How do you calculate that 99% ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 08:23:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 06:23:55 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-Xqek0XCkJJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #11 from David Cook <dcook at prosentient.com.au> --- (In reply to Marcel de Rooy from comment #10) > (In reply to David Cook from comment #9) > > (In reply to Katrin Fischer from comment #7) > > > Marked bug 32385 as a dependency for this one. I think in order to have > > > different timeouts, we need different sessions first. > > > > Actually, thinking about this again, you would already have different > > sessions between the OPAC and staff interface, so long as your hostname is > > different, which should be 99% of Koha instances... > > How do you calculate that 99% ? Perhaps I should say 99% of commercially supported Koha instances. Even then you're right that it's a total guess based off the idea that Koha defaults to separate hostname for OPAC and staff interface when using Debian packages, and most commercial support vendors for Koha seem to use Debian packages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 08:39:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 06:39:58 +0000 Subject: [Koha-bugs] [Bug 33631] results_summary label and content are slightly misaligned in staff interface In-Reply-To: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33631-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33631-70-Lk6bIUw8fm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33631 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Lucas Gass from comment #4) > (In reply to David Nind from comment #3) > > Thanks Lucas for reporting and fixing this! > > > > I also noticed some ISBD view labels are slightly misaligned (see for > > example biblionumber=262 Programming Perl). I can log a separate bug for > > this if you like. > > David, > > I am going to provide an alternative patch that will fix both. I think we > can eliminate the vertical-align rule altogether. It will effect all label > (element) and .label ( class ) in Koha so it will require a bit more > thourough testing. Back to NSO for such testing :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 08:41:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 06:41:32 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-8V4lmBdL66@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 08:42:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 06:42:15 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-JR5PzUg0Y0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #19) > Could you review my follow-up Agustin? Changing status to reflect need for feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 08:44:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 06:44:00 +0000 Subject: [Koha-bugs] [Bug 23781] Recalls notices and messaging preferences In-Reply-To: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23781-70-BD0u2Y606H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Applying: Bug 23781: SMS notices and messaging preferences for recalls Using index info to reconstruct a base tree... M Koha/Recall.pm M Koha/Recalls.pm M installer/data/mysql/en/mandatory/sample_notices.yml Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/en/mandatory/sample_notices.yml Auto-merging Koha/Recalls.pm CONFLICT (content): Merge conflict in Koha/Recalls.pm Auto-merging Koha/Recall.pm CONFLICT (content): Merge conflict in Koha/Recall.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 08:44:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 06:44:59 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28726-70-u2hR7gfFEY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 08:45:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 06:45:01 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28726-70-NSH0NAFGq0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 08:55:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 06:55:57 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28726-70-nscmDE07GU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:01:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:01:33 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28726-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28726-70-N717EsJQPc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 --- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- If I am adding borrowers to the patron card batch, I am still seeing the box "There are no patrons in this batch" and I have no possibility to go further? Could be that I am missing config data for this module still, but this form should be more helpful. Probably out of scope, but it limits testing of this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:19:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:19:13 +0000 Subject: [Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field In-Reply-To: <bug-33039-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33039-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33039-70-apZrT1d1Eo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy at rijksmuseum.nl --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:22:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:22:41 +0000 Subject: [Koha-bugs] [Bug 32453] Object methods _result and _resultset methods not available in templates In-Reply-To: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32453-70-jxoEKBdkS1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32453 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Not sure if we should go this way and put such constructs in our templates too. This needs a broader dev discussion. Please trigger it by mailing dev list or putting it on dev meeting agenda. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:26:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:26:57 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-kMtLrqB0DT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nick said: "The only bit I am not sure about is the indexing, there is some massaging it looks like in the utils - and I don't see where we have an equivalent in ES" So, that confirms my suspicions that we might need to do more for this to work with ES -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:30:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:30:04 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-oGRuBib1DZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149906|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150357&action=edit Bug 29185: Facilitate searching for cnum Instead of typing the case sensitive Control-number each time. 4 strikes instead of 15 on your keyboard. Wow! Gain of 73%. Test plan: Copy ccl.properties to /etc/koha/zebradb, restart Zebra and search for cnum=SOME_ID in opac or intranet. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:30:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:30:06 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-i0v5PfUeqx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149907|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150358&action=edit Bug 29185: Groundwork: add template GetCnumSearchURL in Utils Note for QA: Opened bug 33515 to see if we can use this same function in a few other places too. Would probably reduce code and increase consistency. Test plan: See next patch. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:30:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:30:09 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-HFXHL0N33s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149908|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 150359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150359&action=edit Bug 29185: Display MARC tag 765 in OPAC and intranet XSLT Test plan: ** For OPAC [1] Pick a biblio record A as original entry, fill $001/$003. [2] Pick another biblio record B as translation, add 765 with $t, $a and $d. Put (orgcode)cnum from A into $w. [3] Disable UseControlNumber. [4] Goto OPAC detail page of B. Check link; should be title based. [5] Enable UseControlNumber. [6] Goto OPAC detail page of B. Check link; should incl orgcode and cnum. [7] Edit B. Replace $w with cnum of A only. [8] Goto OPAC detail page of B. Check link; should incl cnum only. ** For staff client [9] Goto staff detail page of B. Check link again. [10] Edit B. Set 765 ind2 to 8, fill $i. [11] Goto staff detail page of B. You should see different label. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:30:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:30:53 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-9a3AC6LAfr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- OK, confirms we're only adding an alias here and elasticsearch is handled. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:32:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:32:03 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-Bdh5k8aM8x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #11) > Nick said: > > "The only bit I am not sure about is the indexing, there is some massaging > it looks like in the utils - and I don't see where we have an equivalent in > ES" > > So, that confirms my suspicions that we might need to do more for this to > work with ES >From IRC: [09:26] <marcelr> +++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm @@ -82,6 +82,7 @@ our %index_field_convert = ( + 'cnum' => 'control-number', [09:28] <marcelr> admin/searchengine/elasticsearch/mappings.yaml: control-number: [09:28] <marcelr> i am not adding something new, but just an alias -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:32:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:32:13 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-CvriAUuRpm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #17 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #15) > OK, confirms we're only adding an alias here and elasticsearch is handled. > > Passing QA Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:35:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:35:12 +0000 Subject: [Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field In-Reply-To: <bug-33039-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33039-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33039-70-JF4eZVq23D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- +use Carp qw( croak ); Shouldnt we use exceptions now ? PERL26: Koha::Exceptions (Approved on Apr 26, 2017) Instead of die or croak when meeting unfavorable conditions in our code, we should raise exceptions via Koha::Exceptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:54:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:54:02 +0000 Subject: [Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field In-Reply-To: <bug-33039-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33039-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33039-70-p5xqxuOCxx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- + if ( index( $template, '[%' ) != -1 ) { # Much faster than regex No problem, but 'much' sounds like exaggerating :) Just in memory.. The variable name could be confusing btw. It is template code. This call worries me: + my $tt = Template->new( + { + EVAL_PERL => 1, + ABSOLUTE => 1, + PLUGIN_BASE => 'Koha::Template::Plugin', + COMPILE_EXT => $use_template_cache ? '.ttc' : '', + COMPILE_DIR => $use_template_cache ? C4::Context->config('template_cache_dir') : '', + FILTERS => {}, + ENCODING => 'UTF-8', + } + ) or die Template->error(); Would prefer to see calling something central like in C4::Templates or in C4::Letters instead. + $schema->txn_begin; + try { + my $text; + $tt->process( Please explain why a process call would need a transaction. Can we just remove it ? Could generating alternative text via a Koha plugin be easier somehow? And without needing a db revision ? Note that we already have: Koha/Plugins/Base.pm: $args->{'template'} = Template->new( { ABSOLUTE => 1, ENCODING => 'UTF-8' } ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:59:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:59:35 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26597-70-pqJkGjGmE0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED CC| |m.de.rooy at rijksmuseum.nl --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 09:59:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 07:59:52 +0000 Subject: [Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field In-Reply-To: <bug-33039-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33039-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33039-70-F9peXBwd65@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 10:47:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 08:47:55 +0000 Subject: [Koha-bugs] [Bug 33336] Use a dedicated column for plugin status in plugins table In-Reply-To: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33336-70-Q4eAiChTya@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33336 --- Comment #9 from Fridolin Somers <fridolin.somers at biblibre.com> --- (In reply to Matt Blenkinsop from comment #8) > Hi Fridolin, I'm happy to backport this but we are currently in string > freeze as we head towards this months release. We'll backport this at the > start of next month once this release is finished Great -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 10:58:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 08:58:08 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-26597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-26597-70-4VmVdGU0vg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt FAIL filters missing_filter at line 1921 ( guarantor_attributes = [% To.json(guarantor_attributes) %];) missing_filter at line 1924 ( to_api_mapping = [% To.json(to_api_mapping) %];) Please fix. + error:function(){ + $('#saverecord').prop('disabled', false); Shouldnt we do more than that ? koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: select_user( borrowernumber, JSON.parse(borrower_data) ); koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: function select_user(borrowernumber, data) { koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: p.select_user(borrowernumber, data); koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt: function select_user(borrowernumber, borrower) { It seems that we are overloading this function name already. So no blocker for this report. Just noting. But might be a chance to rename in members.js? The name is quite obscure for copying guarantor information. koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: select_user( '[% g.patron.borrowernumber | html %]', [% To.json( g.patron.unblessed ) | $raw %], '[% g.relationship | html %]' ); koha-tmpl/intranet-tmpl/prog/js/members.js:function select_user(borrowernumber, borrower, relationship) { [% IF new_guarantors %] [% FOREACH g IN new_guarantors %] select_user( '[% g.patron.borrowernumber | html %]', [% To.json( g.patron.unblessed ) | $raw %], '[% g.relationship | html %]' ); [% END %] [% END %] Please explain why whe should do an ajax GET in select_user when we pass the borrower unblessed hash to this function? This does not look good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 11:07:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 09:07:25 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-slhDIrOj28@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 11:08:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 09:08:48 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31735-70-HFeeooHD52@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 11:32:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 09:32:10 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-jikehJjXWO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #78 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Still applies. Looking here (a bit) Searched for the syntax error by going back patches: HEAD is now at 3aa1c17185 Bug 29523: Add Koha::Object->accessible root at master:/usr/share/koha# perl -cw t/db_dependent/Koha/Object.t t/db_dependent/Koha/Object.t syntax OK The next patch is the faulty one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 11:33:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 09:33:32 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-leqxGZdXzt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #79 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- + subtest 'accessible usage tests' => sub { + + plan tests => 2; + + $schema->storage->txn_begin; + + my $library_1 = $builder->build_object( { class => 'Koha::Libraries' } ); + my $library_2 = $builder->build_object( { class => 'Koha::Libraries' } ); + + my $patron = $builder->build_object( + { + class => 'Koha::Patrons', + value => { + flags => 2**2, # only has catalogue permissions + branchcode => $library_1->id + } + } + ); + There is no end subtest here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 11:39:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 09:39:18 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29523-70-z3OdaD6Tmh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #80 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Code for this test has been moved during the rebase somehow. Please fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 11:52:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 09:52:21 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-kL2zzFtwF9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- let formated_date = $datetime(data.created_on); Typo formatted. But what is $datetime ?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 11:52:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 09:52:28 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-1jLIzCdHLe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 12:00:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 10:00:13 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-KypfGYRKaM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 12:00:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 10:00:15 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-8EVcXnG5F6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150322|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150360&action=edit Bug 33621: Fix claim return To test: 1. Set the CaimReturnedLostValue system preference to one of your LOST authorised values 2. Check out an item 3. In the checkouts table, claim return 4. Notice the processing icon keeps spinning 5. Apply the patch 6. Check in the item and resolve the return claim to clear it 7. Check out an item 8. In the checkouts table, claim return 9. Confirm the checkouts table reloads and the return is claimed as expected Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 12:00:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 10:00:18 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-WOSM3IMl8w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 150361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150361&action=edit Bug 33621: (QA follow-up) Typo formated_date Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 12:00:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 10:00:49 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-QzH5ZOgZsz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #11) > > But what is $datetime ?? Ah, I found him: window.$datetime = function(value, options) { options = options||{}; options.withtime = true; return $date(value, options); }; window.$date = function(value, options) { ETC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 12:45:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 10:45:14 +0000 Subject: [Koha-bugs] [Bug 33623] getAll not encoding URL params In-Reply-To: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33623-70-xadwrM0WZK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 --- Comment #5 from Pedro Amorim <pedro.amorim at ptfs-europe.com> --- Created attachment 150362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150362&action=edit Bug 33623: Move ULSearchParams into http-client.js Remove unused getAll methods in erm-api-client.js Make use of new getAll query in AgreementRelationships -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 12:46:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 10:46:25 +0000 Subject: [Koha-bugs] [Bug 33616] JavaScript error in when using claims return button in checkout table In-Reply-To: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33616-70-Cf9BY61Mzl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33616 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Lucas Gass from comment #1) > match() matches a string against a regular expression. We need to make sure > the value passed is a string. Looks good to me. Do you know what you got that triggered the type error? In theory we could pass something that may not have a toString method too and cause a new error? Probably not reproducable :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 12:46:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 10:46:30 +0000 Subject: [Koha-bugs] [Bug 33616] JavaScript error in when using claims return button in checkout table In-Reply-To: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33616-70-CPuYCtRmtl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33616 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 12:48:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 10:48:25 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8367-70-ynHHnJm6Ts@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #235 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Aleisha Amohia from comment #234) > There are lots of signoffs on these patches, can this be marked Passed QA? Hi Aleisha, It appears I was wrong in comment 187, see comment 222 It is a question of how the fallback should work, so we either need a DB update, or to change the expectation for when a rule is not set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 13:02:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 11:02:12 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: <bug-32804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32804-70-Glr38SjDNn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 --- Comment #28 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150363&action=edit Bug 32804: [22.05.x] Do not adjust biblionumber when replacing items during import This patch adjust the item matching at import to confirm that for a duplicate itemnumber or barcode matches an existing item in the DB and uses the original biblionumber when updating the item. When ordering in a consortium the items may be moved around, duplicate biblios added, and various matches found. We should not allow importing of items to move them from 1 biblio to another, but we should allow the imports to succeed and assume itemnumber or barcode matches are authoritative. The responsibility for correct matching of items to biblio should fall on the creator of the files To test: 1 - Be using the sample data in koha testing docker 2 - Stage the sample file on this report 3 - Match on KohaBiblio(999$c) / Item processing: replace 4 - Note the biblio match is "The complete novels / Austen, Jane" 5 - View the staged marc, note the barcode 39999000004090 in an item 6 - Search for that barcode 7 - You find biblio "Five novels : complete and unabridged / Gustave Flaubert" 8 - Import the file 9 - Check the db: SELECT * FROM items WHERE biblionumber != biblioitemnumber; 10 - Note the mismatch 11 - Fix the item and set it as 'Music' type UPDATE items SET biblionumber = biblioitemnumber, itype='MU' WHERE biblionumber != biblioitemnumber; 12 - Apply patch, restart all 13 - Stage and import the file with the same settings 14 - Confirm the item is modified on its original biblio (99) and that item type is Book again 15 - Change itemnumber to avoid itemnumber match and reset type UPDATE items SET itype='MU', itemnumber=999 WHERE itemnumber=212; 16 - Stage and import with the same setttings 17 - Confirm the marcode match worked and item is updated to book on original record 18 - Delete the original item 19 - Stage and import the file with the same settings 20 - The item is successfully created 21 - Stage and import, but item processing option is 'add' 22 - Confirm 1 item ignored 23 - Check the db SELECT * FROM import_items WHERE barcode=39999000004090 24 - Confirm there is a line with 'error' and duplicate_barcode JD amended patch - # We assume that when replaicing tiems we do not want to move them - the onus is on the importer to + # We assume that when replacing items we do not want to move them - the onus is on the importer to Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Bug 32804: Add unit tests JD amended patch - is( $item1->homebranch, $library->branchcode, "Item was overlayed succesfully" ); + is( $item1->homebranch, $library->branchcode, "Item was overlaid successfully" ); Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Bug 32804: (follow-up) Test that id's have not changed Rather than assuming biblionumber and biblioitemnumber are the same, we should test that they have not changed form their original values Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Bug 32804: (QA follow-up) Typo ahs and fix ImportBatch.t Resolve: # Failed test 'Item's biblioitemnumber has not changed' # at t/db_dependent/ImportBatch.t line 407. # # got: '4261' # expected: '2371' Do not compare $item1->biblionumber with $original_biblioitemnumber :) Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 13:02:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 11:02:45 +0000 Subject: [Koha-bugs] [Bug 32804] Importing and replacing items causes inconsistency when itemnumber match and biblio match disagree In-Reply-To: <bug-32804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32804-70-8PJFL5Vbhg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32804 --- Comment #29 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Lucas Gass from comment #27) > Merge conflicts with 22.05.x, no backport. If needed please rebase. Patch rebased, please test before pushing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 13:16:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 11:16:25 +0000 Subject: [Koha-bugs] [Bug 21043] Add routes to add debits to a patron's account In-Reply-To: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21043-70-SlUYYxom7a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21043 TomĂĄs Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Change sponsored?|Seeking developer |Sponsored --- Comment #21 from TomĂĄs Cohen Arazi <tomascohen at gmail.com> --- The follow-up is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 13:25:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 11:25:58 +0000 Subject: [Koha-bugs] [Bug 32990] Possible deadlock in C4::ImportBatch::_update_batch_record_counts In-Reply-To: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32990-70-3JBiU5tvLH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32990 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- This worked, however, the error I got was: C4::ImportBatch::SetImportRecordMatches(): DBI Exception: DBD::mysql::st execute failed: Deadlock found when trying to get lock; try restarting transaction at /kohadevbox/koha/C4/ImportBatch.pm line 494 Does the statement in that routine need an update too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 13:40:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 11:40:01 +0000 Subject: [Koha-bugs] [Bug 33138] Don't copy tag 147 to MARC frameworks, since it should only be in a manually-created NAME_EVENT framework In-Reply-To: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33138-70-OrbsmvUjPi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33138 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 13:40:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 11:40:03 +0000 Subject: [Koha-bugs] [Bug 33138] Don't copy tag 147 to MARC frameworks, since it should only be in a manually-created NAME_EVENT framework In-Reply-To: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33138-70-KgKl6H3xrP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33138 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149706|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150364&action=edit Bug 33138: Don't copy tag 147 to authority MARC frameworks We shouldn't be including tag 147 in every authority MARC framework we install, since like all 1xx authority tags there should only be one per record. It only belongs in a NAME_EVENT framework, which we don't install. Test plan: 1. Apply patch, kd && ku or however you like to restart 2. Administration - Authority types - Actions button for Default - MARC structure 3. In the search box below the text "Select an authority framework" enter 147 and click OK 4. Once you see that it exists in Default, switch the dropdown to each of the other frameworks and verify it doesn't appear in any. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 13:43:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 11:43:37 +0000 Subject: [Koha-bugs] [Bug 33138] Don't copy tag 147 to MARC frameworks, since it should only be in a manually-created NAME_EVENT framework In-Reply-To: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33138-70-Kf3tCPMsnp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33138 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- I wondered if there should be a DB update, but I don't think we want to remove things from existing frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 13:59:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 11:59:41 +0000 Subject: [Koha-bugs] [Bug 32990] Possible deadlock in C4::ImportBatch::_update_batch_record_counts In-Reply-To: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32990-70-G85iAYHmn0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32990 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Nick Clemens from comment #5) > This worked, however, the error I got was: > > C4::ImportBatch::SetImportRecordMatches(): DBI Exception: DBD::mysql::st > execute failed: Deadlock found when trying to get lock; try restarting > transaction at /kohadevbox/koha/C4/ImportBatch.pm line 494 > > > Does the statement in that routine need an update too? Looks like it doesnt. You just hit the same problem in another part of the code execution in backgroundjob->process. It first does Stage and later calls FindDup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 14:15:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 12:15:04 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-KLvUkRVB2i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150365&action=edit Bug 29185: (QA follow-up) Capitalize AND to ensure it is a boolean for ES -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 14:15:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 12:15:50 +0000 Subject: [Koha-bugs] [Bug 29185] Show MARC21 tag 765 - Original Language Entry In-Reply-To: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-29185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-29185-70-8zWNtx8TDK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29185 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #19 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #16) > (In reply to Martin Renvoize from comment #11) > > Nick said: > > > > "The only bit I am not sure about is the indexing, there is some massaging > > it looks like in the utils - and I don't see where we have an equivalent in > > ES" > > > > So, that confirms my suspicions that we might need to do more for this to > > work with ES > > From IRC: > > [09:26] <marcelr> +++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm @@ > -82,6 +82,7 @@ our %index_field_convert = ( + 'cnum' => > 'control-number', > [09:28] <marcelr> admin/searchengine/elasticsearch/mappings.yaml: > control-number: > [09:28] <marcelr> i am not adding something new, but just an alias Ah, I thought I saw some handling in the zebra xslt, but I must have gotten confused. Tested and works nicely with a minor follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 14:24:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 12:24:44 +0000 Subject: [Koha-bugs] [Bug 28315] PopupMARCFieldDoc is defined twice in addbiblio.tt In-Reply-To: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28315-70-xKcukYMDOY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28315 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 14:24:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 12:24:46 +0000 Subject: [Koha-bugs] [Bug 28315] PopupMARCFieldDoc is defined twice in addbiblio.tt In-Reply-To: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28315-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28315-70-Uyg74KIQPR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28315 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150183|0 |1 is obsolete| | Attachment #150216|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150366&action=edit Bug 28315: Remove duplicate function definition This patch removes the unnecessary second definition of the JS function PopupMARCFieldDoc from addbiblio.tt. To test: 1. Apply the patch 2. Check that addbiblio.tt contains only one function definition for PopupMARCFieldDoc 3. Navigate to "Cataloging" -> "Add MARC record" 4. Check that after clicking on the question mark symbol next to any MARC field, the loc description of that MARC field is opened in a new tab Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 14:52:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 12:52:21 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-6nSrG3n0iJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 14:52:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 12:52:23 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-VEK3dOEXxO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150367&action=edit Bug 33445: [alternate] Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1. Without the patch, edit a personal name authority record, replacing the value in 100 subfield a (200 subfield a for UNIMARC) with your own name. 2. Click "Replace record via Z39.50/SRU search" and note that the prefilled search field contains the original value, not your name. 3. Replace the Author (personal) field with your name again, choose a search target, and click Search. 4. Note that the results of the search are for the original value, not for your name. 5. Apply patch, repeat, noting that the search form is prefilled with your change made in the editor, and any changes you make in the search form are reflected in what the search results return. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 14:58:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 12:58:15 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-CYt1WIipPQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150367|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150368&action=edit Bug 33445: [alternate] Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1 - Without the patch, edit a personal name authority record 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name 3 - Click "Replace record via Z39.50/SRU search" 4 - Note that prefilled search field contains the original value, not your name. 5 - Replace the Author (personal) field with your name in the search form 6 - choose a search target, and click Search. 7 - Note that the results of the search are for the original value, not your name 8 - From the details page of a record, click 'Edit -> Replace record via Z3950' 9 - Note form is prefilled 10 - Change value as in 5 and search 11 - Note original term was searched 12 - Apply patch, restart all 13 - Repeat searches as before 14 - Confirm that form is prefilled with record or the updated value 15 - Confirm your entered search terms are always searched -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 14:59:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 12:59:16 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-bWR8KIFT1d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Rather than revert, I think we need to ensure we handle record values when needed, and the form values when searching. I attached an alternate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:05:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:05:04 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-NNi0zTJui7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:05:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:05:35 +0000 Subject: [Koha-bugs] [Bug 32990] Possible deadlock in C4::ImportBatch::_update_batch_record_counts In-Reply-To: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32990-70-6eDptmdSWi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32990 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:05:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:05:37 +0000 Subject: [Koha-bugs] [Bug 32990] Possible deadlock in C4::ImportBatch::_update_batch_record_counts In-Reply-To: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32990-70-a0viDnZPmY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32990 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147785|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150369&action=edit Bug 32990: Prevent deadlock in _update_batch_record_counts Resolves: C4::ImportBatch::_update_batch_record_counts(): DBI Exception: DBD::mysql::st execute failed: Deadlock found when trying to get lock; try restarting transaction at /usr/share/koha/C4/ImportBatch.pm line 392 See also bug 32558. Test plan: If you apply 32558 first, run multiple processes that stage a marc import. Without this patch, you can trigger the deadlock. With this patch, it works. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:11:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:11:36 +0000 Subject: [Koha-bugs] [Bug 33635] New: CSV export display broken diacritics in Excel Message-ID: <bug-33635-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33635 Bug ID: 33635 Summary: CSV export display broken diacritics in Excel Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: clemens.tubach at kit.edu, gmcharlt at gmail.com, michaela.sieber at kit.edu This has been a re-occurring support issue: When using one of Koha's many CSV download options, the exported CSV file doesn't open as UTF-8 in Excel, resulting in broken diacritics. LibreOffice doesn't show the issue. The only way to fix it right now is not to open the file directly, but to use the import functionality in Excel as it lets you pick the encoding and separators. This means a lot of extra steps and clicks, which make the CSV export functionalities in Koha hard to use. It turns out that Excel will import the CSV correctly, if we convert the encoding of the exported CSV file from UTF-8 to UTF-8-BOM. Problematic CSV exports include: * Exporting a basket summary page as CSV * Using CSV profile based exports in general, including: lists, basket, lost items report * ... Can we 'fix' the encoding to use BOM? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:12:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:12:31 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-wFGkJWDGCr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:12:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:12:33 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-35naxPoVuf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149459|0 |1 is obsolete| | Attachment #149460|0 |1 is obsolete| | Attachment #149461|0 |1 is obsolete| | Attachment #149462|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150370&action=edit Bug 31795: Add REST endpoint to add an authority To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Make a POST request to /api/v1/authorities with one of the following content type header - application/json - application/marcxml+xml - application/marc-in-json - application/marc 4. If content type is other than application/json, then add the following header to the request: "x-authority-type: <auth type code>" 5. Check that the authority is created 6. Sign off Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:12:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:12:35 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-3PI8vsptMc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 --- Comment #21 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150371&action=edit Bug 31795: (QA follow-up) Use x-koha-override header Despite its title, this patch does a couple more things. 1. The tests are rewritten to cover more things, and also to avoid deleting all authorities inside the transaction. It is really not required. 2. It makes the endpoint rely on the already generically implemented x-koha-override header, which is intended for the same use case as x-confirm-not-duplicate is for. 3. It changes the return codes to match the coding guidelines [1] 4. Only checks for duplicates if no override passed. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/authorities.t => SUCCESS: Tests pass! 2. Apply this follow-up 3. Repeat 1 => SUCCESS: Tests pass! 4. Sign off :-D [1] https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#SWAGGER3.2.1_POST Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:12:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:12:37 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-fLUSmzeTxU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 --- Comment #22 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150372&action=edit Bug 31795: Fix required permissions Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:12:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:12:39 +0000 Subject: [Koha-bugs] [Bug 31795] REST API: POST endpoint for Authorities In-Reply-To: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31795-70-QlrbT1tSKE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31795 --- Comment #23 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150373&action=edit Bug 31795: (follow-up) Mock call to FindDuplicateAuthority When running against Zebra, this tests fail because it requires the record to be indexed timely. In theory, a 5 seconds delay should be enough for the indexer to pick up. But that's not the point of the test, and we should better just mock the query in this case. To test: 1. Have ktd launch with zebra: $ ktd up -d 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/authorities.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Launch ktd with ES: $ ktd down $ ktd --es7 up -d 6. Repeat 2 => SUCCESS: Tests pass! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:20:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:20:12 +0000 Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities In-Reply-To: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31796-70-it7SqbKlZf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:20:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:20:15 +0000 Subject: [Koha-bugs] [Bug 31796] REST API: PUT endpoint for Authorities In-Reply-To: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31796-70-tFjcsBogu7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31796 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149702|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150374&action=edit Bug 31796: Add REST endpoint to modify an authority To test: 1. Apply patch 2. Set RESTBasicAuth preference to true 3. Pick an authority to modify, and modify it's marc record 4. Make a PUT request to /api/v1/authorities/:authid with one of the following content type header - application/json - application/marcxml+xml - application/marc-in-json - application/marc 5. If content type is other than 'application/json' place the following header in the request 'x-authority-type: <auth type>' 5. Check that the authority was modified 6. Sign off Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:32:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:32:19 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-C225fg4tWw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:32:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:32:21 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-4iCbLCpTJX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149734|0 |1 is obsolete| | Attachment #149735|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150375&action=edit Bug 33329: Regression tests This patch introduces tests for the bug highlighted on bug 32336, but in the context of lists of records. To reproduce: 1. Run: $ prove t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => FAIL: Test fail, encoding is bad! Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:32:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:32:23 +0000 Subject: [Koha-bugs] [Bug 33329] GET /biblios encoding wrong when UNIMARC In-Reply-To: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33329-70-51Ns8nPnIL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33329 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150376&action=edit Bug 33329: Correctly handle UNIMARC encoding for biblios This patch introduces the same treatment we had for bug 32336, this time for Koha::Objects::Record::Collections. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/biblios.t => FAIL: Tests fail! Encoding is wrong for UNIMARC! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:36:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:36:58 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-MuzFMyWkrJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 --- Comment #6 from Slava Shishkin <slavashishkin at gmail.com> --- Created attachment 150377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150377&action=edit Bug 33590: Fix DOM id name for tabs after WRAPPER code added to export.tt The list of CSV profiles was not displayed if the CSV format was selected in the output format settings. To test: 1. Go to /cgi-bin/koha/tools/export.pl 2. At the bottom of the page in the Output format, select SCV format. *If SCV format is not active in the drop-down File format menu, create any profile to Usage export records on the link /cgi-bin/koha/tools/csv-profiles.pl 3. Note that the list of SCV profiles is not displayed. 4. Apply the patch. 5. Restart the page and repeat steps 2. 6. Verify that when you select the CSV format, the list of CSV profiles appears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:38:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:38:43 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-JcvrqJVY4s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:38:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:38:45 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-pomoGDXjvm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147664|0 |1 is obsolete| | Attachment #147665|0 |1 is obsolete| | Attachment #147666|0 |1 is obsolete| | Attachment #147667|0 |1 is obsolete| | Attachment #148939|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150378&action=edit Bug 31212: Change datelastseen from date to datetime field Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:38:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:38:54 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-4qo4qDMDGJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150379&action=edit Bug 31212: Add Database update Signed-off-by: Ann Flournoy <aflournoy at cityofkeller.com> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:38:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:38:56 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-howOiwUMTe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #38 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150380&action=edit Bug 31212: Fix date_from_string and explicitly called output_pref subroutine Signed-off-by: Ann Flournoy <aflournoy at cityofkeller.com> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:38:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:38:59 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-JhjBJkthwt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150381&action=edit Bug 31212: (follow-up) Fix datelastseen when returning item Signed-off-by: Andrew Fuerste-Henry <andrewfh at dubcolib.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:39:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:39:01 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-XHBGALbzc1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #40 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150382&action=edit Bug 31212: (follow-up) Remove unnessesary changes from Items.pm Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:39:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:39:04 +0000 Subject: [Koha-bugs] [Bug 31212] Datelastseen should be a datetime In-Reply-To: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31212-70-88jt8i5Gt1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150383&action=edit Bug 31212: (QA follow-up) Fix unit test, remove unused imports Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:41:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:41:27 +0000 Subject: [Koha-bugs] [Bug 33340] Correct formatting of English 1-page order PDF when the basket group covers multiple pages In-Reply-To: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33340-70-I4CpOS0Wpz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:45:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:45:46 +0000 Subject: [Koha-bugs] [Bug 33340] Correct formatting of English 1-page order PDF when the basket group covers multiple pages In-Reply-To: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33340-70-dwG2L8W9je@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:45:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:45:48 +0000 Subject: [Koha-bugs] [Bug 33340] Correct formatting of English 1-page order PDF when the basket group covers multiple pages In-Reply-To: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33340-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33340-70-GohDXMSqWQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148764|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150384&action=edit Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages If a basket group contains many ordered items then this patchset will ensure: - The page number at the bottom of the first page is not obscured - The table of ordered items does not start half way down the second page Test plan: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add many orders to this basket, for example 25 items (this is to make the Order PDF cover multiple pages). 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm the PDF is multiple pages long. If it is not then re-open the basketgroup and add more orders to the basket and repeat steps 5, 6, 7 and 8 9) If the PDF is multiple pages long then confirm: - The page numbers at the bottom of the first page are not obscured by the order table. - That the order table starts near the top of the second page, and not half way down. 10) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:47:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:47:49 +0000 Subject: [Koha-bugs] [Bug 33028] The decimal separator 'comma' and its consequences on the calculation of fines (crons) In-Reply-To: <bug-33028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33028-70-1FYu2oIQGw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:54:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:54:29 +0000 Subject: [Koha-bugs] [Bug 33318] [21.11] Advanced editor doesn't load In-Reply-To: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33318-70-d4me1MEUog@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:54:31 +0000 Subject: [Koha-bugs] [Bug 33318] [21.11] Advanced editor doesn't load In-Reply-To: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33318-70-q65iH8g8NE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149732|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150385&action=edit Bug 33318: Fix JS errors on advanced cataloguing editor This patch reverts bug 31818 Test plan: 1. Checkout 21.11.x 2. Set the EnableAdvancedCatalogingEditor syspref = 'Enable' 3. Go to Cataloguing > Advanced editor 4. Notice the advanced editor is stuck on 'Loading, please wait' 5. Right click > Inspect > Console 6. Notice there is a JS error: "Uncaught TypeError: $.fn.popover.Constructor.DEFAULTS.whiteList is undefined" 7. Apply patch 8. Restart services 9. Refresh the advanced editor 10. Notice it is not stuck on 'Loading, please wait' 11. Right click > Inspect > Console 12. Notice the JS error is no longer showing 13. Click on 'Keyboard shortcuts' and confirm it contains content - that is what bug 31818 was aiming to fix Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:54:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:54:56 +0000 Subject: [Koha-bugs] [Bug 33318] [21.11] Advanced editor doesn't load In-Reply-To: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33318-70-eMsA8NNMdY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:55:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:55:36 +0000 Subject: [Koha-bugs] [Bug 33318] [21.11] Advanced editor doesn't load In-Reply-To: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33318-70-7OWSsKjWLM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31818 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818 [Bug 31818] Advanced editor doesn't show keyboard shortcuts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:55:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:55:36 +0000 Subject: [Koha-bugs] [Bug 31818] Advanced editor doesn't show keyboard shortcuts In-Reply-To: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31818-70-4OOYUBLyss@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31818 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 [Bug 33318] [21.11] Advanced editor doesn't load -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:55:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:55:52 +0000 Subject: [Koha-bugs] [Bug 33318] [21.11] Advanced editor doesn't load In-Reply-To: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33318-70-YvkVjURmBZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33318 --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Moved to oldoldstable queue for Arthur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:57:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:57:21 +0000 Subject: [Koha-bugs] [Bug 33028] The decimal separator 'comma' and its consequences on the calculation of fines (crons) In-Reply-To: <bug-33028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33028-70-priEWX2Sgm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> --- Circ rules are not enforcing currency formats either. This might fix things once, but does not keep the issue from coming back. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 15:59:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 13:59:29 +0000 Subject: [Koha-bugs] [Bug 33028] The decimal separator 'comma' and its consequences on the calculation of fines (crons) In-Reply-To: <bug-33028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33028-70-ItP43rJZpK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Kyle M Hall from comment #20) > Circ rules are not enforcing currency formats either. This might fix things > once, but does not keep the issue from coming back. Hi Kyle, what do you suggest? A format check on the inputs in the circ rules? We could use the pattern check we use in other forms. Or did you think of something else? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:18:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:18:11 +0000 Subject: [Koha-bugs] [Bug 33590] WRAPPER tab_panel breaks JS on some pages (Select all/Clear all, post-Ajax updates) In-Reply-To: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33590-70-Let9bLwGIv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33590 Slava Shishkin <slavashishkin at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #7 from Slava Shishkin <slavashishkin at gmail.com> --- Hi Katrin! Here, I found another case, which I added above. That's all I found, for now, can be test it. If I find something later, I'll create a new ticket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:18:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:18:45 +0000 Subject: [Koha-bugs] [Bug 33616] JavaScript error in when using claims return button in checkout table In-Reply-To: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33616-70-iCrG2SBzaK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33616 --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> --- I think this is now a duplicate of Bug 33621. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:19:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:19:16 +0000 Subject: [Koha-bugs] [Bug 33616] JavaScript error in when using claims return button in checkout table In-Reply-To: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33616-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33616-70-NoulgerfjY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33616 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 33621 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:19:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:19:16 +0000 Subject: [Koha-bugs] [Bug 33621] Javascript error when claiming return via circulation.pl In-Reply-To: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33621-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33621-70-5PaSpwpAtq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33621 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> --- *** Bug 33616 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:26:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:26:13 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31479-70-3iDuoIOxKW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:26:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:26:16 +0000 Subject: [Koha-bugs] [Bug 33242] Allow passing things like add_days => 3 to KohaDates filter In-Reply-To: <bug-33242-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33242-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33242-70-TsODQd7Qvm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33242 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:32:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:32:57 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-eczqWaiYPx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147839|0 |1 is obsolete| | --- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150386&action=edit Bug 30928: Add interface to statistics -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:33:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:33:00 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-ZRRxwhKixY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #19 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150387&action=edit Bug 30928: DB and Schema updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:33:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:33:35 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-aYcW1pjvu5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:34:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:34:13 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-wzGYhHCaZQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #20 from Lucas Gass <lucas at bywatersolutions.com> --- (In reply to Aleisha Amohia from comment #17) > Please move schema update to a separate patch. Once fixed I'll be happy to > pass QA. Thanks Aleisha! I have separated them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:42:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:42:47 +0000 Subject: [Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats In-Reply-To: <bug-33013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33013-70-R3YzeR00Hv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:44:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:44:13 +0000 Subject: [Koha-bugs] [Bug 33636] New: Move C4::Stats to Koha namespace Message-ID: <bug-33636-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33636 Bug ID: 33636 Summary: Move C4::Stats to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Plan is to move code already to Koha on bug 33608. But to replace calls and remove module on this report. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:44:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:44:26 +0000 Subject: [Koha-bugs] [Bug 33636] Move C4::Stats to Koha namespace In-Reply-To: <bug-33636-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33636-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33636-70-TMDh7jAW9A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33636 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:44:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:44:30 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31479-70-W2JHMbvONi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:44:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:44:31 +0000 Subject: [Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates In-Reply-To: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31479-70-ROLzWGJ9JH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150036|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150388&action=edit Bug 31479: Option to skip t/00-check-atomic-updates.t when building custom packages This enhancement adds an option to skip the check for leftover atomic updates when building custom packages. This is particularly useful for Koha providers or anyone else building Koha packages manually. In practice, this could be run like: sudo CUSTOM_PACKAGE=1 ./debian/build-git-snapshot -r ~/debian -v 21.11.01git -d This test plan should all take place within the shell. 0. sudo koha-shell kohadev 1. Run prove t/00-check-atomic-updates.t and confirm the test passes 2. Add a fake atomic update to installer/data/mysql/atomicupdate/ . You can use the example from https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file 3. Run prove t/00-check-atomic-updates.t and notice the test fails 4. Set the CUSTOM_PACKAGE environment variable so we can test this. You can either set on the commandline (using export) or in /etc/environment (remember to run source /etc/environment so the changes are accessed) 5. Run prove t/00-check-atomic-updates.t and the test should now pass. Sponsored-by: Catalyst IT Signed-off-by: Mason James <mtj at kohaaloha.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:44:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:44:43 +0000 Subject: [Koha-bugs] [Bug 33636] Move C4::Stats to Koha namespace In-Reply-To: <bug-33636-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33636-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33636-70-IlhvuqLyQi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33636 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 [Bug 33608] Allow to get statistics about found books -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:44:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:44:43 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-jVOkhFzo7W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33636 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33636 [Bug 33636] Move C4::Stats to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:45:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:45:36 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-mTNyGighzp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33013, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33608, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33636 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:45:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:45:36 +0000 Subject: [Koha-bugs] [Bug 33013] Add age, interface and operator as additional report stats In-Reply-To: <bug-33013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33013-70-5yvw6ys8yf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33013 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30928 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:45:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:45:36 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-YTBWFunfEc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30928 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:45:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:45:36 +0000 Subject: [Koha-bugs] [Bug 33636] Move C4::Stats to Koha namespace In-Reply-To: <bug-33636-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33636-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33636-70-SeAROryfH0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33636 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30928 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:47:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:47:00 +0000 Subject: [Koha-bugs] [Bug 33220] Recalls to pull should not show in transit or allocated items In-Reply-To: <bug-33220-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33220-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33220-70-AZ6nXQLz7T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33220 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |lucas at bywatersolutions.com |y.org | CC| |lucas at bywatersolutions.com --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Changes make sense, works as described, QA scripts are happy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:47:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:47:17 +0000 Subject: [Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books In-Reply-To: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33608-70-goJZUfqbk4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow to get statistics |Allow to get statistics |about found books |about found/recovered books -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:47:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:47:41 +0000 Subject: [Koha-bugs] [Bug 33220] Recalls to pull should not show in transit or allocated items In-Reply-To: <bug-33220-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33220-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33220-70-u07UoG6Kiy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33220 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 16:47:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 14:47:43 +0000 Subject: [Koha-bugs] [Bug 33220] Recalls to pull should not show in transit or allocated items In-Reply-To: <bug-33220-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33220-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33220-70-Ll7nbixsNK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33220 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149121|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150389&action=edit Bug 33220: Fix recalls to pull to not show in transit or allocated items This patch fixes the Recalls to pull circulation report so that it does not show items that are already allocated to another recall. This requires the UseRecalls system preference to be enabled and recalls circulation and fines rules to be configured. To test: 1. Cancel any recalls on Item A/Biblio A. 2. Check out Item A to Patron A. Item A should be the only item on Biblio A (pick a record with only one item, or create a record with one item). 2. Log into the OPAC as Patron B. 3. Place a recall on Item A for Patron B. Change the pickup library so it isn't your default library. 4. Log into the OPAC as Patron C. 5. Place a recall on Item A for Patron C. Item A should now be checked out to Patron A, with two recalls on it for Patrons B and C. 6. Log back into the staff interface. 7. Check in Item A. Confirm the recall and transfer for Patron B. 8. Go to Circulation -> Recalls to pull. Notice the recall for Patron C shows here, even though the one item that could fill this recall has already been allocated to Patron B and is in transit 9. Apply the patch and restart services 10. Refresh the Recalls to pull page 11. Confirm the recall no longer shows on the Recalls to pull page --> SUCCESS 12. Go to Biblio A and add a second item - Item B 13. Go back to Recalls to pull and refresh the page 14. Confirm the recall for Patron C now shows and can be filled by Item B Sponsored-by: Auckland University of Technology Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 17:43:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 15:43:45 +0000 Subject: [Koha-bugs] [Bug 33242] Allow passing things like add_days => 3 to KohaDates filter In-Reply-To: <bug-33242-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33242-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33242-70-9wumKbDIvy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33242 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 17:43:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 15:43:47 +0000 Subject: [Koha-bugs] [Bug 33242] Allow passing things like add_days => 3 to KohaDates filter In-Reply-To: <bug-33242-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33242-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33242-70-iZjkIUeev5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33242 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148264|0 |1 is obsolete| | Attachment #148265|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150390&action=edit Bug 33242: Allow passing add_{duration} options to KohaDates For example, if I want to add a few days to the issuedate in a TT template, I could do this: [% checkout.issuedate | $KohaDates add_days => 3 %] This development allows you to pass add/subtract years, months, weeks, days, hours, minutes and seconds. Test plan: Pick a notice like CHECKOUT. Add a line like: [% checkout.date_due | $KohaDates with_hours => 1, add_minutes => 15 %] Do a checkout. Verify that the notice generated contains a time that shifted 15 minutes. Undo your change. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 17:50:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 15:50:34 +0000 Subject: [Koha-bugs] [Bug 33242] Allow passing things like add_days => 3 to KohaDates filter In-Reply-To: <bug-33242-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33242-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33242-70-LRlaVGJ5GE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33242 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150390|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150391&action=edit Bug 33242: Allow passing add_{duration} options to KohaDates For example, if I want to add a few days to the issuedate in a TT template, I could do this: [% checkout.issuedate | $KohaDates add_days => 3 %] This development allows you to pass add/subtract years, months, weeks, days, hours, minutes and seconds. Test plan: Pick a notice like CHECKOUT. Add a line like: [% checkout.date_due | $KohaDates with_hours => 1, add_minutes => 15 %] Do a checkout. Verify that the notice generated contains a time that shifted 15 minutes. Undo your change. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 17:50:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 15:50:47 +0000 Subject: [Koha-bugs] [Bug 33242] Allow passing things like add_days => 3 to KohaDates filter In-Reply-To: <bug-33242-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33242-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33242-70-nzNUmJ7Cuk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33242 --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150392&action=edit Bug 33242: Add unit test Test plan: Run t/db_dependent/Letters/TemplateToolkit.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 17:55:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 15:55:27 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-ERY4D0Ahvv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 17:55:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 15:55:30 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-cptym3YsFy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150393&action=edit Bug 33634: Correct anchors in system preference submenu To test: 1. Go to Koha Administration -> Global system preferences 2. Go to a tab with a few headings like Circulation 3. Click on a heading in the sidebar navigation under Circulation that takes you a bit down the page, like Recalls 4. Notice this anchor link does not work, you are not taken to the recalls preferences 5. Apply patch 6. Try again, the links should take you to the proper place. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 17:55:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 15:55:50 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-EgtoTJWKUu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 17:56:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 15:56:51 +0000 Subject: [Koha-bugs] [Bug 33637] New: Batch patron modification broken Message-ID: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Bug ID: 33637 Summary: Batch patron modification broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When attempting to batch modify patrons, the inputs are always cleared because the js was not updated then the ids were changed To recreate: 1 - Browse to tools -> Batch patron modification 2 - Enter cardnumbers and submit 3 - No patrons 4 - Enter borrowernumbers and submit 5 - No patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 17:58:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 15:58:29 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-EOJf91tybU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 17:58:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 15:58:31 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-yUlwFqrzcS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150394&action=edit Bug 33637: Update tab ids for batch modification form This patch adjusts the ids in the submit function To test: 1 - Browse to tools -> Batch patron modification 2 - Enter cardnumbers and submit 3 - No patrons 4 - Enter borrowernumbers and submit 5 - No patrons 6 - Apply patch 7 - Repeat 8 - Success, patrons are listed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:08:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:08:12 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-ByDqPCZ9bf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25379 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:08:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:08:12 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-ZZBdv1dOo7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33637 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:08:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:08:52 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-HIp2lSKfvA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:08:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:08:55 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-1NuQDY5Jho@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148496|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150395&action=edit Bug 25379: Add raw filter to circulation note on checkin page This is a consistency patch: we already allow adding HTML tags to the patron circulation note and the contents display correctly in the patron account and in the patron search results in the staff interface. But the HTML tags are printed on the checkins page. To test: * Add a circulation note including HTML tags to a patron Example: <h1>This patron is great!</h1> * Check an item out to this patron * Verify that the note displays formatted in patron search results * Verify that the note displays formatted in the patron record * Return the item * Verify the note shows the printed tags * Apply patch * Check item out again and check it in again * Verify the note now displays correctly in list of checkins Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:08:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:08:57 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-XL7qNk5qcl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150396&action=edit Bug 25379: (QA follow-up) Adjust other occurrences and add line break This updates the other occurrences and adds html_line_break to all except the edit page - it seems html or raw doesn't affect the value of the textarea, but moved to raw for consistency To test: 1 - Add an HTML note to a patron, make sure to add a line break: <h1>Testing</h1> <h2>Newline</h2> 2 - Checkout to patron and return 3 - Confirm note shows correctly 4 - Add patron to a list 5 - Confirm note displays correctly 6 - Edit patron, confirm note field is correct 7 - Batch modify borrower 8 - Confirm note displays correctly in batch list Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:09:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:09:18 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-Yk0HjGEXJN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Minor followups, RM can veirfy, PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:09:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:09:39 +0000 Subject: [Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field In-Reply-To: <bug-33039-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33039-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33039-70-ZVP4HqTJbg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #14) > + if ( index( $template, '[%' ) != -1 ) { # Much faster than regex > No problem, but 'much' sounds like exaggerating :) Just in memory.. https://stackoverflow.com/questions/30744379/unanchored-substring-searching-index-vs-regex > > This call worries me: > + my $tt = Template->new( > + { > + EVAL_PERL => 1, > + ABSOLUTE => 1, > + PLUGIN_BASE => 'Koha::Template::Plugin', > + COMPILE_EXT => $use_template_cache ? '.ttc' : '', > + COMPILE_DIR => $use_template_cache ? > C4::Context->config('template_cache_dir') : '', > + FILTERS => {}, > + ENCODING => 'UTF-8', > + } > + ) or die Template->error(); > Would prefer to see calling something central like in C4::Templates or in > C4::Letters instead. Bug 33041 already handles that > > + $schema->txn_begin; > + try { > + my $text; > + $tt->process( > Please explain why a process call would need a transaction. Can we just > remove it ? Please have a look at C4::Letters. This is now standard procedure for template processing. > Could generating alternative text via a Koha plugin be easier somehow? And > without needing a db revision ? > Note that we already have: > Koha/Plugins/Base.pm: $args->{'template'} = Template->new( { ABSOLUTE => > 1, ENCODING => 'UTF-8' } ); That sounds more complicated. If you want to write a POC for that I'd be happy to take a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:11:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:11:36 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-cwBy65XcH8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324 [Bug 33324] Use template wrapper for tabs: Tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:11:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:11:36 +0000 Subject: [Koha-bugs] [Bug 33324] Use template wrapper for tabs: Tools In-Reply-To: <bug-33324-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33324-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33324-70-DwUAWyphss@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33324 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33637 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 [Bug 33637] Batch patron modification broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:12:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:12:17 +0000 Subject: [Koha-bugs] [Bug 33039] Add ability to specify a template for serial subscription "Published on (text)" field In-Reply-To: <bug-33039-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33039-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33039-70-zT02XbNun3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33039 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:16:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:16:51 +0000 Subject: [Koha-bugs] [Bug 33478] Customise the format of notices when they are printed In-Reply-To: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33478-70-vtYCNEX1Wi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 Andrew Fuerste-Henry <andrewfh at dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:23:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:23:25 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31405-70-QWd38JR0ZO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:23:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:23:28 +0000 Subject: [Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set In-Reply-To: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31405-70-qulhiuJOZH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150134|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150397&action=edit Bug 31405: Set focus for cursor to setSpec input when adding a new OAI set Makes sure the focus is in the first form field when adding a new OAI set: setSpec To test: * Go to administration > OAI sets * Add a new set, verify the focus is still in the search bar on top * Apply patch * Repeat and verify the focus is now in the first form field * Save set * Edit set and verify the focus is in the search field at the top Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:25:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:25:49 +0000 Subject: [Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server In-Reply-To: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31410-70-5YMoXfqRzP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 18:25:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 16:25:51 +0000 Subject: [Koha-bugs] [Bug 31410] Set focus for cursor to Server name when adding a new Z39.50 or SRU server In-Reply-To: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31410-70-z906w5UVWw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31410 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146265|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150398&action=edit Bug 31410: Set focus for cursor to Server name when adding a new Z39.50/SRU server This makes sure that the focus is in the first form field when adding a new Z39.50 or SRU server. To test: * Administration > Z39.50/SRU servers * Add a new server for each * Verify the focus is not in the form * Apply patch * Verify the focus is now in the first form field * Edit an existing server * Verify the focus is not in the form Not having the focus when editing is to avoid accidental changes. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:01:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:01:37 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8367-70-SR3QP6rghP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #236 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Nick Clemens from comment #235) > (In reply to Aleisha Amohia from comment #234) > > There are lots of signoffs on these patches, can this be marked Passed QA? > > Hi Aleisha, > > It appears I was wrong in comment 187, see comment 222 > > It is a question of how the fallback should work, so we either need a DB > update, or to change the expectation for when a rule is not set It sounds like this needs a little bit more work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:02:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:02:16 +0000 Subject: [Koha-bugs] [Bug 33633] Check if email exists In-Reply-To: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33633-70-oG9tohuPK0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Would it not also be dangerous/a security issue if such a service existed? Guessing email addresses and testing them would be a great activity for spammers or even people who want to sell email addresses to spammers. But I like the idea of having users verify their emails and flagging verified ones. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:08:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:08:09 +0000 Subject: [Koha-bugs] [Bug 33398] Show primary_contact_method when holds are triggered In-Reply-To: <bug-33398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33398-70-die8nVFxo1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33398 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:08:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:08:11 +0000 Subject: [Koha-bugs] [Bug 33398] Show primary_contact_method when holds are triggered In-Reply-To: <bug-33398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33398-70-y88zWoRBEZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33398 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149202|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150399&action=edit Bug 33398: Add primary_contact_method to display when triggering a waiting hold To test: 1. Apply patch, yarn build 2. Trigger a waiting hold for a patron that has a value for primary_contact_method 3. Notice the modal now includes a line indicating the primary_contact_method. 4. Trigger a hold for a patron without a primary_contact_method. Nothing should display. Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:09:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:09:34 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32548-70-GuSO1VmN7r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:09:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:09:36 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32548-70-VrdCtP9Yw5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149064|0 |1 is obsolete| | Attachment #149065|0 |1 is obsolete| | Attachment #149066|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150400&action=edit Bug 32548: Make illrequestattributes available in ILL emails Without this ILL module only provides very limited data to be included in the notices sent about the request itself. We have the columns illrequests, but not the illrequestattributes, that often will contain the more useful information needed. This patch enables to use values of the illrequestattributs using [% illrequestattributes.<attributname> %] in the notices. To test: * Apply patch * First you'll need to activate the ILL module and install a backend to use it with. FreeForm was used for this test plan, BLDSS is usually also good for testing. See: https://wiki.koha-community.org/wiki/ILL_backends * Also set up an SMTP server to use for notices and make sure the email address is set in KohaAdminEmailAddress and the user you are using for testing this with. * Make sure your user has an email address and will receive ILL notices by seleting them in the messaging preferences. * Create an ILL request with the FreeForm backend for your user. * On the ILL request detail page: "Display supplier metadata" Pick some attributes you want to use in the notice * Go to Tools > Notices and slips and edit ILL_REQUEST_UNAVAIL * Add some of the attributes you picked. Example: [% illrequestattributes.type %] [% illrequestattributes.title %] * Back to the ILL request detail page: Send notice to patron > ILL request unavailable * Go to your patron's account and check the notices tab * The generated notice shoudl show and include the information from the illrequestattributes you picked. Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:09:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:09:38 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32548-70-dVISQOJivp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150401&action=edit Bug 32548: Add tests Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:09:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:09:40 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32548-70-6NP1Lmd8wf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150402&action=edit Bug 32548: Replace while with map Signed-off-by: Pedro Amorim <pedro.amorim at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:10:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:10:06 +0000 Subject: [Koha-bugs] [Bug 33398] Show primary_contact_method when holds are triggered In-Reply-To: <bug-33398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33398-70-z6SMFbfuT1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33398 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:10:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:10:09 +0000 Subject: [Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled In-Reply-To: <bug-30295-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30295-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30295-70-71ZpStRX8e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:10:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:10:31 +0000 Subject: [Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled In-Reply-To: <bug-30295-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30295-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30295-70-3SlPL4REKv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle at bywatersolutions.com |testopia at bugs.koha-communit | |y.org Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:10:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:10:38 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32548-70-CNNKycV2H7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- Just to be pedantic, it is possible to use these before these patches, but it is inconvenient: [% FOREACH attribute IN illrequest.illrequestattributes %] [% IF attribute.type == 'title' %] [% attribute.value %] [% END %] [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:10:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:10:44 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32548-70-Qt6f79KPZO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:17:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:17:28 +0000 Subject: [Koha-bugs] [Bug 32627] Reprinting holds slips should not reset the expiration date In-Reply-To: <bug-32627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32627-70-YKVU7N0zT8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149245|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150403&action=edit Bug 32627: Calculate expirationdate relative to waitingdate Hold::set_waiting should calculate the MaxPickupDelay expiration date based on waitingdate rather than the current date, to avoid resetting the expirationdate on a hold that was already waiting. To test: 1. Place a hold and check in the item so the hold will be set to Waiting 2. Confirm that the expiration date is correct based on the ReservesMaxPickupDelay setting 3. Adjust your system clock to one day later 4. Check in the item again and confirm the hold 5. Note that the expiration date has changed 7. Apply patch and restart_all 8. Repeat steps 1-4. Confirm that the expiration date is calculated correctly, and does not change when the item is checked in again 9. Reset your system clock to the current date 10. Set ExcludeHolidaysFromMaxPickupDelay to Use the Calendar 11. Add an upcoming holiday to the calendar 12. Repeat steps 1-4. Confirm the expiration date correctly accounts for the holiday, and does not change when the item is checked in again Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Laura Escamilla <laura.escamilla at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:17:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:17:47 +0000 Subject: [Koha-bugs] [Bug 32627] Reprinting holds slips should not reset the expiration date In-Reply-To: <bug-32627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32627-70-zfBY8axbxn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32627 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:18:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:18:39 +0000 Subject: [Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32357-70-mlezHBNjNW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:18:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:18:57 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-M5gTZNry0e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:18:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:18:59 +0000 Subject: [Koha-bugs] [Bug 32937] Zebra: Ignore copyright symbol when searching In-Reply-To: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32937-70-LiNVKeZZUf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32937 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149736|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150404&action=edit Bug 32937: Make Zebra ignore the copyright symbol in searches It's common to catalog the year with the copyright symbol attached to it. This creates some issues with search that we can fix by adding the © to the list of characters Zebra ignores in search. To test: * Search for any existing publication year with ©, example: ©1951 * Verify your record is not found * Add the copyright symbol to a record, verify it's now found with ©, but not without * Apply patch * On ktd: * sudo cp -i /kohadevbox/koha/etc/zebradb/etc/word-phrase-utf.chr /etc/koha/zebradb/etc/word-phrase-utf.chr * sudo koha-zebra --restart kohadev * sudo koha-mysql kohadev * DELETE FROM biblio WHERE biblionumber = 369; * The reindex woudl fail for me with this broken record present. * sudo koha-rebuild-zebra -f kohadev * Repeat searches, the records should be found when searching with and without ©. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:28:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:28:03 +0000 Subject: [Koha-bugs] [Bug 33633] Check if email exists In-Reply-To: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33633-70-Y6XXjEASYM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 --- Comment #6 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Katrin Fischer from comment #5) > Would it not also be dangerous/a security issue if such a service existed? > Guessing email addresses and testing them would be a great activity for > spammers or even people who want to sell email addresses to spammers. Regardless, tools exist. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:31:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:31:50 +0000 Subject: [Koha-bugs] [Bug 22178] Add start and end date for repeated holidays In-Reply-To: <bug-22178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22178-70-ejcLAUEIRg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22178 Lisette Scheer <lisette.scheer at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:36:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:36:15 +0000 Subject: [Koha-bugs] [Bug 33633] Check if email exists In-Reply-To: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33633-70-by5PG2d8Ac@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- But how do those tools operate and should we be using them? If you use a web service, it will know that you requested information about a certain email, giving them more information. I might not know much about how this works, but I would not want the library to use a third party vendors software and give them my email (GDPR etc.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:38:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:38:08 +0000 Subject: [Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32357-70-RxaBaWTEzB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:38:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:38:10 +0000 Subject: [Koha-bugs] [Bug 32357] Set borrower_message_preferences.days_in_advance default to NULL In-Reply-To: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32357-70-RbwUVg60bC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32357 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149223|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150405&action=edit Bug 32357: Set borrower_message_preferences.days_in_advance default to NULL To test: 1. prove t/db_dependent/cronjobs/advance_notices_digest.t 2. prove t/db_dependent/Letters/TemplateToolkit.t 3. prove t/db_dependent/Koha/CurbsidePickups.t 4. prove t/db_dependent/Koha/Patrons.t 5. prove t/db_dependent/Patron/Messaging.t Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:39:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:39:29 +0000 Subject: [Koha-bugs] [Bug 23773] Send MEMBERSHIP_EXPIRY notice by SMS In-Reply-To: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23773-70-S32IE3jHEf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23773 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:39:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:39:39 +0000 Subject: [Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4 In-Reply-To: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33582-70-dyNNkFaDlz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |lucas at bywatersolutions.com |y.org | CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:43:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:43:41 +0000 Subject: [Koha-bugs] [Bug 15428] Different timeout preference for OPAC and staff interface In-Reply-To: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15428-70-gxnFOWbSME@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15428 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to David Cook from comment #11) > (In reply to Marcel de Rooy from comment #10) > > (In reply to David Cook from comment #9) > > > (In reply to Katrin Fischer from comment #7) > > > > Marked bug 32385 as a dependency for this one. I think in order to have > > > > different timeouts, we need different sessions first. > > > > > > Actually, thinking about this again, you would already have different > > > sessions between the OPAC and staff interface, so long as your hostname is > > > different, which should be 99% of Koha instances... > > > > How do you calculate that 99% ? > > Perhaps I should say 99% of commercially supported Koha instances. Even then > you're right that it's a total guess based off the idea that Koha defaults > to separate hostname for OPAC and staff interface when using Debian > packages, and most commercial support vendors for Koha seem to use Debian > packages. You are right that different subdomains will create separate sessions, but I think the 99% is wrong. Koha used ports for a long time in its default setup and there are still reasons why you would want to do so. We do, with packages, use ports, for the installations we support. And it doesn't solve the problem here... different sessions, one timeout. How could you attach a different timeout to each? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:46:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:46:07 +0000 Subject: [Koha-bugs] [Bug 20859] SMS and other notification preferences during self registration In-Reply-To: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20859-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20859-70-s6IrrR7JrJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20859 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I guess it would always have to be configurable through the *Unwanted* preference like all other fields. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:47:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:47:23 +0000 Subject: [Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes In-Reply-To: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21083-70-QVgdN3LsxO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Because it fixes JavaScript error breaking functionality with the patron attributes on that page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:50:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:50:47 +0000 Subject: [Koha-bugs] [Bug 24499] System preference EnhancedMessagingPreferences if set to 'Don't allow' doesn't even show within patron categories In-Reply-To: <bug-24499-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24499-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24499-70-1hAljRf2HW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Does the bug description still fit with what the patch does? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:53:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:53:44 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-DrY1fiKVP3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thanks, Nick! I am not sure really about allowing HTML and then also meddling with line breaks. It creates a somewhat weird combination. html_line_break This filter replaces any newlines with <br> HTML tags, thus preserving the line breaks of the original text in the HTML output. So you can do now without <br>, but if you add any line breaks just for making the HTML more readable, they will also all create a line break. Should we not do either/or? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:53:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:53:59 +0000 Subject: [Koha-bugs] [Bug 23773] Send MEMBERSHIP_EXPIRY notice by SMS In-Reply-To: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23773-70-EdEtCEl5hO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23773 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:54:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:54:01 +0000 Subject: [Koha-bugs] [Bug 23773] Send MEMBERSHIP_EXPIRY notice by SMS In-Reply-To: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23773-70-Gxc3aSunK9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23773 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148244|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150406&action=edit Bug 23773: Send membership expiry notices by sms too Test plan: 1. Verify in "About" page that SMS::Send is installed. If not, install it. 2. Set system preferences: - SMSSendDriver = 'Test' - MembershipExpiryDaysNotice = 30 3. In "Notices and Slips" tool, edit the 'MEMBERSHIP_EXPIRY' letter and verify that both email and sms parts are filled. Use a different title and body for the sms part 4. Create a new borrower with an email address and an SMS number. Set their expiry date to a date next week 5. Run misc/cronjobs/membership_expiry.pl --confirm 6. Verify in the patron "Notices" tab that two notices are pending, one for email, one for sms Sponsored-by: MĂ©diathĂšque de Montauban Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:55:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:55:05 +0000 Subject: [Koha-bugs] [Bug 23773] Send MEMBERSHIP_EXPIRY notice by SMS In-Reply-To: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23773-70-hYnPHxMoSW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23773 --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- QA note: My initial reaction was to require a cli switch, but simply not having that notice will disable the feature from the UI, which is preferable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:55:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:55:22 +0000 Subject: [Koha-bugs] [Bug 27765] Set a custom order to libraries on the libraries page in the OPAC In-Reply-To: <bug-27765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-27765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-27765-70-gJU8KfQ7Of@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27765 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Set a custom order to |Set a custom order to |library branches on |libraries on the libraries |opac-library.pl |page in the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:56:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:56:37 +0000 Subject: [Koha-bugs] [Bug 33638] New: Batch patron modification is broken Message-ID: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 Bug ID: 33638 Summary: Batch patron modification is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com While testing Bug 33582 I noticed that Batch patron modification seems to be broken: To recreate: 1. Get some valid cardnumbers and borrowernumbers 2. Go to Tools > Batch patron modification 3. Try entering either cardnumbers or borrowernumbers. Even with valid cardnumbers or borrowernumbers I get: No patron card numbers or borrowernumbers given. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 19:58:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 17:58:47 +0000 Subject: [Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search In-Reply-To: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-28166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-28166-70-8A1aQsv7o0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- This looks neat, I like the feature, the patches need some cleanup Must fix: - the patch adds the function _add_rowdata, I think it's a rebase leftover? - the call from _handle_one_result should be updated to pass the biblio related preference to the updated routine - delete the commented lines from the code Could fix: - the routine should take a hashref, the more parameters we have, the nicer it i s to have them named -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:02:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:02:01 +0000 Subject: [Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4 In-Reply-To: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33582-70-aQknTnaL6F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:02:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:02:03 +0000 Subject: [Koha-bugs] [Bug 33582] Use template wrapper for breadcrumbs: Tools, part 4 In-Reply-To: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33582-70-wj6HOKfAff@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33582 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150156|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150407&action=edit Bug 33582: Use template wrapper for breadcrumbs: Tools, part 4 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Notices and slips - New notice - Edit notice - Confirm deletion - Batch patron modification - Overdue notice/status triggers - Cataloging -> - Manage staged records - Batch details - MARC modification templates - Edit actions for a template Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:10:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:10:34 +0000 Subject: [Koha-bugs] [Bug 25379] HTML in circulation notes doesn't show correctly on checkin In-Reply-To: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-25379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-25379-70-l10wvfmDG9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25379 --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #11) >if you add any line breaks just for > making the HTML more readable, they will also all create a line break. > Should we not do either/or? We had calls that already did this - if we want either or, we need a flag to determine whether the field is HTML or not, otherwise we need to test with regex? I don't think the additional breaks for HTML cause a problem, but I'll follow your viewpoint. Maybe a new bug - so we can make a decision and be consistent on all the calls? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:16:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:16:38 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-NDiPKsnLEE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150393|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 150408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150408&action=edit Bug 33634: Correct anchors in system preference submenu To test: 1. Go to Koha Administration -> Global system preferences 2. Go to a tab with a few headings like Circulation 3. Click on a heading in the sidebar navigation under Circulation that takes you a bit down the page, like Recalls 4. Notice this anchor link does not work, you are not taken to the recalls preferences 5. Apply patch 6. Try again, the links should take you to the proper place. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:17:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:17:53 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-umKt3FyB7T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:18:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:18:02 +0000 Subject: [Koha-bugs] [Bug 33638] Batch patron modification is broken In-Reply-To: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33638-70-tBhkpUQLN9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:18:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:18:04 +0000 Subject: [Koha-bugs] [Bug 33638] Batch patron modification is broken In-Reply-To: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33638-70-u13RTLu20j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150409&action=edit Bug 33638: Fix if statement in modborrowers.tt To test: 1. Get some valid cardnumbers and borrowernumbers 2. Go to Tools > Batch patron modification 3. Try entering either cardnumbers or borrowernumbers. 4. Apply patch 5. Try again, now it should work. 6. Make sure it works for both cardnumbers and borrowernumbers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:18:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:18:33 +0000 Subject: [Koha-bugs] [Bug 33638] Batch patron modification is broken In-Reply-To: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33638-70-5BOGYngT0Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:22:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:22:19 +0000 Subject: [Koha-bugs] [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes In-Reply-To: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21083-70-ZwbIUCFocn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 --- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> --- If you are testing this bug it is probably good to know about this one which may effect your ability to test: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:25:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:25:15 +0000 Subject: [Koha-bugs] [Bug 33638] Batch patron modification is broken In-Reply-To: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33638-70-MQ02VSaKwD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150409|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 150410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150410&action=edit Bug 33638: Fix if statement in modborrowers.tt To test: 1. Get some valid cardnumbers and borrowernumbers 2. Go to Tools > Batch patron modification 3. Try entering either cardnumbers or borrowernumbers. 4. Apply patch 5. Try again, now it should work. 6. Make sure it works for both cardnumbers and borrowernumbers. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:25:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:25:45 +0000 Subject: [Koha-bugs] [Bug 33638] Batch patron modification is broken In-Reply-To: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33638-70-pIDT2TPrnk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:30:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:30:24 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-HwzzZ2PnbM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:31:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:31:45 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-7NRHcZz4yC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:31:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:31:47 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-NrcBUovYAe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 150411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150411&action=edit Bug 32993: Holds priority changed incorrectly with dropdown selector Test Plan: 1) Find record with at least 3 holds. 2) Change first holds priority as 2, Priority is changed to 3. 3) Try to change priority back to 1, Priority is changed to 2. 4) Apply this patch 5) Reload the page 2) Change first holds priority as 2, Priority is changed to 2. 3) Try to change priority back to 1, Priority is changed to 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:36:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:36:32 +0000 Subject: [Koha-bugs] [Bug 32894] Objects cache methods' result without invalidation In-Reply-To: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32894-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32894-70-HSJV0z4TPq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- Something is not right with Koha::Item::last_returned_by It returns a patron object, but the relationship is to ItemsLastBorrower and the call to set it doesn't work prove -v t/db_dependent/Circulation/StoreLastBorrower.t Also Koha/Virtualshelfshare.pm : everywhere else we assign resultset to rs, then create new - it isn't wrong, just inconsistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:39:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:39:06 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-WrRbEpptZu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:39:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:39:09 +0000 Subject: [Koha-bugs] [Bug 33356] Add link to mana-kb settings from 'Useful resources' in reports In-Reply-To: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33356-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33356-70-pqESMIkO2q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33356 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149985|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150412&action=edit Bug 33356: Add mana-kb hint to reports start page An alternate placement of the Mana KB hint on the reports start page. To test: * Go to Reports module * Verify the hint shows when you haven't decided on Mana KB * Once you set yes or no, it will no longer show Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:43:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:43:09 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-p9JShL6QUI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:43:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:43:11 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-eCDsNf2l6o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150148|0 |1 is obsolete| | Attachment #150149|0 |1 is obsolete| | Attachment #150151|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150413&action=edit Bug 33597: Get rid of warning about intranet_bib_list Resolve: Cookie “intranet_bib_list” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. basket_22.1200022.js:67:65 Test plan: Do not apply this patch. Logout from staff. Check browser console warnings. Apply this patch. Login and logout again. Check warnings again. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:43:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:43:13 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-dzfdMTgJke@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150414&action=edit Bug 33597: Fix deleting cookie for holdfor(club) Resolve: Cookie “holdfor” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. Did not see warning for holdforclub. But since it is created with Lax, we should remove it with Lax. Test plan: Similar to previous patch. Check console on logout page. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:43:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:43:15 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-mliYnY2jsS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150415&action=edit Bug 33597: (follow-up) Two other occurrences for holdfor Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:44:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:44:07 +0000 Subject: [Koha-bugs] [Bug 33597] Get rid of few SameSite warnings In-Reply-To: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33597-70-kCN2coYTjd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33597 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- I still noted 6 warnings about this, but we don't need to do them all at once :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:49:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:49:56 +0000 Subject: [Koha-bugs] [Bug 33633] Check if email exists In-Reply-To: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33633-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33633-70-4vsjXWWERy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33633 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I have my doubts whether this should be part of Koha as ILS. I suppose that you could process/parse the mail logs from an internal mail server (if being used) in a "neighboring application" and support changing mail queue status and/or patron email address etc. via REST API in order to signal that there are issues with this address. Perhaps we need a flag to temporarily block email. Just brainstorming.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:56:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:56:54 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-Lj8TMWQzuL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:56:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:56:56 +0000 Subject: [Koha-bugs] [Bug 32232] Koha crashes if dateofbirth is 1947-04-27, 1948-04-25, or 1949-04-24 In-Reply-To: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32232-70-wxmNyX5qbd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32232 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149758|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150416&action=edit Bug 32232: Ignore DST when calculating patron age This change calculates patron age using the floating timezone, so that datetimes missing midnight don't cause fatal errors in the comparison. Test plan: 0. Apply patch 1. Change <timezone></timezone> in koha-conf.xml to include Canada/Eastern 2. koha-plack --restart kohadev 3. Create a patron, setting the date of birth to one of these three dates - 1947-04-27 - 1948-04-25 - 1949-04-24 4. Save the patron 5. Patron detail page loads instead of producing fatal error Signed-off-by: Marius Mandrescu <marius.mandrescu at inLibro.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:57:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:57:42 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-dqrPi09VNg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 20:57:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 18:57:45 +0000 Subject: [Koha-bugs] [Bug 32993] Holds priority changed incorrectly with dropdown selector In-Reply-To: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32993-70-2oYNPI41Zh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32993 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150411|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 150417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150417&action=edit Bug 32993: Holds priority changed incorrectly with dropdown selector Test Plan: 1) Find record with at least 3 holds. 2) Change first holds priority as 2, Priority is changed to 3. 3) Try to change priority back to 1, Priority is changed to 2. 4) Apply this patch 5) Reload the page 2) Change first holds priority as 2, Priority is changed to 2. 3) Try to change priority back to 1, Priority is changed to 1. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 21:07:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 19:07:16 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-0a9s4Cqps4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150394|0 |1 is obsolete| | --- Comment #2 from David Nind <david at davidnind.com> --- Created attachment 150418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150418&action=edit Bug 33637: Update tab ids for batch modification form This patch adjusts the ids in the submit function To test: 1 - Browse to tools -> Batch patron modification 2 - Enter cardnumbers and submit 3 - No patrons 4 - Enter borrowernumbers and submit 5 - No patrons 6 - Apply patch 7 - Repeat 8 - Success, patrons are listed Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 21:07:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 19:07:44 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-9e1bKWSzgp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 21:11:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 19:11:06 +0000 Subject: [Koha-bugs] [Bug 33638] Batch patron modification is broken In-Reply-To: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33638-70-HSJrb63z6s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind <david at davidnind.com> --- This looks like a duplicate of bug 33637 - I'll leave it to the patch authors to decide which is the 'best' solution 8-). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 21:11:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 19:11:10 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-PvlSSVd8eh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 --- Comment #3 from David Nind <david at davidnind.com> --- This looks like a duplicate of bug 33638 - I'll leave it to the patch authors to decide which is the 'best' solution 8-). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 21:11:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 19:11:30 +0000 Subject: [Koha-bugs] [Bug 33638] Batch patron modification is broken In-Reply-To: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33638-70-igNkvA6MvU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33637 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 21:11:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 19:11:30 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-cHLeBwvD3O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33638 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 21:17:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 19:17:44 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-0lhs4LbsYk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|phil at chetcolibrary.org |nick at bywatersolutions.com --- Comment #8 from Phil Ringnalda <phil at chetcolibrary.org> --- That does still retain one behavior change, altering the meaning of the "Try another search" button on search results from the historic "Try a different search starting from scratch with an empty form" to "Try another search starting with a form prefilled from the saved record" but I can't object too much to that, since I have always avoided the another search from scratch button, preferring to use the browser's back button if I'm only a page or two forward, or just closing and reopening the popup if I'm several pages deep. According to my concept of the meaning of "stable" we should still revert back down to oldoldstable and then land this on master, but obviously my concept of stable is very different from Koha's. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 21:18:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 19:18:33 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-eu23MdT6Jg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 21:18:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 19:18:36 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-6CuMuSCPDp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 Phil Ringnalda <phil at chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149624|0 |1 is obsolete| | Attachment #150368|0 |1 is obsolete| | --- Comment #9 from Phil Ringnalda <phil at chetcolibrary.org> --- Created attachment 150419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150419&action=edit Bug 33445: [alternate] Pass through form info if present and use record values otherwise This patch updates the form to pass through values formthe form when searching, and to use record values if nothing is passed in. TO test: 1 - Without the patch, edit a personal name authority record 2 - Replace 100 subfield a (200 subfield a for UNIMARC) with your own name 3 - Click "Replace record via Z39.50/SRU search" 4 - Note that prefilled search field contains the original value, not your name. 5 - Replace the Author (personal) field with your name in the search form 6 - choose a search target, and click Search. 7 - Note that the results of the search are for the original value, not your name 8 - From the details page of a record, click 'Edit -> Replace record via Z3950' 9 - Note form is prefilled 10 - Change value as in 5 and search 11 - Note original term was searched 12 - Apply patch, restart all 13 - Repeat searches as before 14 - Confirm that form is prefilled with record or the updated value 15 - Confirm your entered search terms are always searched Signed-off-by: Phil Ringnalda <phil at chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 21:30:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 19:30:16 +0000 Subject: [Koha-bugs] [Bug 2646] Add sort option for the series number In-Reply-To: <bug-2646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2646-70-9hJ50REZgu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2646 Sarah Cornell <sbcornell at cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 21:44:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 19:44:51 +0000 Subject: [Koha-bugs] [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered In-Reply-To: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33262-70-N5F5pwyCf9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 Sarah Cornell <sbcornell at cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 21:55:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 19:55:18 +0000 Subject: [Koha-bugs] [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority In-Reply-To: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33445-70-KR0gCTnq9C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 --- Comment #10 from David Nind <david at davidnind.com> --- I was testing at the same time as Phil (using KTD): 1. Everything works as per the test plan. 2. However, after applying the patch and repeating the searches: - for Step 6, after getting no results using my name and clicking on "Try another search", the name in the field reverts to the original record name and not my name - for Step 10, the same as step 6 - which is probably correct (but I'm not sure...) - feel free to change the status to Failed QA if this is not the expected behavour (I would probably have failed QA if there wasn't already a sign off) 3. I tested using MARC21 and UNIMARC instances. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 22:21:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 20:21:17 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-YoaNRyfiwj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- Kidclamp's is better. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 22:21:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 20:21:42 +0000 Subject: [Koha-bugs] [Bug 33638] Batch patron modification is broken In-Reply-To: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33638-70-Jn9GtL4QwS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33638 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 33637 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 22:21:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 20:21:42 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-TPoX2FtDzb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> --- *** Bug 33638 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 22:24:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 20:24:09 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31378-70-oIGskvnfFD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #274 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Hello everyone! This is a bit technical for me, but I attempted to add the information to the manual. Would any of you who worked on this have the time to read what I wrote and let me know if I mangled anything? (It's not very long) https://gitlab.com/koha-community/koha-manual/-/merge_requests/670 Thanks! Caroline -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 22:24:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 20:24:18 +0000 Subject: [Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation In-Reply-To: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-31378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-31378-70-AiyZYn7IsX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/670 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Apr 28 22:41:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 20:41:42 +0000 Subject: [Koha-bugs] [Bug 33639] New: Adding item to item group from 'Add item' screen doesn't work Message-ID: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Bug ID: 33639 Summary: Adding item to item group from 'Add item' screen doesn't work Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: sbrown at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When creating a new item in 22.11.02, the 'Add to item group' feature at the bottom of the 'Add item' screen doesn't successfully add that new item to a group. To replicate: -Create one or more item groups for a bib if needed -Create a new item, and at the bottom of the 'Add item' screen, select the item group to which you want this item added. Save. -On the Normal tab, see that the item has not been added to the item group you selected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 00:15:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 22:15:03 +0000 Subject: [Koha-bugs] [Bug 19814] Batch Check-in function In-Reply-To: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19814-70-BhKVgSYJvw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 carthur at slolibrary.org <carthur at slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur at slolibrary.org --- Comment #28 from carthur at slolibrary.org <carthur at slolibrary.org> --- Hi, This sounds like a great, this would help a lot with our workflow! I would like to ask that it be more like batch item modification so I can use the scanner or copy/paste barcodes to check in! Thank you, Charlie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 00:26:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 22:26:52 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: <bug-33317-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33317-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33317-70-8wuv2cDgj5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148593|0 |1 is obsolete| | --- Comment #6 from Hammat wele <hammat.wele at inlibro.com> --- Created attachment 150420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150420&action=edit Bug 33317: Add system preference to set meta robots for the OPAC Websites must have a robots meta tag to improve search engine crawling, so we could tell search engines to not index OPAC pages for example. To test: 1) Look at opac-main source and see that meta name=robots is missing. 2) Apply patch. 3) Run ./installer/data/mysql/updatedatabase.pl 4) Go to system preferences > OPAC and add some directives to OpacMetaRobots (ex: noindex,nofollow). 5) Look at opac-main source and confirm that meta name=robots now has content equal to the text set in the OpacMetaRobots system preference. 6) This should Prevent search engines from indexing Opac pages (if OpacMetaRobots is set to noindex) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 00:27:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 22:27:37 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: <bug-33317-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33317-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33317-70-oegLXX52JX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Hammat wele <hammat.wele at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 00:28:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 22:28:29 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-4gdSvEU6TK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- Trivial fix, changes make perfect sense, QA script is happy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 00:28:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 22:28:55 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-kNPI2ZFq2h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 00:28:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 22:28:58 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-GL7t5VLkvj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150418|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150421&action=edit Bug 33637: Update tab ids for batch modification form This patch adjusts the ids in the submit function To test: 1 - Browse to tools -> Batch patron modification 2 - Enter cardnumbers and submit 3 - No patrons 4 - Enter borrowernumbers and submit 5 - No patrons 6 - Apply patch 7 - Repeat 8 - Success, patrons are listed Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 00:29:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 22:29:03 +0000 Subject: [Koha-bugs] [Bug 33637] Batch patron modification broken In-Reply-To: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33637-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33637-70-Gtn5nQg3gv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33637 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 01:49:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 23:49:42 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33639-70-MbFyFBTPu9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 01:49:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 23:49:44 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33639-70-pmPlR5lduC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 150422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150422&action=edit Bug 33639: Fix selectors for adding to item group To test: Apply patch 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4 - Note the bottom of the page has a form to attach to existing group 5 - Note when a group is selected the enumchron field is populated 6 - Confirm item is saved to group when saved Note: this does not fix the 'Create new item group' feature in the dropdown. I am having trouble seeing why that would work in the first in place! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 01:50:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 23:50:00 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33639-70-8QPA8DBzvs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Version|21.11 |master CC| |lucas at bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 01:53:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 23:53:31 +0000 Subject: [Koha-bugs] [Bug 33640] New: Adding new item group from item additem.pl does nothing Message-ID: <bug-33640-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33640 Bug ID: 33640 Summary: Adding new item group from item additem.pl does nothing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl To recreate: 1 - Browse to details page for a record 2 - Create or ensure the record has item group(s) 3 - Click New->New item 4. At the bottom of the page in the under Add to item group click the 'Options:' dropdown and select 'Create new item group'. 5. Add a name and click add item. 6. No item group is created. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 01:53:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Apr 2023 23:53:41 +0000 Subject: [Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work In-Reply-To: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33639-70-CHdJ48UdKY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639 --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Filed Bug 33640 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 06:37:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 04:37:12 +0000 Subject: [Koha-bugs] [Bug 32782] Add UNIMARC support to the ERM module In-Reply-To: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32782-70-fVGx7VnFWd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32782 Victor Grousset/tuxayo <victor at tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Works, makes sense (not expert so I just checked fields in code against UNIMARC documentation), QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 12:44:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 10:44:25 +0000 Subject: [Koha-bugs] [Bug 33048] Empty email link on error page when OPAC login not allowed In-Reply-To: <bug-33048-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33048-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33048-70-Rump7yPyMH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33048 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Empty email link on error |Empty email link on error |page when opac login not |page when OPAC login not |allowed |allowed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 13:03:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 11:03:08 +0000 Subject: [Koha-bugs] [Bug 32548] Make illrequestattributes easily available to ILL notices In-Reply-To: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32548-70-Pqb5IQzJD2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32548 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Nick Clemens from comment #13) > Just to be pedantic, it is possible to use these before these patches, but > it is inconvenient: > > [% FOREACH attribute IN illrequest.illrequestattributes %] > [% IF attribute.type == 'title' %] > [% attribute.value %] > [% END %] > [% END %] Thank you, Nick :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 21:30:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 19:30:15 +0000 Subject: [Koha-bugs] [Bug 33504] ILS-DI does not record renewer_id for renewals In-Reply-To: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33504-70-Nlkk366min@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33504 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind <david at davidnind.com> --- Hi Magnus You may wish to change the status to signed off. 8-) And maybe remove the Bugzilla link at the end. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 21:48:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 19:48:57 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-pZzu5QgXSy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 21:49:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 19:49:00 +0000 Subject: [Koha-bugs] [Bug 33437] Use template wrapper for breadcrumbs: Reports part 2 In-Reply-To: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33437-70-ZH70qMSgmk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33437 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150171|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150423&action=edit Bug 33437: Use template wrapper for breadcrumbs: Reports part 2 This patch updates several reports templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Reports -> - Most circulated items - Report results - Items with no checkouts - Report results - Catalog statistics wizard - Report results - View dictionary - New definition (steps 1-5) - Saved reports - View report - New report - Edit report - Guided reports - Build a report - Steps 1 through 6 Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 21:56:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 19:56:41 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-WsMb6TprYK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 21:56:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 19:56:44 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-ExpU6HYUo8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150167|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150424&action=edit Bug 33559: Use template wrapper for breadcrumbs: Serials part 2 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Serials home page - New subscription - Serials search results - Subscription details -> Edit subscription - Subscription details -> Serial collection -> Edit serials - Select one or more seach results and click the "Edit selected serials" to test the batch edit page Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 21:57:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 19:57:44 +0000 Subject: [Koha-bugs] [Bug 33559] Use template wrapper for breadcrumbs: Serials part 2 In-Reply-To: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33559-70-qKjyOcKlgY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33559 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Serial collection -> edit serials On this page the breadcrumb for current subscription leads 'subscription not found' - this is true before these patches as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 22:02:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 20:02:24 +0000 Subject: [Koha-bugs] [Bug 33564] Use template wrapper for breadcrumbs: Serials part 3 In-Reply-To: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33564-70-j9D24GzUt7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33564 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 22:02:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 20:02:27 +0000 Subject: [Koha-bugs] [Bug 33564] Use template wrapper for breadcrumbs: Serials part 3 In-Reply-To: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33564-70-yyIva2NSRi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33564 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150169|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150425&action=edit Bug 33564: Use template wrapper for breadcrumbs: Serials part 3 This patch updates several serials templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Serials -> - Manage frequencies - New frequency - Edit frequency - Manage numbering patterns - New numbering pattern - Edit numbering pattern - Search subscriptions -> View subscription details - If necessary, edit the subscription to enable "Manual history" - Under the "Planning" tab of the detail page, click "Edit history" - If necessary, edit the subscription and select a notice under "Patron notification." - Under the "Information" tab of the subscription detail page, click "subscribers" Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 22:08:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 20:08:20 +0000 Subject: [Koha-bugs] [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 In-Reply-To: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33566-70-yjepGrDSqU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 22:08:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 20:08:22 +0000 Subject: [Koha-bugs] [Bug 33566] Use template wrapper for breadcrumbs: Tools, part 1 In-Reply-To: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33566-70-1yHeq9m0PG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33566 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150202|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150426&action=edit Bug 33566: Use template wrapper for breadcrumbs: Tools, part 1 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Batch extend due dates - Access files (it is not necessary to have file access configured to test, there are no variations to the breadcrumbs) - News, HTML customizations, and Pages: For each category check each variation: - List of entries - New entry - Edit entry - Cataloging -> - Batch record deletion - Item modifications by age - Edit rules Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 22:12:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 20:12:16 +0000 Subject: [Koha-bugs] [Bug 33596] Merge result page is missing page-section In-Reply-To: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33596-70-5TYOJ9EnBr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33596 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 22:12:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 20:12:19 +0000 Subject: [Koha-bugs] [Bug 33596] Merge result page is missing page-section In-Reply-To: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33596-70-j391fYDD4K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33596 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150177|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150427&action=edit Bug 33596: Merge result page is missing page-section This patch adds a "page-section" container around the contents of the page seen when you complete the process of merging catalog records. The patch also adds the "merge was successful" message into the standard message dialog. Perform a catalog search which will return more than one record. - Select two records in your search results and click "Edit" -> "Merge records." - Complete the process of merging your selected records. - On the last page you should see a "merge was successful" message styled as the standard information box. - The "Report" section should be shown inside a "page-section" div. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 22:18:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 20:18:30 +0000 Subject: [Koha-bugs] [Bug 33598] Use template wrapper for breadcrumbs: Tools, part 5 In-Reply-To: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33598-70-BgUxNz0XM7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33598 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 22:18:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 20:18:32 +0000 Subject: [Koha-bugs] [Bug 33598] Use template wrapper for breadcrumbs: Tools, part 5 In-Reply-To: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33598-70-1tnsMdqhLA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33598 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150157|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150428&action=edit Bug 33598: Use template wrapper for breadcrumbs: Tools, part 5 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Pages -> - View a page in the staff interface - Upload patron images - Upload results - Quote editor - Quotes upload - OPAC problem reports (must have OPACReportProblem enabled) Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 23:03:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 21:03:42 +0000 Subject: [Koha-bugs] [Bug 33010] CheckinSlip doesn't return checkins if checkout branch and checkin branch differ In-Reply-To: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33010-70-CnQ05Pg0Wq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 23:03:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 21:03:44 +0000 Subject: [Koha-bugs] [Bug 33010] CheckinSlip doesn't return checkins if checkout branch and checkin branch differ In-Reply-To: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33010-70-il55GnIrW6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150174|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 150429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150429&action=edit Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl If one tries to print checkin slip for checkins that have been checked out from different branch, list of checkins is empty. One has to change their branch as checkout library to be able to print checkins. This happens because we filter (or rather search) patrons old checkouts with logged in patrons branch. This patch removes this search so that checkout are filtered using just filter_by_todays_checkins. To test: 1. Checkout items for patron from branch A. 2. Switch to branch B and checkin items. 3. Print checkin slip. => Checkins list is empty. 4. Switch back to branch A. 5. Print checkin slip again. => Checkins are printed. 6. Apply this patch, restart services if needed. 7. Switch back to branch B and print checkin slip. => Checkins should now print. Sponsored-by: Koha-Suomi Oy Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 23:05:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 21:05:18 +0000 Subject: [Koha-bugs] [Bug 33641] New: We should record return branch in old checkouts (oldissues) Message-ID: <bug-33641-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Bug ID: 33641 Summary: We should record return branch in old checkouts (oldissues) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org See bug 33010 - the intention is to list the checkouts returned at current branch, but we only store this info in statistics. It would be handy to keep this info in the issue/oldissues tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 23:05:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 21:05:29 +0000 Subject: [Koha-bugs] [Bug 33641] We should record return branch in old checkouts (oldissues) In-Reply-To: <bug-33641-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33641-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33641-70-ekwrwwIMML@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 [Bug 33010] CheckinSlip doesn't return checkins if checkout branch and checkin branch differ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 23:05:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 21:05:29 +0000 Subject: [Koha-bugs] [Bug 33010] CheckinSlip doesn't return checkins if checkout branch and checkin branch differ In-Reply-To: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33010-70-ChEJvYHDdu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33010 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33641 [Bug 33641] We should record return branch in old checkouts (oldissues) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Apr 29 23:53:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Apr 2023 21:53:08 +0000 Subject: [Koha-bugs] [Bug 30002] Add project-level perltidyrc In-Reply-To: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30002-70-ScEOviqhn3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30002 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #16 from David Nind <david at davidnind.com> --- Discussion at the 26 April 2023 Development IRC Meeting. To vote on this at the next Development IRC Meeting - see https://meetings.koha-community.org/2023/development_irc_meeting_26_april_2023.2023-04-26-14.31.log.html#l-87 Added to the agenda: https://wiki.koha-community.org/wiki/Development_IRC_meeting_10_May_2023 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 12:39:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 10:39:55 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-32910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-32910-70-DuJown6lfR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Any chance for this one still? I'd like to pick a new icon for inventory from the newer version :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 23:19:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 21:19:01 +0000 Subject: [Koha-bugs] [Bug 23781] Recalls notices and messaging preferences In-Reply-To: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23781-70-21gKp6lUcM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 23:19:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 21:19:04 +0000 Subject: [Koha-bugs] [Bug 23781] Recalls notices and messaging preferences In-Reply-To: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23781-70-zTm5cEOtzL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148260|0 |1 is obsolete| | --- Comment #20 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150430&action=edit Bug 23781: SMS notices and messaging preferences for recalls This patch adds recalls notices (pick up a waiting recall or return a requested recall) to the messaging preferences. To test: 1) Apply Bug 19532 2) Apply this bug 3) Update database, rebuild dbix files 4) Ensure UseRecalls syspref is enabled and values have been set in the circulation rules for recalls 5) Go to a borrower (Person A) account page in the Intranet or the OPAC 6) Go to messaging preferences 7) Notice there are now preferences for two recalls notices 8) Select email as a preference 9) Find a different borrower (Person B) and set their messaging preferences to SMS 10) Check out any item to Person B 11) Go to the OPAC logged in as Person A and find that item 12) Recall the item 13) In the terminal, look at the message_queue in the database. There should be a 'RETURN_RECALLED_ITEM' recall notice sent to Person B via SMS 14) Go back to the Intranet and check in the item. Confirm the recall when checking in 15) Look at the message_queue in the database again. There should be a 'PICKUP_RECALLED_ITEM' recall notice sent to Person A via email. 16) Confirm tests pass t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 23:19:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 21:19:47 +0000 Subject: [Koha-bugs] [Bug 23781] Recalls notices and messaging preferences In-Reply-To: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23781-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23781-70-mSWr5Xwh0X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23781 --- Comment #21 from Aleisha Amohia <aleisha at catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #19) > Applying: Bug 23781: SMS notices and messaging preferences for recalls > Using index info to reconstruct a base tree... > M Koha/Recall.pm > M Koha/Recalls.pm > M installer/data/mysql/en/mandatory/sample_notices.yml > Falling back to patching base and 3-way merge... > Auto-merging installer/data/mysql/en/mandatory/sample_notices.yml > Auto-merging Koha/Recalls.pm > CONFLICT (content): Merge conflict in Koha/Recalls.pm > Auto-merging Koha/Recall.pm > CONFLICT (content): Merge conflict in Koha/Recall.pm Fixed, set back to Signed Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 23:21:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 21:21:37 +0000 Subject: [Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled In-Reply-To: <bug-30295-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30295-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30295-70-QADqhRsRJG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 23:21:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 21:21:40 +0000 Subject: [Koha-bugs] [Bug 30295] Send a notification when a recall is manually cancelled In-Reply-To: <bug-30295-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30295-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30295-70-YhRndWf7OX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30295 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149127|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150431&action=edit Bug 30295: Send a notification when a recall is manually cancelled This patch adds a RECALL_MANUAL_CANCEL email and sms notice which will be sent to the requestor when their recall is cancelled. This notice can also be configured using the messaging preferences. To test: 1. Apply the patch, update database, restart services. 2. Ensure UseRecalls system preference is enabled and values have been set in the circulation rules for recalls 3. Log in as a patron (Patron A) to the staff client and view your account details 4. Notice there is now a 'recall cancelled' notice that can be configured under messaging preferences 5. Confirm this notice also shows in the messaging preferences page on the OPAC 6. Select email and sms as a preference for the 'recall cancelled' notice and save. You may need to enable other settings to see the sms options (SMSSendDriver for example) 7. Check out an item to another patron (Patron B) 8. Log into the OPAC as Patron A and place a recall on the checked out item/biblio 9. Go back to the staff client and view the biblio. Go to the recalls tab and cancel the recall. 10. Go to Patron A's accout and view their notices tab 11. Confirm the 'recall cancelled' notice has been generated for both email and sms. Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Andrew Auld <andrew.auld at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 23:23:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 21:23:32 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-REVpSpLhsL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |aleisha at catalyst.net.nz |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 23:23:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 21:23:58 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-8ZyGmYzbW3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 23:24:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 21:24:00 +0000 Subject: [Koha-bugs] [Bug 33634] Sidebar navigation links in system preferences not taking user to the clicked section In-Reply-To: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-33634-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-33634-70-kYJJu7Ulo7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33634 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150408|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150432&action=edit Bug 33634: Correct anchors in system preference submenu To test: 1. Go to Koha Administration -> Global system preferences 2. Go to a tab with a few headings like Circulation 3. Click on a heading in the sidebar navigation under Circulation that takes you a bit down the page, like Recalls 4. Notice this anchor link does not work, you are not taken to the recalls preferences 5. Apply patch 6. Try again, the links should take you to the proper place. Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov> Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 23:34:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 21:34:26 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-Yg6IWfhSW0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 23:34:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 21:34:29 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-omg6O25ZoU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147838|0 |1 is obsolete| | Attachment #150387|0 |1 is obsolete| | --- Comment #21 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150433&action=edit Bug 30928: Add tests prove -v t/db_dependent/Koha/Statistics.t prove -v t/db_dependent/Stats.t Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 23:34:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 21:34:32 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-9XpDJhZo08@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150386|0 |1 is obsolete| | --- Comment #22 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150434&action=edit Bug 30928: Add interface to statistics Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 23:34:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 21:34:35 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-rkIHHZmS5v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #23 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150435&action=edit Bug 30928: (QA follow-up) DB updates Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 30 23:34:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Apr 2023 21:34:39 +0000 Subject: [Koha-bugs] [Bug 30928] Add interface to statistics table In-Reply-To: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-30928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-30928-70-48vQ4ICbzD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 --- Comment #24 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 150436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150436&action=edit Bug 30928: (QA follow-up) Schema updates Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> -- You are receiving this mail because: You are watching all bug changes.