[Koha-bugs] [Bug 33417] Create one standard Toolbar component

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #12 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
Tested, and it does not work.

% git --no-pager diff **/*.vue
diff --git
a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue
b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue
index 5fee4862f17..a2bca463341 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue
+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue
@@ -88,10 +88,12 @@ export default {
             toolbar_options: [
                 {
                     to: "AgreementsFormAdd",
-                    button_title: "New agreement",
+                    button_title: "Here is a test string",
                 },
             ],
+            another_string: this.$__("Here is ANOTHER string"),
         }
     },
     beforeRouteEnter(to, from, next) {
         next(vm => {


% cd misc/translator
% perl translate update fr-FR
% git grep 'Here is .* string' misc/translator/po/fr-FR-*
misc/translator/po/fr-FR-messages-js.po:msgid "Here is ANOTHER string"

Matt, you are not supposed to add the string in the po file manually. What I
meant previously is that the 'update' part of the translate process is picking
the strings from the source code (tt, inc, js and vue files).

To make it aware of the strings (and so new strings) you MUST use explicitly
the __() function ($__() in vue files)

If you didn't add the string manually in the po file then tell me which black
magic you used ;)

-- 
You are receiving this mail because:
You are watching all bug changes.