[Koha-bugs] [Bug 33304] Report schedule form time input element attribute type changed to improve valid time value entry

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Apr 7 04:31:55 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33304

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148519|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 149252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149252&action=edit
Bug 33304: Report schedule form time input element attribute type changed to
improves valid time value entry

I offer an enhancement for the task scheduler form:
/cgi-bin/koha/tools/scheduler.pl via scheduler.tt

The time input element currently has an 'text' value for type attribute. This
requires a user to enter a valid time string for any scheduled report manually
which is no fun. I have created patch in scheduler.tt that changes the type
attribute value from 'text' to 'time' which makes the input of valid time easy.
This change leveraged standard web form principles of html5 and would be
compatible with any modern browser such as chrome, firefox and safari.

To test:
1) login to koha instance
2) navigate to report module from home page
3) create test report with basic action and save. (no actual run of report is
requires, simply need to save with valid syntax)
...
SELECT id
FROM biblio_metadata
LIMIT 1
...
4) Press 'Schedule' icon from nav options
5) Enter relevant time value for schedule in 'time' input element which now has
type 'time' attribute 3.00 pm, added easily.
6) Enter valid future date
7) Enter valid email address and press 'Save'
8) SIGN OFF

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list