[Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
Testing notes using KTD:

1. I used Ruben Harper (23529000686353) as the guarantor and Joyce Gaines
(23529000224510) and Bobbie Middleton (23529000080862) as the guarantees.

2. I wasn't sure how to restart the SIP emulator after applying the patch, so
ending up shutting down and starting up KTD (otherwise there was no change in
the responses received).

3. Tests passed after applying the patches: t/db_dependent/SIP/Patron.t 

Results before patch applied
============================

kohadev-koha at kohadevbox:koha(master)$ perl misc/sip_cli_emulator.pl -a
localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron
23529000686353
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 123.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941

Trying 'patron_information'
SEND: 6300120230407    201515          AOCPL|AA23529000686353|ACterm1|
READ: 64YYYY          00120230407   
201515000000000000000100000000AOCPL|AA23529000686353|AERuben
Harper|BLY|BV1|CC5|BD6963 Library Rd. Springfield, MA 44224|BF(212)
555-1212|PB19170924|PCS|PIY|AFGreetings from Koha.  -- Patron blocked by fines
(11) on guaranteed accounts -- Patron owes 1.00|


kohadev-koha at kohadevbox:koha(master)$ perl misc/sip_cli_emulator.pl -a
localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron
23529000224510
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 123.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941

Trying 'patron_information'
SEND: 6300120230407    201635          AOCPL|AA23529000224510|ACterm1|
READ: 64              00120230407   
201635000000000000000100000000AOCPL|AA23529000224510|AEJoyce
Gaines|BLY|BV5|CC5|BD6012 Library Rd. Springfield, MA 44224|BF(212)
555-1212|PB20080407|PCYA|PIY|AFGreetings from Koha.  -- Patron owes 5.00|


kohadev-koha at kohadevbox:koha(master)$ perl misc/sip_cli_emulator.pl -a
localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron
23529000080862
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 123.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941

Trying 'patron_information'
SEND: 6300120230407    201658          AOCPL|AA23529000080862|ACterm1|
READ: 64              00120230407   
201658000000000000000100000000AOCPL|AA23529000080862|AEBobbie
Middleton|BLY|BV5|CC5|BD4619 Library Rd. Springfield, MA 44224|BF(212)
555-1212|PB20080407|PCJ|PIY|AFGreetings from Koha.  -- Patron owes 5.00|


Results after patch applied
============================

kohadev-koha at kohadevbox:koha(bz33411)$ perl misc/sip_cli_emulator.pl -a
localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron
23529000686353
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 123.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941

Trying 'patron_information'
SEND: 6300120230407    202802          AOCPL|AA23529000686353|ACterm1|
READ: 64              00120230407   
202802000000000000000000000000AOCPL|AA23529000686353|AERuben
Harper|BLY|BV0|CC5|BD6963 Library Rd. Springfield, MA 44224|BF(212)
555-1212|PB19170924|PCS|PIY|AFGreetings from Koha. |


kohadev-koha at kohadevbox:koha(bz33411)$ perl misc/sip_cli_emulator.pl -a
localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron
23529000224510
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 123.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941

Trying 'patron_information'
SEND: 6300120230407    203519          AOCPL|AA23529000224510|ACterm1|
READ: 64              00120230407   
203519000000000000000000000000AOCPL|AA23529000224510|AEJoyce
Gaines|BLY|BV0|CC5|BD6012 Library Rd. Springfield, MA 44224|BF(212)
555-1212|PB20080407|PCYA|PIY|AFGreetings from Koha. |


kohadev-koha at kohadevbox:koha(bz33411)$ perl misc/sip_cli_emulator.pl -a
localhost -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron
23529000080862
Attempting socket connection to localhost:6001...connected!
Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl
line 123.
SEND: 9300CNterm1|COterm1|CPCPL|
READ: 941

Trying 'patron_information'
SEND: 6300120230407    203605          AOCPL|AA23529000080862|ACterm1|
READ: 64              00120230407   
203605000000000000000000000000AOCPL|AA23529000080862|AEBobbie
Middleton|BLY|BV0|CC5|BD4619 Library Rd. Springfield, MA 44224|BF(212)
555-1212|PB20080407|PCJ|PIY|AFGreetings from Koha. |

-- 
You are receiving this mail because:
You are watching all bug changes.