[Koha-bugs] [Bug 33103] Add vendor aliases

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #35 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Katrin Fischer from comment #34)

Thanks, Katrin!

> 1) Please check:
>  FAIL	Koha/Acquisition/Bookseller/Alias.pm
>    FAIL	  pod coverage
> 		POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666

False positive.

>  OK	Koha/Acquisition/Bookseller/Aliases.pm
>  OK	Koha/Schema/Result/Aqbookseller.pm
>  FAIL	Koha/Schema/Result/AqbooksellerAlias.pm
>    FAIL	  pod coverage
> 		POD is missing for koha_object_class
> 		POD is missing for koha_objects_class

POD is always missing for those methods. Nothing to worry here.

> 2) Vendor detail page
> 
> * We should add some space between the the alias name and the trash
> * More important: it needs at least a tool tip, right now it's a big
> accessibility issue. I believe with aria-hidden=true it will actually be
> invisible to screen readers?
> * Same goes for the Plus icon to add another field: space and accessibility.
> * When you click 'enter' in the field, the form submits 'save' and you are
> back on the detail page, but the alias was not saved.

Fixed in "Fix accessibility issues"

> 3) Other features
> 
> * Search and display in the aquisition module work nicely
> 
> 4) ERM module
> 
> I am not persuaded by the display tbh, I believe it will get messy very soon
> as often those aliases will be quite long and we might even want to record a
> slight name change. 
> 
> Could it be an option to show the aliases in the list as "second level"
> entries, kind of a hiearchical display, like we have it for funds? 
> 
> 
> I know that CORAL uses the aliases also for matching in some form (I believe
> when importing data), so it will be really nice to have this feature.

It was the easiest approach to make the filtering works in the ERM module.
Could we move that to its own bug?

-- 
You are receiving this mail because:
You are watching all bug changes.