[Koha-bugs] [Bug 33484] Generalise table saveState for all tables

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484

Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> ---
Update: The tables that aren't retaining the save state are generated with the
REST API wrapper from datatables.js, not the KohaTable wrapper from
column_settings.inc. All the tables I've tested that use the KohaTable wrapper
do retain the save state as intended. I think I do need to set this in its
current state to Failed QA for causing a regression on branches.tt, though.

As for the fact that saveState saves pagination and filters, there are
certainly times when that's less desirable, but there are times when it is
desirable too. Part of what spurred me to create bug 33426 was that our
selectors want that behavior on the purchase suggestion table. Also, to be
fair, the same could be said for saving the column configuration - there are
definitely times when staff hide certain columns to make a page print more
nicely, but don't necessarily need that state to persist.

That being said...there are definitely some tables where saving the search
filters is almost never going to be desirable. For example, on holdings_table
in detail.pl, because the search filter on one bib will carry over to a
different bib where that search filter may not even make sense. Not sure what
the right answer is here... Go back to adding saveState only to certain tables
individually, where it's actually needed? Add it globally but make it
configurable (which would add some scope creep)?

-- 
You are receiving this mail because:
You are watching all bug changes.