[Koha-bugs] [Bug 33490] Agreements - Filter by expired results in error

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33490

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK.. I'm happy with that last patch now.

However, it does mean that the old url of `/agreements?by_expired=true` leads
to a datatables error as we no longer autofill table_url with a default
max_expiration_date when it's not passed in the url.

The url you'll see in the address bar will include max_expiration_date however,
so as long as someone isn't manually typing their url and leaving out the date
we're OK.. Does this seem reasonable to you Jonathan.. or should we have belt
and braces and autofill for both cases as my last patch did?

-- 
You are receiving this mail because:
You are watching all bug changes.