[Koha-bugs] [Bug 32450] Make it possible to exclude debit types from charges counted for circulation restriction (noissuecharge)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32450

--- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Preliminary QA Comments
Bit confusing as to naming.
+        my @renewals = ('RENT', 'RENT_DAILY', 'RENT_RENEW',
'RENT_DAILY_RENEW');
+                    if($_ eq 'RentalsInNoissuesCharge') { push
@debit_types_to_update, @renewals};
Will fix in a follow-up.

+                    if($_ eq 'ManInvInNoissuesCharge') { push
@debit_types_to_update, @manual};
Perl allows you to do: statement if condition; for these kind of lines.
When we are using { }, we normally add newlines etc.
No blocker

This is a theory thing. But if you run it multiple times, the field has been
inserted already and the DEFAULT 1 has been applied. The sysprefs have been
deleted, so saying 'default value has been applied' is not true anymore. They
are not reset again or so.
No blocker, just noting.

Wording is a bit less intuitive. The column name is No issues charge (which is
already obscure). And then we could have the value Not included. Twice, no and
not, might not be very clear. No blocker, could be improved. Or even should be,
I am breaking my head every time ;)

Similar for sub non_issues_charges. Already existed. But non should better be
no here, I guess. Leaving as-is.

Remove prefs from C4/UsageStats.pm. See follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.