[Koha-bugs] [Bug 33447] Add caching to Biblio->pickup_locations

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33447

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #8)
> (In reply to Marcel de Rooy from comment #5)
> > I think that it would be a very good thing to try caching here. What I am
> > not sure about, is the theoretical possibility of getting wrong results if
> > we would repeatedly ask for pickup_locations (while handling one request).
> > 
> > The change in the test confirms this actually. You do not add a test for
> > caching, but just add a flush. Removing that one makes the test fail.
> > 
> > # Subtest: pickup_locations
> >     not ok 6 - ReservesControlBranch: PatronLibrary, biblio1, patron8 should
> > return 3 but returns 1
> >     not ok 7 - ReservesControlBranch: PatronLibrary, biblio2, patron1 should
> > return 0 but returns 2
> >     not ok 8 - ReservesControlBranch: PatronLibrary, biblio2, patron8 should
> > return 3 but returns 0
> >     # Looks like you failed 3 tests of 9.
> > not ok 8 - pickup_locations
> > 
> > I would recommend to add the flush in Biblio->pickup_locations.
> 
> Those tests fail because we have changed a syspref - we are essentially
> testing multiple requests there. It is not expected for a syspref to change
> during a request. I flush to indicate that

Thx for explaining. Would be good to add a short comment for such things.

-- 
You are receiving this mail because:
You are watching all bug changes.