[Koha-bugs] [Bug 33216] SIP fee paid messages explode if payment registers are enabled and the SIP account has no register

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33216

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149795|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 149796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149796&action=edit
Bug 33216: Catch and handle RegisterRequired exceptions for SIP fee paid
messages

If registers are being used in Koha, they are required. If a SIP account has no
register and a fee paid message is sent, the SIP server crashes and the client
never gets a response. It would be much better if Koha would response with 38
response where "payment accepted" is N, and an AF field stating that the SIP
account needs to be associated with a register.

Test Plan:
1) Enable UseCashRegisters, set RequireCashRegister to "always require a
   cash register". Do *not* set a cash register for the SIP account you
   will be testing with.
2) Using the SIP cli tester, send a fee paid message for a patron owing
   fees.
3) Note the lack of a SIP response
4) Apply this patch
5) Restart the SIP server
6) Repeat step 2, you should now get a SIP response with the error
   message in it!

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.