[Koha-bugs] [Bug 31187] Regression, Permanent shelving location is always updated when editing location VIA BATCH ITEM MOD if both are mapped to MARC fields

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31187

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #2)
> It seems we keep running into this kind of issue in some variations.

This is why I add a test here, to prevent future breakage

> Actually, I am also confused: 
> When do we want to update the permanent item location and when do we not?

If it is visible in the form, but has no value then we want to preserve the
original value and not set it to location


> My impression was that whenever the location is updated and the value is not
> CART or PROC, the we'd also like to make the permanent location match. It's
> been moved to a new location, so if it was checked out/checked in, set to
> CART, it should be able to go back to the new location.

This was the case originally, however, it became possible to add both to the
editors and set individual values.

> But now it feels a bit like we might have different uses of the field
> depending on configuration maybe? And if we do... should we do that? And if
> so, is this documented somewhere?

It may not be documented, but it has become a fairly common practice. I think
we should document and support it.

> Do we expect people to always set both manually if they are linked to MARC
> fields? What if $k was set to hidden in the item form?

If mapped and hidden, then it operates where a location update always updates
both. If exposed in the form, i.e. we receive a value in the scripts, then we
need to assess if the value is blank and preserve pre-edited value rather than
matching to location

-- 
You are receiving this mail because:
You are watching all bug changes.