[Koha-bugs] [Bug 24975] Refactor database translations

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975

--- Comment #108 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Some findings in random order:

I am missing an Add button on admin/localization. You can clear a record and
remove it; but perhaps adding a Delete button would be nice too.

Not sure why we are using DBIC here instead of Koha objects. No performance
figures are given to justify. Koha::Object should be our standard.

opac/opac-search.pl
     my $description = $itemtypes->{$itemtype}->{iscat}
       ? $itemtypes->{$itemtype}->{description}
-      : db_t('itemtype', Koha::ItemTypes->find($itemtype)->itemtype);
+      : Koha::ItemTypes->find($itemtype)->translated_description;
     $itemtypes->{$itemtype}->{description} = $description ||
$itemtypes->{$itemtype}->{description} || q{};
Weird code.

package Koha::Template::Plugin::ItemTypes;
sub GetDescription {
    return $parent ? $self->t($parent->description) . "->" .
$self->t($itemtype->description) : $self->t($itemtype->description);
Omission for switching to itemtype.

-- 
You are receiving this mail because:
You are watching all bug changes.