[Koha-bugs] [Bug 33575] Add table settings to hold_table on /reserve/request.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

--- Comment #2 from Sally <sally.healey at cheshiresharedservices.gov.uk> ---
This is a brilliant idea, Lucas - adding configuration to the request.pl table
is super helpful, and I'd love to see this patch in Koha.

It works well on testing:

- The dataTable works as expected; I am able to hide columns using the controls
on the page

- The dataTable configuration works as expected; I am able to change settings
(hidden by default, cannot be toggled) in the administration screen and they're
correctly reflected on the dataTable - and these changes are remembered when
the page reloads after submitting a change

- Logging in as a staff member without the modify_holds_priority permission
works as described

The only issue is that there's a couple of columns which I think need to be set
as default as visible / cannot be toggled, the same as the checkbox.  

They are: Priority and Pickup Library

Priority

When you hide Priority and submit any changes, the page redirects to:
/cgi-bin/koha/reserve/request.pl / Place a hold on No title - instead of
reloading the page you were on

Pickup library

When you hide Pickup library and submit any changes, Koha throws an error: 
[You must supply a pickup location when placing a hold] at
/usr/share/perl5/Exception/Class/Base.pm line 88 

If those two changes can be made, I can sign off. :)

-- 
You are receiving this mail because:
You are watching all bug changes.