[Koha-bugs] [Bug 32917] Change patron.firstname and patron.surname in password change sample notice
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sun Apr 23 01:42:31 CEST 2023
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32917
David Nind <david at davidnind.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #149729|0 |1
is obsolete| |
--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 150111
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150111&action=edit
Bug 32917: Fix sample notice for CHANGE_PASSWORD
We've identified 3 issues:
* Name of patron is not showing up in subject line
* Name of patron is now showing in notice text
* Notice is set to be HTML, but has no line breaks and uses no HTML tags
In the database update, these issues don't occur:
$dbh->do( q{
INSERT IGNORE INTO letter (module, code, name, title, content,
message_transport_type) VALUES ('members', 'PASSWORD_CHANGE', 'Notification of
password change', 'Library account password change notification',
"Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nWe want to
notify you that your password has been changed. If you did not change it
yourself (or requested that change), please contact library staff.\r\n\r\nYour
library.", 'email');
});
So this patch will make them match up:
* Remove HTML flag
* Update patron. to borrower. in message text
* Remove patron name from subject (it won't work even with the correct
variables)
To test:
* Add an email address to your favourite sample user
* Make sure NotifyPasswordChange is set to "Notify"
* Update the sample user's password using the "change password" feature
* Verify a notice is shown in the notices tabs
Note: you won't see the line break issue there because of bug 30287
* Apply patch
* Recreate your database/run web installer so sample notices are loaded
* Repeat the test, it should generate a nice lookig notice now
Signed-off-by: David Nind <david at davidnind.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list