[Koha-bugs] [Bug 33612] New: Staff with limited permissions don't always get an expanded catalog_search bar

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612

            Bug ID: 33612
           Summary: Staff with limited permissions don't always get an
                    expanded catalog_search bar
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

To recreate:

1. Setup a staff member with staff access permission but no circulate
permissions. 
2. Log in as that and on the intranet-home page notice that 'Search patron' bar
across the top is not visible by default. 
3. Click the 'Search patrons' link at the top, now you see the search bar.
4. This is also true on the item search page. 

It is because we are using the old home-search.inc when it should be the
cat-search.inc

If you git grep 'home-search.inc' you'll see it on these two pages.

koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt:    [% INCLUDE
'home-search.inc' %]
koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt:        [% INCLUDE
'home-search.inc' %]


We can change that to cat-search.inc and remove the unused home-search.inc, I
think.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.