[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #104 from David Nind <david at davidnind.com> ---
(In reply to Hammat wele from comment #103)
> (In reply to David Nind from comment #101)
> > Unfortunately, the patch no longer applies 8-(..
> 
> I've rebased the patch, this one should apply now.
> Sorry

No problem, and thanks!

I can confirm that this all now works as per the test plan.

However, the tests fail (even though that wasn't included in the test plan) -
they passed before applying the patch.

prove t/db_dependent/Members.t
t/db_dependent/Members.t .. 1/57 
#   Failed test 'notice_email_address returns correct value when
AutoEmailPrimaryAddress is emailpro'
#   at t/db_dependent/Members.t line 163.
#          got: 'Marie at email.com'
#     expected: 'Marie at work.com'
t/db_dependent/Members.t .. 35/57 # Looks like you failed 1 test of 57.
t/db_dependent/Members.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/57 subtests 

Test Summary Report
-------------------
t/db_dependent/Members.t (Wstat: 256 Tests: 57 Failed: 1)
  Failed test:  11
  Non-zero exit status: 1
Files=1, Tests=57,  2 wallclock secs ( 0.02 usr  0.00 sys +  1.84 cusr  0.37
csys =  2.23 CPU)
Result: FAIL

prove t/db_dependent/Letters.t
t/db_dependent/Letters.t .. 48/87 
    #   Failed test 'SendQueuedMessages with limit 1'
    #   at t/db_dependent/Letters.t line 1069.
    # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at
/kohadevbox/koha/C4/Letters.pm line 1325.
    # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at
/kohadevbox/koha/C4/Letters.pm line 1325.
    # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at
/kohadevbox/koha/C4/Letters.pm line 1325.
    # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at
/kohadevbox/koha/C4/Letters.pm line 1325.
    # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at
/kohadevbox/koha/C4/Letters.pm line 1325.
    # expected to find warning: (?^u:Fake send_or_die)

    #   Failed test 'Sent 1 message with limit of 1 and 5 unprocessed messages'
    #   at t/db_dependent/Letters.t line 1071.
    #          got: '0'
    #     expected: '1'

    #   Failed test 'SendQueuedMessages with limit 2'
    #   at t/db_dependent/Letters.t line 1076.
    # didn't find a warning
    # expected to find warning: (?^u:Fake send_or_die)
    # expected to find warning: (?^u:Fake send_or_die)

    #   Failed test 'Sent 2 messages with limit of 2 and 4 unprocessed
messages'
    #   at t/db_dependent/Letters.t line 1078.
    #          got: '0'
    #     expected: '2'

    #   Failed test 'SendQueuedMessages with limit 3'
    #   at t/db_dependent/Letters.t line 1083.
    # didn't find a warning
    # expected to find warning: (?^u:Fake send_or_die)
    # expected to find warning: (?^u:Fake send_or_die)

    #   Failed test 'Sent 2 messages with limit of 3 and 2 unprocessed
messages'
    #   at t/db_dependent/Letters.t line 1085.
    #          got: '0'
    #     expected: '2'

    #   Failed test '5 messages sent'
    #   at t/db_dependent/Letters.t line 1088.
    #          got: '0'
    #     expected: '5'

    #   Failed test 'SendQueuedMessages with limit 2 and domain limits'
    #   at t/db_dependent/Letters.t line 1114.
    # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at
/kohadevbox/koha/C4/Letters.pm line 1325.
    # found warning: FAIL: No 'to_address' and INVALID borrowernumber (107) at
/kohadevbox/koha/C4/Letters.pm line 1325.
    # found warning: Sending messages: domain fake1.domain reached limit of
1/1m at /kohadevbox/koha/Koha/Notice/Util.pm line 97.
    # found warning: Fake send_or_die at t/db_dependent/Letters.t line 43.
    # expected to find warning: (?^u:wrong.net reached limit)
    # expected to find warning: (?^u:Fake send_or_die)
    # expected to find warning: (?^u:fake1.domain reached limit)
    # expected to find warning: (?^u:Fake send_or_die)

    #   Failed test 'Only expecting 2 sent messages'
    #   at t/db_dependent/Letters.t line 1116.
    #          got: '1'
    #     expected: '2'

    #   Failed test 'Still 4 pending'
    #   at t/db_dependent/Letters.t line 1117.
    #          got: '3'
    #     expected: '4'

    #   Failed test 'We saw 6 messages while checking domain limits: so we
deferred 4'
    #   at t/db_dependent/Letters.t line 1118.
    #          got: '4'
    #     expected: '6'
    # Looks like you planned 18 tests but ran 12.
    # Looks like you failed 11 tests of 12 run.

#   Failed test 'Test limit parameter for SendQueuedMessages'
#   at t/db_dependent/Letters.t line 1119.
# Looks like you failed 1 test of 87.
t/db_dependent/Letters.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/87 subtests 

Test Summary Report
-------------------
t/db_dependent/Letters.t (Wstat: 256 Tests: 87 Failed: 1)
  Failed test:  86
  Non-zero exit status: 1
Files=1, Tests=87,  2 wallclock secs ( 0.02 usr  0.01 sys +  1.87 cusr  0.31
csys =  2.21 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.