[Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
Hi Lucas.

I get an error trace after applying the patch and repeating the steps. The
payment is recorded. The start of the error trace:

Exception 'Koha::Exceptions::Account::PaymentTypeRequired' thrown 'Account
transaction requires a payment type'
 at /usr/share/perl5/Exception/Class/Base.pm line 88

    in Exception::Class::Base::throw at
/usr/share/perl5/Exception/Class/Base.pm line 88

       85: 
       86:     $proto->rethrow if ref $proto;
       87: 
       88:     die $proto->new(@_);
       89: }
       90: 
       91: sub rethrow {

    Show function arguments
    in Koha::Account::pay at /kohadevbox/koha/Koha/Account.pm line 105
....

David

Testing notes (using KTD):

1. Editing the page HTML using Firefox:
   - Right click on the payment type label
   - Select 'Inspect'
   - In the web development tools window that opens, select <select
name="payment_type" id="payment_type" class="required" required="required">,
right click, and then select 'Edit HTML'
   - Remove: class="required" required="required"
   - Click on the Submit button in the page

-- 
You are receiving this mail because:
You are watching all bug changes.