[Koha-bugs] [Bug 33478] Customise the format of notices when they are printed

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478

--- Comment #38 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Nick Clemens from comment #24)
> I didn't do a full run through as I hit a few issues.

Thank you for testing! Decided to remove the permission as I agree it's not
really needed and think that addresses half of these issues.

> 
> Must fix:
>  - A patron without permissions cannot save print notices. The current
> settings need to be included as hidden inputs
>  - The permission doesn't prevent url/form manipulation without the
> permission. This must be checked in the code.

Removed permission

>  - There is an empty value in the Units dropdown for 'AGATE'

Fixed in latest patchset

> 
> Should fix:
>  - The DB fields should be enum if they only support a limited range of
> values

Fixed in latest patchset

>  - This reveals  an consistency - ISSUESLIP is presented in print format,
> however, it uses the 'email' template. Possibly the settings can be their
> own section? Otherwise this needs to be addressed

Moved to its own section out of the Print section)

>  - 'Apply format settings to all notices' - I can see the utility here for
> initially settings things up - but this seems a bit too powerful. A warning
> at least would be nice

Added a confirmation box when hitting Save

>  - Even if you cannot edit the settings - it would be useful to view the
> print formatting so you know what you can see

I haven't addresses the print preview because you can see a print preview when
you go to Print the notice - I know it's not ideal. I can come back to this if
I have some time but I don't think it should be a blocker at this point.

>  - The new form is added to all notices - but it really only applies to
> slips if I understand correctly? Does this work with bug 33260 for printing
> notices from the staff interface? It should be clarified if it does not work
> with gather_print_notices etc.

I plan to rebase Bug 33260 on top of this.

> 
> Could fix:
>  - I don't know that a permission is needed here, if you can edit slips I
> would assume you can edit this portion too, but I assume there is a
> motivation

Removed permission

-- 
You are receiving this mail because:
You are watching all bug changes.