[Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
   FAIL   filters
                missing_filter at line 1921 (            guarantor_attributes =
[% To.json(guarantor_attributes) %];)
                missing_filter at line 1924 (            to_api_mapping = [%
To.json(to_api_mapping) %];)
Please fix.

+                error:function(){
+                    $('#saverecord').prop('disabled', false);
Shouldnt we do more than that ?

koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:               
select_user( borrowernumber, JSON.parse(borrower_data) );
koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:        function
select_user(borrowernumber, data) {
koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:                   
p.select_user(borrowernumber, data);
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt:            function
select_user(borrowernumber, borrower) {
It seems that we are overloading this function name already. So no blocker for
this report. Just noting. But might be a chance to rename in members.js? The
name is quite obscure for copying guarantor information.

koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:             
      select_user( '[% g.patron.borrowernumber | html %]', [% To.json(
g.patron.unblessed ) | $raw %], '[% g.relationship | html %]' );
koha-tmpl/intranet-tmpl/prog/js/members.js:function select_user(borrowernumber,
borrower, relationship) {
            [% IF new_guarantors %]
                [% FOREACH g IN new_guarantors %]
                    select_user( '[% g.patron.borrowernumber | html %]', [%
To.json( g.patron.unblessed ) | $raw %], '[% g.relationship | html %]' );
                [% END %]
            [% END %]
Please explain why whe should do an ajax GET in select_user when we pass the
borrower unblessed hash to this function?
This does not look good.

-- 
You are receiving this mail because:
You are watching all bug changes.