[Koha-bugs] [Bug 28166] Optionally add MARC fields to authority search

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Apr 28 19:58:47 CEST 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28166

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Signed Off                  |Failed QA

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
This looks neat, I like the feature, the patches need some cleanup

Must fix:
- the patch adds the function _add_rowdata, I think it's a rebase leftover?
- the call from _handle_one_result should be updated to pass the biblio related
preference to the updated routine
- delete the commented lines from the code

Could fix:
- the routine should take a hashref, the more parameters we have, the nicer it
i s to have them named

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list