From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 01:46:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 31 Jul 2023 23:46:47 +0000 Subject: [Koha-bugs] [Bug 26641] link_bibs_to_authorities.pl: Add the ability to specify the MARC field to operate on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26641 --- Comment #19 from Andreas Roussos --- (In reply to Jonathan Druart from comment #15) > why "g"? Because "t" was already taken (for the -t/--test option). Apologies for necro posting ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 05:37:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 03:37:30 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 --- Comment #9 from David Cook --- (In reply to Katrin Fischer from comment #8) > Something is not working quite right there: > > * loan period 5 days > * no renewal before 5 dates > * today is 2023-07-29 and date in ktd also shows me that > * message shown: no renewal before 2023-07-29 > > ... but I can't renew :( Is your NoRenewalBeforePrecision set to "date" or "exact time"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 05:50:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 03:50:45 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 --- Comment #10 from David Cook --- Test plan: 0. Apply patch 1. koha-plack --reload kohadev 2. Set http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=NoRenewalBeforePrecision to "exact time" 3. Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl 4. Set "No renewal before" to 5 5. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 and checkout 39999000001310 6. Note that you can't renew the item 7. Set http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=NoRenewalBeforePrecision to "date" 8. Note that you can renew the item -- Since the due date is at 23:59 5 days from now, it makes sense that we can't renew until it's 5 days before the due date (which would be tonight at 23:59). Hmm... but I changed NoRenewalBeforePrecision to "exact time" and Due Date to "08/06/2023" and it's saying "No renewal before 08/01/2023 13:45" but the time is "08/01/2023 13:49". This might be a timezone issue with the ktd... ah yes it is because ktd is using UTC and it thinks the time is "08/01/2023 03:49" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 05:52:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 03:52:42 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #11 from David Cook --- (In reply to Katrin Fischer from comment #8) > Something is not working quite right there: > > * loan period 5 days > * no renewal before 5 dates > * today is 2023-07-29 and date in ktd also shows me that > * message shown: no renewal before 2023-07-29 > > ... but I can't renew :( In fact, with "exact time", that's the norm with master even without this patch. Going to move this one back to "Signed Off" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 08:38:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 06:38:27 +0000 Subject: [Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > (In reply to Jonathan Druart from comment #3) > > I still completely disagree with this kind of patch, see my comments on bug > > 13457. > > Have we settled on assuming the sample data is available? use TestBuilder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 08:39:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 06:39:34 +0000 Subject: [Koha-bugs] [Bug 34450] New: systempreferences.pl has unused op 'update_and_reedit' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34450 Bug ID: 34450 Summary: systempreferences.pl has unused op 'update_and_reedit' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org I noticed that admin/systempreferences.pl has an op called "update_and_reedit" but I can't see anywhere that it ever gets used. I think we could get rid of that block of code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 08:40:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 06:40:04 +0000 Subject: [Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Jonathan Druart --- And this is what did this commit commit f9654783e2154bfd95cac92ae9b23615d88538e2 Bug 16912: Koha::Patrons - Move and rewrite tests for AddEnrolmentFeeIfNeeded *** This bug has been marked as a duplicate of bug 16912 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 08:40:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 06:40:04 +0000 Subject: [Koha-bugs] [Bug 16912] Koha::Patrons - Move AddEnrolmentFeeIfNeeded to add_enrolment_fee_if_needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16912 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #29 from Jonathan Druart --- *** Bug 13455 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 08:42:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 06:42:31 +0000 Subject: [Koha-bugs] [Bug 33289] Vue - Add API client class to interact with svc/config/systempreferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33289 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34369 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 08:45:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 06:45:39 +0000 Subject: [Koha-bugs] [Bug 34155] OPAC item level holds "force" option broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #6) > Unless someone wants to do a quick bugfix here? We left this unfixed for a > month now, that's not good for this type of bug. Backporting bad bugfixes is worst. Code in the controller must be cleaned before push in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 08:50:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 06:50:13 +0000 Subject: [Koha-bugs] [Bug 34448] ERM should be able to display error messages coming from the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34448 --- Comment #4 from Jonathan Druart --- I would keep the console.log with the whole 'response' object. Looking at js/datatables.js, https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha-tmpl/intranet-tmpl/prog/js/datatables.js#L493 And wondering if we should not split on several lines instead of separating with a space. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 08:57:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 06:57:47 +0000 Subject: [Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #9 from Jonathan Druart --- Nick, I would remove the changes in ModBiblio, and keep the explicit update in the controller. Also I think we should have a selenium test. We already have 'Bibliographic record detail page must not explode even with invalid metadata' in regressions.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 10:16:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 08:16:16 +0000 Subject: [Koha-bugs] [Bug 34155] OPAC item level holds "force" option broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 --- Comment #8 from Katrin Fischer --- (In reply to Jonathan Druart from comment #7) > (In reply to Katrin Fischer from comment #6) > > Unless someone wants to do a quick bugfix here? We left this unfixed for a > > month now, that's not good for this type of bug. > > Backporting bad bugfixes is worst. Code in the controller must be cleaned > before push in my opinion. So we just keep it broken, because noone is going to write that fix apparently? This was filed a month ago, is a user facing issue in stable releases. The patch is really small, it will be quite easy to do a proper fix on top. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 10:36:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 08:36:11 +0000 Subject: [Koha-bugs] [Bug 34448] ERM should be able to display error messages coming from the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34448 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154099|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim --- Created attachment 154123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154123&action=edit Bug 34448: Update cypress tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 10:36:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 08:36:40 +0000 Subject: [Koha-bugs] [Bug 34448] ERM should be able to display error messages coming from the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34448 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154097|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim --- Created attachment 154124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154124&action=edit Bug 34448: Update the way we handle response in http-client.js Test plan: Before patch: - Visit a non-existent ID i.e. /cgi-bin/koha/erm/agreements/999 - Visit a char ID i.e. /cgi-bin/koha/erm/agreements/abc Apply patch: Repeat above steps. Run cypress tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 10:41:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 08:41:27 +0000 Subject: [Koha-bugs] [Bug 34448] ERM should be able to display error messages coming from the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34448 --- Comment #7 from Pedro Amorim --- (In reply to Jonathan Druart from comment #4) > I would keep the console.log with the whole 'response' object. > > Looking at js/datatables.js, > > https://git.koha-community.org/Koha-community/Koha/src/branch/master/koha- > tmpl/intranet-tmpl/prog/js/datatables.js#L493 > > And wondering if we should not split on several lines instead of separating > with a space. Thank you very much Jonathan, I've squashed that into the patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 12:15:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 10:15:03 +0000 Subject: [Koha-bugs] [Bug 34004] Typo: new items > news items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34004 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Emmanuel Bétemps contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/707 CC| |e.betemps at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 12:15:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 10:15:30 +0000 Subject: [Koha-bugs] [Bug 34004] Typo: new items > news items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34004 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #1 from Emmanuel Bétemps --- Added to master manual -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:48:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 11:48:53 +0000 Subject: [Koha-bugs] [Bug 17433] Koha::Validator. Validation for the masses! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17433 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:49:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 11:49:26 +0000 Subject: [Koha-bugs] [Bug 34430] Add Koha::Validator module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Polish Koha::Validator |Add Koha::Validator module |module | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:49:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 11:49:33 +0000 Subject: [Koha-bugs] [Bug 34430] Add Koha::Validator module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17433 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:49:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 11:49:33 +0000 Subject: [Koha-bugs] [Bug 17433] Koha::Validator. Validation for the masses! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17433 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34430 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:50:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 11:50:09 +0000 Subject: [Koha-bugs] [Bug 34430] Add Koha::Validator module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 --- Comment #1 from Marcel de Rooy --- Copying code from 34367 here. Got obsoleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:50:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 11:50:45 +0000 Subject: [Koha-bugs] [Bug 34430] Add Koha::Validator module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34367 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:50:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 11:50:56 +0000 Subject: [Koha-bugs] [Bug 34430] Add Koha::Validator module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34367 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:51:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 11:51:37 +0000 Subject: [Koha-bugs] [Bug 17433] Koha::Validator. Validation for the masses! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17433 --- Comment #10 from Marcel de Rooy --- A similar idea on bug 34430 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:53:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 11:53:52 +0000 Subject: [Koha-bugs] [Bug 34430] Add Koha::Validator module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34349 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:54:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 11:54:07 +0000 Subject: [Koha-bugs] [Bug 34430] Add Koha::Validator module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:54:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 11:54:27 +0000 Subject: [Koha-bugs] [Bug 34430] Add Koha::Validator module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 --- Comment #2 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #1) > Copying code from 34367 here. Got obsoleted. No, bug 34349 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:55:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 11:55:39 +0000 Subject: [Koha-bugs] [Bug 34430] Add Koha::Validator module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 --- Comment #3 from Marcel de Rooy --- Created attachment 154125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154125&action=edit Bug 34430: Module for validating input Test plan: Run t/Koha/Validator.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 13:56:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 11:56:18 +0000 Subject: [Koha-bugs] [Bug 34430] Add Koha::Validator module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34430 --- Comment #4 from Marcel de Rooy --- Not (yet) actively working on this, but if you are interested, add yourself to cc or comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:01:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 14:01:25 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com, | |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:26:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 14:26:18 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:26:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 14:26:20 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154106|0 |1 is obsolete| | --- Comment #8 from Sam Lau --- Created attachment 154126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154126&action=edit Bug 34024: Block changing pickup location for found holds This patch adds a check on holds for 'found' statuses. Holds with the following statuses have special workflows in Koha, and overwritting their pickup locations yields uncertain scenarios: * Waiting: the item has probably been put on a special shelve * In transit: the item is travelling to a new destination, and changing the pickup location should include some validations, and probably generate some notifications. At least. * In processing: the item has already been taken out of the shelve for some internal processing. Changing the pickup location could interfere with this workflow. Overriding this limitation could be introduced with care on a separate report. To test: 1. Apply the unit tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests don't pass. Holds go through (200) instead of being rejected (409). 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:27:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 14:27:31 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154105|0 |1 is obsolete| | --- Comment #9 from Sam Lau --- Created attachment 154127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154127&action=edit Bug 34024: Unit tests Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:35:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 14:35:45 +0000 Subject: [Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:35:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 14:35:47 +0000 Subject: [Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153996|0 |1 is obsolete| | --- Comment #2 from Sam Lau --- Created attachment 154128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154128&action=edit Bug 34436: Some breadcrumbs lack for translatability This patch modifies several templates which were updated recently so that breadcrumbs markup could be built using template wrappers. The patch wraps strings in in cases where it is necessary to make them translatable. To test, apply the patch and view the following pages to confirm that the breadcrumbs still show up correctly: - Administration -> MARC bibliographic framework - Add framework - Edit framework - Delete framework - Administration -> Share content with Mana KB - Administration -> Circulation and fine rules - Authorities -> - Add authority - Edit authority - Catalog -> Advanced search - Bibliographic detail page - Must have EasyAnalyticalRecords enabled. - Edit -> Link to host record - Patrons - Reports -> Average loan time - Serials -> Serials home Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:42:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 14:42:40 +0000 Subject: [Koha-bugs] [Bug 34402] Sorting holds on patron account includes articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 16:42:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 14:42:42 +0000 Subject: [Koha-bugs] [Bug 34402] Sorting holds on patron account includes articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153923|0 |1 is obsolete| | --- Comment #2 from Sam Lau --- Created attachment 154129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154129&action=edit Bug 34402: Sorting holds on patron account includes articles This patch adds some configuration to the table of holds shown on the checkout and patron detail pages so that sorting by title correctly excludes articles. To test, apply the patch and clear your browser cache. - Check out to a patron who has multiple holds on titles which include leading articles like "a" "an" and "the." - Click the holds tab and click the "title" column to sort by title. - The titles should be correctly sorted alphabetically while ignoring articles. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 18:17:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 16:17:46 +0000 Subject: [Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #10 from Nick Clemens --- (In reply to Jonathan Druart from comment #9) > Nick, I would remove the changes in ModBiblio, and keep the explicit update > in the controller. > > Also I think we should have a selenium test. We already have 'Bibliographic > record detail page must not explode even with invalid metadata' in > regressions.t. The ModBiblio changes are needed to prevent an explosion in logging - without them we die on recording the modification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:46:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 17:46:30 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 --- Comment #10 from Emily Lamancusa --- Is changing the pickup location on a hold that's in transit truly an unhandled situation? Looking at bug 30500 and bug 14783, if the syspref is set to allow it, opac-modrequest.pl calls $hold->set_pickup_location without extra handling, because AddReturn already has logic to handle a situation where a transfer completes and a new transfer needs to be initiated based on hold pickup location. It's true the functionality to directly change the pickup location on an in-transit hold wasn't added to the staff interface when it was added to the OPAC, but is there a practical reason it shouldn't be permitted, or more just that there hasn't been a need to add it yet (in part because staff have the capability to revert the transit status on a hold in order to make those types of changes, while the OPAC and API do not)? I'm not sure I fully understand the implications of a privileged API endpoint being able to change the pickup location on an in-transit hold, versus allowing the OPAC to do it, versus allowing a person in the staff interface to revert the transit status, change the pickup location, and then put the hold back in transit. (though actually I'd say the existing behavior allowing a staff member to mess with transit data as a workaround is riskier than adding the ability for them to change the pickup location directly, but that's beyond the scope of this bug) If there's a true risk to allowing the API to change the pickup location on an in-transit hold without an override, then it makes sense to be cautious. But if that's the case, please open a follow-up bug to add such an override route and restore the functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 19:52:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 17:52:10 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Felicity Brown changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicity.brown at montgomeryco | |untymd.gov --- Comment #11 from Felicity Brown --- I second "allowing a staff member to mess with transit data as a workaround is riskier." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 20:06:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 18:06:04 +0000 Subject: [Koha-bugs] [Bug 30247] Add a receive shipment link to unreceived orders in acq advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30247 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 20:09:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 18:09:43 +0000 Subject: [Koha-bugs] [Bug 28771] Received orders in Acq can be cancelled from an open basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28771 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6819 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 20:09:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 18:09:43 +0000 Subject: [Koha-bugs] [Bug 6819] Don't offer cancel order links for received order lines on basket summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6819 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28771 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 20:17:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 18:17:09 +0000 Subject: [Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #11 from Jonathan Druart --- (In reply to Nick Clemens from comment #10) > (In reply to Jonathan Druart from comment #9) > > Nick, I would remove the changes in ModBiblio, and keep the explicit update > > in the controller. > > > > Also I think we should have a selenium test. We already have 'Bibliographic > > record detail page must not explode even with invalid metadata' in > > regressions.t. > > The ModBiblio changes are needed to prevent an explosion in logging - > without them we die on recording the modification Got it, agreed. Thanks for your quick answer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 20:17:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 18:17:40 +0000 Subject: [Koha-bugs] [Bug 34036] Single receive doesn't reload data and order lines appears as pending In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 20:55:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 18:55:53 +0000 Subject: [Koha-bugs] [Bug 34452] New: Button Update adjustments is hidden Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Bug ID: 34452 Summary: Button Update adjustments is hidden Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: michaela.sieber at kit.edu QA Contact: testopia at bugs.koha-community.org To recreate: 1. Go to acquisition modul 2. search for Vendor 3. Button receive shipment and create invoive 4. click finish receiving (we don't need an order line for this test) 5. Click +Add an adjustment 6. Enter an amount and save via Button 'Update adjustments' 7. Now change the amount 8. recognize that there is not button to save or update the changed amount The Button 'Update adjustments' is hidden, you first have to click on 'Add an adjustment' That is not intuitive and changed with Version 22.11 and the new UI. Check in older Koha Versions (e.g. 21.11) that the Button 'Update adjustments' was always visible underneath the Link to 'Add an adjustment'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 21:00:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 19:00:18 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 --- Comment #12 from Tomás Cohen Arazi --- (In reply to Emily Lamancusa from comment #10) > Is changing the pickup location on a hold that's in transit truly an > unhandled situation? The code for handling it in the OPAC is defined in: sub can_update_pickup_location_opac { my ($self) = @_; my @statuses = split /,/, C4::Context->preference("OPACAllowUserToChangeBranch"); foreach my $status ( @statuses ){ return 1 if ($status eq 'pending' && !$self->is_found && !$self->is_suspended ); return 1 if ($status eq 'intransit' && $self->is_in_transit); return 1 if ($status eq 'suspended' && $self->is_suspended); } return 0; } I assume it should be safe to allow in_transit. I just don't know the area (staff UI-wise) enough to feel confident about enabling. Some thought on the initial report was needed though, as I found the in processing use case while digging. I'm open to change it to allow changing the pickup location for in transit holds. I just thougth it deserved it's own bug report in which people involved in the area could weight in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 21:16:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 19:16:40 +0000 Subject: [Koha-bugs] [Bug 34452] Button Update adjustments is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 --- Comment #1 from Michaela Sieber --- Created attachment 154130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154130&action=edit acqui/invoice.pl Hidden Button Update Adjustments Screenshot old vs. new UI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 21:20:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 19:20:44 +0000 Subject: [Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 --- Comment #1 from Andreas Roussos --- (In reply to Martin Renvoize from comment #0) > The routine iterates through all fields in a biblio and compares them to a > list of acceptable tags that may link to an authority. It may be more > efficient to do the opposite iteration, working through acceptable authority > tags and looking for the existence of that field in the biblio. (Note.. I've > not tested this hypothesis.. it depends heavily on how efficient it is to > fetch a single MARC tag using Marc::Record) Hi Martin, TL;DR: In UNIMARC instances, link_bibs_to_authorities.pl run time can be reduced by 80% and the number of DBI calls can be reduced by 90% with a very simple fix that optimises the C4::Biblio::LinkBibHeadingsToAuthorities routine ;-) I had a go at optimising this routine recently, as I'm in the process of writing a Perl script that will perform some housekeeping tasks in our bibliographic records. [The script is meant to search for "TOPICAL SUBJECT" authority headings (UNIMARC field 250) using the text found in our existing "UNCONTROLLED SUBJECT TERMS" (biblio subfield 610$a) and, when a match is found, add a new "TOPICAL NAME USED AS SUBJECT" tag (field 606) to the bibliographic record, copy the authority record contents over, link it via subfield $9, then finally remove the (unwanted) uncontrolled subject term.] In developing this script, I investigated the inner workings of the routine in question, and I'm pleased to report that I've identified where the inefficiency in LinkBibHeadingsToAuthorities() actually lies. The patch for fixing this is trivial and backportable, too! ;-) > The routine iterates through all fields in a biblio and compares them to a > list of acceptable tags that may link to an authority. Indeed, that's exactly what happens in LinkBibHeadingsToAuthorities() with the crucial bit being line 641: 637 foreach my $field ( $bib->fields() ) { 638 if ( defined $tagtolink ) { 639 next unless $field->tag() == $tagtolink ; 640 } 641 my $heading = C4::Heading->new_from_field( $field, $frameworkcode ); 642 next unless defined $heading; [...] Then, in C4::Heading->new_from_field(): 61 sub new_from_field { 62 my $class = shift; 63 my $field = shift; 64 my $frameworkcode = shift; #FIXME this is not used? 65 my $auth = shift; 66 my $marcflavour = C4::Context->preference('marcflavour'); 67 my $marc_handler = _marc_format_handler($marcflavour); [...] 277 sub _marc_format_handler { 278 my $marcflavour = uc shift; 279 my $pname = "C4::Heading::$marcflavour"; 280 load $pname; 281 return $pname->new(); 282 } This is where things get interesting as the behaviour diverges a bit depending on the MARC flavour being used: in C4/Heading/MARC21.pm the object is constructed with: 255 sub new { 256 my $class = shift; 257 return bless {}, $class; 258 } ... and the $bib_heading_fields data structure/hash is statically set at the top of the module: 49 my $bib_heading_fields = { 50 '100' => { 51 auth_type => 'PERSO_NAME', 52 subfields => 'abcdfghjklmnopqrst', 53 main_entry => 1 54 }, 55 '110' => { 56 auth_type => 'CORPO_NAME', 57 subfields => 'abcdfghklmnoprst', 58 main_entry => 1 59 }, [...] Whilst in C4/Heading/UNIMARC.pm the object is constructed with: 68 sub new { 69 my $class = shift; 70 71 my $dbh = C4::Context->dbh; 72 my $sth = $dbh->prepare( 73 "SELECT tagfield, authtypecode 74 FROM marc_subfield_structure 75 WHERE frameworkcode = '' AND authtypecode <> ''" 76 ); 77 $sth->execute(); 78 $bib_heading_fields = {}; 79 while ( my ( $tag, $auth_type ) = $sth->fetchrow ) { 80 $bib_heading_fields->{$tag} = { 81 auth_type => $auth_type, 82 subfields => 'abcdefghjklmnopqrstvxyz', 83 }; 84 } 85 86 return bless {}, $class; 87 } ... thus resetting the $bib_heading_fields hash *in each invocation*, then populating it again with the results fetched from the database! Does this information really need to be re-calculated for each field of the record being saved/updated/linked? I think not, as: 1) Changes to the marc_subfield_structure table are not that frequent, and are unlikely to occur in the relatively short timeframe that a save/update/linking takes to complete. 2) As per the official Koha manual, you're not really meant to edit the Default framework as this will cause problems, but rather clone it to a different one which you'll use to catalogue your records. [C4::Heading->new_from_field() can actually be fed with a $frameworkcode parameter, but it doesn't currently use it. I'll leave that for a different bug report, though ;-)] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 21:23:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 19:23:37 +0000 Subject: [Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |misc/link_bibs_to_authoriti | |es.pl --- Comment #2 from Andreas Roussos --- bulkmarcimport.pl seems to be the only script that is affected the most by this, as it can potentially make an excessive number of calls to LinkBibHeadingsToAuthorities(). Also, if the AutoLinkBiblios system preference is set to 'Do', then AddBiblio() and ModBiblio() both call BiblioAutoLink() which in turn calls LinkBibHeadingsToAuthorities() to do the heavy-lifting. So, I believe my patch might bring an improvement in the overall responsiveness of the Staff interface when saving new bibliographic records or modifying existing ones, especially for records with many many fields. However, the big win here is the significantly lower execution times for any helper scripts that call these functions. These benefits apply to UNIMARC only ;-) To put the above claim to the test, I profiled the DBI calls made while using link_bibs_to_authorities.pl and also timed how long it took to run the script. The exact command line used is shown below. My database had 8,241 authority and 23,142 biblio records. +---------------+------------+------------+ DBI calls made | without patch | with patch | difference | +---------------+------------+------------+ | 14,732,858 | 626,090 | -95.75% | +---------------+------------+------------+ +---------------+------------+------------+ execution time | without patch | with patch | difference | +---------------+------------+------------+ | 1,125 sec | 186 sec | -83.47% | +---------------+------------+------------+ Command line used: $ DBI_PROFILE=1 ./misc/link_bibs_to_authorities.pl -t I include the "raw" profiling data from my test runs below: Bib authority heading linking report ======================================================= Linker module: C4::Linker::Default Run started at: 08/01/23 20:10:39 Run ended at: 08/01/23 20:29:24 Total run time: 1124977 ms Number of bibs checked: 23142 Number of bibs modified: 0 Number of bibs with errors: 0 Number of headings linked: 32316 Number of headings unlinked: 15793 Number of headings fuzzily linked: 0 **** Ran in test mode only **** DBI::Profile: 880.455353s 78.05% (14732858 calls) link_bibs_to_authorities.pl @ 2023-08-01 20:29:24 Bib authority heading linking report ======================================================= Linker module: C4::Linker::Default Run started at: 08/01/23 20:40:06 Run ended at: 08/01/23 20:43:12 Total run time: 185965 ms Number of bibs checked: 23142 Number of bibs modified: 0 Number of bibs with errors: 0 Number of headings linked: 32316 Number of headings unlinked: 15793 Number of headings fuzzily linked: 0 **** Ran in test mode only **** DBI::Profile: 29.444538s 15.58% (626090 calls) link_bibs_to_authorities.pl @ 2023-08-01 20:43:12 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 21:24:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 19:24:10 +0000 Subject: [Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |a.roussos at dataly.gr |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 21:25:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 19:25:09 +0000 Subject: [Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 21:25:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 19:25:11 +0000 Subject: [Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 --- Comment #3 from Andreas Roussos --- Created attachment 154131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154131&action=edit Bug 21828: build $bib_heading_fields only once per invocation In UNIMARC instances, the run time of link_bibs_to_authorities.pl can be reduced by up to 80% and the number of DBI calls can be reduced by up to 90% with a very simple fix that optimises the constructor of the C4::Heading::UNIMARC object. Currently, the constructor resets the $bib_heading_fields hash *in each invocation* (i.e. for every field the bibliographic record contains), then populating it again with the results fetched from the database! This is inefficient. The patch/fix is trivial: we take advantage of the fact that $bib_heading_fields is declared at the top of the C4::Heading::UNIMARC module and is thus a package variable that is in scope for the entire execution of the program (more info here: https://stackoverflow.com/q/75317862). Placing the section that generates the $bib_heading_fields hash inside a "unless ( defined $bib_heading_fields )" code block is enough to cause a significant reduction in the number of "expensive" SQL SELECT queries that must be run. Test plan: 0) Have a UNIMARC instance with some sample data (the KTD one will do just fine for this experiment). 1) Run the following commands: $ ktd --shell k$ DBI_PROFILE=1 ./misc/link_bibs_to_authorities.pl -t Observe the output from the script and the DBI profiling info. [You may want to play with different DBI_PROFILE levels (such as 2, 4, 6, 8, etc.) to see what's going on under the hood DBI-wise, for reference see: https://metacpan.org/pod/DBI::Profile] 2) Apply this patch. 3) Rerun the script from step 1), it should run a lot faster! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 21:31:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 19:31:51 +0000 Subject: [Koha-bugs] [Bug 28771] Received orders in Acq can be cancelled from an open basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28771 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Michaela Sieber --- I think it was fixed in version 20.11.00 see bug 6819 *** This bug has been marked as a duplicate of bug 6819 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 21:31:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 19:31:51 +0000 Subject: [Koha-bugs] [Bug 6819] Don't offer cancel order links for received order lines on basket summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6819 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #16 from Michaela Sieber --- *** Bug 28771 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 21:43:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 19:43:11 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 154132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154132&action=edit Bug 34024: (QA follow-up) Allow pickup location changing for in transit holds Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 21:59:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 19:59:28 +0000 Subject: [Koha-bugs] [Bug 28691] Quick spine label should split the same way the label creator does / use splitting rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28691 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose --- We've just had someone on IRC ask about this. https://irc.koha-community.org/koha/2023-08-01#i_2501434 They had a label printer and wanted to use the quick spine label creator to print the spine labels with a specific splitting rule. Test plan : 1. Create a splitting rule that splits on periods and spaces 1.1. Go to Administration > Classification configuration 1.2. Click 'New splitting rule' 1.3. Fill out the form - Splitting rule code: TEST - Description: Split on period and spaces - Splitting routine: RegEx - Regular expression: s/\s/\n/g (click 'New' to add a second regex) s/\./\n\./g 1.4. Optionally, test the regex by entering a call number, e.g. 822.33 H521 It should be split as follows 822 .33 H521 1.5. Click 'Save' 2. Add this splitting rule to the Other/Generic Classification Scheme 2.1. In Classification sources, click 'Edit' next to Other/Generic Classification Scheme 2.2. Edit as follows - Source in use: Check - Splitting rule: Split on period and spaces (TEST) 2.3. Click 'Save' 3. Create or edit an item to add a call number 3.1. Find or create a record 3.2. Edit or create an item 3.3. Edit/Create the item as follows - 2 - Source of classification or shelving scheme: Other/Generic Classification Scheme - o - Full call number: 822.33 H521 - p - Barcode: enter a barcode, note this down, you'll need it later - y - Koha item type: fill this out if it's not already 3.4. Click 'Add item' or 'Save changes' 4. Print a quick label 4.1. Go to Cataloging > Quick spine label creator 4.2. Enter the barcode of the item and press Enter --> The call number is not split according to the rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:28:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 20:28:00 +0000 Subject: [Koha-bugs] [Bug 34453] New: Update background of quick spine label pop-up Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34453 Bug ID: 34453 Summary: Update background of quick spine label pop-up Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org When printing a quick spine label, the background of the pop-up window is still in the old style. To recreate: 0. Make sure to have an item with a call number and a barcode 1. Go to Cataloging > Quick spine label creator 2. Enter the barcode of the item and press Enter --> The background of the pop-up is blue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:37:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 20:37:30 +0000 Subject: [Koha-bugs] [Bug 28691] Quick spine label should split the same way the label creator does / use splitting rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28691 --- Comment #5 from Katrin Fischer --- The regex rules don't work, but there is a lot of mark-up useful for splitting with jQuery and CSS if you have a look at how it presents in HTML. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:44:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 20:44:36 +0000 Subject: [Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:44:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 20:44:38 +0000 Subject: [Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154128|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 154133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154133&action=edit Bug 34436: Some breadcrumbs lack for translatability This patch modifies several templates which were updated recently so that breadcrumbs markup could be built using template wrappers. The patch wraps strings in in cases where it is necessary to make them translatable. To test, apply the patch and view the following pages to confirm that the breadcrumbs still show up correctly: - Administration -> MARC bibliographic framework - Add framework - Edit framework - Delete framework - Administration -> Share content with Mana KB - Administration -> Circulation and fine rules - Authorities -> - Add authority - Edit authority - Catalog -> Advanced search - Bibliographic detail page - Must have EasyAnalyticalRecords enabled. - Edit -> Link to host record - Patrons - Reports -> Average loan time - Serials -> Serials home Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:44:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 20:44:41 +0000 Subject: [Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 --- Comment #4 from Katrin Fischer --- Created attachment 154134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154134&action=edit Bug 34436: (QA follow-up) Move spans to surround full text Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:45:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 20:45:13 +0000 Subject: [Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 --- Comment #5 from Katrin Fischer --- - Delete framework for [% framework.frameworktext | html %] ([% framework.frameworkcode | html %])? + Delete framework for [% framework.frameworktext | html %] ([% framework.frameworkcode | html %])? The span should be after the ? because you might have a different sentence structure for a question. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:45:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 20:45:24 +0000 Subject: [Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:47:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 20:47:54 +0000 Subject: [Koha-bugs] [Bug 34402] Sorting holds on patron account includes articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:47:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 20:47:57 +0000 Subject: [Koha-bugs] [Bug 34402] Sorting holds on patron account includes articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154129|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 154135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154135&action=edit Bug 34402: Sorting holds on patron account includes articles This patch adds some configuration to the table of holds shown on the checkout and patron detail pages so that sorting by title correctly excludes articles. To test, apply the patch and clear your browser cache. - Check out to a patron who has multiple holds on titles which include leading articles like "a" "an" and "the." - Click the holds tab and click the "title" column to sort by title. - The titles should be correctly sorted alphabetically while ignoring articles. Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:48:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 20:48:14 +0000 Subject: [Koha-bugs] [Bug 34402] Sorting holds on patron account includes articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 22:51:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 20:51:41 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 --- Comment #12 from Katrin Fischer --- (In reply to David Cook from comment #11) > (In reply to Katrin Fischer from comment #8) > > Something is not working quite right there: > > > > * loan period 5 days > > * no renewal before 5 dates > > * today is 2023-07-29 and date in ktd also shows me that > > * message shown: no renewal before 2023-07-29 > > > > ... but I can't renew :( > > In fact, with "exact time", that's the norm with master even without this > patch. > > Going to move this one back to "Signed Off" You were right, I was actually not aware of that system preference! It's still ab it wrong isn't it? Since we don't show the time, the user only gets this: No renewal before 01.08.2023 (which makes no sense, when that day is today. Maybe we should show the time or rephrase for 23:59:00 to "after". But not part of this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 23:00:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 21:00:40 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 23:00:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 21:00:42 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153738|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer --- Created attachment 154136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154136&action=edit Bug 30362: Fix GetSoonestRenewDate to really return soonest renew date This change fixes GetSoonestRenewDate so that it returns the soonest renew date as calculated using "No Renewal Before" and "NoRenewalBeforePrecision". In the past, it would only return the soonest renew date if "$now" was lesser than it, which would typically only happen when using an "exact" precision rather than a "date" precision. Test plan: 0. Apply the patch 1. prove t/db_dependent/Circulation.t Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 23:12:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 21:12:49 +0000 Subject: [Koha-bugs] [Bug 30036] Add XSLT for authority results view in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30036 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11083 CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 23:12:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 21:12:49 +0000 Subject: [Koha-bugs] [Bug 11083] Authority search result display in staff interface should be XSLT driven In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30036 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 23:45:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 21:45:17 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153736|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 154137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154137&action=edit Bug 30362: Unit test Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 23:45:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 21:45:19 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153737|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 154138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154138&action=edit Bug 30362: Fix unit test Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 1 23:45:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 21:45:22 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154136|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 154139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154139&action=edit Bug 30362: Fix GetSoonestRenewDate to really return soonest renew date This change fixes GetSoonestRenewDate so that it returns the soonest renew date as calculated using "No Renewal Before" and "NoRenewalBeforePrecision". In the past, it would only return the soonest renew date if "$now" was lesser than it, which would typically only happen when using an "exact" precision rather than a "date" precision. Test plan: 0. Apply the patch 1. prove t/db_dependent/Circulation.t Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 00:19:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 22:19:15 +0000 Subject: [Koha-bugs] [Bug 34454] New: Error:Can't call method "raw" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34454 Bug ID: 34454 Summary: Error:Can't call method "raw" Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: bibliotecas at biteca.com QA Contact: testopia at bugs.koha-community.org Hi, I have an installation in Koha 22.05.09, we just updated to 22.05.14 We have 800,000 bibliographic records Sometimes in the search the system throws the following error: Error:Can't call method "raw" on an undefined value at /usr/share/koha/lib/C4/Search.pm line 774. We have reindexed several times, and the server has 16 GB of RAM and 16 processor cores. In the database, the server is somewhat more modest, but both work well. What could be happening? Andrés -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:15:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:15:11 +0000 Subject: [Koha-bugs] [Bug 29664] Do not show voided payments in cash register statistics wizard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Andrii Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com --- Comment #20 from Andrii Nugged --- Follow-up bug note: $whereTType .= q{ AND status != 'VOID' }; This makes MariaDB act unexpectedly: statuses with NULL are also skipped! When I added this to our piloting production: $whereTType .= q{ AND (status IS NULL OR status != 'VOID') }; it started to show those accountlines which has NULLs. Reasoning: https://mariadb.com/kb/en/null-values/ SELECT NULL != 'VOID', 'VOID' != 'VOID', 'TOTAL' != 'VOID'; +----------------+------------------+-------------------+ | NULL != 'VOID' | 'VOID' != 'VOID' | 'TOTAL' != 'VOID' | +----------------+------------------+-------------------+ | NULL | 0 | 1 | +----------------+------------------+-------------------+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:20:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:20:53 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128858|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:20:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:20:58 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128859|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:21:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:21:18 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 --- Comment #5 from Alex Buckley --- Created attachment 154140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154140&action=edit Bug 29750: Reserves.pm should check if a patron is eligible to reserve and item before confirming the reserve Test plan: 1. Create two patrons, with the following patron categories: - Patron A -> Patron - Patron B -> Student 2. Create two items attached to a single biblio record: - Book - Continuing resource 3. Create the following circ rules: Patron category, item type, Holds allowed (total), Holds allowed (daily), Holds per record (count) - Patron, Book, 0, 0, 0 - Student, Book, 1, 1, 1 - All, Continuing resources, 1, 1, 1 4. Place a title level hold on the biblio for patron A 5. Place a title level hold on the biblio for patron B 6. Checkin the Book and notice you are prompted to confirm the hold by Patron A - even though according to circ rules they cannot reserve Books 7. Apply patch and restart services 9. Checkin the Book, and notice you're prompted to confirm the hold by Patron B Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:21:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:21:34 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 --- Comment #6 from Alex Buckley --- Created attachment 154141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154141&action=edit Bug 29750: Unit test fixes for Reserves.pm Test plan: 1. sudo koha-shell 2. prove t/db_dependent/Holds.t prove t/db_dependent/Reserves.t Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:24:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:24:20 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23172 | Status|ASSIGNED |Needs Signoff Change sponsored?|--- |Sponsored --- Comment #7 from Alex Buckley --- (In reply to Katrin Fischer from comment #4) > Hi Alex, should this have a different status? Hi Katrin, My apologies for the late reply. Yes you're right this should be 'Needs signoff' As this is an old bug report I've just checked upstream and this bug can still be replicated. I've tidied up the patches a bit, they apply cleanly, and they actually don't depend on bug 23172 so I've removed that dependency. Ready for testing. Kind regards Alex Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:24:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:24:20 +0000 Subject: [Koha-bugs] [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29750 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:37:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:37:06 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150560|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:37:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:37:16 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150559|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:37:23 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150558|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:37:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:37:30 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150557|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:37:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:37:49 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #16 from Alex Buckley --- Created attachment 154142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154142&action=edit Bug 33259: Add SameSiteSessionCookie system preference Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:38:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:38:06 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #17 from Alex Buckley --- Created attachment 154143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154143&action=edit Bug 33259: Optionally set SameSite attribute of session cookie to Strict Note: The below test plan is assuming you are running the Mozilla Firefox browser. Test plan: 1. Apply patches 2. Upgrade database sudo koha-upgrade-schema 3. Confirm the new system preference 'SameSiteSessionCookie' is 'Lax' 4. Go to a staff client and OPAC page, right click, choose 'Inspect', go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 5. Confirm 'SameSite' = 'Lax' 6. Change the 'SameSiteSessionCookie' to 'Strict' 7. Open a new private browser window. Go to a staff client and OPAC page, right click, choose 'Inspect, go to the 'Storage' tab, click on 'Cookies', click on 'CGISESSID' 8. Repeat step 4 and confirm 'SameSite' = 'Strict' 9. Go to: Cataloguing > New record 10. Right click, click 'Inspect', go to the 'Console' tab, confirm there are no JavaScript errors 11. Change 'SameSiteSessionCookie' to 'None' 12. Open a new private browser window, repeat step 4, and confirm the 'SameSite' = 'None' 13. Go to: Cataloguing > New record 14. Right click, click 'Inspect', go to the 'Console' tab, confirm there are no JavaScript errors. Sponsored-by: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:38:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:38:22 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #18 from Alex Buckley --- Created attachment 154144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154144&action=edit Bug 33259: (follow-up) Use different speechmarks to prevent errors To test: Confirm the checkouts table for a patron loads successfully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:38:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:38:33 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #19 from Alex Buckley --- Created attachment 154145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154145&action=edit Bug 33259: (follow-up) Add HTML filters to Cookies.set Test plan: Run QA test tools and confirm the no complaints about filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:38:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:38:56 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #20 from Alex Buckley --- Rebased against master, applies cleanly now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:39:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:39:55 +0000 Subject: [Koha-bugs] [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 01:40:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Aug 2023 23:40:05 +0000 Subject: [Koha-bugs] [Bug 23172] Holds queue should check patron category hold policies when mapping items to pending reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23172 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128857|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 02:59:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 00:59:26 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #21 from David Cook --- It might be worth adding that "None" has security implications and is not recommended? Overall, I think only "Lax" and "Strict" makes sense for Koha with "Strict" being preferable overall, although it would need some testing, especially with identity providers... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 03:02:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 01:02:21 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 --- Comment #17 from David Cook --- (In reply to Katrin Fischer from comment #12) > It's still a bit wrong isn't it? Since we don't show the time, the user only > gets this: No renewal before 01.08.2023 (which makes no sense, when that day > is today. Maybe we should show the time or rephrase for 23:59:00 to "after". It is worth double-checking. When I set the due date to "08/06/2023 13:45" it said no renewal before "08/01/2023 13:45". But I think it just said no renewal before "08/01/2023" when I didn't specify a time which I think defaults to 23:59? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 03:32:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 01:32:08 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 03:32:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 01:32:10 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147090|0 |1 is obsolete| | --- Comment #24 from Andreas Roussos --- Created attachment 154146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154146&action=edit Bug 29578: Upgrade the jQuery highlighter plugin Under certain conditions, the jQuery term highlighter can break and in the process make the "Highlight" / "Unhighlight" button disappear altogether. This affects catalog searches in both the OPAC and the Staff Client, with UNIMARC-based instances affected the most as the "Highlight" / "Unhighlight" button disappears if you perform a specific OPAC search (see Test plan below). This patch fixes that by upgrading the highlighter plugin to its latest version for both the OPAC and the Staff interface. Then, the changes from commit 2e4b574074 (Bug 5844) are applied to the plugin code. Also, Koha uses "term" instead of "highlight" as the class name for the highlighting elements, so the plugin code is modified for that aspect, too. Finally, the plugin file is renamed to reflect the version change (v3 -> v5) and all references to the old filename in the Template files are updated. Test plan: 0) In a UNIMARC instance, catalogue two books using the titles given below (Title subfield = 200$a): Book 1: Συλλογής των εν επιτομή τοῖς πάλαι γεωγραφηθέντων Book 2: Επιτομή της ιστορίας των Βαλκανικών Πολέμων (1912-1913) 1) OpacHighlightedWords and StaffHighlightedWords should both be set to "Highlight". 2) Search the OPAC for "επιτομή των" (without the quotes). In the results page, notice that: a) You get an Uncaught DOMException error in the web browswer's JavaScript Console (press F12): "Failed to execute 'splitText' on 'Text': The offset 3 is larger than the Text node's length." b) the "Highlight" / "Unhighlight" button vanishes c) some search terms matches are not highlighted (for example "των" in the 2nd Book) 3) Repeat the same search in the Staff interface. In the results page, notice that: a) You get an Uncaught DOMException error in the web browswer's JavaScript Console (press F12): "Failed to execute 'splitText' on 'Text': The offset 3 is larger than the Text node's length." b) Even though some terms are highlighted, the button still says "Highlight" c) some search terms matches are not highlighted (for example "των" in the 2nd Book) 4) Apply this patch. 5) Repeat the searches (you may have to press CTRL-F5 to reload the JavaScript code). This time the "Highlight" / "Unhighlight" button is displayed in the OPAC, and all your search terms should be highlighted in yellow. Toggling the highlight should cause no problems, and there shouldn't be any errors logged in your browser's Console. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 03:36:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 01:36:36 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #25 from Andreas Roussos --- (In reply to Stephanie Etallaz from comment #23) > CONFLICT (rename/rename): Rename > "koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js"- > >"koha-tmpl/opac-tmpl/lib/jquery/plugins/jquery.highlight-3.js" in branch > "HEAD" rename > "koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js"- > >"koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-5.js" in > "Bug 29578: Upgrade the jQuery highlighter plugin" Thank you for your interest in this bug report, Stephanie. The patch has been rebased against the current master, please try again ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 05:44:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 03:44:29 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #22 from Alex Buckley --- (In reply to David Cook from comment #21) > It might be worth adding that "None" has security implications and is not > recommended? > > Overall, I think only "Lax" and "Strict" makes sense for Koha with "Strict" > being preferable overall, although it would need some testing, especially > with identity providers... That's a great idea to add that None has security implications and isn't recommended, thanks for suggesting that David, Will add that to the syspref description in the yaml file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 06:46:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 04:46:45 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146608|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 06:46:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 04:46:53 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 06:47:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 04:47:05 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 06:47:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 04:47:13 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 06:47:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 04:47:34 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #57 from Alex Buckley --- Created attachment 154147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154147&action=edit Bug 21159: Database changes Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 06:53:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 04:53:37 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #58 from Alex Buckley --- Created attachment 154148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154148&action=edit Bug 21159: Template and yaml changes Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 06:54:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 04:54:17 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #59 from Alex Buckley --- Created attachment 154149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154149&action=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'CART'. Observe the location does not change on issue or return. 8. Run unit tests sudo koha-shell kohadev prove t/db_dependent/Circulation/issue.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 06:54:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 04:54:45 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #60 from Alex Buckley --- Created attachment 154150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154150&action=edit Bug 21159: (follow-up) Remove tab space Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 06:56:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 04:56:04 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #61 from Alex Buckley --- (In reply to Laura Escamilla from comment #56) > Applying: Bug 21159: Database changes > Using index info to reconstruct a base tree... > M installer/data/mysql/mandatory/sysprefs.sql > Falling back to patching base and 3-way merge... > Auto-merging installer/data/mysql/mandatory/sysprefs.sql > Applying: Bug 21159: Template and yaml changes > Applying: Bug 21159: Update item location on checkout > Using index info to reconstruct a base tree... > M C4/Circulation.pm > M Koha/Item.pm > M t/db_dependent/Circulation/issue.t > Falling back to patching base and 3-way merge... > Auto-merging t/db_dependent/Circulation/issue.t > CONFLICT (content): Merge conflict in t/db_dependent/Circulation/issue.t > Auto-merging Koha/Item.pm > CONFLICT (content): Merge conflict in Koha/Item.pm > Auto-merging C4/Circulation.pm > error: Failed to merge in the changes. > Patch failed at 0001 Bug 21159: Update item location on checkout > hint: Use 'git am --show-current-patch=diff' to see the failed patch > When you have resolved this problem run "git bz apply --continue". > If you would prefer to skip this patch, instead run "git bz apply --skip". > To restore the original branch and stop patching run "git bz apply --abort". > Patch left in /tmp/Bug-21159-Update-item-location-on-checkout-TimIX1.patch Thanks for trying to test Laura. I've rebased against master, these patches should now apply cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 07:11:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 05:11:25 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154150|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 07:11:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 05:11:33 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154149|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 07:12:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 05:12:18 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #62 from Alex Buckley --- Created attachment 154151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154151&action=edit Bug 21159: Update item location on checkout This patchset shifts the logic for changing the item location on checkin (controlled by the UpdateItemLocationOnCheckin system preference) to a new subroutine in Koha/Items.pm That subroutine logic is shared with the UpdateItemLocationOnCheckout system preference. Test plan: 1. Apply patches, update databases and restart services 2. Set the following system preferences: - UpdateItemLocationOnCheckin: FIC: PROC - UpdateItemLocationOnCheckout: PROC: FIC 3. Checkout an an item with items.location = 'PROC'. Observe it's location is changed to 'FIC' 4. Return the item. Observe it's location is changed to 'PROC' 5. Change UpdateItemLocationOnCheckout to: PROC: _BLANK_ 6. Issue the item with items.location = 'PROC' and confirm it's location is blanked on checkout 7. Issue and return an item with a different location e.g. 'CART'. Observe the location does not change on issue or return. 8. Run unit tests sudo koha-shell kohadev prove t/db_dependent/Circulation/issue.t Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 07:12:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 05:12:32 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #63 from Alex Buckley --- Created attachment 154152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154152&action=edit Bug 21159: (follow-up) Remove tab space Sponsored-by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 07:14:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 05:14:34 +0000 Subject: [Koha-bugs] [Bug 33259] Optionally set SameSite attribute of cookie to Strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33259 --- Comment #23 from David Cook --- Another thing about "None" is that I think it can only be set with the Secure attribute set as well. Not sure what happens when you try to send a cookie with "None" that isn't secure... I imagine it would default back to Lax but don't know for sure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 13:11:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 11:11:18 +0000 Subject: [Koha-bugs] [Bug 34136] Add ability to render a report using a notice template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153100|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 154153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154153&action=edit Bug 34136: Add ability to render a report using a notice template Sometimes it is useful to display the results of a report in a non-table format. We should be able to create notice templates to render reports. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Create a new notice template using the new "Report" option from the "New notice" pulldown. 4) In the "Print" area, paste the following template: [% FOREACH b IN data %]
[% b.surname %], [% b.firstname %]
Expiration: [% b.dateexpiry %]
ID: [% b.borrowernumber %]
[% END %] 5) Create a report with the query: SELECT * FROM borrowers 6) Once the report is saved, use the new "Run with template" option to select the template you just created. 7) Note that instead of the results being a paged table, you instead see the results rendered as cards! Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 13:22:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 11:22:21 +0000 Subject: [Koha-bugs] [Bug 34365] Hold cancellation request workflow cannot be triggered on API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34365 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 13:22:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 11:22:23 +0000 Subject: [Koha-bugs] [Bug 34365] Hold cancellation request workflow cannot be triggered on API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34365 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153935|0 |1 is obsolete| | Attachment #153936|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 154154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154154&action=edit Bug 34365: Unit tests Signed-off-by: Emily Lamancusa Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 13:22:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 11:22:30 +0000 Subject: [Koha-bugs] [Bug 34365] Hold cancellation request workflow cannot be triggered on API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34365 --- Comment #6 from Kyle M Hall --- Created attachment 154155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154155&action=edit Bug 34365: Add cancellation request flow to DELETE /holds This patch adds a new `x-koha-override` header to allow enforcing the cancellation request flow for waiting holds. If the hold is not waiting, the header has no effect. To test: 1. Apply the tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/holds.t => FAIL: The endpoint doesn't implement the required logic 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! The endpoint behavior is changed! 5. Sign off :-D Signed-off-by: Emily Lamancusa Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 13:58:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 11:58:53 +0000 Subject: [Koha-bugs] [Bug 34455] New: Exclude pronouns from fields hidden via HidePersonalPatronDetailsOnCirculation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34455 Bug ID: 34455 Summary: Exclude pronouns from fields hidden via HidePersonalPatronDetailsOnCirculation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: r.delahunty at arts.ac.uk QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a patron record has the borrowers.pronouns field populated and the HidePersonalPatronDetailsOnCirculation system parameter set to Hide, then the pronoun data is no longer visible. If the pronouns removal was optional or prevented we would not have to use the workaround of copying the pronouns data to a patron attribute and exposing that attribute. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:27:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 12:27:22 +0000 Subject: [Koha-bugs] [Bug 34456] New: Add the ability to download a template rendered report as a file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456 Bug ID: 34456 Summary: Add the ability to download a template rendered report as a file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 34136 adds the ability to render a report using a notice template rather than displaying data in a table. It would be even more useful to be able to download the contents as a file where the notice subject can be used as the filename so the filename can be generated dynamically ( such as adding the current date as part of the filename ). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:27:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 12:27:27 +0000 Subject: [Koha-bugs] [Bug 34456] Add the ability to download a template rendered report as a file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:32:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 12:32:31 +0000 Subject: [Koha-bugs] [Bug 34456] Add the ability to download a template rendered report as a file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:32:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 12:32:32 +0000 Subject: [Koha-bugs] [Bug 34456] Add the ability to download a template rendered report as a file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456 --- Comment #1 from Kyle M Hall --- Created attachment 154156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154156&action=edit Bug 34456 - Add the ability to download a template rendered report as a file Bug 34136 adds the ability to render a report using a notice template rather than displaying data in a table. It would be even more useful to be able to download the contents as a file where the notice subject can be used as the filename so the filename can be generated dynamically ( such as adding the current date as part of the filename ). Test Plan: 1) Follow the test plan for Bug 34136 2) Run your report 3) Note under the Download menu the new item "Download as" with the subject line for your template 4) Click that link, note the file contains the contents of your report! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:32:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 12:32:46 +0000 Subject: [Koha-bugs] [Bug 34456] Add the ability to download a template rendered report as a file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 [Bug 34136] Add ability to render a report using a notice template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 14:32:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 12:32:46 +0000 Subject: [Koha-bugs] [Bug 34136] Add ability to render a report using a notice template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456 [Bug 34456] Add the ability to download a template rendered report as a file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 15:55:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 13:55:06 +0000 Subject: [Koha-bugs] [Bug 34457] New: Add card number to hold details page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 Bug ID: 34457 Summary: Add card number to hold details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Adding the patron's cardnumber to the Hold details page can help libraries verify whether they are placing the hold for the correct patron. Especially if they have several patrons with the same or similar name. /cgi-bin/koha/reserve/request.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 15:55:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 13:55:24 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |Laura.escamilla at bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:00:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:00:11 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:00:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:00:13 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 --- Comment #1 from Laura Escamilla --- Created attachment 154157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154157&action=edit Bug 34457: Added the patron's cardnumber to the hold details page Test plan: 1. Go to place a hold on a patron 2. The hold details page (/cgi-bin/koha/reserve/request.pl) only shows the patron’s name. 3. Apply the patch 4. The hold details page now shows the patron’s name and their card number. 5. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:18:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:18:04 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 --- Comment #14 from Nick Clemens --- This seems correct. We should allow the API to update pickup location for in-transit holds. IMHO I think we should also add the ability to the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:21:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:21:52 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 --- Comment #15 from Tomás Cohen Arazi --- (In reply to Nick Clemens from comment #14) > This seems correct. We should allow the API to update pickup location for > in-transit holds. IMHO I think we should also add the ability to the staff > interface I agree. I'll file a separate report so we discuss the implementation details (logs? notifications?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:39:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:39:12 +0000 Subject: [Koha-bugs] [Bug 34456] Add the ability to download a template rendered report as a file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:39:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:39:14 +0000 Subject: [Koha-bugs] [Bug 34456] Add the ability to download a template rendered report as a file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34456 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154156|0 |1 is obsolete| | --- Comment #2 from Sam Lau --- Created attachment 154158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154158&action=edit Bug 34456 - Add the ability to download a template rendered report as a file Bug 34136 adds the ability to render a report using a notice template rather than displaying data in a table. It would be even more useful to be able to download the contents as a file where the notice subject can be used as the filename so the filename can be generated dynamically ( such as adding the current date as part of the filename ). Test Plan: 1) Follow the test plan for Bug 34136 2) Run your report 3) Note under the Download menu the new item "Download as" with the subject line for your template 4) Click that link, note the file contains the contents of your report! Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:41:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:41:35 +0000 Subject: [Koha-bugs] [Bug 34458] New: It should be possible to change the pickup location for in transit holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34458 Bug ID: 34458 Summary: It should be possible to change the pickup location for in transit holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 30500 introduced a way to change the pickup location for in transit holds, in the OPAC. And now bug 34024 highlighted we don't have a feature on the staff interface. I open this bug so we discuss possible implementation details. Questions: - Does it need any workflow? - Should this be reported somewhere? (e.g. in transit holds report highlighting those that changed) - Should it be notified. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:51:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:51:57 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:51:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:51:59 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154140|0 |1 is obsolete| | --- Comment #8 from Sam Lau --- Created attachment 154159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154159&action=edit Bug 29750: Reserves.pm should check if a patron is eligible to reserve and item before confirming the reserve Test plan: 1. Create two patrons, with the following patron categories: - Patron A -> Patron - Patron B -> Student 2. Create two items attached to a single biblio record: - Book - Continuing resource 3. Create the following circ rules: Patron category, item type, Holds allowed (total), Holds allowed (daily), Holds per record (count) - Patron, Book, 0, 0, 0 - Student, Book, 1, 1, 1 - All, Continuing resources, 1, 1, 1 4. Place a title level hold on the biblio for patron A 5. Place a title level hold on the biblio for patron B 6. Checkin the Book and notice you are prompted to confirm the hold by Patron A - even though according to circ rules they cannot reserve Books 7. Apply patch and restart services 9. Checkin the Book, and notice you're prompted to confirm the hold by Patron B Sponsored-By: Catalyst IT Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:52:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:52:01 +0000 Subject: [Koha-bugs] [Bug 29750] Reserves.pm should check patron category hold policies when finding a reserve for an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29750 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154141|0 |1 is obsolete| | --- Comment #9 from Sam Lau --- Created attachment 154160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154160&action=edit Bug 29750: Unit test fixes for Reserves.pm Test plan: 1. sudo koha-shell 2. prove t/db_dependent/Holds.t prove t/db_dependent/Reserves.t Sponsored-By: Catalyst IT Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:55:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:55:25 +0000 Subject: [Koha-bugs] [Bug 34136] Add ability to render a report using a notice template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:57:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:57:06 +0000 Subject: [Koha-bugs] [Bug 34458] It should be possible to change the pickup location for in transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34458 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34024 Depends on| |30500 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:57:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:57:06 +0000 Subject: [Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34458 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34458 [Bug 34458] It should be possible to change the pickup location for in transit holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 16:57:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 14:57:06 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34458 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 17:00:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 15:00:34 +0000 Subject: [Koha-bugs] [Bug 34458] It should be possible to change the pickup location for in transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34458 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 17:11:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 15:11:48 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau at gmail.com --- Comment #64 from Sam Lau --- Everything in your test plan is working perfectly. Failing QA because the tests are failing. # Failed test 'UpdateNotForLoanStatusOnCheckin updates notforloan value from 1 to 9 with setting "1: 9"' # at t/db_dependent/Circulation/issue.t line 432. # Failed test 'UpdateNotForLoanStatusOnCheckin does not update notforloan value from 9 with setting "1: 9"' # at t/db_dependent/Circulation/issue.t line 438. t/db_dependent/Circulation/issue.t .. 48/62 # Looks like you failed 2 tests of 62. t/db_dependent/Circulation/issue.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/62 subtests Test Summary Report ------------------- t/db_dependent/Circulation/issue.t (Wstat: 512 Tests: 62 Failed: 2) Failed tests: 27, 29 Non-zero exit status: 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 17:12:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 15:12:03 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 17:12:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 15:12:24 +0000 Subject: [Koha-bugs] [Bug 34458] It should be possible to change the pickup location for in transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34458 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 17:14:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 15:14:16 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154157|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 154161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154161&action=edit Bug 34457: Added the patron's cardnumber to the hold details page Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 17:15:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 15:15:44 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #3 from Sally --- Really nice idea for a patch - works as expected, signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 17:16:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 15:16:22 +0000 Subject: [Koha-bugs] [Bug 34459] New: Log in MARC record if the record was brought in via z39.50 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34459 Bug ID: 34459 Summary: Log in MARC record if the record was brought in via z39.50 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl For some libraries, it would be helpful to be able to report on and find what records are being brought in via a z39.50 search. If a value or indication could exist in the record, this would be easy for libraries to identify and find. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 17:18:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 15:18:54 +0000 Subject: [Koha-bugs] [Bug 34136] Add ability to render a report using a notice template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 --- Comment #6 from Sally --- This is a brilliant development - can't wait to see this in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 18:01:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 16:01:45 +0000 Subject: [Koha-bugs] [Bug 26994] Display list of names in alphabetical order when using the Suggestion information filter in Suggestions management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26994 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 19:52:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 17:52:16 +0000 Subject: [Koha-bugs] [Bug 28691] Quick spine label should split the same way the label creator does / use splitting rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28691 --- Comment #6 from Heather --- I was able to follow the test plan on a sandbox! I needed to enable the SpineLabelShowPrintOnBibDetails syspref, and to make the Other/generic... classification source "in use." When I followed the test plan with the regex and tested the regex (when adding the splitting rule) the call number split correctly. But after putting that exact same call number into an item record and trying the "spine label" button in the "Normal" display of the bib record to quick print a spint label, the call number did not split, even though I had configured the Other/generic to use the TEST splitting rule. So, does that help? Is there something else to do/test? Cheerio! h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 20:16:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 18:16:56 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154161|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 154162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154162&action=edit Bug 34457: Added the patron's cardnumber to the hold details page Signed-off-by: Sally Signed-off-by: Christine Lee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 21:36:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 19:36:25 +0000 Subject: [Koha-bugs] [Bug 34460] New: Patron category should regulate if account can have permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34460 Bug ID: 34460 Summary: Patron category should regulate if account can have permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Permission management would be simpler if there were a setting in patron categories that indicate whether that category of patron can have permissions. - If no, that option would not appear in the patron menu. - If patron category is changed to a category that does not allow permissions, any existing permissions should be cleared when change is saved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 21:40:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 19:40:02 +0000 Subject: [Koha-bugs] [Bug 34460] Patron category should regulate if account can have permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34460 --- Comment #1 from Christopher Brannon --- On further reflections, my second suggestion above should have its own preference setting to retain current behavior. - Create a pref, like ClearPermissionsAutomatically, where it defaults to Don't, but can be set to Do if you want permissions cleared automatically when changing patron to a category that doesn't allow permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 22:16:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 20:16:02 +0000 Subject: [Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize at ptfs-europe |tomascohen at gmail.com |.com | Status|Failed QA |ASSIGNED --- Comment #24 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #22) > Please fix: > > root at master:/usr/share/koha# git grep EmbedItemsInMarcBiblio > C4/Biblio.pm: EmbedItemsInMarcBiblio > > Exported not existing I don't understand this comment or why this is FQA (because of it?). This anyway doesn't apply anymore, and the last patch needs to be redone entirely. Will poke around it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 22:16:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 20:16:20 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 22:18:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 20:18:26 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 22:30:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 20:30:18 +0000 Subject: [Koha-bugs] [Bug 34458] It should be possible to change the pickup location for in transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34458 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 22:32:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 20:32:08 +0000 Subject: [Koha-bugs] [Bug 28691] Quick spine label should split the same way the label creator does / use splitting rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28691 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 22:45:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 20:45:32 +0000 Subject: [Koha-bugs] [Bug 31363] Background jobs table should include columns for name and library of initiating staff user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31363 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 22:49:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 20:49:31 +0000 Subject: [Koha-bugs] [Bug 21159] Update item shelving location (952$c) on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #65 from Alex Buckley --- Thank you for testing Sam. Taking a look now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 22:57:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 20:57:21 +0000 Subject: [Koha-bugs] [Bug 24968] Add system preference controls for cronjobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24968 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 23:00:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 21:00:40 +0000 Subject: [Koha-bugs] [Bug 32329] Marking early closures in calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32329 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 2 23:52:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 21:52:52 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 --- Comment #31 from Fridolin Somers --- (In reply to Jonathan Druart from comment #27) > (In reply to Fridolin Somers from comment #26) > > Interresting. > > > > Maybe a silly question : > > why not caching entire Koha::Patron object in > > CanBookBeReserved/CanItemBeReserve ? > > "entire"? What do you mean? The unblessed/hash version? Never mind, I bet the most important methods have been tracked down -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 00:00:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 22:00:04 +0000 Subject: [Koha-bugs] [Bug 34461] New: Sorting the Holds awaiting pickup table prevents the count on the "Cancel selected' button from changing unless all entries are shown Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34461 Bug ID: 34461 Summary: Sorting the Holds awaiting pickup table prevents the count on the "Cancel selected' button from changing unless all entries are shown Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If you sort the Holds waiting over x days, holds waiting, or holds with cancellation requests, then use the checkboxes on the left to select items to cancel, the number will not update and you can't cancel with the "cancel selected" button. If you change the "show x entries" to show all/a high enough number that all show, then it works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 00:03:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Aug 2023 22:03:23 +0000 Subject: [Koha-bugs] [Bug 32509] Embed see-also-from headings into bibliographic records export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32509 --- Comment #6 from Fridolin Somers --- Needs test plan and unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 03:36:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 01:36:55 +0000 Subject: [Koha-bugs] [Bug 34462] New: Bug 25299 seems to have been reintroduced in more recent versions. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 Bug ID: 34462 Summary: Bug 25299 seems to have been reintroduced in more recent versions. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On the details screen of a patron record, if the patron is due to expire the alert at the top of the screen reads: Expiration: Patron's card will expire soon. Patron's card expires on The date is missing from this alert. This was originally fixed in Bug 25299, but seems to have been reintroduced. I can replicate this at 21.11 and 22.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 03:46:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 01:46:30 +0000 Subject: [Koha-bugs] [Bug 34462] Bug 25299 seems to have been reintroduced in more recent versions. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34462 --- Comment #1 from David Roberts --- See https://snipboard.io/t5034G.jpg for a screenshot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 06:21:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 04:21:32 +0000 Subject: [Koha-bugs] [Bug 28525] TinyMCE for system prefs does some automatic code clean up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28525 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34463 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 06:21:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 04:21:32 +0000 Subject: [Koha-bugs] [Bug 26942] TinyMCE in the News Tool is still doing some types of automatic code cleanup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26942 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34463 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 06:21:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 04:21:32 +0000 Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34463 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 06:45:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 04:45:23 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #50 from David Cook --- +1 for UserCSS but I'm thinking that we might want to start killing off UserJS... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 09:29:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 07:29:04 +0000 Subject: [Koha-bugs] [Bug 34465] New: "Actions" columns are sortable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34465 Bug ID: 34465 Summary: "Actions" columns are sortable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com And it generates a 500 + JS error To recreate: Create at least one license or agreement Go to the list view Click on the header of the last column ("Actions") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 09:29:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 07:29:04 +0000 Subject: [Koha-bugs] [Bug 34447] "Actions" columns are exported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34447 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34465 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 09:30:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 07:30:12 +0000 Subject: [Koha-bugs] [Bug 34466] New: "Clear filter" always disabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34466 Bug ID: 34466 Summary: "Clear filter" always disabled Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com The "Clear filter" button of KohaTable in Vue components is always disabled and has no effect when clicked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 09:46:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 07:46:49 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Jonathan Druart --- 1. Atomic update contains SQL error: ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'SET @saved_cs_client = @@character_set_client */; 2. There are warnings in the console [Vue warn]: Data property "leftMenu" is already defined in Props. at at
[Vue warn]: Vue received a Component which was made a reactive object. This can lead to unnecessary performance overhead, and should be avoided by marking the component with `markRaw` or using `shallowRef` instead of `ref` 3. It's missing the "loading" when we fetch data. It's what we do in other places to avoid a "blink" 4. I think the breadcrumb is missing "administration" at the beginning. 5. If you create a new source without patron, you can submit the form (even if marked as required) and you get a 500 ('DBD::mysql::st execute failed: Field 'patron_id' doesn't have a default value') 6. CONSTRAINT `record_source_fk_1` FOREIGN KEY (`patron_id`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE Do we really want the 'on delete cascade' clause here? 7. Found 2 UI bugs but not related to this, reported on bug 34465 and bug 34466. Not blocker of course. 8. Why did you name the directory of the components "record-sources" instead of "RecordSources"? Isn't the standard to have CamelCase for component's names (and this top directory is kind of part of the component name). 9. Cancel link is not a pointer. Cancel link from here {{ $__("Cancel") }} vs Cancel link from AgreementsFormAdd {{ $__("Cancel") }} 10. in the routes file title: "List", you are missing $__("") 11. You are not using Breadcrumbs but setTitle in Main, why that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 09:53:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 07:53:48 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #64 from Laurence Rault --- User no superlibrarian with Preservation permission can access the module now and use it. User with no Preservation permission can't access to any page of the Preservation module. I sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 09:55:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 07:55:06 +0000 Subject: [Koha-bugs] [Bug 28900] Staff interface should have equivalent for OpacSuggestionMandatoryFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28900 Michelle West changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Michelle.West at eastdunbarton | |.gov.uk --- Comment #1 from Michelle West --- Having the option to mark fields as mandatory in the staff client would be really helpful for us too! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 09:57:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 07:57:01 +0000 Subject: [Koha-bugs] [Bug 34460] Patron category should regulate if account can have permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34460 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #2 from Sally --- +1 this is a great suggestion. Koha having the ability to clear permissions from an account when it moves from a 'permissions allowed category' into an ordinary patron category would be a huge help. Despite policies explaining otherwise, some staff members still believe that moving an ex-staff account to being an ordinary patron account revokes Koha access. I run a report to identify when this happens - but it would be very helpful if Koha could manage this automatically. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:22:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:22:14 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152940|0 |1 is obsolete| | Attachment #152941|0 |1 is obsolete| | Attachment #152942|0 |1 is obsolete| | Attachment #152943|0 |1 is obsolete| | Attachment #152944|0 |1 is obsolete| | Attachment #152945|0 |1 is obsolete| | Attachment #152946|0 |1 is obsolete| | Attachment #152947|0 |1 is obsolete| | Attachment #152948|0 |1 is obsolete| | Attachment #152949|0 |1 is obsolete| | Attachment #152950|0 |1 is obsolete| | Attachment #152951|0 |1 is obsolete| | Attachment #152952|0 |1 is obsolete| | Attachment #152953|0 |1 is obsolete| | Attachment #152954|0 |1 is obsolete| | Attachment #152955|0 |1 is obsolete| | Attachment #152956|0 |1 is obsolete| | Attachment #152957|0 |1 is obsolete| | Attachment #152958|0 |1 is obsolete| | Attachment #152959|0 |1 is obsolete| | Attachment #152960|0 |1 is obsolete| | Attachment #152961|0 |1 is obsolete| | Attachment #152962|0 |1 is obsolete| | Attachment #152963|0 |1 is obsolete| | Attachment #152964|0 |1 is obsolete| | Attachment #152965|0 |1 is obsolete| | Attachment #152966|0 |1 is obsolete| | Attachment #152967|0 |1 is obsolete| | Attachment #152968|0 |1 is obsolete| | Attachment #152969|0 |1 is obsolete| | Attachment #152970|0 |1 is obsolete| | Attachment #153102|0 |1 is obsolete| | --- Comment #65 from Jonathan Druart --- Created attachment 154167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154167&action=edit Bug 30708: Add REST API controllers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:22:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:22:19 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #66 from Jonathan Druart --- Created attachment 154168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154168&action=edit Bug 30708: Add Koha Objects Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:22:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:22:23 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #67 from Jonathan Druart --- Created attachment 154169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154169&action=edit Bug 30708: Add tests Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:22:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:22:27 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #68 from Jonathan Druart --- Created attachment 154170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154170&action=edit Bug 30708: REST API specs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:22:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:22:31 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #69 from Jonathan Druart --- Created attachment 154171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154171&action=edit Bug 30708: Vue app This commit contains the main commit message The description of the original need is described in documents attached by the sponsor on the bug report specifically "[En] Preservation module - Main principles". The idea is to develop a whole new module to track the status of the documents that are sent for processings/treatments in order to preserve them (eg. covering). This is a first step, more are certainly coming later. The author and sponsors have worked for several months before providing this MVP version. The different discussion and needs can be found at https://tree.taiga.io/project/joubu-koha-preservation-module/kanban Some ideas of the next steps are also listed. The first iterations have been done using the classic .pl/.tt Koha style but we finally switched to a new Vue module, for more fun. These patches made the following main changes: New files * Koha objects under Koha/Preservation * REST API controllers under Koha/REST/V1/Preservation * preservation/home.pl and preservation/home.tt * Vue components under js/vue/components/Preservation * tests under t/db_dependent/Koha/Preservation and t/db_dependent/api/v1/preservation_* * Cypress tests under t/cypress/integration/Preservation DB: * 3 new sysprefs PreservationModule, PreservationNotForLoanWaitingListIn, PreservationNotForLoanDefaultTrainIn * 1 new permission "preservation" (will be split into subpermissions later) * 5 new tables: - preservation_processings - preservation_trains - preservation_processing_attributes - preservation_trains_items - preservation_processing_attributes_items Terminology and workflow: *Processings* are the different treatments an item can receive during its stay in the preservation module A *processing* is defined by a list of *attributes*. To make the module as easy to use for the librarians in charge of the preservation area a list of processings will be defined when the module will be set up. An *attribute* is a name and a value. That's it. However it also has a type, to define what the value is coming from: *free text*, *authorised value* or *database column*. For instance if you are defining a processing that will handling the book cover you could have 3 *attributes*: - first named "Barcode" that will be automatically filled with "items.barcode" (type *database column*" - second attribute named "color" linked with a new PRES_COLOR authorised value category you would have previously defined with "red", "blue", "green", etc. (type *authorised value*) - third attribute named "notes", because librarians like notes (type *free text*) Important: Even if the attribute is linked with a DB column or AV category, the value will be automatically pre filled but will stay editable (could be a config option to restrict the edition, later, if needed). The *status* of an item will change during the preservation process. First it will arrive in the preservation area and be on a *waiting list*. It is not processed already but is not available anymore for the patrons of the library. That's why we are going to use the "not for loan" (items.notforloan) value for this. This *waiting list* is a fictional concept, it simply lists all the items in the library with a specific *status*. A *train* is... how they call that at the BULAC, a train (same in French!). And we quite like the word so we kept it. It is what it is: a list of items/waggons, one after each other. We could have picked "cart", "list", but the concepts were already used in different places. We are not strongly attached to the term and it can be modified (but it's spread all over the code already and will be tedious to modify!) if you have a very good suggestion :) So, a *train* is where items are going after they have been sent to the waiting list. It's a stack of items that will be sent to a provider. When you create a new train you will be asked for the "Status for item added to this train", that will be the "not for loan" value to set to the items added to this train, and a "Default processing" that will be the processing used. But keep in mind that a train can have items that have different processings (specific case, will see later). When all items have been added to a *train*, you can *close* it. You cannot add items anymore to it! Then you can *send* it, and finally *receive* it. They are just statuses to keep track of the dates, and filter trains by status. However when a train is received you can *copy* an item to another (opened) train. It means that you have the item on hand but something went wrong, you are not happy with the work done by the supplier and want to send it back, so you create a new train (that can have different items, and it is the case where you will have items in a train that don't all have the same processing!). Test plan: A. Prerequisites 0. Just `reset_all` and jump to B, or: 1. Apache configuration You will need to edit /etc/koha/apache-shared-intranet-git.conf and add the following lines after the RewriteRule for erm (line.24?) RewriteCond %{REQUEST_URI} !^/cgi-bin/koha/preservation/.*.pl$ RewriteRule ^/cgi-bin/koha/preservation/.*$ /cgi-bin/koha/preservation/home.pl [PT] The RewriteCond is only useful if you are testing the "print slips" bugs as well, but it cannot hurt to have it! 2. `yarn js:build` to regenerate the Vue app for the preservation module 3. `updatedatabase` 4. `restart_all` B. Settings 0. Create 2 different values for NOTLOAN, eg. 'In preservation' and 'In preservation external' Create different authorised values for a new category, eg. PRES_COLORS: RED, BLUE, GREEN. Feel free to create more categories. 1. You can turn on the "PreservationModule" syspref and go to the Koha homepage to see a new "Preservation" link 2. You landed on the empty home page of the preservation, no worry! We need to fill this page with useful information! (see #2 on the kanban) 3. Go to settings 4. Set "Status for item added to waiting list" to "In preservation" and "Default status for item added to train": "In preservation external" Create a new processing and define some attributes. Ideally at least one of each type. 5. Go to "Waiting list" and add some items 6. Go to "Trains" and create several trains (at least 2). Notice that the "Status for item added to this train" value is set to the value defined in the settings, but can be modified. Notice that this status can be set when a train is created but it won't be possible to edit later. 7. Add items to a train. You can only add items that are already in the waiting list. Add values for the attributes. Notice that the attributes linked with a database column are automatically pre filled. Notice that attributes linked with an authorised value are displayed with a dropdown list but that a different value can be set (remember, this is a feature!). Notice that attributes can be multivalued. 8. Add other items to the waiting list, notice the "Add last X items to a train" link at the top of the waiting list table, click it 9. You can now add several items to a train, directly (for instance if you don't really need to pass through the waiting list). Values can be set for the batch, but attributes linked with a database column are not editable (they will be prefilled automatically) 10. Once you have a train with several items, look at the "show train" view and notice the item list. If all of them are using the same processing then a table is displayed, one column per attribute. However if at least one item of the train has a different processing then the items are not listed in a table. 11. Edit items and confirm that the values are correctly saved. 12. Close, send and receive a train 13. Once a train is closed you can no longer add items to it 14. Once a train is received notice that you can "copy" an item to another (opened) train QA notes: The patch is huge! New enhancements and improvements have been moved to separate bug reports but this cannot be split. We need a ground base to build on top. The size is mainly coming from Vue components, Koha::Objects, REST API controllers and specs, and tests. Nothing hard ;) More to come: - See the kanban! - Print slips (bug 33547 and bug 34030) - Put something on the landing page! - Link with the acquisition module (suppliers, funds, etc.) Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:22:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:22:36 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #70 from Jonathan Druart --- Created attachment 154172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154172&action=edit Bug 30708: DB changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:22:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:22:40 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #71 from Jonathan Druart --- Created attachment 154173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154173&action=edit Bug 30708: Add apache RewriteRule Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:22:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:22:44 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #72 from Jonathan Druart --- Created attachment 154174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154174&action=edit Bug 30708: Koha controller script and template changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:22:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:22:47 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #73 from Jonathan Druart --- Created attachment 154175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154175&action=edit Bug 30708: Add user_train_item_id Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:22:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:22:51 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #74 from Jonathan Druart --- Created attachment 154176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154176&action=edit Bug 30708: Do not allow edition of 'status for item added to train' It does not seem useful to enforce it at lower level, it is not a condition that will break the feature, but it does not feel correct to allow the modification of this value Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:22:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:22:55 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #75 from Jonathan Druart --- Created attachment 154177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154177&action=edit Bug 30708: Keep item attributes when editing a new processing Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:22:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:22:59 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #76 from Jonathan Druart --- Created attachment 154178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154178&action=edit Bug 30708: Show the copy button right after the train is received Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:03 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #77 from Jonathan Druart --- Created attachment 154179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154179&action=edit Bug 30708: Duplicate/copy items to an opened train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:07 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #78 from Jonathan Druart --- Created attachment 154180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154180&action=edit Bug 30708: Do not allow deletion of processings that are used Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:11 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #79 from Jonathan Druart --- Created attachment 154181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154181&action=edit Bug 30708: Do not allow copy item to a train if the item already exists in a non-received train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:15 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #80 from Jonathan Druart --- Created attachment 154182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154182&action=edit Bug 30708: Do not allow adding new items to a closed train Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:19 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #81 from Jonathan Druart --- Created attachment 154183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154183&action=edit Bug 30708: DBIC schema changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:23 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #82 from Jonathan Druart --- Created attachment 154184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154184&action=edit Bug 30708: DBIC specific Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:27 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #83 from Jonathan Druart --- Created attachment 154185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154185&action=edit Bug 30708: Allow attributes to be multivalued This is not working as it, but we are going to fix the problem when working on the "Set default values for items added in batch to a train" Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:31 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #84 from Jonathan Druart --- Created attachment 154186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154186&action=edit Bug 30708: DO NOT PUSH - ONLY FOR DB UPDATE DURING TESTING STAGE Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:35 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #85 from Jonathan Druart --- Created attachment 154187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154187&action=edit Bug 30708: DBIC Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:39 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #86 from Jonathan Druart --- Created attachment 154188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154188&action=edit Bug 30708: Allow modifying attribute linked with AV to another value If a value is not in the AV list, or if it differs slightly, they would like to force the modification of the value, without creating a new authorised value. Note that this could be a candidate for an option at the attribute level if there are different needs (ie. for some attributes we don't want to allow an other value). Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:43 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #87 from Jonathan Druart --- Created attachment 154189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154189&action=edit Bug 30708: Set default values for items added in batch to a train Technical notes: Ideally we would have split TrainsFormAddItem to make some part reusable, but it turned out into a complicated component that would have been hard to maintain. It seems easier to have two different components. Ideas to improve this area are welcome! Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:47 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #88 from Jonathan Druart --- Created attachment 154190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154190&action=edit Bug 30708: Display AV descriptions instead of codes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:51 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #89 from Jonathan Druart --- Created attachment 154191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154191&action=edit Bug 30708: Add spacing for buttons Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:55 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #90 from Jonathan Druart --- Created attachment 154192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154192&action=edit Bug 30708: Prevent dropdown list to be hidden behind the modal Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:23:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:23:59 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #91 from Jonathan Druart --- Created attachment 154193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154193&action=edit Bug 30708: Add a default sort for trains We want opened, closed, sent, then finally received trains. But ordering by desc for opened, and asc for the others. Which means the last opened will be first, but the closed, send and received will display oldest first. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:24:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:24:03 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #92 from Jonathan Druart --- Created attachment 154194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154194&action=edit Bug 30708: Add missing action buttons for non-table view If items with different processings are in a train, there is only the "edit" action button. It's missing "Remove" and "Copy". Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:24:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:24:07 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #93 from Jonathan Druart --- Created attachment 154195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154195&action=edit Bug 30708: Deal with deleted authorised value categories If a AV category is renamed or deleted, the app will freeze with "TypeError: av_match is undefined" To prevent that we add an check to prevent the freeze and a warning in the settings. We could eventually add a FK on option_source, but the idea was to let it flexible in case we want to add another source. This bug can be considered a configuration error anyway. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:24:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:24:11 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #94 from Jonathan Druart --- Created attachment 154196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154196&action=edit Bug 30708: Fix Trains.ts tests Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:24:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:24:15 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #95 from Jonathan Druart --- Created attachment 154197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154197&action=edit Bug 30708: Remove q_header from specs It broke the REST API routes. Adjustement for bug 33971. Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:24:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:24:19 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #96 from Jonathan Druart --- Created attachment 154198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154198&action=edit Bug 30708: (bugfix) Redirect to train list view after the train is deleted Do not stay on the show train view. Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:24:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:24:23 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #97 from Jonathan Druart --- Created attachment 154199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154199&action=edit Bug 30708: Rebase - Rewrite toolbar Bug 33417 has changed how we handle the toolbars in Vue apps, this patch is adjusting the 'Preservation' module code on top of it, but also adds to make it more flexible (see bug 34215). Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:24:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:24:27 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #98 from Jonathan Druart --- Created attachment 154200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154200&action=edit Bug 30708: Rebase - Use name instead of url for router-links Adjust code to match changes done by bug 32932. Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:24:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:24:31 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #99 from Jonathan Druart --- Created attachment 154201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154201&action=edit Bug 30708: Rebase - Adjust breadcrumbs To match what has been done on bug 33169 and bug 34418. Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:24:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:24:35 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #100 from Jonathan Druart --- Created attachment 154202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154202&action=edit Bug 30708: Rebase - Use a dedicated 'config' endpoint To retrieve the sysprefs, instead of using the svc script. See bug 33606. Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:24:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:24:39 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 --- Comment #101 from Jonathan Druart --- Created attachment 154203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154203&action=edit Bug 30708: Do not allow non-authorised users to edit the settings In case the logged in user does not have manage_sysprefs we should no display the form in the settings. Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:26:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:26:21 +0000 Subject: [Koha-bugs] [Bug 33547] Print slips from the preservation module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33547 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152971|0 |1 is obsolete| | Attachment #152972|0 |1 is obsolete| | Attachment #152973|0 |1 is obsolete| | Attachment #152974|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 154204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154204&action=edit Bug 33547: Add print slip Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:26:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:26:24 +0000 Subject: [Koha-bugs] [Bug 33547] Print slips from the preservation module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33547 --- Comment #13 from Jonathan Druart --- Created attachment 154205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154205&action=edit Bug 33547: DBIC schema changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:26:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:26:26 +0000 Subject: [Koha-bugs] [Bug 33547] Print slips from the preservation module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33547 --- Comment #14 from Jonathan Druart --- Created attachment 154206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154206&action=edit Bug 33547: Display AV descriptions instead of codes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:26:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:26:29 +0000 Subject: [Koha-bugs] [Bug 33547] Print slips from the preservation module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33547 --- Comment #15 from Jonathan Druart --- Created attachment 154207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154207&action=edit Bug 33547: Add missing action button for non-table view Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:26:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:26:57 +0000 Subject: [Koha-bugs] [Bug 34030] Print slips in a batch from the preservation module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152975|0 |1 is obsolete| | Attachment #152976|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 154208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154208&action=edit Bug 34030: Add a "print slips" action links to print in batch Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:26:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:26:59 +0000 Subject: [Koha-bugs] [Bug 34030] Print slips in a batch from the preservation module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34030 --- Comment #7 from Jonathan Druart --- Created attachment 154209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154209&action=edit Bug 34030: non-table view Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: BULAC - http://www.bulac.fr/ Signed-off-by: Heather Hernandez Signed-off-by: Laurence Rault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:27:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:27:44 +0000 Subject: [Koha-bugs] [Bug 34030] Print slips in a batch from the preservation module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34030 --- Comment #8 from Jonathan Druart --- (In reply to Laurence Rault from comment #5) > When I click on the Print slips link without having selected items, nothing > occurs. Could be done : either disabled the click, or print a warning "no > item was selected" Will do here if QA think it's blocker, or on a separate bug report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:29:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:29:55 +0000 Subject: [Koha-bugs] [Bug 33547] Print slips from the preservation module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33547 Laurence Rault changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |laurence.rault at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:30:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:30:28 +0000 Subject: [Koha-bugs] [Bug 34030] Print slips in a batch from the preservation module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34030 Laurence Rault changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:32:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:32:15 +0000 Subject: [Koha-bugs] [Bug 34418] Allow empty nodes in breadcrumb's elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |matt.blenkinsop at ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:32:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:32:55 +0000 Subject: [Koha-bugs] [Bug 34418] Allow empty nodes in breadcrumb's elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:32:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:32:58 +0000 Subject: [Koha-bugs] [Bug 34418] Allow empty nodes in breadcrumb's elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153910|0 |1 is obsolete| | Attachment #153911|0 |1 is obsolete| | Attachment #153912|0 |1 is obsolete| | Attachment #153913|0 |1 is obsolete| | Attachment #154095|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 154210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154210&action=edit Bug 34418: DO NOT PUSH - example Try the other patch with this patch applied. Go to http://localhost:8081/cgi-bin/koha/erm/agreements/1/items/add Without the patch you get: E-resource management > Agreements > Show agreement > > Add item to train With this patch applied: E-resource management > Agreements > Show agreement > Add item to train Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:33:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:33:01 +0000 Subject: [Koha-bugs] [Bug 34418] Allow empty nodes in breadcrumb's elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #20 from Jonathan Druart --- Created attachment 154211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154211&action=edit Bug 34418: Allow empty nodes in breadcrumb's elements Coming from an adaptation of "Bug 33169: DO NOT PUSH Allow breadcrumbs to accept dynamic values" Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:33:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:33:04 +0000 Subject: [Koha-bugs] [Bug 34418] Allow empty nodes in breadcrumb's elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #21 from Jonathan Druart --- Created attachment 154212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154212&action=edit Bug 34418: Add is_empty flag Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:33:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:33:07 +0000 Subject: [Koha-bugs] [Bug 34418] Allow empty nodes in breadcrumb's elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #22 from Jonathan Druart --- Created attachment 154213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154213&action=edit Bug 34418: DO NOT PUSH - update example Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 10:33:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 08:33:10 +0000 Subject: [Koha-bugs] [Bug 34418] Allow empty nodes in breadcrumb's elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #23 from Jonathan Druart --- Created attachment 154214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154214&action=edit Bug 34418: Replace dynamic parameter on unnamed route node Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 11:07:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 09:07:14 +0000 Subject: [Koha-bugs] [Bug 34467] New: OAI GetRecord bad encoding for Unimarc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 Bug ID: 34467 Summary: OAI GetRecord bad encoding for Unimarc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 11:12:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 09:12:38 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 11:12:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 09:12:40 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 --- Comment #1 from Frédéric Demians --- Created attachment 154215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154215&action=edit Bug 34467: OAI GetRecord bad encoding for Unimarc For some Unimarc biblio records, the OAI Server returns a bad XML document, ie a document with extended characters, such as accents, not encoded in UTF8. It seems to come from somewhere in MARC::Record library trying to deduce biblio record endoding from some fields. It may work for MARC21 records. It doesn't for Unimarc records. So it's necessary to send to the method transforming record into XML the marcflavour. This way there is no encoding guessing from Unimarc biblio records content. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 11:13:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 09:13:00 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 12:10:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 10:10:52 +0000 Subject: [Koha-bugs] [Bug 34468] New: Add a progress callback to job_progress.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34468 Bug ID: 34468 Summary: Add a progress callback to job_progress.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, kyle at bywatersolutions.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com Depends on: 31666 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 [Bug 31666] Add job progress bar to stage-marc-import.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 12:10:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 10:10:52 +0000 Subject: [Koha-bugs] [Bug 31666] Add job progress bar to stage-marc-import.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31666 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34468 [Bug 34468] Add a progress callback to job_progress.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 12:12:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 10:12:31 +0000 Subject: [Koha-bugs] [Bug 34468] Add a progress callback to job_progress.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34468 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 12:12:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 10:12:34 +0000 Subject: [Koha-bugs] [Bug 34468] Add a progress callback to job_progress.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34468 --- Comment #1 from Pedro Amorim --- Created attachment 154216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154216&action=edit Bug 34468: Add progress callback to job_progress.js -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 12:12:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 10:12:37 +0000 Subject: [Koha-bugs] [Bug 34468] Add a progress callback to job_progress.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34468 --- Comment #2 from Pedro Amorim --- Created attachment 154217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154217&action=edit Bug 34468: Update how we call updateProgress in stage-marc-import.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 12:14:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 10:14:12 +0000 Subject: [Koha-bugs] [Bug 34468] Add a progress callback to job_progress.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34468 --- Comment #3 from Pedro Amorim --- Calling anyone who can SO/QA this by testing the stage marc import tool and progress bar. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 12:14:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 10:14:29 +0000 Subject: [Koha-bugs] [Bug 34468] Add a progress callback to job_progress.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34468 --- Comment #4 from Pedro Amorim --- This is something we're using/need for ERM Usage Statistics. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 12:21:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 10:21:28 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #50 from Jonathan Druart --- (In reply to Kyle M Hall from comment #47) > Created attachment 153929 [details] [review] > Bug 28966: (QA Follow-up) Fix failing unit tests > > Test Plan: > 1) prove t/db_dependent/TestBuilder.t > 2) Note tests fail > 3) Apply this patch > 4) Run updatedatabase.pl > 5) Update the schema files ( alias 'dbic' can be used in > koha-testing-docker ) > 6) prove t/db_dependent/TestBuilder.t > 7) Tests now pass! This is breaking Koha_Master_My8 12:06:40 koha_1 | DBD::mysql::st execute failed: All parts of a PRIMARY KEY must be NOT NULL; if you need NULL in a key, use UNIQUE instead at /usr/share/perl5/DBIx/RunSQL.pm line 279, <$args{...}> line 1. 12:06:40 koha_1 | Something went wrong loading file /kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE TABLE `tmp_holdsqueue` ( 12:06:40 koha_1 | `biblionumber` int(11) DEFAULT NULL, 12:06:40 koha_1 | `itemnumber` int(11) DEFAULT NULL, 12:06:40 koha_1 | `barcode` varchar(20) DEFAULT NULL, 12:06:40 koha_1 | `surname` longtext NOT NULL, 12:06:40 koha_1 | `firstname` mediumtext DEFAULT NULL, 12:06:40 koha_1 | `phone` mediumtext DEFAULT NULL, 12:06:40 koha_1 | `borrowernumber` int(11) NOT NULL, 12:06:40 koha_1 | `cardnumber` varchar(32) DEFAULT NULL, 12:06:40 koha_1 | `reservedate` date DEFAULT NULL, 12:06:40 koha_1 | `title` longtext DEFAULT NULL, 12:06:40 koha_1 | `itemcallnumber` varchar(255) DEFAULT NULL, 12:06:40 koha_1 | `holdingbranch` varchar(10) DEFAULT NULL, 12:06:40 koha_1 | `pickbranch` varchar(10) DEFAULT NULL, 12:06:40 koha_1 | `notes` mediumtext DEFAULT NULL, 12:06:40 koha_1 | `item_level_request` tinyint(4) NOT NULL DEFAULT 0, 12:06:40 koha_1 | `timestamp` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'date and time this entry as added/last updated', 12:06:40 koha_1 | PRIMARY KEY (`itemnumber`), 12:06:40 koha_1 | KEY `tmp_holdsqueue_ibfk_1` (`itemnumber`), 12:06:40 koha_1 | KEY `tmp_holdsqueue_ibfk_2` (`biblionumber`), 12:06:40 koha_1 | KEY `tmp_holdsqueue_ibfk_3` (`borrowernumber`), 12:06:40 koha_1 | CONSTRAINT `tmp_holdsqueue_ibfk_1` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE ON UPDATE CASCADE, 12:06:40 koha_1 | CONSTRAINT `tmp_holdsqueue_ibfk_2` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE, 12:06:40 koha_1 | CONSTRAINT `tmp_holdsqueue_ibfk_3` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE 12:06:40 koha_1 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci 12:06:40 koha_1 | ) at /kohadevbox/koha/C4/Installer.pm line 585. https://jenkins.koha-community.org/job/Koha_Master_My8/1236/console -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 12:46:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 10:46:12 +0000 Subject: [Koha-bugs] [Bug 33857] Reduce and resize local cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #9 from Jonathan Druart --- Manos is right, we should fix the original problem instead of doing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 12:47:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 10:47:22 +0000 Subject: [Koha-bugs] [Bug 33857] Reduce and resize local cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33857 --- Comment #10 from Jonathan Druart --- See bug 33143, bug 31049, bug 23963 and bug 22988. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 14:30:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 12:30:16 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 14:30:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 12:30:18 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 --- Comment #7 from Nick Clemens --- Created attachment 154218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154218&action=edit Bug 34108: Preserve checked orders after item editing The js that buils the new row after editing expects to receive a value '_checked' indicating if theitem was selected. The 'item' variable used to create the row after edit comes from the api and doesn't include this. We need to inspect the previous html before building the new row to confirm the box wa checked To test: 1 - Create a basket with 'items created on receive' 2 - Add an order line with multiple items to it 3 - Close basket 4 - Receive shipment 5 - Add invoice information 6 - Receive through receive link in the table 7 - Check some items 8 - Click on the "Edit" link and make some change to the item 9 - Save 10 - Checkboxes have disappeared 11 - Cancel receipt 12 - Apply patch 13 - Reload the page 14 - Repeat 7-9 15 - Checkbox is preserved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 14:30:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 12:30:41 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 14:41:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 12:41:39 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 --- Comment #2 from Frédéric Demians --- The issue comes from leader position 9. In MARC21, if pos9 doesn't contain a 'a', MARC::File::XML transcode data from marc8 to utf8. In Unimarc, pos9 is not used (then often empty) and marc8 is never used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 15:04:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 13:04:47 +0000 Subject: [Koha-bugs] [Bug 18205] Use Koha::Logger/Log4Perl using Mojolicious app log method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #39 from Marcel de Rooy --- We can close this one. See 22678. *** This bug has been marked as a duplicate of bug 22678 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 15:04:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 13:04:47 +0000 Subject: [Koha-bugs] [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at hypernova.fi --- Comment #26 from Marcel de Rooy --- *** Bug 18205 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 15:04:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 13:04:48 +0000 Subject: [Koha-bugs] [Bug 18206] REST API: Default exception handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206 Bug 18206 depends on bug 18205, which changed state. Bug 18205 Summary: Use Koha::Logger/Log4Perl using Mojolicious app log method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 15:30:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 13:30:21 +0000 Subject: [Koha-bugs] [Bug 34469] New: Modifying an order line of a standing order will delete linked invoice ID Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Bug ID: 34469 Summary: Modifying an order line of a standing order will delete linked invoice ID Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When modifying a received order line from a standing order, the invoice id in the order line will be emptied out, leaving you with an order line that is complete, but not linked to an invoice (= inconsistent state, data loss) This cannot be resolved in the GUI, since you can't 'cancel receipt' for this order line, since it's not linked to an invoice any more. The only way to fix things is with SQL. And there is no way to find out which invoice the order line was originally received in. To test: * Create basket as standing order with items added in cataloguing * Add an order line * Receive shipment * Go to the basket summary page, click on 'Modify' * Change the actual cost * Save * Verify that the invoice is now empty * In the database aqorders.invoiceid will be NULL -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 15:30:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 13:30:29 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 15:34:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 13:34:00 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 --- Comment #1 from Katrin Fischer --- Solution: it should not be possible to modify received order lines in any basket. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 15:45:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 13:45:49 +0000 Subject: [Koha-bugs] [Bug 34470] New: Real Time Holds Queue - make random numbers play nice with forked processes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 Bug ID: 34470 Summary: Real Time Holds Queue - make random numbers play nice with forked processes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org In our system, we're noticing that the real-time holds queue is consistently sending a disproportionate number of holds to the same branches, although RandomizeHoldsQueueWeight is set to distribute holds randomly. The holds queue cron job often produced a "bubble" where one or two libraries would have a much longer holds queue than the others, but the "bubble" would move around between different branches from run to run. Since turning on the real-time holds queue, the "bubble" has stayed on the same two libraries for the full week that the real-time holds queue has been running. Other library systems have reported imbalanced distributions as well. Adding some logging revealed that the branches were being "randomized" to an identical order each time the holds queue is updated! This is consistent with the evidence that the same branches are always being assigned the most and second-most holds (respectively) in our production server. I was also able to replicate that same behavior on master, 22.11.x, and 22.05.x. Instructions to replicate are coming in the first comment, along with a patch to add the logging. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 15:48:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 13:48:51 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 15:58:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 13:58:27 +0000 Subject: [Koha-bugs] [Bug 34471] New: Do we need any from List::Util or List::MoreUtils? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34471 Bug ID: 34471 Summary: Do we need any from List::Util or List::MoreUtils? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org We use both in the codebase. The latter is widely used. git grep -P "List::Util.*any" Koha/Exporter/Record.pm:use List::Util qw( all any ); Koha/SearchEngine/Elasticsearch/Indexer.pm:use List::Util qw( any ); Koha/Template/Plugin/Categories.pm:use List::Util qw( any ); opac/opac-password-recovery.pl:use List::Util qw( any ); reports/cash_register_stats.pl:use List::Util qw( any ); t/db_dependent/Koha/SearchEngine/Elasticsearch.t:use List::Util qw( any ); git grep -l -P "List::MoreUtils.*any" | wc -l 59 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 16:01:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 14:01:18 +0000 Subject: [Koha-bugs] [Bug 34254] Reopening a basket to edit an order item will remove it from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34254 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Laura Escamilla --- *** This bug has been marked as a duplicate of bug 34469 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 16:01:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 14:01:18 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #2 from Laura Escamilla --- *** Bug 34254 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 16:30:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 14:30:24 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 --- Comment #1 from Emily Lamancusa --- Created attachment 154219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154219&action=edit Bug 34470: [DO NOT PUSH] Add logging to watch randomization -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 16:30:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 14:30:47 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 --- Comment #2 from Emily Lamancusa --- To replicate: 1. Apply logging patch 2. Set system preferences: a. RealTimeHoldsQueue -> Enable b. RandomizeHoldsQueueWeight -> in random order 3. Watch the logs for the staff interface in ktd: ktd --shell koha-intra-err 4. Place a hold. Note that the logs display the branch list before and after it is randomized. 5. Place some more holds. Note that the branch order after randomization is identical each time. Bonus round 1: 6. Fill in some branches (I recommend at least 8 or so) for StaticHoldsQueueWeight 7. Place some more holds. 8. Note that the branch list before randomization is identical to the list in StaticHoldsQueueWeight, and the list after randomization is the same each time (but not necessarily identical to the randomized list that was produced when StaticHoldsQueueWeight was empty). Bonus round 2: 9. Add the following line to load_branches_to_pull_from in C4/HoldsQueue.pm: $logger->warn(rand()); 10. Place some more holds. 11. Note that rand() produces the same result each time, and the list after randomization is still the same each time (but not necessarily identical to the randomized list that was produced before the call to rand() was added). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 16:40:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 14:40:28 +0000 Subject: [Koha-bugs] [Bug 34254] Reopening a basket to edit an order item will remove it from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34254 --- Comment #2 from Katrin Fischer --- Sorry Laura, I had missed you filing this one! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 16:46:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 14:46:19 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 --- Comment #3 from Emily Lamancusa --- The logging makes it clear that the call to shuffle() in load_branches_to_pull_from is "randomizing" deterministically for some reason. According to the List::Utils docs, shuffle() depends on Perl's rand() function (unless an alternative method is set). I think the bug has to do with the scenario described here: https://stackoverflow.com/questions/58120618/how-to-get-random-number-in-forked-processes We do fork at minimum one process to process a background job (or more depending on configuration after bug 32558). According to the above, if a parent process uses rand() and later spawns a child process which also calls rand(), every child process will inherit the same seed and thus produce an identical random number sequence unless the seed is reset with srand() after the fork. The official docs for rand() don't quite spell this out but they allude to the need to call srand() in a child process (though they also warn that srand() should not be called more than once per process). The results I'm seeing are consistent with this, and that would also explain why this doesn't happen in the cron job (which does not fork). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 16:50:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 14:50:24 +0000 Subject: [Koha-bugs] [Bug 25159] Action logs should be stored in JSON ( and as a diff of the change ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #29 from Jonathan Druart --- 1. I am not sure, but maybe we could pass $self and log $self->get_from_store as the original (?) Maybe we will lose flexibility however. 2. What about the switch? Should we continue to log in 'info'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 17:11:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 15:11:30 +0000 Subject: [Koha-bugs] [Bug 34254] Reopening a basket to edit an order item will remove it from the invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34254 --- Comment #3 from Laura Escamilla --- (In reply to Katrin Fischer from comment #2) No worries, Katrin! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 17:15:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 15:15:12 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 --- Comment #4 from Emily Lamancusa --- The only thing I can't figure out is where (if?) randomization is happening in the parent process, which is supposed to be one of the conditions for the identical rand() results in the child process...but everything else fits. Either way, this is so deep in the weeds of Perl and parallel processing that I'd like to get more eyes on it (both for perspective and confirmation that others replicate the problem) before going further with it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 17:27:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 15:27:50 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 17:27:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 15:27:52 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154218|0 |1 is obsolete| | --- Comment #8 from Sam Lau --- Created attachment 154220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154220&action=edit Bug 34108: Preserve checked orders after item editing The js that buils the new row after editing expects to receive a value '_checked' indicating if theitem was selected. The 'item' variable used to create the row after edit comes from the api and doesn't include this. We need to inspect the previous html before building the new row to confirm the box wa checked To test: 1 - Create a basket with 'items created on receive' 2 - Add an order line with multiple items to it 3 - Close basket 4 - Receive shipment 5 - Add invoice information 6 - Receive through receive link in the table 7 - Check some items 8 - Click on the "Edit" link and make some change to the item 9 - Save 10 - Checkboxes have disappeared 11 - Cancel receipt 12 - Apply patch 13 - Reload the page 14 - Repeat 7-9 15 - Checkbox is preserved Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 17:33:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 15:33:34 +0000 Subject: [Koha-bugs] [Bug 33828] ExportCircHistory description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 17:33:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 15:33:36 +0000 Subject: [Koha-bugs] [Bug 33828] ExportCircHistory description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152578|0 |1 is obsolete| | --- Comment #4 from Sam Lau --- Created attachment 154221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154221&action=edit Bug 33828: ExportCircHistory description is misleading This patch removes the mention of checkout history from the ExportCircHistory system preference description, as this system preference only allows to export current checkouts, not checkout history. This patch also modifies the description of the ExportRemoveFields system preference to also remove mention of checkout history. To test: 0. Apply patch 1. Go to Administration > System preferences > Circulation 2. Read the description for ExportCircHistory, make sure it makes sense, and that spelling and syntax are correct 3. Read the description for ExportRemoveFields, make sure it makes sense, and that spelling and syntax are correct Signed-off-by: Sam Lau -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 17:49:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 15:49:11 +0000 Subject: [Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 17:49:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 15:49:13 +0000 Subject: [Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146031|0 |1 is obsolete| | --- Comment #12 from Sam Lau --- Created attachment 154222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154222&action=edit Bug 32560: Cronjob to mark expired borrowers as lost their card Test plan: 1. Edit a borrower to have an expiration date in the past - also make sure they have 'Lost card' set to 'No' 2. Run the set_expired_lost.pl script: sudo koha-shell cd misc/cronjobs ./set_expired_lost.pl 3. Notice you get output saying the number of borrowers are to be changed 4. View the borrower account from #1 and notice they have a 'Lost card' value of 'Yes' 5. Run the set_expired_lost.pl script again and observe no output is printed to the terminal - this is because all expired borrowers have already been marked as lost. Sponsored-by: Dalton McCaughey Library, Australia Signed-off-by: David Nind Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 17:49:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 15:49:16 +0000 Subject: [Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146032|0 |1 is obsolete| | --- Comment #13 from Sam Lau --- Created attachment 154223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154223&action=edit Bug 32560: (follow-up) Altered wording of output Sponsored-by: Dalton McCaughey Library, Australia Signed-off-by: David Nind Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 17:49:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 15:49:18 +0000 Subject: [Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147814|0 |1 is obsolete| | --- Comment #14 from Sam Lau --- Created attachment 154224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154224&action=edit Bug 32560: (follow-up) Replace raw SQL queries with Koha::Patrons search and update Also: - Add use Koha::Script -cron; - Add license - Add optional verbose flag - Add cronjob logging Test plan: 1. Set 'CronjobLog' syspref = 'Log' 2. Edit a borrower to have an expiration date in the past - also make sure they have 'Lost card' set to 'No' 3. Run the set_expired_lost.pl script: sudo koha-shell cd misc/cronjobs ./set_expired_lost.pl 4. Observe no output is displayed but viewing the borrower account from step #1 they now have a 'Lost card' value of 'Yes'. 5. Change the borrower account 'Lost card' back to 'No' 6. Run the set_expired_lost.pl script again, this time with the verbose flag: sudo koha-shell cd misc/cronjobs ./set_expired_lost.pl -v 7. Observe output is displayed to the commandline showing the number of borrowers that have been changed. Check the borrower account again and notice the 'Lost card' has been set back to 'Yes'. 8. Repeat step #6 and observe no output is printed to the terminal - this is because all expired borrowers have already been marked as lost. 9. Check there are log entries for set_expired_lost.pl cronjob in the action_logs table: sudo koha-mysql select * from action_logs where script='set_expired_lost.pl'; Sponsored-by: Dalton McCaughey Library, Australia Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 17:57:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 15:57:03 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154220|0 |1 is obsolete| | --- Comment #9 from Biblibre Sandboxes --- Created attachment 154225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154225&action=edit Bug 34108: Preserve checked orders after item editing The js that buils the new row after editing expects to receive a value '_checked' indicating if theitem was selected. The 'item' variable used to create the row after edit comes from the api and doesn't include this. We need to inspect the previous html before building the new row to confirm the box wa checked To test: 1 - Create a basket with 'items created on receive' 2 - Add an order line with multiple items to it 3 - Close basket 4 - Receive shipment 5 - Add invoice information 6 - Receive through receive link in the table 7 - Check some items 8 - Click on the "Edit" link and make some change to the item 9 - Save 10 - Checkboxes have disappeared 11 - Cancel receipt 12 - Apply patch 13 - Reload the page 14 - Repeat 7-9 15 - Checkbox is preserved Signed-off-by: Sam Lau Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 17:58:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 15:58:06 +0000 Subject: [Koha-bugs] [Bug 32560] Mark expired borrowers as having lost their card In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32560 --- Comment #15 from Katrin Fischer --- This feels like a workaround for a specific use case or to achieve a certain behavior. We do have other means to lock a patron account now that is expired, either by using system preferences to block OPAC actions (BlockExpiredPatronOpacActions) or using LockExpiredDelay and cleanup_database.pl. Maybe one of these would achieve the wanted behaviour as well? You can now also create custom patron restrictions. I feel using one of those would also be a bit cleaner than using lost and give a less confusing message in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 18:01:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 16:01:15 +0000 Subject: [Koha-bugs] [Bug 34392] Run automated Stylelint fixes on staff CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34392 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 18:01:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 16:01:17 +0000 Subject: [Koha-bugs] [Bug 34392] Run automated Stylelint fixes on staff CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34392 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153926|0 |1 is obsolete| | --- Comment #2 from Sam Lau --- Created attachment 154226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154226&action=edit Bug 34392: Run automated Stylelint fixes on staff CSS This patch corrects errors raised by the new stylelint configuration in staff-global.scss. Many of the fixes were made automatically by using the "--fix" option: npx stylelint koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss --fix Some examples of errors found: - Expected single space after ":" - Expected single space after "(" - Expected single space before ")" - Expected empty line before comment - Expected no more than 1 empty line - Expected a trailing semicolon Manual fixes include replacing named colors with hex codes, combining duplicate selectors, removing empty blocks, etc. Some warnings remain: "Unexpected !important" requires more than a quick fix, if we should choose to address them. To test, apply the patch and rebuild the staff interface CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client The changes affect CSS all around the staff interface, but there should be no visible results of the patch. Everything should look correct. The stylelint check should return only warnings about "!important" npx stylelint koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 18:03:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 16:03:01 +0000 Subject: [Koha-bugs] [Bug 34136] Add ability to render a report using a notice template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34136 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154153|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 154227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154227&action=edit Bug 34136: Add ability to render a report using a notice template Sometimes it is useful to display the results of a report in a non-table format. We should be able to create notice templates to render reports. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Create a new notice template using the new "Report" option from the "New notice" pulldown. 4) In the "Print" area, paste the following template: [% FOREACH b IN data %]
[% b.surname %], [% b.firstname %]
Expiration: [% b.dateexpiry %]
ID: [% b.borrowernumber %]
[% END %] 5) Create a report with the query: SELECT * FROM borrowers 6) Once the report is saved, use the new "Run with template" option to select the template you just created. 7) Note that instead of the results being a paged table, you instead see the results rendered as cards! Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 18:21:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 16:21:51 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Sarah Cornell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 18:26:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 16:26:32 +0000 Subject: [Koha-bugs] [Bug 33895] Use template wrapper for tabs: OPAC user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33895 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Sam Lau --- Applying: Bug 33895: Use template wrapper for tabs: OPAC user summary Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 33895: Use template wrapper for tabs: OPAC user summary hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-33895-Use-template-wrapper-for-tabs-OPAC-user--VW0_jB.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 18:30:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 16:30:38 +0000 Subject: [Koha-bugs] [Bug 34472] New: Template Toolkit reference guide needed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Bug ID: 34472 Summary: Template Toolkit reference guide needed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org There are no resources that I've been able to find that clearly layout what we can use from Template Toolkit in our notices and slips. We have https://wiki.koha-community.org/wiki/Customising_Notices_and_Slips#Notice_Markup and https://wiki.koha-community.org/wiki/Notices_with_Template_Toolkit but neither clearly layout what we can use, and in which slips. These are more generalized guidelines, but if I am referencing some specific elements, it's a guessing game. And I keep coming across things to use I never heard of before, not mentioned anywhere. It would really be helpful if a wiki guide were put together to make this much clearer than it is right now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 18:31:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 16:31:43 +0000 Subject: [Koha-bugs] [Bug 27769] Advanced editor shouldn't break copying selected text with Ctrl+C In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27769 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 18:34:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 16:34:49 +0000 Subject: [Koha-bugs] [Bug 20678] Save draft records without committing them to the catalogue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20678 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov --- Comment #33 from Heather --- I just found this and it looks wonderful--it's not just useful for junior catalogers, but useful for cataloging something that could take a REALLY long time (i.e., there are items that require research, there are times when one is doing original cataloging and gets interrupted, etc.) Is it ready to test for signing-off?? --h2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 18:35:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 16:35:21 +0000 Subject: [Koha-bugs] [Bug 34323] Enhance header search icon for more options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 18:35:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 16:35:23 +0000 Subject: [Koha-bugs] [Bug 34323] Enhance header search icon for more options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34323 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153721|0 |1 is obsolete| | --- Comment #2 from Sam Lau --- Created attachment 154228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154228&action=edit Bug 34323: Enhance header search icon for more options This patch modifies header search forms which have a "more options" icon, adding a title attribute to the control and "aria-hidden" to the Font Awesome icons. I've added a bit of CSS and JS to change the appearance of the icon when it is clicked to expand the panel of options. To test, apply the patch and rebuild the staff interface CSS. - Test pages which have a "more options" icon in the search header: - Home -> Catalog search tab, with IntranetCatalogSearchPulldown enabled. - Acquisitions -> Orders search tab - Authorities -> All search tabs - Administration -> Budgets - Patrons -> Patron search tab - Serials -> Subscription search tab - On all these pages, hovering your mouse over the icon in the search form should trigger a "More options" title. - Clicking the icon should expand the panel, and the icon should be now have a highlighted style. - Clicking the icon to collapse the panel should return the icon to its original state. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 18:52:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 16:52:52 +0000 Subject: [Koha-bugs] [Bug 33363] More specific permissions for purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363 Joseph Alway changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbalway at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 19:48:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 17:48:02 +0000 Subject: [Koha-bugs] [Bug 20653] Issue expected from irregularities don't display right month In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20653 Esther Melander changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander at bywatersolu | |tions.com --- Comment #3 from Esther Melander --- Created attachment 154229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154229&action=edit Serial naming pattern passed to item record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 19:48:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 17:48:40 +0000 Subject: [Koha-bugs] [Bug 20653] Issue expected from irregularities don't display right month In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20653 --- Comment #4 from Esther Melander --- Still valid in 22.11. It also has some downstream impacts. If the serial is configured to create an item record, the name of the issue is passed to 952 $H. However, 952 $H will appear correct in the item form. Once the item form is saved, if you look at the Normal view of the biblio record, the name of the issue is incorrect. In some cases the name of the issue is duplicated. The work around is to edit the name of the issue before receiving so that the proper text is passed to the item form and saved. This also seems to correct the display issue in the item list of the Normal view of the bibliographic record. Image attached above. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 19:57:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 17:57:16 +0000 Subject: [Koha-bugs] [Bug 34088] Schema upgrade should short circuit faster if no upgrade needs to be done In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34088 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 19:57:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 17:57:18 +0000 Subject: [Koha-bugs] [Bug 34088] Schema upgrade should short circuit faster if no upgrade needs to be done In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34088 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152998|0 |1 is obsolete| | --- Comment #12 from Sam Lau --- Created attachment 154230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154230&action=edit Bug 34088: Short circuit database upgrade check If the database version and the code version are the same, we should short circuit and exit immediately. This patch adds the Koha::Installer module which can very quickly check if a db or atomic update is needed. It also moves the logic for C4::Installer::TransformToNum to Koha::Installer::TransformToNum for performance reasons. It also moves the logic for C4::Installer::get_atomic_updates to Koha::Installer::get_atomic_updates for performance reasons. Test plan: 1. Apply patch 2. Run `time koha-upgrade-schema kohadev` 3. Note that it completes in less than .1 seconds 4. To test db updates, change the database Version to a number slightly behind the code version, and run `time koha-upgrade-schema kohadev` 5. Note that the correct version update is processed 6. To test atomic updates: cp installer/data/mysql/atomicupdate/skeleton.pl \ installer/data/mysql/atomicupdate/bug_34088.pl 7. Run `time koha-upgrade-schema kohadev` 8. Note that it takes over 1 second to run and the atomic update is attempted Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 20:34:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 18:34:05 +0000 Subject: [Koha-bugs] [Bug 33895] Use template wrapper for tabs: OPAC user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33895 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 20:34:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 18:34:07 +0000 Subject: [Koha-bugs] [Bug 33895] Use template wrapper for tabs: OPAC user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33895 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152298|0 |1 is obsolete| | Attachment #152299|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 154231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154231&action=edit Bug 33895: Use template wrapper for tabs: OPAC user summary This patch updates the OPAC user summary page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and log in to the OPAC. Check these tabs on the patron summary page: - Checkouts - Relatives' checkouts - Relatives' charges - Overdues - Charges - Credits - Clubs - Test enrolling and unenrolling - Holds - Recalls - Article requests - Overdrive - Test with OverDriveCirculation enabled - Logging in, logging out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 20:34:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 18:34:09 +0000 Subject: [Koha-bugs] [Bug 33895] Use template wrapper for tabs: OPAC user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33895 --- Comment #9 from Owen Leonard --- Created attachment 154232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154232&action=edit Bug 33895: (follow-up) Build overdrive tab-pane only if OverDriveCirculation is turned on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 20:41:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 18:41:16 +0000 Subject: [Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153888|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 154233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154233&action=edit Bug 31667: Merge 'tip' and 'hint' classes This patch corrects a few instances of the use of the "tip" class and replaces them with "hint." The patch also removes the class from the staff interface CSS. To test, apply the patch and rebuild the staff interface CSS. - View a patron account and click the "Routing lists" link in the left-hand sidebar. - On the subscription routing lists page the "Search subscriptions" page label should look correct. - Go to Reports -> Catalog by item type. - The "Select none..." hint should be styled correctly. - The third instance, in the installer, is only visible if you try to install Koha using a MySQL user who doesn't have the correct privileges, so may be too much trouble to really test. A check of the patch should be adequate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 20:47:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 18:47:09 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Owen Leonard --- There's no need to remove the use of the patron-title include file. You can remove the "no_cardnumber => 1" from that line and it will work just how you want it to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 21:23:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 19:23:34 +0000 Subject: [Koha-bugs] [Bug 34467] OAI GetRecord bad encoding for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34467 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OAI GetRecord bad encoding |OAI GetRecord bad encoding |for Unimarc |for UNIMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 21:24:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 19:24:48 +0000 Subject: [Koha-bugs] [Bug 34473] New: "Holds Waiting Over..." is not matching the ReservesMaxPickupDelay syspref Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34473 Bug ID: 34473 Summary: "Holds Waiting Over..." is not matching the ReservesMaxPickupDelay syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Holds are being marked as problematic even before they reach the number of days set in the ReservesMaxPickUpDelay syspref. Library Example: The ReservesMaxPickUpDelay syspref is set to mark holds as problematic at 10 days. Today is August 3rd and yet it is showing holds with expiration dates of August 1st and August 2nd in the Holds Waiting Over 10 days tab at /cgi-bin/koha/circ/waitingreserves.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 21:48:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 19:48:18 +0000 Subject: [Koha-bugs] [Bug 34276] upgrading 23.05 to 23.05.002 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34276 beardst at rlasd.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |beardst at rlasd.net --- Comment #19 from beardst at rlasd.net --- I upgraded from 22.05 and came across this issue as well. Actually had 3 issues in the DB that I had to work through independently. For this one here is what worked, had to track down the FK that was blocking the drop of the illrequests_bibfk key ALTER TABLE illrequests DROP FOREIGN KEY illrequests_ibfk_1; ALTER TABLE illrequests DROP KEY illrequests_bibfk; After that I was able to retry the webinstall and it went through. Ran this command to see if the FK constraint was recreated. This is also the command I used to find the FK in the first place SELECT RefCons.constraint_schema, RefCons.table_name, RefCons.referenced_table_name, RefCons.constraint_name, KeyCol.column_name FROM information_schema.referential_constraints RefCons JOIN information_schema.key_column_usage KeyCol ON RefCons.constraint_schema = KeyCol.table_schema AND RefCons.table_name = KeyCol.table_name AND RefCons.constraint_name = KeyCol.constraint_name WHERE RefCons.constraint_schema = 'DATABASE_NAME'; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 22:06:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 20:06:10 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154162|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 22:07:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 20:07:16 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 22:07:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 20:07:19 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 --- Comment #6 from Laura Escamilla --- Created attachment 154234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154234&action=edit Bug 34457: Rebased added the patron's cardnumber to the hold details page Same test plan as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 22:07:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 20:07:45 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 --- Comment #7 from Laura Escamilla --- (In reply to Owen Leonard from comment #5) > There's no need to remove the use of the patron-title include file. > > You can remove the "no_cardnumber => 1" from that line and it will work just > how you want it to. Thank you, Owen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 22:09:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 20:09:34 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 22:14:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 20:14:18 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154234|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 22:56:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 20:56:25 +0000 Subject: [Koha-bugs] [Bug 33371] Add 'koha-common.service' systemd service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33371 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 22:56:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 20:56:45 +0000 Subject: [Koha-bugs] [Bug 33877] Fix teams.yaml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33877 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 22:58:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 20:58:50 +0000 Subject: [Koha-bugs] [Bug 33493] Add a filter relationship for branchtransfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33493 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00, 23.05.02 |23.11.00,23.05.02 released in| | CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 23:05:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 21:05:15 +0000 Subject: [Koha-bugs] [Bug 33786] ILL requests table pagination in patron ILL history is transposing for different patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00,22.11.07, 23.05.01 |23.11.00,23.05.01,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 23:05:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 21:05:48 +0000 Subject: [Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00,22.11.07, 23.05.01 |23.11.00,23.05.01,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 23:07:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 21:07:00 +0000 Subject: [Koha-bugs] [Bug 33236] Move C4::Suggestions::NewSuggestion to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33236 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin Somers --- Enhancement, not backporting to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 23:07:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 21:07:58 +0000 Subject: [Koha-bugs] [Bug 21983] Better handling of deleted biblios on ILL requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00,22.11.07, 23.05.01 |23.11.00,23.05.01,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 23:08:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 21:08:52 +0000 Subject: [Koha-bugs] [Bug 34473] "Holds Waiting Over..." is not matching the ReservesMaxPickupDelay syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34473 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 23:32:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 21:32:53 +0000 Subject: [Koha-bugs] [Bug 34320] Hold reordering arrows look broken after Font Awesome upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 23:33:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 21:33:45 +0000 Subject: [Koha-bugs] [Bug 34474] New: OVERDUE_FINE_DESC shows title in parenthesis Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34474 Bug ID: 34474 Summary: OVERDUE_FINE_DESC shows title in parenthesis Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Regardless of what is defined in OVERDUE_FINE_DESC, the title shows up at the end of the description in parenthesis. This is redundant if it is already defined. If this is meant to help retain some kind of link to the record, perhaps it should be turned into a button or link with the item number, so as not to repeat information. If this information is retained, even after item deletion, then maybe this needs to be explained in OVERDUE_FINE_DESC, so as to not repeat it. As is, I define everything we need to retain in the description into OVERDUE_FINE_DESC, but there is no indication of what is automatically added to the description, or any explanation as to what is retained. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 23:34:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 21:34:44 +0000 Subject: [Koha-bugs] [Bug 33961] In-built Offline circulation tool no longer working and should be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33961 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 23:49:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 21:49:21 +0000 Subject: [Koha-bugs] [Bug 25996] Changes to restrictions should be logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 23:53:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 21:53:29 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |fridolin.somers at biblibre.co | |m --- Comment #62 from Fridolin Somers --- Indeed, fix needed in installer/data/mysql/db_revs/230600006.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 3 23:59:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 21:59:46 +0000 Subject: [Koha-bugs] [Bug 28726] Add sort1 and sort2 to patron card creator patron search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28726 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00,22.11.08 |23.11.00,23.05.02,22.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 00:02:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 22:02:21 +0000 Subject: [Koha-bugs] [Bug 30860] Performance: Add option for CanBookBeReserved to return all item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30860 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7923 CC| |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 [Bug 7923] Performance omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 00:02:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 22:02:21 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30860 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30860 [Bug 30860] Performance: Add option for CanBookBeReserved to return all item values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 00:03:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 22:03:17 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #33 from Victor Grousset/tuxayo --- (In reply to Nick Clemens from comment #18) > Forgive the silly example, but "alternate: shifted" ignores punctuation and > whitespace. > > Do we want white space considered? i.e. is it correct for 'Santabna' to sort > before 'Santa clarita'? Thanks for catching this! :o --- (In reply to Heather from comment #32) > I don't think so. In > https://babel.hathitrust.org/cgi/pt?id=mdp.39015022080140&view=1up&seq=63 > Rule 12 states, "Words connected by a hyphen [...] So if I understand correctly. The current proposal should sort " " (space) after "-","," and other symbols? How much of a problem is it? The 1st problematic cases on this ticket caused the results to grouped by punctuation. Which was bad because it was randomly mixing stuff that semantically was linked and should have been together, the letters have the real meaning here. Not a hyphen. comment 18 also shows stuff mixed that splat the group of "santa " that should have stayed all together. So about sorting " " after "-" and "," => does it lead to examples of stuff that is in the wrong place as bad as the two above cases? Or is the rule more about having a standardized unambiguous order for the sake of consistency and predictability even if there was nothing semantically messed up without that rule. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 00:04:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 22:04:36 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #34 from Victor Grousset/tuxayo --- splat => split (past participle) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 00:05:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 22:05:16 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30860 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 00:05:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 22:05:16 +0000 Subject: [Koha-bugs] [Bug 30860] Performance: Add option for CanBookBeReserved to return all item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30860 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32476 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 00:07:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 22:07:05 +0000 Subject: [Koha-bugs] [Bug 32476] Add caching for relatively expensive patron methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32476 --- Comment #32 from Fridolin Somers --- I see Bug 30860 has done a similar job. We should use the same way in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 00:14:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 22:14:58 +0000 Subject: [Koha-bugs] [Bug 25996] Changes to restrictions should be logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #1 from Christopher Brannon --- Very, very bad. Much bad. Needs fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 00:54:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 22:54:07 +0000 Subject: [Koha-bugs] [Bug 34475] New: categories.pl does not show all settings for categories Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34475 Bug ID: 34475 Summary: categories.pl does not show all settings for categories Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Password strength and length are not columns that show in categories.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 01:08:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 23:08:15 +0000 Subject: [Koha-bugs] [Bug 34452] Button Update adjustments is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com --- Comment #2 from Lisette Scheer --- I believe this is related to changed made in Bug 32746. If you click the add an adjustment button and then make changes to your existing adjustment, it will let you save those, as a workaround until this is fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 01:08:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 23:08:34 +0000 Subject: [Koha-bugs] [Bug 34452] Button Update adjustments is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 [Bug 32746] Standardize structure around action fieldsets in acquisitions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 01:08:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 23:08:34 +0000 Subject: [Koha-bugs] [Bug 32746] Standardize structure around action fieldsets in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34452 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 [Bug 34452] Button Update adjustments is hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 01:09:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Aug 2023 23:09:52 +0000 Subject: [Koha-bugs] [Bug 34476] New: SyndeticsCoverImageSize needs to be split for results and details Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34476 Bug ID: 34476 Summary: SyndeticsCoverImageSize needs to be split for results and details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org We would like large images on the details page but medium on the results page. Right now we have to set both with one setting. This setting needs to be divided into two settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:08:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:08:40 +0000 Subject: [Koha-bugs] [Bug 34088] Schema upgrade should short circuit faster if no upgrade needs to be done In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34088 --- Comment #13 from David Cook --- Thanks, Sam :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:13:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:13:27 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #41 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:34:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:34:30 +0000 Subject: [Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #106 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:35:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:35:49 +0000 Subject: [Koha-bugs] [Bug 33992] Only consider the date when labelling a waiting recall as problematic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33992 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #14 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:36:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:36:43 +0000 Subject: [Koha-bugs] [Bug 34133] ILL table should be sorted by request id descending by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34133 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #11 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:40:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:40:08 +0000 Subject: [Koha-bugs] [Bug 33444] AddRenewal should take a hash of parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33444 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin Somers --- Not backporting in 23.05.x Method signature change should have a nice release note -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:42:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:42:15 +0000 Subject: [Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #33 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:43:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:43:30 +0000 Subject: [Koha-bugs] [Bug 34279] overduefinescap of 0 is ignored, but overduefinescap of 0.00 is enforced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34279 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #16 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:47:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:47:20 +0000 Subject: [Koha-bugs] [Bug 28493] Make koha-passwd display the username In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28493 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #9 from Fridolin Somers --- Small enhancement, Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:49:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:49:26 +0000 Subject: [Koha-bugs] [Bug 33105] Add vendor issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #73 from Fridolin Somers --- New feature not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:50:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:50:21 +0000 Subject: [Koha-bugs] [Bug 34321] Tidy skeleton too In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34321 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:51:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:51:17 +0000 Subject: [Koha-bugs] [Bug 34316] account->add_credit does not rethrow exception In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34316 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:52:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:52:02 +0000 Subject: [Koha-bugs] [Bug 33379] virtualshelfcontents.flags seems useless In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33379 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 03:53:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 01:53:15 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #42 from David Cook --- Sounds good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:02:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:02:14 +0000 Subject: [Koha-bugs] [Bug 33556] $c->validation should be avoided (part 1) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #30 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:03:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:03:03 +0000 Subject: [Koha-bugs] [Bug 34320] Hold reordering arrows look broken after Font Awesome upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 --- Comment #6 from Fridolin Somers --- (In reply to Fridolin Somers from comment #5) > Enhancement not pushed to 23.05.x I mean : Depends on Bug 32910 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:03:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:03:50 +0000 Subject: [Koha-bugs] [Bug 33286] 'Catalog record' should be 'Bibliographic record' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:05:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:05:08 +0000 Subject: [Koha-bugs] [Bug 34334] 'Item(s)' in MARC detail view untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:07:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:07:09 +0000 Subject: [Koha-bugs] [Bug 34332] Syntax error in point of sale email template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34332 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |24381 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:07:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:07:09 +0000 Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34332 [Bug 34332] Syntax error in point of sale email template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:07:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:07:29 +0000 Subject: [Koha-bugs] [Bug 34332] Syntax error in point of sale email template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34332 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:09:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:09:19 +0000 Subject: [Koha-bugs] [Bug 34213] False POD for matchpoint option in import_patrons.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34213 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #4 from Fridolin Somers --- More a fix than enhancement I'd say ;) Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:09:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:09:58 +0000 Subject: [Koha-bugs] [Bug 32711] Add biblio details to trusted self-checkout modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32711 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #20 from Fridolin Somers --- Depends on Bug 30979 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:11:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:11:09 +0000 Subject: [Koha-bugs] [Bug 34280] Patrons with no email address produce a warning when saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:11:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:11:50 +0000 Subject: [Koha-bugs] [Bug 34280] Patrons with no email address produce a warning when saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:11:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:11:50 +0000 Subject: [Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 [Bug 34280] Patrons with no email address produce a warning when saving -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:12:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:12:50 +0000 Subject: [Koha-bugs] [Bug 34280] Patrons with no email address produce a warning when saving In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34280 --- Comment #9 from Fridolin Somers --- Looks like this has been added by Bug 29046 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:13:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:13:46 +0000 Subject: [Koha-bugs] [Bug 33978] Adding authority from automatic linker closes imported record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33978 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:15:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:15:23 +0000 Subject: [Koha-bugs] [Bug 33964] Use Email::Sender::Transport::SMTP::Persistent for sending email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33964 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #26 from Fridolin Somers --- More enhancement no ? Can this be backported ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:22:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:22:36 +0000 Subject: [Koha-bugs] [Bug 34169] Add validation for monetary input fields in acquisition module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34169 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #21 from Fridolin Somers --- Long lasting bug I gladly backport. Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:24:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:24:01 +0000 Subject: [Koha-bugs] [Bug 34226] Format dates from DT filters before querying the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34226 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #20 from Fridolin Somers --- Enhancement not backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:26:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:26:01 +0000 Subject: [Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #28 from Fridolin Somers --- I prefer not to backport since it is about passwords ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 04:28:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 02:28:41 +0000 Subject: [Koha-bugs] [Bug 34258] Cannot renew item via SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34258 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #14 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 05:33:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 03:33:17 +0000 Subject: [Koha-bugs] [Bug 28413] background job worker is running with all the modules in RAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28413 --- Comment #23 from David Cook --- I reckon we could keep reducing the memory footprint on background_jobs_worker.pl. When you have a lot of instances with at least 2 of those workers, the memory usage does add up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 05:33:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 03:33:43 +0000 Subject: [Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27267 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 [Bug 27267] Create more efficient daemon for indexing Zebra -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 05:33:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 03:33:43 +0000 Subject: [Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28410 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 [Bug 28410] [Omnibus] Reduce memory footprint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 05:34:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 03:34:40 +0000 Subject: [Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 --- Comment #20 from David Cook --- I need to revisit this one at some point. I had forgotten to enable it on one of my servers, and I just saved so much reserved memory as a result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 05:39:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 03:39:34 +0000 Subject: [Koha-bugs] [Bug 34477] New: Further reduce memory usage for idle background job worker Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34477 Bug ID: 34477 Summary: Further reduce memory usage for idle background job worker Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org While bug 28413 reduced the amount of memory used by background job worker, I think that we can reduce it further yet. I'm seeing a lot of workers around 56MB RES and 104MB VIRT at the moment (although there are some smaller ones). Multiple that for multiple workers across multiple instances, and it adds up pretty quickly. Contrast that with bug 27267 where I've got an idle Zebra indexer that uses 7MB RES and 12MB VIRT. That scales up much nicer. Anyway, not a burning issue, but it would be useful to do sometime down the track. It could be an easy win for server resource usage. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 05:39:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 03:39:44 +0000 Subject: [Koha-bugs] [Bug 28410] [Omnibus] Reduce memory footprint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34477 [Bug 34477] Further reduce memory usage for idle background job worker -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 05:39:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 03:39:44 +0000 Subject: [Koha-bugs] [Bug 34477] Further reduce memory usage for idle background job worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34477 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28410 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28410 [Bug 28410] [Omnibus] Reduce memory footprint -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 06:45:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 04:45:30 +0000 Subject: [Koha-bugs] [Bug 23861] Add authorised value categories description option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23861 --- Comment #5 from Ray Delahunty --- I am passionate about documenting as I go, so it would be great to be able to add descptions to AVs. We have created dozens, for 'subject funds' below funds, and lots of various fiscal periods for use in report date range selectors, and others besides. Documenting these briefly would help colleagues understand where/how/why these are used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 08:00:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 06:00:43 +0000 Subject: [Koha-bugs] [Bug 33745] Speed up Koha::Object attribute accessors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33745 --- Comment #43 from Marcel de Rooy --- (In reply to Fridolin Somers from comment #41) > Enhancement not pushed to 23.05.x Not sure about that choice ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 08:55:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 06:55:28 +0000 Subject: [Koha-bugs] [Bug 34204] Koha user needs to be able to login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #3 from Jonathan Druart --- Make bookworm unusable in ktd. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 09:00:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 07:00:38 +0000 Subject: [Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 09:00:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 07:00:40 +0000 Subject: [Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154233|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers --- Created attachment 154236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154236&action=edit Bug 31667: Merge 'tip' and 'hint' classes This patch corrects a few instances of the use of the "tip" class and replaces them with "hint." The patch also removes the class from the staff interface CSS. To test, apply the patch and rebuild the staff interface CSS. - View a patron account and click the "Routing lists" link in the left-hand sidebar. - On the subscription routing lists page the "Search subscriptions" page label should look correct. - Go to Reports -> Catalog by item type. - The "Select none..." hint should be styled correctly. - The third instance, in the installer, is only visible if you try to install Koha using a MySQL user who doesn't have the correct privileges, so may be too much trouble to really test. A check of the patch should be adequate. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 09:01:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 07:01:15 +0000 Subject: [Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 --- Comment #6 from Fridolin Somers --- Thanks a lot Owen for the additional work ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 09:08:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 07:08:22 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr Depends on| |21828 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 09:08:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 07:08:22 +0000 Subject: [Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7923 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 [Bug 7923] Performance omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 09:15:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 07:15:57 +0000 Subject: [Koha-bugs] [Bug 21828] Improve efficiency of C4::Biblio::LinkBibHeadingsToAuthorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21828 --- Comment #4 from Andreas Roussos --- (In reply to Andreas Roussos from comment #2) > bulkmarcimport.pl seems to be the only script that is affected > the most by this, as it can potentially make an excessive number > of calls to LinkBibHeadingsToAuthorities(). Wrong script name -- I meant to write "link_bibs_to_authorities.pl". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 09:40:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 07:40:33 +0000 Subject: [Koha-bugs] [Bug 33193] Book cover image visibility depends on the order of 856 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33193 Anneli Österman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman at koha-suomi. | |fi --- Comment #2 from Anneli Österman --- Do we need to look at the q field? Could it just go through all the 856u fields? We do not use Koha's opac in Koha-Suomi's libraries so OPACDisplay856uAsImage systempreference is not ideal for us. Also the problem is in staff interface so opac syspref doesn't sound right to me. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 10:00:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 08:00:10 +0000 Subject: [Koha-bugs] [Bug 34473] "Holds Waiting Over..." is not matching the ReservesMaxPickupDelay syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34473 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 10:18:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 08:18:34 +0000 Subject: [Koha-bugs] [Bug 34472] Template Toolkit reference guide needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #1 from Sally --- +1 strong agree. Template Toolkit is so powerful and the work that's been done to introduce it is amazing. However, as a librarian, reading the standard Template Toolkit docs only takes you so far when you're not quite sure what is accessible in Koha and how to reach it - and you waste a lot of time experimenting. It's also causing developers to reinvent the wheel, as seen in Bug 28556 - see Martin's comments at 8/9/10: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556#c9 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 10:18:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 08:18:56 +0000 Subject: [Koha-bugs] [Bug 34472] Template Toolkit reference guide needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15278 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 10:18:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 08:18:56 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34472 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 10:19:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 08:19:30 +0000 Subject: [Koha-bugs] [Bug 34472] Template Toolkit reference guide needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15276 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 10:19:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 08:19:30 +0000 Subject: [Koha-bugs] [Bug 15276] Add documentation for Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34472 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 10:46:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 08:46:15 +0000 Subject: [Koha-bugs] [Bug 29684] Warning File not found: js/locale_data.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684 --- Comment #37 from Marcel de Rooy --- Saw this in 21.11: [WARN] Preventing $template->lang='-undef-' to be overwritten by template->{VARS}{lang}='-undef-' at /usr/share/koha/C4/Templates.pm line 118. It comes from the 'honeypot'. Undef overwritten by undef does not make me much wiser. Am I mistaken that this code looks like a bug itself? if(exists $self->{VARS}{lang}) { warn "Preventing \$template->lang='" . ($self->{vars}{lang}//'-undef-') . "' to be overwritten by template->{VARS}{lang}='" . ($self->{VARS}{lang}//'-undef-') . "'"; delete $self->{VARS}{lang}; } Should we replace $self->{vars}{lang} here by $vars->{lang}, which comes from $self->lang ?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 11:25:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 09:25:46 +0000 Subject: [Koha-bugs] [Bug 29324] Some files still don't have the correct license statement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29324 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153924|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy --- Created attachment 154240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154240&action=edit Bug 29324: (QA follow-up) Polishing Making the verbose output a bit more manageable with -v option. If we just run the test, we get the total of files with license problems. Added Koha/Schema/Result as exception. Sorts results on file name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 11:26:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 09:26:23 +0000 Subject: [Koha-bugs] [Bug 29324] Some files still don't have the correct license statement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29324 --- Comment #37 from Marcel de Rooy --- (In reply to Philip Orr from comment #35) > Hm, the way I understood the original test was that files that already have > copyright statements should still be checked (because we also want to check > for license statement problems e.g. Franklin Street or gpl v2... etc., even > if there's already a copyright statement in the file). I fixed it. Restored the old condition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 11:28:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 09:28:30 +0000 Subject: [Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #14 from Marcel de Rooy --- Processing files before patches File not found : css/staff-global.css at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 107. Processing files after patches File not found : css/staff-global.css at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 107. Please explain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 11:31:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 09:31:32 +0000 Subject: [Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 --- Comment #15 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #14) > Processing files before patches > File not found : css/staff-global.css at > /usr/share/koha/Koha/Template/Plugin/Asset.pm line 107. > > Processing files after patches > File not found : css/staff-global.css at > /usr/share/koha/Koha/Template/Plugin/Asset.pm line 107. > > > Please explain. Hmm. Dont bother. I ran build resources again ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 11:42:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 09:42:41 +0000 Subject: [Koha-bugs] [Bug 33970] We need a "backend" column in "illrequestattributes" table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33970 --- Comment #9 from Pedro Amorim --- (In reply to Pedro Amorim from comment #5) > A possible interesting follow-up would be to create a bottom section in the > "Manage request" page titled "Details from previous backend(s)", where we'd > list all illrequestattributes from backends different than the current one. > > Under the existing "Details from supplier (supplier name)" section, we'd > update this list to just show the illrequestattributes from the current > backend. Scratch this. This list is provided by the backend's metadata method, hence must be solved on the backend, not core. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 11:52:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 09:52:24 +0000 Subject: [Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 11:52:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 09:52:26 +0000 Subject: [Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154074|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy --- Created attachment 154255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154255&action=edit Bug 34269: Convert to using codes in select compares This patch updates the logic in smart rules to compare option values to codes as apposed to option texts to value descriptions. 0. Apply patch 1. Install another language in the staff interface 1. ./translate install xx-XX 2. Check the box of the language in the 'language' system preference 3. Refresh 2. Create an item type with a parent 1. Go to Administration > Item types 2. Create a new item type or modify an existing one, assigning a parent type Example: Create a 'Children's books' itemtypetype and assig 'Books' as its parent 3. Create a third item type with the same description but something added in (): Example: 'Children's books (3-5)' 3. Create a circulation rule for the parent type Example: All/Books, with 2 checkouts allowed 4. Create a circulation rule for: All/All with 3 checkouts allowed 5. In English, click on "Edit" next to the parent type rule (All/Books) --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)' 6. Modify the number of checkouts allowed (e.g. 99) --> The All/Books rule is modified 7. Switch the interface to the other language 8. Click on "Edit" next to the parent type rule (All/Books) --> The All/Books rule is modified 9. Add rules for Children's books and Children's books (3-5) 10. Click on "Edit" next to each rule and change a value --> Verify that the changed values are always saved for the correct rule Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 11:52:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 09:52:29 +0000 Subject: [Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154075|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy --- Created attachment 154256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154256&action=edit Bug 34269: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 11:52:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 09:52:42 +0000 Subject: [Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 11:57:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 09:57:36 +0000 Subject: [Koha-bugs] [Bug 34305] If actual cost is negative, wrong price will display in the acq details tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34305 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 11:57:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 09:57:38 +0000 Subject: [Koha-bugs] [Bug 34305] If actual cost is negative, wrong price will display in the acq details tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34305 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153621|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 154257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154257&action=edit Bug 34305: Account for negative prices on acq details tab The acquisition detail tab shows the estimated cost while the order is still pending and the actual price, once received. At least the tool tip on the table header row says so. This was not working correctly. To test: * Create a basket * Create a new order line with a negative list price (credit) * Close the basket * Verify that the price shows correctly in the acquisition details tab on the record * Receive the order and enter a different negative actual price. * Reload detail view, verify it still shows the estimated price * Apply patch, restart_all * Verify now the correct actual price displays * Create another basket and order line * Verify while not yet received, it still shows the estimated price Signed-off-by: Caroline Cyr La Rose Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 11:57:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 09:57:59 +0000 Subject: [Koha-bugs] [Bug 34305] If actual cost is negative, wrong price will display in the acq details tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34305 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 12:14:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 10:14:14 +0000 Subject: [Koha-bugs] [Bug 30281] Schedule batch patron deletion and anonymization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30281 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 12:16:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 10:16:47 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 12:18:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 10:18:51 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #6 from Pedro Amorim --- I'm going to implement this differently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 12:57:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 10:57:10 +0000 Subject: [Koha-bugs] [Bug 33964] Use Email::Sender::Transport::SMTP::Persistent for sending email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33964 --- Comment #27 from Kyle M Hall --- (In reply to Fridolin Somers from comment #26) > More enhancement no ? > Can this be backported ? This fixes brokenness with using Gmail as an SMTP server for Koha, so I would consider it a bug fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 13:58:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 11:58:28 +0000 Subject: [Koha-bugs] [Bug 34417] ERM's breadcrumb (Vue) does not display the entity's name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34417 --- Comment #12 from Matt Blenkinsop --- Created attachment 154258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154258&action=edit Bug 34417: Add routeClass to routes and api call This patch adds a class to match the route to the API call and ensure that no items with the same property (e.g. license.name and agreement.name) can lead to incorrect breadcrumbs. Code is also moved into the get() request function to reduce the number of times it is called -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 14:03:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 12:03:46 +0000 Subject: [Koha-bugs] [Bug 34448] ERM should be able to display error messages coming from the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34448 --- Comment #8 from Jonathan Druart --- Before: Something went wrong: Error: Error: Internal Server Error (500) After: Something went wrong: Error: Error: Something went wrong, check Koha logs for details. Before: Something went wrong: Error: Not Found (404) After: Something went wrong: Error: Agreement not found Before: Something went wrong: Error: Bad Request (400) After: Something went wrong: Error: Expected integer - got string. Note for myself: """The ok read-only property of the Response interface contains a Boolean stating whether the response was successful (status in the range 200-299) or not.""" Only wondering if we should not keep the HTTP status code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 14:04:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 12:04:37 +0000 Subject: [Koha-bugs] [Bug 34448] ERM should be able to display error messages coming from the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 14:04:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 12:04:40 +0000 Subject: [Koha-bugs] [Bug 34448] ERM should be able to display error messages coming from the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154123|0 |1 is obsolete| | Attachment #154124|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 154259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154259&action=edit Bug 34448: Update cypress tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 14:04:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 12:04:43 +0000 Subject: [Koha-bugs] [Bug 34448] ERM should be able to display error messages coming from the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34448 --- Comment #10 from Jonathan Druart --- Created attachment 154260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154260&action=edit Bug 34448: Update the way we handle response in http-client.js Test plan: Before patch: - Visit a non-existent ID i.e. /cgi-bin/koha/erm/agreements/999 - Visit a char ID i.e. /cgi-bin/koha/erm/agreements/abc Apply patch: Repeat above steps. Run cypress tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 14:26:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 12:26:20 +0000 Subject: [Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 14:31:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 12:31:39 +0000 Subject: [Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 14:31:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 12:31:41 +0000 Subject: [Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154236|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 154261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154261&action=edit Bug 31667: Merge 'tip' and 'hint' classes This patch corrects a few instances of the use of the "tip" class and replaces them with "hint." The patch also removes the class from the staff interface CSS. To test, apply the patch and rebuild the staff interface CSS. - View a patron account and click the "Routing lists" link in the left-hand sidebar. - On the subscription routing lists page the "Search subscriptions" page label should look correct. - Go to Reports -> Catalog by item type. - The "Select none..." hint should be styled correctly. - The third instance, in the installer, is only visible if you try to install Koha using a MySQL user who doesn't have the correct privileges, so may be too much trouble to really test. A check of the patch should be adequate. Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 14:33:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 12:33:13 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 14:41:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 12:41:35 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 14:41:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 12:41:37 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154225|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 154262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154262&action=edit Bug 34108: Preserve checked orders after item editing The js that buils the new row after editing expects to receive a value '_checked' indicating if theitem was selected. The 'item' variable used to create the row after edit comes from the api and doesn't include this. We need to inspect the previous html before building the new row to confirm the box wa checked To test: 1 - Create a basket with 'items created on receive' 2 - Add an order line with multiple items to it 3 - Close basket 4 - Receive shipment 5 - Add invoice information 6 - Receive through receive link in the table 7 - Check some items 8 - Click on the "Edit" link and make some change to the item 9 - Save 10 - Checkboxes have disappeared 11 - Cancel receipt 12 - Apply patch 13 - Reload the page 14 - Repeat 7-9 15 - Checkbox is preserved Signed-off-by: Sam Lau Signed-off-by: Michaela Sieber Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 14:41:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 12:41:57 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 --- Comment #11 from Katrin Fischer --- Small patch, great effect - thanks a lot, Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 14:48:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 12:48:17 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #172 from Katrin Fischer --- Back for this one... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 14:48:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 12:48:26 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:07:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:07:42 +0000 Subject: [Koha-bugs] [Bug 34417] ERM's breadcrumb (Vue) does not display the entity's name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34417 --- Comment #13 from Jonathan Druart --- Created attachment 154263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154263&action=edit Bug 34417: [ALTERNATIVE PATCH] Set entity's name from the component itself I would have preferred to not modify the component to pass what we have fetched, but I think it's cleaner than hacking the low level fetch function. This is just a POC and work only on the "show agreement" view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:08:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:08:37 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:08:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:08:41 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154015|0 |1 is obsolete| | --- Comment #173 from Katrin Fischer --- Created attachment 154264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154264&action=edit Bug 27378: Introduce cookie consent to OPAC and staff client To avoid confusion around commit messages and the content of this enhancement, this first commit is a squashed commit of all the original code submited to this bug. Following a few years of inactivity, it has been rebased and re-submitted with some fixes and concept changes contained in the more recent commits. Signed-ff-by: Barry Cannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:08:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:08:45 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154016|0 |1 is obsolete| | --- Comment #174 from Katrin Fischer --- Created attachment 154265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154265&action=edit Bug 27378: (follow-up) Add missing filters (cherry picked from commit 6b8565b949b62269f6d850e6d412458d0dbcfb37) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:08:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:08:49 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154017|0 |1 is obsolete| | --- Comment #175 from Katrin Fischer --- Created attachment 154266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154266&action=edit Bug 27378: Fix accessibility issues Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:08:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:08:52 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154018|0 |1 is obsolete| | --- Comment #176 from Katrin Fischer --- Created attachment 154267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154267&action=edit Bug 27378: Update to new atomicupdate structure This patch consolidates the previous 4 database update files into one atomicupdate file in line with the new structure Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:08:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:08:56 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154019|0 |1 is obsolete| | --- Comment #177 from Katrin Fischer --- Created attachment 154268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154268&action=edit Bug 27378: Change ConsentJS to CookieConsentedJS This patch updates the name of the ConsentJS syspref to CookieConsentedJS and amends the description to be more clear what the syspref is for Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:09:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:09:00 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154020|0 |1 is obsolete| | --- Comment #178 from Katrin Fischer --- Created attachment 154269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154269&action=edit Bug 27378: Stop the codemirror editor and delete confirmation from duplicating Previously, if the "Add new code button" was clicked in the CookieConsentedJS editor, the original entry would have duplicated CodeMirror editors. This was exponential, i.e adding two new lines would result in three codemirror editors appearing on the first entry, two on the second and so on. The click event was not being applied properly and was being applied to every element with the .expand-textarea class, rather than specifically the new elements being created. The addExpandHandler function now loops through each element individually and decides whether to apply the click event handler. Similarly, the delete confirmation was dupliacting for the same reason. This has also been resolved. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:09:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:09:04 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154021|0 |1 is obsolete| | --- Comment #179 from Katrin Fischer --- Created attachment 154270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154270&action=edit Bug 27378: Remove two sysprefs and replace with html customisations Currently there are two sysprefs - CookieConsentBar and CookieConsentPopup. These allow the user to select what text they would like to see in the consent bar and modal. These have been removed and replaced with HTML customisations to allow more flexible customisations and different languages. Sponsored by: PTFS-Europe Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:09:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:09:09 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154022|0 |1 is obsolete| | --- Comment #180 from Katrin Fischer --- Created attachment 154271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154271&action=edit Bug 27378: (QA follow-up) Small fixes and tidy-ups This patch does the following: - Realphabetizes the lines in sysprefs.sql - Fixes a formatting error in patrons.pref - Adjusts the position of the cookie consent bar if the language selector is visible - Fixes translatability on the syspref modal Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:09:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:09:13 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154023|0 |1 is obsolete| | --- Comment #181 from Katrin Fischer --- Created attachment 154272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154272&action=edit Bug 27378: (QA follow-up) Allow staff to view their cookie consents This patch allows staff to view their cookie consents through a link in the dropdown menu in the navbar. Previously staff had no way of accessing their cookie consents Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:09:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:09:16 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154024|0 |1 is obsolete| | --- Comment #182 from Katrin Fischer --- Created attachment 154273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154273&action=edit Bug 27378: (QA follow-up) Add cancel button to cookie modal This patch adds a cancel button to the modal for reviewing cookie consents. Previously there was no way to exit without selecting one of the cookie options Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:09:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:09:20 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154025|0 |1 is obsolete| | --- Comment #183 from Katrin Fischer --- Created attachment 154274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154274&action=edit Bug 27378: (QA follow-up) Add filtering for OPAC only and staff only cookies This patch fixes an issue where cookies selected as OPAC only would still show in the staff client and vise versa. The cookies are now filtered and only the correct cookies will be used in the OPAC and staff client Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:09:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:09:24 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154093|0 |1 is obsolete| | --- Comment #184 from Katrin Fischer --- Created attachment 154275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154275&action=edit Bug 27378: (QA follow-up) Fix tests and character encoding This patch fixes an encoding issue when using diacritics. It also fixes a failing test, corrects the format of the "Cancel" links in the modal and perltidy has been used on all relevant files Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:09:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:09:28 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #185 from Katrin Fischer --- Created attachment 154276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154276&action=edit Bug 27378: (QA follow-up) Tidy admin/preferences.pl Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:17:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:17:40 +0000 Subject: [Koha-bugs] [Bug 34448] ERM should be able to display error messages coming from the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34448 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha at gmail. |pedro.amorim at ptfs-europe.co |com |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:18:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:18:29 +0000 Subject: [Koha-bugs] [Bug 34418] Allow empty nodes in breadcrumb's elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid at lmscloud.de --- Comment #24 from Jonathan Druart --- Paul, we need you here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:19:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:19:30 +0000 Subject: [Koha-bugs] [Bug 34417] ERM's breadcrumb (Vue) does not display the entity's name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid at lmscloud.de --- Comment #14 from Jonathan Druart --- Paul, we need you here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:19:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:19:35 +0000 Subject: [Koha-bugs] [Bug 34418] Allow empty nodes in breadcrumb's elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34418 --- Comment #25 from Jonathan Druart --- (In reply to Jonathan Druart from comment #24) > Paul, we need you here. Sorry, wrong bug, it was 34417! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:21:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:21:02 +0000 Subject: [Koha-bugs] [Bug 34453] Update background of quick spine label pop-up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34453 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:37:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:37:32 +0000 Subject: [Koha-bugs] [Bug 34453] Update background of quick spine label pop-up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34453 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:37:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:37:34 +0000 Subject: [Koha-bugs] [Bug 34453] Update background of quick spine label pop-up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34453 --- Comment #1 from Owen Leonard --- Created attachment 154277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154277&action=edit Bug 34453: Update background of quick spine label pop-up This patch updates the quick spine label popup so that the footer uses the same markup as the recently updated Z39.50 popup window in cataloging. To test, apply the patch and rebuild the staff interface CSS. Go to Cataloging -> Quick spine label creator. - Test the form with both an existing barcode and a non-existent barcode. - In the pop-up window, confirm that the footer looks correct and that the buttons in the footer, in both cases, work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:39:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:39:45 +0000 Subject: [Koha-bugs] [Bug 34435] get_password_expiry_date should not modify its parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34435 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154100|0 |1 is obsolete| | Attachment #154101|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 154278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154278&action=edit Bug 34435: Add unit test To test: prove t/db_dependent/Koha/Patron/Category.t Signed-off-by: Sam Lau Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:39:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:39:47 +0000 Subject: [Koha-bugs] [Bug 34435] get_password_expiry_date should not modify its parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34435 --- Comment #6 from Jonathan Druart --- Created attachment 154279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154279&action=edit Bug 34435: Remove side effect from get_password_expiry_date If get_password_expiry_date is passed a DateTime object as a parameter, it modifies and returns the original object. This can create possible side effects. This patch modifies get_password_expiry_date to clone the DateTime object that it receives as a parameter and return the modified clone, so that object references can be passed in safely. To test: prove t/db_dependent/Koha/Patron/Category.t Signed-off-by: Sam Lau Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:40:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:40:03 +0000 Subject: [Koha-bugs] [Bug 34453] Update background of quick spine label pop-up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34453 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34343 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 [Bug 34343] Z39.50 search background not updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:40:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:40:03 +0000 Subject: [Koha-bugs] [Bug 34343] Z39.50 search background not updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34453 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34453 [Bug 34453] Update background of quick spine label pop-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:40:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:40:48 +0000 Subject: [Koha-bugs] [Bug 34417] ERM's breadcrumb (Vue) does not display the entity's name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34417 --- Comment #15 from Matt Blenkinsop --- Passing the data from the component is for sure the cleanest method. Setting the breadcrumb from the get() function was the best method I could find for avoiding doing that but I think it will be harder to maintain if we get a lot more edge cases/more complicated routes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 15:55:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 13:55:33 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #186 from Katrin Fischer --- Ok, I think this all works now. I am really glad we found the encoding issue last round of testing, that would have bitten us badly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:18:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:18:18 +0000 Subject: [Koha-bugs] [Bug 34109] When adding items on receive, mandatory fields are not checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34109 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:18:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:18:20 +0000 Subject: [Koha-bugs] [Bug 34109] When adding items on receive, mandatory fields are not checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34109 --- Comment #1 from Nick Clemens --- Created attachment 154280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154280&action=edit Bug 34109: Check mandatory item fields when creating during recipt This patch adds a check of mandatory item fields before saving during order receipt. We check both when adding the item initially, and when submitting the order, as it will use the values from the open form. To test: * Go to administration > frameworks > ACQ > MARC structure > 952 * Set callnumber (o) or barcode (p) to mandatory * In acquisition: * Create a basket with "create items on order" and "is standing" "standing" helps as you can do multiple receives testing different things, but is optional * Add an order line * Receive shipment * Verify the mandatory fields show in the item form * Set itemtype = Music * Save with the fields blank * Item row is added, no warning * Edit the item, change the item type to blank * Click 'Confirm' for the order without closing the item edit form * Verify the item was added with itemtype Books (on sample data) and empty mandatory field * Apply patch * Repeat above, however, you should not be able to submit the item or order until mandatory fields are filled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:18:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:18:27 +0000 Subject: [Koha-bugs] [Bug 34109] When adding items on receive, mandatory fields are not checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34109 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:36:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:36:53 +0000 Subject: [Koha-bugs] [Bug 34452] Button Update adjustments is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:36:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:36:55 +0000 Subject: [Koha-bugs] [Bug 34452] Button Update adjustments is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 --- Comment #3 from Katrin Fischer --- Created attachment 154281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154281&action=edit Bug 34452: Restore fund label and 'Update adjustments' button This patch fixed 2 small and recent regressions: * The "Update adjustments" button used to always display. It's required to save a new first adjustment, but also to save changes to existing adjustments edited inline. It now would only display after "Add adjustments" was clicked. We retore to display it always. (bug 32746) * We have several "Fund" pull downs on this page, but they are for different things and require different labelling. "Fund" was changed to "Shipping fund" which matches at the top, but doesn't work for the adjustments table and single adjustment form. Now we use "Shipping fund" "Fund" and no label in the table as the table header covers it there. (bug 33721) To test. * Add a vendor * Receive shipment * Add invoice and save * Click on "Finish receiving" * Verify the button "Update adjustments" appears after clicking "Add new adjustment" * Verify the button is gone after you clicked it and the table shows * Change something in the table - no button to save change :( * Apply patch * Repeat steps, button "Update adjustments" should not always be visible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:39:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:39:40 +0000 Subject: [Koha-bugs] [Bug 34452] Button 'Update adjustments' is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Summary|Button Update adjustments |Button 'Update adjustments' |is hidden |is hidden -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:39:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:39:59 +0000 Subject: [Koha-bugs] [Bug 34452] Button 'Update adjustments' is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 [Bug 33721] Show inactive funds in invoice.tt out of order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:39:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:39:59 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34452 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 [Bug 34452] Button 'Update adjustments' is hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:41:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:41:13 +0000 Subject: [Koha-bugs] [Bug 34453] Update background of quick spine label pop-up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34453 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:41:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:41:15 +0000 Subject: [Koha-bugs] [Bug 34453] Update background of quick spine label pop-up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34453 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154277|0 |1 is obsolete| | --- Comment #2 from Sam Lau --- Created attachment 154282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154282&action=edit Bug 34453: Update background of quick spine label pop-up This patch updates the quick spine label popup so that the footer uses the same markup as the recently updated Z39.50 popup window in cataloging. To test, apply the patch and rebuild the staff interface CSS. Go to Cataloging -> Quick spine label creator. - Test the form with both an existing barcode and a non-existent barcode. - In the pop-up window, confirm that the footer looks correct and that the buttons in the footer, in both cases, work correctly. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:51:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:51:38 +0000 Subject: [Koha-bugs] [Bug 33895] Use template wrapper for tabs: OPAC user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33895 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:51:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:51:40 +0000 Subject: [Koha-bugs] [Bug 33895] Use template wrapper for tabs: OPAC user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33895 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154231|0 |1 is obsolete| | --- Comment #10 from Sam Lau --- Created attachment 154283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154283&action=edit Bug 33895: Use template wrapper for tabs: OPAC user summary This patch updates the OPAC user summary page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and log in to the OPAC. Check these tabs on the patron summary page: - Checkouts - Relatives' checkouts - Relatives' charges - Overdues - Charges - Credits - Clubs - Test enrolling and unenrolling - Holds - Recalls - Article requests - Overdrive - Test with OverDriveCirculation enabled - Logging in, logging out Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:51:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:51:43 +0000 Subject: [Koha-bugs] [Bug 33895] Use template wrapper for tabs: OPAC user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33895 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154232|0 |1 is obsolete| | --- Comment #11 from Sam Lau --- Created attachment 154284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154284&action=edit Bug 33895: (follow-up) Build overdrive tab-pane only if OverDriveCirculation is turned on Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:59:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:59:16 +0000 Subject: [Koha-bugs] [Bug 34452] Button 'Update adjustments' is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 16:59:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 14:59:18 +0000 Subject: [Koha-bugs] [Bug 34452] Button 'Update adjustments' is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154281|0 |1 is obsolete| | --- Comment #4 from Sam Lau --- Created attachment 154285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154285&action=edit Bug 34452: Restore fund label and 'Update adjustments' button This patch fixed 2 small and recent regressions: * The "Update adjustments" button used to always display. It's required to save a new first adjustment, but also to save changes to existing adjustments edited inline. It now would only display after "Add adjustments" was clicked. We retore to display it always. (bug 32746) * We have several "Fund" pull downs on this page, but they are for different things and require different labelling. "Fund" was changed to "Shipping fund" which matches at the top, but doesn't work for the adjustments table and single adjustment form. Now we use "Shipping fund" "Fund" and no label in the table as the table header covers it there. (bug 33721) To test. * Add a vendor * Receive shipment * Add invoice and save * Click on "Finish receiving" * Verify the button "Update adjustments" appears after clicking "Add new adjustment" * Verify the button is gone after you clicked it and the table shows * Change something in the table - no button to save change :( * Apply patch * Repeat steps, button "Update adjustments" should not always be visible. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:10:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:10:12 +0000 Subject: [Koha-bugs] [Bug 34109] When adding items on receive, mandatory fields are not checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34109 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:10:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:10:14 +0000 Subject: [Koha-bugs] [Bug 34109] When adding items on receive, mandatory fields are not checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34109 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154280|0 |1 is obsolete| | --- Comment #2 from Sam Lau --- Created attachment 154286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154286&action=edit Bug 34109: Check mandatory item fields when creating during recipt This patch adds a check of mandatory item fields before saving during order receipt. We check both when adding the item initially, and when submitting the order, as it will use the values from the open form. To test: * Go to administration > frameworks > ACQ > MARC structure > 952 * Set callnumber (o) or barcode (p) to mandatory * In acquisition: * Create a basket with "create items on order" and "is standing" "standing" helps as you can do multiple receives testing different things, but is optional * Add an order line * Receive shipment * Verify the mandatory fields show in the item form * Set itemtype = Music * Save with the fields blank * Item row is added, no warning * Edit the item, change the item type to blank * Click 'Confirm' for the order without closing the item edit form * Verify the item was added with itemtype Books (on sample data) and empty mandatory field * Apply patch * Repeat above, however, you should not be able to submit the item or order until mandatory fields are filled Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:13:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:13:42 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:17:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:17:30 +0000 Subject: [Koha-bugs] [Bug 15278] Port default slips and notices from bespoke syntax to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #9 from Christopher Brannon --- I would also like to see this move forward. We have little documentation to work with, and are at the mercy of developers to give us nuggets of information on TT coding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:21:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:21:08 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:21:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:21:11 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 --- Comment #3 from Katrin Fischer --- Created attachment 154287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154287&action=edit Bug 34469: Block editing for received order lines When an already received order line is modified/edited, we experience data loss. Most prominently, we will lose the linked invoiceid. Therefore we should not allow editing an order line that was already received. If something needs to be changed, the receipt should be cancelled first. To test: * Create basket as standing order with items added in cataloguing * Add an order line * Receive shipment * Go to the basket summary page, click on 'Modify' * Change the actual cost * Save * Verify that the invoice is now empty * In the database aqorders.invoiceid will be NULL * Apply patch * Receive another shipment for the standing order * Go back to basket summary page * Verify the 'Modify' link is no longer present * Click 'Modify' on the unreceived order line * Edit the URL parameter odernumber to have the number of an already received order line * Verify you see a nice error message: This order cannot be edited, the basket is closed or the order was already received. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:28:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:28:14 +0000 Subject: [Koha-bugs] [Bug 34036] Single receive doesn't reload data and order lines appears as pending In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 --- Comment #1 from Katrin Fischer --- I just tested this again and it looks like the "Pending orders" table reloads, updating the Quantity if you do a partial receive, but the "Already received" table is not updated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:33:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:33:49 +0000 Subject: [Koha-bugs] [Bug 34036] Single receive doesn't reload data and order lines appears as pending In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 --- Comment #2 from Katrin Fischer --- It looks like the "Already received" is not yet API driven, but in this case we need to force a page reload maybe? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:36:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:36:58 +0000 Subject: [Koha-bugs] [Bug 34036] Single receive doesn't reload data and order lines appears as pending In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34036 --- Comment #3 from Katrin Fischer --- ... or make it API driven, but that's the harder fix. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:40:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:40:39 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:40:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:40:41 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154287|0 |1 is obsolete| | --- Comment #4 from Sam Lau --- Created attachment 154288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154288&action=edit Bug 34469: Block editing for received order lines When an already received order line is modified/edited, we experience data loss. Most prominently, we will lose the linked invoiceid. Therefore we should not allow editing an order line that was already received. If something needs to be changed, the receipt should be cancelled first. To test: * Create basket as standing order with items added in cataloguing * Add an order line * Receive shipment * Go to the basket summary page, click on 'Modify' * Change the actual cost * Save * Verify that the invoice is now empty * In the database aqorders.invoiceid will be NULL * Apply patch * Receive another shipment for the standing order * Go back to basket summary page * Verify the 'Modify' link is no longer present * Click 'Modify' on the unreceived order line * Edit the URL parameter odernumber to have the number of an already received order line * Verify you see a nice error message: This order cannot be edited, the basket is closed or the order was already received. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:41:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:41:48 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 --- Comment #5 from Laura Escamilla --- Hi Katrin, Thank you so much for working on this patch! In testing, everything was working as described until these steps: * Click 'Modify' on the unreceived order line * Edit the URL parameter ordernumber to have the number of an already received order line. When I edited the URL parameter with an order number that was already received, it let me make modifications without receiving an error message. I then confirmed that the received item line was removed from the invoice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:44:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:44:37 +0000 Subject: [Koha-bugs] [Bug 34443] Spelling: Patron search pop-up Sort1: should be Sort 1: In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34443 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:45:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:45:27 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:46:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:46:38 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:51:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:51:38 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Christopher Brannon --- I'm getting a merge failure in the sandbox on this bug. TASK [Apply bug 33462 via git-bz in docker container] ************************** fatal: [localhost -> koha-bug33462]: FAILED! => {"changed": true, "cmd": "koha-shell -c 'cd /kohadevbox/koha && yes | git bz apply 33462' bug33462", "delta": "0:00:03.143844", "end": "2023-08-04 15:49:21.744724", "msg": "non-zero return code", "rc": 1, "start": "2023-08-04 15:49:18.600880", "stderr": "error: Failed to merge in the changes.\nhint: Use 'git am --show-current-patch=diff' to see the failed patch\nPatch left in /tmp/Bug-33462-Unit-Tests-4t46gml6.patch", "stderr_lines": ["error: Failed to merge in the changes.", "hint: Use 'git am --show-current-patch=diff' to see the failed patch", "Patch left in /tmp/Bug-33462-Unit-Tests-4t46gml6.patch"], "stdout": "\nBug 33462 - Force password change for new patrons entered by staff\n\n153687 - Bug 33462: Unit Tests\n153688 - Bug 33462: Update Schema Files [DO NOT PUSH]\n153689 - Bug 33462: Add ability to force password change for new patrons entered by staff\n\nApply? [(y)es, (n)o, (i)nteractive] Applying: Bug 33462: Unit Tests\nUsing index info to reconstruct a base tree...\nM\tt/db_dependent/Koha/Patron.t\nFalling back to patching base and 3-way merge...\nAuto-merging t/db_dependent/Koha/Patron.t\nCONFLICT (content): Merge conflict in t/db_dependent/Koha/Patron.t\nPatch failed at 0001 Bug 33462: Unit Tests\nWhen you have resolved this problem run \"git bz apply --continue\".\nIf you would prefer to skip this patch, instead run \"git bz apply --skip\".\nTo restore the original branch and stop patching run \"git bz apply --abort\".", "stdout_lines": ["", "Bug 33462 - Force password change for new patrons entered by staff", "", "153687 - Bug 33462: Unit Tests", "153688 - Bug 33462: Update Schema Files [DO NOT PUSH]", "153689 - Bug 33462: Add ability to force password change for new patrons entered by staff", "", "Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 33462: Unit Tests", "Using index info to reconstruct a base tree...", "M\tt/db_dependent/Koha/Patron.t", "Falling back to patching base and 3-way merge...", "Auto-merging t/db_dependent/Koha/Patron.t", "CONFLICT (content): Merge conflict in t/db_dependent/Koha/Patron.t", "Patch failed at 0001 Bug 33462: Unit Tests", "When you have resolved this problem run \"git bz apply --continue\".", "If you would prefer to skip this patch, instead run \"git bz apply --skip\".", "To restore the original branch and stop patching run \"git bz apply --abort\"."]} Sam, can you please check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 17:53:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 15:53:11 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #35 from Heather --- Hi! I think it would be an OK fix if it sorts " "(space) after hyphens and other punctuation, because that is clear to the user. It may not comply exactly to Library of Congress Filing Rules, but Koha is for the whole world and not everyone wants to comply with Library of Congress Filing Rules! A fix is NEEDED to make it better, and this would be better. I think it is for a developer to say if it is easier and quicker to make this patch comply to Library of Congress Filing Rules (i.e., treat hyphens, commas, etc. as spaces) NOW and delay the fix, or just get this fix out there to make it better now and create another bug to let the library decide if they want spaces sorted after hyphens & other punctuation, or to have hyphens & commas & such treated as spaces in the sorting (via a new syspref?). --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:06:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:06:46 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154034|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:06:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:06:49 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154035|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:06:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:06:59 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154036|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:07:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:07:03 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154037|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:07:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:07:32 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:07:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:07:35 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #7 from Pedro Amorim --- Created attachment 154289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154289&action=edit Bug 34431: Allow for x-koha-embed in ill/backends endpoint -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:07:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:07:38 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #8 from Pedro Amorim --- Created attachment 154290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154290&action=edit Bug 34431: Show both status and status_alias - if exists - in table column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:07:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:07:41 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #9 from Pedro Amorim --- Created attachment 154291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154291&action=edit Bug 34431: Add a status_alias filter input, if any status_alias exist This patch also makes it so that the status input filter is enabled by default, and shows all existing statuses by default, or all existing statuses for a specific backend, if and when selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:07:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:07:44 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #10 from Pedro Amorim --- Created attachment 154292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154292&action=edit Bug 34431: Update tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:09:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:09:04 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 --- Comment #6 from Michaela Sieber --- (In reply to Laura Escamilla from comment #5) > > When I edited the URL parameter with an order number that was already > received, it let me make modifications without receiving an error message. I > then confirmed that the received item line was removed from the invoice. Hi Laura, I tried to reproduce that in a sandbox and there is an error message : "This order cannot be edited, the basket is closed or the order was already received." Please have a look here: http://staff-b34469.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=3&booksellerid=1&basketno=2 Acq Log is active and there is a SQL-Report for aqorders. I also checked the use case described in bug 34254 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:09:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:09:32 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 --- Comment #7 from Katrin Fischer --- (In reply to Laura Escamilla from comment #5) > Hi Katrin, > > Thank you so much for working on this patch! > > In testing, everything was working as described until these steps: > * Click 'Modify' on the unreceived order line > * Edit the URL parameter ordernumber to have the number of an > already received order line. > > When I edited the URL parameter with an order number that was already > received, it let me make modifications without receiving an error message. I > then confirmed that the received item line was removed from the invoice. Hi Laura, that's not nice! It looks like I committed all changes and it worked for me (on the other computer) - I'll retest, but maybe you could confirm that you did a restart_all before testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:10:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:10:47 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 --- Comment #8 from Katrin Fischer --- Now I overlapped with Michaela also testing - glad to see the acq bugs getting so much attention :) Hope we can resolve! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:12:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:12:59 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 --- Comment #9 from Michaela Sieber --- Created attachment 154293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154293&action=edit Error Message order cannot be edited, the order was already received. Message: order cannot be edited, the basket is closed or the order was already received. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:14:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:14:49 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154288|0 |1 is obsolete| | --- Comment #10 from PTFS Europe Sandboxes --- Created attachment 154294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154294&action=edit Bug 34469: Block editing for received order lines When an already received order line is modified/edited, we experience data loss. Most prominently, we will lose the linked invoiceid. Therefore we should not allow editing an order line that was already received. If something needs to be changed, the receipt should be cancelled first. To test: * Create basket as standing order with items added in cataloguing * Add an order line * Receive shipment * Go to the basket summary page, click on 'Modify' * Change the actual cost * Save * Verify that the invoice is now empty * In the database aqorders.invoiceid will be NULL * Apply patch * Receive another shipment for the standing order * Go back to basket summary page * Verify the 'Modify' link is no longer present * Click 'Modify' on the unreceived order line * Edit the URL parameter odernumber to have the number of an already received order line * Verify you see a nice error message: This order cannot be edited, the basket is closed or the order was already received. Signed-off-by: Sam Lau Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:19:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:19:23 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #11 from Michaela Sieber --- status back to signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:45:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:45:51 +0000 Subject: [Koha-bugs] [Bug 34479] New: Clear saved patron search selections after certain actions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Bug ID: 34479 Summary: Clear saved patron search selections after certain actions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: cslone at camdencountylibrary.org, gmcharlt at gmail.com, kyle.m.hall at gmail.com, testopia at bugs.koha-community.org Depends on: 29971 +++ This bug was initially created as a clone of Bug #29971 +++ (In reply to Chris Slone from comment #17) > I think this is a problematic implementation, as it seems to be retaining > the selected patrons even after you perform a function (merge patrons, > create a list, do a batch edit) and do a completely new search. This means > that the previously selected patrons remain selected even when it doesn't > really make logical sense. It's great to be able to select multiple patrons > across different searches, but doing something like merging accounts should > absolutely clear out that selection. > > It seems to already be causing some issues, see this ticket: > > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 > > We've also had some errors at our library from this (before we realized what > was happening). I'm moving this issue into a new bug report because we don't re-open bugs for features which have been pushed. This will let us have a discussion about refining the behavior. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 [Bug 29971] Remember selections across patron search pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:45:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:45:51 +0000 Subject: [Koha-bugs] [Bug 29971] Remember selections across patron search pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34479 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 [Bug 34479] Clear saved patron search selections after certain actions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:47:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:47:37 +0000 Subject: [Koha-bugs] [Bug 29971] Remember selections across patron search pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #18 from Owen Leonard --- (In reply to Chris Slone from comment #17) > I think this is a problematic implementation I created bug 34479 to discuss possible solutions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:47:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:47:37 +0000 Subject: [Koha-bugs] [Bug 28366] Add batch patron modification to patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28366 Bug 28366 depends on bug 29971, which changed state. Bug 29971 Summary: Remember selections across patron search pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:47:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:47:38 +0000 Subject: [Koha-bugs] [Bug 33263] selenium/patrons_search.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33263 Bug 33263 depends on bug 29971, which changed state. Bug 29971 Summary: Remember selections across patron search pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:47:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:47:38 +0000 Subject: [Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Bug 34479 depends on bug 29971, which changed state. Bug 29971 Summary: Remember selections across patron search pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 18:47:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 16:47:38 +0000 Subject: [Koha-bugs] [Bug 31566] 'Patrons selected' counter doubles on 'Select all' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566 Bug 31566 depends on bug 29971, which changed state. Bug 29971 Summary: Remember selections across patron search pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:01:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:01:16 +0000 Subject: [Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 --- Comment #29 from Katrin Fischer --- (In reply to Fridolin Somers from comment #28) > I prefer not to backport since it is about passwords ;) It would be nice if you could reconsider. This brings this API in line and is more a bug fix than an enhancement I feel. The API is also very new still, so better to change it earlier than later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:01:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:01:23 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 --- Comment #10 from Sam Lau --- Hi Christopher, thanks for trying to test! Were you using ByWater's sandbox? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:03:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:03:11 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 --- Comment #12 from Laura Escamilla --- (In reply to Michaela Sieber from comment #11) > status back to signed Off My apologies, Katrin! I missed that pesky restart_all step! It works as expected and I did in fact get the error message. Thank you again for working on this patch so quickly! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:09:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:09:03 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 --- Comment #13 from Katrin Fischer --- (In reply to Laura Escamilla from comment #12) > (In reply to Michaela Sieber from comment #11) > > status back to signed Off > > My apologies, Katrin! I missed that pesky restart_all step! It works as > expected and I did in fact get the error message. > > Thank you again for working on this patch so quickly! Glad that resolved it :) And very happy to be able to kill an evil bug! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:12:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:12:29 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Sam Lau --- (In reply to Sam Lau from comment #10) > Hi Christopher, thanks for trying to test! Were you using ByWater's sandbox? I tried applying patch on the testing docker and everything was still applying cleanly. I then tried going to the sandbox (I used ByWater) and after applying it and I did end up getting the same message as you in the provision logs. I'm not sure what the issue is (not very familiar with the sandbox) but I asked Kyle Hall for help and we are both hoping the issue is fixed now. I would say give it another shot (I think Kyle created a sandbox for this bug) and if it still doesn't work let me know and then maybe try another sandbox? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:31:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:31:15 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:31:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:31:17 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 --- Comment #8 from Laura Escamilla --- Created attachment 154295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154295&action=edit Bug 34457: Added cardnumber view to hold details page Test plan: 1. Go to place a hold on a patron 2. The hold details page (/cgi-bin/koha/reserve/request.pl) only shows the patron’s name. 3. Apply the patch 4. The hold details page now shows the patron’s name and their card number. 5. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:34:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:34:22 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 --- Comment #12 from Sam Lau --- Everything looks like it is working good on PTFS Europe sandbox so maybe try that one out! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:45:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:45:43 +0000 Subject: [Koha-bugs] [Bug 7132] Check for duplicates when creating a new record in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7132 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|no duplicate checking |Check for duplicates when |unless ordering from Z |creating a new record in |target |acquisitions -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:47:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:47:51 +0000 Subject: [Koha-bugs] [Bug 7152] Koha should make it easy for librarians to attach covers using Open Library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7152 --- Comment #19 from Katrin Fischer --- (In reply to Noufal Ibrahim from comment #18) > I'm refactoring parts of the OL import system to support this. There's some > non trivial work from our end. I'll keep this bug posted with the details. I see this bug has been sitting for a while. Maybe we could get an update on the status of these changes? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:53:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:53:27 +0000 Subject: [Koha-bugs] [Bug 7170] Remove use of XML::Simple In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 --- Comment #24 from Katrin Fischer --- It looks like while some where fixed, others were added: C4/Auth_with_ldap.pm:XML::Simple() C4/External/BakerTaylor.pm C4/ILSDI/Services.pm C4/SIP/README C4/SIP/Sip/Configuration.pm C4/Search.pm C4/Search/PazPar2.pm C4/XISBN.pm Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm cpanfile labels/label-create-xml.pl misc/bin/connexion_import_daemon.pl misc/maintenance/generate_MARC21Languages.pl opac/ilsdi.pl patroncards/create-pdf.pl patroncards/edit-layout.pl svc/authentication svc/bib svc/bib_framework svc/bib_profile svc/import_bib svc/new_bib t/Biblio/TransformHtmlToXml.t t/db_dependent/OAI/Server.t t/db_dependent/www/auth_values_input_www.t t/db_dependent/www/batch.t t/db_dependent/www/history.t t/db_dependent/www/search_utf8.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:54:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:54:55 +0000 Subject: [Koha-bugs] [Bug 7236] Add "Save as RDF" option to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7236 --- Comment #1 from Katrin Fischer --- Magnus, do you still plan to implement this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:55:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:55:22 +0000 Subject: [Koha-bugs] [Bug 7292] New permission for claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7292 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|new permission for claims |New permission for claims -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 19:55:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 17:55:53 +0000 Subject: [Koha-bugs] [Bug 7335] Allow custom parameters for sorting in SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7335 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow custom parameters for |Allow custom parameters for |sorting in sql reports |sorting in SQL reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 20:07:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 18:07:48 +0000 Subject: [Koha-bugs] [Bug 7385] Enrich OPAC with wikipedia content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7385 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Katrin Fischer --- I think the correct link would be https://www.openbib.org/, but I didn't find anything on a Wikipedia integration. This bug is 12 years old, I suspect things have moved on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 20:10:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 18:10:42 +0000 Subject: [Koha-bugs] [Bug 7414] Analytics records need to use indicators to determine display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7414 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > Is the note field $i in this case? Hi Heather, can you maybe help me out understanding the documentation here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 20:13:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 18:13:16 +0000 Subject: [Koha-bugs] [Bug 7464] Add ability to automatically add ISBD punctuation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7464 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to |Add ability to |automatically add |automatically add ISBD |punctuation |punctuation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 20:20:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 18:20:25 +0000 Subject: [Koha-bugs] [Bug 34480] New: Reduce DB calls when importing patrons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34480 Bug ID: 34480 Summary: Reduce DB calls when importing patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org sub check_branch_code { sub check_borrower_category { Both do a search of the db based on the values in the import file for each borrower - it seems we could lookup the allowed values once and cache them? We also fetch the category another time to get the expiratoin date, it feels like we could store these early on. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 20:35:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 18:35:54 +0000 Subject: [Koha-bugs] [Bug 7414] Analytics records need to use indicators to determine display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7414 --- Comment #3 from Heather --- Hi, Katrin! Of course! This is the relevant documentation: https://www.loc.gov/marc/bibliographic/bd760787.html And I think Koha already does this correctly, but I haven't tested *all* the fields. This is the way the indicators work: First indicator: 0 = do not display a note 1 = display a note (This usually means to a system, "display a 500 note in addition to displaying the 7XX linking entry field," so most often it's set to zero, because the 7XX linking entry field has all the relevant information in it--and the link!) Second indicator controls the display of default words or phrases about the relationship between the bibs being linked, and you will see in the MARC documentation above a list of "display constants" (i.e., default display words and phrases) that can be chosen. For all fields except 780 and 785, the second indicator can also be set to 8 which will allow the display of a note from the free text entered into $i. (This is how $i is used.) A very common implementation of this are the 776 fields on related print and online versions of books; it wouldn't be helpful to use the display constant "Available in another form" because that doesn't tell you *what* the other form is, so the 776s usually look something like this: On the printed book record: 776 08 $i Online version $a Hobb, Robin. $t Mad ship $w (OCoLC)1234567 On the ebook version: 776 08 $i Print version $a Hobb, Robin. $t Mad ship $w (OCoLC)7654321 This is a bib in our catalog using the very common 780 & 785, showing Koha correctly using the second indicator display constants: https://keys.bywatersolutions.com/cgi-bin/koha/opac-detail.pl?biblionumber=16159 Hope this helps--let me know if this was anywhere near what you wanted!! --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 20:37:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 18:37:24 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #50 from Katrin Fischer --- Looking at the code, I am pretty sure this has been fixed since, see also bug 29755. C4/SIP/ILS/Patron.pm: sub _fee_limit { return C4::Context->preference('noissuescharge') || 5; } # Get fines and add fines for guarantees (depends on preference NoIssuesChargeGuarantees) my $fines_amount = ($patron->account->balance > 0) ? $patron->account->non_issues_charges : 0; my $personal_fines_amount = $fines_amount; my $fee_limit = _fee_limit(); my $noissueschargeguarantorswithguarantees = C4::Context->preference('NoIssuesChargeGuarantorsWithGuarantees'); my $fines_msg = ""; my $fine_blocked = 0; my $noissueschargeguarantees = C4::Context->preference('NoIssuesChargeGuarantees'); if( $fines_amount > $fee_limit ){ $fine_blocked = 1; $fines_msg .= " -- " . "Patron blocked by fines" if $fine_blocked; } elsif ( $noissueschargeguarantorswithguarantees ) { $fines_amount += $patron->relationships_debt({ include_guarantors => 1, only_this_guarantor => 0, include_this_patron => 0 }); $fine_blocked ||= $fines_amount > $noissueschargeguarantorswithguarantees; $fines_msg .= " -- " . "Patron blocked by fines ($fines_amount) on related accounts" if $fine_blocked; } elsif ( $noissueschargeguarantees ) { if( $patron->guarantee_relationships->count ){ $fines_amount += $patron->relationships_debt({ include_guarantors => 0, only_this_guarantor => 1, include_this_patron => 0 }); $fine_blocked ||= $fines_amount > $noissueschargeguarantees; $fines_msg .= " -- " . "Patron blocked by fines ($fines_amount) on guaranteed accounts" if $fine_blocked; } } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 20:38:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 18:38:47 +0000 Subject: [Koha-bugs] [Bug 7568] Allow to change labels on patron entry page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7568 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Katrin Fischer --- I believe jQuery works really well for this use case. Closing, but please reopen if you disagree! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 20:39:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 18:39:27 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Ah OK all places use style in label tag : > git grep 'Show inactive:' koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt: koha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt: koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt: It would be better to use a class and CSS rule in staff file. For another bug report of course ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 20:52:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 18:52:16 +0000 Subject: [Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 --- Comment #30 from Fridolin Somers --- (In reply to Katrin Fischer from comment #29) > (In reply to Fridolin Somers from comment #28) > > I prefer not to backport since it is about passwords ;) > > It would be nice if you could reconsider. This brings this API in line and > is more a bug fix than an enhancement I feel. The API is also very new > still, so better to change it earlier than later. OK on it. I looks solid ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 20:53:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 18:53:47 +0000 Subject: [Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #31 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 20:55:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 18:55:03 +0000 Subject: [Koha-bugs] [Bug 7569] Add Google Transliteration tool to fields during cataloging and in advanced search in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7569 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Depends on| |26070 Resolution|--- |WONTFIX --- Comment #3 from Katrin Fischer --- It looks like we won't be able to add this: The Google Transliterate API has been deprecated by Google in 2011... (see bug 26070) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26070 [Bug 26070] Google Transliterate API has been deprecated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 20:55:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 18:55:03 +0000 Subject: [Koha-bugs] [Bug 26070] Google Transliterate API has been deprecated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7569 [Bug 7569] Add Google Transliteration tool to fields during cataloging and in advanced search in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 20:58:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 18:58:50 +0000 Subject: [Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 --- Comment #32 from Katrin Fischer --- Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:00:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:00:50 +0000 Subject: [Koha-bugs] [Bug 33964] Use Email::Sender::Transport::SMTP::Persistent for sending email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33964 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #28 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:03:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:03:53 +0000 Subject: [Koha-bugs] [Bug 7664] Library transfer limits check/uncheck all will only work for displayed libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7664 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- Closing this as I think we can assume that librarians are aware on how the datatable driven tables work by now. Please reopen if you disagree. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:06:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:06:39 +0000 Subject: [Koha-bugs] [Bug 7414] Analytics records need to use indicators to determine display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7414 --- Comment #4 from Heather --- Hi, again! Looking this over again, if the bug is only about the 773 field (which is in an analytic record), then Koha is already doing it correctly, I think. We are on 22.11.07, and this analytic record in our catalog has: 773 0_ $t Sea story annual $g 1943, cover $w (OCoLC)38923654 And Koha correctly displays the display constant: In: https://keys.bywatersolutions.com/cgi-bin/koha/opac-detail.pl?biblionumber=37701 (As do the other analytics I've looked at in our catalog.) I haven't tested this on sandboxes, though! The initial description of this bug is a little confusing, though, because the bug is titled, "Analytics records need to use indicators to determine display," and then the description talks about 78X fields--but analytic records use 773 fields to link to their "Host" (or sometimes called "Parent"). Hope this helps! --h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:13:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:13:57 +0000 Subject: [Koha-bugs] [Bug 30427] Debian packages only include release notes for Koha 3.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30427 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com --- Comment #1 from Katrin Fischer --- Could someone check on a package installation if this is still true? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:14:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:14:32 +0000 Subject: [Koha-bugs] [Bug 30427] Debian packages only include release notes for Koha 3.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30427 --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > Could someone check on a package installation if this is still true? I realize this bug is much newer than bug 7750 which mentioned it for the first time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:17:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:17:34 +0000 Subject: [Koha-bugs] [Bug 7750] Release notes for stable releases should be in Master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7750 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #5 from Katrin Fischer --- I don't believe this is true still: https://git.koha-community.org/Koha-community/Koha/src/branch/master/misc/release_notes We do have the release notes of all major releases in master, this makes sense, as the minor releases only contain backports. The release notes for these are part of the various branches. I am closing this - please reopen if you disagree! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:24:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:24:08 +0000 Subject: [Koha-bugs] [Bug 32509] Embed see-also-from headings into bibliographic records export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32509 --- Comment #7 from Fridolin Somers --- Maybe should rename Koha::RecordProcessor "EmbedSeeFromHeadings" For example "EmbedOtherHeadings" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:24:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:24:46 +0000 Subject: [Koha-bugs] [Bug 7782] Replace yes/no for cancelling holds with checkboxes and add delete link in patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7782 --- Comment #3 from Katrin Fischer --- I believe this would still be a great improvement! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:28:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:28:05 +0000 Subject: [Koha-bugs] [Bug 7865] Command line utility to BATCH load borrower pictures based on Cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7865 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |LATER --- Comment #5 from Katrin Fischer --- (In reply to Martin Renvoize from comment #4) > I had a quick go at re-basing this and updating it to current code standards > but it looks to be allot of work.. the original script doesn't pass the > basic perlcritic tests with a number of defined but unused variables and POD > errors at least. > > It also seems to use lots of modules needlessly so probably needs a rethink. > > Is anyone actually interested in this one, or should we remove it from the > queue and mark is as RESOLVED LATER or something similar? Another 3 years, no comment. Closing RESOLVED LATER as suggested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:32:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:32:43 +0000 Subject: [Koha-bugs] [Bug 7867] Use consistent terminology for username and password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #34 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 33766 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:32:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:32:43 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adrien.saurat at biblibre.com --- Comment #16 from Katrin Fischer --- *** Bug 7867 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:32:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:32:50 +0000 Subject: [Koha-bugs] [Bug 34481] New: Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34481 Bug ID: 34481 Summary: Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Like IncludeSeeFromInSearches adds see from heading in search (4xx), add a system preference IncludeSeeAlsoFromInSearches to add see also from heading (5xx). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:33:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:33:02 +0000 Subject: [Koha-bugs] [Bug 34481] Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34481 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32509 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:33:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:33:02 +0000 Subject: [Koha-bugs] [Bug 32509] Embed see-also-from headings into bibliographic records export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32509 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34481 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:37:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:37:28 +0000 Subject: [Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number generation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911 --- Comment #10 from Katrin Fischer --- Maybe instead of trying to build something configurable for an endless number of use cases, we could implement a plugin hook here instead? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:37:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:37:56 +0000 Subject: [Koha-bugs] [Bug 7912] Print acquisitions and serials claims letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7912 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Print Acquisitions and |Print acquisitions and |Serials claims letters |serials claims letters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:47:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:47:44 +0000 Subject: [Koha-bugs] [Bug 7915] Print a barcoded membership card from member detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7915 --- Comment #3 from Katrin Fischer --- I still like this idea. It could be a great workflow improvement to have a shortcut to the patron card printing tool from the patron account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:47:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:47:45 +0000 Subject: [Koha-bugs] [Bug 26994] Display list of names in alphabetical order when using the Suggestion information filter in Suggestions management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26994 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153934|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 154296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154296&action=edit Bug 26994: List names in alphabetical order in Suggestion filter Display list of names in alphabetical order when using the Suggestion information filter in Suggestions management Test plan: 1. Add different purchase suggestions from various patron's names 2. Go to Acquisition > Suggestions 3. Click on the Suggestion information filters on the left-hand side 4. Use one of these drop-down menus: "Suggested by" or, "Managed by" or "Accepted by" --> notice the list of names in menus, names aren't displayed from A to Z 5. Apply patch and refresh page 6. Redo step 4 --> notice now it's sorted alphabetically Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:48:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:48:42 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 --- Comment #1 from Katrin Fischer --- There are quite a few open bugs here still... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:49:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:49:43 +0000 Subject: [Koha-bugs] [Bug 7942] Allow modification of basket group PDF template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7942 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow modification of |Allow modification of |basket group pdf template |basket group PDF template --- Comment #1 from Katrin Fischer --- I wonder if we should not close this in favor of a new development using TT based templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 21:55:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 19:55:47 +0000 Subject: [Koha-bugs] [Bug 7967] Z39.50 client should negotiate encoding with server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #8 from Katrin Fischer --- (In reply to Pongtawat from comment #7) > > Since it seems no one else has this problem, maybe the code should be leave > as-is and this bug closed? This is the last comment from 2013. I'll close as WONTFIX. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:05:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:05:39 +0000 Subject: [Koha-bugs] [Bug 31744] Inventory tool can take a long time and never complete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152370|0 |1 is obsolete| | --- Comment #19 from Emily Lamancusa --- Created attachment 154297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154297&action=edit Bug 31744: Run inventory.pl as CGI with keep alives to prevent timeouts This patches causes inventory.pl to run as CGI instead of PSGI, since Plack::App::CGIBin buffers the whole response before sending any data to the Apache reverse proxy. This patch also causes inventory.pl to quickly output HTTP headers, and print NULL characters roughly every 5 seconds until the HTML or CSV data is ready to be printed. This prevents HTTP forward and reverse proxies from timing out waiting for data from the inventory script, which can be very slow. In the future, we will want to move inventory.pl to use background jobs, but this change makes inventory.pl usable for staff users stuck behind HTTP forward proxies with short timeouts. Test plan: 0. Apply patch 1. cp debian/templates/apache-shared-intranet-plack.conf /etc/koha/apache-shared-intranet-plack.conf 2. cp debian/templates/apache-shared.conf /etc/koha/apache-shared.conf 3. service apache2 restart 4. Go to create a SQL report from SQL /cgi-bin/koha/reports/guided_reports.pl?phase=Create%20report%20from%20SQL 5. Save a report with the following SQL: SELECT barcode FROM items where barcode <> ''; 6. Run the report 7. Download as CSV 8. Edit the CSV and remove the "barcode" heading 9. Open F12 dev tools in browser and open the "Network" tab 10. Go to http://localhost:8081/cgi-bin/koha/mainpage.pl 11. Note that mainpage.pl has a "Content-Encoding: gzip" header 12. Go to http://localhost:8081/cgi-bin/koha/tools/inventory.pl 13. Note that inventory.pl does not have a "Content-Encoding: gzip" header, while the .js and .css files do have this header. 14. Click "Choose file" and choose your barcode CSV file 15. Uncheck "Compare barcodes list to results" 16. Check "Export to CSV file" 17. Click "Submit" 18. Note that the download initially only increases in size by 1B at a time 19. Open inventory.csv with a text editor that can show symbols like Notepad++ 20. Note approximately 7 or 8 NULL characters at start of file 21. Note that CSV loads without problems in Excel or LibreOffice (ie the NULL characters are ignored) 22. Return to your browser and uncheck "Export to CSV file" 23. Click "Submit" 24. On the "Response" tab, note approximately 7 or 8 NULL characters at start of response -- 25. For bonus points, set up a reverse proxy in front of inventory.pl with a proxy timeout of 10 seconds and run an inventory job. Note that the proxy times out without the patch, and does *not* time out with the patch. Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:12:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:12:01 +0000 Subject: [Koha-bugs] [Bug 34482] New: Improve MARC21 7xx linking fields in bibliographic records [Omnibus] Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 Bug ID: 34482 Summary: Improve MARC21 7xx linking fields in bibliographic records [Omnibus] Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:12:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:12:09 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6011 [Bug 6011] 7xx fields should optionally link on standard (ISBN/ISSN/etc.) numbers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:12:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:12:09 +0000 Subject: [Koha-bugs] [Bug 6011] 7xx fields should optionally link on standard (ISBN/ISSN/etc.) numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:12:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:12:42 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7414 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7414 [Bug 7414] Analytics records need to use indicators to determine display -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:12:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:12:42 +0000 Subject: [Koha-bugs] [Bug 7414] Analytics records need to use indicators to determine display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7414 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:17:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:17:13 +0000 Subject: [Koha-bugs] [Bug 6041] Errors from _koha_modify_item are ignored in ModItem (C4/Items) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6041 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Katrin Fischer --- There is no ModItem anymore (bug 23463) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:18:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:18:00 +0000 Subject: [Koha-bugs] [Bug 6041] Errors from _koha_modify_item are ignored in ModItem (C4/Items) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6041 --- Comment #4 from Katrin Fischer --- (In reply to Katrin Fischer from comment #3) > There is no ModItem anymore (bug 23463) Nor a _koha_modify_item -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:20:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:20:12 +0000 Subject: [Koha-bugs] [Bug 31744] Inventory tool can take a long time and never complete In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31744 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |emily.lamancusa at montgomeryc | |ountymd.gov --- Comment #20 from Emily Lamancusa --- Thanks for working on this, David! We've definitely encountered the timeout error, and a keep-alive of sorts is a nice first step for improving the inventory tool! Testing notes: I performed steps 1-2 from inside KTD with elevated permissions (also, the paths in steps 1-2 are from the starting point of /kohadevbox/koha). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:21:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:21:53 +0000 Subject: [Koha-bugs] [Bug 34483] New: [Omnibus] Standardize fund pull downs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34483 Bug ID: 34483 Summary: [Omnibus] Standardize fund pull downs Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org We have a very nice fund pull down on the order receive page. * shows the budget * makes hierarchies visible * shows inactive on demand * always shows currently selected to prevent data loss * ordered alphabetically within budgets/hierarchies * select2 for easy selecting We should really have a nice fund list like this everywhere in Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:22:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:22:01 +0000 Subject: [Koha-bugs] [Bug 34483] [Omnibus] Standardize fund pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34483 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6069 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6069 [Bug 6069] Multiple level budget list on suggestions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:22:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:22:01 +0000 Subject: [Koha-bugs] [Bug 6069] Multiple level budget list on suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6069 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34483 [Bug 34483] [Omnibus] Standardize fund pull downs -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:22:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:22:11 +0000 Subject: [Koha-bugs] [Bug 6069] Multiple level budget list on suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6069 --- Comment #10 from Katrin Fischer --- I believe we should replace this with the funds list that has hierarchy levels etc as we have it on the receive screen. We should use that everywhere. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:24:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:24:45 +0000 Subject: [Koha-bugs] [Bug 6113] Keep previous IDs when importing bibliographic and authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Keep previous ids when |Keep previous IDs when |importing bibliographic and |importing bibliographic and |authority records |authority records -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:25:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:25:05 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:26:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:26:53 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:28:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:28:53 +0000 Subject: [Koha-bugs] [Bug 6129] ISSN url param for serialssolutions.com In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #20 from Katrin Fischer --- (In reply to Galen Charlton from comment #18) > (In reply to Jared Camins-Esakov from comment #17) > > Actually, never mind. This is because serialssolutions apparently provides > > records with URLs that are missing the ISSN, not for adding serialssolutions > > URLs to records that don't have that 856 yet. > > Question for the audience ... is Serials Solutions still distributing > records with (apparently) incomplete URLs? > > If so, I think a better implementation of the fixup nowadays would be as a > TT plugin. Closing this now more than 7 years after last comment. Please reopen if you disagree and can confirm that this is still an issue for libraries. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:35:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:35:08 +0000 Subject: [Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:39:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:39:44 +0000 Subject: [Koha-bugs] [Bug 6354] Show MARC labels on a per user basis while cataloguing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6354 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #2) > I wonder if this could be closed not that we also have the advanced > cataloguing editor as an option? No comment since 2019. Closing as WONTIFX, please reopen if you are still interested in seeing this feature. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:41:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:41:01 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 --- Comment #1 from Heather --- Hi! It makes me SO happy to see this!! This is the relevant documentation for the MARC21 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:44:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:44:35 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #16 from Katrin Fischer --- Moving to failed QA on the consensus that this should not be moved into HTML customizations. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:46:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:46:57 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 --- Comment #2 from Heather --- ...the MARC21 76X-78X Linking Entry Fields: https://www.loc.gov/marc/bibliographic/bd760787.html (I was so excited I mistyped and my previous comment got saved before I finished!) ByWater has created custom XSLT so that the field linking of these fields works via enabling linking on the control numbers in the $w of these fields: https://keys.bywatersolutions.com/ They are willing to share this XSLT so this linking can get into the community version, if that would help. In our catalog, selecting the hyperlinked control number in the $w of the 76X-78X Linking Entry Field executes a search on the 001 of the target record. It is not a simple search, since we, like many, many libraries, use OCLC, so our 001 fields contain OCLC numbers with prefixes--but it works! So happy to see this omnibus!!! --h2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:54:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:54:36 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 --- Comment #3 from Katrin Fischer --- Hi Heather, I had planned to add you when I have a more complete picture of open bugs concerning 7xx fields :) I think any specifics for OCLC + $w should go on a separate bug linked to this one. We might want to tie it to a new preference or similar. As I have never used OCLC, I am not aware of what needs to be done exactly, but we need to be careful not to break things for other use cases (I think union catalogs in Finland, Sweden and Germany at least are using $w these days :) ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 22:56:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 20:56:22 +0000 Subject: [Koha-bugs] [Bug 6424] Configure default sorting of result lists by material type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6424 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > I am not sure how this one could be done. I guess this would not work for > 'mixed' result lists, but only if you manage a search that brings up only > one sort of material. Still not sure how this could be implemented in a useful way and there have not been any more comments or information provided. Closing as WONTFIX, but please reopen if you think this still requires attention. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 23:03:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 21:03:27 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 --- Comment #4 from Heather --- Hi, Katrin! Specifics of linking (e.g., $w vs. $a/$t, and/or with different types of $w numbers) in a separate bug, perhaps (hopefully!) tied to a syspref makes so much sense. Thank you!!! h2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 23:22:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 21:22:24 +0000 Subject: [Koha-bugs] [Bug 6514] Save book price in different currencies (cataloging) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6514 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Katrin Fischer --- Koha will do all internal calculations using prices converted to the active currency. You could use a user defined item field (for example using uppercase letters) to store the price in foreign currency. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 23:22:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 21:22:40 +0000 Subject: [Koha-bugs] [Bug 34481] Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34481 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 23:27:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 21:27:06 +0000 Subject: [Koha-bugs] [Bug 6533] Option to exclude cover images when printing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6533 --- Comment #4 from Katrin Fischer --- (In reply to Karen Fellows from comment #2) > We have had patron requests for this as well. A downloadable or printable > reading history as well would be a great enhancement --without the book > jackets and extra stuff, just title and author. This is possible now with the export/print options on top of the table :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 23:32:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 21:32:25 +0000 Subject: [Koha-bugs] [Bug 6625] Allow Koha to use Openlibrary subject API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6625 --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #2) > API is still marked as experimental, last change was: October 12, 2010 Still unchanged. Should we close? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 23:38:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 21:38:16 +0000 Subject: [Koha-bugs] [Bug 6778] Display suggestor's name in catalog detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6778 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Katrin Fischer --- In the staff interface we have a 'suggestion details' tab now. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 4 23:40:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 21:40:00 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 00:12:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Aug 2023 22:12:36 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 --- Comment #13 from Christopher Brannon --- Yes, I did use ByWater's sandbox. I'll take a look again. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 02:14:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 00:14:48 +0000 Subject: [Koha-bugs] [Bug 34481] Add IncludeSeeAlsoFromInSearches like IncludeSeeFromInSearches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34481 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 02:25:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 00:25:09 +0000 Subject: [Koha-bugs] [Bug 31599] Add an option to disable local cover images on search results but keep them visible on item details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31599 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 02:29:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 00:29:22 +0000 Subject: [Koha-bugs] [Bug 17650] Create the option to save local cover images outside the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 02:30:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 00:30:06 +0000 Subject: [Koha-bugs] [Bug 18147] Show cover images in public lists in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18147 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 02:31:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 00:31:34 +0000 Subject: [Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 02:32:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 00:32:17 +0000 Subject: [Koha-bugs] [Bug 27167] Add Local Cover Image vs Amazon Cover Image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27167 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 02:34:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 00:34:32 +0000 Subject: [Koha-bugs] [Bug 27187] Cannot delete/update local cover image with LocalCoverImages off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27187 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 02:36:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 00:36:02 +0000 Subject: [Koha-bugs] [Bug 32514] Local cover images missing at OPAC for user checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32514 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 02:36:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 00:36:46 +0000 Subject: [Koha-bugs] [Bug 33143] Improve handling of local covers upon upload so that they don't increase in file size while decreasing in pixel size. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33143 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 02:37:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 00:37:40 +0000 Subject: [Koha-bugs] [Bug 33202] Add system preference to limit the size of local cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33202 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 02:39:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 00:39:20 +0000 Subject: [Koha-bugs] [Bug 33568] Use the REST API to display items on the biblio detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 02:40:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 00:40:59 +0000 Subject: [Koha-bugs] [Bug 33857] Reduce and resize local cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33857 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 03:29:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 01:29:34 +0000 Subject: [Koha-bugs] [Bug 26472] Elasticsearch - ES - Authority record results not ordered correctly due to punctuation marks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26472 --- Comment #36 from Victor Grousset/tuxayo --- > It may not comply exactly to Library of Congress Filing Rules, but Koha is for the whole world and not everyone wants to comply with Library of Congress Filing Rules! That wouldn't prevent someone to submit a change in another ticket to implement the Library of Congress Filing Rules. From a functional POV if there is no other convention that this would conflict with, then there wouldn't be an issue to change that last sorting rule. > I think it is for a developer to say if it is easier and quicker to make this patch comply to Library of Congress Filing Rules (i.e., treat hyphens, commas, etc. as spaces) About that, I'm not sure there is a config in ICU or Elastic that changes only what we need without messing up all the rest. For reference if someone wants to dig into that: https://www.elastic.co/guide/en/elasticsearch/plugins/7.17/analysis-icu-collation-keyword-field.html https://unicode-org.github.io/icu-docs/apidoc/released/icu4j/com/ibm/icu/text/Collator.html > or just get this fix out there to make it better now We might be in this situation. It seems getting the last detail (which isn't strictly the initial report but a thread that lead us to a clew of yarn ^^) suddenly greatly raises the time to make a working solution. Other than that, the current proposal has no known potential issue, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 06:15:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 04:15:32 +0000 Subject: [Koha-bugs] [Bug 34484] New: checkin error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34484 Bug ID: 34484 Summary: checkin error Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: yashwanth6678 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 154298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154298&action=edit after checkout the book again when the checkin given the following error occurs when i submit the checkin the following error occurs whats the next thankyou team -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 11:27:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 09:27:32 +0000 Subject: [Koha-bugs] [Bug 6892] If a URL has been entered without http://, it isn't correctly linked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6892 --- Comment #8 from Katrin Fischer --- (In reply to David Cook from comment #7) > I think bug 8609 might be a good successor to this one. Only that it was closed ages ago. - Is this still something we should look into? I assume we would not change the data, but fix anytime we create a HTML link? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 11:29:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 09:29:09 +0000 Subject: [Koha-bugs] [Bug 6948] Default hold expiry date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6948 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- This has been resolved on another bug report. We now have DefaultHoldExpirationdate to make sure holds expire. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 11:31:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 09:31:48 +0000 Subject: [Koha-bugs] [Bug 6960] staffaccess permission requires borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6960 --- Comment #8 from Katrin Fischer --- I suggest to just add a hint to the permission as an easy fix. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 11:33:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 09:33:21 +0000 Subject: [Koha-bugs] [Bug 6961] runtime parameter for fund codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6961 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34483 --- Comment #2 from Katrin Fischer --- Maybe if we do this, we should create a standard fund pull down like on the order receive page, showing the budgets and have an inactive checkbox. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34483 [Bug 34483] [Omnibus] Standardize fund pull downs -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 11:33:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 09:33:21 +0000 Subject: [Koha-bugs] [Bug 34483] [Omnibus] Standardize fund pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34483 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6961 [Bug 6961] runtime parameter for fund codes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 11:37:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 09:37:02 +0000 Subject: [Koha-bugs] [Bug 6967] Add link to suggestions when nothing is found in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6967 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Staff interface CC| |gmcharlt at gmail.com Summary|Create suggestion from |Add link to suggestions |z39.50 / existing records |when nothing is found in | |the staff interface --- Comment #2 from Katrin Fischer --- I like the idea with the link to suggestions in the staff interface still, but not so sure anymore how I envisioned the z39.50 feature to work. Changing bug for the first. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 11:41:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 09:41:57 +0000 Subject: [Koha-bugs] [Bug 14019] Streamline display of suggestions in different places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14019 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- I believe that this has improved since the bug has been filed in 2015 and the bug is also a bit too general to act. Closing invalid, but please feel free to reopen with more details! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 11:45:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 09:45:38 +0000 Subject: [Koha-bugs] [Bug 14037] Add support for itemBarcodeFallbackSearch to checkin screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14037 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No way to trigger a hold |Add support for |when using |itemBarcodeFallbackSearch |itemBarcodeFallbackSearch |to checkin screen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 11:48:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 09:48:39 +0000 Subject: [Koha-bugs] [Bug 14071] Preserve changes on XSLT files over upgrades In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14071 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Web services |Packaging CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 11:55:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 09:55:03 +0000 Subject: [Koha-bugs] [Bug 14085] Search for biblionumber in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14085 --- Comment #2 from Katrin Fischer --- This is quite an old bug, wondering if more people would find this useful still? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 11:55:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 09:55:58 +0000 Subject: [Koha-bugs] [Bug 14086] date ordered on ordered fund search doesn't match order date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14086 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14084 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 11:55:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 09:55:58 +0000 Subject: [Koha-bugs] [Bug 14084] order date language in Koha inconsistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14086 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 12:04:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 10:04:31 +0000 Subject: [Koha-bugs] [Bug 14095] Enhancing the automatic renewal checkbox on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14095 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatic Renewal |Enhancing the automatic |Enhancements |renewal checkbox on | |checkout --- Comment #9 from Katrin Fischer --- > (In reply to Owen Leonard from comment #2) > > It would be nice if the automatic renewal checkbox were checked by default > > if you were checking out to a patron who has automatic renewals turned on > > for their patron category in circulation and fine rules. > > Agreed. :) Hm, rereaading this: the reason we cannot pre-check the checkbox for a patron is simpler: We cannot foresee the itemtype of the next scanned item. The automatic renewal is set in the circulation rules and might only apply for some item types. So if we pre-checked, we'd overwrite the circulation rules checking everything out with auto-renewal.(In reply to Christopher Brannon from comment #3) (In reply to Christopher Brannon from comment #0) > Automatic renewals should put the focus back on checkout barcode textbox > after being checked or unchecked. > > It should also stay on until turned off again or a new patron is pulled up. > > It would be courteous to show automatic renewal has been applied on the > slips. These are still good ideas. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 12:07:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 10:07:27 +0000 Subject: [Koha-bugs] [Bug 14110] Silence warnings t/00-load.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #9 from Katrin Fischer --- I ran prove -v t/00-load.t on master and it's all green and without any warnings or errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 12:07:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 10:07:28 +0000 Subject: [Koha-bugs] [Bug 8879] Silence unneeded messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 Bug 8879 depends on bug 14110, which changed state. Bug 14110 Summary: Silence warnings t/00-load.t https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 12:12:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 10:12:19 +0000 Subject: [Koha-bugs] [Bug 14139] Koha showing 1 264 and it's not the first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14139 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Katrin Fischer --- I believe this is not a bug per se, but Koha trying to make a good guess on which entry being the best one to display in absence of the indicators. Also the screenshots prove that indeed the first one IS displayed. I am closing this as WORKSFORME, but please feel free to reopen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 12:13:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 10:13:23 +0000 Subject: [Koha-bugs] [Bug 14156] Add id tags to each MARC note in the display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14156 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add id tags to each marc |Add id tags to each MARC |note in the display |note in the display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 12:35:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 10:35:29 +0000 Subject: [Koha-bugs] [Bug 14174] Home suspension and / or in situ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14174 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > Hi Hector, can you explain this a bit more? Do you mean they can only do > on-site-checkouts opposite to taking items home with them? Asked in 2016, no more information has been provided. Closing INVALID for now, please reopen if you see fit! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 12:42:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 10:42:09 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency is wrong in the GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Field width for |Field width for currency is |currency.currency is |wrong in the GUI |inadequate | --- Comment #16 from Katrin Fischer --- (In reply to Jon Knight from comment #15) > > > Did anything come of this? I see the currency table in the current master is > still pretty much the same, with the currency.currency field still > varchar(10) and the new currency addition input field size set to 50. > > At the very least, could we get the field size set to 10 so that people > don't lose long currency names? Agreed. Also: changing the field width in currency would not be enough: we'd also need to update where the field is referenced in other tables, including aqorders and aqbooksellers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 12:42:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 10:42:47 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency is wrong in the GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39022|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 12:42:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 10:42:56 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency is wrong in the GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39031|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 12:43:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 10:43:08 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency is wrong in the GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 12:43:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 10:43:17 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency is wrong in the GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|indradg at l2c2.co.in |koha-bugs at lists.koha-commun | |ity.org Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 12:52:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 10:52:19 +0000 Subject: [Koha-bugs] [Bug 14212] Add 'oldip' and 'newip' to different_ip message in auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14212 --- Comment #1 from Katrin Fischer --- I could try and make this change, but is there a reason we might not want to show this information? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 12:58:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 10:58:58 +0000 Subject: [Koha-bugs] [Bug 14225] Include external library calendar / event list in Koha's search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14225 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid at lmscloud.de --- Comment #1 from Katrin Fischer --- There is a plugin for managing library events now from LMSCloud, maybe a parallel search and showing it on top of results would be an option that could be done with hooks/JS? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:01:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:01:51 +0000 Subject: [Koha-bugs] [Bug 14227] RDA toolkit integration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14227 --- Comment #4 from Katrin Fischer --- The RDA toolkit it not generally accessible, so this makes it a bit harder to think up a way to integrate it. So far, we are still missing ideas/information here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:05:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:05:17 +0000 Subject: [Koha-bugs] [Bug 14228] Fill in patron info by scanning an ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14228 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #6 from Katrin Fischer --- It looks like there is a plugin now for doing exactly this :) https://github.com/bywatersolutions/koha-plugin-drivers-license-scanner Not sure if I should close this WONTFIX or FIXED... as the plugin is strictly speaking not in Koha. I am picking MOVED :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:07:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:07:35 +0000 Subject: [Koha-bugs] [Bug 14230] Show percentages for spent/encumbered/available on fund list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14230 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|fund list show percentage |Show percentages for | |spent/encumbered/available | |on fund list --- Comment #1 from Katrin Fischer --- As more columns might cause a space issue, maybe we could add the percentage in a tooltip? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:16:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:16:35 +0000 Subject: [Koha-bugs] [Bug 14273] Add check for invalid holds linked to deleted records to inconsistencies script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds tab never loads if |Add check for invalid holds |borrower has an invalid |linked to deleted records |reserve |to inconsistencies script CC| |robin at catalyst.net.nz Component|Circulation |Command-line Utilities -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:22:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:22:00 +0000 Subject: [Koha-bugs] [Bug 14287] Preserve valid ISBN-13 identifiers if they start with something else than 978 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14287 --- Comment #16 from Katrin Fischer --- (In reply to Aleisha Amohia from comment #15) > Hi all, I think this is becoming a problem now - we have a library getting > covers through Syndetics and records with ^979 ISBNs are not fetching covers > successfully. > > Any progress on this work? I believe Mark and Olli-Antti are no longer around, so it might wait for someone to adopt and push it further. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:29:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:29:18 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #43 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #42) > (In reply to Jonathan Druart from comment #35) > > I understand from comment 29 that Sonia disagrees with the behavior of this > > patch. > > Sonia's concern can be addressed by adding an option, analogous to fines' > 'When to charge', and defaulting it to end of the interval, of course. I think we could even use the one used for fines now: "When to charge" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:31:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:31:05 +0000 Subject: [Koha-bugs] [Bug 14294] Umbrella report for tracking improvements to File upload feature (see also 6874) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14294 --- Comment #9 from Katrin Fischer --- Only 2 pending bugs remaining :) * Bug 17298 - Should uploaded files have a file description? * Bug 14282 - Add configurable http headers for retrievable uploads (see 6874) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:33:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:33:46 +0000 Subject: [Koha-bugs] [Bug 14296] Introduce upload settings, add quota and translate alerts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14296 --- Comment #13 from Katrin Fischer --- Looks like 3 bugs in one, but stuck - worth getting unstuck? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:38:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:38:37 +0000 Subject: [Koha-bugs] [Bug 14319] Support for DuoSecurity 2FA Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14319 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Katrin Fischer --- Koha now supports 2FA for the staff interface now. It's possible to use different Apps and email. The linked repository is deprecated: Deprecation Notice This repository is deprecated by Duo Security. The repository will remain public and visible, and integrations built using this repository’s code will continue to work. You can also continue to fork, clone, or pull from this repository. It looks like DuoSecurity is also not free to use. I am marking this as WONTFIX, please reopen if you disagree. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:38:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:38:37 +0000 Subject: [Koha-bugs] [Bug 20476] Two factor authentication for the staff client - omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476 Bug 20476 depends on bug 14319, which changed state. Bug 14319 Summary: Support for DuoSecurity 2FA Authentication https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14319 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:42:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:42:01 +0000 Subject: [Koha-bugs] [Bug 14323] Users who share userid and cardnumber cause Privacy Breach In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14323 --- Comment #4 from Katrin Fischer --- You should not be able to add/import these patrons unless you are using SQL, but I think we cannot prevent it on that level. Should we revive this patch set and maybe add a warning in the inconsistencies script or even on the about page? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:44:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:44:36 +0000 Subject: [Koha-bugs] [Bug 14336] SCO: Move embedded JavaScript from sco-main.tt to new sco.js file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14336 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #1 from Katrin Fischer --- Is this something we should pursue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:47:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:47:13 +0000 Subject: [Koha-bugs] [Bug 14340] 773x ISSN Index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14340 --- Comment #2 from Katrin Fischer --- I assume she meant that we should add the field to the ISSN search index. But I see some problems there: It would give you many more results when searching by ISSN in databases that include article records. What about other 7xx fields? I believe as proposed this would be a bit problematic, but maybe we could imagine having a separate "wider ISSN" index? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:48:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:48:29 +0000 Subject: [Koha-bugs] [Bug 14341] XSLT 773$x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14341 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34482 --- Comment #5 from Katrin Fischer --- I believe if we decide the ISSN/ISBN are helpful here, we might want to display it for all 7xx? Maybe with a class that allows to hide it easily? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:48:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:48:29 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14341 [Bug 14341] XSLT 773$x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:49:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:49:42 +0000 Subject: [Koha-bugs] [Bug 14347] Running overdue_notices.pl with --html flag set does not create well structured html In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14347 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 29354 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:49:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:49:42 +0000 Subject: [Koha-bugs] [Bug 29354] Make overdue_notices.pl send HTML attachment as .html In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29354 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #13 from Katrin Fischer --- *** Bug 14347 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 13:57:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 11:57:32 +0000 Subject: [Koha-bugs] [Bug 14355] Suggestions: Organize by: Library broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14355 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- I believe his has been fixed since this was filed :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 14:02:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 12:02:18 +0000 Subject: [Koha-bugs] [Bug 14379] Batch item modification tool can't change subfields stored in more_subfields_xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14379 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch item modification |Batch item modification |tool - Can't change custom |tool can't change subfields |subfields |stored in | |more_subfields_xml --- Comment #6 from Katrin Fischer --- I think if $1 is still an issue (I believe we fixed that?), than it should be on a separate bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 14:06:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 12:06:25 +0000 Subject: [Koha-bugs] [Bug 14413] Map aqorders.order_internalnote in MarcFieldsToOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14413 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|map internalnotes to |Map |MarcFieldsToOrder |aqorders.order_internalnote | |in MarcFieldsToOrder -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 14:07:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 12:07:26 +0000 Subject: [Koha-bugs] [Bug 14319] Support for DuoSecurity 2FA Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14319 --- Comment #4 from Tom Misilo --- Duo is free for up to 10 users, but it is a popular solution for MFA with business and higher education. It looks like the perl library has been replaced with https://github.com/duosecurity/duo_api_perl I don't have a horse in the race anymore, but just wanted to provided up info incase someone is looking to implement it locally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 14:42:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 12:42:54 +0000 Subject: [Koha-bugs] [Bug 14438] RTF / CSV /ODS format in Download cart option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14438 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #8 from Katrin Fischer --- (In reply to Katrin Fischer from comment #7) > Koha now offers cart downloads in ISBD and configurable CSV output since > this bus was files. Should we assume this bug as fixed? Another 3 years - closing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 14:49:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 12:49:49 +0000 Subject: [Koha-bugs] [Bug 14451] OPAC Bootstrap theme hides table headings in holdings display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14451 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |oleonard at myacpl.org --- Comment #2 from Katrin Fischer --- I just tested and in 22.11 it looks really strange. The table headings are not removed, but all overlap and the text in the cells moves to read from top to bottom... The display is unusable like this as you can't read the headers nor the content. It's much better in master - not sure what the difference is? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 14:51:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 12:51:31 +0000 Subject: [Koha-bugs] [Bug 34485] New: Holdings table in OPAC shows broken icon when displayed on small screen Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34485 Bug ID: 34485 Summary: Holdings table in OPAC shows broken icon when displayed on small screen Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org On a smaller screen you can uncollapse some information using a button. The icon on the button is broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 14:55:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 12:55:07 +0000 Subject: [Koha-bugs] [Bug 14459] Marking parts of text bold is bad for translation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14459 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- I believe we have some ways to work around this now using the more modern translation tools. I am closing this as FIXED. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 14:57:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 12:57:31 +0000 Subject: [Koha-bugs] [Bug 14460] Show in patron account which libraries an item can be returned to In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show library a book can be |Show in patron account |returned to/home |which libraries an item can |library/checkout library in |be returned to |patron account | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 14:57:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 12:57:40 +0000 Subject: [Koha-bugs] [Bug 14460] Show in OPAC patron account which libraries an item can be returned to In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show in patron account |Show in OPAC patron account |which libraries an item can |which libraries an item can |be returned to |be returned to -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 15:11:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 13:11:59 +0000 Subject: [Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41341|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 15:23:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 13:23:50 +0000 Subject: [Koha-bugs] [Bug 14558] Bulk print routing lists to save paper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14558 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 22590 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 15:23:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 13:23:50 +0000 Subject: [Koha-bugs] [Bug 22590] Allow batch printing of routing lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22590 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Katrin Fischer --- *** Bug 14558 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 15:53:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 13:53:03 +0000 Subject: [Koha-bugs] [Bug 14970] Allow changing of status for items when routing list is printed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14970 --- Comment #1 from Katrin Fischer --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 16:08:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 14:08:52 +0000 Subject: [Koha-bugs] [Bug 14933] SIPserver should not use warn or die to log errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14933 --- Comment #2 from Katrin Fischer --- No idea if this was fixed, can someone tell? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 16:16:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 14:16:24 +0000 Subject: [Koha-bugs] [Bug 14914] Circulation limits: show in greater detail which limit(s) were exceeded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14914 --- Comment #1 from Katrin Fischer --- It's a little more complicated: It could also be the overall limit that was reached, independent of itemtype. So both possibilities would need to be taken into account. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 16:17:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 14:17:53 +0000 Subject: [Koha-bugs] [Bug 14913] Item search: add limit by material type (books, serials, etc) taken from 008 MARC field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14913 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item search: add limit by |Item search: add limit by |item type (books, serials, |material type (books, |etc) taken from 008 Marc |serials, etc) taken from |field |008 MARC field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 16:27:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 14:27:38 +0000 Subject: [Koha-bugs] [Bug 14892] Initial checkin of an item to be transferred shows incorrect holding location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14892 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- We've relabelled the holdingbranch column to "Tranfer to" since. So this works well now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 16:33:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 14:33:08 +0000 Subject: [Koha-bugs] [Bug 14875] Search serials by barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14875 --- Comment #9 from Katrin Fischer --- I'd be interested to learn about the use case here. Since items are optional for subscriptions, I'd be interested to learn about the workflow here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 5 16:38:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Aug 2023 14:38:06 +0000 Subject: [Koha-bugs] [Bug 14865] Update Koha::Logger documentation based on wiki docs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14865 --- Comment #1 from Katrin Fischer --- Could it also work to add a reference to the wiki to the POD? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 6 04:23:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Aug 2023 02:23:56 +0000 Subject: [Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- > 4) Run a bunch of elastic index updates > 5) Verify you have defunct processes > If you do not see defunct processes, the test plan is to simply verify > everything continues to work as expected. Any idea what factors can help having the issue reproduced? Also, I renamed multiple times at record, that causes ES updates with a background worker, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 6 04:26:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Aug 2023 02:26:20 +0000 Subject: [Koha-bugs] [Bug 33898] background_jobs_worker.pl may leave defunct children processes for extended periods of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33898 --- Comment #10 from Victor Grousset/tuxayo --- at record => a record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 6 10:24:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Aug 2023 08:24:52 +0000 Subject: [Koha-bugs] [Bug 2894] Routing list holds are broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2894 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber at kit.edu Status|Needs Signoff |Patch doesn't apply Severity|major |normal --- Comment #16 from Michaela Sieber --- I think the idea to fix the behaviour of RoutingListAddReserves, and create item-level holds (so only if items have been created) is correct. When trying to apply patch I got the error message: "Cannot apply cleanly patches from bug 31335. Everything will be left dirty." Perhaps someone / developer could first have a look on bug 31335. As far as I understand this is about code cleaning. And there should be a new test plan. Perhaps like this: - Set systempref RoutingListAddReserves to "Place received serials on hold if they are on a routing list." - Create a new subscription, e.g. for title "Chapman" (ISSN 0308-2695) - choose to create items for the subscription on receive - Create a routing list with at least two recipients - Receive an issue and fill item form (item type) - Click on 'Print List' in column Routing - Check for holds on the biblio record > Holds are created, but those are indeed not item level. (see Holds column Details = Next available) - Apply Patch - Receive next issue with item - Click on 'Print List' in column Routing - Check for holds - Holds should be on the item level for new received serial items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 6 14:09:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Aug 2023 12:09:02 +0000 Subject: [Koha-bugs] [Bug 34486] New: Show OPAC Column Due Date only if items on loan exist Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34486 Bug ID: 34486 Summary: Show OPAC Column Due Date only if items on loan exist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: michaela.sieber at kit.edu QA Contact: testopia at bugs.koha-community.org The OPAC holdings table always has a column for Due Date even if all items are available or all items are not for loan. The Column Due Date should only appear if items on loan exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 01:18:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Aug 2023 23:18:57 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #17 from David Cook --- (In reply to Katrin Fischer from comment #16) > Moving to failed QA on the consensus that this should not be moved into HTML > customizations. We might want to re-think that. These sysprefs have security problems which will be better addressed in Additional Contents/HTML Customizations. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 01:23:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Aug 2023 23:23:48 +0000 Subject: [Koha-bugs] [Bug 30427] Debian packages only include release notes for Koha 3.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30427 --- Comment #3 from David Cook --- (In reply to Katrin Fischer from comment #1) > Could someone check on a package installation if this is still true? 100% still true for on a 22.11 install. They're totally missing from koha-testing-docker but that looks unrelated. dpkg -L koha-common | less /usr/share/doc/koha-common/release_notes_30000.txt.gz /usr/share/doc/koha-common/release_notes_30000alpha.txt.gz /usr/share/doc/koha-common/release_notes_30000beta.txt.gz /usr/share/doc/koha-common/release_notes_30000stableRC1.txt.gz /usr/share/doc/koha-common/release_notes_30001.txt.gz /usr/share/doc/koha-common/release_notes_30002.txt.gz /usr/share/doc/koha-common/release_notes_30003.txt.gz /usr/share/doc/koha-common/release_notes_30004.txt.gz /usr/share/doc/koha-common/release_notes_30005.txt.gz /usr/share/doc/koha-common/release_notes_3_10_0.txt.gz /usr/share/doc/koha-common/release_notes_3_12_0.txt.gz /usr/share/doc/koha-common/release_notes_3_14_0.txt.gz /usr/share/doc/koha-common/release_notes_3_16_0.txt.gz /usr/share/doc/koha-common/release_notes_3_18_0.txt.gz /usr/share/doc/koha-common/release_notes_3_20_0.txt.gz /usr/share/doc/koha-common/release_notes_3_22_0.txt.gz /usr/share/doc/koha-common/release_notes_3_2_0.txt.gz /usr/share/doc/koha-common/release_notes_3_4_0.txt.gz /usr/share/doc/koha-common/release_notes_3_6_0.txt.gz /usr/share/doc/koha-common/release_notes_3_8_0.txt.gz The reason is the following: grep -R "release_notes" debian/* debian/koha-common.docs:misc/release_notes/release_notes_3*.txt debian/koha-core.docs:misc/release_notes/release_notes_3*.txt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 01:24:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Aug 2023 23:24:55 +0000 Subject: [Koha-bugs] [Bug 30427] Debian packages only include release notes for Koha 3.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30427 --- Comment #4 from David Cook --- It would be an easy fix. It's just super low on the priority list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 01:36:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Aug 2023 23:36:25 +0000 Subject: [Koha-bugs] [Bug 14319] Support for DuoSecurity 2FA Authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14319 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- Duo is pretty good. I've used it before but haven't had any library demand for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 01:37:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Aug 2023 23:37:37 +0000 Subject: [Koha-bugs] [Bug 14294] Umbrella report for tracking improvements to File upload feature (see also 6874) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14294 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 02:38:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 00:38:52 +0000 Subject: [Koha-bugs] [Bug 31143] We should attempt to fix/identify all cases where '0000-00-00' may still remain in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31143 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |wainuiwitikapark at catalyst.n |ity.org |et.nz Status|NEW |ASSIGNED CC| |wainuiwitikapark at catalyst.n | |et.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 03:20:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 01:20:21 +0000 Subject: [Koha-bugs] [Bug 33492] ERM - We need EBSCO Cypress tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33492 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #5 from Victor Grousset/tuxayo --- (In reply to Martin Renvoize from comment #1) > I wonder if we could optionally run tests if an environment variable, > containing an API key, is set? > > That way ebsco partners with a valid test key could at least run tests. > It's not perfect as it wouldn't be easy to run them consistently in the > existing CI framework as I imagine sharing such a key with community would > likely be against some terms and conditions somewhere. Is there any Koha support provider that has an EBSCO key of their own? Or only their libraries have? So they could put it in a CI an existing runner in the case they host one or if they can provide a new CI runner that would run cypress tests which would include the EBSCO ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 06:41:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 04:41:10 +0000 Subject: [Koha-bugs] [Bug 31143] We should attempt to fix/identify all cases where '0000-00-00' may still remain in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31143 --- Comment #1 from wainuiwitikapark at catalyst.net.nz --- Created attachment 154299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154299&action=edit Bug 31143: Update patrons with dates of 0000-00-00 to NULL To test: 1) Change a patron's value of one or more of the following to 0000-00-00: dateofbirth dateenrolled dateexpiry date_renewed 2) Run the fix_patron_dates.pl (-c -v) 3) Notice the value has changed from 0000-00-00 to NULL Sponsored by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 06:41:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 04:41:38 +0000 Subject: [Koha-bugs] [Bug 31143] We should attempt to fix/identify all cases where '0000-00-00' may still remain in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31143 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 09:01:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 07:01:40 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #41 from Emmi Takkinen --- (In reply to Sam Lau from comment #40) > I am still failing subtest 'safe_to_delete() tests'. The only thing that > changed in that subtest was that you commented out this line: > > $patron->account->pay({ amount => 10, debits => [ $debit ] }); > > Uncommenting it made all tests successful for me Ouch, that comment was there to make tests pass for me and I forgot to remove it. They failed because of that line, but that wasn't in scope of this bug, maybe it's now fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 09:37:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 07:37:19 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153154|0 |1 is obsolete| | --- Comment #42 from Emmi Takkinen --- Created attachment 154300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154300&action=edit Bug 12133: Add requirements for guarantor and guarantee Add two requirements when registering a new patron: - A child patron must have a guarantor. This is controlled by a new syspref ChildNeedsGuarantor. - A guarantor cannot be a guarantee. Test plan: 1. Add a child patron without guarantor or child patron with guarantee as guarantor succesfully. 2. Apply this patch. 3. Add a child patron as a guarantor. => Error is raised. 4. Turn syspref "ChildNeedsGuarantor" ON. 5. Add a child patron without a guarantor and error "Child needs a guarantor" is raised. 6. Add guarantor. Guarantor can either be existing patron or added with "Contact" section. => Save without errors. Also prove t/db_dependent/Koha/Patron.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 09:37:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 07:37:51 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #43 from Emmi Takkinen --- I deleted the unnecessary comment, tests should now pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 09:47:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 07:47:59 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #18 from Katrin Fischer --- (In reply to David Cook from comment #17) > (In reply to Katrin Fischer from comment #16) > > Moving to failed QA on the consensus that this should not be moved into HTML > > customizations. > > We might want to re-think that. These sysprefs have security problems which > will be better addressed in Additional Contents/HTML Customizations. Sorry, typo on my part: SHOULD BE moved into HTML customizations. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 10:08:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 08:08:15 +0000 Subject: [Koha-bugs] [Bug 14225] Include external library calendar / event list in Koha's search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14225 --- Comment #2 from Paul Derscheid --- Our plugin could easily do this as everything is based on Koha's API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 11:23:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 09:23:40 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154034|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 12:06:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 10:06:01 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 --- Comment #11 from Pedro Amorim --- Created attachment 154301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154301&action=edit Bug 34431: Add status and status_alias filters to clear -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 12:20:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 10:20:36 +0000 Subject: [Koha-bugs] [Bug 34488] New: Import default framework Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34488 Bug ID: 34488 Summary: Import default framework Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: viliam.polonec at snk.sk QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I am testing 23.05.01 version, so we can update our production ILS. I found that I can't import default framework for bibliographic records. I tried export it and import. But with no success. KOHA shows MARC Framework for default MARC framework Create framework for () using selector with frameworks After that nothings changed I test it on two different instalations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 12:30:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 10:30:48 +0000 Subject: [Koha-bugs] [Bug 34282] ILL batches - availability checking has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34282 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 12:30:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 10:30:51 +0000 Subject: [Koha-bugs] [Bug 34282] ILL batches - availability checking has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34282 --- Comment #3 from Pedro Amorim --- Created attachment 154304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154304&action=edit Bug 34282: Fix availability check in ILL batches Staging modal area had issues listing availability checks for each request in the batch creation process To test: 1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh) 2) Install a metadata enrichment plugin, e.g. https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases 3) Install and configure an availability plugin, e.g. eds https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/releases 4) Enable ILLCheckAvailability sys pref 5) Create a new ILL batch and input some pubmedids, i.e. 34898594, 31452466 6) Verify that the availability results show and are working, for each request in the batch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 12:31:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 10:31:10 +0000 Subject: [Koha-bugs] [Bug 34282] ILL batches - availability checking has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34282 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153494|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 12:31:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 10:31:14 +0000 Subject: [Koha-bugs] [Bug 34282] ILL batches - availability checking has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34282 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153564|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 14:30:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 12:30:29 +0000 Subject: [Koha-bugs] [Bug 34152] Tests in t/db_dependent/Koha/Item.t fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34152 --- Comment #5 from Emmi Takkinen --- (In reply to Sam Lau from comment #4) > Oddly enough, I also can't get it to fail. I ran it 5 times and it passed > every time. This is especially weird since tests were failing for me and > Lucas on Bug 12133, but it wasn't initially failing for you I actually managed to "can_edit_items_from" problem by changing one of my test borrowers borrowernumber to 51 (which is the borrowernumber of mock patron created with sub mock_userenv). I also had to set him as superlibrarian to prevent "holds tests" from failing. Could it be that sub mock_userenv doesn't work properly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 14:47:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 12:47:49 +0000 Subject: [Koha-bugs] [Bug 34489] New: Koha/Patrons.t: Run get_age and is_valid_age in UTC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Bug ID: 34489 Summary: Koha/Patrons.t: Run get_age and is_valid_age in UTC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Running in Amsterdam TZ gives: # Subtest: get_age not ok 5 - Today=2020-02-28, dob=2004-02-28, should be 16 # Failed test 'Today=2020-02-28, dob=2004-02-28, should be 16' # at t/db_dependent/Koha/Patrons.t line 814. # got: '15' # expected: '16' not ok 9 - Today=2020-02-28, dob=2002-02-28, should be 18 not ok 16 - Today=2020-02-29, dob=2004-02-29, should be 16 not ok 19 - Today=2020-03-01, dob=2002-03-01, should be 18 not ok 23 - Today=2020-03-01, dob=2004-03-01, should be 16 not ok 25 - Today=2019-01-31, dob=2001-01-31, should be 18 not ok 28 - Today=2019-01-31, dob=2003-01-31, should be 16 # Looks like you failed 7 tests of 31. not ok 18 - get_age # Subtest: is_valid_age not ok 2 - Today=2020-02-28, dob=2009-02-28, is 11, should be valid=0 in category AGE_5_10 # Failed test 'Today=2020-02-28, dob=2009-02-28, is 11, should be valid=0 in category AGE_5_10' # at t/db_dependent/Koha/Patrons.t line 893. # got: '1' # expected: '0' not ok 7 - Today=2020-02-28, dob=2015-02-28, is 5, should be valid=1 in category AGE_5_10 # Failed test 'Today=2020-02-28, dob=2015-02-28, is 5, should be valid=1 in category AGE_5_10' # at t/db_dependent/Koha/Patrons.t line 893. # got: '0' # expected: '1' # Looks like you failed 2 tests of 10. not ok 19 - is_valid_age Adding a tzset to UTC in the test as a workaround. Bug 25621 suggests patching DateUtils.pm as a definitive solution? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 14:48:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 12:48:06 +0000 Subject: [Koha-bugs] [Bug 34489] Koha/Patrons.t: Run get_age and is_valid_age in UTC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 15:02:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 13:02:46 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #50 from Pedro Amorim --- Created attachment 154305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154305&action=edit Bug 33716: (QA follow-up) Update z39.50 availability search in 'Request from partners' screen Test plan: - Enable ILLCheckAvailability; - Enable ILLModule and install FreeForm - Update partner_code in koha-conf.xml to match the patron category being used ('IL' if on k-t-d) - Install and configure z39.50 availability plugin, link it to the patron ID ('16' if on k-t-d) - Add a valid e-mail address to the patron of 'IL' category - Create a new ILL request and go to 'Manage request' screen - Click 'Place request with partners' notice the label 'Partners available for searching: none' - Apply patch and refresh, notice a 'Search selected partners' button now shows up after you select the partner from the list This is a fix for a regression caused by the rest of the code in this bug. I'm submitting this here since this has not yet been pushed and the fix is quite self-explanatory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 16:18:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 14:18:21 +0000 Subject: [Koha-bugs] [Bug 34453] Update background of quick spine label pop-up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34453 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154282|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose --- Created attachment 154306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154306&action=edit Bug 34453: Update background of quick spine label pop-up This patch updates the quick spine label popup so that the footer uses the same markup as the recently updated Z39.50 popup window in cataloging. To test, apply the patch and rebuild the staff interface CSS. Go to Cataloging -> Quick spine label creator. - Test the form with both an existing barcode and a non-existent barcode. - In the pop-up window, confirm that the footer looks correct and that the buttons in the footer, in both cases, work correctly. Signed-off-by: Sam Lau Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 16:20:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 14:20:23 +0000 Subject: [Koha-bugs] [Bug 34453] Update background of quick spine label pop-up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34453 --- Comment #4 from Caroline Cyr La Rose --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 16:29:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 14:29:39 +0000 Subject: [Koha-bugs] [Bug 34355] Automated Marc record ordering process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 17:06:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 15:06:31 +0000 Subject: [Koha-bugs] [Bug 14341] XSLT 773$x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14341 Heather changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez at nps.gov --- Comment #6 from Heather --- Hi! A clarification for MARC21: The $x is not valid in all 7XX fields. For those 7XX fields for which it is valid, it is an ISSN only (not an ISBN). ISSNs are waaaaaaaaaay more reliable than ISBNs, and are very, very, very useful for searching, so, yes, I think they should be visible in all the 7XX fields for which they are valid. (In the 754 field (Added Entry, Taxonomic Identification), $x is a non-public note. This is not a very commonly used field in most types of libraries, though.) Cheerio! h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 17:12:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 15:12:03 +0000 Subject: [Koha-bugs] [Bug 31143] We should attempt to fix/identify all cases where '0000-00-00' may still remain in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31143 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #2 from Laura Escamilla --- Hi! Thank you for working on this patch. I ran into this error: Missing right curly or square bracket at misc/cronjobs/fix_patron_dates.pl line 53, at end of line syntax error at misc/cronjobs/fix_patron_dates.pl line 53, at EOF After adding the curly this works as described! I'm marking this as Failed QA for now, but once the patch is updated I'll be happy to sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 17:27:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 15:27:17 +0000 Subject: [Koha-bugs] [Bug 34247] Improve translation of notice character count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34247 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 17:27:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 15:27:18 +0000 Subject: [Koha-bugs] [Bug 34247] Improve translation of notice character count In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34247 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153288|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose --- Created attachment 154307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154307&action=edit Bug 34247: Improve translation of notice character count This patch restructures the template markup around the part of the notice edit screen where the system tracks how many characters have been entered in an SMS message. The change is intended to make translation easier. To test, apply the patch and run the translation script to update the .po files, e.g. perl misc/translator/translate update fr-FR Check the updated .po files: - In fr-FR-staff-prog.po there should not be a line with the string "160 characters" - In fr-FR-messages.po the string should have been picked up like this: msgid "{content_length} / 160 characters" msgstr "" - Add a translation to fr-FR-messages.pl and install the updated translation: perl misc/translator/translate install fr-FR - Switch to the update language in the staff interface and go to Tools -> Notices. Edit any notice and expand the "SMS" block. (you may be asked to enable SMSSendDriver). - Confirm that the "X/160 characters" text updates correctly as you enter content into the textarea. Confirm that the same is true when you switch to your updated translation. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 17:42:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 15:42:23 +0000 Subject: [Koha-bugs] [Bug 34196] UI adjustment to filters on funds administration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34196 --- Comment #3 from Caroline Cyr La Rose --- Is it normal that the invoices search filters is h3 and funds search filters is h4? (And also that in both cases there are no h2?) Otherwise, I think it looks much better! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 18:00:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 16:00:16 +0000 Subject: [Koha-bugs] [Bug 14341] XSLT 773$x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14341 --- Comment #7 from Katrin Fischer --- Thx, Heather! I was thinking of: 773 $z - International Standard Book Number (R) I haven't checked if all 7xx with ISSN also support ISBN - maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 18:01:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 16:01:41 +0000 Subject: [Koha-bugs] [Bug 34355] Automated MARC record ordering process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automated Marc record |Automated MARC record |ordering process |ordering process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 18:09:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 16:09:48 +0000 Subject: [Koha-bugs] [Bug 14341] XSLT 773$x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14341 --- Comment #8 from Heather --- Hi, Katrin! No, not all 7XX have an ISBN field, e.g., 700 (personal name), 710 (corporate name), 711 (conference name) don't & can't have an ISBN because they are not "books/publications.":) $z ISBN is present in Linking Entry Fields. IMO, bibliographic frameworks hide/reveal the subfields easily. It would be great to have syspref(s), though, that allow hyperlinking or not. (My library would not want hyperlinked ISBNs--they are too unreliable, and being a history library, were not used during the publication of most of our collection.) ISBNs are helpful for contemporary collections, like public libraries, though! Cheerio! h2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 18:13:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 16:13:00 +0000 Subject: [Koha-bugs] [Bug 34282] ILL batches - availability checking has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34282 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 18:13:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 16:13:03 +0000 Subject: [Koha-bugs] [Bug 34282] ILL batches - availability checking has issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34282 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154304|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim --- Created attachment 154308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154308&action=edit Bug 34282: Fix availability check in ILL batches Staging modal area had issues listing availability checks for each request in the batch creation process To test: 1) Run bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh) 2) Install a metadata enrichment plugin, e.g. https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases 3) Install and configure an availability plugin, e.g. eds https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds/releases 4) Enable ILLCheckAvailability sys pref 5) Create a new ILL batch and input some pubmedids, i.e. 34898594, 31452466 6) Verify that the availability results show and are working, for each request in the batch Signed-off-by: Edith Speller Sponsored-by: UKHSA (UK Health Security Agency) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 19:35:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 17:35:52 +0000 Subject: [Koha-bugs] [Bug 34490] New: Resolving a claim doesn't change the Account Type Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34490 Bug ID: 34490 Summary: Resolving a claim doesn't change the Account Type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1. Have a patron with an account type at /cgi-bin/koha/members/pay.pl showing as Fines (Accruing). 2. Mark the item that is accruing fines as Claims returned. 3. Check the item in. 4. Resolve the claim on the patron's account. Don't make any changes to the status. 5. Check the account type again. It is still showing as Fines (Accruing) - no fines continue to accrue though. When a claim is resolved it should changed to Fines (Returned). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 20:24:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 18:24:14 +0000 Subject: [Koha-bugs] [Bug 13811] Silent Cronjobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13811 --- Comment #7 from Blou --- ooooh, a time machine! :-) Yes, fair point. I had to dig to recover references to this Bug. Unfortunately, our sponsor pulled the plug on this one a while ago. Could be simple to do, but I can't prioritize this in any fashion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 20:30:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 18:30:45 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 --- Comment #63 from Tomás Cohen Arazi --- Created attachment 154309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154309&action=edit Bug 33117: Make dbrev idempotent QA didn't spot the issue, nor I. So fixing now. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 20:48:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 18:48:15 +0000 Subject: [Koha-bugs] [Bug 13811] Silent Cronjobs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13811 --- Comment #8 from Katrin Fischer --- (In reply to Blou from comment #7) > ooooh, a time machine! :-) > > Yes, fair point. I had to dig to recover references to this Bug. > Unfortunately, our sponsor pulled the plug on this one a while ago. Could > be simple to do, but I can't prioritize this in any fashion. That's too bad, but thanks for the feedback :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 20:54:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 18:54:18 +0000 Subject: [Koha-bugs] [Bug 12967] Allow to choose currency for calculating shipping cost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12967 --- Comment #1 from Michaela Sieber --- (In reply to Katrin Fischer from comment #0) > When receiving books in the acquisition module, you can enter an amount and > a fund for the shipping cost, but there is no currency pull down for > calculating the amount from another currency. +1 and btw it is also not possible to enter a currency for Adjustments -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 21:11:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 19:11:38 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate, | |rel_23_05_candidate Status|Pushed to oldstable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 21:11:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 19:11:47 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 21:12:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 19:12:19 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master --- Comment #64 from Tomás Cohen Arazi --- Follow-up pushed to master. @RMaints please port the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 21:30:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 19:30:41 +0000 Subject: [Koha-bugs] [Bug 34491] New: Add select2 to fund selection in adjustments (invoice) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34491 Bug ID: 34491 Summary: Add select2 to fund selection in adjustments (invoice) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: michaela.sieber at kit.edu QA Contact: testopia at bugs.koha-community.org When you have a lot of funds, would be useful to have autocompletion in funds combobox in the invoice adjustments section Test plan : 1. Go to acquisition modul 2. Create an activ and an inactiv budget with at least one fund 3. Search for Vendor 4. Button receive shipment and create invoice 5. Click finish receiving (we don't need an order line for this test) 6. Click +Add an adjustment There is no autocompletion in 'Fund' combobox 7. Apply Patch 8. Search for your invoice 9. Click +Add an adjustment 10. Check you see autocompletion in 'Fund' combobox 11. Click on 'Show inactive' 12. Check you see inactiv funds in combobox 13. Update adjustments 14. Change the fund in the existing adjustment line using the autocompletion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 21:35:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 19:35:46 +0000 Subject: [Koha-bugs] [Bug 34491] Add select2 to fund selection in adjustments (invoice) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34491 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Depends on| |31388 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 [Bug 31388] Add select2 to fund selection in new order form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 21:35:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 19:35:46 +0000 Subject: [Koha-bugs] [Bug 31388] Add select2 to fund selection in new order form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31388 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34491 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34491 [Bug 34491] Add select2 to fund selection in adjustments (invoice) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 22:05:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 20:05:04 +0000 Subject: [Koha-bugs] [Bug 34492] New: Fund in adjustments is now shipping fund Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34492 Bug ID: 34492 Summary: Fund in adjustments is now shipping fund Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: michaela.sieber at kit.edu QA Contact: testopia at bugs.koha-community.org the fund in invoice adjustments has been renamed to shipping fund. But the shipping fund is for shipping costs and adjustments are for different purposes (not shipping costs) Changed since 22.11.07 see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721#c1 To recreate: 1. Go to acquisition modul 2. search for Vendor 3. Button receive shipment and create invoive 4. click finish receiving (we don't need an order line for this test) 5. Click +Add an adjustment 6. See that the fund is named "shipping fund" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 22:05:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 20:05:25 +0000 Subject: [Koha-bugs] [Bug 34492] Fund in adjustments is now shipping fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34492 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 [Bug 33721] Show inactive funds in invoice.tt out of order -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 22:05:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 20:05:25 +0000 Subject: [Koha-bugs] [Bug 33721] Show inactive funds in invoice.tt out of order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721 Michaela Sieber changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34492 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34492 [Bug 34492] Fund in adjustments is now shipping fund -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 22:07:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 20:07:28 +0000 Subject: [Koha-bugs] [Bug 34452] Button 'Update adjustments' is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154285|0 |1 is obsolete| | --- Comment #5 from Biblibre Sandboxes --- Created attachment 154310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154310&action=edit Bug 34452: Restore fund label and 'Update adjustments' button This patch fixed 2 small and recent regressions: * The "Update adjustments" button used to always display. It's required to save a new first adjustment, but also to save changes to existing adjustments edited inline. It now would only display after "Add adjustments" was clicked. We retore to display it always. (bug 32746) * We have several "Fund" pull downs on this page, but they are for different things and require different labelling. "Fund" was changed to "Shipping fund" which matches at the top, but doesn't work for the adjustments table and single adjustment form. Now we use "Shipping fund" "Fund" and no label in the table as the table header covers it there. (bug 33721) To test. * Add a vendor * Receive shipment * Add invoice and save * Click on "Finish receiving" * Verify the button "Update adjustments" appears after clicking "Add new adjustment" * Verify the button is gone after you clicked it and the table shows * Change something in the table - no button to save change :( * Apply patch * Repeat steps, button "Update adjustments" should not always be visible. Signed-off-by: Sam Lau Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 22:11:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 20:11:55 +0000 Subject: [Koha-bugs] [Bug 34492] Fund in adjustments is now shipping fund In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34492 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- This was already fixed by bug 34452 (see test plan) *** This bug has been marked as a duplicate of bug 34452 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 22:11:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 20:11:55 +0000 Subject: [Koha-bugs] [Bug 34452] Button 'Update adjustments' is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 --- Comment #6 from Katrin Fischer --- *** Bug 34492 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 22:57:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 20:57:45 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable --- Comment #65 from Fridolin Somers --- Done for 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 23:26:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 21:26:58 +0000 Subject: [Koha-bugs] [Bug 16544] Changes to circ rules should be logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16544 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 7 23:40:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 21:40:46 +0000 Subject: [Koha-bugs] [Bug 34438] OPAC self registration form does not include lang ( Preferred language for notices ) field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34438 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 00:05:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 22:05:07 +0000 Subject: [Koha-bugs] [Bug 34076] [ALTERNATE] [DOCS] Automated screenshots using Cypress.io testing framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34076 --- Comment #26 from Caroline Cyr La Rose --- Ok, it took me a lot of trial and error (around 1.5 hours worth), but I got step 7 done. Look at this gorgeous screenshot! https://snipboard.io/bhyizO.jpg (lol!!) I tried making a test from scratch to replicate the screenshots in the Administration chapter https://koha-community.org/manual/23.05/en/html/administration.html#libraries It mostly worked. I ran into some problems. - For the screenshot showing the library URL in the OPAC (https://koha-community.org/manual/23.05/en/html/_images/librarylink.png), I had to create another test because I couldn't find a way to go to the OPAC in the same test (unless I didn't find the correct way?) - For the screenshot showing the library link (https://koha-community.org/manual/23.05/en/html/_images/librarylink.png) I cannot get the tabs as well as the content. Also, when I clicked around in Cypress Studio to get the correct html section, I could not find it. I went into the inspector and clicked around there to find the correct div id and changed it manually. - For the screenshots showing the HTML customization (https://koha-community.org/manual/23.05/en/html/_images/libraryinfo.png and https://koha-community.org/manual/23.05/en/html/_images/opacinfo.png), Cypress studio would not save the text I entered in the body of the customization... I wonder if it's a problem with tiny MCE? - It's not the end of the world, but I could not take screenshots of partial forms (i.e. https://koha-community.org/manual/23.05/en/html/_images/newlibrary.png and https://koha-community.org/manual/23.05/en/html/_images/librarycontact.png will be together with automatic screenshots) This will necessitate a bit of reorganization in the manual. - It's also not the end of the world, but I always make the screenshots a tiny bit larger than the div or other html section. For example, this is the screenshot taken with Cypress https://snipboard.io/jSgRZz.jpg , compared to the one in the manual https://koha-community.org/manual/23.05/en/html/_images/librarydetails.png . Notice the sides are not cut as close to the text as the automatic screenshot... I find it's not as... aggressive? I don't know how to describe it, but I find looking at the picture with the tiny bit of space feels calmer. Might just be me being nitpicky... This is the total of the tests I did for the 4-5 screenshots. It took me about 2 hours to get these. I'm stuck at the HTML customization one. describe("Administration", function () { beforeEach(() => { cy.login(); cy.set_cookie_lang(); }); /* ==== Test Created with Cypress Studio ==== */ it('librarylist', function() { /* ==== Generated with Cypress Studio ==== */ cy.get(':nth-child(2) > .biglinks-list > :nth-child(6) > .icon_general').click(); cy.get(':nth-child(1) > :nth-child(4) > :nth-child(1) > a').click(); cy.wait_for_ajax(); cy.get('main').should('be.visible').screenshot("librarylist"); /* ==== End Cypress Studio ==== */ /* ==== Generated with Cypress Studio ==== */ cy.get(':nth-child(7) > .sorting_1 > a').click(); cy.get('main').should('be.visible').screenshot("librarydetails"); /* ==== End Cypress Studio ==== */ }); /* ==== Test Created with Cypress Studio ==== */ it('newlibrary', function() { /* ==== Generated with Cypress Studio ==== */ cy.get(':nth-child(2) > .biglinks-list > :nth-child(6) > .icon_general').click(); cy.get(':nth-child(1) > :nth-child(4) > :nth-child(1) > a').click(); cy.get('#newbranch').click(); cy.get('main').should('be.visible').screenshot("newlibrary"); /* ==== End Cypress Studio ==== */ }); /* ==== Test Created with Cypress Studio ==== */ it('librarylink', function() { /* ==== Generated with Cypress Studio ==== */ cy.get(':nth-child(2) > .biglinks-list > :nth-child(6) > .icon_general').click(); cy.get(':nth-child(1) > :nth-child(4) > :nth-child(1) > a').click(); cy.get(':nth-child(1) > .actions > a.btn').click(); cy.get('#branchurl').type('https://www.google.com'); cy.get('.btn').click(); /* ==== End Cypress Studio ==== */ }); /* ==== Test Created with Cypress Studio ==== */ it('librarylink2', function() { /* ==== Generated with Cypress Studio ==== */ cy.visit('http://kohadev.mydnsname.org:8080/cgi-bin/koha/opac-detail.pl?biblionumber=131'); cy.get('#holdings_panel').should('be.visible').screenshot("librarylink"); /* ==== End Cypress Studio ==== */ }); /* ==== Test Created with Cypress Studio ==== */ it('libraryinfo1', function() { /* ==== Generated with Cypress Studio ==== */ cy.get(':nth-child(2) > .biglinks-list > :nth-child(5) > .icon_general').click(); cy.get(':nth-child(2) > dl > :nth-child(9) > a').click(); cy.get('#newentry').click(); cy.get('#location').select('OpacLibraryInfo'); cy.get('#branchcode').select('CPL'); cy.get(':nth-child(3) > .flatpickr_wrapper > .flatpickr').click(); cy.get('.open > .flatpickr-innerContainer > .flatpickr-rContainer > .flatpickr-days > .dayContainer > [aria-label="August 1, 2023"]').click(); cy.get('#title_default').type('Closure information'); cy.get('#submit_form').click(); /* ==== End Cypress Studio ==== */ }); }); Other things to think about: - I noticed the screenshots generated have the language code before (e.g. en_librarylist.png). I'm not sure how this will be managed in the manual. Currently, we refer to an image file in the source/images/ folder. Will there be a symbolic link (or something) to say librarylist.png in the english manual is en_librarylist.png, and in the fr-CA manual it is fr-CA_librarylist.png, etc? If not, how do we manage all the different images? - How to manage the tests? One per chapter? One per section? One per image? Do we have a naming convention? We don't really have a naming convention currently, but it would be good to think about it if we are going to have thousands of new files to manage. We don't need answers for this right away, but it's just things I thought about while doing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 01:06:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 23:06:30 +0000 Subject: [Koha-bugs] [Bug 31841] Shelving location search in staff interface sometimes creates invalid Zebra query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31841 --- Comment #21 from Fridolin Somers --- (In reply to David Cook from comment #3) > In Master: > 1) Turn off QueryAutoTruncate > 2) Go to > http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=GEN&idx=location > 3) Note "No results found" > > The problem is that QueryWeightFields adds a "phr" qualifier which is a > problem since "location" doesn't have a phrase index defined...: > > (rk=( location,ext,r1=" GEN " or location,phr,r3=" GEN " or > location,wrdl,r6=" GEN " or location,wrdl,fuzzy,r8=" GEN " or > location,wrdl,rt,r9=""gen"? ")) We have seen other problems like that. We should add phrase search to all search fields to fix once and for all. But for this cas, it disables autotruncation of location code, so its a good fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 01:10:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 23:10:45 +0000 Subject: [Koha-bugs] [Bug 34493] New: Bad indenting in search_indexes.inc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34493 Bug ID: 34493 Summary: Bad indenting in search_indexes.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 32683 broke indenting in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc Not on purpose looks like. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 01:10:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 23:10:53 +0000 Subject: [Koha-bugs] [Bug 34493] Bad indenting in search_indexes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34493 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |32683 Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683 [Bug 32683] Convert header search tabs to Bootstrap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 01:10:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 23:10:53 +0000 Subject: [Koha-bugs] [Bug 32683] Convert header search tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32683 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34493 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34493 [Bug 34493] Bad indenting in search_indexes.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 01:13:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 23:13:08 +0000 Subject: [Koha-bugs] [Bug 34493] Bad indenting in search_indexes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34493 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 01:13:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 23:13:11 +0000 Subject: [Koha-bugs] [Bug 34493] Bad indenting in search_indexes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34493 --- Comment #1 from Fridolin Somers --- Created attachment 154311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154311&action=edit Bug 34493: Fix indenting in search_indexes.inc Bug 32683 broke indenting in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc Not on purpose looks like. Test plan : 1) Look at changes to validate indenting 2) Run prove xt/tt_valid.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 01:33:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 23:33:24 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #19 from David Cook --- (In reply to Katrin Fischer from comment #18) > Sorry, typo on my part: SHOULD BE moved into HTML customizations. Ahhh all good then! Thanks for clarifying :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 01:42:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 23:42:37 +0000 Subject: [Koha-bugs] [Bug 34493] Bad indenting in search_indexes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34493 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 01:42:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Aug 2023 23:42:39 +0000 Subject: [Koha-bugs] [Bug 34493] Bad indenting in search_indexes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34493 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154311|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 154312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154312&action=edit Bug 34493: Fix indenting in search_indexes.inc Bug 32683 broke indenting in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc Not on purpose looks like. Test plan : 1) Look at changes to validate indenting 2) Run prove xt/tt_valid.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 02:10:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 00:10:05 +0000 Subject: [Koha-bugs] [Bug 34219] getAll not allowing additional parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34219 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #10 from Victor Grousset/tuxayo --- Confirmed that tests pass after patch :) To run one test (in case of flaky tests): yarn cypress run --spec t/cypress/integration/ERM/Agreements_spec.ts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 08:42:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 06:42:26 +0000 Subject: [Koha-bugs] [Bug 34152] Tests in t/db_dependent/Koha/Item.t fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34152 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #6 from David Nind --- Like the other earlier comments, the tests pass for me using koha-testing-docker (KTD) before trying to apply the patch. (The patch still applies successfully). I've changed the status to Failed QA - happy to retest if you could identify what settings/changes to make to get it to fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 08:42:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 06:42:36 +0000 Subject: [Koha-bugs] [Bug 34152] Tests in t/db_dependent/Koha/Item.t fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34152 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 09:39:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 07:39:45 +0000 Subject: [Koha-bugs] [Bug 31652] Add geo-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at trust-box.at --- Comment #6 from Mark Hofstetter --- This is/was a pre-existing problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 10:25:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 08:25:53 +0000 Subject: [Koha-bugs] [Bug 33812] Accessibility: OPAC messaging preferences is missing form labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33812 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 10:51:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 08:51:20 +0000 Subject: [Koha-bugs] [Bug 33406] Searching for authority with hyphen surrounded by spaces causes error 500 (with ES) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33406 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151067|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim --- Created attachment 154313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154313&action=edit Bug 33406: Handle ES search errors for authorities We are dealing ok with ES exceptions for biblio records search, catching them and raising them to the end user. But we don't for authorities, where we explode with an ugly 500. Test plan: Search for "(term_1*) AND (-) AND (term_2*)" in the authority search and notice that you don't get a 500 but an error instead saying that you should try again Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 10:51:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 08:51:22 +0000 Subject: [Koha-bugs] [Bug 33406] Searching for authority with hyphen surrounded by spaces causes error 500 (with ES) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33406 --- Comment #4 from Pedro Amorim --- Created attachment 154314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154314&action=edit Bug 33406: Filter out some known isolated trouble makers Test plan: 1) Launch k-t-d with ES: -- ktd --es7 pull -- ktd --es7 up 2) Visit /cgi-bin/koha/authorities/authorities-home.pl and search for 'tim' 3) Edit that, add a dash '-' to 100$a, like 'Bunce, Tim - name'" 4) Do a authority search for 'tim - name', notice it errors out 5) Apply patch 6) Perform the same search, notice it doesn't error and returns the correct record Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 10:51:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 08:51:32 +0000 Subject: [Koha-bugs] [Bug 33406] Searching for authority with hyphen surrounded by spaces causes error 500 (with ES) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33406 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |pedro.amorim at ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 10:52:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 08:52:44 +0000 Subject: [Koha-bugs] [Bug 33406] Searching for authority with hyphen surrounded by spaces causes error 500 (with ES) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33406 --- Comment #5 from Pedro Amorim --- (In reply to Janusz Kaczmarek from comment #2) > > This would prevent most known issues to emerge. (I was unable, due to lack > of time, to prepare the official patch by myself). Janusz I've tested your fix proposal and it works. I've submitted the patch with your name on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 13:10:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 11:10:37 +0000 Subject: [Koha-bugs] [Bug 34494] New: Table tmp_holdsqueue fails to be created for MySQL 8 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 Bug ID: 34494 Summary: Table tmp_holdsqueue fails to be created for MySQL 8 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It appears that MySQL 8 rejects creating any table where the primary key is nullable. The table tmp_holdsqueue has a nullable pk ( itemnumber ) but there is no reason for this column to be nullable ( generating a holds queue entry with no itemnumber is not possible ) so it make sense to just remove the nullability for MySQL compatiability. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 13:10:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 11:10:43 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 [Bug 28966] Holds queue viewer too slow to load for large numbers of holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 13:10:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 11:10:43 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34494 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 13:10:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 11:10:51 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|enhancement |blocker -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 13:19:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 11:19:55 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 13:19:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 11:19:57 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 --- Comment #1 from Kyle M Hall --- Created attachment 154315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154315&action=edit Bug 34494: Table tmp_holdsqueue fails to be created for MySQL 8 It appears that MySQL 8 rejects creating any table where the primary key is nullable. The table tmp_holdsqueue has a nullable pk ( itemnumber ) but there is no reason for this column to be nullable ( generating a holds queue entry with no itemnumber is not possible ) so it make sense to just remove the nullability for MySQL compatiability. Test Plan: 1) Using MySQL 8.0, attempt to create a database from kohastructure.sql If you use ktd, you can try: DB_IMAGE=mysql:8.0 ktd up 2) Note the failure to create the table 3) Apply this patch 4) Repeat step 1 5) The table is created! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 14:23:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 12:23:05 +0000 Subject: [Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha/Patrons.t: Run get_age |Koha/Patrons.t: Subtests |and is_valid_age in UTC |get_age and is_valid_age do | |not pass in another | |timezone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 14:33:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 12:33:23 +0000 Subject: [Koha-bugs] [Bug 25621] Some tests in t/DateUtils.t fail when timezone is not UTC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25621 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 14:35:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 12:35:48 +0000 Subject: [Koha-bugs] [Bug 25621] Some tests in t/DateUtils.t fail when timezone is not UTC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25621 --- Comment #3 from Marcel de Rooy --- Added the mock_config line in another test to see if it would resolve a similar problem with time zones. But it did not.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 14:36:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 12:36:24 +0000 Subject: [Koha-bugs] [Bug 25621] Some tests in t/DateUtils.t fail when timezone is not UTC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25621 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34489 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 14:36:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 12:36:24 +0000 Subject: [Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25621 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 14:37:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 12:37:09 +0000 Subject: [Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 --- Comment #1 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #0) > Adding a tzset to UTC in the test as a workaround. Bug 25621 suggests > patching DateUtils.pm as a definitive solution? No tzset is not satisfactory. What about removing floating from get_age ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 14:53:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 12:53:44 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 14:53:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 12:53:48 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154300|0 |1 is obsolete| | --- Comment #44 from David Nind --- Created attachment 154316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154316&action=edit Bug 12133: Add requirements for guarantor and guarantee Add two requirements when registering a new patron: - A child patron must have a guarantor. This is controlled by a new syspref ChildNeedsGuarantor. - A guarantor cannot be a guarantee. Test plan: 1. Add a child patron without guarantor or child patron with guarantee as guarantor succesfully. 2. Apply this patch. 3. Add a child patron as a guarantor. => Error is raised. 4. Turn syspref "ChildNeedsGuarantor" ON. 5. Add a child patron without a guarantor and error "Child needs a guarantor" is raised. 6. Add guarantor. Guarantor can either be existing patron or added with "Contact" section. => Save without errors. Also prove t/db_dependent/Koha/Patron.t Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 14:54:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 12:54:40 +0000 Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #45 from David Nind --- Testing notes (using KTD): 1. After apply the patch, run updatedatabase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 14:56:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 12:56:25 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Tomás Cohen Arazi --- I've asked my DBA to analyze it. Nick and I have talked about making a specialized endpoint that restores the subquery, but this might be solvable with some DB optimizations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 14:56:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 12:56:59 +0000 Subject: [Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #51 from Tomás Cohen Arazi --- Thanks Kyle for taking care on the separate bug. Please QA y'all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 15:00:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 13:00:10 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Julian Maurice from comment #6) > (In reply to Jonathan Druart from comment #4) > > I was going to suggest to have a separate "extended_attributes" parameter we > > could pass to the endpoint, but that's not trivial to implement (we need the > > search_type, and to know if we need a OR or AND with q...) > > I think you'd need to pass all three parameters (the search text, the search > field, and the search type) to make it work. Would that be acceptable to > have this special case inside Koha::REST::V1::Patrons::list ? Should we do it on a specialized endpoint? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 15:05:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 13:05:48 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 15:05:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 13:05:51 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154315|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 154317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154317&action=edit Bug 34494: Table tmp_holdsqueue fails to be created for MySQL 8 It appears that MySQL 8 rejects creating any table where the primary key is nullable. The table tmp_holdsqueue has a nullable pk ( itemnumber ) but there is no reason for this column to be nullable ( generating a holds queue entry with no itemnumber is not possible ) so it make sense to just remove the nullability for MySQL compatiability. Test Plan: 1) Using MySQL 8.0, attempt to create a database from kohastructure.sql If you use ktd, you can try: DB_IMAGE=mysql:8.0 ktd up 2) Note the failure to create the table 3) Apply this patch 4) Repeat step 1 5) The table is created! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 15:16:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 13:16:00 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. Before applying the patch, testing with MySQL 8.0 as the database fails, as expected (exits during start up - edit .env, change DB_IMAGE=mysql:8.0, ktd up). 2. Shut down ktd, then change database back to DB_IMAGE=mariadb:10.5 - KTD should start up as normal. Apply the patch. 3. Shut down KTD, change database to MySQL as in step 1, start up should now be successful. 4. Probably an easier way, but this worked for me when testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 15:21:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 13:21:03 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 --- Comment #10 from Nick Clemens --- I am working on a 'patrons/lookup' endpoint to see about building the query in a more performant way. For testing, I imported 100k borrowers with several attributes each and was able to confirm the slowdown when attributes are enabled I dumped the tables and made them available on github: https://github.com/kidclamp/sample_files/blob/main/many_attributes.gz https://github.com/kidclamp/sample_files/blob/main/many_borrowers.gz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 15:47:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 13:47:13 +0000 Subject: [Koha-bugs] [Bug 6892] If a URL has been entered without http://, it isn't correctly linked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6892 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32794 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 15:47:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 13:47:13 +0000 Subject: [Koha-bugs] [Bug 32794] mailto links in 856 can be incorrectly formed by XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32794 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6892 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 15:47:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 13:47:34 +0000 Subject: [Koha-bugs] [Bug 6892] If a URL has been entered without http://, it isn't correctly linked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6892 --- Comment #9 from Nick Clemens --- Still valid? Or fixed by bug 32794? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 16:09:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 14:09:04 +0000 Subject: [Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 --- Comment #2 from Marcel de Rooy --- Created attachment 154318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154318&action=edit Bug 34489: Testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 16:11:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 14:11:32 +0000 Subject: [Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 --- Comment #3 from Marcel de Rooy --- dt_from_string is rather weird with time zones. Why not pass now in server_tz ? See testing patch too. Some tests in DateUtils.t are just wrong. Try testing in Pacific/Fiji. Having a difference of 13 hours, will make one of the rfc3339 tests fail. The test is wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 16:16:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 14:16:18 +0000 Subject: [Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 16:53:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 14:53:53 +0000 Subject: [Koha-bugs] [Bug 34149] Syndetics cover images don't load in staff interface detail page if other images services are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Syndetics cover images |Syndetics cover images |don't load in staff |don't load in staff |interface detail page in |interface detail page if |other images services are |other images services are |enabled |enabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 17:05:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 15:05:10 +0000 Subject: [Koha-bugs] [Bug 34495] New: AutomaticConfirmTransfer does not confirm if the check-in form is resubmitted Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34495 Bug ID: 34495 Summary: AutomaticConfirmTransfer does not confirm if the check-in form is resubmitted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: emily.lamancusa at montgomerycountymd.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 33300 Bug 29792 added a new system preference, AutomaticConfirmTransfer, to control the behavior of a transfer when the user clicked away from the "Wrong Transfer" modal without selecting anything. (assuming TransfersBlockCirc is set to "Don't block") With the syspref set to automatically confirm, it works as intended if the user literally clicks away from the modal using the mouse. However, if the user submits the check-in form again without selecting an option on the modal (i.e. by scanning the next item, or accidentally double-scanning the item initiating the transfer), then the transfer is not confirmed. It looks like this is happening because the automatic confirmation is triggered when the modal is hidden by Bootstrap event. If the check-in form is resubmitted, it doesn't actively hide the modal before reloading the page, so the automatic confirmation is not triggered. To reproduce: 0. Configure sysprefs and circulation rules: a. TransfersBlockCirc to Don't block b. AutomaticConfirmTransfer to Do c. In the circulation rules, set the default return policy to "Item returns home" 1. Find an item that belongs to a different library and check it in 2. When the transfer modal appears, click away from the modal. -> Notice the animation - the modal appears to fade upwards. 3. Query the transfer table -> Notice that there is a transfer with values for daterequested and datesent 4. Check the item in again 5. When the Wrong Transfer modal appears, click away from the modal. -> Notice the animation - the modal appears to fade upwards. 6. Query the transfer table -> Notice that the previous transfer was canceled, and there is a new transfer with values for daterequested and datesent 7. Repeat steps 1-6, except instead of clicking away from the modals, press Enter on the keyboard instead -> Notice that the animation no longer appears - the modals simply disappear when the page is reloaded -> Notice that after the Wrong Transfer modal is bypassed like this, the transfer table shows that the previous transfer was canceled, and there is a new transfer with a value for daterequested but no value for datesent Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 [Bug 33300] Wrong system preference name AutomaticWrongTransfer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 17:05:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 15:05:10 +0000 Subject: [Koha-bugs] [Bug 33300] Wrong system preference name AutomaticWrongTransfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34495 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34495 [Bug 34495] AutomaticConfirmTransfer does not confirm if the check-in form is resubmitted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 17:11:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 15:11:05 +0000 Subject: [Koha-bugs] [Bug 34496] New: Make default saved report results count configurable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34496 Bug ID: 34496 Summary: Make default saved report results count configurable Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: hebah at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries would like the ability to set a default count of saved SQL report results other than 20. It would be nice if that could be configured, either by sys pref or in table settings. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 17:14:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 15:14:25 +0000 Subject: [Koha-bugs] [Bug 34496] Make default saved report results count configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34496 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi Hebah, I remembered that this was filed before, but phrased a little differently. *** This bug has been marked as a duplicate of bug 17120 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 17:14:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 15:14:25 +0000 Subject: [Koha-bugs] [Bug 17120] Specify number of rows per page in report and initial run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com --- Comment #3 from Katrin Fischer --- *** Bug 34496 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 17:20:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 15:20:44 +0000 Subject: [Koha-bugs] [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 17:29:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 15:29:40 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us --- Comment #6 from Rebecca Coert --- +1 - this would be a useful feature! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 18:01:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 16:01:22 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 18:07:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 16:07:16 +0000 Subject: [Koha-bugs] [Bug 34497] New: Vue - Dialog component should allow for confirmation input options Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Bug ID: 34497 Summary: Vue - Dialog component should allow for confirmation input options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: pedro.amorim at ptfs-europe.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 18:08:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 16:08:16 +0000 Subject: [Koha-bugs] [Bug 34497] Vue - Dialog component should allow for confirmation input options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 --- Comment #1 from Pedro Amorim --- Created attachment 154319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154319&action=edit Bug 34497: Dialog component should allow for optional input options on confirmation modal Currently supports 'Text' or 'Date' inputs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 18:08:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 16:08:47 +0000 Subject: [Koha-bugs] [Bug 34497] Vue - Dialog component should allow for confirmation input options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|jonathan.druart+koha at gmail. |pedro.amorim at ptfs-europe.co |com |m --- Comment #2 from Pedro Amorim --- Currently missing cypress tests for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 18:11:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 16:11:16 +0000 Subject: [Koha-bugs] [Bug 33812] Accessibility: OPAC messaging preferences is missing form labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33812 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 18:11:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 16:11:19 +0000 Subject: [Koha-bugs] [Bug 33812] Accessibility: OPAC messaging preferences is missing form labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33812 Sam Lau changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151594|0 |1 is obsolete| | --- Comment #2 from Sam Lau --- Created attachment 154320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154320&action=edit Bug 33812: Checkboxes need labels in opac-messaging.tt Aria-labels have been added to checkboxes in the OPAC messaging preferences table to assist with screen reading. The relevant preference has been mentioned in each label to identify what the checkbox is for. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 18:36:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 16:36:10 +0000 Subject: [Koha-bugs] [Bug 34498] New: Default autorenewal notices do not account for item_denied_renewal Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34498 Bug ID: 34498 Summary: Default autorenewal notices do not account for item_denied_renewal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1. Have the default notices set for AUTO_RENEWALS and AUTO_RENEWALS_DGST. 2. Set the ItemsDeniedRenewal system preference. ( itemlost: [1,2,3,4,5] ) 3. Set the AutoRenewalNotices system preference to 'According to messaging preferences'. 4. Don't mark lost items as returned ( MarkLostItemsAsReturned ). 5. Set up some auto renewals and then mark the items as lost. 6. Run automatic_renewals.pl 7. You get a notice telling you the item cannot be renewed but no reason is specified. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 18:42:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 16:42:54 +0000 Subject: [Koha-bugs] [Bug 27976] Add Granular options to CircConfirmItemParts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27976 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 19:48:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 17:48:55 +0000 Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Michelle Spinney changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 19:52:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 17:52:06 +0000 Subject: [Koha-bugs] [Bug 34499] New: Framework defaults don't work when adding records with the option "from a new (empty) record" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34499 Bug ID: 34499 Summary: Framework defaults don't work when adding records with the option "from a new (empty) record" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org Hi, It seems there is a problem with the default values ​​in the acquisition module as well. When adding a record to a basket with the "from a new (empty) record" option, the default values ​​are not added to the record according to the default grid. Was there work for this problem? currently the ApplyFrameworkDefaults system preference does not fix the problem for the acquisition module. Thanks, Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 20:13:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 18:13:11 +0000 Subject: [Koha-bugs] [Bug 23861] Add authorised value categories description option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23861 Joseph Alway changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbalway at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 20:31:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 18:31:18 +0000 Subject: [Koha-bugs] [Bug 23861] Add authorised value categories description option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23861 --- Comment #6 from Joseph Alway --- It would be nice for this to be a thing. I'm using a custom Authorized Value for use with one of our reports. Not being able to enter a description for the Authorized Value Category is just a little annoying. https://wiki.koha-community.org/wiki/SQL_Reports_Library#Suggestion_Report_with_selection_by_Status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 21:02:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 19:02:19 +0000 Subject: [Koha-bugs] [Bug 23861] Add authorised value categories description option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23861 --- Comment #7 from Joseph Alway --- (In reply to Katrin Fischer from comment #2) > At the moment these messages are in the template and can be translated - if > we move to the database they won't tanslate or translations have to be > provided separately (and at the moment can only be one language at a time). > I'd say if we move, we could still provide the text for the standard ones in > the template, but allow to add your own additionally? This sounds reasonable to me. What seems like the most likely scenario is that someone will be adding/editing custom authorized value categories. Which is where I found that I couldn't edit the description or even provide one when I added the category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 21:13:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 19:13:01 +0000 Subject: [Koha-bugs] [Bug 34468] Add a progress callback to job_progress.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34468 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- If you could add a test plan, I'll happily have a go at testing. For example, what it does, and what to expect before and after the patches are applied. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 21:29:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 19:29:07 +0000 Subject: [Koha-bugs] [Bug 33361] Renewals prevented on items where there is an item level hold on another item on the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33361 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #2 from Lisette Scheer --- I was wrong, this was not fixed in 32878, we are still experiencing this issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 21:55:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 19:55:12 +0000 Subject: [Koha-bugs] [Bug 33744] Plugins not working on duplicated MARC fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33744 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30975 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 21:55:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 19:55:12 +0000 Subject: [Koha-bugs] [Bug 30975] Framework plugins do not work on cloned fields/subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33744 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 22:07:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 20:07:50 +0000 Subject: [Koha-bugs] [Bug 34038] Fix incorrect use of __() in .tt and .inc files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34038 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose --- Hi Owen, I tried this and I still don't see the strings in the po file. I applied the patch, then ./misc/translator/translate update fr-CA then checked in fr-CA-staff-prog.po for the strings (specifically "Check in and add to bundle" since it's unique) and they are not there. I'm probably missing a step? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 22:07:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 20:07:59 +0000 Subject: [Koha-bugs] [Bug 34500] New: Add data-attributes about the SCO logged in user Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34500 Bug ID: 34500 Summary: Add data-attributes about the SCO logged in user Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In the OPAC we have a hidden loggedinuser class with info. about that patron's category, borrowernumber, and homebranch. This is useful and we be nice if there was something similar in the SCO module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 22:22:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 20:22:56 +0000 Subject: [Koha-bugs] [Bug 25023] Claims returned dates not formatted according to dateformat preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 22:22:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 20:22:58 +0000 Subject: [Koha-bugs] [Bug 25023] Claims returned dates not formatted according to dateformat preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153783|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose --- Created attachment 154321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154321&action=edit Bug 25023: Claims returned dates not formatted according to dateformat preference This patch updates the code for rendering the claims returned table on the checkout and patron detail pages. Now the dates are formatted using the global js-date-format.inc code. To test, apply the patch and make sure the claims returned feature is enabled by setting a value in the ClaimReturnedLostValue system preference. - Check out some items to a patron. - Under the checkouts tab, mark several checkouts as "Claim returned." - Open the claims tab. - The dates in the "Created on" column should be formatted according to your dateformat system preference. - Change the dateformat preference and return to the checkouts page. Confirm that the claims tab shows dates formatted correctly. - The "created on" and "updated on" columns should sort correctly with any dateformat setting. You may have to directly modify the dates in the database in order to have the right data for testing this. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 22:32:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 20:32:14 +0000 Subject: [Koha-bugs] [Bug 34066] Datatable options don't fully translate on list of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34066 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 22:32:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 20:32:16 +0000 Subject: [Koha-bugs] [Bug 34066] Datatable options don't fully translate on list of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34066 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152519|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose --- Created attachment 154322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154322&action=edit Bug 34066: Datatable options don't fully translate on list of saved reports This patch corrects the DataTable option for defining an alternate language string when no records are returned by a table filter. An obsolete version of the option name was breaking the existing custom option supplied by our datatables.js To test, apply the patch and go to Reports -> Use saved.. - In the DataTable of existing reports, all the DataTable controls should look correct. - In the filter field at the top of the table, enter a string which will not be found. You should see a message, "No matching reports found." - Install another language if necessary, and switch to that language. - The labels on all the DataTable controls should show the terms which have been translated for that language. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 22:56:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 20:56:56 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 --- Comment #18 from Fridolin Somers --- Needs a rebase on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 23:12:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 21:12:46 +0000 Subject: [Koha-bugs] [Bug 34501] New: Patron Purchase Suggestion table should include the non-public note Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34501 Bug ID: 34501 Summary: Patron Purchase Suggestion table should include the non-public note Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently the purchase suggestion table at /cgi-bin/koha/members/purchase-suggestions.pl only shows the public note, but not the non-public note. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 23:13:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 21:13:13 +0000 Subject: [Koha-bugs] [Bug 34501] Patron Purchase Suggestion table should include the non-public note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34501 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |Laura.escamilla at bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 23:19:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 21:19:10 +0000 Subject: [Koha-bugs] [Bug 34501] Patron Purchase Suggestion table should include the non-public note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34501 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 23:19:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 21:19:12 +0000 Subject: [Koha-bugs] [Bug 34501] Patron Purchase Suggestion table should include the non-public note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34501 --- Comment #1 from Laura Escamilla --- Created attachment 154323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154323&action=edit Bug 34501: Added Non-public notes to the member purchase suggestion table To test: 1. Create a new purchase suggestion for a patron and add a “Note” and a “Non-public Note” 2. View the purchase suggestion on the patron page at /cgi-bin/koha/members/purchase-suggestions.pl 1. It currently only shows the public note 3. Apply this patch 4. Refresh the page, it now shows both the “Note” and “Non-public Note” 5. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 8 23:44:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Aug 2023 21:44:23 +0000 Subject: [Koha-bugs] [Bug 34501] Patron Purchase Suggestion table should include the non-public note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34501 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 02:30:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 00:30:27 +0000 Subject: [Koha-bugs] [Bug 34307] Update plugin wrapper to use template wrapper for breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 02:30:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 00:30:30 +0000 Subject: [Koha-bugs] [Bug 34307] Update plugin wrapper to use template wrapper for breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34307 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153623|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 154324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154324&action=edit Bug 34307: Update plugin template to match master conventions This change uses WRAPPER to build the breadcrumbs and updates the plugin template to follow some other master conventions like differentiating between Administration and Tools for plugins. Test plan: 0. Apply patch 1. Upload koha-plugin-test-wrapper 2. Enable the plugin 3. Click "Actions" and click "Run tool" 4. Note how the plugin page looks like a perfect Koha Tools page 5. Note that the plugin only contains 6 lines of template code to achieve this effect Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 02:50:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 00:50:40 +0000 Subject: [Koha-bugs] [Bug 34435] get_password_expiry_date should not modify its parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #7 from Victor Grousset/tuxayo --- Now that dependency bug 34117 is passed QA, this one can be too IIUC. Works (tests before implementation made it easy to check 👍), makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 02:50:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 00:50:47 +0000 Subject: [Koha-bugs] [Bug 34435] get_password_expiry_date should not modify its parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34435 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 03:05:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 01:05:44 +0000 Subject: [Koha-bugs] [Bug 34502] New: Useless SEARCH_RESULT.localimage usage Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34502 Bug ID: 34502 Summary: Useless SEARCH_RESULT.localimage usage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org In ./koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt the following line is useless: [% SEARCH_RESULT.localimage | html %] This hash key doesn't exist so it just renders nothing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 03:05:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 01:05:48 +0000 Subject: [Koha-bugs] [Bug 34502] Useless SEARCH_RESULT.localimage usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34502 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 03:07:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 01:07:51 +0000 Subject: [Koha-bugs] [Bug 34502] Useless SEARCH_RESULT.localimage usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34502 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 03:07:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 01:07:53 +0000 Subject: [Koha-bugs] [Bug 34502] Useless SEARCH_RESULT.localimage usage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34502 --- Comment #1 from David Cook --- Created attachment 154325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154325&action=edit Bug 34502: Remove useless SEARCH_RESULT.localimage This patch removes a useless Template Toolkit tag. To test: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=LocalCoverImages 2. Change to "Show" 3. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 4. Upload an image 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 6. Note that the local cover image appears even without the TT tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 03:25:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 01:25:08 +0000 Subject: [Koha-bugs] [Bug 34503] New: additional-contents.tt unnecessarily tests for languages.size Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34503 Bug ID: 34503 Summary: additional-contents.tt unnecessarily tests for languages.size Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Even if you only have 1 language on your system, you should always have at least 2 languages on your system (ie "default" and your install language). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 03:38:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 01:38:16 +0000 Subject: [Koha-bugs] [Bug 24125] Batch delete should not remove authorities that are still in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24125 --- Comment #7 from Phil Ringnalda --- Probably just need two choices for the radio button, unlink and delete, since we already have the don't delete option as a "Clear used authorities" link. FWIW, I use this feature precisely for what it currently does, delete an unwanted authority record and delete the bib fields using it, all the time. Having it removed rather than just put behind a radio button choice, so that I would have to decide each time between manually editing a bunch of bib records, or writing a targetted MARC modification template to delete any 100/600/700/800 or 110/610/710/810, etc., with a particular authid, would be a frustrating step backward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 03:53:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 01:53:24 +0000 Subject: [Koha-bugs] [Bug 34503] additional-contents.tt unnecessarily tests for languages.size In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34503 --- Comment #1 from David Cook --- Then again maybe I'm just misunderstanding what's going on there... I think we've got too much happening in the templates... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 03:55:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 01:55:03 +0000 Subject: [Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |phil at chetcolibrary.org --- Comment #4 from Phil Ringnalda --- Looks like you accidentally included something from work on another patch, since the hunk commenting out part of koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt doesn't fit this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 08:23:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 06:23:37 +0000 Subject: [Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WISHLIST |--- Status|RESOLVED |REOPENED --- Comment #20 from David Cook --- (In reply to Tomás Cohen Arazi from comment #12) > My vote would be: > - Use separate files with expected names (config.yaml, shibboleth.yaml, etc) > - No includes > - Have C4::Context->config rebuild the 'old structure we already have, and > deal with a different new handling on a separate bug (Koha::Config singleton > implementation?) > - Have a way for C4::Context->config to override any configuration if an env > variable exists. e.g. KOHA_DATABASE_NAME should override the relevant entry. > > My two cents as well These are still good ideas. I think we could do them with some very small changes to Koha/Config.pm. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 08:36:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 06:36:06 +0000 Subject: [Koha-bugs] [Bug 26790] Refactor Koha configuration (koha-conf.xml) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26790 --- Comment #21 from David Cook --- Tried to use Koha::Config->read_from_file($file) to create a data structure I wanted using XML but couldn't do it. Going to be much nicer to use YAML... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 08:51:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 06:51:36 +0000 Subject: [Koha-bugs] [Bug 34504] New: Elasticsearch error when updating mappings Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34504 Bug ID: 34504 Summary: Elasticsearch error when updating mappings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: michaela.sieber at kit.edu Since 23.05 it is not possible to add MARC fields to search fields in the Mapping table in staff interface. To recreate: Administration > Search engine configuration (Elasticsearch) Tab Bibliographic records: Add a new line , (e.g. abstract > 942v). See that in drop down for 'Sortable' you can select "1", "0", or "Undef" instead of "Yes" or "No". Click the "Add" Button - the line appears (last entry) Save. Error Message: " You attempted to delete all mappings for a required index, you must leave at least one mapping An error occurred when updating mappings: . " -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 09:04:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 07:04:56 +0000 Subject: [Koha-bugs] [Bug 34504] Elasticsearch error when updating mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 09:29:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 07:29:55 +0000 Subject: [Koha-bugs] [Bug 27443] Add an item loop mechanism to patron_emailer.pl cron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27443 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 09:35:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 07:35:53 +0000 Subject: [Koha-bugs] [Bug 5428] Back to results after deleting a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at trust-box.at Resolution|FIXED |--- Status|CLOSED |REOPENED --- Comment #20 from Mark Hofstetter --- the link 'Go back to the results' has disappeared at least up to 22.11.06.005 (maybe some changes in the js or the dom) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 09:36:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 07:36:26 +0000 Subject: [Koha-bugs] [Bug 34505] New: Patron invalid age in search_for_data_inconsistencies.pl should skip expired patrons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34505 Bug ID: 34505 Summary: Patron invalid age in search_for_data_inconsistencies.pl should skip expired patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Bug 26311 added patron invalid age in search_for_data_inconsistencies.pl But this is not relevant for expired patrons, especially in child categories. Check should skip expired patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 09:36:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 07:36:34 +0000 Subject: [Koha-bugs] [Bug 34505] Patron invalid age in search_for_data_inconsistencies.pl should skip expired patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34505 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26311 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 09:36:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 07:36:34 +0000 Subject: [Koha-bugs] [Bug 26311] Add patron invalid age to search_for_data_inconsistencies.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26311 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34505 [Bug 34505] Patron invalid age in search_for_data_inconsistencies.pl should skip expired patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 09:36:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 07:36:44 +0000 Subject: [Koha-bugs] [Bug 34505] Patron invalid age in search_for_data_inconsistencies.pl should skip expired patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34505 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 09:46:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 07:46:57 +0000 Subject: [Koha-bugs] [Bug 34505] Patron invalid age in search_for_data_inconsistencies.pl should skip expired patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34505 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 09:47:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 07:47:00 +0000 Subject: [Koha-bugs] [Bug 34505] Patron invalid age in search_for_data_inconsistencies.pl should skip expired patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34505 --- Comment #1 from Fridolin Somers --- Created attachment 154328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154328&action=edit Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons Bug 26311 added patron invalid age in search_for_data_inconsistencies.pl But this is not relevant for expired patrons, especially in child categories. Check should skip expired patrons 1) Set a non-expired patron with invalid age 2) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you see the patron 3) Edit patron to be expired 4) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you do not see the patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 09:55:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 07:55:16 +0000 Subject: [Koha-bugs] [Bug 5428] Back to results after deleting a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 --- Comment #21 from Katrin Fischer --- (In reply to Mark Hofstetter from comment #20) > the link 'Go back to the results' has disappeared at least up to > 22.11.06.005 (maybe some changes in the js or the dom) Hi Mark, please open a new bug and use the depends on to link to this one. Once something has been released, we always need a new bug for the patches. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 10:01:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 08:01:33 +0000 Subject: [Koha-bugs] [Bug 34506] New: After deleting record from a search result the link 'Go back to the results' has disappeared Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34506 Bug ID: 34506 Summary: After deleting record from a search result the link 'Go back to the results' has disappeared Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: koha at trust-box.at QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com As was implemented in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 the link 'Go back to the results' seems to have disappeared to test: 1. make a search in the staff interface eg "perl" 2. chose a record 3. delete it (maybe including items) 4. in 21.05 there was a link 'Go back to the results', which is no present in 21.11.06 thx mark -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 10:02:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 08:02:45 +0000 Subject: [Koha-bugs] [Bug 34506] After deleting record from a search result the link 'Go back to the results' has disappeared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34506 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at trust-box.at See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5428 Depends on| |5428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 [Bug 5428] Back to results after deleting a record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 10:02:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 08:02:45 +0000 Subject: [Koha-bugs] [Bug 5428] Back to results after deleting a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34506 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34506 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34506 [Bug 34506] After deleting record from a search result the link 'Go back to the results' has disappeared -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 10:24:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 08:24:16 +0000 Subject: [Koha-bugs] [Bug 34468] Add a progress callback to job_progress.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34468 --- Comment #6 from Pedro Amorim --- (In reply to David Nind from comment #5) > If you could add a test plan, I'll happily have a go at testing. > > For example, what it does, and what to expect before and after the patches > are applied. Hi David, thank you! These patches change the current updateProgress function to accept a progress callback (a function that is called every time the bar progresses) in addition to the already existing callback that is called when the progress bar finishes. It's not expected to change any current behavior in master because updateProgress is only used once in the stage marc import tool using the already existing callback, and these patches aim to keep that. I think the most appropriate test plan here is to make sure it doesn't break existing functionality, by using the test plan in bug 31666 : Test Plan: 1) Apply this patch 2) Stage a marc batch ( preferrably a large one to show the progress updating ) 3) Note the new progess bar, verify it functions correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 10:26:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 08:26:20 +0000 Subject: [Koha-bugs] [Bug 34364] Background job - Fix visual progress of progress bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34364 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com, | |jonathan.druart+koha at gmail. | |com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34468 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 10:26:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 08:26:20 +0000 Subject: [Koha-bugs] [Bug 34468] Add a progress callback to job_progress.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34468 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34364 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 10:26:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 08:26:59 +0000 Subject: [Koha-bugs] [Bug 34362] Stage MARC for import background job - Progress bar does not progress In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34362 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 10:31:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 08:31:17 +0000 Subject: [Koha-bugs] [Bug 34497] Vue - Dialog component should allow for confirmation input options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 --- Comment #3 from Pedro Amorim --- (In reply to Pedro Amorim from comment #2) > Currently missing cypress tests for this. Cypress tests will come in the ERM sushi submission, where the code that makes use of this exists. Coming up with a test patch for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 10:39:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 08:39:29 +0000 Subject: [Koha-bugs] [Bug 34497] Vue - Dialog component should allow for confirmation input options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 10:39:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 08:39:32 +0000 Subject: [Koha-bugs] [Bug 34497] Vue - Dialog component should allow for confirmation input options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 --- Comment #4 from Pedro Amorim --- Created attachment 154329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154329&action=edit Bug 34497: [DO NOT PUSH] Test patch only Test plan (Apply both patches, including TEST PATCH): 1) Go to ERM /cgi-bin/koha/erm/agreements 2) Add a new agreement, with whatever values 3) Go back to agreements list, click 'delete' on that agreement 4) Verify the confirmation dialog now shows 2 inputs from the test patch 5) Change the values in the inputs and confirm the dialog 6) Notice that not only the agreement gets deleted, but console now shows the values submitted 7) Bonus: Test both Text and Date input types and required: true or false -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 10:43:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 08:43:41 +0000 Subject: [Koha-bugs] [Bug 34468] Add a progress callback to job_progress.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34468 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 10:44:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 08:44:11 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 11:14:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 09:14:00 +0000 Subject: [Koha-bugs] [Bug 16652] Omnibus: RestfulAPI supporting services for Vufind and for xnciptoolkit drivers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|ASSIGNED |RESOLVED --- Comment #18 from Josef Moravec --- This patch is abandoned, rest api in Koha is moving forward and such an omnibus patch does not makes sense anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 15:00:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 13:00:29 +0000 Subject: [Koha-bugs] [Bug 34076] [ALTERNATE] [DOCS] Automated screenshots using Cypress.io testing framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34076 --- Comment #27 from Jonathan Druart --- (In reply to Caroline Cyr La Rose from comment #26) Caroline, you are awesome! :) I am looking forward to discuss all this with you in a few days in Helsinki, see you soon! During a talk next Wednesday I will suggest something to move forward with this topic, and maybe recruit new people :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 15:07:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 13:07:10 +0000 Subject: [Koha-bugs] [Bug 34489] Koha/Patrons.t: Subtests get_age and is_valid_age do not pass in another timezone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34489 --- Comment #4 from Marcel de Rooy --- This might be in the same category: t/db_dependent/api/v1/patrons.t not ok 6 - Filtering by date-time works # Failed test 'Filtering by date-time works' # at t/db_dependent/api/v1/patrons.t line 123. # got: undef # expected: '2253' my $last_seen_rfc3339 = $last_seen . "z"; $t->get_ok("//$userid:$password@/api/v1/patrons?last_seen=" . $last_seen_rfc3339 . "&cardnumber=" . $patron->cardnumber) >status_is(200) >json_is( '/0/patron_id' => $patron->id, 'Filtering by date-time works' ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 15:14:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 13:14:23 +0000 Subject: [Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #21 from Emily Lamancusa --- (In reply to Katrin Fischer from comment #20) > I perltidied the unit test file a little to make the QA test tools green. > Emily: remember to run "qa" on your branch before submitting and have a look > at how to use the our new perltidy file with your editor of choice > (https://wiki.koha-community.org/wiki/Perltidy) :) Thanks for the reminder! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 15:29:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 13:29:21 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforloan values as unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |emily.lamancusa at montgomeryc | |ountymd.gov CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 15:35:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 13:35:44 +0000 Subject: [Koha-bugs] [Bug 34505] Patron invalid age in search_for_data_inconsistencies.pl should skip expired patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34505 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 15:35:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 13:35:46 +0000 Subject: [Koha-bugs] [Bug 34505] Patron invalid age in search_for_data_inconsistencies.pl should skip expired patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34505 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154328|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose --- Created attachment 154330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154330&action=edit Bug 34505: Patron invalid age in search_for_data_inconsistencies.pl skip expired patrons Bug 26311 added patron invalid age in search_for_data_inconsistencies.pl But this is not relevant for expired patrons, especially in child categories. Check should skip expired patrons 1) Set a non-expired patron with invalid age 2) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you see the patron 3) Edit patron to be expired 4) Run misc/maintenance/search_for_data_inconsistencies.pl => Check you do not see the patron Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 15:59:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 13:59:16 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 --- Comment #11 from Nick Clemens --- Created attachment 154331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154331&action=edit Bug 33554: [WIP] Add a new lookup endpoint for patron searching This patch adds a new API lookup optoin for patrons. This endpoint takes three params: search_type - contains or starts with search_term - the string passed to search search_field - a comma separated string of fields to search The patron-search code is altered to pass these additional params, and the datatables code is updated to pass these params through The lookup code parses the attributes search directly, then adds it as a subquery to the results This should only affect patron/checkout searches - other patron searches are not changed at this time NOTE: In testing I noted that a search for a patron field plus an attribute returns nothing, but this is the same as existing code. i.e. patron Kenneth ABRAMS with SCHOOL attribute 'Oxford' is not returned for 'ken oxf' search WIP: Needs test coverage TO test: 1 - Add the sample borrowers and attributes to your DB 2 - Perform some patron searches 'ken' 'ken abr' 'oxford' 'ken oxford' 3 - Note the response times, most are slow 4 - Apply patch, restart all 5 - Repeat searches 6 - Note faster response times, but same results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 16:44:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 14:44:47 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 --- Comment #12 from Kyle M Hall --- I feel like we could greatly simplify and speed up patron searching by simply have a new table column or columns that exist solely to contain searchable content. We could even store this in JSON format and make use of JSON functions at a later date if possible. Here are the default patron search fields: firstname,middle_name,surname,othernames,cardnumber,userid Let's say I have a patron: Joe Gerald Patronson, esquire ( 123456789 ), jpatronson Upon editing, we could store the following: { firstname: "Joe", middle_name: "Gerald", surname: "Patronson", othernames: "esquire", cardnumber: "123456789", userid: "jpatronson", } Now, if we need to search the entire field we can do a LIKE ': "%%\n' for contains and LIKE ': "%\n' for begins with If we want to search for patrons with a firstname starting with J and surname containing son it would like like WHERE newcolumn LIKE 'firstname: "J%"\n' AND newcolumn LIKE 'surname: "%son%"\n' If we do this, we can have a single column to search and index. We can also add extended attributes to this by attribute code, for example: { firstname: "Joe", middle_name: "Gerald", surname: "Patronson", othernames: "esquire", cardnumber: "123456789", userid: "jpatronson", ATTR: "value1", ATTR: "value2", } Right now we cannot search on specific attributes, but that could easily be added using this system. This allows us to search all needed patron data without the need for complex joins. I think TINYTEXT might be a bit too small, but we could definitely be fine with TEXT and we can specify the length of the index as a reasonable number ( say 500 characters or so ). Thoughts? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 17:13:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 15:13:39 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforloan values as unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Emily Lamancusa --- The patch itself looks good and passes the qa script, but the unit doesn't quite test what it's supposed to. Please make the following adjustments to the test: - This bug addresses the use case where an item has a negative notforloan value *and* the circulation rule for on-shelf holds is set to "if any unavailable", so that circ rule should be set before running the test. As written, the test passes even without the patch because it's using the default setting of "yes". Please add code to set the circ rule to "if any unavailable" for the test (if needed, see t/db_dependent/Koha/CirculationRules.t for example) - Please change the failure message to describe what's being tested - Don't forget to perltidy the test file :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 17:42:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 15:42:47 +0000 Subject: [Koha-bugs] [Bug 34507] New: Add configuration for renaming of terms on the staff interface Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34507 Bug ID: 34507 Summary: Add configuration for renaming of terms on the staff interface Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: lisette.scheer at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be great if there was an interface for changing labels (surname -> last name, ILL -> Specific ILL partner etc) on the staff interface without using jquery that is easily accessible to library staff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 17:51:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 15:51:16 +0000 Subject: [Koha-bugs] [Bug 34497] Vue - Dialog component should allow for confirmation input options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154319|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim --- Created attachment 154332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154332&action=edit Bug 34497: Dialog component should allow for optional input options on confirmation modal Currently supports 'Text' or 'Date' inputs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 17:51:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 15:51:19 +0000 Subject: [Koha-bugs] [Bug 34497] Vue - Dialog component should allow for confirmation input options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34497 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154329|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim --- Created attachment 154333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154333&action=edit Bug 34497: [DO NOT PUSH] Test patch only Test plan (Apply both patches, including TEST PATCH): 1) Go to ERM /cgi-bin/koha/erm/agreements 2) Add a new agreement, with whatever values 3) Go back to agreements list, click 'delete' on that agreement 4) Verify the confirmation dialog now shows 2 inputs from the test patch 5) Change the values in the inputs and confirm the dialog 6) Notice that not only the agreement gets deleted, but console now shows the values submitted 7) Bonus: Test both Text and Date input types and required: true or false -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 18:07:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 16:07:32 +0000 Subject: [Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 18:19:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 16:19:40 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 --- Comment #13 from Jonathan Druart --- We can also resurrect bug 17500... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 18:20:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 16:20:05 +0000 Subject: [Koha-bugs] [Bug 34508] New: MARC modification templates have poor results when working with multiple of a field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34508 Bug ID: 34508 Summary: MARC modification templates have poor results when working with multiple of a field Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: ephetteplace at cca.edu QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 154334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154334&action=edit minimal example record MARC modification templates "copy and replace" actions struggle to modify records in an expected manner when there are multiple of the field being modified. There are at least two unexpected results: - a "copy and replace" on the "1st" of two fields results in the first field's modified subfield being copied to the second - using an "if" condition with either the "1st" or "all" fields also causes the first field's modified subfield to overwrite the second's subfield, even if the second does not meet the if condition I've attached a minimal MARC record with two 856 fields. The goal of a modification template should be to modify only the first "example.com" ‡u subfield while leaving the second untouched. However, both of these modification templates result in the second 856‡u being a copy of the first. 1) Copy and replace 1st field 856$u to 856$u using RegEx s/^http?s://example\.com/https://proxy.cca.edu/?url=https://example.com/ 2) Copy and replace field 856$u to 856$u using RegEx s/^http?s://example\.com/https://proxy.cca.edu/?url=https://example.com/ if 856$u matches RegEx m/https?://example\.com.*/ Original record: 245 _ _ ‡aTest record for MARC modification 856 4 0 ‡uhttps://example.com‡yProxy link 856 4 0 ‡uhttps://cca.edu‡yRetain link Expected outcome: 245 _ _ ‡aTest record for MARC modification 856 4 0 ‡uhttps://proxy.cca.edu/?url=https://example.com‡yProxy link 856 4 0 ‡uhttps://cca.edu‡yRetain link Actual outcome: 245 _ _ ‡aTest record for MARC modification 856 4 0 ‡uhttps://proxy.cca.edu/?url=https://example.com‡yProxy link 856 4 0 ‡uhttps://proxy.cca.edu/?url=https://example.com‡yRetain link Note that the second field's ‡y subfield is untouched. For template #1, I expect the second field not to be modified because it specifies only the "1st" MARC field. For template #2, I expect the second field not to be modified because it does not match the if condition. In BOTH templates, the regex substitution should not affect the second field, because it does not match the pattern. There was a thread on the Koha listserv between myself and Caroline Cyr La Rose from August 4th to August 9th, 2023 that may provide helpful details. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 18:40:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 16:40:48 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 --- Comment #5 from Emily Lamancusa --- Created attachment 154335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154335&action=edit Bug 34470: Initialize random seed after spawning a child worker process When background_jobs_worker.pl spawns a new child process, it needs to explicitly reinitialize the random seed - otherwise each child process will inherit the same random seed from the parent process, and any randomization will produce identical results each time. This patch adds a call to srand immediately after the fork to reinitialize the seed. Note that child processes should not call srand with no parameter anywhere else, as the Perl documentation indicates that srand should not be called with no parameter more than once per process. To test: 1. Apply the logging patch only 2. Set system preferences: a. RealTimeHoldsQueue -> Enable b. RandomizeHoldsQueueWeight -> in random order 3. Watch the logs for the staff interface in ktd: ktd --shell koha-intra-err 4. Place a hold. Note that the logs display the branch list before and after it is randomized. 5. Place some more holds. Note that the branch order after randomization is identical each time. 6. Apply both patches and restart_all 7. Repeat steps 3-5. -> Note that the branch order before randomization hasn't changed -> Note that the branch order after randomization is now different each time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 18:44:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 16:44:13 +0000 Subject: [Koha-bugs] [Bug 26802] Improve speed with records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802 Eileen Chandler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echandler at clamsnet.org --- Comment #12 from Eileen Chandler --- We still have a lot of print serials at our member libraries. We are a consortium with 38 locations. We've done a lot of work dividing these by year due to slow response time when opening a periodical record in Circulation (to check out) and, when adding a barcoded item in Cataloging for the latest periodical issue. We have approximately 100 bibliographic records with between 100 and 500 items attached. These are really slow to find and open. In a consortium setting it is reasonable to expect faster response time to search for and retrieve a bib record with many items attached and to open this kind of bib record in Cataloging to attach a barcoded item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 18:46:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 16:46:20 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154335|0 |1 is obsolete| | --- Comment #6 from Emily Lamancusa --- Created attachment 154336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154336&action=edit Bug 34470: Initialize random seed after spawning a child worker process When background_jobs_worker.pl spawns a new child process, it needs to explicitly reinitialize the random seed - otherwise each child process will inherit the same random seed from the parent process, and any randomization will produce identical results each time. This patch adds a call to srand immediately after the fork to reinitialize the seed. Note that child processes should not call srand with no parameter anywhere else, as the Perl documentation indicates that srand should not be called with no parameter more than once per process. To test: 1. Apply the logging patch only 2. Set system preferences: a. RealTimeHoldsQueue -> Enable b. RandomizeHoldsQueueWeight -> in random order 3. Watch the logs for the staff interface in ktd: ktd --shell koha-intra-err 4. Place a hold. Note that the logs display the branch list before and after it is randomized. 5. Place some more holds. Note that the branch order after randomization is identical each time. 6. Apply both patches and restart_all 7. Repeat steps 3-5. -> Note that the branch order before randomization hasn't changed -> Note that the branch order after randomization is now different each time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 18:50:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 16:50:16 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 18:50:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 16:50:27 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |emily.lamancusa at montgomeryc |ity.org |ountymd.gov -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 19:36:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 17:36:02 +0000 Subject: [Koha-bugs] [Bug 33666] Add facet for publication year In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33666 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10734 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 19:36:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 17:36:02 +0000 Subject: [Koha-bugs] [Bug 10734] Add Publication Date Facet in Searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10734 --- Comment #13 from Katrin Fischer --- *** Bug 33666 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 19:39:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 17:39:36 +0000 Subject: [Koha-bugs] [Bug 34509] New: Cannot create baskets of too many vendors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34509 Bug ID: 34509 Summary: Cannot create baskets of too many vendors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When creating a new basket, we load every existing vendor into a dropdown and allow the user to choose which library the basket is for. On systems with too many vendors, this can be problematic. We should either remove this, as you generally create a basket from preselected vendor, or use the api to load vendor options as needed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 19:50:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 17:50:20 +0000 Subject: [Koha-bugs] [Bug 34509] Cannot create baskets of too many vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34509 --- Comment #1 from Nick Clemens --- Created attachment 154337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154337&action=edit Bug 34509: Use select2 to load vendors on basket creation This patch moves the dropdown to use select2 and avoids loading all vendors at page load. To test: 1 - Create some extra vendors in your system, ideally over 20 2 - Search for a vendor in acquisitions 3 - Click 'New->basket' 4 - Note the dropdown of all vendors 5 - Choose a vendor and create a basket 6 - Apply patch 7 - Repeat 8 - Note only a partial list of vendors is loaded 9 - Search in the dropdown and confirm vendors are returned 10 - Select a vendor and create the basket -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 19:50:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 17:50:57 +0000 Subject: [Koha-bugs] [Bug 34509] Cannot create baskets of too many vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34509 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 19:51:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 17:51:15 +0000 Subject: [Koha-bugs] [Bug 34509] Cannot create baskets of too many vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34509 --- Comment #2 from Nick Clemens --- Something is wrong in my patch though, it won't save the selection, help? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 20:07:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 18:07:40 +0000 Subject: [Koha-bugs] [Bug 34510] New: connexion_import_daemon.pl should flush logs to make them more useful / timely Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34510 Bug ID: 34510 Summary: connexion_import_daemon.pl should flush logs to make them more useful / timely Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: JBoyer at equinoxOLI.org QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Created attachment 154338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154338&action=edit Flush Connexion Import Daemon Log The connexion_import_daemon.pl tool can output logs to the location specified in its config file, but because it uses buffered files (fine) and never flushes the buffer (not fine) the latest log entries are not available until additional records are submitted or the daemon is restarted and the log filehandle closed. The attached patch flushes the log only at the end of the request so the logs are usefully up to date without spamming i/o flushes on every call to log(). To test, pre-patch: 1. Export or locate a single marc record in binary format 2. Setup the connexion_import_daemon.pl as in https://koha-community.org/manual/19.11/en/html/third_party_software.html#oclc-connexion-gateway and take note of the logging location 3. Using Connexion or netcat, send the record to the specified port ( nc koha-host 8000 < recrd.mrc ) 4. Check the logfile configured in 2. It will likely end somewhere in the middle of the "Response: XYZ" output (probably somewhere in the middle of some marcxml) 5. Stop the daemon and verify that the remainder of the response is logged 6. Apply the patch 7. Restart the import daemon and resend the record from step 3 8. This time the full response should be logged as soon as the record is sent -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 20:13:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 18:13:14 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 20:13:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 18:13:16 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154336|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 154339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154339&action=edit Bug 34470: Initialize random seed after spawning a child worker process When background_jobs_worker.pl spawns a new child process, it needs to explicitly reinitialize the random seed - otherwise each child process will inherit the same random seed from the parent process, and any randomization will produce identical results each time. This patch adds a call to srand immediately after the fork to reinitialize the seed. Note that child processes should not call srand with no parameter anywhere else, as the Perl documentation indicates that srand should not be called with no parameter more than once per process. To test: 1. Apply the logging patch only 2. Set system preferences: a. RealTimeHoldsQueue -> Enable b. RandomizeHoldsQueueWeight -> in random order 3. Watch the logs for the staff interface in ktd: ktd --shell koha-intra-err 4. Place a hold. Note that the logs display the branch list before and after it is randomized. 5. Place some more holds. Note that the branch order after randomization is identical each time. 6. Apply both patches and restart_all 7. Repeat steps 3-5. -> Note that the branch order before randomization hasn't changed -> Note that the branch order after randomization is now different each time. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 20:14:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 18:14:04 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Passed QA --- Comment #8 from Nick Clemens --- Very small change, straightforward code, and excellently sleuthed! Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 20:14:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 18:14:13 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 21:46:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 19:46:36 +0000 Subject: [Koha-bugs] [Bug 30434] Convert catalog merge page tabs to Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30434 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33591 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 21:46:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 19:46:36 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30434 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 21:47:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 19:47:05 +0000 Subject: [Koha-bugs] [Bug 33591] Cannot merge bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33591 --- Comment #10 from Fridolin Somers --- I'd say this is more caused by Bug 30434 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 22:02:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 20:02:45 +0000 Subject: [Koha-bugs] [Bug 31127] By default sort suggestions from latest to oldest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31127 --- Comment #4 from Fridolin Somers --- Ah also Bug 32603 added a new column without changing default sorting column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 22:03:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 20:03:26 +0000 Subject: [Koha-bugs] [Bug 31127] By default sort suggestions from latest to oldest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31127 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32603 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32603 [Bug 32603] Suggester category in Suggestions management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 22:03:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 20:03:26 +0000 Subject: [Koha-bugs] [Bug 32603] Suggester category in Suggestions management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32603 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31127 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31127 [Bug 31127] By default sort suggestions from latest to oldest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 22:03:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 20:03:40 +0000 Subject: [Koha-bugs] [Bug 34511] New: Typo in manage_staged_records permission description Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34511 Bug ID: 34511 Summary: Typo in manage_staged_records permission description Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com While translating, I noticed there is a typo in the description of the manage_staged_records permission. All other permission descriptions are in the present tense, but this one is in the past tense. Managed staged MARC records, including completing and reversing imports (manage_staged_marc) For example, compared to Stage MARC records into the reservoir (stage_marc_import) To recreate: 1. Go to any patron record 2. Click More > Set permissions 3. Click Show details next to the Use all tools permission --> Notice all descriptions start with a present tense verb except Managed staged MARC records A simple slip of the finger! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 22:23:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 20:23:23 +0000 Subject: [Koha-bugs] [Bug 34511] Typo in manage_staged_records permission description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34511 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 22:23:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 20:23:25 +0000 Subject: [Koha-bugs] [Bug 34511] Typo in manage_staged_records permission description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34511 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 154340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154340&action=edit Bug 34511: Typo in manage_staged_records permission description This patch corrects a typo in the description of the manage_staged_records permission. All other permission descriptions are in the present tense, but this one is in the past tense. To test: 0. Apply the patch 1. Go to any patron record 2. Click More > Set permissions 3. Click Show details next to the Use all tools permission 4. Read the description for the manage_staged_records permission, make sure the spelling and grammar are correct -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 22:23:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 20:23:37 +0000 Subject: [Koha-bugs] [Bug 34511] Typo in manage_staged_records permission description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34511 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 22:24:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 20:24:14 +0000 Subject: [Koha-bugs] [Bug 34511] Typo in manage_staged_records permission description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34511 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch corrects a typo release notes| |in the description of the | |manage_staged_records | |permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 22:30:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 20:30:55 +0000 Subject: [Koha-bugs] [Bug 34458] It should be possible to change the pickup location for in transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34458 --- Comment #1 from Emily Lamancusa --- My understanding is the OPAC feature didn't add any new workflows or reporting under the assumption that, once the item was in transit, it wasn't going to be touched until it got to its destination anyway. Then when the item is checked in at its destination, the check-in function already handles checking the hold pickup location, initiating a new transfer, and notifying the staff member while they have the item in their hand so they can send it along to its new destination. It seems to me like doing this in the staff interface wouldn't need any new workflows for the same reason (other than perhaps a confirmation modal). A patron notification would be a good idea to minimize the chances of the patron looking for their item at the wrong branch. I'm not sure about reporting. I don't think we have a use case for it, but I can't speak for anyone else. The OPAC feature has a syspref that allows libraries to decide which statuses (Pending, Suspended, and/or In-Transit) permit pickup location changes via OPAC, so there should probably be a similar syspref for the staff-side feature for consistency. I see a couple of folks from libraries following this bug - any of you want to weigh in? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 22:49:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 20:49:30 +0000 Subject: [Koha-bugs] [Bug 34509] Cannot create baskets of too many vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34509 --- Comment #3 from Lucas Gass --- Created attachment 154341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154341&action=edit Bug 34509: Make select2 dropdown populate on change -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 22:52:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 20:52:23 +0000 Subject: [Koha-bugs] [Bug 34509] Cannot create baskets of too many vendors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34509 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 9 23:01:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Aug 2023 21:01:17 +0000 Subject: [Koha-bugs] [Bug 34512] New: "Changed" flag and Reset link missing when changing matching rules in manage marc import page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34512 Bug ID: 34512 Summary: "Changed" flag and Reset link missing when changing matching rules in manage marc import page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 154342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154342&action=edit Sample MARC21 file When importing MARC records, it's possible to change the matching rule after the records are staged. Before, if we changed the option, there was a "Changed" flag with a "Reset" link next to the changed option. It seems the flag is still in the .tt file, but it doesn't show on the screen in the staff interface. To recreate: 1. Stage a MARC file (I attached one in case you don't have any handy) 1.1. Go to Cataloging > Stage records for import 1.2. Choose a marc file and click Upload file 1.3. Click Stage for import 2. View the staged file 2.1. Click "View lot" or go to Cataloging > Managed staged records and click on the file name 3. Change matching options --> No Changed flag or Reset option I checked in 22.05 and Emily checked in 22.11 and the flag is there. In 23.05 and master, the flag doesn't show. In the koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt file, around line 83 Changed. Reset -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 02:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 00:43:12 +0000 Subject: [Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 02:43:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 00:43:15 +0000 Subject: [Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153790|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 154343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154343&action=edit Bug 34340: Changed "Tendered" to the correct input id which is "Collected" Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 02:48:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 00:48:04 +0000 Subject: [Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154343|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 154344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154344&action=edit Bug 34340: Changed "Tendered" to the correct input id which is "Collected" Must also apply bug 34332 - fixed a syntax error for the pos email template To test: 1. Configure your Koha to enable the point of sale system (i.e. enable syspref, set up a register, set up an item to sell). 2. Complete a transaction in the POS system. 3. Click on the “Email receipt” button next to the “Print receipt” option and enter an email address and confirm that the email is sent. 4. Check the “Tendered” field. It is showing up as 0.00 and not reflecting the actual amount that was tendered. 5. Apply patch 6. Repeat steps 2 & 3 7. The emailed receipt is now showing the correct tendered amount. 8. Sign off! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 02:49:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 00:49:33 +0000 Subject: [Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Not sure what happened, but when I did the git bz attach -e 34340 HEAD, the text of the bug including the test plan was not included. I amended the commit message and reattached. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 03:00:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 01:00:38 +0000 Subject: [Koha-bugs] [Bug 34340] Point of Sale email template is showing 0.00 in the Tendered field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 --- Comment #5 from David Nind --- Testing notes (using KTD): 1. Needed to set up KTD so that email could be sent.[1] 2. For the updated notice to appear, I needed to do a reset_all then setup POS again. I'm not sure how this will affect upgrades, or if there is a way for updated notices to be applied - does this require a database update as well? 3. In additional, while this does fix the problem, all the other fields in the email notice are empty.[2] This was the case before the patch was applied. Does this need a separate bug to fix this? I have also included the notice as it is for me after the patch in KTD.[3] [1] To test sending emails using a Google account, edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where = your Google email address; = your APP password, not your Google account password): smtp.gmail.com 587 5 STARTTLS GOOGLEACCOUNTUSER GOOGLEAPPPASSWORD 1 [2] Email notice with Tendered amount fixed: Transaction ID: Operator ID: Payment type: Payment receipt Description of charges Amount Total: 0.00 Tendered: 30.00 Change given: 0.00 [3] Current email notice (HTRML) for Point of sale receipt: [% USE KohaDates %] [% USE Branches %] [% USE Price %] [% PROCESS "accounts.inc" %] [% IF ( LibraryName ) %] [% END %] [% IF credit.library %] [% END %] [% FOREACH offset IN payment.credit_offsets %] [% END %]

[% LibraryName | html %]

[% payment.library.branchname | html %]

[% payment.date | $KohaDates %]
Transaction ID: [% payment.accountlines_id %]
Operator ID: [% payment.manager_id %]
Payment type: [% payment.payment_type %]

Payment receipt
Description of charges Amount
[% PROCESS account_type_description account=debit %] [% debit.amount * -1 | $Price %]
Total: [% payment.amount * -1 | $Price %]
Tendered: [% collected | $Price %]
Change given: [% change | $Price %]
-- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 09:16:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 07:16:19 +0000 Subject: [Koha-bugs] [Bug 31127] By default sort suggestions from latest to oldest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31127 Emmanuel Bétemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 09:18:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 07:18:17 +0000 Subject: [Koha-bugs] [Bug 27443] Add an item loop mechanism to patron_emailer.pl cron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27443 --- Comment #6 from Ray Delahunty --- We are using the Koha patron emailer (introduced in 19.05) rather than the Bywater plugin for our leavers (chasing them before they leave for items on loan to be returned) and have been trying to use template toolkit inside the notice so it can send different wordings to different patron groups (like we have it doing for MEMBERSHIP_EXPIRY, for example), but the testing has failed. Had it worked, our plan was to try the [% FOREACH checkout IN checkouts %] loop from the AUTO_RENEWAL_DGST to improve the horrid word-wrapped list of items on loan, pulled from the report. Our support company said: "the patron emailer doesn't yet support HTML, and I highly doubt that it would support template toolkit either". Might the answer be to improve the patron emailer so it accepts TT (and also html)? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 10:27:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 08:27:59 +0000 Subject: [Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #187 from Matt Blenkinsop --- Thanks for persevering on this one Cait! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 13:41:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 11:41:49 +0000 Subject: [Koha-bugs] [Bug 34442] Info around CSV export profiles edition not correct for sql option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34442 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk --- Comment #2 from Ray Delahunty --- Let me be the first person to add here that we really do need more fields able to be added to the late issue claims csv export. (Actually Thibaud, in 22.11 and 21.11 we are able to add subscription.branchcode). But **at least**, we would want subtitle, and we are considering using callnumber to house the vendor's own vendor number, as the note and the internalnote fields are already used locally. (And we can't even add the subscription.note field to the csv export). Or if we created a 'vendornum' field in the additional_fields table, it would be great to be able to pull the vendornum data from there into the csv file for shipping to the vendor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 13:53:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 11:53:40 +0000 Subject: [Koha-bugs] [Bug 22018] Add an option to 'AllowEarlyRenewal' to enable users to renew before the autorenew date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22018 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 13:53:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 11:53:53 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 14:20:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 12:20:55 +0000 Subject: [Koha-bugs] [Bug 31357] Separate holds history from intranetreadinghistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31357 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Version|21.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 15:11:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 13:11:15 +0000 Subject: [Koha-bugs] [Bug 33759] Typo: Thankyou In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 15:32:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 13:32:13 +0000 Subject: [Koha-bugs] [Bug 34149] Syndetics cover images don't load in staff interface detail page if other images services are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com --- Comment #1 from Laura Escamilla --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 15:55:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 13:55:54 +0000 Subject: [Koha-bugs] [Bug 34511] Typo in manage_staged_records permission description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34511 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154340|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 154345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154345&action=edit Bug 34511: Typo in manage_staged_records permission description This patch corrects a typo in the description of the manage_staged_records permission. All other permission descriptions are in the present tense, but this one is in the past tense. To test: 0. Apply the patch 1. Go to any patron record 2. Click More > Set permissions 3. Click Show details next to the Use all tools permission 4. Read the description for the manage_staged_records permission, make sure the spelling and grammar are correct Signed-off-by: hebah -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 15:56:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 13:56:39 +0000 Subject: [Koha-bugs] [Bug 34511] Typo in manage_staged_records permission description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34511 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #3 from hebah at bywatersolutions.com --- Typo fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 16:00:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 14:00:53 +0000 Subject: [Koha-bugs] [Bug 34149] Syndetics cover images don't load in staff interface detail page if other images services are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 --- Comment #2 from Lucas Gass --- The #syndetics-bookcoverimg is prematurely removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 16:15:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 14:15:18 +0000 Subject: [Koha-bugs] [Bug 32554] Test prediction pattern does not consider subscription length (uses only subscription end date) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32554 Dani Elder changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle.elder at law.utexas.e | |du -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 16:43:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 14:43:50 +0000 Subject: [Koha-bugs] [Bug 33886] Flatpickr calendar - year controls for date of birth on memberentry.pl are not intuitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33886 --- Comment #2 from Sally --- Is it possible to launch flatpickr with a different date, rather than today? It wouldn't resolve the problem, but it would mitigate it slightly. If it initiated say, 20 years ago, rather than with the current date, at least every user can select their date and month - and then they can try to work out the year controls after. At the moment, if you try to join on the OPAC (or via the staff client) and your birthday is the 20th of November, you have to change the year first - whilst those born on the 4th of April don't. It's not intuitive. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 16:49:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 14:49:09 +0000 Subject: [Koha-bugs] [Bug 16544] Changes to circ rules should be logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16544 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:08:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:08:01 +0000 Subject: [Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 Fabricio Molina changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153185|0 |1 is obsolete| | --- Comment #11 from Fabricio Molina --- Created attachment 154346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154346&action=edit Bug 28805: Add on-site checkout checkbox in batch checkout Add the 'on-site checkout' checkbox to the 'Batch checkout'. To verify the functionality, follow these steps: 1) Before the modification is added, enable the 'OnSiteCheckouts' and 'BatchCheckout' system preferences. 2) In the 'BatchCheckoutsValidCategories' preference, select all categories. 3) Find a user in the system. For example, Henry Acevedo. 4) In the 'Check out' section, you can see that the 'Checkout settings' option displays the 'On-site Checkout' checkbox when clicked. 5) Check the 'On-site checkout' option. This will display the current date with a runtime deadline of 23:59. 6) Enter a barcode (for example 39999000011418). 7) Click the 'Check out' button. This will show that the loan was made on-site. 8) Check the 'Batch checkout' section. This section does not hace the 'On-site checkout' checkbox. When loading the patch with the addition of the 'on-site checkout' checkbox in 'Batch checkout' starting from step 3), you can already find the checkbox in the 'Batch checkout' section. To use it, you can try the barcodes 39999000006179 and 39999000008494 together. Then continue from step 5). When viewing the loans, you will see that both items (39999000006179 and 39999000008494) will appear with the label 'On-site checkout'. If this patch is deactivated, the functionality will remain the same as it was before this change. Sponsored-by: Banco Central de la República Argentina Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:13:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:13:28 +0000 Subject: [Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 Fabricio Molina changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:19:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:19:19 +0000 Subject: [Koha-bugs] [Bug 28805] Batch checkout should have on-site checkout option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28805 --- Comment #12 from Fabricio Molina --- Hi Thanks for your feedback and suggestions. In this fix, the "OnSiteCheckouts" preference can be used without depending on the "SpecifyDueData" preference. Regarding the functionality of being able to modify the preselected due date, I used the same behavior that on-site checkout has for individual loans (the preselected date can also be modified there). I look forward to any feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:24:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:24:20 +0000 Subject: [Koha-bugs] [Bug 29930] Auth with LDAP: Update tag leads to unwanted updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29930 Alexander Wagner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130926|0 |1 is obsolete| | --- Comment #6 from Alexander Wagner --- Created attachment 154347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154347&action=edit Bug 29930: Auth with LDAP: Update tag leads to unwanted updates In the sub the userId was given, but the cardnumber was expected, therefore at every login the cardnumber changed to the userId. To test: 1. Login to the OPAC with an LDAP account that has a cardnumber which is different to the userId 2. Check the patron record's cardnumber. 3. The cardnumber should equal to the userId 4. Apply the patch. 5. Login to the OPAC with an LDAP account that has a cardnumber which is different to the userId 6. Check the patron record's cardnumber. 7. The cardnumber should be the same as before Signed-off-by: Alexander Wagner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:31:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:31:59 +0000 Subject: [Koha-bugs] [Bug 32530] When duplicating child card, guarantor is not saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32530 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:44:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:44:09 +0000 Subject: [Koha-bugs] [Bug 34356] Enabling RecordStaffUserOnCheckout causes bad default sorting in checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34356 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:44:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:44:50 +0000 Subject: [Koha-bugs] [Bug 23641] Checkout via camera on device In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:45:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:45:10 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:46:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:46:28 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:47:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:47:45 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:55:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:55:15 +0000 Subject: [Koha-bugs] [Bug 30981] Add option to configure preferred pronouns as a pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30981 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:55:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:55:42 +0000 Subject: [Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:56:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:56:54 +0000 Subject: [Koha-bugs] [Bug 34248] Curbside pickup times should follow TimeFormat preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34248 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:59:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:59:16 +0000 Subject: [Koha-bugs] [Bug 19814] Batch Check-in function In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:59:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:59:19 +0000 Subject: [Koha-bugs] [Bug 34356] Enabling RecordStaffUserOnCheckout causes bad default sorting in checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34356 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 17:59:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 15:59:24 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:02:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:02:50 +0000 Subject: [Koha-bugs] [Bug 34472] Template Toolkit reference guide needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:03:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:03:27 +0000 Subject: [Koha-bugs] [Bug 30981] Add option to configure preferred pronouns as a pull down In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30981 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:04:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:04:30 +0000 Subject: [Koha-bugs] [Bug 33397] Adding custom authorized values for bsort1/bsort2 can result in data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33397 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:05:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:05:05 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 --- Comment #14 from Kyle M Hall --- (In reply to Jonathan Druart from comment #13) > We can also resurrect bug 17500... I think that's the best idea. It's gonna take time though, assuming you are interesting in picking it back up. If you are I'd be happy to help how I can! In the mean time we can try to get a quick fix that gets us to acceptable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:05:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:05:23 +0000 Subject: [Koha-bugs] [Bug 34248] Curbside pickup times should follow TimeFormat preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34248 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:05:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:05:27 +0000 Subject: [Koha-bugs] [Bug 32256] Self checkout batch mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32256 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:05:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:05:46 +0000 Subject: [Koha-bugs] [Bug 20653] Issue expected from irregularities don't display right month In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20653 --- Comment #5 from Esther Melander --- Created attachment 154348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154348&action=edit Serial chronology display error In reference to my comments on 8/3, the display error persists in the detail/normal view of the biblio with the items. It is possible to edit the item record to the correct name either at receiving or after receiving. If the item's serial/chronology data is edited after receiving, the detail view is not updated. Attached image. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:08:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:08:15 +0000 Subject: [Koha-bugs] [Bug 34460] Patron category should regulate if account can have permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34460 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:09:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:09:19 +0000 Subject: [Koha-bugs] [Bug 25996] Changes to restrictions should be logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:10:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:10:08 +0000 Subject: [Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:14:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:14:43 +0000 Subject: [Koha-bugs] [Bug 7335] Allow custom parameters for sorting in SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7335 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:15:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:15:48 +0000 Subject: [Koha-bugs] [Bug 25912] Any lost value triggers refund message on check in, even if it doesn't apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25912 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:17:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:17:06 +0000 Subject: [Koha-bugs] [Bug 6961] runtime parameter for fund codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6961 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:17:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:17:26 +0000 Subject: [Koha-bugs] [Bug 12709] Send a custom email to some or all patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12709 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:18:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:18:30 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:19:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:19:45 +0000 Subject: [Koha-bugs] [Bug 5920] Remove HTML from downloaded reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:30:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:30:06 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 --- Comment #15 from Nick Clemens --- If this approach looks reasonable then I will write tests, and update to fix the attribute search. Just let me know if I should put this time in -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:30:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:30:57 +0000 Subject: [Koha-bugs] [Bug 18147] Show cover images in public lists in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18147 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:33:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:33:10 +0000 Subject: [Koha-bugs] [Bug 26802] Improve speed with records with many items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26802 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:36:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:36:05 +0000 Subject: [Koha-bugs] [Bug 34507] Add configuration for renaming of terms on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34507 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 18:36:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 16:36:43 +0000 Subject: [Koha-bugs] [Bug 34149] Syndetics cover images don't load in staff interface detail page if other images services are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 19:01:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 17:01:47 +0000 Subject: [Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 19:29:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 17:29:32 +0000 Subject: [Koha-bugs] [Bug 34149] Syndetics cover images don't load in staff interface detail page if other images services are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 --- Comment #3 from Lucas Gass --- This is because when Amazon is used there is a check for 1px by 1px images inside of detail.tt. Then, without a visible syndetics image the entire container is removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 19:33:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 17:33:07 +0000 Subject: [Koha-bugs] [Bug 34149] Syndetics cover images don't load in staff interface detail page if other images services are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 19:33:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 17:33:11 +0000 Subject: [Koha-bugs] [Bug 34149] Syndetics cover images don't load in staff interface detail page if other images services are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 --- Comment #4 from Lucas Gass --- Created attachment 154349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154349&action=edit Bug 34149: Let Syndetics images show when Amazon returns 1px images 1. Turn on Syndetics 2. Set AmazonCoverImages to show 3. Go to a record detail page that has a Syndetics image but no Amazon image. In KTD I am using bib 181. 4. The image never loads. 5. Apply patch 6. Try again, the image should load. 7. Try records that have both Amazon and Syndetics images making sure it loads correctly in the lightbox. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 19:33:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 17:33:43 +0000 Subject: [Koha-bugs] [Bug 34149] Syndetics cover images don't load in staff interface detail page if other images services are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 19:33:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 17:33:58 +0000 Subject: [Koha-bugs] [Bug 34149] Syndetics cover images don't load in staff interface detail page if other images services are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 19:34:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 17:34:20 +0000 Subject: [Koha-bugs] [Bug 34149] Syndetics cover images don't load in staff interface detail page if other images services are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 --- Comment #5 from Lucas Gass --- I'm not 100% sure about this patch, so CC'ing Owen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 20:20:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 18:20:39 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30645 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 20:20:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 18:20:39 +0000 Subject: [Koha-bugs] [Bug 30645] Patron search not building the query correctly for extended attributes if several terms passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33554 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 20:30:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 18:30:00 +0000 Subject: [Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33428 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 20:30:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 18:30:00 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33554 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 20:49:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 18:49:33 +0000 Subject: [Koha-bugs] [Bug 34514] New: opac-showmarc.pl does not handle UNIMARC well Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 Bug ID: 34514 Summary: opac-showmarc.pl does not handle UNIMARC well Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org opac-showmarc.pl calls $record->as_xml. We see in other places using XSL transformation that MARC flavor should be sent. Looks like encoding fails when a "real" UTF-8 character is used. For example É Bug 29333 fixed catalogue/showmarc.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 20:49:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 18:49:47 +0000 Subject: [Koha-bugs] [Bug 34514] opac-showmarc.pl does not handle UNIMARC well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 20:49:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 18:49:56 +0000 Subject: [Koha-bugs] [Bug 34514] opac-showmarc.pl does not handle UNIMARC well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29333 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 20:49:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 18:49:56 +0000 Subject: [Koha-bugs] [Bug 29333] Importing UNIMARC authorities in MARCXML UTF-8 breaks the encoding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34514 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 20:52:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 18:52:42 +0000 Subject: [Koha-bugs] [Bug 30324] Parent and child itemtype checkout limits not enforced as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30324 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 20:57:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 18:57:39 +0000 Subject: [Koha-bugs] [Bug 34514] opac-showmarc.pl does not handle UNIMARC well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 20:57:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 18:57:42 +0000 Subject: [Koha-bugs] [Bug 34514] opac-showmarc.pl does not handle UNIMARC well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 --- Comment #1 from Fridolin Somers --- Created attachment 154350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154350&action=edit Bug 34514: opac-showmarc.pl does not handle UNIMARC well opac-showmarc.pl calls $record->as_xml. We see in other places using XSL transformation that MARC flavor should be sent. Looks like encoding fails when a "real" UTF-8 character is used. For example uppercase é Bug 29333 fixed catalogue/showmarc.pl. Test plan : 1) Use UNIMARC database 2) Edit a biblio record to add uppercase é in title 200$a 3) Go to OPAC MARC vue of this record 4) Download record as MARCXML => Check encoding of title is OK 5) Click on 'view plain' => Check encoding of title is OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:01:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:01:10 +0000 Subject: [Koha-bugs] [Bug 34514] opac-showmarc.pl does not handle UNIMARC well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154350|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 154351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154351&action=edit Bug 34514: opac-showmarc.pl use marc flavour opac-showmarc.pl calls $record->as_xml. We see in other places using XSL transformation that MARC flavor should be sent. Looks like encoding fails when a "real" UTF-8 character is used. For example uppercase é Bug 29333 fixed catalogue/showmarc.pl. Test plan : 1) Use UNIMARC database 2) Edit a biblio record to add uppercase é in title 200$a 3) Go to OPAC MARC vue of this record 4) Download record as MARCXML => Check encoding of title is OK 5) Click on 'view plain' => Check encoding of title is OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:02:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:02:46 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:02:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:02:48 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 --- Comment #3 from Nick Clemens --- Created attachment 154352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154352&action=edit Bug 33428: Parse search fields in buildPatronSearchQuery This patch moves the parsing of standard search_field into the buildPatronQuery subroutine and adds a check for 'standard' field before adding attributes to the search To test: 1 - Add a new attribute type and make it searchable 2 - Add a value to a patron 3 - Search for this value using 'Standard' fields, confirm you get the patron 4 - Search for the value using 'Cardnumber' field, confirm you get the patron - BAD! 5 - Apply patch 6 - Repeat cardnumebr search, confirm patron not found - Yay! 7 - Search standard, confirm patron is found 8 - Add a new field to 'DefaultPatronSearchFields 9 - Confirm it appears in patron search dropdown 10 - Confirm a search of this field with the attribute value does not return the patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:03:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:03:07 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolin.somers at biblibre.co |nick at bywatersolutions.com |m | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:03:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:03:32 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 --- Comment #4 from Nick Clemens --- Frido, I stole this, apologies, feel free to provide an alternate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:15:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:15:10 +0000 Subject: [Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34514 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:15:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:15:10 +0000 Subject: [Koha-bugs] [Bug 34514] opac-showmarc.pl does not handle UNIMARC well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32336 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:30:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:30:40 +0000 Subject: [Koha-bugs] [Bug 34515] New: MARCXML output of OAI-PMH may be badly encoded (UNIMARC) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34515 Bug ID: 34515 Summary: MARCXML output of OAI-PMH may be badly encoded (UNIMARC) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Like fixed for REST API, OAI-PMH output should be fixed to use metadata schema when building MARCXML. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:30:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:30:52 +0000 Subject: [Koha-bugs] [Bug 34515] MARCXML output of OAI-PMH may be badly encoded (UNIMARC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34515 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336 [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:30:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:30:52 +0000 Subject: [Koha-bugs] [Bug 32336] MARCXML output of REST API may be badly encoded (UNIMARC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32336 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34515 [Bug 34515] MARCXML output of OAI-PMH may be badly encoded (UNIMARC) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:31:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:31:00 +0000 Subject: [Koha-bugs] [Bug 34515] MARCXML output of OAI-PMH may be badly encoded (UNIMARC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34515 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:31:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:31:39 +0000 Subject: [Koha-bugs] [Bug 34515] MARCXML output of OAI-PMH may be badly encoded (UNIMARC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34515 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:37:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:37:51 +0000 Subject: [Koha-bugs] [Bug 34515] MARCXML output of OAI-PMH may be badly encoded (UNIMARC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34515 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:37:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:37:54 +0000 Subject: [Koha-bugs] [Bug 34515] MARCXML output of OAI-PMH may be badly encoded (UNIMARC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34515 --- Comment #1 from Fridolin Somers --- Created attachment 154353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154353&action=edit Bug 34515: Fix encoding of MARCXML output for REST API (UNIMARC) Like fixed for REST API, OAI-PMH output should be fixed to use metadata schema when building MARCXML. Test plan : 1) Use UNIMARC database 2) Enable OAI-PMH webservice 3) Edit a biblio record to add uppercase éin title 200$a 4) Go to OAI record : /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=xxx => Check encoding of title is OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 21:40:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 19:40:45 +0000 Subject: [Koha-bugs] [Bug 34515] MARCXML output of OAI-PMH may be badly encoded (UNIMARC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34515 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154353|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 154354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154354&action=edit Bug 34515: Fix encoding of MARCXML output for OAI-PMH (UNIMARC) Like fixed for REST API, OAI-PMH output should be fixed to use metadata schema when building MARCXML. Test plan : 1) Use UNIMARC database 2) Enable OAI-PMH webservice 3) Edit a biblio record to add uppercase éin title 200$a 4) Go to OAI record : /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=xxx => Check encoding of title is OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 22:24:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 20:24:54 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 --- Comment #5 from Fridolin Somers --- (In reply to Nick Clemens from comment #4) > Frido, I stole this, apologies, feel free to provide an alternate Your welcome :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 22:35:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 20:35:08 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 22:35:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 20:35:11 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154352|0 |1 is obsolete| | --- Comment #6 from Fridolin Somers --- Created attachment 154355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154355&action=edit Bug 33428: Parse search fields in buildPatronSearchQuery This patch moves the parsing of standard search_field into the buildPatronQuery subroutine and adds a check for 'standard' field before adding attributes to the search To test: 1 - Add a new attribute type and make it searchable 2 - Add a value to a patron 3 - Search for this value using 'Standard' fields, confirm you get the patron 4 - Search for the value using 'Cardnumber' field, confirm you get the patron - BAD! 5 - Apply patch 6 - Repeat cardnumebr search, confirm patron not found - Yay! 7 - Search standard, confirm patron is found 8 - Add a new field to 'DefaultPatronSearchFields 9 - Confirm it appears in patron search dropdown 10 - Confirm a search of this field with the attribute value does not return the patron Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 22:36:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 20:36:27 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 --- Comment #7 from Fridolin Somers --- Works great. I signed and removed unnecessary empty line addition in staff-global.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 10 23:25:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 21:25:01 +0000 Subject: [Koha-bugs] [Bug 34516] New: Upgrade database fails for 22.11.07.003, points to web installer Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34516 Bug ID: 34516 Summary: Upgrade database fails for 22.11.07.003, points to web installer Change sponsored?: --- Product: Koha Version: 22.11 Hardware: PC OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: dcowens76 at gmail.com QA Contact: testopia at bugs.koha-community.org Following an upgrade to 22.11.07.003 on Ubuntu 22.04, the upgrade fails and the staff interface goes to the web installer. Following advice on the community list, I ran the following commands to try to resolve the issue, with the output following: $ sudo service memcached restart $ sudo koha-upgrade-schema [instance name] Upgrading database schema for [instance name] Upgrade to 22.11.07.003 [14:01:47]: Bug 34029 - Extend datatypes in biblioitems and deletedbiblioitems tables to avoid import errors Updated biblioitems.place to text Updated deletedbiblioitems.place to text ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: BLOB/TEXT column 'publishercode' used in key specification without a key length at /usr/share/koha/lib/C4/Installer.pm line 741 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 01:02:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Aug 2023 23:02:13 +0000 Subject: [Koha-bugs] [Bug 25667] Add field for items.notforloan_on to record when a notforloan status is applied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667 Bea changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 CC| |bbjoerklund at santabarbaraca. | |gov --- Comment #2 from Bea --- We are also interested in this, particularly to know when items arrive. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 02:57:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 00:57:57 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154294|0 |1 is obsolete| | --- Comment #14 from Victor Grousset/tuxayo --- Created attachment 154356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154356&action=edit Bug 34469: Block editing for received order lines When an already received order line is modified/edited, we experience data loss. Most prominently, we will lose the linked invoiceid. Therefore we should not allow editing an order line that was already received. If something needs to be changed, the receipt should be cancelled first. To test: * Create basket as standing order with items added in cataloguing * Add an order line * Receive shipment * Go to the basket summary page, click on 'Modify' * Change the actual cost * Save * Verify that the invoice is now empty * In the database aqorders.invoiceid will be NULL * Apply patch * Receive another shipment for the standing order * Go back to basket summary page * Verify the 'Modify' link is no longer present * Click 'Modify' on the unreceived order line * Edit the URL parameter odernumber to have the number of an already received order line * Verify you see a nice error message: This order cannot be edited, the basket is closed or the order was already received. Signed-off-by: Sam Lau Signed-off-by: Michaela Sieber Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 02:58:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 00:58:37 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #15 from Victor Grousset/tuxayo --- Added Laura's signoff :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 03:27:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 01:27:27 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 05:43:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 03:43:18 +0000 Subject: [Koha-bugs] [Bug 34119] After redesign, print.css no longer hides things at the top of report results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 05:44:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 03:44:32 +0000 Subject: [Koha-bugs] [Bug 34119] After redesign, print.css no longer hides things at the top of report results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|phil at chetcolibrary.org |oleonard at myacpl.org Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 07:10:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 05:10:59 +0000 Subject: [Koha-bugs] [Bug 34143] "no attempt to encode" (|||) in the language facet doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34143 --- Comment #7 from Päivi Knuutinen --- > See here: > "No attempt to encode" (|||) in MARC controlfield 008 character places > 35-37." > https://www.loc.gov/marc/bibliographic/bd008a.html > > Maybe we should just exclude them from the language facets? That is ok with me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 08:55:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 06:55:41 +0000 Subject: [Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #70 from Frédéric Demians --- It would be nice to have this functionnality with more granularity, not with a global system preference, but with a SIPconfig.xml parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 09:45:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 07:45:02 +0000 Subject: [Koha-bugs] [Bug 32306] Hold modifications don't log correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32306 --- Comment #12 from Emmi Takkinen --- I think it's save to say that this bug is a duplicate of bug 25159? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 10:06:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 08:06:21 +0000 Subject: [Koha-bugs] [Bug 29930] Auth with LDAP: Update tag leads to unwanted updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29930 Alexander Wagner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Alexander Wagner --- **Note** `card number` is a mandatory field. Setting ```xml 1 ``` will now happily create a user without assign a card number with this patch applied. It seems simple to change it to the old behaviour and assign the ldap-id in case a new user is created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 10:36:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 08:36:03 +0000 Subject: [Koha-bugs] [Bug 33759] Typo: Thankyou In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 10:36:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 08:36:05 +0000 Subject: [Koha-bugs] [Bug 33759] Typo: Thankyou In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759 --- Comment #2 from Katrin Fischer --- Created attachment 154358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154358&action=edit Bug 33759: Fix typo 'Thankyou' in sample notices This fixes the typo 'Thankyou' in some of the sample notices. To test: * With the sample data * Create and run a report: SELECT code,content FROM letter where content LIKE "%Thankyou%"; * Verify 3 notices contain 'Thankyou' * Apply patch * Drop your database * Run the web installer * Run report again, you should no longer get any results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 10:58:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 08:58:33 +0000 Subject: [Koha-bugs] [Bug 34506] After deleting record from a search result the link 'Go back to the results' has disappeared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34506 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |koha at trust-box.at |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 11:06:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 09:06:23 +0000 Subject: [Koha-bugs] [Bug 34506] After deleting record from a search result the link 'Go back to the results' has disappeared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34506 --- Comment #1 from Mark Hofstetter --- Created attachment 154359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154359&action=edit Bug 34506: After deleting record from a search result the link 'Go back to the results' has disappeared This patch fixes the regression of https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 introduced in 22.11.x Test plan see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428 To test: 0 - Perform a search in the staff client 1 - Click a title to go to the details page for a record 2 - Click the 'Edit' button and select 'Edit items in a batch' 3 - Note the searchid is in the url 4 - Make a change and hit 'Save' 5 - Note the 'Return the the record' link at the top, and the button on the bottom include searchid in URL 6 - Click one and note the brwoser is stil there 7 - Click 'Edit' and select 'Delete items in a batch' 8 - Delete one item 9 - Click return to record 10 - Browser is there 11 - Click 'Delete items in a batch again 12 - Select all and check 'Delete records if no items remain' 13 - Delete them 14 - Note you have a link to 'Go back to the results' Sponsored-by: Steiermärkische Landesbibliothek -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 11:16:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 09:16:45 +0000 Subject: [Koha-bugs] [Bug 34506] After deleting record from a search result the link 'Go back to the results' has disappeared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34506 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 12:07:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 10:07:59 +0000 Subject: [Koha-bugs] [Bug 34119] After redesign, print.css no longer hides things at the top of report results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #9 from Katrin Fischer --- Better to avoid "In Discussion" unless there is an argument that needs more people to be resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 12:08:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 10:08:04 +0000 Subject: [Koha-bugs] [Bug 34119] After redesign, print.css no longer hides things at the top of report results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 13:14:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 11:14:14 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33428 CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 13:14:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 11:14:14 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29822 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 13:19:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 11:19:48 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #76 from Nick Clemens --- This and 33428 are going to clash, happy to rebase mine on top of this Would it be better to leave the fields from the pref as pipe, and just move the other fields 'full_address', 'all_emails' etc to use the pipe too? Then we don't have to replace in the one instance for splitting. I don't understand the comment: + effectively replace 'standard', don't display it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 13:32:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 11:32:04 +0000 Subject: [Koha-bugs] [Bug 33759] Typo: Thankyou In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759 Alexander Wagner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154358|0 |1 is obsolete| | --- Comment #3 from Alexander Wagner --- Created attachment 154360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154360&action=edit Bug 33759: Fix typo 'Thankyou' in sample notices This fixes the typo 'Thankyou' in some of the sample notices. To test: * With the sample data * Create and run a report: SELECT code,content FROM letter where content LIKE "%Thankyou%"; * Verify 3 notices contain 'Thankyou' * Apply patch * Drop your database * Run the web installer * Run report again, you should no longer get any results Signed-off-by: Alexander Wagner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 13:32:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 11:32:34 +0000 Subject: [Koha-bugs] [Bug 33759] Typo: Thankyou In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759 Alexander Wagner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |alexander.wagner at desy.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:16:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:16:01 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:16:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:16:04 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153442|0 |1 is obsolete| | Attachment #153443|0 |1 is obsolete| | Attachment #153444|0 |1 is obsolete| | Attachment #153445|0 |1 is obsolete| | Attachment #153446|0 |1 is obsolete| | Attachment #153447|0 |1 is obsolete| | --- Comment #77 from Nick Clemens --- Created attachment 154361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154361&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:16:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:16:07 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #78 from Nick Clemens --- Created attachment 154362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154362&action=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all fields from the borrowers database table Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:16:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:16:10 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #79 from Nick Clemens --- Created attachment 154363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154363&action=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of moving from comma delimited to pipe delimitation for the preference contents Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:16:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:16:13 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #80 from Nick Clemens --- Created attachment 154364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154364&action=edit Bug 29822: Database and Preference description updates Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:16:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:16:16 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #81 from Nick Clemens --- Created attachment 154365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154365&action=edit Bug 29822: Update unit tests Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:16:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:16:19 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #82 from Nick Clemens --- Created attachment 154366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154366&action=edit Bug 29822: (QA follow-up) Use pipe for all field separators - Tidy atomic update Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:31:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:31:57 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18094 |29822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 [Bug 18094] Patron search filters are broken by searchable attributes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:31:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:31:57 +0000 Subject: [Koha-bugs] [Bug 18094] Patron search filters are broken by searchable attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33428 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 [Bug 33428] Should only search in searchable patron attributes if searching in standard fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:31:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:31:57 +0000 Subject: [Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 [Bug 33428] Should only search in searchable patron attributes if searching in standard fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:32:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:32:00 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154355|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 154367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154367&action=edit Bug 33428: Parse search fields in buildPatronSearchQuery This patch moves the parsing of standard search_field into the buildPatronQuery subroutine and adds a check for 'standard' field before adding attributes to the search To test: 1 - Add a new attribute type and make it searchable 2 - Add a value to a patron 3 - Search for this value using 'Standard' fields, confirm you get the patron 4 - Search for the value using 'Cardnumber' field, confirm you get the patron - BAD! 5 - Apply patch 6 - Repeat cardnumebr search, confirm patron not found - Yay! 7 - Search standard, confirm patron is found 8 - Add a new field to 'DefaultPatronSearchFields 9 - Confirm it appears in patron search dropdown 10 - Confirm a search of this field with the attribute value does not return the patron Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:32:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:32:02 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 --- Comment #9 from Nick Clemens --- Created attachment 154368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154368&action=edit Bug 33428: Adjust Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:38:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:38:00 +0000 Subject: [Koha-bugs] [Bug 34507] Add configuration for renaming of terms on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34507 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:53:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:53:51 +0000 Subject: [Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:56:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:56:01 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 14:56:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 12:56:50 +0000 Subject: [Koha-bugs] [Bug 23641] Checkout via camera on device In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 15:06:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 13:06:27 +0000 Subject: [Koha-bugs] [Bug 34517] New: Add option to search patron attribute in standard search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Bug ID: 34517 Summary: Add option to search patron attribute in standard search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently if a patron attribute is marked 'staff_searchable' it is always searched when using a 'standard search' It should be possible to make attributes searchable without searching them by default -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 15:07:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 13:07:35 +0000 Subject: [Koha-bugs] [Bug 34518] New: "Renew all" button doesn't work in OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34518 Bug ID: 34518 Summary: "Renew all" button doesn't work in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: andrew.auld at ptfs-europe.com, david at davidnind.com, katrin.fischer at bsz-bw.de, kyle at bywatersolutions.com, martin.renvoize at ptfs-europe.com, nick at bywatersolutions.com Depends on: 31735 I believe this regression was introduced in patch "Bug 31735: Optimize OPAC checkouts view". To reproduce, on k-t-d: - Checkout an item to koha user (42) - Log-in to OPAC and visit user summary to see check-outs - Press 'Renew all' button at the bottom, notice it doesn't work. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 15:07:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 13:07:35 +0000 Subject: [Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34518 [Bug 34518] "Renew all" button doesn't work in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 15:08:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 13:08:54 +0000 Subject: [Koha-bugs] [Bug 34518] "Renew all" button doesn't work in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34518 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 15:08:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 13:08:57 +0000 Subject: [Koha-bugs] [Bug 34518] "Renew all" button doesn't work in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34518 --- Comment #1 from Pedro Amorim --- Created attachment 154369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154369&action=edit Bug 34518: Fix 'Renew all' button in OPAC Test plan: - Checkout an item to koha user (42) - Log-in to OPAC and visit user summary to see check-outs - Press 'Renew all' button at the bottom, notice it doesn't work. - Apply patch. Repeat and verify it now works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 15:44:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 13:44:35 +0000 Subject: [Koha-bugs] [Bug 34095] Shipping cost should default to a blank box instead of 0.00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34095 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 16:15:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 14:15:43 +0000 Subject: [Koha-bugs] [Bug 34519] New: Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 Bug ID: 34519 Summary: Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently we fetch the searchable attributes in several scripts Moving to a plugin allows us to make a single call from the patron search template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 16:24:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 14:24:50 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 16:24:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 14:24:57 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145041|0 |1 is obsolete| | Attachment #145042|0 |1 is obsolete| | --- Comment #14 from Thibaud Guillot --- Created attachment 154370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154370&action=edit Bug 31550: (follow-up) fix bareword issue Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 16:25:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 14:25:04 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #15 from Thibaud Guillot --- Created attachment 154371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154371&action=edit Bug 31550: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 16:26:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 14:26:46 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 --- Comment #16 from Thibaud Guillot --- Created attachment 154372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154372&action=edit Bug 31550: Add fields to get opac description on ILSDI web service Test plan 1) Active your ILS-DI syspref 2) Have some authorised values linked to one or more concern fields 3) Choose an item and go to 'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords&id=' 4) The XML file contains item fields with some of them the code associated to the authorized values. 5) Apply this patch 6) Repeat step 3 and see the new fields with specific "_description" suffix added and contains opac description from authorized values https://bugs.koha-community.org/show_bug.cgi?id=31550 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 16:26:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 14:26:52 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154370|0 |1 is obsolete| | --- Comment #17 from Thibaud Guillot --- Created attachment 154373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154373&action=edit Bug 31550: (follow-up) fix bareword issue Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 16:27:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 14:27:03 +0000 Subject: [Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154371|0 |1 is obsolete| | --- Comment #18 from Thibaud Guillot --- Created attachment 154374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154374&action=edit Bug 31550: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 16:37:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 14:37:48 +0000 Subject: [Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 16:37:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 14:37:50 +0000 Subject: [Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 --- Comment #1 from Nick Clemens --- Created attachment 154375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154375&action=edit Bug 34519: Add a template plugin for fetch searchable patron attributes This patch moves code form scripts to a template plguin and unifies the calls To test: 1 - Add a searchable patron attribute type 2 - Add values to several patrons and test patron searching from Patrons home Patrons search results Holds request screen Article request screen Patron search sidebar 3 - Apply patch 4 - Confirm results are the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 16:37:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 14:37:52 +0000 Subject: [Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 --- Comment #2 from Nick Clemens --- Created attachment 154376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154376&action=edit Bug 34519: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 16:38:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 14:38:29 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 16:38:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 14:38:29 +0000 Subject: [Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34517 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 [Bug 34517] Add option to search patron attribute in standard search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 17:23:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 15:23:40 +0000 Subject: [Koha-bugs] [Bug 7972] GUI for Crons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 17:33:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 15:33:24 +0000 Subject: [Koha-bugs] [Bug 34095] Shipping cost should default to a blank box instead of 0.00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34095 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |Laura.escamilla at bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 17:39:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 15:39:15 +0000 Subject: [Koha-bugs] [Bug 34095] Shipping cost should default to a blank box instead of 0.00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34095 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 17:39:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 15:39:17 +0000 Subject: [Koha-bugs] [Bug 34095] Shipping cost should default to a blank box instead of 0.00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34095 --- Comment #1 from Laura Escamilla --- Created attachment 154377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154377&action=edit Bug 34095: Adjust logic so that shipment cost is empty if the receiving shipment cost is blank. To test: 1. Create a new basket (Orders are not standing, and items are created when placing an order) 2. Add a record to the basket. 3. Close the basket. 4. Receive the shipment - when creating the invoice leave the shipment cost as blank and then receive the item you added to the basket. 5. View the invoice and notice that the Shipping Cost is showing as “0.00” 6. Apply the patch and restart_all 7. Repeat steps 1-5 8. View the invoice and notice that the Shipping Cost is now blank. 9. Repeat steps 1-5 but this time add a shipment cost when creating the invoice. When you view the invoice confirm that the shipping cost does show up. 10. Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 17:47:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 15:47:45 +0000 Subject: [Koha-bugs] [Bug 34501] Patron Purchase Suggestion table should include the non-public note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34501 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154323|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 154378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154378&action=edit Bug 34501: Added Non-public notes to the member purchase suggestion table Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 17:48:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 15:48:40 +0000 Subject: [Koha-bugs] [Bug 34501] Patron Purchase Suggestion table should include the non-public note In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34501 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lisette.scheer at bywatersolut | |ions.com --- Comment #3 from Lisette Scheer --- Worked as expected! Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 17:58:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 15:58:47 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151377|0 |1 is obsolete| | --- Comment #168 from Hammat wele --- Created attachment 154379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154379&action=edit Bug 17385: Add custom export XSLT Rebase Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 17:59:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 15:59:42 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151378|0 |1 is obsolete| | --- Comment #169 from Hammat wele --- Created attachment 154380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154380&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 18:00:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 16:00:19 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151379|0 |1 is obsolete| | --- Comment #170 from Hammat wele --- Created attachment 154381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154381&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 18:01:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 16:01:00 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151380|0 |1 is obsolete| | --- Comment #171 from Hammat wele --- Created attachment 154382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154382&action=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : 
$ prove -l t/db_dependent/XSLT.t
t/db_dependent/XSLT.t .. 1/3
    #   Failed test 'This list comes from the cache and that is fine'
    #   at t/db_dependent/XSLT.t line 122.
    #          got: '1'
    #     expected: '2'
    # Looks like you failed 1 test of 1.

 #   Failed test 'CustomXSLTExportList: Caching'
 #   at t/db_dependent/XSLT.t line 124.
 # Looks like you failed 1 test of 3.
t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
-------------------
t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=3,  3 wallclock secs ( 0.03 usr  0.00 sys +  1.74 cusr  0.14
csys =  1.91 CPU)
Result: FAIL
This one works fine : 
$ prove -l t/XSLT.t
t/XSLT.t .. ok
All tests successful.
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.55 cusr  0.17
csys =  2.74 CPU)
Result: PASS
Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 18:01:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 16:01:50 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151381|0 |1 is obsolete| | --- Comment #172 from Hammat wele --- Created attachment 154383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154383&action=edit Bug 17385: (Fix) Add custum export format option to the cart and the lists and fix tests for CustomXSLTExportList This patch adds 'XSL-Simple Export' to the cart and the lists and correct the fail test in t/XSLT.t it contains Add custum export format option when saving a record TO TEST: Before applying: 1) Search for a record in the intranet. 2) Click on the 'Save' button and observe the dropdown menu. --> There is no 'XSL- Simple Export' in the dropdown menu. 3) Apply the patch. 4) In System preferences search for OpacExportOptions and enable XSL 5) Repeat the steps 1 and 2. ---> There is now 'XSL- Simple Export' option in the dropdown menu 6) Click on 'XSL - Simple Export'. a .html file should be downloaded. 7) Open the .html file. You should see the record's informations. 8) Add some items to your Cart 9) Open the Cart 10) Click on the 'Download' and 'XSL - Simple Export'. ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 11) Add some items to a List 12) Open the List 13) Click on the 'Download' and 'XSL - Simple Export'. ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 14) Do the same steps in OPAC ----> a .html file should be downloaded. ----> you should see the record's informations in the downloaded file. 15) In System preferences search for OpacExportOptions and disable XSL 16) Repeat all steps 17) Notice that 'XSL - Simple Export' is no more in the menus. 18) Run prove -l t/XSLT.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 18:04:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 16:04:29 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #173 from Hammat wele --- Rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 18:43:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 16:43:32 +0000 Subject: [Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 --- Comment #3 from Nick Clemens --- Created attachment 154384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154384&action=edit Bug 34519: Ensure we always have an array -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 19:01:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 17:01:54 +0000 Subject: [Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 --- Comment #35 from Pablo AB --- I upgraded MariaDB from 10.1 to 10.6 and tried to upgrade (from 22.05) again. I successfully passed through the `Bug 30472` section! Still having issues, now on Bug 24860 (Can't create table `koha_myinstance`.`reserves` (errno: 150 "Foreign key constraint is incorrectly formed")). I'll file a new bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 19:18:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 17:18:34 +0000 Subject: [Koha-bugs] [Bug 34520] New: Database update 22.06.00.078 breaks update process Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 Bug ID: 34520 Summary: Database update 22.06.00.078 breaks update process Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: pablo.bianchi at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Trying to upgrade from 22.05.15-1, 10.6.14-MariaDB, Debian 11: Upgrade to 22.06.00.078 [13:21:46]: Bug 24860 - Add ability to place item group level holds ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Can't create table `koha_myinstance`.`reserves` (errno: 150 "Foreign key constraint is incorrectly formed") at /usr/share/koha/lib/C4/Installer.pm line 741 I had some issues (bug 33671 comments 14-19) that it seems are now fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 19:41:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 17:41:01 +0000 Subject: [Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 19:41:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 17:41:04 +0000 Subject: [Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 --- Comment #2 from Nick Clemens --- Created attachment 154385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154385&action=edit Bug 26916: Show searchable patron attributes in patron search dropdown This patch adds attributes that have been marked searchable to the patron search dropdowns To test: 1 - Define some new patron attribute types and make then staff_searchable 2 - Add some values to patrons 3 - Confirm they are searched in 'Standard' search, but there is no other way to search them 4 - Apply patch 5 - Confirm the fields now show in patorn search dropdowns 6 - Search using 'standard' and confirm the searhc works 7 - Search specific attributes and confirm the searhc works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 19:41:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 17:41:06 +0000 Subject: [Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 --- Comment #3 from Nick Clemens --- Created attachment 154386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154386&action=edit Bug 26916: Adjust unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 19:41:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 17:41:19 +0000 Subject: [Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 20:08:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 18:08:26 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 20:17:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 18:17:08 +0000 Subject: [Koha-bugs] [Bug 34458] It should be possible to change the pickup location for in transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34458 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 20:25:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 18:25:13 +0000 Subject: [Koha-bugs] [Bug 34521] New: Claim Return should be controlled by system preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34521 Bug ID: 34521 Summary: Claim Return should be controlled by system preference Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: catrina at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com There is no longer a way to remove the claim return tab from a patron account, even if the library does not have a LOST value set for claims return and ClaimReturnedLostValue system preference is NULL. There should be an option for libraries who do not want to use claim returns to turn it off via system preference so the tab no longer shows on the patron account rather than having to hide it with CSS. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 20:26:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 18:26:06 +0000 Subject: [Koha-bugs] [Bug 34458] It should be possible to change the pickup location for in transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34458 --- Comment #2 from Rebecca Coert --- I was excited to see the OPACAllowUserToChangeBranch in 22.11 but immediately wondered why there wasn't also an option for this in the staff interface. Thanks for opening this bug and discussion! I agree that this should be made available on the staff side, and I'd like to request that it be available for adjustment on the Holds tab of the borrower's record, as well as on the Holds tab of the Bib record. Staff here would appreciate not having to jump between screens to accomplish this task. I think adding re-routing information to the /transferstoreceive.pl page would be useful, especially if things went missing while in transit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 20:28:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 18:28:49 +0000 Subject: [Koha-bugs] [Bug 25667] Add field for items.notforloan_on to record when a notforloan status is applied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 20:29:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 18:29:13 +0000 Subject: [Koha-bugs] [Bug 25667] Add field for items.notforloan_on to record when a notforloan status is applied In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667 --- Comment #3 from Rebecca Coert --- +1 - This would be a useful addition for us! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 20:39:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 18:39:49 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Todd Goatley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tgoatley at gmail.com --- Comment #17 from Todd Goatley --- What does this bug need to move forward? It shows signed off but FailedQA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 21:02:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 19:02:48 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154295|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes --- Created attachment 154387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154387&action=edit Bug 34457: Added cardnumber view to hold details page Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 21:03:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 19:03:06 +0000 Subject: [Koha-bugs] [Bug 33374] Holds captured at different branch when pickup branch has a copy on shelf can create long wait times for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33374 Carolyn Hughesman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chughesman at cclsny.org --- Comment #1 from Carolyn Hughesman --- +1 This would be very useful to us! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 21:17:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 19:17:12 +0000 Subject: [Koha-bugs] [Bug 31652] Add geo-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 Thomas Klausner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153720|0 |1 is obsolete| | --- Comment #7 from Thomas Klausner --- Created attachment 154388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154388&action=edit Bug 31652: Add geo-search This patch adds geosearch to Koha (using Elasticsearch 7). ElasticSearch search_mappings get new types to store lat/lon, which can be indexed from MARC 034$s and 034$t. There is a small change to the DB to allow a new value in search_field.type ENUM. The QueryBuilder is extended to allow for building advanced ElasticSearch Querys (eg geo_distance) that cannot be represented in a simple string query. We added a new SystemPreference `GeoSearchEnabled`. If it is set to `true`, we show a new advanced search field that allows for input of lat/lng and distance (radius). On the search result page, a we render a map using leaflet.js with pins for each found item. Therefor we also added a new api endpoint that returns lat/lng for each biblio in the selection. Test Plan: * make sure you're running ElasticSearch 7 (eg via `curl http://es:9200?pretty | grep number`) * apply patch * Set system preference "SearchEngine" to "Elasticsearch" * got to a Framework, check Editor for 034$s and 034$t and save * got to some books (in the correct framework) and enter some lat and lon into 034$s and 034$t (for example lat=48.216, lon=16.395) * Run the elasticsearch indexer, maybe limited on the books you edited (-bn 123 -bn 456): misc/search_tools/rebuild_elasticsearch.pl -b -v * You can check if the indexing worked by inspecting the document in elasticsearch: * get the biblionumber (eg 123) * curl http://es:9200/koha_kohadev_biblios/_doc/123?pretty | grep -A5 geolocation * You should get back a JSON fragment containing the lat/lon you stored * You can query elasticsearch directly: * Run the following curl command, but adapt the value for lat/lng and/or the distance (in meters) * curl -X GET "http://es:9200/koha_kohadev_biblios/_search?pretty" -H 'Content-Type: application/json' -d '{"query": {"bool":{"must":{"match_all":{}},"filter":{"geo_distance":{"distance":100000,"geolocation":{"lat":48.2,"lon":16.4}}}}}}' * To run the search via Koha: * Set system preference "GeoSearchEnabled" to "true" * got to OPAC / Advanced Search * There is a new input box "Geographic Search" where you can enter lat/long/radius, for example lat=48.2, lng=16.3, distance=100km * On the search result page a map is shown with pins for each found biblioitem Sponsored-by: ZAMG - Zentralanstalt für Meterologie und Geodynamik, Austria - https://www.zamg.ac.at/ Authors: Mark Hofstetter , Thomas Klausner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 21:32:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 19:32:47 +0000 Subject: [Koha-bugs] [Bug 31868] Add search options for searchable patron attributes to pull down list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31868 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |nick at bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #1 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 26916 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 21:32:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 19:32:47 +0000 Subject: [Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Nick Clemens --- *** Bug 31868 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 21:37:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 19:37:22 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 21:37:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 19:37:24 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #1 from Nick Clemens --- Created attachment 154389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154389&action=edit Bug 34517: DB updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 21:37:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 19:37:26 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #2 from Nick Clemens --- Created attachment 154390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154390&action=edit Bug 34517: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 21:37:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 19:37:28 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #3 from Nick Clemens --- Created attachment 154391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154391&action=edit Bug 34517: Add boolean to search columns for schema -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 21:37:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 19:37:30 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #4 from Nick Clemens --- Created attachment 154392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154392&action=edit Bug 34517: Add option search patron attributes by default This patch moves form any staff_searchable attribute being automatically included in the the Standard patron serch, to allowing the librarian to choose. Current searchable attributes will be marked as 'searched_by_default' To test: 1 - Add a searchable patron attribute type 2 - Add some values 3 - Confirm they are searched in a 'Standard' patron search 4 - Apply patch 5 - Go to admin - >patron attribute types 6 - Note new 'Searching' column 7 - Confirm attribute is 'Searched by default' 8 - Confirm searches work as before 9 - Edit the attribute type 10 - Uncheck 'searched_by_default' 11 - Save 12 - Confirm attribute not searched in 'Standard' search 13 - Select the attribute in patron search dropdowns 14 - Confirm it is correctly searched -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 21:38:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 19:38:08 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 21:40:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 19:40:30 +0000 Subject: [Koha-bugs] [Bug 31652] Add geo-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 --- Comment #8 from Thomas Klausner --- The latest patch has some warnings/errors reported from koha-qa.pl. Plus I'm not totally happy with the way the search params are handled. So I guess it will need a bit more work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 22:24:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 20:24:00 +0000 Subject: [Koha-bugs] [Bug 34457] Add card number to hold details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us Status|Needs Signoff |Signed Off --- Comment #10 from Rebecca Coert --- Works as described! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 22:26:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 20:26:01 +0000 Subject: [Koha-bugs] [Bug 34522] New: Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Bug ID: 34522 Summary: Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: hebah at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Observed in 22.11 To recreate: Log into OPAC as patron of Branch A Make purchase suggestion for Branch B Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to have been made for Branch A View suggestion from staff client See that it accurately reflects suggestion having been made for Branch B This display is confusing (and inaccurate) for patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 22:47:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 20:47:25 +0000 Subject: [Koha-bugs] [Bug 34522] Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass --- The column that displays inaccurately is "Suggested for" which requires the system preference OPACViewOthersSuggestions to be turned on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 22:55:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 20:55:31 +0000 Subject: [Koha-bugs] [Bug 34522] Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 22:55:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 20:55:33 +0000 Subject: [Koha-bugs] [Bug 34522] Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 --- Comment #2 from Lucas Gass --- Created attachment 154393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154393&action=edit Bug 34522: Pass the suggestion branchcode, not the suggeter branchcode To test: 1. Turn on OPACViewOthersSuggestions 2. Log into OPAC as patron of Branch A 3. Make purchase suggestion for Branch B 4. Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to have been made for Branch A 5. View suggestion from staff client - See that it accurately reflects suggestion having been made for Branch B 6. Apply patch and try steps 2 - 5 again, this time you should see the proper branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 22:55:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 20:55:49 +0000 Subject: [Koha-bugs] [Bug 34522] Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 22:55:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 20:55:54 +0000 Subject: [Koha-bugs] [Bug 34522] Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 11 23:12:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 21:12:17 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #63 from Emily Lamancusa --- I'd love to see this move forward soon! It needs a minor rebase and fixes for the two issues I noticed the last time I tested, but then I think I'll be able to sign off on it. I was able to fix the first issue locally by making the following change in circulation.pref: - 690 yes: Revert - 691 no: "Don't revert" + 690 1: Revert + 691 0: "Don't revert" The issue was that the code in most places checked the syspref as follows: if ( C4::Context->preference('RevertLostBibLevelHolds') ) which evaluates to true for both "yes" and "no". (The default was put into the database as 0, so the odd behavior only occurs after the pref has been changed.) -------- For the second issue - do moredetail.tt and additem.tt have access to the syspref value in any way? It's not clear to me whether either of the template files is taking the value of the syspref into account when determining whether to display the confirmation alert for handling a lost item-level hold. However, all of the .pl files in the patches perform the actual handling of lost item-level holds inside of a conditional that checks the syspref. I assume the templates should be checking that data somehow as well, so as to display the alert only if the syspref is set to "revert"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 12 00:33:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Aug 2023 22:33:25 +0000 Subject: [Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil at chetcolibrary.org --- Comment #5 from Phil Ringnalda --- What's the path forward here? All three of unimarc_field_124.pl, unimarc_field_125.pl, and unimarc_field_126.pl are the exact same thing, most likely from someone copying 100 and then realizing they needed separate ones for each subfield and forgetting to remove the non-subfield ones. Julian's patch for the 124 copy has already been pushed, and nothing bad has happened in the last five months as a result. Are we going to file a bug to remove all three plugins, or remove them in these bugs (including essentially reopening bug 32850 to remove 124), or push the patches here and in bug 32856 and then think about removing them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 12 11:08:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Aug 2023 09:08:28 +0000 Subject: [Koha-bugs] [Bug 34452] Button 'Update adjustments' is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154310|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo --- Created attachment 154394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154394&action=edit Bug 34452: Restore fund label and 'Update adjustments' button This patch fixed 2 small and recent regressions: * The "Update adjustments" button used to always display. It's required to save a new first adjustment, but also to save changes to existing adjustments edited inline. It now would only display after "Add adjustments" was clicked. We retore to display it always. (bug 32746) * We have several "Fund" pull downs on this page, but they are for different things and require different labelling. "Fund" was changed to "Shipping fund" which matches at the top, but doesn't work for the adjustments table and single adjustment form. Now we use "Shipping fund" "Fund" and no label in the table as the table header covers it there. (bug 33721) To test. * Add a vendor * Receive shipment * Add invoice and save * Click on "Finish receiving" * Verify the button "Update adjustments" appears after clicking "Add new adjustment" * Verify the button is gone after you clicked it and the table shows * Change something in the table - no button to save change :( * Apply patch * Repeat steps, button "Update adjustments" should not always be visible. Signed-off-by: Sam Lau Signed-off-by: Michaela Sieber Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 12 11:10:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Aug 2023 09:10:15 +0000 Subject: [Koha-bugs] [Bug 34452] Button 'Update adjustments' is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #8 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Aug 12 20:01:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Aug 2023 18:01:35 +0000 Subject: [Koha-bugs] [Bug 34523] New: Add smart logic to branches for holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34523 Bug ID: 34523 Summary: Add smart logic to branches for holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The transport cost matrix does a good job at equalizing hold requests, but can be overwhelming when it comes to implementing or updating. What if, under each library in branches.pl, there were a "Smart holds" section, that asked for certain criteria, in which Koha could determine the best selection for holds. This smart setting could be turned on or off for the entire system, but if turned on, it would utilize information from this section under each branch. Information that could be entered and evaluated could be things like: Which days are you open. Which days do you have courier pickup? How often does courier pickup on each of those days? How far are you from each of the other branches. How many courier exchanges are made between you and each branch? Koha could then evaluate this information and determine which location would be the best (fastest) branch to request from. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Aug 13 01:42:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Aug 2023 23:42:35 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153687|0 |1 is obsolete| | --- Comment #14 from Biblibre Sandboxes --- Created attachment 154395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154395&action=edit Bug 33462: Unit Tests prove t/db_dependent/Koha/Patron/Category.t prove t/db_dependent/Koha/Patron.t Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 13 01:42:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Aug 2023 23:42:38 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153688|0 |1 is obsolete| | --- Comment #15 from Biblibre Sandboxes --- Created attachment 154396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154396&action=edit Bug 33462: Update Schema Files [DO NOT PUSH] This updates the schema files for Borrower.pm, BorrowerModification.pm, Category.pm, and Deletedborrower.pm. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 13 01:42:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Aug 2023 23:42:41 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153689|0 |1 is obsolete| | --- Comment #16 from Biblibre Sandboxes --- Created attachment 154397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154397&action=edit Bug 33462: Add ability to force password change for new patrons entered by staff This patch attempts to force a password change for new staff created patrons. This is done by setting the password_expiration_date to an expired date when adding a new patron. This patch adds a new system preference 'ForcePasswordResetWhenSetByStaff', a new column to the categories table 'force_password_reset_when_set_by_staff', and new columns to the borrowers, borrower_modification, and deletedborrowers table 'needs_password_reset' To test: 1) Apply patch, restart_all, updatedatabase, and also be sure to update schema. 2) Visit Administration->Sytem Preferences and search for 'EnableExpiredPasswordReset'. Make sure this is set to enable. Now search for 'ForcePasswordResetWhenSetByStaff'. This should be defaulted to 'Don't force'. 3) Keep that tab open and visit Administration->Patron categories. Click on edit on the Board category. Noitce that there is a now a 'Force new patron password reset' section. Notice that the by default, this is set to follow the ForcePasswordResetWhenSetByStaff system preference (currently set to don't force). Click on the dropdown and change it to 'Force'. Save changes 4) Click on the Patrons tab to visit members-home.pl and then click 'New Patron'. Select on Patron. Fill in the required information and also enter a password. 5) Submit this form and notice that the patron's password expiration date is set to never. This should be the case because the default for 'Force new patron password reset' follows the sys. pref. which is still set to 'Don't force' (You could have some expiry date in this step, but it should at least be set to a date that is not expired. this depends on whether or not you have a defalut password expiration date set in patron categories ) 6) Log into the OPAC with this patron and notice it works as expected and log in was successful. 7) Go back to the patron home page and click to add a new patron. This time select 'Board'. Once again fill out the required info, enter a password, and then save the form. 8) Notice that for this patron, the password expiration date is set for today's date. This is because we changed the setting for the 'Board' patron category to force. 9) Log into the OPAC with this patron. You should be redirected to a page with an error that says: "It's your first login! You need to reset your password." Click on the reset password link below this message. 10) You should be sent to a page where you can reset your password. Fill in the form and click 'Update password'. Attempt to sign into the OPAC with this new password. Everything works as expected. 11) Go back to the staff interface and view this patron's detail page. Notice the password expiration date is now set to what the default is in the patron category. 12) Edit this patrons information and set their password expiration date to yesterday. Go back to the OPAC and try to sign in with this patron again. Note that this time, you are also redirected but the message says "Error: Your password has expired!" 13) Go back to the staff interface and visit the sys. pref tab we left open. Set it to the 'Force' option and save changes. 14) Visit the patron home page and click add patron, now select the patron category again. Fill in required info and enter password. Submit form and note that the patron's password expiration date is set to today. Try to login to the OPAC with this patron, you should be redirected to the page with the error that says "Error: It's your first login! You need to reset your password." 15) Sign-off :) Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 13 01:43:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Aug 2023 23:43:36 +0000 Subject: [Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Christopher Brannon --- Works as expected and is fantastic! Can't wait to have it in production!!!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 13 02:05:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Aug 2023 00:05:00 +0000 Subject: [Koha-bugs] [Bug 34493] Bad indenting in search_indexes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34493 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154312|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 154398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154398&action=edit Bug 34493: Fix indenting in search_indexes.inc Bug 32683 broke indenting in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc Not on purpose looks like. Test plan : 1) Look at changes to validate indenting 2) Run prove xt/tt_valid.t Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 13 02:06:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Aug 2023 00:06:26 +0000 Subject: [Koha-bugs] [Bug 34493] Bad indenting in search_indexes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34493 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #4 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 13 02:57:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Aug 2023 00:57:58 +0000 Subject: [Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #6 from Victor Grousset/tuxayo --- > Julian's patch for the 124 copy has already been pushed, and nothing bad has happened in the last five months as a result. Nothing bad was reported for years even. Julian's patch doesn't even change a thing regarding the issue right? The problem Katrin found seems to have been like that for a long time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 13 03:24:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Aug 2023 01:24:05 +0000 Subject: [Koha-bugs] [Bug 29275] Use the API to render checkout history for a biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29275 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #44 from Victor Grousset/tuxayo --- Gave a go at rebasing but can't arbitrate on a conflict about a change of HTML header level. (both in this patch and main/master) Anyway, this doesn't seem to be needing a rebase right now but rather settling on what to do about comment 37 (continued in Comment 40 and Comment 43) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Aug 13 13:29:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Aug 2023 11:29:44 +0000 Subject: [Koha-bugs] [Bug 31661] libcache-memcached-fast-safe-perl not available on ARM64 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31661 Stephen Gaito changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Stephen Gaito --- Hi Mason, I am sorry to have taken a while to reply. I have just recently gotten back into using Koha (testing for a School Library). I am *very* happy to say, Koha can now be installed (and runs very nicely) on a Raspberry Pi 4 with 8GB. For the record here are the outputs you requested: > $ sudo apt update > Hit:1 http://deb.debian.org/debian bullseye InRelease > Get:2 http://security.debian.org/debian-security bullseye-security InRelease [48.4 kB] > Hit:3 http://archive.raspberrypi.org/debian bullseye InRelease > Get:4 http://deb.debian.org/debian bullseye-updates InRelease [44.1 kB] > Hit:5 https://debian.koha-community.org/koha stable InRelease > Get:6 http://security.debian.org/debian-security bullseye-security/main arm64 Packages [249 kB] > Get:7 http://security.debian.org/debian-security bullseye-security/main armhf Packages [249 kB] > Get:8 http://security.debian.org/debian-security bullseye-security/main Translation-en [164 kB] > Fetched 755 kB in 2s (450 kB/s) > Reading package lists... > Building dependency tree... > Reading state information... > All packages are up to date. and: > $ apt policy libcache-memcached-fast-safe-perl koha-common > libcache-memcached-fast-safe-perl: > Installed: 0.06-1~koha1 > Candidate: 0.06-1~koha1 > Version table: > *** 0.06-1~koha1 500 > 500 https://debian.koha-community.org/koha stable/main arm64 Packages > 500 https://debian.koha-community.org/koha stable/main armhf Packages > 100 /var/lib/dpkg/status > koha-common: > Installed: 23.05.02-1 > Candidate: 23.05.02-1 > Version table: > *** 23.05.02-1 500 > 500 https://debian.koha-community.org/koha stable/main arm64 Packages > 500 https://debian.koha-community.org/koha stable/main armhf Packages > 100 /var/lib/dpkg/status Since Koha can now be installed on a Raspberry Pi 4, please close this bug as solved. Many thanks for a wonderful tool! Regards, Stephen Gaito -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 00:31:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Aug 2023 22:31:08 +0000 Subject: [Koha-bugs] [Bug 31143] We should attempt to fix/identify all cases where '0000-00-00' may still remain in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31143 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154299|0 |1 is obsolete| | --- Comment #3 from wainuiwitikapark at catalyst.net.nz --- Created attachment 154399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154399&action=edit Bug 31143: Update patrons with dates of 0000-00-00 to NULL To test: 1) Change a patron's value of one or more of the following to 0000-00-00: dateofbirth dateenrolled dateexpiry date_renewed 2) Run the fix_patron_dates.pl (-c -v) 3) Notice the value has changed from 0000-00-00 to NULL Sponsored by: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 00:31:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Aug 2023 22:31:46 +0000 Subject: [Koha-bugs] [Bug 31143] We should attempt to fix/identify all cases where '0000-00-00' may still remain in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31143 wainuiwitikapark at catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 00:32:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Aug 2023 22:32:40 +0000 Subject: [Koha-bugs] [Bug 31143] We should attempt to fix/identify all cases where '0000-00-00' may still remain in the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31143 --- Comment #4 from wainuiwitikapark at catalyst.net.nz --- (In reply to Laura Escamilla from comment #2) > Hi! Thank you for working on this patch. I ran into this error: > > Missing right curly or square bracket at misc/cronjobs/fix_patron_dates.pl > line 53, at end of line > syntax error at misc/cronjobs/fix_patron_dates.pl line 53, at EOF > > After adding the curly this works as described! I'm marking this as Failed > QA for now, but once the patch is updated I'll be happy to sign off! Thanks Laura for pointing that out. I have added the curly bracket to the end of the file and reuploaded the patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 01:33:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Aug 2023 23:33:58 +0000 Subject: [Koha-bugs] [Bug 34518] "Renew all" button doesn't work in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34518 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 02:02:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 00:02:06 +0000 Subject: [Koha-bugs] [Bug 23641] Checkout via camera on device In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #12 from David Cook --- (In reply to Martin Renvoize from comment #8) > https://zxing-js.github.io/library/ Looks promising Back in June 2021, I did a local implementation using version 0.0.9 of https://github.com/zxing-js/browser It was easy enough to do, but the library didn't work that well. Performance ranged heavily between mobile devices (with cheaper devices not working well or at all in many cases), and even with a good more expensive device it could take a lot of attempts to get 1 good scan as the camera wouldn't focus on the barcode very well. We ended up discarding the implementation and integrating with third-party commercial software which worked much much better. -- I can share my zxing-js implementation, but I wouldn't recommend anyone use it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 02:14:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 00:14:21 +0000 Subject: [Koha-bugs] [Bug 23641] Checkout via camera on device In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641 --- Comment #13 from David Cook --- Created attachment 154400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154400&action=edit Bug 23641: Add barcode capture via device camera for self-checkout This patch adds barcode capture via device camera using the zxing-browser Javascript library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 02:22:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 00:22:52 +0000 Subject: [Koha-bugs] [Bug 23641] Checkout via camera on device In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #14 from David Cook --- In my original version, I wrapped the buttons with a system preference. I left it off here just for ease of testing. I just double-checked it worked using my webcam and a barcode from my breakfast. It took a bit of time and physical manipulation, but it managed to scan the barcode. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 02:33:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 00:33:25 +0000 Subject: [Koha-bugs] [Bug 34507] Add configuration for renaming of terms on the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34507 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 02:42:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 00:42:49 +0000 Subject: [Koha-bugs] [Bug 30913] Show itemtype notforloan with ILS-DI service GetRecords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 02:47:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 00:47:44 +0000 Subject: [Koha-bugs] [Bug 30913] Show itemtype notforloan with ILS-DI service GetRecords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 02:47:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 00:47:47 +0000 Subject: [Koha-bugs] [Bug 30913] Show itemtype notforloan with ILS-DI service GetRecords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30913 --- Comment #3 from David Cook --- Created attachment 154401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154401&action=edit Bug 30913: Show notforloan from itemtype for ILS-DI GetRecords This patch sets notforloan for an item if its itemtype is set to notforloan, when creating the ILS-DI GetRecords response. To test: 0. Apply the patch 1. koha-plack --restart kohadev 2. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ILS-DI 3. Enable the ILS-DI API 4. Go to http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=29 5. Note the "notforloan" is 0 6. Go to http://localhost:8081/cgi-bin/koha/admin/itemtypes.pl?op=add_form&itemtype=BK 7. Checkbox the "Not for loan" and save 8. Go to http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=29 9. Note the "notforloan" is 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 04:17:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 02:17:40 +0000 Subject: [Koha-bugs] [Bug 32129] Use patron categorycode of most relevant recall when checking if item can be a waiting recall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32129 --- Comment #12 from Victor Grousset/tuxayo --- (In reply to Tomás Cohen Arazi from comment #7) > Created attachment 151160 [details] [review] > Bug 32129: (QA follow-up) Avoid duplicate calculation > > This patch stores the output from ->check_recall() (a Koha::Recall > object or undef) and reuses afterwards, on a ternaty operator. Thanks for catching this Tomás! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 04:45:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 02:45:46 +0000 Subject: [Koha-bugs] [Bug 33861] Packages_spec.ts is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33861 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- > Unable to reproduce locally. Depending on the machine the failure probability can be drastically different. My laptop that is showing it's age (2012 CPU) has 0% probability of running all the cypress tests successfully all in a row. I usually have two or three files failing. And then by running them again individually, I can expect to have a success by running them 3 or 5 times for the one or two that fails easily. So I can easily tests patches for flaky tests [1]. Best would be to give a go at fixing them. What are the tricks we can use with Cypress to make them more reliable? (besides adding horrible sleep() instructions). I guess adding check for elements that should load earlier? Like ensuring a list has loaded it's elements because a button might be there before and would be clickable even if the callback has 0 associated targets. [1] maybe anyone can do so by running at the same time "stress --cpu 4". With the right amount of threads, maybe leaving only one of two would work best, the point is not to hit the 10 sec timeout in every test instruction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 05:21:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 03:21:24 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 --- Comment #350 from Victor Grousset/tuxayo --- @Catrina in your (and your customer libraries) situation, your best bet is two get one or two of your several colleagues that are on the QA team to assess how fixable or fundamentally problematic the problems found in the earlier reviews are. comment 322 (the 2nd half is the 1st thing to look) should point to everything relevant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 05:54:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 03:54:59 +0000 Subject: [Koha-bugs] [Bug 34524] New: Hecked-BO_2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34524 Bug ID: 34524 Summary: Hecked-BO_2 Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bila200311 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 154402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154402&action=edit haked Hecked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 05:58:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 03:58:17 +0000 Subject: [Koha-bugs] [Bug 34525] New: Hecked-BO_2 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34525 Bug ID: 34525 Summary: Hecked-BO_2 Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bila200311 at gmail.com QA Contact: testopia at bugs.koha-community.org Hecked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 08:28:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 06:28:37 +0000 Subject: [Koha-bugs] [Bug 14933] SIPserver should not use warn or die to log errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14933 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Magnus Enger --- (In reply to Katrin Fischer from comment #2) > No idea if this was fixed, can someone tell? Pretty sure this was fixed by Bug 15253. *** This bug has been marked as a duplicate of bug 15253 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 08:28:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 06:28:37 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #108 from Magnus Enger --- *** Bug 14933 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 08:59:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 06:59:46 +0000 Subject: [Koha-bugs] [Bug 34524] Hecked-BO_2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34524 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 08:59:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 06:59:54 +0000 Subject: [Koha-bugs] [Bug 34524] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34524 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hecked-BO_2 |SPAM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 09:15:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 07:15:56 +0000 Subject: [Koha-bugs] [Bug 34525] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34525 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|Hecked-BO_2 |SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 10:55:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 08:55:48 +0000 Subject: [Koha-bugs] [Bug 34482] Improve MARC21 7xx linking fields in bibliographic records [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34482 K. Liddle changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katherine.liddle+bugzilla at w | |ycliff.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 11:00:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 09:00:06 +0000 Subject: [Koha-bugs] [Bug 14341] XSLT 773$x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14341 K. Liddle changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katherine.liddle+bugzilla at w | |ycliff.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 12:59:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 10:59:23 +0000 Subject: [Koha-bugs] [Bug 34526] New: Add override options to checkout renewal endpoint Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34526 Bug ID: 34526 Summary: Add override options to checkout renewal endpoint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com CC: tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 12:59:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 10:59:33 +0000 Subject: [Koha-bugs] [Bug 34526] Add override options to checkout renewal endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 [Bug 25393] Create separate 'no automatic renewal before' rule -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 12:59:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 10:59:33 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34526 [Bug 34526] Add override options to checkout renewal endpoint -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 12:59:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 10:59:43 +0000 Subject: [Koha-bugs] [Bug 34526] Add override options to checkout renewal endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34526 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33709 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 12:59:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 10:59:43 +0000 Subject: [Koha-bugs] [Bug 33709] Add override options to checkouts endpoint(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33709 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34526 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 13:15:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 11:15:49 +0000 Subject: [Koha-bugs] [Bug 7152] Koha should make it easy for librarians to attach covers using Open Library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7152 nigel at titley.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nigel at titley.com --- Comment #20 from nigel at titley.com --- Now that OL has been added to the SISC list with identifier "openlib" it is feasible (and correct) to add an OpenLibrary ID to a MARC record as 024 7 _ | $2 openlib | $a -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 13:26:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 11:26:10 +0000 Subject: [Koha-bugs] [Bug 34527] New: Enhance the Openlibrary book cover retrieval to use the 024 MARC record and the OLID Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34527 Bug ID: 34527 Summary: Enhance the Openlibrary book cover retrieval to use the 024 MARC record and the OLID Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nigel at titley.com QA Contact: testopia at bugs.koha-community.org Now that OpenLibrary has been added to the SISC list, with identifier "openlib" it is feasible (and correct) to add an OpenLibrary ID (OLID) to MARC record 024 024 7 _ | $2 openlib | $a Enhancing the OpenLibrary book cover retrieval method to include OLIDs in this fashion would allow more complete retrieval of book covers from OpenLibrary even in the case where the book has no ISBN -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 13:29:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 11:29:09 +0000 Subject: [Koha-bugs] [Bug 34527] Enhance the Openlibrary book cover retrieval to use the 024 MARC record and the OLID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34527 nigel at titley.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nigel at titley.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 13:50:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 11:50:58 +0000 Subject: [Koha-bugs] [Bug 34528] New: Add a "dump" method for Koha objects Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34528 Bug ID: 34528 Summary: Add a "dump" method for Koha objects Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To aid developers we should provide a method to dump objects -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 16:34:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 14:34:09 +0000 Subject: [Koha-bugs] [Bug 34529] New: Offline circulation should be able to accept userid as well as cardnumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Bug ID: 34529 Summary: Offline circulation should be able to accept userid as well as cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 16:34:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 14:34:24 +0000 Subject: [Koha-bugs] [Bug 34529] Offline circulation should be able to accept userid as well as cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 16:58:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 14:58:05 +0000 Subject: [Koha-bugs] [Bug 34529] Offline circulation should be able to accept userid as well as cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 16:58:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 14:58:07 +0000 Subject: [Koha-bugs] [Bug 34529] Offline circulation should be able to accept userid as well as cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 --- Comment #1 from Kyle M Hall --- Created attachment 154403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154403&action=edit Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 39999000001396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 17:20:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 15:20:23 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforloan values as unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 --- Comment #18 from Hammat wele --- Created attachment 154404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154404&action=edit Bug 30846: (Fix) Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 17:23:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 15:23:30 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforloan values as unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 17:55:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 15:55:05 +0000 Subject: [Koha-bugs] [Bug 34203] CollapseFieldsPatronAddForm should have an option to check if fields are empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34203 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us --- Comment #1 from Rebecca Coert --- +1 - Completely agree! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 17:55:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 15:55:28 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 17:55:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 15:55:31 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154034|0 |1 is obsolete| | --- Comment #12 from Pedro Amorim --- Created attachment 154405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154405&action=edit Bug 34431: Add 'type' to existing_statuses method Signed-off-by: Stephen Graham -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 17:55:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 15:55:34 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154289|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim --- Created attachment 154406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154406&action=edit Bug 34431: Allow for x-koha-embed in ill/backends endpoint Signed-off-by: Stephen Graham -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 17:55:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 15:55:37 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154290|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim --- Created attachment 154407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154407&action=edit Bug 34431: Show both status and status_alias - if exists - in table column Signed-off-by: Stephen Graham -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 17:55:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 15:55:40 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154291|0 |1 is obsolete| | --- Comment #15 from Pedro Amorim --- Created attachment 154408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154408&action=edit Bug 34431: Add a status_alias filter input, if any status_alias exist This patch also makes it so that the status input filter is enabled by default, and shows all existing statuses by default, or all existing statuses for a specific backend, if and when selected. Signed-off-by: Stephen Graham -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 17:55:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 15:55:42 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154292|0 |1 is obsolete| | --- Comment #16 from Pedro Amorim --- Created attachment 154409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154409&action=edit Bug 34431: Update tests Signed-off-by: Stephen Graham -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 17:55:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 15:55:45 +0000 Subject: [Koha-bugs] [Bug 34431] Distinguish between status and status_alias in ILL UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34431 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154301|0 |1 is obsolete| | --- Comment #17 from Pedro Amorim --- Created attachment 154410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154410&action=edit Bug 34431: Add status and status_alias filters to clear Signed-off-by: Stephen Graham -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 18:00:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 16:00:48 +0000 Subject: [Koha-bugs] [Bug 34530] New: CollapseFieldsPatronAddForm - Needs ADD vs. EDIT component Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34530 Bug ID: 34530 Summary: CollapseFieldsPatronAddForm - Needs ADD vs. EDIT component Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: rcoert at arlingtonva.us QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently, the system preference CollapseFieldsPatronAddForm controls display for both ADD patron and EDIT patrons. It would be more beneficial to break this into 2 system preferences CollapseFieldsPatronAddForm and CollapseFieldsPatronEditForm. There are fields we set up during registration that we don't need to see or edit again once they're set, and having these hidden when editing an account would cut down on the scrolling to reach the sections we need to edit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 18:07:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 16:07:04 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforloan values as unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Emily Lamancusa --- Thanks for the follow-up, Hammat! Code and tests look good, and qa tool is happy. Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 18:11:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 16:11:29 +0000 Subject: [Koha-bugs] [Bug 34529] Offline circulation should be able to accept userid as well as cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 --- Comment #2 from Kyle M Hall --- Created attachment 154411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154411&action=edit test.koc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 18:39:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 16:39:49 +0000 Subject: [Koha-bugs] [Bug 34518] "Renew all" button doesn't work in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34518 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |lucas at bywatersolutions.com Assignee|oleonard at myacpl.org |pedro.amorim at ptfs-europe.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 18:40:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 16:40:10 +0000 Subject: [Koha-bugs] [Bug 34518] "Renew all" button doesn't work in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34518 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 18:40:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 16:40:12 +0000 Subject: [Koha-bugs] [Bug 34518] "Renew all" button doesn't work in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34518 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154369|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 154412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154412&action=edit Bug 34518: Fix 'Renew all' button in OPAC Test plan: - Checkout an item to koha user (42) - Log-in to OPAC and visit user summary to see check-outs - Press 'Renew all' button at the bottom, notice it doesn't work. - Apply patch. Repeat and verify it now works Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 18:48:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 16:48:53 +0000 Subject: [Koha-bugs] [Bug 34277] Add an API endpoint to return all patrons with outstanding charges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34277 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass --- Tests fail for me when I add a manual credit to a patron accout: # Failed test 'exact match for JSON Pointer ""' # at /kohadevbox/koha/t/db_dependent/api/v1/patrons_accounts.t line 510. # Structures begin differing at: # $got->[0] = HASH(0x56200b91c9c8) # $expected->[0] = Does not exist ok 4 - GET //aMgjvtk9LM4Tcta89qLDALIsozh9yWEECy4Au6B:thePassword123@/api/v1/patrons/get_balances ok 5 - 200 OK not ok 6 - exact match for JSON Pointer "" # Failed test 'exact match for JSON Pointer ""' # at /kohadevbox/koha/t/db_dependent/api/v1/patrons_accounts.t line 525. # Structures begin differing at: # $got->[0]{outstanding_credits}{lines}[0] = HASH(0x56200b4754d0) # $expected->[0]{outstanding_credits}{lines}[0] = Does not exist ok 7 - GET //aMgjvtk9LM4Tcta89qLDALIsozh9yWEECy4Au6B:thePassword123@/api/v1/patrons/get_balances ok 8 - 200 OK not ok 9 - exact match for JSON Pointer "" # Failed test 'exact match for JSON Pointer ""' # at /kohadevbox/koha/t/db_dependent/api/v1/patrons_accounts.t line 552. # Structures begin differing at: # $got->[0]{outstanding_credits}{lines}[0] = HASH(0x56200b9414b8) # $expected->[0]{outstanding_credits}{lines}[0] = Does not exist ok 10 - GET //aMgjvtk9LM4Tcta89qLDALIsozh9yWEECy4Au6B:thePassword123@/api/v1/patrons/get_balances ok 11 - 200 OK not ok 12 - exact match for JSON Pointer "" # Failed test 'exact match for JSON Pointer ""' # at /kohadevbox/koha/t/db_dependent/api/v1/patrons_accounts.t line 590. # Structures begin differing at: # $got->[0]{outstanding_credits}{lines}[0]{credit_type} = 'CREDIT' # $expected->[0]{outstanding_credits}{lines}[0]{credit_type} = 'PAYMENT' ok 13 - GET //aMgjvtk9LM4Tcta89qLDALIsozh9yWEECy4Au6B:thePassword123@/api/v1/patrons/get_balances ok 14 - 200 OK not ok 15 - exact match for JSON Pointer "" # Failed test 'exact match for JSON Pointer ""' # at /kohadevbox/koha/t/db_dependent/api/v1/patrons_accounts.t line 628. # Structures begin differing at: # $got->[0]{borrowernumber} = '51' # $expected->[0]{borrowernumber} = '66' # Looks like you failed 5 tests of 15. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 18:49:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 16:49:03 +0000 Subject: [Koha-bugs] [Bug 34277] Add an API endpoint to return all patrons with outstanding charges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34277 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 18:59:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 16:59:02 +0000 Subject: [Koha-bugs] [Bug 34445] Default budget is not selected in addorderiso2709.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34445 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 18:59:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 16:59:04 +0000 Subject: [Koha-bugs] [Bug 34445] Default budget is not selected in addorderiso2709.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34445 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154085|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 154413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154413&action=edit Bug 34445: Set default budget in addorderiso2709.pl This patch allows the default budget to be used as a fallback if no budget is selected. Currently the default budget is set using lines 129-133 but then is never used. Test plan: 1) Apply patch 2) restart_all 3) Follow the steps from the bug description 4) Order lines should be added properly Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 19:01:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 17:01:50 +0000 Subject: [Koha-bugs] [Bug 31652] Add geo-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #9 from Lucas Gass --- (In reply to Thomas Klausner from comment #8) > The latest patch has some warnings/errors reported from koha-qa.pl. Plus I'm > not totally happy with the way the search params are handled. So I guess it > will need a bit more work. Based on this I am setting this to FQA, to get it out of the 'Needs signoff' queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 19:02:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 17:02:38 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 19:06:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 17:06:16 +0000 Subject: [Koha-bugs] [Bug 34364] Background job - Fix visual progress of progress bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34364 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 19:06:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 17:06:19 +0000 Subject: [Koha-bugs] [Bug 34364] Background job - Fix visual progress of progress bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34364 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153843|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 154414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154414&action=edit Bug 34364: Fix progress bar progress update Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 19:20:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 17:20:02 +0000 Subject: [Koha-bugs] [Bug 34530] CollapseFieldsPatronAddForm - Needs ADD vs. EDIT component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34530 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 19:56:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 17:56:10 +0000 Subject: [Koha-bugs] [Bug 34531] New: Hiding Lost card flag and Gone no address flag via BorrowerUnwantedFields hides Patron restrictions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34531 Bug ID: 34531 Summary: Hiding Lost card flag and Gone no address flag via BorrowerUnwantedFields hides Patron restrictions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com >From BorrowerUnwantedFields 1. Hide Gone no address flag (gonenoaddress) and Lost card flag (lost). 2. Got to memberentrygen.tt and see that Patron restrictions is now hidden -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 21:24:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 19:24:20 +0000 Subject: [Koha-bugs] [Bug 33759] Typo: Thankyou In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759 --- Comment #4 from Katrin Fischer --- Thanks, Alexander! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 22:14:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 20:14:30 +0000 Subject: [Koha-bugs] [Bug 34531] Hiding Lost card flag and Gone no address flag via BorrowerUnwantedFields hides Patron restrictions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34531 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 23:10:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 21:10:23 +0000 Subject: [Koha-bugs] [Bug 34532] New: Silence warns in Patroncard.pm when layout values are empty Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34532 Bug ID: 34532 Summary: Silence warns in Patroncard.pm when layout values are empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1. Go to patron card creator and make a patron card batch, card layout, and card template. 2. In the card layout leave some values blank for Lower left X coordinate and Lower left Y coordinate. 3. Now go create a card batch while tailing the plack-intranet-error log/ 4. Notice in the logs: [2023/08/14 20:50:54] [WARN] Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 109. [2023/08/14 20:50:54] [WARN] Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 248. [2023/08/14 20:50:54] [WARN] Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 249. The more patrons in a given batch the more of these errors you will see. If no llx or lly value is given we should assume it is 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 23:13:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 21:13:48 +0000 Subject: [Koha-bugs] [Bug 34532] Silence warns in Patroncard.pm when layout values are empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34532 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 23:13:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 21:13:50 +0000 Subject: [Koha-bugs] [Bug 34532] Silence warns in Patroncard.pm when layout values are empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34532 --- Comment #1 from Lucas Gass --- Created attachment 154415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154415&action=edit Bug 34532: Silence warns in Patroncard.pm To test: 1. Go to patron card creator and make a patron card batch, card layout, and card template. 2. In the card layout leave some values blank for Lower left X coordinate and Lower left Y coordinate. 3. Now go create a card batch while tailing the plack-intranet-error log/ 4. Notice in the logs: [2023/08/14 20:50:54] [WARN] Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 109. [2023/08/14 20:50:54] [WARN] Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 248. [2023/08/14 20:50:54] [WARN] Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 249. 5. Apply patch, restart_all 6. Try again and notice the WARNS should be gone from the logs now. 7. Make sure you can still create patron cards and the PDF's the generate look right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 23:14:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 21:14:02 +0000 Subject: [Koha-bugs] [Bug 34532] Silence warns in Patroncard.pm when layout values are empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34532 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |lucas at bywatersolutions.com |u | Patch complexity|--- |Small patch Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Aug 14 23:15:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 21:15:22 +0000 Subject: [Koha-bugs] [Bug 34532] Silence warns in Patroncard.pm when layout values are empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34532 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154415|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 154416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154416&action=edit Bug 34532: Silence warns in Patroncard.pm To test: 1. Go to patron card creator and make a patron card batch, card layout, and card template. 2. In the card layout leave some values blank for Lower left X coordinate and Lower left Y coordinate. 3. Now go create a card batch while tailing the plack-intranet-error log/ 4. Notice in the logs: [2023/08/14 20:50:54] [WARN] Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 109. [2023/08/14 20:50:54] [WARN] Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 248. [2023/08/14 20:50:54] [WARN] Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/C4/Patroncards/Patroncard.pm line 249. 5. Apply patch, restart_all 6. Try again and notice the WARNS should be gone from the logs now. 7. Make sure you can still create patron cards and the PDF's the generate look right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 00:06:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 22:06:59 +0000 Subject: [Koha-bugs] [Bug 34262] Add styling to emphasize the "clear selected patrons" button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34262 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- (In reply to Chris Slone from comment #5) > I don't think that emphasizing the button is the total fix here, this is > retaining selected patrons past the point that it makes logical sense; if > you merge 14 records then do a totally new search it still considers those > 14 records to be selected. And it's not just for merging patrons, it's any > previous selection, so adding patrons to a list, selecting for batch edit... > > Besides the fact that considering 13 records that have been deleted as still > being selected, something like merging patrons is a destructive change (to > the old records) and so that function at least should clear it out. > > I think this is just setting people up for errors. Perhaps the "remember patrons" feature implemented in Bug 29971 should be optional. Maybe a sys pref on/off switch? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 00:59:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Aug 2023 22:59:59 +0000 Subject: [Koha-bugs] [Bug 34529] Offline circulation should be able to accept userid as well as cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 04:28:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 02:28:02 +0000 Subject: [Koha-bugs] [Bug 34527] Enhance the Openlibrary book cover retrieval to use the 024 MARC record and the OLID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34527 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 06:14:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 04:14:36 +0000 Subject: [Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #12 from David Cook --- Note that bib record deletions are also impacted by this issue and this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 06:18:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 04:18:22 +0000 Subject: [Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #13 from David Cook --- (In reply to Nick Clemens from comment #10) > The ModBiblio changes are needed to prevent an explosion in logging - > without them we die on recording the modification In the context of touch_all_biblios.pl, I suppose we'll still bust on the line 'my $record = $biblio->metadata->record;' which is probably good for now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 09:06:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 07:06:12 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154317|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 154417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154417&action=edit Bug 34494: Table tmp_holdsqueue fails to be created for MySQL 8 It appears that MySQL 8 rejects creating any table where the primary key is nullable. The table tmp_holdsqueue has a nullable pk ( itemnumber ) but there is no reason for this column to be nullable ( generating a holds queue entry with no itemnumber is not possible ) so it make sense to just remove the nullability for MySQL compatiability. Test Plan: 1) Using MySQL 8.0, attempt to create a database from kohastructure.sql If you use ktd, you can try: DB_IMAGE=mysql:8.0 ktd up 2) Note the failure to create the table 3) Apply this patch 4) Repeat step 1 5) The table is created! Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 09:06:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 07:06:15 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 154418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154418&action=edit Bug 34494: (QA follow-up) fiks spelin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 09:33:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 07:33:59 +0000 Subject: [Koha-bugs] [Bug 14156] Add id tags to each MARC note in the display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14156 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |oleonard at myacpl.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 09:53:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 07:53:50 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor at tuxayo.net QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | --- Comment #6 from Victor Grousset/tuxayo --- weird, with and without the patch I'm hitting this error with MySQL8 before getting to the part relevant to this ticket: koha-koha-1 | DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: DBI connect('database=koha_kohadev;host=db;port=3306','koha_kohadev',...) failed: Authentication plugin 'caching_sha2_password' reported error: Authentication requires secure connection. at /kohadevbox/koha/Koha/Database.pm line 91. at /kohadevbox/koha/Koha/Database.pm line 139 koha-koha-1 exited with code 1 Does that speak to anyone? ktd repo, koha code, ktd images up to date **Anyway**, it works for Kyle and David and the change is trivial, there is enough confidence to not block on my dev env issue. And with the patch, it still works for me with MariaDB. And this will be the CI which fails on the right issue so it should be fixed. So: Makes sense, QA script happy[1], code looks good, passing QA :) [1] waived this perltidy warning: ``` $dbh->do(q{ ALTER TABLE tmp_holdsqueue CHANGE COLUMN itemnumber `itemnumber` int(11) NOT NULL }); ``` ↓↓↓↓↓ ``` $dbh->do( q{ ALTER TABLE tmp_holdsqueue CHANGE COLUMN itemnumber `itemnumber` int(11) NOT NULL } ); ``` The proposed code is following our two examples: https://wiki.koha-community.org/wiki/Database_updates minor tangent question: @Kyle, @Tomas Maybe they should be changed or it's not a big deal to have this warning on each new db rev? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:09:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:09:47 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #7 from Tomás Cohen Arazi --- Testing the upgrade before 28966 (using 328baf44b457bc34cd93ffad8128b79d4ee30a42). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:19:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:19:11 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 --- Comment #8 from Tomás Cohen Arazi --- Upgrading works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:24 +0000 Subject: [Koha-bugs] [Bug 30451] Delete a subscription deletes the linked order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30451 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:26 +0000 Subject: [Koha-bugs] [Bug 30451] Delete a subscription deletes the linked order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30451 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:28 +0000 Subject: [Koha-bugs] [Bug 33909] Improve translation of title tags: Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:29 +0000 Subject: [Koha-bugs] [Bug 33909] Improve translation of title tags: Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 --- Comment #16 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:31 +0000 Subject: [Koha-bugs] [Bug 34056] authorised-values API client file is missing -api-client suffix In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34056 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:32 +0000 Subject: [Koha-bugs] [Bug 34056] authorised-values API client file is missing -api-client suffix In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34056 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:34 +0000 Subject: [Koha-bugs] [Bug 34059] advance_notices.pl -c --digest-per-branch does not work as intended In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34059 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:36 +0000 Subject: [Koha-bugs] [Bug 34059] advance_notices.pl -c --digest-per-branch does not work as intended In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34059 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:37 +0000 Subject: [Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:39 +0000 Subject: [Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #22 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:41 +0000 Subject: [Koha-bugs] [Bug 34155] OPAC item level holds "force" option broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:43 +0000 Subject: [Koha-bugs] [Bug 34155] OPAC item level holds "force" option broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:45 +0000 Subject: [Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:47 +0000 Subject: [Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 --- Comment #18 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:49 +0000 Subject: [Koha-bugs] [Bug 34345] 'Circulation and fine rules' vs 'Circulation and fines rules' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:50 +0000 Subject: [Koha-bugs] [Bug 34345] 'Circulation and fine rules' vs 'Circulation and fines rules' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34345 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:52 +0000 Subject: [Koha-bugs] [Bug 34365] Hold cancellation request workflow cannot be triggered on API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34365 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:53 +0000 Subject: [Koha-bugs] [Bug 34365] Hold cancellation request workflow cannot be triggered on API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34365 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:55 +0000 Subject: [Koha-bugs] [Bug 34387] API docs tags missing descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:57 +0000 Subject: [Koha-bugs] [Bug 34387] API docs tags missing descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34387 --- Comment #18 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:24:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:24:58 +0000 Subject: [Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:25:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:25:00 +0000 Subject: [Koha-bugs] [Bug 34436] Some breadcrumbs lack for translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34436 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:25:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:25:01 +0000 Subject: [Koha-bugs] [Bug 34452] Button 'Update adjustments' is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:25:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:25:03 +0000 Subject: [Koha-bugs] [Bug 34452] Button 'Update adjustments' is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:25:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:25:05 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:25:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:25:06 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:25:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:25:08 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:25:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:25:09 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:33:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:33:48 +0000 Subject: [Koha-bugs] [Bug 34387] API docs tags missing descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34387 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 154419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154419&action=edit [23.05.x] Bug 34387: (QA follow-up) Fix display of 'Import batches' Fixes the heading and sidebar display of the 'Import batches' section. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:36:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:36:52 +0000 Subject: [Koha-bugs] [Bug 34533] New: jsdiff library missing from guided reports page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34533 Bug ID: 34533 Summary: jsdiff library missing from guided reports page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 19663 If you add an sql report which uses outdated syntax, syntax which references biblioitems.marcxml, the interface offers to upgrade that report for you: "This report seems obsolete, it uses biblioitems.marcxml field. " When you click the "Update SQL" button the browser tries to run a diff on the old and new sql versions for display before you save the updated report. The page lost the linked JS library in Bug 19663. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 [Bug 19663] Move JS to the footer: Reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:36:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:36:52 +0000 Subject: [Koha-bugs] [Bug 19663] Move JS to the footer: Reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19663 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34533 [Bug 34533] jsdiff library missing from guided reports page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:36:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:36:58 +0000 Subject: [Koha-bugs] [Bug 34387] API docs tags missing descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34387 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 154420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154420&action=edit [22.11.x] Bug 34387: (QA follow-up) Fix display of 'Import batches' Fixes the heading and sidebar display of the 'Import batches' section. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:38:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:38:10 +0000 Subject: [Koha-bugs] [Bug 34387] API docs tags missing descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154089|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:38:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:38:26 +0000 Subject: [Koha-bugs] [Bug 34387] API docs tags missing descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154092|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:40:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:40:58 +0000 Subject: [Koha-bugs] [Bug 34387] API docs tags missing descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34387 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Manual |rel_22_11_candidate, | |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:41:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:41:57 +0000 Subject: [Koha-bugs] [Bug 34387] API docs tags missing descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34387 --- Comment #21 from Tomás Cohen Arazi --- @Rmaints make sure you pick all the patches for your version. I had to amend the last follow-up for an unintended breakage it introduced, and they ended up stacked at the bottom. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 10:42:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 08:42:08 +0000 Subject: [Koha-bugs] [Bug 34534] New: Anonymisation - ability to set different period by patron category Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34534 Bug ID: 34534 Summary: Anonymisation - ability to set different period by patron category Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: aude.charillon at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Both the batch_anonymise.pl script and the Batch patron deletion/anonymization tool allow to set a number of days or a date after which circulation history is anonymised. However, both of these methods apply the same period of time to all patrons. It would be useful if libraries could set different periods by patron category. For example, if standard users could have their circulation history anonymised earlier than housebound users. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:13:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:13:40 +0000 Subject: [Koha-bugs] [Bug 33755] Profile used is not saved when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33755 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:13:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:13:42 +0000 Subject: [Koha-bugs] [Bug 33755] Profile used is not saved when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33755 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:13:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:13:44 +0000 Subject: [Koha-bugs] [Bug 33848] Enabling Coce in the OPAC breaks cover images on bibliographic detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:13:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:13:46 +0000 Subject: [Koha-bugs] [Bug 33848] Enabling Coce in the OPAC breaks cover images on bibliographic detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:13:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:13:49 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:13:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:13:50 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:13:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:13:52 +0000 Subject: [Koha-bugs] [Bug 34197] Group and label vendor contact settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34197 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:13:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:13:54 +0000 Subject: [Koha-bugs] [Bug 34197] Group and label vendor contact settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34197 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:13:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:13:56 +0000 Subject: [Koha-bugs] [Bug 34289] UI issue on checkin page when checking the forgive fines checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:13:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:13:58 +0000 Subject: [Koha-bugs] [Bug 34289] UI issue on checkin page when checking the forgive fines checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:00 +0000 Subject: [Koha-bugs] [Bug 34292] Date formatting in checkouts list broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:02 +0000 Subject: [Koha-bugs] [Bug 34292] Date formatting in checkouts list broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:04 +0000 Subject: [Koha-bugs] [Bug 34322] Correct icon triggering more fund search options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:07 +0000 Subject: [Koha-bugs] [Bug 34322] Correct icon triggering more fund search options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:08 +0000 Subject: [Koha-bugs] [Bug 34344] Make item types breadcrumbs uniform In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34344 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:10 +0000 Subject: [Koha-bugs] [Bug 34344] Make item types breadcrumbs uniform In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34344 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:12 +0000 Subject: [Koha-bugs] [Bug 34354] Job progress typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34354 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:14 +0000 Subject: [Koha-bugs] [Bug 34354] Job progress typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34354 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:16 +0000 Subject: [Koha-bugs] [Bug 34357] Subroutine Koha::ItemType::SUPER::imageurl redefined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34357 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:18 +0000 Subject: [Koha-bugs] [Bug 34357] Subroutine Koha::ItemType::SUPER::imageurl redefined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34357 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:20 +0000 Subject: [Koha-bugs] [Bug 34359] Get rid of Koha/BiblioUtils/Iterator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:23 +0000 Subject: [Koha-bugs] [Bug 34359] Get rid of Koha/BiblioUtils/Iterator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:25 +0000 Subject: [Koha-bugs] [Bug 34433] 'Custom cover image' in lightbox is untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34433 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:26 +0000 Subject: [Koha-bugs] [Bug 34433] 'Custom cover image' in lightbox is untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34433 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:28 +0000 Subject: [Koha-bugs] [Bug 34434] Terminology: Biblio should be bibliographic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34434 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:29 +0000 Subject: [Koha-bugs] [Bug 34434] Terminology: Biblio should be bibliographic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34434 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:33 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:35 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:38 +0000 Subject: [Koha-bugs] [Bug 34493] Bad indenting in search_indexes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34493 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:14:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:14:40 +0000 Subject: [Koha-bugs] [Bug 34493] Bad indenting in search_indexes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34493 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:17:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:17:32 +0000 Subject: [Koha-bugs] [Bug 34435] get_password_expiry_date should not modify its parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34435 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:17:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:17:34 +0000 Subject: [Koha-bugs] [Bug 34435] get_password_expiry_date should not modify its parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34435 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:19:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:19:46 +0000 Subject: [Koha-bugs] [Bug 34533] jsdiff library missing from guided reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34533 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:19:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:19:50 +0000 Subject: [Koha-bugs] [Bug 34533] jsdiff library missing from guided reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34533 --- Comment #1 from Owen Leonard --- Created attachment 154421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154421&action=edit Bug 34533: jsdiff library missing from guided reports page This patch restores the inclusion of the jsdiff JS library on the guided reports page when displaying saved SQL reports. This fixes a JS error in the browser console when the user tries to use our automatic update on SQL reports which use an older syntax. The patch also corrects a problem with svc/convert_report which was causing an error when trying to display the diff information. To test, apply the patch and restart services. - Go to Reports -> Create from SQL. - Add a report which is based on an older db structure. The example I found was: SELECT biblionumber, ExtractValue(marcxml,'//datafield/@tag/text()[substring(.,1,1) = "5"]') as 'notes' FROM biblioitems HAVING notes <> '' - Save the report and go to the list of saved reports. There should be an "Update" column in the table, with a message about your newly-added report: "This report seems obsolete, it uses biblioitems.marcxml field." - Clicking the "Update SQL" button should trigger a modal window that shows the before an after versions of the report. There should be no error in the browser console. Unfortunately the diff will not display because of a separate bug in svc/convert_report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:41:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:41:48 +0000 Subject: [Koha-bugs] [Bug 14156] Add id tags to each MARC note in the display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14156 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:41:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:41:53 +0000 Subject: [Koha-bugs] [Bug 14156] Add id tags to each MARC note in the display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14156 --- Comment #4 from Owen Leonard --- Created attachment 154422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154422&action=edit Bug 14156: Add id tags to each MARC note in the display This patch adds tag number to the data which is returned by $biblio->get_marc_notes(). The bibliographic detail page in the staff client is modified to use the tag number in both a class (for consistent styling across the same tag number) and id (for unique styling for each repeated tag). To test, apply the patch and restart services. - As a quick test for custom CSS, go to Administration -> System preferences and locate the IntranetUserCSS preference. - Add this testing CSS: .marcnote { font-size:140%; font-family: serif; } .marcnote-500 { background-color: #66FFCC; } .marcnote-511 { background-color: #99FFFF; } .marcnote-520 { background-color: #CCFF00; } .marcnote-521 { background-color: #CCFFFF; } .marcnote-538 { background-color: #FFCCCC; } .marcnote-546 { background-color: #FFFFCC; } - Locate a record with multiple notes fields. In the sample data, record 46, "Viridiana" is a good example which works well with the above CSS. - On the bibliographic detail page for the record, click the "Descriptions" tab. - Each MARC note should be colored according to the tag it comes from. - Inspect the HTML to confirm that each paragraph also has its own unique ID. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 11:42:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 09:42:56 +0000 Subject: [Koha-bugs] [Bug 14156] Add id tags to each MARC note in the display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14156 --- Comment #5 from Owen Leonard --- Nicole, please come back and test this patch :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 12:15:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 10:15:52 +0000 Subject: [Koha-bugs] [Bug 28172] Optimize Koha::Plugins::GetPlugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs Signoff |RESOLVED --- Comment #10 from David Nind --- Changed status - fixed on bug 29672. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 12:15:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 10:15:52 +0000 Subject: [Koha-bugs] [Bug 7923] Performance omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Bug 7923 depends on bug 28172, which changed state. Bug 28172 Summary: Optimize Koha::Plugins::GetPlugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28172 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 12:30:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 10:30:29 +0000 Subject: [Koha-bugs] [Bug 34364] Background job - Fix visual progress of progress bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34364 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 12:30:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 10:30:33 +0000 Subject: [Koha-bugs] [Bug 34364] Background job - Fix visual progress of progress bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34364 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 12:30:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 10:30:38 +0000 Subject: [Koha-bugs] [Bug 34364] Background job - Fix visual progress of progress bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34364 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 12:38:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 10:38:29 +0000 Subject: [Koha-bugs] [Bug 34535] New: Online help directs you to incorrect place Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34535 Bug ID: 34535 Summary: Online help directs you to incorrect place Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: fiona.borthwick at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In 22.11, cataloguing tools were moved to the Cataloguing screen. If you click Help when on the Export data screen, you get taken to this help file - https://koha-community.org/manual//22.11/en/html/tools.html#export-bibliographic-records which is no longer correct. The user then needs to navigate to Cataloguing / Export Data from the menu option on the left. Can the link be updated please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 13:29:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 11:29:13 +0000 Subject: [Koha-bugs] [Bug 29752] [DOCS] Look at adding documentation tasks to the dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29752 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30998 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 13:29:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 11:29:13 +0000 Subject: [Koha-bugs] [Bug 30998] [DOCS] Managing documentation tasks - simplify processes and integrate more with the development process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30998 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29752 Status|ASSIGNED |RESOLVED --- Comment #24 from David Nind --- I think this is now resolved with Bug 29752. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 13:44:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 11:44:54 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153824|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize --- Created attachment 154423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154423&action=edit Bug 25672: use enable_plugin_browser_upload flag to control plugin upload This patch adds a enable_plugin_browser_upload flag to koha-conf.xml, which controls whether or not Koha intranet users can upload Koha plugins via their browser. Like "enable_plugins", it defaults to 0 for new installs. This is useful when you want to provide Koha intranet users with plugins that are pre-installed by administrators (by CLI) or restricting them to plugins from a Github repo. See the following for more information: Bug 23975 - Add ability to search and install plugins from GitHub Bug 23191 - Administrators should be able to install plugins from the command line To test: 1) Apply the patch 2) Set 1 in koha-conf.xml 3) Add 0 in koha-conf.xml 4) restart_all (in koha-testing-docker) 5) Go to /cgi-bin/koha/plugins/plugins-home.pl and note that you don't see an option to upload plugins 6) Go to /cgi-bin/koha/plugins/plugins-upload.pl and note that it says "Plugin browser upload disabled!" and gives instructions on how to enable browser upload 7) Install a plugin from the CLI using koha-shell kohadev -c "/usr/share/koha/bin/devel/install_plugins.pl" 8) Note that the Uninstall option for the plugin does not appear 9) Enable Koha plugin git repos and search for "coverflow" 10) Note that you can find the plugin but you cannot install it 11) Change enable_plugin_browser_upload back to 1 and "restart_all" 12) Note that you can not upload plugins, uninstall plugins, and install plugins from Git repos Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 13:44:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 11:44:57 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153825|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize --- Created attachment 154424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154424&action=edit Bug 25672: Enable enable_plugin_browser_upload by default This patch enables enable_plugin_browser_upload by default, since the current behaviour for Koha is to enable browser upload when enable_plugins is 1. Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 13:45:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 11:45:00 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153826|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Created attachment 154425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154425&action=edit Bug 25672: (QA follow-up) Hide install after search button If plugin upload is disabled, but there are git repositories listed in the config for plugin searching, then you can search for a plugin and attempt to install it. The install leads to an error page. This patch removes the actions column and install button should the enable_browser_upload option be disabled Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 13:45:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 11:45:02 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153827|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize --- Created attachment 154426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154426&action=edit Bug 25672: Prevent uninstall when plugin browser upload disabled When plugin browser upload is disabled, also prevent plugin browser uninstall. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 13:45:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 11:45:05 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #37 from Martin Renvoize --- Created attachment 154427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154427&action=edit Bug 25672: Convert to restricting to listed repositories only I think instead of a plain on/off switch we should use it in combination with the plugin_repo's and set it to restrict to only those repos' (i.e. disable uploads entirely if no repo's are listed, or just allow those repo's when there are). This patch achieves that, but only if plugins are installed via the plugin browser method. We disable all direct upload avenues, so install is blocked for other cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 13:45:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 11:45:24 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153925|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 13:50:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 11:50:05 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #10 from David Nind --- The patch no longer applies 8-(... Applying: Bug 24401: REST API: Check-in Using index info to reconstruct a base tree... M Koha/REST/V1/Checkouts.pm M api/v1/swagger/paths/checkouts.yaml M api/v1/swagger/swagger.yaml M t/db_dependent/api/v1/checkouts.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/api/v1/checkouts.t CONFLICT (content): Merge conflict in t/db_dependent/api/v1/checkouts.t Auto-merging api/v1/swagger/swagger.yaml Auto-merging api/v1/swagger/paths/checkouts.yaml Auto-merging Koha/REST/V1/Checkouts.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 24401: REST API: Check-in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 13:51:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 11:51:59 +0000 Subject: [Koha-bugs] [Bug 33997] Borrowers.updated_on should not be updated by track_login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:02:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:02:26 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com | |, | |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:03:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:03:32 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen at gmail.com --- Comment #18 from Tomás Cohen Arazi --- Is it correct or not? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:16:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:16:26 +0000 Subject: [Koha-bugs] [Bug 34447] "Actions" columns are exported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34447 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tomás Cohen Arazi --- > Created attachment 154102 [details] [review] > Bue 34447: Do not export "Actions" columns ^ Hey y'all, please don't forget to run the 'qa' script... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:17:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:17:21 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152717|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 154428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154428&action=edit Bug 24401: REST API: Check-in Updating files to include API endpoints for check-ins Test plan: 1) Apply bug 23336 as there are dependencies in there required for this to work 2) Apply this patch 3) Run unit tests in t/db_dependent/api/v1/checkouts.t 4) Make POST request to http://yourlibrary/api/v1/checkouts with request body containing 'item_id' & 'library_id' properties. - Observe returned data and HTTP code - 201 for item checked in - 403 for check in not allowed - 409 for Item not found - 400 for item not checked out Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:17:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:17:23 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 --- Comment #12 from Martin Renvoize --- Created attachment 154429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154429&action=edit Bug 24401: (QA follow-up) Tidy Checkouts.pm This just tidies the API controller to fit current best practice and make the QA script happy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:17:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:17:26 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 --- Comment #13 from Martin Renvoize --- Created attachment 154430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154430&action=edit Bug 24401: (QA follow-up) Remove $c->validation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:17:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:17:29 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 --- Comment #14 from Martin Renvoize --- Created attachment 154431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154431&action=edit Bug 24401: (QA follow-up) Fix failing test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:18:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:18:36 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:19:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:19:04 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 --- Comment #15 from Martin Renvoize --- Rebased and resolved QA script issues highlighted.. I've not actually tested the code as yet however, so leaving as NSO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:19:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:19:53 +0000 Subject: [Koha-bugs] [Bug 12421] No way to get back to search results from overdrive results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:19:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:19:55 +0000 Subject: [Koha-bugs] [Bug 12421] No way to get back to search results from overdrive results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:19:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:19:57 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforloan values as unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:19:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:19:59 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforloan values as unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 --- Comment #20 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:20:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:20:01 +0000 Subject: [Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:20:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:20:03 +0000 Subject: [Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:20:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:20:05 +0000 Subject: [Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:20:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:20:06 +0000 Subject: [Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:20:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:20:08 +0000 Subject: [Koha-bugs] [Bug 34305] If actual cost is negative, wrong price will display in the acq details tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34305 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:20:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:20:10 +0000 Subject: [Koha-bugs] [Bug 34305] If actual cost is negative, wrong price will display in the acq details tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34305 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:20:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:20:12 +0000 Subject: [Koha-bugs] [Bug 34343] Z39.50 search background not updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:20:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:20:13 +0000 Subject: [Koha-bugs] [Bug 34343] Z39.50 search background not updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:20:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:20:15 +0000 Subject: [Koha-bugs] [Bug 34351] ILL list table - access_url column content should be clickable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34351 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:20:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:20:17 +0000 Subject: [Koha-bugs] [Bug 34351] ILL list table - access_url column content should be clickable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34351 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:20:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:20:19 +0000 Subject: [Koha-bugs] [Bug 34447] "Actions" columns are exported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34447 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:20:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:20:20 +0000 Subject: [Koha-bugs] [Bug 34447] "Actions" columns are exported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34447 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:26:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:26:46 +0000 Subject: [Koha-bugs] [Bug 33843] Use filter_by_last_update in Koha::Notice::Util In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33843 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:26:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:26:48 +0000 Subject: [Koha-bugs] [Bug 33843] Use filter_by_last_update in Koha::Notice::Util In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33843 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153922|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 154432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154432&action=edit Bug 33843: Use filter_by_last_update in Koha::Notice::Util Resolve FIXME in sub _get_domain_count by using new logic from bug 33837. Test plan: Run t/db_dependent/Koha/Notice_Util.t. This triggers the _get_domain_count call using the filter. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 14:58:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 12:58:04 +0000 Subject: [Koha-bugs] [Bug 34523] Add smart logic to branches for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34523 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 15:48:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 13:48:24 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34464 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 17:03:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 15:03:08 +0000 Subject: [Koha-bugs] [Bug 25996] Changes to restrictions should be logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 17:03:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 15:03:54 +0000 Subject: [Koha-bugs] [Bug 25996] Changes to restrictions should be logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25996 --- Comment #2 from Rebecca Coert --- Tested this on 22.11 and it's still showing as Andrew described in 2020. This needs to be fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 17:04:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 15:04:32 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139501|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 154433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154433&action=edit Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences. Signed-off-by: Brandon J -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 17:04:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 15:04:35 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #21 from Martin Renvoize --- Created attachment 154434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154434&action=edit Bug 6419: Add IntranetAcquisitionsHome block to additional contents This patch adds a new `IntranetAcquisitionsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the acquisitions home page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 17:04:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 15:04:38 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #22 from Martin Renvoize --- Created attachment 154435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154435&action=edit Bug 6419: Add IntranetAuthoritiesHome block to additional contents This patch adds a new `IntranetAuthoritiesHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the authorities home page. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 17:04:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 15:04:41 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #23 from Martin Renvoize --- Created attachment 154436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154436&action=edit Bug 6419: Add IntranetCataloguingHome block to additional contents This patch adds a new `IntranetCataloguingHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the cataloguing home page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 17:05:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 15:05:48 +0000 Subject: [Koha-bugs] [Bug 31573] Patron restrictions page in administration should hint required syspref PatronRestrictionTypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31573 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 17:07:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 15:07:14 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #24 from Martin Renvoize --- I've started the conversion.. if someone fancies taking a look at the outstanding ones that would be awesome.. I've been converting from the ones added in the original patch one per patch so we can track them easily. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 17:37:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 15:37:49 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #25 from Martin Renvoize --- Created attachment 154437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154437&action=edit Bug 6419: Add IntranetListsHome block to additional contents This patch adds a new `IntranetListsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the lists home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 18:27:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 16:27:21 +0000 Subject: [Koha-bugs] [Bug 10869] Can't cancel order line if title deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #100 from Barbara Johnson --- I agree with Rhonda. This is problematic functionality and it would be great to get a fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 18:45:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 16:45:15 +0000 Subject: [Koha-bugs] [Bug 24401] REST API: Check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401 --- Comment #16 from Lucas Gass --- Is delete the best name for this subroutine? Since perl has a delete() would it not be better to call this delete_checkout? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 21:29:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 19:29:13 +0000 Subject: [Koha-bugs] [Bug 29079] Make bibliographic information in holds queue customizable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29079 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 21:41:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 19:41:35 +0000 Subject: [Koha-bugs] [Bug 34447] "Actions" columns are exported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34447 --- Comment #6 from Pedro Amorim --- (In reply to Tomás Cohen Arazi from comment #4) > > Created attachment 154102 [details] [review] [review] > > Bue 34447: Do not export "Actions" columns > ^ > > Hey y'all, please don't forget to run the 'qa' script... Fair point. Thanks Tomas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 22:46:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 20:46:20 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 22:46:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 20:46:26 +0000 Subject: [Koha-bugs] [Bug 32607] Add import sources CRUD In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607 --- Comment #21 from Agustín Moyano --- Created attachment 154438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154438&action=edit Bug 32607: (follow-up) Apply new suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Aug 15 23:03:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 21:03:39 +0000 Subject: [Koha-bugs] [Bug 33690] Add ability to send welcome notice when creating patrons using the REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33690 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 00:01:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 22:01:35 +0000 Subject: [Koha-bugs] [Bug 34538] New: additional-contents.pl needs a None option in libraries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34538 Bug ID: 34538 Summary: additional-contents.pl needs a None option in libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Currently, I can set something like opacheader for all libraries or specific libraries, but I cannot tell it what to display for no libraries. Without logging in on the OPAC, I see the header. I haven't identified a library. It is showing opadheader assigned to all libraries. If I have an opacheader for a specific library, and I log in as a patron to that library, both headers show. What I would want to see is a way to define an element for when you are not logged in, and then a specific header all libraries, and then if I want specific headers for certain libraries, they would take the place of the all libraries one. So, what we need is: - library location of None/Not selected - a check box or something to indicate we want it to override all other elements of the same name, rather than in addition to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 01:50:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 23:50:17 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #19 from David Cook --- (In reply to Tomás Cohen Arazi from comment #18) > Is it correct or not? The patch is correct. The patch just removes a small logic error. Currently, if the soonest renewal time is 1970-01-01 00:00:00, the time returned will be $now. This patch makes it so that 1970-01-01 will be returned instead. -- The (pre-existing) issue that Katrin has observed is that Kate::DateUtils->output_pref erases "11:59 PM" and "23:59" from the time when output_pref() takes an "as_due_date" parameter. In master: If due date is "2023-08-21 23:59:00" "NoRenewalBeforePrecision" set to "date" - "No renewal before 08/16/2023 00:00" "NoRenewalBeforePrecision" set to "exact" - "No renewal before 08/16/2023" If due date is "2023-08-21 22:00:00" "NoRenewalBeforePrecision" set to "date" - "No renewal before 08/16/2023 00:00" "NoRenewalBeforePrecision" set to "exact" - "No renewal before 08/16/2023 22:00" This behaviour dates back to bug 11148. It looks like Marcel noticed it during QA back then even: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148#c25 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 01:54:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 23:54:01 +0000 Subject: [Koha-bugs] [Bug 34539] New: Time not shown for due dates with time of 23:59 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34539 Bug ID: 34539 Summary: Time not shown for due dates with time of 23:59 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org As noted at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362#c19 due dates with a time of 23:59 get the time erased. If the due date time is any time but 23:59, the time will appear under columns like "Due date" and "Renew". However, if it's "23:59", then the time doesn't appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 01:54:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 23:54:01 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34539 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 01:54:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 23:54:14 +0000 Subject: [Koha-bugs] [Bug 34539] Time not shown for due dates and renewal dates with time of 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34539 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Time not shown for due |Time not shown for due |dates with time of 23:59 |dates and renewal dates | |with time of 23:59 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 01:55:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 23:55:40 +0000 Subject: [Koha-bugs] [Bug 34539] Time not shown for due dates and renewal dates with time of 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34539 --- Comment #1 from David Cook --- Personally, I don't know why we wouldn't show 23:59 - at least on the staff interface. On the OPAC, I suppose a library might not want to show the exact time it's due except for hourly loans, but then we allow libraries to set specific times as well, so... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 01:56:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 15 Aug 2023 23:56:13 +0000 Subject: [Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 --- Comment #20 from David Cook --- (In reply to David Cook from comment #19) > The (pre-existing) issue that Katrin has observed is that > Kate::DateUtils->output_pref erases "11:59 PM" and "23:59" from the time > when output_pref() takes an "as_due_date" parameter. I've raised bug 34539 to document the issue, but as I note above it's related to the patch on this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 02:09:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 00:09:22 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #38 from David Cook --- Comment on attachment 154427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154427 Bug 25672: Convert to restricting to listed repositories only Review of attachment 154427: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25672&attachment=154427) ----------------------------------------------------------------- ::: plugins/plugins-upload.pl @@ +48,5 @@ > + $template->param( plugins_restricted => $plugins_restricted ); > +} > + > +# Exit early if uploads are not enabled > +if ( !$ ) { You've got a little typo here with the variable name. But I'm not sure how this would work with the current implementation of "plugins_restricted"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 02:09:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 00:09:46 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 03:16:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 01:16:03 +0000 Subject: [Koha-bugs] [Bug 34539] Time not shown for due dates and renewal dates with time of 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34539 --- Comment #2 from David Cook --- Bug 34292 got me looking at koha-tmpl/intranet-tmpl/prog/en/includes/js-date-format.inc which also has some handling for 23:59. So if there is any chagne to Koha::DateUtils, we'd also need to make it to this include. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 03:16:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 01:16:08 +0000 Subject: [Koha-bugs] [Bug 34539] Time not shown for due dates and renewal dates with time of 23:59 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34539 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34292 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 03:16:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 01:16:08 +0000 Subject: [Koha-bugs] [Bug 34292] Date formatting in checkouts list broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34539 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 03:19:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 01:19:50 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #10 from David Cook --- (In reply to Nick Clemens from comment #8) > Very small change, straightforward code, and excellently sleuthed! +1 to the excellent sleuthing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 04:57:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 02:57:54 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 --- Comment #10 from Victor Grousset/tuxayo --- (In reply to Tomás Cohen Arazi from comment #7) > Testing the upgrade before 28966 (using > 328baf44b457bc34cd93ffad8128b79d4ee30a42). Thanks, so the idea is if possible, spin a Koha on the version just before the problem was created. And then upgrade it to main/master + the patch to see if the combination works, did I get it right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 08:12:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 06:12:21 +0000 Subject: [Koha-bugs] [Bug 26170] Create "system" patrons that cannot be (easily) deleted via the web UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 08:28:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 06:28:15 +0000 Subject: [Koha-bugs] [Bug 32739] REST API: Extend endpoint /auth/password/validation for cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32739 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 08:34:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 06:34:22 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #26 from Martin Renvoize --- Created attachment 154441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154441&action=edit Bug 6419: Add IntranetPatronsHome block to additional contents This patch adds a new `IntranetPatronsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the patrons home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 08:42:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 06:42:14 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #27 from Martin Renvoize --- Created attachment 154442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154442&action=edit Bug 6419: Add IntranetPOSHome block to additional contents This patch adds a new `IntranetPOSHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: All the blocks have been placed at the bottom of the home pages respectively for consistency. However, in this case it doesn't look as clean as the content above is a form. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 08:51:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 06:51:06 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #28 from Martin Renvoize --- Created attachment 154443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154443&action=edit Bug 6419: Add IntranetSerialsHome block to additional contents This patch adds a new `IntranetSerialsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: This patch also removes the now defunct database update introduced in the first patch of the series. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 08:54:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 06:54:42 +0000 Subject: [Koha-bugs] [Bug 25023] Claims returned dates not formatted according to dateformat preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #5 from Victor Grousset/tuxayo --- I'm not enough knowledgeable with the JS part to review it but about the template: why do we need a duplication of the lines with return-claim-created-on and return-claim-updated-on? It's definitely related to ``` "mDataProp": "created_on", "bVisible": false, ``` and it's counterpart for updated-on. And without the duplication in the template, the table breaks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:03:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:03:44 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #29 from Owen Leonard --- I would like to use another term besides "Intranet" since we've been trying to get away from that word for a while. I would think "Staff" would be clear enough to distinguish these options from the ones which are for the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:06:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:06:38 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:08:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:08:47 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #30 from Martin Renvoize --- That's a good call Owen.. I can do that. I've not migrated any existing preferences here yet either.. but I'd like to. I'd also love to see these contents blocks work a little differently from News with regards dates.. it's a bit silly to require a publication date for these blocks that are much more likely to just be static. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:09:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:09:24 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|david.roberts at ptfs-europe.c |martin.renvoize at ptfs-europe |om |.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:34:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:34:07 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154433|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize --- Created attachment 154444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154444&action=edit Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences. Signed-off-by: Brandon J -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:34:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:34:10 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #32 from Martin Renvoize --- Created attachment 154445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154445&action=edit Bug 6419: Add StaffAcquisitionsHome block to additional contents This patch adds a new `StaffAcquisitionsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the acquisitions home page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:34:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:34:13 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #33 from Martin Renvoize --- Created attachment 154446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154446&action=edit Bug 6419: Add StaffAuthoritiesHome block to additional contents This patch adds a new `StaffAuthoritiesHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the authorities home page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:34:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:34:17 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #34 from Martin Renvoize --- Created attachment 154447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154447&action=edit Bug 6419: Add StaffCataloguingHome block to additional contents This patch adds a new `StaffCataloguingHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the cataloguing home page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:34:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:34:20 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #35 from Martin Renvoize --- Created attachment 154448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154448&action=edit Bug 6419: Add StaffListsHome block to additional contents This patch adds a new `StaffListsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the lists home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:34:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:34:23 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #36 from Martin Renvoize --- Created attachment 154449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154449&action=edit Bug 6419: Add StaffPatronsHome block to additional contents This patch adds a new `StaffPatronsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the patrons home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:34:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:34:26 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #37 from Martin Renvoize --- Created attachment 154450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154450&action=edit Bug 6419: Add StaffPOSHome block to additional contents This patch adds a new `StaffPOSHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: All the blocks have been placed at the bottom of the home pages respectively for consistency. However, in this case it doesn't look as clean as the content above is a form. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:34:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:34:29 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #38 from Martin Renvoize --- Created attachment 154451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154451&action=edit Bug 6419: Add StaffSerialsHome block to additional contents This patch adds a new `StaffSerialsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: This patch also removes the now defunct database update introduced in the first patch of the series. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:34:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:34:55 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154434|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:35:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:35:02 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154435|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:35:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:35:11 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154436|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:35:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:35:18 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154437|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:35:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:35:27 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154441|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:35:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:35:36 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154442|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:35:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:35:45 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154443|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:38:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:38:21 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #39 from Martin Renvoize --- Done the switch to 'Staff' now.. just the migrations of the old preference based ones that pre-exist this patchset now.. should we do that here or in a follow-up bug? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:57:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:57:27 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31162 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:57:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:57:27 +0000 Subject: [Koha-bugs] [Bug 31162] Add a clear cataloguing module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6419 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 [Bug 6419] Add customizable areas to intranet home pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 09:58:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 07:58:54 +0000 Subject: [Koha-bugs] [Bug 31652] Add geo-search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com | |, | |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 10:17:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 08:17:45 +0000 Subject: [Koha-bugs] [Bug 34076] [ALTERNATE] [DOCS] Automated screenshots using Cypress.io testing framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34076 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com | |, | |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 10:24:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 08:24:39 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #40 from Owen Leonard --- Created attachment 154452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154452&action=edit Bug 6419: (follow-up) Use Select2 with optgroups This patch divides the OPAC and staff options into separate optgroups and adds Select2 for styling and filtering. THe patch also corrects a few missed instances of "Intranet" in the list of location options on the entry form. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 10:26:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 08:26:11 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34536 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 10:28:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 08:28:40 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34537 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 10:35:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 08:35:04 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154427|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize --- Created attachment 154453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154453&action=edit Bug 25672: Convert to restricting to listed repositories only I think instead of a plain on/off switch we should use it in combination with the plugin_repo's and set it to restrict to only those repos' (i.e. disable uploads entirely if no repo's are listed, or just allow those repo's when there are). This patch achieves that, but only if plugins are installed via the plugin browser method. We disable all direct upload avenues, so install is blocked for other cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 10:36:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 08:36:22 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #40 from Martin Renvoize --- Good catch, I've fixed that inline in the latest patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 10:43:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 08:43:46 +0000 Subject: [Koha-bugs] [Bug 33716] ILL - Allow for a disclaimer stage per request type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33716 --- Comment #51 from Pedro Amorim --- Created attachment 154454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154454&action=edit Bug 33716: (QA follow-up) Fix xt/yaml_valid.t Test plan: Run prove -vv xt/yaml_valid.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 11:03:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 09:03:34 +0000 Subject: [Koha-bugs] [Bug 25023] Claims returned dates not formatted according to dateformat preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 --- Comment #6 from Owen Leonard --- (In reply to Victor Grousset/tuxayo from comment #5) > why do we need a duplication of the lines with return-claim-created-on and > return-claim-updated-on? Each date column has a corresponding hidden column which contains the unformatted date which is used when sorting by that date. In the visible column we see the formatted date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 11:10:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 09:10:32 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #65 from Victor Grousset/tuxayo --- Will that warning ever be visible in a real installation impacted by this? Since to see the warning, one must have been able to do many DB upgrades to reach 22.11.x and will certainly (IIUC) hit the issue on a few of the tables that had alterations in the last few years. I guess if they only fix the blocking tables one at a time, they will still have most the of the table with the row format. And hence the warning will be useful to hopefully get them all fixed and not hit this again in the future. Is that the main uses that? (admins that didn't fix all the tables) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 11:10:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 09:10:51 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154453|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize --- Created attachment 154455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154455&action=edit Bug 25672: Convert to restricting to listed repositories only I think instead of a plain on/off switch we should use it in combination with the plugin_repo's and set it to restrict to only those repos' (i.e. disable uploads entirely if no repo's are listed, or just allow those repo's when there are). This patch achieves that, but only if plugins are installed via the plugin browser method. We disable all direct upload avenues, so install is blocked for other cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 11:11:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 09:11:16 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #42 from Martin Renvoize --- All works in testing for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 11:13:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 09:13:27 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 11:13:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 09:13:49 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Administrators should be |Administrators should be |able to disable client-side |able to restrict |plugin upload |client-side plugin upload | |to trusted sources -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 11:14:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 09:14:26 +0000 Subject: [Koha-bugs] [Bug 33886] Flatpickr calendar - year controls for date of birth on memberentry.pl are not intuitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33886 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 11:16:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 09:16:54 +0000 Subject: [Koha-bugs] [Bug 33920] Improve translation of title tags: Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33920 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose --- OK Patrons home page OK Patron search OK Merge patron records OK Add patron OK Check duplicate patron OK Patron details for XX (YY) OK API keys OK Account for XX (YY) OK Details of debit - Details of credit - It was like this before, but it still says 'Details of debit' even when we click on the details button of a payment for example OK Print receipt for XX (YY) - improved from before! :) - Print invoice - It was like this before, but the invoice also says 'Print receipt' OK Make a payment for XX (YY) OK Collect payment for XX (YY) OK Create manual invoice OK Create manual credit OK Subscription routing lists for XX (YY) OK Circulation history for XX (YY) - improved from before! :) - Holds history for XX (YY) - I think this one is missing a > between the name and Patrons OK Sent notices for XX (YY) - Discharge for XX (YY) - There is an extra > between the patron's name and Patrons OK Statistics for XX (YY) OK Files for XX (YY) - One > missing between the patron's name and Patrons OK Purchase suggestions for XX (YY) OK Details for XX (YY) > Housebound OK ILL requests history for XX (YY) OK Set permissions for XX (YY) - Update password for XX (YY) - There is an extra > between the patron's name and Patrons OK Print summary for XX (YY) - improved from before! OK Account summary for XX (YY) OK Two-factor authentication OK Modify patron XX (YY) (ZZ) OK Choose adult category OK Delete patron XX (YY) - improved from before! :) OK Pending discharge requests OK Update patron records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 11:18:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 09:18:39 +0000 Subject: [Koha-bugs] [Bug 33920] Improve translation of title tags: Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33920 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Caroline Cyr La Rose --- Hi Owen! I tested this and there are a couple of things that need to be corrected. - Holds history for XX (YY) - I think this one is missing a > between the name and Patrons - Discharge for XX (YY) - There is an extra > between the patron's name and Patrons - Update password for XX (YY) - There is an extra > between the patron's name and Patrons Caroline -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 11:52:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 09:52:57 +0000 Subject: [Koha-bugs] [Bug 33886] Flatpickr calendar - year controls for date of birth on memberentry.pl are not intuitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 12:09:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 10:09:43 +0000 Subject: [Koha-bugs] [Bug 34540] New: Unimarc Default framework Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34540 Bug ID: 34540 Summary: Unimarc Default framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: Igor.A.Sychev at mail.ru QA Contact: testopia at bugs.koha-community.org Unimarc Default framework When saving a record, the message: Tag 600 subfield a Entry Element in tab 6 Tag 601 subfield a Entry Element in tab 6 In Unimarc fields 600 and 601 are optional. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 12:10:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 10:10:34 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144939|0 |1 is obsolete| | --- Comment #23 from Thibaud Guillot --- Created attachment 154456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154456&action=edit Bug 10762: Change the size of barcodes in label creator Test plan: 1)Home > Tools > Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.04), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 12:10:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 10:10:40 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144940|0 |1 is obsolete| | --- Comment #24 from Thibaud Guillot --- Created attachment 154457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154457&action=edit Bug 10762: (follow-up) Update test plan, add kohastructure.sql files I also change the default value for scale_height to '0.01' Test plan: 1)Home > Cataloguing > Tools: Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.02), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 12:10:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 10:10:44 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144941|0 |1 is obsolete| | --- Comment #25 from Thibaud Guillot --- Created attachment 154458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154458&action=edit Bug 10762: (follow-up) Add exec right on atomic update file https://bugs.koha-community.org/show_bug.cgi?id=17062 Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 12:10:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 10:10:49 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 --- Comment #26 from Thibaud Guillot --- Created attachment 154459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154459&action=edit Bug 10762: (follow-up) Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 12:11:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 10:11:34 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 12:19:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 10:19:46 +0000 Subject: [Koha-bugs] [Bug 24638] UNIMARC Authorities update from IFLA for new Koha installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24638 Igor A. Sychev changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 12:39:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 10:39:00 +0000 Subject: [Koha-bugs] [Bug 33920] Improve translation of title tags: Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33920 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 12:39:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 10:39:07 +0000 Subject: [Koha-bugs] [Bug 33920] Improve translation of title tags: Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33920 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152309|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 154460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154460&action=edit Bug 33920: Improve translation of title tags: Patrons This patch updates patron module templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following patron-related pages have the correct title tags: - Patrons home page - Patron search -> - Select two patrons -> Merge selected - Add patron -> - Add a patron with the same name and email address -> - Click "View existing record" in "Duplicate patron record?" dialog. - Patron details - Manage API keys (must have RESTOAuth2ClientCredentials enabled) - Accounting - Transactions - Print fee receipt - Print invoice - Make a payment - Create manual invoice - Create manual credit - Routing lists (must have RoutingSerials enabled) - Circulation history - Notices - Statistics - Files (must have EnableBorrowerFiles enabled) - Purchase suggestions - Discharges (must have useDischarge enabled) - Housebound (must have HouseboundModule enabled) - ILL requests history (must have ILLModule enabled) - Set permissions - Change password - Print summary - Print account balance - Two-factor authentication (must have TwoFactorAuthentication enabled) - Edit patron - Update child to adult patron: - Must have more than one "adult" type category defined - Locate a patron with a "child" type category - Choose More -> Update child to adult patron - Delete patron (confirmation page) - Pending discharge requests - Patrons requesting modifications -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:19:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:19:30 +0000 Subject: [Koha-bugs] [Bug 34541] New: MARC authority framework doesn't work if there is only one tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34541 Bug ID: 34541 Summary: MARC authority framework doesn't work if there is only one tab Change sponsored?: --- Product: Koha Version: 22.11 Hardware: PC OS: Windows Status: NEW Severity: minor Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: alejojanin at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 154461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154461&action=edit Authority framework console error MARC authority framework is not working when all MARC fields are on the same tab. It doesn't allow saving the record. I attach a screenshot of console error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:27:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:27:46 +0000 Subject: [Koha-bugs] [Bug 34313] Make password validation endpoint return patron IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34313 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:27:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:27:50 +0000 Subject: [Koha-bugs] [Bug 34313] Make password validation endpoint return patron IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34313 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153787|0 |1 is obsolete| | --- Comment #10 from Nick Clemens --- Created attachment 154462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154462&action=edit Bug 34313: Unit tests Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:27:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:27:56 +0000 Subject: [Koha-bugs] [Bug 34313] Make password validation endpoint return patron IDs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34313 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153788|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 154463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154463&action=edit Bug 34313: Add patron information in pass validation response This patch makes the password validation response return the following patron attributes to the API consumer: * cardnumber * userid This will give hints on what was used to validate in the fallback bahvior the endpoint has. To test: 1. Apply the unit tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/password_validation.t => FAIL: The endpoint doesn't return this valuable data 3. Apply this patch 4. Repeat 2 => SUCESS: Tests pass! We got the cardnumber and the userid! 5. Sign off :-D Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:29:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:29:15 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:29:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:29:18 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154423|0 |1 is obsolete| | Attachment #154424|0 |1 is obsolete| | Attachment #154425|0 |1 is obsolete| | Attachment #154426|0 |1 is obsolete| | Attachment #154455|0 |1 is obsolete| | --- Comment #43 from Kyle M Hall --- Created attachment 154464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154464&action=edit Bug 25672: use enable_plugin_browser_upload flag to control plugin upload This patch adds a enable_plugin_browser_upload flag to koha-conf.xml, which controls whether or not Koha intranet users can upload Koha plugins via their browser. Like "enable_plugins", it defaults to 0 for new installs. This is useful when you want to provide Koha intranet users with plugins that are pre-installed by administrators (by CLI) or restricting them to plugins from a Github repo. See the following for more information: Bug 23975 - Add ability to search and install plugins from GitHub Bug 23191 - Administrators should be able to install plugins from the command line To test: 1) Apply the patch 2) Set 1 in koha-conf.xml 3) Add 0 in koha-conf.xml 4) restart_all (in koha-testing-docker) 5) Go to /cgi-bin/koha/plugins/plugins-home.pl and note that you don't see an option to upload plugins 6) Go to /cgi-bin/koha/plugins/plugins-upload.pl and note that it says "Plugin browser upload disabled!" and gives instructions on how to enable browser upload 7) Install a plugin from the CLI using koha-shell kohadev -c "/usr/share/koha/bin/devel/install_plugins.pl" 8) Note that the Uninstall option for the plugin does not appear 9) Enable Koha plugin git repos and search for "coverflow" 10) Note that you can find the plugin but you cannot install it 11) Change enable_plugin_browser_upload back to 1 and "restart_all" 12) Note that you can not upload plugins, uninstall plugins, and install plugins from Git repos Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:29:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:29:24 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #44 from Kyle M Hall --- Created attachment 154465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154465&action=edit Bug 25672: Enable enable_plugin_browser_upload by default This patch enables enable_plugin_browser_upload by default, since the current behaviour for Koha is to enable browser upload when enable_plugins is 1. Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:29:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:29:27 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #45 from Kyle M Hall --- Created attachment 154466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154466&action=edit Bug 25672: (QA follow-up) Hide install after search button If plugin upload is disabled, but there are git repositories listed in the config for plugin searching, then you can search for a plugin and attempt to install it. The install leads to an error page. This patch removes the actions column and install button should the enable_browser_upload option be disabled Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:29:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:29:29 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #46 from Kyle M Hall --- Created attachment 154467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154467&action=edit Bug 25672: Prevent uninstall when plugin browser upload disabled When plugin browser upload is disabled, also prevent plugin browser uninstall. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:29:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:29:31 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #47 from Kyle M Hall --- Created attachment 154468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154468&action=edit Bug 25672: Convert to restricting to listed repositories only I think instead of a plain on/off switch we should use it in combination with the plugin_repo's and set it to restrict to only those repos' (i.e. disable uploads entirely if no repo's are listed, or just allow those repo's when there are). This patch achieves that, but only if plugins are installed via the plugin browser method. We disable all direct upload avenues, so install is blocked for other cases. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:29:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:29:56 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30999 Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:29:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:29:56 +0000 Subject: [Koha-bugs] [Bug 30999] Add a script to manage plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30999 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25672 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:30:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:30:05 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 13:46:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 11:46:05 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mengu Yazicioglu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mengu at devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 14:25:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 12:25:20 +0000 Subject: [Koha-bugs] [Bug 14179] Field width for currency is wrong in the GUI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 14:31:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 12:31:52 +0000 Subject: [Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #104 from Martin Renvoize --- I think I've mentioned it before.. but I think the solution likely lies in redaction rather than outright removal of results.. I think we probably need a way to identify what fields should be redacted for the redacted case at each object level and then obviously a way to know when to call a redaction function to clear out the fields for the API response. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 14:35:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 12:35:21 +0000 Subject: [Koha-bugs] [Bug 34424] Update release team on about page for new QA team member In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34424 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 14:39:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 12:39:59 +0000 Subject: [Koha-bugs] [Bug 26994] Display list of names in alphabetical order when using the Suggestion information filter in Suggestions management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26994 Shi Yao Wang changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 14:49:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 12:49:36 +0000 Subject: [Koha-bugs] [Bug 33886] Flatpickr calendar - year controls for date of birth on memberentry.pl are not intuitive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33886 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 14:49:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 12:49:36 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33886 [Bug 33886] Flatpickr calendar - year controls for date of birth on memberentry.pl are not intuitive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 14:51:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 12:51:30 +0000 Subject: [Koha-bugs] [Bug 28469] Move "Skip to main content" link to top of page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 14:51:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 12:51:30 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28469 [Bug 28469] Move "Skip to main content" link to top of page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 14:52:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 12:52:26 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to main content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23003 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 14:52:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 12:52:26 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22807 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 [Bug 22807] Accessibility: Add 'Skip to main content' link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 14:55:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 12:55:40 +0000 Subject: [Koha-bugs] [Bug 34542] New: Add tests for '.maincontent' presence to the QA tools Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34542 Bug ID: 34542 Summary: Add tests for '.maincontent' presence to the QA tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Depends on: 22807 Blocks: 23003 We added the 'Skip to main content' feature in bug 22807. It relies heavily on the present of a .maincontent class being found on every OPAC page. We have a coding guidline around this, but to date I don't think we have a QA script test for it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 [Bug 22807] Accessibility: Add 'Skip to main content' link https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 14:55:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 12:55:40 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to main content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34542 [Bug 34542] Add tests for '.maincontent' presence to the QA tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 14:55:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 12:55:40 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34542 [Bug 34542] Add tests for '.maincontent' presence to the QA tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 15:01:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 13:01:32 +0000 Subject: [Koha-bugs] [Bug 34543] New: Content block accessibility helpers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34543 Bug ID: 34543 Summary: Content block accessibility helpers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Blocks: 23003 With the ability to enter almost anything into the HTML Content blocks, and especially the WYSIWYG editor used.. it's very, very easy to break the accessibility of your OPAC. We should look into options for hinting at correct headings level start point in the editor and perhaps add options for adding simple styled blocks that conform to Koha best practices (Like the use of page-sections in intranet blocks for example) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 15:01:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 13:01:32 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34543 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34543 [Bug 34543] Content block accessibility helpers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 15:07:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 13:07:19 +0000 Subject: [Koha-bugs] [Bug 34543] Content block accessibility helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34543 --- Comment #1 from Martin Renvoize --- TinyMCE actually have an accessability checker tool.. though it looks like a premium plugin to me.. likely licensed? https://www.tiny.cloud/docs/tinymce/6/a11ychecker/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 15:45:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 13:45:24 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 17:30:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 15:30:26 +0000 Subject: [Koha-bugs] [Bug 24073] Allow suggestion management page to default to all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24073 --- Comment #5 from Andrew Fuerste-Henry --- (In reply to Lucas Gass from comment #4) > I am wondering if this problem has been solved by Bug 26833 since now we can > see both the logged in branches suggestions and all libraries suggestions on > /cgi-bin/koha/mainpage.pl. This issue is not particularly solved by Bug 26833. If I follow the link to All Library suggestions from the homepage, I go to /cgi-bin/koha/suggestion/suggestion.pl?branchcode=__ANY__#ASKED and see all suggestions. But if I move off of that page in order to edit a suggestion, all of the avenues back to the main Suggestions page will end up just taking me to /cgi-bin/koha/suggestion/suggestion.pl, where I'll see only my logged-in branch suggestions. We need a way to make the page always default to all branches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 18:26:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 16:26:53 +0000 Subject: [Koha-bugs] [Bug 34544] New: Add file option to delete_items.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34544 Bug ID: 34544 Summary: Add file option to delete_items.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: Slodico at knoxlib.org QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Writeoff_debts.pl and delete_patrons.pl can both be run with input from a file. Please add this option to delete_items.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 18:34:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 16:34:42 +0000 Subject: [Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #31 from Lucas Gass --- Should this still be FQA? I'd like to see it move along! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 19:09:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 17:09:34 +0000 Subject: [Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 --- Comment #32 from Phil Ringnalda --- Do things typically become not-FQA from reasons outside the bug? The patches in this bug have always chosen to implement move with insert_grouped_field, which puts a 600 after a 690, rather than insert_field_ordered, which puts a 600 with 600s, before 610. Nobody has ever responded with a reason why, going back to 2020, only asked "is this still FQA?" Nick's update of the patches included a change to the behavior of copy and replace, from replace the first n to replace all, in a patch called "Unit test." No response as to why, or even whether it was intentional or accidental. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 19:48:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 17:48:50 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 20:03:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 18:03:07 +0000 Subject: [Koha-bugs] [Bug 30031] Add lists to table settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 20:06:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 18:06:27 +0000 Subject: [Koha-bugs] [Bug 32306] Hold modifications don't log correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32306 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 20:28:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 18:28:13 +0000 Subject: [Koha-bugs] [Bug 34545] New: AutoSelfCheckID fails silently if userid is invalid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 Bug ID: 34545 Summary: AutoSelfCheckID fails silently if userid is invalid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If AutoSelfCheckID is an not valid ( either by deleting the patron or by changing the patron's userid ), self-checkout will display the login screen and no error will be generated in any logs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 20:34:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 18:34:05 +0000 Subject: [Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |liz at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 20:37:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 18:37:19 +0000 Subject: [Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 20:37:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 18:37:20 +0000 Subject: [Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 --- Comment #1 from Kyle M Hall --- Created attachment 154469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154469&action=edit Bug 34545: Koha should die with an error if AutoSelfCheckID is invalid If AutoSelfCheckID is an not valid ( either by deleting the patron or by changing the patron's userid ), self-checkout will display the login screen and no error will be generated in any logs. Test Plan: 1) Apply this patch 2) Verify AutoSelfCheckID is working as expected 3) Change AutoSelfCheckID to an invalid userid 4) Restart all the things! 5) Verify visiting sco-main.pl generates an error! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 20:37:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 18:37:30 +0000 Subject: [Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 22:04:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 20:04:13 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 22:20:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 20:20:59 +0000 Subject: [Koha-bugs] [Bug 34546] New: Report group code should only contain ASCII chars Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34546 Bug ID: 34546 Summary: Report group code should only contain ASCII chars Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org When creating a new report, one can create a new report group. Since its code will be used in tab id attribute, it should be tested to contain only ASCII chars (and no space) : [a-zA-Z0-9_-] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 22:48:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 20:48:19 +0000 Subject: [Koha-bugs] [Bug 34547] New: Add transfer reason to returns.pl table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34547 Bug ID: 34547 Summary: Add transfer reason to returns.pl table Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: hebah at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice for the reason for branch transfers (branchtransfers.reason) to be a configurable column on returns.pl, so libraries know which checkins may need more attention in the case of a dismissed modal or receipt printing issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 23:20:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 21:20:29 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 hebah at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 23:24:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 21:24:08 +0000 Subject: [Koha-bugs] [Bug 34547] Add transfer reason to returns.pl table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34547 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 23:24:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 21:24:10 +0000 Subject: [Koha-bugs] [Bug 34547] Add transfer reason to returns.pl table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34547 --- Comment #1 from Lucas Gass --- Created attachment 154470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154470&action=edit Bug 34547: Add transfer reason to checkedintable on returns.tt To test: 1. Apply patch, restart_all 2. Check some items out and prepare some reasons that would initiate a branchtransfer. According the schema it can be any of the following: 'Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding', 'RotatingCollection', 'Reserve', 'LostReserve', 'CancelReserve', 'TransferCancellation', 'Recall', 'RecallCancellation. 3. CHeck in some the items and notice the 'Transfer reason' column in the table. Make sure the reasons are acurate and make sense. 4. To go Table settings and find the 'checkedintable'. Make sure you can properly hide the column from the display. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 23:24:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 21:24:51 +0000 Subject: [Koha-bugs] [Bug 34547] Add transfer reason to returns.pl table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34547 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 23:31:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 21:31:53 +0000 Subject: [Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153522|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 154471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154471&action=edit Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 23:32:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 21:32:39 +0000 Subject: [Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 23:37:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 21:37:50 +0000 Subject: [Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 --- Comment #6 from Lucas Gass --- (In reply to Phil Ringnalda from comment #4) > Looks like you accidentally included something from work on another patch, > since the hunk commenting out part of > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt doesn't fit > this bug. Good catch Phil, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 23:52:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 21:52:07 +0000 Subject: [Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Aug 16 23:52:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 21:52:10 +0000 Subject: [Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Phil Ringnalda changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154471|0 |1 is obsolete| | --- Comment #7 from Phil Ringnalda --- Created attachment 154472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154472&action=edit Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. Signed-off-by: Barbara Johnson Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 01:12:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 23:12:03 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- We did have some folk struggle due to the change in permissions, although the description for "edit_borrowers" is "Add, modify and view patron information" and the patron search results does show patron information for all patrons. I'm not sure requiring "edit_borrowers" was the right way to go, but I can understand wanting to make it more restricted too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 01:18:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 23:18:28 +0000 Subject: [Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 01:18:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 23:18:31 +0000 Subject: [Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154469|0 |1 is obsolete| | --- Comment #2 from David Cook --- Created attachment 154473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154473&action=edit Bug 34545: Koha should die with an error if AutoSelfCheckID is invalid If AutoSelfCheckID is an not valid ( either by deleting the patron or by changing the patron's userid ), self-checkout will display the login screen and no error will be generated in any logs. Test Plan: 1) Apply this patch 2) Verify AutoSelfCheckID is working as expected 3) Change AutoSelfCheckID to an invalid userid 4) Restart all the things! 5) Verify visiting sco-main.pl generates an error! Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 01:20:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 23:20:17 +0000 Subject: [Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- I'm signing off on this one, since it works as described. However, I'm not sure about the approach. I think adding a warning in the logs is a very good idea, but generating an internal server error seems suboptimal. It might be better to generate a more graceful error message on the screen. That said, an ISE is probably better than what we have at the moment. Failing early and noisy would get the situation fixed ASAP I suspect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 01:34:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 23:34:54 +0000 Subject: [Koha-bugs] [Bug 34543] Content block accessibility helpers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34543 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- It's an interesting idea. I've been adding element/attribute filtering to the HTML Content blocks, so the UI for this is certainly on my mind these days... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 01:36:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Aug 2023 23:36:10 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 02:23:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 00:23:31 +0000 Subject: [Koha-bugs] [Bug 28499] Add support for no-UI / administrative plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 --- Comment #6 from David Cook --- (In reply to Tomás Cohen Arazi from comment #3) > (In reply to David Cook from comment #2) > > Would the plugin itself denote itself as non-accessible to users, or would > > it be a flag used when installing via the CLI? > > I think both use cases are valid and interesting. I was pointing more to the > first one in an initial approach, as the second one has interesting edge > cases, like users installing a new version, etc. > > What do you think it would be best? Actually, I think it would need to be a flag, because you might want to distribute a third-party plugin via a shared directory to many Koha instances and not want 1 Koha admin to be able to uninstall it for everyone... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 02:24:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 00:24:26 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154464|0 |1 is obsolete| | --- Comment #48 from David Cook --- Created attachment 154474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154474&action=edit Bug 25672: use enable_plugin_browser_upload flag to control plugin upload This patch adds a enable_plugin_browser_upload flag to koha-conf.xml, which controls whether or not Koha intranet users can upload Koha plugins via their browser. Like "enable_plugins", it defaults to 0 for new installs. This is useful when you want to provide Koha intranet users with plugins that are pre-installed by administrators (by CLI) or restricting them to plugins from a Github repo. See the following for more information: Bug 23975 - Add ability to search and install plugins from GitHub Bug 23191 - Administrators should be able to install plugins from the command line To test: 1) Apply the patch 2) Set 1 in koha-conf.xml 3) Add 0 in koha-conf.xml 4) restart_all (in koha-testing-docker) 5) Go to /cgi-bin/koha/plugins/plugins-home.pl and note that you don't see an option to upload plugins 6) Go to /cgi-bin/koha/plugins/plugins-upload.pl and note that it says "Plugin browser upload disabled!" and gives instructions on how to enable browser upload 7) Install a plugin from the CLI using koha-shell kohadev -c "/usr/share/koha/bin/devel/install_plugins.pl" 8) Note that the Uninstall option for the plugin does not appear 9) Enable Koha plugin git repos and search for "coverflow" 10) Note that you can find the plugin but you cannot install it 11) Change enable_plugin_browser_upload back to 1 and "restart_all" 12) Note that you can not upload plugins, uninstall plugins, and install plugins from Git repos Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 02:24:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 00:24:30 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154465|0 |1 is obsolete| | --- Comment #49 from David Cook --- Created attachment 154475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154475&action=edit Bug 25672: Enable enable_plugin_browser_upload by default This patch enables enable_plugin_browser_upload by default, since the current behaviour for Koha is to enable browser upload when enable_plugins is 1. Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 02:24:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 00:24:34 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154466|0 |1 is obsolete| | --- Comment #50 from David Cook --- Created attachment 154476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154476&action=edit Bug 25672: (QA follow-up) Hide install after search button If plugin upload is disabled, but there are git repositories listed in the config for plugin searching, then you can search for a plugin and attempt to install it. The install leads to an error page. This patch removes the actions column and install button should the enable_browser_upload option be disabled Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 02:24:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 00:24:38 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154467|0 |1 is obsolete| | --- Comment #51 from David Cook --- Created attachment 154477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154477&action=edit Bug 25672: Prevent uninstall when plugin browser upload disabled When plugin browser upload is disabled, also prevent plugin browser uninstall. Signed-off-by: Kyle M Hall Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 02:24:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 00:24:42 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154468|0 |1 is obsolete| | --- Comment #52 from David Cook --- Created attachment 154478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154478&action=edit Bug 25672: Convert to restricting to listed repositories only I think instead of a plain on/off switch we should use it in combination with the plugin_repo's and set it to restrict to only those repos' (i.e. disable uploads entirely if no repo's are listed, or just allow those repo's when there are). This patch achieves that, but only if plugins are installed via the plugin browser method. We disable all direct upload avenues, so install is blocked for other cases. Signed-off-by: Kyle M Hall Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 02:26:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 00:26:52 +0000 Subject: [Koha-bugs] [Bug 25370] Create allowlist of plugins allowed to be installed by Web UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25370 --- Comment #5 from David Cook --- Going forward I'll probably just rely on bug 25672 so I doubt I'll work on this... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 02:27:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 00:27:57 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #53 from David Cook --- Adding my SO and leaving "Signed Off" since I wrote some of these patches. Kyle, should we consider your SO as QA, or do you want to have another look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 02:30:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 00:30:31 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #54 from David Cook --- I would still like a way to prevent "Uninstall" as well for plugins installed via the CLI, but I think that can be its own thing. I'm also less worried about people uninstalling plugins than installing problematic plugins. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 02:40:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 00:40:33 +0000 Subject: [Koha-bugs] [Bug 28499] Add support for no-UI / administrative plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 --- Comment #7 from David Cook --- (In reply to David Cook from comment #6) > Actually, I think it would need to be a flag, because you might want to > distribute a third-party plugin via a shared directory to many Koha > instances and not want 1 Koha admin to be able to uninstall it for > everyone... But the problem with the flag is that often plugins are installed from the CLI like this: koha-shell kohadev -c "/usr/share/koha/bin/devel/install_plugins.pl" So there would need to be some other way of preventing uninstall... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 02:55:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 00:55:17 +0000 Subject: [Koha-bugs] [Bug 34548] New: Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34548 Bug ID: 34548 Summary: Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: mjnkml at gmail.com QA Contact: testopia at bugs.koha-community.org Changes in: /usr/share/koha/intranet/cgi-bin/installer/data/mysql/db_revs/230501003.pl to convert publishercode to text on both tables resulted in an upgrade error. Manually deleted the indexes from the tables allowed the [Try again] to proceed without incident. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 02:56:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 00:56:46 +0000 Subject: [Koha-bugs] [Bug 34548] Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34548 --- Comment #1 from mjnkml at gmail.com --- The error was something like: "column 'publishercode' used in key specification without a key length" Sorry I don't have the full output. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 02:57:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 00:57:29 +0000 Subject: [Koha-bugs] [Bug 34548] Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34548 --- Comment #2 from mjnkml at gmail.com --- Actions I took: DROP INDEX `publishercode` ON `koha_instance`.`biblioitems` DROP INDEX `publishercode` ON `koha_instance`.`deletedbiblioitems` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 03:08:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 01:08:02 +0000 Subject: [Koha-bugs] [Bug 34548] Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34548 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au, | |katrin.fischer at bsz-bw.de, | |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 03:18:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 01:18:17 +0000 Subject: [Koha-bugs] [Bug 34548] Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34548 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34029 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34029 [Bug 34029] Import breaks when data exceeds size of mapped database columns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 03:18:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 01:18:17 +0000 Subject: [Koha-bugs] [Bug 34029] Import breaks when data exceeds size of mapped database columns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34029 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34548 [Bug 34548] Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 04:11:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 02:11:13 +0000 Subject: [Koha-bugs] [Bug 25023] Claims returned dates not formatted according to dateformat preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 --- Comment #7 from Victor Grousset/tuxayo --- Oh okay :o No problem then. Crazy that it's identical and relies on position for which one to do what. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 05:24:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 03:24:46 +0000 Subject: [Koha-bugs] [Bug 34549] New: The cataloguing editor allows you to input invalid data Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 Bug ID: 34549 Summary: The cataloguing editor allows you to input invalid data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl I had a library using UTF-8 encoding instead of MARC-8 encoding, and they were able to import records into the cataloguing editor and save them into Koha. Then when they tried to view, edit, or delete the records, Koha would throw fatal errors. You can duplicate this by copying and pasting the following character into your cataloguing editor in say the 245$a field: -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 05:28:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 03:28:34 +0000 Subject: [Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 --- Comment #1 from David Cook --- Ok Bugzilla won't print that non-printable character so that's going to make this harder. I'll look at adding a text attachment where you can just copy the text and paste it into Koha to get it to break. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 05:35:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 03:35:19 +0000 Subject: [Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 --- Comment #2 from David Cook --- Created attachment 154479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154479&action=edit Text file containing control characters On Windows, open this file with Notepad or Notepad++. I haven't tried other OSes but use a graphical text editor. Copying and pasting this into a MARC record via the cataloguing editor will generate this kind of warning: "PCDATA invalid Char value 27" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 05:39:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 03:39:17 +0000 Subject: [Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 --- Comment #3 from David Cook --- Actually, it looks like you can just go straight to https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154479 and copy the text from there in the web browser and that will break your MARC record via the cataloguing editor. Click "Save and view record" for the most obvious results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 05:41:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 03:41:36 +0000 Subject: [Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34014 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 05:41:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 03:41:36 +0000 Subject: [Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34549 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 06:33:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 04:33:10 +0000 Subject: [Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 06:33:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 04:33:13 +0000 Subject: [Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 --- Comment #4 from David Cook --- Created attachment 154480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154480&action=edit Bug 34549: Strip non-XML chars during TransformHtmlToMarc This patch strips non-XML characters from inputs during TransformHtmlToMarc. To test: 0. Apply patch 1. koha-plack --restart kohadev 2. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl 3. Fill out record and use the text from "Text file containing control characters" as the title 4. Click Save 5. Note that your record displays without any warnings like the following: Error: invalid data, cannot decode metadata object parser error : PCDATA invalid Char value 27 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 06:36:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 04:36:02 +0000 Subject: [Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #14 from David Cook --- Hmm after reviewing this one again... perhaps a combination of this and bug 34549 make sense... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 06:40:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 04:40:45 +0000 Subject: [Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #15 from David Cook --- Bug 34549 came about because I had a library that was able to import and save MARC data which couldn't be parsed as MARCXML. We could warn or fail earlier. In their case, they had the encoding wrong on their Z39.50 server config. As soon as I fixed that, the problem went away. So perhaps we should put more thought into treating the root cause and not just the symptom... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 06:43:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 04:43:32 +0000 Subject: [Koha-bugs] [Bug 34551] New: Don't allow Z39.50 import if MARC can't be converted to MARCXML Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34551 Bug ID: 34551 Summary: Don't allow Z39.50 import if MARC can't be converted to MARCXML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl As I note on bug 34014 and bug 34549, if you've got the wrong encoding on your Z39.50 server, you can wind up importing MARC data that contains invalid data (like control characters). During copy cataloguing, there should be a warning that there's a problem with the data (possibly because of Z39.50 server config). That way we have librarians raising the flag that there's a problem before the data is in Koha rather than us doing cleanup after it's been imported. (Of course, bulk loaded MARC will still be a problem, but baby steps...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 06:43:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 04:43:42 +0000 Subject: [Koha-bugs] [Bug 34551] Don't allow Z39.50 import if MARC can't be converted to MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34551 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34014, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34549 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 06:43:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 04:43:42 +0000 Subject: [Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34551 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 06:43:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 04:43:42 +0000 Subject: [Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34551 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 06:44:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 04:44:36 +0000 Subject: [Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 --- Comment #5 from David Cook --- Note that there's no warnings anywhere that any stripping occurred. We probably should log to file and show something on the screen for users... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 06:53:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 04:53:55 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #66 from Victor Grousset/tuxayo --- Created attachment 154481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154481&action=edit Bug 28267: [22.05] Add warnings for database row formats This patch adds a warning on about.pl regarding database row formats other than "DYNAMIC". It points to the Koha community wiki for more information on how to resolve the problem. This patch also stops the installer if there are any database tables with a row format other than "DYNAMIC". It points to the Koha community wiki for more information on how to resolve the problem. Test plan: 0a. Apply the patch 0b. koha-plack --restart kohadev 1a. koha-mysql kohadev 1b. ALTER TABLE tags ROW_FORMAT=COMPACT; 2. Go to http://localhost:8081/cgi-bin/koha/about.pl 3. Note that there is a warning about database row formats 4a. koha-mysql kohadev 4b. ALTER TABLE tags ROW_FORMAT=DYNAMIC; 5. Go to http://localhost:8081/cgi-bin/koha/about.pl 6. Note that there is no warning about database row formats 7a. Manually change the version in Koha.pm to a higher version 7b. koha-plack --restart kohadev 8a. koha-mysql kohadev 8b. ALTER TABLE tags ROW_FORMAT=COMPACT; 9. Go to http://localhost:8081/ 10. Log into the web installer and click through until you reach a warning telling you that you have database row formats other than 'DYNAMIC' 11. Note that you can't progress with the installer until this problem is resolved 12a. koha-mysql kohadev 12b. ALTER TABLE tags ROW_FORMAT=DYNAMIC; 13. Refresh the page or redo the web installer process 14. Note that you're no longer blocked from running the installer due to database row format 15. Undo your change to Koha.pm 16. Profit Note: Due to bug 32665 you'll see an unrelated warning on step 3 Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi (cherry picked from commit b76fb9cf466dd4cc4eb4d382c4bfb9fa78a1fce6) Rebased-by: Victor Grousset/tuxayo Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 06:54:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 04:54:01 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #67 from Victor Grousset/tuxayo --- Created attachment 154482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154482&action=edit Bug 28267: [22.05] Simplify things We don't need: * a separate Koha::Installer module when we already have C4::Installer * the tests as they are actually modifying the DB structure without rolling back * An unecessary complicated subroutine, just make is simple WNC amended patch: Remove change to Koha.pm Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi (cherry picked from commit f394bf61cf7e60058afd9856f7ae8dda8afb385b) Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 06:54:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 04:54:54 +0000 Subject: [Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #68 from Victor Grousset/tuxayo --- (In reply to Lucas Gass from comment #64) > Merge conflicts with 22.05.x, please rebase. Here is a rebase :) Test plan done to check that it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 08:17:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 06:17:07 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 08:39:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 06:39:01 +0000 Subject: [Koha-bugs] [Bug 34552] New: Statistics wizards : Cash register Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 Bug ID: 34552 Summary: Statistics wizards : Cash register Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: azmikhalib at utm.my QA Contact: testopia at bugs.koha-community.org There are no results when filtering "All payments to the library" or "payment", but other transaction types can filter and show results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 08:46:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 06:46:14 +0000 Subject: [Koha-bugs] [Bug 34043] Improve translation of CSV header templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34043 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 08:46:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 06:46:16 +0000 Subject: [Koha-bugs] [Bug 34043] Improve translation of CSV header templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34043 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152558|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose --- Created attachment 154483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154483&action=edit Bug 34043: Improve translation of CSV header templates This patch reformats serverl CSV header templates so that it's easier to translate the English strings. The templates now use the [% t(" ") %] construction to ensure that each string is managed separately. To test, apply the patch and go to Acquisitions. - Locate a vendor with a basket and view the basket. - Click the "Export as CSV" button. The CSV file you get should be well-formatted. - Go to basket groups for that vendor and click the "Closed" tab. - Click the "Export as CSV" button for one of the baskets. The CSV file should be correct. - Go to Acquisitions -> Late orders. - Check some checkboxes in the list of late orders. Click "Export as CSV" at the bottom of the page. The CSV file should be correct. - Go to the catalog's item search page. - Perform a search which will return results. On the result page, choose "Export all results to -> CSV" and check the resulting CSV file. - Go to Reports -> Statistics Wizards -> Cash register - Select "To a file" under "Output" and submit. Check the resulting CSV file. - Go to Reports -> Orders by funds. - Choose "To a file" under "Output" and submit. Check the resulting CSV file. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 08:46:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 06:46:58 +0000 Subject: [Koha-bugs] [Bug 34043] Improve translation of CSV header templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34043 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose --- I translated in fr-CA and it worked for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 08:57:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 06:57:16 +0000 Subject: [Koha-bugs] [Bug 34553] New: Update send list and send cart popup footers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34553 Bug ID: 34553 Summary: Update send list and send cart popup footers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 34343 Like Bug 34343, I would like to add a fixed footer to the "send list" and "send cart" popups in the staff interface, making them consistent with Z39.50 and quick spine label (Bug 34453) popups. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 [Bug 34343] Z39.50 search background not updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 08:57:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 06:57:16 +0000 Subject: [Koha-bugs] [Bug 34343] Z39.50 search background not updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34553 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34553 [Bug 34553] Update send list and send cart popup footers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:19:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:19:35 +0000 Subject: [Koha-bugs] [Bug 34554] New: Item status In Transit doesn't update after Check In Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34554 Bug ID: 34554 Summary: Item status In Transit doesn't update after Check In Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: azmikhalib at utm.my QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Item status in the staff interface does not change from "In Transit " to "Available" but in OPAC status follows changes according to the setting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:22:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:22:46 +0000 Subject: [Koha-bugs] [Bug 29074] DefaultHoldExpirationdatePeriod blank value interpreted as zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29074 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144572|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes --- Created attachment 154484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154484&action=edit Bug 29074: Do not set default expiration date for hold if DefaultHoldExpirationdatePeriod is left blank If DefaultHoldExpirationdate is on and DefaultHoldExpirationdatePeriod is blank, the blank is treated as a zero and all holds are created with an expiration date of today. This patch changes expiration dates storing so that if DefaultHoldExpirationdatePeriod is left blank, expiration date is not set. Users are informed about this with a note in syspref. To test: 1. Set DefaultHoldExpirationdate on but leave DefaultHoldExpirationdatePeriod blank. 2. Add hold for patron. => Note that expiration date is set as today. 3. Apply this patch => Confirm following note is now added after sysprefs: "NOTE: If DefaultHoldExpirationdatePeriod is left blank default expiration date is not set." 4. Add new hold for patron. => Note that expiration date is not set. Also prove t/db_dependent/Hold.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: stina -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:23:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:23:40 +0000 Subject: [Koha-bugs] [Bug 29074] DefaultHoldExpirationdatePeriod blank value interpreted as zero In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29074 Stina Hallin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |stina.hallin at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:30:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:30:14 +0000 Subject: [Koha-bugs] [Bug 34555] New: Add regression test for 'insufficient contrast' accessibility failures Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34555 Bug ID: 34555 Summary: Add regression test for 'insufficient contrast' accessibility failures Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Blocks: 23003 Can we somehow add a test to the QA script for checking changes to CSS and templates that may introduce insufficient contrast accessibility issues? Perhaps this needs to be done at the CI level at worst case so we are aware of and can fix issues after the fact quickly before they hit production systems. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:30:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:30:14 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34555 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34555 [Bug 34555] Add regression test for 'insufficient contrast' accessibility failures -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:32:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:32:37 +0000 Subject: [Koha-bugs] [Bug 34556] New: Add a template 'Accessibility statement' page to the default data Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34556 Bug ID: 34556 Summary: Add a template 'Accessibility statement' page to the default data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Blocks: 23003 We should add a template 'accessibility statement' using the pages feature of Koha and add it optionally to the installer default data. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:32:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:32:37 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34556 [Bug 34556] Add a template 'Accessibility statement' page to the default data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:52:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:52:17 +0000 Subject: [Koha-bugs] [Bug 34266] Item type should not default to biblio itemtype if it's not a valid itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34266 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153390|0 |1 is obsolete| | --- Comment #13 from Biblibre Sandboxes --- Created attachment 154485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154485&action=edit Bug 34266: Default to biblioitems.itemtype only if it's a valid itemtype biblioitems.itemtype can contain values that are not itemtypes (for instance if the MARC field mapped to it uses another authorised value category) This patch checks that before using it as a default value for the 'itemtypes' item subfield. Test plan: 0. Do not apply the patch yet 1. Change your MARC framework so that the field linked to biblioitems.itemtype uses an authorised value category different from 'itemtypes' 2. Make sure that you have an item subfield linked to the authorised value 'itemtypes' in your MARC framework 3. Create a biblio with an itemtype (using a value that is NOT an item type, but a value from the authorised value category you selected in step 1) 4. Create a new item for this biblio. Notice that the biblio itemtype is automatically selected for the 'itemtypes' subfield 5. Apply the patch 6. Create a new item for the same biblio. Now the 'itemtypes' subfield should be empty. 7. Revert the change at step 1 so that your biblioitems.itemtype MARC field uses the 'itemtypes' AV category 8. Modify your biblio to use a valid item type. 9. Create a new item. The biblio itemtype should be used as a default value Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:52:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:52:19 +0000 Subject: [Koha-bugs] [Bug 34266] Item type should not default to biblio itemtype if it's not a valid itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34266 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153393|0 |1 is obsolete| | --- Comment #14 from Biblibre Sandboxes --- Created attachment 154486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154486&action=edit Bug 34266: Add unit tests Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:54:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:54:01 +0000 Subject: [Koha-bugs] [Bug 34506] After deleting record from a search result the link 'Go back to the results' has disappeared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34506 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- We tested this in a sandbox today and in the last step the link remained "Return to the record" and would lead to "The record you requested does not exist (262)" as is to be expected. The link didn't change to "Return to results" as the test plan said. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:54:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:54:11 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Thomas Klausner changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |domm at plix.at -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:54:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:54:12 +0000 Subject: [Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |emmi.takkinen at koha-suomi.fi --- Comment #21 from Emmi Takkinen --- I'm getting this error when trying to apply the patches: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33260: Add view_generated_notices user permission Applying: Bug 33260: Add NoticesManagement system preference Applying: Bug 33260: Add a patron getter method to Koha::Notice::Message Applying: Bug 33260: Add Notice management tool Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt M koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt A koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js Falling back to patching base and 3-way merge... CONFLICT (modify/delete): koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js deleted in HEAD and modified in Bug 33260: Add Notice management tool. Version Bug 33260: Add Notice management tool of koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js left in tree. Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 33260: Add Notice management tool hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-33260-Add-Notice-management-tool-wp4ViP.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:55:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:55:39 +0000 Subject: [Koha-bugs] [Bug 34266] Item type should not default to biblio itemtype if it's not a valid itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34266 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154485|0 |1 is obsolete| | --- Comment #15 from Biblibre Sandboxes --- Created attachment 154487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154487&action=edit Bug 34266: Default to biblioitems.itemtype only if it's a valid itemtype biblioitems.itemtype can contain values that are not itemtypes (for instance if the MARC field mapped to it uses another authorised value category) This patch checks that before using it as a default value for the 'itemtypes' item subfield. Test plan: 0. Do not apply the patch yet 1. Change your MARC framework so that the field linked to biblioitems.itemtype uses an authorised value category different from 'itemtypes' 2. Make sure that you have an item subfield linked to the authorised value 'itemtypes' in your MARC framework 3. Create a biblio with an itemtype (using a value that is NOT an item type, but a value from the authorised value category you selected in step 1) 4. Create a new item for this biblio. Notice that the biblio itemtype is automatically selected for the 'itemtypes' subfield 5. Apply the patch 6. Create a new item for the same biblio. Now the 'itemtypes' subfield should be empty. 7. Revert the change at step 1 so that your biblioitems.itemtype MARC field uses the 'itemtypes' AV category 8. Modify your biblio to use a valid item type. 9. Create a new item. The biblio itemtype should be used as a default value Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:55:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:55:41 +0000 Subject: [Koha-bugs] [Bug 34266] Item type should not default to biblio itemtype if it's not a valid itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34266 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154486|0 |1 is obsolete| | --- Comment #16 from Biblibre Sandboxes --- Created attachment 154488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154488&action=edit Bug 34266: Add unit tests Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 09:55:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 07:55:48 +0000 Subject: [Koha-bugs] [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Johanna Miettunen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.miettunen at haaga-hel | |ia.fi --- Comment #5 from Johanna Miettunen --- Can you please give instructions how to test this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:02:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:02:09 +0000 Subject: [Koha-bugs] [Bug 34266] Item type should not default to biblio itemtype if it's not a valid itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34266 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154487|0 |1 is obsolete| | --- Comment #17 from Biblibre Sandboxes --- Created attachment 154489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154489&action=edit Bug 34266: Default to biblioitems.itemtype only if it's a valid itemtype biblioitems.itemtype can contain values that are not itemtypes (for instance if the MARC field mapped to it uses another authorised value category) This patch checks that before using it as a default value for the 'itemtypes' item subfield. Test plan: 0. Do not apply the patch yet 1. Change your MARC framework so that the field linked to biblioitems.itemtype uses an authorised value category different from 'itemtypes' 2. Make sure that you have an item subfield linked to the authorised value 'itemtypes' in your MARC framework 3. Create a biblio with an itemtype (using a value that is NOT an item type, but a value from the authorised value category you selected in step 1) 4. Create a new item for this biblio. Notice that the biblio itemtype is automatically selected for the 'itemtypes' subfield 5. Apply the patch 6. Create a new item for the same biblio. Now the 'itemtypes' subfield should be empty. 7. Revert the change at step 1 so that your biblioitems.itemtype MARC field uses the 'itemtypes' AV category 8. Modify your biblio to use a valid item type. 9. Create a new item. The biblio itemtype should be used as a default value Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:02:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:02:12 +0000 Subject: [Koha-bugs] [Bug 34266] Item type should not default to biblio itemtype if it's not a valid itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34266 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154488|0 |1 is obsolete| | --- Comment #18 from Biblibre Sandboxes --- Created attachment 154490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154490&action=edit Bug 34266: Add unit tests Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:04:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:04:23 +0000 Subject: [Koha-bugs] [Bug 34266] Item type should not default to biblio itemtype if it's not a valid itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34266 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154489|0 |1 is obsolete| | --- Comment #19 from Biblibre Sandboxes --- Created attachment 154491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154491&action=edit Bug 34266: Default to biblioitems.itemtype only if it's a valid itemtype biblioitems.itemtype can contain values that are not itemtypes (for instance if the MARC field mapped to it uses another authorised value category) This patch checks that before using it as a default value for the 'itemtypes' item subfield. Test plan: 0. Do not apply the patch yet 1. Change your MARC framework so that the field linked to biblioitems.itemtype uses an authorised value category different from 'itemtypes' 2. Make sure that you have an item subfield linked to the authorised value 'itemtypes' in your MARC framework 3. Create a biblio with an itemtype (using a value that is NOT an item type, but a value from the authorised value category you selected in step 1) 4. Create a new item for this biblio. Notice that the biblio itemtype is automatically selected for the 'itemtypes' subfield 5. Apply the patch 6. Create a new item for the same biblio. Now the 'itemtypes' subfield should be empty. 7. Revert the change at step 1 so that your biblioitems.itemtype MARC field uses the 'itemtypes' AV category 8. Modify your biblio to use a valid item type. 9. Create a new item. The biblio itemtype should be used as a default value Signed-off-by: joubu Signed-off-by: tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:04:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:04:26 +0000 Subject: [Koha-bugs] [Bug 34266] Item type should not default to biblio itemtype if it's not a valid itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34266 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154490|0 |1 is obsolete| | --- Comment #20 from Biblibre Sandboxes --- Created attachment 154492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154492&action=edit Bug 34266: Add unit tests Signed-off-by: joubu Signed-off-by: tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:04:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:04:26 +0000 Subject: [Koha-bugs] [Bug 31415] Script to automate converting holds to recalls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31415 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:06:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:06:16 +0000 Subject: [Koha-bugs] [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 --- Comment #6 from Owen Leonard --- (In reply to Johanna Miettunen from comment #5) > Can you please give instructions how to test this. I think this browser extension is a good option: https://addons.mozilla.org/en-US/firefox/addon/wave-accessibility-tool/ (Firefox version) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:08:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:08:49 +0000 Subject: [Koha-bugs] [Bug 34522] Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 --- Comment #3 from Katrin Fischer --- Testing this one right now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:08:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:08:50 +0000 Subject: [Koha-bugs] [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:08:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:08:54 +0000 Subject: [Koha-bugs] [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151618|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 154493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154493&action=edit Bug 33810: Opac advanced search fields need aria-labels The OPAC advanced search fields need aria-labels to assist with screen reading. This patch adds labels to both the dropdown selects and the text inputs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:09:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:09:05 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154146|0 |1 is obsolete| | --- Comment #26 from Biblibre Sandboxes --- Created attachment 154494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154494&action=edit Bug 29578: Upgrade the jQuery highlighter plugin Under certain conditions, the jQuery term highlighter can break and in the process make the "Highlight" / "Unhighlight" button disappear altogether. This affects catalog searches in both the OPAC and the Staff Client, with UNIMARC-based instances affected the most as the "Highlight" / "Unhighlight" button disappears if you perform a specific OPAC search (see Test plan below). This patch fixes that by upgrading the highlighter plugin to its latest version for both the OPAC and the Staff interface. Then, the changes from commit 2e4b574074 (Bug 5844) are applied to the plugin code. Also, Koha uses "term" instead of "highlight" as the class name for the highlighting elements, so the plugin code is modified for that aspect, too. Finally, the plugin file is renamed to reflect the version change (v3 -> v5) and all references to the old filename in the Template files are updated. Test plan: 0) In a UNIMARC instance, catalogue two books using the titles given below (Title subfield = 200$a): Book 1: Συλλογής των εν επιτομή τοῖς πάλαι γεωγραφηθέντων Book 2: Επιτομή της ιστορίας των Βαλκανικών Πολέμων (1912-1913) 1) OpacHighlightedWords and StaffHighlightedWords should both be set to "Highlight". 2) Search the OPAC for "επιτομή των" (without the quotes). In the results page, notice that: a) You get an Uncaught DOMException error in the web browswer's JavaScript Console (press F12): "Failed to execute 'splitText' on 'Text': The offset 3 is larger than the Text node's length." b) the "Highlight" / "Unhighlight" button vanishes c) some search terms matches are not highlighted (for example "των" in the 2nd Book) 3) Repeat the same search in the Staff interface. In the results page, notice that: a) You get an Uncaught DOMException error in the web browswer's JavaScript Console (press F12): "Failed to execute 'splitText' on 'Text': The offset 3 is larger than the Text node's length." b) Even though some terms are highlighted, the button still says "Highlight" c) some search terms matches are not highlighted (for example "των" in the 2nd Book) 4) Apply this patch. 5) Repeat the searches (you may have to press CTRL-F5 to reload the JavaScript code). This time the "Highlight" / "Unhighlight" button is displayed in the OPAC, and all your search terms should be highlighted in yellow. Toggling the highlight should cause no problems, and there shouldn't be any errors logged in your browser's Console. Signed-off-by: Christian Nelson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:09:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:09:52 +0000 Subject: [Koha-bugs] [Bug 34557] New: Add option to prevent loading a patron's checkouts on the SCO Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557 Bug ID: 34557 Summary: Add option to prevent loading a patron's checkouts on the SCO Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some libraries do not wish to load a patron's checkouts by default on the SCO as the machines can be in highly visible locations and may compromise patron privacy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:14:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:14:07 +0000 Subject: [Koha-bugs] [Bug 34553] Update send list and send cart popup footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34553 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:14:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:14:11 +0000 Subject: [Koha-bugs] [Bug 34553] Update send list and send cart popup footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34553 --- Comment #1 from Owen Leonard --- Created attachment 154495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154495&action=edit Bug 34553: Update send list and send cart popup footers This patch updates the templates behind the "send cart" and "send list" pop-ups in order to make the style of the footer consistent with some recently-updated similar examples, like the catalog's Z39.50 search popup. The patch also makes a minor change to our global JavaScript include so we can get away from using the "close" class as a trigger for closing a pop-up window. Bootstrap has a built-in "close" class that we always have to override. "close_window" is added as another class to use, and the other instances can be cleaned up overy time. To test, apply the patch and perform a catalog search in the staff interface. - Add one or more items to the cart. - Open the cart popup and click the "Send" button. - In the pop-up window, confirm that the footer looks correct. - Test the process of using the tab key between input fields and submit/cancel buttons. All controls should be accessible. - Test the "Cancel" button to confirm that it closes the window. - Reopen the window and test sending the email. - On the confirmation page, confirm that the footer looks correct and that the "Close window" button works. - Test the same processes in the Lists module: View a list in the staff interface and test the process of sending a list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:19:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:19:36 +0000 Subject: [Koha-bugs] [Bug 34522] Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154393|0 |1 is obsolete| | --- Comment #4 from Biblibre Sandboxes --- Created attachment 154496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154496&action=edit Bug 34522: Pass the suggestion branchcode, not the suggeter branchcode To test: 1. Turn on OPACViewOthersSuggestions 2. Log into OPAC as patron of Branch A 3. Make purchase suggestion for Branch B 4. Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to have been made for Branch A 5. View suggestion from staff client - See that it accurately reflects suggestion having been made for Branch B 6. Apply patch and try steps 2 - 5 again, this time you should see the proper branch. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:20:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:20:27 +0000 Subject: [Koha-bugs] [Bug 34522] Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:23:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:23:55 +0000 Subject: [Koha-bugs] [Bug 34129] Responsive table button icon broken after FontAwesome upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34129 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153063|0 |1 is obsolete| | --- Comment #8 from Caroline Cyr La Rose --- Created attachment 154497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154497&action=edit Bug 34129: Fix plus and minus icon This patch fixes the plus and minus on the buttons to expand the columns in mobile or zoomed in view. To test: 1. Apply the patch 2. Rebuild css (yarn build) 3. Go to the OPAC and search for a record with an item 4. Zoom in to 400% or change view to mobile --> The items table should have a plus (+) button in the last column to expand and have the rest of the information Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:24:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:24:23 +0000 Subject: [Koha-bugs] [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154493|0 |1 is obsolete| | --- Comment #8 from Biblibre Sandboxes --- Created attachment 154498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154498&action=edit Bug 33810: Opac advanced search fields need aria-labels The OPAC advanced search fields need aria-labels to assist with screen reading. This patch adds labels to both the dropdown selects and the text inputs Signed-off-by: joubu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:24:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:24:58 +0000 Subject: [Koha-bugs] [Bug 33810] Accessibility: OPAC Advanced Search fields are not labelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33810 delaye changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |stephane.delaye at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:25:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:25:04 +0000 Subject: [Koha-bugs] [Bug 34129] Responsive table button icon broken after FontAwesome upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34129 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Status|NEW |Needs Signoff --- Comment #9 from Caroline Cyr La Rose --- It wasn't at need signoff, but I tried and it works well. Also added a test plan. Thanks Jonathan! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:25:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:25:12 +0000 Subject: [Koha-bugs] [Bug 34129] Responsive table button icon broken after FontAwesome upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34129 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:26:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:26:31 +0000 Subject: [Koha-bugs] [Bug 34266] Item type should not default to biblio itemtype if it's not a valid itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34266 delaye changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye at biblibre.co | |m Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:26:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:26:40 +0000 Subject: [Koha-bugs] [Bug 34458] It should be possible to change the pickup location for in transit holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34458 --- Comment #3 from Sally --- (In reply to Emily Lamancusa from comment #1) > I see a couple of folks from libraries following this bug - any of you want > to weigh in? :) Yes, I agree with the points here: - The staff need the feature; anything the patrons can do, the staff should be able to do - As in the OPAC feature, a syspref to choose which statuses permit pickup location changes should exist - The staff should also be able to modify the pickup location using the Holds tab in the patron account (when a record has 100+ holds on it, it's too easy to accidentally modify the wrong hold) For reporting: - I'd like to see the change recorded in the action logs - I think this should be the same for both this staff feature and the OPAC feature Suspend/resume are already recorded in the action logs, including when a patron performs the action - and we use this data when reporting on how long it takes us to fill holds. Changing location whilst in transit will impact fill times, so it would be important for us to be able to see how much the feature was being used and how much of an impact it was having. Having the change in action logs would also mean we could run reports where intervention is needed. For example, if an item is in transit to a library with few collections (i.e. high cost on the Transport Cost Matrix), we might decide that we'd be better reverting the in transit status and selecting an alternative copy, instead of waiting for the original copy to arrive at the original location and be sent onwards. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:30:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:30:56 +0000 Subject: [Koha-bugs] [Bug 34555] Add regression test for 'insufficient contrast' accessibility failures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34555 --- Comment #1 from Owen Leonard --- I think this kind of check could be built into the SCSS -> CSS build process -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:38:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:38:54 +0000 Subject: [Koha-bugs] [Bug 24718] Introduce hour-based holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi Status|Needs Signoff |Patch doesn't apply --- Comment #65 from Emmi Takkinen --- There is a minor merge conflict in t/db_dependent/Holds.t while trying to apply patch "Bug 24718: Hour based holds on staff client". I was able to resolve this, but Koha now dies on Internal Server Error. Looking from locks there are these lines: Global symbol "$expdate" requires explicit package name (did you forget to declare "my $expdate"?) at ../Koha/C4/Reserves.pm line 216." (and several others) Type of arg 1 to List::MoreUtils::XS::any must be block or sub {} (not reference constructor) at ../Koha/C4/Reserves.pm line 1848, near "$ignore_borrowers ;" Setting this status as "Patch doesn't apply". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:39:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:39:33 +0000 Subject: [Koha-bugs] [Bug 34095] Shipping cost should default to a blank box instead of 0.00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34095 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154377|0 |1 is obsolete| | --- Comment #2 from Biblibre Sandboxes --- Created attachment 154499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154499&action=edit Bug 34095: Adjust logic so that shipment cost is empty if the receiving shipment cost is blank. Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:39:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:39:36 +0000 Subject: [Koha-bugs] [Bug 33819] Accessibility: More description required in opac search breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33819 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:39:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:39:39 +0000 Subject: [Koha-bugs] [Bug 33819] Accessibility: More description required in opac search breadcrumbs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33819 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151693|0 |1 is obsolete| | --- Comment #5 from Matt Blenkinsop --- Created attachment 154500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154500&action=edit Bug 33819: Add page numbers to opac results breadcrumb This patch adds the page number to the breadcrumb in the opac search results to ensure that it is unique to the content on the page. Currently it is not compliant to Accessibility guidelines as the breadcrumb is identical on every page despite the content being different. To test: 1) Apply patch 2) Run a search in the OPAC that will return more than 20 results. 3) The breadcrumb should say "Results of search for 'search term', page x of y" 4) Run a search that will return less than 20 results 5) The breadcrumb should say "Results of search for 'search term' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:40:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:40:23 +0000 Subject: [Koha-bugs] [Bug 34095] Shipping cost should default to a blank box instead of 0.00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34095 Anneli Österman changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |anneli.osterman at koha-suomi. | |fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:43:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:43:16 +0000 Subject: [Koha-bugs] [Bug 34547] Add transfer reason to returns.pl table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34547 Stina Hallin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stina.hallin at ub.lu.se --- Comment #2 from Stina Hallin --- Tried to apply the patch in a Bywater sandbox and got this error: Error getting login cookie from browser: Cannot find default Firefox profile Configured browser: firefox3 (change with 'git config --global bz.browser ') Possible browsers: chromium, epiphany, firefox3, galeon, google-chrome I tried using both Forefox and Chrome and got the same error. Tried the bug anyway but could not see the changes in the table or in the settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:44:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:44:51 +0000 Subject: [Koha-bugs] [Bug 34558] New: Update custom.sql for it-IT webinstaller Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Bug ID: 34558 Summary: Update custom.sql for it-IT webinstaller Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: ztajoli at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com With new developments about transaltion, the file ../installer/data/mysql/localization/it-IT/custom.sql needs an update. Today, when you install a 23.05 version with Italian setup (it-IT), you will see a warning about problems with Authorised values (AV). We need to fix it and update the file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:45:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:45:48 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |ztajoli at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:46:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:46:09 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ztajoli at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:46:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:46:29 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gmcharlt at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:48:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:48:42 +0000 Subject: [Koha-bugs] [Bug 34514] opac-showmarc.pl does not handle UNIMARC well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer --- We tested in in a Sandbox and it worked without applying the Patches. We didnt see any encoding errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:50:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:50:18 +0000 Subject: [Koha-bugs] [Bug 34514] opac-showmarc.pl does not handle UNIMARC well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 --- Comment #4 from Katrin Fischer --- (In reply to Katrin Fischer from comment #3) > We tested in in a Sandbox and it worked without applying the Patches. We > didnt see any encoding errors. This was tested by Pascal Uphaus (just wrong bugzilla login :) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:54:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:54:22 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid at lmscloud.de --- Comment #17 from Paul Derscheid --- Any suggestions on the pref name? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:55:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:55:47 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #2 from Kelly McElligott --- Testing Plan 1. Ensure that there is a new column in the circulation and rule matrix for "No Automatic Renewal Before" 2. To test this process, a few rules will need to be tested to ensure that staff/patrons have the option to renew - even if the item is set to auto-renewal. 3. Use values such as No renewal before= 2 and No Auto Renewal = 3 4. Ensure that the patron can renew the item that is set to Auto Renew if they are within the date range of renewability (set up by the No Renew/No Auto Renew column values). If the item is too early to renew, ensure that it gives a date and also states that this item is set to automatically renew. 5. Try values such as No Renewal before =2 and No Auto Renewal =1, Ensure that the patron can renew the item that is set to Auto Renew if they are within the date range of renewability (set up by the No Renew/No Auto Renew column values). If the item is too early to renew, ensure that it gives a date and also states that this item is set to automatically renew. 6 Now go to the SCO and make sure the patron can renew items that are eligible to renew and if not, make sure patrons can see that they are scheduled to auto-renew. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:58:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:58:59 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148597|0 |1 is obsolete| | --- Comment #30 from Emmi Takkinen --- Created attachment 154501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154501&action=edit Bug 26597: Transfer informations from guarantor when adding a guarantor to an existing patron When creating a new guarantee from the guarantor, the preference PrefillGuaranteeField dictates some fields to be transfered from guarantor to guarantee. This patch makes it so those informations are also transfered when adding a new guarantor relationship to an existing patron. To test: 1) Apply patch 2) Search PrefillGuaranteeField preference and make sure some fields are selected 3) Select a user that can have a guarantor 4) In the edit form, click on 'Search to add' in 'Patron guarantor' fieldset 5) Choose a patron who has at least one of the fields in 1) set 6) Click 'Select' 7) Confirm guarantee's information is filled from the guarantor's record 8) Check that any preexisting information is not overwritten Signed-off-by: Sally Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:59:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:59:17 +0000 Subject: [Koha-bugs] [Bug 27943] MARC21 authorities not support 7XX on display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27943 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146945|0 |1 is obsolete| | --- Comment #8 from Biblibre Sandboxes --- Created attachment 154502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154502&action=edit Bug 27943: (follow-up) Fix unit test, and use systempreference AuthoritySeparator Instead of hardcoding the separator we take the value from systempreference. Also adjust the unit test to expect the "equalterm" array. Test plan same as before. Signed-off-by: Christian Nelson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 10:59:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 08:59:29 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148598|0 |1 is obsolete| | --- Comment #31 from Emmi Takkinen --- Created attachment 154503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154503&action=edit Bug 26597: Fixing the populate of fields when using the REST API route This attachment correct the populate of fields by using the api mapping. Now All fields are populated following the selected PrefillGuaranteeField options Signed-off-by: Sally Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:00:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:00:05 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148599|0 |1 is obsolete| | --- Comment #32 from Emmi Takkinen --- Created attachment 154504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154504&action=edit Bug 26597: (follow-up) Add disabling / enabled the save button while waiting from api to respond I've updated the test plan since the REST API route takes a little time to respond To test: 1) Apply patch 2) Search PrefillGuaranteeField preference and make sure some fields are selected 3) Select a user that can have a guarantor 4) In the edit form, click on "Search to add" in "Patron guarantor" fieldset 5) Choose a patron who has at least one of the fields in 1) set 6) Click Select 7) Wait until save button is enabled 8) Confirm guarantee's information is filled from the guarantor's record 9) Check that any preexisting information is not overwritten Signed-off-by: Sally Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:00:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:00:34 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151850|0 |1 is obsolete| | --- Comment #33 from Emmi Takkinen --- Created attachment 154505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154505&action=edit Bug 26597: (Fix) remove REST API call and retrieve the patron's data from borrower_data input This patch remove the REST API call in select_user function and retrieve the patron's data from borrower_data To test: 1) Apply patch 2) Search PrefillGuaranteeField preference and make sure some fields are selected 3) Select a user that can have a guarantor 4) In the edit form, click on "Search to add" in "Patron guarantor" fieldset 5) Choose a patron who has at least one of the fields in 1) set 6) Click Select 7) Confirm guarantee's information is filled from the guarantor's record 8) Check that any preexisting information is not overwritten Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:01:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:01:02 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151878|0 |1 is obsolete| | --- Comment #34 from Emmi Takkinen --- Created attachment 154506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154506&action=edit Bug 26597: (QA follow-up) Add missing filters Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:01:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:01:10 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:01:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:01:24 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 --- Comment #1 from Zeno Tajoli --- Created attachment 154507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154507&action=edit Image of the bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:03:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:03:52 +0000 Subject: [Koha-bugs] [Bug 34559] New: "Return to record" is doubled up when batch editing items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34559 Bug ID: 34559 Summary: "Return to record" is doubled up when batch editing items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When batch editing items from the detail page in the staff interface there is a link and an additional button that both read "Return to the record" after saving the modification. To test: 0 - Perform a search in the staff interface 1 - Click a title to go to the details page for a record 2 - Click the 'Edit' button and select 'Edit items in a batch' 3 - Make a change and hit 'Save' 4 - Note that there is a 'Return to the record' link and an additional button on the bottom with the same functionality and text -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:08:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:08:01 +0000 Subject: [Koha-bugs] [Bug 34560] New: Upgrade stops after: MYSQL_OPT_RECONNECT error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34560 Bug ID: 34560 Summary: Upgrade stops after: MYSQL_OPT_RECONNECT error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: joseanjos at gmail.com QA Contact: testopia at bugs.koha-community.org I'm trying to upgrade from version 20.05 to 23.05 When the upgrade starts I get this warning: Upgrading database schema for koha WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version. The upgrade goes OK until the end. Then, on Web Installer, I get this: Updating database structure Update errors : WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version. The only option available is: Try again It seems a Mysql bug: https://bugs.mysql.com/bug.php?id=112089 Is there a way to bypass this warning? My Ubuntu version: 20.04.6 LTS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:08:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:08:09 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #18 from Matt Blenkinsop --- Decision reached: OPACLoginLabelTextContent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:10:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:10:25 +0000 Subject: [Koha-bugs] [Bug 34556] Add a template 'Accessibility statement' page to the default data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34556 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:19:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:19:36 +0000 Subject: [Koha-bugs] [Bug 34557] Add option to prevent loading a patron's checkouts on the SCO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:19:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:19:41 +0000 Subject: [Koha-bugs] [Bug 34557] Add option to prevent loading a patron's checkouts on the SCO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557 --- Comment #1 from Nick Clemens --- Created attachment 154508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154508&action=edit Bug 34557: Add SCOLoadCheckoutsByDefault system preference This patch adds a enw system preference SCOLoadCheckoutsByDefault When enabled, a patron's list o fcurrent checkouts will be loaded when the sign in to the SCO module. If disabled, they will see link to load their checkouts. In either case, a new section is added to the SCO to show a brief display of the last checked out it To test: 1 - Enable WebBasedSelfCheck system preference 2 - Browse to: http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3 - Sign in the SCO user (or enable AutoSelfCheck) 4 - Sign in as a user with several items checked out 5 - Confirm you see a list of items checked out 6 - Apply patches, updatedatabase, restart_all 7 - 'Finish' and login patron to SCO again 8 - Confirm you still see the list 9 - 'Finish' 10 - Chenge the system preference 11 - Sign in to SCO, confirm checkouts do not load 12 - Confirm you see 'Load your checkouts' link 13 - Check an item out 14 - Confirm you see the last checkout, but not a list 15 - Attempt to checkout an item that cannot be checked out 16 - Confirm "Return to account summary" does not load checkouts 17 - Click "Load your checkouts" 18 - Confirm they load 19 - Check out another item, confrim they remain and are updated 20 - Checkout an item that cannot be issued 21 - Confirm 'Return to account summary' loads the checkouts again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:35:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:35:56 +0000 Subject: [Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:36:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:36:00 +0000 Subject: [Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145222|0 |1 is obsolete| | --- Comment #27 from Peter Vashchuk --- Created attachment 154509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154509&action=edit Bug 27428: Show the number of records in the bibliographic record detail page with ElasticSearch. Tests: 1. Apply this patch; 2. In the Preference system - OPACDisplayRecordCount -> Show; 3. We can see the number of records next to search links in the bibliographic record detail page in the OPAC. Signed-off-by: Stina Hallin Signed-off-by: Solene Ngamga Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:36:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:36:03 +0000 Subject: [Koha-bugs] [Bug 27428] Show the number of records in the bibliographic record detail page with ElasticSearch. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27428 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148842|0 |1 is obsolete| | --- Comment #28 from Peter Vashchuk --- Created attachment 154510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154510&action=edit Bug 27428: (QA follow-up) Add missing POD, remove ES template literals in opac-display-record-count.js Signed-off-by: Petro Vashchuk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 11:47:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 09:47:05 +0000 Subject: [Koha-bugs] [Bug 34556] Add a template 'Accessibility statement' page to the default data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34556 --- Comment #1 from Martin Renvoize --- See some discussion on the wiki: https://wiki.koha-community.org/wiki/Accessibility_Statement -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:04:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:04:07 +0000 Subject: [Koha-bugs] [Bug 33920] Improve translation of title tags: Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33920 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:04:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:04:10 +0000 Subject: [Koha-bugs] [Bug 33920] Improve translation of title tags: Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33920 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154460|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose --- Created attachment 154511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154511&action=edit Bug 33920: Improve translation of title tags: Patrons This patch updates patron module templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following patron-related pages have the correct title tags: - Patrons home page - Patron search -> - Select two patrons -> Merge selected - Add patron -> - Add a patron with the same name and email address -> - Click "View existing record" in "Duplicate patron record?" dialog. - Patron details - Manage API keys (must have RESTOAuth2ClientCredentials enabled) - Accounting - Transactions - Print fee receipt - Print invoice - Make a payment - Create manual invoice - Create manual credit - Routing lists (must have RoutingSerials enabled) - Circulation history - Notices - Statistics - Files (must have EnableBorrowerFiles enabled) - Purchase suggestions - Discharges (must have useDischarge enabled) - Housebound (must have HouseboundModule enabled) - ILL requests history (must have ILLModule enabled) - Set permissions - Change password - Print summary - Print account balance - Two-factor authentication (must have TwoFactorAuthentication enabled) - Edit patron - Update child to adult patron: - Must have more than one "adult" type category defined - Locate a patron with a "child" type category - Choose More -> Update child to adult patron - Delete patron (confirmation page) - Pending discharge requests - Patrons requesting modifications Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:09:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:09:11 +0000 Subject: [Koha-bugs] [Bug 34109] When adding items on receive, mandatory fields are not checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34109 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154286|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 154512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154512&action=edit Bug 34109: Check mandatory item fields when creating during recipt This patch adds a check of mandatory item fields before saving during order receipt. We check both when adding the item initially, and when submitting the order, as it will use the values from the open form. To test: * Go to administration > frameworks > ACQ > MARC structure > 952 * Set callnumber (o) or barcode (p) to mandatory * In acquisition: * Create a basket with "create items on order" and "is standing" "standing" helps as you can do multiple receives testing different things, but is optional * Add an order line * Receive shipment * Verify the mandatory fields show in the item form * Set itemtype = Music * Save with the fields blank * Item row is added, no warning * Edit the item, change the item type to blank * Click 'Confirm' for the order without closing the item edit form * Verify the item was added with itemtype Books (on sample data) and empty mandatory field * Apply patch * Repeat above, however, you should not be able to submit the item or order until mandatory fields are filled Signed-off-by: Sam Lau Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:09:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:09:45 +0000 Subject: [Koha-bugs] [Bug 34109] When adding items on receive, mandatory fields are not checked In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34109 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Nice work, QA scripts all happy and no regressions spotted. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:16:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:16:06 +0000 Subject: [Koha-bugs] [Bug 34553] Update send list and send cart popup footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34553 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:21:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:21:09 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154126|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize --- Created attachment 154513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154513&action=edit Bug 34024: Block changing pickup location for found holds This patch adds a check on holds for 'found' statuses. Holds with the following statuses have special workflows in Koha, and overwritting their pickup locations yields uncertain scenarios: * Waiting: the item has probably been put on a special shelve * In transit: the item is travelling to a new destination, and changing the pickup location should include some validations, and probably generate some notifications. At least. * In processing: the item has already been taken out of the shelve for some internal processing. Changing the pickup location could interfere with this workflow. Overriding this limitation could be introduced with care on a separate report. To test: 1. Apply the unit tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/holds.t => FAIL: Tests don't pass. Holds go through (200) instead of being rejected (409). 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Sam Lau Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:21:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:21:12 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154127|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 154514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154514&action=edit Bug 34024: Unit tests Signed-off-by: Sam Lau Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:21:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:21:15 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154132|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 154515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154515&action=edit Bug 34024: (QA follow-up) Allow pickup location changing for in transit holds Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:21:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:21:58 +0000 Subject: [Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #19 from Martin Renvoize --- Solid fix with unit tests included. QA scripts happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:22:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:22:13 +0000 Subject: [Koha-bugs] [Bug 34277] Add an API endpoint to return all patrons with outstanding charges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34277 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:22:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:22:16 +0000 Subject: [Koha-bugs] [Bug 34277] Add an API endpoint to return all patrons with outstanding charges In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34277 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153478|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop --- Created attachment 154516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154516&action=edit Bug 34277: Add unit test prove t/db_dependent/api/v1/patrons_accounts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:28:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:28:36 +0000 Subject: [Koha-bugs] [Bug 34219] getAll not allowing additional parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34219 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153631|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 154517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154517&action=edit Bug 34219: Allow getAll to receive additional URL parameters It's not possible to pass additional URL parameters. We need it at least for bug 32474. Signed-off-by: Pedro Amorim Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:29:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:29:09 +0000 Subject: [Koha-bugs] [Bug 34219] getAll not allowing additional parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34219 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |martin.renvoize at ptfs-europe | |.com --- Comment #12 from Martin Renvoize --- Code makes sense and all works as expected here.. unit tests are passing still and qa script is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:30:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:30:23 +0000 Subject: [Koha-bugs] [Bug 34553] Update send list and send cart popup footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34553 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:30:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:30:29 +0000 Subject: [Koha-bugs] [Bug 34553] Update send list and send cart popup footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34553 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154495|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 154518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154518&action=edit Bug 34553: Update send list and send cart popup footers This patch updates the templates behind the "send cart" and "send list" pop-ups in order to make the style of the footer consistent with some recently-updated similar examples, like the catalog's Z39.50 search popup. The patch also makes a minor change to our global JavaScript include so we can get away from using the "close" class as a trigger for closing a pop-up window. Bootstrap has a built-in "close" class that we always have to override. "close_window" is added as another class to use, and the other instances can be cleaned up overy time. To test, apply the patch and perform a catalog search in the staff interface. - Add one or more items to the cart. - Open the cart popup and click the "Send" button. - In the pop-up window, confirm that the footer looks correct. - Test the process of using the tab key between input fields and submit/cancel buttons. All controls should be accessible. - Test the "Cancel" button to confirm that it closes the window. - Reopen the window and test sending the email. - On the confirmation page, confirm that the footer looks correct and that the "Close window" button works. - Test the same processes in the Lists module: View a list in the staff interface and test the process of sending a list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:30:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:30:59 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:31:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:31:03 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154444|0 |1 is obsolete| | --- Comment #41 from Caroline Cyr La Rose --- Created attachment 154519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154519&action=edit Bug 6419: Add custom HTML areas to intranet home pages This patch adds customisable HTML text areas to acqui/acqui-home.pl, authorities/authorities-home.pl, cataloguing/addbooks.pl, virtualshelves/shelves.pl, members/members-home.pl, pos/pay.pl and serials/serials-home.pl pages To test: 1) Apply patch 2) Run updatedatabase.pl 3) Add some html to the new prefs IntranetAcquisitionsHomeHTML, IntranetAuthoritiesHomeHTML, IntranetCatalogingHomeHTML, IntranetListsHomeHTML, IntranetPatronsHomeHTML, IntranetPOSHomeHTML and IntranetSerialsHomeHTML 4) View the Acquisition, Authorities, Cataloging, Lists, Patrons, Point of Sale, and Serials homepages and confirm that your changes show. Note that this should display in exactly the same way as it does in the already extant IntranetCirculationHomeHTML and IntranetReportsHomeHTML system preferences. Signed-off-by: Brandon J Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:31:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:31:07 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154445|0 |1 is obsolete| | --- Comment #42 from Caroline Cyr La Rose --- Created attachment 154520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154520&action=edit Bug 6419: Add StaffAcquisitionsHome block to additional contents This patch adds a new `StaffAcquisitionsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the acquisitions home page. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:31:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:31:11 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154446|0 |1 is obsolete| | --- Comment #43 from Caroline Cyr La Rose --- Created attachment 154521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154521&action=edit Bug 6419: Add StaffAuthoritiesHome block to additional contents This patch adds a new `StaffAuthoritiesHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the authorities home page. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:31:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:31:15 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154447|0 |1 is obsolete| | --- Comment #44 from Caroline Cyr La Rose --- Created attachment 154522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154522&action=edit Bug 6419: Add StaffCataloguingHome block to additional contents This patch adds a new `StaffCataloguingHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the cataloguing home page. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:31:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:31:19 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154448|0 |1 is obsolete| | --- Comment #45 from Caroline Cyr La Rose --- Created attachment 154523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154523&action=edit Bug 6419: Add StaffListsHome block to additional contents This patch adds a new `StaffListsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the lists home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:31:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:31:23 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154449|0 |1 is obsolete| | --- Comment #46 from Caroline Cyr La Rose --- Created attachment 154524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154524&action=edit Bug 6419: Add StaffPatronsHome block to additional contents This patch adds a new `StaffPatronsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the patrons home page. NOTE: This one may highlight an issue with Panels directly followed by page-sections. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:31:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:31:27 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154450|0 |1 is obsolete| | --- Comment #47 from Caroline Cyr La Rose --- Created attachment 154525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154525&action=edit Bug 6419: Add StaffPOSHome block to additional contents This patch adds a new `StaffPOSHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: All the blocks have been placed at the bottom of the home pages respectively for consistency. However, in this case it doesn't look as clean as the content above is a form. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:31:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:31:31 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154451|0 |1 is obsolete| | --- Comment #48 from Caroline Cyr La Rose --- Created attachment 154526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154526&action=edit Bug 6419: Add StaffSerialsHome block to additional contents This patch adds a new `StaffSerialsHome` block to the HTML Customisations options. This allows for the addition of a block of content in a page-section at the bottom of the point of sale page. NOTE: This patch also removes the now defunct database update introduced in the first patch of the series. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:31:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:31:35 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154452|0 |1 is obsolete| | --- Comment #49 from Caroline Cyr La Rose --- Created attachment 154527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154527&action=edit Bug 6419: (follow-up) Use Select2 with optgroups This patch divides the OPAC and staff options into separate optgroups and adds Select2 for styling and filtering. THe patch also corrects a few missed instances of "Intranet" in the list of location options on the entry form. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:33:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:33:41 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #50 from Caroline Cyr La Rose --- This is really cool. Thanks Martin! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:35:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:35:35 +0000 Subject: [Koha-bugs] [Bug 34553] Update send list and send cart popup footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34553 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:37:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:37:04 +0000 Subject: [Koha-bugs] [Bug 34561] New: Move IntranetReportsHomeHTML to HTML customizations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34561 Bug ID: 34561 Summary: Move IntranetReportsHomeHTML to HTML customizations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org Bug 6419 adds some HTML customizations to the staff interface. IntranetReportsHomeHTML is still a system preference. It would be nice to move it to HTML customizations with the others. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:37:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:37:46 +0000 Subject: [Koha-bugs] [Bug 34562] New: Update more pop-up windows with consistent footer markup Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34562 Bug ID: 34562 Summary: Update more pop-up windows with consistent footer markup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 34343 I would like to change some other pop-up windows to be consistent with Bug 34343 and its children, including: - Add to list (from catalog search results) - SRU Search fields mapping - Bibliographic - SRU Search fields mapping - Authority Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 [Bug 34343] Z39.50 search background not updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:37:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:37:46 +0000 Subject: [Koha-bugs] [Bug 34343] Z39.50 search background not updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34562 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34562 [Bug 34562] Update more pop-up windows with consistent footer markup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:37:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:37:58 +0000 Subject: [Koha-bugs] [Bug 34561] Move IntranetReportsHomeHTML to HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34561 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6419 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:37:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:37:58 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34561 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:39:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:39:47 +0000 Subject: [Koha-bugs] [Bug 31502] Add a customizable list of useful resources for cataloging to the left side of the cataloging module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31502 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #3 from Caroline Cyr La Rose --- Bug 6419 adds a section at the bottom. I don't know if it answers the need? Or if you really need it to be on the left? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:41:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:41:08 +0000 Subject: [Koha-bugs] [Bug 34563] New: Move IntranetCirculationHomeHTML to HTML customizations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Bug ID: 34563 Summary: Move IntranetCirculationHomeHTML to HTML customizations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org Bug 6419 adds some HTML customizations to the staff interface. IntranetCirculationHomeHTML is still a system preference. It would be nice to move it to HTML customizations with the others. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:41:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:41:15 +0000 Subject: [Koha-bugs] [Bug 34563] Move IntranetCirculationHomeHTML to HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6419 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:41:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:41:15 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34563 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:41:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:41:37 +0000 Subject: [Koha-bugs] [Bug 34563] Move IntranetCirculationHomeHTML to HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34561 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:41:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:41:37 +0000 Subject: [Koha-bugs] [Bug 34561] Move IntranetReportsHomeHTML to HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34561 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34563 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:45:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:45:15 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:46:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:46:51 +0000 Subject: [Koha-bugs] [Bug 18784] Add 'auto claim' option to subscription batch edit tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Anneli Österman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman at koha-suomi. | |fi --- Comment #9 from Anneli Österman --- I tested this on PTFS Europe's sandbox and got the following error when I changed in batch edit Enable automatic claims -> Yes. The method Koha::Subscription->auto_claim_enabled is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 931 Koha::Object::AUTOLOAD('Koha::Subscription=HASH(0x561f2228ef70)', 1) called at /kohadevbox/koha/serials/subscription-batchedit.pl line 75 eval {...} at /kohadevbox/koha/serials/subscription-batchedit.pl line 2 CGI::Compile::ROOT::kohadevbox_koha_serials_subscription_2dbatchedit_2epl::__ANON__('CGI::Compile=HASH(0x561f212bfe10)', '', '/kohadevbox/koha/serials/subscription-batchedit.pl', '/kohadevbox/koha/serials', 'ARRAY(0x561f215d3778)') called at /usr/share/perl5/CGI/Compile.pm line 151 CGI::Compile::ROOT::kohadevbox_koha_serials_subscription_2dbatchedit_2epl::subscription_2dbatchedit_2epl at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 CGI::Emulate::PSGI::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/App/WrapCGI.pm line 95 Plack::App::WrapCGI::call('Plack::App::WrapCGI=HASH(0x561f2188aa88)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/App/CGIBin.pm line 50 Plack::App::CGIBin::serve_path('Plack::App::CGIBin=HASH(0x561f173e7a30)', 'HASH(0x561f21f35db8)', '/kohadevbox/koha/serials/subscription-batchedit.pl') called at /usr/share/perl5/Plack/App/File.pm line 34 Plack::App::File::call('Plack::App::CGIBin=HASH(0x561f173e7a30)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/LogWarn.pm line 22 Plack::Middleware::LogWarn::call('Plack::Middleware::LogWarn=HASH(0x561f212ef248)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/Log4perl.pm line 30 Plack::Middleware::Log4perl::call('Plack::Middleware::Log4perl=HASH(0x561f212f6f58)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 20 Plack::Middleware::HTTPExceptions::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x561f2161c7c8)', 'Try::Tiny::Catch=REF(0x561f21ff9598)') called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 23 Plack::Middleware::HTTPExceptions::call('Plack::Middleware::HTTPExceptions=HASH(0x561f212f69d0)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/ErrorDocument.pm line 15 Plack::Middleware::ErrorDocument::call('Plack::Middleware::ErrorDocument=HASH(0x561f21515c98)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/App/URLMap.pm line 71 Plack::App::URLMap::call('Plack::App::URLMap=HASH(0x561f200e95f8)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /kohadevbox/koha/Koha/Middleware/RealIP.pm line 64 Koha::Middleware::RealIP::call('Koha::Middleware::RealIP=HASH(0x561f212f6da8)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /kohadevbox/koha/Koha/Middleware/SetEnv.pm line 106 Koha::Middleware::SetEnv::call('Koha::Middleware::SetEnv=HASH(0x561f21407f80)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/Static.pm line 18 Plack::Middleware::Static::call('Plack::Middleware::Static=HASH(0x561f21515b78)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/ReverseProxy.pm line 68 Plack::Middleware::ReverseProxy::call('Plack::Middleware::ReverseProxy=HASH(0x561f21515ed8)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/Lint.pm line 24 Plack::Middleware::Lint::call('Plack::Middleware::Lint=HASH(0x561f173e77f0)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/StackTrace.pm line 38 Plack::Middleware::StackTrace::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x561f21d32aa8)', 'Try::Tiny::Catch=REF(0x561f221c52c0)') called at /usr/share/perl5/Plack/Middleware/StackTrace.pm line 42 Plack::Middleware::StackTrace::call('Plack::Middleware::StackTrace=HASH(0x561f200de578)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/AccessLog.pm line 27 Plack::Middleware::AccessLog::call('Plack::Middleware::AccessLog=HASH(0x561f200dd7c8)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Util.pm line 145 eval {...} at /usr/share/perl5/Plack/Util.pm line 145 Plack::Util::run_app('CODE(0x561f200dd708)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Starman/Server.pm line 195 Starman::Server::dispatch_request('Starman::Server=HASH(0x561f16e053b0)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Starman/Server.pm line 298 Starman::Server::process_request('Starman::Server=HASH(0x561f16e053b0)', 'Net::Server::Proto::UNIX=GLOB(0x561f21a137c8)') called at /usr/share/perl5/Net/Server.pm line 72 Net::Server::run_client_connection('Starman::Server=HASH(0x561f16e053b0)') called at /usr/share/perl5/Net/Server/PreFork.pm line 225 eval {...} at /usr/share/perl5/Net/Server/PreFork.pm line 225 Net::Server::PreFork::run_child('Starman::Server=HASH(0x561f16e053b0)') called at /usr/share/perl5/Net/Server/PreFork.pm line 183 Net::Server::PreFork::run_n_children('Starman::Server=HASH(0x561f16e053b0)', 2) called at /usr/share/perl5/Net/Server/PreFork.pm line 107 Net::Server::PreFork::loop('Starman::Server=HASH(0x561f16e053b0)') called at /usr/share/perl5/Net/Server.pm line 58 Net::Server::run('Starman::Server=HASH(0x561f16e053b0)', 'port', 'ARRAY(0x561f17392100)', 'host', '*', 'proto', 'tcp', 'serialize', 'none', 'min_servers', 2, 'min_spare_servers', 1, 'max_spare_servers', 1, 'max_servers', 2, 'max_requests', 50, 'user', 'bug18784-koha', 'group', 'bug18784-koha', 'listen', 1024, 'check_for_waiting', 1, 'no_client_stdout', 1, 'pid_file', '/var/run/koha/bug18784/plack.pid', 'setsid', 1, 'log_file', '/var/log/koha/bug18784/plack-error.log', 'background', 1) called at /usr/share/perl5/Starman/Server.pm line 106 Starman::Server::run('Starman::Server=HASH(0x561f16e053b0)', 'CODE(0x561f16e05260)', 'HASH(0x561f16e05008)') called at /usr/share/perl5/Plack/Handler/Starman.pm line 25 Plack::Handler::Starman::run('Plack::Handler::Starman=HASH(0x561f16e05278)', 'CODE(0x561f16e05260)') called at /usr/share/perl5/Plack/Loader/Delayed.pm line 20 Plack::Loader::Delayed::run('Plack::Loader::Delayed=HASH(0x561f16b56f10)', 'Plack::Handler::Starman=HASH(0x561f16e05278)') called at /usr/share/perl5/Plack/Runner.pm line 279 Plack::Runner::run('Plack::Runner=HASH(0x561f16af0360)') called at /usr/bin/starman line 38 at /usr/share/perl5/Exception/Class/Base.pm line 88 I tried to refresh the schema and restart the services but there was no change. Any tips how to test this further? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:55:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:55:09 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154367|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 154528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154528&action=edit Bug 33428: Parse search fields in buildPatronSearchQuery This patch moves the parsing of standard search_field into the buildPatronQuery subroutine and adds a check for 'standard' field before adding attributes to the search To test: 1 - Add a new attribute type and make it searchable 2 - Add a value to a patron 3 - Search for this value using 'Standard' fields, confirm you get the patron 4 - Search for the value using 'Cardnumber' field, confirm you get the patron - BAD! 5 - Apply patch 6 - Repeat cardnumebr search, confirm patron not found - Yay! 7 - Search standard, confirm patron is found 8 - Add a new field to 'DefaultPatronSearchFields 9 - Confirm it appears in patron search dropdown 10 - Confirm a search of this field with the attribute value does not return the patron Signed-off-by: Fridolin Somers Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:55:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:55:10 +0000 Subject: [Koha-bugs] [Bug 34557] Add option to prevent loading a patron's checkouts on the SCO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:55:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:55:11 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154368|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 154529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154529&action=edit Bug 33428: Adjust Unit Tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:55:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:55:14 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 --- Comment #12 from Martin Renvoize --- Created attachment 154530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154530&action=edit Bug 33428: (QA follow-up) Fix escaping in a split call We'd missed an escape case in one of the calls to .split for the pipe delimited split operations. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:55:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:55:40 +0000 Subject: [Koha-bugs] [Bug 28499] Add support for no-UI / administrative plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 --- Comment #8 from Kyle M Hall --- (In reply to David Cook from comment #7) > (In reply to David Cook from comment #6) > > Actually, I think it would need to be a flag, because you might want to > > distribute a third-party plugin via a shared directory to many Koha > > instances and not want 1 Koha admin to be able to uninstall it for > > everyone... > > But the problem with the flag is that often plugins are installed from the > CLI like this: > > koha-shell kohadev -c "/usr/share/koha/bin/devel/install_plugins.pl" > > So there would need to be some other way of preventing uninstall... Perhaps a "--read-only" switch that would add an additional "_ReadOnly" key to the plugin_data table? That would be easy enough to code a check for. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:55:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:55:56 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- Nice work, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 12:56:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 10:56:03 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:05:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:05:30 +0000 Subject: [Koha-bugs] [Bug 34562] Update more pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34562 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:05:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:05:34 +0000 Subject: [Koha-bugs] [Bug 34562] Update more pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34562 --- Comment #1 from Owen Leonard --- Created attachment 154531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154531&action=edit Bug 34562: Update more pop-up windows with consistent footer markup This patch updates a few more pop-up window templates to standardize the markup of footer controls. The patch also updates the way catalog.js triggers the "Add to list" pop-up so that it uses the same window-opening JS function that similar pages do, since the default gives us consistent popup features. To test, apply the patch and perform a catalog search in the staff interface which will return multiple results. - Check the box next to one or more results. - Click the "Add to list" button. - Test the various options here: Add to an existing list, a new list, or choose "More lists." - In each case the pop-up window which appears should have a consistent fixed footer with "Save" and "Cancel" buttons. - Confirm that these controls can be navigated to using the tab key. - Confirm that each one works correctly. - Go to Administration -> Z39.50/SRU servers -> New SRU server. - Click the "Modify" button by the "SRU Search fields mapping" field. - Inspect and test the resulting pop-up window. - Switch the "Record type" dropdown to "Authority," click the "Modify" button again, and test this version of the pop-up window too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:06:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:06:56 +0000 Subject: [Koha-bugs] [Bug 34563] Move IntranetCirculationHomeHTML to HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:08:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:08:02 +0000 Subject: [Koha-bugs] [Bug 25023] Claims returned dates not formatted according to dateformat preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154321|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 154532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154532&action=edit Bug 25023: Claims returned dates not formatted according to dateformat preference This patch updates the code for rendering the claims returned table on the checkout and patron detail pages. Now the dates are formatted using the global js-date-format.inc code. To test, apply the patch and make sure the claims returned feature is enabled by setting a value in the ClaimReturnedLostValue system preference. - Check out some items to a patron. - Under the checkouts tab, mark several checkouts as "Claim returned." - Open the claims tab. - The dates in the "Created on" column should be formatted according to your dateformat system preference. - Change the dateformat preference and return to the checkouts page. Confirm that the claims tab shows dates formatted correctly. - The "created on" and "updated on" columns should sort correctly with any dateformat setting. You may have to directly modify the dates in the database in order to have the right data for testing this. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:09:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:09:01 +0000 Subject: [Koha-bugs] [Bug 25023] Claims returned dates not formatted according to dateformat preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- All working as expected. I was surprised this wasn't an ajax table yet using the wrapper.. it would be nice to convert it at some point, then this column fun could go away as sorting works more clearly for those I believe. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:09:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:09:06 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:09:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:09:07 +0000 Subject: [Koha-bugs] [Bug 25023] Claims returned dates not formatted according to dateformat preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:09:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:09:10 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #3 from Pedro Amorim --- Created attachment 154533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154533&action=edit Bug 25393: Add new noautorenewalbefore circulation rule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:09:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:09:13 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #4 from Pedro Amorim --- Created attachment 154534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154534&action=edit Bug 25393: Use new noautorenewalbefore circulation rule in _CanBookBeAutoRenewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:09:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:09:16 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #5 from Pedro Amorim --- Created attachment 154535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154535&action=edit Bug 25393: UI adjustments This updates the information messages that are displayed in Staff, OPAC and SCO regarding renewals and if the item is up for automatic renewal or not. Add issues.auto_renew to svc/checkouts endpoint response -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:09:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:09:19 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #6 from Pedro Amorim --- Created attachment 154536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154536&action=edit Bug 25393: Distinguish between auto or normal renewals in GetSoonestRenewDate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:09:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:09:22 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #7 from Pedro Amorim --- Created attachment 154537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154537&action=edit Bug 25393: atomicupdate file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:09:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:09:25 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #8 from Pedro Amorim --- Created attachment 154538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154538&action=edit Bug 25393: Auto renewals logic reimplementation: Check if it's too soon for a manual renewal even if 'Automatic renewals' is enabled Allow for a manual renewal even if it's too soon for an automatic renewal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:09:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:09:29 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #9 from Pedro Amorim --- Created attachment 154539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154539&action=edit Bug 25393: Update CanBookBeRenewed pod with bug 25758 changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:09:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:09:32 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #10 from Pedro Amorim --- Created attachment 154540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154540&action=edit Bug 25393: Tests - Variable renaming issue_4 is an auto_renew issue, rename to auto_renew_issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:09:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:09:35 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #11 from Pedro Amorim --- Created attachment 154541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154541&action=edit Bug 25393: Update Circulation.t prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:10:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:10:11 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Pascal Uphaus changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:10:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:10:14 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Pascal Uphaus changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148720|0 |1 is obsolete| | --- Comment #32 from Pascal Uphaus --- Created attachment 154542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154542&action=edit Bug 31729: Enable automatic filesystem refresh in Plack to test (on KTD) - install inotify-tools $ sudo apt install inotify-tools - apply patch $ git bz apply 31729 - manually install files and set perms $ cd /kohadevbox/koha $ sudo cp debian/scripts/koha-plack /usr/sbin $ sudo cp debian/scripts/koha-watcher /usr/sbin $ sudo chmod 755 /usr/sbin/koha-plack $ sudo chmod 755 /usr/sbin/koha-watcher - restart, with --watch arg $ sudo koha-plack --restart --watch kohadev - observe koha-watch process $ ps -ef | grep koha-watcher | grep -v grep | wc -l 3 - modify some perl files in watched dir $ echo `date` > /kohadevbox/koha/xxx.pl $ echo `date` > /kohadevbox/koha/xxx.pm - see HUP/inotify messages in log file $ tail -f /var/log/koha/kohadev/plack-watcher.log CLOSE_WRITE,CLOSE event on /kohadevbox/koha/xxx.pl CLOSE_WRITE,CLOSE event on /kohadevbox/koha/xxx.pm koha-plack reloaded - add syntax error to file in watched dir $ echo `date` > /kohadevbox/koha/C4/Context.pm - see HUP/inotify messages in log file $ tail -f /var/log/koha/kohadev/plack-watcher.log CLOSE_WRITE,CLOSE event on /kohadevbox/koha/C4/Context.pm koha-plack failed! sleeping 2 secs koha-plack failed! sleeping 3 secs koha-plack failed! sleeping 4 secs ... koha-plack failed! sleeping 10 secs - fix syntax error in file in watched dir $ git checkout /kohadevbox/koha/C4/Context.pm - see HUP/inotify messages in log file $ tail -f /var/log/koha/kohadev/plack-watcher.log CLOSE_WRITE,CLOSE event on /kohadevbox/koha/C4/Context.pm koha-plack reloaded ok - stop koha-plack $ sudo koha-plack --stop kohadev - observe no koha-watch process $ ps -ef | grep koha-watcher | grep -v grep | wc -l 0 Signed-off-by: Pascal Uphaus Signed-off-by: Thomas Klausner Signed-off-by: Lari Strand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:10:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:10:45 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Inkeri Hakulinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |inkeri.hakulinen+bugz at helsi | |nki.fi --- Comment #5 from Inkeri Hakulinen --- At the test phase step 13 the new patron attribute does not appear in any dropdown menus, so I cannot test if it's searchable or not. Other steps until that work as planned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:13:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:13:24 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |several new locations to | |HTML customizations to add | |content to various staff | |interface pages. This | |supports multilingual | |content, as with any HTML | |customization. | | | |New | |locations are: | | | |- | |StaffAcquisitionsHome: adds | |content at the bottom of | |the acquisitions module | |home page | | | |- | |StaffAuthoritiesHome: adds | |content at the bottom of | |the authorities module home | |page | | | |- | |StaffCataloguingHome: adds | |content at the bottom of | |the cataloguing module home | |page | | | |- StaffListsHome: | |adds content at the bottom | |of the lists module home | |page | | | |- StaffPatronsHome: | |adds content at the bottom | |of the patrons module home | |page | | | |- StaffPOSHome: adds | |content at the bottom of | |the point of sale module | |home page | | | |- | |StaffSerialsHome: adds | |content at the bottom of | |the serials module home | |page -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:13:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:13:27 +0000 Subject: [Koha-bugs] [Bug 34564] New: Create a clickable link for the WebBasedSelfCheck system preference Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34564 Bug ID: 34564 Summary: Create a clickable link for the WebBasedSelfCheck system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In the system preferences, this system preference, WebBasedSelfCheck is a partial link for the SCO module. It would be super helpful if this was a clickable link that include the OPACbaseURL with the SCO end part. And that entire address could be clickable from the system preference itself. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:14:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:14:03 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Inkeri Hakulinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Inkeri Hakulinen --- I tested this but I couldn't get it working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:23:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:23:23 +0000 Subject: [Koha-bugs] [Bug 34441] Typo: paramater In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34441 Pascal Uphaus changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascal.uphaus at gwdg.de Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |pascal.uphaus at gwdg.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:27:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:27:43 +0000 Subject: [Koha-bugs] [Bug 33074] ReservesControlBranch not taken into account in opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33074 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147426|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 154543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154543&action=edit Bug 33074: Take ReservesControlBranch into account in opac-reserve.pl Test plan: 1. Set system preferences: - Disable OPACAllowUserToChooseBranch - Set ReservesControlBranch to "item's home library" - Enable UseBranchTransferLimits - Set BranchTransferLimitsType to "item type" - Enable canreservefromotherbranches - Disable IndependantBranches 2. Create two libraries: ITEM_LIB and PATRON_LIB 3. Set circulation rules: - Remove all circulation rules (DELETE FROM circulation_rules) - Set a default rule that allow some holds and with "OPAC item level holds" = "force". Allow "on shelf" holds for easier testing. - In the rules for ITEM_LIB, under "Default checkout, hold and return policy", - set "Hold policy" to "From any library" - set "Hold pickup library match" to "item's home library" - In the rules for PATRON_LIB, under "Default checkout, hold and return policy", - set "Hold policy" to "From any library", - set "Hold pickup library match" to "any library" 4. In "Library transfer limits" disable all transfers from ITEM_LIB to PATRON_LIB for an item type (let's say "BOOK") 5. Create a biblio with an item: - item type must be the same as in previous step ("BOOK") - home branch and holding branch must be ITEM_LIB 6. Create a patron at PATRON_LIB, give it a password so it can log in. 7. Go to OPAC, and login with this patron 8. Try to place a hold for the new item. You should be allowed to place a hold, but when doing it, no holds will be created. 9. Apply patch, restart Koha 10. Try to place a hold for the new item. This time the hold should be created Signed-off-by: Jessie Zairo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:27:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:27:58 +0000 Subject: [Koha-bugs] [Bug 34557] Add option to prevent loading a patron's checkouts on the SCO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154508|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 154544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154544&action=edit Bug 34557: Add SCOLoadCheckoutsByDefault system preference This patch adds a enw system preference SCOLoadCheckoutsByDefault When enabled, a patron's list o fcurrent checkouts will be loaded when the sign in to the SCO module. If disabled, they will see link to load their checkouts. In either case, a new section is added to the SCO to show a brief display of the last checked out it To test: 1 - Enable WebBasedSelfCheck system preference 2 - Browse to: http://localhost:8080/cgi-bin/koha/sco/sco-main.pl 3 - Sign in the SCO user (or enable AutoSelfCheck) 4 - Sign in as a user with several items checked out 5 - Confirm you see a list of items checked out 6 - Apply patches, updatedatabase, restart_all 7 - 'Finish' and login patron to SCO again 8 - Confirm you still see the list 9 - 'Finish' 10 - Chenge the system preference 11 - Sign in to SCO, confirm checkouts do not load 12 - Confirm you see 'Load your checkouts' link 13 - Check an item out 14 - Confirm you see the last checkout, but not a list 15 - Attempt to checkout an item that cannot be checked out 16 - Confirm "Return to account summary" does not load checkouts 17 - Click "Load your checkouts" 18 - Confirm they load 19 - Check out another item, confrim they remain and are updated 20 - Checkout an item that cannot be issued 21 - Confirm 'Return to account summary' loads the checkouts again Signed-off-by: Andrew Auld -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:28:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:28:14 +0000 Subject: [Koha-bugs] [Bug 33074] ReservesControlBranch not taken into account in opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33074 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:28:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:28:28 +0000 Subject: [Koha-bugs] [Bug 25165] Explain all the cataloging plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25165 Anke Bruns changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #4 from Anke Bruns --- (In reply to Anke Bruns from comment #3) > Currently writing a manual entry for the value builder scripts. https://koha-community.org/manual//latest/de/html/valuebuilder.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:28:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:28:36 +0000 Subject: [Koha-bugs] [Bug 33074] ReservesControlBranch not taken into account in opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33074 --- Comment #3 from Jessie Zairo --- Very thorough testing steps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:28:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:28:50 +0000 Subject: [Koha-bugs] [Bug 34557] Add option to prevent loading a patron's checkouts on the SCO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34557 Andrew Auld changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrew.auld at ptfs-europe.com --- Comment #3 from Andrew Auld --- Great patch. Only my own incompetence slowed me down in working through the test plan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:28:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:28:56 +0000 Subject: [Koha-bugs] [Bug 25165] Explain all the cataloging plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25165 Anke Bruns changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|anke.bruns at gwdg.de |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:34:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:34:51 +0000 Subject: [Koha-bugs] [Bug 25816] Add OPAC messages in SIP display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139688|0 |1 is obsolete| | --- Comment #5 from Matthias Meusburger --- Created attachment 154545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154545&action=edit Bug 25816: Add opac messages in SIP display. Test plan: - Add one or more opac messages to a patron (patron detail -> add message -> Add a message for: OPAC) - Check that the messages will be displayed, with correctly formatted dates. You can use src/C4/SIP/interactive_patron_dump.pl for easier testing. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:36:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:36:01 +0000 Subject: [Koha-bugs] [Bug 34533] jsdiff library missing from guided reports page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34533 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jzairo at bywatersolutions.com --- Comment #2 from Jessie Zairo --- The test worked as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:36:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:36:51 +0000 Subject: [Koha-bugs] [Bug 34565] New: Label mismatch in MARC21 006 and 008 cataloging plugins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34565 Bug ID: 34565 Summary: Label mismatch in MARC21 006 and 008 cataloging plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy, accessibility Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org A common JS file, xmlControlfield.js, generates markup for labels and input fields but the labels don't match. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:37:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:37:54 +0000 Subject: [Koha-bugs] [Bug 34441] Typo: paramater In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34441 Pascal Uphaus changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:37:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:37:57 +0000 Subject: [Koha-bugs] [Bug 34441] Typo: paramater In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34441 --- Comment #1 from Pascal Uphaus --- Created attachment 154546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154546&action=edit Bug 34441: Fixed Typo "Paramater" To test: 1. git grep paramater 2. notice 3 files have spelling mistakes 3. apply the patch 4. git grep paramater 5. notice there are no spelling mistakes for that word -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:40:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:40:17 +0000 Subject: [Koha-bugs] [Bug 25816] Add OPAC messages in SIP display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25816 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Matthias Meusburger --- Hello ! I've rebased the patch against master, and added unit tests. Kyle, could you have another try now that it is rebased? It's working for me with the rebased patch: kohadev-koha at kohadevbox:/kohadevbox/koha/misc$ ./sip_cli_emulator.pl -a 127.0.0.1 -su koha -sp koha -l MPL --patron 23529000035676 -m patron_information Attempting socket connection to 127.0.0.1:6001...connected! Use of uninitialized value $hold_mode in string eq at ./sip_cli_emulator.pl line 123. SEND: 9300CNkoha|COkoha|CPMPL| READ: 941 Trying 'patron_information' SEND: 6300120230817 113324 AOMPL|AA23529000035676|ACkoha| READ: 64 00120230817 113324000000000000000000000000AOkohalibrary|AA23529000035676|AEHenry Acevedo|BLY|BV0|CC5|BD4345 Library Rd. Springfield, MA 44224|BF(212) 555-1212|PB19580530|PCS|PIY|AFGreetings from Koha. . Messages for you: 08/17/2023: My message| -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:41:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:41:28 +0000 Subject: [Koha-bugs] [Bug 34240] Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 Pascal Uphaus changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascal.uphaus at gwdg.de Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |pascal.uphaus at gwdg.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:42:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:42:22 +0000 Subject: [Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:46:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:46:36 +0000 Subject: [Koha-bugs] [Bug 34565] Label mismatch in MARC21 006 and 008 cataloging plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34565 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:46:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:46:44 +0000 Subject: [Koha-bugs] [Bug 34565] Label mismatch in MARC21 006 and 008 cataloging plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34565 --- Comment #1 from Owen Leonard --- Created attachment 154547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154547&action=edit Bug 34565: Label mismatch in MARC21 006 and 008 cataloging plugins This patch modifies the JS which builds the table of options for populating MARC21 fields 006 and 008 when using the cataloging plugin. To test, apply the patch and go to Cataloging -> New record. - Click the plugin trigger link next to the 006 input field (you may need to click the tag to expand it. - In the table of input fields, test that clicking the label, e.g. "Type of material", "00 - Form of material," etc, moves focus to the corresponding form field. - Perform the same test on the plugin-popup for field 008. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:47:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:47:08 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22018 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:47:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:47:08 +0000 Subject: [Koha-bugs] [Bug 22018] Add an option to 'AllowEarlyRenewal' to enable users to renew before the autorenew date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22018 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25393 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:47:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:47:16 +0000 Subject: [Koha-bugs] [Bug 34441] Typo: paramater In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34441 Thomas Klausner changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:47:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:47:18 +0000 Subject: [Koha-bugs] [Bug 34441] Typo: paramater In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34441 Thomas Klausner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154546|0 |1 is obsolete| | --- Comment #2 from Thomas Klausner --- Created attachment 154548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154548&action=edit Bug 34441: Fixed Typo "Paramater" To test: 1. git grep paramater 2. notice 3 files have spelling mistakes 3. apply the patch 4. git grep paramater 5. notice there are no spelling mistakes for that word Signed-off-by: Thomas Klausner -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:54:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:54:54 +0000 Subject: [Koha-bugs] [Bug 9762] Log circulation overrides In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 13:57:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 11:57:49 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #7 from Kelly McElligott --- REVISED test plan- removing step 13 from previous test plan. This option view is another bug! Created attachment 154392 [details] [review] Bug 34517: Add option search patron attributes by default This patch moves form any staff_searchable attribute being automatically included in the the Standard patron serch, to allowing the librarian to choose. Current searchable attributes will be marked as 'searched_by_default' To test: 1 - Add a searchable patron attribute type 2 - Add some values 3 - Confirm they are searched in a 'Standard' patron search 4 - Apply patch 5 - Go to admin - >patron attribute types 6 - Note new 'Searching' column 7 - Confirm attribute is 'Searched by default' 8 - Confirm searches work as before 9 - Edit the attribute type 10 - Uncheck 'searched_by_default' 11 - Save 12 - Confirm attribute not searched in 'Standard' search 13 - Confirm it is correctly searched -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:07:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:07:14 +0000 Subject: [Koha-bugs] [Bug 34240] Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 Pascal Uphaus changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:07:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:07:17 +0000 Subject: [Koha-bugs] [Bug 34240] Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 --- Comment #1 from Pascal Uphaus --- Created attachment 154549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154549&action=edit Bug 34240: Added hint about having to use Koha-to-MARC mappings for Koha link in frameworks To test: 1. Go to administration > marc bibliographic framework > choose framework > marc structure choose any tag 2. go to actions and edit subfields 3. check that the koha link pulldown can not be edited => There is no hint 4. Apply patch 5. Refresh the page, now there is a hint on how to edit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:10:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:10:49 +0000 Subject: [Koha-bugs] [Bug 31579] Improve reserve/request.pl to avoid mistakes with pick up locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31579 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144634|0 |1 is obsolete| | --- Comment #10 from PTFS Europe Sandboxes --- Created attachment 154550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154550&action=edit Bug 31579: Improve reserve/request.pl to avoid mistakes with pick up locations This patch improve the behavior of the intranet reservation page cgi-bin/koha/reserve/request.pl It ensures that when you change the 'pickup at' value in the 'Hold details' section, the 'Allowed pickup locations' values of each item are also changed (in the table) Prerequisites have 3 different branches (libraries) library A - logged in library, the one used to log into the intranet by the employee library B - item's home library library C - item's holding library found in the file of the user who will have the reservation have a record with multiple copies create one item for each library A, B, C with homebranch = holdingbranch (with barcode) Test plan 1- Find a user record 2- Change the user library (put library C) and Save 3- Find the notice 4- Click on 'Place Hold' 5- Enter user name 6- Check the 'pickup at' field of the top section and those in the coluumn 'Allowed pickup locations' 7- Change the library of the top 'pickup at' field 8- Check the 'Allowed pickup locations' of each item 9- Notice that the 'Allowed pickup locations' columns are not adjusted 10- Apply the path 11- Repeat step 3,4,5,6,7,8 12- Notice that all the 'Allowed pickup locations' columns are now adjusted and are the same that the selected 'pickup at' field Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:11:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:11:27 +0000 Subject: [Koha-bugs] [Bug 31579] Improve reserve/request.pl to avoid mistakes with pick up locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31579 Anneli Österman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman at koha-suomi. | |fi Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:11:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:11:51 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 --- Comment #2 from Zeno Tajoli --- Created attachment 154551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154551&action=edit patch for custom.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:13:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:13:12 +0000 Subject: [Koha-bugs] [Bug 34558] Update custom.sql for it-IT webinstaller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34558 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Zeno Tajoli --- It is an update of this file, here there are the specific customization for italian users. Test plan for the patch: Start a web installation with italian language. Select Marc21 as biblio format Select all optional .sql files See the warning present into the image. Conclude the installation. Apply the patch. Drop and recreate the mysql db Redone the installation with italian language. Use the same options written above. Now no more the warning. Installation conclude OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:13:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:13:15 +0000 Subject: [Koha-bugs] [Bug 34095] Shipping cost should default to a blank box instead of 0.00 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34095 Katariina Hanhisalo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katariina.hanhisalo at xamk.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:13:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:13:16 +0000 Subject: [Koha-bugs] [Bug 22221] Changing an item to a Lost Status on an item level hold does not change the hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22221 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master CC| |emily.lamancusa at montgomeryc | |ountymd.gov See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20844 --- Comment #3 from Emily Lamancusa --- This bug is mostly a duplicate of bug 20844, which would handle both item-level holds, and bib-level holds that already have a specific item allocated to them. But I agree with Agnes that it would be helpful to handle unallocated bib-level holds when the last/only item on the bib is marked missing, too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:13:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:13:16 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22221 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:15:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:15:19 +0000 Subject: [Koha-bugs] [Bug 33664] Add ability to cancel order lines in closed baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33664 Katariina Hanhisalo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katariina.hanhisalo at xamk.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:15:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:15:30 +0000 Subject: [Koha-bugs] [Bug 33200] IndependentBranchesTransfers does not prevent holds from creating transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33200 --- Comment #13 from Hammat wele --- Created attachment 154552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154552&action=edit Bug 33200: (fix) remove SuperLibrarian check from Reserves.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:16:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:16:29 +0000 Subject: [Koha-bugs] [Bug 34515] MARCXML output of OAI-PMH may be badly encoded (UNIMARC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34515 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154354|0 |1 is obsolete| | --- Comment #3 from Biblibre Sandboxes --- Created attachment 154553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154553&action=edit Bug 34515: Fix encoding of MARCXML output for OAI-PMH (UNIMARC) Like fixed for REST API, OAI-PMH output should be fixed to use metadata schema when building MARCXML. Test plan : 1) Use UNIMARC database 2) Enable OAI-PMH webservice 3) Edit a biblio record to add uppercase éin title 200$a 4) Go to OAI record : /cgi-bin/koha/oai.pl?verb=GetRecord&metadataPrefix=marcxml&identifier=xxx => Check encoding of title is OK Signed-off-by: Delaye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:16:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:16:39 +0000 Subject: [Koha-bugs] [Bug 26170] Add protected status for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Create "system" patrons |Add protected status for |that cannot be (easily) |patrons |deleted via the web UI | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:16:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:16:44 +0000 Subject: [Koha-bugs] [Bug 34240] Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 Pascal Uphaus changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154549|0 |1 is obsolete| | --- Comment #2 from Pascal Uphaus --- Created attachment 154554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154554&action=edit Bug 34240: Added hint about having to use Koha-to-MARC mappings for Koha link in frameworks To test: 1. Go to administration > marc bibliographic framework > choose framework > marc structure choose any tag 2. go to actions and edit subfields 3. check that the koha link pulldown can not be edited => There is no hint 4. Apply patch 5. Refresh the page, the select box is replaced by text and there is a hint on how to edit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:17:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:17:13 +0000 Subject: [Koha-bugs] [Bug 34515] MARCXML output of OAI-PMH may be badly encoded (UNIMARC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34515 delaye changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye at biblibre.co | |m Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:19:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:19:15 +0000 Subject: [Koha-bugs] [Bug 33200] IndependentBranchesTransfers does not prevent holds from creating transfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33200 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Hammat wele --- (In reply to Marcel de Rooy from comment #12) > +sub _Removereserve { > + my ( @reserves) = @_; > + if ( C4::Context->preference("IndependentBranchesTransfers") && > !C4::Context->IsSuperLibrarian() && scalar @reserves) { > > The test for superlibrarian is unusual. At first sight it should not be > there. > Please clarify. The test for superlibrarian is made because the IndependentBranchesTransfers syspref is suppose to prevent staff from transfering but not superlibrarians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:19:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:19:41 +0000 Subject: [Koha-bugs] [Bug 34240] Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154554|0 |1 is obsolete| | --- Comment #3 from Biblibre Sandboxes --- Created attachment 154555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154555&action=edit Bug 34240: Added hint about having to use Koha-to-MARC mappings for Koha link in frameworks To test: 1. Go to administration > marc bibliographic framework > choose framework > marc structure choose any tag 2. go to actions and edit subfields 3. check that the koha link pulldown can not be edited => There is no hint 4. Apply patch 5. Refresh the page, the select box is replaced by text and there is a hint on how to edit Signed-off-by: Christina -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:20:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:20:21 +0000 Subject: [Koha-bugs] [Bug 34240] Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 Christina F changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cjf at wmu.se Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:20:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:20:40 +0000 Subject: [Koha-bugs] [Bug 34565] Label mismatch in MARC21 006 and 008 cataloging plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34565 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154547|0 |1 is obsolete| | --- Comment #2 from Biblibre Sandboxes --- Created attachment 154556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154556&action=edit Bug 34565: Label mismatch in MARC21 006 and 008 cataloging plugins This patch modifies the JS which builds the table of options for populating MARC21 fields 006 and 008 when using the cataloging plugin. To test, apply the patch and go to Cataloging -> New record. - Click the plugin trigger link next to the 006 input field (you may need to click the tag to expand it. - In the table of input fields, test that clicking the label, e.g. "Type of material", "00 - Form of material," etc, moves focus to the corresponding form field. - Perform the same test on the plugin-popup for field 008. Signed-off-by: Andrew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:21:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:21:06 +0000 Subject: [Koha-bugs] [Bug 34565] Label mismatch in MARC21 006 and 008 cataloging plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34565 Andrew Auld changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld at ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Auld --- Works beautifully, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:21:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:21:44 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Katariina Hanhisalo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katariina.hanhisalo at xamk.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:26:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:26:43 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 --- Comment #51 from Martin Renvoize --- I love the follow-up, thanks for that Owen. Thanks for the testing Caroline, really happy to see this one start moving forward again.. David will be pleased too :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:27:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:27:13 +0000 Subject: [Koha-bugs] [Bug 34266] Item type should not default to biblio itemtype if it's not a valid itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34266 delaye changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:27:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:27:54 +0000 Subject: [Koha-bugs] [Bug 23548] AQ field required in checkin response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23548 --- Comment #13 from Matthias Meusburger --- Created attachment 154557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154557&action=edit Bug 23548: Unit test - Set AQ to empty when item not exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:28:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:28:51 +0000 Subject: [Koha-bugs] [Bug 33920] Improve translation of title tags: Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33920 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154511|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 154558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154558&action=edit Bug 33920: Improve translation of title tags: Patrons This patch updates patron module templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following patron-related pages have the correct title tags: - Patrons home page - Patron search -> - Select two patrons -> Merge selected - Add patron -> - Add a patron with the same name and email address -> - Click "View existing record" in "Duplicate patron record?" dialog. - Patron details - Manage API keys (must have RESTOAuth2ClientCredentials enabled) - Accounting - Transactions - Print fee receipt - Print invoice - Make a payment - Create manual invoice - Create manual credit - Routing lists (must have RoutingSerials enabled) - Circulation history - Notices - Statistics - Files (must have EnableBorrowerFiles enabled) - Purchase suggestions - Discharges (must have useDischarge enabled) - Housebound (must have HouseboundModule enabled) - ILL requests history (must have ILLModule enabled) - Set permissions - Change password - Print summary - Print account balance - Two-factor authentication (must have TwoFactorAuthentication enabled) - Edit patron - Update child to adult patron: - Must have more than one "adult" type category defined - Locate a patron with a "child" type category - Choose More -> Update child to adult patron - Delete patron (confirmation page) - Pending discharge requests - Patrons requesting modifications Signed-off-by: Caroline Cyr La Rose Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:29:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:29:24 +0000 Subject: [Koha-bugs] [Bug 33920] Improve translation of title tags: Patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33920 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize --- Great improvement, well worthwhile! Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:29:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:29:26 +0000 Subject: [Koha-bugs] [Bug 23548] AQ field required in checkin response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23548 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com Status|Failed QA |Signed Off --- Comment #14 from Matthias Meusburger --- Hello! I've added a unit test for this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:30:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:30:04 +0000 Subject: [Koha-bugs] [Bug 34553] Update send list and send cart popup footers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34553 Andrew Auld changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld at ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Auld --- Tested on the Biblibre Sandbox 17/08/2023 Works beautifully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:32:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:32:07 +0000 Subject: [Koha-bugs] [Bug 34240] Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Sorry, QA script failed, missing TT filter! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:37:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:37:54 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154456|0 |1 is obsolete| | --- Comment #27 from Biblibre Sandboxes --- Created attachment 154559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154559&action=edit Bug 10762: Change the size of barcodes in label creator Test plan: 1)Home > Tools > Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.04), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass Signed-off-by: Johanna Miettunen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:37:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:37:57 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154457|0 |1 is obsolete| | --- Comment #28 from Biblibre Sandboxes --- Created attachment 154560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154560&action=edit Bug 10762: (follow-up) Update test plan, add kohastructure.sql files I also change the default value for scale_height to '0.01' Test plan: 1)Home > Cataloguing > Tools: Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.02), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger Signed-off-by: Lucas Gass Signed-off-by: Johanna Miettunen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:38:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:38:01 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154458|0 |1 is obsolete| | --- Comment #29 from Biblibre Sandboxes --- Created attachment 154561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154561&action=edit Bug 10762: (follow-up) Add exec right on atomic update file https://bugs.koha-community.org/show_bug.cgi?id=17062 Signed-off-by: Lucas Gass Signed-off-by: Johanna Miettunen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:38:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:38:04 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154459|0 |1 is obsolete| | --- Comment #30 from Biblibre Sandboxes --- Created attachment 154562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154562&action=edit Bug 10762: (follow-up) Add tests Signed-off-by: Johanna Miettunen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:38:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:38:45 +0000 Subject: [Koha-bugs] [Bug 31846] Add syspref for serials search results limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141999|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes --- Created attachment 154563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154563&action=edit Bug 31846: Add syspref for serials search results limit To test: 1) Make sure SerialsSearchResultsLimit syspref is unset or set to 0. 2) Perform an advanced search on serials without any conditions and confirm all serials are listed as expected. 3) Set SerialsSearchResultsLimit to a value less the the number of total subscriptions, perform the search again, and confirm that the number of serials has been limited to the set value. 4) Ensure all tests pass in t/db_dependent/Serials.t Sponsored-by: Gothenburg University Library Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:39:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:39:01 +0000 Subject: [Koha-bugs] [Bug 34240] Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 Pascal Uphaus changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:39:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:39:04 +0000 Subject: [Koha-bugs] [Bug 34240] Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 Pascal Uphaus changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154555|0 |1 is obsolete| | --- Comment #5 from Pascal Uphaus --- Created attachment 154564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154564&action=edit Bug 34240: Added hint about having to use Koha-to-MARC mappings for Koha link in frameworks To test: 1. Go to administration > marc bibliographic framework > choose framework > marc structure choose any tag 2. go to actions and edit subfields 3. check that the koha link pulldown can not be edited => There is no hint 4. Apply patch 5. Refresh the page, the select box is replaced by text and there is a hint on how to edit Signed-off-by: Christina Fairlamb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:40:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:40:00 +0000 Subject: [Koha-bugs] [Bug 34240] Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 Pascal Uphaus changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:40:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:40:41 +0000 Subject: [Koha-bugs] [Bug 34530] CollapseFieldsPatronAddForm - Needs ADD vs. EDIT component In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34530 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:40:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:40:46 +0000 Subject: [Koha-bugs] [Bug 34240] Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:40:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:40:49 +0000 Subject: [Koha-bugs] [Bug 34240] Add hint about having to use Koha-to-MARC mappings for Koha link in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34240 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154564|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 154565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154565&action=edit Bug 34240: Added hint about having to use Koha-to-MARC mappings for Koha link in frameworks To test: 1. Go to administration > marc bibliographic framework > choose framework > marc structure choose any tag 2. go to actions and edit subfields 3. check that the koha link pulldown can not be edited => There is no hint 4. Apply patch 5. Refresh the page, the select box is replaced by text and there is a hint on how to edit Signed-off-by: Christina Fairlamb Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:41:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:41:30 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Johanna Miettunen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.miettunen at haaga-hel | |ia.fi --- Comment #31 from Johanna Miettunen --- Worked as designed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:42:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:42:40 +0000 Subject: [Koha-bugs] [Bug 34566] New: Update MARC21 cataloging plugins with consistent footers Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34566 Bug ID: 34566 Summary: Update MARC21 cataloging plugins with consistent footers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 34343 I propose to update these MARC21 cataloging plugin pages to use consistent styling for pop-up window footers: - EXAMPLE.tt (as an example) - marc21_field_006.tt - marc21_field_007.tt - marc21_field_008.tt - marc21_field_008_authorities.tt - marc21_field_008_classifications.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 [Bug 34343] Z39.50 search background not updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:42:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:42:40 +0000 Subject: [Koha-bugs] [Bug 34343] Z39.50 search background not updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34566 [Bug 34566] Update MARC21 cataloging plugins with consistent footers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:48:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:48:40 +0000 Subject: [Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Whilst the functionality here works nicely, I'm not sure about the styling myself. I think I'd either prefer a 'Switch to X editor' button that contextually sets 'X' or an 'Advanced editor: TOGGLE' with a narrower simple toggle switch rather than the large toggle the includes the text within it. Tagging Owen for that more artistic eye ;P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:48:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:48:49 +0000 Subject: [Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:49:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:49:40 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:49:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:49:43 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Paul Derscheid changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151427|0 |1 is obsolete| | --- Comment #19 from Paul Derscheid --- Created attachment 154566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154566&action=edit Bug 33766: Fix ambiguous "Login" field This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set to the following values - Cardnumber - Username - Cardnumber or Username To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:50:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:50:57 +0000 Subject: [Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Johanna Miettunen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #32 from Johanna Miettunen --- Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:57:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:57:09 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #20 from Paul Derscheid --- Just noticed that this is not translatable in this way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:59:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:59:50 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 14:59:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 12:59:53 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154566|0 |1 is obsolete| | --- Comment #21 from Matt Blenkinsop --- Created attachment 154567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154567&action=edit Bug 33766: Fix ambiguous "Login" field This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set to the following values - Cardnumber - Username - Cardnumber or Username To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:00:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:00:42 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #22 from Matt Blenkinsop --- Didn't see your comment before SO! Changing back to NSO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:04:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:04:11 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Andrew Auld changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld at ptfs-europe.com --- Comment #8 from Andrew Auld --- Something broke when I applied the patch on the sandbox and went back to Patron Attributes in admin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:04:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:04:25 +0000 Subject: [Koha-bugs] [Bug 34567] New: Correct colors for advanced cataloging editor status bar Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34567 Bug ID: 34567 Summary: Correct colors for advanced cataloging editor status bar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The "status bar" at the bottom of the advanced cataloging editor still uses colors from our old color scheme. The CSS should be updated to match the staff interface redesign. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:08:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:08:06 +0000 Subject: [Koha-bugs] [Bug 34364] Background job - Fix visual progress of progress bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34364 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov QA Contact|testopia at bugs.koha-communit |emily.lamancusa at montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA Severity|enhancement |minor --- Comment #3 from Emily Lamancusa --- Small patch, looks good, QA tool happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:10:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:10:11 +0000 Subject: [Koha-bugs] [Bug 34193] Default HTTPS template has outdated SSLProtocol value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152994|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 154568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154568&action=edit Bug 34193: SSLProtocol enable in use versions and disable deprecated versions This patch changes the default SSLProtocol for the Let's Encrypt HTTPS template, so that it enables in use versions of TLS while disabling the deprecated versions of TLS. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:10:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:10:23 +0000 Subject: [Koha-bugs] [Bug 34567] Correct colors for advanced cataloging editor status bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34567 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:10:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:10:26 +0000 Subject: [Koha-bugs] [Bug 34567] Correct colors for advanced cataloging editor status bar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34567 --- Comment #1 from Owen Leonard --- Created attachment 154569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154569&action=edit Bug 34567: Correct colors for advanced cataloging editor status bar This patch updates the advanced cataloging editor CSS so that the "status bar" footer below the editor has colors consistent with the staff interface redesign. To test, apply the patch and clear your browser cache if necessary. - Enable the EnableAdvancedCatalogingEditor preference if necessary. - Go to Cataloging -> Advanced editor. - At the bottom of the screen below the editor the "status bar" should have a green border that matches color in the header search bar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:10:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:10:38 +0000 Subject: [Koha-bugs] [Bug 34193] Default HTTPS template has outdated SSLProtocol value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Confirmed this is the right thing to do.. all working as expected.. Going straight for PQA here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:10:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:10:43 +0000 Subject: [Koha-bugs] [Bug 34193] Default HTTPS template has outdated SSLProtocol value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:10:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:10:46 +0000 Subject: [Koha-bugs] [Bug 34193] Default HTTPS template has outdated SSLProtocol value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34193 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:32:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:32:42 +0000 Subject: [Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:33:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:33:24 +0000 Subject: [Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:56:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:56:13 +0000 Subject: [Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 15:56:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 13:56:33 +0000 Subject: [Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 16:11:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 14:11:10 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #33 from Thomas Klausner --- FYI, I have another approach nearly finished, where instead of creating a new daemon and using inotify we start the Plack app via plackup (instead of just usnig starman) and use the -R flag to reload when something changed. This is the common way to do is in Plack apps, and does not need another service. The patch will be ready tomorrow at the latest (side note: Not sure if you want the patch in this ticket or in a new one?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 16:44:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 14:44:16 +0000 Subject: [Koha-bugs] [Bug 34028] Two factor authentication (2FA) shows the wrong values for manual entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 --- Comment #13 from Pedro Amorim --- @Frido can you please take a look at the follow-up for 23.05.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 17:00:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 15:00:31 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #23 from Paul Derscheid --- Created attachment 154570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154570&action=edit Bug 33766: (follow-up) Fix ambiguous "Login" field This follow-up fixes some problems w/ the unconventional parts of the first commit. We now use conditionals in a BLOCK to map the selected value from the preference to string representations which should now be easily translatable. To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 17:35:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 15:35:03 +0000 Subject: [Koha-bugs] [Bug 34178] Add caching of ItemsAnyAvailableAndNotRestricted to IsAvailableForItemLevelRequest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34178 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #12 from Pedro Amorim --- Does not apply for 22.11.x because bug 30860 and bug 31735 have not been pushed, maybe others. Not pushing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 17:35:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 15:35:04 +0000 Subject: [Koha-bugs] [Bug 33746] [omnibus] speed improvement In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 Bug 33746 depends on bug 34178, which changed state. Bug 34178 Summary: Add caching of ItemsAnyAvailableAndNotRestricted to IsAvailableForItemLevelRequest https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34178 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 18:05:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 16:05:42 +0000 Subject: [Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.03 |23.11.00,23.05.03,22.11.09 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 18:05:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 16:05:44 +0000 Subject: [Koha-bugs] [Bug 33028] Wrongly formatted monetary amounts in circulation rules break scripts and calculations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33028 --- Comment #107 from Pedro Amorim --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 18:05:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 16:05:47 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02,22.11.08 |23.11.00,23.05.02,22.11.09, released in| |22.11.08 Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 18:05:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 16:05:49 +0000 Subject: [Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117 --- Comment #66 from Pedro Amorim --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 18:05:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 16:05:52 +0000 Subject: [Koha-bugs] [Bug 34181] Batch patron modification tool missing checkboxes to clear field values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.09 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 18:05:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 16:05:54 +0000 Subject: [Koha-bugs] [Bug 34181] Batch patron modification tool missing checkboxes to clear field values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34181 --- Comment #13 from Pedro Amorim --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 18:05:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 16:05:56 +0000 Subject: [Koha-bugs] [Bug 34337] Web installer doesn't install patrons when select all is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34337 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 18:05:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 16:05:58 +0000 Subject: [Koha-bugs] [Bug 34337] Web installer doesn't install patrons when select all is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34337 --- Comment #6 from Pedro Amorim --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 19:01:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 17:01:49 +0000 Subject: [Koha-bugs] [Bug 31846] Add syspref for serials search results limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31846 --- Comment #8 from David Nind --- Hi Kelly. Since you've signed it off, you should change the status in Bugzilla to 'Signed Off'. That way you will get the credit in the dashboard! David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 19:18:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 17:18:05 +0000 Subject: [Koha-bugs] [Bug 34356] Enabling RecordStaffUserOnCheckout causes bad default sorting in checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34356 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 19:27:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 17:27:08 +0000 Subject: [Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #27 from David Nind --- Hi Christian. Since you've signed off the bug, you should change the status in Bugzilla to 'Signed Off'. That way you will get the credit in the dashboard! (https://dashboard.koha-community.org/) David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 19:27:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 17:27:15 +0000 Subject: [Koha-bugs] [Bug 34356] Enabling RecordStaffUserOnCheckout causes bad default sorting in checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34356 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 19:27:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 17:27:18 +0000 Subject: [Koha-bugs] [Bug 34356] Enabling RecordStaffUserOnCheckout causes bad default sorting in checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34356 --- Comment #1 from Lucas Gass --- Created attachment 154571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154571&action=edit Bug 34356: Make sort order always default to correct column To test: 1- Check out an item to a patron 2- View checkout history, default sort is on 'Date due' 3- Enable RecordStaffUserOnCheckout 4- View checkout history, default sort is on 'Checked out by' 5- Apply patch 6- Table should sort to 'Date due' no matter what the sys pref is set to -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 19:27:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 17:27:33 +0000 Subject: [Koha-bugs] [Bug 34356] Enabling RecordStaffUserOnCheckout causes bad default sorting in checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34356 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 20:41:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 18:41:45 +0000 Subject: [Koha-bugs] [Bug 34387] API docs tags missing descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34387 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #22 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 20:44:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 18:44:14 +0000 Subject: [Koha-bugs] [Bug 34059] advance_notices.pl -c --digest-per-branch does not work as intended In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34059 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 20:50:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 18:50:14 +0000 Subject: [Koha-bugs] [Bug 30451] Delete a subscription deletes the linked order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30451 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #12 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 20:52:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 18:52:10 +0000 Subject: [Koha-bugs] [Bug 34452] Button 'Update adjustments' is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 20:56:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 18:56:32 +0000 Subject: [Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #19 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 20:57:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 18:57:22 +0000 Subject: [Koha-bugs] [Bug 34269] Regression in circulation rules for 'similar' patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34269 --- Comment #20 from Fridolin Somers --- Lets hope this does not appear in translation files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 20:59:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 18:59:07 +0000 Subject: [Koha-bugs] [Bug 34155] OPAC item level holds "force" option broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #10 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:07:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:07:36 +0000 Subject: [Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #23 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:17:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:17:58 +0000 Subject: [Koha-bugs] [Bug 34470] Real Time Holds Queue - make random numbers play nice with forked processes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34470 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:22:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:22:51 +0000 Subject: [Koha-bugs] [Bug 33909] Improve translation of title tags: Administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33909 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #17 from Fridolin Somers --- I propose to not backport to stable to avoid to much translation work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:24:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:24:11 +0000 Subject: [Koha-bugs] [Bug 34365] Hold cancellation request workflow cannot be triggered on API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34365 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:27:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:27:46 +0000 Subject: [Koha-bugs] [Bug 34056] authorised-values API client file is missing -api-client suffix In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34056 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:30:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:30:24 +0000 Subject: [Koha-bugs] [Bug 34494] Table tmp_holdsqueue fails to be created for MySQL 8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34494 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin Somers --- Depends on Bug 28966 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:31:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:31:59 +0000 Subject: [Koha-bugs] [Bug 34359] Get rid of Koha/BiblioUtils/Iterator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- I propose not to backport to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:32:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:32:41 +0000 Subject: [Koha-bugs] [Bug 34357] Subroutine Koha::ItemType::SUPER::imageurl redefined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34357 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Depends on Bug 33745 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:33:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:33:50 +0000 Subject: [Koha-bugs] [Bug 34108] When items are added on order, item selection gets lost on editing items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34108 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #13 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:35:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:35:55 +0000 Subject: [Koha-bugs] [Bug 34356] Enabling RecordStaffUserOnCheckout causes bad default sorting in checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34356 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154571|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 154572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154572&action=edit Bug 34356: Make sort order always default to correct column To test: 1- Check out an item to a patron 2- View checkout history, default sort is on 'Date due' 3- Enable RecordStaffUserOnCheckout 4- View checkout history, default sort is on 'Checked out by' 5- Apply patch 6- Table should sort to 'Date due' no matter what the sys pref is set to Signed-off-by: Jason -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:36:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:36:40 +0000 Subject: [Koha-bugs] [Bug 34356] Enabling RecordStaffUserOnCheckout causes bad default sorting in checkout history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34356 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Jason Robb --- Fix worked for me, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:38:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:38:39 +0000 Subject: [Koha-bugs] [Bug 13259] Set notforloan status when adding items to a course reserve In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13259 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine at collecto.ca --- Comment #3 from Noémie Labine --- +1 It would be useful to be able to change the not for loan status as we can change the location, homebranch, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:42:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:42:50 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #18 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:48:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:48:34 +0000 Subject: [Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154385|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 154573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154573&action=edit Bug 26916: Show searchable patron attributes in patron search dropdown This patch adds attributes that have been marked searchable to the patron search dropdowns To test: 1 - Define some new patron attribute types and make then staff_searchable 2 - Add some values to patrons 3 - Confirm they are searched in 'Standard' search, but there is no other way to search them 4 - Apply patch 5 - Confirm the fields now show in patorn search dropdowns 6 - Search using 'standard' and confirm the searhc works 7 - Search specific attributes and confirm the searhc works Current depends: 17374 34519 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:48:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:48:37 +0000 Subject: [Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154386|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 154574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154574&action=edit Bug 26916: Adjust unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:49:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:49:11 +0000 Subject: [Koha-bugs] [Bug 34289] UI issue on checkin page when checking the forgive fines checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34289 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Since we have now : [% IF ( exemptfine ) %] [% ELSIF ( dropboxmode ) %] [% ELSE %] There is no difference between those two lines since type="text" is default behavior. Maybe merge into [% IF ( exemptfine || dropboxmode ) %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:49:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:49:20 +0000 Subject: [Koha-bugs] [Bug 34568] New: Add ability to undo an import in ERM Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34568 Bug ID: 34568 Summary: Add ability to undo an import in ERM Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha at gmail.com Reporter: esther.melander at bywatersolutions.com CC: jonathan.druart+koha at gmail.com, jonathan.field at ptfs-europe.com, martin.renvoize at ptfs-europe.com, matt.blenkinsop at ptfs-europe.com, pedro.amorim at ptfs-europe.com The ERM module currently has the ability to import a package list/records locally. Once those records are in the system, it is very difficult to pull them back out. It would be nice to have an undo import similar to what is found in Managing Staged Records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:49:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:49:31 +0000 Subject: [Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:49:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:49:31 +0000 Subject: [Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 [Bug 26916] Show searchable patron attributes in patron search dropdown -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:49:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:49:52 +0000 Subject: [Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 [Bug 33428] Should only search in searchable patron attributes if searching in standard fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:49:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:49:52 +0000 Subject: [Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:50:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:50:22 +0000 Subject: [Koha-bugs] [Bug 34493] Bad indenting in search_indexes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34493 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:50:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:50:22 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|34519 |26916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 [Bug 26916] Show searchable patron attributes in patron search dropdown https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:50:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:50:22 +0000 Subject: [Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34517 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 [Bug 34517] Add option to search patron attribute in standard search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:50:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:50:22 +0000 Subject: [Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|34517 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 [Bug 34517] Add option to search patron attribute in standard search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:51:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:51:52 +0000 Subject: [Koha-bugs] [Bug 34292] Date formatting in checkouts list broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |33804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 [Bug 33804] Implement as_due_date for $date (js-date-format) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:51:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:51:52 +0000 Subject: [Koha-bugs] [Bug 33804] Implement as_due_date for $date (js-date-format) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34292 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292 [Bug 34292] Date formatting in checkouts list broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:52:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:52:07 +0000 Subject: [Koha-bugs] [Bug 34292] Date formatting in checkouts list broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34292 --- Comment #13 from Fridolin Somers --- Depends on Bug 33804 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:55:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:55:27 +0000 Subject: [Koha-bugs] [Bug 34322] Correct icon triggering more fund search options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |32910 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 [Bug 32910] Upgrade fontawesome icons to V6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:55:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:55:27 +0000 Subject: [Koha-bugs] [Bug 32910] Upgrade fontawesome icons to V6 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32910 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34322 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 [Bug 34322] Correct icon triggering more fund search options -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:55:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:55:57 +0000 Subject: [Koha-bugs] [Bug 34322] Correct icon triggering more fund search options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 --- Comment #5 from Fridolin Somers --- Depends on Bug 32910 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:57:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:57:16 +0000 Subject: [Koha-bugs] [Bug 34354] Job progress typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34354 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #5 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 21:57:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 19:57:50 +0000 Subject: [Koha-bugs] [Bug 34354] Job progress typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34354 --- Comment #6 from Fridolin Somers --- Nice wok ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:03:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:03:35 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:03:38 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154389|0 |1 is obsolete| | Attachment #154390|0 |1 is obsolete| | Attachment #154391|0 |1 is obsolete| | Attachment #154392|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 154575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154575&action=edit Bug 34517: DB updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:03:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:03:41 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #10 from Nick Clemens --- Created attachment 154576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154576&action=edit Bug 34517: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:03:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:03:44 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #11 from Nick Clemens --- Created attachment 154577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154577&action=edit Bug 34517: Add boolean to search columns for schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:03:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:03:47 +0000 Subject: [Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #12 from Nick Clemens --- Created attachment 154578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154578&action=edit Bug 34517: Add option search patron attributes by default This patch moves form any staff_searchable attribute being automatically included in the the Standard patron serch, to allowing the librarian to choose. Current searchable attributes will be marked as 'searched_by_default' To test: 1 - Add a searchable patron attribute type 2 - Add some values 3 - Confirm they are searched in a 'Standard' patron search 4 - Apply patch 5 - Go to admin - >patron attribute types 6 - Note new 'Searching' column 7 - Confirm attribute is 'Searched by default' 8 - Confirm searches work as before 9 - Edit the attribute type 10 - Uncheck 'searched_by_default' 11 - Save 12 - Confirm attribute not searched in 'Standard' search 13 - Select the attribute in patron search dropdowns 14 - Confirm it is correctly searched -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:06:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:06:58 +0000 Subject: [Koha-bugs] [Bug 34197] Group and label vendor contact settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34197 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:09:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:09:01 +0000 Subject: [Koha-bugs] [Bug 33755] Profile used is not saved when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33755 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | CC| |fridolin.somers at biblibre.co | |m Patch complexity|--- |Trivial patch --- Comment #10 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:11:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:11:03 +0000 Subject: [Koha-bugs] [Bug 33848] Enabling Coce in the OPAC breaks cover images on bibliographic detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33848 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:12:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:12:03 +0000 Subject: [Koha-bugs] [Bug 34344] Make item types breadcrumbs uniform In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34344 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:14:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:14:24 +0000 Subject: [Koha-bugs] [Bug 34435] get_password_expiry_date should not modify its parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34435 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #9 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:15:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:15:56 +0000 Subject: [Koha-bugs] [Bug 34447] "Actions" columns are exported In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34447 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Bue pushed to 23.05.x for 23.05.03 ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:17:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:17:48 +0000 Subject: [Koha-bugs] [Bug 34305] If actual cost is negative, wrong price will display in the acq details tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34305 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:18:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:18:21 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Teresa Rice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |trice at bossierlibrary.org --- Comment #93 from Teresa Rice --- We are experiencing this issue as well. We have a check out limit set to 40. Some of our card types are not permitted to check out that many items. However, if they check out items from our different locations they can exceed the check out limit without a system warning. We would like an admin feature where we can group all our locations as a system wide. Our ILS used to be TLC and this was an issue there as well until a few years ago they applied a setting the counted all locations as one and did not let a patron type that is only able to check out 10 items to exceed that rule. It was actually handy with item types. Because we had set it so that patrons could only check out 5 DVDs, but they could check out more than 5 if they were from different home locations. After the fix, the system would let the staff know if the check out limit was exceeded regardless of the home location of the item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:19:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:19:55 +0000 Subject: [Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:20:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:20:40 +0000 Subject: [Koha-bugs] [Bug 31667] Merge 'tip' and 'hint' classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31667 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.03 released in| | --- Comment #9 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:23:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:23:35 +0000 Subject: [Koha-bugs] [Bug 34343] Z39.50 search background not updated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34343 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:25:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:25:09 +0000 Subject: [Koha-bugs] [Bug 34351] ILL list table - access_url column content should be clickable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34351 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:29:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:29:09 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforloan values as unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:30:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:30:32 +0000 Subject: [Koha-bugs] [Bug 34532] Silence warns in Patroncard.pm when layout values are empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34532 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:31:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:31:58 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforloan values as unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #21 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:32:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:32:16 +0000 Subject: [Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforloan values as unavailable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846 --- Comment #22 from Fridolin Somers --- This behavior change needs a good release note -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:38:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:38:13 +0000 Subject: [Koha-bugs] [Bug 34569] New: misc/cronjobs/holds/holds_reminder.pl problem with trigger arg Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34569 Bug ID: 34569 Summary: misc/cronjobs/holds/holds_reminder.pl problem with trigger arg Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz misc/cronjobs/holds/holds_reminder.pl help says one can use arge -t for --triggered But not implemented in code. Should be like in misc/cronjobs/overdue_notices.pl : 't|triggered' => \$triggered, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:39:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:39:08 +0000 Subject: [Koha-bugs] [Bug 34569] misc/cronjobs/holds/holds_reminder.pl problem with trigger arg In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34569 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:43:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:43:54 +0000 Subject: [Koha-bugs] [Bug 34569] misc/cronjobs/holds/holds_reminder.pl problem with trigger arg In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34569 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:43:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:43:56 +0000 Subject: [Koha-bugs] [Bug 34569] misc/cronjobs/holds/holds_reminder.pl problem with trigger arg In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34569 --- Comment #1 from Fridolin Somers --- Created attachment 154579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154579&action=edit Bug 34569: Fix misc/cronjobs/holds/holds_reminder.pl trigger arg misc/cronjobs/holds/holds_reminder.pl help says one can use arge -t for --triggered But not implemented in code. Should be like in misc/cronjobs/overdue_notices.pl : 't|triggered' => \$triggered, Test plan : Play with misc/cronjobs/holds/holds_reminder.pl with arg -t and --trigger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:47:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:47:54 +0000 Subject: [Koha-bugs] [Bug 34514] opac-showmarc.pl does not handle UNIMARC well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 --- Comment #5 from Fridolin Somers --- We use Ubuntu Focal, maybe Perl MARC::Record is a bit different -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:51:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:51:10 +0000 Subject: [Koha-bugs] [Bug 34514] opac-showmarc.pl does not handle UNIMARC well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34515 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:51:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:51:10 +0000 Subject: [Koha-bugs] [Bug 34515] MARCXML output of OAI-PMH may be badly encoded (UNIMARC) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34515 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34514 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:52:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:52:00 +0000 Subject: [Koha-bugs] [Bug 34514] opac-showmarc.pl does not handle UNIMARC well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 --- Comment #6 from Fridolin Somers --- Bug 32336 did this same change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:52:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:52:12 +0000 Subject: [Koha-bugs] [Bug 34514] opac-showmarc.pl does not handle UNIMARC well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34514 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:54:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:54:14 +0000 Subject: [Koha-bugs] [Bug 34028] Two factor authentication (2FA) shows the wrong values for manual entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34028 --- Comment #14 from Fridolin Somers --- (In reply to Pedro Amorim from comment #13) > @Frido can you please take a look at the follow-up for 23.05.x? Followup pushed to 23.05.x for 23.05.03 : Bug 34028: Show the secret when registering from the auth screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Aug 17 22:57:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 20:57:03 +0000 Subject: [Koha-bugs] [Bug 28688] Automatically renew patron membership In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #12 from Lucas Gass --- This works and see the contens of the MEMBERSHIP_RENEWED notice in the command line output. However I don't see the MEMBERSHIP_RENEWED notice in the message_queue. Ive tried with the default notice MEMEBERSHIP_RENEWED ( /misc/cronjobs/membership_expiry.pl -c -n -v -letter_renew MEMBERSHIP_RENEWED -renew ) and with a custom notice called X ( /misc/cronjobs/membership_expiry.pl -c -n -v -letter_renew X -renew ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 18 01:51:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 23:51:50 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #34 from David Cook --- (In reply to Thomas Klausner from comment #33) > FYI, I have another approach nearly finished, where instead of creating a > new daemon and using inotify we start the Plack app via plackup (instead of > just usnig starman) and use the -R flag to reload when something changed. > > This is the common way to do is in Plack apps, and does not need another > service. I use plackup (without -R) for a different Plack app of mine, and I find it doesn't work very well. Maybe it's how I'm using it or some middleware I'm using, but it tends to be slow and seems to hang on some requests until I send another request. But it's worth a try. > The patch will be ready tomorrow at the latest > > (side note: Not sure if you want the patch in this ticket or in a new one?) I think you could attach it here and just mark it as [Alternate] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 18 01:53:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 23:53:45 +0000 Subject: [Koha-bugs] [Bug 31729] Enable automatic filesystem refresh in Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #35 from David Cook --- Just reiterating that it would be great to have this be "optional", since I wouldn't want to use it. Definitely not in prod, and not even in koha-testing-docker. I prefer to manually restart my Plack processes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 18 01:58:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Aug 2023 23:58:04 +0000 Subject: [Koha-bugs] [Bug 34193] Default HTTPS template has outdated SSLProtocol value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34193 --- Comment #6 from David Cook --- (In reply to Martin Renvoize from comment #5) > Confirmed this is the right thing to do.. all working as expected.. Going > straight for PQA here. Thanks, Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 18 02:03:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Aug 2023 00:03:49 +0000 Subject: [Koha-bugs] [Bug 28499] Add support for no-UI / administrative plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 --- Comment #9 from David Cook --- (In reply to Kyle M Hall from comment #8) > Perhaps a "--read-only" switch that would add an additional "_ReadOnly" key > to the plugin_data table? That would be easy enough to code a check for. I was thinking adding a key to the plugin_data table was the way to go as well. The only thing about the "--read-only" switch is "/usr/share/koha/bin/devel/install_plugins.pl" can install 0+ plugins, so it's not 100% clear which plugins it will affect ahead of running it. I was thinking about keeping a configurable list of plugin names but then that seems cumbersome... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 18 02:05:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Aug 2023 00:05:24 +0000 Subject: [Koha-bugs] [Bug 28499] Add support for no-UI / administrative plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 --- Comment #10 from David Cook --- I did have another thought... What about adding a method to Koha::Plugins::Base, and then invoking it on a per-plugin basis using bug 34335? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 18 02:42:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Aug 2023 00:42:15 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #15 from David Cook --- For our inline scripts (like OpacUserJS and IntranetUserJS), we could use a nonce. We'd need to generate the nonce and pass it to the $template in C4::Auth::get_template_and_user(). Then we could easily place it into whatever inline script we need. It wouldn't prevent XSS where we've made an error in our inline script, but it would prevent a lot of stored and reflected XSS in other contexts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 18 02:46:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Aug 2023 00:46:41 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #16 from David Cook --- (In reply to David Cook from comment #15) > We'd need to generate the nonce and pass it to the $template in > C4::Auth::get_template_and_user(). But then we also need to get it into C4::Output. Without doing any refactoring, the place to put it is probably in the L1 cache. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Aug 18 02:56:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Aug 2023 00:56:06 +0000 Subject: [Koha-bugs] [Bug 32328] Add ability to specify how long an item stays on a library's holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32328 Michelle Spinney changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 18 03:30:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Aug 2023 01:30:25 +0000 Subject: [Koha-bugs] [Bug 33374] Holds captured at different branch when pickup branch has a copy on shelf can create long wait times for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33374 Michelle Spinney changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Aug 18 03:39:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Aug 2023 01:39:33 +0000 Subject: [Koha-bugs] [Bug 20397] Implement Content Security Policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20397 --- Comment #17 from David Cook --- Created attachment 154580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154580&action=edit Bug 20397: Add default Content-Security-Policy This patch adds a default Content-Security-Policy to Koha, and includes a mechanism for generating a nonce so that our current inline