[Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
Test plan:
0. Apply patch
1. koha-plack --reload kohadev
2. Set
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=NoRenewalBeforePrecision
to "exact time"
3. Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl
4. Set "No renewal before" to 5

5. Go to
http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 and
checkout 39999000001310 
6. Note that you can't renew the item
7. Set
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=NoRenewalBeforePrecision
to "date"
8. Note that you can renew the item

--

Since the due date is at 23:59 5 days from now, it makes sense that we can't
renew until it's 5 days before the due date (which would be tonight at 23:59).

Hmm... but I changed NoRenewalBeforePrecision to "exact time" and Due Date to
"08/06/2023" and it's saying "No renewal before 08/01/2023 13:45" but the time
is "08/01/2023 13:49".

This might be a timezone issue with the ktd... ah yes it is because ktd is
using UTC and it thinks the time is "08/01/2023 03:49"

-- 
You are receiving this mail because:
You are watching all bug changes.