[Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Emily Lamancusa from comment #10)
> Is changing the pickup location on a hold that's in transit truly an
> unhandled situation? 

The code for handling it in the OPAC is defined in:

sub can_update_pickup_location_opac {
    my ($self) = @_;

    my @statuses = split /,/,
C4::Context->preference("OPACAllowUserToChangeBranch");
    foreach my $status ( @statuses ){
        return 1 if ($status eq 'pending' && !$self->is_found &&
!$self->is_suspended );
        return 1 if ($status eq 'intransit' && $self->is_in_transit);
        return 1 if ($status eq 'suspended' && $self->is_suspended);
    }
    return 0;
}

I assume it should be safe to allow in_transit. I just don't know the area
(staff UI-wise) enough to feel confident about enabling. Some thought on the
initial report was needed though, as I found the in processing use case while
digging.

I'm open to change it to allow changing the pickup location for in transit
holds. I just thougth it deserved it's own bug report in which people involved
in the area could weight in.

-- 
You are receiving this mail because:
You are watching all bug changes.