[Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Cook from comment #11)
> (In reply to Katrin Fischer from comment #8)
> > Something is not working quite right there:
> > 
> > * loan period 5 days
> > * no renewal before 5 dates
> > * today is 2023-07-29 and date in ktd also shows me that
> > * message shown: no renewal before 2023-07-29
> > 
> > ... but I can't renew :(
> 
> In fact, with "exact time", that's the norm with master even without this
> patch. 
> 
> Going to move this one back to "Signed Off"

You were right, I was actually not aware of that system preference!

It's still ab it wrong isn't it? Since we don't show the time, the user only
gets this: No renewal before 01.08.2023 (which makes no sense, when that day is
today. Maybe we should show the time or rephrase for 23:59:00 to "after".

But not part of this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.