[Koha-bugs] [Bug 28966] Holds queue viewer too slow to load for large numbers of holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966

Jonathan Druart <jonathan.druart+koha at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #50 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Kyle M Hall from comment #47)
> Created attachment 153929 [details] [review]
> Bug 28966: (QA Follow-up) Fix failing unit tests
> 
> Test Plan:
> 1) prove t/db_dependent/TestBuilder.t
> 2) Note tests fail
> 3) Apply this patch
> 4) Run updatedatabase.pl
> 5) Update the schema files ( alias 'dbic' can be used in
>    koha-testing-docker )
> 6) prove t/db_dependent/TestBuilder.t
> 7) Tests now pass!

This is breaking Koha_Master_My8

12:06:40 koha_1       | DBD::mysql::st execute failed: All parts of a PRIMARY
KEY must be NOT NULL; if you need NULL in a key, use UNIQUE instead at
/usr/share/perl5/DBIx/RunSQL.pm line 279, <$args{...}> line 1.
12:06:40 koha_1       | Something went wrong loading file
/kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE
TABLE `tmp_holdsqueue` (
12:06:40 koha_1       |   `biblionumber` int(11) DEFAULT NULL,
12:06:40 koha_1       |   `itemnumber` int(11) DEFAULT NULL,
12:06:40 koha_1       |   `barcode` varchar(20) DEFAULT NULL,
12:06:40 koha_1       |   `surname` longtext NOT NULL,
12:06:40 koha_1       |   `firstname` mediumtext DEFAULT NULL,
12:06:40 koha_1       |   `phone` mediumtext DEFAULT NULL,
12:06:40 koha_1       |   `borrowernumber` int(11) NOT NULL,
12:06:40 koha_1       |   `cardnumber` varchar(32) DEFAULT NULL,
12:06:40 koha_1       |   `reservedate` date DEFAULT NULL,
12:06:40 koha_1       |   `title` longtext DEFAULT NULL,
12:06:40 koha_1       |   `itemcallnumber` varchar(255) DEFAULT NULL,
12:06:40 koha_1       |   `holdingbranch` varchar(10) DEFAULT NULL,
12:06:40 koha_1       |   `pickbranch` varchar(10) DEFAULT NULL,
12:06:40 koha_1       |   `notes` mediumtext DEFAULT NULL,
12:06:40 koha_1       |   `item_level_request` tinyint(4) NOT NULL DEFAULT 0,
12:06:40 koha_1       |   `timestamp` timestamp NOT NULL DEFAULT
current_timestamp() ON UPDATE current_timestamp() COMMENT 'date and time this
entry as added/last updated',
12:06:40 koha_1       |   PRIMARY KEY (`itemnumber`),
12:06:40 koha_1       |   KEY `tmp_holdsqueue_ibfk_1` (`itemnumber`),
12:06:40 koha_1       |   KEY `tmp_holdsqueue_ibfk_2` (`biblionumber`),
12:06:40 koha_1       |   KEY `tmp_holdsqueue_ibfk_3` (`borrowernumber`),
12:06:40 koha_1       |   CONSTRAINT `tmp_holdsqueue_ibfk_1` FOREIGN KEY
(`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE ON UPDATE
CASCADE,
12:06:40 koha_1       |   CONSTRAINT `tmp_holdsqueue_ibfk_2` FOREIGN KEY
(`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON
UPDATE CASCADE,
12:06:40 koha_1       |   CONSTRAINT `tmp_holdsqueue_ibfk_3` FOREIGN KEY
(`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE
ON UPDATE CASCADE
12:06:40 koha_1       | ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4
COLLATE=utf8mb4_unicode_ci
12:06:40 koha_1       | ) at /kohadevbox/koha/C4/Installer.pm line 585.


https://jenkins.koha-community.org/job/Koha_Master_My8/1236/console

-- 
You are receiving this mail because:
You are watching all bug changes.