[Koha-bugs] [Bug 34109] When adding items on receive, mandatory fields are not checked

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34109

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 154280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154280&action=edit
Bug 34109: Check mandatory item fields when creating during recipt

This patch adds a check of mandatory item fields before saving during order
receipt.
We check both when adding the item initially, and when submitting the order, as
it will use
the values from the open form.

To test:
* Go to administration > frameworks > ACQ > MARC structure > 952
* Set callnumber (o) or barcode (p) to mandatory
* In acquisition:
* Create a basket with "create items on order" and "is standing"
  "standing" helps as you can do multiple receives testing different things,
  but is optional
* Add an order line
* Receive shipment
* Verify the mandatory fields show in the item form
* Set itemtype = Music
* Save with the fields blank
* Item row is added, no warning
* Edit the item, change the item type to blank
* Click 'Confirm' for the order without closing the item edit form
* Verify the item was added with itemtype Books (on sample data) and empty
mandatory field
* Apply patch
* Repeat above, however, you should not be able to submit the item or order
until mandatory fields are filled

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.