[Koha-bugs] [Bug 34495] New: AutomaticConfirmTransfer does not confirm if the check-in form is resubmitted

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34495

            Bug ID: 34495
           Summary: AutomaticConfirmTransfer does not confirm if the
                    check-in form is resubmitted
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: emily.lamancusa at montgomerycountymd.gov
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 33300

Bug 29792 added a new system preference, AutomaticConfirmTransfer, to control
the behavior of a transfer when the user clicked away from the "Wrong Transfer"
modal without selecting anything. (assuming TransfersBlockCirc is set to "Don't
block")

With the syspref set to automatically confirm, it works as intended if the user
literally clicks away from the modal using the mouse. However, if the user
submits the check-in form again without selecting an option on the modal (i.e.
by scanning the next item, or accidentally double-scanning the item initiating
the transfer), then the transfer is not confirmed.

It looks like this is happening because the automatic confirmation is triggered
when the modal is hidden by Bootstrap event. If the check-in form is
resubmitted, it doesn't actively hide the modal before reloading the page, so
the automatic confirmation is not triggered.


To reproduce:
0. Configure sysprefs and circulation rules:
    a. TransfersBlockCirc to Don't block
    b. AutomaticConfirmTransfer to Do
    c. In the circulation rules, set the default return policy to "Item returns
home"
1. Find an item that belongs to a different library and check it in
2. When the transfer modal appears, click away from the modal.
   -> Notice the animation - the modal appears to fade upwards.
3. Query the transfer table
   -> Notice that there is a transfer with values for daterequested and
datesent
4. Check the item in again
5. When the Wrong Transfer modal appears, click away from the modal.
   -> Notice the animation - the modal appears to fade upwards.
6. Query the transfer table
   -> Notice that the previous transfer was canceled, and there is a new
transfer
      with values for daterequested and datesent
7. Repeat steps 1-6, except instead of clicking away from the modals, press
Enter on
   the keyboard instead
   -> Notice that the animation no longer appears - the modals simply disappear
when
      the page is reloaded
   -> Notice that after the Wrong Transfer modal is bypassed like this, the
transfer
      table shows that the previous transfer was canceled, and there is a new
      transfer with a value for daterequested but no value for datesent


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33300
[Bug 33300] Wrong system preference name AutomaticWrongTransfer
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.