[Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 154331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154331&action=edit
Bug 33554: [WIP] Add a new lookup endpoint for patron searching

This patch adds a new API lookup optoin for patrons. This endpoint takes
three params:
search_type - contains or starts with
search_term - the string passed to search
search_field - a comma separated string of fields to search

The patron-search code is altered to pass these additional params, and the
datatables
code is updated to pass these params through

The lookup code parses the attributes search directly, then adds it as a
subquery to the
results

This should only affect patron/checkout searches - other patron searches are
not changed at this time

NOTE: In testing I noted that a search for a patron field plus an attribute
returns nothing, but
this is the same as existing code.
i.e. patron Kenneth ABRAMS with SCHOOL attribute 'Oxford' is not returned for
'ken oxf' search

WIP:
Needs test coverage

TO test:
1 - Add the sample borrowers and attributes to your DB
2 - Perform some patron searches 'ken' 'ken abr' 'oxford' 'ken oxford'
3 - Note the response times, most are slow
4 - Apply patch, restart all
5 - Repeat searches
6 - Note faster response times, but same results

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.