[Koha-bugs] [Bug 30846] "If any unavailable" doesn't consider negative notforloan values as unavailable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30846

Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #17 from Emily Lamancusa <emily.lamancusa at montgomerycountymd.gov> ---
The patch itself looks good and passes the qa script, but the unit doesn't
quite test what it's supposed to. Please make the following adjustments to the
test:

 - This bug addresses the use case where an item has a negative notforloan
value 
   *and* the circulation rule for on-shelf holds is set to "if any
unavailable",
   so that circ rule should be set before running the test. As written, the
test
   passes even without the patch because it's using the default setting of
"yes".
   Please add code to set the circ rule to "if any unavailable" for the test
   (if needed, see t/db_dependent/Koha/CirculationRules.t for example)

- Please change the failure message to describe what's being tested

- Don't forget to perltidy the test file :)

-- 
You are receiving this mail because:
You are watching all bug changes.