[Koha-bugs] [Bug 29002] Add ability to book items ahead of time

Fri Aug 18 16:30:34 CEST 2023

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sandbox updated.

(In reply to Caroline Cyr La Rose from comment #31)
> > Usability comments:
> > - Patron search inconsistency.

Working on this at the moment, reverting to 'patron_autocomplete' as per
various places in the UI.

> >
> > -  The Holds tab shows how many holds there are, maybe the bookings tab
> > should show if there are bookings and how many?
> > 
> 
> This was added, thank you! I noticed however that when you add a booking,
> the number doesn't automatically go up. You have to refresh the page. I
> don't think this is blocking for now.

Fixed on the sandbox (Please check both booking placement and cancellation and
try the cancellation from all locations (including the patron details page)

> > -  In the bookings tab, the calendar shows the booking id (?). This id is
> > not displayed in the table, so it's not very clear what it refers to. I
> > think it would be better to show the patron's name and cardnumber. Maybe
> > with a hover display for short bookings.
> 
> I still think it would be better to show something else than the id in the
> calendar. Or show the ID in the table so that we can know which is which. 

Fixed on the sandbox 

> >
> > -  In the bookings tab, in the table, not sure why there is a search box for
> > the Actions columns...
> > 
> 
> The search box is still there. Not a blocker, just weird.

This is weird, I've removed the search header for now.. seems that's an issue
with the kohaTable implimentation.. all the rows are getting shifted one to the
left for this header row.  I'll resolve that in a new bug.

> >
> > -  I would also like the patron's name to have their cardnumber, and maybe a
> > link to their file like in the Holds tab
> > 
> 
> The link was added! There is still no cardnumber. Not blocking, but it is
> not consistent with the rest of Koha.

Fixed on the sandbox

> >
> > -  Not sure how I triggered the "It worked" message
> > https://snipboard.io/0KNJzp.jpg I think it was by moving a booking around in
> > the calendar, but I also got it while scrolling in the calendar (although I
> > think the latter was a belated message for the former)
> >    If it was for updating a booking, it could say "Booking updated".
> > 
> 
> Still the case. I don't think this is blocking, but I would like to see more
> meaningful messages.

Message removed, I'm not sure how best to give feedback.. I feel like you don't
need something to dismiss, but we don't really have a consistent way of doing
this yet in Koha.. another one for a future followup I think.

> 
> New (?) blocker bugs
> 
> -  When I select 'Any item' (https://snipboard.io/X4wGIL.jpg), the booking
> is placed for the specific item (https://snipboard.io/zmD3fu.jpg). I thought
> at first it was because there was only one item that was bookable on the
> record, but I made more items bookable after the booking was made and it
> stayed on the specific item. And when I added another booking for 'Any item'
> (https://snipboard.io/BPw8iy.jpg) it put it for the same specific item
> (https://snipboard.io/w4YBk9.jpg). It also doesn't block the booked dates if
> I try to make another booking for 'Any item'
> (https://snipboard.io/iNVWS4.jpg).
> I tried placing a new booking for 'Any item' with the same dates, and it
> just added it to the same row (https://snipboard.io/nJhEk0.jpg).

The 'Any item' functionality was changed for now to autoselect an item for you
at booking placement time.  The reason being, I could get the bookings clashing
logic to work 100% of the time without selecting an item immediately.  I intend
to revisit this once we've got the foundations in.

> - I noticed in the Bookings tab of the patron file that there are hours to
> the start and end dates (https://snipboard.io/P85tHo.jpg). I don't know how
> I managed to make a booking from 4 to 3:58... If we permit bookings with
> hours, we should be able to choose them when making the booking, and show
> the hours everywhere. If not, then displaying only date would be sufficient
> (and have the saved date be 00:00 to 23:59?).

I removed the time component on the table on this page now.. It was an error
leaving it as $datetime instead of $date.

> - I don't have access to the DB in the sandbox, but I made a report to see
> what it looked like. This might be philosophical, but I think we should
> stick to borrowernumber, biblionumber and itemnumber as column names. Unless
> it was decided otherwise in a dev meeting that now borrowers are patrons and
> everything is _id in the DB...

I can do this. :(

>
> New usability comments
> 
> - Would it be possible to add an 'Edit' button? I know we can change the
> dates by double-clicking or long-clicking and then sliding the booking
> sideways in the calendar view, but I don't find this intuitive. I was trying
> to slide the booking and it was sliding the whole calendar (because I hadn't
> double-clicked on it first), and I expected double-clicking to open the
> modal to edit the booking... Mind you, I might just be weird :) . I wonder
> if people might also want to change the item on which the booking is. Mostly
> everywhere else in Koha there is an Edit button in the Actions column.

I used an edit button initially, but again it was difficult to work with..
However I am working on restoring it now.

>
> - In the Bookings tab of the patron file :
> 
>   - If possible, could you add links to the bookings tab of the biblio
> record under the title (like in the Holds tab).

Fixed on the sandbox

> 
>   - The table says it was filtered from X total entries, which I'm guessing
> is the total number of bookings (https://snipboard.io/P85tHo.jpg). I find
> this confusing, I'm expecting this patron to have 31 bookings but I somehow
> filtered it to show only two.

We filter out past bookings by default here.. perhaps that needs rethinking.

> 
>   - There is also a search box in the Actions column.  

Removed the header search row again, as above.

> 
> This is it for now! Sorry, I know it's a lot again...

Thanks for testing.. it's all great feedback.. but I must admit I'm struggling
to keep on top of it all.

-- 
You are receiving this mail because:
You are watching all bug changes.