[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Rebased (tiny change), perl tidied, applied changes for bug 33556.
Note the two important comments about a few qa tools warns that can be ignored.

Rest is fine now:

Processing files before patches
|========================>| 21 / 21 (100.00%)
Processing files after patches
|========================>| 21 / 21 (100.00%)

 OK     C4/Installer.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   OK     tidiness
   OK     valid

 FAIL   Koha/Exceptions/DomainLimit.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     Koha/MailDomainLimit.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     Koha/MailDomainLimits.pm
   OK     critic
   OK     file permissions
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     Koha/Notice/Util.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     Koha/REST/V1/Config/SMTP/DomainLimits.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   OK     tidiness
   OK     valid

 FAIL   Koha/Schema/Result/MailDomainLimit.pm
   OK     critic
   OK     file permissions
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   SKIP   spelling
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 0,
now: 35)
   OK     valid

 OK     admin/domain_limits.pl
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     api/v1/swagger/definitions/smtp_domain_limits.yaml
   OK     git manipulation
   OK     rest_api_specs
   OK     yaml_valid

 OK     api/v1/swagger/paths/smtp_domain_limits.yaml
   OK     git manipulation
   OK     rest_api_specs
   OK     yaml_valid

 OK     api/v1/swagger/swagger.yaml
   OK     git manipulation
   OK     rest_api_specs
   OK     yaml_valid

 OK     installer/data/mysql/atomicupdate/bug33537.pl
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     installer/data/mysql/kohastructure.sql
   OK     boolean_vs_tinyint
   OK     charset_collate
   OK     git manipulation
   OK     tinyint_has_boolean_flag

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/admin/domain_limits.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   SKIP   spelling
   OK     tt_valid
   OK     valid_template

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   SKIP   spelling
   OK     tt_valid
   OK     valid_template

 OK     koha-tmpl/intranet-tmpl/prog/js/domain_limits.js
   OK     git manipulation

 OK     t/db_dependent/Installer.t
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     t/db_dependent/Koha/MailDomainLimits.t
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     t/db_dependent/Koha/Notice_Util.t
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     t/db_dependent/api/v1/domain_limits.t
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   OK     tidiness
   OK     valid

 OK     t/lib/TestBuilder.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     pod coverage
   SKIP   spelling
   OK     tidiness
   OK     valid

-- 
You are receiving this mail because:
You are watching all bug changes.