[Koha-bugs] [Bug 34585] "When to charge" columns value not copied when editing circulation rule

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34585

Johanna Miettunen <johanna.miettunen at haaga-helia.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |johanna.miettunen at haaga-hel
                   |                            |ia.fi

--- Comment #3 from Johanna Miettunen <johanna.miettunen at haaga-helia.fi> ---
After applying the patch, value on "When to charge" column is copied as it is
in the rule before editing. In my tests the patch works. I can't repeat the
situation that Owen is describing. 

But, there are couple things I noticed. 
1) On our current production Koha (23.05.01.003, custom build: KK-Koha
23.05.848) value on "When to charge" column is copied as it is when editing the
rule. So, our library doesn't seem to have this problems Emmi is reporting in
the first place. Maybe we already have some fix for this...

2) I think the one problem is with the Clear button and how it behaves. This
happens in our production Koha and in sandbox tests before and after applying
the patch. 
1. Edit rule A, values are copied, but then decide to cancel, click Clear
2. Edit rule B, values might be copied, but then decide to cancel, click Clear
3. Edit rule C, not all values are not copied

All in all, it seems that even after the first time, when one cancels by
clicking Clear, it is most reliable to first refresh the page and and then
start editing the same rule or the next rule.

I feel silly writing this, but I thing Emmi's patch is partially fixing the
error at least on test sandbox. But if one cancels the editing process, the
Koha/page can't keep up and editing mode starts behaving weirdly, and can't
copy data on rule row as it maybe should.

-- 
You are receiving this mail because:
You are watching all bug changes.