[Koha-bugs] [Bug 34609] Holds history errors 500 if old_reserves.biblionumber is NULL

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34609

--- Comment #5 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
(In reply to Lucas Gass from comment #3)
> Thanks Pedro, this works! Do you think we need unit tests for this change?

Thanks Lucas, I had not realized there was already a bug filed for this.

What I think happened is, the biblio method in Hold.pm returned undef if it did
not have a biblionumber, but after this patch:
https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32894&attachment=152086
It started returning an empty DBix::ResultSource(?) instead of undef leading to
holdhistory.tt to explode.

A test making sure biblio in Hold.pm returns either a biblio object or undef
would certainly been helpful before bug 32894, and certainly does not hurt now
either!

-- 
You are receiving this mail because:
You are watching all bug changes.