[Koha-bugs] [Bug 34639] Item shown in transit on detail.pl even if marked as arrived or cancelled

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34639

--- Comment #9 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Nick Clemens from comment #7)
> Created attachment 154900 [details] [review]
> Bug 34639: Use coderef for releationship
> This does not include an order_by, so I am not sure if it is sufficient

prove t/db_dependent/Koha/Item.t fails with

# Subtest: get_transfers
    1..16
    ok 1 - Koha::Item->get_transfer should return a Koha::Item::Transfers
object
    ok 2 - When no transfers exist, the Koha::Item:Transfers object should be
empty
    ok 3 - When one transfer has been requested, the Koha::Item:Transfers
object should contain one result
    ok 4 - When there are multiple open transfer requests, the
Koha::Item::Transfers object contains them all
    ok 5 - Koha::Item->get_transfers returns the oldest transfer request first
    ok 6 - Koha::Item->get_transfers returns the newer transfer request second
    ok 7 - Koha::Item->get_transfers returns the newest transfer request last
    ok 8 - When one transfer is set to in_transit, the Koha::Item::Transfers
object still contains them all
    not ok 9 - Koha::Item->get_transfers returns the active transfer request
first
    #   Failed test 'Koha::Item->get_transfers returns the active transfer
request first'
    #   at t/db_dependent/Koha/Item.t line 1158.
    #          got: '369'
    #     expected: '370'
    not ok 10 - Koha::Item->get_transfers returns the other transfers oldest to
newest
    #   Failed test 'Koha::Item->get_transfers returns the other transfers
oldest to newest'
    #   at t/db_dependent/Koha/Item.t line 1159.
    #          got: '370'
    #     expected: '369'
    ok 11 - Koha::Item->get_transfers returns the other transfers oldest to
newest
    ok 12 - Once a transfer is received, it no longer appears in the list from
->get_transfers()
    ok 13 - Koha::Item->get_transfers returns the other transfers oldest to
newest
    ok 14 - Koha::Item->get_transfers returns the other transfers oldest to
newest
    ok 15 - Once a transfer is cancelled, it no longer appears in the list from
->get_transfers()
    ok 16 - Koha::Item->get_transfers returns the only transfer that remains
    # Looks like you failed 2 tests of 16.
not ok 18 - get_transfers

Other than that your patch seems to fix the original issue. Awesome!

-- 
You are receiving this mail because:
You are watching all bug changes.