[Koha-bugs] [Bug 34666] _Findgroupreserve is not returning title level matches from the queue for holds with no item group
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Aug 30 21:34:19 CEST 2023
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34666
David Nind <david at davidnind.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #154981|0 |1
is obsolete| |
--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 154986
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154986&action=edit
Bug 34666: Combine queries in _Findgroupreserve
The queries here are the same except for 2 differences:
1 - They check if the hold was on a particular item
2 - The latter confirms that the reserve item group matches the item's item
group
For 1, it doesn't matter - only 1 item can be mapped ot a reserve, itemnumber
is the primary key
for hold_fill_targets - so we are either matching it in the first query or the
second, either way we get the same
reserve - the returns are the same so we don't care which query it came from
For 2, this has already been checked when the queue was built. We don't need to
verify the match because
it wouldn't be in the targets if they didn't match
To test:
1 - Apply second unit test patch
2 - prove t/db_dependent/Reserves.t
3 - It should pass
4 - Apply this patch
5 - prove t/db_dependent/Reserves.t
6 - It continues to pass
Signed-off-by: David Nind <david at davidnind.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list