From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 00:01:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Nov 2023 23:01:59 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #25 from David Cook --- (In reply to Andrew Fuerste-Henry from comment #22) > I feel like this permission should be grouped with the other borrowers > permissions, rather than set off as its own top-level permission. +1 This needs to be in "permissions" and not "userflags". This is important for the UI and overall permission logic. > A couple of minor things seem off, though, both on the member.pl search > results page: > - clicking a patron name in the results list takes one to > cgi-bin/koha/members/moremember.pl, a page one would otherwise not be able > to access with only list_borrowers It's a good point. I think list_borrowers should be able to go to the moremember.pl page, since "list_borrowers" basically means you can list all patrons and their information. But they shouldn't be able to update/delete. In general, Koha doesn't have very nuanced authorization, but I suppose in this case maybe we should be defining "flagsrequired" based on HTTP method. If it's a GET, then "list_borrowers" can be included. But if it's a POST or something else, it needs to only be "edit_borrowers". > - while on member.pl or moremember.pl as a user with only list_borrowers > permission, the Search Patrons feature in the main search bar is only > partially disabled -- the Search Patrons option still appears, but when it > is selected the search box disappears, thereby preventing the search. This > is a visually confusing approach and becomes more confusing if one clicks > around between the options here, as the search box will reappear when > something other than Search Patrons is selected. See the attached screenshot > in which the interface is simultaneously indicating both Check Out and > Search Patrons. Can we remove Search Patrons from this bar entirely if the > user lacks that permission? I'm not sure I understand what you're saying here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 00:30:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 Nov 2023 23:30:26 +0000 Subject: [Koha-bugs] [Bug 30627] koha-run-backups delete the backup files after finished its job without caring days option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30627 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 02:15:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 01:15:42 +0000 Subject: [Koha-bugs] [Bug 35181] Can no longer edit sample records with advanced cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Lauren Denny changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauren_denny at sil.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 02:36:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 01:36:22 +0000 Subject: [Koha-bugs] [Bug 5534] Koha mapping punctuation to space for indexing/searching can be confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27153 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 02:36:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 01:36:22 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5534 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 02:37:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 01:37:58 +0000 Subject: [Koha-bugs] [Bug 5534] Koha mapping punctuation to space for indexing/searching can be confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534 --- Comment #19 from David Cook --- For folk using Zebra in English, QueryStemming can help with this, although QueryStemming only works if automatic QueryTruncation isn't turned on. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 02:45:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 01:45:35 +0000 Subject: [Koha-bugs] [Bug 9729] Unable to use IT search terms such as C#, .NET, C++ in searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9729 --- Comment #12 from David Cook --- It would be interesting to look at this in an Elasticsearch context... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 02:50:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 01:50:40 +0000 Subject: [Koha-bugs] [Bug 35455] New: ICU does not strip = when indexing/searching Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35455 Bug ID: 35455 Summary: ICU does not strip = when indexing/searching Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au The CHR config file /etc/koha/zebradb/etc/word-phrase-utf.chr replaces = with a space, but the ICU config files /etc/koha/zebradb/etc/words-icu.xml and /etc/koha/zebradb/etc/phrases-icu.xml do not transform the = character. I encountered this problem because the "Show analytics" link wasn't appearing for a journal record, but it will affect other search contexts too. Note on https://unicode-org.github.io/icu/userguide/strings/regexp.html it says: "The property expression \p{punct} differs in what it matches. Java matches matches any of !"#$%&'()*+,-./:;<=>?@[\]^_`{|}~. From that list, ICU omits $+<=>^`|~ ICU follows the recommendations from Unicode UTS-1" Arguably we should remove <=>^`|~ during ICU normalization but I'm just focusing on = for now, as the colon : gets changed to = during searches, and subtitles frequently are introduced by : in English. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 03:06:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 02:06:01 +0000 Subject: [Koha-bugs] [Bug 35455] ICU does not strip = when indexing/searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35455 --- Comment #1 from David Cook --- For example: Record 1: 245$a Awesome title: awesome subtitle Record 2: 245$a Cool article 773$t Awesome title: awesome subtitle -- At indexing time, this will be indexed as "Awesome title awesome subtitle" as the ICU removes the punctuation. At search time, we can't use "Awesome title= awesome subtitle" because the tokens "title" and "title=" won't match. We've got to remove the = since at indexing time it was a : -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 03:48:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 02:48:59 +0000 Subject: [Koha-bugs] [Bug 35455] ICU does not strip = when indexing/searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35455 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 03:49:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 02:49:02 +0000 Subject: [Koha-bugs] [Bug 35455] ICU does not strip = when indexing/searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35455 --- Comment #2 from David Cook --- Created attachment 159422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159422&action=edit Bug 35455: Remove = in ICU for indexing/searching This change more closely aligns ICU and CHR so that ICU also removes the = character. This fixes issues in ICU when searching with a : which gets transformed into a =. Without this change, the Analytics features won't work for titles with a colon in them. Test plan: 0. Apply the patch and import bibs from Bugzilla (using Staged MARC tools) 1. cp ./etc/zebradb/etc/phrases-icu.xml /etc/koha/zebradb/etc/phrases-icu.xml 2. cp ./etc/zebradb/etc/words-icu.xml /etc/koha/zebradb/etc/words-icu.xml 3. vi /etc/koha/zebradb/etc/default.idx Change "charmap word-phrase-utf.chr" to "icuchain words-icu.xml" for "index w" and "icuchain phrases-icu.xml" for "index p" 4. koha-zebra --stop kohadev 5. pkill zebrasrv 6. koha-zebra --start kohadev 7. koha-rebuild-zebra -a -b -f -v kohadev 8. Search for "Awesome title" and open the detail page 9. Note that the "Analytics: Show analytics" line shows up 10. Click that link 11. Note that it opens the "Cool article" record and it displays "In: Awesome title: awesome subtitle" 12. Click that link 13. Note that it opens the "Awesome title" record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 03:57:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 02:57:41 +0000 Subject: [Koha-bugs] [Bug 35455] ICU does not strip = when indexing/searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35455 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This change fixes an issue release notes| |with Zebra ICU searching | |where titles with colons | |aren't properly searchable, | |especially when used with | |Analytics. | | | |A full re-index | |of Zebra is needed for this | |change to take effect. Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 03:59:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 02:59:34 +0000 Subject: [Koha-bugs] [Bug 35455] ICU does not strip = when indexing/searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35455 --- Comment #3 from David Cook --- Created attachment 159423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159423&action=edit Record 1 Record 1 for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 03:59:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 02:59:50 +0000 Subject: [Koha-bugs] [Bug 35455] ICU does not strip = when indexing/searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35455 --- Comment #4 from David Cook --- Created attachment 159424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159424&action=edit Record 2 for testing Record 2 for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 06:37:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 05:37:27 +0000 Subject: [Koha-bugs] [Bug 35456] New: The fine will not be displayed. And even if the expired book is not handed over, it will show as a checked out book. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35456 Bug ID: 35456 Summary: The fine will not be displayed. And even if the expired book is not handed over, it will show as a checked out book. Change sponsored?: --- Product: Koha Version: 22.11 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: csuranjith64 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a patron takes a book and it is overdue, the fine will not be displayed. And even if the expired book is not handed over, it will show as a checked out book. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 07:51:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 06:51:40 +0000 Subject: [Koha-bugs] [Bug 35438] Importing records can create too large transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35438 --- Comment #4 from Jonathan Druart --- The idea of surrounding the whole job with a transaction was to be able to "retry" it in case it fails. If we process only a subset it won't be possible (unless parsing the "report"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 07:55:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 06:55:01 +0000 Subject: [Koha-bugs] [Bug 31575] Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #10 from Jonathan Druart --- I have been git bisect a selenium failure on 21.11.x STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm:361 in Try::Tiny::try (eval 1693):1 in Selenium::Remote::Driver::__ANON__ (eval 1695):2 in Selenium::Remote::Driver::__ANON__ /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm:1335 in Selenium::Remote::Driver::_execute_command /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm:1335 in (eval) t/db_dependent/selenium/basic_workflow.t:263 in Selenium::Remote::Driver::find_element Error while executing command: unexpected alert open: Dismissed user prompt dialog: And found this commit 7a88155fe13c3a4f71f1a8d09b170738e7d8cbb8 is the first bad commit It's crazy that the failure has been ignored for so long... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 08:18:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 07:18:13 +0000 Subject: [Koha-bugs] [Bug 35383] Dragging and dropping subfield of repeated tags doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 --- Comment #6 from Marcel de Rooy --- (In reply to Slava Shishkin from comment #5) > (In reply to Marcel de Rooy from comment #4) > > thanks, that makes a sense, > > I can wrap up it in "if", > > if (typeof Sortable !== 'undefined') { > $(clone).find("ul.sortable_subfield").each((i, e) => { > Sortable.create(e, { > animation: 150, > }); > }); > } > > but the best then is to make a callback option for CloneSubfield and leave > Sortable.create code in files where it resides, > > but that also leads to refactoring of onclick="CloneSubfield... to modern > way how we doing that in our codebase by moving that listener to JS document > ready block > > Marcel, what do you think? You are welcome to improve it. Please do so on a new report. I think that this patch can go in now in its current form. Your commitment is appreciated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 08:26:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 07:26:35 +0000 Subject: [Koha-bugs] [Bug 35414] Silence warn related to number_of_copies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 08:26:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 07:26:37 +0000 Subject: [Koha-bugs] [Bug 35414] Silence warn related to number_of_copies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159365|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy --- Created attachment 159425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159425&action=edit Bug 35414: Silence warn related to number_of_copies To test in ktd: - Tail the logs with "sudo tail -f /var/log/koha/kohadev/plack*.log" - Find a record in the staff client - Add an item to the record - Observe "[WARN] Argument "" isn't numeric in subroutine entry ..." in /var/log/koha/kohadev/plack-intranet-error.log - Apply this patch - restart_all - Tail the logs again - Add another item - Observe the absence of the earlier warning Thanks to Jonathan Druart for suggesting this particular solution! Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 08:43:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 07:43:41 +0000 Subject: [Koha-bugs] [Bug 34585] "When to charge" columns value not copied when editing circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34585 --- Comment #5 from Emmi Takkinen --- Pressing "Cancel" button should set first select option as selected and it does. However previous selection is never cleared. So every time rule row is selected to be edited it's select options receive "selected" attribute which persists. When new value is selected, it's select options still have previous rules options as selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 08:47:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 07:47:15 +0000 Subject: [Koha-bugs] [Bug 35425] Sortable prevents mouse selection of text inside child input/textarea elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 08:47:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 07:47:17 +0000 Subject: [Koha-bugs] [Bug 35425] Sortable prevents mouse selection of text inside child input/textarea elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159379|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 159426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159426&action=edit Bug 35425: Optimize UX when dragging a Tag or Subfield To reproduce: 1. Open any biblio and edit that record. (select "Edit record" from the "Edit" drop-down menu). 2. Check that selecting the text in any draggable block input/textarea fields with a mouse is not possible - it starts dragging instantly. 3. Apply the patch 4. Make sure that draging is activated only when you click on the "::" icon in front of the dragged item. And text selection works correctly. Signed-off-by: Phil Ringnalda Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 08:47:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 07:47:36 +0000 Subject: [Koha-bugs] [Bug 35425] Sortable prevents mouse selection of text inside child input/textarea elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 08:51:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 07:51:39 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 08:51:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 07:51:42 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159409|0 |1 is obsolete| | --- Comment #26 from Thibaud Guillot --- Created attachment 159427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159427&action=edit Bug 30230: Add new 'list_borrowers' permission When a patron search is performed only a user with edit_borrowers permission can search by name. Search can works only with cardnumber but it makes searching less intuitive I think. So, as mentioned in the discussion, I've added a new 'list_borrowers' permission, completely independent of 'edit_borrowers', so that I can search for a member via the interface and get the results. In addition to the permission to perform check in and checkouts, this no longer poses an obstacle to simple use. Test plan: 1) Check with a user without 'edit_borrowers' permission that the patron search can only be performed with cardnumber 2) Apply this patch 3) Make the updatedatabase to add new 'list_borrowers' permissions 4) Set 'list_borrowers' permission on one user and see the difference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 08:58:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 07:58:37 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #27 from Thibaud Guillot --- (In reply to Andrew Fuerste-Henry from comment #22) > I feel like this permission should be grouped with the other borrowers > permissions, rather than set off as its own top-level permission. > > I created a user with only catalogue, circulate_remaining_permissions, and > list_borrowers. I was able to check out to a patron using either their > cardnumber or name to find them and when I entered a name which found more > than one patron I was able to access the patron search screen to select the > correct patron. So that all worked as desired. > > A couple of minor things seem off, though, both on the member.pl search > results page: > - clicking a patron name in the results list takes one to > cgi-bin/koha/members/moremember.pl, a page one would otherwise not be able > to access with only list_borrowers > > - while on member.pl or moremember.pl as a user with only list_borrowers > permission, the Search Patrons feature in the main search bar is only > partially disabled -- the Search Patrons option still appears, but when it > is selected the search box disappears, thereby preventing the search. This > is a visually confusing approach and becomes more confusing if one clicks > around between the options here, as the search box will reappear when > something other than Search Patrons is selected. See the attached screenshot > in which the interface is simultaneously indicating both Check Out and > Search Patrons. Can we remove Search Patrons from this bar entirely if the > user lacks that permission? Hello ! Thanks for your comments Andrew and David, I've updated my patch to take them into account. I've grouped this permission under those linked to borrowers, and modified access on the moremember.pl page. I'm divided on this point because, as David says, it may be useful to see more detailed information on a member, but at the same time, there's the view_borrower_infos_from_any_libraries permission which allows it, it seems to me. The difference is that it's not limited to one site... so I'm open to suggestions on this point, of course, as I don't know what would be best. As far as the search bar and the "Search patrons" tab are concerned, I did indeed notice a bug when it appeared, so I modified the code to display this tab only if the user had "circulate" permission... that's what I understood from your example. The patch can now be tested again :) Thanks to both of you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 09:13:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 08:13:09 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #19 from Marcel de Rooy --- QA: Revisiting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 09:13:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 08:13:42 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 --- Comment #20 from Marcel de Rooy --- FAIL installer/data/mysql/db_revs/220600024.pl FAIL forbidden patterns forbidden pattern: IFNULL (must be replaced by COALESCE) (line 33) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 09:14:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 08:14:11 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 --- Comment #21 from Marcel de Rooy --- Probably we should allow IFNULL in the mysql folder :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 09:18:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 08:18:52 +0000 Subject: [Koha-bugs] [Bug 35436] Copy is not translatable in OPAC search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 --- Comment #6 from Adolfo Rodríguez Taboada --- This is not intuitive. I noticed that in "your checkout history" Copy is translatable unlike in "your search history". I compared the way the table is created and saw that "your checkout history" uses KohaTable so I changed "your search history" to do the same and now Copy gets translated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 09:56:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 08:56:04 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 --- Comment #22 from Marcel de Rooy --- Looks good to me. Any particular reason why you replaced the original suspension_chargeperiod by fine btw ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 09:57:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 08:57:44 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 09:57:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 08:57:47 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159410|0 |1 is obsolete| | Attachment #159411|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy --- Created attachment 159428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159428&action=edit Bug 33847: Database update replaces undefined rules with defaults rather than the value that would be used Bug 29012 introduces a database update that sets the default values for rules that are required but undefined. This functionally changes the results of the circulation rules. Instead, this update should find value that is being used for that rule combo and use that as the rule value, only using the default in the case that the derived rule doesn't exist or has a null value. Test Plan: 1) Check out Koha 22.05.05 2) Create a default all/all/all rule, 3 other rules. Ensure they all have Loan period set to 7, with one of the non-default rules having a Loan period of 14. 3) Delete all but one of the non-default rules with the following query: Delete from circulation_rules where rule_name = 'issuelength' and ( rule_value != 14 and not ( branchcode is null and categorycode is null and itemtype is null ) ) limit 2; 4) Check out 254f721320 5) Run updatedatabase.pl and restart 6) Note the rules were recreated with the value 0 7) Repeat steps 1-4 8) Apply this patch 9) If you're using the same database, set the version to 22.0600023 and restart 10) Run updatedatabase.pl 11) Note the rules were recreated, but the value is the derived value from the all/all/all rule! Signed-off-by: Kevin Carnes Signed-off-by: Marcel de Rooy Signed-off-by: Emily Lamancusa Bug 33847: Rewrite to use SQL Signed-off-by: Emily Lamancusa Signed-off-by: Marcel de Rooy [EDIT] Squashed, and added reference to new bug too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:01:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:01:29 +0000 Subject: [Koha-bugs] [Bug 34149] Syndetics cover images don't load in staff interface detail page if other images services are enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Marcel de Rooy --- Moving back to FQA in view of previous discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:02:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:02:53 +0000 Subject: [Koha-bugs] [Bug 35416] Advanced editor interface hang when trying to edit an existing catalogue record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35416 Felix Klein changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felix.klein at incher.uni-kass | |el.de --- Comment #3 from Felix Klein --- I have the same problem. The intranet-error.log shows: [cgi:error] malformed header from script 'bib': Bad header: Invalid-metadata, referer: /cgi-bin/koha/cataloguing/editor.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:12:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:12:59 +0000 Subject: [Koha-bugs] [Bug 34597] Expired patrons can still place ILL requests through OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34597 Georgia Newman changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |g.newman at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:18:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:18:35 +0000 Subject: [Koha-bugs] [Bug 34597] Expired patrons can still place ILL requests through OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34597 --- Comment #2 from Georgia Newman --- We’ve had an instance this week whereby an expired user was able to place an ILL request, which we assumed would have been blocked by BlockExpiredPatronOpacActions. We would want to prevent expired users from placing ILL requests. Looking through the system preferences, we did think about whether we could maybe use the LockExpiredDelay preference (and say set to 1 day), to prevent expired patrons logging into the OPAC at all, in order to prevent these instances slipping through. However, I think this preference would be too blunt, as it requires the misc/cronjobs/cleanup_database.pl to be running. Assuming this was say set to run once daily, in the event of a staff member extending the expiry date of a patron, presumably they would still be blocked from logging into the OPAC for the rest of the day until the job ran again. So for us it makes sense to see placing an ILL request included in the BlockExpiredPatronOpacActions preference, as it seems less blunt than using the LockExpiredDelay preference to prevent this action. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:20:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:20:25 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 --- Comment #24 from Marcel de Rooy --- Btw: does <=> work for MariaDB? Yes, see: https://mariadb.com/kb/en/null-safe-equal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:25:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:25:48 +0000 Subject: [Koha-bugs] [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159332|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 159429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159429&action=edit Bug 33171: Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder Some libraries would like to use the following item fields with the MarcItemFieldsToOrder system preference: * coded_location_qualifier * barcode * enumchron Test Plan: 1) Set up MarcItemFieldsToOrder, verify it is functioning 2) Test coded_location_qualifier, barcode, and enumchron 3) Note the fields are imported and set for the items Signed-off-by: Matt Blenkinsop Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:25:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:25:51 +0000 Subject: [Koha-bugs] [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159333|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 159430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159430&action=edit Bug 33171: Fix missing price when mapped from MarcItemFieldsToOrder This patch fixes an issue where the price is not passed to the UI when read from MarcItemFieldsToOrder. Test plan: 1) In Administration, copy and paste the following into MarcItemFieldsToOrder: quantity: 975$q budget_code: 975$h price: 975$p itype: 975$y coded_location_qualifier: 975$a barcode: 975$b enumchron: 975$c 2) Save 3) Navigate to Acquisitions and find a basket 4) Click Add to basket and select From a new file 5) Choose the file attached to this bug 6) Upload file and click Stage for import 7) Click Add staged files to basket once the job is finished 8) Check the box next to the record 9) The price should show 10.00 under Item record 1 10) coded location qualifier, barcode, enumchron should also have values as per the other commit on this bug 11) Save and import, the basket should not have a value of 0 as the price has been read correctly 12) Check the database, the newest item should have values for price, coded_location_qualifier, barcode and enumchron Signed-off-by: Matt Blenkinsop Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:27:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:27:14 +0000 Subject: [Koha-bugs] [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize --- All working as desired, QA scripts happy and no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:27:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:27:36 +0000 Subject: [Koha-bugs] [Bug 35416] Advanced editor interface hang when trying to edit an existing catalogue record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35416 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- Hi, this is very likely a duplicate to Bug 35181 - Can no longer edit sample records with advanced cataloguing editor See there for versions this will be fixed in. *** This bug has been marked as a duplicate of bug 35181 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:27:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:27:36 +0000 Subject: [Koha-bugs] [Bug 35181] Can no longer edit sample records with advanced cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |iming at rosewoodfarm.com.au --- Comment #11 from Katrin Fischer --- *** Bug 35416 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:32:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:32:44 +0000 Subject: [Koha-bugs] [Bug 35457] New: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35457 Bug ID: 35457 Summary: Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 20755 As noted by Caroline on bug 20755, we should move the 2 mentioned system preferences to the serials tab. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20755 [Bug 20755] Allow separate email configuration for acquisition and serials emails -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:32:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:32:44 +0000 Subject: [Koha-bugs] [Bug 20755] Allow separate email configuration for acquisition and serials emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20755 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35457 [Bug 35457] Move SerialsDefaultEMailAddress and SerialsDefaultReplyTo to serials preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:40:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:40:57 +0000 Subject: [Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED --- Comment #42 from Marcel de Rooy --- Looking here. This feels a bit like an enhancement ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:51:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:51:08 +0000 Subject: [Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #43 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #42) > Looking here. > This feels a bit like an enhancement ? The original bug wasn't, but it might have grown a bit. The problem was that the display in Koha was not matching the email in terms of line breaks. This caused confusion when testing etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:55:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:55:04 +0000 Subject: [Koha-bugs] [Bug 35416] Advanced editor interface hang when trying to edit an existing catalogue record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35416 Felix Klein changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |FIXED --- Comment #5 from Felix Klein --- (In reply to Katrin Fischer from comment #4) > Hi, this is very likely a duplicate to > Bug 35181 - Can no longer edit sample records with advanced cataloguing > editor > See there for versions this will be fixed in. > > *** This bug has been marked as a duplicate of bug 35181 *** Thank you very much! This has solved the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:56:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:56:52 +0000 Subject: [Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #44 from Marcel de Rooy --- +sub html_content { + Teasing a bit: but who says that this text is English ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:57:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:57:33 +0000 Subject: [Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:57:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:57:36 +0000 Subject: [Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158892|0 |1 is obsolete| | --- Comment #45 from Marcel de Rooy --- Created attachment 159431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159431&action=edit Bug 30287: Conditionally render notice preview This patch adds conditional formatting based on whether the notice was generated from an HTML template or a plaintext one. We simply drop the 'html_line_break' filter for the case where the notice should already be html formatted. I was tempted to replace the html_line_break for plaintext formatted notices too as I believe this closer resembles how we actually output such generated notices.. but I decided that should be for another bug. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:57:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:57:39 +0000 Subject: [Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158893|0 |1 is obsolete| | --- Comment #46 from Marcel de Rooy --- Created attachment 159432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159432&action=edit Bug 30287: (follow-up) Add content wrap matching send time This patch adds a new method to the Koha::Notice::Message class to wrap content in the same way we currently do at email send time. We then update the notice preview to use this method so we're embedding NoticeCSS into that iframe. This means the generated preview should now exactly match how your notice will display in email clients including any CSS you may have placed within NoticeCSS. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:57:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:57:41 +0000 Subject: [Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158894|0 |1 is obsolete| | --- Comment #47 from Marcel de Rooy --- Created attachment 159433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159433&action=edit Bug 30287: (follow-up) Unit test for html_content This patch adds a unit test for the new `html_content` method introduced to Koha::Notice::Template in the previous patch. Test 1) Run the new unit test ;P Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 10:57:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 09:57:44 +0000 Subject: [Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158895|0 |1 is obsolete| | --- Comment #48 from Marcel de Rooy --- Created attachment 159434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159434&action=edit Bug 30287: (follow-up) Make unit test more reliable in ktd This patch mocks NoticeCSS earlier to ensure we're not inadvertantly failing due to a local setup in ktd having added to the preference. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:18:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:18:29 +0000 Subject: [Koha-bugs] [Bug 35277] Pseudonymization should be done in a background job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35277 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Marcel de Rooy --- +use Modern::Perl; + +use Koha::PseudonymizedTransactions; + +use base 'Koha::BackgroundJob'; + +=head1 NAME + +Koha::BackgroundJob::BatchCancelHold - Batch cancel holds Copy and paste stuff? Please check the rest too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:18:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:18:43 +0000 Subject: [Koha-bugs] [Bug 35277] Pseudonymization should be done in a background job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35277 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:21:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:21:06 +0000 Subject: [Koha-bugs] [Bug 34573] Inconsistencies in acquisitions modify vendor title tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:21:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:21:08 +0000 Subject: [Koha-bugs] [Bug 34573] Inconsistencies in acquisitions modify vendor title tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159183|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy --- Created attachment 159435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159435&action=edit Bug 34573: Fix inconsistencies in acquisitions modify vendor title tag This patch updates the vendor details template so that the title tag correctly reflects whether the user is viewing the vendor or modifying it. To test, apply the patch and go to Acquisitions. - Locate a vendor and view the details (supplier.pl?booksellerid=X) - The title should read "Vendor X > Acquisitions > Koha" - Edit the vendor. - The title should read "Modify vendor X > Acquisitions > Koha" Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:21:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:21:10 +0000 Subject: [Koha-bugs] [Bug 34573] Inconsistencies in acquisitions modify vendor title tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159184|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy --- Created attachment 159436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159436&action=edit Bug 34573: (follow-up) Additional updates for modify vendor page Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:21:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:21:26 +0000 Subject: [Koha-bugs] [Bug 34573] Inconsistencies in acquisitions modify vendor title tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:29:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:29:01 +0000 Subject: [Koha-bugs] [Bug 35458] New: Issues rules without value can cause problems when perform checkouts on many sites Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35458 Bug ID: 35458 Summary: Issues rules without value can cause problems when perform checkouts on many sites Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: thibaud.guillot at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hello everyone, In the case of multi-site use, when defining rules such as "maxissueqty" or "patron_maxissueqty", for example, defining a value and then deleting it will allow the basic value to be kept but empty. As a result, certain code checks based on the rule definition rather than its value may produce unwanted behavior. I want to make sure with this bz that the "can_be_blank" setting could solve this kind of behavior. Here's a use case: For site A, no rule has ever been added to the "Default checkout, hold and return policy" table. For site B patron_maxissueqty was set to "5", then deleted, and is now set to empty "". Perform a checkout from site A to a borrower from site C will cause a pop-up with the possibility of forcing the message "This patron can't check out this item per library circulation policy. No circulation rule is defined for this patron and itemtype combination", whereas the same borrower will be able to obtain an issue without a pop-up for a document linked to site B since the rule is present, the check being based on its presence and not its value. I therefore wonder whether a list of additional rules could contain the "can_be_blank" parameter introduced by bug 26529 in order to avoid this kind of behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:29:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:29:07 +0000 Subject: [Koha-bugs] [Bug 35458] Issues rules without value can cause problems when perform checkouts on many sites In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35458 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26529 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:29:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:29:07 +0000 Subject: [Koha-bugs] [Bug 26529] Holds rules enforced incorrectly when not set at library level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26529 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35458 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:30:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:30:24 +0000 Subject: [Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #10 from Marcel de Rooy --- (In reply to David Cook from comment #8) > While I think we should ultimately retire the "Cataloging search", this at > least makes it a bit more usable. Agreed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:30:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:30:32 +0000 Subject: [Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:30:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:30:56 +0000 Subject: [Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:30:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:30:59 +0000 Subject: [Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159246|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy --- Created attachment 159437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159437&action=edit Bug 33646: Better organize availability in cataloging search This change adds "Available", "Unavailable", and "Not for loan" categories in the availability cell of the "cataloging search" found at /cgi-bin/koha/cataloguing/addbooks.pl This change also adds missing location information for the "Not for loan" items. Test plan: 0. Apply the patch 1. Add available, checked out, and not for loan items for a test record (like "Gairm" in koha-testing-docker) 2. Go to the cataloging search, http://localhost:8081/cgi-bin/koha/cataloguing/addbooks.pl?q=test 3. Note that the items in the "Location" column now have labels to differentiate which items are available, unavailable, and not for loan. 4. Note that the "Not for loan" data is similar to the "Available" data Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:31:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:31:15 +0000 Subject: [Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159437|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 159438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159438&action=edit Bug 33646: Better organize availability in cataloging search This change adds "Available", "Unavailable", and "Not for loan" categories in the availability cell of the "cataloging search" found at /cgi-bin/koha/cataloguing/addbooks.pl This change also adds missing location information for the "Not for loan" items. Test plan: 0. Apply the patch 1. Add available, checked out, and not for loan items for a test record (like "Gairm" in koha-testing-docker) 2. Go to the cataloging search, http://localhost:8081/cgi-bin/koha/cataloguing/addbooks.pl?q=test 3. Note that the items in the "Location" column now have labels to differentiate which items are available, unavailable, and not for loan. 4. Note that the "Not for loan" data is similar to the "Available" data Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:31:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:31:40 +0000 Subject: [Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:31:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:31:51 +0000 Subject: [Koha-bugs] [Bug 33646] "Cataloging search" missing important data for not for loan items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33646 --- Comment #13 from Marcel de Rooy --- Moved to enh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:49:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:49:14 +0000 Subject: [Koha-bugs] [Bug 35344] Patron image upload does not warn about missing cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35344 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 11:49:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 10:49:16 +0000 Subject: [Koha-bugs] [Bug 35344] Patron image upload does not warn about missing cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35344 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159247|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 159439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159439&action=edit Bug 35344: Warn on patron image upload if missing cardnumber This change displays a warning message instead of the patron image upload feature in the patron record when the patron is missing the cardnumber. Without this change, the staff user can try to upload a patron image but it will silently fail. This change warns the staff user of the cardnumber requirement for patron image upload. Test plan: 0. Apply the patch 1. Enable the "patronimages" system preference 2. Go to http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 3. Click "Add" over the patron image placeholder 4. Note the "Upload photo" button and the ability to take a patron photo if your device has a camera 5. Remove "cardnumber" from BorrowerMandatoryField 6. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 7. Edit the patron to remove the cardnumber 8. Click "Add" over the patron image placeholder 9. Note that no patron image upload features appear. Instead, only a warning appears stating that the patron needs a cardnumber before the patron image upload can be performed Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 12:15:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 11:15:18 +0000 Subject: [Koha-bugs] [Bug 30287] Notices using HTML render differently in notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #49 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #44) > +sub html_content { > + > > Teasing a bit: but who says that this text is English ? That's actually a really good point.. I didn't consider that at all.. but we really aught to be able to do better, I would have thought. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 12:17:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 11:17:52 +0000 Subject: [Koha-bugs] [Bug 35277] Pseudonymization should be done in a background job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35277 --- Comment #15 from Kyle M Hall --- Created attachment 159440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159440&action=edit Bug 35277: (QA follow-up) Fix POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 12:18:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 11:18:25 +0000 Subject: [Koha-bugs] [Bug 35277] Pseudonymization should be done in a background job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35277 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 12:24:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 11:24:31 +0000 Subject: [Koha-bugs] [Bug 35459] New: Don't always claim to be 'en' in html notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35459 Bug ID: 35459 Summary: Don't always claim to be 'en' in html notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Depends on: 35285 As highlighted in bug 30287 comment 44 we're continuing to hard code that the html content is 'en' here.. I'm sure we could do better and grab the lang code from GetPreparred letter and pass it along. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35285 [Bug 35285] Centralise notice content wrapping for html output -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 12:24:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 11:24:31 +0000 Subject: [Koha-bugs] [Bug 35285] Centralise notice content wrapping for html output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35285 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35459 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35459 [Bug 35459] Don't always claim to be 'en' in html notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 12:49:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 11:49:19 +0000 Subject: [Koha-bugs] [Bug 35438] Importing records can create too large transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35438 --- Comment #5 from Kyle M Hall --- (In reply to Jonathan Druart from comment #4) > The idea of surrounding the whole job with a transaction was to be able to > "retry" it in case it fails. If we process only a subset it won't be > possible (unless parsing the "report"). I think it was a great theory and and bad practice. Especially since we are transacting 50 at a time and not entire batches ( perish the thought! ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 12:53:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 11:53:42 +0000 Subject: [Koha-bugs] [Bug 35438] Importing records can create too large transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35438 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159415|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 159442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159442&action=edit Bug 35438: Transact each record import separately When importing a staged file we commit every 50 records For an authority import we are also merging, which can affect many more biblios, and these all end up in the transaction. This can cause tables locks and issues across Koha Test Plan: 1) Apply this patch 2) prove t/db_dependent/ImportBatch.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 12:53:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 11:53:47 +0000 Subject: [Koha-bugs] [Bug 35438] Importing records can create too large transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35438 --- Comment #7 from Kyle M Hall --- Created attachment 159443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159443&action=edit Bug 35438: Remove skip_intermediate_commit parameter It no longer does anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:01:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:01:25 +0000 Subject: [Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:01:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:01:27 +0000 Subject: [Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159091|0 |1 is obsolete| | Attachment #159092|0 |1 is obsolete| | Attachment #159093|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 159444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159444&action=edit Bug 35348: Add cookies link to opac footer This patch adds a link that opens the cookies info dialogue to the opac footer when the CookieConsent feature is enabled. Test plan 1) Enable CookieConsent 2) On the OPAC you should now see a 'Cookies' link at the bottom of the page. 3) Clicking the link should open the "Cookie consent" modal where you can see the details of the cookies you have accepted and change your choices. 4) Bonus points: Enable 'OpacProblemReports' and note it aligns left of 'Cookies' in the same footer bar. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:01:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:01:29 +0000 Subject: [Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 --- Comment #10 from Owen Leonard --- Created attachment 159445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159445&action=edit Bug 35348: Ensure users can access cookie details in staff client We remove the check on JSConsents content so that when cookie consent is enabled we retain the option for users to get more information about what cookies are being used. Test plan 1) Enable CookieConsents 2) Do not add any tracking cookies for the staff client into CookieConsentedJS preference 3) Note that 'My consents' appears in the user menu 4) Clicking 'My consents' opens the 'Cookie consent' modal displaying information about the cookies used. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:01:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:01:31 +0000 Subject: [Koha-bugs] [Bug 35348] Cookie information should be available regardless of whether you are logged in or not In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 --- Comment #11 from Owen Leonard --- Created attachment 159446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159446&action=edit Bug 35348: Remove cookie consents link from opac consents The cookies details modal is now visible for all users from a footer link, we no longer need it under the 'Consents' tab for logged in users. Test plan 1) Enable CookieConsent and add a placholder tracker cookie to CookieConsentedJS preference 2) Log into the OPAC 3) Note that the 'Consents' link no longer appears in the users page. 4) Enable 'PrivacyPolicyConsent' 5) Note that the 'Consents' link now appears but on navigating to it there is no link for Cookie consents. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:21:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:21:23 +0000 Subject: [Koha-bugs] [Bug 35458] Issues rules without value can cause problems when perform checkouts on many sites In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35458 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:21:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:21:55 +0000 Subject: [Koha-bugs] [Bug 30618] Important and mandatory select fields not highlighted on additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30618 Lari Strand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmstrand at gmail.com --- Comment #1 from Lari Strand --- As far as I can see, only the select2 elements are not highlighted after the page reloads when mandatory fields have not been filled. I couldn't locate how the "missing" properties to the elements' class are generated (like ), but if there was a check on whether the element is a pulldown list/any other type of element not getting highlighted, their styling could be processed separately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:29:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:29:34 +0000 Subject: [Koha-bugs] [Bug 35415] Rephrase: Some patrons have requested a privacy ... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35415 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:29:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:29:36 +0000 Subject: [Koha-bugs] [Bug 35415] Rephrase: Some patrons have requested a privacy ... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35415 --- Comment #3 from Owen Leonard --- Created attachment 159447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159447&action=edit Bug 35415: Rephrase: Some patrons have requested a privacy ... This patch revises the wording of the warning which is displayed on the 'About' page when the 'OPACPrivacy' system preference is enabled but the 'AnonymousPatron' preference is empty. The new phrasing is hopefully more clear. To test, apply the patch and go to Administration -> System preferences. - Search for 'AnonymousPatron' and enter a borrowernumber if necessary. - Log in to the OPAC and click the 'Privacy' tab in the left-hand sidebar of the user summary page. - Set your privacy rule to 'Never'. - Return to Admnistration -> Sytem preferences in the staff interface. - Search for 'OPACPrivacy' and set it to 'Allow'. - Clear the borrowernumber from the 'AnonymousPatron' preference. - Go to the 'About" page and open the 'System information' tab. - You should see an error message at the bottom: "Some patrons have requested privacy after their items are checked in, but the AnonymousPatron preference is not set correctly. Set it to a valid borrower number or checkins for these patrons will fail." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:36:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:36:43 +0000 Subject: [Koha-bugs] [Bug 34597] Expired patrons can still place ILL requests through OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34597 --- Comment #3 from Pedro Amorim --- Perhaps we could enhance BlockExpiredPatronOpacActions to be a selection list of multiple actions (place holds, place ILL requests, others) instead of just an on/off as it is currently. This would: 1) Be in line with existing behavior for those upgrading. 2) Extend existing behavior to potentially include placing an ILL request as a optional blocked action (among other possible actions). 3) Still allow libraries who wish to keep the possibility of placing holds for blocked patrons (as Nick mentioned) 4) Not be YASP. Thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:43:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:43:40 +0000 Subject: [Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310 --- Comment #29 from Pedro Amorim --- Hi Victor, thanks for your continued analysis on this issue. It did reveal itself to be a bit deeper than the simple bug it appeared to be initially. I believe I did address your last concern when I replied: (In reply to Pedro Amorim from comment #22) > I would say so, I don't think tackling the temporary inconsistency is > cost-effective, because the inconsistency only happens in the items page and > the items page only considers current checkouts. After an upgrade it's only > a matter of time until all current renewals exist in the checkout_renewals > table. > Patron circulation history shows everything. I may be incorrect in my way of thinking, but I addressed it, unless I misunderstood the issue you're mentioning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:49:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:49:32 +0000 Subject: [Koha-bugs] [Bug 30645] Patron search not building the query correctly for extended attributes if several terms passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 --- Comment #7 from Martin Renvoize --- After some consideration, I think we should put this into the API plugin side.. so REST/Plugin/Query.pm We already have the Mixin which does this for additional_fields with a filter_by_ method... though I'm not sure how well advertised/documented that is.. and I think it may well confuse object consumers later having this level of magic in the base class search method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:53:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:53:03 +0000 Subject: [Koha-bugs] [Bug 35460] New: Unable to add or edit hold rules in circulation rules table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Bug ID: 35460 Summary: Unable to add or edit hold rules in circulation rules table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: emmi.takkinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Adding or editing following columns in circulation rules table doesn't seem to work: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) To reproduce: 1. Create new rule or edit existing one. 2. Add or change values in following columns: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count 3. Save rule. => Note that columns have value "Unlimited" on them. If you check database, columns haven't been saved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:55:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:55:09 +0000 Subject: [Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 13:56:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 12:56:48 +0000 Subject: [Koha-bugs] [Bug 34597] Expired patrons can still place ILL requests through OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34597 --- Comment #4 from Nick Clemens --- (In reply to Pedro Amorim from comment #3) > Perhaps we could enhance BlockExpiredPatronOpacActions to be a selection > list of multiple actions (place holds, place ILL requests, others) instead > of just an on/off as it is currently. > > This would: > 1) Be in line with existing behavior for those upgrading. > 2) Extend existing behavior to potentially include placing an ILL request as > a optional blocked action (among other possible actions). > 3) Still allow libraries who wish to keep the possibility of placing holds > for blocked patrons (as Nick mentioned) > 4) Not be YASP. > > Thoughts? +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:00:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:00:39 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 --- Comment #1 from Emmi Takkinen --- It seems that bug 8367 dropped those columns at some point from smart-rules.pl and now the saving isn't working. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:04:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:04:59 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker --- Comment #2 from Katrin Fischer --- Hi Emmi, do you have a link to the broken database update? it should have only added a column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:06:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:06:53 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #13 from Owen Leonard --- Created attachment 159448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159448&action=edit Bug 34900: (follow-up) Correct last entry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:08:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:08:22 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 --- Comment #3 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #2) > Hi Emmi, do you have a link to the broken database update? it should have > only added a column. It's not really a database update that is broken https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158023 If you look changes made to smart-rules.pl variable my $rules, these columns have been dropped from there. I'm currently making a patch for this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:10:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:10:19 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at koha-suomi.fi |ity.org | --- Comment #4 from Emmi Takkinen --- Created attachment 159449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159449&action=edit Bug 35460: Fix add and edit of hold rules in circulation rules table Adding or editing following columns in circulation rules table didn't work: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) At some point those columns were dropped from list of saved columns in smart-rules.pl. To test: 1. Create new rule or edit existing one. 2. Add or change values in following columns: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count 3. Save rule. => Note that columns have value "Unlimited" on them. If you check database, columns haven't been saved. 4. Apply this patch. 5. Repeat steps 1. to 3. => Columns should now have values in them and they are saved to database. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:12:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:12:10 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |major --- Comment #5 from Katrin Fischer --- Thanks Emmi! (just was got scared for a moment there. Still not nice, but not AS evil) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:12:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:12:42 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33847 CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:12:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:12:42 +0000 Subject: [Koha-bugs] [Bug 33847] Database update replaces undefined rules with defaults rather than the value that would be used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33847 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35460 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:15:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:15:34 +0000 Subject: [Koha-bugs] [Bug 30645] Patron search not building the query correctly for extended attributes if several terms passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154949|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 159450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159450&action=edit Bug 30645: Add tests to highlight the problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:15:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:15:50 +0000 Subject: [Koha-bugs] [Bug 30645] Patron search not building the query correctly for extended attributes if several terms passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 --- Comment #9 from Jonathan Druart --- (In reply to Pedro Amorim from comment #6) > Joubu can you please rebase your test patch? Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:31:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:31:43 +0000 Subject: [Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:35:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:35:17 +0000 Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33171 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:35:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:35:17 +0000 Subject: [Koha-bugs] [Bug 33171] Add coded_location_qualifier, barcode, and enumchron to MarcItemFieldsToOrder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33171 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35026 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 [Bug 35026] Refactor addorderiso2709.pl to use object methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:35:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:35:37 +0000 Subject: [Koha-bugs] [Bug 35026] Refactor addorderiso2709.pl to use object methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35026 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |matt.blenkinsop at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:36:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:36:53 +0000 Subject: [Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159275|0 |1 is obsolete| | --- Comment #16 from Matt Blenkinsop --- Created attachment 159451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159451&action=edit Bug 34479: Move patron selection history to a re-useable file This patch takes some of the functionality for maintaining patron selections and moves it to a new file that can be used in other template files. It also introduces a new method for determining whether to delete the history after an operation is complete, along with an .inc file containing the checkbox that manages this Test plan: 1) Navigate to Patrons and run a search 2) Use the checkboxes to select some patrons and run the three different options in the menu bar: Add to patron list, Merge selected patrons, Batch patron modification. 3) For each operation, you should see a checkbox asking if you want to "Keep patrons selected for anew operation". N.B. For adding patrons to a list, you will only see this when selecting to add them to a new list 4) When you run the operations, if you select the checkbox to keep the patrons then when you return tho the patron search, those patrons should all be still selected. 5) If you don't check the box, when you return to the search, your patron selection history should be empty and no patrons should be selected N.B. If you have run a merge operation and elected to keep the patron history, you will only keep the patron who was kept Signed-off-by: Sharon Dugdale -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:45:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:45:13 +0000 Subject: [Koha-bugs] [Bug 35461] New: Renew All 66 SIP server response messages produce HASH content in replies Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 Bug ID: 35461 Summary: Renew All 66 SIP server response messages produce HASH content in replies Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: lmstrand at gmail.com QA Contact: testopia at bugs.koha-community.org "Renew All" -function aka. 65-66-messages work like this: 66-return messages has renewed items in BM-fields and non-renewables go into BN-fields. If all items were renewable, then the reply message looks like: Reply: 13.07.2022 10:06:17:530 OUTESTI1 6610005000020220713 100616AOOUPK|BM564N15977171|BM564N09203960|BM564N23261720|BM564N25161958|BM564N23455012|C4::SIP::SIPServer=HASHC4::SIP::SIPServer=HASHAY6AZCEFE If items include renewables and non-renewables, the response includes the renewed items first, then a HASH mixed into the first BN-field, then rest of the renewed ones like they should show in BN-fields and after that, anohter HASH: 13.07.2022 14:41:32:610 OUTESTI1 6610003000420220713 144130AOOUPK|BM564N23455012|BM564N23261720|BM564N25161958|C4::SIP::SIPServer=HASHBN564N09203960|BN564N04191259|BN564N15977171|BN564N13788332|C4::SIP::SIPServer=HASHAY8AZC7C5 If all loans were unrenewable (this test included just one item), you first get a HASH in a BN-field, and another at the end. 13.07.2022 14:49:00:037 OUTESTI1 6610000000120220713 144858AOOUPK|C4::SIP::SIPServer=HASHBN564N19874533|C4::SIP::SIPServer=HASHAY9AZDD3B Our self checkout/checkin machine can handle/parse these reply messages correctly, but this might not be the case with all self checkout/checkin devices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:55:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:55:34 +0000 Subject: [Koha-bugs] [Bug 35462] New: "savepoint_0 does not exist" when saving patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35462 Bug ID: 35462 Summary: "savepoint_0 does not exist" when saving patron Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When trying to save a new patron, clicking on "Save" sends me right back to the form for adding the new patron, but some of the information I entered is missing (at least firstname and cardnumber). There is no error message displayed. I see this in the logs: ==> /var/log/koha/konaturvard/plack-error.log <== DBIx::Class::Storage::DBI::mysql::_exec_svp_release(): DBI Exception: DBD::mysql::db do failed: SAVEPOINT savepoint_0 does not exist at /usr/share/koha/lib/Koha/Object.pm line 170 Patron creation failed! - DBIx::Class::Storage::DBI::mysql::_exec_svp_release(): DBI Exception: DBD::mysql::db do failed: SAVEPOINT savepoint_0 does not exist at /usr/share/koha/lib/Koha/Object.pm line 170 The code around /usr/share/koha/lib/Koha/Object.pm line 170 looks like this (in "sub store"): 169 try { 170 return $self->_result()->update_or_insert() ? $self : undef; 171 } The error "Patron creation failed!" comes from members/memberentry.pl: 424 ### Error checks should happen before this line. 425 $nok = $nok || scalar(@errors); 426 if ((!$nok) and $nodouble and ($op eq 'insert' or $op eq 'save')){ 427 my $success; 428 if ($op eq 'insert'){ 429 # we know it's not a duplicate borrowernumber or there would already be an error 430 delete $newdata{password2}; 431 $patron = eval { Koha::Patron->new(\%newdata)->store }; 432 if ( $@ ) { 433 # FIXME Urgent error handling here, we cannot fail without relevant feedback 434 # Lot of code will need to be removed from this script to handle exceptions raised by Koha::Patron->store 435 warn "Patron creation failed! - $@"; # Maybe we must die instead of just warn 436 push @messages, {error => 'error_on_insert_patron'}; 437 $op = "add"; This happens in two different instances on the same server, but not on other servers with similar setups. Koha version: 22.11.10-2 (Debian packages) OS: Ubuntu 18.04.6 LTS DB: 10.3.38-MariaDB-0ubuntu0.20.04.1-log Must be related to bug 26639, I guess. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:56:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:56:04 +0000 Subject: [Koha-bugs] [Bug 35462] "savepoint_0 does not exist" when saving patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35462 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26639 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 14:56:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 13:56:04 +0000 Subject: [Koha-bugs] [Bug 26639] Turn auto_savepoint ON In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26639 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35462 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:13:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:13:14 +0000 Subject: [Koha-bugs] [Bug 27667] Display the number of non-indexed records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667 Philip Orr changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/760 Documentation| |Philip Orr contact| | Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |philip.orr at lmscloud.de --- Comment #17 from Philip Orr --- Added to the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:17:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:17:43 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159449|0 |1 is obsolete| | --- Comment #6 from Emily Lamancusa --- Created attachment 159452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159452&action=edit Bug 35460: Fix add and edit of hold rules in circulation rules table Adding or editing following columns in circulation rules table didn't work: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) At some point those columns were dropped from list of saved columns in smart-rules.pl. To test: 1. Create new rule or edit existing one. 2. Add or change values in following columns: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count 3. Save rule. => Note that columns have value "Unlimited" on them. If you check database, columns haven't been saved. 4. Apply this patch. 5. Repeat steps 1. to 3. => Columns should now have values in them and they are saved to database. Sponsored-by: Koha-Suomi Oy Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:18:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:18:22 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:19:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:19:19 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Emily Lamancusa --- Going straight to PQA for this one - it's a small, straightforward change and an important fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:19:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:19:40 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:19:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:19:49 +0000 Subject: [Koha-bugs] [Bug 35463] New: Link preservation module help to the manual Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Bug ID: 35463 Summary: Link preservation module help to the manual Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Preservation Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org The "help" link in the new preservation module needs to point to the new preservation module chapter in the manual. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:20:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:20:12 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30708 Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 [Bug 30708] Creation of a new 'Preservation' module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:20:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:20:12 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35463 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 [Bug 35463] Link preservation module help to the manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:20:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:20:21 +0000 Subject: [Koha-bugs] [Bug 35462] "savepoint_0 does not exist" when saving patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35462 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #1 from Jonathan Druart --- Does it appear after an update? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:21:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:21:05 +0000 Subject: [Koha-bugs] [Bug 35462] "savepoint_0 does not exist" when saving patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35462 --- Comment #2 from Jonathan Druart --- We do no longer support U18 for Koha 22.11 btw. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:24:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:24:00 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:27:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:27:36 +0000 Subject: [Koha-bugs] [Bug 35462] "savepoint_0 does not exist" when saving patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35462 --- Comment #3 from Magnus Enger --- > Does it appear after an update? The issue was reported about month after the upgrade to 22.11, but I think these are fairly low traffic instances, so I'm guessing it wasn't discovered earlier. > We do no longer support U18 for Koha 22.11 btw. Yeah, this made me realize more upgrades are called for. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:39:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:39:20 +0000 Subject: [Koha-bugs] [Bug 35464] New: When importing records diff view implies imported records will overwrite even ignored Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35464 Bug ID: 35464 Summary: When importing records diff view implies imported records will overwrite even ignored Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Export some records form Koha 2 - Strip all the subject fields 3 - Stage for import - Set matching rule on 999 or isbn, whatever works - Set action when matching record found to ignore 4 - View the batch and see the matches 5 - Click the diff view 6 - It shows the imported record with subject stripped 7 - It shows the subject fields in the existing record crossed out 8 - This makes it look like the import will remove fields 9 - Import the batch 10 - Confirm the records are still complete, subject not removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:40:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:40:44 +0000 Subject: [Koha-bugs] [Bug 35440] Partial refund triggers a 500 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35440 --- Comment #5 from Katrin Fischer --- We also see this in 22.11.10 There were no partial refunds, but full refunds using the button in the transactions table: Exception 'Koha::Exceptions::ParameterTooHigh' thrown 'Combined reduction (2 + -2) is higher than original amount (2)' Exception 'Koha::Exceptions::ParameterTooHigh' thrown 'Combined reduction (3 + -3) is higher than original amount (3)' Exception 'Koha::Exceptions::ParameterTooHigh' thrown 'Combined reduction (3.00 + -3) is higher than original amount (3)' Which makes no mathematical sense to me actually? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:50:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:50:45 +0000 Subject: [Koha-bugs] [Bug 35440] Partial refund triggers a 500 error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35440 --- Comment #6 from Kyle M Hall --- (In reply to Katrin Fischer from comment #5) > We also see this in 22.11.10 > > There were no partial refunds, but full refunds using the button in the > transactions table: > > Exception 'Koha::Exceptions::ParameterTooHigh' thrown 'Combined reduction (2 > + -2) is higher than original amount (2)' > Exception 'Koha::Exceptions::ParameterTooHigh' thrown 'Combined reduction (3 > + -3) is higher than original amount (3)' > Exception 'Koha::Exceptions::ParameterTooHigh' thrown 'Combined reduction > (3.00 + -3) is higher than original amount (3)' > > Which makes no mathematical sense to me actually? The code uses absolute values which I think may be part of the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 15:52:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 14:52:23 +0000 Subject: [Koha-bugs] [Bug 35454] A bad RENEWAL notice breaks the ability to renew items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35454 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:07:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:07:59 +0000 Subject: [Koha-bugs] [Bug 33257] Suspended holds should be styled differently on moremember.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33257 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:08:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:08:23 +0000 Subject: [Koha-bugs] [Bug 35465] New: Ability to select multiple funds for a single order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35465 Bug ID: 35465 Summary: Ability to select multiple funds for a single order Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: cguenther at coloradocollege.edu QA Contact: testopia at bugs.koha-community.org Allow multiple funds to be selected for tracking payment on a single order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:11:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:11:54 +0000 Subject: [Koha-bugs] [Bug 34955] One Koha manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34955 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master CC| |tomascohen at gmail.com --- Comment #7 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #5) > Suggest we push an empty commit for this one to ensure it appears in the > release notes :) > > git commit --allow-empty -s -m "Bug 34955: One Koha Manual" Did this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:22:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:22:18 +0000 Subject: [Koha-bugs] [Bug 35415] Rephrase: Some patrons have requested a privacy ... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35415 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159447|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 159453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159453&action=edit Bug 35415: Rephrase: Some patrons have requested a privacy ... This patch revises the wording of the warning which is displayed on the 'About' page when the 'OPACPrivacy' system preference is enabled but the 'AnonymousPatron' preference is empty. The new phrasing is hopefully more clear. To test, apply the patch and go to Administration -> System preferences. - Search for 'AnonymousPatron' and enter a borrowernumber if necessary. - Log in to the OPAC and click the 'Privacy' tab in the left-hand sidebar of the user summary page. - Set your privacy rule to 'Never'. - Return to Admnistration -> Sytem preferences in the staff interface. - Search for 'OPACPrivacy' and set it to 'Allow'. - Clear the borrowernumber from the 'AnonymousPatron' preference. - Go to the 'About" page and open the 'System information' tab. - You should see an error message at the bottom: "Some patrons have requested privacy after their items are checked in, but the AnonymousPatron preference is not set correctly. Set it to a valid borrower number or checkins for these patrons will fail." Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:22:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:22:38 +0000 Subject: [Koha-bugs] [Bug 35415] Rephrase: Some patrons have requested a privacy ... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35415 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:23:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:23:20 +0000 Subject: [Koha-bugs] [Bug 24616] Cannot copy notice to another library if it already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24616 Philip Orr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |philip.orr at lmscloud.de Resolution|--- |FIXED --- Comment #23 from Philip Orr --- Since the "copy notice" function wasn't in the manual yet, I added some documentation for that. No need for documentation on this bug though since the error message is self-explanatory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:31:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:31:25 +0000 Subject: [Koha-bugs] [Bug 35426] Improve layout of bookings modal form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159312|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 159454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159454&action=edit Bug 35426: Improve layout of bookings modal form This patch changes the class on the bookings modal form's fieldset in order to make the form work better in the small space offered by the modal. Also changed: The hint for the patron search field has been moved below the field for consistency. To test, apply the patch and search for a title in the staff interface. - View the detail page. - If you don't see a "Place booking" button in the toolbar, click "Items" in the sidebar menu. - Locate the "Priority" heading, and change the "Bookable" setting to "Yes." - Click the "PLace booking" button in the toolbar. - The bookings modal form should appear, and the form layout should be improved. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:32:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:32:30 +0000 Subject: [Koha-bugs] [Bug 35426] Improve layout of bookings modal form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35426 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:35:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:35:29 +0000 Subject: [Koha-bugs] [Bug 35419] Update page title for bookings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35419 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159310|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 159455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159455&action=edit Bug 35419: Update page title for bookings This patch updates the structure of the Bookings list page so that the title can be better translated. To test, apply the patch and locate a bibliographic record in the staff interface catalog. - View the detail page. - If you don't see a "Place booking" button in the toolbar, click "Items" in the sidebar menu. - Locate the "Priority" heading, and change the "Bookable" setting to "Yes." - Click the "Bookings" menu item in the left-hand sidebar. - Check that the page title looks correct and consistent with breadcrumbs. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:35:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:35:47 +0000 Subject: [Koha-bugs] [Bug 35419] Update page title for bookings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35419 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:37:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:37:22 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 159456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159456&action=edit WIP adding preservation links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:41:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:41:59 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33346 CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:41:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:41:59 +0000 Subject: [Koha-bugs] [Bug 33346] Add Help link to Koha manual in ERM module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33346 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35463 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:42:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:42:33 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #2 from Martin Renvoize --- Added bug 33346 to the see also as an example of how vue module help works.. hope it helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:46:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:46:50 +0000 Subject: [Koha-bugs] [Bug 35350] Update label creator pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159051|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 159457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159457&action=edit Bug 35350: Update label creator pop-up windows with consistent footer markup This patch updates two label creator templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch. - Click the "Add items" button under the form. - A "Search for items" window should pop up. - The window's fixed footer should have the "Search" and "Close window" buttons. Test that each work correctly. - Submit a search which will return results. - The search results window should also have a fixed footer. I moved the "Add checked" and "Done" buttons out of a floating toolbar and put the controls there for consistency's sake. - Confirm that both controls work correctly. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:47:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:47:58 +0000 Subject: [Koha-bugs] [Bug 35350] Update label creator pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:56:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:56:22 +0000 Subject: [Koha-bugs] [Bug 35349] Reindent label item search template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35349 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #2 from Barbara Johnson --- The popup is displaying some unwanted info which looks like the following: <<<<<<< HEAD ======= You can see it in the attached screenshot circled in green. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:56:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:56:32 +0000 Subject: [Koha-bugs] [Bug 34591] Unable to add new item to exisiting item group from additems.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34591 Rhiana changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rmcompton at arlingtonva.us --- Comment #1 from Rhiana --- Just tested this. Adding an item to an item group only works when choosing "Add/Move to an item group" from the holdings table. Otherwise it doesn't show up or have any function in OPAC (Aspen) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 16:56:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 15:56:43 +0000 Subject: [Koha-bugs] [Bug 35349] Reindent label item search template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35349 --- Comment #3 from Barbara Johnson --- Created attachment 159458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159458&action=edit unwanted info in popup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:00:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:00:52 +0000 Subject: [Koha-bugs] [Bug 35349] Reindent label item search template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35349 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:02:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:02:13 +0000 Subject: [Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:05:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:05:34 +0000 Subject: [Koha-bugs] [Bug 35349] Reindent label item search template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35349 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Owen Leonard --- (In reply to Barbara Johnson from comment #2) > <<<<<<< HEAD ======= That's the kind of thing you'll see when a patch doesn't apply, but I tested it just now and it applies fine for me in master. Could you try again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:10:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:10:22 +0000 Subject: [Koha-bugs] [Bug 35383] Dragging and dropping subfield of repeated tags doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 --- Comment #7 from Slava Shishkin --- (In reply to Marcel de Rooy from comment #6) > You are welcome to improve it. Please do so on a new report. I think that > this patch can go in now in its current form. Your commitment is appreciated. Ok, then I'll leave it in its current state and start working on refactoring. I will create a new ticket for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:15:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:15:28 +0000 Subject: [Koha-bugs] [Bug 35443] Persistent encoding error message in Advanced Editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35443 --- Comment #3 from Esther Melander --- I was using 23.05.05. I tried editing the example record again this morning and the persistent warning message is now gone. Could there be some kind of caching happening? If it helps, I use the Brave browser. I believe this is likely connected to Bug 35181. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:19:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:19:08 +0000 Subject: [Koha-bugs] [Bug 35466] New: bulkmarcimport needs a parameter to skip indexing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35466 Bug ID: 35466 Summary: bulkmarcimport needs a parameter to skip indexing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart+koha at gmail.com, michaela.sieber at kit.edu, robin at catalyst.net.nz When using bulkmarcimport for migrations it does make sense to do a full reindex after finishing the import. At the moment the import will always create entries in background_jobs for Elasticsearch and in zebra_queue for Zebra. We should have a switch to turn this off if indexing is not required to increase performance and avoid unnecessary load. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:22:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:22:39 +0000 Subject: [Koha-bugs] [Bug 35453] Wrong 'Laserdisc)' string on 007 builder (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35453 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:26:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:26:05 +0000 Subject: [Koha-bugs] [Bug 35466] bulkmarcimport needs a parameter to skip indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35466 --- Comment #1 from Katrin Fischer --- We need to adjust the calls to: AddBiblio ModBiblio ModBiblioMarc AddItemBatchFromMarc And add the skip_record_index parameter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:26:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:26:49 +0000 Subject: [Koha-bugs] [Bug 35450] Punctuation: Preservation system preferences should end with a . In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:27:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:27:43 +0000 Subject: [Koha-bugs] [Bug 35131] Add scan-able barcode to the patron sidebar (patroninfo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35131 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:33:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:33:09 +0000 Subject: [Koha-bugs] [Bug 35131] Add scan-able barcode to the patron sidebar (patroninfo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35131 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:33:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:33:11 +0000 Subject: [Koha-bugs] [Bug 35131] Add scan-able barcode to the patron sidebar (patroninfo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35131 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158242|0 |1 is obsolete| | Attachment #158243|0 |1 is obsolete| | Attachment #158244|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 159459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159459&action=edit Bug 35131: Add new system preference and DBRev Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:33:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:33:21 +0000 Subject: [Koha-bugs] [Bug 35467] New: NewsLog should be renamed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35467 Bug ID: 35467 Summary: NewsLog should be renamed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The system preference NewsLog should indicate that it logs changes from news, html customizations, or pages. It should be renamed accordingly. AdditionalContentsLog ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:35:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:35:08 +0000 Subject: [Koha-bugs] [Bug 35450] Preservation system preferences should authval dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Punctuation: Preservation |Preservation system |system preferences should |preferences should authval |end with a . |dropdowns Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:37:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:37:27 +0000 Subject: [Koha-bugs] [Bug 35131] Add scan-able barcode to the patron sidebar (patroninfo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35131 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159459|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 159460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159460&action=edit Bug 35131: Add new system preference and DBRev Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:37:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:37:33 +0000 Subject: [Koha-bugs] [Bug 35131] Add scan-able barcode to the patron sidebar (patroninfo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35131 --- Comment #24 from Kyle M Hall --- Created attachment 159461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159461&action=edit Bug 35131: Show the patron cardnumber as a borcode in the patron record To test: 1. Apply patch, updatedatabase, yarn build, and restart services 2. Search for the system preference 'ShowBarcodeOnPatronRecord' and set it to something other than 'Don't show'. 3. Now go to any page that shows the 'patroninfo' section. ( circ/circulation.pl, members/moremember.pl, members/pay.pl, etc ) 4. Make sure this patron has a cardnumber. 5. From any of the aforementioned pages make sure you can see the patron barcode. 6. Try many different barcode types, making sure they each display well. 7. Remove the patron cardnumber and confirm that nothing displays. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:37:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:37:35 +0000 Subject: [Koha-bugs] [Bug 35131] Add scan-able barcode to the patron sidebar (patroninfo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35131 --- Comment #25 from Kyle M Hall --- Created attachment 159462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159462&action=edit Bug 35131: Fix preference description and move barcode to bottom of patroninfo Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:41:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:41:13 +0000 Subject: [Koha-bugs] [Bug 35450] Preservation system preferences should authval dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:41:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:41:15 +0000 Subject: [Koha-bugs] [Bug 35450] Preservation system preferences should authval dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 --- Comment #2 from Owen Leonard --- Created attachment 159463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159463&action=edit Bug 35450: Preservation system preferences should authval dropdowns This patch updates two preservation module system preferences so that they offer dropdowns of "Not for loan" values instead of requiring entry of a specific code. The patch also adds a missing "." at the end of one preference description. To test, apply the patch and restart services. - Go to Administration -> System preferences. - Search for "preservation" - Check that the "PreservationNotForLoanDefaultTrainIn" and "PreservationNotForLoanWaitingListIn" preferences have dropdowns offering "Not for loan" values. - Confirm that your choices are correctly saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:46:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:46:19 +0000 Subject: [Koha-bugs] [Bug 34469] Modifying an order line of a standing order will delete linked invoice ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34469 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6819, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6729 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:46:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:46:19 +0000 Subject: [Koha-bugs] [Bug 6819] Don't offer cancel order links for received order lines on basket summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6819 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34469 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:46:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:46:19 +0000 Subject: [Koha-bugs] [Bug 6729] Block received order lines from editing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6729 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34469 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:46:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:46:24 +0000 Subject: [Koha-bugs] [Bug 35449] Accessibility: No links on "here" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:52:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:52:59 +0000 Subject: [Koha-bugs] [Bug 35449] Accessibility: No links on "here" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:53:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:53:01 +0000 Subject: [Koha-bugs] [Bug 35449] Accessibility: No links on "here" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 --- Comment #3 from Owen Leonard --- Created attachment 159464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159464&action=edit Bug 35449: Accessibility: No links on "here" This patch updates two system preferences, "OPACUserJS" and "OPACUserCSS" so that the "here" links in the description instead read "library administration". To test, apply the patch and go to Administration -> System preferences. - Search for "opacuser" - The descriptions of the "OPACUserJS" and "OPACUserCSS" preferences should include the phrase "...can be defined in library administration," with "library administration" leading to the correct page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 17:55:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 16:55:03 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 --- Comment #8 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #5) > Thanks Emmi! > > (just was got scared for a moment there. Still not nice, but not AS evil) Sorry for that :D but yeah, it's not _that_ bad situation but quite nasty still. Those columns are easy to miss since they are at the end of table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:01:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:01:16 +0000 Subject: [Koha-bugs] [Bug 35350] Update label creator pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159457|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 159465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159465&action=edit Bug 35350: Update label creator pop-up windows with consistent footer markup This patch updates two label creator templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch. - Click the "Add items" button under the form. - A "Search for items" window should pop up. - The window's fixed footer should have the "Search" and "Close window" buttons. Test that each work correctly. - Submit a search which will return results. - The search results window should also have a fixed footer. I moved the "Add checked" and "Done" buttons out of a floating toolbar and put the controls there for consistency's sake. - Confirm that both controls work correctly. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:01:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:01:56 +0000 Subject: [Koha-bugs] [Bug 35350] Update label creator pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159465|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 159466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159466&action=edit Bug 35350: Update label creator pop-up windows with consistent footer markup This patch updates two label creator templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. To test, apply the patch and go to Cataloging -> Label creator. - Click New -> Label batch. - Click the "Add items" button under the form. - A "Search for items" window should pop up. - The window's fixed footer should have the "Search" and "Close window" buttons. Test that each work correctly. - Submit a search which will return results. - The search results window should also have a fixed footer. I moved the "Add checked" and "Done" buttons out of a floating toolbar and put the controls there for consistency's sake. - Confirm that both controls work correctly. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:02:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:02:49 +0000 Subject: [Koha-bugs] [Bug 35350] Update label creator pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35350 --- Comment #5 from Barbara Johnson --- I tested it on a new sandbox and it worked great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:04:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:04:27 +0000 Subject: [Koha-bugs] [Bug 35349] Reindent label item search template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35349 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Barbara Johnson --- I tested it on a new sandbox and it worked great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:26:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:26:13 +0000 Subject: [Koha-bugs] [Bug 35260] Review batch checkout page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35260 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:26:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:26:15 +0000 Subject: [Koha-bugs] [Bug 35260] Review batch checkout page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35260 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158573|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 159467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159467&action=edit Bug 35260: Revise structure of the batch checkout page This patch makes some changes to the style and structure of the batch checkout page in order to make it more usable. To test, apply the patch and rebuild the staff interface CSS. Clear your browser cache if necessary. - Make sure the BatchCheckouts preference is enabled and that the BatchCheckoutsValidCategories has some categories selected. - Locate a patron and open the batch checkout page. - Test the process of checking out to the patron both by entering barcodes into the textarea and by uploading a file. Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:26:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:26:35 +0000 Subject: [Koha-bugs] [Bug 35436] Copy is not translatable in OPAC search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:26:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:26:37 +0000 Subject: [Koha-bugs] [Bug 35436] Copy is not translatable in OPAC search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159388|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 159468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159468&action=edit Bug 35436: Copy is not translatable in OPAC Search History Test plan 1 Enter in OPAC Search History in a language other than English and check that Copy is not translated 2 Apply patch, restart services 3 Regenerate the templates for that language 4 Repeat step 1 and check that Copy appears now translated Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:28:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:28:17 +0000 Subject: [Koha-bugs] [Bug 35376] Rephrase: Be careful removing attribute to this processing, the items using it will be impacted as well! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35376 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:28:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:28:19 +0000 Subject: [Koha-bugs] [Bug 35376] Rephrase: Be careful removing attribute to this processing, the items using it will be impacted as well! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35376 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159325|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 159469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159469&action=edit Bug 35376: Rephrase "be careful..." Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:33:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:33:53 +0000 Subject: [Koha-bugs] [Bug 35376] Rephrase: Be careful removing attribute to this processing, the items using it will be impacted as well! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35376 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:37:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:37:14 +0000 Subject: [Koha-bugs] [Bug 35428] gulp po tasks do not clean temporary files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35428 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:41:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:41:38 +0000 Subject: [Koha-bugs] [Bug 35428] gulp po tasks do not clean temporary files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35428 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:41:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:41:40 +0000 Subject: [Koha-bugs] [Bug 35428] gulp po tasks do not clean temporary files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35428 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159318|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 159470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159470&action=edit Bug 35428: Remove temporary files for gulp po tasks gulp po:update will generate 1 /tmp/koha-* directory per task. We need to remove them when the script does not longer need them. Test plan: 0. Do not apply this patch 1. ls -ltr /tmp 2. gulp po:update --lang es-ES 3. ls -ltr /tmp => Notice new koha-* directories Repeat 2, 3 4. Apply this patch and try again => No new directories when the job is done Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:47:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:47:07 +0000 Subject: [Koha-bugs] [Bug 35468] New: Bookings permission mismatch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35468 Bug ID: 35468 Summary: Bookings permission mismatch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com git grep manage_bookings The api routes require: parameters: manage_bookings The permission is defined as: circulate: manage_bookings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:47:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:47:22 +0000 Subject: [Koha-bugs] [Bug 35468] Bookings permission mismatch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35468 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com Depends on| |29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:47:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:47:22 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35468 [Bug 35468] Bookings permission mismatch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:49:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:49:36 +0000 Subject: [Koha-bugs] [Bug 34091] Typo in help for cleanupdatabase.pl: --log-modules needs to be --log-module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34091 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |fridolin.somers at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:51:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:51:15 +0000 Subject: [Koha-bugs] [Bug 35469] New: Cannot create bookings without circulation permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35469 Bug ID: 35469 Summary: Cannot create bookings without circulation permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When attempting to place a booking on an item in the catalogue a user needs several permissions: 1 - Patron search permissions (see bug 29503) 2 - circulate: manage_bookings 3 - circulate_ circulate_remaning_permissions If you don't have the third, the loading of patrons seems to die on looking up checkouts via the api - this prevents the JS from enabling the 'Period' field for choosing booking dats and the booking cannot proceed. That third permission is not expected I think -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:51:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:51:28 +0000 Subject: [Koha-bugs] [Bug 35469] Cannot create bookings without circulation permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35469 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com Depends on| |29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:51:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:51:28 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35469 [Bug 35469] Cannot create bookings without circulation permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:57:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:57:46 +0000 Subject: [Koha-bugs] [Bug 34091] Typo in help for cleanupdatabase.pl: --log-modules needs to be --log-module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34091 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:57:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:57:48 +0000 Subject: [Koha-bugs] [Bug 34091] Typo in help for cleanupdatabase.pl: --log-modules needs to be --log-module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34091 --- Comment #1 from Fridolin Somers --- Created attachment 159471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159471&action=edit Bug 34091: Fix typo log-modules in help for cleanupdatabase.pl This parameter is actually --log-module. Test plan : Run misc/cronjobs/cleanup_database.pl -h Confirm you see --log-module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:57:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:57:55 +0000 Subject: [Koha-bugs] [Bug 34862] blocking_errors.inc not included everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:57:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:57:57 +0000 Subject: [Koha-bugs] [Bug 34862] blocking_errors.inc not included everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155997|0 |1 is obsolete| | Attachment #158755|0 |1 is obsolete| | Attachment #158756|0 |1 is obsolete| | Attachment #158757|0 |1 is obsolete| | Attachment #158758|0 |1 is obsolete| | Attachment #158759|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 159472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159472&action=edit Bug 34862: [DO NOT PUSH] add script Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:58:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:58:05 +0000 Subject: [Koha-bugs] [Bug 34862] blocking_errors.inc not included everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #19 from Kyle M Hall --- Created attachment 159473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159473&action=edit Bug 34862: Remove blocking_errors where there is no main Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:58:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:58:08 +0000 Subject: [Koha-bugs] [Bug 34862] blocking_errors.inc not included everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #20 from Kyle M Hall --- Created attachment 159474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159474&action=edit Bug 34862: Include messages.inc Generated using `perl add_blocking_errors.pl` Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:58:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:58:11 +0000 Subject: [Koha-bugs] [Bug 34862] blocking_errors.inc not included everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #21 from Kyle M Hall --- Created attachment 159475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159475&action=edit Bug 34862: Add messages.inc Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:58:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:58:13 +0000 Subject: [Koha-bugs] [Bug 34862] blocking_errors.inc not included everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #22 from Kyle M Hall --- Created attachment 159476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159476&action=edit Bug 34862: Manual changes Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 18:58:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 17:58:15 +0000 Subject: [Koha-bugs] [Bug 34862] blocking_errors.inc not included everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34862 --- Comment #23 from Kyle M Hall --- Created attachment 159477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159477&action=edit Bug 34862: (follow-up) Fix some misplaced messages and add missing This patch fixes some templates where the messages include was appearing in the wrong place, for instance above the left-hand sidebar instead of at the top of the main content. The patch also adds the new include to some templates which lacked it. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 20:11:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 19:11:35 +0000 Subject: [Koha-bugs] [Bug 35470] New: 23.05 button class update Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35470 Bug ID: 35470 Summary: 23.05 button class update Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: ddaghita at mckinneytexas.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 159478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159478&action=edit update and sql run button reports I used CSS to change the color of "Update and Run SQL Button" in the reports sections, but it uses a generic button class id. It changes the color of more buttons in different modules like cataloging and circulation. Can I have it be a more specialized button class id ex: .btn.btn-default change it to .btn.btn-default-sqlrunning Below is the CSS code: /* Speed Green Update and Run Sql button */ .btn.btn-default { background-color: #7CFC00; } Maybe I there is a button class id that is there I just choose the wrong one. Let me know what would be a good resolution. Thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 20:12:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 19:12:05 +0000 Subject: [Koha-bugs] [Bug 35470] 23.05 button class update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35470 --- Comment #1 from Dave --- Created attachment 159479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159479&action=edit more buttons chaged color -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 20:25:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 19:25:27 +0000 Subject: [Koha-bugs] [Bug 34091] Typo in help for cleanupdatabase.pl: --log-modules needs to be --log-module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34091 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 20:25:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 19:25:29 +0000 Subject: [Koha-bugs] [Bug 34091] Typo in help for cleanupdatabase.pl: --log-modules needs to be --log-module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34091 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159471|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159480&action=edit Bug 34091: Fix typo log-modules in help for cleanupdatabase.pl This parameter is actually --log-module. Test plan : Run misc/cronjobs/cleanup_database.pl -h Confirm you see --log-module Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 20:48:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 19:48:31 +0000 Subject: [Koha-bugs] [Bug 35449] Accessibility: No links on "here" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 20:48:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 19:48:34 +0000 Subject: [Koha-bugs] [Bug 35449] Accessibility: No links on "here" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159464|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 159481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159481&action=edit Bug 35449: Accessibility: No links on "here" This patch updates two system preferences, "OPACUserJS" and "OPACUserCSS" so that the "here" links in the description instead read "library administration". To test, apply the patch and go to Administration -> System preferences. - Search for "opacuser" - The descriptions of the "OPACUserJS" and "OPACUserCSS" preferences should include the phrase "...can be defined in library administration," with "library administration" leading to the correct page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 20:49:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 19:49:13 +0000 Subject: [Koha-bugs] [Bug 35450] Preservation system preferences should authval dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159463|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 159482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159482&action=edit Bug 35450: Preservation system preferences should authval dropdowns This patch updates two preservation module system preferences so that they offer dropdowns of "Not for loan" values instead of requiring entry of a specific code. The patch also adds a missing "." at the end of one preference description. To test, apply the patch and restart services. - Go to Administration -> System preferences. - Search for "preservation" - Check that the "PreservationNotForLoanDefaultTrainIn" and "PreservationNotForLoanWaitingListIn" preferences have dropdowns offering "Not for loan" values. - Confirm that your choices are correctly saved. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 20:49:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 19:49:29 +0000 Subject: [Koha-bugs] [Bug 35450] Preservation system preferences should authval dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 21:02:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 20:02:57 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Andrew Fuerste-Henry --- With this new patch, I did the following: - create a user with catalogue, circulate_remaining_permissions, and list_borrowers permissions - log into the staff client as that user - in the Checkout field of mainpage.pl, search for "a" (with superlibrarian permissions, this returns all patrons with "a" in their name") - Koha takes you to the search results page, but shows no results and gives message "Something went wrong when loading this table. 403: Forbidden" - go back to the homepage and enter "Henry" in the Checkout box (in the default sandbox data this name finds only one patron and should take you straight to them) - Koha again takes you to the search results page and gives a 403 error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 21:17:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 20:17:12 +0000 Subject: [Koha-bugs] [Bug 34977] Allow to delete multiple patron lists at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Salah Ghedda changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158349|0 |1 is obsolete| | --- Comment #9 from Salah Ghedda --- Created attachment 159483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159483&action=edit Bug 34977: The "Patron Lists" only allows deleting one list at a time In the patrons lists, it's only possible to delete on list at a time. This patch add the possibility to select lists and delete them at once. TEST PLAN 1. Apply the patch. 2. Create at least 2 patron lists (Navigate to Tools > Patron lists > New patron list). 3. Select the lists you want to delete. 4. Click the "Delete selected lists" button. 5. Confirm that the selected lists have been deleted. 6. Ensure that the button cannot be used if no list is selected. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 21:17:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 20:17:15 +0000 Subject: [Koha-bugs] [Bug 34977] Allow to delete multiple patron lists at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 Salah Ghedda changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158350|0 |1 is obsolete| | --- Comment #10 from Salah Ghedda --- Created attachment 159484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159484&action=edit Bug 34977: (QA follow-up) Tidy code Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 21:17:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 20:17:41 +0000 Subject: [Koha-bugs] [Bug 34977] Allow to delete multiple patron lists at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34977 --- Comment #11 from Salah Ghedda --- Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 22:18:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 21:18:08 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla at bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 22:47:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 21:47:20 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 22:47:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 21:47:22 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159456|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose --- Created attachment 159485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159485&action=edit Bug 35463: Link preservation module help to the manual This patch links the various pages of the preservation module to each specific section of the preservation module chapter in the manual. To test: 1. Enable the PreservationModule system preference 2. Go to the Preservation module 3. Click "help" in the top right corner --> You are brought to the manual, but not a specific page 4. Apply patch 5. Click "Help" in the top right corner --> You are brought to the Preservation chapter of the manual 6. Click "Settings" 7. Click "Help" in the top right corner --> You are brought to the Settings section of the Preservation chapter of the manual 8. Choose a not for loan status for items added to the waiting list (the mandatory field) and submit 9. Click "Add a new processing" 10. Click "Help" in the top right corner --> You are brought to the Add a new processing section of the Preservation chapter of the manual 11. Fill out the form to create the processing and submit 12. Click "Edit this processing" 13. Click "Help" in the top right corner --> You are brought to the Add a new processing section of the Preservation chapter of the manual (there is no edit a processing section) 14. Click "Waiting list" 15. Click "Help" in the top right corner --> You are brought to the Waiting list section of the Preservation chapter of the manual 16. Add items to the waiting list 17. Click "Trains" 18. Click "Help" in the top right corner --> You are brought to the Trains section of the Preservation chapter of the manual 19. Click "New train" 20. Click "Help" in the top right corner --> You are brought to the New train section of the Preservation chapter of the manual 21. Fill out the form to create a new train and submit 22. Click "Add items" 23. Click "Help" in the top right corner --> You are brought to the Add items section of the Preservation chapter of the manual 24. Also check ERM help links to make sure nothing is broken Bug 35463: Link preservation module help to the manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 22:48:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 21:48:34 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #4 from Caroline Cyr La Rose --- I hope I did everything OK. There was a lot of new stuff here for me, and I even had to ask chatgpt for help with perl lol! Let me know if I need to change something -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 22:49:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 21:49:44 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch links the release notes| |various pages of the | |preservation module to each | |specific section of the | |preservation module chapter | |in the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 1 23:41:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 22:41:12 +0000 Subject: [Koha-bugs] [Bug 35471] New: Automatically select child MARC framework when adding child records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Bug ID: 35471 Summary: Automatically select child MARC framework when adding child records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Some libraries create their own MARC frameworks for component/child records. When adding a child record through host record, Koha currently selects the default MARC framework and a librarian must manually change to the child record framework. This Bug adds a parent-child relationship to MARC frameworks and aims to skip the manual step of selecting child record framework. The goal is to automatically select child MARC framework when adding child record through the host record. To reproduce problem: Administration -> MARC bibliographic framework 1. Create framework with frameworkcode "A" 2. Create framework with frameworkcode "A-child" Record view 1. Save record with framework "A" 2. Navigate to a record 3. Click "+ New", a drop-down opens 4. Click "New child record" 5. After add biblio form opens, click "Settings" 6. Observe default framework selected 7. You must manually select "A-child framework" After this change, To test: Administration -> MARC bibliographic framework 1. Create framework with frameworkcode "A" 2. Create framework with frameworkcode "A-child" 3. Set "A" as "A-child" 's parent framework Record view 1. Save record with framework "A" 2. Navigate to a record 3. Click "+ New", a drop-down opens 4. Click "New child record" 5. After add biblio form opens, click "Settings" 6. Observe "A-child" framework automatically selected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:07:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:07:21 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:07:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:07:23 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 --- Comment #1 from Lari Taskula --- Created attachment 159486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159486&action=edit Bug 35471: Add column parent_frameworkcode to table biblio_framework Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:07:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:07:26 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 --- Comment #2 from Lari Taskula --- Created attachment 159487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159487&action=edit Bug 35471: DBIx changes Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:07:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:07:28 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 --- Comment #3 from Lari Taskula --- Created attachment 159488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159488&action=edit Bug 35471: Add support for selecting parent framework on MARC framework modification screen To test: 1. Navigate to Administration -> MARC bibliographic framework 2. Create MARC framework with frameworkcode "A" 3. Observe new field "Parent framework" when adding a new framework 4. After adding the framework, click Actions -> MARC structure 5. Select "Create framework for A" using "Default", click OK 6. Navigate back to frameworks listing 7. Create framework with frameworkcode "A-1" 8. Select framework you created at step 2 as the parent framework 9. After adding the framework, click Actions -> MARC structure 10. Select "Create framework for A-1" using "Default", click OK Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:07:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:07:30 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 --- Comment #4 from Lari Taskula --- Created attachment 159489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159489&action=edit Bug 35471: List child frameworks on MARC modification screen 1. Navigate to Administration -> MARC bibliographic framework 2. Select the parent framework you added in previous patch 3. Observe child framework being listed Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:07:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:07:33 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 --- Comment #5 from Lari Taskula --- Created attachment 159490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159490&action=edit Bug 35471: List parent frameworks on MARC framework list screen 1. Navigate to Administration -> MARC bibliographic framework 2. Observe new column "Parent framework" 3. Observe parent framework being populated for the child framework you added in previous patch Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:07:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:07:35 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 --- Comment #6 from Lari Taskula --- Created attachment 159491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159491&action=edit Bug 35471: Add Koha::Template::Plugin::Frameworks->GetChildren() To test: 1. prove t/db_dependent/Koha/Template/Plugin/Frameworks.t Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:07:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:07:37 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 --- Comment #7 from Lari Taskula --- Created attachment 159492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159492&action=edit Bug 35471: Add child frameworks to cataloguing toolbar's new child record button To test: Administration -> MARC bibliographic framework 1. Create framework with frameworkcode "A" 2. Create framework with frameworkcode "A-child" 3. Set "A" as "A-child" 's parent framework Record view 1. Save record with framework "A" 2. Navigate to a record 3. Click "+ New", a drop-down opens 4. Click "New child record" 5. After add biblio form opens, click "Settings" 6. Observe "A-child" framework automatically selected Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:08:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:08:08 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:14:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:14:08 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159492|0 |1 is obsolete| | --- Comment #8 from Lari Taskula --- Created attachment 159493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159493&action=edit Bug 35471: Add child frameworks to cataloguing toolbar's new child record button To test: Administration -> MARC bibliographic framework 1. Create framework with frameworkcode "A" 2. Create framework with frameworkcode "A-1" 3. Set "A" as "A-1" 's parent framework Record view 1. Save record with framework "A" 2. Navigate to a record 3. Click "+ New", a drop-down opens 4. Click "New child record" 5. After add biblio form opens, click "Settings" 6. Observe "A-1" framework automatically selected Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:16:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:16:09 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159486|0 |1 is obsolete| | --- Comment #9 from Lari Taskula --- Created attachment 159494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159494&action=edit Bug 35471: Add column parent_frameworkcode to table biblio_framework Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:16:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:16:11 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159487|0 |1 is obsolete| | --- Comment #10 from Lari Taskula --- Created attachment 159495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159495&action=edit Bug 35471: DBIx changes Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:16:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:16:13 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159488|0 |1 is obsolete| | --- Comment #11 from Lari Taskula --- Created attachment 159496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159496&action=edit Bug 35471: Add support for selecting parent framework on MARC framework modification screen To test: 1. Navigate to Administration -> MARC bibliographic framework 2. Create MARC framework with frameworkcode "A" 3. Observe new field "Parent framework" when adding a new framework 4. After adding the framework, click Actions -> MARC structure 5. Select "Create framework for A" using "Default", click OK 6. Navigate back to frameworks listing 7. Create framework with frameworkcode "A-1" 8. Select framework you created at step 2 as the parent framework 9. After adding the framework, click Actions -> MARC structure 10. Select "Create framework for A-1" using "Default", click OK Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:16:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:16:16 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159489|0 |1 is obsolete| | --- Comment #12 from Lari Taskula --- Created attachment 159497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159497&action=edit Bug 35471: List child frameworks on MARC modification screen 1. Navigate to Administration -> MARC bibliographic framework 2. Select the parent framework you added in previous patch 3. Observe child framework being listed Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:16:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:16:18 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159490|0 |1 is obsolete| | --- Comment #13 from Lari Taskula --- Created attachment 159498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159498&action=edit Bug 35471: List parent frameworks on MARC framework list screen 1. Navigate to Administration -> MARC bibliographic framework 2. Observe new column "Parent framework" 3. Observe parent framework being populated for the child framework you added in previous patch Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:16:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:16:21 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159491|0 |1 is obsolete| | --- Comment #14 from Lari Taskula --- Created attachment 159499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159499&action=edit Bug 35471: Add Koha::Template::Plugin::Frameworks->GetChildren() To test: 1. prove t/db_dependent/Koha/Template/Plugin/Frameworks.t Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 00:16:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Dec 2023 23:16:23 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159493|0 |1 is obsolete| | --- Comment #15 from Lari Taskula --- Created attachment 159500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159500&action=edit Bug 35471: Add child frameworks to cataloguing toolbar's new child record button To test: Administration -> MARC bibliographic framework 1. Create framework with frameworkcode "A" 2. Create framework with frameworkcode "A-1" 3. Set "A" as "A-1" 's parent framework Record view 1. Save record with framework "A" 2. Navigate to a record 3. Click "+ New", a drop-down opens 4. Click "New child record" 5. After add biblio form opens, click "Settings" 6. Observe "A-1" framework automatically selected Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 01:52:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Dec 2023 00:52:32 +0000 Subject: [Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310 --- Comment #30 from Victor Grousset/tuxayo --- > I believe I did address your last concern when I replied: > Patron circulation history shows everything. Ah yes, indeed it w -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 01:53:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Dec 2023 00:53:22 +0000 Subject: [Koha-bugs] [Bug 35310] Current renewals 'view' link doesnt work if renewals correspond to an item no longer checked out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35310 --- Comment #31 from Victor Grousset/tuxayo --- as about that! (accidental tab strike!) Thanks all for the contributions here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 02:01:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Dec 2023 01:01:03 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 carthur at slolibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur at slolibrary.org --- Comment #13 from carthur at slolibrary.org --- Hi, We're [SLO County Libraries] also interested in having this feature added to the Suggest a Title module. Thank you, Charlie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 05:26:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Dec 2023 04:26:37 +0000 Subject: [Koha-bugs] [Bug 35159] New edit item limitation to library groups also prevents batch modification of items owned by other libraries. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35159 holly at bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |holly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 11:00:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Dec 2023 10:00:23 +0000 Subject: [Koha-bugs] [Bug 34174] Saving RIS results to Error 505 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34174 --- Comment #10 from Eugene Espinoza --- Great work everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 17:10:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Dec 2023 16:10:37 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 2 17:11:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Dec 2023 16:11:01 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 16:43:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 15:43:01 +0000 Subject: [Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to * In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Failed QA --- Comment #21 from Victor Grousset/tuxayo --- pending comment 18 (perltidy unhappy) and comment 20 (test plan needed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 17:40:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 16:40:56 +0000 Subject: [Koha-bugs] [Bug 32477] Hiding batch item modification columns isn't remembered correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32477 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #12 from Victor Grousset/tuxayo --- So, still needs work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 20:36:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 19:36:32 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 20:36:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 19:36:35 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158074|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 159501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159501&action=edit Bug 34900: Simplify text of about page license information This patch simplifies the language describing third-party libraries and their licenses so that translation are not so complicated. The patch also removes information about some assets which are no longer part of Koha. The license information now lists only the library name, version (if possible) and license. To test, apply the patch and go to the about page in the staff interface. Open the "Licenses" tab and check the content. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 20:36:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 19:36:38 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159448|0 |1 is obsolete| | --- Comment #15 from David Nind --- Created attachment 159502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159502&action=edit Bug 34900: (follow-up) Correct last entry Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 20:36:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 19:36:41 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #16 from David Nind --- Created attachment 159503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159503&action=edit Bug 34900: (follow-up) List alphabetically and tidy ups Listed in alphabetical order (except for Koha, which is listed at the start). Tidy ups and consistency changes: - end of each entry: remove full stops - separator between software and license: use a colon - headings for software/library name: use sentence case unless a noun, abbreviation, or the actual software name - http and https: use https where site uses it - URLs: update where required - license names: use consistent full names with title case Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 20:50:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 19:50:37 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #17 from David Nind --- I probably got a bit carried away with the follow-up - possibly outside the scope of the bug? Happy to put in a separate bug! License names: I used the full name and made consistent (for example: MIT License, instead of MIT or MIT license; GNU General Public License vX, instead of GPL or General public license). I did think about using abbreviations used at https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository or https://opensource.org/licenses/ Hopefully this helps a bit with translation. Questions for other bugs, if required: - Should the version of a piece of software be shown? A few do. - Should we have a short description of what they do, where they are used in Koha? - Should we change to a bullet list? - Versions of libraries: many seem quite old or not updated for a while. . Should I create an omnibus bug to update? . Should we update all libraries used at the start of a cycle? (The biggies, such as Bootstrap and jQuery, might be more problematic.) . Or do we have a "if it isn't broken, don't fix it" approach, unless there are security updates? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 23:14:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 22:14:05 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 23:14:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 22:14:09 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159277|0 |1 is obsolete| | --- Comment #53 from David Nind --- Created attachment 159504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159504&action=edit Bug 14293: The suspension should be calculated in days There was a mismatch between bug 13909 and bug 5549. The get_chargeable_units call from _debar_user_on_return should specify that we want a suspension in days. However I don't understand the comment let by the author of bug 5549 f61a9617184ec4b24100c1d99150bfd4ebf13336 1/ > finedays is in days, so hourly loans must multiply by 24 Yes but the suspension is in days, so no need to * 24 2/ And we should have a look on this one too: > grace period is measured in the same units as the loan But the grace period is always in days. On the circ rules the column is "Fine grace period (day)". I think we should replace DateTime::Duration->new( $unit => $issuingrule->{firstremind} ); with DateTime::Duration->new( days => $issuingrule->{firstremind} ); Anyway, we definitelly need more tests in this area! Test plan: 1/ Define an issuing rule with a unit=hour 2/ Set a suspension in days 3/ Check an item out and specify a past due date. 4/ Check the item in 5/ The patron should be debarred correctly Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 23:17:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 22:17:24 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #54 from David Nind --- Testing notes (using koha-testing-docker): 1. Tests pass for me: prove t/db_dependent/Circulation/maxsuspensiondays.t 2. Use the same test plan as in comment#49 Maybe the code changes made need to be tidied using Perltidy? (https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy and https://wiki.koha-community.org/wiki/Perltidy) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 23:34:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 22:34:19 +0000 Subject: [Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 23:34:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 22:34:22 +0000 Subject: [Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156509|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 159505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159505&action=edit Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the record matching rules administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Some controls on this page have been updated to use Bootstrap link style with Font Awesome icons added. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Record matching rules - New record matching rule - Edit record matching rule - Delete record matching rule - Test the process of adding new match points and new match checks, and removing match points and match checks. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 23:35:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 22:35:18 +0000 Subject: [Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- (In reply to Katy Maydon from comment #2) > Testing on 02/11/23: > ... > I don't know if this is an issue, but when you add a new match check or > point, remove it and then add another it adds "2" then when you remove 2, it > adds "3" instead of another 2, even though you didn't save the original "2". Hi Katy. It does this before the patch, so I think that would be a separate bug. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 3 23:40:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 22:40:27 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from David Nind --- Changing status to Failed QA - see comment#2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 00:15:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Dec 2023 23:15:13 +0000 Subject: [Koha-bugs] [Bug 14156] Add id tags to each MARC note in the display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14156 --- Comment #11 from Katrin Fischer --- Why only staff interface? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 02:42:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 01:42:25 +0000 Subject: [Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 02:42:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 01:42:28 +0000 Subject: [Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158886|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 159510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159510&action=edit Bug 35322: Fix the logic for checking for holds in CanBookBeIssued We are having reports that AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP no longer work. It appreas that in CanBookBeIssued, the ignore reserves check was changed from "check reserves unless the ignore reserves flag was passed" to "check reserves unless the ignore reserves flag was passed *and* we have a recall". I think this was a logic mistake and we want to check reserves unless we have an ignore flag *or* there is a recall. Test Plan: 1) Enable AllowItemsOnHoldCheckoutSCO 2) Place a hold on an item 3) Attempt to check that item out to another patron 4) Note the checkout is blocked 5) Apply this patch 6) Restart all the things! 7) Attempt the checkout again 8) The checkout now succeeds! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 02:42:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 01:42:31 +0000 Subject: [Koha-bugs] [Bug 35322] AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP do not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35322 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159341|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 159511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159511&action=edit Bug 35322: Add unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 03:38:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 02:38:07 +0000 Subject: [Koha-bugs] [Bug 35455] ICU does not strip = when indexing/searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35455 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 03:38:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 02:38:09 +0000 Subject: [Koha-bugs] [Bug 35455] ICU does not strip = when indexing/searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35455 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159422|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 159512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159512&action=edit Bug 35455: Remove = in ICU for indexing/searching This change more closely aligns ICU and CHR so that ICU also removes the = character. This fixes issues in ICU when searching with a : which gets transformed into a =. Without this change, the Analytics features won't work for titles with a colon in them. Test plan: 0. Apply the patch and import bibs from Bugzilla (using Staged MARC tools) 1. cp ./etc/zebradb/etc/phrases-icu.xml /etc/koha/zebradb/etc/phrases-icu.xml 2. cp ./etc/zebradb/etc/words-icu.xml /etc/koha/zebradb/etc/words-icu.xml 3. vi /etc/koha/zebradb/etc/default.idx Change "charmap word-phrase-utf.chr" to "icuchain words-icu.xml" for "index w" and "icuchain phrases-icu.xml" for "index p" 4. koha-zebra --stop kohadev 5. pkill zebrasrv 6. koha-zebra --start kohadev 7. koha-rebuild-zebra -a -b -f -v kohadev 8. Search for "Awesome title" and open the detail page 9. Note that the "Analytics: Show analytics" line shows up 10. Click that link 11. Note that it opens the "Cool article" record and it displays "In: Awesome title: awesome subtitle" 12. Click that link 13. Note that it opens the "Awesome title" record Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 05:17:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 04:17:46 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 --- Comment #4 from David Nind --- Created attachment 159513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159513&action=edit Bug 35410: Use "Online resources" label in search results Update the staff interface and OPAC XSLT files to use "Online resources" as the label in search results, instead of "Online access". This matches the label used in the detail page for a record. Test plan: 1. Search for perl in the staff interface and OPAC (or add to an existing record a URL to 856$u with 4 for the first indicator). 2. For any search result that displays the "Online access" label, view the detail page for the record. 3. Note that the detail page uses the label "Online resources". 4. Apply the patch and restart_all. 5. Repeat steps 1 and 2. 6. Note that the search result pages now show "Online resources" for the label, matching the detail page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 05:18:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 04:18:23 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 05:18:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 04:18:26 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159513|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 159514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159514&action=edit Bug 35410: Use "Online resources" label in search results Update the staff interface and OPAC XSLT files to use "Online resources" as the label in search results, instead of "Online access". This matches the label used in the detail page for a record. Test plan: 1. Search for perl in the staff interface and OPAC (or add to an existing record a URL to 856$u with 4 for the first indicator). 2. For any search result that displays the "Online access" label, view the detail page for the record. 3. Note that the detail page uses the label "Online resources". 4. Apply the patch and restart_all. 5. Repeat steps 1 and 2. 6. Note that the search result pages now show "Online resources" for the label, matching the detail page. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 05:21:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 04:21:20 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This updates the default release notes| |staff interface and OPAC | |XSLT files so that "Online | |resources" is used as the | |label in search results for | |filed 856 - Electronic | |Location and Access, | |instead of "Online access". | |This matches the label used | |in the detail page for a | |record. Patch complexity|--- |String patch Assignee|koha-bugs at lists.koha-commun |david at davidnind.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 05:21:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 04:21:42 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy, Sandbox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 05:25:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 04:25:32 +0000 Subject: [Koha-bugs] [Bug 34608] Add sort1 and sort2 to patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #6 from David Nind --- The patch no longer applies 8-(... git bz apply 34608 Bug 34608 - Add sort1 and sort2 to patron search results 155343 - Bug 34608: Add sort1 and sort2 to patron search results 158194 - Bug 34608: (follow-up) Display authorized values if used Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 34608: Add sort1 and sort2 to patron search results Using index info to reconstruct a base tree... M admin/columns_settings.yml M koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc M koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc Auto-merging admin/columns_settings.yml error: Failed to merge in the changes. Patch failed at 0001 Bug 34608: Add sort1 and sort2 to patron search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 05:27:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 04:27:50 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 --- Comment #6 from David Cook --- Legend! I was just thinking how I needed to get around to this, so thanks for taking care of it :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 05:28:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 04:28:32 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 --- Comment #7 from David Cook --- I might let someone else sign off so that I can QA it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 05:52:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 04:52:35 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 --- Comment #8 from David Nind --- >From what I can tell, no update for UNIMARC is required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 05:59:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 04:59:14 +0000 Subject: [Koha-bugs] [Bug 35363] Update transfer order pop-up window with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35363 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 05:59:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 04:59:16 +0000 Subject: [Koha-bugs] [Bug 35363] Update transfer order pop-up window with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35363 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159104|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159515&action=edit Bug 35363: Update transfer order pop-up window with consistent footer markup This patch updates the "Transfer order" pop-up window so that it has a fixed footer consistent with other similar pop-up windows. In order to make navigation between pages within the pop-up window easier I've added a button in the footer which can take the user back to the previous step, including any necessary parameters. To test, apply the patch and go to Acquisitions. - Locate a vendor with a basket, and a basket with one or more orders. - On the basket detail page, click the "Transfer" link in the "Modify" column. - In the pop-up window, test each step: - Vendor search - Vendor selection - Basket selection - Confirm that at any step you can use the new button to go back to the previous step. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 05:59:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 04:59:42 +0000 Subject: [Koha-bugs] [Bug 35363] Update transfer order pop-up window with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35363 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Nice! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 06:36:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 05:36:12 +0000 Subject: [Koha-bugs] [Bug 35445] OPAC registration verification triggered by email URL scanners In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 06:36:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 05:36:15 +0000 Subject: [Koha-bugs] [Bug 35445] OPAC registration verification triggered by email URL scanners In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445 --- Comment #2 from David Cook --- Created attachment 159516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159516&action=edit Bug 35445: Require OPAC user to confirm self-registration with button push This change requires the OPAC user to confirm self-registration with a button push when verifying registration using an emailed token. Test plan: 0. Apply the patch and koha-plack --reload kohadev 1. Set syspref PatronSelfRegistrationVerifyByEmail to "Don't require" 2. Create a patron using the self-registration on the OPAC 3. Note that no confirmation step is needed when self-registering 4. Set syspref PatronSelfRegistrationVerifyByEmail to "Require" 5. Create a patron using the self-registration on the OPAC 6. Look in message_queue to find the URL with the token to visit in the browser 7. Visit that URL 8. Note that the page says "Registration pending" and asks you to click a button labeled "Confirm" 9. Click the button labeled "Confirm" 10. Note that the self-registration is confirmed and details are shown on the page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 06:44:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 05:44:11 +0000 Subject: [Koha-bugs] [Bug 32477] Hiding batch item modification columns isn't remembered correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32477 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #13 from Emmi Takkinen --- (In reply to Victor Grousset/tuxayo from comment #12) > So, still needs work? A little yeah. Setting this back to assigned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 08:31:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 07:31:54 +0000 Subject: [Koha-bugs] [Bug 35472] New: Bug 33028 - Fix wrongly formatted values for monetary values in circulation rules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35472 Bug ID: 35472 Summary: Bug 33028 - Fix wrongly formatted values for monetary values in circulation rules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: naseel at emeacollege.ac.in QA Contact: testopia at bugs.koha-community.org koha-common 23.11.00-1 upgrading database schema for library Upgrade to 23.06.00.010 [01:00:16]: Bug 33028 - Fix wrongly formatted values for monetary values in circulation rules ERROR - {UNKNOWN}: Circulation rules contain invalid monetary values: Rule ID: 419 (All-TE-BK) Rule: overduefinescap Value: 1,000.00 Rule ID: 2150 (All-GL-BK) Rule: overduefinescap Value: 1,000.00 Rule ID: 2464 (EMEACL-GL-BK) Rule: overduefinescap Value: 1,000.00 Please fix these before you restart the update. at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/db_revs/230600010.pl line 33. at /usr/share/koha/lib/C4/Installer.pm line 741 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 08:32:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 07:32:58 +0000 Subject: [Koha-bugs] [Bug 35472] Bug 33028 - Fix wrongly formatted values for monetary values in circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35472 NASEEL changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |23.05 Hardware|All |PC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 09:34:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 08:34:11 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 09:34:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 08:34:15 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #29 from Thibaud Guillot --- Created attachment 159517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159517&action=edit Bug 30230 : (follow-up) Fix permission on /patrons api route -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 09:35:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 08:35:38 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #30 from Thibaud Guillot --- (In reply to Andrew Fuerste-Henry from comment #28) > With this new patch, I did the following: > - create a user with catalogue, circulate_remaining_permissions, and > list_borrowers permissions > - log into the staff client as that user > - in the Checkout field of mainpage.pl, search for "a" (with superlibrarian > permissions, this returns all patrons with "a" in their name") > - Koha takes you to the search results page, but shows no results and gives > message "Something went wrong when loading this table. 403: Forbidden" > - go back to the homepage and enter "Henry" in the Checkout box (in the > default sandbox data this name finds only one patron and should take you > straight to them) > - Koha again takes you to the search results page and gives a 403 error Hello Andrew, Sorry it's my bad I forgot to change permission name on patrons api route. Now it's fixed I think -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 10:24:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 09:24:25 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis at dataly.gr --- Comment #51 from George Veranis --- Be aware that if you use the koha-plugin-room-reservations plugin, the plugin will create a database table titled "bookings", so the updatedatabase.pl Koha script will fail when it tries to create the table by the same name. Here: https://github.com/Koha-Community/Koha/blob/0e6d576d70630ba2812ae02461be166ceb5d451f/installer/data/mysql/db_revs/230600061.pl#L13 checks only if the table exists so it skips the creation of the right structure of the table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 10:36:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 09:36:10 +0000 Subject: [Koha-bugs] [Bug 35472] Bug 33028 - Fix wrongly formatted values for monetary values in circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35472 --- Comment #1 from Katrin Fischer --- Hi Naseel, this is not a bug, it's supposed to help you fix your configuration. When you go into your circulation rules, you need to fix the overdue amount through editing for the listed combinations. The , in the format is not valid. Remove it and things should be ok to continue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 10:37:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 09:37:16 +0000 Subject: [Koha-bugs] [Bug 35473] New: Core bookings and room reservations plugin tables clash Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473 Bug ID: 35473 Summary: Core bookings and room reservations plugin tables clash Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Some early 23.11 adopters have spotted that the rooms reservations plugin already adds a 'bookings' table (without any form of table qualification which is modern best practice). We'll want to try and identify when this is the case and migrate the table. I'll contact the authors for the original plugin to discuss the next steps.. but there's lots of forks of this particular plugin so we'll want to somehow highlight issues to end users too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 10:55:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 09:55:15 +0000 Subject: [Koha-bugs] [Bug 33271] Show information about patron's guarantees charges on patron details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33271 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show |Show information about |charges_guarantors_guarante |patron's guarantees charges |es on patron details page |on patron details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 11:53:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 10:53:55 +0000 Subject: [Koha-bugs] [Bug 35474] New: Add icon for protected patrons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474 Bug ID: 35474 Summary: Add icon for protected patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 26170 It would be nice if the protected status of a patron account stood out in some way, using an icon (like superlibrarian or provileged users) or a text message. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 [Bug 26170] Add protected status for patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 11:53:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 10:53:55 +0000 Subject: [Koha-bugs] [Bug 26170] Add protected status for patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35474 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474 [Bug 35474] Add icon for protected patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 12:00:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 11:00:38 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Philip Orr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr at lmscloud.de Status|Needs Signoff |Failed QA --- Comment #5 from Philip Orr --- Setting this to Failed QA for only one reason: all links open the manual in the same tab. AFAIK in Koha links to the manual usually open in a new tab. By the way the "Help" links in the ERM module have the same problem, they should open in a new tab as well. Should I open a bug for that? As for the links themselves as detailed in the test plan, they are all correct! I also checked the ERM Module: "data providers" and "reports" both link to the manual mainpage. All other links in ERM module are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 12:01:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 11:01:29 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #6 from Philip Orr --- Oh, and one more thing: qa says the manual is now less tidy after the patch. WARN Koha/Manual.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 27, now: 28) ...Don't know if that's important. :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 12:13:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 11:13:10 +0000 Subject: [Koha-bugs] [Bug 35475] New: Untranslatable string in booking modal Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Bug ID: 35475 Summary: Untranslatable string in booking modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr, jonathan.druart+koha at gmail.com Depends on: 29002 When booking an item there is an untranslatable string in the modal: "Search for a patron" The calendar was also behaving a little oddly requiring a double click to take the date (just leaving the note here to see if someone else sees that) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 12:13:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 11:13:10 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35475 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 [Bug 35475] Untranslatable string in booking modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 12:35:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 11:35:05 +0000 Subject: [Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to * In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 12:35:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 11:35:09 +0000 Subject: [Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to * In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159160|0 |1 is obsolete| | Attachment #159161|0 |1 is obsolete| | --- Comment #22 from Tomás Cohen Arazi --- Created attachment 159518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159518&action=edit Bug 33268: Overlay rules don't work correctly when source is set to * Fallback to overlay rules with wildcard filter if no match found for exact filter match. To test: 1) Run tests t/db_dependent/Biblio/MarcOverlayRules.t Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 12:35:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 11:35:12 +0000 Subject: [Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to * In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 159519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159519&action=edit Bug 33268: Add tests for context module priority Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 12:38:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 11:38:43 +0000 Subject: [Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to * In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #24 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #18) > > Please tidy inline. Done! I think the fact '*' rules don't stack up is a bit confusing, but it makes sense. We should (maybe) name it 'fallback' or similar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 12:41:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 11:41:47 +0000 Subject: [Koha-bugs] [Bug 35029] Doubled up entries in notices and slips after update of notice name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35029 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Doubled up entries in |Doubled up entries in |notices and slips after |notices and slips after |update |update of notice name Severity|minor |normal --- Comment #3 from Katrin Fischer --- Now this also happens when the name of a notice is updated in the GUI, which makes this a much less avoidable issue :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 12:52:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 11:52:30 +0000 Subject: [Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461 Anu Seilonen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anu.seilonen at ouka.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 13:04:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 12:04:57 +0000 Subject: [Koha-bugs] [Bug 35445] OPAC registration verification triggered by email URL scanners In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159516|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 159520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159520&action=edit Bug 35445: Require OPAC user to confirm self-registration with button push This change requires the OPAC user to confirm self-registration with a button push when verifying registration using an emailed token. Test plan: 0. Apply the patch and koha-plack --reload kohadev 1. Set syspref PatronSelfRegistrationVerifyByEmail to "Don't require" 2. Create a patron using the self-registration on the OPAC 3. Note that no confirmation step is needed when self-registering 4. Set syspref PatronSelfRegistrationVerifyByEmail to "Require" 5. Create a patron using the self-registration on the OPAC 6. Look in message_queue to find the URL with the token to visit in the browser 7. Visit that URL 8. Note that the page says "Registration pending" and asks you to click a button labeled "Confirm" 9. Click the button labeled "Confirm" 10. Note that the self-registration is confirmed and details are shown on the page Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 13:07:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 12:07:03 +0000 Subject: [Koha-bugs] [Bug 35445] OPAC registration verification triggered by email URL scanners In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 13:07:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 12:07:24 +0000 Subject: [Koha-bugs] [Bug 35445] OPAC registration verification triggered by email URL scanners In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445 --- Comment #4 from Martin Renvoize --- All working as expected here, signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 13:19:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 12:19:57 +0000 Subject: [Koha-bugs] [Bug 35476] New: Submit button for adding new processings is not translatable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 Bug ID: 35476 Summary: Submit button for adding new processings is not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr, jonathan.druart+koha at gmail.com Depends on: 30708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 [Bug 30708] Creation of a new 'Preservation' module -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 13:19:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 12:19:57 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 [Bug 35476] Submit button for adding new processings is not translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 13:25:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 12:25:40 +0000 Subject: [Koha-bugs] [Bug 35477] New: Can't add items to train, claims barcode unknown or in waiting list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 Bug ID: 35477 Summary: Can't add items to train, claims barcode unknown or in waiting list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Preservation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart+koha at gmail.com Depends on: 30708 Might be me doing something wrong: I tried to add 3999900000611 to my created train in the preservation module, but I only get the "barcode not found, must be in waiting list". My waiting list is empty, adding the item there also fails. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 [Bug 30708] Creation of a new 'Preservation' module -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 13:25:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 12:25:40 +0000 Subject: [Koha-bugs] [Bug 30708] Creation of a new 'Preservation' module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30708 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 [Bug 35477] Can't add items to train, claims barcode unknown or in waiting list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 13:38:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 12:38:37 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #59 from Katrin Fischer --- Testing with a superlibrarian, but I don't get a pull down in the details column on my item level holds. Any idea what could go wrong there? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 14:05:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 13:05:32 +0000 Subject: [Koha-bugs] [Bug 35478] New: When selecting a patron for a suggestion we have undefined fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35478 Bug ID: 35478 Summary: When selecting a patron for a suggestion we have undefined fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In the code in suggestion.tt: 1301 function select_suggester(borrowernumber, borrower) { 1302 var suggested = ''; 1303 suggested += ''; 1304 suggested += borrower.surname + ', ' + borrower.firstname + ' (' + borrower.cardnumber + ')'; 1305 suggested += ' '; 1306 suggested += borrower.branchname + ' (' + borrower.category_description + ')'; 1307 $("#tdsuggestedby").html(suggested); 1308 return 0; 1309 } The borrower json in the search doesn't have branchcode or category description -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 14:05:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 13:05:41 +0000 Subject: [Koha-bugs] [Bug 35478] When selecting a patron for a suggestion we have undefined fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35478 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 14:28:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 13:28:34 +0000 Subject: [Koha-bugs] [Bug 23981] Inconsistencies with the different prices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981 Mark Hofstetter changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at trust-box.at --- Comment #5 from Mark Hofstetter --- hi, I am not sure if our customer/we have the same problem but it seems to be related - I just tested it with 23.06.00.079, just to clarify things for me if I am looking the right place(s): IMHO the price should be deducted from fund WITHOUT the tax (but it is with the the tax) 0) create a vendor List prices: Include tax Invoice prices: Don't include tax 1) placing an order: cgi-bin/koha/acqui/neworderempty.pl?booksellerid=3&basketno=4 Vendor price: 10 (tax inclusive) Tax rate: 10% Discount: 13% Retail price: 10.00 (adjusted for USD, tax inclusive) Replacement cost: 10.00 Budgeted cost: 8.70 (tax inclusive) Total: 8.70 (budgeted cost * quantity) Actual cost: 0.00 ==> 10 * 0.87 2) cgi-bin/koha/acqui/basket.pl?basketno=4 RRP => 9.09 (10 / 1.1) Price - Tax ie Budgeted cost tax ex => 7.91 ( 9.09 * 0.87 (13% Discount)) total ex tax => 7.91 GST => 0.79 (7,91 * 0.1 (10% Tax)) 3) Close Basket => Yes 4) cgi-bin/koha/acqui/booksellers.pl?booksellerid=3 Click receive Shipment fill in: Vendor invoice: 123345 (some random number) add no shippment costs 5) mark create book and click "Receive selected(1)" 6) mark item as received Actual cost: 7.91 (tax exclusive) 7) Total tax exc. 7.91 Total (GST 10%) 0.79 Total tax inc. 8.70 there should be no tax because the vendor is tax excluded 8) Secondary fund Secondary fund 1,000.00 0.00 0.00 8.70 8.70 991.30 991.30 the full amount is deducted even if you are tax exempt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 14:31:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 13:31:55 +0000 Subject: [Koha-bugs] [Bug 34082] Cut some redundancy in OPAC JavaScript string translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34082 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 14:31:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 13:31:57 +0000 Subject: [Koha-bugs] [Bug 34082] Cut some redundancy in OPAC JavaScript string translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34082 --- Comment #2 from Owen Leonard --- Created attachment 159521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159521&action=edit Bug 34082: Cut some redundancy in OPAC JavaScript string translations This patch consolidates some JS code so that we're not defining a string ine one place and using it once elsewhere. With JS-friendly translations tools we don't need this workaround. To test, apply the patch and go to Administration -> Circulation and fine rules. - Configure an item type rule with the "OPAC item level holds" setting set to "Force." - Log in to the OPAC and locate a record with that item type and multiple items. An example in the sample data: /cgi-bin/koha/opac-detail.pl?biblionumber=12 - Place a hold on the item. - The holds screen should show a table of items. - Open your browser's developer tools. - In the Console tab, paste in this code and hit ENTER. - All radio buttons in the table of items should be cleared. - Click the "Confirm hold" button. You should get an alert: "Expecting a specific item selection." - Log in to the OPAC and click the "Search history" tab from the user summary page. - Check one or more checkboxes next to search history items and click the "Remove selected searches." - You should get an alert: "Are you sure you want to delete selected search history entries?" - Log in to the OPAC, create a new list if necessary, and add some titles to the list. - Test that confirmation messages show correctly: - Deleting a single title by clicking the "Remove from this list" link. - Deleting multiple titles by checking boxes and clicking "Remove from list." - Deleting a list. - In Administration -> System preferences, enable TagsEnabled if necessary. - Log in to the OPAC and tag one or more items. - From the Tag cloud page, check one or more boxes for your tags, and click the "Delete selected tags" button at the bottom of the page. - The confirmation message should display correctly. - To test the change to opac-account.tt you have to install a payment plugin, e.g. https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal, and attempt to submit a payment which is below the minimum payment threshold set in the plugin's configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 14:49:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 13:49:50 +0000 Subject: [Koha-bugs] [Bug 35472] Bug 33028 - Fix wrongly formatted values for monetary values in circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35472 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger --- I have fun into this several times when upgrading. I have solved it by logging into the database and running queries like these: UPDATE circulation_rules SET rule_value = '0.00' WHERE rule_value = '0,00'; You will have to replace the numbers with the actual numbers that are problematic in your databse. Then resume the upgrade with: sudo apt-get (dist-)upgrade -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 14:50:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 13:50:34 +0000 Subject: [Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:10:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:10:33 +0000 Subject: [Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159307|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize --- Created attachment 159522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159522&action=edit Bug 18139: Display the rule critera used to determin the checkout limits to the template The too many checked out message can be very confusing for librarians when the limit specified is more or less than the number of checkouts the patron already has. We should make it clear to the librarian that his is only counting certain types of checkouts by giving them the issuing rule criteria used. Test Plan: 1) Apply this patch 2) Try to check out more items than the circ rules allow for regular and on-site checkouts Signed-off-by: Eric Gosselin Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:10:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:10:36 +0000 Subject: [Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159308|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 159523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159523&action=edit Bug 18139: Add/update unit tests Signed-off-by: Eric Gosselin Signed-off-by: Marc Véron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:11:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:11:22 +0000 Subject: [Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize --- All working here.. minor perltidy issues highlighted, but on inspection, I can't work out how to resolve them. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:11:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:11:27 +0000 Subject: [Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:12:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:12:47 +0000 Subject: [Koha-bugs] [Bug 35477] Can't add items to train, claims barcode unknown or in waiting list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 --- Comment #1 from Jonathan Druart --- Items can be added to a train if there are in the waiting list. > My waiting list is empty, adding the item there also fails. Which error do you get? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:13:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:13:14 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:13:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:13:17 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #14 from Nick Clemens --- Created attachment 159524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159524&action=edit Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:13:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:13:20 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #15 from Nick Clemens --- Created attachment 159525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159525&action=edit Bug 27595: Add place_hold method to Koha::Suggestion This patch adds anew method to allow placing a hold from a purchase suggestion To test: prove -v t/db_dependent/Suggestions.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:13:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:13:23 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #16 from Nick Clemens --- Created attachment 159526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159526&action=edit Bug 27595: Place holds when ordering from a suggestion This patch updates the ordering code to place a hold when adding to a basket from a suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled. To test: 1 - Apply all patches 2 - updatedatabase 3 - See new system preference PlaceHoldsOnOrdersFromSuggestions 4 - Create a new purchase suggestion, mark it accepted 5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion' 6 - Complete order, confirm no hold was placed 7 - Enable the new system preference 8 - Repeast 4-6 9 - Confirm a hold was placed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:17:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:17:42 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #7 from Jonathan Druart --- 1. Why the following 2 lines? + 'preservation/trains' => '/preservation.html#trains', + 'preservation/trains/' => '/preservation.html#trains', Same for settings. 2. Doubled / preservation/trains//items/add -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:18:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:18:38 +0000 Subject: [Koha-bugs] [Bug 35439] Large background jobs can create delays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35439 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:19:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:19:02 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #8 from Jonathan Druart --- Forget 1, it's a "starting with". Looks good then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:20:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:20:55 +0000 Subject: [Koha-bugs] [Bug 35474] Add icon for protected patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:21:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:21:53 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #9 from Caroline Cyr La Rose --- (In reply to Jonathan Druart from comment #7) > > 2. Doubled / > preservation/trains//items/add The part at the bottom says to remove the digits. I figured if the digit was removed in preservation/trains/1/items/add the the resulting string would be preservation/trains//items/add -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:22:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:22:19 +0000 Subject: [Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22384 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:22:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:22:19 +0000 Subject: [Koha-bugs] [Bug 22384] Make the title of an ILL clickable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22384 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33544 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:23:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:23:06 +0000 Subject: [Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:23:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:23:09 +0000 Subject: [Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 --- Comment #1 from Jonathan Druart --- Created attachment 159527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159527&action=edit Bug 35476: Make 'Submit' buttons translatable in vue components -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:23:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:23:21 +0000 Subject: [Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:26:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:26:44 +0000 Subject: [Koha-bugs] [Bug 35114] Total on basketgroup can be different than basket details total In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114 Philip Orr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr at lmscloud.de --- Comment #2 from Philip Orr --- Hi Thibaud, I'm trying to test this but running into some questions already before applying the patch. Could you make the test plan a bit more specific? I tried creating a couple of baskets and basket groups and for me the sums in the basket view and in the basket group view are already the same before applying the patch, so I'm not entirely sure what I should do to replicate the display errors. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:30:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:30:29 +0000 Subject: [Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #9 from Martin Renvoize --- Hmm.. The biblio column is now a clickable representation of the biblio already.. it uses $biblio_to_html behind the scenes. The other details that this patch merges into one field are those that were entered by the user when making the request.. We don't always have a linked biblio. Needs a little thought -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:37:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:37:58 +0000 Subject: [Koha-bugs] [Bug 35114] Total on basketgroup can be different than basket details total In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114 --- Comment #3 from Thibaud Guillot --- Hi Philip, Thank you for taking the time to test this patch. From what I remember it was a calculation difference related to cents, as one function truncates while another rounds and that's what leads to a discrepancy. I'll take the time soon to write a test plan with exact amounts, but I need to free up some time to do it. Try on your side with several amounts that may cause calculation differences such as X,946 etc... If the result is unclear, I'll draw up a more precise test plan. Thanks again ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:38:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:38:11 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:40:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:40:47 +0000 Subject: [Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #10 from Martin Renvoize --- Created attachment 159528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159528&action=edit Bug 33544: Replace title details with one column Combine the request title details fields into onea column for display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:40:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:40:50 +0000 Subject: [Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152862|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 159529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159529&action=edit Bug 33544: Update columns_settings.yml Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:40:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:40:52 +0000 Subject: [Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 --- Comment #12 from Martin Renvoize --- Created attachment 159530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159530&action=edit Bug 33544: Link title in details to biblio This patch removes the biblio id column and instead adds the biblio link to the title field in the request details column when appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:41:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:41:09 +0000 Subject: [Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152861|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:41:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:41:46 +0000 Subject: [Koha-bugs] [Bug 33544] Squash some ILL fields to alleviate request table overflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33544 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:42:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:42:30 +0000 Subject: [Koha-bugs] [Bug 22384] Make the title of an ILL clickable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22384 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize --- See alternative in bug 33544 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:54:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:54:07 +0000 Subject: [Koha-bugs] [Bug 35432] Clarify and simplify the workings of MapItemsToHoldRequests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35432 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 15:54:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 14:54:18 +0000 Subject: [Koha-bugs] [Bug 35439] Large background jobs can create delays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35439 --- Comment #2 from Matt Blenkinsop --- I've actually got a start point for this in a piece of work I'm doing for importing KBART files into ERM. The files can contain 10s of 1000s of titles and quite often breach the max_allowed_packet in the database when you try and store the args in the background_jobs table. I've got some subroutines that chunk those files to make sure that we are never more than 75% of the max_allowed_packet and enqueue chunked jobs based on those acceptable sizes. They are still large and sometimes slow jobs though and they all just get passed to the worker queue in order - how would you envisage the interleaving of jobs? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 16:04:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 15:04:26 +0000 Subject: [Koha-bugs] [Bug 35159] New edit item limitation to library groups also prevents batch modification of items owned by other libraries. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35159 Sally Lodico changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 16:08:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 15:08:14 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Philip Orr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr at lmscloud.de Documentation| |Philip Orr contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 16:17:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 15:17:06 +0000 Subject: [Koha-bugs] [Bug 27919] Split claims return from LOST In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 16:18:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 15:18:31 +0000 Subject: [Koha-bugs] [Bug 25901] Add option for ClaimsReturnedWarningThreshold to count only unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901 Cheryl changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman at fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 16:38:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 15:38:51 +0000 Subject: [Koha-bugs] [Bug 35470] 23.05 button class update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35470 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- Dave, Try using the following CSS: /* Speed Green Update and Run Sql button */ #sql_report_form .btn[value="update_and_run_sql"] { background: #7CFC00; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 16:39:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 15:39:28 +0000 Subject: [Koha-bugs] [Bug 35470] 23.05 button class update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35470 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 16:40:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 15:40:05 +0000 Subject: [Koha-bugs] [Bug 35474] Add icon for protected patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 16:48:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 15:48:33 +0000 Subject: [Koha-bugs] [Bug 35407] Terminology: Show fewer collection codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 16:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 15:54:31 +0000 Subject: [Koha-bugs] [Bug 35470] 23.05 button class update In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35470 --- Comment #3 from Dave --- Thank you Lucas. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 16:59:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 15:59:25 +0000 Subject: [Koha-bugs] [Bug 35479] New: plugins nightly cronjob should log the plugins that are being run Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Bug ID: 35479 Summary: plugins nightly cronjob should log the plugins that are being run Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Bug 31203 adding logging of the start and end of a run to cronjobs. When running the plugins_nightly.pl cronjob, we should record the plugins that have a nightly method, logging the start and end of each plugins routine -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:02:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:02:18 +0000 Subject: [Koha-bugs] [Bug 35407] Terminology: Show fewer collection codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:02:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:02:20 +0000 Subject: [Koha-bugs] [Bug 35407] Terminology: Show fewer collection codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 --- Comment #1 from Owen Leonard --- Created attachment 159531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159531&action=edit Bug 35407: Correct terminology: Show fewer collections In the OPAC, the "Show more" and "Show less" links have aria-labels to make their function clearer to screen readers. The collection and item type controls need corrected terminology, and the links also need to have their template filter corrected (html, not uri). To test, apply the patch and perform a catalog search in the OPAC. - Test that the "Show more" and "Show less" links in the facets sidebar work correctly to expand and collapse the lists of facets. - It's not necessary to test with a screen reader. You can view the source to confirm the markup on the "Show more collections" and "Show more item types" links. Before: Show more After: Show more -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:05:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:05:35 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:22:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:22:36 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Philip Orr changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/766 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:37:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:37:21 +0000 Subject: [Koha-bugs] [Bug 35474] Add icon for protected patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:37:23 +0000 Subject: [Koha-bugs] [Bug 35474] Add icon for protected patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474 --- Comment #1 from Owen Leonard --- Created attachment 159532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159532&action=edit Bug 35474: Add icon for protected patrons This patch adds a "protected" icon (fa-lock) to the patron information in the sidebar of patron-related pages in the staff interface. To test, apply the patch and perform a patron search in the staff interface. - Edit a patron and go to the "Library management" section. - Set "Protected" to "Yes." - Save the record and view the information in the sidebar. You should see the lock icon by the patron's name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:40:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:40:48 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159524|0 |1 is obsolete| | --- Comment #17 from ByWater Sandboxes --- Created attachment 159533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159533&action=edit Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:40:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:40:51 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159525|0 |1 is obsolete| | --- Comment #18 from ByWater Sandboxes --- Created attachment 159534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159534&action=edit Bug 27595: Add place_hold method to Koha::Suggestion This patch adds anew method to allow placing a hold from a purchase suggestion To test: prove -v t/db_dependent/Suggestions.t Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:40:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:40:53 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159526|0 |1 is obsolete| | --- Comment #19 from ByWater Sandboxes --- Created attachment 159535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159535&action=edit Bug 27595: Place holds when ordering from a suggestion This patch updates the ordering code to place a hold when adding to a basket from a suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled. To test: 1 - Apply all patches 2 - updatedatabase 3 - See new system preference PlaceHoldsOnOrdersFromSuggestions 4 - Create a new purchase suggestion, mark it accepted 5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion' 6 - Complete order, confirm no hold was placed 7 - Enable the new system preference 8 - Repeast 4-6 9 - Confirm a hold was placed Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:41:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:41:33 +0000 Subject: [Koha-bugs] [Bug 35474] Add icon for protected patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:41:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:41:35 +0000 Subject: [Koha-bugs] [Bug 35474] Add icon for protected patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35474 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159532|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 159536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159536&action=edit Bug 35474: Add icon for protected patrons This patch adds a "protected" icon (fa-lock) to the patron information in the sidebar of patron-related pages in the staff interface. To test, apply the patch and perform a patron search in the staff interface. - Edit a patron and go to the "Library management" section. - Set "Protected" to "Yes." - Save the record and view the information in the sidebar. You should see the lock icon by the patron's name. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:45:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:45:12 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from Andrew Fuerste-Henry --- I want to note here that this feature will create holds that would not otherwise be allowed. It'll put holds on bibs without items and on bibs where all items are of an unholdable item type. I guess that shouldn't be an issue, since staff are purposefully ordering the title, but I wanted to make sure it was explicitly acknowledged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:49:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:49:42 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Lucas Gass --- Looks good Hammat. Only issue now is to perltidy 'installer/data/mysql/atomicupdate/bug_33317.pl'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:53:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:53:06 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159533|0 |1 is obsolete| | --- Comment #21 from ByWater Sandboxes --- Created attachment 159537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159537&action=edit Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:53:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:53:09 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159534|0 |1 is obsolete| | --- Comment #22 from ByWater Sandboxes --- Created attachment 159538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159538&action=edit Bug 27595: Add place_hold method to Koha::Suggestion This patch adds anew method to allow placing a hold from a purchase suggestion To test: prove -v t/db_dependent/Suggestions.t Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:53:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:53:12 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159535|0 |1 is obsolete| | --- Comment #23 from ByWater Sandboxes --- Created attachment 159539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159539&action=edit Bug 27595: Place holds when ordering from a suggestion This patch updates the ordering code to place a hold when adding to a basket from a suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled. To test: 1 - Apply all patches 2 - updatedatabase 3 - See new system preference PlaceHoldsOnOrdersFromSuggestions 4 - Create a new purchase suggestion, mark it accepted 5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion' 6 - Complete order, confirm no hold was placed 7 - Enable the new system preference 8 - Repeast 4-6 9 - Confirm a hold was placed Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:53:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:53:17 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159537|0 |1 is obsolete| | --- Comment #24 from ByWater Sandboxes --- Created attachment 159540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159540&action=edit Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:53:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:53:20 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159538|0 |1 is obsolete| | --- Comment #25 from ByWater Sandboxes --- Created attachment 159541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159541&action=edit Bug 27595: Add place_hold method to Koha::Suggestion This patch adds anew method to allow placing a hold from a purchase suggestion To test: prove -v t/db_dependent/Suggestions.t Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:53:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:53:23 +0000 Subject: [Koha-bugs] [Bug 27595] Place holds for patrons on accepted purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159539|0 |1 is obsolete| | --- Comment #26 from ByWater Sandboxes --- Created attachment 159542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159542&action=edit Bug 27595: Place holds when ordering from a suggestion This patch updates the ordering code to place a hold when adding to a basket from a suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled. To test: 1 - Apply all patches 2 - updatedatabase 3 - See new system preference PlaceHoldsOnOrdersFromSuggestions 4 - Create a new purchase suggestion, mark it accepted 5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion' 6 - Complete order, confirm no hold was placed 7 - Enable the new system preference 8 - Repeast 4-6 9 - Confirm a hold was placed Signed-off-by: Kelly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:54:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:54:48 +0000 Subject: [Koha-bugs] [Bug 35407] Terminology: Show fewer collection codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:54:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:54:51 +0000 Subject: [Koha-bugs] [Bug 35407] Terminology: Show fewer collection codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35407 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159531|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 159543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159543&action=edit Bug 35407: Correct terminology: Show fewer collections In the OPAC, the "Show more" and "Show less" links have aria-labels to make their function clearer to screen readers. The collection and item type controls need corrected terminology, and the links also need to have their template filter corrected (html, not uri). To test, apply the patch and perform a catalog search in the OPAC. - Test that the "Show more" and "Show less" links in the facets sidebar work correctly to expand and collapse the lists of facets. - It's not necessary to test with a screen reader. You can view the source to confirm the markup on the "Show more collections" and "Show more item types" links. Before: Show more After: Show more Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:55:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:55:24 +0000 Subject: [Koha-bugs] [Bug 34608] Add sort1 and sort2 to patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:55:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:55:25 +0000 Subject: [Koha-bugs] [Bug 34608] Add sort1 and sort2 to patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155343|0 |1 is obsolete| | Attachment #158194|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 159544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159544&action=edit Bug 34608: Add sort1 and sort2 to patron search results This patch adds the option of displaying patron "sort1" and "sort2" statistical fields in the patron module's main search results. The fields are hidden by default in the updated table configuration. To test, apply the patch and restart services. - Go to Patrons and perform a search. - You should not see columns for sort1 and sort2. - Under the "Columns" button you should see options to display sort1 and sort2. Confirm that they work to show and hide the columns. - Confirm that the sort1 and sort2 columns are sortable and searchable. - Go to Administration -> Table settings. - Under Patrons -> member, toggle the sort1 and sort1 "hidden by default" checkboxes and save the configuration. - Return to patron search results to confirm that the columns are now shown by default. Signed-off-by: Émily-Rose Francoeur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:55:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:55:28 +0000 Subject: [Koha-bugs] [Bug 34608] Add sort1 and sort2 to patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 --- Comment #8 from Owen Leonard --- Created attachment 159545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159545&action=edit Bug 34608: (follow-up) Display authorized values if used This patch shamelessly steals from Bug 33568 in order to allow the correct authorized value description to be shown in the JS-generated table of results for values of borrowers sort1 and sort2. To test, apply the patch and go to Administration -> Authorized values. - Add some values, if necessary, to both the 'Bsort1' and 'Bsort2' categories. - Locate some patron records to edit, and set the patron's "Sort 1" and "Sort 2" fields. - Perform a patron search which will return those patron records. - Confirm that the correct authorized value description is shown instead of the authorized value code. - Delete all values from the 'Bsort1' and 'Bsort2' authorized value categories. - Return to your patron search and confirm that "Sort 1" and "Sort 2" values are still being shown, though now it's the "raw" code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 17:55:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 16:55:54 +0000 Subject: [Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:01:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:01:09 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157854|0 |1 is obsolete| | Attachment #157855|0 |1 is obsolete| | Attachment #157856|0 |1 is obsolete| | Attachment #157857|0 |1 is obsolete| | Attachment #157858|0 |1 is obsolete| | Attachment #159342|0 |1 is obsolete| | --- Comment #42 from Owen Leonard --- Created attachment 159546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159546&action=edit Bug 33766: Fix ambiguous "Login" field This patch introduces a new syspref 'OPACLoginLabelTextContent' which can be set to the following values - Cardnumber - Username - Cardnumber or Username To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:01:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:01:12 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #43 from Owen Leonard --- Created attachment 159547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159547&action=edit Bug 33766: (follow-up) Fix ambiguous "Login" field This follow-up fixes some problems w/ the unconventional parts of the first commit. We now use conditionals in a BLOCK to map the selected value from the preference to string representations which should now be easily translatable. To test: - Check that the label for - The masthead inc - The opac-auth template - The opac-main template - The opac-password-recovery template - The opac-registration-confirmation template - The opac-reset-password template - The sco-main template reflect the changes you made to the syspref Signed-off-by: Matt Blenkinsop Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:01:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:01:14 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #44 from Owen Leonard --- Created attachment 159548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159548&action=edit Bug 33766: (sign-off follow-up) Fix sentence case "Cardnumber or Username" is now "Cardnumber or username" Signed-off-by: Matt Blenkinsop Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:01:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:01:17 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #45 from Owen Leonard --- Created attachment 159549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159549&action=edit Bug 33766: (follow-up) Enable translation for strings In my test the strings inside a SET directive were not picked up for translation. This patch adds the t() function around the new strings in order to allow them to be translated. To test, apply the patch and test the translation process for any language, in this example fr-FR: - Run 'perl translate update fr-FR' - Open misc/translator/po/fr-FR-messages.po - Look for the affected strings: "Username", "Cardnumber", and "Cardnumber or username." - Update the po file with translations of the strings - Run 'perl translate install fr-FR' - View the OPAC in your translated language and test each setting of OPACLoginLabelTextContent to confirm that the translated strings appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:01:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:01:19 +0000 Subject: [Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766 --- Comment #46 from Owen Leonard --- Created attachment 159550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159550&action=edit Bug 33766: (follow-up) Change "cardnumber" to "card number" "Cardnumber' isn't really a word, and I think it comes off as librarian-speak. This patch updates it to "Card number" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:23:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:23:19 +0000 Subject: [Koha-bugs] [Bug 35153] Convert IntranetmainUserblock system preference to additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35153 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159177|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 159551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159551&action=edit Bug 35153: Convert IntranetmainUserblock system preference to additional contents This patch moves the IntranetmainUserblock system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the IntranetmainUserblock system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from IntranetmainUserblock is now stored there. - The HTML customization entry form should offer IntranetmainUserblock as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the IntranetmainUserblock HTML customization and add unique content to the "fr-FR" tab. - Go to the staff client home page. You should see the content you added to the IntranetmainUserblock HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "IntranetmainUserblock." It should return no results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:26:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:26:12 +0000 Subject: [Koha-bugs] [Bug 30623] Copy permissions from one user to another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155144|0 |1 is obsolete| | --- Comment #15 from Owen Leonard --- Created attachment 159552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159552&action=edit Bug 30623: Copy permissions from one user to another This patch adds controls to the patron "Set permissions" page allowing the user to copy a set of permissions from one patron to another. The patch also makes a minor correction to global staff interface CSS to correct the appearance of non-primary split buttons. To test, apply the patch and rebuild the staff interface CSS. You may want to clear your browser cache. - Locate a patron in the staff client and choose More -> Set permissions. You might want to start with a staff patron who has multiple permissions enabled. - You should see two new buttons in the toolbar immediately above the list of permissions: "Copy settings," a split button with a secondary option to choose "Forget copied settings"; and "Paste settings" which should be disabled by default. - Clicking the "Copy settings" button should trigger the copy icon to cycle/fade from the copy icon to the check-mark icon and back to the copy icon. I thought this interaction needed some visual feedback since it doesn't otherwise trigger visible action. - Clicking the "Copy settings" button should also enable the "Paste settings" button. - Locate another patron, preferable one with permissions visibly different from your first choice. - On their "Set permissions" page, click the "Paste settings" button. The list of permissions should expand all settings and all the checkboxes should now match your original choice. - At this stage you could find another patron and paste the same permissions again. - Click "Copy settings -> Forget copied settings." The "Paste settings" button should become disabled. - Using the browser console to check the contents of Local Storage should confirm that the "copiedPermissions" entry has been removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:26:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:26:58 +0000 Subject: [Koha-bugs] [Bug 21893] Batch Modify button in report with itemnumber only includes titles in first page of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21893 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:27:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:27:18 +0000 Subject: [Koha-bugs] [Bug 31025] Reports with too many params can exceed length limit of URI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31025 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:31:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:31:45 +0000 Subject: [Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358 carthur at slolibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur at slolibrary.org --- Comment #8 from carthur at slolibrary.org --- This would be a great help for the Acquisition side of things. Would be very interested to see what happens with this project. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:34:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:34:06 +0000 Subject: [Koha-bugs] [Bug 22632] Add logging of merged patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:34:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:34:09 +0000 Subject: [Koha-bugs] [Bug 22632] Add logging of merged patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157266|0 |1 is obsolete| | Attachment #157267|0 |1 is obsolete| | Attachment #157268|0 |1 is obsolete| | Attachment #157269|0 |1 is obsolete| | Attachment #157270|0 |1 is obsolete| | Attachment #157271|0 |1 is obsolete| | Attachment #157286|0 |1 is obsolete| | --- Comment #51 from Owen Leonard --- Created attachment 159553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159553&action=edit Bug 22632: Add logging of merged patrons without this patch , when patrons are merged , you can't see the merge in the log viewer. To test: -Apply the patch -Make sure you have "BorrowersLog" on in you System Preference -Search patrons -Check two ore more patrons -Merge selected patrons -Merge patrons -Go to log viewer - Make sure there is the line with the action : "Merge" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:34:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:34:12 +0000 Subject: [Koha-bugs] [Bug 22632] Add logging of merged patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #52 from Owen Leonard --- Created attachment 159554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159554&action=edit Bug 22632: adding of the rescearch of merge in the log viewer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:34:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:34:16 +0000 Subject: [Koha-bugs] [Bug 22632] Add logging of merged patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #53 from Owen Leonard --- Created attachment 159555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159555&action=edit Bug 22632: Unit Testing of patch 22632 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:34:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:34:19 +0000 Subject: [Koha-bugs] [Bug 22632] Add logging of merged patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #54 from Owen Leonard --- Created attachment 159556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159556&action=edit Bug 22632: (follow-up) Use PATRON_MERGE as log action -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:34:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:34:22 +0000 Subject: [Koha-bugs] [Bug 22632] Add logging of merged patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #55 from Owen Leonard --- Created attachment 159557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159557&action=edit Bug 22632: (follow-up) Perltidy fixes for Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:34:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:34:25 +0000 Subject: [Koha-bugs] [Bug 22632] Add logging of merged patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 --- Comment #56 from Owen Leonard --- Created attachment 159558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159558&action=edit Bug 22632: (follow-up) Apply perltidy fixes and add missing exec flag to Log.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:39:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:39:10 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #31 from Andrew Fuerste-Henry --- Created attachment 159559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159559&action=edit Link to be removed This latest patch addresses all of my concerns except for the "Search Patrons" link in the main search bar on the patron search results page. See attached screenshot. We should hide that "Search Patrons" link entirely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:50:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:50:15 +0000 Subject: [Koha-bugs] [Bug 35479] plugins nightly cronjob should log the plugins that are being run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:50:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:50:17 +0000 Subject: [Koha-bugs] [Bug 35479] plugins nightly cronjob should log the plugins that are being run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 --- Comment #1 from Kyle M Hall --- Created attachment 159560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159560&action=edit Bug 35479: Log start, end, and any failures for each plugin's nightly cronjob When running the plugins_nightly.pl cronjob, we should record the plugins that have a nightly method, logging the start and end of each plugins routine Test Plan: 1) Enable CronjobLog 2) Install a plugin with a nightly cronjob ( e.g. https://github.com/bywatersolutions/koha-plugin-book-list-printer ) 3) Run plugins_nightly.pl 4) Note new entries in the cronjob viewer for the start and end of the plugin's nightly cronjob run 5) Edit the plugin, add a line like "die 'this is a test';" to the plugin's nightly cronjob 6) Run plugins_nightly.pl 7) View the action logs, not the log for the error you added! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:50:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:50:22 +0000 Subject: [Koha-bugs] [Bug 35479] plugins nightly cronjob should log the plugins that are being run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:50:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:50:27 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #10 from Caroline Cyr La Rose --- (In reply to Philip Orr from comment #5) > Setting this to Failed QA for only one reason: all links open the manual in > the same tab. AFAIK in Koha links to the manual usually open in a new tab. > > By the way the "Help" links in the ERM module have the same problem, they > should open in a new tab as well. Should I open a bug for that? > > As for the links themselves as detailed in the test plan, they are all > correct! > I also checked the ERM Module: "data providers" and "reports" both link to > the manual mainpage. All other links in ERM module are correct. I don't see any "target" or "blank" in the Koha/Manual.pm file nor in the help.pl file. I wonder if it's managed elsewhere. For the erm data providers and reports, I think it's due to those things being new in this version and we haven't had time to create/write the sections in the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 18:57:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 17:57:28 +0000 Subject: [Koha-bugs] [Bug 35480] New: Make it easier to customize dialog messages on opac-suggestions.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35480 Bug ID: 35480 Summary: Make it easier to customize dialog messages on opac-suggestions.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some librarians would like to customize the dialog messages that can appear: -A similar document already exists: {title} Click on "Confirm your suggestion" to ignore this message. -The manager you selected does not have sufficient permissions -The suggestion has not been added. A suggestion with this title already exists {title} If these strings were wrapped in a HTML id/class it would make this much easier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 19:08:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 18:08:45 +0000 Subject: [Koha-bugs] [Bug 9799] Prompt for due date for specific item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9799 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 19:34:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 18:34:22 +0000 Subject: [Koha-bugs] [Bug 21893] Batch Modify button in report with itemnumber only includes titles in first page of results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21893 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 19:38:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 18:38:19 +0000 Subject: [Koha-bugs] [Bug 23981] Inconsistencies with the different prices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981 --- Comment #6 from Katrin Fischer --- (In reply to Mark Hofstetter from comment #5) > hi, > > I am not sure if our customer/we have the same problem but it seems to be > related - I just tested it with 23.06.00.079, just to clarify things for me > if I am looking the right place(s): > > IMHO the price should be deducted from fund WITHOUT the tax (but it is with > the the tax) I believe with tax is standard as most libraries have to pay it and you need the funds to reflect that. But there is CalculateFundValuesIncludingTax in 23.11 to change it. > 0) create a vendor > List prices: Include tax > Invoice prices: Don't include tax > > 1) placing an order: > cgi-bin/koha/acqui/neworderempty.pl?booksellerid=3&basketno=4 > > > Vendor price: 10 (tax inclusive) > Tax rate: 10% > Discount: 13% > Retail price: 10.00 (adjusted for USD, tax inclusive) > Replacement cost: 10.00 > Budgeted cost: 8.70 (tax inclusive) > Total: 8.70 (budgeted cost * quantity) > Actual cost: 0.00 > > ==> 10 * 0.87 > > 2) cgi-bin/koha/acqui/basket.pl?basketno=4 > RRP => 9.09 (10 / 1.1) Price - Tax ie > Budgeted cost tax ex => 7.91 ( 9.09 * 0.87 (13% Discount)) > total ex tax => 7.91 > GST => 0.79 (7,91 * 0.1 (10% Tax)) > > 3) Close Basket => Yes > > 4) > cgi-bin/koha/acqui/booksellers.pl?booksellerid=3 > Click receive Shipment > > fill in: > Vendor invoice: 123345 (some random number) > add no shippment costs > > 5) mark create book and click "Receive selected(1)" > > 6) mark item as received > Actual cost: 7.91 (tax exclusive) > > > 7) > Total tax exc. 7.91 > Total (GST 10%) 0.79 > Total tax inc. 8.70 > > there should be no tax because the vendor is tax excluded The vendor is not tax excluded, the setting means: the price is entered with or without tax. If you set a tax, it will still be calculated. You would need to set the tax percentage to 0 if you don't want tax. > > 8) > Secondary fund Secondary fund 1,000.00 0.00 0.00 8.70 8.70 991.30 991.30 > > the full amount is deducted even if you are tax exempt There is no setting for tax exempt. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 19:39:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 18:39:25 +0000 Subject: [Koha-bugs] [Bug 35477] Can't add items to train, claims barcode unknown or in waiting list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 --- Comment #2 from Katrin Fischer --- No error on the waiting list or only a very quick flicker and nothing in the console. I believe I might have been missing one digit in my barcode, but then the error is missing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 19:41:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 18:41:36 +0000 Subject: [Koha-bugs] [Bug 35370] There should be a system preference to disable checking for holds when issuing an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35370 --- Comment #2 from Nick Clemens --- Currently it still notifies you of the holds, but does allow checking out anyways. To avoid mistakes or cancelling holds etc. the request was made to eliminate the confirmation box and simply always allow the patron to checkout the material with no interruption -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 19:42:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 18:42:47 +0000 Subject: [Koha-bugs] [Bug 35370] There should be a system preference to disable checking for holds when issuing an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35370 --- Comment #3 from Katrin Fischer --- That makes sense, thanks for the explanation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 19:58:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 18:58:08 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #60 from David Nind --- (In reply to Katrin Fischer from comment #59) > Testing with a superlibrarian, but I don't get a pull down in the details > column on my item level holds. Any idea what could go wrong there? I'm not seeing it either... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 20:25:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 19:25:39 +0000 Subject: [Koha-bugs] [Bug 34608] Add sort1 and sort2 to patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 20:25:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 19:25:41 +0000 Subject: [Koha-bugs] [Bug 34608] Add sort1 and sort2 to patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34608 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159545|0 |1 is obsolete| | --- Comment #9 from David Nind --- Created attachment 159561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159561&action=edit Bug 34608: (follow-up) Display authorized values if used This patch shamelessly steals from Bug 33568 in order to allow the correct authorized value description to be shown in the JS-generated table of results for values of borrowers sort1 and sort2. To test, apply the patch and go to Administration -> Authorized values. - Add some values, if necessary, to both the 'Bsort1' and 'Bsort2' categories. - Locate some patron records to edit, and set the patron's "Sort 1" and "Sort 2" fields. - Perform a patron search which will return those patron records. - Confirm that the correct authorized value description is shown instead of the authorized value code. - Delete all values from the 'Bsort1' and 'Bsort2' authorized value categories. - Return to your patron search and confirm that "Sort 1" and "Sort 2" values are still being shown, though now it's the "raw" code. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 20:54:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 19:54:32 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 20:54:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 19:54:34 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159514|0 |1 is obsolete| | --- Comment #9 from Lucas Gass --- Created attachment 159562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159562&action=edit Bug 35410: Use "Online resources" label in search results Update the staff interface and OPAC XSLT files to use "Online resources" as the label in search results, instead of "Online access". This matches the label used in the detail page for a record. Test plan: 1. Search for perl in the staff interface and OPAC (or add to an existing record a URL to 856$u with 4 for the first indicator). 2. For any search result that displays the "Online access" label, view the detail page for the record. 3. Note that the detail page uses the label "Online resources". 4. Apply the patch and restart_all. 5. Repeat steps 1 and 2. 6. Note that the search result pages now show "Online resources" for the label, matching the detail page. Signed-off-by: David Nind Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 21:01:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 20:01:11 +0000 Subject: [Koha-bugs] [Bug 22632] Add logging of merged patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22632 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas at bywatersolutions.com --- Comment #57 from Lucas Gass --- Your tests include a deleted subroutine, C4::Logs::GetLogs. You must now use Koha::ActionLogs->search instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 21:10:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 20:10:51 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas at bywatersolutions.com --- Comment #32 from Lucas Gass --- As this stands no borrowers/staff will get the new permission on update. That is a change in behavior that needs to be avoided. I think we need to give anyone who has the edit_borrowers permission the list_borrowers permission via a DB update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 22:18:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 21:18:37 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature adds a new |This new feature adds a new release notes|`OpacTrustedSelfCheckout` |`OpacTrustedCheckout` |system preference. When |system preference. When |enabled, OPAC users will |enabled, OPAC users will |see a new checkout option |see a new checkout option |in the header of the page |in the header of the page |when logged in. This option |when logged in. This option |displays a modal where they |displays a modal where they |can scan barcodes to |can scan barcodes to |perform a self checkout. |perform a self checkout. | | |**Sponsored by** *European |**Sponsored by** *European |Southern Observatory* |Southern Observatory* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 22:18:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 21:18:38 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #61 from Lari Taskula --- (In reply to Katrin Fischer from comment #59) > Testing with a superlibrarian, but I don't get a pull down in the details > column on my item level holds. Any idea what could go wrong there? Looks like the change introduced to koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc in "Allow librarians to change hold type in staff client" patch was reverted by Bug 33575. So this feature is no longer working as of now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 22:22:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 21:22:17 +0000 Subject: [Koha-bugs] [Bug 35481] New: Ignore whitespace when entering or scanning barcodes in trusted web checkout modal Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35481 Bug ID: 35481 Summary: Ignore whitespace when entering or scanning barcodes in trusted web checkout modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 30979 Like in other barcode fields we should ignore leading and trailing whitespace when entering barcodes for the new trusted self checkout feature. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 [Bug 30979] Add ability for OPAC users to checkout to themselves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 22:22:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 21:22:17 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35481 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35481 [Bug 35481] Ignore whitespace when entering or scanning barcodes in trusted web checkout modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 22:25:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 21:25:35 +0000 Subject: [Koha-bugs] [Bug 35482] New: Trusted self check modal too small for translations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35482 Bug ID: 35482 Summary: Trusted self check modal too small for translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 30979 The modal for the trusted self checkout is quite small, but that doesn't work so well for languages with longer words (yes, German...). It would be nice if we made it slightly bigger to accomodate for variations like this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 [Bug 30979] Add ability for OPAC users to checkout to themselves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 22:25:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 21:25:35 +0000 Subject: [Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35482 [Bug 35482] Trusted self check modal too small for translations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:25:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:25:33 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:25:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:25:35 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #11 from Caroline Cyr La Rose --- Created attachment 159563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159563&action=edit Bug 35463: Open erm and preservation help in new tab This patch adds target="_blank" to the Vue help file so that the manual opens in a new tab when clicking on the help link in the erm and preservation modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:35:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:35:47 +0000 Subject: [Koha-bugs] [Bug 35483] New: Restore item level to record level hold switch in hold table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483 Bug ID: 35483 Summary: Restore item level to record level hold switch in hold table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 33575 commit [1] has reverted hold level switch feature added in Bug 31692 commit [2] to holds table. Switching item level holds to record level holds no longer works in the table. Let's restore the feature in this Bug. [1] https://github.com/Koha-Community/Koha/commit/c649f73d029b406a6bad80c31b8388ba19cdd15c [2] https://github.com/Koha-Community/Koha/commit/b0f49d5dafa4e2dcc05e1e85c13cde3b66f041f5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:36:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:36:18 +0000 Subject: [Koha-bugs] [Bug 35483] Restore item level to record level hold switch in hold table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33575, 31692 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 [Bug 31692] Let librarians change item level holds to record level holds when possible https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 [Bug 33575] Add table settings to the holds table for a specific record in the staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:36:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:36:18 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483 [Bug 35483] Restore item level to record level hold switch in hold table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:36:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:36:18 +0000 Subject: [Koha-bugs] [Bug 33575] Add table settings to the holds table for a specific record in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483 [Bug 35483] Restore item level to record level hold switch in hold table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:44:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:44:20 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #12 from Caroline Cyr La Rose --- Created attachment 159564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159564&action=edit Bug 35463: perltidy formatting corrections -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:49:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:49:04 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:49:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:49:07 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159562|0 |1 is obsolete| | --- Comment #10 from David Cook --- Created attachment 159565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159565&action=edit Bug 35410: Use "Online resources" label in search results Update the staff interface and OPAC XSLT files to use "Online resources" as the label in search results, instead of "Online access". This matches the label used in the detail page for a record. Test plan: 1. Search for perl in the staff interface and OPAC (or add to an existing record a URL to 856$u with 4 for the first indicator). 2. For any search result that displays the "Online access" label, view the detail page for the record. 3. Note that the detail page uses the label "Online resources". 4. Apply the patch and restart_all. 5. Repeat steps 1 and 2. 6. Note that the search result pages now show "Online resources" for the label, matching the detail page. Signed-off-by: David Nind Signed-off-by: Lucas Gass Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:49:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:49:14 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |dcook at prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:53:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:53:23 +0000 Subject: [Koha-bugs] [Bug 35483] Restore item level to record level hold switch in hold table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:53:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:53:25 +0000 Subject: [Koha-bugs] [Bug 35483] Restore item level to record level hold switch in hold table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483 --- Comment #1 from Lari Taskula --- Created attachment 159566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159566&action=edit Bug 35483: Restore holds table select to switch item level holds to record level holds To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item " dropdown 5. Select "Next available" from the dropdown 6. Click Update hold(s) 7. Observe dropdown is gone and cell value has changed from "Only item " to "Next available" 8. Cancel the hold and add two item level holds for the same patron 9. Under "Existing holds" table, in "Details" column you should see "Only item ", but no select dropdown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:56:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:56:48 +0000 Subject: [Koha-bugs] [Bug 35381] Add list_borrowers permission for viewing patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35381 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from David Cook --- *** This bug has been marked as a duplicate of bug 30230 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:56:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:56:48 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #33 from David Cook --- *** Bug 35381 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 4 23:58:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 22:58:54 +0000 Subject: [Koha-bugs] [Bug 29291] Self Registration e-mail verification is not stored in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29291 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|RESOLVED |REOPENED --- Comment #4 from Christopher Brannon --- I don't think I am being understood here. I am not talking about the template of OPAC_REG_VERIFY. That is all well and good. What I am not seeing is a copy of the email sent to the patron in notices.pl. It would be great if we could see what was sent out here, and when it was sent. It would also be great if we could resend it, if they missed their window of time to respond. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 00:07:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 23:07:48 +0000 Subject: [Koha-bugs] [Bug 35484] New: OPACShelfBrowser secondary sort should be biblio.title not item.itemnumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35484 Bug ID: 35484 Summary: OPACShelfBrowser secondary sort should be biblio.title not item.itemnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The OPACShelfBrowser sorts on cn_sort but also includes a secondary sort on itemnumber. This secondary sort is arbitrary and unhelpful, libraries typically don't arrange things on the shelf based on Koha's itemnumber. This secondary sort should be based on title to better refelct how libraries organize shelves. To recreate: 1. In k-t-d, set all item itemcallnumbers to the same thing, ie: 'abcdefg'; 2. Touch all items to update the cn_sort values 3. Turn on OPACShelfBrowser and view a record detail page on the OPAC. 4. Browse the shelf and see that all items are organized by itemnumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 00:13:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 23:13:58 +0000 Subject: [Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692 --- Comment #62 from Lari Taskula --- See Bug 35483 for restoring the missing feature. (In reply to Tomás Cohen Arazi from comment #56) > Lari, are you still willing to work on this? Thanks Sorry I had either missed or forgot to answer your comment! (In reply to Tomás Cohen Arazi from comment #54) > Can we please change the method signature? I'd expect > > $hold->change_type( > { > type => [biblio|item], > [ item_id => $item->id, ] > } > ); > > Or even split it in two methods: > > $hold->make_biblio_level > $hold->make_item_level( $item->id ) Well, why not, if you feel it's still important even after pushing the Bug (sorry again for the late answer). I'm not extremely attached or strongly opinionated about the choice I made - I suppose I was thinking of it more as a toggle hence not introducing two methods. The itemnumber param in my sense specifies the type already, if given => item, if not given => biblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 00:14:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Dec 2023 23:14:31 +0000 Subject: [Koha-bugs] [Bug 29291] Self Registration e-mail verification is not stored in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29291 --- Comment #5 from David Cook --- (In reply to Christopher Brannon from comment #4) > I don't think I am being understood here. I am not talking about the > template of OPAC_REG_VERIFY. That is all well and good. What I am not > seeing is a copy of the email sent to the patron in notices.pl. It would be > great if we could see what was sent out here, and when it was sent. It > would also be great if we could resend it, if they missed their window of > time to respond. You're misunderstanding Katrin's comment. The email doesn't appear in notices.pl because it's not linked to the patron by borrowernumber, since the patron and its borrowernumber doesn't exist until after they verify the registration. You could see the information via a SQL report, but it's true there's no way of resending it, although the window to respond out of the box is 14 days. If they haven't signed up in that time, I think it's reasonable to have them try to self-register again. I don't really see this one changing, but I suppose it's possible someone could sponsor an enhancement that provides a UI for an administrator to see all emails in the message_queue and lets them resend whatever they want. But I think that would different to "Self Registration e-mail verification is not stored in notices". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 01:58:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 00:58:45 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159494|0 |1 is obsolete| | --- Comment #16 from Lari Taskula --- Created attachment 159567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159567&action=edit Bug 35471: Add column parent_frameworkcode to table biblio_framework Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 01:58:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 00:58:48 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159495|0 |1 is obsolete| | --- Comment #17 from Lari Taskula --- Created attachment 159568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159568&action=edit Bug 35471: DBIx changes Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 01:58:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 00:58:50 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159496|0 |1 is obsolete| | --- Comment #18 from Lari Taskula --- Created attachment 159569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159569&action=edit Bug 35471: Add support for selecting parent framework on MARC framework modification screen To test: 1. Navigate to Administration -> MARC bibliographic framework 2. Create MARC framework with frameworkcode "A" 3. Observe new field "Parent framework" when adding a new framework 4. After adding the framework, click Actions -> MARC structure 5. Select "Create framework for A" using "Default", click OK 6. Navigate back to frameworks listing 7. Create framework with frameworkcode "A-1" 8. Select framework you created at step 2 as the parent framework 9. After adding the framework, click Actions -> MARC structure 10. Select "Create framework for A-1" using "Default", click OK Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 01:58:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 00:58:53 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159497|0 |1 is obsolete| | --- Comment #19 from Lari Taskula --- Created attachment 159570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159570&action=edit Bug 35471: List child frameworks on MARC modification screen 1. Navigate to Administration -> MARC bibliographic framework 2. Select the parent framework you added in previous patch 3. Observe child framework being listed Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 01:58:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 00:58:55 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159498|0 |1 is obsolete| | --- Comment #20 from Lari Taskula --- Created attachment 159571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159571&action=edit Bug 35471: List parent frameworks on MARC framework list screen 1. Navigate to Administration -> MARC bibliographic framework 2. Observe new column "Parent framework" 3. Observe parent framework being populated for the child framework you added in previous patch Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 01:58:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 00:58:57 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159499|0 |1 is obsolete| | --- Comment #21 from Lari Taskula --- Created attachment 159572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159572&action=edit Bug 35471: Add Koha::Template::Plugin::Frameworks->GetChildren() To test: 1. prove t/db_dependent/Koha/Template/Plugin/Frameworks.t Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 01:59:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 00:59:00 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159500|0 |1 is obsolete| | --- Comment #22 from Lari Taskula --- Created attachment 159573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159573&action=edit Bug 35471: Add child frameworks to cataloguing toolbar's new child record button To test: Administration -> MARC bibliographic framework 1. Create framework with frameworkcode "A" 2. Create framework with frameworkcode "A-1" 3. Set "A" as "A-1" 's parent framework Record view 1. Save record with framework "A" 2. Navigate to a record 3. Click "+ New", a drop-down opens 4. Click "New child record" 5. After add biblio form opens, click "Settings" 6. Observe "A-1" framework automatically selected Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 02:07:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 01:07:04 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 --- Comment #23 from Lari Taskula --- I know qa-tools is complaining about tidiness, I tried my best fixing the issues but eventually had to give up as I'm not able to resolve them. KomodoIDE/perltidy v20230912/perltidy command line arguments: -pro=/kohapath/.perltidyrc , Code -> Format -> Selection using perltidy How do I know which lines are less tidy exactly? Can koha-qa tell me that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 03:07:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 02:07:12 +0000 Subject: [Koha-bugs] [Bug 35485] New: Error staging authority MARC record if a match is found Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35485 Bug ID: 35485 Summary: Error staging authority MARC record if a match is found Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org To reproduce: 1. Set up a record matching rule Match threshold: 100 Record type: authority Matchpoint 1: Search index: local-number Score: 100 Tag: 001 2. Create an authority record 3. Save the authority record in any format (maybe marcxml) 4. Go to Stage MARC for import in Cataloguing Home 5. Upload your downloaded MARC for the authority record. Set the following settings: Record type: authority Record matching rule: Your new 001 matching rule 6. Stage for import. Notice the job FAILS. There appears to be no useful error messages in logs, but the job results say '1 records not staged because of MARC error' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 03:12:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 02:12:51 +0000 Subject: [Koha-bugs] [Bug 35485] Error staging authority MARC record if a match is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35485 --- Comment #1 from Aleisha Amohia --- Confirm we get this error in every version 22.05.x and above -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 04:57:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 03:57:17 +0000 Subject: [Koha-bugs] [Bug 28965] Add public routes for lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 04:57:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 03:57:23 +0000 Subject: [Koha-bugs] [Bug 28965] Add public routes for lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28965 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 06:27:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 05:27:02 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 --- Comment #11 from David Nind --- Thanks Lucas for the sign-off and David for the QA! David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 06:38:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 05:38:23 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 07:10:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 06:10:12 +0000 Subject: [Koha-bugs] [Bug 32029] Automatic item modifications by age missing biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 07:10:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 06:10:15 +0000 Subject: [Koha-bugs] [Bug 32029] Automatic item modifications by age missing biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151073|0 |1 is obsolete| | --- Comment #6 from Fridolin Somers --- Created attachment 159574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159574&action=edit Bug 32029: Automatic item modifications by age add biblio table In automatic item modifications by age missing, conditions can be on columns of tables items or biblioitems. Table biblio is missing. Test plan : 1) Create an automatic item modifications by age with a condition on a column of biblio table 2) Create a record and item matching the rule 3) Run misc/cronjobs/automatic_item_modification_by_age.pl -c -v => Check only matching items are impacted Signed-off-by: Philip Orr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 07:10:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 06:10:27 +0000 Subject: [Koha-bugs] [Bug 32029] Automatic item modifications by age missing biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029 --- Comment #7 from Fridolin Somers --- Created attachment 159575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159575&action=edit Bug 32029: (follow-up) unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 07:10:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 06:10:53 +0000 Subject: [Koha-bugs] [Bug 32029] Automatic item modifications by age missing biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32029 --- Comment #8 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #5) > Please add some tests to > t/db_dependent/Items/AutomaticItemModificationByAge.t Here it is :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 07:17:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 06:17:07 +0000 Subject: [Koha-bugs] [Bug 32448] Datatable filtering problem whith hidden column In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32448 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Fridolin Somers --- Great, fixed *** This bug has been marked as a duplicate of bug 30406 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 07:17:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 06:17:07 +0000 Subject: [Koha-bugs] [Bug 30406] Our DT tables not filtering on the correct column if hidden by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30406 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin Somers --- *** Bug 32448 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 07:56:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 06:56:16 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #13 from Martin Renvoize --- The window open for other help links is found in https://git.koha-community.org/Koha-community/Koha/src/commit/b6f350e27598ff68d930880fddc7dcb6c08719fd/koha-tmpl/intranet-tmpl/prog/js/staff-global.js. I think for the Vue equivalent we'll 2ant to adapt the Vue component, https://git.koha-community.org/Koha-community/Koha/src/commit/5a188651e484517f28367e44183b680fa77ad77b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Help.vue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 07:57:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 06:57:31 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #14 from Martin Renvoize --- Oops, must read full pay he's including follow-ups before posting.. sorry for the noise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 08:03:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 07:03:52 +0000 Subject: [Koha-bugs] [Bug 35486] New: When editing an authority show all subfields of the heading field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35486 Bug ID: 35486 Summary: When editing an authority show all subfields of the heading field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Currently when creating/editing and authority, only mandatory fields are shown. This patch changes to show all subfields for the heading tag. For example in UNIMARC authorities NP show subfields of 200 : $a surname, $b firstname ... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 08:10:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 07:10:06 +0000 Subject: [Koha-bugs] [Bug 35482] Trusted self check modal too small for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35482 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #1 from Magnus Enger --- Norwegian translations are often longer than the English originals too. ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 08:29:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 07:29:09 +0000 Subject: [Koha-bugs] [Bug 35486] When editing an authority show all subfields of the heading field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35486 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED --- Comment #1 from Fridolin Somers --- For example in MARC21 authorities Personal Name show subfields of 100 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 08:35:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 07:35:19 +0000 Subject: [Koha-bugs] [Bug 35486] When editing an authority show all subfields of the heading field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35486 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 08:35:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 07:35:21 +0000 Subject: [Koha-bugs] [Bug 35486] When editing an authority show all subfields of the heading field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35486 --- Comment #2 from Fridolin Somers --- Created attachment 159576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159576&action=edit Bug 35486: When editing an authority show all subfields of the heading field Currently when creating/editing and authority, only mandatory fields are shown. This patch changes to show all subfields for the heading tag. For example in UNIMARC authorities NP show subfields of 200 : $a surname, $b firstname ... For example in MARC21 authorities Personal Name show subfields of 100 This will make cataloguing easier since heading subfields are usually filled. Test plan : 1) Use MARC21 database 2) Create a new authority type 'Personal Name' 3) In section 0 you see for example field 40 showing only mandatory subfield $a 4) Go to section 1 5) You see all subfields of field 100 because it is the heading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 09:08:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 08:08:24 +0000 Subject: [Koha-bugs] [Bug 34142] Add column sub_location to items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #11 from Emmi Takkinen --- Now I'm facing the same problem as Owen. Update runs as it should, but column isn't added to database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 09:10:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 08:10:40 +0000 Subject: [Koha-bugs] [Bug 34142] Add column sub_location to items table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34142 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #12 from Emmi Takkinen --- (In reply to Emmi Takkinen from comment #11) > Now I'm facing the same problem as Owen. Update runs as it should, but > column isn't added to database. My bad, for some reason column was already in the table but in wrong place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 09:37:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 08:37:13 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #15 from Jonathan Druart --- 243 'preservation/trains/' => '/preservation.html#trains', Shouldn't it link to /preservation.html#show-train? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 09:37:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 08:37:25 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #16 from Jonathan Druart --- Everything is perfect, thanks a lot! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 09:49:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 08:49:04 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #34 from Thibaud Guillot --- (In reply to Andrew Fuerste-Henry from comment #31) > Created attachment 159559 [details] > Link to be removed > > This latest patch addresses all of my concerns except for the "Search > Patrons" link in the main search bar on the patron search results page. See > attached screenshot. We should hide that "Search Patrons" link entirely. Hello Andrew, Normally I've taken your comments into account and removed the "Search patrons" link from the main search bar... it's only accessible to members with 'catalog' permission. Unless I've misunderstood, but from my point of view, with a member who only has the 'list_borrowers' permission, this seems correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 09:50:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 08:50:55 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #35 from Thibaud Guillot --- (In reply to Lucas Gass from comment #32) > As this stands no borrowers/staff will get the new permission on update. > That is a change in behavior that needs to be avoided. > > I think we need to give anyone who has the edit_borrowers permission the > list_borrowers permission via a DB update. Hello Lucas, This permission is only there to allow search and list view of members, no access to the details of each member (moremember.pl) and therefore in my opinion no update... I've missed something else, or perhaps I'm misunderstanding you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 12:32:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 11:32:18 +0000 Subject: [Koha-bugs] [Bug 35487] New: It would be nice to have a Selective dissemination of information module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35487 Bug ID: 35487 Summary: It would be nice to have a Selective dissemination of information module Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: verolencinas at yahoo.com.ar QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Selective dissemination of information is a current awareness service in which libraries or information centers send new publications to users. It can be implemented in Koha through lists that have to be manually send to interested users, or through public lists to which users can subscribe through RSS. A real Selective dissemination of information module would need to be able to configure one or several search terms or search expressions, and a scheduler to trigger these searches regularly. The results of the search should only include records added after the last search and be send to users in a user list. The "send" function could be implemented through mail or OPAC access or both. Librarians should be able to control the lists sent to the users. That could be implemented for example with a delay in sending during which librarians could alter the list, or more simple through a access to sent lists where librarians can control which records has been sent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 12:57:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 11:57:52 +0000 Subject: [Koha-bugs] [Bug 35487] Add a selective dissemination of information module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35487 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature Summary|It would be nice to have a |Add a selective |Selective dissemination of |dissemination of |information module |information module Version|22.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 13:51:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 12:51:45 +0000 Subject: [Koha-bugs] [Bug 35238] Incorrect label markup in patron card creator printer profile edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35238 --- Comment #1 from Eugene Espinoza --- Created attachment 159577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159577&action=edit Bug 35238: Incorrect label markup in patron card creator printer profile edit form HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'. So from: It should now be: Template name: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 13:56:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 12:56:35 +0000 Subject: [Koha-bugs] [Bug 35238] Incorrect label markup in patron card creator printer profile edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35238 Eugene Espinoza changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159577|0 |1 is obsolete| | --- Comment #2 from Eugene Espinoza --- Created attachment 159578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159578&action=edit Bug 35238: Incorrect label markup in patron card creator printer profile edit form HTML element for Template name is changed from 'label for "template_name"' to 'span with "label" class'. So from: It should now be: Template name: To test: 1) Go to: Tools -> Patron card creator -> Edit printer profile. 2) Right click page and choose "View page source". 3) Locate the part with "Template name". It should read: Template name: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 14:19:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 13:19:53 +0000 Subject: [Koha-bugs] [Bug 35477] Can't add items to train, claims barcode unknown or in waiting list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 --- Comment #3 from Jonathan Druart --- It says "No items added". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 14:20:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 13:20:34 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't add items to train, |Adding non-existent items |claims barcode unknown or |to the waiting list should |in waiting list |display a warning -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 14:22:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 13:22:43 +0000 Subject: [Koha-bugs] [Bug 34850] MySQL 8 test suite output is full of warnings regarding mysql_native_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 14:22:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 13:22:46 +0000 Subject: [Koha-bugs] [Bug 34850] MySQL 8 test suite output is full of warnings regarding mysql_native_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34850 --- Comment #1 from Jonathan Druart --- Created attachment 159579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159579&action=edit Bug 34850: Show a warning when non-existent items are added to the waiting list Only messages "X new items added" or "No items added" were displayed. With this patch we will display: A warning with "No items added" A warning with "X new items added. Y items not found." when some items have not been added A messages "X new items added" when everything went well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 14:23:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 13:23:31 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 14:23:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 13:23:33 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 --- Comment #4 from Jonathan Druart --- Created attachment 159580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159580&action=edit Bug 35477: Show a warning when non-existent items are added to the waiting list Only messages "X new items added" or "No items added" were displayed. With this patch we will display: A warning with "No items added" A warning with "X new items added. Y items not found." when some items have not been added A messages "X new items added" when everything went well -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 14:23:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 13:23:35 +0000 Subject: [Koha-bugs] [Bug 34850] MySQL 8 test suite output is full of warnings regarding mysql_native_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 14:23:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 13:23:48 +0000 Subject: [Koha-bugs] [Bug 34850] MySQL 8 test suite output is full of warnings regarding mysql_native_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 14:24:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 13:24:01 +0000 Subject: [Koha-bugs] [Bug 34850] MySQL 8 test suite output is full of warnings regarding mysql_native_password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34850 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 14:24:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 13:24:22 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart+koha at gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 14:47:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 13:47:21 +0000 Subject: [Koha-bugs] [Bug 35479] plugins nightly cronjob should log the plugins that are being run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 --- Comment #2 from Nick Clemens --- Created attachment 159581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159581&action=edit Bug 35479: (follow-up) Match formatting for other cronjob logs To test: 1 - Install the Kitchen Sink plugin 2 - Restart all 3 - Enable 'CronjobLog' system preference 4 - perl misc/cronjobs/plugins_nightly.pl 5 - Note you see on the command line 'Remember to clean the kitchen' - this indicates the plugin cron ran 6 - Tools->log viewer, select 'cronjob' and view 7 - Note you only see 'plugins_nightly.pl' Run and End lines 8 - Apply patches 9 - perl misc/cronjobs/plugins_nightly.pl 10 - View logs agian 11 - Note you now see Run and End lines for 'Koha::Plugin::Com::ByWaterSolutions::KitchenSink' 12 - Confirm they look like the other lines 13 - Edit KitchenSink.pm and add 'die "Kittens";' to the cronjob nightly 14 - perl misc/cronjobs/plugins_nightly.pl 15 - View logs, confirm there is a FAILED error message for the KitchenSink cron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 14:47:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 13:47:42 +0000 Subject: [Koha-bugs] [Bug 35479] plugins nightly cronjob should log the plugins that are being run In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35479 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 15:21:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 14:21:49 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159485|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 159582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159582&action=edit Bug 35463: Link preservation module help to the manual This patch links the various pages of the preservation module to each specific section of the preservation module chapter in the manual. To test: 1. Enable the PreservationModule system preference 2. Go to the Preservation module 3. Click "help" in the top right corner --> You are brought to the manual, but not a specific page 4. Apply patch 5. Click "Help" in the top right corner --> You are brought to the Preservation chapter of the manual 6. Click "Settings" 7. Click "Help" in the top right corner --> You are brought to the Settings section of the Preservation chapter of the manual 8. Choose a not for loan status for items added to the waiting list (the mandatory field) and submit 9. Click "Add a new processing" 10. Click "Help" in the top right corner --> You are brought to the Add a new processing section of the Preservation chapter of the manual 11. Fill out the form to create the processing and submit 12. Click "Edit this processing" 13. Click "Help" in the top right corner --> You are brought to the Add a new processing section of the Preservation chapter of the manual (there is no edit a processing section) 14. Click "Waiting list" 15. Click "Help" in the top right corner --> You are brought to the Waiting list section of the Preservation chapter of the manual 16. Add items to the waiting list 17. Click "Trains" 18. Click "Help" in the top right corner --> You are brought to the Trains section of the Preservation chapter of the manual 19. Click "New train" 20. Click "Help" in the top right corner --> You are brought to the New train section of the Preservation chapter of the manual 21. Fill out the form to create a new train and submit 22. Click "Add items" 23. Click "Help" in the top right corner --> You are brought to the Add items section of the Preservation chapter of the manual 24. Also check ERM help links to make sure nothing is broken Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 15:21:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 14:21:52 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159563|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 159583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159583&action=edit Bug 35463: Open erm and preservation help in new tab Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 15:21:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 14:21:54 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159564|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize --- Created attachment 159584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159584&action=edit Bug 35463: perltidy formatting corrections Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 15:22:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 14:22:47 +0000 Subject: [Koha-bugs] [Bug 18885] When 'on-site checkout' was used, the 'Specify due date' should be emptied for next checkout unless OnSiteCheckoutAutoCheck In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885 Biblibre Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158115|0 |1 is obsolete| | --- Comment #4 from Biblibre Sandboxes --- Created attachment 159585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159585&action=edit Bug 18885: Specify due date behavior according to on-site checkbox When a on-site checkout is performed a date is automatically added but if you unchecked the date remains. Even with OnSiteCheckoutAutoCheck syspref Test plan: 1) Do an on-site checkout by clicking on checkbox and see date added 2) Unchecked and see that the date remains on input 3) Do another test with OnSiteCheckoutAutoCheck enabled 4) Apply this patch and repeat actions Normally now its works correctly Signed-off-by: tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 15:22:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 14:22:59 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from Martin Renvoize --- Great work, signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 15:23:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 14:23:56 +0000 Subject: [Koha-bugs] [Bug 18885] When 'on-site checkout' was used, the 'Specify due date' should be emptied for next checkout unless OnSiteCheckoutAutoCheck In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18885 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor at tuxayo.net --- Comment #5 from Victor Grousset/tuxayo --- It work :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 15:51:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 14:51:29 +0000 Subject: [Koha-bugs] [Bug 35034] Add link to the bibliographic records when they are selected for merging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35034 --- Comment #5 from Laura Escamilla --- (In reply to Katrin Fischer from comment #4) Thank you, Katrin! I will implement this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 15:52:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 14:52:46 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 15:52:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 14:52:48 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #21 from Caroline Cyr La Rose --- Created attachment 159586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159586&action=edit Bug 35463: More preservation manual links This patch adds some missing links from the preservation module to the manual. To test: 1. Go to Preservation > Trains 2. Click on a train name --> You are brought to the Show train section of the Preservation chapter of the manual 3. Click Edit next to an item --> You are brought to the Add items section of the Preservation chapter of the manual (there is no section specific to editing items, but the form to edit is the same as the form to add) 4. Go back to the trains list, and click the Edit button next to one of the trains --> You are brought to the Trains section of the Preservation chapter of the manual (there is no section specific to editing trains yet) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 15:53:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 14:53:51 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 --- Comment #22 from Caroline Cyr La Rose --- (In reply to Jonathan Druart from comment #15) > 243 'preservation/trains/' => > '/preservation.html#trains', > > Shouldn't it link to /preservation.html#show-train? I added a new patch for this (as well as a couple of other pages). I set the bug back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 15:59:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 14:59:01 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28995 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 [Bug 28995] Add --added_after to writeoff_debts.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 15:59:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 14:59:01 +0000 Subject: [Koha-bugs] [Bug 28995] Add --added_after to writeoff_debts.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28995 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34077 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:05:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:05:10 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #36 from Lucas Gass --- (In reply to Thibaud Guillot from comment #35) > (In reply to Lucas Gass from comment #32) > > As this stands no borrowers/staff will get the new permission on update. > > That is a change in behavior that needs to be avoided. > > > > I think we need to give anyone who has the edit_borrowers permission the > > list_borrowers permission via a DB update. > > Hello Lucas, > > This permission is only there to allow search and list view of members, no > access to the details of each member (moremember.pl) and therefore in my > opinion no update... I've missed something else, or perhaps I'm > misunderstanding you. If staff can see/view borrower information before the patchset they need to have the same behavior after the patchset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:07:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:07:24 +0000 Subject: [Koha-bugs] [Bug 35034] Add link to the bibliographic records when they are selected for merging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35034 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:07:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:07:27 +0000 Subject: [Koha-bugs] [Bug 35034] Add link to the bibliographic records when they are selected for merging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35034 --- Comment #6 from Laura Escamilla --- Created attachment 159587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159587&action=edit Bug 35034: Add parameter that links titles to their records Same test as above -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:07:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:07:56 +0000 Subject: [Koha-bugs] [Bug 35413] Terminology: differentiate issues for vendor issues and serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Terminology: Manage issues |Terminology: differentiate |(issue_manage) |issues for vendor issues | |and serials --- Comment #3 from Katrin Fischer --- Thx for fixing the navigation! I ran into this today as it's the same string for serials and vendor issues currently. This will help a lot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:08:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:08:17 +0000 Subject: [Koha-bugs] [Bug 35034] Add link to the bibliographic records when they are selected for merging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35034 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156962|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:20:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:20:15 +0000 Subject: [Koha-bugs] [Bug 29007] Prompt for reason when cancelling waiting hold via popup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com Documentation| |kelly mcelligott contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:28:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:28:39 +0000 Subject: [Koha-bugs] [Bug 35488] New: Placing a hold on the OPAC takes the user to their accont page, but does not activate the holds tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 Bug ID: 35488 Summary: Placing a hold on the OPAC takes the user to their accont page, but does not activate the holds tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Place a hold on the opac 2 - Note after placing the hold the URL is: http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds 3 - Note the holds tab is not active -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:38:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:38:28 +0000 Subject: [Koha-bugs] [Bug 35488] Placing a hold on the OPAC takes the user to their accont page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:47:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:47:01 +0000 Subject: [Koha-bugs] [Bug 35489] New: Holds on items with no barcode are missing an input for itemnumber Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Bug ID: 35489 Summary: Holds on items with no barcode are missing an input for itemnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This causes a move/loss of data on the holds form (request.pl) when holds are adjusted To test: 1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without 2 - Place an item level hold on the item with no barcode 3 - Place another hold for a different patron on the item with a barcode 4 - From the holds table add an expiration date to the hold with a barcode and save 5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:50:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:50:50 +0000 Subject: [Koha-bugs] [Bug 35489] Holds on items with no barcode are missing an input for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:50:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:50:52 +0000 Subject: [Koha-bugs] [Bug 35489] Holds on items with no barcode are missing an input for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 --- Comment #1 from Nick Clemens --- Created attachment 159588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159588&action=edit Bug 35489: Add a hidden input for itemnumber even if item has no barcode This page is a single form, all fields must have inputs to avoid data loss/mismatch To test: 1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without 2 - Place an item level hold on the item with no barcode 3 - Place another hold for a different patron on the item with a barcode 4 - From the holds table add an expiration date to the hold with a barcode and save 5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold 6 - Delete the holds 7 - Apply patch 8 - Repeat 2-4 9 - Confirm the itemnumbers for the holds have not changed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:51:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:51:24 +0000 Subject: [Koha-bugs] [Bug 35490] New: Remove GetMarcItem from C4::Biblio Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35490 Bug ID: 35490 Summary: Remove GetMarcItem from C4::Biblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:53:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:53:17 +0000 Subject: [Koha-bugs] [Bug 35490] Remove GetMarcItem from C4::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35490 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:53:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:53:19 +0000 Subject: [Koha-bugs] [Bug 35490] Remove GetMarcItem from C4::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35490 --- Comment #1 from Marcel de Rooy --- Created attachment 159589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159589&action=edit Bug 35490: Remove GetMarcItem from C4::Biblio module Test plan: Compile module, run qa tools. Search for the use of C4::Items in C4/Biblio. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:53:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:53:42 +0000 Subject: [Koha-bugs] [Bug 35490] Remove GetMarcItem from C4::Biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35490 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | --- Comment #2 from Marcel de Rooy --- Trivial one liner: self SO -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:55:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:55:06 +0000 Subject: [Koha-bugs] [Bug 33427] Managing individual users with access to subscriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33427 Jessie Zairo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com --- Comment #1 from Jessie Zairo --- Like this enhancement. This would be helpful for staff/librarians to track who has access to this particular subscription / resource in this license. Currently, only staff with superlibrarian or ERM permissions are returned in the search results when adding users to the license. An example would be attaching a faculty member or professor who has access or lawyer or attorney who has access. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:58:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:58:24 +0000 Subject: [Koha-bugs] [Bug 35034] Add link to the bibliographic records when they are selected for merging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35034 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:58:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:58:26 +0000 Subject: [Koha-bugs] [Bug 35034] Add link to the bibliographic records when they are selected for merging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35034 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159587|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 159590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159590&action=edit Bug 35034: Add parameter that links titles to their records To recreate: 1. Select two items from the catalog and begin a merge. 2. Notice that the title of the items, their biblionumber and a hyperlink to their MARC record is available. 3. Apply the patch and refresh the page. The biblionumber for each title is now hyperlinked and leads to the item’s bib records. 4. Sign off and have a great day :) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 16:58:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 15:58:47 +0000 Subject: [Koha-bugs] [Bug 35489] Holds on items with no barcode are missing an input for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:02:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:02:04 +0000 Subject: [Koha-bugs] [Bug 35483] Restore item level to record level hold switch in hold table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:08:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:08:05 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159005|0 |1 is obsolete| | --- Comment #10 from Matt Blenkinsop --- Created attachment 159591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159591&action=edit Bug 35341: Fix ciruclation rule dates being overwritten This patch correctly sets the values of the date fields so that they are not overwritten when only one is amended. It also amends the collumn indexes being used in the click event as new columns have been added without these being updated Test plan: 1) Navigate to Administration > Circulation and fine rules 2) Add a new circulation rule for a category of your choice 3) For the "All" rule, add the date 31/12/2023 to both the Hard due date and No automatic renewal after (hard limit) (NARAHL) columns and save 4) Now edit the rule that you created. 5) Change the two columns above to 01/12/2023 and click save 6) Edit the rule again and change the Hard due date to 15/12/2023. Click save 7) Note that the date for your rule in the NARAHL has changed to 31/12/2023 despite not being edited 8) Click edit again, and change the NARAHL date to 15/12/2023 and save. 9) This time the date in Hard due date will have changed to 31/12/2023 10) Apply patch 11) Edit the dates individually a few times and this time your rule should update correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:08:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:08:38 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 --- Comment #11 from Matt Blenkinsop --- Created attachment 159592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159592&action=edit Bug 35341: Fix circulation rule dates being overwritten This patch correctly sets the values of the date fields so that they are not overwritten when only one is amended. It also amends the collumn indexes being used in the click event as new columns have been added without these being updated Test plan: 1) Navigate to Administration > Circulation and fine rules 2) Add a new circulation rule for a category of your choice 3) For the "All" rule, add the date 31/12/2023 to both the Hard due date and No automatic renewal after (hard limit) (NARAHL) columns and save 4) Now edit the rule that you created. 5) Change the two columns above to 01/12/2023 and click save 6) Edit the rule again and change the Hard due date to 15/12/2023. Click save 7) Note that the date for your rule in the NARAHL has changed to 31/12/2023 despite not being edited 8) Click edit again, and change the NARAHL date to 15/12/2023 and save. 9) This time the date in Hard due date will have changed to 31/12/2023 10) Apply patch 11) Edit the dates individually a few times and this time your rule should update correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:09:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:09:03 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159591|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:09:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:09:10 +0000 Subject: [Koha-bugs] [Bug 35483] Restore item level to record level hold switch in hold table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:09:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:09:12 +0000 Subject: [Koha-bugs] [Bug 35483] Restore item level to record level hold switch in hold table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159566|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 159593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159593&action=edit Bug 35483: Restore holds table select to switch item level holds to record level holds To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item " dropdown 5. Select "Next available" from the dropdown 6. Click Update hold(s) 7. Observe dropdown is gone and cell value has changed from "Only item " to "Next available" 8. Cancel the hold and add two item level holds for the same patron 9. Under "Existing holds" table, in "Details" column you should see "Only item ", but no select dropdown Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:09:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:09:14 +0000 Subject: [Koha-bugs] [Bug 35483] Restore item level to record level hold switch in hold table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483 --- Comment #3 from Owen Leonard --- Created attachment 159594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159594&action=edit Bug 35483: (follow-up) Trivial indentation changes Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:11:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:11:26 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Matt Blenkinsop --- I've taken your test patch Marcel and made some changes so that it now only uses flatpickr rather than adding additional hidden inputs to hold the value. This feels like a major bug so I think we should get a fix in place for this ASAP. Let me know what you think and if you agree with the concept I will address some of the other issues you spotted in follow-up bugs (e.g. incorrect column indexes etc). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:27:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:27:34 +0000 Subject: [Koha-bugs] [Bug 35491] New: Reverting waiting status for holds is not logged Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35491 Bug ID: 35491 Summary: Reverting waiting status for holds is not logged Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We should capture the modification of the hold when this is done -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:35:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:35:47 +0000 Subject: [Koha-bugs] [Bug 35491] Reverting waiting status for holds is not logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35491 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:35:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:35:49 +0000 Subject: [Koha-bugs] [Bug 35491] Reverting waiting status for holds is not logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35491 --- Comment #1 from Nick Clemens --- Created attachment 159595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159595&action=edit Bug 35491: Add logging to RevertWaitingStatus This patch simply adds a logaction line to RevertWaitingStatus To test: 1 - Enable HoldsLog 2 - Place a hold 3 - Fill the hold 4 - Revert the waiting status 5 - Note there is no action log added 6 - Apply patch 7 - Repeat 2-4 8 - Confirm you now have a MODIFY action logged for the reversion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:36:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:36:00 +0000 Subject: [Koha-bugs] [Bug 35491] Reverting waiting status for holds is not logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35491 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:36:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:36:04 +0000 Subject: [Koha-bugs] [Bug 35489] Holds on items with no barcode are missing an input for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:41:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:41:56 +0000 Subject: [Koha-bugs] [Bug 35488] Placing a hold on the OPAC takes the user to their accont page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:41:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:41:58 +0000 Subject: [Koha-bugs] [Bug 35488] Placing a hold on the OPAC takes the user to their accont page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 --- Comment #1 from Lucas Gass --- Created attachment 159596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159596&action=edit Bug 35488: Open holds tab by default on opac-user.pl after placing a hold 1 - Place a hold on the opac 2 - Note after placing the hold the URL is: http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds 3 - Note the holds tab is not active 4 - APPLY PATCH and restart_all 5 - Try steps 1 - 3 again, this time the holds tab should be opened. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:43:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:43:12 +0000 Subject: [Koha-bugs] [Bug 35444] Add easy way to retrieve a logged in user's categorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35444 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:43:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:43:14 +0000 Subject: [Koha-bugs] [Bug 35444] Add easy way to retrieve a logged in user's categorycode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35444 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159380|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 159597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159597&action=edit Bug 35444: Add hidden span with information about the loggedinuser categorycode To test: 1. APPLY PATCH 2. Log into the staff interface and use the browser's dev tools to look for the HTML class 'loggedincategorycode'. It should match the current logged in user's categorycode. 3. You could also use a console.log like so: console.log( $('.loggedincategorycode').text() ); Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:49:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:49:27 +0000 Subject: [Koha-bugs] [Bug 35492] New: Suspending/unsuspending a hold on the OPAC takes the user to their account page, but does not activate the holds tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35492 Bug ID: 35492 Summary: Suspending/unsuspending a hold on the OPAC takes the user to their account page, but does not activate the holds tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Go to the opac-user.pl page for a user with some holds and suspend a hold. 2 - Note after placing the hold the URL is: http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds 3 - Note the holds tab is not active -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:49:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:49:38 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157230|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 159598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159598&action=edit Bug 34077: Update output to match POD This patch adds a check on !$confirm such that we enable verbose output should the confirm flag not be passed. This adheres with what the documentation already states. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:49:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:49:39 +0000 Subject: [Koha-bugs] [Bug 35492] Suspending/unsuspending a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35492 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com Depends on| |35488 Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 [Bug 35488] Placing a hold on the OPAC takes the user to their accont page, but does not activate the holds tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:49:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:49:39 +0000 Subject: [Koha-bugs] [Bug 35488] Placing a hold on the OPAC takes the user to their accont page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35492 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35492 [Bug 35492] Suspending/unsuspending a hold on the OPAC takes the user to their account page, but does not activate the holds tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:50:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:50:26 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Martin Renvoize --- The logic was flawed, thanks for testing David. I've corrected it now, and also added a little extra detail into the output as it was missing some of the more recently added parameters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:52:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:52:55 +0000 Subject: [Koha-bugs] [Bug 35492] Suspending/unsuspending a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35492 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:52:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:52:57 +0000 Subject: [Koha-bugs] [Bug 35492] Suspending/unsuspending a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35492 --- Comment #1 from Lucas Gass --- Created attachment 159599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159599&action=edit Bug 35492: Open holds tab by default on opac-user.pl after suspending a hold To recreate: 1 - Go to the opac-user.pl page for a user with some holds and suspend a hold. 2 - Note after placing the hold the URL is: http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds 3 - Note the holds tab is not active 4. APPLY PATCH and restart all 5. Now after suspending a hold, the refreshed page should have an active hold tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:53:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:53:06 +0000 Subject: [Koha-bugs] [Bug 35492] Suspending/unsuspending a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35492 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 17:53:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 16:53:45 +0000 Subject: [Koha-bugs] [Bug 35488] Placing a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Placing a hold on the OPAC |Placing a hold on the OPAC |takes the user to their |takes the user to their |accont page, but does not |account page, but does not |activate the holds tab |activate the holds tab Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:06:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:06:22 +0000 Subject: [Koha-bugs] [Bug 35493] New: Housebound roles show as a collapsed field option when checked in CollapseFieldsPatronAddForm, even if housebound is off Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Bug ID: 35493 Summary: Housebound roles show as a collapsed field option when checked in CollapseFieldsPatronAddForm, even if housebound is off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1. HouseboundModule - disabled 2. CollapseFieldsPatronAddForm, add 'Housebound roles' 3. Edit/create a patron. 4. Notice the useless Housebound roles link at the top of the page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:06:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:06:29 +0000 Subject: [Koha-bugs] [Bug 35493] Housebound roles show as a collapsed field option when checked in CollapseFieldsPatronAddForm, even if housebound is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:11:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:11:26 +0000 Subject: [Koha-bugs] [Bug 35493] Housebound roles show as a collapsed field option when checked in CollapseFieldsPatronAddForm, even if housebound is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:11:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:11:28 +0000 Subject: [Koha-bugs] [Bug 35493] Housebound roles show as a collapsed field option when checked in CollapseFieldsPatronAddForm, even if housebound is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 --- Comment #1 from Lucas Gass --- Created attachment 159600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159600&action=edit Bug 35493: Do not show housebound roles as collapsible unless the housebound module is on To test: 1. HouseboundModule - disabled 2. CollapseFieldsPatronAddForm, add 'Housebound roles' 3. Edit/create a patron. 4. Notice the useless Housebound roles link at the top of the page 5. APPLY PATCH 6. Try 1 - 3 again, this time no Housebound roles at the top ( Show collapsed fields ) 7. Turn on HouseboundModule and make sure it now shows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:12:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:12:21 +0000 Subject: [Koha-bugs] [Bug 35487] Add a selective dissemination of information module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35487 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:17:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:17:10 +0000 Subject: [Koha-bugs] [Bug 35181] Can no longer edit sample records with advanced cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:19:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:19:24 +0000 Subject: [Koha-bugs] [Bug 35488] Placing a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:19:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:19:26 +0000 Subject: [Koha-bugs] [Bug 35488] Placing a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159596|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 159601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159601&action=edit Bug 35488: Open holds tab by default on opac-user.pl after placing a hold 1 - Place a hold on the opac 2 - Note after placing the hold the URL is: http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds 3 - Note the holds tab is not active 4 - APPLY PATCH and restart_all 5 - Try steps 1 - 3 again, this time the holds tab should be opened. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:21:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:21:04 +0000 Subject: [Koha-bugs] [Bug 35492] Suspending/unsuspending a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35492 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:21:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:21:06 +0000 Subject: [Koha-bugs] [Bug 35492] Suspending/unsuspending a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35492 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159599|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 159602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159602&action=edit Bug 35492: Open holds tab by default on opac-user.pl after suspending a hold To recreate: 1. Go to the opac-user.pl page for a user with some holds and suspend a hold. 2. Note after placing the hold the URL is: http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds 3 Note the holds tab is not active 4. APPLY PATCH and restart all 5. Now after suspending a hold, the refreshed page should have an active hold tab. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:38:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:38:31 +0000 Subject: [Koha-bugs] [Bug 35494] New: SQL auto-complete should not be triggered by closing a quotation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35494 Bug ID: 35494 Summary: SQL auto-complete should not be triggered by closing a quotation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: andrewfh at dubcolib.org QA Contact: testopia at bugs.koha-community.org Depends on: 32613 To recreate: - create a new report from SQL - Type 'test' (including the single quotation marks) - observe that the auto-complete popup appears when you type the closing quotation mark - type "test" and see it does the same with double quotation marks This is really unhelpful. If I'm quote-wrapping something, it's because it's a string rather than a field. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 [Bug 32613] Add auto-completion to our SQL reports editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:38:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:38:31 +0000 Subject: [Koha-bugs] [Bug 32613] Add auto-completion to our SQL reports editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35494 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35494 [Bug 35494] SQL auto-complete should not be triggered by closing a quotation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:38:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:38:56 +0000 Subject: [Koha-bugs] [Bug 35181] Can no longer edit sample records with advanced cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35181 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:46:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:46:39 +0000 Subject: [Koha-bugs] [Bug 35495] New: Cancelling a hold on the OPAC takes the user to their account page, but does not activate the holds tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35495 Bug ID: 35495 Summary: Cancelling a hold on the OPAC takes the user to their account page, but does not activate the holds tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Go to the opac-user.pl page for a user with some holds and cancel a hold. 2 - Note after placing the hold the URL is: http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds 3 - Note the holds tab is not active -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:46:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:46:53 +0000 Subject: [Koha-bugs] [Bug 35495] Cancelling a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35495 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35488 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 [Bug 35488] Placing a hold on the OPAC takes the user to their account page, but does not activate the holds tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:46:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:46:53 +0000 Subject: [Koha-bugs] [Bug 35488] Placing a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35495 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35495 [Bug 35495] Cancelling a hold on the OPAC takes the user to their account page, but does not activate the holds tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:47:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:47:07 +0000 Subject: [Koha-bugs] [Bug 35495] Cancelling a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35495 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com Severity|enhancement |normal Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:49:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:49:12 +0000 Subject: [Koha-bugs] [Bug 35495] Cancelling a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35495 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:49:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:49:14 +0000 Subject: [Koha-bugs] [Bug 35495] Cancelling a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35495 --- Comment #1 from Lucas Gass --- Created attachment 159603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159603&action=edit Bug 35495: Open holds tab by default on opac-user.pl after cancelling a hold To test: 1 - Go to the opac-user.pl page for a user with some holds and cancel a hold. 2 - Note after placing the hold the URL is: http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds 3 - Note the holds tab is not active 4. APPLY PATCH and restart all 5. Now after cancelling a hold, the refreshed page should have an active hold tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:54:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:54:54 +0000 Subject: [Koha-bugs] [Bug 35496] New: Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35496 Bug ID: 35496 Summary: Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Turn on ArticleRequests 1 - Place an Article Requests on the opac 2 - Note after placing the request the URL is: http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-article-requests 3 - Note the article request tab is not active -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:55:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:55:00 +0000 Subject: [Koha-bugs] [Bug 35496] Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35496 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35488 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 [Bug 35488] Placing a hold on the OPAC takes the user to their account page, but does not activate the holds tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 18:55:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 17:55:00 +0000 Subject: [Koha-bugs] [Bug 35488] Placing a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35488 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35496 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35496 [Bug 35496] Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 19:01:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 18:01:43 +0000 Subject: [Koha-bugs] [Bug 35491] Reverting waiting status for holds is not logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35491 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159595|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 159604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159604&action=edit Bug 35491: Add logging to RevertWaitingStatus This patch simply adds a logaction line to RevertWaitingStatus To test: 1 - Enable HoldsLog 2 - Place a hold 3 - Fill the hold 4 - Revert the waiting status 5 - Note there is no action log added 6 - Apply patch 7 - Repeat 2-4 8 - Confirm you now have a MODIFY action logged for the reversion Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 19:05:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 18:05:06 +0000 Subject: [Koha-bugs] [Bug 35491] Reverting waiting status for holds is not logged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35491 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 19:07:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 18:07:02 +0000 Subject: [Koha-bugs] [Bug 35496] Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35496 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 19:07:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 18:07:04 +0000 Subject: [Koha-bugs] [Bug 35496] Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35496 --- Comment #1 from Lucas Gass --- Created attachment 159605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159605&action=edit Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request To test: 1 - Turn on ArticleRequests 2 - Place an Article Requests on the opac 3 - Note after placing the request the URL is: http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-article-requests 4 - Note the article request tab is not active 5 - APPLY PATCH and restart_all 6. Try steps 2 - 4 again, this time the article request tab should be open by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 19:07:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 18:07:29 +0000 Subject: [Koha-bugs] [Bug 35496] Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35496 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 20:11:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 19:11:22 +0000 Subject: [Koha-bugs] [Bug 35497] New: Add a view of related import records to the details page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35497 Bug ID: 35497 Summary: Add a view of related import records to the details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Sometimes one is viewing a record in the staff interface, and would like to see when it was imported/overlaid - it would be nice to add a tab to view this information. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 20:13:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 19:13:46 +0000 Subject: [Koha-bugs] [Bug 35497] Add a view of related import records to the details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35497 --- Comment #1 from Nick Clemens --- Created attachment 159606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159606&action=edit Bug 35497: WIP This patch adds a new tab to the record details page called 'Imported records' This tab contains a table linking to the import batches for any imports or overlays of this biblio Some questions: 1 - Do we need a syspref for this? Or should it just be included? 2 - What info is useful? date/time of import? Import settings? A diff view? 3 - Other thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 20:14:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 19:14:21 +0000 Subject: [Koha-bugs] [Bug 35497] Add a view of related import records to the details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35497 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org, | |katrin.fischer at bsz-bw.de, | |kelly at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 20:23:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 19:23:18 +0000 Subject: [Koha-bugs] [Bug 35497] Add a view of related import records to the details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35497 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 20:34:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 19:34:52 +0000 Subject: [Koha-bugs] [Bug 35497] Add a view of related import records to the details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35497 --- Comment #2 from Kelly McElligott --- If not a syspref, a permission ?! Or both! I love this, import date/time, import file (batch id), and a diff view would be great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 20:38:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 19:38:43 +0000 Subject: [Koha-bugs] [Bug 35489] Holds on items with no barcode are missing an input for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 --- Comment #2 from ByWater Sandboxes --- Created attachment 159607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159607&action=edit Bug 35489: This page is a ingle form, all fields must have inputs to avoid data loss/mismatch To test: 1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without 2 - Place an item level hold on the item with no barcode 3 - Place another hold for a different patron on the item with a barcode 4 - From the holds table add an expiration date to the hold with a barcode and save 5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold 6 - Delete the holds 7 - Apply patch 8 - Repeat 2-4 9 - Confirm the itemnumbers for the holds have not changed Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 20:40:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 19:40:27 +0000 Subject: [Koha-bugs] [Bug 35489] Holds on items with no barcode are missing an input for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Fuerste-Henry --- The sandbox seems to have done something weird to the attachments on this bug, but it was my intent to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 20:54:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 19:54:50 +0000 Subject: [Koha-bugs] [Bug 35493] Housebound roles show as a collapsed field option when checked in CollapseFieldsPatronAddForm, even if housebound is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 20:54:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 19:54:53 +0000 Subject: [Koha-bugs] [Bug 35493] Housebound roles show as a collapsed field option when checked in CollapseFieldsPatronAddForm, even if housebound is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159600|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159608&action=edit Bug 35493: Do not show housebound roles as collapsible unless the housebound module is on To test: 1. HouseboundModule - disabled 2. CollapseFieldsPatronAddForm, add 'Housebound roles' 3. Edit/create a patron. 4. Notice the useless Housebound roles link at the top of the page 5. APPLY PATCH 6. Try 1 - 3 again, this time no Housebound roles at the top ( Show collapsed fields ) 7. Turn on HouseboundModule and make sure it now shows Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 21:01:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 20:01:33 +0000 Subject: [Koha-bugs] [Bug 35494] SQL auto-complete should not be triggered by closing a quotation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35494 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 21:11:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 20:11:40 +0000 Subject: [Koha-bugs] [Bug 35498] New: SQL auto-complete should not prevent use of tab for spacing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Bug ID: 35498 Summary: SQL auto-complete should not prevent use of tab for spacing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: andrewfh at dubcolib.org QA Contact: testopia at bugs.koha-community.org Depends on: 32613 With the new auto-complete feature for SQL, the tab key *always* opens the auto-complete suggestions popup, even when the cursor is at the start of a new line or immediately after a whitespace. This makes tab unusable for spacing/formatting, which is difficult functionality to use. In a code editor, I expect tab to auto-complete if I've started a word/string, but to insert a whitespace if I'm at the start of a line or otherwise between words. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 [Bug 32613] Add auto-completion to our SQL reports editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 21:11:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 20:11:40 +0000 Subject: [Koha-bugs] [Bug 32613] Add auto-completion to our SQL reports editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35498 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 [Bug 35498] SQL auto-complete should not prevent use of tab for spacing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 21:18:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 20:18:23 +0000 Subject: [Koha-bugs] [Bug 35493] Housebound roles show as a collapsed field option when checked in CollapseFieldsPatronAddForm, even if housebound is off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35493 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- I've signed off, as it does what it says in the test plan. Should the rules be in the system preference? That is: if an option for CollapseFieldsPatronAddForm is "not valid", for example like housebound roles that requires HouseboundModule, then it is greyed out/not able to be selected? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 21:25:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 20:25:00 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 --- Comment #5 from Katrin Fischer --- Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 21:45:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 20:45:07 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 21:50:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 20:50:24 +0000 Subject: [Koha-bugs] [Bug 35485] Error staging authority MARC record if a match is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35485 --- Comment #2 from Katrin Fischer --- Hi Aleisha, could this be bug 26611? Fixed in Backported to 22.05.x for upcoming 22.05.17 release. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 21:51:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 20:51:05 +0000 Subject: [Koha-bugs] [Bug 35485] Error staging authority MARC record if a match is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35485 --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #2) > Hi Aleisha, could this be bug 26611? Fixed in Backported to 22.05.x for > upcoming 22.05.17 release. ... no longer upcoming of course, I just copied the note from the other bug :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 21:54:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 20:54:20 +0000 Subject: [Koha-bugs] [Bug 16959] E-mail alerts for saved searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16959 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 35487 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 21:54:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 20:54:20 +0000 Subject: [Koha-bugs] [Bug 35487] Add a selective dissemination of information module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35487 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- *** Bug 16959 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 21:56:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 20:56:41 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #1 from Katrin Fischer --- Hm, I don't think the tab ever worked there for adding whitespace/tab, so maybe not a regression and tab for auto-complete seems common? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 22:01:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 21:01:19 +0000 Subject: [Koha-bugs] [Bug 35494] SQL auto-complete should not be triggered by closing a quotation or parentheses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35494 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SQL auto-complete should |SQL auto-complete should |not be triggered by closing |not be triggered by closing |a quotation |a quotation or parentheses --- Comment #1 from Andrew Fuerste-Henry --- Update to add that is also pops up the autocomplete when closing a parentheses, and that's possibly even less helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 22:05:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 21:05:37 +0000 Subject: [Koha-bugs] [Bug 29291] Self Registration e-mail verification is not stored in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29291 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |INVALID --- Comment #6 from Katrin Fischer --- Thanks David, that's what I was trying to say. The account doesn't exist yet, so we cannot show it in the notice tab. It's still in the message_queue table but with borrowernumber NULL. We do have a record of the attempt. I just verified this in a 22.11 installation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 22:09:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 21:09:22 +0000 Subject: [Koha-bugs] [Bug 35473] Core bookings and room reservations plugin tables clash In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35473 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 22:11:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 21:11:51 +0000 Subject: [Koha-bugs] [Bug 35499] New: Lost item blocked at checkin still logs a return in action logs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35499 Bug ID: 35499 Summary: Lost item blocked at checkin still logs a return in action logs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I found this while investigating something for a client and noticed that in the patron's modification log, an item was checked out once and checked in twice. It seems if you try to check in a lost item and BlockReturnOfLostItems is set to block, an action_log of the return is still logged (with nothing different from a log of a real checkin). I don't know if this is normal, but it doesn't feel normal. To recreate: 1. Make sure BlockReturnOfLostItems is set to Block 2. Make sure MarkLostItemsAsReturned is set to nothing (or at least not From the items tab of the catalog module) 3. Make sure ReturnLog is set to Log 4. Check out an item to a patron 5. In the list of checkouts, click the barcode and set the status to Lost 6. Try to check in the item --> should be blocked and say Item is lost, cannot be checked in. ; Cannot check in ; NOT CHECKED IN 7. Go to the patron's file and click the Modification log button --> Note that there is a line for the return of the item 8. Go back to the item and change the status back to not lost 9. Check in the item again --> Should check in normally 10. Go to the patron's file > Modification log --> Note that there is a new line for the return of the item; both lines are identical, there is nothing that indicates one return was not successful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 22:25:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 21:25:28 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #2 from Andrew Fuerste-Henry --- I'm deeply accustomed to tab-indenting new lines when writing reports in Koha and am certain this is a change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 22:28:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 21:28:36 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #3 from Katrin Fischer --- (In reply to Andrew Fuerste-Henry from comment #2) > I'm deeply accustomed to tab-indenting new lines when writing reports in > Koha and am certain this is a change. Hm OK, I might have never tried, but seem to remember getting annoyed by it not working in the system preferences (*UserJS etc). Maybe some changes happened over time. Usually a normal HTML input field doesn't allow it (like here in bugzilla), as the tab is used in form fields to jump to the next field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 23:08:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 22:08:53 +0000 Subject: [Koha-bugs] [Bug 35500] New: Remove Summary and Matrix options in the guided reports wizard Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35500 Bug ID: 35500 Summary: Remove Summary and Matrix options in the guided reports wizard Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org In Step 2 of the guided reports wizard, there is a drop-down menu with three options, Tabular, Summary and Matrix, but only one option, Tabular, is available. We should remove the two other options, Summary and Matrix, and remove that step, since there is nothing the user can do here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 23:15:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 22:15:33 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #37 from David Cook --- (In reply to Lucas Gass from comment #36) > > This permission is only there to allow search and list view of members, no > > access to the details of each member (moremember.pl) and therefore in my > > opinion no update... I've missed something else, or perhaps I'm > > misunderstanding you. > > If staff can see/view borrower information before the patchset they need to > have the same behavior after the patchset. I agree with Lucas. Another way to think of it is as "view" rather than "list". The user could just visit http://localhost:8081/api/v1/patrons?_page=1&_per_page=100 and see all the details, so it doesn't really make sense to stop them from seeing the moremember.pl page. (We just need to make sure someone with list_borrowers only can't add/update borrowers. They're fine to view them.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 23:29:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 22:29:29 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- I can confirm Andrew's report, and I agree that it is frustrating. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 23:29:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 22:29:49 +0000 Subject: [Koha-bugs] [Bug 32613] Add auto-completion to our SQL reports editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #23 from David Cook --- Unfortunately, it looks like this broke the indentWithTabs option as noted in bug 35498 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 23:30:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 22:30:15 +0000 Subject: [Koha-bugs] [Bug 35485] Error staging authority MARC record if a match is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35485 --- Comment #4 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #2) > Hi Aleisha, could this be bug 26611? Fixed in Backported to 22.05.x for > upcoming 22.05.17 release. Thanks Katrin but unfortunately I don't think it is. I get this error in all versions, including upstream/master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 23:34:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 22:34:57 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #5 from David Cook --- I notice that the "tab" is in a list of exclusions in guided_reports_start.tt at https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=32613&attachment=147715 However, it looks like it is triggering the autocomplete anyway. I imagine PTFS-Europe as the folk who introduced the change might have an idea on how to fix it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 23:41:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 22:41:11 +0000 Subject: [Koha-bugs] [Bug 35487] Add a selective dissemination of information module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35487 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- I have a local implementation of bug 16959 that I wrote many years ago, but it would need a bit of work to be ready for upstream I think. Basically, users could save searches as "Reading interests", and then a cronjob would periodically check for new records that match their reading interests, and would email out personalised emails. (In reply to verolencinas from comment #0) > Librarians should be able to control the lists sent to the users. That could > be implemented for example with a delay in sending during which librarians > could alter the list, or more simple through a access to sent lists where > librarians can control which records has been sent. This is very different to sending out emails based on save searches. It sounds to me like 2 different features. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 23:46:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 22:46:01 +0000 Subject: [Koha-bugs] [Bug 29291] Self Registration e-mail verification is not stored in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29291 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #7 from Christopher Brannon --- Okay, I think I understand now. Until they verify, the account isn't created? So, forgive me for not walking through the process. Are they asked to create a login before they provide all the information and email address? If not, where is all their information stored until the email address is validated? I'm just trying to understand which comes first, email validation, or the storage of their self registration information. And maybe this needs to morph into a different subject/title, but what if an email address is changed or added later, either by staff or patron. It seems that right now the only validation happening is at registration, but no other time. It seems that we need to work towards adding this notification to notices.pl, if not for this specific instance, but for the possibility of validating addresses at some other point. I know. I am putting the cart before the horse here. But back to my question. Is there no patron info stored before the validation email goes out? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 23:50:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 22:50:27 +0000 Subject: [Koha-bugs] [Bug 34077] writeoff_debts without --confirm doesn't show which accountline records it would have been written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34077 --- Comment #6 from David Nind --- I'm now getting an error when I confirm. Am I testing this correctly? ./misc/cronjobs/writeoff_debts.pl --added_after 2023-12-04 --category-code PT --confirm DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data truncated for column 'type' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data truncated for column 'type' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170 or ./misc/cronjobs/writeoff_debts.pl --added_after 2023-12-04 --confirm DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data truncated for column 'type' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data truncated for column 'type' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170 This is the test plan I used: 1. Add two fees in a patron account (I used Mary Burton, borrower number = 49): 1.1. Go into a patron record > Accounting tab 1.2. Go to the Create a manual invoice tab 1.3. Fill out the form (use manual fee) 1.4. Click 'Save' 1.5. Redo steps 1.2 to 1.4 to add a second fee 2. Manually change the date for one transaction in the database: 2.1. There should be two transactions in the accountlines and account_offsets tables (koha-mysql kohadev + select * from accountlines; + select * from account_offsets;) 2.2. Update the date for one of the fees using the accountlines_id: update accountlines set date = '2023-06-01 09:34:05' where accountlines_id = 1; update account_offsets set created_on = '2023-06-01 09:34:05' where debit_id = '1'; => If you look at the patron record in the staff interface, you should now have two fees with different date: one fee on 1 June 2023 and one with today's date (the account_offset is also modified - not sure if that last part is necessary). 3. Run writeoff_debts.pl with various options to make sure it works as expected (to use --added_after, the date should be after the first fee but before the second): 3.1. Without any options it should return the help: ./misc/cronjobs/writeoff_debts.pl 3.2. Without --confirm and one option it should show what it would change: ./misc/cronjobs/writeoff_debts.pl --added_after 2023-12-04 ==> With --confirm we would write off 1 debts added after 2023-12-04 Accountline 2 will be written of 3.3. Without --confirm and with two or more options - it should show what it would change: ./misc/cronjobs/writeoff_debts.pl --added-after 2023-06-20 --category-code PT ==> With --confirm we would write off 1 debts of type MANUAL added after 2023-06-20 Accountline 2 will be written off 3.4. With --confirm it should correctly write off one amount: ./misc/cronjobs/writeoff_debts.pl --added_after 2023-12-04 --confirm 4. Check the patron record ==> The fee with the date after should be written off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 23:52:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 22:52:29 +0000 Subject: [Koha-bugs] [Bug 29291] Self Registration e-mail verification is not stored in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29291 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |INVALID --- Comment #8 from Katrin Fischer --- (In reply to Christopher Brannon from comment #7) > Okay, I think I understand now. Until they verify, the account isn't > created? So, forgive me for not walking through the process. Are they > asked to create a login before they provide all the information and email > address? If not, where is all their information stored until the email > address is validated? I'm just trying to understand which comes first, > email validation, or the storage of their self registration information. The data is stored in borrower_modifications. They provide an email address when registering, it's mandatory when using email verification and is used to send the email. They don't need to create a login right away, they will be able to enter a password after clicking on the verification link in the email, at which time the account is created and the data moved to borrowers. > And maybe this needs to morph into a different subject/title, but what if an > email address is changed or added later, either by staff or patron. It > seems that right now the only validation happening is at registration, but > no other time. It seems that we need to work towards adding this > notification to notices.pl, if not for this specific instance, but for the > possibility of validating addresses at some other point. I know. I am > putting the cart before the horse here. > > But back to my question. Is there no patron info stored before the > validation email goes out? See above. Everything they enter in the self registration form is stored, but in borrower_modifications. There is a cronjob option to delete data of unverified registrations to clean that up regularly. There are already other bugs for email/patron verification. Bug 33633 - Check if email exists Bug 26166 - Patron verification through SMS one time code Bug 32136 - E-mail testing Bug 23908 - Require patrons to confirm their email address Can we now keep this one closed? ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 5 23:55:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 22:55:49 +0000 Subject: [Koha-bugs] [Bug 35497] Add a view of related import records to the details page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35497 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- It's an interesting idea. The import_* tables are not necessarily permanent, but it looks like cleanup_database.pl doesn't clean them up in the out of the box crontab, so most libraries probably do persist that data... Rather than having it on the detail page, it might make more sense to add it on the sidebar with a label like "Import history". That way, it doesn't actually affect the detail.pl page at all, and people can opt-in to that information. As a result, I don't think we'd need a syspref for it. If people don't want it, they just don't click on it, and then nothing is different. And for people who do want it, they can just choose it from that list of sidebar items which is fairly short at the moment. Just my 2 cents :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 00:06:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 23:06:01 +0000 Subject: [Koha-bugs] [Bug 29291] Self Registration e-mail verification is not stored in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29291 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #9 from Christopher Brannon --- Well, you keep closing it, and I would like to keep it open for discussion, but I'm not given that option when you close it. I think this is something we should work on. I don't think this notification has to slip through the cracks in the process. It seems to me, if this information is kept in borrower_modifications, we could find some way of tying the email to this information. Regardless of whether the email serves a functional purpose in notices.pl, it serves us to keep a record of communications. Having this piece slip through the cracks because the account can't be created until they respond is not enough of a reason to not keep record of it where staff can see it. I know, it isn't crucial, but it would be more thorough to put this in the notices.pl after the account is validated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 00:06:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 23:06:10 +0000 Subject: [Koha-bugs] [Bug 29291] Self Registration e-mail verification is not stored in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29291 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 00:34:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 23:34:35 +0000 Subject: [Koha-bugs] [Bug 35495] Cancelling a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35495 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 00:34:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 23:34:37 +0000 Subject: [Koha-bugs] [Bug 35495] Cancelling a hold on the OPAC takes the user to their account page, but does not activate the holds tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35495 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159603|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159609&action=edit Bug 35495: Open holds tab by default on opac-user.pl after cancelling a hold To test: 1 - Go to the opac-user.pl page for a user with some holds and cancel a hold. 2 - Note after placing the hold the URL is: http://localhost:8080/cgi-bin/koha/opac-user.pl?#opac-user-holds 3 - Note the holds tab is not active 4. APPLY PATCH and restart all 5. Now after cancelling a hold, the refreshed page should have an active hold tab. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 00:40:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 23:40:17 +0000 Subject: [Koha-bugs] [Bug 35496] Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35496 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 00:40:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 23:40:20 +0000 Subject: [Koha-bugs] [Bug 35496] Placing an article request on the OPAC takes the user to their account page, but does not activate the article request tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35496 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159605|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159610&action=edit Bug 35496: Open article requests tab by default on opac-user.pl after placing an article request To test: 1 - Turn on ArticleRequests 2 - Place an Article Requests on the opac 3 - Note after placing the request the URL is: http://localhost:8080/cgi-bin/koha/opac-user.pl#opac-user-article-requests 4 - Note the article request tab is not active 5 - APPLY PATCH and restart_all 6. Try steps 2 - 4 again, this time the article request tab should be open by default. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 00:45:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Dec 2023 23:45:39 +0000 Subject: [Koha-bugs] [Bug 29291] Link self registration verification email to patron account after verification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29291 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Self Registration e-mail |Link self registration |verification is not stored |verification email to |in notices |patron account after | |verification --- Comment #10 from Katrin Fischer --- I changed the bug description. I think at the moment we don't have good enough information to reliably link. Maybe keeping the letter_id in borrower_modifications could be a way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 05:18:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 04:18:27 +0000 Subject: [Koha-bugs] [Bug 35485] Error staging authority MARC record if a match is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35485 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #5 from Aleisha Amohia --- I'm not sure what I did differently but tested it again today and seems to work on upstream. *** This bug has been marked as a duplicate of bug 26611 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 05:18:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 04:18:27 +0000 Subject: [Koha-bugs] [Bug 26611] Required match checks don't work for authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26611 --- Comment #13 from Aleisha Amohia --- *** Bug 35485 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 08:11:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 07:11:39 +0000 Subject: [Koha-bugs] [Bug 29816] Document patron emailer cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29816 --- Comment #3 from Ray Delahunty --- Apologies- on 22.11 I have notices being sent by the patron_emailer.pl script working perfectly with html, and the fields pulled in from the report must use TT notation so html and at least some TT is supported. All I can assume from earlier failures (ages back) must be down to specific objects/ variables that either aren’t fully supported (or more likely!) I had syntax errors in my TT code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 08:13:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 07:13:00 +0000 Subject: [Koha-bugs] [Bug 27443] Add an item loop mechanism to patron_emailer.pl cron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27443 --- Comment #8 from Ray Delahunty --- Apologies- on 22.11 I have notices being sent by the patron_emailer.pl script working perfectly with html, and the fields pulled in from the report must use TT notation so html and at least some TT is supported. All I can assume from earlier failures (ages back) must be down to specific objects/ variables that either aren’t fully supported (or more likely!) I had syntax errors in my TT code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 08:28:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 07:28:39 +0000 Subject: [Koha-bugs] [Bug 34423] (proof-of-concept) Bugzilla could look better with a new skin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34423 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 09:00:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 08:00:04 +0000 Subject: [Koha-bugs] [Bug 35462] "savepoint_0 does not exist" when saving patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35462 --- Comment #4 from Magnus Enger --- We moved the site to a new server (but not the database, which is on a separate/dedicated server), but the problem remains, with the exact same error in the logs that I reported initially. The versions are now: - Koha 22.11.12-1 - Database: 10.3.38-MariaDB-0ubuntu0.20.04.1-log - Ubuntu 22.04.3 LTS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 09:21:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 08:21:29 +0000 Subject: [Koha-bugs] [Bug 35462] "savepoint_0 does not exist" when saving patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35462 --- Comment #5 from Jonathan Druart --- Do you have plugins installed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 09:33:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 08:33:18 +0000 Subject: [Koha-bugs] [Bug 35462] "savepoint_0 does not exist" when saving patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35462 --- Comment #6 from Magnus Enger --- (In reply to Jonathan Druart from comment #5) > Do you have plugins installed? No plugins installed, and plugins are not enabled: 0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 09:54:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 08:54:14 +0000 Subject: [Koha-bugs] [Bug 35462] "savepoint_0 does not exist" when saving patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35462 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #7 from Magnus Enger --- Looks like we were running this site with ProxySQL and that was causing the problems. Sorry for the noise, but maybe this bug can serve as a pointer for someone else in the future. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 10:21:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 09:21:03 +0000 Subject: [Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com --- Comment #17 from Jonathan Druart --- I don't understand the original problem. This implementation seems more confusing to me. There is an info at the top of the page: "Patrons selected: 2" Here you are adding not-related checkboxes all around. You are also changing the existing behaviour: prior to this patch you didn't have to do anything to keep the selection, now you need to tick the box. I would like to collect more feedbacks on what you suggest with this approach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 10:33:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 09:33:15 +0000 Subject: [Koha-bugs] [Bug 35501] New: Make koha-restore restore only files, not db Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35501 Bug ID: 35501 Summary: Make koha-restore restore only files, not db Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Use case: We have Koha instances on a number of different virtual servers, and databases on separate/dedicated servers. Sometimes we need to move an instance from one server to another, without doing anything about the database. It would be nice if we could copy a .tar.gz backupfile from the old server to the new server, and recreate the site on the new server with something like: sudo koha-restore --onlyfiles mykoha-.tar.gz This is the opposite of bug 34777. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 10:35:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 09:35:05 +0000 Subject: [Koha-bugs] [Bug 35502] New: [Omnibus] Rewrite koha-restore Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35502 Bug ID: 35502 Summary: [Omnibus] Rewrite koha-restore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Looks like there are several wishes to enhance koha-restore, with functionality like only restoring the DB or only restoring files. This omnibus bug tries to collect the active bugs related to this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 10:35:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 09:35:22 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 10:35:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 09:35:25 +0000 Subject: [Koha-bugs] [Bug 35477] Adding non-existent items to the waiting list should display a warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35477 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159580|0 |1 is obsolete| | --- Comment #6 from Matt Blenkinsop --- Created attachment 159611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159611&action=edit Bug 35477: Show a warning when non-existent items are added to the waiting list Only messages "X new items added" or "No items added" were displayed. With this patch we will display: A warning with "No items added" A warning with "X new items added. Y items not found." when some items have not been added A messages "X new items added" when everything went well Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 10:37:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 09:37:26 +0000 Subject: [Koha-bugs] [Bug 21769] koha-restore file-exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21769 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #3 from Magnus Enger --- No activity here for a long time. Is this still a problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 10:40:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 09:40:00 +0000 Subject: [Koha-bugs] [Bug 35502] [Omnibus] Rewrite koha-restore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35502 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34777, 35501, 15664, 4875 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4875 [Bug 4875] koha-remove, koha-restore should have options similar to --request-db https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15664 [Bug 15664] koha-restore: Allow database dump to be restored to another Koha instance https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34777 [Bug 34777] koha-restore could use a db-only option https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35501 [Bug 35501] Make koha-restore restore only files, not db -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 10:40:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 09:40:00 +0000 Subject: [Koha-bugs] [Bug 4875] koha-remove, koha-restore should have options similar to --request-db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4875 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35502 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35502 [Bug 35502] [Omnibus] Rewrite koha-restore -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 10:40:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 09:40:00 +0000 Subject: [Koha-bugs] [Bug 15664] koha-restore: Allow database dump to be restored to another Koha instance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15664 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35502 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35502 [Bug 35502] [Omnibus] Rewrite koha-restore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 10:40:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 09:40:00 +0000 Subject: [Koha-bugs] [Bug 34777] koha-restore could use a db-only option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34777 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35502 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35502 [Bug 35502] [Omnibus] Rewrite koha-restore -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 10:40:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 09:40:00 +0000 Subject: [Koha-bugs] [Bug 35501] Make koha-restore restore only files, not db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35501 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35502 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35502 [Bug 35502] [Omnibus] Rewrite koha-restore -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 10:45:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 09:45:41 +0000 Subject: [Koha-bugs] [Bug 35501] Make koha-restore restore only files, not db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35501 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34777 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 10:45:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 09:45:41 +0000 Subject: [Koha-bugs] [Bug 34777] koha-restore could use a db-only option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34777 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35501 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 11:07:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 10:07:56 +0000 Subject: [Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 11:07:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 10:07:58 +0000 Subject: [Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204 --- Comment #1 from Matt Blenkinsop --- Created attachment 159612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159612&action=edit Bug 35204: Prevent an expired password from throwing a 500 error Currently when a patron with an expired password is authenticated via the API a 500 error is returned rather than a 400 "Validation failed" error. This patch catches the return value for an expired password and returns the validation failure before the patron search is attempted. Test plan: 1) Choose a patron and set their password expiry date to a date in the past 2) Send a request to auth/password/validation with that patron's details 3) The response should be a 500 error 4) Apply patch 5) Repeat steps 1-3 and this time the response should be a 400 code with an error message of "Validation failed" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 11:08:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 10:08:14 +0000 Subject: [Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |matt.blenkinsop at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 11:11:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 10:11:02 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 11:11:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 10:11:06 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159427|0 |1 is obsolete| | Attachment #159517|0 |1 is obsolete| | --- Comment #38 from Thibaud Guillot --- Created attachment 159613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159613&action=edit Bug 30230: Add new 'list_borrowers' permission When a patron search is performed only a user with edit_borrowers permission can search by name. Search can works only with cardnumber but it makes searching less intuitive I think. So, as mentioned in the discussion, I've added a new 'list_borrowers' permission, completely independent of 'edit_borrowers', so that I can search for a member via the interface and get the results. In addition to the permission to perform check in and checkouts, this no longer poses an obstacle to simple use. Test plan: 1) Check with a user without 'edit_borrowers' permission that the patron search can only be performed with cardnumber 2) Apply this patch 3) Make the updatedatabase to add new 'list_borrowers' permissions 4) Set 'list_borrowers' permission on one user and see the difference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 11:18:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 10:18:31 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #39 from Thibaud Guillot --- Hello, I've added the 'list_borrowers' permission on moremember.pl, as it seemed more logical, I had included it initially but removed it later. A member with only the list_borrowers permission won't be able to add or modify an existing pattern, but will be able to view its information. What I didn't understand was the need to create an atomicupdate to add the list_borrowers permission to members with the 'edit_borrowers' permission (comment 32). I hope I've understood you correctly this time :) thanks in any case for your feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 11:19:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 10:19:43 +0000 Subject: [Koha-bugs] [Bug 25015] Staff with Edit Items permission Currently Can Not Edit Items attached to a Fast Add Framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Chris Rowlands changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.rowlands6 at nhs.net --- Comment #3 from Chris Rowlands --- This has cropped up for us recently as well. I think our libraries were also expecting that edit_items wouldn't be blocked by an unchecked fast_cataloguing permission. However, you can still edit these blocked items if you use the batch modification feature on the record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 11:22:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 10:22:16 +0000 Subject: [Koha-bugs] [Bug 35503] New: Increase 'status' column size in bugslist Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35503 Bug ID: 35503 Summary: Increase 'status' column size in bugslist Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.druart+koha at gmail.com Reporter: martin.renvoize at ptfs-europe.com The status column is very narrow and some of our status's start with the same 4 characters which makes it hard to distinguish between them in search results. Could we extend the column width. Reported by Aude and Caroline recently, but also spoken about on IRC a few times -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 11:27:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 10:27:57 +0000 Subject: [Koha-bugs] [Bug 35503] Increase 'status' column size in bugslist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35503 --- Comment #1 from Martin Renvoize --- Created attachment 159614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159614&action=edit Expand width Not tested yet as I don't have a bugzilla installed yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 11:41:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 10:41:52 +0000 Subject: [Koha-bugs] [Bug 35503] Increase 'status' column size in bugslist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35503 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 12:04:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 11:04:10 +0000 Subject: [Koha-bugs] [Bug 35503] Increase 'status' column size in bugslist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35503 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 12:53:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 11:53:23 +0000 Subject: [Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #21 from Martin Renvoize --- Created attachment 159615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159615&action=edit Bug 35104: [Alternative] Throw exception on store of invalid marcxml This patch adds an exception into ModBilioMarc to prevent erronious marcxml being stored into the database. We also remove the cleanup of such characters from TransformHtmlToMarc as introduced by bug 34549. This should result in there being no way, outside of direct database manipulation, of getting forbidden characters into our marcxml store. We'll need to work through the codebase to catch the exception thrown to give the end user the oportunities to act on the error and fix the data at source. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 12:54:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 11:54:57 +0000 Subject: [Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #22 from Martin Renvoize --- I think we could perhaps go a level lower and put this exception into Koha::Biblio::Metadata->store maybe instead? We'll also need to account for the exception at various places with a try/catch block as detailed in the commit message.. but I wanted to start getting feedback on the proposed approach before committing to continuing down this path. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 13:12:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 12:12:03 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 --- Comment #13 from Marcel de Rooy --- (In reply to Matt Blenkinsop from comment #12) > I've taken your test patch Marcel and made some changes so that it now only > uses flatpickr rather than adding additional hidden inputs to hold the value. > > This feels like a major bug so I think we should get a fix in place for this > ASAP. Let me know what you think and if you agree with the concept I will > address some of the other issues you spotted in follow-up bugs (e.g. > incorrect column indexes etc). Okay. Will have a look later this week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 14:10:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 13:10:51 +0000 Subject: [Koha-bugs] [Bug 35154] Convert StaffLoginInstructions system preference to additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 14:10:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 13:10:54 +0000 Subject: [Koha-bugs] [Bug 35154] Convert StaffLoginInstructions system preference to additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159178|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159616&action=edit Bug 35154: Convert StaffLoginInstructions system preference to additional contents This patch moves the StaffLoginInstructions system preference into HTML customizations, making it possible to have language-specific content. To test you should have some content in the StaffLoginInstructions system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from StaffLoginInstructions is now stored there. - The HTML customization entry form should offer StaffLoginInstructions as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the StaffLoginInstructions HTML customization and add unique content to the "fr-FR" tab. - View the staff interface login page. You should see the content you added to the StaffLoginInstructions HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "StaffLoginInstructions." It should return no results. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 14:23:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 13:23:39 +0000 Subject: [Koha-bugs] [Bug 35154] Convert StaffLoginInstructions system preference to additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35154 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Testing notes (using KTD): 1. Something I noticed before applying the patch (so not related to this bug), is that bullet points don't display correctly on the login screen if you have these in StaffLoginInstructions. But unordered lists do. This is the same after the change in this bug. 2. Translations since 23.11 (after .po files now in separate l10n repository) - quick instructions for KTD: . Before starting up KTD, cd misc/translator/po: . git checkout master . git reset --hard origin/master . git pull . When in KTD, after it has started successfully (used es-ES here): . gulp po:update --lang es-ES . Install language: koha-translate --install es-ES --dev kohadev . To reset everything: . your koha clone - as normal: git checkout master, git branch -D bzXXXXX, git reset --hard origin/master . the l10n repository (change to misc/translator/po): . git checkout master (you should already be on master for the l10n repository, so normally not necessary) . git status (check that there are no stray files or directories, remove them if required) . git reset --hard origin/master . Remove the installed language: koha-translate --remove es-ES --dev kohadev . reset_all -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 14:25:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 13:25:04 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 14:25:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 13:25:07 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 --- Comment #14 from Kevin Carnes --- Created attachment 159617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159617&action=edit Bug 32392: Fix QA issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 14:26:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 13:26:01 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Kevin Carnes changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |kevin.carnes at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 14:37:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 13:37:20 +0000 Subject: [Koha-bugs] [Bug 6428] refered column 'items.coded_location_qualifier' does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6428 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- --- Comment #40 from Marcel de Rooy --- I just stumble over this report anno 2023. I noticed in my data (empty) occurrences of $f in more_subfields_xml. And surprisingly, there is no mapping in my data from $f to items.coded_location_qualifier. So this leaves a theoretical issue: AFAICS the patches here did not check if there was a Koha to MARC mapping when adding the item field but assumed that it was there? Hence possible data in the xml field was lost when no mapping existed. But yes, if you do not use the field, no problem :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 14:37:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 13:37:21 +0000 Subject: [Koha-bugs] [Bug 35486] When editing an authority show all subfields of the heading field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35486 --- Comment #3 from Owen Leonard --- Is this a functional gap in the options we have for editing authority frameworks? Shouldn't we enable the option of making subfields visible or not in authority frameworks instead of hard-coding the choice? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 14:50:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 13:50:30 +0000 Subject: [Koha-bugs] [Bug 35504] New: Release team 24.05 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Bug ID: 35504 Summary: Release team 24.05 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: RM_priority Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 14:53:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 13:53:15 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 15:05:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 14:05:00 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159617|0 |1 is obsolete| | --- Comment #15 from PTFS Europe Sandboxes --- Created attachment 159618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159618&action=edit Bug 32392: Fix QA issues Signed-off-by: Stina -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 15:06:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 14:06:17 +0000 Subject: [Koha-bugs] [Bug 32392] Ability to skip forward serial issues when receiving double (or more) issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32392 Stina Hallin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stina.hallin at ub.lu.se Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 15:30:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 14:30:38 +0000 Subject: [Koha-bugs] [Bug 35505] New: Add specific selectors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35505 Bug ID: 35505 Summary: Add specific selectors Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart+koha at gmail.com Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org For bug 34076 we need specific selectors on elements we want to screenshot. More precise selectors will certainly help other use cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 15:30:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 14:30:38 +0000 Subject: [Koha-bugs] [Bug 34076] [ALTERNATE] [DOCS] Automated screenshots using Cypress.io testing framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34076 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35505 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 15:33:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 14:33:06 +0000 Subject: [Koha-bugs] [Bug 35505] Add specific selectors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35505 --- Comment #1 from Jonathan Druart --- Created attachment 159619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159619&action=edit Bug 35505: Add id to fieldsets on acqui/supplier.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:01:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:01:57 +0000 Subject: [Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159615|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 159620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159620&action=edit Bug 35104: [Alternative] Throw exception on store of invalid marcxml This patch adds an exception Koha::Biblio::Metadata->store to prevent erroneous characters in marcxml being stored into the database. We also remove the cleanup of such characters from TransformHtmlToMarc as introduced by bug 34549. This should result in there being no way, outside of direct database manipulation, of getting forbidden characters into our marcxml store. We'll need to work through the codebase to catch the exception thrown to give the end user the oportunities to act on the error and fix the data at source. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:02:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:02:00 +0000 Subject: [Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #24 from Martin Renvoize --- Created attachment 159621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159621&action=edit Bug 35104: Initial attempt at catching the failure on new records Whilst I can see the warning output from store, I can't seem to actually catch any exceptions.. confused -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:17:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:17:41 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:17:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:17:44 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #6 from Matt Blenkinsop --- Created attachment 159622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159622&action=edit Bug 35498: Allow tab to indent lines and trigger autocomplete This patch allows the tab key to indent lines as well as trigger autocomplete. Test plan: 1) Apply patch, navigate to reports and create a new SQL report 2) Click in the text editor and press tab, it should indent and then trigger the autocomplete options 3) Type something to select from the autocomplete box and press tab - it should autocomplete that option 4) Type any word and then press space. Now press tab and it should indent again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:17:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:17:59 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop at ptfs-europe | |.com Assignee|koha-bugs at lists.koha-commun |matt.blenkinsop at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:29:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:29:08 +0000 Subject: [Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 --- Comment #18 from Emily Lamancusa --- The main problem is that adding the "saved patron" functionality was a behavior change in the first place, and if staff aren't aware of it or forget to pay attention to the "patrons selected" box, it can lead to data loss. Most notably, if a staff member merges Patron A and Patron B (we'll call the resulting account Patron AB), the merged patron remains selected. If they don't remember or realize they need to clear selected patrons before trying to do a separate merge of Patron C and Patron D, then Koha will merge Patron AB, C, and D all together, and Patron AB will be lost, with no good way to undo the action. The consequences to accidentally keeping an "old" selected patron when adding to a list or doing a batch modification are less permanent, but they will still lead to data errors that are likely to go unnoticed. In our library system, staff have also reported confusion about going to the patron page and finding that there are already "mysteriously" selected patrons. (Presumably, those patrons are still saved from an earlier action.) This means that even if a staff member is conscientious about clearing selected patrons in between actions, they might still have a leftover selected patron on their "first" action when they're not expecting to have one, and therefore are less likely to notice it. I think it's pretty reasonable to ask a staff member to actively confirm whether they still want to keep their selected patrons after performing an action on them. I imagine it's more common to perform one action on a patron set and then move on, rather than perform an additional, separate batch action on the exact same set. More importantly, it's safer to assume the staff member is finished with their selected patrons after performing an action, unless specified otherwise: -> If a staff member accidentally fails to keep their selected patrons, it may cause them a bit more work re-selecting the patrons, but their attempted action will fail and they will be able to correct the issue right away. ->If a staff member accidentally keeps their selected patrons when they don't intend to, their attempted action will succeed with unintended side effects that may go unnoticed and may not be easy to correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:36:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:36:01 +0000 Subject: [Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 --- Comment #19 from Michael Adamyk --- Emily, that's a fantastic explanation! I agree; the drawbacks of not keeping patrons selected is occasional inconvenience, while the current behavior can potentially cause major problems, as Emily noted. This is made worse because the selected patron doesn't ever "expire," so someone could be interrupted and do something else for an hour, return to the computer, and do another process without remembering that they still have patrons selected from their previous process. Again, potentially causing data loss. In my opinion, it's not very intuitive that selections are saved between processes. It perplexed me when I first noticed it, and I thought it was a problem, not a feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:36:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:36:13 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Matt Blenkinsop changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159622|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop --- Created attachment 159623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159623&action=edit Bug 35498: Allow tab to indent lines and trigger autocomplete This patch allows the tab key to indent lines as well as trigger autocomplete. Test plan: 1) Apply patch, navigate to reports and create a new SQL report 2) Click in the text editor and press tab, it should indent and then trigger the autocomplete options 3) Type something to select from the autocomplete box and press tab - it should autocomplete that option 4) Type any word and then press space. Now press tab and it should indent again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:46:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:46:56 +0000 Subject: [Koha-bugs] [Bug 29291] Link self registration verification email to patron account after verification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29291 --- Comment #11 from Christopher Brannon --- Thank you for hearing me out on this, and putting up with my noise. Just trying to make the most sense out of all of this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:47:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:47:30 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33899 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33899 [Bug 33899] Release team 23.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:47:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:47:30 +0000 Subject: [Koha-bugs] [Bug 33899] Release team 23.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33899 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 [Bug 35504] Release team 24.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:49:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:49:50 +0000 Subject: [Koha-bugs] [Bug 35506] New: selenium/regressions.t is failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 Bug ID: 35506 Summary: selenium/regressions.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org koha_1 | koha_1 | # Failed test 'Checkouts table must be correctly aligned' koha_1 | # at t/db_dependent/selenium/regressions.t line 204. koha_1 | # got: '' koha_1 | # expected: '1' koha_1 | # thead: 0 ; tfoot: 18 ; tbody: 0 koha_1 | # Looks like you failed 1 test of 1. koha_1 | koha_1 | # Failed test 'Display circulation table correctly' koha_1 | # at t/db_dependent/selenium/regressions.t line 211. selenium_1 | JavaScript error: http://kohadev.mydnsname.org:8080/cgi-bin/koha/opac-user.pl, line 859: ReferenceError: ssGPCYcY is not defined selenium_1 | [Child 2137, MediaDecoderStateMachine #1] WARNING: 7f7ec97e4d60 OpenCubeb() failed to init cubeb: file /builds/worker/checkouts/gecko/dom/media/AudioStream.cpp:324 selenium_1 | [Child 2137, MediaDecoderStateMachine #1] WARNING: Decoder=7f7ecb817400 [OnMediaSinkAudioError]: file /builds/worker/checkouts/gecko/dom/media/MediaDecoderStateMachine.cpp:3980 selenium_1 | [Child 2137, MediaDecoderStateMachine #1] WARNING: Decoder=7f7ecb817400 Decode error: NS_ERROR_DOM_MEDIA_MEDIASINK_ERR (0x806e000b) - OnMediaSinkAudioError: file /builds/worker/checkouts/gecko/dom/media/MediaDecoderStateMachine.cpp:3541 koha_1 | [13:36:29] t/db_dependent/00-strict.t .................................................. ok 87 ms ( 0.08 usr 0.00 sys + 496.36 cusr 72.29 csys = 568.73 CPU) koha_1 | # Looks like you planned 18 tests but ran 1. koha_1 | koha_1 | # Failed test 'Encoding in session variables' koha_1 | # at t/db_dependent/selenium/regressions.t line 340. koha_1 | Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 325. koha_1 | # Looks like your test exited with 11 just after 7. koha_1 | [13:36:34] t/db_dependent/selenium/regressions.t ....................................... koha_1 | Dubious, test returned 11 (wstat 2816, 0xb00) koha_1 | Failed 3/8 subtests This was failing on Koha_Master/2760 (Docker_11) but fixed on 2761 (Docker_15). Nothing has been pushed in between. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:50:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:50:48 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #1 from Jonathan Druart --- Same failure Koha_Master/2758 on Docker_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:51:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:51:30 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #2 from Jonathan Druart --- Different one Koha_Master/2759 Docker_11 koha_1 | # Failed test 'Encoding in session variables' koha_1 | # at t/db_dependent/selenium/regressions.t line 340. koha_1 | Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 325. koha_1 | # Looks like your test exited with 11 just after 7. koha_1 | [15:45:46] t/db_dependent/selenium/regressions.t ....................................... koha_1 | Dubious, test returned 11 (wstat 2816, 0xb00) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:51:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:51:40 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:52:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:52:44 +0000 Subject: [Koha-bugs] [Bug 35507] New: TestBuilder.t is failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 Bug ID: 35507 Summary: TestBuilder.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart+koha at gmail.com QA Contact: testopia at bugs.koha-community.org koha_1 | # Failed test 'No encoding warnings!' koha_1 | # at t/db_dependent/TestBuilder.t line 519. koha_1 | # found warning: Failed to load Koha::Plugin::Com::ByWaterSolutions::KitchenSink: Could not find or check module 'Koha::Plugin::Com::ByWaterSolutions::KitchenSink' at /kohadevbox/koha/Koha/Plugins.pm line 124. koha_1 | # didn't expect to find a warning koha_1 | # Looks like you failed 1 test of 1. koha_1 | koha_1 | # Failed test 'build_sample_biblio() tests' koha_1 | # at t/db_dependent/TestBuilder.t line 523. Has been failing on Koha_Master/2759 but fixed in 2760. The output is full of Failed to load Koha::Plugin::Com::ByWaterSolutions::KitchenSink: Could not find or check module 'Koha::Plugin::Com::ByWaterSolutions::KitchenSink' at /kohadevbox/koha/Koha/Plugins.pm line 124. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 16:52:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 15:52:53 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:01:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:01:21 +0000 Subject: [Koha-bugs] [Bug 13580] Item circ history has 'last seen' labeled wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13580 Emily Lamancusa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa at montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:04:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:04:47 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #1 from Martin Renvoize --- Created attachment 159624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159624&action=edit Bug 35504: New cycle, new team :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:07:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:07:18 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #2 from Martin Renvoize --- Now is also a good time for a codename if you wanted one for this cycle... The last codename we added was Rosalie.. I quite like the idea of something to highlight inclusivity? You're our first female RM, aren't you.. at least to my knowledge? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:11:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:11:53 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:12:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:12:43 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159623|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes --- Created attachment 159625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159625&action=edit Bug 35498: Allow tab to indent lines and trigger autocomplete This patch allows the tab key to indent lines as well as trigger autocomplete. Test plan: 1) Apply patch, navigate to reports and create a new SQL report 2) Click in the text editor and press tab, it should indent and then trigger the autocomplete options 3) Type something to select from the autocomplete box and press tab - it should autocomplete that option 4) Type any word and then press space. Now press tab and it should indent again Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:12:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:12:55 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:13:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:13:44 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:17:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:17:35 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |lucas at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:20:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:20:17 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:20:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:20:19 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159625|0 |1 is obsolete| | --- Comment #9 from Lucas Gass --- Created attachment 159626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159626&action=edit Bug 35498: Allow tab to indent lines and trigger autocomplete This patch allows the tab key to indent lines as well as trigger autocomplete. Test plan: 1) Apply patch, navigate to reports and create a new SQL report 2) Click in the text editor and press tab, it should indent and then trigger the autocomplete options 3) Type something to select from the autocomplete box and press tab - it should autocomplete that option 4) Type any word and then press space. Now press tab and it should indent again Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:20:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:20:53 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #10 from Lucas Gass --- Thanks for the quick fix, Matt. Works great, passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:21:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:21:03 +0000 Subject: [Koha-bugs] [Bug 27096] Add option to message_queue to exclude specific letter codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27096 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #7 from Andrew Fuerste-Henry --- I believe this is made irrelevant by Bug 31453. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:26:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:26:08 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 Jake Deery changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery at ptfs-europe.com --- Comment #3 from Jake Deery --- How about Ada Lovelace, oft cited as the first computer programmer Or Grace Hopper, who wrote one of the first ever linkers. I think the others here at PTFS Europe had other great suggestions too :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:50:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:50:29 +0000 Subject: [Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:51:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:51:28 +0000 Subject: [Koha-bugs] [Bug 25901] Add option for ClaimsReturnedWarningThreshold to count only unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:52:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:52:10 +0000 Subject: [Koha-bugs] [Bug 35508] New: Update borrowers.updated_on when modifying a patron's attribute Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35508 Bug ID: 35508 Summary: Update borrowers.updated_on when modifying a patron's attribute Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently, if you have patron attributes and modify the values in a patron's account, the patron's updated_on date is not updated. So you cannot know when a patron was last modified if it was an attribute modification. To recreate: 1. Create a patron attribute type 1.1. Go to Administration > Patron attribute types 1.2. Click New patron attribute 1.3. Fill out the code and description 1.4. Click Save 2. Edit a patron (normal) 2.1. Go to Patrons and find a patron account 2.2. Click Edit 2.3. Change a regular field (e.g. Middle name) 2.4. Click Save --> Notice the "Updated on" date in the left column has been updated to now 3. Edit a patron attribute 3.1. In another patron account*, click Edit 3.2. Change the value of an attribute 3.3. Click Save --> Notice the "Updated on" date did not change * There needs to be at least a minute between doing step 2 and doing step 3 to notice the date/time doesn't change, or use another patron account completely. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:54:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:54:19 +0000 Subject: [Koha-bugs] [Bug 9799] Prompt for due date for specific item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9799 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:55:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:55:53 +0000 Subject: [Koha-bugs] [Bug 35509] New: Make SQL autocomplete an optional feature Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35509 Bug ID: 35509 Summary: Make SQL autocomplete an optional feature Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 32613 added autocomplete to the SQL CodeMirror editor. Not everyone loves this. It would be nice if there was a a way to turn it off per user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:56:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:56:00 +0000 Subject: [Koha-bugs] [Bug 35509] Make SQL autocomplete an optional feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35509 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32613 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 [Bug 32613] Add auto-completion to our SQL reports editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 17:56:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 16:56:00 +0000 Subject: [Koha-bugs] [Bug 32613] Add auto-completion to our SQL reports editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32613 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35509 [Bug 35509] Make SQL autocomplete an optional feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 18:08:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 17:08:14 +0000 Subject: [Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 18:09:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 17:09:54 +0000 Subject: [Koha-bugs] [Bug 35509] Make SQL autocomplete an optional feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35509 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 18:15:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 17:15:43 +0000 Subject: [Koha-bugs] [Bug 30623] Copy permissions from one user to another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 Katie Bliss changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss at dmpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 18:17:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 17:17:57 +0000 Subject: [Koha-bugs] [Bug 35510] New: Non-patron guarantor missing from CollapseFieldsPatronAddForm options Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 Bug ID: 35510 Summary: Non-patron guarantor missing from CollapseFieldsPatronAddForm options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 25654 The CollapseFieldsPatronAddForm system preference controls whether sections of the patron add/edit form are collapsed by default. Since Bug 25654 we have an additional section for Non-patron guarantor. This should be added to the list of CollapseFieldsPatronAddForm options. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 [Bug 25654] Make the contact and non-patron guarantor sections separate on patron entry form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 18:17:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 17:17:57 +0000 Subject: [Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor sections separate on patron entry form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 [Bug 35510] Non-patron guarantor missing from CollapseFieldsPatronAddForm options -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 18:49:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 17:49:54 +0000 Subject: [Koha-bugs] [Bug 35510] Non-patron guarantor missing from CollapseFieldsPatronAddForm options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 18:49:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 17:49:56 +0000 Subject: [Koha-bugs] [Bug 35510] Non-patron guarantor missing from CollapseFieldsPatronAddForm options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 --- Comment #1 from Owen Leonard --- Created attachment 159627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159627&action=edit Bug 35510: Non-patron guarantor missing from CollapseFieldsPatronAddForm options This patch adds a missing option to the CollapseFieldsPatronAddForm system preference so that the "Non-patron guarantor" section can be collapsed by default. To test, apply the patch and go to Administration -> System preferences. - Search for CollapseFieldsPatronAddForm. - In the dropdown of options you should see an entry for "Non-patron guarantor." - Click "Select all" and save your changes. - Go to Patrons -> New patron and choose a patron category which can have a guarantor (for example J - Juvenile) - The patron entry page should load with all sections collapsed, including the Non-patron guarantor section. - Uncheck all options in the CollapseFieldsPatronAddForm preference and return to the patron entry form. All sections should now appear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 18:59:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 17:59:23 +0000 Subject: [Koha-bugs] [Bug 35511] New: Add visual indicators of patron edit form collapsible sections Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 Bug ID: 35511 Summary: Add visual indicators of patron edit form collapsible sections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org Depends on: 35510 On the patron add/edit form there is no visible sign that the heading of each section is clickable other than the cursor change. I think adding some style there will help avoid accidentally clicking the heading unintentionally. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 [Bug 35510] Non-patron guarantor missing from CollapseFieldsPatronAddForm options -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 18:59:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 17:59:23 +0000 Subject: [Koha-bugs] [Bug 35510] Non-patron guarantor missing from CollapseFieldsPatronAddForm options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35511 [Bug 35511] Add visual indicators of patron edit form collapsible sections -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 19:20:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 18:20:05 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #4 from Katrin Fischer --- Hedy Lamarr or Katherine Johnson (NASA mathematician) also come to mind :) Overall I feel this should be a community decision not an RM one. We have a general meeting coming up in January. What about adding it to the agenda there? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 19:31:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 18:31:20 +0000 Subject: [Koha-bugs] [Bug 29291] Link self registration verification email to patron account after verification In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29291 --- Comment #12 from Katrin Fischer --- (In reply to Christopher Brannon from comment #11) > Thank you for hearing me out on this, and putting up with my noise. Just > trying to make the most sense out of all of this. I think I could have done a bit better here. Glad we came to a solution. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 20:28:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 19:28:28 +0000 Subject: [Koha-bugs] [Bug 35502] [Omnibus] Rewrite koha-restore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35502 Rudolf Byker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rudolfbyker at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 21:04:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 20:04:14 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- Notes/questions from testing ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ - Accessibility advocate: is empty on the About > Koha team > Current maintenance team, in the patch we have two listed (as per the roles page) and these show under individual names - Website Maintainer: patch shows Liz Rea, but on the roles page this is empty; assuming she is continuing until new website is running(?) - KTD maintainer: no role/section in the patch for KTD maintainer, but it is on the role page - I think this is the first time we have had this specific role - Wiki Curator: George Williams also added his name on the roles page, but this is not included - Wiki team member (shown as Wiki Curator(?)): Mason James not included (is on the roles page), Katrin Fisher is included (but not on the roles page - probably should be as she does lots of changes and tidy ups!) Names for release ~~~~~~~~~~~~~~~~~ I don't have any objections to having names for releases. However, I thought the Rosalie release was special - to commemorate her importance to the existence of Koha. If we did have names, I think it should be in some way either library, information management, or Koha related - people important to these. Maybe, if there was a theme for the release (such as a major new module), it could be named after that, for example: the ERM release. But, as Katrin says, for discussion at the next general meeting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 21:58:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 20:58:31 +0000 Subject: [Koha-bugs] [Bug 35510] Non-patron guarantor missing from CollapseFieldsPatronAddForm options In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35510 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind --- For me, this worked except for under the "Add patron (Kid) heading: it only shows [] Show collapsed fields (without No-patron guarantor). For example, if I ticked Non-patron guarantor and Patron guarantor, this shows under the heading: [] Show collapsed fields: Guarantor information | (As an aside, I don't think the display under the heading is that great, but I have no suggestions...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 22:01:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 21:01:39 +0000 Subject: [Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- I'm happy to test, but how to send a request is not something I'm great at. Could you provide an example of how to send a request to generate the error? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 22:44:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 21:44:24 +0000 Subject: [Koha-bugs] [Bug 35512] New: Notices transferred during a patron merge should preserve their original dates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35512 Bug ID: 35512 Summary: Notices transferred during a patron merge should preserve their original dates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: Laura.escamilla at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When two patrons are merged their notices are transferred over and the 'Updated on' column in the Notice table changes the dates to the date of the merge. While this is expected behavior it would be helpful if the 'Updated on' column kept it's original dates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 22:44:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 21:44:37 +0000 Subject: [Koha-bugs] [Bug 35512] Notices transferred during a patron merge should preserve their original dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35512 Laura Escamilla changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 22:58:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 21:58:17 +0000 Subject: [Koha-bugs] [Bug 35513] New: DataTable controls being retained throughout different acq baskets Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35513 Bug ID: 35513 Summary: DataTable controls being retained throughout different acq baskets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1. Add 2 vendors, Vendor A and Vendor B 2. Create a basket with Vendor A that has more than 20 items in it. 3. Close basket, receive. 4. Note the URL on are at. Something like /cgi-bin/koha/acqui/basket.pl?basketno=3 5. Create another basket with Vendor B, this one should have less than 10 items. 6. Close basket, receive. URL /cgi-bin/koha/acqui/basket.pl?basketno=4 7. Now go back to the first basket and change go to the 2nd page ( pagination ). 8. Now open up the 2nd basket, It looks like there are no items but this is because it is trying to paginate to the 2nd page which doesn't exist in this case. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 23:01:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 22:01:55 +0000 Subject: [Koha-bugs] [Bug 35513] DataTable controls being retained throughout different acq baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35513 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh at dubcolib.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 23:14:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 22:14:30 +0000 Subject: [Koha-bugs] [Bug 35513] DataTable controls being retained throughout different acq baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35513 --- Comment #1 from Andrew Fuerste-Henry --- The same appears to be true of invoices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 23:17:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 22:17:54 +0000 Subject: [Koha-bugs] [Bug 35513] DataTable controls being retained throughout different acq baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35513 --- Comment #2 from Lucas Gass --- It seems like we are retaining too much in localStorage. console.log(localStorage): "DataTables_pending_orders_/cgi-bin/koha/acqui/parcel.pl": '{"time":1701900452223,"start":20,"length":10,"order":[[1,"asc"]],"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true},"columns":[{"visible":true,"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true}},{"visible":true,"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true}},{"visible":true,"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true}},{"visible":true,"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true}},{"visible":true,"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true}},{"visible":true,"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true}},{"visible":true,"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true}},{"visible":true,"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true}},{"visible":true,"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true}},{"visible":true,"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true}},{"visible":true,"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true}},{"visible":true,"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true}},{"visible":true,"search":{"search":"","smart":true,"regex":false,"caseInsensitive":true}}]} -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 23:28:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 22:28:46 +0000 Subject: [Koha-bugs] [Bug 35513] DataTable controls being retained throughout different acq baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35513 --- Comment #3 from Lucas Gass --- To avoid this "stateSave" should be set to false in the dataTable config. However I worry that there is a reason that stateSave is implicitly set to true. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 23:50:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 22:50:56 +0000 Subject: [Koha-bugs] [Bug 35509] Make SQL autocomplete an optional feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35509 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 23:52:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 22:52:12 +0000 Subject: [Koha-bugs] [Bug 35498] SQL auto-complete should not prevent use of tab for spacing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35498 --- Comment #11 from David Cook --- You're a legend, Matt. Thanks for hopping on this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 23:53:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 22:53:48 +0000 Subject: [Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #25 from David Cook --- Thanks for working on this, Martin. I'll try to take a look in a bit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 6 23:55:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 22:55:11 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #40 from David Cook --- Sounds good! I've got something on at the moment, but I'll try to look at this later. Thanks, Thibaud for your hard work on this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 00:01:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 23:01:09 +0000 Subject: [Koha-bugs] [Bug 31361] Button batch operations disappears when alias is used for itemnumber of biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31361 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com --- Comment #2 from Benjamin Daeuber --- I've created a merge request to add this to the manual here: https://gitlab.com/koha-community/koha-manual/-/merge_requests/767 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 00:06:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 23:06:54 +0000 Subject: [Koha-bugs] [Bug 34315] Replacement of mailman (mailing lists) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34315 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I currently run a Discourse instance so happy to share what I know... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 00:41:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Dec 2023 23:41:05 +0000 Subject: [Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- I had a go at testing, but didn't quite get there. How do you update the po files when Vue stuff is involved? I'm sure I'm not quite getting it all yet! I tried (after installing the patch): 1. yarn build (for rebuilding Vue stuff) 2. gulp po:update --lang es-ES (as an example) 3. language was already installed (es-ES as an example) The es-ES-messages-js.po (as an example) doesn't seem to have been updated - I think this is the one that should have been udpated? Test plan so far: 1. Install another language 2. Enable the language for the staff interface (Administration > System preferences > I18N/L10N > language) 3. Enable the ERM module (ERMModule) 4. Change the language to the one you installed 5. Go to E-resource management > eHoldings > Local > Packages > +New package 6. Note that the submit button is not translated (Compare to one of the other submit buttons that is translated (E-resource management > Agreements > +New agreement) 7. Search misc/translation/po/-messages-js.po for 'Submit' - Note that there is only one line entry for 'Submit' #: koha-tmpl/intranet-tmpl/prog/js/vue/components/ButtonSubmit.vue:11 8. Apply the patch 9. Update the Vie stuff: yarn build 10. gulp po:update --lang 11. Update the language: koha-translate --update es-ES --dev kohadev (necessary?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 05:27:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 04:27:52 +0000 Subject: [Koha-bugs] [Bug 35412] Capitalization: Toggle Dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35412 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159321|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 159628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159628&action=edit Bug 35412: Fix incorrect capitalization: Toggle Dropdown This patch corrects incorrect capitalization in the last-borrower include file. The string his hidden except to screen readers, so visual confirmation isn't straightforward. Viewing the diff should be enough to confirm this single character change. Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 05:28:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 04:28:31 +0000 Subject: [Koha-bugs] [Bug 35412] Capitalization: Toggle Dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35412 --- Comment #4 from Victor Grousset/tuxayo --- Trivial change, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 05:28:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 04:28:37 +0000 Subject: [Koha-bugs] [Bug 35412] Capitalization: Toggle Dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35412 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 06:26:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 05:26:04 +0000 Subject: [Koha-bugs] [Bug 35404] Wrong copy and paste in string (ILL batches) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35404 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159270|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 159629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159629&action=edit Bug 35404: Fix wrong copy and paste in string (ILL batches) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Pedro Amorim Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 06:27:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 05:27:15 +0000 Subject: [Koha-bugs] [Bug 35404] Wrong copy and paste in string (ILL batches) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35404 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo --- Trivial change, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 06:43:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 05:43:16 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #41 from David Cook --- (In reply to Lucas Gass from comment #32) > As this stands no borrowers/staff will get the new permission on update. > That is a change in behavior that needs to be avoided. Originally, I was thinking this too, but now I'm not so sure, since this issue has been around for 2 years now. > I think we need to give anyone who has the edit_borrowers permission the > list_borrowers permission via a DB update. Thibaud has made it so you can have either list_borrowers or edit_borrowers, so I don't think we'd want to give list_borrowers to anyone with edit_borrowers. But perhaps we'd want to give list_borrowers to anyone with "circulate_remaining_permissions". But then I think maybe we don't need to worry about it, since over the last 2 years people will have probably given "edit_borrowers"... so maybe we're catering more to new installs / new users... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 06:45:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 05:45:23 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #42 from David Cook --- I would've been happy to sign this off, but looks like there is a little perltidy problem with the database update. If you perltidy that file, then you should be good to go. -- testing 1 commit(s) (applied to 0d483a5 '22 DBRev 23.12.00.000: Start of a new') Processing files before patches |========================>| 8 / 8 (100.00%) Processing files after patches |========================>| 8 / 8 (100.00%) OK api/v1/swagger/paths/patrons.yaml WARN installer/data/mysql/atomicupdate/bug_29509_add-new-list-borrowers-permission.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 1) OK koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-header.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt OK members/member.pl OK members/members-home.pl OK members/moremember.pl Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 06:59:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 05:59:13 +0000 Subject: [Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204 --- Comment #3 from David Cook --- (In reply to David Nind from comment #2) > I'm happy to test, but how to send a request is not something I'm great at. > > Could you provide an example of how to send a request to generate the error? > > Thanks! curl -u AMINDUSER:ADMINPASSWORD -H "Content-Type: application/json" http://localhost:8081/api/v1/auth/password/validation -d '{"identifier":"patron","password":"$uper Duper 4wesome Password"}' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 07:14:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 06:14:32 +0000 Subject: [Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204 --- Comment #4 from David Cook --- While this works... I don't think it's the right solution. It looks like we should change "unless ($status)" to "unless ($status && $status > 0)". I'm basing that off these lines 2004 # INTERNAL AUTH 2005 if ( $check_internal_as_fallback ) { 2006 @return = checkpw_internal( $userid, $password, $no_set_userenv); 2007 $passwd_ok = 1 if $return[0] > 0; # 1 or 2 2008 } I don't think the -2 for an expired password actually gets used anywhere so that's fun. The "password_expired" message at login time seems to come from $patron->password_expired in a different auth function. I don't know what a return value of 2 means either... (One of these days auth in Koha won't be a nightmare...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 07:15:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 06:15:07 +0000 Subject: [Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from David Cook --- Sorry but I think I'm going to mark this one as Failed QA even though I'm the one who made the original mistake 😅 I can fix this tomorrow afternoon if you'd prefer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 07:27:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 06:27:02 +0000 Subject: [Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #26 from David Cook --- I've applied the last 2 patches and restarted Koha... Bug 35104: [Alternative] Throw exception on store of invalid marcxml Bug 35104: Initial attempt at catching the failure on new records And then I added the text from "Text file containing control characters" into a test record -- I'm getting an error trace page. It looks like you made a little mistake when catching the exception and it's causing you to rethrow it. I'll fix that up in a sec... -- However, with the fix, we're still having a problem rendering the page. But I'll let folk take it from there... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 07:27:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 06:27:45 +0000 Subject: [Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #27 from David Cook --- Created attachment 159630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159630&action=edit Bug 35104: Fix typo when catching exception -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 07:28:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 06:28:43 +0000 Subject: [Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #28 from David Cook --- I have to run and I'm away tomorrow morning, but hopefully this gets you a bit further. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 08:02:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 07:02:19 +0000 Subject: [Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204 --- Comment #6 from David Nind --- (In reply to David Cook from comment #3) > (In reply to David Nind from comment #2) > > I'm happy to test, but how to send a request is not something I'm great at. > > > > Could you provide an example of how to send a request to generate the error? > > > > Thanks! > > curl -u AMINDUSER:ADMINPASSWORD -H "Content-Type: application/json" > http://localhost:8081/api/v1/auth/password/validation -d > '{"identifier":"patron","password":"$uper Duper 4wesome Password"}' Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 08:03:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 07:03:12 +0000 Subject: [Koha-bugs] [Bug 35415] Rephrase: Some patrons have requested a privacy ... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35415 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159453|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 159631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159631&action=edit Bug 35415: Rephrase: Some patrons have requested a privacy ... This patch revises the wording of the warning which is displayed on the 'About' page when the 'OPACPrivacy' system preference is enabled but the 'AnonymousPatron' preference is empty. The new phrasing is hopefully more clear. To test, apply the patch and go to Administration -> System preferences. - Search for 'AnonymousPatron' and enter a borrowernumber if necessary. - Log in to the OPAC and click the 'Privacy' tab in the left-hand sidebar of the user summary page. - Set your privacy rule to 'Never'. - Return to Admnistration -> Sytem preferences in the staff interface. - Search for 'OPACPrivacy' and set it to 'Allow'. - Clear the borrowernumber from the 'AnonymousPatron' preference. - Go to the 'About" page and open the 'System information' tab. - You should see an error message at the bottom: "Some patrons have requested privacy after their items are checked in, but the AnonymousPatron preference is not set correctly. Set it to a valid borrower number or checkins for these patrons will fail." Signed-off-by: Barbara Johnson Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 08:03:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 07:03:31 +0000 Subject: [Koha-bugs] [Bug 35415] Rephrase: Some patrons have requested a privacy ... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35415 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 08:09:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 07:09:58 +0000 Subject: [Koha-bugs] [Bug 35486] When editing an authority show all subfields of the heading field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35486 --- Comment #4 from Fridolin Somers --- (In reply to Owen Leonard from comment #3) > Is this a functional gap in the options we have for editing authority > frameworks? Sort of > > Shouldn't we enable the option of making subfields visible or not in > authority frameworks instead of hard-coding the choice? Indeed But this may be more work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 08:10:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 07:10:14 +0000 Subject: [Koha-bugs] [Bug 35453] Wrong 'Laserdisc)' string on 007 builder (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35453 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159417|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 159632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159632&action=edit Bug 35453: Fix wrong 'Laserdisc)' string on 007 builder (MARC21) Steps to reproduce: 1. On cataloguing, open the 007 builder. 2. Choose material type 'Video recording' 3. On 04 choose g - Laserdisc 4. Click save => SUCCESS: 'g' correctly shows on the 007 5. Edit the 007 again => FAIL: on 04, 'g - Laserdisc)' is displayed 6. Apply this patch 7. Repeat 4 and 5 => SUCCESS: no trailing ')' 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 08:10:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 07:10:56 +0000 Subject: [Koha-bugs] [Bug 35453] Wrong 'Laserdisc)' string on 007 builder (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35453 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor at tuxayo.net --- Comment #4 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 09:13:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 08:13:31 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 09:13:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 08:13:34 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159613|0 |1 is obsolete| | --- Comment #43 from Thibaud Guillot --- Created attachment 159633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159633&action=edit Bug 30230: Add new 'list_borrowers' permission When a patron search is performed only a user with edit_borrowers permission can search by name. Search can works only with cardnumber but it makes searching less intuitive I think. So, as mentioned in the discussion, I've added a new 'list_borrowers' permission, completely independent of 'edit_borrowers', so that I can search for a member via the interface and get the results. In addition to the permission to perform check in and checkouts, this no longer poses an obstacle to simple use. Test plan: 1) Check with a user without 'edit_borrowers' permission that the patron search can only be performed with cardnumber 2) Apply this patch 3) Make the updatedatabase to add new 'list_borrowers' permissions 4) Set 'list_borrowers' permission on one user and see the difference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 09:15:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 08:15:09 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #44 from Thibaud Guillot --- (In reply to David Cook from comment #42) > I would've been happy to sign this off, but looks like there is a little > perltidy problem with the database update. > > If you perltidy that file, then you should be good to go. > > -- > > testing 1 commit(s) (applied to 0d483a5 '22 DBRev 23.12.00.000: Start of a > new') > > Processing files before patches > |========================>| 8 / 8 (100.00%) > Processing files after patches > |========================>| 8 / 8 (100.00%) > > OK api/v1/swagger/paths/patrons.yaml > > WARN > installer/data/mysql/atomicupdate/bug_29509_add-new-list-borrowers- > permission.pl > WARN tidiness > The file is less tidy than before (bad/messy lines before: > 0, now: 1) > > OK koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-header.inc > > OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc > > OK koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt > > OK members/member.pl > > OK members/members-home.pl > > OK members/moremember.pl > > > Processing additional checks OK! Thanks for you feedback, I rebased it cause the bug number was not good in update file. So I hope that will be okay now :) Have a nice day -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 09:45:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 08:45:20 +0000 Subject: [Koha-bugs] [Bug 28869] If authorized values for STACK (shelving control number) are > 127 things explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- (In reply to Lucas Gass from comment #0) > The A.V. category of STACK maps to items.stack. Somehow in our local production db I do have the AV STACK category (without any value under it) and no mappings to STACK in the frameworks! We do not use the field but it contains a small number of 127s. Should have hidden the field in the item editor ;) > Tinyint can be anything between -128 and 127. MySQL defaults to signed. If we SHOULD alter it to UNSIGNED. We have 0 to 255. Which might be just a bit more useful in the library environment. See also below. > -Edit an item, things seem to work fine. If you enter a value over 127, it is converted to 127. This is not really fine imo :) It is just silently adjusted/capped. > Should items.stack be int? This actually is a harder question than it looks like. One aspect is that the item editor just silently ignores non-numeric input in this field. So a text field would be nice? But authorised_values.id is an INT. But "unfortunately", Koha does not save the id in the corresponding item field but the actual value which is varchar(80). (Using a TEXT variant here would have performance impacts.) In conclusion, for items.stack I would opt for varchar(80) too here. It does however trigger a few remarks having a wider scope (postponed to next comment). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 10:15:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 09:15:36 +0000 Subject: [Koha-bugs] [Bug 35486] When editing an authority show all subfields of the heading field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35486 --- Comment #5 from Katrin Fischer --- I think the right fix here is to make the "collapsable" option available in the fameworks configuration so it matches up with the bibliographic frameworks. As the headings have many subfields a library might almost never use, showing them all by default might just give us the next bug report. The library should be able to control what is immediately visible and what is visible after clicking on the tag. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 10:24:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 09:24:51 +0000 Subject: [Koha-bugs] [Bug 35504] Release team 24.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35504 --- Comment #6 from Katrin Fischer --- I added it to the agenda: https://wiki.koha-community.org/wiki/General_IRC_meeting_17_January_2024 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 10:30:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 09:30:21 +0000 Subject: [Koha-bugs] [Bug 29816] Document patron emailer cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29816 --- Comment #4 from Katrin Fischer --- (In reply to Ray Delahunty from comment #3) > Apologies- on 22.11 I have notices being sent by the patron_emailer.pl > script working perfectly with html, and the fields pulled in from the report > must use TT notation so html and at least some TT is supported. All I can > assume from earlier failures (ages back) must be down to specific objects/ > variables that either aren’t fully supported (or more likely!) I had syntax > errors in my TT code. Thanks for the feedback! I think it would be worthwhile to have better documentation especially with some no longer available for the plugin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 10:40:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 09:40:09 +0000 Subject: [Koha-bugs] [Bug 35387] Capitalization: Labels in preservation module are not capitalized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Capitalization: 'name' |Capitalization: Labels in |label in preservation |preservation module are not |module |capitalized -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 10:50:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 09:50:15 +0000 Subject: [Koha-bugs] [Bug 34573] Inconsistencies in acquisitions modify vendor title tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Katrin Fischer --- I found some oddness here: When adding a new vendor, the title tag reads: "Modify vendor ''". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:19 +0000 Subject: [Koha-bugs] [Bug 35327] Fix capitalization of language name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:21 +0000 Subject: [Koha-bugs] [Bug 35327] Fix capitalization of language name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327 --- Comment #7 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:23 +0000 Subject: [Koha-bugs] [Bug 35376] Rephrase: Be careful removing attribute to this processing, the items using it will be impacted as well! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35376 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:24 +0000 Subject: [Koha-bugs] [Bug 35376] Rephrase: Be careful removing attribute to this processing, the items using it will be impacted as well! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35376 --- Comment #6 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:26 +0000 Subject: [Koha-bugs] [Bug 35378] 'This authority type is used {count} times' missing dot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:27 +0000 Subject: [Koha-bugs] [Bug 35378] 'This authority type is used {count} times' missing dot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35378 --- Comment #6 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:29 +0000 Subject: [Koha-bugs] [Bug 35383] Dragging and dropping subfield of repeated tags doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:30 +0000 Subject: [Koha-bugs] [Bug 35383] Dragging and dropping subfield of repeated tags doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 --- Comment #8 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:32 +0000 Subject: [Koha-bugs] [Bug 35387] Capitalization: Labels in preservation module are not capitalized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35387 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:33 +0000 Subject: [Koha-bugs] [Bug 35387] Capitalization: Labels in preservation module are not capitalized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35387 --- Comment #8 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:35 +0000 Subject: [Koha-bugs] [Bug 35404] Wrong copy and paste in string (ILL batches) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35404 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:36 +0000 Subject: [Koha-bugs] [Bug 35404] Wrong copy and paste in string (ILL batches) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35404 --- Comment #7 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:38 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:39 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 --- Comment #12 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:41 +0000 Subject: [Koha-bugs] [Bug 35412] Capitalization: Toggle Dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35412 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:42 +0000 Subject: [Koha-bugs] [Bug 35412] Capitalization: Toggle Dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35412 --- Comment #5 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:43 +0000 Subject: [Koha-bugs] [Bug 35415] Rephrase: Some patrons have requested a privacy ... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35415 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:45 +0000 Subject: [Koha-bugs] [Bug 35415] Rephrase: Some patrons have requested a privacy ... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35415 --- Comment #7 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:47 +0000 Subject: [Koha-bugs] [Bug 35441] Typo 'UniqueItemsFields' system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35441 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:48 +0000 Subject: [Koha-bugs] [Bug 35441] Typo 'UniqueItemsFields' system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35441 --- Comment #5 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:49 +0000 Subject: [Koha-bugs] [Bug 35453] Wrong 'Laserdisc)' string on 007 builder (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35453 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:05:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:05:51 +0000 Subject: [Koha-bugs] [Bug 35453] Wrong 'Laserdisc)' string on 007 builder (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35453 --- Comment #5 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:09:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:09:09 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This updates the default |This updates the default release notes|staff interface and OPAC |staff interface and OPAC |XSLT files so that "Online |XSLT files so that "Online |resources" is used as the |resources" is used as the |label in search results for |label in search results for |filed 856 - Electronic |filed 856 - Electronic |Location and Access, |Location and Access, |instead of "Online access". |instead of "Online access". |This matches the label used |This matches the label used |in the detail page for a |in the detail page for a |record. |record. | | | |It also adjusts | |the CSS class so OPAC and | |staff interface both use | |online_resources. --- Comment #13 from Katrin Fischer --- Note: I like the consistency of the change to the class, but it could have some side effects for existing CSS. I decided to push, because the change is in the staff interface, not in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:24:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:24:53 +0000 Subject: [Koha-bugs] [Bug 35225] Improve AllowRenewalIfOtherItemsAvailable performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35225 --- Comment #1 from Johanna Räisä --- This problem seems to be fixed with bug 34178. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:25:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:25:04 +0000 Subject: [Koha-bugs] [Bug 35225] Improve AllowRenewalIfOtherItemsAvailable performance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35225 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Johanna Räisä --- *** This bug has been marked as a duplicate of bug 34178 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:25:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:25:04 +0000 Subject: [Koha-bugs] [Bug 34178] Add caching of ItemsAnyAvailableAndNotRestricted to IsAvailableForItemLevelRequest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34178 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa at koha-suomi.fi --- Comment #13 from Johanna Räisä --- *** Bug 35225 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:38:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:38:39 +0000 Subject: [Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 --- Comment #3 from Jonathan Druart --- Hi David, I cannot test right now, but you need: 8. Apply the patch 9. yarn build (or simply yarn js:build) 10. restart_all (JS translations are cached in memcached) That should be enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:55:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:55:44 +0000 Subject: [Koha-bugs] [Bug 34168] Make it possible to configure display sequence of additional fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Blocks| |32751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32751 [Bug 32751] [Omnibus] Extend, improve and standardize additional fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:55:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:55:44 +0000 Subject: [Koha-bugs] [Bug 32751] [Omnibus] Extend, improve and standardize additional fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32751 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34168 [Bug 34168] Make it possible to configure display sequence of additional fields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:55:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:55:51 +0000 Subject: [Koha-bugs] [Bug 28795] Ability additional fields to lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28795 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Blocks| |32751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32751 [Bug 32751] [Omnibus] Extend, improve and standardize additional fields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:55:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:55:51 +0000 Subject: [Koha-bugs] [Bug 32751] [Omnibus] Extend, improve and standardize additional fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32751 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28795 [Bug 28795] Ability additional fields to lists -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:57:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:57:37 +0000 Subject: [Koha-bugs] [Bug 35197] Expose additional fields through REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35190 [Bug 35190] Additional_fields table should allow null values for authorised_value_category -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 12:57:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 11:57:37 +0000 Subject: [Koha-bugs] [Bug 35190] Additional_fields table should allow null values for authorised_value_category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35190 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35197 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 [Bug 35197] Expose additional fields through REST API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:04:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:04:41 +0000 Subject: [Koha-bugs] [Bug 32755] Make it possible to show additional fields for baskets in acq search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32755 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30645 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 [Bug 30645] Patron search not building the query correctly for extended attributes if several terms passed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:04:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:04:41 +0000 Subject: [Koha-bugs] [Bug 30645] Patron search not building the query correctly for extended attributes if several terms passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32755 [Bug 32755] Make it possible to show additional fields for baskets in acq search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:05:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:05:58 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30645 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 [Bug 30645] Patron search not building the query correctly for extended attributes if several terms passed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:05:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:05:58 +0000 Subject: [Koha-bugs] [Bug 30645] Patron search not building the query correctly for extended attributes if several terms passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 [Bug 35287] Add additional fields support to ERM Licenses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:08:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:08:23 +0000 Subject: [Koha-bugs] [Bug 30645] API searches across joined extended attributes database query is built incorrectly when several terms are passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron search not building |API searches across joined |the query correctly for |extended attributes |extended attributes if |database query is built |several terms passed |incorrectly when several | |terms are passed Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:09:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:09:05 +0000 Subject: [Koha-bugs] [Bug 30645] Generated DBIC query incorrect for api searches across joined extended attributes when several terms are passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|API searches across joined |Generated DBIC query |extended attributes |incorrect for api searches |database query is built |across joined extended |incorrectly when several |attributes when several |terms are passed |terms are passed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:28:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:28:48 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158725|0 |1 is obsolete| | --- Comment #11 from PTFS Europe Sandboxes --- Created attachment 159634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159634&action=edit Bug 35287: Add cypress tests Test plan, k-t-d: cd /kohadevbox/koha cypress run --spec "t/cypress/integration/AdditionalFields_spec.ts" Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:28:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:28:51 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158726|0 |1 is obsolete| | --- Comment #12 from PTFS Europe Sandboxes --- Created attachment 159635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159635&action=edit Bug 35287: Add unit tests Test plan, k-t-d: prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:28:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:28:53 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158727|0 |1 is obsolete| | --- Comment #13 from PTFS Europe Sandboxes --- Created attachment 159636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159636&action=edit Bug 35287: Preparation: Extend AdditionalFields Mixin The mixin now implements the extended_attributes method to be utilized by any Koha class that implements the AdditionalFields Mixin and is exposed through the REST API It also implements a strings_map to be utilized in the same fashion as described above. This is useful because additional fields may be an authorised value Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:28:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:28:55 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158728|0 |1 is obsolete| | --- Comment #14 from PTFS Europe Sandboxes --- Created attachment 159637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159637&action=edit Bug 35287: Preparation: AdditionalFields License Mixin Koha::Object::Mixin::AdditionalFields needs to come before Koha::Object in the inheritance so that the strings_map method that is called is the one from Mixin and not from Koha::Object. This is only required for Koha classes implementing the AdditionalFields Mixin and expose data through the REST API, because strings_map is implement in both the aforementioned classes Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:28:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:28:58 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158729|0 |1 is obsolete| | --- Comment #15 from PTFS Europe Sandboxes --- Created attachment 159638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159638&action=edit Bug 35287: Admin ERM licenses is now a table option in the additional fields admin panel ERM licenses allows for the 'searchable' option (as well as 'repeatable') Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:29:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:29:00 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158730|0 |1 is obsolete| | --- Comment #16 from PTFS Europe Sandboxes --- Created attachment 159639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159639&action=edit Bug 35287: REST API - Add additional fields support to ERM Licenses Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:29:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:29:03 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158731|0 |1 is obsolete| | --- Comment #17 from PTFS Europe Sandboxes --- Created attachment 159640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159640&action=edit Bug 35287: Vue preparation - AdditionalFields New api client: additional-fields-api-client.js to interact with the REST endpoint introduced by bug 35197 2 new components: - AdditionalFieldsEntry: Component used to extend the FormAdd component including the corresponding additional fields - AdditionalFieldsDisplay: Component used to display the additional fields associated to a data record implementing it (makes use of strings_map) Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:29:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:29:05 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158732|0 |1 is obsolete| | --- Comment #18 from PTFS Europe Sandboxes --- Created attachment 159641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159641&action=edit Bug 35287: Vue preparation - Extend KohaTable to consider searchable additional fields This follows the same pattern as in subscription serials searchable additional fields, i.e. if an additional field is searchable, it is added to the list table - with the corresponding search inputs and functionality Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:29:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:29:08 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158733|0 |1 is obsolete| | --- Comment #19 from PTFS Europe Sandboxes --- Created attachment 159642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159642&action=edit Bug 35287: Vue - Add additional fields support to ERM Licenses Test plan, k-t-d: 1) Add a new additional field for the newly supported 'erm_licenses', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 2) Create 4 fields by clicking on '+ New field' 2.1) 'text non-repeatable' 2.2) 'text repeatable', check the 'repeatable' box 2.3) 'av non-repeatable', pick an authorised value category 2.4) 'av repeatable', pick an authorised value category and check the 'repeatable' box 3) Add a new ERM license, visit: /cgi-bin/koha/erm/licenses/add 4) Notice there is now a 'Additional fields' section at the bottom listing the fields we created 5) Fill in the mandatory regular license fields and play around with the additional fields 5.1) Put in some text in the text fields, test out the 'clear' and '+new' buttons 5.2) Select some AV options from the AV fields, deselect them, notice the repeatable one allows for multiple selection, the non-repeatable one does not 6) Save the license. On the list table, click on the license name (to navigate to the show page), or if license id=1, visit: /cgi-bin/koha/erm/licenses/1 7) Notice the additional fields are listed there, AV fields show their human readable description, not the AV code. Repeatable fields are shown comma separated 8) Edit the license, visit: /cgi-bin/koha/erm/licenses/edit/1 9) Play around again, do some more inserting and deletion of additional fields. Save. Notice everything is as expected. Searchable testing: 10) Go back to the additional fields admin panel, visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=erm_licenses 11) Edit one field (AV or not) that you have inserted some data in, in the previous steps, and tick the 'searchable' box 12) Go back to licenses, visit: /cgi-bin/koha/erm/licenses 13) Notice the searchable additional field now has its own column in the licenses list table 14) If the searchable field is AV, it has a dropdown with the AV values of the same AV category 15) If the searchable field not AV, it has a text input that allows for normal text search 16) If the searchable field is repeatable and has multiple values, its displayed in comma separated Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:29:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:29:11 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158734|0 |1 is obsolete| | --- Comment #20 from PTFS Europe Sandboxes --- Created attachment 159643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159643&action=edit Bug 35287: perltidy for green QA script Signed-off-by: Edith Speller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:31:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:31:18 +0000 Subject: [Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 Edith Speller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edith.speller at ukhsa.gov.uk Status|Needs Signoff |Signed Off --- Comment #21 from Edith Speller --- Great work, thanks very much Pedro! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 13:31:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 12:31:51 +0000 Subject: [Koha-bugs] [Bug 35204] REST API: POST endpoint /auth/password/validation dies on patron with expired password In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35204 --- Comment #7 from Tomás Cohen Arazi --- I was going to fail this one yesterday but had a flight delayed. - We need tests (they should highlight what dcook is saying) - My opinion is we should return `error_code` => 'password_expired' or similar, so API consumers can really act correctly on further steps for the end user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:01:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:01:33 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Philip Orr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:01:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:01:36 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Philip Orr changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159582|0 |1 is obsolete| | --- Comment #23 from Philip Orr --- Created attachment 159644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159644&action=edit Bug 35463: Link preservation module help to the manual This patch links the various pages of the preservation module to each specific section of the preservation module chapter in the manual. To test: 1. Enable the PreservationModule system preference 2. Go to the Preservation module 3. Click "help" in the top right corner --> You are brought to the manual, but not a specific page 4. Apply patch 5. Click "Help" in the top right corner --> You are brought to the Preservation chapter of the manual 6. Click "Settings" 7. Click "Help" in the top right corner --> You are brought to the Settings section of the Preservation chapter of the manual 8. Choose a not for loan status for items added to the waiting list (the mandatory field) and submit 9. Click "Add a new processing" 10. Click "Help" in the top right corner --> You are brought to the Add a new processing section of the Preservation chapter of the manual 11. Fill out the form to create the processing and submit 12. Click "Edit this processing" 13. Click "Help" in the top right corner --> You are brought to the Add a new processing section of the Preservation chapter of the manual (there is no edit a processing section) 14. Click "Waiting list" 15. Click "Help" in the top right corner --> You are brought to the Waiting list section of the Preservation chapter of the manual 16. Add items to the waiting list 17. Click "Trains" 18. Click "Help" in the top right corner --> You are brought to the Trains section of the Preservation chapter of the manual 19. Click "New train" 20. Click "Help" in the top right corner --> You are brought to the New train section of the Preservation chapter of the manual 21. Fill out the form to create a new train and submit 22. Click "Add items" 23. Click "Help" in the top right corner --> You are brought to the Add items section of the Preservation chapter of the manual 24. Also check ERM help links to make sure nothing is broken Signed-off-by: Martin Renvoize Signed-off-by: Philip Orr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:01:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:01:43 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Philip Orr changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159583|0 |1 is obsolete| | --- Comment #24 from Philip Orr --- Created attachment 159645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159645&action=edit Bug 35463: Open erm and preservation help in new tab Signed-off-by: Martin Renvoize Signed-off-by: Philip Orr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:01:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:01:46 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Philip Orr changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159584|0 |1 is obsolete| | --- Comment #25 from Philip Orr --- Created attachment 159646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159646&action=edit Bug 35463: perltidy formatting corrections Signed-off-by: Martin Renvoize Signed-off-by: Philip Orr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:01:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:01:49 +0000 Subject: [Koha-bugs] [Bug 35463] Link preservation module help to the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35463 Philip Orr changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159586|0 |1 is obsolete| | --- Comment #26 from Philip Orr --- Created attachment 159647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159647&action=edit Bug 35463: More preservation manual links This patch adds some missing links from the preservation module to the manual. To test: 1. Go to Preservation > Trains 2. Click on a train name --> You are brought to the Show train section of the Preservation chapter of the manual 3. Click Edit next to an item --> You are brought to the Add items section of the Preservation chapter of the manual (there is no section specific to editing items, but the form to edit is the same as the form to add) 4. Go back to the trains list, and click the Edit button next to one of the trains --> You are brought to the Trains section of the Preservation chapter of the manual (there is no section specific to editing trains yet) Signed-off-by: Philip Orr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:08:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:08:01 +0000 Subject: [Koha-bugs] [Bug 35378] 'This authority type is used {count} times' missing dot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35378 --- Comment #7 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #5) > RM: You know that this contains a string change :) XD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:24:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:24:21 +0000 Subject: [Koha-bugs] [Bug 35197] Expose additional fields through REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158577|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 159648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159648&action=edit Bug 35197: Add additional_fields REST API endpoint Test plan: 1) Apply patch, restart plack 'koha-plack --restart kohadev' 2) Visit /api/v1/additional_fields?tablename=aqinvoices - Notice its empty 3) Visit /cgi-bin/koha/admin/additional-fields.pl?tablename=aqbasket and add a new additional field 4) Do step 2) again - Notice the newly created additional field is there 5) Visit /cgi-bin/koha/admin/additional-fields.pl?tablename=aqinvoices and add a new additional field for invoices 6) Do step 2) again - Notice both additional fields are there 7) Visit /api/v1/additional_fields?tablename=aqinvoices - Notice only the additional field for aqinvoices is listed Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:24:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:24:24 +0000 Subject: [Koha-bugs] [Bug 35197] Expose additional fields through REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158578|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 159649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159649&action=edit Bug 35197: Add tests prove t/db_dependent/api/v1/additional_fields.t Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:24:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:24:26 +0000 Subject: [Koha-bugs] [Bug 35197] Expose additional fields through REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 --- Comment #11 from Martin Renvoize --- Created attachment 159650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159650&action=edit Bug 35197: Field name consistency This patch adds a to_api_mapping and updates the yaml definitions to be ensure we are consistent with modern best practice for our api field names. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:26:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:26:00 +0000 Subject: [Koha-bugs] [Bug 35197] Expose additional fields through REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 --- Comment #12 from Martin Renvoize --- I updated the mappings to be more consistent with the communities agreed guidelines.. though it raised lots of little questions for me.. I'm wondering how often our embeded extended_attributes are going to really look like the spec here. Sending Tomas's way for final QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:26:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:26:08 +0000 Subject: [Koha-bugs] [Bug 35197] Expose additional fields through REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35197 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:34:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:34:58 +0000 Subject: [Koha-bugs] [Bug 21329] Add additional fields to purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329 library_jane changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.henshaw at lcm.ac.uk --- Comment #8 from library_jane --- Custom fields for the purchase suggestion form would be wonderful. Firstly, we're often asked for music materials in different formats and it would be good to have a free-text field to ask a specific question (rather than relying on 'notes') and we'd also like requesters to specify which course module something is for - if a field could be added that linked to an authorised value that we use for additional fields in aqbasket, even better! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:36:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:36:23 +0000 Subject: [Koha-bugs] [Bug 35506] selenium/regressions.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35506 --- Comment #3 from Katrin Fischer --- Failing again with today's run: https://jenkins.koha-community.org/job/Koha_Master/2762/ t_db_dependent_selenium_regressions_t.Display circulation table correctly (344) t_db_dependent_selenium_regressions_t.Encoding in session variables (344) t_db_dependent_selenium_regressions_t.Number of runned tests does not match plan. (344) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:37:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:37:04 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #1 from Katrin Fischer --- Failing again with today's run: https://jenkins.koha-community.org/job/Koha_Master/2762/ t_db_dependent_TestBuilder_t.build_sample_biblio() tests (2071) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:50:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:50:23 +0000 Subject: [Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #29 from Martin Renvoize --- Awesome.. I knew it was something silly when catching the exception! That gives me enough to get going again :), thanks David -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 14:56:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 13:56:42 +0000 Subject: [Koha-bugs] [Bug 31361] Button batch operations disappears when alias is used for itemnumber of biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31361 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/767 Documentation|Aude Charillon |Benjamin Daeuber contact| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 15:43:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 14:43:46 +0000 Subject: [Koha-bugs] [Bug 30645] Generated DBIC query incorrect for api searches across joined extended attributes when several terms are passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 15:43:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 14:43:49 +0000 Subject: [Koha-bugs] [Bug 30645] Generated DBIC query incorrect for api searches across joined extended attributes when several terms are passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159414|0 |1 is obsolete| | --- Comment #10 from Pedro Amorim --- Created attachment 159651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159651&action=edit Bug 30645: Consider multiple instances of extended_attributes in query params This will rewrite a query like: { "-and":[ [ { "extended_attributes.value":{ "like":"abc%" }, "extended_attributes.code":[ [ "arbitrary_attr_code", "another_attr_code" ] ] } ], [ { "extended_attributes.value":{ "like":"123%" }, "extended_attributes.code":[ [ "arbitrary_attr_code", "another_attr_code" ] ] } ] ] } To: { "-and":[ [ { "extended_attributes.value":{ "like":"abc%" }, "extended_attributes.code":[ [ "arbitrary_attr_code", "another_attr_code" ] ] } ], [ { "extended_attributes_2.value":{ "like":"123%" }, "extended_attributes_2.code":[ [ "arbitrary_attr_code", "another_attr_code" ] ] } ] ] } And it'll also add the number of required 'join' attributes to the query attributes to match it. Test plan (with Joubu's test patch applied), run: prove t/db_dependent/selenium/patrons_search.t Or Test plan, k-t-d: 1) Create 2 patron attributes, visit: /cgi-bin/koha/admin/patron-attr-types.pl 2) Name the first attribute 'test1' and the second attribute 'test2' 3) On both, tick the 'Searchable' and 'Search by default' checkboxes 4) Edit a koha borrower, example visit: /cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 5) Put '123' on the test1 attribute, and 'abc' on the test2 attribute 6) Visit the main patrons page: /cgi-bin/koha/members/members-home.pl 7) On the first left side filter input called 'Search', type '123' and search. Notice you get the patron result 8) Repeat step 7, but type 'abc' instead of '123'. Notice you get the patron result 9) Now do the same search but type '123 abc'. Notice you do not get the patron result. 10) Apply patch. Repeat test plan. Notice you get the patron result in step 9). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 15:45:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 14:45:13 +0000 Subject: [Koha-bugs] [Bug 34677] Update to MARC21 relator terms list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34677 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #28 from Caroline Cyr La Rose --- Nothing to document here, that I can see. Feel free to reopen with more details if I'm wrong! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 15:45:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 14:45:41 +0000 Subject: [Koha-bugs] [Bug 34679] Description for RELTERMS authorized value category is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34679 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/768 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 15:52:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 14:52:17 +0000 Subject: [Koha-bugs] [Bug 30645] Generated DBIC query incorrect for api searches across joined extended attributes when several terms are passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159651|0 |1 is obsolete| | --- Comment #11 from Pedro Amorim --- Created attachment 159652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159652&action=edit Bug 30645: Consider multiple instances of extended_attributes in query params This will rewrite a query like: { "-and":[ [ { "extended_attributes.value":{ "like":"abc%" }, "extended_attributes.code":[ [ "arbitrary_attr_code", "another_attr_code" ] ] } ], [ { "extended_attributes.value":{ "like":"123%" }, "extended_attributes.code":[ [ "arbitrary_attr_code", "another_attr_code" ] ] } ] ] } To: { "-and":[ [ { "extended_attributes.value":{ "like":"abc%" }, "extended_attributes.code":[ [ "arbitrary_attr_code", "another_attr_code" ] ] } ], [ { "extended_attributes_2.value":{ "like":"123%" }, "extended_attributes_2.code":[ [ "arbitrary_attr_code", "another_attr_code" ] ] } ] ] } And it'll also add the number of required 'join' attributes to the query attributes to match it. Test plan (with Joubu's test patch applied), run: prove t/db_dependent/selenium/patrons_search.t Or Test plan, k-t-d: 1) Create 2 patron attributes, visit: /cgi-bin/koha/admin/patron-attr-types.pl 2) Name the first attribute 'test1' and the second attribute 'test2' 3) On both, tick the 'Searchable' and 'Search by default' checkboxes 4) Edit a koha borrower, example visit: /cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 5) Put '123' on the test1 attribute, and 'abc' on the test2 attribute 6) Visit the main patrons page: /cgi-bin/koha/members/members-home.pl 7) On the first left side filter input called 'Search', type '123' and search. Notice you get the patron result 8) Repeat step 7, but type 'abc' instead of '123'. Notice you get the patron result 9) Now do the same search but type '123 abc'. Notice you do not get the patron result. 10) Apply patch. Repeat test plan. Notice you get the patron result in step 9). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 16:04:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 15:04:57 +0000 Subject: [Koha-bugs] [Bug 28869] If authorized values for STACK (shelving control number) are > 127 things explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #4 from Marcel de Rooy --- The promised comment is still coming btw. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 16:09:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 15:09:11 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 --- Comment #12 from Hammat wele --- Created attachment 159653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159653&action=edit Bug 33317: (follow-up) Perltidy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 16:10:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 15:10:50 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Hammat wele changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 16:25:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 15:25:05 +0000 Subject: [Koha-bugs] [Bug 28869] If authorized values for STACK (shelving control number) are > 127 things explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #5 from Marcel de Rooy --- Just some related questions here. Should we save authorised_values.id in connected fields? Perhaps theoretically, but it does not sound very practical at this point in our codebase. So NO. Should we adjust other item fields that are of integer type connected to AV where the same problem actually may occur? Move them all to varchar(80)? It feels a bit like overkill? These are: | stack | tinyint(1) | # on this report | notforloan | tinyint(1) | | damaged | tinyint(1) | | itemlost | tinyint(1) | | withdrawn | tinyint(1) | | restricted | tinyint(1) | IF doing so, we could look at default values. They are not completely consistent, since damaged and withdrawn default to 0. `restricted` tinyint(1) DEFAULT NULL COMMENT 'authorized value defining use restrictions for this item (MARC21 952$5)', `stack` tinyint(1) DEFAULT NULL, `ccode` varchar(80) DEFAULT NULL COMMENT 'authorized value for the collection code associated with this item (MARC21 952$8)', `location` varchar(80) DEFAULT NULL COMMENT 'authorized value for the shelving location for this item (MARC21 952$c)', I thought about warning for a wrong value in an item field of type integer/date BEFORE saving. Now we can just enter something in various fields, save, get no warning and come back later to discover that our data is lost. E.g. the example of 127 for a higher number. (Coming back as 127 with a warning in the editor.) Or just 0 for a string. But since this originates from AV. We should perhaps add a restriction THERE! Why not add an AV column that allows you to only enter tinyints instead of 80 char codes? If we solve it in AV, there will be no problem in items? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 16:26:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 15:26:56 +0000 Subject: [Koha-bugs] [Bug 28869] If authorized values for STACK (shelving control number) are > 127 things explode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28869 --- Comment #6 from Marcel de Rooy --- Note that things only 'explode' in strict SQL mode probably. Otherwise they are just silently converted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 16:34:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 15:34:16 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #45 from Andrew Fuerste-Henry --- > Normally I've taken your comments into account and removed the "Search > patrons" link from the main search bar... it's only accessible to members > with 'catalog' permission. Unless I've misunderstood, but from my point of > view, with a member who only has the 'list_borrowers' permission, this seems > correct. Hi Thibaud, thanks for your work here! This code will help us a lot. That "Search Patrons" link still shows up and behaves oddly for someone with just list_borrowers permission, but only in one little spot. To see it: - have an account with permissions "Staff access, allows viewing of catalogue in staff interface (catalogue)", "Remaining circulation permissions (circulate_remaining_permissions)", and "Search and list patrons (list_borrowers)" - Go to the checkout screen on any patron record (/cgi-bin/koha/circ/circulation.pl?borrowernumber=) - Click "Routing Lists" in the menu on the left of the screen - That takes you to /cgi-bin/koha/members/routing-lists.pl?borrowernumber= - "Search patrons" shows in the search bar, with no search field displayed while "Search patrons" is selected. I realize this is a really minor display issue on one page few users look at. I'm going to go ahead and sign off on this because it works in every other way. I'm happy to sign off again if you have a chance to change that page, or we can worry about it on a follow-up bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 16:34:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 15:34:38 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159633|0 |1 is obsolete| | --- Comment #46 from ByWater Sandboxes --- Created attachment 159654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159654&action=edit Bug 30230: Add new 'list_borrowers' permission When a patron search is performed only a user with edit_borrowers permission can search by name. Search can works only with cardnumber but it makes searching less intuitive I think. So, as mentioned in the discussion, I've added a new 'list_borrowers' permission, completely independent of 'edit_borrowers', so that I can search for a member via the interface and get the results. In addition to the permission to perform check in and checkouts, this no longer poses an obstacle to simple use. Test plan: 1) Check with a user without 'edit_borrowers' permission that the patron search can only be performed with cardnumber 2) Apply this patch 3) Make the updatedatabase to add new 'list_borrowers' permissions 4) Set 'list_borrowers' permission on one user and see the difference Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 16:35:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 15:35:04 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 17:04:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 16:04:16 +0000 Subject: [Koha-bugs] [Bug 34075] Allow specifying default tab view for authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34075 Michelle Spinney changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 17:04:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 16:04:24 +0000 Subject: [Koha-bugs] [Bug 35514] New: Total prices not updated when importing records from staged file with multiple items added Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Bug ID: 35514 Summary: Total prices not updated when importing records from staged file with multiple items added Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: thibaud.guillot at biblibre.com QA Contact: testopia at bugs.koha-community.org Hello everyone, When you add an order line to a basket from a staged file, on the neworderempty.pl page during entry the prices are correctly calculated when you add item one by one, but if you add multiple items simultaneously the total costs are not updated and adding the line leads to having the prices set to 0. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 17:04:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 16:04:29 +0000 Subject: [Koha-bugs] [Bug 35514] Total prices not updated when importing records from staged file with multiple items added In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |thibaud.guillot at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 17:13:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 16:13:13 +0000 Subject: [Koha-bugs] [Bug 35514] Total prices not updated when importing records from staged file with multiple items added In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 17:13:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 16:13:15 +0000 Subject: [Koha-bugs] [Bug 35514] Total prices not updated when importing records from staged file with multiple items added In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35514 --- Comment #1 from Thibaud Guillot --- Created attachment 159656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159656&action=edit Bug 35514: Fix costs update when adding multiple items from staged file Test plan: 1) Stage a file with records 2) Create a basket and add order line from imported records to go on neworderempty.pl 3) Choose to add one item and repeat the operation 4) See on form that the total cost is updated without update vendor price 5) Now add multiple items, for example, "2" you will see that the total cost is not updated and if you save "0" price will be set 6) Apply this patch and repeat step 5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 17:36:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 16:36:40 +0000 Subject: [Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Owen Leonard --- The qa tool still has complaints about the atomicupdate. Please take another look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 17:38:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 16:38:52 +0000 Subject: [Koha-bugs] [Bug 31361] Button batch operations disappears when alias is used for itemnumber of biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31361 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 17:40:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 16:40:43 +0000 Subject: [Koha-bugs] [Bug 35108] ILL - "Manage request" page is too loaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 17:52:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 16:52:28 +0000 Subject: [Koha-bugs] [Bug 35108] ILL - "Manage request" page is too loaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 17:52:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 16:52:31 +0000 Subject: [Koha-bugs] [Bug 35108] ILL - "Manage request" page is too loaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157463|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim --- Created attachment 159657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159657&action=edit Bug 35108: Move request id to page header Redundant information, can be moved to header for more visibility and less horizontal length -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 17:52:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 16:52:33 +0000 Subject: [Koha-bugs] [Bug 35108] ILL - "Manage request" page is too loaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157464|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim --- Created attachment 159658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159658&action=edit Bug 35108: Hide optionally empty fields label entries, these are: orderid, biblio_id, batch already was the case, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 17:56:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 16:56:34 +0000 Subject: [Koha-bugs] [Bug 33284] checkout_renewals table retains checkout history in violation of patron privacy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #17 from Andrew Fuerste-Henry --- Hi all, giving this bug a bump as it continues to force us to keep patron circulation history in violation of their privacy selection. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 18:15:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 17:15:51 +0000 Subject: [Koha-bugs] [Bug 35151] Convert ILLModuleCopyrightClearance system preference to additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35151 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 18:15:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 17:15:54 +0000 Subject: [Koha-bugs] [Bug 35151] Convert ILLModuleCopyrightClearance system preference to additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35151 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158741|0 |1 is obsolete| | --- Comment #8 from Pedro Amorim --- Created attachment 159659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159659&action=edit Bug 35151: Convert ILLModuleCopyrightClearance system preference to additional contents This patch moves the ILLModuleCopyrightClearance system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the ILLModuleCopyrightClearance system preference before applying the patch. Apply the patch, run the database update process, and rebuild the OPAC CSS. - In the staff client, go to Tools -> HTML customizations and verify that the content from ILLModuleCopyrightClearance is now stored there. - The HTML customization entry form should offer ILLModuleCopyrightClearance as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Enable the "opaclanguagesdisplay" preference if necessary. - Edit the ILLModuleCopyrightClearance HTML customization and add unique content to the "fr-FR" tab. - Enable the "ILLModule" and "ILLModuleUnmediated" system preferences if necessary. You must have at least one ILL backend installed. - Log into the OPAC and click the "Interlibrary loan requests" in the sidebar menu on the user summary page. - Click "Create new request." - You should be taken to a page with your ILLModuleCopyrightClearance content shown along with "Yes" and "No" buttons. - Clicking "Yes" should take you to the form for creating a new request. - Switch to your updated translation and confirm that the content appears correctly. - Remove all "ILLModuleCopyrightClearance" html customizations. Test the "Create new request" process in the OPAC again. - There should be no confirmation step before arriving at the form for creating a new ILL request. - Go to Administration -> System preferences and search for "ILLModuleCopyrightClearance." It should return no results. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 18:20:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 17:20:33 +0000 Subject: [Koha-bugs] [Bug 35151] Convert ILLModuleCopyrightClearance system preference to additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35151 --- Comment #9 from Pedro Amorim --- This is great, not only the language specific but also library specific option. My only minor concern (not about this patch) is that, before, ILL related options where somewhat exclusive to sys prefs, now it's sys prefs and html customizations (among others, like ILL batch statuses in the Koha admin) but this relates to a different problem, one that could maybe be addressed by having an ILL config dedicated admin page where all ILL related configs would be accessible through that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 18:24:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 17:24:28 +0000 Subject: [Koha-bugs] [Bug 35515] New: Change occurences of "Global system preferences" to "System preferences" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35515 Bug ID: 35515 Summary: Change occurences of "Global system preferences" to "System preferences" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: Needs documenting Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: aude.charillon at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org With Bug 33673, Administration > Global system preferences became Administration > System preferences. We need to update this on all pages of the manual. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 18:24:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 17:24:28 +0000 Subject: [Koha-bugs] [Bug 33673] Global system preferences - change to just system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33673 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35515 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 18:26:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 17:26:15 +0000 Subject: [Koha-bugs] [Bug 35516] New: OPAC search results incorrectly displays order when skipping lost items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35516 Bug ID: 35516 Summary: OPAC search results incorrectly displays order when skipping lost items Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: esther.melander at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 159660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159660&action=edit Lost item is skipped in ordered list. To recreate: 1. Ensure the system preference hidelostitems is set to don't show. 2. Search the staff interface using search catalog with a term that returns several results. Select a bib record with an item and change the status to lost. (In my example, I choose an item in the 4th result). 3. Do a search in the OPAC for the same term. See that the results are ordered in the list 1, 2, 3, 5, 6. The system preference is doing its job and hiding the lost item. However, the results should be ordered 1, 2, 3, 4, 5, etc., and not indicate that an item was skipped or suppressed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 18:26:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 17:26:35 +0000 Subject: [Koha-bugs] [Bug 35515] Change occurences of "Global system preferences" to "System preferences" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35515 --- Comment #1 from Aude Charillon --- It would be worth doing a proper search to check for occurences. As an example, all the preferences pages (e.g. Acquisitions) start with: "Get there: More > Administration > Global system preferences > Acquisitions" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 18:37:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 17:37:40 +0000 Subject: [Koha-bugs] [Bug 35515] Change occurences of "Global system preferences" to "System preferences" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35515 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose --- If you have a local copy, you can do the following command to find all the occurrences git grep -i "Global system preferences" caroline at ahuntsic[12:36:27](master-dev)/inlibro/git/koha-manual/source$ git grep -i "Global system preferences" accountspreferences.rst:*Get there:* More > Administration > Global system preferences > acquisitionspreferences.rst:*Get there:* More > Administration > Global system preferences > Acquisitions administrationpreferences.rst:*Get there:* More > Administration > Global system preferences > authoritiespreferences.rst:*Get there:* More > Administration > Global system preferences > catalogingpreferences.rst:*Get there:* More > Administration > Global system preferences > circulationpreferences.rst:*Get there:* More > Administration > Global system preferences > Circulation enhancedcontentpreferences.rst:*Get there:* More > Administration > Global system preferences > ermpreferences.rst:- Get there: More > Administration > Global System Preferences > E-Resource management i18npreferences.rst:*Get there:* More > Administration > Global system preferences > illpreferences.rst:*Get there:* More > Administration > Global system preferences > Interlibrary intro.rst:*Get there:* More > Administration > Global system preferences localusepreferences.rst:*Get there:* More > Administration > Global system preferences > Local logspreferences.rst:*Get there:* More > Administration > Global system preferences > Logs opacpreferences.rst:*Get there:* More > Administration > Global system preferences > OPAC patronspreferences.rst:*Get there:* More > Administration > Global system preferences > Patrons searchingpreferences.rst:*Get there:* More > Administration > Global system preferences > serialspreferences.rst:*Get there:* More > Administration > Global system preferences > Serials staffclientpreferences.rst:*Get there:* More > Administration > Global system preferences > Staff toolspreferences.rst:*Get there:* More > Administration > Global system preferences > Tools webservicespreferences.rst:*Get there:* More > Administration > Global system preferences > Web -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 19:14:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 18:14:20 +0000 Subject: [Koha-bugs] [Bug 35517] New: Choose correct default header search tab according to permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 Bug ID: 35517 Summary: Choose correct default header search tab according to permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org On the staff interface home page the default header search box is the checkout one. But if the user doesn't have circulation permission the search tabs are initially hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 19:29:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 18:29:15 +0000 Subject: [Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 19:29:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 18:29:17 +0000 Subject: [Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 --- Comment #1 from Owen Leonard --- Created attachment 159661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159661&action=edit Bug 35517: Choose correct default header search tab according to permissions This patch adds some additional template logic to the header search form for the staff interface home page so that users with different permissions will see the correct tab in the header search form. To test, apply the patch and view the staff interface home page using a user with different permissions: - 'catalogue' and 'circulate' - Header should show circulation search - 'catalogue' and 'borrowers' - Header should show patron search - 'catalogue' only - Header should show catalog search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 19:29:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 18:29:46 +0000 Subject: [Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 19:29:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 18:29:49 +0000 Subject: [Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159527|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 159662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159662&action=edit Bug 35476: Make 'Submit' buttons translatable in vue components Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 19:31:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 18:31:47 +0000 Subject: [Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 --- Comment #5 from David Nind --- (In reply to Jonathan Druart from comment #3) > Hi David, > I cannot test right now, but you need: > 8. Apply the patch > 9. yarn build (or simply yarn js:build) > 10. restart_all (JS translations are cached in memcached) > > That should be enough. Thanks Jonathan! That worked. Simplified test plan: 1. Install another language, for example: koha-translate --install es-ES --dev kohadev 2. Enable the language for the staff interface (Administration > System preferences > I18N/L10N > language) 3. Enable the ERM module (ERMModule) 4. Change the language to the one you installed 5. Go to E-resource management > eHoldings > Local > Packages > +New package 6. Note that the submit button is not translated (for +New package it is Submit instead of Enviar for es-ES) (Compare to one of the other submit buttons that is translated correctly (E-resource management > Agreements > +New agreement) 7. Apply the patch, yarn js:build, restart_all 8. Repeat step 5 - the submit button is now translated! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 19:38:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 18:38:13 +0000 Subject: [Koha-bugs] [Bug 35476] Submit button for adding new processings is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35476 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes some submit release notes| |buttons in the ERM and | |Preservation modules so | |that are now translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 19:42:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 18:42:33 +0000 Subject: [Koha-bugs] [Bug 35516] OPAC search results incorrectly displays order when skipping lost items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35516 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 19:54:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 18:54:31 +0000 Subject: [Koha-bugs] [Bug 35327] Fix capitalization of language name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the release notes| |capitalization of English | |(english -> English) in the | |ILS_DI GetAvailability | |information page | |(:/cgi-bi | |n/koha/ilsdi.pl?service=Des | |cribe&verb=GetAvailability) | |. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 19:57:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 18:57:28 +0000 Subject: [Koha-bugs] [Bug 35387] Capitalization: Labels in preservation module are not capitalized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35387 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the release notes| |capitalization of some | |label names in the | |Preservation module (name | |-> Name, and barcode -> | |Barcode). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 19:59:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 18:59:26 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This updates the default |This updates the default release notes|staff interface and OPAC |staff interface and OPAC |XSLT files so that "Online |XSLT files so that "Online |resources" is used as the |resources" is used as the |label in search results for |label in search results for |filed 856 - Electronic |field 856 - Electronic |Location and Access, |Location and Access, |instead of "Online access". |instead of "Online access". |This matches the label used |This matches the label used |in the detail page for a |in the detail page for a |record. |record. | | |It also adjusts |It also adjusts |the CSS class so OPAC and |the CSS class so OPAC and |staff interface both use |staff interface both use |online_resources. |online_resources. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 20:08:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 19:08:42 +0000 Subject: [Koha-bugs] [Bug 35505] Add specific selectors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35505 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 20:58:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 19:58:53 +0000 Subject: [Koha-bugs] [Bug 35436] Copy is not translatable in OPAC search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159468|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo --- Created attachment 159663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159663&action=edit Bug 35436: Copy is not translatable in OPAC Search History Test plan 1 Enter in OPAC Search History in a language other than English and check that Copy is not translated 2 Apply patch, restart services 3 Regenerate the templates for that language 4 Repeat step 1 and check that Copy appears now translated Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 20:59:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 19:59:05 +0000 Subject: [Koha-bugs] [Bug 35436] Copy is not translatable in OPAC search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #9 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 21:03:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 20:03:33 +0000 Subject: [Koha-bugs] [Bug 34091] Typo in help for cleanupdatabase.pl: --log-modules needs to be --log-module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34091 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159480|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 159664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159664&action=edit Bug 34091: Fix typo log-modules in help for cleanupdatabase.pl This parameter is actually --log-module. Test plan : Run misc/cronjobs/cleanup_database.pl -h Confirm you see --log-module Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 21:04:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 20:04:30 +0000 Subject: [Koha-bugs] [Bug 34091] Typo in help for cleanupdatabase.pl: --log-modules needs to be --log-module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34091 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor at tuxayo.net --- Comment #4 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 21:16:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 20:16:26 +0000 Subject: [Koha-bugs] [Bug 35449] Accessibility: No links on "here" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159481|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 159665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159665&action=edit Bug 35449: Accessibility: No links on "here" This patch updates two system preferences, "OPACUserJS" and "OPACUserCSS" so that the "here" links in the description instead read "library administration". To test, apply the patch and go to Administration -> System preferences. - Search for "opacuser" - The descriptions of the "OPACUserJS" and "OPACUserCSS" preferences should include the phrase "...can be defined in library administration," with "library administration" leading to the correct page. Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 21:16:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 20:16:52 +0000 Subject: [Koha-bugs] [Bug 35449] Accessibility: No links on "here" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 21:23:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 20:23:22 +0000 Subject: [Koha-bugs] [Bug 35450] Preservation system preferences should authval dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159482|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 159666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159666&action=edit Bug 35450: Preservation system preferences should authval dropdowns This patch updates two preservation module system preferences so that they offer dropdowns of "Not for loan" values instead of requiring entry of a specific code. The patch also adds a missing "." at the end of one preference description. To test, apply the patch and restart services. - Go to Administration -> System preferences. - Search for "preservation" - Check that the "PreservationNotForLoanDefaultTrainIn" and "PreservationNotForLoanWaitingListIn" preferences have dropdowns offering "Not for loan" values. - Confirm that your choices are correctly saved. Signed-off-by: Barbara Johnson Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 21:25:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 20:25:09 +0000 Subject: [Koha-bugs] [Bug 35450] Preservation system preferences should authval dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Status|Signed Off |Passed QA CC| |victor at tuxayo.net --- Comment #5 from Victor Grousset/tuxayo --- Good catch, it was possible to save any value in the syspref 💥 :o Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 21:26:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 20:26:18 +0000 Subject: [Koha-bugs] [Bug 34573] Inconsistencies in acquisitions modify vendor title tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34573 --- Comment #10 from David Nind --- I thought I might have caused it, but it is something to do with line 150 (after the patches are applied) - that text appears in the HTML page title if you add a new vendor or modify an existing vendor. I don't understand how it works enough to fix it 8-(. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 21:26:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 20:26:37 +0000 Subject: [Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 Esther Melander changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander at bywatersolu | |tions.com --- Comment #39 from Esther Melander --- To add a wrinkle to this discussion. OCLC is using $0 in authority records, perhaps as intended with linking information. An example authority: Conduct of life. $2 fast $0 (OCoLC)fst00874563 In this case, a library wants to retain this subfield as a reference point. It would cause a conflict if a library is using $0 for internal linking and brought in a record which contains reference data in this field for a different system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 21:58:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 20:58:36 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | --- Comment #18 from Victor Grousset/tuxayo --- These are very nice improvements, much cleaner :) After comparing the pages before and after the patches, here is the relevant thing I've found: There is no more mention of FileSaver library despite it being included in cateditor-ui.inc and lib/datatables/datatables.js Mistake or good reason? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:04:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:04:01 +0000 Subject: [Koha-bugs] [Bug 35518] New: Call to C4::Context->userenv happens before it's gets populated breaks code logic Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518 Bug ID: 35518 Summary: Call to C4::Context->userenv happens before it's gets populated breaks code logic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: slavashishkin at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, nugged at gmail.com Depends on: 17798 We getting results from `C4::Context->userenv` on line 72: my $userenv = C4::Context->userenv; but `C4::Context->userenv` gets populated only far below in `get_template_and_user` call, line 142, this means that everything that we getting further from `$userenv` is empty. And more, because autovivification occurs for the `$userenv` at line 73: my $branch = $userenv->{'branch'} // ''; that does not cause any visible errors, but it causes malfunctions at places where $branch, $desk_id is used, and also where $userenv is accessed, at line 153: if (!C4::Auth::haspermission( $userenv->{id} , { circulate => 'force_checkout' } ) ). To check that we have undef and it gets autovivificated, let's add some dumps into code when we open any borrower, e.g. /cgi-bin/koha/circ/circulation.pl?borrowernumber=19, Let's dump $userenv before and after `$branch = $userenv->{'branch'} // '';` line: 72 my $userenv = C4::Context->userenv; 73 use Data::Dumper; 74 warn __LINE__, ' ', Dumper($userenv); 75 my $branch = $userenv->{'branch'} // ''; 76 warn __LINE__, ' ', Dumper($userenv); this gives in server logs: 74 $VAR1 = undef; 76 $VAR1 = {}; and also to check when `C4::Context->userenv` gets its real values, let's dump before and after the `get_template_and_user()` call at line 142 (line 145 if to continue above dumps code): 145 warn __LINE__, ' ', Dumper([C4::Context->userenv]); 146 my ( $template, $loggedinuser, $cookie ) = get_template_and_user ( ... 153 ); 154 warn __LINE__, ' ', Dumper([C4::Context->userenv]); this gives in server logs: 145 $VAR1 = []; 154 $VAR1 = [ { ... 'id' => 'admin', ... } ]; what depicts the whole bug. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:04:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:04:01 +0000 Subject: [Koha-bugs] [Bug 17798] Checking out an item on hold for another patron prints a slip but does not update hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17798 Slava Shishkin changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35518 [Bug 35518] Call to C4::Context->userenv happens before it's gets populated breaks code logic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:09:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:09:32 +0000 Subject: [Koha-bugs] [Bug 29438] Importing a record with an ISBN13 with no ISBN10 counterpart does not save the ISBN In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29438 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass --- Any ISBN prefixed with 979 cannot be converted to an ISBN10. An 979 ISBN will also not pass the check here: if ( $isbn && $isbn->is_valid() ) For example: use Business::ISBN; my $isbn = Business::ISBN->new(9798986969305); warn Data::Dumper::Dumper($isbn->is_valid); this returns an empty string for $isbn->is_valid -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:16:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:16:17 +0000 Subject: [Koha-bugs] [Bug 35327] Fix capitalization of language name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35327 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin Somers --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:17:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:17:27 +0000 Subject: [Koha-bugs] [Bug 35378] 'This authority type is used {count} times' missing dot In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35378 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin Somers --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:18:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:18:24 +0000 Subject: [Koha-bugs] [Bug 35387] Capitalization: Labels in preservation module are not capitalized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35387 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Patch complexity|--- |String patch --- Comment #9 from Fridolin Somers --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:19:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:19:04 +0000 Subject: [Koha-bugs] [Bug 35441] Typo 'UniqueItemsFields' system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35441 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:19:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:19:52 +0000 Subject: [Koha-bugs] [Bug 35376] Rephrase: Be careful removing attribute to this processing, the items using it will be impacted as well! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35376 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.01 released in| | Patch complexity|--- |String patch Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:20:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:20:28 +0000 Subject: [Koha-bugs] [Bug 35412] Capitalization: Toggle Dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35412 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.01 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:21:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:21:13 +0000 Subject: [Koha-bugs] [Bug 35404] Wrong copy and paste in string (ILL batches) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35404 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Patch complexity|--- |String patch --- Comment #8 from Fridolin Somers --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:22:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:22:12 +0000 Subject: [Koha-bugs] [Bug 35415] Rephrase: Some patrons have requested a privacy ... In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35415 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.01 released in| | --- Comment #8 from Fridolin Somers --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:23:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:23:04 +0000 Subject: [Koha-bugs] [Bug 35453] Wrong 'Laserdisc)' string on 007 builder (MARC21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35453 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.01 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:24:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:24:24 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #14 from Fridolin Somers --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:25:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:25:43 +0000 Subject: [Koha-bugs] [Bug 35383] Dragging and dropping subfield of repeated tags doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:29:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:29:55 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #19 from Victor Grousset/tuxayo --- Also, no entry for DataTables itself. Is there a reason or should I open a ticket to report it? Some opinions about: (In reply to David Nind from comment #17) > Questions for other bugs, if required: > - Should the version of a piece of software be shown? A few do. Might be tough to be reliably maintained. Maybe not actually, it's not often to have library updates and a QA guideline to remind to keep the about page up to date would do. > - Should we have a short description of what they do, where they are used in > Koha? Maybe, if someone wants to volunteer to implement it why not. Or maybe we prefer to spare any new string for translators unless necessary? Or even a few dozen are not a big deal? > - Should we change to a bullet list? > - Versions of libraries: many seem quite old or not updated for a while. > . Should I create an omnibus bug to update? Now that you remention it, it might have enough value as a technical documentation. Both for regular development and when looking at security issues. Oops, I understood that as creating a ticket to add the version for all libraries. Answer to your question comes later down. > . Should we update all libraries used at the start of a cycle? (The > biggies, such as Bootstrap and jQuery, might be more problematic.) Even the small ones, multiple of them might need to test and tweak a lot of pages. So overall it might be equivalent like if we had another (or multiple more?) Bootstrap, jQuery, datatable. > . Or do we have a "if it isn't broken, don't fix it" approach, unless > there are security updates? Seems like the current situation due to limited resources. It's seems hard enough at the moment to keep the biggies up to date. Unless there is some spare capacity after catching up for security, compatibility, big bugfixes. Until then it's tough to plan for general updates of the rest. If someone needs a new feature or just has an itch for updating a library it can still happen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 22:50:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 21:50:47 +0000 Subject: [Koha-bugs] [Bug 35519] New: apt install koha-common has error with koha-l10n Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35519 Bug ID: 35519 Summary: apt install koha-common has error with koha-l10n Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com Tomas said he saw this too, so it's not my (really Kyle's) custom package. :) Installing koha-common with apt install koha-common= with 23.05.06 over the top of an older version errors out as follows: dpkg: error processing archive /tmp/apt-dpkg-install-tZKDjI/062-koha-l10n_23.05.06-1_all.deb (--unpack): trying to overwrite '/usr/share/koha/misc/translator/po/am-Ethi-installer-MARC21.po', which is also in package koha-common 23.05.05 This can be fixed by running apt install -f and subsequent installs are ok. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 7 23:02:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 22:02:22 +0000 Subject: [Koha-bugs] [Bug 34900] The translation of the string "The " should depend on context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 --- Comment #20 from David Nind --- (In reply to Victor Grousset/tuxayo from comment #18) > These are very nice improvements, much cleaner :) > > After comparing the pages before and after the patches, here is the relevant > thing I've found: > There is no more mention of FileSaver library despite it being included in > cateditor-ui.inc and lib/datatables/datatables.js > > Mistake or good reason? After a quick look, that looks like a mistake, so should be added back in. I've just had a quick look (not comprehensive), and it looks like there are some software licences missing, including: - DataTables (koha-tmpl/intranet-tmpl/lib/datatables) - GreyBox (koha-tmpl/intranet-tmpl/lib/greybox) - Some jQuery plugins - jsTree, rowGroup (doesn't look the same as jquery.dataTables.grouping.js), fnReloadAjax (part of DataTables?), Humanized Messages, jquery.dataTables.columnFilter.js (part of DataTables?), highlight (part of DataTables?), jquery-jeditable (koha-tmpl/intranet-tmpl/lib/jquery/plugins/) - linters (several) (koha-tmpl/intranet-tmpl/lib/linters) - sortable (koha-tmpl/intranet-tmpl/lib/linters/sortable) - vis-timeline and vis-graph2d (koha-tmpl/intranet-tmpl/lib/vis-timeline/) - media.match.js (koha-tmpl/opac-tmpl/lib/) Maybe this should be a separate bug to review what is used and add any missing ones? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 00:31:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Dec 2023 23:31:39 +0000 Subject: [Koha-bugs] [Bug 24889] Sort subscription in opac view : closed vs open In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24889 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer at bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 04:26:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 03:26:07 +0000 Subject: [Koha-bugs] [Bug 35104] We should warn when attempting to save MARC records that contain characters invalid in XML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35104 --- Comment #30 from David Cook --- (In reply to Martin Renvoize from comment #29) > Awesome.. I knew it was something silly when catching the exception! > > That gives me enough to get going again :), thanks David Yay teamwork! :D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 04:43:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 03:43:42 +0000 Subject: [Koha-bugs] [Bug 35410] 856 label is inconsistent between detail page and search results in XSLTs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 --- Comment #15 from David Cook --- (In reply to Katrin Fischer from comment #13) > Note: I like the consistency of the change to the class, but it could have > some side effects for existing CSS. I decided to push, because the change is > in the staff interface, not in the OPAC. I was thinking the same thing. Initially, I thought we should've kept the existing class and added the new one, but then I figured since it's the staff interface people can just update on upgrade as needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 08:21:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 07:21:48 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #14 from Marcel de Rooy --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 09:03:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 08:03:18 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159654|0 |1 is obsolete| | --- Comment #47 from Emmi Takkinen --- Created attachment 159667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159667&action=edit Bug 30230: Add new 'list_borrowers' permission When a patron search is performed only a user with edit_borrowers permission can search by name. Search can works only with cardnumber but it makes searching less intuitive I think. So, as mentioned in the discussion, I've added a new 'list_borrowers' permission, completely independent of 'edit_borrowers', so that I can search for a member via the interface and get the results. In addition to the permission to perform check in and checkouts, this no longer poses an obstacle to simple use. Test plan: 1) Check with a user without 'edit_borrowers' permission that the patron search can only be performed with cardnumber 2) Apply this patch 3) Make the updatedatabase to add new 'list_borrowers' permissions 4) Set 'list_borrowers' permission on one user and see the difference Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 09:07:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 08:07:21 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #48 from Emmi Takkinen --- Signing off, since this change is much needed and patch works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 09:26:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 08:26:41 +0000 Subject: [Koha-bugs] [Bug 35519] apt install koha-common has error with koha-l10n In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35519 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 09:29:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 08:29:51 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 --- Comment #15 from Marcel de Rooy --- Still some issues here: Template process failed: undef error - The given date (0NaN-aN-aN) does not match the date format (iso) at /usr/share/koha/Koha/DateUtils.pm line 205. => Try another date format like dd-mm-yy => var formatted_date = flatpickr.formatDate(new Date(itm_text), "Y-m-d") does not look good. Still looking further -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 09:47:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 08:47:09 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #49 from Thibaud Guillot --- Created attachment 159668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159668&action=edit Bug 30230 : (follow-up) Fix display issue on search bar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 09:48:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 08:48:09 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #50 from Thibaud Guillot --- Thank you all for this time of testing and feedback. I think I've managed to fix the display problem Andrew was talking about. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 10:23:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 09:23:03 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 10:23:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 09:23:05 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159077|0 |1 is obsolete| | Attachment #159592|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy --- Created attachment 159669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159669&action=edit Bug 35341: Improve processing hard due date and auto renewal date After quite a struggle, came up with this approach using flatpickr's parseDate and setDate. Seems to be the best. The dateformat variable is set in calendar.inc. Test plan: Test edit, save, clear rules, focus on both dates. Toggle all I18N preference date formats. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 10:23:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 09:23:45 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 10:24:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 09:24:59 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 --- Comment #17 from Marcel de Rooy --- (In reply to Matt Blenkinsop from comment #12) > I've taken your test patch Marcel and made some changes so that it now only > uses flatpickr rather than adding additional hidden inputs to hold the value. > > This feels like a major bug so I think we should get a fix in place for this > ASAP. Let me know what you think and if you agree with the concept I will > address some of the other issues you spotted in follow-up bugs (e.g. > incorrect column indexes etc). Sorry, but it did not work yet. I obsoleted your patch now in favor of adding flatpickr methods on top of the first patch. Could you add your signoff, Matts? And perhaps let Martin do the final QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 10:25:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 09:25:08 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|matt.blenkinsop at ptfs-europe |m.de.rooy at rijksmuseum.nl |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 10:29:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 09:29:29 +0000 Subject: [Koha-bugs] [Bug 35341] Circulation rule dates are being overwritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35341 --- Comment #18 from Marcel de Rooy --- Note that this patch makes sure that the dates are not kept when saving or clearing the rule in the edit row. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 10:41:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 09:41:09 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl CC| |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED --- Comment #2 from Marcel de Rooy --- Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 11:23:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 10:23:43 +0000 Subject: [Koha-bugs] [Bug 35520] New: Add a script to export images from the db Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35520 Bug ID: 35520 Summary: Add a script to export images from the db Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Could be useful both for cover_images and patronimage. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 11:44:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 10:44:04 +0000 Subject: [Koha-bugs] [Bug 35520] Add a script to export images from the db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35520 --- Comment #1 from Magnus Enger --- Or is there a standard way to do this that makes a special script unnecessary? I imagine we want to put things like biblionumber and borrowernumber in the filename, which might make a generic solution har to use. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 12:01:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 11:01:20 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #3 from Marcel de Rooy --- Created attachment 159670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159670&action=edit Bug 35507: Clear cache key for enabled plugins at deletion KitchenSink is still in cache key and causes other tests to fail. Test plan: Install some after_biblio_action plugin. Delete the plugin without this patch. Run t/db_dependent/TestBuilder.t [FAIL] Delete plugin with this patch Run t/db_dependent/TestBuilder.t [PASS] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 12:02:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 11:02:01 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #4 from Marcel de Rooy --- Will still improve the test plan a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 12:06:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 11:06:18 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #5 from Marcel de Rooy --- But it should work: not ok 1 - No encoding warnings! # Failed test 'No encoding warnings!' # at t/db_dependent/TestBuilder.t line 519. # found warning: Failed to load Koha::Plugin::TestItemBarcodeTransform: Could not find or check module 'Koha::Plugin::TestItemBarcodeTransform' at /usr/share/koha/Koha/Plugins.pm line 124. # didn't expect to find a warning # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 12:07:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 11:07:22 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #6 from Marcel de Rooy --- With this patch, Plugins.t will remove KitchenSink from the enabled cache key too, resolving issues in other tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 12:16:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 11:16:10 +0000 Subject: [Koha-bugs] [Bug 35520] Add a script to export images from the db In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35520 --- Comment #2 from Magnus Enger --- Here's a very basic POC, just for cover images. Feel free to build on it if you can beat me to it! :-) use Koha::CoverImages; use File::Slurper qw( write_binary ); use Modern::Perl; my $outputdir = '.'; my $covers = Koha::CoverImages->search(); while ( my $cover = $covers->next ) { my $biblionumber = $cover->biblionumber; my $imagenumber = $cover->imagenumber; my $itemnumber = $cover->itemnumber; # Can be NULL my $filename = "$outputdir/biblionumber_$biblionumber" . "_imagenumber_$imagenumber" . "_full.png"; write_binary( $filename, $cover->imagefile ); say "Wrote $filename"; my $thumbnail = "$outputdir/biblionumber_$biblionumber" . "_imagenumber_$imagenumber" . "_thumb.png"; write_binary( $thumbnail, $cover->thumbnail ); say "Wrote $thumbnail"; } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 12:22:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 11:22:32 +0000 Subject: [Koha-bugs] [Bug 35515] Change occurences of "Global system preferences" to "System preferences" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35515 --- Comment #3 from Aude Charillon --- Thanks for listing those files, Caroline! I'll make a note of that command too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 12:24:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 11:24:31 +0000 Subject: [Koha-bugs] [Bug 35515] Change occurences of "Global system preferences" to "System preferences" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35515 Rasa Satinskiene changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rasa.satinskiene at ptfs-europ | |e.com Documentation| |Rasa Satinskiene contact| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 12:44:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 11:44:42 +0000 Subject: [Koha-bugs] [Bug 35483] Restore item level to record level hold switch in hold table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159593|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes --- Created attachment 159671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159671&action=edit Bug 35483: Restore holds table select to switch item level holds to record level holds To test: 1. Apply patch 2. Add item level hold to a record/item, make sure patron has no other holds on that record 3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is the record you placed the hold for 4. Under "Existing holds" table, in "Details" column you should see "Only item " dropdown 5. Select "Next available" from the dropdown 6. Click Update hold(s) 7. Observe dropdown is gone and cell value has changed from "Only item " to "Next available" 8. Cancel the hold and add two item level holds for the same patron 9. Under "Existing holds" table, in "Details" column you should see "Only item ", but no select dropdown Signed-off-by: Owen Leonard Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 12:44:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 11:44:44 +0000 Subject: [Koha-bugs] [Bug 35483] Restore item level to record level hold switch in hold table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35483 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159594|0 |1 is obsolete| | --- Comment #5 from PTFS Europe Sandboxes --- Created attachment 159672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159672&action=edit Bug 35483: (follow-up) Trivial indentation changes Signed-off-by: Owen Leonard Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 12:52:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 11:52:16 +0000 Subject: [Koha-bugs] [Bug 35114] Total on basketgroup can be different than basket details total In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35114 --- Comment #4 from Philip Orr --- Hi Thibaud, thanks for the quick response! I tried it again with different amounts including e.g. 10,496 or 10,5996 .. etc. I still didn't see any difference between the two views. They were still both the same (possibly calculated wrongly, but at least both calculated seemingly the same :) ) Also I checked activating OrderPriceRounding, but still then, both sums were the same in basketgroup view and in the basket details itself. So I think you will have to write up a more detailed test plan for this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 12:53:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 11:53:36 +0000 Subject: [Koha-bugs] [Bug 35489] Holds on items with no barcode are missing an input for itemnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35489 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 13:31:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 12:31:30 +0000 Subject: [Koha-bugs] [Bug 22018] Add an option to 'AllowEarlyRenewal' to enable users to renew before the autorenew date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22018 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #13 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 25393 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 13:31:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 12:31:30 +0000 Subject: [Koha-bugs] [Bug 25393] Create separate 'no automatic renewal before' rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25393 --- Comment #46 from Nick Clemens --- *** Bug 22018 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 15:04:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 14:04:07 +0000 Subject: [Koha-bugs] [Bug 25015] Staff with Edit Items permission Currently Can Not Edit Items attached to a Fast Add Framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Eileen Chandler changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echandler at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 15:11:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 14:11:21 +0000 Subject: [Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 --- Comment #51 from Andrew Fuerste-Henry --- (In reply to Thibaud Guillot from comment #50) > Thank you all for this time of testing and feedback. I think I've managed to > fix the display problem Andrew was talking about. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 17:09:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 16:09:02 +0000 Subject: [Koha-bugs] [Bug 35521] New: Erros in main search tab display Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35521 Bug ID: 35521 Summary: Erros in main search tab display Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 159673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159673&action=edit Screenshot After upgrading to 22.11.12, I'm seeing both the 'catalog' and 'syspref' search boxes. Circling through the tabs hides the cataloguing search and the view is back to normal. See the screenshot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 17:10:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 16:10:42 +0000 Subject: [Koha-bugs] [Bug 35521] Erros in main search tab display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35521 --- Comment #1 from Owen Leonard --- Could it be a browser cache issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 17:15:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 16:15:40 +0000 Subject: [Koha-bugs] [Bug 35521] Erros in main search tab display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35521 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #2 from Tomás Cohen Arazi --- I couldn't reproduce on my dev environment. Only on a packages install... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 17:26:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 16:26:13 +0000 Subject: [Koha-bugs] [Bug 35521] Errors in main search tab display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35521 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Erros in main search tab |Errors in main search tab |display |display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 17:30:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 16:30:30 +0000 Subject: [Koha-bugs] [Bug 34188] Require library selection when logging in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34188 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/771 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 17:30:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 16:30:30 +0000 Subject: [Koha-bugs] [Bug 35259] Highlight staff user's home library in library selection on login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35259 Bug 35259 depends on bug 34188, which changed state. Bug 34188 Summary: Require library selection when logging in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34188 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 17:35:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 16:35:09 +0000 Subject: [Koha-bugs] [Bug 25015] Staff with Edit Items permission Currently Can Not Edit Items attached to a Fast Add Framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25015 Angela Berrett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett at familysearch | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 17:39:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 16:39:37 +0000 Subject: [Koha-bugs] [Bug 35471] Automatically select child MARC framework when adding child records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35471 Angela Berrett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett at familysearch | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 17:45:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 16:45:08 +0000 Subject: [Koha-bugs] [Bug 35521] Errors in main search tab display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35521 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Tomás Cohen Arazi --- Found the cause in IntranetUserJS: ``` /* JS for Koha RoomReservation Plugin This JS was added automatically by installing the RoomReservation plugin Please do not modify */ ... $(".nav-tabs li:first-child").removeClass("active").attr("aria-expanded", "false"); $("#circ_search").removeClass("active"); $("#catalog_search").addClass("active"); $(".nav-tabs li:last-child").addClass("active").attr("aria-expanded", "true"); ``` Leaving here in case others have the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 17:54:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 16:54:35 +0000 Subject: [Koha-bugs] [Bug 35486] When editing an authority show all subfields of the heading field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35486 Angela Berrett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett at familysearch | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 18:06:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 17:06:22 +0000 Subject: [Koha-bugs] [Bug 30623] Copy permissions from one user to another In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30623 Angela Berrett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett at familysearch | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 19:14:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 18:14:00 +0000 Subject: [Koha-bugs] [Bug 12044] Checkout should be clearly disallowed before inputting item barcode if a patron's fines will block the transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12044 --- Comment #5 from Cab Vinton --- Created attachment 159674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159674&action=edit sample block message +1 from here as well. Note that some processes do add very helpful restriction messages to the patron page (see attached). Something similar would be helpful for any patrons with fines above the noissues or OPACFineNoRenewals thresholds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 19:23:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 18:23:16 +0000 Subject: [Koha-bugs] [Bug 30645] Generated DBIC query incorrect for api searches across joined extended attributes when several terms are passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 19:23:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 18:23:18 +0000 Subject: [Koha-bugs] [Bug 30645] Generated DBIC query incorrect for api searches across joined extended attributes when several terms are passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159450|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 159675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159675&action=edit Bug 30645: Add tests to highlight the problem Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 19:23:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 18:23:21 +0000 Subject: [Koha-bugs] [Bug 30645] Generated DBIC query incorrect for api searches across joined extended attributes when several terms are passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159652|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 159676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159676&action=edit Bug 30645: Consider multiple instances of extended_attributes in query params This will rewrite a query like: { "-and":[ [ { "extended_attributes.value":{ "like":"abc%" }, "extended_attributes.code":[ [ "arbitrary_attr_code", "another_attr_code" ] ] } ], [ { "extended_attributes.value":{ "like":"123%" }, "extended_attributes.code":[ [ "arbitrary_attr_code", "another_attr_code" ] ] } ] ] } To: { "-and":[ [ { "extended_attributes.value":{ "like":"abc%" }, "extended_attributes.code":[ [ "arbitrary_attr_code", "another_attr_code" ] ] } ], [ { "extended_attributes_2.value":{ "like":"123%" }, "extended_attributes_2.code":[ [ "arbitrary_attr_code", "another_attr_code" ] ] } ] ] } And it'll also add the number of required 'join' attributes to the query attributes to match it. Test plan (with Joubu's test patch applied), run: prove t/db_dependent/selenium/patrons_search.t Or Test plan, k-t-d: 1) Create 2 patron attributes, visit: /cgi-bin/koha/admin/patron-attr-types.pl 2) Name the first attribute 'test1' and the second attribute 'test2' 3) On both, tick the 'Searchable' and 'Search by default' checkboxes 4) Edit a koha borrower, example visit: /cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51 5) Put '123' on the test1 attribute, and 'abc' on the test2 attribute 6) Visit the main patrons page: /cgi-bin/koha/members/members-home.pl 7) On the first left side filter input called 'Search', type '123' and search. Notice you get the patron result 8) Repeat step 7, but type 'abc' instead of '123'. Notice you get the patron result 9) Now do the same search but type '123 abc'. Notice you do not get the patron result. 10) Apply patch. Repeat test plan. Notice you get the patron result in step 9). Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 19:33:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 18:33:05 +0000 Subject: [Koha-bugs] [Bug 30645] Generated DBIC query incorrect for api searches across joined extended attributes when several terms are passed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30645 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes patron searching release notes| |where there are multiple | |patron attributes - all | |patron attributes are now | |searched. Before this, if | |your search included values | |from multiple patron | |attributes, no results | |would be found. Example: if | |you have two patron | |attributes with the value | |'abc' in one and '123' in | |another, searching for | |either one worked as | |expected, but no results | |would be found searching | |for 'abc 123'. CC| |david at davidnind.com --- Comment #14 from David Nind --- Testing notes (using KTD): 1. To run the tests, start up KTD with selenium: ktd --selenium up 2. I ran the tests (these passed) and added patron attributes to test that patron search works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 20:09:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 19:09:10 +0000 Subject: [Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 20:09:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 19:09:12 +0000 Subject: [Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159661|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159677&action=edit Bug 35517: Choose correct default header search tab according to permissions This patch adds some additional template logic to the header search form for the staff interface home page so that users with different permissions will see the correct tab in the header search form. To test, apply the patch and view the staff interface home page using a user with different permissions: - 'catalogue' and 'circulate' - Header should show circulation search - 'catalogue' and 'borrowers' - Header should show patron search - 'catalogue' only - Header should show catalog search Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 20:16:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 19:16:47 +0000 Subject: [Koha-bugs] [Bug 35517] Choose correct default header search tab according to permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |the header search form on | |the staff interface home | |page so that staff patrons | |with different permissions | |will see the correct tab in | |the header search form. | |Previously, the default was | |to display the check out | |search - if they didn't | |have circulation | |permissions, the search | |tabs were initially hidden. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:03:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:03:11 +0000 Subject: [Koha-bugs] [Bug 31557] Add ability for holds queue builder to prioritize either matching a patron's home library to the item's home or holding library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31557 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor at clamsnet.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:07:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:07:03 +0000 Subject: [Koha-bugs] [Bug 34886] Regression in when hold button appears In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:07:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:07:06 +0000 Subject: [Koha-bugs] [Bug 34886] Regression in when hold button appears In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156980|0 |1 is obsolete| | --- Comment #30 from David Nind --- Created attachment 159678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159678&action=edit Bug 34886: [alternate] Adjust holdability checks on opac details page This patch tries to simplify some of the logic here to match that on the search results. When we don't have a patron, we fallback to determining if an item can be held buy determining whether there are any items that don't have holds disallowed at the all libraries level. We also remove items with non-holdable statuses like withdrawn etc (and check some system preferences) If we don't have a patron, then we are done, however, if we do, then we need to check each item against the policies related to that patron. This patch also removes two checks at the end: CountItemsIssued($biblionumber) $biblio->has_items_waiting_or_intransit These seem to be from bug 4319 - however, those rules are checked by IsAvailableForItemLevelRequest and are only relevant when we have a patron. These checks essentially assumed 'onshelfholds' policy of 'If any unavailable' For consistency sake I think we should follow the same logic as the results page. To test: 1 - Find a record with two items, of different types, set a 'Default checkout, hold and return policy' of 'No holds allowed' 2 - Search opac, not logged in, and verify neither the results page or details page shows the place hold button 3 - Delete that rule, make both items withdrawn 4 - Search opac, not logged in, and verify neither the results page or details page shows the place hold button 5 - Mark one item as not withdrawn 6 - Search opac, not logged in, and verify both the results page or details page shows the place hold button 7 - Log in to opac 8 - Search opac, logged in, and verify both the results page or details page shows the place hold button 9 - Place an 'On shelf holds policy' rule for that patron category of 'If any unavailable' 10 - Search opac, logged in, and verify the results and details page shows the place hold button 11 - Set the other item to not withdrawn 12 - Search opac, logged in, and verify the results page shows the place hold button, but details does not 13 - Try various other scenarios - details page should be more correct, results page is always an approximation Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:07:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:07:10 +0000 Subject: [Koha-bugs] [Bug 34886] Regression in when hold button appears In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156981|0 |1 is obsolete| | --- Comment #31 from David Nind --- Created attachment 159679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159679&action=edit Bug 34886: [alternate] adjust other opac detail scripts Same chanegs as before, but for MARC and ISBD details pages Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:17:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:17:11 +0000 Subject: [Koha-bugs] [Bug 34886] Regression in when hold button appears In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34886 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #32 from David Nind --- Testing notes (using KTD): 1. Tested alternate patches. 2. Step 10 fails for me, but as per comment #29 I've signed off anyway (hopefully I understand that correctly). Results for me: . Logged in, one item withdrawn and other available, "If any unavailable" set as rule . Search results: has place hold option, if you go to place a hold - "There are no items that can be placed on hold" . Details page (Normal, MARC and ISBD views): no place hold option 3. I've changed the importance to Major as it is a regression, feel free to change it back to Normal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:30:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:30:23 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:30:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:30:25 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 159680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159680&action=edit Bug 34943: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:30:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:30:28 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 159681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159681&action=edit Bug 34943: Implement before_record_store() plugin hook This patch implements a hook allowing record modification right before they are written on the DB. The idea is that a plugin could be used to add machine-generated fields/subfields. To test: 1. Apply the unit tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t => FAIL: Tests fail! The hook is not implemented so the desired results don't appear (added fields/subfields). 3. Apply this patch 4. Repeat 2 => SUCCESS: It works! 5. Run: k$ qa -c 2 => SUCCESS: All green! 6. Sign off :-D Sponsored-by: Theke Solutions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:30:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:30:36 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:37:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:37:08 +0000 Subject: [Koha-bugs] [Bug 29392] Add plugin hooks before merging biblios or authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |tomascohen at gmail.com --- Comment #5 from Tomás Cohen Arazi --- I just noticed this one, after submitting bug 34943. The chosen name for the hook is not specific enough, given the fact it is only called on merging records. Regarding testing it, I would say the best is to write tests for it :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:43:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:43:11 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159680|0 |1 is obsolete| | Attachment #159681|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi --- Created attachment 159682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159682&action=edit Bug 34943: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:43:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:43:13 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 159683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159683&action=edit Bug 34943: Implement before_record_store() plugin hook This patch implements a hook allowing record modification right before they are written on the DB. The idea is that a plugin could be used to add machine-generated fields/subfields. To test: 1. Apply the unit tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t => FAIL: Tests fail! The hook is not implemented so the desired results don't appear (added fields/subfields). 3. Apply this patch 4. Repeat 2 => SUCCESS: It works! 5. Run: k$ qa -c 2 => SUCCESS: All green! 6. Sign off :-D Sponsored-by: Theke Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:44:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:44:02 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29392 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:44:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:44:02 +0000 Subject: [Koha-bugs] [Bug 29392] Add plugin hooks before merging biblios or authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29392 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34943 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:44:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:44:26 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:44:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:44:28 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159682|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 159684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159684&action=edit Bug 34943: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:44:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:44:30 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159683|0 |1 is obsolete| | --- Comment #8 from David Nind --- Created attachment 159685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159685&action=edit Bug 34943: Implement before_record_store() plugin hook This patch implements a hook allowing record modification right before they are written on the DB. The idea is that a plugin could be used to add machine-generated fields/subfields. To test: 1. Apply the unit tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t => FAIL: Tests fail! The hook is not implemented so the desired results don't appear (added fields/subfields). 3. Apply this patch 4. Repeat 2 => SUCCESS: It works! 5. Run: k$ qa -c 2 => SUCCESS: All green! 6. Sign off :-D Sponsored-by: Theke Solutions Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:45:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:45:48 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #9 from Tomás Cohen Arazi --- David, we overlapped. I'm renaming the hook for clarity. Let me re-submit and you test again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:47:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:47:18 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:47:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:47:21 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159684|0 |1 is obsolete| | Attachment #159685|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi --- Created attachment 159686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159686&action=edit Bug 34943: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:47:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:47:24 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 159687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159687&action=edit Bug 34943: Implement `before_biblio_metadata_store` plugin hook This patch implements a hook allowing record modification right before they are written on the DB. The idea is that a plugin could be used to add machine-generated fields/subfields. To test: 1. Apply the unit tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t => FAIL: Tests fail! The hook is not implemented so the desired results don't appear (added fields/subfields). 3. Apply this patch 4. Repeat 2 => SUCCESS: It works! 5. Run: k$ qa -c 2 => SUCCESS: All green! 6. Sign off :-D Sponsored-by: Theke Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 21:48:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 20:48:12 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 --- Comment #12 from Tomás Cohen Arazi --- I decided to rename for hook for better scoping it (authorities could have a hook too) taking the idea from bug 29392, which feels valuable as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:05:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:05:25 +0000 Subject: [Koha-bugs] [Bug 23454] Fine for the previous overdue may get overwritten by the next one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #15 from Katrin Fischer --- In the screenshots we see 2 fines "Accruing", that is where things went wrong as only one fine for an item should ever be accruing. But: we have not been able to replicate. I believe that in newer versions and accruing fine is correctly set to static when the item is returned or renewed and a second fine will not overwrite, but start over being completely separate. Please re-open if you can still reproduce this issue in a maintained version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:09:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:09:11 +0000 Subject: [Koha-bugs] [Bug 23460] Be able to specify a default item type, to allow Koha to do things to items that don't have itypes? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23460 --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #2) > Hm, I might have misunderstood (forcing an itemtype in the item vs having a > fallback Koha just uses when itemtype empty). But a bit afraid it would > require changing a lot of code to make that happen... favoring fixing the > data a bit right now. We have made the itemtype mandatory all over Koha since. There is also a bug that breaks the display in the OPAC for records with items missing itemtypes. I wonder if this is still needed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:16:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:16:23 +0000 Subject: [Koha-bugs] [Bug 23480] Improve usability of renewal/return columns in the checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23480 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- Note: in 23.11 we now have separate buttons for renew and return that activate after checking checkboxes in the corresponding column. I believe this to be a nice usability enhancement and it might also cover this report. Please re-open if you disagree. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:17:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:17:43 +0000 Subject: [Koha-bugs] [Bug 23486] Date last seen should be set upon registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23486 --- Comment #29 from Katrin Fischer --- We could add patron creation to the list of actions in TrackLastPatronActivityTriggers to resolve this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:19:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:19:28 +0000 Subject: [Koha-bugs] [Bug 35108] ILL - "Manage request" page is too loaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:19:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:19:30 +0000 Subject: [Koha-bugs] [Bug 35108] ILL - "Manage request" page is too loaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159657|0 |1 is obsolete| | --- Comment #6 from David Nind --- Created attachment 159688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159688&action=edit Bug 35108: Move request id to page header Redundant information, can be moved to header for more visibility and less horizontal length Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:19:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:19:33 +0000 Subject: [Koha-bugs] [Bug 35108] ILL - "Manage request" page is too loaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159658|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 159689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159689&action=edit Bug 35108: Hide optionally empty fields label entries, these are: orderid, biblio_id, batch already was the case, type, type_disclaimer_value, type_disclaimer_date, cost, price_paid, notesstaff, notesopac Test plan, k-t-d: 1) Install FreeForm and BLDSS backends, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-plus.sh) 2) Create a new FreeForm request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm 5) Set type 'Book', put '42' in the cardnumber, and pick a library. Click 'create'. 6) Notice how there is a lot of unnecessary empty field entries 7) Apply patch, restart plack (koha-plack --restart kohadev) 8) Refresh the page, notice all the empty fields entries are no longer displayed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:21:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:21:01 +0000 Subject: [Koha-bugs] [Bug 23487] Utf8mb4 collation causes problems with missing tables when upgrading the database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23487 --- Comment #1 from Katrin Fischer --- This has been reported 4 years ago and I believe it might have been caused by a changed collation on the borrowers table. Should this be marked WONTFIX at this point? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:22:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:22:23 +0000 Subject: [Koha-bugs] [Bug 35108] ILL - "Manage request" page is too loaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35108 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement hides release notes| |option fields that are | |empty when displaying ILL | |requests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:22:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:22:33 +0000 Subject: [Koha-bugs] [Bug 23494] Ability to automatically remove entries from personal lists on checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Tie Lists to CKO |Ability to automatically | |remove entries from | |personal lists on checkout Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:26:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:26:27 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:26:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:26:30 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159686|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 159690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159690&action=edit Bug 34943: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:26:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:26:33 +0000 Subject: [Koha-bugs] [Bug 34943] Add a pre-save plugin hook for biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159687|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 159691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159691&action=edit Bug 34943: Implement `before_biblio_metadata_store` plugin hook This patch implements a hook allowing record modification right before they are written on the DB. The idea is that a plugin could be used to add machine-generated fields/subfields. To test: 1. Apply the unit tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t => FAIL: Tests fail! The hook is not implemented so the desired results don't appear (added fields/subfields). 3. Apply this patch 4. Repeat 2 => SUCCESS: It works! 5. Run: k$ qa -c 2 => SUCCESS: All green! 6. Sign off :-D Sponsored-by: Theke Solutions Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:27:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:27:35 +0000 Subject: [Koha-bugs] [Bug 23498] [18.11] Broken links to bibs when placing holds on multiple records and a hold exists on at least one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23498 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- 18.11 is no longer maintained and this appears to be fixed in current versions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:28:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:28:22 +0000 Subject: [Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Drag-and-drop hold |Drag-and-drop hold |reordering in the staff |reordering in the staff |client |interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:29:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:29:30 +0000 Subject: [Koha-bugs] [Bug 35505] Add specific selectors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35505 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:29:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:29:42 +0000 Subject: [Koha-bugs] [Bug 34076] [ALTERNATE] [DOCS] Automated screenshots using Cypress.io testing framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34076 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:31:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:31:19 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #7 from Tomás Cohen Arazi --- Should we clear on all plugin-related test files? subtests? Should we generalize this cleanup step? I know we rollback, and then call ->delete() in some places, we should just add this cache cleaning too. $ ls t/db_dependent/Koha/Plugins/ Account_hooks.t* Broken.t* Patron.t* BackgroundJob.t* Circulation_hooks.t* Plugins.t* Barcode_transform_hooks.t* Holds_hooks.t* Recall_hooks.t* Biblio_and_Items_plugin_hooks.t* KitchenSinkPlugin.kpz authority_hooks.t* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:31:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:31:45 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha at gmail. | |com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:32:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:32:46 +0000 Subject: [Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159505|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 159692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159692&action=edit Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the record matching rules administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Some controls on this page have been updated to use Bootstrap link style with Font Awesome icons added. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Record matching rules - New record matching rule - Edit record matching rule - Delete record matching rule - Test the process of adding new match points and new match checks, and removing match points and match checks. Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:32:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:32:48 +0000 Subject: [Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 159693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159693&action=edit Bug 34398: (QA follow-up): add missing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:34:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:34:09 +0000 Subject: [Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor at tuxayo.net QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | --- Comment #7 from Victor Grousset/tuxayo --- Much cleaner, looks great :) Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:34:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:34:13 +0000 Subject: [Koha-bugs] [Bug 23524] Can modify/delete funds for locked budgets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23524 --- Comment #4 from Katrin Fischer --- (In reply to Donna from comment #2) > To me, lock means nothing changes. So no changing of fund amounts, no > adding/removing funds, and no ordering/receiving. > > Active/inactive makes sense for whether or not I can use the money in the > budget, where lock means it has been finalized/closed out and nothing should > change in it. We also have inactive and a fund could be set to inactive and locked. An idea would be to make them add up, but not overlap maybe. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:36:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:36:31 +0000 Subject: [Koha-bugs] [Bug 34721] Change facet description for Limit to available items to accurately reflect what it does In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34721 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/773 Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:39:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:39:48 +0000 Subject: [Koha-bugs] [Bug 23550] Not possible to add multiple patron restrictions when editing a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23550 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Not possible to add |Not possible to add |multiple patron |multiple patron |restrictions in |restrictions when editing a |memberentry.pl |patron Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:42:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:42:28 +0000 Subject: [Koha-bugs] [Bug 23558] REST API: Get an ILL request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23558 --- Comment #1 from Katrin Fischer --- It looks like this might be resolved: https://api.koha-community.org/#tag/ill_requests/operation/listIllrequests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:44:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:44:38 +0000 Subject: [Koha-bugs] [Bug 33828] ExportCircHistory description is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33828 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/774 Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 22:48:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 21:48:07 +0000 Subject: [Koha-bugs] [Bug 23572] Regression: Bug 18878 - Improve item form display / labels too far from input fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23572 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- The labels have been moved back to the right meanwhile :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 8 23:09:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 22:09:45 +0000 Subject: [Koha-bugs] [Bug 23629] Retain search results until staff close window In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23629 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 00:46:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Dec 2023 23:46:05 +0000 Subject: [Koha-bugs] [Bug 25079] Show club enrollment question answers in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25079 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/775 Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 07:54:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 06:54:47 +0000 Subject: [Koha-bugs] [Bug 29539] UNIMARC: authority number in $9 displays for thesaurus controlled fields instead of content of $a In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29539 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 11:30:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 10:30:41 +0000 Subject: [Koha-bugs] [Bug 31375] Account Expiration Date Auto-updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31375 kch-tr.lhl-consortium at nhs.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kch-tr.lhl-consortium at nhs.n | |et --- Comment #4 from kch-tr.lhl-consortium at nhs.net --- Any more thoughts on this? It really would be very useful when upgrading self-registered user accounts to full privilege accounts, much in the same way that the messaging preferences are changed when switching category types. Would probably work best as an optional setting to enable in sys preferences? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 11:45:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 10:45:38 +0000 Subject: [Koha-bugs] [Bug 33218] Should the 'Main contact method' field override the AutoEmailPrimaryAddress at patron-level? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33218 --- Comment #3 from kch-tr.lhl-consortium at nhs.net --- (In reply to Martin Renvoize from comment #2) > I think I'd do this a little differently. I think we should have an option > to enable/disable that picker option at the patron level rather than adding > it to primary address options. Then use it whenever explicitly set by the > patron or use the primary address option if they've not set it. > > I also wonder where advanced patron messaging preferences should sit in > regards to all this If this works to prioritise the patron's preferred email choice, then I'd like to see it, would save our staff a lot of time manually swapping data between fields. Not sure what to say about messaging preferences, what are the possible impacts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 12:25:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 11:25:47 +0000 Subject: [Koha-bugs] [Bug 33166] Item type database fields should not be nullable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33166 --- Comment #9 from Katrin Fischer --- I would be happy if we could avoid making the biblio-level itype mandatory. We don't set it usually, because of our union catalog situation. You cannot really predict the item type reliably from the bibliographic data and in the past it was not able to protect the field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 12:36:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 11:36:15 +0000 Subject: [Koha-bugs] [Bug 23752] Search all z39.50 / SRU targets and resource discovery layer / open link resolver from any ILL backend In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23752 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim at ptfs-europe.co | |m --- Comment #4 from Katrin Fischer --- I am not familiar with the kind of functionality the availability plugins can provide, so adding Pedro, maybe he can help us get an idea what we should do on Koha side and what would be better on the plugin end. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 12:37:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 11:37:00 +0000 Subject: [Koha-bugs] [Bug 23756] Appendix for workflows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23756 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon at ptfs-europe. | |com, | |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 12:38:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 11:38:52 +0000 Subject: [Koha-bugs] [Bug 23758] Advanced editor: automatically populate a field with the current date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23758 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Advanced editor should have |Advanced editor: |a widget to automatically |automatically populate a |populate when a biblio is |field with the current date |first entered | Assignee|hayleypelham at ownmail.net |koha-bugs at lists.koha-commun | |ity.org Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 12:42:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 11:42:55 +0000 Subject: [Koha-bugs] [Bug 23766] Allow MARC record importer to handle large batches without causing memory issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23766 --- Comment #3 from Katrin Fischer --- Was this solved by using the background jobs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 12:44:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 11:44:40 +0000 Subject: [Koha-bugs] [Bug 23776] API comparative documentation for tierce application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23776 --- Comment #1 from Katrin Fischer --- Should this remain open? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 12:51:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 11:51:00 +0000 Subject: [Koha-bugs] [Bug 23814] Make it easier to manage items in baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23814 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- We weren't able to clarify the request as of yet - I am closing INVALID, please re-open if you can help specifying this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 12:55:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 11:55:29 +0000 Subject: [Koha-bugs] [Bug 23837] detail.pl contains a lot of whitespace in the td.status cell In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23837 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #4 from Katrin Fischer --- I am pondering if this is a WONTFIX because I don't think we can easily fix it. Adding Owen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:06:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:06:18 +0000 Subject: [Koha-bugs] [Bug 23875] Elasticsearch - When sorting by score we should provide a tiebreaker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23875 --- Comment #19 from Katrin Fischer --- I believe we have solved the numerical sorting by now - could this be revived? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:09:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:09:27 +0000 Subject: [Koha-bugs] [Bug 23886] Autocreate thumbnail for PDFs or images hosted in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23886 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|autocreate thumbnail for |Autocreate thumbnail for |pdfs or images hosted at |PDFs or images hosted in |koha repository |Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:18:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:18:47 +0000 Subject: [Koha-bugs] [Bug 23899] Cannot change size of Show SQL Code box on run report page (Chromium) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23899 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- It does work for me now in Chromium - I assume the bug in Code Mirror might have been fixed since. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:20:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:20:24 +0000 Subject: [Koha-bugs] [Bug 23906] Show information if patron is on Patron list on circulation page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23906 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- This is resolved in 23.11 with a new tab in the patron detail view that shows all lists the patron is on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:23:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:23:41 +0000 Subject: [Koha-bugs] [Bug 23909] SCO allows to check out items with Waiting state if AllowItemsOnHoldCheckoutSCO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23909 --- Comment #8 from Katrin Fischer --- I can understand the argument for items that haven't been set to waiting yet, but I think once we have sent out the mail to the user, it should not be able for someone else to check it out on the self check. The circulation desk is a different case. If proxy pick-up is allowed and wanted... how do you prevent patrons picking any item from the pick-up shelf they'd like to jump the queue on? But if this strictly needs to be configurable, maybe it should be something like: SCOAllowWaitingPickupByProxy? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:29:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:29:06 +0000 Subject: [Koha-bugs] [Bug 23918] Search results incorrect for multiple vowel words In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23918 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:33:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:33:37 +0000 Subject: [Koha-bugs] [Bug 23935] Sharing on Social Media looks wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23935 --- Comment #1 from Katrin Fischer --- I am not sure if we could share the cover like this, as there is copyright on covers and service agreements might now allow sharing to third party websites. But I believe we did improve the information shared at some point, maybe you could try again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:34:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:34:28 +0000 Subject: [Koha-bugs] [Bug 23936] Authenticating a patron with a one-time code via SMS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Authenticating a patron |Authenticating a patron |without library card or ID |with a one-time code via | |SMS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:45:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:45:12 +0000 Subject: [Koha-bugs] [Bug 23996] MySQL 8 support [Omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- All depending bugs have been closed. Closing this as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:49:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:49:46 +0000 Subject: [Koha-bugs] [Bug 24041] Renewal only slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24041 --- Comment #2 from Katrin Fischer --- Maybe this could be achieved with the new custom patron slips now? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:52:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:52:08 +0000 Subject: [Koha-bugs] [Bug 24049] Limit for consecutive hold requests on same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24049 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Limit for consecutive hold |Limit for consecutive hold |requests |requests on same record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:52:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:52:44 +0000 Subject: [Koha-bugs] [Bug 24050] Limit consecutive issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24050 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24049 Summary|Limit Consecutive Issues |Limit consecutive issues -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:52:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:52:44 +0000 Subject: [Koha-bugs] [Bug 24049] Limit for consecutive hold requests on same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24049 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24050 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 13:59:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 12:59:25 +0000 Subject: [Koha-bugs] [Bug 24096] Mana KB "Shared successfully" untranslatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24096 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Mana-kb |Mana-kb (server) Product|Koha |Project Infrastructure Version|master |unspecified -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:01:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:01:46 +0000 Subject: [Koha-bugs] [Bug 24107] returns.pl fetches the same item from the database multiple times In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24107 --- Comment #1 from Katrin Fischer --- Kyle, can you tell if this is still the case? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:11:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:11:33 +0000 Subject: [Koha-bugs] [Bug 24133] nb-NO and pl-PL biblio frameworks out of sync In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24133 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Resolved by removal of language specific installer files. We create all frameworks from the same base files now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:18:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:18:13 +0000 Subject: [Koha-bugs] [Bug 26836] Add ability to assign Z39.50 servers to groups for searching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26836 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:25:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:25:36 +0000 Subject: [Koha-bugs] [Bug 26861] Indicate that a record is using OpacHiddenItems in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Indicate that a record is |Indicate that a record is |using OpacHiddenItems in |using OpacHiddenItems in |staff client |the staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:27:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:27:45 +0000 Subject: [Koha-bugs] [Bug 26868] biblio and biblio_metadata tables timestamp do not update when moving an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26868 --- Comment #4 from Katrin Fischer --- I think there is work underway to log biblio record merges, maybe we could also create a specific log entry for moving items? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:27:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:27:56 +0000 Subject: [Koha-bugs] [Bug 26868] biblio and biblio_metadata tables timestamp do not update when moving an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26868 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:32:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:32:03 +0000 Subject: [Koha-bugs] [Bug 26876] Add ability to create items when using Bibliotheca eBook plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26876 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- I believe this should be filed on the issue tracker for the plugin instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:35:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:35:16 +0000 Subject: [Koha-bugs] [Bug 26877] Add ability for libraries to be able to restart the SIP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26877 --- Comment #5 from Katrin Fischer --- I believe that we have resolved all known caching issues with the SIP server now. We also do a nightly restart, but we haven't had issues reported in a while. Barbara, do you think this could be closed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:40:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:40:33 +0000 Subject: [Koha-bugs] [Bug 26884] [Omnibus] Refactor overdue_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26884 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16063 Summary|overdue_notices.pl |[Omnibus] Refactor | |overdue_notices.pl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16063 [Bug 16063] logic from overdue_notice.pl should be moved into a module -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:40:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:40:33 +0000 Subject: [Koha-bugs] [Bug 16063] logic from overdue_notice.pl should be moved into a module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26884 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26884 [Bug 26884] [Omnibus] Refactor overdue_notices.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:42:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:42:07 +0000 Subject: [Koha-bugs] [Bug 26888] New installer: Make it possible to set active currency according to language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26888 --- Comment #1 from Katrin Fischer --- We can solve this with the localization file. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:47:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:47:06 +0000 Subject: [Koha-bugs] [Bug 26890] Add opac_biblio_tab and opac_biblio_enhancements_toolbar_button hooks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opac-detail plugin like |Add opac_biblio_tab and |intranet/cgi-bin/catalogue/ |opac_biblio_enhancements_to |detail.pl |olbar_button hooks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:52:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:52:45 +0000 Subject: [Koha-bugs] [Bug 26966] table_borrowers does not allow you to toggle columns directly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I believe this has been fixed - borrower search results now has the full table options. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:54:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:54:47 +0000 Subject: [Koha-bugs] [Bug 26780] Have an option to include authorised value descriptions in titles/items exported from Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26780 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Summary|have a parameter to export |Have an option to include |authorized-values labels |authorised value |instead of codes. |descriptions in | |titles/items exported from | |Koha Component|Command-line Utilities |Tools -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:56:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:56:31 +0000 Subject: [Koha-bugs] [Bug 26793] Hidden "more" menu if a lot of information is displayed in header section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26793 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hidden 'more" menu if many |Hidden "more" menu if a lot |informations displayed on |of information is displayed |header |in header section --- Comment #1 from Katrin Fischer --- We should retest with the new staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:57:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:57:22 +0000 Subject: [Koha-bugs] [Bug 26794] Item transfer modal may close automatically after a delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26794 --- Comment #1 from Katrin Fischer --- Hi Arthur, is this still an issue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 14:58:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 13:58:57 +0000 Subject: [Koha-bugs] [Bug 26801] New display location should not default to All In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26801 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I think this was resolved by splitting News and HTML customizations into different tools. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 15:06:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 14:06:02 +0000 Subject: [Koha-bugs] [Bug 26715] Make Z39.50 modal moveable in the advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26715 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Summary|Make Z39.50 modal moveable |Make Z39.50 modal moveable |in the Advanced Cataloging |in the advanced cataloging |Editor |editor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 15:07:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 14:07:45 +0000 Subject: [Koha-bugs] [Bug 26717] Allow specifying where to insert new subfields in MARC Modification Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26717 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26716 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 15:07:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 14:07:45 +0000 Subject: [Koha-bugs] [Bug 26716] Allow specifying where to insert new fields in MARC Modification Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26717 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 15:08:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 14:08:46 +0000 Subject: [Koha-bugs] [Bug 26731] Change default sort order of inactive budgets on aqbudgetperiods.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26731 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 15:09:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 14:09:24 +0000 Subject: [Koha-bugs] [Bug 26732] Add a dropdown box on acq start page to select which inactive budget to view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26732 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a dropdown box on |Add a dropdown box on acq |acqui-home.pl to select |start page to select which |which inactive budget to |inactive budget to view |view | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 15:10:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 14:10:56 +0000 Subject: [Koha-bugs] [Bug 26740] REST API: Add endpoint for task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26740 --- Comment #1 from Katrin Fischer --- Is this resolved? https://api.koha-community.org/#tag/jobs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 15:20:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 14:20:39 +0000 Subject: [Koha-bugs] [Bug 26644] Keyword search on "Reports" is persistant In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26644 --- Comment #2 from Katrin Fischer --- It allows you to go back and forth between your result list and single report,s when you need to find something specific through testing. I usually find it quite useful. Is there a middle ground between off/on here? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:15:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:15:18 +0000 Subject: [Koha-bugs] [Bug 26671] Simplify reports navigation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26671 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23478 --- Comment #6 from Katrin Fischer --- It looks like we are using 2 different navigations in the reports module, the hard coded reports and the different report options (saved reports too) are different. I suggest focusing on the navigation bar here for now and having the discussion on the start page on bug 23478. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:15:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:15:18 +0000 Subject: [Koha-bugs] [Bug 23478] Simplify report landing page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23478 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26671 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:16:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:16:23 +0000 Subject: [Koha-bugs] [Bug 25825] Allow claim return function to be controlled by permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25825 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Summary|Allow Claim Return function |Allow claim return function |to be controlled by |to be controlled by |permissions |permissions --- Comment #6 from Katrin Fischer --- As it's not also used with item bundles, we might need to take that into account. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:18:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:18:16 +0000 Subject: [Koha-bugs] [Bug 25835] Include overdue report (under circulation module) as a staff permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25835 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:19:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:19:38 +0000 Subject: [Koha-bugs] [Bug 25836] MARC fields not able to be reordered in basic editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25836 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master --- Comment #2 from Katrin Fischer --- I wonder if we should really be able to do this and if it would persist after saving. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:20:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:20:22 +0000 Subject: [Koha-bugs] [Bug 25843] Add REST API route for patron information update requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25843 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Send patron updates to |Add REST API route for |Staff Review |patron information update | |requests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:23:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:23:18 +0000 Subject: [Koha-bugs] [Bug 25848] Allow staff to cancel subscription alerts on behalf of patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25848 --- Comment #3 from Katrin Fischer --- This is possible from 23.11 in the patron account in the staff interface and in the OPAC :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:28:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:28:28 +0000 Subject: [Koha-bugs] [Bug 26545] Patrons cannot see or update their housebound information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26545 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:36:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:36:01 +0000 Subject: [Koha-bugs] [Bug 26566] Enable translation of system preference JSON files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26566 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I believe this is already working. I checked the modal for BorrowerMandatoryField. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:39:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:39:42 +0000 Subject: [Koha-bugs] [Bug 26603] Add the ability to have patron driven choice in what format they receive messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26603 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add the ability to have |Add the ability to have |Patron driven choice in |patron driven choice in |what format they receive |what format they receive |messages |messages Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:44:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:44:04 +0000 Subject: [Koha-bugs] [Bug 26609] Batch extend due dates tool should have filters for patron expiry date and holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26609 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Summary|Batch Extend Due Dates tool |Batch extend due dates tool |should add filter for |should have filters for |borrower expiry date and |patron expiry date and |item holds |holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:46:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:46:41 +0000 Subject: [Koha-bugs] [Bug 26620] Regarding serials receiving with same title published in different languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26620 --- Comment #1 from Katrin Fischer --- In which MARC field do you catalog the different language title? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:50:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:50:10 +0000 Subject: [Koha-bugs] [Bug 26623] MARC field links should only show once for repeated fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26623 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|MARC field links can take |MARC field links should |up too much space |only show once for repeated | |fields --- Comment #1 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:52:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:52:03 +0000 Subject: [Koha-bugs] [Bug 26447] Provide more sophisticated DB dependency management in web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- We have added some logic to the installer since this was reported. So you can only select sample holidays if you also have sample libraries, similar for sample patrons etc. Marking this as FIXED. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 16:59:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 15:59:39 +0000 Subject: [Koha-bugs] [Bug 26482] Add macros ability to basic editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26482 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:01:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:01:22 +0000 Subject: [Koha-bugs] [Bug 26483] Allow search-to-link for analytical cataloging of existing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26483 --- Comment #5 from Katrin Fischer --- (In reply to Andrew Fuerste-Henry from comment #3) > Thanks, Katrin, I hadn't played with marc21_linking_section.pl! It doesn't > quite do what analytical cataloging needs, but it's a start! Can you explain what you are missing? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:12:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:12:31 +0000 Subject: [Koha-bugs] [Bug 25904] Use patron attributes to track timestamp and count of patron related events In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25904 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Summary|Enhancing patron attributes |Use patron attributes to | |track timestamp and count | |of patron related events -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:15:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:15:50 +0000 Subject: [Koha-bugs] [Bug 25912] Any lost value triggers refund message on check in, even if it doesn't apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25912 --- Comment #6 from Katrin Fischer --- It looks like the bug description should be updated? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:17:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:17:52 +0000 Subject: [Koha-bugs] [Bug 25916] Create UI to modify and track changes to budget and fund amounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Create function and UI to |Create UI to modify and |modify budgets and funds. |track changes to budget and | |fund amounts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:19:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:19:48 +0000 Subject: [Koha-bugs] [Bug 13325] Create a nice view of budget and fund changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 --- Comment #23 from Katrin Fischer --- Mathieu, you might be interested in bug 25918! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:19:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:19:56 +0000 Subject: [Koha-bugs] [Bug 25918] Add budget/fund modification history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25918 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add budget/fund |Add budget/fund |modification history to |modification history |function added in BUG 25916 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:20:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:20:08 +0000 Subject: [Koha-bugs] [Bug 25918] Add budget/fund modification history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25918 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13325 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:20:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:20:08 +0000 Subject: [Koha-bugs] [Bug 13325] Create a nice view of budget and fund changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25918 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:20:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:20:59 +0000 Subject: [Koha-bugs] [Bug 25921] Merge (deleted)biblio* and (deleted)items tables - Update reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25921 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Merge biblio* and items |Merge (deleted)biblio* and |table - Update reports |(deleted)items tables - | |Update reports -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:23:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:23:13 +0000 Subject: [Koha-bugs] [Bug 25929] create_analytical_rel.pl don't sets host biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25929 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master --- Comment #1 from Katrin Fischer --- It doesn't create $0, because that is only used with EasyAnalytics. The script creates links according to the MARC standard. Both ways of creating analytical records are supported by Koha. It's intentional and should be made configurable if changed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:23:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:23:33 +0000 Subject: [Koha-bugs] [Bug 25929] create_analytical_rel.pl doesn't set host biblionumber in 773$0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25929 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|create_analytical_rel.pl |create_analytical_rel.pl |don't sets host |doesn't set host |biblionumber |biblionumber in 773$0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:24:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:24:12 +0000 Subject: [Koha-bugs] [Bug 25930] Datatables_Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25930 --- Comment #3 from Katrin Fischer --- This is 3 years old now... does it still fail? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:33:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:33:22 +0000 Subject: [Koha-bugs] [Bug 13325] Create a nice view of budget and fund changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 --- Comment #24 from mathieu saby --- it is a duplicate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:41:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:41:51 +0000 Subject: [Koha-bugs] [Bug 25965] Create SIP2 client daemon with HTTPS API endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25965 --- Comment #23 from Katrin Fischer --- Hi Lari, does you plugin cover the full functionality or are there any changes needed in Koha still? We could add it to https://wiki.koha-community.org/wiki/Koha_plugins and close the bug maybe. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:42:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:42:49 +0000 Subject: [Koha-bugs] [Bug 25966] Renewal of lost item generates overdue fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25966 --- Comment #1 from Katrin Fischer --- Is the item still lost after renewal? I seem to remember another bug about this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 17:44:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 16:44:31 +0000 Subject: [Koha-bugs] [Bug 25970] Make account_debit_types and account_credit_types available as runtime parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25970 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Katrin Fischer --- This is available in 23.11, but I believe at least 23.05 as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 18:06:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 17:06:21 +0000 Subject: [Koha-bugs] [Bug 13325] Create a nice view of budget and fund changes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 --- Comment #25 from Katrin Fischer --- I missed the earlier comment pointing it out already - yes, maybe we should resolve them. Just going through old bugs, it's hard to keep an overview. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 18:19:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 17:19:18 +0000 Subject: [Koha-bugs] [Bug 24438] index can fail on timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24438 --- Comment #2 from Katrin Fischer --- 3 years later - does this problem still exist in our current implementation? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 18:30:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 17:30:46 +0000 Subject: [Koha-bugs] [Bug 26391] Patron import tool notes info is incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26391 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Summary|patron import tool notes |Patron import tool notes |info is incorrect |info is incorrect -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 18:41:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 17:41:41 +0000 Subject: [Koha-bugs] [Bug 26409] Possible Duplication of Serials occurs during receiving process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26409 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Katrin Fischer --- Reading this again it feels like a misunderstanding. Changing the serial enumeration has no effect on the inner counters of the subscription and the prediction of the next issue. The enumeration, if changed, will be copied to the item form, when it's opened. But otherwise the 2 fields are independent from each other. The next issue predicted will be determined by the value in the subscription only. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 18:47:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 17:47:02 +0000 Subject: [Koha-bugs] [Bug 26410] Improve serial receive table headers when items are created on receive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26410 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Adding Supplemental Issues, |Improve serial receive |column headings are not |table headers when items |labeled. |are created on receive --- Comment #2 from Katrin Fischer --- I am not sure about this one. The headers of the table apply to the supplemental issue as well. It's only when creating items, that the item form gets in between a bit. This is not specific to supplemental issues, but also happens when you have multiple issues to be received in the list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 18:50:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 17:50:13 +0000 Subject: [Koha-bugs] [Bug 35445] OPAC registration verification triggered by email URL scanners In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35445 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 9 20:36:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Dec 2023 19:36:30 +0000 Subject: [Koha-bugs] [Bug 35413] Terminology: differentiate issues for vendor issues and serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35413 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #4 from Victor Grousset/tuxayo --- Shouldn't there be a database migration for existing installs? Because they will still have the old description: select * from permissions where code = 'issue_manage'; | module_bit | code | description | | 11 | issue_manage | Manage issues | Or maybe it doesn't matter because where is permissions.description used anyway? The test plan seems to looks in the right places and they don't use permissions.description. Otherwise, all looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 09:24:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 08:24:45 +0000 Subject: [Koha-bugs] [Bug 25979] In Firefox, Koha will not respond to first attempt at adding a duplicate field in Basic Editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- I also tested this and could not replicate the problem. Closing WORKSFORME, please re-open if you can still replicate the behaviour in maintained versions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 09:36:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 08:36:28 +0000 Subject: [Koha-bugs] [Bug 26342] Suspended hold not marked filled when patron checks out item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26342 --- Comment #1 from Katrin Fischer --- On first glance I think the behavior is correct. When the hold is suspended, it's not in effect, so it should not be triggered/filled. I think at the circulation desk, we could ask, but then the issue remains for SIP2/self checkout. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 09:52:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 08:52:35 +0000 Subject: [Koha-bugs] [Bug 26442] Account home page is missing the image icon for Dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26442 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #8 from Katrin Fischer --- We could not replicate the issue so far, so closing WORKSFORME, please re-open if you can still see this issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 09:55:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 08:55:40 +0000 Subject: [Koha-bugs] [Bug 26508] "sn:" shortcut to search by biblionumber is too broad In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26508 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 32707 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 09:55:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 08:55:40 +0000 Subject: [Koha-bugs] [Bug 32707] ElasticSearch should not auto truncate (even if QueryAutoTruncate = 1) for identifiers (and some other fields) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32707 --- Comment #12 from Katrin Fischer --- *** Bug 26508 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:05:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:05:18 +0000 Subject: [Koha-bugs] [Bug 26520] Can't change default messaging prefs on patron creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 30318 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:05:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:05:18 +0000 Subject: [Koha-bugs] [Bug 30318] Cannot override default patron messaging preferences when creating a patron in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30318 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Katrin Fischer --- *** Bug 26520 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:07:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:07:04 +0000 Subject: [Koha-bugs] [Bug 26527] Option for librarian to receive email when holds ratio above a set level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26527 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:09:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:09:08 +0000 Subject: [Koha-bugs] [Bug 26531] "add subfield" macro for Advanced Catalog Editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26531 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |Documentation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:15:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:15:21 +0000 Subject: [Koha-bugs] [Bug 25797] REST API using OAuth doesn't actually authorize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25797 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #9 from Katrin Fischer --- I wonder if this could be closed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:17:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:17:49 +0000 Subject: [Koha-bugs] [Bug 25806] Move Koha::CirculationRules special cases into overloaded Koha::CirculationRule method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25806 --- Comment #2 from Katrin Fischer --- Is this still valid? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:18:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:18:24 +0000 Subject: [Koha-bugs] [Bug 35522] New: Error in Upgrading: ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 741 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35522 Bug ID: 35522 Summary: Error in Upgrading: ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 741 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: hbala at ou.ac.lk QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 159694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159694&action=edit Koha upgrading issues: Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1 Cannot upgrade the Koha , Following error message appears in both command line updating and web base upgrading process ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 741 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:22:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:22:45 +0000 Subject: [Koha-bugs] [Bug 25824] DecreaseLoanHighHolds.t is still failing randomly 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25824 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |chris at bigballofwax.co.nz |ity.org | Component|Circulation |Test Suite -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:27:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:27:39 +0000 Subject: [Koha-bugs] [Bug 25884] Automatic item modifications by age needs title and description fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25884 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:34:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:34:03 +0000 Subject: [Koha-bugs] [Bug 25900] QueryWeightFields creates unnecessary whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 --- Comment #24 from Katrin Fischer --- (In reply to Katrin Fischer from comment #23) > Please add a unit test! Still waiting for a test - please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:35:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:35:18 +0000 Subject: [Koha-bugs] [Bug 25901] Add option for ClaimsReturnedWarningThreshold to count only unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901 --- Comment #5 from Katrin Fischer --- Does it need to be an option? It seems like it might not work as expected right now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:39:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:39:26 +0000 Subject: [Koha-bugs] [Bug 25976] Convert 'Writeoff' to a modal available under Transactions tab in patron accounting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 24079 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:39:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:39:26 +0000 Subject: [Koha-bugs] [Bug 24079] Convert paycollect 'page' to a modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079 --- Comment #2 from Katrin Fischer --- *** Bug 25976 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:39:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:39:27 +0000 Subject: [Koha-bugs] [Bug 17735] Merge boraccount and pay pages into one In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 Bug 17735 depends on bug 25976, which changed state. Bug 25976 Summary: Convert 'Writeoff' to a modal available under Transactions tab in patron accounting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25976 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:40:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:40:41 +0000 Subject: [Koha-bugs] [Bug 25737] Allow for claims returned status in lost authorized value to be library specific In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25737 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Summary|Allow for Claims Returned |Allow for claims returned |status in Lost Authorized |status in lost authorized |Value to be branch specific |value to be library | |specific -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:46:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:46:30 +0000 Subject: [Koha-bugs] [Bug 25766] Install error on 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25766 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- (In reply to Jonathan Druart from comment #1) > What is the full error you see in the Koha log file? There wasn't any additional information provided to help resolve the issue. Closing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:50:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:50:26 +0000 Subject: [Koha-bugs] [Bug 25719] Add system preference for logged in patrons to display only the patron's first name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- I think we should merge this with the discussion on bug 26607. *** This bug has been marked as a duplicate of bug 26607 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:53:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:53:54 +0000 Subject: [Koha-bugs] [Bug 25736] ClaimsReturnedWarningThreshold should be disabled by being unset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25736 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25901 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:53:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:53:54 +0000 Subject: [Koha-bugs] [Bug 25901] Add option for ClaimsReturnedWarningThreshold to count only unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25736 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:56:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:56:16 +0000 Subject: [Koha-bugs] [Bug 25770] vars loggedinusername and loggedinusernumber should be replaced by use of logged_in_user in templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25770 --- Comment #1 from Katrin Fischer --- Can you explain this one a bit more? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 10:59:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 09:59:00 +0000 Subject: [Koha-bugs] [Bug 25784] Flag to make individual items non-holdable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25784 --- Comment #1 from Katrin Fischer --- Maybe an equivalent to ItemsDeniedRenewal could work here: ItemsDeniedHold ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 11:00:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 10:00:02 +0000 Subject: [Koha-bugs] [Bug 25788] Club holds should have an optional expiration date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25788 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 11:04:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 10:04:30 +0000 Subject: [Koha-bugs] [Bug 25657] Remove username and cardnumber from default value form in patron import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove username from |Remove username and |default value form in |cardnumber from default |patron import |value form in patron import -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 11:06:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 10:06:04 +0000 Subject: [Koha-bugs] [Bug 25660] Unable to change system preferences in "vintage" git install without plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25660 --- Comment #5 from Katrin Fischer --- Hi Caroline, did you find a solution to this problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 11:09:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 10:09:44 +0000 Subject: [Koha-bugs] [Bug 25676] Staff interface catalog search shows incorrect item status under location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Staff client catalog search |Staff interface catalog |shows incorrect item status |search shows incorrect item |under location |status under location -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 11:12:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 10:12:26 +0000 Subject: [Koha-bugs] [Bug 25579] Holds tracker page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25579 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Hold requests Summary|Holds Tracker Page |Holds tracker page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 11:16:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 10:16:43 +0000 Subject: [Koha-bugs] [Bug 25604] Plugin unlinking failing during uninstall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25604 --- Comment #3 from Katrin Fischer --- Can you tell if this one is still valid? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 11:40:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 10:40:09 +0000 Subject: [Koha-bugs] [Bug 24425] Remove utf8 as an export option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #3 from Katrin Fischer --- I believe all available options produce different formats/output, so this might be invalid. The internal naming could probably be improved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:19:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:19:24 +0000 Subject: [Koha-bugs] [Bug 35523] New: Fix doubled up quotes in cash register deletion confirmation message Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35523 Bug ID: 35523 Summary: Fix doubled up quotes in cash register deletion confirmation message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:19:30 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:19:30 +0000 Subject: [Koha-bugs] [Bug 35523] Fix doubled up quotes in cash register deletion confirmation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:23:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:23:21 +0000 Subject: [Koha-bugs] [Bug 35523] Fix doubled up quotes in cash register deletion confirmation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35523 --- Comment #1 from Katrin Fischer --- Created attachment 159695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159695&action=edit Bug 35523: Fix doubled up quotes in cash register title Updates ''{cash_register}'' to '{cash_register}' To test: I believe this is not actually testable, as cash registers can only be archived and not deleted? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:24:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:24:09 +0000 Subject: [Koha-bugs] [Bug 35523] Fix doubled up quotes in cash register deletion confirmation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|NEW |Needs Signoff --- Comment #2 from Katrin Fischer --- This is a bit of an odd one, as we have code and strings for cash register deletion, but I believe this is not possible via the GUI? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:28:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:28:40 +0000 Subject: [Koha-bugs] [Bug 35524] New: Terminology: Bookseller in basket CSV export Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35524 Bug ID: 35524 Summary: Terminology: Bookseller in basket CSV export Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:29:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:29:14 +0000 Subject: [Koha-bugs] [Bug 35524] Terminology: Bookseller in basket CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:30:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:30:59 +0000 Subject: [Koha-bugs] [Bug 35524] Terminology: Bookseller in basket group CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Terminology: Bookseller in |Terminology: Bookseller in |basket CSV export |basket group CSV export -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:34:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:34:01 +0000 Subject: [Koha-bugs] [Bug 35524] Terminology: Bookseller in basket group CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:34:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:34:03 +0000 Subject: [Koha-bugs] [Bug 35524] Terminology: Bookseller in basket group CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35524 --- Comment #1 from Katrin Fischer --- Created attachment 159696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159696&action=edit Bug 35524: Fix terminology in basket group CSV export Bookseller should be vendor to match our preferred terminology. To test: * Run: prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t * Add a basket with at least one order line * Close basket and add to a basket group * Close the basket group * Export as CSV * Verify headers include "Bookseller" * Apply patch, restart all * Repeat export, it should now say "Vendor" * Rerun tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:35:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:35:24 +0000 Subject: [Koha-bugs] [Bug 35525] New: Spelling: SMS is an abbreviation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 Bug ID: 35525 Summary: Spelling: SMS is an abbreviation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:48:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:48:08 +0000 Subject: [Koha-bugs] [Bug 35525] Spelling: SMS is an abbreviation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:48:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:48:10 +0000 Subject: [Koha-bugs] [Bug 35525] Spelling: SMS is an abbreviation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 --- Comment #1 from Katrin Fischer --- Created attachment 159697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159697&action=edit Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC Updates sms to SMS. * Apply patch * Set SMSSendDriver system preference to Email * Go to the OPAC patron account, messaging tab * Check some SMS check boxes and save * Verify that the source code for the checked and unchecked the aria-label now reads "Select/Unselect SMS messaging" Also fixes a mismatched itiva message. Repeat test plan with TalkingTechItivaPhoneNotification Enabled and the phone checkboxes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:49:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:49:38 +0000 Subject: [Koha-bugs] [Bug 35526] New: Terminology: Id is an abbreviation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35526 Bug ID: 35526 Summary: Terminology: Id is an abbreviation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 14:50:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 13:50:26 +0000 Subject: [Koha-bugs] [Bug 35526] Terminology: Id, sushi and counter are abbreviations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35526 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Terminology: Id is an |Terminology: Id, sushi and |abbreviation |counter are abbreviations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 15:03:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 14:03:27 +0000 Subject: [Koha-bugs] [Bug 35526] Terminology: Id, sushi and counter are abbreviations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35526 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 15:03:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 14:03:29 +0000 Subject: [Koha-bugs] [Bug 35526] Terminology: Id, sushi and counter are abbreviations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35526 --- Comment #1 from Katrin Fischer --- Created attachment 159698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159698&action=edit Bug 35526: Fix terminology and spelling for ERM data providers This makes several changes on the form for adding a data provider and on the data provider details page: * Enable ERMModule system preference * Go to the ERM module, add a new data provider * Look at the labels on the form * Save and check the labels on the summary tab * Apply patch, run: yarn build * Verify fixes ...Id => ID ...sushi => SUSHI ...counter => COUNTER ...Report Release => Report release ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 15:03:38 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 14:03:38 +0000 Subject: [Koha-bugs] [Bug 35526] Terminology: Id, sushi and counter are abbreviations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35526 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 15:03:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 14:03:47 +0000 Subject: [Koha-bugs] [Bug 35525] Spelling: SMS is an abbreviation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |String patch Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 15:03:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 14:03:58 +0000 Subject: [Koha-bugs] [Bug 35524] Terminology: Bookseller in basket group CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35524 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 15:04:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 14:04:15 +0000 Subject: [Koha-bugs] [Bug 35523] Fix doubled up quotes in cash register deletion confirmation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35523 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 15:09:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 14:09:09 +0000 Subject: [Koha-bugs] [Bug 35527] New: Accessibility: Don't use "Click" in link descriptions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35527 Bug ID: 35527 Summary: Accessibility: Don't use "Click" in link descriptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org For accessilibity we should avoid "click to" and similar in link descriptions. See: https://usability.yale.edu/web-accessibility/articles/links#link-text https://www.w3.org/TR/WCAG20-TECHS/F84.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 15:55:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 14:55:43 +0000 Subject: [Koha-bugs] [Bug 35527] [Omnibus] Accessibility: Don't use "Click" in link descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35527 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility: Don't use |[Omnibus] Accessibility: |"Click" in link |Don't use "Click" in link |descriptions |descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 15:56:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 14:56:28 +0000 Subject: [Koha-bugs] [Bug 35528] New: Avoid 'click' for links in system preferences Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35528 Bug ID: 35528 Summary: Avoid 'click' for links in system preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Blocks: 35527 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35527 [Bug 35527] [Omnibus] Accessibility: Don't use "Click" in link descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 15:56:28 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 14:56:28 +0000 Subject: [Koha-bugs] [Bug 35527] [Omnibus] Accessibility: Don't use "Click" in link descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35527 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35528 [Bug 35528] Avoid 'click' for links in system preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:05:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:05:50 +0000 Subject: [Koha-bugs] [Bug 35528] Avoid 'click' for links in system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:05:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:05:53 +0000 Subject: [Koha-bugs] [Bug 35528] Avoid 'click' for links in system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35528 --- Comment #1 from Katrin Fischer --- Created attachment 159699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159699&action=edit Bug 35528: Remove 'click' from links in system preferences It's not necessary to label a link with 'click', it being a link and being formatted as such is enough. This updates the occurences in the sytem preferences editor. To test: * Go to system preferences like OpacUserCSS that allow editing in a textarea * Verify link descrptions for editing and collapsing the area * For a section of grouped system preferences, hover over the arrow and verify the text for collapsing/uncollapsing the area * Apply patch, restart all * Verify the links and tool tips have been updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:08:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:08:43 +0000 Subject: [Koha-bugs] [Bug 35529] New: Avoid 'click' for links in library administration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35529 Bug ID: 35529 Summary: Avoid 'click' for links in library administration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Blocks: 35527 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35527 [Bug 35527] [Omnibus] Accessibility: Don't use "Click" in link descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:08:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:08:43 +0000 Subject: [Koha-bugs] [Bug 35527] [Omnibus] Accessibility: Don't use "Click" in link descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35527 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35529 [Bug 35529] Avoid 'click' for links in library administration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:08:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:08:52 +0000 Subject: [Koha-bugs] [Bug 35529] Avoid 'click' for links in library administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35529 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:13:35 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:13:35 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #69 from Katrin Fischer --- >From the GUI it's not obvious that the new options are for the OPAC - was this intentional? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:16:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:16:37 +0000 Subject: [Koha-bugs] [Bug 35530] New: Can't tell if UserCSS and UserJS in ibraries are for staff interface or OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 Bug ID: 35530 Summary: Can't tell if UserCSS and UserJS in ibraries are for staff interface or OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 32721 It looks like they are for OPAC, but it's not visible in the library edit form. We should add a hint or rename the options with prefix OPAC. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:16:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:16:37 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35530 [Bug 35530] Can't tell if UserCSS and UserJS in ibraries are for staff interface or OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:17:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:17:09 +0000 Subject: [Koha-bugs] [Bug 32721] Allow specifying UserCSS and UserJS at library level for the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32721 --- Comment #70 from Katrin Fischer --- (In reply to Nick Clemens from comment #39) > One more question: should these be 'opacuserjs' and 'opacusercss' in the > case of implementing the same feature in the staff client? It was not changed/updated in the end, I filed: Bug 35530 - Can't tell if UserCSS and UserJS in ibraries are for staff interface or OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:18:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:18:57 +0000 Subject: [Koha-bugs] [Bug 35529] Avoid 'click' for links in library administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35529 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:19:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:19:00 +0000 Subject: [Koha-bugs] [Bug 35529] Avoid 'click' for links in library administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35529 --- Comment #1 from Katrin Fischer --- Created attachment 159700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159700&action=edit Bug 35529: Avoid 'click' in link in library administration It's not necessary to label a link with 'click', it being a link and being formatted as such is enough. To test: * Go to administration > libraries * Edit any library * Verify link texts for UserCSS and UserJS * Click to edit * Click to collapse * Apply patch, restart all * Verify links have been updated, click removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:19:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:19:12 +0000 Subject: [Koha-bugs] [Bug 35529] Avoid 'click' for links in library administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35529 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:31:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:31:13 +0000 Subject: [Koha-bugs] [Bug 35525] Spelling: SMS is an abbreviation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159697|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 159701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159701&action=edit Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC Updates sms to SMS. * Set SMSSendDriver system preference to Email * Go to the OPAC patron account, messaging tab * Check some SMS check boxes and save * Verify that in the source code the aria-label for the checked and unchecked checkboxes reads: sms messaging * Verify that in the source code for the 'days in advance' pull down, the message reads "... receive notice" * Apply patch, restart all * Verify that the source code for the checked and unchecked the aria-label now reads "Select/Unselect SMS messaging" * Verify that the aria-label on the 'days in advance' pull down now reads 'receive the message' Also fixes a mismatched itiva message. Repeat test plan with TalkingTechItivaPhoneNotification Enabled and the phone checkboxes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:34:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:34:23 +0000 Subject: [Koha-bugs] [Bug 35531] New: Add context for translation of gender option "Other" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35531 Bug ID: 35531 Summary: Add context for translation of gender option "Other" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr, jonathan.druart+koha at gmail.com Depends on: 25364 Other can be translated in different ways and especially as a gender option it would be nice to have context for translation. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 [Bug 25364] Add "Other" to the gender options in a patron record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 16:34:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 15:34:23 +0000 Subject: [Koha-bugs] [Bug 25364] Add "Other" to the gender options in a patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35531 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35531 [Bug 35531] Add context for translation of gender option "Other" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 17:01:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 16:01:56 +0000 Subject: [Koha-bugs] [Bug 35531] Add context for translation of gender option "Other" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35531 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 17:01:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 16:01:58 +0000 Subject: [Koha-bugs] [Bug 35531] Add context for translation of gender option "Other" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35531 --- Comment #1 from Katrin Fischer --- Created attachment 159702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159702&action=edit Bug 35531: Add context for translating gender option "Other" To test: * Apply patch * Verify the option "Other" for gender is correctly displayed when: * Editing a patron record in the staff interface * Viewing the 'Details' tab of a patron in staff interface * Triggering a "duplicate" patron warning and looking at the details of the existing patron record * Self registering a patron in the OPAC * Viewing 'Personal details' tab in the OPAC for a registered patron * If you are using ktd, run: gulp po:update --lang de-DE * Verify string "gender" appears with the occurences of "Other"and "Other:" in misc/translator/Koha-messages.pot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 17:28:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 16:28:25 +0000 Subject: [Koha-bugs] [Bug 35531] Add context for translation of gender option "Other" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35531 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159702|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 159703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159703&action=edit Bug 35531: Add context for translating gender option "Other" To test: * Apply patch * Verify the option "Other" for gender is correctly displayed when: * Editing a patron record in the staff interface * Viewing the 'Details' tab of a patron in staff interface * Triggering a "duplicate" patron warning and looking at the details of the existing patron record * Self registering a patron in the OPAC * Viewing 'Personal details' tab in the OPAC for a registered patron * If you are using ktd, run: gulp po:update --lang de-DE * Verify string "gender" appears with the occurences of "Other"and "Other:" in misc/translator/Koha-messages.pot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 17:42:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 16:42:05 +0000 Subject: [Koha-bugs] [Bug 35482] Trusted self check modal too small for translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35482 --- Comment #2 from Katrin Fischer --- The problem is visible after the first checkout as the table of checkouts doesn't quite fit into the modal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 17:53:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 16:53:59 +0000 Subject: [Koha-bugs] [Bug 35532] New: Calendar in booking modal requires 2 clicks to take date Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 Bug ID: 35532 Summary: Calendar in booking modal requires 2 clicks to take date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 29002 When making a booking in the staff interface, clicking on the date once won't take, you need to click a second time. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 17:53:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 16:53:59 +0000 Subject: [Koha-bugs] [Bug 29002] Add ability to book items ahead of time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35532 [Bug 35532] Calendar in booking modal requires 2 clicks to take date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 17:55:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 16:55:07 +0000 Subject: [Koha-bugs] [Bug 35475] Untranslatable strings in booking modal and JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Summary|Untranslatable string in |Untranslatable strings in |booking modal |booking modal and JS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 17:55:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 16:55:17 +0000 Subject: [Koha-bugs] [Bug 35475] Untranslatable strings in booking modal and JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 18:26:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 17:26:45 +0000 Subject: [Koha-bugs] [Bug 35475] Untranslatable strings in booking modal and JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 18:26:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 17:26:47 +0000 Subject: [Koha-bugs] [Bug 35475] Untranslatable strings in booking modal and JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 --- Comment #1 from Katrin Fischer --- Created attachment 159704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159704&action=edit Bug 35475: Makes strings in booking JS file translatable This makes several strings in the booking specific JS file translatable. To test: * Make an item bookable: * Find a record with items in your catalog or create one * From the details page, switch to the items tab * Mark items as bookable * Add a booking, verify the modal works as expected * Check the bookings tab * Verify the column headings of the bookings table show correctly * Verify the "Biblio level" and "Item" in the calendar show Note: Months don't translate, this will be a separate bug * Cancel a booking, edit a booking... make sure everything works as expected * If you can: Install a translation and verify strings show up in po files as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 21:09:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 20:09:51 +0000 Subject: [Koha-bugs] [Bug 35533] New: use a specific framework for specific vendor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35533 Bug ID: 35533 Summary: use a specific framework for specific vendor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org Use case : if some vendor sells ebooks and not printed books, a specific framework (different from ACQ) could be used to define relevant values in item fields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 21:32:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 20:32:32 +0000 Subject: [Koha-bugs] [Bug 25797] REST API using OAuth doesn't actually authorize In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25797 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #10 from Aleisha Amohia --- Let's close it for the sake of cleanup and if it turns out to still be valid a new one can be opened. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 21:36:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 20:36:37 +0000 Subject: [Koha-bugs] [Bug 25848] Allow staff to cancel subscription alerts on behalf of patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25848 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Aleisha Amohia --- Cool! Let's close this one then *** This bug has been marked as a duplicate of bug 28130 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 21:36:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 20:36:37 +0000 Subject: [Koha-bugs] [Bug 28130] Show list of serial email alerts a patron subscribed to in patron account in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28130 --- Comment #20 from Aleisha Amohia --- *** Bug 25848 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 23:25:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 22:25:09 +0000 Subject: [Koha-bugs] [Bug 25604] Plugin unlinking failing during uninstall In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25604 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #4 from David Cook --- (In reply to Katrin Fischer from comment #3) > Can you tell if this one is still valid? Ehhh I just tried uninstalling a plugin on master and it seems fine. Either it's fixed or the issue I had is old. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 23:26:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 22:26:49 +0000 Subject: [Koha-bugs] [Bug 25660] Unable to change system preferences in "vintage" git install without plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25660 --- Comment #6 from David Cook --- I think we might not be supporting non-Plack anymore... I imagine Caroline must be using koha-testing-docker these days as well? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 10 23:41:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Dec 2023 22:41:33 +0000 Subject: [Koha-bugs] [Bug 26740] REST API: Add endpoint for task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26740 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from David Cook --- (In reply to Katrin Fischer from comment #1) > Is this resolved? > > https://api.koha-community.org/#tag/jobs It looks like you can only get/list jobs. The search also looks like it could have some issues if used outside of the current context (ie the Admin module)... I'm happy to close this one though as I don't think I'll work on it, and I'm not sure it's even a good idea. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 08:40:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 07:40:43 +0000 Subject: [Koha-bugs] [Bug 25965] Create SIP2 client daemon with HTTPS API endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25965 --- Comment #24 from Lari Strand --- (In reply to Katrin Fischer from comment #23) > Hi Lari, does you plugin cover the full functionality or are there any > changes needed in Koha still? > > We could add it to https://wiki.koha-community.org/wiki/Koha_plugins and > close the bug maybe. It covers the full functionality of SIP2 and acts as a wrapper for talking to the Koha SIP2 server. Some changes to the SIP server configuration file is needed, nothing else. So yes it works as a "standalone" plugin. I guess we could close the ticket. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 09:30:55 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 08:30:55 +0000 Subject: [Koha-bugs] [Bug 35534] New: Wrong encoding of reports exported in tab format Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35534 Bug ID: 35534 Summary: Wrong encoding of reports exported in tab format Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: mathsabypro at gmail.com QA Contact: testopia at bugs.koha-community.org Reports exported in csv are encoded in unicode. In tab they are encoding in ANSI. If a record contains unicode characters, this is problematic. Maybe linked to https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45501&action=diff ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 09:31:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 08:31:07 +0000 Subject: [Koha-bugs] [Bug 35534] Wrong encoding of reports exported in tab format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35534 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:14:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:14:08 +0000 Subject: [Koha-bugs] [Bug 25965] Create SIP2 client daemon with HTTPS API endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25965 --- Comment #25 from Katrin Fischer --- (In reply to Lari Strand from comment #24) > (In reply to Katrin Fischer from comment #23) > > Hi Lari, does you plugin cover the full functionality or are there any > > changes needed in Koha still? > > > > We could add it to https://wiki.koha-community.org/wiki/Koha_plugins and > > close the bug maybe. > > It covers the full functionality of SIP2 and acts as a wrapper for talking > to the Koha SIP2 server. Some changes to the SIP server configuration file > is needed, nothing else. So yes it works as a "standalone" plugin. I guess > we could close the ticket. Please do :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:16:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:16:21 +0000 Subject: [Koha-bugs] [Bug 25965] Create SIP2 client daemon with HTTPS API endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25965 --- Comment #26 from Marcel de Rooy --- I have the idea that the reason behind this report is still valid. People want to protect their SIP2 communication and this is still not available in standard Koha. But it might deserve a report on its own? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:17:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:17:17 +0000 Subject: [Koha-bugs] [Bug 35526] Terminology: Id, sushi and counter are abbreviations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35526 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:17:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:17:19 +0000 Subject: [Koha-bugs] [Bug 35526] Terminology: Id, sushi and counter are abbreviations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35526 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159698|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159705&action=edit Bug 35526: Fix terminology and spelling for ERM data providers This makes several changes on the form for adding a data provider and on the data provider details page: * Enable ERMModule system preference * Go to the ERM module, add a new data provider * Look at the labels on the form * Save and check the labels on the summary tab * Apply patch, run: yarn build * Verify fixes ...Id => ID ...sushi => SUSHI ...counter => COUNTER ...Report Release => Report release ... Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:23:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:23:29 +0000 Subject: [Koha-bugs] [Bug 35524] Terminology: Bookseller in basket group CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35524 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:23:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:23:31 +0000 Subject: [Koha-bugs] [Bug 35524] Terminology: Bookseller in basket group CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35524 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159696|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159706&action=edit Bug 35524: Fix terminology in basket group CSV export Bookseller should be vendor to match our preferred terminology. To test: * Run: prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t * Add a basket with at least one order line * Close basket and add to a basket group * Close the basket group * Export as CSV * Verify headers include "Bookseller" * Apply patch, restart all * Repeat export, it should now say "Vendor" * Rerun tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:30:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:30:58 +0000 Subject: [Koha-bugs] [Bug 35535] New: Candcel hold -button does not work in pop-up (Hold found, item is already waiting) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Bug ID: 35535 Summary: Candcel hold -button does not work in pop-up (Hold found, item is already waiting) Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: minna.kivinen at hamk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When you check in an item having awaiting hold there comes a pop-up window. There is a button saying Cancel hold. This button does not do anything. (you are able to cancel the hold from other hold windows) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:34:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:34:08 +0000 Subject: [Koha-bugs] [Bug 35535] Cancel hold -button does not work in pop-up (Hold found, item is already waiting) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35535 Minna Kivinen changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Candcel hold -button does |Cancel hold -button does |not work in pop-up (Hold |not work in pop-up (Hold |found, item is already |found, item is already |waiting) |waiting) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:35:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:35:39 +0000 Subject: [Koha-bugs] [Bug 35523] Fix doubled up quotes in cash register deletion confirmation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:35:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:35:41 +0000 Subject: [Koha-bugs] [Bug 35523] Fix doubled up quotes in cash register deletion confirmation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159695|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 159707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159707&action=edit Bug 35523: Fix doubled up quotes in cash register title Updates ''{cash_register}'' to '{cash_register}' To test: I believe this is not actually testable, as cash registers can only be archived and not deleted? Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:37:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:37:23 +0000 Subject: [Koha-bugs] [Bug 35523] Fix doubled up quotes in cash register deletion confirmation message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35523 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- (In reply to Katrin Fischer from comment #2) > This is a bit of an odd one, as we have code and strings for cash register > deletion, but I believe this is not possible via the GUI? I think that is the case. Deleting a cash register is not possible in the UI. Signing off based on reading the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:43:03 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:43:03 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #8 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #7) > Should we clear on all plugin-related test files? subtests? Should we > generalize this cleanup step? I know we rollback, and then call ->delete() > in some places, we should just add this cache cleaning too. > > $ ls t/db_dependent/Koha/Plugins/ > Account_hooks.t* Broken.t* Patron.t* > BackgroundJob.t* Circulation_hooks.t* Plugins.t* > Barcode_transform_hooks.t* Holds_hooks.t* > Recall_hooks.t* > Biblio_and_Items_plugin_hooks.t* KitchenSinkPlugin.kpz > authority_hooks.t* BackgroundJob.t does: $schema->storage->txn_rollback; Koha::Plugins::Methods->delete; Thats definitely in the wrong order. Same for Barcode_transform_hooks.t Copy/paste? Recall_hooks.t Biblio_and_Items_plugin_hooks.t Etc Yes, we should do some cleanup here ! A valid question is however why did we not see this failure much more? It surely depends on the excecution order of test scripts. This still needs a bit more digging. Will try now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:50:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:50:58 +0000 Subject: [Koha-bugs] [Bug 35528] Avoid 'click' for links in system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35528 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:51:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:51:00 +0000 Subject: [Koha-bugs] [Bug 35528] Avoid 'click' for links in system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35528 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159699|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159708&action=edit Bug 35528: Remove 'click' from links in system preferences It's not necessary to label a link with 'click', it being a link and being formatted as such is enough. This updates the occurences in the sytem preferences editor. To test: * Go to system preferences like OpacUserCSS that allow editing in a textarea * Verify link descrptions for editing and collapsing the area * For a section of grouped system preferences, hover over the arrow and verify the text for collapsing/uncollapsing the area * Apply patch, restart all * Verify the links and tool tips have been updated Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:54:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:54:19 +0000 Subject: [Koha-bugs] [Bug 35529] Avoid 'click' for links in library administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35529 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:54:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:54:21 +0000 Subject: [Koha-bugs] [Bug 35529] Avoid 'click' for links in library administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35529 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159700|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159709&action=edit Bug 35529: Avoid 'click' in link in library administration It's not necessary to label a link with 'click', it being a link and being formatted as such is enough. To test: * Go to administration > libraries * Edit any library * Verify link texts for UserCSS and UserJS * Click to edit * Click to collapse * Apply patch, restart all * Verify links have been updated, click removed Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 10:58:46 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 09:58:46 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #9 from Marcel de Rooy --- Most of the time it is wrong. If you would have plugins on your system, they are removed too. git grep -C1 -P "Plugins::Methods?->delete" t/db_dependent/Koha/Plugins/Account_hooks.t- t/db_dependent/Koha/Plugins/Account_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Account_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/BackgroundJob.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/BackgroundJob.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/BackgroundJob.t-}; -- t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t-}; -- t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t-}; -- t/db_dependent/Koha/Plugins/Circulation_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Circulation_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Circulation_hooks.t-}; -- t/db_dependent/Koha/Plugins/Holds_hooks.t- t/db_dependent/Koha/Plugins/Holds_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Account_hooks.t- t/db_dependent/Koha/Plugins/Account_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Account_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/BackgroundJob.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/BackgroundJob.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/BackgroundJob.t-}; -- t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t-}; -- t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t-}; -- t/db_dependent/Koha/Plugins/Circulation_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Circulation_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Circulation_hooks.t-}; -- t/db_dependent/Koha/Plugins/Holds_hooks.t- t/db_dependent/Koha/Plugins/Holds_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Holds_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/Holds_hooks.t- t/db_dependent/Koha/Plugins/Holds_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Holds_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/Holds_hooks.t- t/db_dependent/Koha/Plugins/Holds_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Holds_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/Patron.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Patron.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Patron.t-}; -- t/db_dependent/Koha/Plugins/Plugins.t- # Temporarily remove any installed plugins data t/db_dependent/Koha/Plugins/Plugins.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t- $schema->resultset('PluginData')->delete(); -- t/db_dependent/Koha/Plugins/Plugins.t- # Temporarily remove any installed plugins data t/db_dependent/Koha/Plugins/Plugins.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t- $schema->resultset('PluginData')->delete(); -- t/db_dependent/Koha/Plugins/Plugins.t- # Temporarily remove any installed plugins data t/db_dependent/Koha/Plugins/Plugins.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t- $schema->resultset('PluginData')->delete(); -- root at master:/usr/share/koha# git grep -C1 -P "Plugins::Methods?->delete" t/db_dependent/Koha/Plugins/Account_hooks.t- t/db_dependent/Koha/Plugins/Account_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Account_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/BackgroundJob.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/BackgroundJob.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/BackgroundJob.t-}; -- t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t-}; -- t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t-}; -- t/db_dependent/Koha/Plugins/Circulation_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Circulation_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Circulation_hooks.t-}; -- t/db_dependent/Koha/Plugins/Holds_hooks.t- t/db_dependent/Koha/Plugins/Holds_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Holds_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/Holds_hooks.t- t/db_dependent/Koha/Plugins/Holds_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Holds_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/Holds_hooks.t- t/db_dependent/Koha/Plugins/Holds_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Holds_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/Patron.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Patron.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Patron.t-}; -- t/db_dependent/Koha/Plugins/Plugins.t- # Temporarily remove any installed plugins data t/db_dependent/Koha/Plugins/Plugins.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t- $schema->resultset('PluginData')->delete(); -- t/db_dependent/Koha/Plugins/Plugins.t- # Temporarily remove any installed plugins data t/db_dependent/Koha/Plugins/Plugins.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t- $schema->resultset('PluginData')->delete(); -- t/db_dependent/Koha/Plugins/Plugins.t- # Temporarily remove any installed plugins data t/db_dependent/Koha/Plugins/Plugins.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t- $schema->resultset('PluginData')->delete(); -- t/db_dependent/Koha/Plugins/Plugins.t- # Temporarily remove any installed plugins data t/db_dependent/Koha/Plugins/Plugins.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t- -- t/db_dependent/Koha/Plugins/Plugins.t- # Make sure there's no previous installs or leftovers on DB t/db_dependent/Koha/Plugins/Plugins.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t- $schema->resultset('PluginData')->delete; -- t/db_dependent/Koha/Plugins/Plugins.t-$schema->storage->txn_begin; t/db_dependent/Koha/Plugins/Plugins.t:Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t-$schema->resultset('PluginData')->delete; -- t/db_dependent/Koha/Plugins/Plugins.t- t/db_dependent/Koha/Plugins/Plugins.t:Koha::Plugins::Methods->delete; -- t/db_dependent/Koha/Plugins/Recall_hooks.t- t/db_dependent/Koha/Plugins/Recall_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Recall_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/authority_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/authority_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/authority_hooks.t-}; root at master:/usr/share/koha# git grep -C1 -P "Plugins::Methods?->delete" > zzz root at master:/usr/share/koha# cat zzz t/db_dependent/Koha/Plugins/Account_hooks.t- t/db_dependent/Koha/Plugins/Account_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Account_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/BackgroundJob.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/BackgroundJob.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/BackgroundJob.t-}; -- t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Barcode_transform_hooks.t-}; -- t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t-}; -- t/db_dependent/Koha/Plugins/Circulation_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Circulation_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Circulation_hooks.t-}; -- t/db_dependent/Koha/Plugins/Holds_hooks.t- t/db_dependent/Koha/Plugins/Holds_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Holds_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/Holds_hooks.t- t/db_dependent/Koha/Plugins/Holds_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Holds_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/Holds_hooks.t- t/db_dependent/Koha/Plugins/Holds_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Holds_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/Patron.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/Patron.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Patron.t-}; -- t/db_dependent/Koha/Plugins/Plugins.t- # Temporarily remove any installed plugins data t/db_dependent/Koha/Plugins/Plugins.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t- $schema->resultset('PluginData')->delete(); -- t/db_dependent/Koha/Plugins/Plugins.t- # Temporarily remove any installed plugins data t/db_dependent/Koha/Plugins/Plugins.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t- $schema->resultset('PluginData')->delete(); -- t/db_dependent/Koha/Plugins/Plugins.t- # Temporarily remove any installed plugins data t/db_dependent/Koha/Plugins/Plugins.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t- $schema->resultset('PluginData')->delete(); -- t/db_dependent/Koha/Plugins/Plugins.t- # Temporarily remove any installed plugins data t/db_dependent/Koha/Plugins/Plugins.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t- -- t/db_dependent/Koha/Plugins/Plugins.t- # Make sure there's no previous installs or leftovers on DB t/db_dependent/Koha/Plugins/Plugins.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t- $schema->resultset('PluginData')->delete; -- t/db_dependent/Koha/Plugins/Plugins.t-$schema->storage->txn_begin; t/db_dependent/Koha/Plugins/Plugins.t:Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Plugins.t-$schema->resultset('PluginData')->delete; -- t/db_dependent/Koha/Plugins/Plugins.t- t/db_dependent/Koha/Plugins/Plugins.t:Koha::Plugins::Methods->delete; -- t/db_dependent/Koha/Plugins/Recall_hooks.t- t/db_dependent/Koha/Plugins/Recall_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/Recall_hooks.t- $schema->storage->txn_rollback; -- t/db_dependent/Koha/Plugins/authority_hooks.t- $schema->storage->txn_rollback; t/db_dependent/Koha/Plugins/authority_hooks.t: Koha::Plugins::Methods->delete; t/db_dependent/Koha/Plugins/authority_hooks.t-}; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:05:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:05:02 +0000 Subject: [Koha-bugs] [Bug 35475] Untranslatable strings in booking modal and JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Jonathan Druart --- Inconsistent use of _() and __() in .js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:05:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:05:47 +0000 Subject: [Koha-bugs] [Bug 25930] Datatables_Members.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25930 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Jonathan Druart --- No, this test file does no longer exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:05:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:05:47 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Bug 25551 depends on bug 25930, which changed state. Bug 25930 Summary: Datatables_Members.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25930 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:06:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:06:51 +0000 Subject: [Koha-bugs] [Bug 25770] vars loggedinusername and loggedinusernumber should be replaced by use of logged_in_user in templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25770 --- Comment #2 from Jonathan Druart --- See comments on those 2 lines: C4/Auth.pm: $template->param( loggedinusername => $user ); # OBSOLETE - Do not reuse this in template, use logged_in_user.userid instead C4/Auth.pm: $template->param( loggedinusernumber => $borrowernumber ); # FIXME Should be replaced with logged_in_user.borrowernumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:08:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:08:33 +0000 Subject: [Koha-bugs] [Bug 35475] Untranslatable strings in booking modal and JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35475 --- Comment #3 from Jonathan Druart --- Also I think that the following line content: _("Item") + " " + item.external_id, should be replaced with content: _("Item %s").format(item.external_id), -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:11:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:11:14 +0000 Subject: [Koha-bugs] [Bug 24107] returns.pl fetches the same item from the database multiple times In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24107 --- Comment #2 from Jonathan Druart --- Yes, still valid, see this comment 838 my $item_from_barcode = Koha::Items->find({barcode => $barcode }); # How many times do we fetch this item?!? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:11:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:11:37 +0000 Subject: [Koha-bugs] [Bug 35525] Spelling: SMS is an abbreviation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:11:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:11:40 +0000 Subject: [Koha-bugs] [Bug 35525] Spelling: SMS is an abbreviation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35525 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159701|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 159710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159710&action=edit Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC Updates sms to SMS. * Set SMSSendDriver system preference to Email * Go to the OPAC patron account, messaging tab * Check some SMS check boxes and save * Verify that in the source code the aria-label for the checked and unchecked checkboxes reads: sms messaging * Verify that in the source code for the 'days in advance' pull down, the message reads "... receive notice" * Apply patch, restart all * Verify that the source code for the checked and unchecked the aria-label now reads "Select/Unselect SMS messaging" * Verify that the aria-label on the 'days in advance' pull down now reads 'receive the message' Also fixes a mismatched itiva message. Repeat test plan with TalkingTechItivaPhoneNotification Enabled and the phone checkboxes. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:23:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:23:50 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #10 from Marcel de Rooy --- === Preliminary conclusion When you call InstallPlugins, or plugin->enable or ->disable, the cache will already be cleared. This covers quite a few cases. But not all, explaining for a bit the reduced number of failures. Things are definitely related to the KitchenSink stuff in Plugins.t and the order of execution. What about temporarily disabling plugins in TestBuilder.t ? Or in build_sample_biblio ? Does not sound very nice. Not the way to go imo. Adding a clear cache in Methods->delete probably works? Yes, we even catch the Handler->delete case too. Since Handler->delete calls uninstall on the plugin. Deletes from plugin_data. And does Methods->search->delete! But it does not feel like the best solution imo. The actions for deleting records in plugin_data and plugin_methods should be done on a general level and not be repeated in all those test scripts etc. (Which requires more code changes definitely. But reordering all deletes after rollback does require a lot of those changes too..) We need a simple fix that can be backported to versions having bug 29672 (i.e. 22.11) And an enhancement taking care of the cleanup and wrong order stuff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:24:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:24:24 +0000 Subject: [Koha-bugs] [Bug 35531] Add context for translation of gender option "Other" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35531 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:24:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:24:26 +0000 Subject: [Koha-bugs] [Bug 35531] Add context for translation of gender option "Other" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35531 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159703|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 159711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159711&action=edit Bug 35531: Add context for translating gender option "Other" To test: * Apply patch * Verify the option "Other" for gender is correctly displayed when: * Editing a patron record in the staff interface * Viewing the 'Details' tab of a patron in staff interface * Triggering a "duplicate" patron warning and looking at the details of the existing patron record * Self registering a patron in the OPAC * Viewing 'Personal details' tab in the OPAC for a registered patron * If you are using ktd, run: gulp po:update --lang de-DE * Verify string "gender" appears with the occurences of "Other"and "Other:" in misc/translator/Koha-messages.pot Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:25:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:25:42 +0000 Subject: [Koha-bugs] [Bug 35531] Add context for translation of gender option "Other" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35531 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | CC| |david at davidnind.com --- Comment #4 from David Nind --- Added assignee 8-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:30:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:30:25 +0000 Subject: [Koha-bugs] [Bug 35536] New: Improve cleanup/uninstall of Koha plugins Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Bug ID: 35536 Summary: Improve cleanup/uninstall of Koha plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org See bug 35507 comment10 a.o. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:30:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:30:52 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35536 --- Comment #11 from Marcel de Rooy --- Adding 35536 on top of this one. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 [Bug 35536] Improve cleanup/uninstall of Koha plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:30:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:30:52 +0000 Subject: [Koha-bugs] [Bug 35536] Improve cleanup/uninstall of Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35507 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 [Bug 35507] TestBuilder.t is failing randomly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:31:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:31:42 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159670|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Comment on attachment 159670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159670 Bug 35507: Clear cache key for enabled plugins at deletion Obsoleting in favor of another approach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 11:32:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 10:32:11 +0000 Subject: [Koha-bugs] [Bug 35536] Improve cleanup/uninstall of Koha plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35536 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 12:09:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 11:09:37 +0000 Subject: [Koha-bugs] [Bug 35537] New: Home entry in navigation can be misleading Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35537 Bug ID: 35537 Summary: Home entry in navigation can be misleading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Preservation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart+koha at gmail.com The "Home" entry in the navigation of the Preservation module looks very similar to the link in the breadcrumbs, but it doesn't lead to Koha's start page, but to the start page of the module. We should adjust the text, like we don in ohter modules (acq for example). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 12:31:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 11:31:21 +0000 Subject: [Koha-bugs] [Bug 26409] Possible Duplication of Serials occurs during receiving process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26409 --- Comment #3 from Kelly McElligott --- Katrin, Thank you! I completely understand what you are saying! Thank you! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 12:34:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 11:34:04 +0000 Subject: [Koha-bugs] [Bug 23756] Appendix for workflows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23756 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29712 --- Comment #2 from Aude Charillon --- Linked to the omnibus bug regarding a content and style guide for the Manual (hopefully I've done that correctly!) Workflows have been mentioned by other members of the Documentation team and we want to try and accommodate those. We will be discussing in upcoming meetings how to do that. Everyone can take part in the discussions; see https://wiki.koha-community.org/wiki/Category:Documentation_IRC_Meetings for the next meeting dates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 [Bug 29712] [DOCS] [Omnibus] Content development guide -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 12:34:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 11:34:04 +0000 Subject: [Koha-bugs] [Bug 29712] [DOCS] [Omnibus] Content development guide In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29712 Aude Charillon changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23756 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23756 [Bug 23756] Appendix for workflows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 13:15:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 12:15:58 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 13:16:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 12:16:25 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #13 from Katrin Fischer --- Is this ready for SO? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 13:18:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 12:18:34 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #8) > BackgroundJob.t does: > $schema->storage->txn_rollback; > Koha::Plugins::Methods->delete; > Thats definitely in the wrong order. I recall we did it that way because InstallPlugins triggered a commit on the transaction. So we decided 'plugin tests will be considered destructive' (in terms of the DB data) and did it this way so there's no test plugin information on the DB when other tests are run. Maybe that's no longer needed. But I don't recall any recent changes in the area. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 13:23:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 12:23:45 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #15 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #13) > Is this ready for SO? No, I removed the patch :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 13:29:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 12:29:20 +0000 Subject: [Koha-bugs] [Bug 35538] New: List of libraries on OPAC self registration form should sort by branchname rather than branchcode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35538 Bug ID: 35538 Summary: List of libraries on OPAC self registration form should sort by branchname rather than branchcode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucy.vaux-harvey at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The dropdown list of libraries on the OPAC self registration form is ordered by branchcode. It would be great if this list was ordered by branchname as it is for the Libraries search filter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 14:05:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 13:05:23 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 14:05:29 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 13:05:29 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152040|0 |1 is obsolete| | Attachment #156318|0 |1 is obsolete| | Attachment #156319|0 |1 is obsolete| | Attachment #156320|0 |1 is obsolete| | Attachment #156321|0 |1 is obsolete| | Attachment #156322|0 |1 is obsolete| | --- Comment #101 from Thibaud Guillot --- Created attachment 159712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159712&action=edit Bug 8137: Add 'global' has_priority rules for checkouts I tried to review the desired behavior through this bug. The goal would be to be able to have a general 'override' rule. Currently, if you set a max_checkouts_allowed of 5 (regardless of itemtype) in one library, for example, and do the same in another, it adds up to 10. By giving checkout rules priority, you "overwrite" other local rules per branchcode. Test plan: 1) Set for library "A" a max_checkouts_allowed to 3 for any type of user and item type. 2) On main rules set the same rule to 2 3) Do a few checkouts with a user belonging to library A, normally you'll be able to do 3. 4) Apply this patch and run updatedatabase.pl and also rebuild your schema by updating dbix class files 5) See now the Has priority checkboxes on "Default checkout, hold and return policy" and "Default checkout, hold policy by patron category" 6) You can set here you new rule for "Total current checkouts allowed" to 2 7) Repeat step 3 and normally you won't be able to make the third -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 14:05:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 13:05:44 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alex.arnaud at biblibre.com |thibaud.guillot at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 14:06:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 13:06:17 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Thibaud Guillot changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Checkout limit by patron |Checkout limit for all |category for all libraries |libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 14:06:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 13:06:37 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 --- Comment #102 from Thibaud Guillot --- During my test, in some use cases I got a "brake foreign key error" without really knowing why, so this is a reworking of the bug in order to bring a different solution and get your feedback so we can move it forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 14:27:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 13:27:48 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |pedro.amorim at ptfs-europe.co | |m, tomascohen at gmail.com Assignee|koha-bugs at lists.koha-commun |pedro.amorim at ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 14:47:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 13:47:10 +0000 Subject: [Koha-bugs] [Bug 33098] Revert suggestion status to 'Accepted' when orders made from a suggestion are cancelled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33098 Philip Orr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr at lmscloud.de Documentation| |Philip Orr contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/776 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 14:47:58 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 13:47:58 +0000 Subject: [Koha-bugs] [Bug 33550] Rename Patron restrictions administration page 'Patron restriction types' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33550 Philip Orr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 14:57:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 13:57:49 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #16 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #14) > I recall we did it that way because InstallPlugins triggered a commit on the > transaction. So we decided 'plugin tests will be considered destructive' (in > terms of the DB data) and did it this way so there's no test plugin > information on the DB when other tests are run. Interesting! I am not sure where that implicit commit hides? Do you see it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 14:59:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 13:59:22 +0000 Subject: [Koha-bugs] [Bug 25965] Create SIP2 client daemon with HTTPS API endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25965 --- Comment #27 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #26) > I have the idea that the reason behind this report is still valid. People > want to protect their SIP2 communication and this is still not available in > standard Koha. But it might deserve a report on its own? Unfortunately this won't protect or work with standard SIP2. SIP2 over http is not a commonly supported feature as far as I am aware. The standard for protecting regular SIP2 traffic would be stunnel. Many if not most SIP2 devices have stunnel support built in. As far as I can tell, there is no way to bake stunnel into our SIP server. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 15:34:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 14:34:59 +0000 Subject: [Koha-bugs] [Bug 35386] Renewals via the API are recorded using the branch of the API account used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35386 Brendan Lawlor changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor at clamsnet.org --- Comment #3 from Brendan Lawlor --- When I tested this out I confirmed before the patch the branch recorded for the renewal is the API user's homebranch. When I applied the patch I noticed the system preference RESTAPIRenewalBranch defaults to 'APIRenew' and when I made a post to {{base_url}}/api/v1/checkouts/1/renewal the branch recorded in the statistics table as 'API Renew' According to the test plan it should default to the branch of the api user. Also one of the options for RESTAPIRenewalBranch is NULL, which did work to record the branch in the statistics as NULL, but I'm not sure if that is an intended option. The other options I tested worked as expected for: the branch of the api user the library the item was checked out from the items home library NULL the patron's home library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 15:57:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 14:57:41 +0000 Subject: [Koha-bugs] [Bug 35254] Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35254 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #10 from Nick Clemens --- Any reason this was not backported to 22.11? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 16:18:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 15:18:33 +0000 Subject: [Koha-bugs] [Bug 35507] TestBuilder.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507 --- Comment #17 from Marcel de Rooy --- Lots of fun here in the meantime. Discovered that we miss a rollback in Plugins.t too. And running prove Plugins.t ends up with additional data in a clean master install: +----------------------------------------+-----------------------+--------------+ | plugin_class | plugin_key | plugin_value | +----------------------------------------+-----------------------+--------------+ | Koha::Plugin::BadAPIRoute | __INSTALLED_VERSION__ | 0.01 | | Koha::Plugin::MarcFieldValues | __INSTALLED_VERSION__ | 1 | | Koha::Plugin::Test | __ENABLED__ | 0 | | Koha::Plugin::Test | __INSTALLED__ | 1 | | Koha::Plugin::Test | __INSTALLED_VERSION__ | v1.01 | | Koha::Plugin::TestItemBarcodeTransform | __INSTALLED_VERSION__ | 1.01 | +----------------------------------------+-----------------------+--------------+ Still WIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 16:19:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 15:19:48 +0000 Subject: [Koha-bugs] [Bug 25159] Action logs should be stored in JSON ( and as a diff of the change ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159 --- Comment #32 from Kyle M Hall --- (In reply to Jonathan Druart from comment #29) > 1. I am not sure, but maybe we could pass $self and log > $self->get_from_store as the original (?) > Maybe we will lose flexibility however. I don't think I understand your question. Could you give me some more detail? > 2. What about the switch? Should we continue to log in 'info'? Yes, I think for the time being we should continue to log in `info`. We can EOL the info column at some point in the future, but we should give everyone plenty of advance notice if we ever choose to do so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 16:23:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 15:23:34 +0000 Subject: [Koha-bugs] [Bug 35254] Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35254 --- Comment #11 from Nick Clemens --- Created attachment 159713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159713&action=edit Bug 35254: [22.11.x] Add import_record_id to order inputs This patch follows the logic of bug 32166 and adds specific inputs for each order to avoid any misalignment when some records are not imported To test: 1 - Find a vendor in acquisitions 2 - Create or find an open basket 3 - Add to basket form a new file 4 - Stage file and add to basket 5 - Select the second record in the list 6 - Enter price info 7 - Save (don't forget, you need to set item type in the second tab) 8 - The order has no price info! 9 - Apply patch 10 - Repeat 3-7 above, staging file fresh 11 - Confirm order has correct prices 12 - Test with a file with many records 13 - Confirm any combination of choosing/skipping records works as expected Signed-off-by: Katrin Fischer Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 16:23:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 15:23:59 +0000 Subject: [Koha-bugs] [Bug 35254] Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35254 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 16:43:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 15:43:40 +0000 Subject: [Koha-bugs] [Bug 26483] Allow search-to-link for analytical cataloging of existing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26483 --- Comment #6 from Andrew Fuerste-Henry --- (In reply to Katrin Fischer from comment #5) > (In reply to Andrew Fuerste-Henry from comment #3) > > Thanks, Katrin, I hadn't played with marc21_linking_section.pl! It doesn't > > quite do what analytical cataloging needs, but it's a start! > > Can you explain what you are missing? Would that I could, but I must admit I have no memory of this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 16:47:22 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 15:47:22 +0000 Subject: [Koha-bugs] [Bug 23752] Search all z39.50 / SRU targets and resource discovery layer / open link resolver from any ILL backend In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23752 --- Comment #5 from Pedro Amorim --- (In reply to Katrin Fischer from comment #4) > I am not familiar with the kind of functionality the availability plugins > can provide, so adding Pedro, maybe he can help us get an idea what we > should do on Koha side and what would be better on the plugin end. Hi, thank you Katrin for bringing this to my attention. I'm not sure I understand the discussion entirely but I'll try my best to provide a useful contribution. I believe there are a couple of things being discussed here, one is the Koha2Koha backend: https://gitlab.com/koha-community/plugins/koha-plugin-ill-koha The other the z39.50 availabililty plugin: https://github.com/PTFS-Europe/koha-plugin-ill-avail-z3950 These 2 are not related and may be used separately. The former is a backend and allows the creation of a request. The latter is an availability plugin and it does not allow the creation of a request, it instead provides availability results prior to creating the request (regardless of which backend was selected). The z39.50 plugin's configuration allows for selecting a set of z39.50 providers from the total configured z39.50/SRU providers in Koha. The plugin requires the ILLCheckAvailability syspref to be enabled. Upon submitting the create request form (OPAC, Staff, or both - optionally configured) Koha will search the selected z39.50 providers with the metadata submitted in the form and comeback with the results. Each z39.50 provider may also be configured to be queried when placing the request with a partner. (In reply to Niamh Walker-Headon from comment #3) > Currently, since our last upgrade the availability plugin shows in the staff > client when creating a request > https://koha.hselibrary.ie/cgi-bin/koha/ill/ill-requests. > pl?method=create&backend=FreeForm but a staff member can't launch a search > from the illview screen. You should be able to do so from the illview screen currently by clicking the "Place request with partners button", provided the plugin has been configured properly, i.e. at least one z39.50 provider has been configured to show availability results in the partners interface AND is linked to a patron (using the patron ID (borrowernumber)) whose category matches the one from the ILLPartnerCode sys pref AND this patron has a valid e-mail address. I hope this information helps. We're actively working to simplify and streamline a lot of what's being discussed here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 17:12:23 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 16:12:23 +0000 Subject: [Koha-bugs] [Bug 26877] Add ability for libraries to be able to restart the SIP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26877 --- Comment #6 from Barbara Johnson --- We haven't been encountering the issues where we need to restart SIP like we used to. Yes, I do think we can close this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 17:12:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 16:12:39 +0000 Subject: [Koha-bugs] [Bug 26877] Add ability for libraries to be able to restart the SIP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26877 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 17:33:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 16:33:42 +0000 Subject: [Koha-bugs] [Bug 35539] New: Remove 'bulk' column from categories table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 Bug ID: 35539 Summary: Remove 'bulk' column from categories table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: pedro.amorim at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: fridolin.somers at biblibre.com, gmcharlt at gmail.com, jonathan.druart+koha at gmail.com, katrin.fischer at bsz-bw.de, kyle.m.hall at gmail.com, martin.renvoize at ptfs-europe.com, nick at bywatersolutions.com, tomascohen at gmail.com Looking at the code (first commited 17 years ago) the "bulk" column in the 'categories' table appears to not be utilized anywhere in the code. Is anyone able to confirm? I suggest we remove this if that is the case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 17:35:25 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 16:35:25 +0000 Subject: [Koha-bugs] [Bug 35539] Remove 'bulk' column from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 --- Comment #1 from Pedro Amorim --- Same goes for the finetype column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 17:36:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 16:36:04 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove 'bulk' column from |Remove unused columns from |categories table |categories table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 17:38:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 16:38:10 +0000 Subject: [Koha-bugs] [Bug 35450] Preservation system preferences should be authorised value pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Preservation system |Preservation system |preferences should authval |preferences should be |dropdowns |authorised value pull downs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 17:40:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 16:40:54 +0000 Subject: [Koha-bugs] [Bug 35539] Remove unused columns from categories table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35539 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26297 --- Comment #2 from Pedro Amorim --- Same for issuelimit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 17:40:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 16:40:54 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35539 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 17:43:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 16:43:32 +0000 Subject: [Koha-bugs] [Bug 26483] Allow search-to-link for analytical cataloging of existing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26483 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #7 from Katrin Fischer --- (In reply to Andrew Fuerste-Henry from comment #6) > (In reply to Katrin Fischer from comment #5) > > (In reply to Andrew Fuerste-Henry from comment #3) > > > Thanks, Katrin, I hadn't played with marc21_linking_section.pl! It doesn't > > > quite do what analytical cataloging needs, but it's a start! > > > > Can you explain what you are missing? > > Would that I could, but I must admit I have no memory of this. It happens to all of us :D I am closing for now, but please feel free to re-open or make a new bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 17:45:33 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 16:45:33 +0000 Subject: [Koha-bugs] [Bug 26877] Add ability for libraries to be able to restart the SIP server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26877 --- Comment #7 from Katrin Fischer --- (In reply to Barbara Johnson from comment #6) > We haven't been encountering the issues where we need to restart SIP like we > used to. Yes, I do think we can close this one. Thanks for the feedback! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 17:57:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 16:57:31 +0000 Subject: [Koha-bugs] [Bug 35540] New: Separate StaffListsHome block from the table block Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35540 Bug ID: 35540 Summary: Separate StaffListsHome block from the table block Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com This is very minor, but I thought I'd mention it. I noticed that most of the new staff interface additional content blocks are in their own white "block" on the page they are on with a space between the normal content and it (I hope that sentence makes sense...). In the case of StaffListsHome, the white block is right under the lists page main content, with no space. To recreate: 1. Go to Tools > HTML customizations 2. Click New entry 3. Fill out the form: - Display location: StaffListsHome - Publication date: any date before today - Title: StaffListsHome (or whatever) - Content: StaffListsHome (or whatever) 4. Click Save 5. Go to Lists --> Note that there is no space between the 'StaffListsHome' white background and the white background of the Your lists table. To compare: 1. Go to Tools > HTML customizations 2. Click New entry 3. Fill out the form: - Display location: StaffAcquisitionsHome - Publication date: any date before today - Title: StaffAcquisitionsHome (or whatever) - Content: StaffAcquisitionsHome (or whatever) 4. Click Save 5. Go to Acquisitions --> Note that there is a clear space between the 'StaffAcquisitionsHome' white background and the white background of the budgets table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 17:57:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 16:57:45 +0000 Subject: [Koha-bugs] [Bug 35540] Separate StaffListsHome block from the table block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35540 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6419 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 [Bug 6419] Add customizable areas to intranet home pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 17:57:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 16:57:45 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35540 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35540 [Bug 35540] Separate StaffListsHome block from the table block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 18:07:21 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 17:07:21 +0000 Subject: [Koha-bugs] [Bug 35540] Separate StaffListsHome block from the table block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35540 --- Comment #1 from Caroline Cyr La Rose --- I just noticed the StaffPatronsHome has the same problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 18:32:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 17:32:45 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #1 from Pedro Amorim --- Created attachment 159714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159714&action=edit Bug 26297: Preparation: Add dateofbirthrequired as boolean in Result/Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 18:32:48 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 17:32:48 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #2 from Pedro Amorim --- Created attachment 159715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159715&action=edit Bug 26297: Add patron categories to_api_mapping -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 18:32:50 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 17:32:50 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 --- Comment #3 from Pedro Amorim --- Created attachment 159716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159716&action=edit Bug 26297: API specs Test plan, k-t-d: 1) Access /api/v1/patron_categories 2) Verify the patron categories are correctly listed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 18:33:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 17:33:12 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Pedro Amorim --- Missing tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 18:35:09 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 17:35:09 +0000 Subject: [Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297 Pedro Amorim changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159716|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim --- Created attachment 159717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159717&action=edit Bug 26297: API specs Test plan, k-t-d: 1) Access /api/v1/patron_categories 2) Verify the patron categories are correctly listed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 18:58:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 17:58:19 +0000 Subject: [Koha-bugs] [Bug 34516] Upgrade database fails for 22.11.07.003, points to web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kevin.carnes at ub.lu.se |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:12:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:12:14 +0000 Subject: [Koha-bugs] [Bug 35425] Sortable prevents mouse selection of text inside child input/textarea elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #4 from Katrin Fischer --- More a bug than an enh! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:19:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:19:06 +0000 Subject: [Koha-bugs] [Bug 35425] Sortable prevents mouse selection of text inside child input/textarea elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 --- Comment #5 from Katrin Fischer --- This fixes the buggy behavior, but in testing this I feel like we might think about improving UX a bit more (on a separate bug). I believe that our drag & drop is not very accessible and a little hard to handle when you are on a slow system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:23:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:23:12 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8367 --- Comment #9 from Katrin Fischer --- Always good to add the "Depends on:" to help our RMaints finding the right versions for backporting :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 [Bug 8367] How long is a hold waiting for pickup at a more granular level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:23:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:23:12 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35460 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 [Bug 35460] Unable to add or edit hold rules in circulation rules table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:44:24 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:44:24 +0000 Subject: [Koha-bugs] [Bug 35386] Renewals via the API are recorded using the branch of the API account used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35386 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:37 +0000 Subject: [Koha-bugs] [Bug 33244] Do not show lists in OPAC if OpacPublic is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:39 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:39 +0000 Subject: [Koha-bugs] [Bug 33244] Do not show lists in OPAC if OpacPublic is disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33244 --- Comment #13 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:41 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:41 +0000 Subject: [Koha-bugs] [Bug 34091] Typo in help for cleanupdatabase.pl: --log-modules needs to be --log-module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34091 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:42 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:42 +0000 Subject: [Koha-bugs] [Bug 34091] Typo in help for cleanupdatabase.pl: --log-modules needs to be --log-module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34091 --- Comment #5 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:44 +0000 Subject: [Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:45 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:45 +0000 Subject: [Koha-bugs] [Bug 34398] Inconsistencies in Record matching rules page titles, breadcrumbs, and header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 --- Comment #8 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:47 +0000 Subject: [Koha-bugs] [Bug 34516] Upgrade database fails for 22.11.07.003, points to web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:49 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:49 +0000 Subject: [Koha-bugs] [Bug 34516] Upgrade database fails for 22.11.07.003, points to web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34516 --- Comment #22 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:51 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:51 +0000 Subject: [Koha-bugs] [Bug 35157] The searchfieldstype select element produces invalid HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:52 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:52 +0000 Subject: [Koha-bugs] [Bug 35157] The searchfieldstype select element produces invalid HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35157 --- Comment #14 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:54 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:54 +0000 Subject: [Koha-bugs] [Bug 35344] Patron image upload does not warn about missing cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35344 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:56 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:56 +0000 Subject: [Koha-bugs] [Bug 35344] Patron image upload does not warn about missing cardnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35344 --- Comment #4 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:57 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:57 +0000 Subject: [Koha-bugs] [Bug 35352] Cannot hide SMSalertnumber via BorrowerUnwantedField In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:46:59 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:46:59 +0000 Subject: [Koha-bugs] [Bug 35352] Cannot hide SMSalertnumber via BorrowerUnwantedField In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35352 --- Comment #7 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:00 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:00 +0000 Subject: [Koha-bugs] [Bug 35408] ERM > Titles > Import from a list gives an invalid link to the import job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:02 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:02 +0000 Subject: [Koha-bugs] [Bug 35408] ERM > Titles > Import from a list gives an invalid link to the import job In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35408 --- Comment #5 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:04 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:04 +0000 Subject: [Koha-bugs] [Bug 35414] Silence warn related to number_of_copies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:05 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:05 +0000 Subject: [Koha-bugs] [Bug 35414] Silence warn related to number_of_copies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35414 --- Comment #5 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:07 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:07 +0000 Subject: [Koha-bugs] [Bug 35425] Sortable prevents mouse selection of text inside child input/textarea elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:08 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:08 +0000 Subject: [Koha-bugs] [Bug 35425] Sortable prevents mouse selection of text inside child input/textarea elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 --- Comment #6 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:10 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:10 +0000 Subject: [Koha-bugs] [Bug 35436] Copy is not translatable in OPAC search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:11 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:11 +0000 Subject: [Koha-bugs] [Bug 35436] Copy is not translatable in OPAC search history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35436 --- Comment #10 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:13 +0000 Subject: [Koha-bugs] [Bug 35449] Accessibility: No links on "here" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:14 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:14 +0000 Subject: [Koha-bugs] [Bug 35449] Accessibility: No links on "here" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35449 --- Comment #7 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:15 +0000 Subject: [Koha-bugs] [Bug 35450] Preservation system preferences should be authorised value pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:17 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:17 +0000 Subject: [Koha-bugs] [Bug 35450] Preservation system preferences should be authorised value pull downs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35450 --- Comment #6 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:18 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:20 +0000 Subject: [Koha-bugs] [Bug 35460] Unable to add or edit hold rules in circulation rules table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35460 --- Comment #10 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 19:47:40 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 18:47:40 +0000 Subject: [Koha-bugs] [Bug 35386] Renewals via the API are recorded using the branch of the API account used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35386 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Brendan Lawlor from comment #3) > Also one of the options for RESTAPIRenewalBranch is NULL, which did work to > record the branch in the statistics as NULL, but I'm not sure if that is an > intended option. That's a good question! I'd like to mention that the author provided tests for that particular use case so I assume it is what they wanted it to be like. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 20:46:13 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 19:46:13 +0000 Subject: [Koha-bugs] [Bug 35541] New: Chosen renewal due date not respected when we override limit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35541 Bug ID: 35541 Summary: Chosen renewal due date not respected when we override limit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: noemie.labine at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When an item has been renewed the maximum number of times, we can override the limit if AllowRenewalLimitOverride says Allow. But if we try to renew the item from the circulation module and we manually choose a new due date, this date is not respected and the due date will follow the circulation rules for the item instead. Test plan : 1. Checkout an item and renew it the maximum number of times 2. when there are no more renewals, go to circulation module and manually choose a due date to renew the item. 3. You'll get the cannot renew message asking if you want to override and renew or cancel. Override and renew the item. The new due date is not the date we chose but the date chosen by the circulation rules. Note that if we try to override the renewal limit and chose a new due date directly in the patron's record, the chosen date will be respected after the override. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 20:46:37 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 19:46:37 +0000 Subject: [Koha-bugs] [Bug 35541] Chosen renewal due date not respected when we override limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35541 Noémie Labine changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Version|unspecified |22.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 20:46:44 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 19:46:44 +0000 Subject: [Koha-bugs] [Bug 33960] Add ability to retrieve deleted biblios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33960 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Tomás Cohen Arazi --- I know I suggested Nick to stick to the 'deleted' query parameter... But right now I feel like this should be a separate endpoint, with deleted_biblio_id as the identifier. My reasoning is it would be ugly that you can GET /biblios but then cannot do things like POST /biblios/:biblio_id/items on the retrieved biblio_ids, for example. Or worse, need to code something to deal with such scenarios polluting the controllers. Sorry :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 21:11:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 20:11:31 +0000 Subject: [Koha-bugs] [Bug 35152] Convert RoutingListNote system preference to additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35152 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 21:11:34 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 20:11:34 +0000 Subject: [Koha-bugs] [Bug 35152] Convert RoutingListNote system preference to additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35152 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158747|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159718&action=edit Bug 35152: Convert RoutingListNote system preference to additional contents This patch moves the RoutingListNote system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the RoutingListNote system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from RoutingListNote is now stored there. - The HTML customization entry form should offer RoutingListNote as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the RoutingListNote HTML customization and add unique content to the "fr-FR" tab. - Go to Serials and create a subscription if necessary. - From the subscription detail page, click "Create routing list" in the left-hand sidebar. - Add one or more recipients to the list and click "Save". - On the "Preview routing list" page click "Save and preview routing slip". - In the pop-up window with the routing list preview you should see the content you added to the RoutingListNote HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "RoutingListNote." It should return no results. NOTE: This patch does not keep the default content which was stored by the RoutingListNote system preference. Having a default value for that kind of preference is not standard. Instead I have updated the description of the RoutingSerials preference to add a mention of the RoutingListNote HTML customization option. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 21:15:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 20:15:06 +0000 Subject: [Koha-bugs] [Bug 34546] Report group code should only contain ASCII chars In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34546 --- Comment #1 from Fridolin Somers --- Also looks like an id must start with a letter. Even if it is under debate for HTML5, we have a library reporting this issue. See https://stackoverflow.com/questions/5672903/can-i-have-an-element-with-an-id-that-starts-with-a-number -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 21:22:12 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 20:22:12 +0000 Subject: [Koha-bugs] [Bug 35351] Adjust basket details template to avoid showing empty page-section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35351 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 21:22:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 20:22:15 +0000 Subject: [Koha-bugs] [Bug 35351] Adjust basket details template to avoid showing empty page-section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35351 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159052|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159719&action=edit Bug 35351: Adjust basket details template to avoid showing empty page-section This patch makes a minor change to the markup of the basket details page so that we don't display an empty div.page-section when there are no orders. Note: This patch includes whitespace changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Acquisitions. - Search for a vendor and add a basket if necessary. - View the details of an empty basket. - Under the "General information" or "Settings" sections there should be no empty white box. - View the details of a basket which has orders (using the "Add to basket" process if necessary). - Orders should be displayed correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 21:24:47 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 20:24:47 +0000 Subject: [Koha-bugs] [Bug 35351] Adjust basket details template to avoid showing empty page-section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35351 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement removes release notes| |the empty white section in | |acquisitions for a basket | |with no orders. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 21:40:01 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 20:40:01 +0000 Subject: [Koha-bugs] [Bug 35386] Renewals via the API are recorded using the branch of the API account used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35386 --- Comment #5 from Tomás Cohen Arazi --- (In reply to Nick Clemens from comment #0) > When renewing items via the API Koha records the branch of the renewal as > the branch of the account that is signed in to the API. > > For outside service (Aspen, Communico) they may have a single API account > that represents all user interactions. > > While this behavior may not be technically incorrect, it should be > configurable like OpacRenewalBranch - allowing the library to decide which > branch is recorded in the statistics table. We can currently specify the current branch by using the `x-koha-library` header (available since bug 24003 => v19.11.07): https://api.koha-community.org/Development.html#section/Special-headers I think decoupling the default from the OPAC would be correct, though. So I'd rename the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 21:43:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 20:43:18 +0000 Subject: [Koha-bugs] [Bug 35364] Update serials pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 21:43:20 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 20:43:20 +0000 Subject: [Koha-bugs] [Bug 35364] Update serials pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159110|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 159720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159720&action=edit Bug 35364: Update label creator pop-up windows with consistent footer markup This patch updates several serials module templates in order to style submission and close buttons in a fixed footer at the bottom of pop-up windows, with markup consistent with other pop-up windows. Unrelated change: A couple of templates have had a "page-section" div added where it was missing. To test, apply the patch and go to Serials. For each affected template, test that the window looks correct and the buttons in the footer work correctly: - New subscription -> - Search for a vendor: - Vendor search form - Vendor search results - Search for record - Record search form - Record search results - Complete the process of creating a subscription if there are no other subscriptions already in your database. - From the subscription detail page, click the "Renew" button in the toolbar and test that window. - From the subscription detail page, click the "Create routing list" link in the left-hand sidebar menu. - Add one or more recipients and click "Save" - Click "Save and preview routing slip" and test the resulting pop-up. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 21:45:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 20:45:27 +0000 Subject: [Koha-bugs] [Bug 35364] Update serials pop-up windows with consistent footer markup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35364 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement updates release notes| |the style of several | |serials module templates so | |that the submission and | |close buttons are in a | |fixed footer at the bottom | |of the pop-up windows, | |consistent with other | |pop-up windows. CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:03:18 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:03:18 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/777 Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:03:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:03:19 +0000 Subject: [Koha-bugs] [Bug 35116] Introduce a AdditionalContents.GetSection(ID) helper In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35116 Bug 35116 depends on bug 6419, which changed state. Bug 6419 Summary: Add customizable areas to intranet home pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:03:19 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:03:19 +0000 Subject: [Koha-bugs] [Bug 35540] Separate StaffListsHome block from the table block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35540 Bug 35540 depends on bug 6419, which changed state. Bug 6419 Summary: Add customizable areas to intranet home pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:03:31 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:03:31 +0000 Subject: [Koha-bugs] [Bug 34889] Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34889 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/777 Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:03:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:03:32 +0000 Subject: [Koha-bugs] [Bug 26050] [OMNIBUS] Convert system preferences to HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 Bug 26050 depends on bug 34889, which changed state. Bug 34889 Summary: Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34889 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:03:32 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:03:32 +0000 Subject: [Koha-bugs] [Bug 34894] Convert OpacSuppressionMessage system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34894 Bug 34894 depends on bug 34889, which changed state. Bug 34889 Summary: Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34889 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:03:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:03:43 +0000 Subject: [Koha-bugs] [Bug 34894] Convert OpacSuppressionMessage system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34894 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/777 Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:03:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:03:43 +0000 Subject: [Koha-bugs] [Bug 26050] [OMNIBUS] Convert system preferences to HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 Bug 26050 depends on bug 34894, which changed state. Bug 34894 Summary: Convert OpacSuppressionMessage system preference to HTML customization https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34894 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:03:43 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:03:43 +0000 Subject: [Koha-bugs] [Bug 35048] Convert SCOMainUserBlock system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35048 Bug 35048 depends on bug 34894, which changed state. Bug 34894 Summary: Convert OpacSuppressionMessage system preference to HTML customization https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34894 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:03:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:03:53 +0000 Subject: [Koha-bugs] [Bug 34869] Convert OPACResultsSidebar system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34869 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/777 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:03:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:03:53 +0000 Subject: [Koha-bugs] [Bug 26050] [OMNIBUS] Convert system preferences to HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 Bug 26050 depends on bug 34869, which changed state. Bug 34869 Summary: Convert OPACResultsSidebar system preference to HTML customization https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34869 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:03:53 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:03:53 +0000 Subject: [Koha-bugs] [Bug 34889] Convert PatronSelfRegistrationAdditionalInstructions system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34889 Bug 34889 depends on bug 34869, which changed state. Bug 34869 Summary: Convert OPACResultsSidebar system preference to HTML customization https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34869 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:04:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:04:06 +0000 Subject: [Koha-bugs] [Bug 23798] Convert OpacMaintenanceNotice system preference to additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23798 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/777 Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:04:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:04:06 +0000 Subject: [Koha-bugs] [Bug 26050] [OMNIBUS] Convert system preferences to HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 Bug 26050 depends on bug 23798, which changed state. Bug 23798 Summary: Convert OpacMaintenanceNotice system preference to additional contents https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23798 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:04:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:04:06 +0000 Subject: [Koha-bugs] [Bug 34869] Convert OPACResultsSidebar system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34869 Bug 34869 depends on bug 23798, which changed state. Bug 23798 Summary: Convert OpacMaintenanceNotice system preference to additional contents https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23798 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:04:15 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:04:15 +0000 Subject: [Koha-bugs] [Bug 35065] Convert SelfCheckHelpMessage system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35065 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/777 CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:04:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:04:16 +0000 Subject: [Koha-bugs] [Bug 26050] [OMNIBUS] Convert system preferences to HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 Bug 26050 depends on bug 35065, which changed state. Bug 35065 Summary: Convert SelfCheckHelpMessage system preference to HTML customization https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35065 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:04:16 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:04:16 +0000 Subject: [Koha-bugs] [Bug 35151] Convert ILLModuleCopyrightClearance system preference to additional contents In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35151 Bug 35151 depends on bug 35065, which changed state. Bug 35065 Summary: Convert SelfCheckHelpMessage system preference to HTML customization https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35065 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:04:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:04:26 +0000 Subject: [Koha-bugs] [Bug 35063] Convert SelfCheckInMainUserBlock system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35063 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/777 CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:04:26 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:04:26 +0000 Subject: [Koha-bugs] [Bug 26050] [OMNIBUS] Convert system preferences to HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 Bug 26050 depends on bug 35063, which changed state. Bug 35063 Summary: Convert SelfCheckInMainUserBlock system preference to HTML customization https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35063 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:04:27 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:04:27 +0000 Subject: [Koha-bugs] [Bug 35065] Convert SelfCheckHelpMessage system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35065 Bug 35065 depends on bug 35063, which changed state. Bug 35063 Summary: Convert SelfCheckInMainUserBlock system preference to HTML customization https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35063 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:04:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:04:36 +0000 Subject: [Koha-bugs] [Bug 35048] Convert SCOMainUserBlock system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35048 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/777 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:04:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:04:36 +0000 Subject: [Koha-bugs] [Bug 26050] [OMNIBUS] Convert system preferences to HTML customizations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 Bug 26050 depends on bug 35048, which changed state. Bug 35048 Summary: Convert SCOMainUserBlock system preference to HTML customization https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35048 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:04:36 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:04:36 +0000 Subject: [Koha-bugs] [Bug 35063] Convert SelfCheckInMainUserBlock system preference to HTML customization In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35063 Bug 35063 depends on bug 35048, which changed state. Bug 35048 Summary: Convert SCOMainUserBlock system preference to HTML customization https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35048 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 11 22:25:06 2023 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Dec 2023 21:25:06 +0000 Subject: [Koha-bugs] [Bug 34082] Cut some redundancy in OPAC JavaScript string translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34082 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Two things I couldn't test: 1. Circulation and fine rules: "In the Console tab, paste in this code and hit ENTER." There is no code provided to enter into the console. 2. Payment plugin: in the current master, the PayPal plugin doesn't work - if you go to configure, you get a screen with nothing in the content area, you can no longer click on any navigation links, and there are errors in the console.[1] Is there another payment plugin to try? [1] Errors in the console: GET http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/77c7724cb7b76d9c6f1f.js [HTTP/1.1 404 Not Found 333ms] GET http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/b50d36cd3cebca67473e.js [HTTP/1.1 404 Not Found 1594ms] GET http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/595ecd69495765507396.js [HTTP/1.1 404 Not Found 1265ms] GET http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/78ed504e6dbe893d56d8.js [HTTP/1.1 404 Not Found 2561ms] JQMIGRATE: Migrate is installed, version 3.3.2 jquery-migrate-3.3.2.min_23.1200000.js:2:709 GET http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/77c7724cb7b76d9c6f1f.js [HTTP/1.1 404 Not Found 2511ms] Loading failed for the