[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230

--- Comment #27 from Thibaud Guillot <thibaud.guillot at biblibre.com> ---
(In reply to Andrew Fuerste-Henry from comment #22)
> I feel like this permission should be grouped with the other borrowers
> permissions, rather than set off as its own top-level permission.
> 
> I created a user with only catalogue, circulate_remaining_permissions, and
> list_borrowers. I was able to check out to a patron using either their
> cardnumber or name to find them and when I entered a name which found more
> than one patron I was able to access the patron search screen to select the
> correct patron. So that all worked as desired.
> 
> A couple of minor things seem off, though, both on the member.pl search
> results page:
>  - clicking a patron name in the results list takes one to
> cgi-bin/koha/members/moremember.pl, a page one would otherwise not be able
> to access with only list_borrowers
> 
> - while on member.pl or moremember.pl as a user with only list_borrowers
> permission, the Search Patrons feature in the main search bar is only
> partially disabled -- the Search Patrons option still appears, but when it
> is selected the search box disappears, thereby preventing the search. This
> is a visually confusing approach and becomes more confusing if one clicks
> around between the options here, as the search box will reappear when
> something other than Search Patrons is selected. See the attached screenshot
> in which the interface is simultaneously indicating both Check Out and
> Search Patrons. Can we remove Search Patrons from this bar entirely if the
> user lacks that permission?

Hello ! 

Thanks for your comments Andrew and David, I've updated my patch to take them
into account.

I've grouped this permission under those linked to borrowers, and modified
access on the moremember.pl page. I'm divided on this point because, as David
says, it may be useful to see more detailed information on a member, but at the
same time, there's the view_borrower_infos_from_any_libraries permission which
allows it, it seems to me. The difference is that it's not limited to one
site... so I'm open to suggestions on this point, of course, as I don't know
what would be best.

As far as the search bar and the "Search patrons" tab are concerned, I did
indeed notice a bug when it appeared, so I modified the code to display this
tab only if the user had "circulate" permission... that's what I understood
from your example.

The patch can now be tested again :) Thanks to both of you

-- 
You are receiving this mail because:
You are watching all bug changes.