[Koha-bugs] [Bug 31692] Let librarians change item level holds to record level holds when possible

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31692

--- Comment #62 from Lari Taskula <lari.taskula at hypernova.fi> ---
See Bug 35483 for restoring the missing feature.

(In reply to Tomás Cohen Arazi from comment #56)
> Lari, are you still willing to work on this? Thanks

Sorry I had either missed or forgot to answer your comment!

(In reply to Tomás Cohen Arazi from comment #54)
> Can we please change the method signature? I'd expect
> 
> $hold->change_type(
>     {
>         type => [biblio|item],
>       [ item_id => $item->id, ]
>     }
> );
> 
> Or even split it in two methods:
> 
> $hold->make_biblio_level
> $hold->make_item_level( $item->id )

Well, why not, if you feel it's still important even after pushing the Bug
(sorry again for the late answer). I'm not extremely attached or strongly
opinionated about the choice I made - I suppose I was thinking of it more as a
toggle hence not introducing two methods. The itemnumber param in my sense
specifies the type already, if given => item, if not given => biblio.

-- 
You are receiving this mail because:
You are watching all bug changes.