[Koha-bugs] [Bug 25159] Action logs should be stored in JSON ( and as a diff of the change )

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25159

--- Comment #33 from Jonathan Druart <jonathan.druart+koha at gmail.com> ---
(In reply to Kyle M Hall from comment #32)
> (In reply to Jonathan Druart from comment #29)
> > 1. I am not sure, but maybe we could pass $self and log
> > $self->get_from_store as the original (?)
> > Maybe we will lose flexibility however.
> 
> I don't think I understand your question. Could you give me some more detail?

Replace:
+    my $original = C4::Context->preference('HoldsLog') ? $self->unblessed :
undef;
+    logaction( 'HOLDS', 'SUSPEND', $self->reserve_id, $self, undef, $original
)

With
+    logaction( 'HOLDS', 'SUSPEND', $self->reserve_id, $self, undef )

And, in logaction, $original = $self->get_from_storage.

-- 
You are receiving this mail because:
You are watching all bug changes.