[Koha-bugs] [Bug 26861] Indicate that a record is using OpacHiddenItems in the staff interface

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26861

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #11)
> (In reply to Fridolin Somers from comment #10)
> > (In reply to Fridolin Somers from comment #7)
> > > A new column in items table ?
> > 
> > I meant a column in the HTML table of items, in details page.
> 
> I like the idea. Do we expect a performance hit by it? 
> Or could it be an indicator somehow, maybe in one of the existing columns,
> like a small icon with a tool tip?

Sorry, Frido. Now I feel embarrassed 😅.

I think that we could expect a performance hit, but the work should be CPU
bound rather than I/O bound, so hopefully it won't be too much. The more rules
and the more holdings you have, the worse it will be. 

If we want to show if the bib is hidden by OpacHiddenItems, then I think it
gets more complicated, because Koha::Biblio->hidden_in_opac performs the
calculation once, and then when building the item array for display, we'd need
to perform the calculation again. This would be suboptimal. 

Perhaps Koha::Biblio->hidden_in_opac should take an optional argument of
"items", and Koha::Item->hidden_in_opac should store its calculation in itself. 

Alternatively, Koha::Biblio->hidden_in_opac could return a hashref of
itemnumbers denoting hidden status, and then on detail.pl when processing items
this hashref could be checked to determine hidden status. 

Or we could just worry about optimizing this later if it's an issue. For a
small number of holdings and a small number of rules, it probably wouldn't be
noticeable. It would probably just have an impact on a higher number of
holdings.

But then that's where bug 33568 saves the day...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.