[Koha-bugs] [Bug 35507] Fix handling plugins in unit tests causing random failures on Jenkins

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 159818
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159818
Bug 35507: Add Plugins::Method->delete

Review of attachment 159818:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=35507&attachment=159818)
-----------------------------------------------------------------

::: Koha/Plugins/Method.pm
@@ +43,5 @@
> +    my ($self) = @_;
> +
> +    # Remove corresponding records from plugin_data. Clear cache.
> +    my $cond = { plugin_class => $self->plugin_class };
> +    Koha::Database->new->schema->resultset('PluginData')->search($cond)->delete;

This scares me..   delete is called from inside InstallPlugins.. InstallPlugins
is called from upload-plugin.pl and misc/devel/install_plugins.pl

So.. on first look, this appears to me that for any new plugin installed will
nuke all data for all other plugins in the system at the time.  Plugin upgrades
too.

-- 
You are receiving this mail because:
You are watching all bug changes.