[Koha-bugs] [Bug 35507] Fix handling plugins in unit tests causing random failures on Jenkins
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Dec 14 17:19:50 CET 2023
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35507
Kyle M Hall <kyle at bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #159817|0 |1
is obsolete| |
Attachment #159846|0 |1
is obsolete| |
Attachment #159847|0 |1
is obsolete| |
--- Comment #56 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 159848
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159848&action=edit
Bug 35507: Plugins.t - Mock SessionStorage, remove KitchenSink
Removing the CGI::Session behavior to auto-commit by mocking
SessionStorage makes that the $plugin->test_template does no
longer commit.
Since KitchenSink includes a CREATE TABLE, removing that code
removes the second implicit commit. We might move that code
to its own script?
Adds a missing rollback too at the end.
Test plan:
Run prove t/db_dependent/Koha/Plugins/Plugins.t
Verify that no records got added to plugin_data/methods table.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list