[Koha-bugs] [Bug 35558] Do not fetch local image if none exists

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35558

--- Comment #13 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #12)
> (In reply to Nick Clemens from comment #11)
> > (In reply to Jonathan Druart from comment #10)
> > > > which benefits the user
> > > 
> > > Unless it overloads the server because it gets too many requests, which is
> > > the goal of this approach.
> > 
> > Is there evidence of this happening in production?

While I haven't had a server overloaded by image requests, it would be nice to
reduce the number of unnecessary HTTP requests. It is conceptually painful
looking at 20 requests going out when you know 0 are going to return anything
on a given page. That CPU time could be put to better use. 

Prefetching is an interesting idea. I'm not familiar enough with the
DBIx::Class internals for prefetching to know how it works exactly, but in
theory it might cut down on DB calls. 

> I feel like we should make sure cache expiration timestamps are sent
> correctly from the svc. So:
> 
> - Only ask for local covers on things that have them
> - Only return them from the svc if they have expired on the browser

That's a good idea too, although I think it would be a separate ticket.

-- 
You are receiving this mail because:
You are watching all bug changes.