[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Dec 15 22:54:42 CET 2023


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |lucas at bywatersolutions.com

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
This creates a bit of a problem on reserve/request.pl with your patched
applied.

1. Have a hold that expires today and go to reserve/request.pl for that item. 
2. Look at the expiration date column and notice it will be blank.
3. We use data-flatpickr-futuredate on this input and today is not a
futuredate. 


Furthermore, I am not sure I agree with this change. If the expiration date is
today I would not considered it "the last day of the pick-up period". I would
consider that to be the day before the expirationdate.



Also, your bug title is not not correct. Have a look at the QA tool:

Processing additional checks

        * Commit title does not start with 'Bug XXXXX: ' - c2d44aa429

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list