[Koha-bugs] [Bug 26297] Rest API: add a route to list patron categories

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26297

Pedro Amorim <pedro.amorim at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart+koha at gmail.
                   |                            |com

--- Comment #15 from Pedro Amorim <pedro.amorim at ptfs-europe.com> ---
Katrin, thank you, I agree. A couple notes:

1) I have made the following patch obsolete:
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159714

I was thrown off by the naming and tinyint(1) in kohastructure and thought this
column was meant to be a boolean indicating whether date of birth was supposed
to be required or not. This is not the case, as we've established.

2) My understanding is that we're reluctant to fix things in the database due
to existing reports, but it doesn't feel great to have to_api_mapping be fixing
stuff that should really be fixed at the root of the problem. This specific
naming is originally from 17 years ago, it's outdated, doesn't make sense and
it should be fixed directly in the database structure imo.

I'm going off on an tangent but I believe this is relevant.
On a different bug I submitted this patch:
https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=35570&attachment=159944

That atomicupdate will search for SQL reports containing the obsolete naming
and notify, on upgrade, if some reports need to be manually looked at (and
which).
I wonder if we could adopt something like this going forward, and become a bit
more open to updating and fixing the database schema.

Note that all of the above is discussion only and should not block this bug
26297 imo.

-- 
You are receiving this mail because:
You are watching all bug changes.