[Koha-bugs] [Bug 35618] New: catalogue/showelastic.pl uses deprecated/removed parameter "type"

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35618

            Bug ID: 35618
           Summary: catalogue/showelastic.pl uses deprecated/removed
                    parameter "type"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: schodkowy.omegi-0r at icloud.com

This can be treated as follow-up to Bug 33353. The showelastic.pl page still
uses "type" parameter that was deprecated in ES7 and removed in ES8:
https://www.elastic.co/guide/en/elasticsearch/reference/6.0/removal-of-types.html

Bug 33353's patch already removed it in other places:
https://github.com/Koha-Community/Koha/commit/24aab6b9c52cb9846653d34d5630caf837e0508a

But one place remained:
https://github.com/Koha-Community/Koha/blob/d6314d32246a7e967e78f1427c338a3e13823617/catalogue/showelastic.pl#L63

This yields the following output in log:
```
[WARN] [Param] ** Unknown param (type) in (get) request. , called from sub
Search::Elasticsearch::Role::Client::Direct::__ANON__ at
/usr/share/koha/intranet/cgi-bin/catalogue/showelastic.pl line 61.
```
An exception is caught and user is redirected to 404 error page for all
requests.

I will be created a patch for this in a moment, as I verified removing this
field fixes the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.