[Koha-bugs] [Bug 35287] Add additional fields support to ERM Licenses

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 159639
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159639
Bug 35287: REST API - Add additional fields support to ERM Licenses

Review of attachment 159639:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=35287&attachment=159639)
-----------------------------------------------------------------

::: Koha/REST/V1/ERM/Licenses.pm
@@ +183,5 @@
>                  $license->user_roles($user_roles);
>                  $license->documents($documents);
>  
> +                my @extended_attributes = map { {'id' => $_->{field_id}, 'value' => $_->{value}} } @{$extended_attributes};
> +                $license->extended_attributes( \@extended_attributes );

Won't you need to check here that @extended_attributes is indeed populated..
else you may wipe them away without meaning to?

-- 
You are receiving this mail because:
You are watching all bug changes.