[Koha-bugs] [Bug 32477] Hiding batch item modification columns isn't remembered correctly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32477

--- Comment #14 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---
(In reply to Emmi Takkinen from comment #11)
> There seems to be a minor problem with these. If one hides all columns and
> then reloads the page or launches tool again, "Holds" column isn't displayed
> and "Itemtype" column is. Also "Itemtype" columns checkbox is checked and
> works as it should.

Problem is that we toggle columns instead of hiding them. Instead of doing this
inside "hideColumns":

>$("#itemst td:nth-child(" + valCookie[i] + "),#itemst th:nth-child(" + valCookie[i] + ")").toggle();
we could to this:

>$("#itemst td:nth-child(" + valCookie[i] + "),#itemst th:nth-child(" + valCookie[i] + ")").nextAll().hide();
Or we could use this outside of for loop:

>$("#itemst td:nth-child(" + nb_cols + "),#itemst th:nth-child(" + nb_cols + ")").nextAll().hide();
I'm a bit unsure how to fix checkboxes. First we set number of columns inside a
cookie as list that starts with value 3 and ends to the value 19. With method
"guess_nb_colums" we receive value 3 and decrease this value from values
received from cookie that list. So we end up with values from 0 to 16 which we
use to determine which checkboxes we hide. However, "Itemtype" column has id
"checkbox17" which is out of scope. 

My guess is that "guess_nb_columns" returns a wrong value when first column
contains checkbox, but I don't now if changing them has some unwanted effect to
task queue jobs. Another option is to add 1 to variable index but that's a bit
ugly solution.

-- 
You are receiving this mail because:
You are watching all bug changes.