[Koha-bugs] [Bug 28012] Error on saving new numbering pattern

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I added a follow-up to use our standard validation with our own error messages,
see
https://wiki.koha-community.org/wiki/Coding_Guidelines#JS10:_Form_Validation.

You can see the difference in how the error messages display.

But we still have a big issue here on saving:

C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI Exception:
DBD::mysql::st execute failed: Incorrect integer value: '' for column
`koha_kohadev`.`subscription_numberpatterns`.`add1` at row 1 at
/kohadevbox/koha/serials/subscription-numberpatterns.pl line 70
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

This appears for all 3 columns and all numeric values in the prediction
pattern. NONE of these should be required or only be required if you have at
least one input field in the column (more complicated, let's go with not
exploding for now. Please follow-up here or on a separate bug.

Additionally we explode when display order is left empty. This should be
possible as well (compare to adding from the subscription form, where the field
is not included).

-- 
You are receiving this mail because:
You are watching all bug changes.