[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
           Keywords|                            |release-notes-needed

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi all,

I have tried to make sense of the notes here, but I am not confident I fully
understand the consequences of this change yet.

I'll try to summarize what I got so far:

* The problem is about how we determine which rules apply in a situation.
* context = filter + module
* In my example context source-z3950 deactivated source-*, as they had the same
context.

+----+-----+--------+----------+-----+--------+--------+--------+
| id | tag | module | filter   | add | append | remove | delete |
+----+-----+--------+----------+-----+--------+--------+--------+
|  3 | 245 | source | z3950    |   0 |      0 |      0 |      0 |
|  4 | 300 | source | *        |   0 |      0 |      0 |      0 |
|  5 | 245 | source | batchmod |   0 |      0 |      0 |      0 |
+----+-----+--------+----------+-----+--------+--------+--------+

The patch states:

  "Fallback to overlay rules with wildcard filter if no match
   found for exact filter match."

Does an exact match comprise of context + tag and now as there is no exact
match for 
300-source-z3950 we will also check for 300-source-*?

Please:

1) Update commit message to include a test plan that highlights the change
2) Please explain: How will this change affect existing installations? Do we
need to provide any information? Can we rule out data loss? 
3) Please add release notes.

-- 
You are receiving this mail because:
You are watching all bug changes.